blob: d743095c79ec9a405c0f4379080c48ad4a1a1b16 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
Edward Lesmes9c349062021-05-06 20:02:39 +000034import metrics_utils
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000035# We have to disable monitoring before importing git_cl.
Edward Lesmes9c349062021-05-06 20:02:39 +000036metrics_utils.COLLECT_METRICS = False
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000037
Jamie Madill5e96ad12020-01-13 16:08:35 +000038import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000039import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000040import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000041import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000042import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000043import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000044import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000045import git_new_branch
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +000046import owners_client
Edward Lemur85153282020-02-14 22:06:29 +000047import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000048import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000049
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000050NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
51
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000052
Edward Lemur0db01f02019-11-12 22:01:51 +000053def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070054 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
55
tandrii5d48c322016-08-18 16:19:37 -070056CERR1 = callError(1)
57
58
Edward Lemur1773f372020-02-22 00:27:14 +000059class TemporaryFileMock(object):
60 def __init__(self):
61 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070062
Edward Lemur1773f372020-02-22 00:27:14 +000063 @contextlib.contextmanager
64 def __call__(self):
65 self.suffix += 1
66 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070067
68
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000069class ChangelistMock(object):
70 # A class variable so we can access it when we don't have access to the
71 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000072 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000073
74 def __init__(self, gerrit_change=None, **kwargs):
75 self._gerrit_change = gerrit_change
76
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000077 def GetIssue(self):
78 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000079
Edward Lemur6c6827c2020-02-06 21:15:18 +000080 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000081 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000082
dsansomee2d6fd92016-09-08 00:10:47 -070083 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000084 ChangelistMock.desc = desc
85
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000086 def GetGerritChange(self, patchset=None, **kwargs):
87 del patchset
88 return self._gerrit_change
89
Josip Sokcevic9011a5b2021-02-12 18:59:44 +000090 def GetRemoteBranch(self):
91 return ('origin', 'refs/remotes/origin/main')
92
tandrii5d48c322016-08-18 16:19:37 -070093
Edward Lemur85153282020-02-14 22:06:29 +000094class GitMocks(object):
95 def __init__(self, config=None, branchref=None):
96 self.branchref = branchref or 'refs/heads/master'
97 self.config = config or {}
98
99 def GetBranchRef(self, _root):
100 return self.branchref
101
102 def NewBranch(self, branchref):
103 self.branchref = branchref
104
Edward Lemur26964072020-02-19 19:18:51 +0000105 def GetConfig(self, root, key, default=None):
106 if root != '':
107 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000108 return self.config.get(key, default)
109
Edward Lemur26964072020-02-19 19:18:51 +0000110 def SetConfig(self, root, key, value=None):
111 if root != '':
112 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000113 if value:
114 self.config[key] = value
115 return
116 if key not in self.config:
117 raise CERR1
118 del self.config[key]
119
120
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000121class WatchlistsMock(object):
122 def __init__(self, _):
123 pass
124 @staticmethod
125 def GetWatchersForPaths(_):
126 return ['joe@example.com']
127
128
Edward Lemur4c707a22019-09-24 21:13:43 +0000129class CodereviewSettingsFileMock(object):
130 def __init__(self):
131 pass
132 # pylint: disable=no-self-use
133 def read(self):
134 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
135 'GERRIT_HOST: True\n')
136
137
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000138class AuthenticatorMock(object):
139 def __init__(self, *_args):
140 pass
141 def has_cached_credentials(self):
142 return True
tandrii221ab252016-10-06 08:12:04 -0700143 def authorize(self, http):
144 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000145
146
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000148 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
149
150 Usage:
151 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100152 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000153
154 OR
155 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100156 CookiesAuthenticatorMockFactory(
157 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000158 """
159 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800160 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000161 # Intentionally not calling super() because it reads actual cookie files.
162 pass
163 @classmethod
164 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000165 return os.path.join('~', '.gitcookies')
166
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000167 @classmethod
168 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000169 return os.path.join('~', NETRC_FILENAME)
170
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100171 def _get_auth_for_host(self, host):
172 if same_auth:
173 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000174 return (hosts_with_creds or {}).get(host)
175 return CookiesAuthenticatorMock
176
Aaron Gable9a03ae02017-11-03 11:31:07 -0700177
kmarshall9249e012016-08-23 12:02:16 -0700178class MockChangelistWithBranchAndIssue():
179 def __init__(self, branch, issue):
180 self.branch = branch
181 self.issue = issue
182 def GetBranch(self):
183 return self.branch
184 def GetIssue(self):
185 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000186
tandriic2405f52016-10-10 08:13:15 -0700187
188class SystemExitMock(Exception):
189 pass
190
191
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000192class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000193 def setUp(self):
194 mock.patch('sys.exit', side_effect=SystemExitMock).start()
195 mock.patch('sys.stdout', StringIO()).start()
196 mock.patch('sys.stderr', StringIO()).start()
197 self.addCleanup(mock.patch.stopall)
198
199 def test_die_with_error(self):
200 with self.assertRaises(SystemExitMock):
201 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
202 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
203 self.assertTrue('saving CL description' in sys.stdout.getvalue())
204 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
205 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
206 sys.exit.assert_called_once_with(1)
207
208 def test_die_with_error_no_desc(self):
209 with self.assertRaises(SystemExitMock):
210 git_cl.DieWithError('foo')
211 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
212 self.assertEqual(sys.stdout.getvalue(), '')
213 sys.exit.assert_called_once_with(1)
214
Edward Lemur6c6827c2020-02-06 21:15:18 +0000215 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000216 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100217 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000218 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700219
Edward Lemur61bf4172020-02-24 23:22:37 +0000220 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
221 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
222 def test_get_cl_statuses(self, *_mocks):
223 statuses = [
224 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
225 changes = []
226 for status in statuses:
227 cl = git_cl.Changelist()
228 cl.status = status
229 changes.append(cl)
230
231 actual = set(git_cl.get_cl_statuses(changes, True))
232 self.assertEqual(set(zip(changes, statuses)), actual)
233
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000234 def test_upload_to_non_default_branch_no_retry(self):
235 m = mock.patch('git_cl.Changelist._CMDUploadChange',
236 side_effect=[git_cl.GitPushError(), None]).start()
237 mock.patch('git_cl.Changelist.GetRemoteBranch',
238 return_value=('foo', 'bar')).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000239 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000240 return_value='foo').start()
241 mock.patch('git_cl.gerrit_util.GetProjectHead',
242 return_value='refs/heads/main').start()
243
244 cl = git_cl.Changelist()
245 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000246 options.target_branch = 'refs/heads/bar'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000247 with self.assertRaises(SystemExitMock):
248 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
249
250 # ensure upload is called once
251 self.assertEqual(len(m.mock_calls), 1)
252 sys.exit.assert_called_once_with(1)
253 # option not set as retry didn't happen
254 self.assertFalse(hasattr(options, 'force'))
255 self.assertFalse(hasattr(options, 'edit_description'))
256
257 def test_upload_to_old_default_still_active(self):
258 m = mock.patch('git_cl.Changelist._CMDUploadChange',
259 side_effect=[git_cl.GitPushError(), None]).start()
260 mock.patch('git_cl.Changelist.GetRemoteBranch',
261 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000262 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000263 return_value='foo').start()
264 mock.patch('git_cl.gerrit_util.GetProjectHead',
Josip Sokcevicb631a882021-01-06 18:18:10 +0000265 return_value='refs/heads/master').start()
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000266
267 cl = git_cl.Changelist()
268 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000269 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000270 with self.assertRaises(SystemExitMock):
271 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
272
273 # ensure upload is called once
274 self.assertEqual(len(m.mock_calls), 1)
275 sys.exit.assert_called_once_with(1)
276 # option not set as retry didn't happen
277 self.assertFalse(hasattr(options, 'force'))
278 self.assertFalse(hasattr(options, 'edit_description'))
279
280 def test_upload_to_old_default_retry_on_failure(self):
281 m = mock.patch('git_cl.Changelist._CMDUploadChange',
282 side_effect=[git_cl.GitPushError(), None]).start()
283 mock.patch('git_cl.Changelist.GetRemoteBranch',
284 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000285 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000286 return_value='foo').start()
287 mock.patch('git_cl.gerrit_util.GetProjectHead',
288 return_value='refs/heads/main').start()
289 mock.patch('git_cl.RunGit').start()
290
291 cl = git_cl.Changelist()
292 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000293 options.target_branch = 'refs/heads/master'
294 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
295 # ensure upload is called twice
296 self.assertEqual(len(m.mock_calls), 2)
297 # option overrides on retry
298 self.assertEqual(options.force, True)
299 self.assertEqual(options.edit_description, False)
300
Gavin Mak68e6cf32021-01-25 18:24:08 +0000301 def test_upload_with_message_file_no_editor(self):
302 m = mock.patch('git_cl.ChangeDescription.prompt',
303 return_value=None).start()
304 mock.patch('git_cl.Changelist.GetRemoteBranch',
305 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
306 mock.patch('git_cl.GetTargetRef',
307 return_value='refs/heads/main').start()
308 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
309 lambda _, offer_removal: None).start()
310 mock.patch('git_cl.Changelist.GetIssue', return_value=None).start()
311 mock.patch('git_cl.Changelist.GetBranch',
312 side_effect=SystemExitMock).start()
313 mock.patch('git_cl.GenerateGerritChangeId', return_value=None).start()
314 mock.patch('git_cl.RunGit').start()
315
316 cl = git_cl.Changelist()
317 options = optparse.Values()
318 options.target_branch = 'refs/heads/master'
319 options.squash = True
320 options.edit_description = False
321 options.force = False
322 options.preserve_tryjobs = False
323 options.message_file = "message.txt"
324
325 with self.assertRaises(SystemExitMock):
326 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
327 self.assertEqual(len(m.mock_calls), 0)
328
329 options.message_file = None
330 with self.assertRaises(SystemExitMock):
331 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
332 self.assertEqual(len(m.mock_calls), 1)
333
Josip Sokcevicb631a882021-01-06 18:18:10 +0000334 def test_upload_to_old_default_retry_on_rollback(self):
335 """Test when default branch migration had to be rolled back to old name"""
336 m = mock.patch('git_cl.Changelist._CMDUploadChange',
337 side_effect=[git_cl.GitPushError(), None]).start()
338 mock.patch('git_cl.Changelist.GetRemoteBranch',
339 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
340 mock.patch('git_cl.Changelist.GetGerritProject',
341 return_value='foo').start()
342 mock.patch('git_cl.gerrit_util.GetProjectHead',
343 return_value='refs/heads/master').start()
344 # GetTargetRef returns new default branch since it has stale remote
345 # information.
346 mock.patch('git_cl.GetTargetRef',
347 return_value='refs/heads/main').start()
348 mock.patch('git_cl.RunGit').start()
349
350 cl = git_cl.Changelist()
351 options = optparse.Values()
352 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000353 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
354 # ensure upload is called twice
355 self.assertEqual(len(m.mock_calls), 2)
356 # option overrides on retry
357 self.assertEqual(options.force, True)
358 self.assertEqual(options.edit_description, False)
359
Edward Lemur61bf4172020-02-24 23:22:37 +0000360 def test_get_cl_statuses_no_changes(self):
361 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
362
363 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
364 @mock.patch('multiprocessing.pool.ThreadPool')
365 def test_get_cl_statuses_timeout(self, *_mocks):
366 changes = [git_cl.Changelist() for _ in range(2)]
367 pool = multiprocessing.pool.ThreadPool()
368 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
369 it.return_value.next.side_effect = [
370 (changes[0], 'lgtm'),
371 multiprocessing.TimeoutError,
372 ]
373
374 actual = list(git_cl.get_cl_statuses(changes, True))
375 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
376
377 @mock.patch('git_cl.Changelist.GetIssueURL')
378 def test_get_cl_statuses_not_finegrained(self, _mock):
379 changes = [git_cl.Changelist() for _ in range(2)]
380 urls = ['some-url', None]
381 git_cl.Changelist.GetIssueURL.side_effect = urls
382
383 actual = set(git_cl.get_cl_statuses(changes, False))
384 self.assertEqual(
385 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
386
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000387 def test_get_issue_url(self):
388 cl = git_cl.Changelist(issue=123)
389 cl._gerrit_server = 'https://example.com'
390 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
391 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
392
393 cl = git_cl.Changelist(issue=123)
394 cl._gerrit_server = 'https://chromium-review.googlesource.com'
395 self.assertEqual(cl.GetIssueURL(),
396 'https://chromium-review.googlesource.com/123')
397 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
398
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000399 def test_set_preserve_tryjobs(self):
400 d = git_cl.ChangeDescription('Simple.')
401 d.set_preserve_tryjobs()
402 self.assertEqual(d.description.splitlines(), [
403 'Simple.',
404 '',
405 'Cq-Do-Not-Cancel-Tryjobs: true',
406 ])
407 before = d.description
408 d.set_preserve_tryjobs()
409 self.assertEqual(before, d.description)
410
411 d = git_cl.ChangeDescription('\n'.join([
412 'One is enough',
413 '',
414 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
415 'Change-Id: Ideadbeef',
416 ]))
417 d.set_preserve_tryjobs()
418 self.assertEqual(d.description.splitlines(), [
419 'One is enough',
420 '',
421 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
422 'Change-Id: Ideadbeef',
423 'Cq-Do-Not-Cancel-Tryjobs: true',
424 ])
425
tandriif9aefb72016-07-01 09:06:51 -0700426 def test_get_bug_line_values(self):
427 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
428 self.assertEqual(f('', ''), [])
429 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
Lei Zhang8a0efc12020-08-05 19:58:45 +0000430 # Prefix that ends with colon.
431 self.assertEqual(f('v8:', '456'), ['v8:456'])
432 self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
433 # Prefix that ends without colon.
tandriif9aefb72016-07-01 09:06:51 -0700434 self.assertEqual(f('v8', '456'), ['v8:456'])
435 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
436 # Not nice, but not worth carying.
Lei Zhang8a0efc12020-08-05 19:58:45 +0000437 self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
438 ['v8:456', 'chromium:123', 'v8:123'])
tandriif9aefb72016-07-01 09:06:51 -0700439 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
440 ['v8:456', 'chromium:123', 'v8:123'])
441
Edward Lemurda4b6c62020-02-13 00:28:40 +0000442 @mock.patch('gerrit_util.GetAccountDetails')
443 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000444 mock_per_account = {
445 'u1': None, # 404, doesn't exist.
446 'u2': {
447 '_account_id': 123124,
448 'avatars': [],
449 'email': 'u2@example.com',
450 'name': 'User Number 2',
451 'status': 'OOO',
452 },
453 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
454 }
455 def GetAccountDetailsMock(_, account):
456 # Poor-man's mock library's side_effect.
457 v = mock_per_account.pop(account)
458 if isinstance(v, Exception):
459 raise v
460 return v
461
Edward Lemurda4b6c62020-02-13 00:28:40 +0000462 mockGetAccountDetails.side_effect = GetAccountDetailsMock
463 actual = git_cl.gerrit_util.ValidAccounts(
464 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000465 self.assertEqual(actual, {
466 'u2': {
467 '_account_id': 123124,
468 'avatars': [],
469 'email': 'u2@example.com',
470 'name': 'User Number 2',
471 'status': 'OOO',
472 },
473 })
474
475
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200476class TestParseIssueURL(unittest.TestCase):
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000477 def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
478 parsed = git_cl.ParseIssueNumberArgument(arg)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200479 self.assertIsNotNone(parsed)
480 if fail:
481 self.assertFalse(parsed.valid)
482 return
483 self.assertTrue(parsed.valid)
484 self.assertEqual(parsed.issue, issue)
485 self.assertEqual(parsed.patchset, patchset)
486 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200487
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000488 def test_basic(self):
489 self._test('123', 123)
490 self._test('', fail=True)
491 self._test('abc', fail=True)
492 self._test('123/1', fail=True)
493 self._test('123a', fail=True)
494 self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
495 self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200496
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000497 def test_gerrit_url(self):
498 self._test('https://codereview.source.com/123', 123, None,
499 'codereview.source.com')
500 self._test('http://chrome-review.source.com/c/123', 123, None,
501 'chrome-review.source.com')
502 self._test('https://chrome-review.source.com/c/123/', 123, None,
503 'chrome-review.source.com')
504 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
505 'chrome-review.source.com')
506 self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
507 'chrome-review.source.com')
508 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
509 'chrome-review.source.com')
510 self._test('https://chrome-review.source.com/123', 123, None,
511 'chrome-review.source.com')
512 self._test('https://chrome-review.source.com/123/4', 123, 4,
513 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200514
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000515 self._test('https://chrome-review.source.com/bad/123/4', fail=True)
516 self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
517 self._test('https://chrome-review.source.com/c/abc/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200518
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000519 def test_short_urls(self):
520 self._test('https://crrev.com/c/2151934', 2151934, None,
521 'chromium-review.googlesource.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200522
523
Edward Lemurda4b6c62020-02-13 00:28:40 +0000524class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100525 def setUp(self):
526 super(GitCookiesCheckerTest, self).setUp()
527 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100528 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000529 mock.patch('sys.stdout', StringIO()).start()
530 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100531
532 def mock_hosts_creds(self, subhost_identity_pairs):
533 def ensure_googlesource(h):
534 if not h.endswith(self.c._GOOGLESOURCE):
535 assert not h.endswith('.')
536 return h + '.' + self.c._GOOGLESOURCE
537 return h
538 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
539 for h, i in subhost_identity_pairs]
540
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200541 def test_identity_parsing(self):
542 self.assertEqual(self.c._parse_identity('ldap.google.com'),
543 ('ldap', 'google.com'))
544 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
545 ('ldap', 'example.com'))
546 # Specical case because we know there are no subdomains in chromium.org.
547 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
548 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800549 # Pathological: ".period." can be either username OR domain, more likely
550 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200551 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
552 ('note', 'period.example.com'))
553
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100554 def test_analysis_nothing(self):
555 self.c._all_hosts = []
556 self.assertFalse(self.c.has_generic_host())
557 self.assertEqual(set(), self.c.get_conflicting_hosts())
558 self.assertEqual(set(), self.c.get_duplicated_hosts())
559 self.assertEqual(set(), self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100560
561 def test_analysis(self):
562 self.mock_hosts_creds([
563 ('.googlesource.com', 'git-example.chromium.org'),
564
565 ('chromium', 'git-example.google.com'),
566 ('chromium-review', 'git-example.google.com'),
567 ('chrome-internal', 'git-example.chromium.org'),
568 ('chrome-internal-review', 'git-example.chromium.org'),
569 ('conflict', 'git-example.google.com'),
570 ('conflict-review', 'git-example.chromium.org'),
571 ('dup', 'git-example.google.com'),
572 ('dup', 'git-example.google.com'),
573 ('dup-review', 'git-example.google.com'),
574 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200575 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100576 ])
577 self.assertTrue(self.c.has_generic_host())
578 self.assertEqual(set(['conflict.googlesource.com']),
579 self.c.get_conflicting_hosts())
580 self.assertEqual(set(['dup.googlesource.com']),
581 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200582 self.assertEqual(set(['partial.googlesource.com',
583 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100584 self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100585
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100586 def test_report_no_problems(self):
587 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100588 self.assertFalse(self.c.find_and_report_problems())
589 self.assertEqual(sys.stdout.getvalue(), '')
590
Edward Lemurda4b6c62020-02-13 00:28:40 +0000591 @mock.patch(
592 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000593 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000594 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100595 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100596 self.assertTrue(self.c.find_and_report_problems())
597 with open(os.path.join(os.path.dirname(__file__),
598 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000599 expected = f.read() % {
600 'sep': os.sep,
601 }
602
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100603 def by_line(text):
604 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700605 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200606 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100607
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800608
Edward Lemurda4b6c62020-02-13 00:28:40 +0000609class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000610 def setUp(self):
611 super(TestGitCl, self).setUp()
612 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700613 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000614 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000615 mock.patch('sys.stdout', StringIO()).start()
616 mock.patch(
617 'git_cl.time_time',
618 lambda: self._mocked_call('time.time')).start()
619 mock.patch(
620 'git_cl.metrics.collector.add_repeated',
621 lambda *a: self._mocked_call('add_repeated', *a)).start()
622 mock.patch('subprocess2.call', self._mocked_call).start()
623 mock.patch('subprocess2.check_call', self._mocked_call).start()
624 mock.patch('subprocess2.check_output', self._mocked_call).start()
625 mock.patch(
626 'subprocess2.communicate',
627 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
628 mock.patch(
629 'git_cl.gclient_utils.CheckCallAndFilter',
630 self._mocked_call).start()
631 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000632 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
633 mock.patch(
634 'git_cl.SaveDescriptionBackup',
635 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
636 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000637 'git_cl.write_json',
638 lambda *a: self._mocked_call('write_json', *a)).start()
639 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000640 'git_cl.Changelist.RunHook',
641 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000642 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
643 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000644 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000645 mock.patch(
646 'git_cl.gerrit_util.GetChangeComments',
647 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
648 mock.patch(
649 'git_cl.gerrit_util.GetChangeRobotComments',
650 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
651 mock.patch(
652 'git_cl.gerrit_util.AddReviewers',
653 lambda *a: self._mocked_call('AddReviewers', *a)).start()
654 mock.patch(
655 'git_cl.gerrit_util.SetReview',
656 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
657 self._mocked_call(
658 'SetReview', h, i, msg, labels, notify, ready))).start()
659 mock.patch(
660 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
661 return_value=False).start()
662 mock.patch(
663 'git_cl.gerrit_util.GceAuthenticator.is_gce',
664 return_value=False).start()
665 mock.patch(
666 'git_cl.gerrit_util.ValidAccounts',
667 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000668 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000669 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000670 self.mockGit = GitMocks()
671 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
672 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
Edward Lesmes50da7702020-03-30 19:23:43 +0000673 mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
674 mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
Edward Lemur85153282020-02-14 22:06:29 +0000675 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000676 mock.patch(
677 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000678 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000679 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000680 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000681 mock.patch(
682 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000683 # It's important to reset settings to not have inter-tests interference.
684 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000685 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000686
687 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000688 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000689 if not self.failed:
690 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100691 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000692 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
693 if len(self.calls) > 5:
694 calls += ' ...\n'
695 self.fail(
696 '\n'
697 'There are un-consumed calls after this test has finished:\n' +
698 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000699 finally:
700 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000701
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000702 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000703 self.assertTrue(
704 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700705 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000706 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000707 expected_args, result = top
708
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000709 # Also logs otherwise it could get caught in a try/finally and be hard to
710 # diagnose.
711 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700712 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000713 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700714 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
715 for i, c in enumerate(self._calls_done[-N:]))
716 following_calls = '\n '.join(
717 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
718 for i, c in enumerate(self.calls[:N]))
719 extended_msg = (
720 'A few prior calls:\n %s\n\n'
721 'This (expected):\n @%d: %r\n'
722 'This (actual):\n @%d: %r\n\n'
723 'A few following expected calls:\n %s' %
724 (prior_calls, len(self._calls_done), expected_args,
725 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700726
Edward Lesmes0dd54822020-03-26 18:24:25 +0000727 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700728 self.fail('@%d\n'
729 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000730 ' Actual: %r\n'
731 '\n'
732 '%s' % (
733 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700734
735 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700736 if isinstance(result, Exception):
737 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000738 # stdout from git commands is supposed to be a bytestream. Convert it here
739 # instead of converting all test output in this file to bytes.
740 if args[0][0] == 'git' and not isinstance(result, bytes):
741 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000742 return result
743
Edward Lemur1a83da12020-03-04 21:18:36 +0000744 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
745 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100746 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100747 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000748 self.assertEqual(
749 'prompt [Yes/No]: Please, type yes or no: ',
750 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100751
tandrii48df5812016-10-17 03:55:37 -0700752 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000753 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700754 self.calls = [
755 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700756 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
757 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
758 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
759 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700760 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
761 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700762 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
763 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000764 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
765 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700766 ((['git', 'config', 'gerrit.host', 'true'],), ''),
767 ]
768 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
769
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000770 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100771 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200772 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000773 custom_cl_base=None, short_hostname='chromium',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000774 change_id=None, default_branch='master'):
Edward Lemur26964072020-02-19 19:18:51 +0000775 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200776 if custom_cl_base:
777 ancestor_revision = custom_cl_base
778 else:
779 # Determine ancestor_revision to be merge base.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000780 ancestor_revision = 'origin/' + default_branch
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200781
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100782 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000783 gerrit_util.GetChangeDetail.return_value = {
784 'owner': {'email': (other_cl_owner or 'owner@example.com')},
785 'change_id': (change_id or '123456789'),
786 'current_revision': 'sha1_of_current_revision',
787 'revisions': {'sha1_of_current_revision': {
788 'commit': {'message': fetched_description},
789 }},
790 'status': fetched_status or 'NEW',
791 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100792 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100793 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100794 if other_cl_owner:
795 calls += [
796 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
797 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100798
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100799 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200800 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
801 ([custom_cl_base] if custom_cl_base else
802 [ancestor_revision, 'HEAD']),),
803 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100804 ]
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000805 calls += [
806 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000807 '1' if default_branch == 'main' else callError(1)),
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000808 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000809
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100810 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000811
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000812 def _gerrit_upload_calls(self,
813 description,
814 reviewers,
815 squash,
tandriia60502f2016-06-20 02:01:53 -0700816 squash_mode='default',
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000817 title=None,
818 notify=False,
819 post_amend_description=None,
820 issue=None,
821 cc=None,
822 custom_cl_base=None,
823 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000824 short_hostname='chromium',
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000825 labels=None,
826 change_id=None,
827 final_description=None,
828 gitcookies_exists=True,
829 force=False,
830 edit_description=None,
831 default_branch='master',
832 push_opts=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000833 if post_amend_description is None:
834 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700835 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200836
837 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000838
Edward Lesmes4de54132020-05-05 19:41:33 +0000839 if squash_mode in ('override_squash', 'override_nosquash'):
840 self.mockGit.config['gerrit.override-squash-uploads'] = (
841 'true' if squash_mode == 'override_squash' else 'false')
842
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000843 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000844 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200845 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200846 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000847 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000848 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000849 calls += [
850 ((['RunEditor'],), description),
851 ]
Josipe827b0f2020-01-30 00:07:20 +0000852 # user wants to edit description
853 if edit_description:
854 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000855 ((['RunEditor'],), edit_description),
856 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000857 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200858
859 if custom_cl_base is None:
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000860 parent = 'origin/' + default_branch
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000861 git_common.get_or_create_merge_base.return_value = parent
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200862 else:
863 calls += [
864 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000865 'refs/remotes/origin/' + default_branch],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200866 callError(1)), # Means not ancenstor.
867 (('ask_for_data',
868 'Do you take responsibility for cleaning up potential mess '
869 'resulting from proceeding with upload? Press Enter to upload, '
870 'or Ctrl+C to abort'), ''),
871 ]
872 parent = custom_cl_base
873
874 calls += [
875 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
876 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000877 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200878 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000879 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200880 ref_to_push),
881 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000882 else:
883 ref_to_push = 'HEAD'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000884 parent = 'origin/refs/heads/' + default_branch
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000885
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000886 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000887 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000888 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200889 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000890
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000891 metrics_arguments = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000892
Aaron Gableafd52772017-06-27 16:40:10 -0700893 if notify:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000894 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000895 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700896 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400897 if not issue and squash:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000898 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000899 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700900 else:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000901 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000902 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800903
Edward Lemur5a644f82020-03-18 16:44:57 +0000904 # If issue is given, then description is fetched from Gerrit instead.
905 if issue is None:
906 if squash:
907 title = 'Initial upload'
908 else:
909 if not title:
910 calls += [
911 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
912 (('ask_for_data', 'Title for patchset []: '), 'User input'),
913 ]
914 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700915 if title:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000916 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000917 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000918
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000919 if short_hostname == 'chromium':
Quinten Yearsley925cedb2020-04-13 17:49:39 +0000920 # All reviewers and ccs get into ref_suffix.
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000921 for r in sorted(reviewers):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000922 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000923 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000924 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000925 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000926 for c in sorted(cc):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000927 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000928 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000929 reviewers, cc = [], []
930 else:
931 # TODO(crbug/877717): remove this case.
932 calls += [
933 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
934 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000935 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000936 {
937 e: {'email': e}
938 for e in (reviewers + ['joe@example.com'] + cc)
939 })
940 ]
941 for r in sorted(reviewers):
942 if r != 'bad-account-or-email':
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000943 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000944 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000945 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000946 if issue is None:
947 cc += ['joe@example.com']
948 for c in sorted(cc):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000949 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000950 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000951 if c in cc:
952 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000953
Edward Lemur687ca902018-12-05 02:30:30 +0000954 for k, v in sorted((labels or {}).items()):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000955 ref_suffix += ',l=%s+%d' % (k, v)
Edward Lemur687ca902018-12-05 02:30:30 +0000956 metrics_arguments.append('l=%s+%d' % (k, v))
957
958 if tbr:
959 calls += [
960 (('GetCodeReviewTbrScore',
961 '%s-review.googlesource.com' % short_hostname,
962 'my/repo'),
963 2,),
964 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000965
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000966 calls += [
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000967 (
968 ('time.time', ),
969 1000,
970 ),
971 (
972 ([
973 'git', 'push',
974 'https://%s.googlesource.com/my/repo' % short_hostname,
975 ref_to_push + ':refs/for/refs/heads/' + default_branch +
976 ref_suffix
977 ] + (push_opts if push_opts else []), ),
978 (('remote:\n'
979 'remote: Processing changes: (\)\n'
980 'remote: Processing changes: (|)\n'
981 'remote: Processing changes: (/)\n'
982 'remote: Processing changes: (-)\n'
983 'remote: Processing changes: new: 1 (/)\n'
984 'remote: Processing changes: new: 1, done\n'
985 'remote:\n'
986 'remote: New Changes:\n'
987 'remote: '
988 'https://%s-review.googlesource.com/#/c/my/repo/+/123456'
989 ' XXX\n'
990 'remote:\n'
991 'To https://%s.googlesource.com/my/repo\n'
992 ' * [new branch] hhhh -> refs/for/refs/heads/%s\n') %
993 (short_hostname, short_hostname, default_branch)),
994 ),
995 (
996 ('time.time', ),
997 2000,
998 ),
999 (
1000 ('add_repeated', 'sub_commands', {
1001 'execution_time': 1000,
1002 'command': 'git push',
1003 'exit_code': 0,
1004 'arguments': sorted(metrics_arguments),
1005 }),
1006 None,
1007 ),
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001008 ]
1009
Edward Lemur1b52d872019-05-09 21:12:12 +00001010 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001011
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001012 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
1013
Edward Lemur1b52d872019-05-09 21:12:12 +00001014 # Trace-related calls
1015 calls += [
1016 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001017 (
1018 ([
1019 'FileWrite', trace_name + '-README',
1020 '%(date)s\n'
1021 '%(short_hostname)s-review.googlesource.com\n'
1022 '%(change_id)s\n'
1023 '%(title)s\n'
1024 '%(description)s\n'
1025 '1000\n'
1026 '0\n'
1027 '%(trace_name)s' % {
Josip Sokcevic5e18b602020-04-23 21:47:00 +00001028 'date': '2017-03-16T20:00:41.000000',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001029 'short_hostname': short_hostname,
1030 'change_id': change_id,
1031 'description': final_description,
1032 'title': title or '<untitled>',
1033 'trace_name': trace_name,
1034 }
1035 ], ),
1036 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001037 ),
1038 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001039 (
1040 (['os.path.isfile',
1041 os.path.join('TEMP_DIR', 'trace-packet')], ),
1042 True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001043 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001044 (
1045 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
1046 ('git-hash: 0123456789012345678901234567890123456789\n'
1047 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +00001048 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001049 (
1050 ([
1051 'FileWrite',
1052 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
1053 'git-hash: abcdea\n'
1054 ], ),
1055 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001056 ),
1057 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001058 (
1059 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
1060 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001061 ),
1062 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001063 (
1064 (['git', 'config', '-l'], ),
1065 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +00001066 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001067 (
1068 ([
1069 'FileWrite',
1070 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
1071 ], ),
1072 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001073 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001074 (
1075 (['os.path.isfile',
1076 os.path.join('~', '.gitcookies')], ),
1077 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +00001078 ),
1079 ]
1080 if gitcookies_exists:
1081 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001082 (
1083 (['FileRead', os.path.join('~', '.gitcookies')], ),
1084 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +00001085 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001086 (
1087 ([
1088 'FileWrite',
1089 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
1090 ], ),
1091 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001092 ),
1093 ]
1094 calls += [
1095 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001096 (
1097 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
1098 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001099 ),
1100 ]
1101
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001102 # TODO(crbug/877717): this should never be used.
1103 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001104 calls += [
1105 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001106 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001107 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001108 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001109 notify),
1110 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001111 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001112 return calls
1113
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001114 def _run_gerrit_upload_test(self,
1115 upload_args,
1116 description,
1117 reviewers=None,
1118 squash=True,
1119 squash_mode=None,
1120 title=None,
1121 notify=False,
1122 post_amend_description=None,
1123 issue=None,
1124 cc=None,
1125 fetched_status=None,
1126 other_cl_owner=None,
1127 custom_cl_base=None,
1128 tbr=None,
1129 short_hostname='chromium',
1130 labels=None,
1131 change_id=None,
1132 final_description=None,
1133 gitcookies_exists=True,
1134 force=False,
1135 log_description=None,
1136 edit_description=None,
1137 fetched_description=None,
1138 default_branch='master',
1139 push_opts=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001140 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001141 if squash_mode is None:
1142 if '--no-squash' in upload_args:
1143 squash_mode = 'nosquash'
1144 elif '--squash' in upload_args:
1145 squash_mode = 'squash'
1146 else:
1147 squash_mode = 'default'
1148
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001149 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001150 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001151 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001152 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001153 same_auth=('git-owner.example.com', '', 'pass'))).start()
1154 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1155 lambda _, offer_removal: None).start()
1156 mock.patch('git_cl.gclient_utils.RunEditor',
1157 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1158 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001159 'DownloadGerritHook', force)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001160 mock.patch('git_cl.gclient_utils.FileRead',
1161 lambda path: self._mocked_call(['FileRead', path])).start()
1162 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001163 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001164 ['FileWrite', path, contents])).start()
1165 mock.patch('git_cl.datetime_now',
1166 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1167 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1168 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1169 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001170 '%(now)s\n'
1171 '%(gerrit_host)s\n'
1172 '%(change_id)s\n'
1173 '%(title)s\n'
1174 '%(description)s\n'
1175 '%(execution_time)s\n'
1176 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001177 '%(trace_name)s').start()
1178 mock.patch('git_cl.shutil.make_archive',
1179 lambda *args: self._mocked_call(['make_archive'] +
1180 list(args))).start()
1181 mock.patch('os.path.isfile',
1182 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001183 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001184 'git_cl._create_description_from_log',
1185 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001186 mock.patch(
1187 'git_cl.Changelist._AddChangeIdToCommitMessage',
1188 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001189 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001190 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1191 mock.patch(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001192 'git_common.get_or_create_merge_base',
1193 return_value='origin/' + default_branch).start()
1194 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001195 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001196 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001197
Edward Lemur26964072020-02-19 19:18:51 +00001198 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001199 self.mockGit.config['branch.master.gerritissue'] = (
1200 str(issue) if issue else None)
1201 self.mockGit.config['remote.origin.url'] = (
1202 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001203 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001204
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001205 self.calls = self._gerrit_base_calls(
1206 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001207 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001208 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001209 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001210 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001211 short_hostname=short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001212 change_id=change_id,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001213 default_branch=default_branch)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001214 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001215 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001216 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001217 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001218 self.calls += self._gerrit_upload_calls(
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001219 description,
1220 reviewers,
1221 squash,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001222 squash_mode=squash_mode,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001223 title=title,
1224 notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001225 post_amend_description=post_amend_description,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001226 issue=issue,
1227 cc=cc,
1228 custom_cl_base=custom_cl_base,
1229 tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001230 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001231 labels=labels,
1232 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001233 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001234 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001235 force=force,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001236 edit_description=edit_description,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001237 default_branch=default_branch,
1238 push_opts=push_opts)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001239 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001240 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001241 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001242 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001243 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001244 self.assertEqual(
1245 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001246 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001247
Edward Lemur1b52d872019-05-09 21:12:12 +00001248 def test_gerrit_upload_traces_no_gitcookies(self):
1249 self._run_gerrit_upload_test(
1250 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001251 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001252 [],
1253 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001254 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001255 change_id='Ixxx',
1256 gitcookies_exists=False)
1257
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001258 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001259 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001260 [],
1261 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1262 [],
1263 change_id='Ixxx')
1264
1265 def test_gerrit_upload_without_change_id_nosquash(self):
1266 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001267 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001268 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001269 [],
1270 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001271 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001272 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001273
Edward Lesmes4de54132020-05-05 19:41:33 +00001274 def test_gerrit_upload_without_change_id_override_nosquash(self):
1275 self._run_gerrit_upload_test(
1276 [],
1277 'desc ✔\n\nBUG=\n',
1278 [],
1279 squash=False,
1280 squash_mode='override_nosquash',
1281 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1282 change_id='Ixxx')
1283
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001284 def test_gerrit_no_reviewer(self):
1285 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001286 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001287 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001288 [],
1289 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001290 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001291 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001292
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001293 def test_gerrit_push_opts(self):
1294 self._run_gerrit_upload_test(['-o', 'wip'],
1295 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
1296 [],
1297 squash=False,
1298 squash_mode='override_nosquash',
1299 change_id='I123456789',
1300 push_opts=['-o', 'wip'])
1301
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001302 def test_gerrit_no_reviewer_non_chromium_host(self):
1303 # TODO(crbug/877717): remove this test case.
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001304 self._run_gerrit_upload_test([],
1305 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
1306 [],
1307 squash=False,
1308 squash_mode='override_nosquash',
1309 short_hostname='other',
1310 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001311
Edward Lesmes0dd54822020-03-26 18:24:25 +00001312 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001313 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001314 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001315 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001316 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001317 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001318 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001319 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001320
ukai@chromium.orge8077812012-02-03 03:41:46 +00001321 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001322 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001323 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001324 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001325 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001326 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001327 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001328 notify=True,
1329 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001330 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001331 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001332
Anthony Polito8b955342019-09-24 19:01:36 +00001333 def test_gerrit_upload_force_sets_bug(self):
1334 self._run_gerrit_upload_test(
1335 ['-b', '10000', '-f'],
1336 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1337 [],
1338 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001339 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001340 change_id='Ixxx')
1341
Edward Lemur5fb22242020-03-12 22:05:13 +00001342 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001343 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001344 ['-b', '10000', '-m', 'Title', '--edit-description'],
1345 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001346 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001347 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001348 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001349 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001350 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001351 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001352
Dan Beamd8b04ca2019-10-10 21:23:26 +00001353 def test_gerrit_upload_force_sets_fixed(self):
1354 self._run_gerrit_upload_test(
1355 ['-x', '10000', '-f'],
1356 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1357 [],
1358 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001359 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001360 change_id='Ixxx')
1361
ukai@chromium.orge8077812012-02-03 03:41:46 +00001362 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001363 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1364 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001365 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001366 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001367 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001368 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001369 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001370 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001371 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001372 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001373 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001374 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001375
1376 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001377 self._run_gerrit_upload_test(
1378 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001379 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001380 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001381 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001382
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001383 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001384 self._run_gerrit_upload_test(
1385 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001386 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001387 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001388 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001389 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001390
Edward Lesmes0dd54822020-03-26 18:24:25 +00001391 def test_gerrit_upload_squash_first_title(self):
1392 self._run_gerrit_upload_test(
1393 ['-f', '-t', 'title'],
1394 'title\n\ndesc\n\nChange-Id: 123456789',
1395 [],
1396 force=True,
1397 squash=True,
1398 log_description='desc',
1399 change_id='123456789')
1400
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001401 def test_gerrit_upload_squash_first_with_labels(self):
1402 self._run_gerrit_upload_test(
1403 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001404 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001405 [],
1406 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001407 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001408 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001409
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001410 def test_gerrit_upload_squash_first_against_rev(self):
1411 custom_cl_base = 'custom_cl_base_rev_or_branch'
1412 self._run_gerrit_upload_test(
1413 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001414 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001415 [],
1416 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001417 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001418 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001419 self.assertIn(
1420 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1421 sys.stdout.getvalue())
1422
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001423 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001424 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001425 self._run_gerrit_upload_test(
1426 ['--squash'],
1427 description,
1428 [],
1429 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001430 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001431 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001432
Edward Lemurd55c5072020-02-20 01:09:07 +00001433 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001434 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001435 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001436 with self.assertRaises(SystemExitMock):
1437 self._run_gerrit_upload_test(
1438 ['--squash'],
1439 description,
1440 [],
1441 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001442 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001443 fetched_status='ABANDONED',
1444 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001445 self.assertEqual(
1446 'Change https://chromium-review.googlesource.com/123456 has been '
1447 'abandoned, new uploads are not allowed\n',
1448 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001449
Edward Lemurda4b6c62020-02-13 00:28:40 +00001450 @mock.patch(
1451 'gerrit_util.GetAccountDetails',
1452 return_value={'email': 'yet-another@example.com'})
1453 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001454 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001455 self._run_gerrit_upload_test(
1456 ['--squash'],
1457 description,
1458 [],
1459 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001460 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001461 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001462 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001463 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001464 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001465 'authenticate to Gerrit as yet-another@example.com.\n'
1466 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001467 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001468
Josipe827b0f2020-01-30 00:07:20 +00001469 def test_upload_change_description_editor(self):
1470 fetched_description = 'foo\n\nChange-Id: 123456789'
1471 description = 'bar\n\nChange-Id: 123456789'
1472 self._run_gerrit_upload_test(
1473 ['--squash', '--edit-description'],
1474 description,
1475 [],
1476 fetched_description=fetched_description,
1477 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001478 issue=123456,
1479 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001480 edit_description=description)
1481
Edward Lemurda4b6c62020-02-13 00:28:40 +00001482 @mock.patch('git_cl.RunGit')
1483 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001484 @mock.patch('sys.stdin', StringIO('\n'))
1485 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001486 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001487 def mock_run_git(*args, **_kwargs):
1488 if args[0] == ['for-each-ref',
1489 '--format=%(refname:short) %(upstream:short)',
1490 'refs/heads']:
1491 # Create a local branch dependency tree that looks like this:
1492 # test1 -> test2 -> test3 -> test4 -> test5
1493 # -> test3.1
1494 # test6 -> test0
1495 branch_deps = [
1496 'test2 test1', # test1 -> test2
1497 'test3 test2', # test2 -> test3
1498 'test3.1 test2', # test2 -> test3.1
1499 'test4 test3', # test3 -> test4
1500 'test5 test4', # test4 -> test5
1501 'test6 test0', # test0 -> test6
1502 'test7', # test7
1503 ]
1504 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001505 git_cl.RunGit.side_effect = mock_run_git
1506 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001507
1508 class MockChangelist():
1509 def __init__(self):
1510 pass
1511 def GetBranch(self):
1512 return 'test1'
1513 def GetIssue(self):
1514 return '123'
1515 def GetPatchset(self):
1516 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001517 def IsGerrit(self):
1518 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001519
1520 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1521 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001522 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001523 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001524 'This command will checkout all dependent branches '
1525 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001526 'or Ctrl+C to abort',
1527 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001528 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001529
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001530 def test_gerrit_change_id(self):
1531 self.calls = [
1532 ((['git', 'write-tree'], ),
1533 'hashtree'),
1534 ((['git', 'rev-parse', 'HEAD~0'], ),
1535 'branch-parent'),
1536 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1537 'A B <a@b.org> 1456848326 +0100'),
1538 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1539 'C D <c@d.org> 1456858326 +0100'),
1540 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1541 'hashchange'),
1542 ]
1543 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1544 self.assertEqual(change_id, 'Ihashchange')
1545
Edward Lesmes8170c292021-03-19 20:04:43 +00001546 @mock.patch('gerrit_util.IsCodeOwnersEnabledOnHost')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001547 @mock.patch('git_cl.Settings.GetBugPrefix')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001548 @mock.patch('git_cl.Changelist.FetchDescription')
1549 @mock.patch('git_cl.Changelist.GetBranch')
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001550 @mock.patch('git_cl.Changelist.GetCommonAncestorWithUpstream')
Edward Lesmese1576912021-02-16 21:53:34 +00001551 @mock.patch('git_cl.Changelist.GetGerritHost')
1552 @mock.patch('git_cl.Changelist.GetGerritProject')
1553 @mock.patch('git_cl.Changelist.GetRemoteBranch')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001554 @mock.patch('owners_client.OwnersClient.BatchListOwners')
1555 def getDescriptionForUploadTest(
Edward Lesmese1576912021-02-16 21:53:34 +00001556 self, mockBatchListOwners=None, mockGetRemoteBranch=None,
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001557 mockGetGerritProject=None, mockGetGerritHost=None,
1558 mockGetCommonAncestorWithUpstream=None, mockGetBranch=None,
Edward Lesmese1576912021-02-16 21:53:34 +00001559 mockFetchDescription=None, mockGetBugPrefix=None,
Edward Lesmes8170c292021-03-19 20:04:43 +00001560 mockIsCodeOwnersEnabledOnHost=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001561 initial_description='desc', bug=None, fixed=None, branch='branch',
1562 reviewers=None, tbrs=None, add_owners_to=None,
1563 expected_description='desc'):
1564 reviewers = reviewers or []
1565 tbrs = tbrs or []
1566 owners_by_path = {
1567 'a': ['a@example.com'],
1568 'b': ['b@example.com'],
1569 'c': ['c@example.com'],
1570 }
Edward Lesmes8170c292021-03-19 20:04:43 +00001571 mockIsCodeOwnersEnabledOnHost.return_value = True
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001572 mockGetBranch.return_value = branch
1573 mockGetBugPrefix.return_value = 'prefix'
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001574 mockGetCommonAncestorWithUpstream.return_value = 'upstream'
Edward Lesmese1576912021-02-16 21:53:34 +00001575 mockGetRemoteBranch.return_value = ('origin', 'refs/remotes/origin/main')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001576 mockFetchDescription.return_value = 'desc'
1577 mockBatchListOwners.side_effect = lambda ps: {
1578 p: owners_by_path.get(p)
1579 for p in ps
1580 }
1581
1582 cl = git_cl.Changelist(issue=1234)
1583 actual = cl._GetDescriptionForUpload(
1584 options=mock.Mock(
1585 bug=bug,
1586 fixed=fixed,
1587 reviewers=reviewers,
1588 tbrs=tbrs,
1589 add_owners_to=add_owners_to),
1590 git_diff_args=None,
1591 files=list(owners_by_path))
1592 self.assertEqual(expected_description, actual.description)
1593
1594 def testGetDescriptionForUpload(self):
1595 self.getDescriptionForUploadTest()
1596
1597 def testGetDescriptionForUpload_Bug(self):
1598 self.getDescriptionForUploadTest(
1599 bug='1234',
1600 expected_description='\n'.join([
1601 'desc',
1602 '',
1603 'Bug: prefix:1234',
1604 ]))
1605
1606 def testGetDescriptionForUpload_Fixed(self):
1607 self.getDescriptionForUploadTest(
1608 fixed='1234',
1609 expected_description='\n'.join([
1610 'desc',
1611 '',
1612 'Fixed: prefix:1234',
1613 ]))
1614
1615
1616 def testGetDescriptionForUpload_BugFromBranch(self):
1617 self.getDescriptionForUploadTest(
1618 branch='bug-1234',
1619 expected_description='\n'.join([
1620 'desc',
1621 '',
1622 'Bug: prefix:1234',
1623 ]))
1624
1625 def testGetDescriptionForUpload_FixedFromBranch(self):
1626 self.getDescriptionForUploadTest(
1627 branch='fix-1234',
1628 expected_description='\n'.join([
1629 'desc',
1630 '',
1631 'Fixed: prefix:1234',
1632 ]))
1633
1634 def testGetDescriptionForUpload_AddOwnersToR(self):
1635 self.getDescriptionForUploadTest(
1636 reviewers=['a@example.com'],
1637 tbrs=['b@example.com'],
1638 add_owners_to='R',
1639 expected_description='\n'.join([
1640 'desc',
1641 '',
1642 'R=a@example.com, c@example.com',
1643 'TBR=b@example.com',
1644 ]))
1645
1646 def testGetDescriptionForUpload_AddOwnersToTBR(self):
1647 self.getDescriptionForUploadTest(
1648 reviewers=['a@example.com'],
1649 tbrs=['b@example.com'],
1650 add_owners_to='TBR',
1651 expected_description='\n'.join([
1652 'desc',
1653 '',
1654 'R=a@example.com',
1655 'TBR=b@example.com, c@example.com',
1656 ]))
1657
1658 def testGetDescriptionForUpload_AddOwnersToNoOwnersNeeded(self):
1659 self.getDescriptionForUploadTest(
1660 reviewers=['a@example.com', 'c@example.com'],
1661 tbrs=['b@example.com'],
1662 add_owners_to='TBR',
1663 expected_description='\n'.join([
1664 'desc',
1665 '',
1666 'R=a@example.com, c@example.com',
1667 'TBR=b@example.com',
1668 ]))
1669
1670 def testGetDescriptionForUpload_Reviewers(self):
1671 self.getDescriptionForUploadTest(
1672 reviewers=['a@example.com', 'b@example.com'],
1673 expected_description='\n'.join([
1674 'desc',
1675 '',
1676 'R=a@example.com, b@example.com',
1677 ]))
1678
1679 def testGetDescriptionForUpload_TBRs(self):
1680 self.getDescriptionForUploadTest(
1681 tbrs=['a@example.com', 'b@example.com'],
1682 expected_description='\n'.join([
1683 'desc',
1684 '',
1685 'TBR=a@example.com, b@example.com',
1686 ]))
1687
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001688 def test_desecription_append_footer(self):
1689 for init_desc, footer_line, expected_desc in [
1690 # Use unique desc first lines for easy test failure identification.
1691 ('foo', 'R=one', 'foo\n\nR=one'),
1692 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1693 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1694 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1695 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1696 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1697 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1698 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1699 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1700 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1701 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1702 ]:
1703 desc = git_cl.ChangeDescription(init_desc)
1704 desc.append_footer(footer_line)
1705 self.assertEqual(desc.description, expected_desc)
1706
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001707 def test_update_reviewers(self):
1708 data = [
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001709 ('foo', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001710 'foo'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001711 ('foo\nR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001712 'foo\nR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001713 ('foo\nTBR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001714 'foo\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001715 ('foo', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001716 'foo\n\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001717 ('foo\nR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001718 'foo\n\nR=a@c, xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001719 ('foo\nTBR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001720 'foo\n\nR=a@c\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001721 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001722 'foo\n\nR=a@c, yy\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001723 ('foo\nBUG=', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001724 'foo\nBUG=\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001725 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001726 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001727 ('foo', ['a@c', 'b@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001728 'foo\n\nR=a@c, b@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001729 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001730 'foo\nBar\n\nR=c@c\nBUG='),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001731 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001732 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001733 # Same as the line before, but full of whitespaces.
1734 (
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001735 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001736 'foo\nBar\n\nR=c@c\n BUG =',
1737 ),
1738 # Whitespaces aren't interpreted as new lines.
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001739 ('foo BUG=allo R=joe ', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001740 'foo BUG=allo R=joe\n\nR=c@c'),
1741 # Redundant TBRs get promoted to Rs
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001742 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001743 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001744 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001745 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001746 actual = []
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001747 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001748 obj = git_cl.ChangeDescription(orig)
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001749 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001750 actual.append(obj.description)
1751 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001752
Nodir Turakulov23b82142017-11-16 11:04:25 -08001753 def test_get_hash_tags(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001754 self.calls = [
1755 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
1756 callError(1)),
1757 ] * 9
Nodir Turakulov23b82142017-11-16 11:04:25 -08001758 cases = [
1759 ('', []),
1760 ('a', []),
1761 ('[a]', ['a']),
1762 ('[aa]', ['aa']),
1763 ('[a ]', ['a']),
1764 ('[a- ]', ['a']),
1765 ('[a- b]', ['a-b']),
1766 ('[a--b]', ['a-b']),
1767 ('[a', []),
1768 ('[a]x', ['a']),
1769 ('[aa]x', ['aa']),
1770 ('[a b]', ['a-b']),
1771 ('[a b]', ['a-b']),
1772 ('[a__b]', ['a-b']),
1773 ('[a] x', ['a']),
1774 ('[a][b]', ['a', 'b']),
1775 ('[a] [b]', ['a', 'b']),
1776 ('[a][b]x', ['a', 'b']),
1777 ('[a][b] x', ['a', 'b']),
1778 ('[a]\n[b]', ['a']),
1779 ('[a\nb]', []),
1780 ('[a][', ['a']),
1781 ('Revert "[a] feature"', ['a']),
1782 ('Reland "[a] feature"', ['a']),
1783 ('Revert: [a] feature', ['a']),
1784 ('Reland: [a] feature', ['a']),
1785 ('Revert "Reland: [a] feature"', ['a']),
1786 ('Foo: feature', ['foo']),
1787 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001788 ('Change Foo::Bar', []),
1789 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001790 ('Revert "Foo bar: feature"', ['foo-bar']),
1791 ('Reland "Foo bar: feature"', ['foo-bar']),
1792 ]
1793 for desc, expected in cases:
1794 change_desc = git_cl.ChangeDescription(desc)
1795 actual = change_desc.get_hash_tags()
1796 self.assertEqual(
1797 actual,
1798 expected,
1799 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1800
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001801 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001802 self.assertEqual(None, git_cl.GetTargetRef(None,
1803 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001804 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001805
wittman@chromium.org455dc922015-01-26 20:15:50 +00001806 # Check default target refs for branches.
1807 self.assertEqual('refs/heads/master',
1808 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001809 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001810 self.assertEqual('refs/heads/master',
1811 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001812 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001813 self.assertEqual('refs/heads/master',
1814 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001815 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001816 self.assertEqual('refs/branch-heads/123',
1817 git_cl.GetTargetRef('origin',
1818 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001819 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001820 self.assertEqual('refs/diff/test',
1821 git_cl.GetTargetRef('origin',
1822 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001823 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001824 self.assertEqual('refs/heads/chrome/m42',
1825 git_cl.GetTargetRef('origin',
1826 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001827 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001828
1829 # Check target refs for user-specified target branch.
1830 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1831 'refs/remotes/branch-heads/123'):
1832 self.assertEqual('refs/branch-heads/123',
1833 git_cl.GetTargetRef('origin',
1834 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001835 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001836 for branch in ('origin/master', 'remotes/origin/master',
1837 'refs/remotes/origin/master'):
1838 self.assertEqual('refs/heads/master',
1839 git_cl.GetTargetRef('origin',
1840 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001841 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001842 for branch in ('master', 'heads/master', 'refs/heads/master'):
1843 self.assertEqual('refs/heads/master',
1844 git_cl.GetTargetRef('origin',
1845 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001846 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001847
Edward Lemurda4b6c62020-02-13 00:28:40 +00001848 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1849 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001850 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001851 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1852
Edward Lemur85153282020-02-14 22:06:29 +00001853 def assertIssueAndPatchset(
1854 self, branch='master', issue='123456', patchset='7',
1855 git_short_host='chromium'):
1856 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001857 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001858 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001859 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001860 self.assertEqual(
1861 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001862 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001863
Edward Lemur85153282020-02-14 22:06:29 +00001864 def _patch_common(self, git_short_host='chromium'):
Edward Lesmes50da7702020-03-30 19:23:43 +00001865 mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
Edward Lemur26964072020-02-19 19:18:51 +00001866 self.mockGit.config['remote.origin.url'] = (
1867 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001868 gerrit_util.GetChangeDetail.return_value = {
1869 'current_revision': '7777777777',
1870 'revisions': {
1871 '1111111111': {
1872 '_number': 1,
1873 'fetch': {'http': {
1874 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1875 'ref': 'refs/changes/56/123456/1',
1876 }},
1877 },
1878 '7777777777': {
1879 '_number': 7,
1880 'fetch': {'http': {
1881 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1882 'ref': 'refs/changes/56/123456/7',
1883 }},
1884 },
1885 },
1886 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001887
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001888 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001889 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001890 self.calls += [
1891 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1892 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001893 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001894 ]
1895 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001896 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001897
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001898 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001899 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001900 self.calls += [
1901 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1902 'refs/changes/56/123456/7'],), ''),
1903 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001904 ]
Edward Lemur85153282020-02-14 22:06:29 +00001905 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1906 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001907
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001908 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001909 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001910 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001911 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001912 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001913 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001914 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001915 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001916 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001917
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001918 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001919 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001920 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001921 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001922 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001923 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001924 ]
1925 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001926 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001927 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001928
Aaron Gable697a91b2018-01-19 15:20:15 -08001929 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001930 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001931 self.calls += [
1932 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1933 'refs/changes/56/123456/1'],), ''),
1934 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001935 ]
1936 self.assertEqual(git_cl.main(
1937 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1938 0)
Edward Lemur85153282020-02-14 22:06:29 +00001939 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001940
Edward Lemurd55c5072020-02-20 01:09:07 +00001941 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001942 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001943 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001944 self.calls += [
1945 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001946 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001947 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001948 ]
1949 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001950 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001951 self.assertEqual(
1952 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1953 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001954
Edward Lemurda4b6c62020-02-13 00:28:40 +00001955 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001956 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001957 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001958 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001959 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001960 self.mockGit.config['remote.origin.url'] = (
1961 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001962 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001963 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001964 self.assertEqual(
1965 'change 123456 at https://chromium-review.googlesource.com does not '
1966 'exist or you have no access to it\n',
1967 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001968
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001969 def _checkout_calls(self):
1970 return [
1971 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001972 'branch\\..*\\.gerritissue'], ),
1973 ('branch.ger-branch.gerritissue 123456\n'
1974 'branch.gbranch654.gerritissue 654321\n')),
1975 ]
1976
1977 def test_checkout_gerrit(self):
1978 """Tests git cl checkout <issue>."""
1979 self.calls = self._checkout_calls()
1980 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1981 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1982
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001983 def test_checkout_not_found(self):
1984 """Tests git cl checkout <issue>."""
1985 self.calls = self._checkout_calls()
1986 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1987
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001988 def test_checkout_no_branch_issues(self):
1989 """Tests git cl checkout <issue>."""
1990 self.calls = [
1991 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001992 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001993 ]
1994 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1995
Edward Lemur26964072020-02-19 19:18:51 +00001996 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00001997 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001998 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001999 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002000 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2001 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00002002 self.mockGit.config['remote.origin.url'] = (
2003 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00002004 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00002005 cl.branch = 'master'
2006 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002007 return cl
2008
Edward Lemurd55c5072020-02-20 01:09:07 +00002009 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002010 def test_gerrit_ensure_authenticated_missing(self):
2011 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002012 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002013 })
Edward Lemurd55c5072020-02-20 01:09:07 +00002014 with self.assertRaises(SystemExitMock):
2015 cl.EnsureAuthenticated(force=False)
2016 self.assertEqual(
2017 'Credentials for the following hosts are required:\n'
2018 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002019 'These are read from ~%(sep)s.gitcookies '
2020 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00002021 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002022 'https://chromium-review.googlesource.com/new-password\n' % {
2023 'sep': os.sep,
2024 'netrc': NETRC_FILENAME,
2025 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002026
2027 def test_gerrit_ensure_authenticated_conflict(self):
2028 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002029 'chromium.googlesource.com':
2030 ('git-one.example.com', None, 'secret1'),
2031 'chromium-review.googlesource.com':
2032 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002033 })
2034 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002035 (('ask_for_data', 'If you know what you are doing '
2036 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002037 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2038
2039 def test_gerrit_ensure_authenticated_ok(self):
2040 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002041 'chromium.googlesource.com':
2042 ('git-same.example.com', None, 'secret'),
2043 'chromium-review.googlesource.com':
2044 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002045 })
2046 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2047
tandrii@chromium.org28253532016-04-14 13:46:56 +00002048 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00002049 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
2050 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00002051 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2052
Eric Boren2fb63102018-10-05 13:05:03 +00002053 def test_gerrit_ensure_authenticated_bearer_token(self):
2054 cl = self._test_gerrit_ensure_authenticated_common(auth={
2055 'chromium.googlesource.com':
2056 ('', None, 'secret'),
2057 'chromium-review.googlesource.com':
2058 ('', None, 'secret'),
2059 })
2060 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2061 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2062 'chromium.googlesource.com')
2063 self.assertTrue('Bearer' in header)
2064
Daniel Chengcf6269b2019-05-18 01:02:12 +00002065 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00002066 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00002067 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002068 (('logging.warning',
2069 'Ignoring branch %(branch)s with non-https remote '
2070 '%(remote)s', {
2071 'branch': 'master',
2072 'remote': 'custom-scheme://repo'}
2073 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00002074 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002075 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2076 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2077 mock.patch('logging.warning',
2078 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002079 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002080 cl.branch = 'master'
2081 cl.branchref = 'refs/heads/master'
2082 cl.lookedup_issue = True
2083 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2084
Florian Mayerae510e82020-01-30 21:04:48 +00002085 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00002086 self.mockGit.config['remote.origin.url'] = (
2087 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00002088 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002089 (('logging.error',
2090 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2091 'but it doesn\'t exist.', {
2092 'remote': 'origin',
2093 'branch': 'master',
2094 'url': 'git@somehost.example:foo/bar.git'}
2095 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00002096 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002097 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2098 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2099 mock.patch('logging.error',
2100 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00002101 cl = git_cl.Changelist()
2102 cl.branch = 'master'
2103 cl.branchref = 'refs/heads/master'
2104 cl.lookedup_issue = True
2105 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2106
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002107 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00002108 self.mockGit.config['branch.master.gerritissue'] = '123'
2109 self.mockGit.config['branch.master.gerritserver'] = (
2110 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00002111 self.mockGit.config['remote.origin.url'] = (
2112 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002113 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00002114 (('SetReview', 'chromium-review.googlesource.com',
2115 'infra%2Finfra~123', None,
2116 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002117 ]
tandriid9e5ce52016-07-13 02:32:59 -07002118
2119 def test_cmd_set_commit_gerrit_clear(self):
2120 self._cmd_set_commit_gerrit_common(0)
2121 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2122
2123 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002124 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002125 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2126
tandriid9e5ce52016-07-13 02:32:59 -07002127 def test_cmd_set_commit_gerrit(self):
2128 self._cmd_set_commit_gerrit_common(2)
2129 self.assertEqual(0, git_cl.main(['set-commit']))
2130
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002131 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002132 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002133 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002134
2135 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002136 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002137
Edward Lemurda4b6c62020-02-13 00:28:40 +00002138 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07002139 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07002140 try:
2141 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00002142 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00002143 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00002144 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07002145
2146 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07002147 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002148 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002149 return 'foobar'
2150
Edward Lemurda4b6c62020-02-13 00:28:40 +00002151 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07002152 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002153 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002154 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00002155 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07002156
iannuccie53c9352016-08-17 14:40:40 -07002157 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002158
iannuccie53c9352016-08-17 14:40:40 -07002159 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002160 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002161 return 'foobar'
2162
Edward Lemurda4b6c62020-02-13 00:28:40 +00002163 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2164 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002165 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002166 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002167
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002168 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00002169 self.mockGit.config['remote.origin.url'] = (
2170 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002171 gerrit_util.GetChangeDetail.return_value = {
2172 'current_revision': 'sha1',
2173 'revisions': {'sha1': {
2174 'commit': {'message': 'foobar'},
2175 }},
2176 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002177 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002178 'description',
2179 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2180 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002181 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002182
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002183 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002184 mock.patch('git_cl.Changelist', ChangelistMock).start()
2185 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002186
2187 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2188 self.assertEqual('hihi', ChangelistMock.desc)
2189
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002190 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002191 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002192
2193 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002194 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002195 '# Enter a description of the change.\n'
2196 '# This will be displayed on the codereview site.\n'
2197 '# The first line will also be used as the subject of the review.\n'
2198 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002199 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002200 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002201 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002202 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002203 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002204
Edward Lemur6c6827c2020-02-06 21:15:18 +00002205 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002206 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002207
Edward Lemurda4b6c62020-02-13 00:28:40 +00002208 mock.patch('git_cl.Changelist.FetchDescription',
2209 lambda *args: current_desc).start()
2210 mock.patch('git_cl.Changelist.UpdateDescription',
2211 UpdateDescription).start()
2212 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002213
Edward Lemur85153282020-02-14 22:06:29 +00002214 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002215 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002216
Dan Beamd8b04ca2019-10-10 21:23:26 +00002217 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2218 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2219
2220 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002221 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002222 '# Enter a description of the change.\n'
2223 '# This will be displayed on the codereview site.\n'
2224 '# The first line will also be used as the subject of the review.\n'
2225 '#--------------------This line is 72 characters long'
2226 '--------------------\n'
2227 'Some.\n\nFixed: 123\nChange-Id: xxx',
2228 desc)
2229 return desc
2230
Edward Lemurda4b6c62020-02-13 00:28:40 +00002231 mock.patch('git_cl.Changelist.FetchDescription',
2232 lambda *args: current_desc).start()
2233 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002234
Edward Lemur85153282020-02-14 22:06:29 +00002235 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002236 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002237
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002238 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002239 mock.patch('git_cl.Changelist', ChangelistMock).start()
2240 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002241
2242 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2243 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2244
kmarshall3bff56b2016-06-06 18:31:47 -07002245 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002246 self.calls = [
2247 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002248 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002249 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002250 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002251 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002252 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002253
Edward Lemurda4b6c62020-02-13 00:28:40 +00002254 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002255 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002256 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2257 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002258 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002259
2260 self.assertEqual(0, git_cl.main(['archive', '-f']))
2261
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002262 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002263 self.calls = [
2264 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2265 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2266 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2267 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002268 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2269 ((['git', 'branch', '-D', 'foo'],), '')
2270 ]
2271
Edward Lemurda4b6c62020-02-13 00:28:40 +00002272 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002273 lambda branches, fine_grained, max_processes:
2274 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2275 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002276 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002277
2278 self.assertEqual(0, git_cl.main(['archive', '-f']))
2279
kmarshall3bff56b2016-06-06 18:31:47 -07002280 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002281 self.calls = [
2282 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2283 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002284 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002285 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002286
Edward Lemurda4b6c62020-02-13 00:28:40 +00002287 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002288 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002289 [(MockChangelistWithBranchAndIssue('master', 1),
2290 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002291
2292 self.assertEqual(1, git_cl.main(['archive', '-f']))
2293
2294 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002295 self.calls = [
2296 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2297 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002298 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002299 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002300
Edward Lemurda4b6c62020-02-13 00:28:40 +00002301 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002302 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002303 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2304 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002305 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002306
kmarshall9249e012016-08-23 12:02:16 -07002307 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2308
2309 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002310 self.calls = [
2311 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2312 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002313 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002314 ((['git', 'branch', '-D', 'foo'],), '')
2315 ]
kmarshall9249e012016-08-23 12:02:16 -07002316
Edward Lemurda4b6c62020-02-13 00:28:40 +00002317 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002318 lambda branches, fine_grained, max_processes:
2319 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2320 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002321 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002322
2323 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002324
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002325 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002326 self.calls = [
2327 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2328 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2329 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002330 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2331 'refs/tags/git-cl-archived-456-foo'),
2332 ((['git', 'branch', '-D', 'foo'],), CERR1),
2333 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2334 'refs/tags/git-cl-archived-456-foo'),
2335 ]
2336
Edward Lemurda4b6c62020-02-13 00:28:40 +00002337 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002338 lambda branches, fine_grained, max_processes:
2339 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2340 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002341 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002342
2343 self.assertEqual(0, git_cl.main(['archive', '-f']))
2344
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002345 def test_archive_with_format(self):
2346 self.calls = [
2347 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
2348 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2349 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2350 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2351 ((['git', 'branch', '-D', 'foo'], ), ''),
2352 ]
2353
2354 mock.patch('git_cl.get_cl_statuses',
2355 lambda branches, fine_grained, max_processes:
2356 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2357
2358 self.assertEqual(
2359 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2360
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002361 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002362 self.mockGit.config['branch.master.gerritissue'] = '123'
2363 self.mockGit.config['branch.master.gerritserver'] = (
2364 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002365 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002366 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002367 ]
2368 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002369 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2370 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002371
Aaron Gable400e9892017-07-12 15:31:21 -07002372 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002373 self.mockGit.config['branch.master.gerritissue'] = '123'
2374 self.mockGit.config['branch.master.gerritserver'] = (
2375 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002376 mock.patch('git_cl.Changelist.FetchDescription',
2377 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002378 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002379 ((['git', 'log', '-1', '--format=%B'],),
2380 'This is a description\n\nChange-Id: Ideadbeef'),
2381 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002382 ]
2383 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002384 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2385 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002386
phajdan.jre328cf92016-08-22 04:12:17 -07002387 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002388 self.mockGit.config['branch.master.gerritissue'] = '123'
2389 self.mockGit.config['branch.master.gerritserver'] = (
2390 'https://chromium-review.googlesource.com')
Nodir Turakulov27379632021-03-17 18:53:29 +00002391 self.mockGit.config['remote.origin.url'] = (
2392 'https://chromium.googlesource.com/chromium/src'
2393 )
2394 self.calls = [(
2395 (
2396 'write_json',
2397 'output.json',
2398 {
2399 'issue': 123,
2400 'issue_url': 'https://chromium-review.googlesource.com/123',
2401 'gerrit_host': 'chromium-review.googlesource.com',
2402 'gerrit_project': 'chromium/src',
2403 },
2404 ),
2405 '',
2406 )]
phajdan.jre328cf92016-08-22 04:12:17 -07002407 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2408
tandrii16e0b4e2016-06-07 10:34:28 -07002409 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002410 mock.patch(
2411 'git_cl.os.path.abspath',
2412 lambda path: self._mocked_call(['abspath', path])).start()
2413 mock.patch(
2414 'git_cl.os.path.exists',
2415 lambda path: self._mocked_call(['exists', path])).start()
2416 mock.patch(
2417 'git_cl.gclient_utils.FileRead',
2418 lambda path: self._mocked_call(['FileRead', path])).start()
2419 mock.patch(
2420 'git_cl.gclient_utils.rm_file_or_tree',
2421 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002422 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002423 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002424 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002425 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002426
2427 def test_GerritCommitMsgHookCheck_custom_hook(self):
2428 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002429 self.calls += [((['exists',
2430 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2431 ((['FileRead',
2432 os.path.join('.git', 'hooks', 'commit-msg')], ),
2433 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002434 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002435
2436 def test_GerritCommitMsgHookCheck_not_exists(self):
2437 cl = self._common_GerritCommitMsgHookCheck()
2438 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002439 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002440 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002441 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002442
2443 def test_GerritCommitMsgHookCheck(self):
2444 cl = self._common_GerritCommitMsgHookCheck()
2445 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002446 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2447 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002448 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002449 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002450 ((['rm_file_or_tree',
2451 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002452 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002453 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002454
tandriic4344b52016-08-29 06:04:54 -07002455 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002456 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2457 self.mockGit.config['branch.master.gerritserver'] = (
2458 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002459 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002460 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002461 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002462 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002463 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002464 'labels': {},
2465 'current_revision': 'deadbeaf',
2466 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002467 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002468 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002469 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002470 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2471 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002472 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002473 self.assertEqual(0, cl.CMDLand(force=True,
2474 bypass_hooks=True,
2475 verbose=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002476 parallel=False,
2477 resultdb=False,
2478 realm=None))
Edward Lemur73c76702020-02-06 23:57:18 +00002479 self.assertIn(
2480 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002481 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002482 self.assertIn(
2483 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002484 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002485
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002486 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002487 mock.patch('git_cl.Changelist.GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002488
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002489 def test_gerrit_change_detail_cache_simple(self):
2490 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002491 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002492 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002493 cl1._cached_remote_url = (
2494 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002495 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002496 cl2._cached_remote_url = (
2497 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002498 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2499 self.assertEqual(cl1._GetChangeDetail(), 'a')
2500 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002501
2502 def test_gerrit_change_detail_cache_options(self):
2503 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002504 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002505 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002506 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002507 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2508 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2509 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2510 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2511 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2512 self.assertEqual(cl._GetChangeDetail(), 'cab')
2513
2514 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2515 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2516 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2517 self.assertEqual(cl._GetChangeDetail(), 'cab')
2518
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002519 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002520 gerrit_util.GetChangeDetail.return_value = {
2521 'current_revision': 'rev1',
2522 'revisions': {
2523 'rev1': {'commit': {'message': 'desc1'}},
2524 },
2525 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002526
2527 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002528 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002529 cl._cached_remote_url = (
2530 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002531 self.assertEqual(cl.FetchDescription(), 'desc1')
2532 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002533
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002534 def test_print_current_creds(self):
2535 class CookiesAuthenticatorMock(object):
2536 def __init__(self):
2537 self.gitcookies = {
2538 'host.googlesource.com': ('user', 'pass'),
2539 'host-review.googlesource.com': ('user', 'pass'),
2540 }
2541 self.netrc = self
2542 self.netrc.hosts = {
2543 'github.com': ('user2', None, 'pass2'),
2544 'host2.googlesource.com': ('user3', None, 'pass'),
2545 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002546 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2547 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002548 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2549 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2550 ' Host\t User\t Which file',
2551 '============================\t=====\t===========',
2552 'host-review.googlesource.com\t user\t.gitcookies',
2553 ' host.googlesource.com\t user\t.gitcookies',
2554 ' host2.googlesource.com\tuser3\t .netrc',
2555 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002556 sys.stdout.seek(0)
2557 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002558 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2559 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2560 ' Host\tUser\t Which file',
2561 '============================\t====\t===========',
2562 'host-review.googlesource.com\tuser\t.gitcookies',
2563 ' host.googlesource.com\tuser\t.gitcookies',
2564 ])
2565
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002566 def _common_creds_check_mocks(self):
2567 def exists_mock(path):
2568 dirname = os.path.dirname(path)
2569 if dirname == os.path.expanduser('~'):
2570 dirname = '~'
2571 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002572 if base in (NETRC_FILENAME, '.gitcookies'):
2573 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002574 # git cl also checks for existence other files not relevant to this test.
2575 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002576 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002577 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002578 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002579 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002580
2581 def test_creds_check_gitcookies_not_configured(self):
2582 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002583 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2584 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002585 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002586 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2587 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2588 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2589 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2590 'or Ctrl+C to abort'), ''),
2591 (([
2592 'git', 'config', '--global', 'http.cookiefile',
2593 os.path.expanduser(os.path.join('~', '.gitcookies'))
2594 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002595 ]
2596 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002597 self.assertTrue(
2598 sys.stdout.getvalue().startswith(
2599 'You seem to be using outdated .netrc for git credentials:'))
2600 self.assertIn(
2601 '\nConfigured git to use .gitcookies from',
2602 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002603
2604 def test_creds_check_gitcookies_configured_custom_broken(self):
2605 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002606 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2607 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002608 custom_cookie_path = ('C:\\.gitcookies'
2609 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002610 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002611 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2612 ((['git', 'config', '--global', 'http.cookiefile'], ),
2613 custom_cookie_path),
2614 (('os.path.exists', custom_cookie_path), False),
2615 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2616 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2617 (([
2618 'git', 'config', '--global', 'http.cookiefile',
2619 os.path.expanduser(os.path.join('~', '.gitcookies'))
2620 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002621 ]
2622 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002623 self.assertIn(
2624 'WARNING: You have configured custom path to .gitcookies: ',
2625 sys.stdout.getvalue())
2626 self.assertIn(
2627 'However, your configured .gitcookies file is missing.',
2628 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002629
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002630 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002631 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002632 self.mockGit.config['remote.origin.url'] = (
2633 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002634 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002635 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002636 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002637 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002638 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002639 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002640
Edward Lemurda4b6c62020-02-13 00:28:40 +00002641 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2642 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002643 self.mockGit.config['remote.origin.url'] = (
2644 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002645 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002646 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002647 'current_revision': 'ba5eba11',
2648 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002649 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002650 '_number': 1,
2651 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002652 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002653 '_number': 2,
2654 },
2655 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002656 'messages': [
2657 {
2658 u'_revision_number': 1,
2659 u'author': {
2660 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002661 u'email': u'could-be-anything@example.com',
2662 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002663 },
2664 u'date': u'2017-03-15 20:08:45.000000000',
2665 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002666 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002667 u'tag': u'autogenerated:cq:dry-run'
2668 },
2669 {
2670 u'_revision_number': 2,
2671 u'author': {
2672 u'_account_id': 11151243,
2673 u'email': u'owner@example.com',
2674 u'name': u'owner'
2675 },
2676 u'date': u'2017-03-16 20:00:41.000000000',
2677 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2678 u'message': u'PTAL',
2679 },
2680 {
2681 u'_revision_number': 2,
2682 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002683 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002684 u'email': u'reviewer@example.com',
2685 u'name': u'reviewer'
2686 },
2687 u'date': u'2017-03-17 05:19:37.500000000',
2688 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2689 u'message': u'Patch Set 2: Code-Review+1',
2690 },
2691 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002692 }
2693 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002694 (('GetChangeComments', 'chromium-review.googlesource.com',
2695 'infra%2Finfra~1'), {
2696 '/COMMIT_MSG': [
2697 {
2698 'author': {
2699 'email': u'reviewer@example.com'
2700 },
2701 'updated': u'2017-03-17 05:19:37.500000000',
2702 'patch_set': 2,
2703 'side': 'REVISION',
2704 'message': 'Please include a bug link',
2705 },
2706 ],
2707 'codereview.settings': [
2708 {
2709 'author': {
2710 'email': u'owner@example.com'
2711 },
2712 'updated': u'2017-03-16 20:00:41.000000000',
2713 'patch_set': 2,
2714 'side': 'PARENT',
2715 'line': 42,
2716 'message': 'I removed this because it is bad',
2717 },
2718 ]
2719 }),
2720 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2721 'infra%2Finfra~1'), {}),
2722 ] * 2 + [(('write_json', 'output.json', [{
2723 u'date':
2724 u'2017-03-16 20:00:41.000000',
2725 u'message': (u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2726 u' Base, Line 42: https://crrev.com/c/1/2/'
2727 u'codereview.settings#b42\n' +
2728 u' I removed this because it is bad\n'),
2729 u'autogenerated':
2730 False,
2731 u'approval':
2732 False,
2733 u'disapproval':
2734 False,
2735 u'sender':
2736 u'owner@example.com'
2737 }, {
2738 u'date':
2739 u'2017-03-17 05:19:37.500000',
2740 u'message':
2741 (u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2742 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
2743 u' Please include a bug link\n'),
2744 u'autogenerated':
2745 False,
2746 u'approval':
2747 False,
2748 u'disapproval':
2749 False,
2750 u'sender':
2751 u'reviewer@example.com'
2752 }]), '')]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002753 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002754 git_cl._CommentSummary(
2755 message=(u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2756 u' Base, Line 42: https://crrev.com/c/1/2/' +
2757 u'codereview.settings#b42\n' +
2758 u' I removed this because it is bad\n'),
2759 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2760 autogenerated=False,
2761 disapproval=False,
2762 approval=False,
2763 sender=u'owner@example.com'),
2764 git_cl._CommentSummary(message=(
2765 u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2766 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002767 u' Please include a bug link\n'),
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002768 date=datetime.datetime(2017, 3, 17, 5, 19, 37,
2769 500000),
2770 autogenerated=False,
2771 disapproval=False,
2772 approval=False,
2773 sender=u'reviewer@example.com'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002774 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002775 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002776 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002777 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002778 self.assertEqual(
2779 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2780
2781 def test_git_cl_comments_robot_comments(self):
2782 # git cl comments also fetches robot comments (which are considered a type
2783 # of autogenerated comment), and unlike other types of comments, only robot
2784 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002785 self.mockGit.config['remote.origin.url'] = (
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002786 'https://x.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002787 gerrit_util.GetChangeDetail.return_value = {
2788 'owner': {'email': 'owner@example.com'},
2789 'current_revision': 'ba5eba11',
2790 'revisions': {
2791 'deadbeaf': {
2792 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002793 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002794 'ba5eba11': {
2795 '_number': 2,
2796 },
2797 },
2798 'messages': [
2799 {
2800 u'_revision_number': 1,
2801 u'author': {
2802 u'_account_id': 1111084,
2803 u'email': u'commit-bot@chromium.org',
2804 u'name': u'Commit Bot'
2805 },
2806 u'date': u'2017-03-15 20:08:45.000000000',
2807 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2808 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2809 u'tag': u'autogenerated:cq:dry-run'
2810 },
2811 {
2812 u'_revision_number': 1,
2813 u'author': {
2814 u'_account_id': 123,
2815 u'email': u'tricium@serviceaccount.com',
2816 u'name': u'Tricium'
2817 },
2818 u'date': u'2017-03-16 20:00:41.000000000',
2819 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2820 u'message': u'(1 comment)',
2821 u'tag': u'autogenerated:tricium',
2822 },
2823 {
2824 u'_revision_number': 1,
2825 u'author': {
2826 u'_account_id': 123,
2827 u'email': u'tricium@serviceaccount.com',
2828 u'name': u'Tricium'
2829 },
2830 u'date': u'2017-03-16 20:00:41.000000000',
2831 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2832 u'message': u'(1 comment)',
2833 u'tag': u'autogenerated:tricium',
2834 },
2835 {
2836 u'_revision_number': 2,
2837 u'author': {
2838 u'_account_id': 123,
2839 u'email': u'tricium@serviceaccount.com',
2840 u'name': u'reviewer'
2841 },
2842 u'date': u'2017-03-17 05:30:37.000000000',
2843 u'tag': u'autogenerated:tricium',
2844 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2845 u'message': u'(1 comment)',
2846 },
2847 ]
2848 }
2849 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002850 (('GetChangeComments', 'x-review.googlesource.com', 'infra%2Finfra~1'),
2851 {}),
2852 (('GetChangeRobotComments', 'x-review.googlesource.com',
2853 'infra%2Finfra~1'), {
2854 'codereview.settings': [
2855 {
2856 u'author': {
2857 u'email': u'tricium@serviceaccount.com'
2858 },
2859 u'updated': u'2017-03-17 05:30:37.000000000',
2860 u'robot_run_id': u'5565031076855808',
2861 u'robot_id': u'Linter/Category',
2862 u'tag': u'autogenerated:tricium',
2863 u'patch_set': 2,
2864 u'side': u'REVISION',
2865 u'message': u'Linter warning message text',
2866 u'line': 32,
2867 },
2868 ],
2869 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002870 ]
2871 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002872 git_cl._CommentSummary(
2873 date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2874 message=(u'(1 comment)\n\ncodereview.settings\n'
2875 u' PS2, Line 32: https://x-review.googlesource.com/c/1/2/'
2876 u'codereview.settings#32\n'
2877 u' Linter warning message text\n'),
2878 sender=u'tricium@serviceaccount.com',
2879 autogenerated=True,
2880 approval=False,
2881 disapproval=False)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002882 ]
2883 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002884 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002885 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002886
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002887 def test_get_remote_url_with_mirror(self):
2888 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002889
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002890 def selective_os_path_isdir_mock(path):
2891 if path == '/cache/this-dir-exists':
2892 return self._mocked_call('os.path.isdir', path)
2893 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002894
Edward Lemurda4b6c62020-02-13 00:28:40 +00002895 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002896
2897 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002898 self.mockGit.config['remote.origin.url'] = (
2899 '/cache/this-dir-exists')
2900 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2901 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002902 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002903 (('os.path.isdir', '/cache/this-dir-exists'),
2904 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002905 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002906 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002907 self.assertEqual(cl.GetRemoteUrl(), url)
2908 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2909
Edward Lemur298f2cf2019-02-22 21:40:39 +00002910 def test_get_remote_url_non_existing_mirror(self):
2911 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002912
Edward Lemur298f2cf2019-02-22 21:40:39 +00002913 def selective_os_path_isdir_mock(path):
2914 if path == '/cache/this-dir-doesnt-exist':
2915 return self._mocked_call('os.path.isdir', path)
2916 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002917
Edward Lemurda4b6c62020-02-13 00:28:40 +00002918 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2919 mock.patch('logging.error',
2920 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002921
Edward Lemur26964072020-02-19 19:18:51 +00002922 self.mockGit.config['remote.origin.url'] = (
2923 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002924 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002925 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2926 False),
2927 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002928 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2929 'but it doesn\'t exist.', {
2930 'remote': 'origin',
2931 'branch': 'master',
2932 'url': '/cache/this-dir-doesnt-exist'}
2933 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002934 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002935 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002936 self.assertIsNone(cl.GetRemoteUrl())
2937
2938 def test_get_remote_url_misconfigured_mirror(self):
2939 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002940
Edward Lemur298f2cf2019-02-22 21:40:39 +00002941 def selective_os_path_isdir_mock(path):
2942 if path == '/cache/this-dir-exists':
2943 return self._mocked_call('os.path.isdir', path)
2944 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002945
Edward Lemurda4b6c62020-02-13 00:28:40 +00002946 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2947 mock.patch('logging.error',
2948 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002949
Edward Lemur26964072020-02-19 19:18:51 +00002950 self.mockGit.config['remote.origin.url'] = (
2951 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002952 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002953 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002954 (('logging.error',
2955 'Remote "%(remote)s" for branch "%(branch)s" points to '
2956 '"%(cache_path)s", but it is misconfigured.\n'
2957 '"%(cache_path)s" must be a git repo and must have a remote named '
2958 '"%(remote)s" pointing to the git host.', {
2959 'remote': 'origin',
2960 'cache_path': '/cache/this-dir-exists',
2961 'branch': 'master'}
2962 ), None),
2963 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002964 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002965 self.assertIsNone(cl.GetRemoteUrl())
2966
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002967 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002968 self.mockGit.config['remote.origin.url'] = (
2969 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002970 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002971 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2972
2973 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002974 mock.patch('logging.error',
2975 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002976
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002977 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002978 (('logging.error',
2979 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2980 'but it doesn\'t exist.', {
2981 'remote': 'origin',
2982 'branch': 'master',
2983 'url': ''}
2984 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002985 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002986 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002987 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002988
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002989 def test_gerrit_new_default(self):
2990 self._run_gerrit_upload_test(
2991 [],
2992 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
2993 [],
2994 squash=False,
2995 squash_mode='override_nosquash',
2996 change_id='I123456789',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002997 default_branch='main')
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002998
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002999
Edward Lemur9aa1a962020-02-25 00:58:38 +00003000class ChangelistTest(unittest.TestCase):
mlcui3da91712021-05-05 10:00:30 +00003001 LAST_COMMIT_SUBJECT = 'Fixes goat teleporter destination to be Australia'
3002
3003 def _mock_run_git(commands):
3004 if commands == ['show', '-s', '--format=%s', 'HEAD']:
3005 return ChangelistTest.LAST_COMMIT_SUBJECT
3006
Edward Lemur227d5102020-02-25 23:45:35 +00003007 def setUp(self):
3008 super(ChangelistTest, self).setUp()
3009 mock.patch('gclient_utils.FileRead').start()
3010 mock.patch('gclient_utils.FileWrite').start()
3011 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
3012 mock.patch(
3013 'git_cl.Changelist.GetCodereviewServer',
3014 return_value='https://chromium-review.googlesource.com').start()
3015 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
3016 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
3017 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003018 mock.patch(
3019 'git_cl.Changelist.GetRemoteBranch',
3020 return_value=('origin', 'refs/remotes/origin/main')).start()
Edward Lemur227d5102020-02-25 23:45:35 +00003021 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
3022 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
3023 mock.patch('git_cl.time_time').start()
3024 mock.patch('metrics.collector').start()
3025 mock.patch('subprocess2.Popen').start()
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003026 mock.patch(
3027 'git_cl.Changelist.GetGerritProject', return_value='project').start()
Edward Lemur227d5102020-02-25 23:45:35 +00003028 self.addCleanup(mock.patch.stopall)
3029 self.temp_count = 0
3030
Edward Lemur227d5102020-02-25 23:45:35 +00003031 def testRunHook(self):
3032 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003033 'more_cc': ['cc@example.com', 'more@example.com'],
3034 'errors': [],
3035 'notifications': [],
3036 'warnings': [],
Edward Lemur227d5102020-02-25 23:45:35 +00003037 }
3038 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003039 git_cl.time_time.side_effect = [100, 200, 300, 400]
Edward Lemur227d5102020-02-25 23:45:35 +00003040 mockProcess = mock.Mock()
3041 mockProcess.wait.return_value = 0
3042 subprocess2.Popen.return_value = mockProcess
3043
3044 cl = git_cl.Changelist()
3045 results = cl.RunHook(
3046 committing=True,
3047 may_prompt=True,
3048 verbose=2,
3049 parallel=True,
3050 upstream='upstream',
3051 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003052 all_files=True,
3053 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003054
3055 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003056 subprocess2.Popen.assert_any_call([
Edward Lemur227d5102020-02-25 23:45:35 +00003057 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00003058 '--root', 'root',
3059 '--upstream', 'upstream',
3060 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00003061 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003062 '--gerrit_project', 'project',
3063 '--gerrit_branch', 'refs/heads/main',
3064 '--author', 'author',
Edward Lemur227d5102020-02-25 23:45:35 +00003065 '--issue', '123456',
3066 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003067 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00003068 '--may_prompt',
3069 '--parallel',
3070 '--all_files',
3071 '--json_output', '/tmp/fake-temp2',
3072 '--description_file', '/tmp/fake-temp1',
3073 ])
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003074 subprocess2.Popen.assert_any_call([
3075 'vpython3', 'PRESUBMIT_SUPPORT',
3076 '--root', 'root',
3077 '--upstream', 'upstream',
3078 '--verbose', '--verbose',
3079 '--gerrit_url', 'https://chromium-review.googlesource.com',
3080 '--gerrit_project', 'project',
3081 '--gerrit_branch', 'refs/heads/main',
3082 '--author', 'author',
3083 '--issue', '123456',
3084 '--patchset', '7',
3085 '--commit',
3086 '--may_prompt',
3087 '--parallel',
3088 '--all_files',
3089 '--json_output', '/tmp/fake-temp4',
3090 '--description_file', '/tmp/fake-temp3',
3091 ])
3092 gclient_utils.FileWrite.assert_any_call(
Edward Lemur1a83da12020-03-04 21:18:36 +00003093 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00003094 metrics.collector.add_repeated('sub_commands', {
3095 'command': 'presubmit',
3096 'execution_time': 100,
3097 'exit_code': 0,
3098 })
3099
Edward Lemur99df04e2020-03-05 19:39:43 +00003100 def testRunHook_FewerOptions(self):
3101 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003102 'more_cc': ['cc@example.com', 'more@example.com'],
3103 'errors': [],
3104 'notifications': [],
3105 'warnings': [],
Edward Lemur99df04e2020-03-05 19:39:43 +00003106 }
3107 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003108 git_cl.time_time.side_effect = [100, 200, 300, 400]
Edward Lemur99df04e2020-03-05 19:39:43 +00003109 mockProcess = mock.Mock()
3110 mockProcess.wait.return_value = 0
3111 subprocess2.Popen.return_value = mockProcess
3112
3113 git_cl.Changelist.GetAuthor.return_value = None
3114 git_cl.Changelist.GetIssue.return_value = None
3115 git_cl.Changelist.GetPatchset.return_value = None
Edward Lemur99df04e2020-03-05 19:39:43 +00003116
3117 cl = git_cl.Changelist()
3118 results = cl.RunHook(
3119 committing=False,
3120 may_prompt=False,
3121 verbose=0,
3122 parallel=False,
3123 upstream='upstream',
3124 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003125 all_files=False,
3126 resultdb=False)
Edward Lemur99df04e2020-03-05 19:39:43 +00003127
3128 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003129 subprocess2.Popen.assert_any_call([
Edward Lemur99df04e2020-03-05 19:39:43 +00003130 'vpython', 'PRESUBMIT_SUPPORT',
3131 '--root', 'root',
3132 '--upstream', 'upstream',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003133 '--gerrit_url', 'https://chromium-review.googlesource.com',
3134 '--gerrit_project', 'project',
3135 '--gerrit_branch', 'refs/heads/main',
Edward Lemur99df04e2020-03-05 19:39:43 +00003136 '--upload',
3137 '--json_output', '/tmp/fake-temp2',
3138 '--description_file', '/tmp/fake-temp1',
3139 ])
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003140 gclient_utils.FileWrite.assert_any_call(
Edward Lemur99df04e2020-03-05 19:39:43 +00003141 '/tmp/fake-temp1', 'description')
3142 metrics.collector.add_repeated('sub_commands', {
3143 'command': 'presubmit',
3144 'execution_time': 100,
3145 'exit_code': 0,
3146 })
3147
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003148 def testRunHook_FewerOptionsResultDB(self):
3149 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003150 'more_cc': ['cc@example.com', 'more@example.com'],
3151 'errors': [],
3152 'notifications': [],
3153 'warnings': [],
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003154 }
3155 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003156 git_cl.time_time.side_effect = [100, 200, 300, 400]
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003157 mockProcess = mock.Mock()
3158 mockProcess.wait.return_value = 0
3159 subprocess2.Popen.return_value = mockProcess
3160
3161 git_cl.Changelist.GetAuthor.return_value = None
3162 git_cl.Changelist.GetIssue.return_value = None
3163 git_cl.Changelist.GetPatchset.return_value = None
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003164
3165 cl = git_cl.Changelist()
3166 results = cl.RunHook(
3167 committing=False,
3168 may_prompt=False,
3169 verbose=0,
3170 parallel=False,
3171 upstream='upstream',
3172 description='description',
3173 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003174 resultdb=True,
3175 realm='chromium:public')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003176
3177 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003178 subprocess2.Popen.assert_any_call([
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003179 'rdb', 'stream', '-new', '-realm', 'chromium:public', '--',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003180 'vpython', 'PRESUBMIT_SUPPORT',
3181 '--root', 'root',
3182 '--upstream', 'upstream',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003183 '--gerrit_url', 'https://chromium-review.googlesource.com',
3184 '--gerrit_project', 'project',
3185 '--gerrit_branch', 'refs/heads/main',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003186 '--upload',
3187 '--json_output', '/tmp/fake-temp2',
3188 '--description_file', '/tmp/fake-temp1',
3189 ])
3190
Edward Lemur227d5102020-02-25 23:45:35 +00003191 @mock.patch('sys.exit', side_effect=SystemExitMock)
3192 def testRunHook_Failure(self, _mock):
3193 git_cl.time_time.side_effect = [100, 200]
3194 mockProcess = mock.Mock()
3195 mockProcess.wait.return_value = 2
3196 subprocess2.Popen.return_value = mockProcess
3197
3198 cl = git_cl.Changelist()
3199 with self.assertRaises(SystemExitMock):
3200 cl.RunHook(
3201 committing=True,
3202 may_prompt=True,
3203 verbose=2,
3204 parallel=True,
3205 upstream='upstream',
3206 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003207 all_files=True,
3208 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003209
3210 sys.exit.assert_called_once_with(2)
3211
Edward Lemur75526302020-02-27 22:31:05 +00003212 def testRunPostUploadHook(self):
3213 cl = git_cl.Changelist()
3214 cl.RunPostUploadHook(2, 'upstream', 'description')
3215
3216 subprocess2.Popen.assert_called_once_with([
3217 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00003218 '--root', 'root',
3219 '--upstream', 'upstream',
3220 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00003221 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003222 '--gerrit_project', 'project',
3223 '--gerrit_branch', 'refs/heads/main',
3224 '--author', 'author',
Edward Lemur75526302020-02-27 22:31:05 +00003225 '--issue', '123456',
3226 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003227 '--post_upload',
3228 '--description_file', '/tmp/fake-temp1',
3229 ])
3230 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00003231 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00003232
mlcui3da91712021-05-05 10:00:30 +00003233 @mock.patch('git_cl.RunGit', _mock_run_git)
3234 def testDefaultTitleEmptyMessage(self):
3235 cl = git_cl.Changelist()
3236 cl.issue = 100
3237 options = optparse.Values({
3238 'squash': True,
3239 'title': None,
3240 'message': None,
3241 'force': None,
3242 'skip_title': None
3243 })
3244
3245 mock.patch('gclient_utils.AskForData', lambda _: user_title).start()
3246 for user_title in ['', 'y', 'Y']:
3247 self.assertEqual(cl._GetTitleForUpload(options), self.LAST_COMMIT_SUBJECT)
3248
3249 for user_title in ['not empty', 'yes', 'YES']:
3250 self.assertEqual(cl._GetTitleForUpload(options), user_title)
3251
Edward Lemur9aa1a962020-02-25 00:58:38 +00003252
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003253class CMDTestCaseBase(unittest.TestCase):
3254 _STATUSES = [
3255 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3256 'INFRA_FAILURE', 'CANCELED',
3257 ]
3258 _CHANGE_DETAIL = {
3259 'project': 'depot_tools',
3260 'status': 'OPEN',
3261 'owner': {'email': 'owner@e.mail'},
3262 'current_revision': 'beeeeeef',
3263 'revisions': {
Gavin Make61ccc52020-11-13 00:12:57 +00003264 'deadbeaf': {
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003265 '_number': 6,
Gavin Make61ccc52020-11-13 00:12:57 +00003266 'kind': 'REWORK',
3267 },
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003268 'beeeeeef': {
3269 '_number': 7,
Gavin Make61ccc52020-11-13 00:12:57 +00003270 'kind': 'NO_CODE_CHANGE',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003271 'fetch': {'http': {
3272 'url': 'https://chromium.googlesource.com/depot_tools',
3273 'ref': 'refs/changes/56/123456/7'
3274 }},
3275 },
3276 },
3277 }
3278 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003279 'builds': [{
3280 'id': str(100 + idx),
3281 'builder': {
3282 'project': 'chromium',
3283 'bucket': 'try',
3284 'builder': 'bot_' + status.lower(),
3285 },
3286 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3287 'tags': [],
3288 'status': status,
3289 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003290 }
3291
Edward Lemur4c707a22019-09-24 21:13:43 +00003292 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003293 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003294 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003295 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3296 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003297 mock.patch(
3298 'git_cl.Changelist.GetCodereviewServer',
3299 return_value='https://chromium-review.googlesource.com').start()
3300 mock.patch(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00003301 'git_cl.Changelist.GetGerritHost',
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003302 return_value='chromium-review.googlesource.com').start()
3303 mock.patch(
3304 'git_cl.Changelist.GetMostRecentPatchset',
3305 return_value=7).start()
3306 mock.patch(
Gavin Make61ccc52020-11-13 00:12:57 +00003307 'git_cl.Changelist.GetMostRecentDryRunPatchset',
3308 return_value=6).start()
3309 mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003310 'git_cl.Changelist.GetRemoteUrl',
3311 return_value='https://chromium.googlesource.com/depot_tools').start()
3312 mock.patch(
3313 'auth.Authenticator',
3314 return_value=AuthenticatorMock()).start()
3315 mock.patch(
3316 'gerrit_util.GetChangeDetail',
3317 return_value=self._CHANGE_DETAIL).start()
3318 mock.patch(
3319 'git_cl._call_buildbucket',
3320 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003321 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003322 self.addCleanup(mock.patch.stopall)
3323
Edward Lemur4c707a22019-09-24 21:13:43 +00003324
Edward Lemur9468eba2020-02-27 19:07:22 +00003325class CMDPresubmitTestCase(CMDTestCaseBase):
3326 def setUp(self):
3327 super(CMDPresubmitTestCase, self).setUp()
3328 mock.patch(
3329 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3330 return_value='upstream').start()
3331 mock.patch(
3332 'git_cl.Changelist.FetchDescription',
3333 return_value='fetch description').start()
3334 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00003335 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00003336 return_value='get description').start()
3337 mock.patch('git_cl.Changelist.RunHook').start()
3338
3339 def testDefaultCase(self):
3340 self.assertEqual(0, git_cl.main(['presubmit']))
3341 git_cl.Changelist.RunHook.assert_called_once_with(
3342 committing=True,
3343 may_prompt=False,
3344 verbose=0,
3345 parallel=None,
3346 upstream='upstream',
3347 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003348 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003349 resultdb=None,
3350 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003351
3352 def testNoIssue(self):
3353 git_cl.Changelist.GetIssue.return_value = None
3354 self.assertEqual(0, git_cl.main(['presubmit']))
3355 git_cl.Changelist.RunHook.assert_called_once_with(
3356 committing=True,
3357 may_prompt=False,
3358 verbose=0,
3359 parallel=None,
3360 upstream='upstream',
3361 description='get description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003362 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003363 resultdb=None,
3364 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003365
3366 def testCustomBranch(self):
3367 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3368 git_cl.Changelist.RunHook.assert_called_once_with(
3369 committing=True,
3370 may_prompt=False,
3371 verbose=0,
3372 parallel=None,
3373 upstream='custom_branch',
3374 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003375 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003376 resultdb=None,
3377 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003378
3379 def testOptions(self):
3380 self.assertEqual(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003381 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003382 '--resultdb', '--realm', 'chromium:public']))
Edward Lemur9468eba2020-02-27 19:07:22 +00003383 git_cl.Changelist.RunHook.assert_called_once_with(
3384 committing=False,
3385 may_prompt=False,
3386 verbose=2,
3387 parallel=True,
3388 upstream='upstream',
3389 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003390 all_files=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003391 resultdb=True,
3392 realm='chromium:public')
Edward Lemur9468eba2020-02-27 19:07:22 +00003393
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003394class CMDTryResultsTestCase(CMDTestCaseBase):
3395 _DEFAULT_REQUEST = {
3396 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003397 "gerritChanges": [{
3398 "project": "depot_tools",
3399 "host": "chromium-review.googlesource.com",
Gavin Make61ccc52020-11-13 00:12:57 +00003400 "patchset": 6,
3401 "change": 123456,
3402 }],
3403 },
3404 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3405 ',builds.*.createTime,builds.*.tags'),
3406 }
3407
3408 _TRIVIAL_REQUEST = {
3409 'predicate': {
3410 "gerritChanges": [{
3411 "project": "depot_tools",
3412 "host": "chromium-review.googlesource.com",
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003413 "patchset": 7,
3414 "change": 123456,
3415 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003416 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003417 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3418 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003419 }
3420
3421 def testNoJobs(self):
3422 git_cl._call_buildbucket.return_value = {}
3423
3424 self.assertEqual(0, git_cl.main(['try-results']))
3425 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3426 git_cl._call_buildbucket.assert_called_once_with(
3427 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3428 self._DEFAULT_REQUEST)
3429
Gavin Make61ccc52020-11-13 00:12:57 +00003430 def testTrivialCommits(self):
3431 self.assertEqual(0, git_cl.main(['try-results']))
3432 git_cl._call_buildbucket.assert_called_with(
3433 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3434 self._DEFAULT_REQUEST)
3435
3436 git_cl._call_buildbucket.return_value = {}
3437 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '7']))
3438 git_cl._call_buildbucket.assert_called_with(
3439 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3440 self._TRIVIAL_REQUEST)
3441 self.assertEqual([
3442 'Successes:',
3443 ' bot_success https://ci.chromium.org/b/103',
3444 'Infra Failures:',
3445 ' bot_infra_failure https://ci.chromium.org/b/105',
3446 'Failures:',
3447 ' bot_failure https://ci.chromium.org/b/104',
3448 'Canceled:',
3449 ' bot_canceled ',
3450 'Started:',
3451 ' bot_started https://ci.chromium.org/b/102',
3452 'Scheduled:',
3453 ' bot_scheduled id=101',
3454 'Other:',
3455 ' bot_status_unspecified id=100',
3456 'Total: 7 tryjobs',
3457 'No tryjobs scheduled.',
3458 ], sys.stdout.getvalue().splitlines())
3459
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003460 def testPrintToStdout(self):
3461 self.assertEqual(0, git_cl.main(['try-results']))
3462 self.assertEqual([
3463 'Successes:',
3464 ' bot_success https://ci.chromium.org/b/103',
3465 'Infra Failures:',
3466 ' bot_infra_failure https://ci.chromium.org/b/105',
3467 'Failures:',
3468 ' bot_failure https://ci.chromium.org/b/104',
3469 'Canceled:',
3470 ' bot_canceled ',
3471 'Started:',
3472 ' bot_started https://ci.chromium.org/b/102',
3473 'Scheduled:',
3474 ' bot_scheduled id=101',
3475 'Other:',
3476 ' bot_status_unspecified id=100',
3477 'Total: 7 tryjobs',
3478 ], sys.stdout.getvalue().splitlines())
3479 git_cl._call_buildbucket.assert_called_once_with(
3480 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3481 self._DEFAULT_REQUEST)
3482
3483 def testPrintToStdoutWithMasters(self):
3484 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3485 self.assertEqual([
3486 'Successes:',
3487 ' try bot_success https://ci.chromium.org/b/103',
3488 'Infra Failures:',
3489 ' try bot_infra_failure https://ci.chromium.org/b/105',
3490 'Failures:',
3491 ' try bot_failure https://ci.chromium.org/b/104',
3492 'Canceled:',
3493 ' try bot_canceled ',
3494 'Started:',
3495 ' try bot_started https://ci.chromium.org/b/102',
3496 'Scheduled:',
3497 ' try bot_scheduled id=101',
3498 'Other:',
3499 ' try bot_status_unspecified id=100',
3500 'Total: 7 tryjobs',
3501 ], sys.stdout.getvalue().splitlines())
3502 git_cl._call_buildbucket.assert_called_once_with(
3503 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3504 self._DEFAULT_REQUEST)
3505
3506 @mock.patch('git_cl.write_json')
3507 def testWriteToJson(self, mockJsonDump):
3508 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3509 git_cl._call_buildbucket.assert_called_once_with(
3510 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3511 self._DEFAULT_REQUEST)
3512 mockJsonDump.assert_called_once_with(
3513 'file.json', self._DEFAULT_RESPONSE['builds'])
3514
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003515 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003516 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3517 self.assertEqual(
3518 [
3519 ('chromium', 'try', 'bot_failure'),
3520 ('chromium', 'try', 'bot_infra_failure'),
3521 ],
3522 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003523
3524 def test_filter_failed_for_retry_many_builds(self):
3525
3526 def _build(name, created_sec, status, experimental=False):
3527 assert 0 <= created_sec < 100, created_sec
3528 b = {
3529 'id': 112112,
3530 'builder': {
3531 'project': 'chromium',
3532 'bucket': 'try',
3533 'builder': name,
3534 },
3535 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3536 'status': status,
3537 'tags': [],
3538 }
3539 if experimental:
3540 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3541 return b
3542
3543 builds = [
3544 _build('flaky-last-green', 1, 'FAILURE'),
3545 _build('flaky-last-green', 2, 'SUCCESS'),
3546 _build('flaky', 1, 'SUCCESS'),
3547 _build('flaky', 2, 'FAILURE'),
3548 _build('running', 1, 'FAILED'),
3549 _build('running', 2, 'SCHEDULED'),
3550 _build('yep-still-running', 1, 'STARTED'),
3551 _build('yep-still-running', 2, 'FAILURE'),
3552 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3553 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3554
3555 # Simulate experimental in CQ builder, which developer decided
3556 # to retry manually which resulted in 2nd build non-experimental.
3557 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3558 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3559 ]
3560 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003561 self.assertEqual(
3562 [
3563 ('chromium', 'try', 'flaky'),
3564 ('chromium', 'try', 'sometimes-experimental'),
3565 ],
3566 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003567
3568
3569class CMDTryTestCase(CMDTestCaseBase):
3570
3571 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003572 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003573 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003574 self.assertEqual(0, git_cl.main(['try']))
3575 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3576 self.assertEqual(
3577 sys.stdout.getvalue(),
3578 'Scheduling CQ dry run on: '
3579 'https://chromium-review.googlesource.com/123456\n')
3580
Edward Lemur4c707a22019-09-24 21:13:43 +00003581 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003582 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003583 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003584
3585 self.assertEqual(0, git_cl.main([
3586 'try', '-B', 'luci.chromium.try', '-b', 'win',
3587 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3588 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003589 'Scheduling jobs on:\n'
3590 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003591 git_cl.sys.stdout.getvalue())
3592
3593 expected_request = {
3594 "requests": [{
3595 "scheduleBuild": {
3596 "requestId": "uuid4",
3597 "builder": {
3598 "project": "chromium",
3599 "builder": "win",
3600 "bucket": "try",
3601 },
3602 "gerritChanges": [{
3603 "project": "depot_tools",
3604 "host": "chromium-review.googlesource.com",
3605 "patchset": 7,
3606 "change": 123456,
3607 }],
3608 "properties": {
3609 "category": "git_cl_try",
3610 "json": [{"a": 1}, None],
3611 "key": "val",
3612 },
3613 "tags": [
3614 {"value": "win", "key": "builder"},
3615 {"value": "git_cl_try", "key": "user_agent"},
3616 ],
3617 },
3618 }],
3619 }
3620 mockCallBuildbucket.assert_called_with(
3621 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3622
Anthony Polito1a5fe232020-01-24 23:17:52 +00003623 @mock.patch('git_cl._call_buildbucket')
3624 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3625 mockCallBuildbucket.return_value = {}
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003626 mock.patch('git_cl.Changelist.GetRemoteBranch',
3627 return_value=('origin', 'refs/remotes/origin/main')).start()
Anthony Polito1a5fe232020-01-24 23:17:52 +00003628
3629 self.assertEqual(0, git_cl.main([
3630 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3631 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3632 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3633 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003634 'Scheduling jobs on:\n'
3635 ' chromium/try: linux\n'
3636 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003637 git_cl.sys.stdout.getvalue())
3638
3639 expected_request = {
3640 "requests": [{
3641 "scheduleBuild": {
3642 "requestId": "uuid4",
3643 "builder": {
3644 "project": "chromium",
3645 "builder": "linux",
3646 "bucket": "try",
3647 },
3648 "gerritChanges": [{
3649 "project": "depot_tools",
3650 "host": "chromium-review.googlesource.com",
3651 "patchset": 7,
3652 "change": 123456,
3653 }],
3654 "properties": {
3655 "category": "git_cl_try",
3656 "json": [{"a": 1}, None],
3657 "key": "val",
3658 },
3659 "tags": [
3660 {"value": "linux", "key": "builder"},
3661 {"value": "git_cl_try", "key": "user_agent"},
3662 ],
3663 "gitilesCommit": {
3664 "host": "chromium-review.googlesource.com",
3665 "project": "depot_tools",
3666 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003667 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003668 }
3669 },
3670 },
3671 {
3672 "scheduleBuild": {
3673 "requestId": "uuid4",
3674 "builder": {
3675 "project": "chromium",
3676 "builder": "win",
3677 "bucket": "try",
3678 },
3679 "gerritChanges": [{
3680 "project": "depot_tools",
3681 "host": "chromium-review.googlesource.com",
3682 "patchset": 7,
3683 "change": 123456,
3684 }],
3685 "properties": {
3686 "category": "git_cl_try",
3687 "json": [{"a": 1}, None],
3688 "key": "val",
3689 },
3690 "tags": [
3691 {"value": "win", "key": "builder"},
3692 {"value": "git_cl_try", "key": "user_agent"},
3693 ],
3694 "gitilesCommit": {
3695 "host": "chromium-review.googlesource.com",
3696 "project": "depot_tools",
3697 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003698 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003699 }
3700 },
3701 }],
3702 }
3703 mockCallBuildbucket.assert_called_with(
3704 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3705
Edward Lemur45768512020-03-02 19:03:14 +00003706 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003707 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003708 with self.assertRaises(SystemExit):
3709 git_cl.main([
3710 'try', '-B', 'not-a-bucket', '-b', 'win',
3711 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003712 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003713 'Invalid bucket: not-a-bucket.',
3714 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003715
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003716 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003717 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003718 def testScheduleOnBuildbucketRetryFailed(
3719 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003720 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003721 7: [],
3722 6: [{
3723 'id': 112112,
3724 'builder': {
3725 'project': 'chromium',
3726 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003727 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003728 'createTime': '2019-10-09T08:00:01.854286Z',
3729 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003730 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003731 mockCallBuildbucket.return_value = {}
3732
3733 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3734 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003735 'Scheduling jobs on:\n'
3736 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003737 git_cl.sys.stdout.getvalue())
3738
3739 expected_request = {
3740 "requests": [{
3741 "scheduleBuild": {
3742 "requestId": "uuid4",
3743 "builder": {
3744 "project": "chromium",
3745 "bucket": "try",
3746 "builder": "linux",
3747 },
3748 "gerritChanges": [{
3749 "project": "depot_tools",
3750 "host": "chromium-review.googlesource.com",
3751 "patchset": 7,
3752 "change": 123456,
3753 }],
3754 "properties": {
3755 "category": "git_cl_try",
3756 },
3757 "tags": [
3758 {"value": "linux", "key": "builder"},
3759 {"value": "git_cl_try", "key": "user_agent"},
3760 {"value": "1", "key": "retry_failed"},
3761 ],
3762 },
3763 }],
3764 }
3765 mockCallBuildbucket.assert_called_with(
3766 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3767
Edward Lemur4c707a22019-09-24 21:13:43 +00003768 def test_parse_bucket(self):
3769 test_cases = [
3770 {
3771 'bucket': 'chromium/try',
3772 'result': ('chromium', 'try'),
3773 },
3774 {
3775 'bucket': 'luci.chromium.try',
3776 'result': ('chromium', 'try'),
3777 'has_warning': True,
3778 },
3779 {
3780 'bucket': 'skia.primary',
3781 'result': ('skia', 'skia.primary'),
3782 'has_warning': True,
3783 },
3784 {
3785 'bucket': 'not-a-bucket',
3786 'result': (None, None),
3787 },
3788 ]
3789
3790 for test_case in test_cases:
3791 git_cl.sys.stdout.truncate(0)
3792 self.assertEqual(
3793 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3794 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003795 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3796 test_case['result'])
3797 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003798
3799
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003800class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003801
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003802 def setUp(self):
3803 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003804 mock.patch('git_cl._fetch_tryjobs').start()
3805 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003806 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003807 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3808 mock.patch(
3809 'git_cl.Settings.GetSquashGerritUploads',
3810 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003811 self.addCleanup(mock.patch.stopall)
3812
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003813 def testWarmUpChangeDetailCache(self):
3814 self.assertEqual(0, git_cl.main(['upload']))
3815 gerrit_util.GetChangeDetail.assert_called_once_with(
3816 'chromium-review.googlesource.com', 'depot_tools~123456',
3817 frozenset([
3818 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3819 'CURRENT_COMMIT']))
3820
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003821 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003822 # This test mocks out the actual upload part, and just asserts that after
3823 # upload, if --retry-failed is added, then the tool will fetch try jobs
3824 # from the previous patchset and trigger the right builders on the latest
3825 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003826 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003827 # Latest patchset: No builds.
3828 [],
3829 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003830 [{
3831 'id': str(100 + idx),
3832 'builder': {
3833 'project': 'chromium',
3834 'bucket': 'try',
3835 'builder': 'bot_' + status.lower(),
3836 },
3837 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3838 'tags': [],
3839 'status': status,
3840 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003841 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003842
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003843 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003844 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003845 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3846 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003847 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003848 expected_buckets = [
3849 ('chromium', 'try', 'bot_failure'),
3850 ('chromium', 'try', 'bot_infra_failure'),
3851 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003852 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3853 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003854
Brian Sheedy59b06a82019-10-14 17:03:29 +00003855
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003856class MakeRequestsHelperTestCase(unittest.TestCase):
3857
3858 def exampleGerritChange(self):
3859 return {
3860 'host': 'chromium-review.googlesource.com',
3861 'project': 'depot_tools',
3862 'change': 1,
3863 'patchset': 2,
3864 }
3865
3866 def testMakeRequestsHelperNoOptions(self):
3867 # Basic test for the helper function _make_tryjob_schedule_requests;
3868 # it shouldn't throw AttributeError even when options doesn't have any
3869 # of the expected values; it will use default option values.
3870 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3871 jobs = [('chromium', 'try', 'my-builder')]
3872 options = optparse.Values()
3873 requests = git_cl._make_tryjob_schedule_requests(
3874 changelist, jobs, options, patchset=None)
3875
3876 # requestId is non-deterministic. Just assert that it's there and has
3877 # a particular length.
3878 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3879 self.assertEqual(requests, [{
3880 'scheduleBuild': {
3881 'builder': {
3882 'bucket': 'try',
3883 'builder': 'my-builder',
3884 'project': 'chromium'
3885 },
3886 'gerritChanges': [self.exampleGerritChange()],
3887 'properties': {
3888 'category': 'git_cl_try'
3889 },
3890 'tags': [{
3891 'key': 'builder',
3892 'value': 'my-builder'
3893 }, {
3894 'key': 'user_agent',
3895 'value': 'git_cl_try'
3896 }]
3897 }
3898 }])
3899
3900 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3901 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3902 jobs = [('chromium', 'try', 'presubmit')]
3903 options = optparse.Values()
3904 requests = git_cl._make_tryjob_schedule_requests(
3905 changelist, jobs, options, patchset=None)
3906 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3907 'category': 'git_cl_try',
3908 'dry_run': 'true'
3909 })
3910
3911 def testMakeRequestsHelperRevisionSet(self):
3912 # Gitiles commit is specified when revision is in options.
3913 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3914 jobs = [('chromium', 'try', 'my-builder')]
3915 options = optparse.Values({'revision': 'ba5eba11'})
3916 requests = git_cl._make_tryjob_schedule_requests(
3917 changelist, jobs, options, patchset=None)
3918 self.assertEqual(
3919 requests[0]['scheduleBuild']['gitilesCommit'], {
3920 'host': 'chromium-review.googlesource.com',
3921 'id': 'ba5eba11',
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003922 'project': 'depot_tools',
3923 'ref': 'refs/heads/main',
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003924 })
3925
3926 def testMakeRequestsHelperRetryFailedSet(self):
3927 # An extra tag is added when retry_failed is in options.
3928 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3929 jobs = [('chromium', 'try', 'my-builder')]
3930 options = optparse.Values({'retry_failed': 'true'})
3931 requests = git_cl._make_tryjob_schedule_requests(
3932 changelist, jobs, options, patchset=None)
3933 self.assertEqual(
3934 requests[0]['scheduleBuild']['tags'], [
3935 {
3936 'key': 'builder',
3937 'value': 'my-builder'
3938 },
3939 {
3940 'key': 'user_agent',
3941 'value': 'git_cl_try'
3942 },
3943 {
3944 'key': 'retry_failed',
3945 'value': '1'
3946 }
3947 ])
3948
3949 def testMakeRequestsHelperCategorySet(self):
Quinten Yearsley925cedb2020-04-13 17:49:39 +00003950 # The category property can be overridden with options.
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003951 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3952 jobs = [('chromium', 'try', 'my-builder')]
3953 options = optparse.Values({'category': 'my-special-category'})
3954 requests = git_cl._make_tryjob_schedule_requests(
3955 changelist, jobs, options, patchset=None)
3956 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3957 {'category': 'my-special-category'})
3958
3959
Edward Lemurda4b6c62020-02-13 00:28:40 +00003960class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003961
3962 def setUp(self):
3963 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003964 mock.patch('git_cl.RunCommand').start()
3965 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3966 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3967 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003968 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003969 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003970
3971 def tearDown(self):
3972 shutil.rmtree(self._top_dir)
3973 super(CMDFormatTestCase, self).tearDown()
3974
Jamie Madill5e96ad12020-01-13 16:08:35 +00003975 def _make_temp_file(self, fname, contents):
Anthony Politoc64e3902021-04-30 21:55:25 +00003976 gclient_utils.FileWrite(os.path.join(self._top_dir, fname),
3977 ('\n'.join(contents)))
Jamie Madill5e96ad12020-01-13 16:08:35 +00003978
Brian Sheedy59b06a82019-10-14 17:03:29 +00003979 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003980 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003981
Brian Sheedyb4307d52019-12-02 19:18:17 +00003982 def _check_yapf_filtering(self, files, expected):
3983 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3984 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003985
Edward Lemur1a83da12020-03-04 21:18:36 +00003986 def _run_command_mock(self, return_value):
3987 def f(*args, **kwargs):
3988 if 'stdin' in kwargs:
3989 self.assertIsInstance(kwargs['stdin'], bytes)
3990 return return_value
3991 return f
3992
Jamie Madill5e96ad12020-01-13 16:08:35 +00003993 def testClangFormatDiffFull(self):
3994 self._make_temp_file('test.cc', ['// test'])
3995 git_cl.settings.GetFormatFullByDefault.return_value = False
3996 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3997 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3998
3999 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004000 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004001 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
4002 self._top_dir, 'HEAD')
4003 self.assertEqual(2, return_value)
4004
4005 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004006 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004007 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
4008 self._top_dir, 'HEAD')
4009 self.assertEqual(0, return_value)
4010
4011 def testClangFormatDiff(self):
4012 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00004013 # A valid file is required, so use this test.
4014 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00004015 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
4016
4017 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004018 git_cl.RunCommand.side_effect = self._run_command_mock('error')
4019 return_value = git_cl._RunClangFormatDiff(
4020 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004021 self.assertEqual(2, return_value)
4022
4023 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004024 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004025 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
4026 'HEAD')
4027 self.assertEqual(0, return_value)
4028
Brian Sheedyb4307d52019-12-02 19:18:17 +00004029 def testYapfignoreExplicit(self):
4030 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
4031 files = [
4032 'bar.py',
4033 'foo/bar.py',
4034 'foo/baz.py',
4035 'foo/bar/baz.py',
4036 'foo/bar/foobar.py',
4037 ]
4038 expected = [
4039 'bar.py',
4040 'foo/baz.py',
4041 'foo/bar/foobar.py',
4042 ]
4043 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004044
Brian Sheedyb4307d52019-12-02 19:18:17 +00004045 def testYapfignoreSingleWildcards(self):
4046 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
4047 files = [
4048 'bar.py', # Matched by *bar.py.
4049 'bar.txt',
4050 'foobar.py', # Matched by *bar.py, foo*.
4051 'foobar.txt', # Matched by foo*.
4052 'bazbar.py', # Matched by *bar.py, baz*.py.
4053 'bazbar.txt',
4054 'foo/baz.txt', # Matched by foo*.
4055 'bar/bar.py', # Matched by *bar.py.
4056 'baz/foo.py', # Matched by baz*.py, foo*.
4057 'baz/foo.txt',
4058 ]
4059 expected = [
4060 'bar.txt',
4061 'bazbar.txt',
4062 'baz/foo.txt',
4063 ]
4064 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004065
Brian Sheedyb4307d52019-12-02 19:18:17 +00004066 def testYapfignoreMultiplewildcards(self):
4067 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
4068 files = [
4069 'bar.py', # Matched by *bar*.
4070 'bar.txt', # Matched by *bar*.
4071 'abar.py', # Matched by *bar*.
4072 'foobaz.txt', # Matched by *foo*baz.txt.
4073 'foobaz.py',
4074 'afoobaz.txt', # Matched by *foo*baz.txt.
4075 ]
4076 expected = [
4077 'foobaz.py',
4078 ]
4079 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004080
4081 def testYapfignoreComments(self):
4082 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004083 files = [
4084 'test.py',
4085 'test2.py',
4086 ]
4087 expected = [
4088 'test2.py',
4089 ]
4090 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004091
Anthony Politoc64e3902021-04-30 21:55:25 +00004092 def testYapfHandleUtf8(self):
4093 self._make_yapfignore(['test.py', 'test_🌐.py'])
4094 files = [
4095 'test.py',
4096 'test_🌐.py',
4097 'test2.py',
4098 ]
4099 expected = [
4100 'test2.py',
4101 ]
4102 self._check_yapf_filtering(files, expected)
4103
Brian Sheedy59b06a82019-10-14 17:03:29 +00004104 def testYapfignoreBlankLines(self):
4105 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004106 files = [
4107 'test.py',
4108 'test2.py',
4109 'test3.py',
4110 ]
4111 expected = [
4112 'test3.py',
4113 ]
4114 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004115
4116 def testYapfignoreWhitespace(self):
4117 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004118 files = [
4119 'test.py',
4120 'test2.py',
4121 ]
4122 expected = [
4123 'test2.py',
4124 ]
4125 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004126
Brian Sheedyb4307d52019-12-02 19:18:17 +00004127 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00004128 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004129 self._check_yapf_filtering([], [])
4130
4131 def testYapfignoreMissingYapfignore(self):
4132 files = [
4133 'test.py',
4134 ]
4135 expected = [
4136 'test.py',
4137 ]
4138 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004139
4140
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004141class CMDStatusTestCase(CMDTestCaseBase):
4142 # Return branch names a,..,f with comitterdates in increasing order, i.e.
4143 # 'f' is the most-recently changed branch.
4144 def _mock_run_git(commands):
4145 if commands == [
4146 'for-each-ref', '--format=%(refname) %(committerdate:unix)',
4147 'refs/heads'
4148 ]:
4149 branches_and_committerdates = [
4150 'refs/heads/a 1',
4151 'refs/heads/b 2',
4152 'refs/heads/c 3',
4153 'refs/heads/d 4',
4154 'refs/heads/e 5',
4155 'refs/heads/f 6',
4156 ]
4157 return '\n'.join(branches_and_committerdates)
4158
4159 # Mock the status in such a way that the issue number gives us an
4160 # indication of the commit date (simplifies manual debugging).
4161 def _mock_get_cl_statuses(branches, fine_grained, max_processes):
4162 for c in branches:
4163 c.issue = (100 + int(c.GetCommitDate()))
4164 yield (c, 'open')
4165
4166 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4167 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4168 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4169 @mock.patch('git_cl.RunGit', _mock_run_git)
4170 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4171 @mock.patch('git_cl.Settings.GetRoot', return_value='')
4172 @mock.patch('scm.GIT.GetBranch', return_value='a')
4173 def testStatus(self, *_mocks):
4174 self.assertEqual(0, git_cl.main(['status', '--no-branch-color']))
4175 self.maxDiff = None
4176 self.assertEqual(
4177 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4178 ' * a : https://crrev.com/c/101 (open)\n'
4179 ' b : https://crrev.com/c/102 (open)\n'
4180 ' c : https://crrev.com/c/103 (open)\n'
4181 ' d : https://crrev.com/c/104 (open)\n'
4182 ' e : https://crrev.com/c/105 (open)\n'
4183 ' f : https://crrev.com/c/106 (open)\n\n'
4184 'Current branch: a\n'
4185 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4186 'Issue description:\n'
4187 'x\n')
4188
4189 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4190 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4191 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4192 @mock.patch('git_cl.RunGit', _mock_run_git)
4193 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4194 @mock.patch('git_cl.Settings.GetRoot', return_value='')
4195 @mock.patch('scm.GIT.GetBranch', return_value='a')
4196 def testStatusByDate(self, *_mocks):
4197 self.assertEqual(
4198 0, git_cl.main(['status', '--no-branch-color', '--date-order']))
4199 self.maxDiff = None
4200 self.assertEqual(
4201 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4202 ' f : https://crrev.com/c/106 (open)\n'
4203 ' e : https://crrev.com/c/105 (open)\n'
4204 ' d : https://crrev.com/c/104 (open)\n'
4205 ' c : https://crrev.com/c/103 (open)\n'
4206 ' b : https://crrev.com/c/102 (open)\n'
4207 ' * a : https://crrev.com/c/101 (open)\n\n'
4208 'Current branch: a\n'
4209 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4210 'Issue description:\n'
4211 'x\n')
4212
4213
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004214class CMDOwnersTestCase(CMDTestCaseBase):
4215 def setUp(self):
4216 super(CMDOwnersTestCase, self).setUp()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004217 self.owners_by_path = {
4218 'foo': ['a@example.com'],
4219 'bar': ['b@example.com', 'c@example.com'],
4220 }
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004221 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
4222 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
4223 mock.patch(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004224 'git_cl.Changelist.GetAffectedFiles',
4225 return_value=list(self.owners_by_path)).start()
4226 mock.patch(
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004227 'git_cl.Changelist.GetCommonAncestorWithUpstream',
4228 return_value='upstream').start()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004229 mock.patch(
Edward Lesmese1576912021-02-16 21:53:34 +00004230 'git_cl.Changelist.GetGerritHost',
4231 return_value='host').start()
4232 mock.patch(
4233 'git_cl.Changelist.GetGerritProject',
4234 return_value='project').start()
4235 mock.patch(
4236 'git_cl.Changelist.GetRemoteBranch',
4237 return_value=('origin', 'refs/remotes/origin/main')).start()
4238 mock.patch(
4239 'owners_client.OwnersClient.BatchListOwners',
Edward Lesmes82b992a2021-01-11 23:24:55 +00004240 return_value=self.owners_by_path).start()
Edward Lesmes8170c292021-03-19 20:04:43 +00004241 mock.patch(
4242 'gerrit_util.IsCodeOwnersEnabledOnHost', return_value=True).start()
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004243 self.addCleanup(mock.patch.stopall)
4244
4245 def testShowAllNoArgs(self):
4246 self.assertEqual(0, git_cl.main(['owners', '--show-all']))
4247 self.assertEqual(
4248 'No files specified for --show-all. Nothing to do.\n',
4249 git_cl.sys.stdout.getvalue())
4250
4251 def testShowAll(self):
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004252 self.assertEqual(
4253 0,
4254 git_cl.main(['owners', '--show-all', 'foo', 'bar', 'baz']))
Edward Lesmese1576912021-02-16 21:53:34 +00004255 owners_client.OwnersClient.BatchListOwners.assert_called_once_with(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004256 ['foo', 'bar', 'baz'])
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004257 self.assertEqual(
4258 '\n'.join([
4259 'Owners for foo:',
4260 ' - a@example.com',
4261 'Owners for bar:',
4262 ' - b@example.com',
4263 ' - c@example.com',
4264 'Owners for baz:',
4265 ' - No owners found',
4266 '',
4267 ]),
4268 sys.stdout.getvalue())
4269
Edward Lesmes82b992a2021-01-11 23:24:55 +00004270 def testBatch(self):
4271 self.assertEqual(0, git_cl.main(['owners', '--batch']))
4272 self.assertIn('a@example.com', sys.stdout.getvalue())
4273 self.assertIn('b@example.com', sys.stdout.getvalue())
4274
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004275
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004276if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01004277 logging.basicConfig(
4278 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004279 unittest.main()