blob: cfae719a50a4fa88537ad7fd418cf66bb4c30de0 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01009import datetime
tandriide281ae2016-10-12 06:02:30 -070010import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010011import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000012import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
15import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000016import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017
18sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
19
20from testing_support.auto_stub import TestCase
21
22import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000023import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000024import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000025import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000026
tandrii5d48c322016-08-18 16:19:37 -070027def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
28 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
29
30
31CERR1 = callError(1)
32
33
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000034class ChangelistMock(object):
35 # A class variable so we can access it when we don't have access to the
36 # instance that's being set.
37 desc = ""
38 def __init__(self, **kwargs):
39 pass
40 def GetIssue(self):
41 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080042 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000043 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070044 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000045 ChangelistMock.desc = desc
46
tandrii5d48c322016-08-18 16:19:37 -070047
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000048class PresubmitMock(object):
49 def __init__(self, *args, **kwargs):
50 self.reviewers = []
51 @staticmethod
52 def should_continue():
53 return True
54
55
56class RietveldMock(object):
57 def __init__(self, *args, **kwargs):
58 pass
maruel@chromium.org78936cb2013-04-11 00:17:52 +000059
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000060 @staticmethod
Kenneth Russell61e2ed42017-02-15 11:47:13 -080061 def get_description(issue, force=False):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000062 return 'Issue: %d' % issue
63
maruel@chromium.org78936cb2013-04-11 00:17:52 +000064 @staticmethod
65 def get_issue_properties(_issue, _messages):
66 return {
67 'reviewers': ['joe@chromium.org', 'john@chromium.org'],
68 'messages': [
69 {
70 'approval': True,
71 'sender': 'john@chromium.org',
72 },
73 ],
Andrii Shyshkalov06a25022016-11-24 16:47:00 +010074 'patchsets': [1, 20001],
maruel@chromium.org78936cb2013-04-11 00:17:52 +000075 }
76
iannuccie53c9352016-08-17 14:40:40 -070077 @staticmethod
78 def close_issue(_issue):
79 return 'Closed'
80
skobes6468b902016-10-24 08:45:10 -070081 @staticmethod
82 def get_patch(issue, patchset):
83 return 'patch set from issue %s patchset %s' % (issue, patchset)
84
Andrii Shyshkalov06a25022016-11-24 16:47:00 +010085 @staticmethod
86 def update_description(_issue, _description):
87 return 'Updated'
88
89 @staticmethod
90 def add_comment(_issue, _comment):
91 return 'Commented'
92
93
94
skobes6468b902016-10-24 08:45:10 -070095
96class GitCheckoutMock(object):
97 def __init__(self, *args, **kwargs):
98 pass
99
100 @staticmethod
101 def reset():
102 GitCheckoutMock.conflict = False
103
104 def apply_patch(self, p):
105 if GitCheckoutMock.conflict:
106 raise Exception('failed')
107
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000108
109class WatchlistsMock(object):
110 def __init__(self, _):
111 pass
112 @staticmethod
113 def GetWatchersForPaths(_):
114 return ['joe@example.com']
115
116
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000117class CodereviewSettingsFileMock(object):
118 def __init__(self):
119 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800120 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000121 def read(self):
122 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000123 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000124
125
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000126class AuthenticatorMock(object):
127 def __init__(self, *_args):
128 pass
129 def has_cached_credentials(self):
130 return True
tandrii221ab252016-10-06 08:12:04 -0700131 def authorize(self, http):
132 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000133
134
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100135def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000136 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
137
138 Usage:
139 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100140 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000141
142 OR
143 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100144 CookiesAuthenticatorMockFactory(
145 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000146 """
147 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800148 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000149 # Intentionally not calling super() because it reads actual cookie files.
150 pass
151 @classmethod
152 def get_gitcookies_path(cls):
153 return '~/.gitcookies'
154 @classmethod
155 def get_netrc_path(cls):
156 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100157 def _get_auth_for_host(self, host):
158 if same_auth:
159 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000160 return (hosts_with_creds or {}).get(host)
161 return CookiesAuthenticatorMock
162
kmarshall9249e012016-08-23 12:02:16 -0700163class MockChangelistWithBranchAndIssue():
164 def __init__(self, branch, issue):
165 self.branch = branch
166 self.issue = issue
167 def GetBranch(self):
168 return self.branch
169 def GetIssue(self):
170 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000171
tandriic2405f52016-10-10 08:13:15 -0700172
173class SystemExitMock(Exception):
174 pass
175
176
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000177class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100178 def test_get_description(self):
179 cl = git_cl.Changelist(issue=1, codereview='rietveld',
180 codereview_host='host')
181 cl.description = 'x'
182 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800183 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100184 self.assertEquals(cl.GetDescription(), 'x')
185 self.assertEquals(cl.GetDescription(force=True), 'y')
186 self.assertEquals(cl.GetDescription(), 'y')
187
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700188 def test_description_footers(self):
189 cl = git_cl.Changelist(issue=1, codereview='gerrit',
190 codereview_host='host')
191 cl.description = '\n'.join([
192 'This is some message',
193 '',
194 'It has some lines',
195 'and, also',
196 '',
197 'Some: Really',
198 'Awesome: Footers',
199 ])
200 cl.has_description = True
201 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
202 msg, footers = cl.GetDescriptionFooters()
203 self.assertEquals(
204 msg, ['This is some message', '', 'It has some lines', 'and, also'])
205 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
206
207 msg.append('wut')
208 footers.append(('gnarly-dude', 'beans'))
209 cl.UpdateDescriptionFooters(msg, footers)
210 self.assertEquals(cl.GetDescription().splitlines(), [
211 'This is some message',
212 '',
213 'It has some lines',
214 'and, also',
215 'wut'
216 '',
217 'Some: Really',
218 'Awesome: Footers',
219 'Gnarly-Dude: beans',
220 ])
221
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000222 def _test_ParseIssueUrl(self, func, url, issue, patchset, hostname, fail):
223 parsed = urlparse.urlparse(url)
224 result = func(parsed)
225 if fail:
226 self.assertIsNone(result)
227 return None
228 self.assertIsNotNone(result)
229 self.assertEqual(result.issue, issue)
230 self.assertEqual(result.patchset, patchset)
231 self.assertEqual(result.hostname, hostname)
232 return result
233
234 def test_ParseIssueURL_rietveld(self):
skobes6468b902016-10-24 08:45:10 -0700235 def test(url, issue=None, patchset=None, hostname=None, fail=None):
236 self._test_ParseIssueUrl(
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000237 git_cl._RietveldChangelistImpl.ParseIssueURL,
238 url, issue, patchset, hostname, fail)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000239
240 test('http://codereview.chromium.org/123',
241 123, None, 'codereview.chromium.org')
242 test('https://codereview.chromium.org/123',
243 123, None, 'codereview.chromium.org')
244 test('https://codereview.chromium.org/123/',
245 123, None, 'codereview.chromium.org')
246 test('https://codereview.chromium.org/123/whatever',
247 123, None, 'codereview.chromium.org')
wychen3c1c1722016-08-04 11:46:36 -0700248 test('https://codereview.chromium.org/123/#ps20001',
249 123, 20001, 'codereview.chromium.org')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000250 test('http://codereview.chromium.org/download/issue123_4.diff',
skobes6468b902016-10-24 08:45:10 -0700251 123, 4, 'codereview.chromium.org')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000252 # This looks like bad Gerrit, but is actually valid Rietveld.
253 test('https://chrome-review.source.com/123/4/',
254 123, None, 'chrome-review.source.com')
255
256 test('https://codereview.chromium.org/deadbeaf', fail=True)
257 test('https://codereview.chromium.org/api/123', fail=True)
258 test('bad://codereview.chromium.org/123', fail=True)
259 test('http://codereview.chromium.org/download/issue123_4.diffff', fail=True)
260
261 def test_ParseIssueURL_gerrit(self):
262 def test(url, issue=None, patchset=None, hostname=None, fail=None):
263 self._test_ParseIssueUrl(
264 git_cl._GerritChangelistImpl.ParseIssueURL,
265 url, issue, patchset, hostname, fail)
266
267 test('http://chrome-review.source.com/c/123',
268 123, None, 'chrome-review.source.com')
269 test('https://chrome-review.source.com/c/123/',
270 123, None, 'chrome-review.source.com')
271 test('https://chrome-review.source.com/c/123/4',
272 123, 4, 'chrome-review.source.com')
273 test('https://chrome-review.source.com/#/c/123/4',
274 123, 4, 'chrome-review.source.com')
275 test('https://chrome-review.source.com/c/123/4',
276 123, 4, 'chrome-review.source.com')
277 test('https://chrome-review.source.com/123',
278 123, None, 'chrome-review.source.com')
279 test('https://chrome-review.source.com/123/4',
280 123, 4, 'chrome-review.source.com')
281
282 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
283 test('https://chrome-review.source.com/c/abc/', fail=True)
284 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
285
286 def test_ParseIssueNumberArgument(self):
287 def test(arg, issue=None, patchset=None, hostname=None, fail=False):
288 result = git_cl.ParseIssueNumberArgument(arg)
289 self.assertIsNotNone(result)
290 if fail:
291 self.assertFalse(result.valid)
292 else:
293 self.assertEqual(result.issue, issue)
294 self.assertEqual(result.patchset, patchset)
295 self.assertEqual(result.hostname, hostname)
296
297 test('123', 123)
298 test('', fail=True)
299 test('abc', fail=True)
300 test('123/1', fail=True)
301 test('123a', fail=True)
302 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
303 # Rietveld.
304 test('https://codereview.source.com/123',
305 123, None, 'codereview.source.com')
306 test('https://codereview.source.com/www123', fail=True)
307 # Gerrrit.
308 test('https://chrome-review.source.com/c/123/4',
309 123, 4, 'chrome-review.source.com')
310 test('https://chrome-review.source.com/bad/123/4', fail=True)
311
tandriif9aefb72016-07-01 09:06:51 -0700312 def test_get_bug_line_values(self):
313 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
314 self.assertEqual(f('', ''), [])
315 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
316 self.assertEqual(f('v8', '456'), ['v8:456'])
317 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
318 # Not nice, but not worth carying.
319 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
320 ['v8:456', 'chromium:123', 'v8:123'])
321
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100322 def _test_git_number(self, parent_msg, dest_ref, child_msg,
323 parent_hash='parenthash'):
324 desc = git_cl.ChangeDescription(child_msg)
325 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
326 return desc.description
327
328 def assertEqualByLine(self, actual, expected):
329 self.assertEqual(actual.splitlines(), expected.splitlines())
330
331 def test_git_number_bad_parent(self):
332 with self.assertRaises(ValueError):
333 self._test_git_number('Parent', 'refs/heads/master', 'Child')
334
335 def test_git_number_bad_parent_footer(self):
336 with self.assertRaises(AssertionError):
337 self._test_git_number(
338 'Parent\n'
339 '\n'
340 'Cr-Commit-Position: wrong',
341 'refs/heads/master', 'Child')
342
343 def test_git_number_bad_lineage_ignored(self):
344 actual = self._test_git_number(
345 'Parent\n'
346 '\n'
347 'Cr-Commit-Position: refs/heads/master@{#1}\n'
348 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
349 'refs/heads/master', 'Child')
350 self.assertEqualByLine(
351 actual,
352 'Child\n'
353 '\n'
354 'Cr-Commit-Position: refs/heads/master@{#2}\n'
355 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
356
357 def test_git_number_same_branch(self):
358 actual = self._test_git_number(
359 'Parent\n'
360 '\n'
361 'Cr-Commit-Position: refs/heads/master@{#12}',
362 dest_ref='refs/heads/master',
363 child_msg='Child')
364 self.assertEqualByLine(
365 actual,
366 'Child\n'
367 '\n'
368 'Cr-Commit-Position: refs/heads/master@{#13}')
369
370 def test_git_number_same_branch_with_originals(self):
371 actual = self._test_git_number(
372 'Parent\n'
373 '\n'
374 'Cr-Commit-Position: refs/heads/master@{#12}',
375 dest_ref='refs/heads/master',
376 child_msg='Child\n'
377 '\n'
378 'Some users are smart and insert their own footers\n'
379 '\n'
380 'Cr-Whatever: value\n'
381 'Cr-Commit-Position: refs/copy/paste@{#22}')
382 self.assertEqualByLine(
383 actual,
384 'Child\n'
385 '\n'
386 'Some users are smart and insert their own footers\n'
387 '\n'
388 'Cr-Original-Whatever: value\n'
389 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
390 'Cr-Commit-Position: refs/heads/master@{#13}')
391
392 def test_git_number_new_branch(self):
393 actual = self._test_git_number(
394 'Parent\n'
395 '\n'
396 'Cr-Commit-Position: refs/heads/master@{#12}',
397 dest_ref='refs/heads/branch',
398 child_msg='Child')
399 self.assertEqualByLine(
400 actual,
401 'Child\n'
402 '\n'
403 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
404 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
405
406 def test_git_number_lineage(self):
407 actual = self._test_git_number(
408 'Parent\n'
409 '\n'
410 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
411 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
412 dest_ref='refs/heads/branch',
413 child_msg='Child')
414 self.assertEqualByLine(
415 actual,
416 'Child\n'
417 '\n'
418 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
419 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
420
421 def test_git_number_moooooooore_lineage(self):
422 actual = self._test_git_number(
423 'Parent\n'
424 '\n'
425 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
426 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
427 dest_ref='refs/heads/mooore',
428 child_msg='Child')
429 self.assertEqualByLine(
430 actual,
431 'Child\n'
432 '\n'
433 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
434 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
435 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
436
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100437 def test_git_number_ever_moooooooore_lineage(self):
438 self.maxDiff = 10000
439 actual = self._test_git_number(
440 'CQ commit on fresh new branch + numbering.\n'
441 '\n'
442 'NOTRY=True\n'
443 'NOPRESUBMIT=True\n'
444 'BUG=\n'
445 '\n'
446 'Review-Url: https://codereview.chromium.org/2577703003\n'
447 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
448 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
449 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
450 dest_ref='refs/heads/gnumb-test/cl',
451 child_msg='git cl on fresh new branch + numbering.\n'
452 '\n'
453 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
454 self.assertEqualByLine(
455 actual,
456 'git cl on fresh new branch + numbering.\n'
457 '\n'
458 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
459 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
460 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
461 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
462 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100463
464 def test_git_number_cherry_pick(self):
465 actual = self._test_git_number(
466 'Parent\n'
467 '\n'
468 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
469 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
470 dest_ref='refs/heads/branch',
471 child_msg='Child, which is cherry-pick from master\n'
472 '\n'
473 'Cr-Commit-Position: refs/heads/master@{#100}\n'
474 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
475 self.assertEqualByLine(
476 actual,
477 'Child, which is cherry-pick from master\n'
478 '\n'
479 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
480 '\n'
481 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
482 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
483 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
484
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000485
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100486class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100487 def setUp(self):
488 super(GitCookiesCheckerTest, self).setUp()
489 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100490 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100491
492 def mock_hosts_creds(self, subhost_identity_pairs):
493 def ensure_googlesource(h):
494 if not h.endswith(self.c._GOOGLESOURCE):
495 assert not h.endswith('.')
496 return h + '.' + self.c._GOOGLESOURCE
497 return h
498 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
499 for h, i in subhost_identity_pairs]
500
501 def test_analysis_nothing(self):
502 self.c._all_hosts = []
503 self.assertFalse(self.c.has_generic_host())
504 self.assertEqual(set(), self.c.get_conflicting_hosts())
505 self.assertEqual(set(), self.c.get_duplicated_hosts())
506 self.assertEqual(set(), self.c.get_partially_configured_hosts())
507 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
508
509 def test_analysis(self):
510 self.mock_hosts_creds([
511 ('.googlesource.com', 'git-example.chromium.org'),
512
513 ('chromium', 'git-example.google.com'),
514 ('chromium-review', 'git-example.google.com'),
515 ('chrome-internal', 'git-example.chromium.org'),
516 ('chrome-internal-review', 'git-example.chromium.org'),
517 ('conflict', 'git-example.google.com'),
518 ('conflict-review', 'git-example.chromium.org'),
519 ('dup', 'git-example.google.com'),
520 ('dup', 'git-example.google.com'),
521 ('dup-review', 'git-example.google.com'),
522 ('partial', 'git-example.google.com'),
523 ])
524 self.assertTrue(self.c.has_generic_host())
525 self.assertEqual(set(['conflict.googlesource.com']),
526 self.c.get_conflicting_hosts())
527 self.assertEqual(set(['dup.googlesource.com']),
528 self.c.get_duplicated_hosts())
529 self.assertEqual(set(['partial.googlesource.com']),
530 self.c.get_partially_configured_hosts())
531 self.assertEqual(set(['chromium.googlesource.com',
532 'chrome-internal.googlesource.com']),
533 self.c.get_hosts_with_wrong_identities())
534
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100535 def test_report_no_problems(self):
536 self.test_analysis_nothing()
537 self.mock(sys, 'stdout', StringIO.StringIO())
538 self.assertFalse(self.c.find_and_report_problems())
539 self.assertEqual(sys.stdout.getvalue(), '')
540
541 def test_report(self):
542 self.test_analysis()
543 self.mock(sys, 'stdout', StringIO.StringIO())
544 self.assertTrue(self.c.find_and_report_problems())
545 with open(os.path.join(os.path.dirname(__file__),
546 'git_cl_creds_check_report.txt')) as f:
547 expected = f.read()
548 def by_line(text):
549 return [l.rstrip() for l in text.rstrip().splitlines()]
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200550 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100551
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000552class TestGitCl(TestCase):
553 def setUp(self):
554 super(TestGitCl, self).setUp()
555 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700556 self._calls_done = []
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000557 self.mock(subprocess2, 'call', self._mocked_call)
558 self.mock(subprocess2, 'check_call', self._mocked_call)
559 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700560 self.mock(subprocess2, 'communicate',
561 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000562 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000563 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000564 self.mock(git_common, 'get_or_create_merge_base',
565 lambda *a: (
566 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000567 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000568 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100569 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
570 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700571 self.mock(git_cl, 'write_json', lambda path, contents:
572 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000573 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000574 self.mock(git_cl.rietveld, 'Rietveld', RietveldMock)
maruel@chromium.org4bac4b52012-11-27 20:33:52 +0000575 self.mock(git_cl.rietveld, 'CachingRietveld', RietveldMock)
skobes6468b902016-10-24 08:45:10 -0700576 self.mock(git_cl.checkout, 'GitCheckout', GitCheckoutMock)
577 GitCheckoutMock.reset()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000578 self.mock(git_cl.upload, 'RealMain', self.fail)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000579 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000580 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100581 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
582 lambda *args, **kwargs: self._mocked_call(
583 'GetChangeDetail', *args, **kwargs))
584 self.mock(git_cl.gerrit_util, 'AddReviewers',
585 lambda h, i, add, is_reviewer, notify: self._mocked_call(
586 'AddReviewers', h, i, add, is_reviewer, notify))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000587 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
588 classmethod(lambda _: False))
tandriic2405f52016-10-10 08:13:15 -0700589 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100590 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000591 # It's important to reset settings to not have inter-tests interference.
592 git_cl.settings = None
593
594 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000595 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100596 self.assertEquals([], self.calls)
597 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000598 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100599 raise
600 # Sadly, has_failed() returns True if this OR any other tests before this
601 # one have failed.
602 git_cl.logging.exception(
603 '\nIF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME!\n'
604 'There are un-consumed self.calls after this test has finished.\n'
605 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700606 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100607 '\n'
608 'If you are already running just this single test, then **first** '
609 'fix the problem whose exception is emitted below by unittest '
610 'runner.\n'
611 '\n'
612 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700613 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100614 'and follow instructions above.\n' +
615 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000616 finally:
617 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000618
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000619 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000620 self.assertTrue(
621 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700622 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000623 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000624 expected_args, result = top
625
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000626 # Also logs otherwise it could get caught in a try/finally and be hard to
627 # diagnose.
628 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700629 N = 5
630 prior_calls = '\n '.join(
631 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
632 for i, c in enumerate(self._calls_done[-N:]))
633 following_calls = '\n '.join(
634 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
635 for i, c in enumerate(self.calls[:N]))
636 extended_msg = (
637 'A few prior calls:\n %s\n\n'
638 'This (expected):\n @%d: %r\n'
639 'This (actual):\n @%d: %r\n\n'
640 'A few following expected calls:\n %s' %
641 (prior_calls, len(self._calls_done), expected_args,
642 len(self._calls_done), args, following_calls))
643 git_cl.logging.error(extended_msg)
644
tandrii99a72f22016-08-17 14:33:24 -0700645 self.fail('@%d\n'
646 ' Expected: %r\n'
647 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700648 len(self._calls_done), expected_args, args))
649
650 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700651 if isinstance(result, Exception):
652 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000653 return result
654
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100655 def test_ask_for_explicit_yes_true(self):
656 self.calls = [
657 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
658 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
659 ]
660 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
661
662 def test_ask_for_explicit_yes_true(self):
663 self.calls = [
664 (('ask_for_data', 'prompt [Yes/No]: '), 'yesish'),
665 (('ask_for_data', 'Please, type yes or no: '), 'nO'),
666 ]
667 self.assertFalse(git_cl.ask_for_explicit_yes('prompt'))
668
tandrii48df5812016-10-17 03:55:37 -0700669 def test_LoadCodereviewSettingsFromFile_gerrit(self):
670 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
671 self.calls = [
672 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
673 ((['git', 'config', '--unset-all', 'rietveld.private'],), CERR1),
674 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
675 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
676 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
677 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700678 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
679 CERR1),
680 ((['git', 'config', '--unset-all', 'rietveld.project'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700681 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
682 CERR1),
683 ((['git', 'config', 'gerrit.host', 'true'],), ''),
684 ]
685 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
686
Jochen Eisinger72606f82017-04-04 10:44:18 +0200687 def test_LoadCodereviewSettingsFromFile_owners_status(self):
688 codereview_file = StringIO.StringIO('OWNERS_STATUS_FILE: status')
689 self.calls = [
690 ((['git', 'config', '--unset-all', 'rietveld.server'],), ''),
691 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
692 ((['git', 'config', '--unset-all', 'rietveld.private'],), CERR1),
693 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
694 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
695 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
696 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
697 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
698 CERR1),
699 ((['git', 'config', '--unset-all', 'rietveld.project'],), CERR1),
700 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
701 CERR1),
702 ((['git', 'config', 'rietveld.owners-status-file', 'status'],), ''),
703 ]
704 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
705
maruel@chromium.orga3353652011-11-30 14:26:57 +0000706 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000707 def _is_gerrit_calls(cls, gerrit=False):
708 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
709 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
710
711 @classmethod
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000712 def _upload_calls(cls, similarity, find_copies, private):
iannucci@chromium.org79540052012-10-19 23:15:26 +0000713 return (cls._git_base_calls(similarity, find_copies) +
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000714 cls._git_upload_calls(private))
maruel@chromium.orga3353652011-11-30 14:26:57 +0000715
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000716 @classmethod
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000717 def _upload_no_rev_calls(cls, similarity, find_copies):
718 return (cls._git_base_calls(similarity, find_copies) +
719 cls._git_upload_no_rev_calls())
720
721 @classmethod
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000722 def _git_base_calls(cls, similarity, find_copies):
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000723 if similarity is None:
724 similarity = '50'
tandrii33a46ff2016-08-23 05:53:40 -0700725 similarity_call = ((['git', 'config',
tandrii5d48c322016-08-18 16:19:37 -0700726 'branch.master.git-cl-similarity'],), CERR1)
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000727 else:
tandrii33a46ff2016-08-23 05:53:40 -0700728 similarity_call = ((['git', 'config',
tandrii5d48c322016-08-18 16:19:37 -0700729 'branch.master.git-cl-similarity', similarity],), '')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000730
731 if find_copies is None:
732 find_copies = True
tandrii5d48c322016-08-18 16:19:37 -0700733 find_copies_call = ((['git', 'config', '--bool',
734 'branch.master.git-find-copies'],), CERR1)
iannucci@chromium.org79540052012-10-19 23:15:26 +0000735 else:
tandrii5d48c322016-08-18 16:19:37 -0700736 val = str(find_copies).lower()
737 find_copies_call = ((['git', 'config', '--bool',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000738 'branch.master.git-find-copies', val],), '')
739
740 if find_copies:
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000741 stat_call = ((['git', 'diff', '--no-ext-diff', '--stat',
scottmgb84b5e32016-11-10 09:25:33 -0800742 '-l100000', '-C'+similarity,
743 'fake_ancestor_sha', 'HEAD'],), '+dat')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000744 else:
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000745 stat_call = ((['git', 'diff', '--no-ext-diff', '--stat',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000746 '-M'+similarity, 'fake_ancestor_sha', 'HEAD'],), '+dat')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000747
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000748 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000749 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii@chromium.org87985d22016-03-24 17:33:33 +0000750 similarity_call,
751 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
752 find_copies_call,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000753 ] + cls._is_gerrit_calls() + [
tandrii@chromium.org87985d22016-03-24 17:33:33 +0000754 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -0700755 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
756 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000757 ((['git', 'config', 'rietveld.server'],),
758 'codereview.example.com'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000759 ((['git', 'config', 'branch.master.merge'],), 'master'),
760 ((['git', 'config', 'branch.master.remote'],), 'origin'),
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000761 ((['get_or_create_merge_base', 'master', 'master'],),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000762 'fake_ancestor_sha'),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000763 ] + cls._git_sanity_checks('fake_ancestor_sha', 'master') + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000764 ((['git', 'rev-parse', '--show-cdup'],), ''),
765 ((['git', 'rev-parse', 'HEAD'],), '12345'),
766 ((['git', 'diff', '--name-status', '--no-renames', '-r',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000767 'fake_ancestor_sha...', '.'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000768 'M\t.gitignore\n'),
tandrii33a46ff2016-08-23 05:53:40 -0700769 ((['git', 'config', 'branch.master.rietveldpatchset'],), CERR1),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000770 ((['git', 'log', '--pretty=format:%s%n%n%b',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000771 'fake_ancestor_sha...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000772 'foo'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000773 ((['git', 'config', 'user.email'],), 'me@example.com'),
iannucci@chromium.org79540052012-10-19 23:15:26 +0000774 stat_call,
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000775 ((['git', 'log', '--pretty=format:%s\n\n%b',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000776 'fake_ancestor_sha..HEAD'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000777 'desc\n'),
Aaron Gable3a16ed12017-03-23 10:51:55 -0700778 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
maruel@chromium.orga3353652011-11-30 14:26:57 +0000779 ]
780
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000781 @classmethod
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000782 def _git_upload_no_rev_calls(cls):
783 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000784 ((['git', 'config', 'core.editor'],), ''),
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000785 ]
786
787 @classmethod
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000788 def _git_upload_calls(cls, private):
789 if private:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000790 cc_call = []
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000791 private_call = []
792 else:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000793 cc_call = [((['git', 'config', 'rietveld.cc'],), '')]
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000794 private_call = [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000795 ((['git', 'config', 'rietveld.private'],), '')]
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000796
maruel@chromium.orga3353652011-11-30 14:26:57 +0000797 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000798 ((['git', 'config', 'core.editor'],), ''),
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000799 ] + cc_call + private_call + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000800 ((['git', 'config', 'branch.master.base-url'],), ''),
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800801 ((['git', 'config', 'remote.origin.url'],), ''),
sheyang@chromium.org152cf832014-06-11 21:37:49 +0000802 ((['git', 'config', 'rietveld.project'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -0700803 ((['git', 'config', 'branch.master.rietveldissue', '1'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000804 ((['git', 'config', 'branch.master.rietveldserver',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000805 'https://codereview.example.com'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000806 ((['git',
tandrii33a46ff2016-08-23 05:53:40 -0700807 'config', 'branch.master.rietveldpatchset', '2'],), ''),
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000808 ] + cls._git_post_upload_calls()
809
810 @classmethod
811 def _git_post_upload_calls(cls):
812 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000813 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
814 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
815 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000816 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000817 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000818 ]
819
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000820 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000821 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000822 fake_ancestor = 'fake_ancestor'
823 fake_cl = 'fake_cl_for_patch'
824 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000825 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000826 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000827 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000828 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000829 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000830 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000831 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000832 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700833 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000834 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000835 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000836 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000837 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000838 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000839 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000840 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000841 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000842 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000843 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000844 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000845
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000846 @staticmethod
bradnelsond975b302016-10-23 12:20:23 -0700847 def _cmd_line(description, args, similarity, find_copies, private, cc):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000848 """Returns the upload command line passed to upload.RealMain()."""
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000849 return [
850 'upload', '--assume_yes', '--server',
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +0000851 'https://codereview.example.com',
maruel@chromium.org71e12a92012-02-14 02:34:15 +0000852 '--message', description
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000853 ] + args + [
bradnelsond975b302016-10-23 12:20:23 -0700854 '--cc', ','.join(['joe@example.com'] + cc),
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000855 ] + (['--private'] if private else []) + [
iannucci@chromium.org79540052012-10-19 23:15:26 +0000856 '--git_similarity', similarity or '50'
Andrii Shyshkalov18975322017-01-25 16:44:13 +0100857 ] + (['--git_no_find_copies'] if find_copies is False else []) + [
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000858 'fake_ancestor_sha', 'HEAD'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000859 ]
860
861 def _run_reviewer_test(
862 self,
863 upload_args,
864 expected_description,
865 returned_description,
866 final_description,
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000867 reviewers,
bradnelsond975b302016-10-23 12:20:23 -0700868 private=False,
869 cc=None):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000870 """Generic reviewer test framework."""
tandrii@chromium.org28253532016-04-14 13:46:56 +0000871 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000872 try:
873 similarity = upload_args[upload_args.index('--similarity')+1]
874 except ValueError:
875 similarity = None
iannucci@chromium.org79540052012-10-19 23:15:26 +0000876
877 if '--find-copies' in upload_args:
878 find_copies = True
879 elif '--no-find-copies' in upload_args:
880 find_copies = False
881 else:
882 find_copies = None
883
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000884 private = '--private' in upload_args
bradnelsond975b302016-10-23 12:20:23 -0700885 cc = cc or []
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000886
887 self.calls = self._upload_calls(similarity, find_copies, private)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000888
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000889 def RunEditor(desc, _, **kwargs):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000890 self.assertEquals(
891 '# Enter a description of the change.\n'
janx@chromium.org104b2db2013-04-18 12:58:40 +0000892 '# This will be displayed on the codereview site.\n'
alancutter@chromium.org63a4d7f2013-05-31 02:22:45 +0000893 '# The first line will also be used as the subject of the review.\n'
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +0000894 '#--------------------This line is 72 characters long'
895 '--------------------\n' +
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000896 expected_description,
897 desc)
898 return returned_description
899 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000900
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000901 def check_upload(args):
iannucci@chromium.org79540052012-10-19 23:15:26 +0000902 cmd_line = self._cmd_line(final_description, reviewers, similarity,
bradnelsond975b302016-10-23 12:20:23 -0700903 find_copies, private, cc)
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000904 self.assertEquals(cmd_line, args)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000905 return 1, 2
906 self.mock(git_cl.upload, 'RealMain', check_upload)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000907
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000908 git_cl.main(['upload'] + upload_args)
909
910 def test_no_reviewer(self):
911 self._run_reviewer_test(
912 [],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000913 'desc\n\nBUG=',
914 '# Blah blah comment.\ndesc\n\nBUG=',
915 'desc\n\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000916 [])
917
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000918 def test_keep_similarity(self):
919 self._run_reviewer_test(
920 ['--similarity', '70'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000921 'desc\n\nBUG=',
922 '# Blah blah comment.\ndesc\n\nBUG=',
923 'desc\n\nBUG=',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000924 [])
925
iannucci@chromium.org79540052012-10-19 23:15:26 +0000926 def test_keep_find_copies(self):
927 self._run_reviewer_test(
928 ['--no-find-copies'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000929 'desc\n\nBUG=',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000930 '# Blah blah comment.\ndesc\n\nBUG=\n',
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000931 'desc\n\nBUG=',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000932 [])
933
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000934 def test_private(self):
935 self._run_reviewer_test(
936 ['--private'],
937 'desc\n\nBUG=',
938 '# Blah blah comment.\ndesc\n\nBUG=\n',
939 'desc\n\nBUG=',
940 [])
941
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000942 def test_reviewers_cmd_line(self):
943 # Reviewer is passed as-is
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000944 description = 'desc\n\nR=foo@example.com\nBUG='
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000945 self._run_reviewer_test(
946 ['-r' 'foo@example.com'],
947 description,
948 '\n%s\n' % description,
949 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000950 ['--reviewers=foo@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000951
952 def test_reviewer_tbr_overriden(self):
953 # Reviewer is overriden with TBR
954 # Also verifies the regexp work without a trailing LF
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000955 description = 'Foo Bar\n\nTBR=reviewer@example.com'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000956 self._run_reviewer_test(
957 ['-r' 'foo@example.com'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000958 'desc\n\nR=foo@example.com\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000959 description.strip('\n'),
960 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000961 ['--reviewers=reviewer@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000962
963 def test_reviewer_multiple(self):
964 # Handles multiple R= or TBR= lines.
965 description = (
bradnelsond975b302016-10-23 12:20:23 -0700966 'Foo Bar\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
967 'CC=more@example.com,people@example.com')
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000968 self._run_reviewer_test(
969 [],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000970 'desc\n\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000971 description,
972 description,
bradnelsond975b302016-10-23 12:20:23 -0700973 ['--reviewers=another@example.com,reviewer@example.com'],
974 cc=['more@example.com', 'people@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000975
maruel@chromium.orga3353652011-11-30 14:26:57 +0000976 def test_reviewer_send_mail(self):
977 # --send-mail can be used without -r if R= is used
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000978 description = 'Foo Bar\nR=reviewer@example.com'
maruel@chromium.orga3353652011-11-30 14:26:57 +0000979 self._run_reviewer_test(
980 ['--send-mail'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000981 'desc\n\nBUG=',
maruel@chromium.orga3353652011-11-30 14:26:57 +0000982 description.strip('\n'),
983 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000984 ['--reviewers=reviewer@example.com', '--send_mail'])
maruel@chromium.orga3353652011-11-30 14:26:57 +0000985
986 def test_reviewer_send_mail_no_rev(self):
987 # Fails without a reviewer.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000988 stdout = StringIO.StringIO()
tandriic2405f52016-10-10 08:13:15 -0700989 self.calls = self._upload_no_rev_calls(None, None) + [
990 ((['DieWithError', 'Must specify reviewers to send email.'],),
991 SystemExitMock())
992 ]
993
994 def RunEditor(desc, _, **kwargs):
995 return desc
996 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
997 self.mock(sys, 'stdout', stdout)
998 with self.assertRaises(SystemExitMock):
maruel@chromium.orga3353652011-11-30 14:26:57 +0000999 git_cl.main(['upload', '--send-mail'])
tandriic2405f52016-10-10 08:13:15 -07001000 self.assertEqual(
1001 'Using 50% similarity for rename/copy detection. Override with '
1002 '--similarity.\n',
1003 stdout.getvalue())
maruel@chromium.orga3353652011-11-30 14:26:57 +00001004
tandriif9aefb72016-07-01 09:06:51 -07001005 def test_bug_on_cmd(self):
1006 self._run_reviewer_test(
1007 ['--bug=500658,proj:123'],
1008 'desc\n\nBUG=500658\nBUG=proj:123',
1009 '# Blah blah comment.\ndesc\n\nBUG=500658\nBUG=proj:1234',
1010 'desc\n\nBUG=500658\nBUG=proj:1234',
1011 [])
1012
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001013 def _land_rietveld_calls(self, repo_url, git_numberer_enabled=False,
1014 parent_msg=None,
1015 new_msg=None,
1016 fail_after_parent_msg=False,
1017 fail_cherry_pick=False,
1018 fail_push_count=0,
1019 debug=False):
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01001020 if debug:
1021 # Very useful due to finally clause in git cl land raising exceptions and
1022 # shadowing real cause of failure.
1023 self.mock(git_cl, '_IS_BEING_TESTED', True)
1024 else:
Andrii Shyshkalov06a25022016-11-24 16:47:00 +01001025 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01001026
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001027 if git_numberer_enabled:
1028 # Special mocks to check validity of timestamp.
1029 original_git_amend_head = git_cl._git_amend_head
1030 def _git_amend_head_mock(msg, tstamp):
1031 self._mocked_call(['git_amend_head committer timestamp', tstamp])
1032 return original_git_amend_head(msg, tstamp)
1033 self.mock(git_cl, '_git_amend_head', _git_amend_head_mock)
1034
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001035 self.mock(git_cl, '_is_git_numberer_enabled', lambda url, ref:
1036 self._mocked_call('_is_git_numberer_enabled', url, ref))
Andrii Shyshkalov06a25022016-11-24 16:47:00 +01001037 self.mock(RietveldMock, 'update_description', staticmethod(
1038 lambda i, d: self._mocked_call(['update_description', i, d])))
1039 self.mock(RietveldMock, 'add_comment', staticmethod(
1040 lambda i, c: self._mocked_call(['add_comment', i, c])))
1041 self.calls = [
Andrii Shyshkalov06a25022016-11-24 16:47:00 +01001042 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
1043 ((['git', 'config', 'branch.feature.git-cl-similarity'],), CERR1),
1044 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
1045 ((['git', 'config', '--bool', 'branch.feature.git-find-copies'],),
1046 CERR1),
1047 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
1048 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001049 ((['git', 'config', 'rietveld.autoupdate'],), ''),
Andrii Shyshkalov06a25022016-11-24 16:47:00 +01001050 ((['git', 'config', 'rietveld.server'],),
1051 'https://codereview.chromium.org'),
1052 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
1053 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1054 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
1055 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
Andrii Shyshkalov06a25022016-11-24 16:47:00 +01001056 ((['git', 'rev-list', '^feature', 'refs/remotes/origin/master'],),
1057 ''), # No commits to rebase, according to local view of origin.
1058 ((['git', 'merge-base', 'refs/remotes/origin/master', 'HEAD'],),
1059 'fake_ancestor_sha'),
1060 ] + self._git_sanity_checks('fake_ancestor_sha', 'feature') + [
1061 ((['git', 'rev-parse', '--show-cdup'],), ''),
1062 ((['git', 'rev-parse', 'HEAD'],), 'fake_sha'),
1063 ((['git', 'diff', '--name-status', '--no-renames', '-r',
1064 'fake_ancestor_sha...', '.'],),
1065 'M\tfile1.cpp'),
1066 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
1067 ((['git', 'config', 'branch.feature.rietveldserver'],),
1068 'https://codereview.chromium.org'),
1069 ((['git', 'config', 'user.email'],), 'user@e.mail'),
1070 ((['git', 'config', 'rietveld.tree-status-url'],), CERR1),
1071 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50',
1072 'fake_ancestor_sha', 'feature'],),
1073 # This command just prints smth like this:
1074 # file1.cpp | 53 ++++++--
1075 # 1 file changed, 33 insertions(+), 20 deletions(-)\n
1076 ''),
1077 ((['git', 'show-ref', '--quiet', '--verify',
1078 'refs/heads/git-cl-commit'],),
1079 ''), # 0 return code means branch exists.
1080 ((['git', 'branch', '-D', 'git-cl-commit'],), ''),
1081 ((['git', 'show-ref', '--quiet', '--verify',
1082 'refs/heads/git-cl-cherry-pick'],),
1083 CERR1), # This means git-cl-cherry-pick branch does not exist.
1084 ((['git', 'rev-parse', '--show-cdup'],), ''),
1085 ((['git', 'checkout', '-q', '-b', 'git-cl-commit'],), ''),
1086 ((['git', 'reset', '--soft', 'fake_ancestor_sha'],), ''),
1087 ((['git', 'commit', '-m',
1088 'Issue: 123\n\nR=john@chromium.org\n\n'
Andrii Shyshkalovf01be222016-12-08 19:21:13 +01001089 'Review-Url: https://codereview.chromium.org/123 .'],), ''),
Andrii Shyshkalov06a25022016-11-24 16:47:00 +01001090 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
1091 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1092 ((['git', 'config', '--get', 'remote.origin.url'],),
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001093 repo_url),
1094
1095 ((['git', 'config', 'remote.origin.url'],), repo_url),
1096 (('_is_git_numberer_enabled', repo_url, 'refs/heads/master'),
1097 git_numberer_enabled),
1098
1099 # Auto-rebase init.
1100 ((['git', 'rev-parse', 'HEAD'],), 'sha1_for_cherry_pick'),
1101 ]
1102 # Auto-rebase loops.
1103 for attempt in xrange(fail_push_count + 1):
1104 self.calls += [
1105 # Auto-rebase loop start.
1106 ((['git', 'retry', 'fetch', 'origin',
1107 '+refs/heads/master:refs/heads/git-cl-cherry-pick'],), ''),
1108 ((['git', 'checkout', 'refs/heads/git-cl-cherry-pick'],), ''),
1109 # NOTE: if fail_push_count>0, this sha1_of_parent should probably be
1110 # different in each loop iteration for truly realistic test.
1111 ((['git', 'rev-parse', 'HEAD'],), 'sha1_of_parent'),
1112 ((['git', 'cherry-pick', 'sha1_for_cherry_pick'],),
1113 callError(1, 'failed to cherry pick') if fail_cherry_pick
1114 else ''),
1115 ]
1116 if fail_cherry_pick:
1117 return
1118
1119 if git_numberer_enabled:
1120 assert parent_msg
1121 self.calls += [
1122 ((['git', 'show', '-s', '--format=%B', 'sha1_of_parent'],),
1123 parent_msg),
1124 ]
1125 if fail_after_parent_msg:
1126 return
1127 assert new_msg
1128 self.calls += [
1129 ((['git', 'show', '-s', '--format=%ct', 'sha1_of_parent'],),
1130 '1480022355'), # Committer's unix timestamp.
1131 ((['git', 'show', '-s', '--format=%ct', 'HEAD'],),
1132 '1480024000'),
1133 ((['git_amend_head committer timestamp', 1480024000],), ''),
1134 ((['git', 'commit', '--amend', '-m', new_msg],), ''),
1135 ]
1136 self.calls += [
1137 ((['git', 'push', '--porcelain', 'origin', 'HEAD:refs/heads/master'],),
1138 CERR1 if attempt < fail_push_count else ''),
1139 ]
1140 # End of autorebase + push.
1141
1142 self.calls += [
1143 ((['git', 'rev-parse', 'HEAD'],), 'sha1_committed'),
1144 ]
1145 if git_numberer_enabled:
1146 self.calls += [
1147 ((['git', 'show', '-s', '--format=%B', 'HEAD'],), new_msg),
1148 ]
1149
1150 # Cleanup calls.
1151 self.calls += [
1152 ((['git', 'checkout', '-q', 'feature'],), ''),
1153 ((['git', 'branch', '-D', 'git-cl-commit'],), ''),
1154 ((['git', 'branch', '-D', 'git-cl-cherry-pick'],), ''),
Andrii Shyshkalov06a25022016-11-24 16:47:00 +01001155 ]
1156
1157 def test_land_rietveld(self):
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001158 self._land_rietveld_calls(
1159 repo_url='https://chromium.googlesource.com/infra/infra',
1160 git_numberer_enabled=False,
1161 debug=False)
Andrii Shyshkalov06a25022016-11-24 16:47:00 +01001162 self.calls += [
Andrii Shyshkalov06a25022016-11-24 16:47:00 +01001163 ((['git', 'config', 'rietveld.viewvc-url'],),
1164 'https://chromium.googlesource.com/infra/infra/+/'),
1165 ((['update_description', 123,
1166 'Issue: 123\n\nR=john@chromium.org\n\nCommitted: '
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001167 'https://chromium.googlesource.com/infra/infra/+/sha1_committed'],),
Andrii Shyshkalov06a25022016-11-24 16:47:00 +01001168 ''),
1169 ((['add_comment', 123, 'Committed patchset #2 (id:20001) manually as '
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001170 'sha1_committed (presubmit successful).'],), ''),
Andrii Shyshkalov06a25022016-11-24 16:47:00 +01001171 ]
1172 git_cl.main(['land'])
1173
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001174 def test_land_rietveld_fail_cherry_pick(self):
1175 self._land_rietveld_calls(
1176 repo_url='https://chromium.googlesource.com/infra/infra',
1177 git_numberer_enabled=False,
1178 fail_cherry_pick=True,
1179 debug=False)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01001180 self.calls += [
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001181 ((['git', 'diff', '--name-status', '--diff-filter=U'],),
1182 'U path/file1\n'
1183 'U file2.cpp\n'),
1184 ((['git', 'cherry-pick', '--abort'],), ''),
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01001185 ((['git', 'checkout', '-q', 'feature'],), ''),
1186 ((['git', 'branch', '-D', 'git-cl-commit'],), ''),
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001187 ((['git', 'branch', '-D', 'git-cl-cherry-pick'],), ''),
1188 ]
1189 git_cl.main(['land'])
1190
1191 def test_land_rietveld_git_numberer_fail_1_push(self):
1192 return self.test_land_rietveld_git_numberer(fail_push_count=1)
1193
1194 def test_land_rietveld_git_numberer(self, fail_push_count=0):
1195 self._land_rietveld_calls(
1196 repo_url='https://chromium.googlesource.com/chromium/src',
1197 git_numberer_enabled=True,
1198 parent_msg=('This is parent commit.\n'
1199 '\n'
1200 'Cr-Commit-Position: refs/heads/master@{#543}\n'
1201 'Cr-Branched-From: refs/svn/2014@{#2208}'),
1202 new_msg=('Issue: 123\n\nR=john@chromium.org\n'
1203 '\n'
1204 'Review-Url: https://codereview.chromium.org/123 .\n'
1205 'Cr-Commit-Position: refs/heads/master@{#544}\n'
1206 'Cr-Branched-From: refs/svn/2014@{#2208}'),
1207 fail_push_count=fail_push_count,
1208 debug=False)
1209
1210 self.calls += [
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01001211 ((['git', 'config', 'rietveld.viewvc-url'],),
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001212 'https://chromium.googlesource.com/chromium/src/+/'),
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01001213 ((['update_description', 123,
1214 'Issue: 123\n\nR=john@chromium.org\n'
1215 '\n'
Andrii Shyshkalovf01be222016-12-08 19:21:13 +01001216 'Review-Url: https://codereview.chromium.org/123 .\n'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01001217 'Cr-Commit-Position: refs/heads/master@{#544}\n'
1218 'Cr-Branched-From: refs/svn/2014@{#2208}\n'
1219 'Committed: '
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001220 'https://chromium.googlesource.com/chromium/src/+/sha1_committed'],),
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01001221 ''),
1222 ((['add_comment', 123, 'Committed patchset #2 (id:20001) manually as '
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001223 'sha1_committed (presubmit successful).'],), ''),
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01001224 ]
1225 git_cl.main(['land'])
1226
1227 def test_land_rietveld_git_numberer_bad_parent(self):
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001228 self._land_rietveld_calls(
1229 repo_url='https://chromium.googlesource.com/v8/v8',
1230 git_numberer_enabled=True,
1231 parent_msg='This is parent commit with no footer.',
1232 fail_after_parent_msg=True,
1233 debug=False)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01001234 self.calls += [
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001235 # Cleanup calls to restore original state.
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01001236 ((['git', 'checkout', '-q', 'feature'],), ''),
1237 ((['git', 'branch', '-D', 'git-cl-commit'],), ''),
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01001238 ((['git', 'branch', '-D', 'git-cl-cherry-pick'],), ''),
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01001239 ]
1240 with self.assertRaises(ValueError) as cm:
1241 git_cl.main(['land'])
1242 self.assertEqual(cm.exception.message,
1243 'Unable to infer commit position from footers')
1244
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001245 def test_git_numberer_not_whitelisted_repo(self):
1246 self.calls = []
1247 res = git_cl._is_git_numberer_enabled(
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001248 remote_url='https://chromium.googlesource.com/chromium/tools/build',
1249 remote_ref='refs/whatever')
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001250 self.assertEqual(res, False)
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001251
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001252 def test_git_numberer_fail_fetch(self):
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001253 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1254 self.calls = [
1255 ((['git', 'fetch', 'https://chromium.googlesource.com/chromium/src',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001256 '+refs/meta/config:refs/git_cl/meta/config'],), CERR1),
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001257 ]
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001258 res = git_cl._is_git_numberer_enabled(
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001259 remote_url='https://chromium.googlesource.com/chromium/src',
1260 remote_ref='refs/whatever')
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001261 self.assertEqual(res, False)
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001262
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001263 def test_git_numberer_valid_configs(self):
Andrii Shyshkalov351c61d2017-01-21 20:40:16 +00001264 with git_cl.gclient_utils.temporary_directory() as tempdir:
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001265 @contextlib.contextmanager
Andrii Shyshkalov351c61d2017-01-21 20:40:16 +00001266 def fake_temporary_directory(**kwargs):
1267 yield tempdir
1268 self.mock(git_cl.gclient_utils, 'temporary_directory',
1269 fake_temporary_directory)
1270 self._test_GitNumbererState_valid_configs_inner(tempdir)
1271
1272 def _test_GitNumbererState_valid_configs_inner(self, tempdir):
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001273 self.calls = [
1274 ((['git', 'fetch', 'https://chromium.googlesource.com/chromium/src',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001275 '+refs/meta/config:refs/git_cl/meta/config'],), ''),
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001276 ((['git', 'show', 'refs/git_cl/meta/config:project.config'],),
1277 '''
1278 [plugin "git-numberer"]
1279 validate-enabled-refglob = refs/else/*
1280 validate-enabled-refglob = refs/heads/*
1281 validate-disabled-refglob = refs/heads/disabled
1282 validate-disabled-refglob = refs/branch-heads/*
1283 '''),
Andrii Shyshkalov351c61d2017-01-21 20:40:16 +00001284 ((['git', 'config', '-f', os.path.join(tempdir, 'project.config') ,
1285 '--get-all', 'plugin.git-numberer.validate-enabled-refglob'],),
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001286 'refs/else/*\n'
1287 'refs/heads/*\n'),
Andrii Shyshkalov351c61d2017-01-21 20:40:16 +00001288 ((['git', 'config', '-f', os.path.join(tempdir, 'project.config') ,
1289 '--get-all', 'plugin.git-numberer.validate-disabled-refglob'],),
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001290 'refs/heads/disabled\n'
1291 'refs/branch-heads/*\n'),
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001292 ] * 3 # 3 tests below have exactly the same IO.
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001293
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001294 res = git_cl._is_git_numberer_enabled(
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001295 remote_url='https://chromium.googlesource.com/chromium/src',
1296 remote_ref='refs/heads/test')
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001297 self.assertEqual(res, True)
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001298
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001299 res = git_cl._is_git_numberer_enabled(
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001300 remote_url='https://chromium.googlesource.com/chromium/src',
1301 remote_ref='refs/heads/disabled')
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001302 self.assertEqual(res, False)
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001303
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01001304 # Validator is disabled by default, even if it's not explicitly in disabled
Andrii Shyshkalovcbec8ef2016-12-09 13:54:51 +01001305 # refglobs.
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001306 res = git_cl._is_git_numberer_enabled(
Andrii Shyshkalovcbec8ef2016-12-09 13:54:51 +01001307 remote_url='https://chromium.googlesource.com/chromium/src',
1308 remote_ref='refs/arbitrary/ref')
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001309 self.assertEqual(res, False)
Andrii Shyshkalovcbec8ef2016-12-09 13:54:51 +01001310
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001311 @classmethod
tandrii@chromium.org28253532016-04-14 13:46:56 +00001312 def _gerrit_ensure_auth_calls(cls, issue=None, skip_auth_check=False):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00001313 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +00001314 if skip_auth_check:
1315 return [((cmd, ), 'true')]
1316
tandrii5d48c322016-08-18 16:19:37 -07001317 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001318 if issue:
1319 calls.extend([
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001320 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001321 ])
1322 calls.extend([
1323 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1324 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1325 ((['git', 'config', 'remote.origin.url'],),
1326 'https://chromium.googlesource.com/my/repo'),
1327 ((['git', 'config', 'remote.origin.url'],),
1328 'https://chromium.googlesource.com/my/repo'),
1329 ])
1330 return calls
1331
1332 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001333 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001334 fetched_status=None, other_cl_owner=None):
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001335 calls = [
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001336 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -07001337 ((['git', 'config', 'branch.master.git-cl-similarity'],),
tandrii5d48c322016-08-18 16:19:37 -07001338 CERR1),
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001339 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii5d48c322016-08-18 16:19:37 -07001340 ((['git', 'config', '--bool', 'branch.master.git-find-copies'],),
1341 CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001342 ]
1343 calls += cls._is_gerrit_calls(True)
1344 calls += [
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001345 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -07001346 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1347 ((['git', 'config', 'branch.master.gerritissue'],),
tandrii5d48c322016-08-18 16:19:37 -07001348 CERR1 if issue is None else str(issue)),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001349 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001350 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001351 ((['get_or_create_merge_base', 'master',
1352 'refs/remotes/origin/master'],),
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001353 'fake_ancestor_sha'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001354 # Calls to verify branch point is ancestor
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001355 ]
1356 calls += cls._gerrit_ensure_auth_calls(issue=issue)
1357
1358 if issue:
1359 calls += [
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001360 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001361 '123456',
1362 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001363 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001364 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001365 'change_id': '123456789',
1366 'current_revision': 'sha1_of_current_revision',
1367 'revisions': { 'sha1_of_current_revision': {
1368 'commit': {'message': fetched_description},
1369 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001370 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001371 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001372 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001373 if fetched_status == 'ABANDONED':
1374 calls += [
1375 (('DieWithError', 'Change https://chromium-review.googlesource.com/'
1376 '123456 has been abandoned, new uploads are not '
1377 'allowed'), SystemExitMock()),
1378 ]
1379 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001380 if other_cl_owner:
1381 calls += [
1382 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
1383 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001384
1385 calls += cls._git_sanity_checks('fake_ancestor_sha', 'master',
1386 get_remote_branch=False)
1387 calls += [
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001388 ((['git', 'rev-parse', '--show-cdup'],), ''),
1389 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001390
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001391 ((['git',
mcgrathr@chromium.org9249f642013-06-03 21:36:18 +00001392 'diff', '--name-status', '--no-renames', '-r',
1393 'fake_ancestor_sha...', '.'],),
ukai@chromium.orge8077812012-02-03 03:41:46 +00001394 'M\t.gitignore\n'),
tandrii33a46ff2016-08-23 05:53:40 -07001395 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001396 ]
1397
1398 if not issue:
1399 calls += [
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001400 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +00001401 'log', '--pretty=format:%s%n%n%b', 'fake_ancestor_sha...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001402 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001403 ]
1404
1405 calls += [
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001406 ((['git', 'config', 'user.email'],), 'me@example.com'),
1407 ((['git',
scottmgb84b5e32016-11-10 09:25:33 -08001408 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50',
1409 'fake_ancestor_sha', 'HEAD'],),
ukai@chromium.orge8077812012-02-03 03:41:46 +00001410 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001411 ]
1412 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +00001413
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001414 @classmethod
1415 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -07001416 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001417 expected_upstream_ref='origin/refs/heads/master',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001418 ref_suffix='', title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001419 post_amend_description=None, issue=None, cc=None,
1420 git_mirror=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +00001421 if post_amend_description is None:
1422 post_amend_description = description
tandriia60502f2016-06-20 02:01:53 -07001423 calls = []
bradnelsond975b302016-10-23 12:20:23 -07001424 cc = cc or []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001425
tandriia60502f2016-06-20 02:01:53 -07001426 if squash_mode == 'default':
1427 calls.extend([
1428 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
1429 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
1430 ])
1431 elif squash_mode in ('override_squash', 'override_nosquash'):
1432 calls.extend([
1433 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
1434 'true' if squash_mode == 'override_squash' else 'false'),
1435 ])
1436 else:
1437 assert squash_mode in ('squash', 'nosquash')
1438
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001439 # If issue is given, then description is fetched from Gerrit instead.
1440 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001441 calls += [
1442 ((['git', 'log', '--pretty=format:%s\n\n%b',
1443 'fake_ancestor_sha..HEAD'],),
1444 description)]
Aaron Gableb56ad332017-01-06 15:24:31 -08001445 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001446 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -08001447 else:
1448 if not title:
1449 calls += [
1450 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001451 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -08001452 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001453 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +00001454 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001455 calls += [
tandrii@chromium.org10625002016-03-04 20:03:47 +00001456 # DownloadGerritHook(False)
1457 ((False, ),
1458 ''),
1459 # Amending of commit message to get the Change-Id.
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001460 ((['git', 'log', '--pretty=format:%s\n\n%b',
sbc@chromium.org5e07e062013-02-28 23:55:44 +00001461 'fake_ancestor_sha..HEAD'],),
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001462 description),
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001463 ((['git', 'commit', '--amend', '-m', description],),
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001464 ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001465 ((['git', 'log', '--pretty=format:%s\n\n%b',
sbc@chromium.org5e07e062013-02-28 23:55:44 +00001466 'fake_ancestor_sha..HEAD'],),
tandrii@chromium.org10625002016-03-04 20:03:47 +00001467 post_amend_description)
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001468 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001469 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001470 if not issue:
1471 # Prompting to edit description on first upload.
1472 calls += [
1473 ((['git', 'config', 'core.editor'],), ''),
1474 ((['RunEditor'],), description),
1475 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001476 ref_to_push = 'abcdef0123456789'
1477 calls += [
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001478 ((['git', 'config', 'branch.master.merge'],),
1479 'refs/heads/master'),
1480 ((['git', 'config', 'branch.master.remote'],),
1481 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001482 ((['get_or_create_merge_base', 'master',
1483 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001484 'origin/master'),
1485 ((['git', 'rev-parse', 'HEAD:'],),
1486 '0123456789abcdef'),
1487 ((['git', 'commit-tree', '0123456789abcdef', '-p',
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001488 'origin/master', '-m', description],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001489 ref_to_push),
1490 ]
1491 else:
1492 ref_to_push = 'HEAD'
1493
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001494 calls += [
luqui@chromium.org609f3952015-05-04 22:47:04 +00001495 ((['git', 'rev-list',
1496 expected_upstream_ref + '..' + ref_to_push],), ''),
ukai@chromium.orge8077812012-02-03 03:41:46 +00001497 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001498
Aaron Gable9b713dd2016-12-14 16:04:21 -08001499 if title:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001500 if ref_suffix:
1501 ref_suffix += ',m=' + title
1502 else:
1503 ref_suffix = '%m=' + title
Aaron Gable9b713dd2016-12-14 16:04:21 -08001504
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001505 notify_suffix = 'notify=%s' % ('ALL' if notify else 'NONE')
1506 if ref_suffix:
1507 ref_suffix += ',' + notify_suffix
1508 else:
1509 ref_suffix = '%' + notify_suffix
1510
1511 if reviewers:
1512 ref_suffix += ',' + ','.join('r=%s' % email
1513 for email in sorted(reviewers))
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001514
1515 if git_mirror is None:
1516 calls += [
1517 ((['git', 'config', 'remote.origin.url'],),
1518 'https://chromium.googlesource.com/yyy/zzz'),
1519 ]
1520 else:
1521 calls += [
1522 ((['git', 'config', 'remote.origin.url'],),
1523 '/cache/this-dir-exists'),
1524 (('os.path.isdir', '/cache/this-dir-exists'),
1525 True),
1526 # Runs in /cache/this-dir-exists.
1527 ((['git', 'config', 'remote.origin.url'],),
1528 'https://chromium.googlesource.com/yyy/zzz'),
1529 ]
1530
ukai@chromium.orge8077812012-02-03 03:41:46 +00001531 calls += [
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001532 ((['git', 'push',
1533 'https://chromium.googlesource.com/yyy/zzz',
1534 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001535 ('remote:\n'
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001536 'remote: Processing changes: (\)\n'
1537 'remote: Processing changes: (|)\n'
1538 'remote: Processing changes: (/)\n'
1539 'remote: Processing changes: (-)\n'
1540 'remote: Processing changes: new: 1 (/)\n'
1541 'remote: Processing changes: new: 1, done\n'
1542 'remote:\n'
1543 'remote: New Changes:\n'
1544 'remote: https://chromium-review.googlesource.com/123456 XXX.\n'
1545 'remote:\n'
1546 'To https://chromium.googlesource.com/yyy/zzz\n'
1547 ' * [new branch] hhhh -> refs/for/refs/heads/master\n')),
ukai@chromium.orge8077812012-02-03 03:41:46 +00001548 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001549 if squash:
1550 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001551 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001552 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001553 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001554 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001555 ((['git', 'config', 'branch.master.gerritsquashhash',
1556 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001557 ]
tandrii88189772016-09-29 04:29:57 -07001558 calls += [
1559 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001560 (('AddReviewers', 'chromium-review.googlesource.com',
tandrii88189772016-09-29 04:29:57 -07001561 123456 if squash else None,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001562 ['joe@example.com'] + cc, False, notify), ''),
tandrii88189772016-09-29 04:29:57 -07001563 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001564 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001565 return calls
1566
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001567 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001568 self,
1569 upload_args,
1570 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001571 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001572 squash=True,
1573 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001574 expected_upstream_ref='origin/refs/heads/master',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001575 ref_suffix='',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001576 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001577 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001578 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001579 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001580 cc=None,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001581 git_mirror=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001582 fetched_status=None,
1583 other_cl_owner=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001584 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001585 if squash_mode is None:
1586 if '--no-squash' in upload_args:
1587 squash_mode = 'nosquash'
1588 elif '--squash' in upload_args:
1589 squash_mode = 'squash'
1590 else:
1591 squash_mode = 'default'
1592
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001593 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001594 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001595 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001596 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001597 CookiesAuthenticatorMockFactory(
1598 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001599 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1600 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001601 self.mock(git_cl.gclient_utils, 'RunEditor',
1602 lambda *_, **__: self._mocked_call(['RunEditor']))
1603 self.mock(git_cl, 'DownloadGerritHook', self._mocked_call)
1604
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001605 original_os_path_isdir = os.path.isdir
1606 def selective_os_path_isdir_mock(path):
1607 if path == '/cache/this-dir-exists':
1608 return self._mocked_call('os.path.isdir', path)
1609 return original_os_path_isdir(path)
1610 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
1611
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001612 self.calls = self._gerrit_base_calls(
1613 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001614 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001615 fetched_status=fetched_status,
1616 other_cl_owner=other_cl_owner)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001617 if fetched_status != 'ABANDONED':
1618 self.calls += self._gerrit_upload_calls(
1619 description, reviewers, squash,
1620 squash_mode=squash_mode,
1621 expected_upstream_ref=expected_upstream_ref,
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001622 ref_suffix=ref_suffix, title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001623 post_amend_description=post_amend_description,
1624 issue=issue, cc=cc, git_mirror=git_mirror)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001625 # Uncomment when debugging.
1626 # print '\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls)))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001627 git_cl.main(['upload'] + upload_args)
1628
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001629 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001630 self._run_gerrit_upload_test(
1631 ['--no-squash'],
1632 'desc\n\nBUG=\n',
1633 [],
1634 squash=False,
1635 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
1636
1637 def test_gerrit_upload_without_change_id_override_nosquash(self):
tandrii@chromium.org10625002016-03-04 20:03:47 +00001638 self.mock(git_cl, 'DownloadGerritHook', self._mocked_call)
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001639 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001640 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001641 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001642 [],
tandriia60502f2016-06-20 02:01:53 -07001643 squash=False,
1644 squash_mode='override_nosquash',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001645 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001646
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001647 def test_gerrit_no_reviewer(self):
1648 self._run_gerrit_upload_test(
1649 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001650 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001651 [],
1652 squash=False,
1653 squash_mode='override_nosquash')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001654
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001655 def test_gerrit_patch_bad_chars(self):
1656 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1657 self._run_gerrit_upload_test(
1658 ['-f', '-t', 'Don\'t put bad cha,.rs'],
1659 'desc\n\nBUG=\n\nChange-Id: I123456789',
1660 squash=False,
1661 squash_mode='override_nosquash',
1662 title='Dont_put_bad_chars')
1663 self.assertIn(
1664 'WARNING: Patchset title may only contain alphanumeric chars '
1665 'and spaces. You can edit it in the UI. See https://crbug.com/663787.\n'
1666 'Cleaned up title: Dont put bad chars\n',
1667 git_cl.sys.stdout.getvalue())
1668
ukai@chromium.orge8077812012-02-03 03:41:46 +00001669 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001670 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001671 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001672 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001673 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001674 squash=False,
1675 squash_mode='override_nosquash',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001676 notify=True)
ukai@chromium.orge8077812012-02-03 03:41:46 +00001677
1678 def test_gerrit_reviewer_multiple(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001679 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001680 [],
bradnelsond975b302016-10-23 12:20:23 -07001681 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1682 'CC=more@example.com,people@example.com\n\n'
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001683 'Change-Id: 123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001684 ['reviewer@example.com', 'another@example.com'],
1685 squash=False,
tandrii99a72f22016-08-17 14:33:24 -07001686 squash_mode='override_nosquash',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001687 ref_suffix='%l=Code-Review+1',
bradnelsond975b302016-10-23 12:20:23 -07001688 cc=['more@example.com', 'people@example.com'])
tandriia60502f2016-06-20 02:01:53 -07001689
1690 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001691 self._run_gerrit_upload_test(
1692 [],
1693 'desc\nBUG=\n\nChange-Id: 123456789',
1694 [],
1695 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001696
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001697 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001698 self._run_gerrit_upload_test(
1699 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001700 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001701 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001702 squash=True,
1703 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001704
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001705 def test_gerrit_upload_squash_first_with_mirror(self):
1706 self._run_gerrit_upload_test(
1707 ['--squash'],
1708 'desc\nBUG=\n\nChange-Id: 123456789',
1709 [],
1710 squash=True,
1711 expected_upstream_ref='origin/master',
1712 git_mirror='https://chromium.googlesource.com/yyy/zzz')
1713
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001714 def test_gerrit_upload_squash_reupload(self):
1715 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001716 self._run_gerrit_upload_test(
1717 ['--squash'],
1718 description,
1719 [],
1720 squash=True,
1721 expected_upstream_ref='origin/master',
1722 issue=123456)
1723
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001724 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1725 self.mock(git_cl, 'DieWithError',
1726 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1727 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1728 with self.assertRaises(SystemExitMock):
1729 self._run_gerrit_upload_test(
1730 ['--squash'],
1731 description,
1732 [],
1733 squash=True,
1734 expected_upstream_ref='origin/master',
1735 issue=123456,
1736 fetched_status='ABANDONED')
1737
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001738 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1739 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1740 lambda *_, **__: {'email': 'yet-another@example.com'})
1741 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1742 self._run_gerrit_upload_test(
1743 ['--squash'],
1744 description,
1745 [],
1746 squash=True,
1747 expected_upstream_ref='origin/master',
1748 issue=123456,
1749 other_cl_owner='other@example.com')
1750 self.assertIn(
1751 'WARNING: change 123456 is owned by other@example.com, but you '
1752 'authenticate to Gerrit as yet-another@example.com.\n'
1753 'Uploading may fail due to lack of permissions',
1754 git_cl.sys.stdout.getvalue())
1755
rmistry@google.com2dd99862015-06-22 12:22:18 +00001756 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001757 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001758 def mock_run_git(*args, **_kwargs):
1759 if args[0] == ['for-each-ref',
1760 '--format=%(refname:short) %(upstream:short)',
1761 'refs/heads']:
1762 # Create a local branch dependency tree that looks like this:
1763 # test1 -> test2 -> test3 -> test4 -> test5
1764 # -> test3.1
1765 # test6 -> test0
1766 branch_deps = [
1767 'test2 test1', # test1 -> test2
1768 'test3 test2', # test2 -> test3
1769 'test3.1 test2', # test2 -> test3.1
1770 'test4 test3', # test3 -> test4
1771 'test5 test4', # test4 -> test5
1772 'test6 test0', # test0 -> test6
1773 'test7', # test7
1774 ]
1775 return '\n'.join(branch_deps)
1776 self.mock(git_cl, 'RunGit', mock_run_git)
1777
1778 class RecordCalls:
1779 times_called = 0
1780 record_calls = RecordCalls()
1781 def mock_CMDupload(*args, **_kwargs):
1782 record_calls.times_called += 1
1783 return 0
1784 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1785
1786 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001787 (('ask_for_data', 'This command will checkout all dependent branches '
1788 'and run "git cl upload". Press Enter to continue, '
1789 'or Ctrl+C to abort'), ''),
1790 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001791
1792 class MockChangelist():
1793 def __init__(self):
1794 pass
1795 def GetBranch(self):
1796 return 'test1'
1797 def GetIssue(self):
1798 return '123'
1799 def GetPatchset(self):
1800 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001801 def IsGerrit(self):
1802 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001803
1804 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1805 # CMDupload should have been called 5 times because of 5 dependent branches.
1806 self.assertEquals(5, record_calls.times_called)
1807 self.assertEquals(0, ret)
1808
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001809 def test_gerrit_change_id(self):
1810 self.calls = [
1811 ((['git', 'write-tree'], ),
1812 'hashtree'),
1813 ((['git', 'rev-parse', 'HEAD~0'], ),
1814 'branch-parent'),
1815 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1816 'A B <a@b.org> 1456848326 +0100'),
1817 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1818 'C D <c@d.org> 1456858326 +0100'),
1819 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1820 'hashchange'),
1821 ]
1822 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1823 self.assertEqual(change_id, 'Ihashchange')
1824
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001825 def test_desecription_append_footer(self):
1826 for init_desc, footer_line, expected_desc in [
1827 # Use unique desc first lines for easy test failure identification.
1828 ('foo', 'R=one', 'foo\n\nR=one'),
1829 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1830 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1831 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1832 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1833 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1834 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1835 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1836 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1837 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1838 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1839 ]:
1840 desc = git_cl.ChangeDescription(init_desc)
1841 desc.append_footer(footer_line)
1842 self.assertEqual(desc.description, expected_desc)
1843
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001844 def test_update_reviewers(self):
1845 data = [
1846 ('foo', [], 'foo'),
agable@chromium.org42c20792013-09-12 17:34:49 +00001847 ('foo\nR=xx', [], 'foo\nR=xx'),
1848 ('foo\nTBR=xx', [], 'foo\nTBR=xx'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001849 ('foo', ['a@c'], 'foo\n\nR=a@c'),
agable@chromium.org42c20792013-09-12 17:34:49 +00001850 ('foo\nR=xx', ['a@c'], 'foo\n\nR=a@c, xx'),
1851 ('foo\nTBR=xx', ['a@c'], 'foo\n\nR=a@c\nTBR=xx'),
1852 ('foo\nTBR=xx\nR=yy', ['a@c'], 'foo\n\nR=a@c, yy\nTBR=xx'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001853 ('foo\nBUG=', ['a@c'], 'foo\nBUG=\nR=a@c'),
agable@chromium.org42c20792013-09-12 17:34:49 +00001854 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], 'foo\n\nR=a@c, xx, bar\nTBR=yy'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001855 ('foo', ['a@c', 'b@c'], 'foo\n\nR=a@c, b@c'),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001856 ('foo\nBar\n\nR=\nBUG=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='),
1857 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='),
1858 # Same as the line before, but full of whitespaces.
1859 (
1860 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'],
1861 'foo\nBar\n\nR=c@c\n BUG =',
1862 ),
1863 # Whitespaces aren't interpreted as new lines.
1864 ('foo BUG=allo R=joe ', ['c@c'], 'foo BUG=allo R=joe\n\nR=c@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001865 ]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001866 expected = [i[2] for i in data]
1867 actual = []
1868 for orig, reviewers, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001869 obj = git_cl.ChangeDescription(orig)
1870 obj.update_reviewers(reviewers)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001871 actual.append(obj.description)
1872 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001873
wittman@chromium.org455dc922015-01-26 20:15:50 +00001874 def test_get_target_ref(self):
1875 # Check remote or remote branch not present.
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001876 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001877 self.assertEqual(None, git_cl.GetTargetRef(None,
1878 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001879 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001880
wittman@chromium.org455dc922015-01-26 20:15:50 +00001881 # Check default target refs for branches.
1882 self.assertEqual('refs/heads/master',
1883 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001884 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001885 self.assertEqual('refs/heads/master',
1886 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001887 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001888 self.assertEqual('refs/heads/master',
1889 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001890 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001891 self.assertEqual('refs/branch-heads/123',
1892 git_cl.GetTargetRef('origin',
1893 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001894 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001895 self.assertEqual('refs/diff/test',
1896 git_cl.GetTargetRef('origin',
1897 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001898 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001899 self.assertEqual('refs/heads/chrome/m42',
1900 git_cl.GetTargetRef('origin',
1901 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001902 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001903
1904 # Check target refs for user-specified target branch.
1905 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1906 'refs/remotes/branch-heads/123'):
1907 self.assertEqual('refs/branch-heads/123',
1908 git_cl.GetTargetRef('origin',
1909 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001910 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001911 for branch in ('origin/master', 'remotes/origin/master',
1912 'refs/remotes/origin/master'):
1913 self.assertEqual('refs/heads/master',
1914 git_cl.GetTargetRef('origin',
1915 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001916 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001917 for branch in ('master', 'heads/master', 'refs/heads/master'):
1918 self.assertEqual('refs/heads/master',
1919 git_cl.GetTargetRef('origin',
1920 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001921 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001922
wychen@chromium.orga872e752015-04-28 23:42:18 +00001923 def test_patch_when_dirty(self):
1924 # Patch when local tree is dirty
1925 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1926 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1927
1928 def test_diff_when_dirty(self):
1929 # Do 'git cl diff' when local tree is dirty
1930 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1931 self.assertNotEqual(git_cl.main(['diff']), 0)
1932
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001933 @staticmethod
1934 def _get_gerrit_codereview_server_calls(branch, value=None,
1935 git_short_host='host',
1936 detect_branch=True):
1937 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1938
1939 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1940 """
1941 calls = []
1942 if detect_branch:
1943 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
1944 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1945 CERR1 if value is None else value))
1946 if value is None:
1947 calls += [
1948 ((['git', 'config', 'branch.' + branch + '.merge'],),
1949 'refs/heads' + branch),
1950 ((['git', 'config', 'branch.' + branch + '.remote'],),
1951 'origin'),
1952 ((['git', 'config', 'remote.origin.url'],),
1953 'https://%s.googlesource.com/my/repo' % git_short_host),
1954 ]
1955 return calls
1956
tandriidf09a462016-08-18 16:23:55 -07001957 def _patch_common(self, is_gerrit=False, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001958 new_branch=False, git_short_host='host',
1959 detect_gerrit_server=True):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001960 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001961 self.mock(git_cl._RietveldChangelistImpl, 'GetMostRecentPatchset',
1962 lambda x: '60001')
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001963 self.mock(git_cl._RietveldChangelistImpl, 'FetchDescription',
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001964 lambda *a, **kw: 'Description')
wychen@chromium.orga872e752015-04-28 23:42:18 +00001965 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1966
tandriidf09a462016-08-18 16:23:55 -07001967 if new_branch:
1968 self.calls = [((['git', 'new-branch', 'master'],), ''),]
1969 else:
1970 self.calls = [((['git', 'symbolic-ref', 'HEAD'],), 'master')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001971
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001972 if not force_codereview:
1973 # These calls detect codereview to use.
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00001974 self.calls += [
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001975 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -07001976 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1977 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
tandrii5d48c322016-08-18 16:19:37 -07001978 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001979 ]
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001980
1981 if is_gerrit:
1982 if not force_codereview:
1983 self.calls += [
1984 ((['git', 'config', 'gerrit.host'],), 'true'),
1985 ]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001986 if detect_gerrit_server:
1987 self.calls += self._get_gerrit_codereview_server_calls(
1988 'master', git_short_host=git_short_host,
1989 detect_branch=not new_branch and force_codereview)
1990
1991 self.calls += [
1992 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001993 '123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001994 {
1995 'current_revision': '7777777777',
1996 'revisions': {
1997 '1111111111': {
1998 '_number': 1,
1999 'fetch': {'http': {
2000 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
2001 'ref': 'refs/changes/56/123456/1',
2002 }},
2003 },
2004 '7777777777': {
2005 '_number': 7,
2006 'fetch': {'http': {
2007 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
2008 'ref': 'refs/changes/56/123456/7',
2009 }},
2010 },
2011 },
2012 }),
2013 ]
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002014 else:
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002015 self.calls += [
tandrii5d48c322016-08-18 16:19:37 -07002016 ((['git', 'config', 'gerrit.host'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002017 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
skobes6468b902016-10-24 08:45:10 -07002018 ((['git', 'config', 'branch.master.rietveldserver',],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002019 ((['git', 'rev-parse', '--show-cdup'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002020 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00002021
tandriidf09a462016-08-18 16:23:55 -07002022 def _common_patch_successful(self, new_branch=False):
2023 self._patch_common(new_branch=new_branch)
wychen@chromium.orga872e752015-04-28 23:42:18 +00002024 self.calls += [
tandrii33a46ff2016-08-23 05:53:40 -07002025 ((['git', 'config', 'branch.master.rietveldissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07002026 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002027 ((['git', 'config', 'branch.master.rietveldserver',
2028 'https://codereview.example.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07002029 ((['git', 'config', 'branch.master.rietveldpatchset', '60001'],),
tandrii5d48c322016-08-18 16:19:37 -07002030 ''),
Aaron Gabled343c632017-03-15 11:02:26 -07002031 ((['git', 'commit', '-m',
2032 'Description\n\n' +
2033 'patch from issue 123456 at patchset 60001 ' +
2034 '(http://crrev.com/123456#ps60001)'],), ''),
wychen@chromium.orga872e752015-04-28 23:42:18 +00002035 ]
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00002036
2037 def test_patch_successful(self):
2038 self._common_patch_successful()
wychen@chromium.orga872e752015-04-28 23:42:18 +00002039 self.assertEqual(git_cl.main(['patch', '123456']), 0)
2040
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00002041 def test_patch_successful_new_branch(self):
tandriidf09a462016-08-18 16:23:55 -07002042 self._common_patch_successful(new_branch=True)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00002043 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
2044
wychen@chromium.orga872e752015-04-28 23:42:18 +00002045 def test_patch_conflict(self):
2046 self._patch_common()
skobes6468b902016-10-24 08:45:10 -07002047 GitCheckoutMock.conflict = True
wychen@chromium.orga872e752015-04-28 23:42:18 +00002048 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
wittman@chromium.org455dc922015-01-26 20:15:50 +00002049
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002050 def test_gerrit_patch_successful(self):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002051 self._patch_common(is_gerrit=True, git_short_host='chromium',
2052 detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002053 self.calls += [
2054 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
2055 'refs/changes/56/123456/7'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07002056 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07002057 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002058 ((['git', 'config', 'branch.master.gerritserver',
2059 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07002060 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gabled343c632017-03-15 11:02:26 -07002061 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002062 ]
2063 self.assertEqual(git_cl.main(['patch', '123456']), 0)
2064
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002065 def test_patch_force_codereview(self):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002066 self._patch_common(is_gerrit=True, force_codereview=True,
2067 git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002068 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002069 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002070 'refs/changes/56/123456/7'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07002071 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07002072 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002073 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002074 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07002075 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gabled343c632017-03-15 11:02:26 -07002076 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002077 ]
2078 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456']), 0)
2079
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002080 def test_gerrit_patch_url_successful(self):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002081 self._patch_common(is_gerrit=True, git_short_host='else',
2082 detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002083 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002084 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002085 'refs/changes/56/123456/1'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07002086 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07002087 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002088 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002089 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07002090 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gabled343c632017-03-15 11:02:26 -07002091 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002092 ]
2093 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002094 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002095
2096 def test_gerrit_patch_conflict(self):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002097 self._patch_common(is_gerrit=True, detect_gerrit_server=False,
2098 git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002099 self.calls += [
2100 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
2101 'refs/changes/56/123456/1'],), ''),
Aaron Gabled343c632017-03-15 11:02:26 -07002102 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
2103 ''),
2104 ((['git', 'config', 'branch.master.gerritserver',
2105 'https://chromium-review.googlesource.com'],), ''),
2106 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07002107 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
2108 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
2109 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002110 ]
2111 with self.assertRaises(SystemExitMock):
2112 git_cl.main(['patch',
2113 'https://chromium-review.googlesource.com/#/c/123456/1'])
2114
tandriic2405f52016-10-10 08:13:15 -07002115 def test_gerrit_patch_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002116 def notExists(_issue, *_, **kwargs):
2117 self.assertFalse(kwargs['ignore_404'])
2118 raise git_cl.gerrit_util.GerritError(404, '')
2119 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
2120
tandriic2405f52016-10-10 08:13:15 -07002121 url = 'https://chromium-review.googlesource.com'
tandriic2405f52016-10-10 08:13:15 -07002122 self.calls = [
2123 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2124 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2125 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
2126 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
2127 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2128 ((['git', 'config', 'gerrit.host'],), 'true'),
Aaron Gablea45ee112016-11-22 15:14:38 -08002129 ((['DieWithError', 'change 123456 at ' + url + ' does not exist '
tandriic2405f52016-10-10 08:13:15 -07002130 'or you have no access to it'],), SystemExitMock()),
2131 ]
2132 with self.assertRaises(SystemExitMock):
2133 self.assertEqual(1, git_cl.main(['patch', url + '/#/c/123456/1']))
2134
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002135 def _checkout_calls(self):
2136 return [
2137 ((['git', 'config', '--local', '--get-regexp',
2138 'branch\\..*\\.rietveldissue'], ),
2139 ('branch.retrying.rietveldissue 1111111111\n'
2140 'branch.some-fix.rietveldissue 2222222222\n')),
2141 ((['git', 'config', '--local', '--get-regexp',
2142 'branch\\..*\\.gerritissue'], ),
2143 ('branch.ger-branch.gerritissue 123456\n'
2144 'branch.gbranch654.gerritissue 654321\n')),
2145 ]
2146
2147 def test_checkout_gerrit(self):
2148 """Tests git cl checkout <issue>."""
2149 self.calls = self._checkout_calls()
2150 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
2151 self.assertEqual(0, git_cl.main(['checkout', '123456']))
2152
2153 def test_checkout_rietveld(self):
2154 """Tests git cl checkout <issue>."""
2155 self.calls = self._checkout_calls()
2156 self.calls += [((['git', 'checkout', 'some-fix'], ), '')]
2157 self.assertEqual(0, git_cl.main(['checkout', '2222222222']))
2158
2159 def test_checkout_not_found(self):
2160 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00002161 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002162 self.calls = self._checkout_calls()
2163 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2164
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002165 def test_checkout_no_branch_issues(self):
2166 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00002167 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002168 self.calls = [
2169 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07002170 'branch\\..*\\.rietveldissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002171 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07002172 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002173 ]
2174 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2175
tandrii@chromium.org28253532016-04-14 13:46:56 +00002176 def _test_gerrit_ensure_authenticated_common(self, auth,
2177 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002178 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2179 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
2180 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11002181 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00002182 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002183 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00002184 cl.branch = 'master'
2185 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002186 cl.lookedup_issue = True
2187 return cl
2188
2189 def test_gerrit_ensure_authenticated_missing(self):
2190 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002191 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002192 })
2193 self.calls.append(
2194 ((['DieWithError',
2195 'Credentials for the following hosts are required:\n'
2196 ' chromium-review.googlesource.com\n'
2197 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002198 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002199 'https://chromium-review.googlesource.com/new-password'],), ''),)
2200 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2201
2202 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00002203 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002204 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002205 'chromium.googlesource.com':
2206 ('git-one.example.com', None, 'secret1'),
2207 'chromium-review.googlesource.com':
2208 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002209 })
2210 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002211 (('ask_for_data', 'If you know what you are doing '
2212 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002213 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2214
2215 def test_gerrit_ensure_authenticated_ok(self):
2216 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002217 'chromium.googlesource.com':
2218 ('git-same.example.com', None, 'secret'),
2219 'chromium-review.googlesource.com':
2220 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002221 })
2222 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2223
tandrii@chromium.org28253532016-04-14 13:46:56 +00002224 def test_gerrit_ensure_authenticated_skipped(self):
2225 cl = self._test_gerrit_ensure_authenticated_common(
2226 auth={}, skip_auth_check=True)
2227 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2228
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002229 def test_cmd_set_commit_rietveld(self):
tandrii4d843592016-07-27 08:22:56 -07002230 self.mock(git_cl._RietveldChangelistImpl, 'SetFlags',
2231 lambda _, v: self._mocked_call(['SetFlags', v]))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002232 self.calls = [
2233 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002234 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002235 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2236 ((['git', 'config', 'rietveld.server'],), ''),
2237 ((['git', 'config', 'rietveld.server'],), ''),
2238 ((['git', 'config', 'branch.feature.rietveldserver'],),
2239 'https://codereview.chromium.org'),
tandrii4d843592016-07-27 08:22:56 -07002240 ((['SetFlags', {'commit': '1', 'cq_dry_run': '0'}], ), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002241 ]
2242 self.assertEqual(0, git_cl.main(['set-commit']))
2243
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002244 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002245 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002246 lambda h, i, labels, notify=None:
2247 self._mocked_call(['SetReview', h, i, labels, notify]))
2248
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002249 self.calls = [
2250 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002251 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2252 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002253 ((['git', 'config', 'branch.feature.gerritserver'],),
2254 'https://chromium-review.googlesource.com'),
2255 ((['SetReview', 'chromium-review.googlesource.com', 123,
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002256 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002257 ]
tandriid9e5ce52016-07-13 02:32:59 -07002258
2259 def test_cmd_set_commit_gerrit_clear(self):
2260 self._cmd_set_commit_gerrit_common(0)
2261 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2262
2263 def test_cmd_set_commit_gerrit_dry(self):
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002264 self._cmd_set_commit_gerrit_common(1, notify='NONE')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002265 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2266
tandriid9e5ce52016-07-13 02:32:59 -07002267 def test_cmd_set_commit_gerrit(self):
2268 self._cmd_set_commit_gerrit_common(2)
2269 self.assertEqual(0, git_cl.main(['set-commit']))
2270
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002271 def test_description_display(self):
2272 out = StringIO.StringIO()
2273 self.mock(git_cl.sys, 'stdout', out)
2274
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002275 self.mock(git_cl, 'Changelist', ChangelistMock)
2276 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002277
2278 self.assertEqual(0, git_cl.main(['description', '-d']))
2279 self.assertEqual('foo\n', out.getvalue())
2280
2281 def test_description_rietveld(self):
2282 out = StringIO.StringIO()
2283 self.mock(git_cl.sys, 'stdout', out)
martiniss6eda05f2016-06-30 10:18:35 -07002284 self.mock(git_cl.Changelist, 'GetDescription', lambda *args: 'foobar')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002285
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002286 self.assertEqual(0, git_cl.main([
2287 'description', 'https://code.review.org/123123', '-d', '--rietveld']))
2288 self.assertEqual('foobar\n', out.getvalue())
2289
iannucci3c972b92016-08-17 13:24:10 -07002290 def test_StatusFieldOverrideIssueMissingArgs(self):
2291 out = StringIO.StringIO()
2292 self.mock(git_cl.sys, 'stderr', out)
2293
2294 try:
2295 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2296 except SystemExit as ex:
2297 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002298 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002299
2300 out = StringIO.StringIO()
2301 self.mock(git_cl.sys, 'stderr', out)
2302
2303 try:
2304 self.assertEqual(git_cl.main(['status', '--issue', '1', '--rietveld']), 0)
2305 except SystemExit as ex:
2306 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002307 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002308
2309 def test_StatusFieldOverrideIssue(self):
2310 out = StringIO.StringIO()
2311 self.mock(git_cl.sys, 'stdout', out)
2312
2313 def assertIssue(cl_self, *_args):
2314 self.assertEquals(cl_self.issue, 1)
2315 return 'foobar'
2316
2317 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2318 self.calls = [
2319 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2320 ((['git', 'config', 'rietveld.server'],), ''),
2321 ((['git', 'config', 'rietveld.server'],), ''),
2322 ]
iannuccie53c9352016-08-17 14:40:40 -07002323 self.assertEqual(
2324 git_cl.main(['status', '--issue', '1', '--rietveld', '--field', 'desc']),
2325 0)
iannucci3c972b92016-08-17 13:24:10 -07002326 self.assertEqual(out.getvalue(), 'foobar\n')
2327
iannuccie53c9352016-08-17 14:40:40 -07002328 def test_SetCloseOverrideIssue(self):
2329 def assertIssue(cl_self, *_args):
2330 self.assertEquals(cl_self.issue, 1)
2331 return 'foobar'
2332
2333 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2334 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
2335 self.calls = [
2336 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2337 ((['git', 'config', 'rietveld.server'],), ''),
2338 ((['git', 'config', 'rietveld.server'],), ''),
2339 ]
2340 self.assertEqual(
2341 git_cl.main(['set-close', '--issue', '1', '--rietveld']), 0)
2342
2343 def test_SetCommitOverrideIssue(self):
2344 def assertIssue(cl_self, *_args):
2345 self.assertEquals(cl_self.issue, 1)
2346 return 'foobar'
2347
2348 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2349 self.mock(git_cl.Changelist, 'SetCQState', lambda *_: None)
2350 self.calls = [
2351 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2352 ((['git', 'config', 'rietveld.server'],), ''),
2353 ((['git', 'config', 'rietveld.server'],), ''),
2354 ((['git', 'symbolic-ref', 'HEAD'],), ''),
2355 ((['git', 'config', 'rietveld.server'],), ''),
2356 ((['git', 'config', 'rietveld.server'],), ''),
2357 ]
2358 self.assertEqual(
2359 git_cl.main(['set-close', '--issue', '1', '--rietveld']), 0)
2360
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002361 def test_description_gerrit(self):
2362 out = StringIO.StringIO()
2363 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002364 self.calls = [
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002365 (('GetChangeDetail', 'code.review.org',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002366 '123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2367 {
2368 'current_revision': 'sha1',
2369 'revisions': {'sha1': {
2370 'commit': {'message': 'foobar'},
2371 }},
2372 }),
2373 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002374 self.assertEqual(0, git_cl.main([
2375 'description', 'https://code.review.org/123123', '-d', '--gerrit']))
2376 self.assertEqual('foobar\n', out.getvalue())
2377
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002378 def test_description_set_raw(self):
2379 out = StringIO.StringIO()
2380 self.mock(git_cl.sys, 'stdout', out)
2381
2382 self.mock(git_cl, 'Changelist', ChangelistMock)
2383 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2384
2385 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2386 self.assertEqual('hihi', ChangelistMock.desc)
2387
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002388 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002389 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002390
2391 def RunEditor(desc, _, **kwargs):
2392 self.assertEquals(
2393 '# Enter a description of the change.\n'
2394 '# This will be displayed on the codereview site.\n'
2395 '# The first line will also be used as the subject of the review.\n'
2396 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002397 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002398 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002399 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002400 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002401 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002402
dsansomee2d6fd92016-09-08 00:10:47 -07002403 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002404 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002405
2406 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2407 self.mock(git_cl.Changelist, 'GetDescription',
2408 lambda *args: current_desc)
2409 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2410 UpdateDescriptionRemote)
2411 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2412
2413 self.calls = [
2414 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002415 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002416 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2417 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002418 ((['git', 'config', 'core.editor'],), 'vi'),
2419 ]
2420 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2421
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002422 def test_description_set_stdin(self):
2423 out = StringIO.StringIO()
2424 self.mock(git_cl.sys, 'stdout', out)
2425
2426 self.mock(git_cl, 'Changelist', ChangelistMock)
2427 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2428
2429 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2430 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2431
kmarshall3bff56b2016-06-06 18:31:47 -07002432 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002433 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2434
kmarshall3bff56b2016-06-06 18:31:47 -07002435 self.calls = \
2436 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2437 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
tandrii33a46ff2016-08-23 05:53:40 -07002438 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
tandrii5d48c322016-08-18 16:19:37 -07002439 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2440 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
tandrii33a46ff2016-08-23 05:53:40 -07002441 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2442 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2443 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002444 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2445 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2446 ((['git', 'branch', '-D', 'foo'],), '')]
2447
kmarshall3bff56b2016-06-06 18:31:47 -07002448 self.mock(git_cl, 'get_cl_statuses',
2449 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002450 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2451 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2452 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002453
2454 self.assertEqual(0, git_cl.main(['archive', '-f']))
2455
2456 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002457 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002458 self.calls = \
2459 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2460 'refs/heads/master'),
tandrii33a46ff2016-08-23 05:53:40 -07002461 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
tandrii5d48c322016-08-18 16:19:37 -07002462 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2463 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
kmarshall3bff56b2016-06-06 18:31:47 -07002464 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2465
kmarshall9249e012016-08-23 12:02:16 -07002466 self.mock(git_cl, 'get_cl_statuses',
2467 lambda branches, fine_grained, max_processes:
2468 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2469
2470 self.assertEqual(1, git_cl.main(['archive', '-f']))
2471
2472 def test_archive_dry_run(self):
2473 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2474
2475 self.calls = \
2476 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2477 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2478 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
2479 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2480 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2481 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2482 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2483 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2484 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002485
2486 self.mock(git_cl, 'get_cl_statuses',
2487 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002488 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2489 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2490 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002491
kmarshall9249e012016-08-23 12:02:16 -07002492 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2493
2494 def test_archive_no_tags(self):
2495 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2496
2497 self.calls = \
2498 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2499 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2500 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
2501 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2502 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2503 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2504 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2505 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2506 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2507 ((['git', 'branch', '-D', 'foo'],), '')]
2508
2509 self.mock(git_cl, 'get_cl_statuses',
2510 lambda branches, fine_grained, max_processes:
2511 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2512 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2513 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2514
2515 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002516
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002517 def test_cmd_issue_erase_existing(self):
2518 out = StringIO.StringIO()
2519 self.mock(git_cl.sys, 'stdout', out)
2520 self.calls = [
2521 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002522 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2523 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002524 # Let this command raise exception (retcode=1) - it should be ignored.
2525 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002526 CERR1),
2527 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2528 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002529 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2530 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2531 ''),
2532 ]
2533 self.assertEqual(0, git_cl.main(['issue', '0']))
2534
phajdan.jre328cf92016-08-22 04:12:17 -07002535 def test_cmd_issue_json(self):
2536 out = StringIO.StringIO()
2537 self.mock(git_cl.sys, 'stdout', out)
2538 self.calls = [
2539 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002540 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
phajdan.jre328cf92016-08-22 04:12:17 -07002541 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2542 ((['git', 'config', 'rietveld.server'],),
2543 'https://codereview.chromium.org'),
2544 ((['git', 'config', 'branch.feature.rietveldserver'],), ''),
2545 (('write_json', 'output.json',
2546 {'issue': 123, 'issue_url': 'https://codereview.chromium.org/123'}),
2547 ''),
2548 ]
2549 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2550
tandriide281ae2016-10-12 06:02:30 -07002551 def test_git_cl_try_default_cq_dry_run(self):
tandrii9de9ec62016-07-13 03:01:59 -07002552 self.mock(git_cl.Changelist, 'GetChange',
2553 lambda _, *a: (
2554 self._mocked_call(['GetChange']+list(a))))
2555 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2556 lambda *_, **__: (
2557 self._mocked_call(['DoGetTryMasters'])))
tandrii9de9ec62016-07-13 03:01:59 -07002558 self.mock(git_cl._RietveldChangelistImpl, 'SetCQState',
2559 lambda _, s: self._mocked_call(['SetCQState', s]))
2560 self.calls = [
2561 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002562 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
tandrii9de9ec62016-07-13 03:01:59 -07002563 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2564 ((['git', 'config', 'rietveld.server'],),
2565 'https://codereview.chromium.org'),
2566 ((['git', 'config', 'branch.feature.rietveldserver'],), ''),
2567 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2568 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2569 ((['get_or_create_merge_base', 'feature', 'feature'],),
2570 'fake_ancestor_sha'),
2571 ((['GetChange', 'fake_ancestor_sha', None], ),
2572 git_cl.presubmit_support.GitChange(
2573 '', '', '', '', '', '', '', '')),
2574 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2575 ((['DoGetTryMasters'], ), None),
tandrii9de9ec62016-07-13 03:01:59 -07002576 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2577 ]
2578 out = StringIO.StringIO()
2579 self.mock(git_cl.sys, 'stdout', out)
2580 self.assertEqual(0, git_cl.main(['try']))
2581 self.assertEqual(
2582 out.getvalue(),
2583 'scheduled CQ Dry Run on https://codereview.chromium.org/123\n')
2584
tandrii8c5a3532016-11-04 07:52:02 -07002585 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2586 self.mock(git_cl.Changelist, 'GetChange',
2587 lambda _, *a: (
2588 self._mocked_call(['GetChange']+list(a))))
2589 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2590 lambda *_, **__: (
2591 self._mocked_call(['DoGetTryMasters'])))
2592 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2593 lambda _, s: self._mocked_call(['SetCQState', s]))
2594
tandrii8c5a3532016-11-04 07:52:02 -07002595 self.calls = [
2596 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2597 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2598 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2599 ((['git', 'config', 'branch.feature.gerritserver'],),
2600 'https://chromium-review.googlesource.com'),
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002601 (('GetChangeDetail', 'chromium-review.googlesource.com', '123456',
2602 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2603 'project': 'depot_tools',
2604 'status': 'OPEN',
2605 'owner': {'email': 'owner@e.mail'},
2606 'revisions': {
2607 'deadbeaf': {
2608 '_number': 6,
2609 },
2610 'beeeeeef': {
2611 '_number': 7,
2612 'fetch': {'http': {
2613 'url': 'https://chromium.googlesource.com/depot_tools',
2614 'ref': 'refs/changes/56/123456/7'
2615 }},
2616 },
2617 },
2618 }),
tandrii8c5a3532016-11-04 07:52:02 -07002619 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2620 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2621 ((['get_or_create_merge_base', 'feature', 'feature'],),
2622 'fake_ancestor_sha'),
2623 ((['GetChange', 'fake_ancestor_sha', None], ),
2624 git_cl.presubmit_support.GitChange(
2625 '', '', '', '', '', '', '', '')),
2626 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2627 ((['DoGetTryMasters'], ), None),
2628 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2629 ]
2630 out = StringIO.StringIO()
2631 self.mock(git_cl.sys, 'stdout', out)
2632 self.assertEqual(0, git_cl.main(['try']))
2633 self.assertEqual(
2634 out.getvalue(),
2635 'scheduled CQ Dry Run on '
2636 'https://chromium-review.googlesource.com/123456\n')
2637
2638 def test_git_cl_try_buildbucket_with_properties_rietveld(self):
2639 self.mock(git_cl._RietveldChangelistImpl, 'GetIssueProperties',
2640 lambda _: {
2641 'owner_email': 'owner@e.mail',
2642 'private': False,
2643 'closed': False,
2644 'project': 'depot_tools',
2645 'patchsets': [20001],
2646 })
tandriide281ae2016-10-12 06:02:30 -07002647 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2648 self.calls = [
2649 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2650 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
2651 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2652 ((['git', 'config', 'rietveld.server'],),
2653 'https://codereview.chromium.org'),
tandriide281ae2016-10-12 06:02:30 -07002654 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
tandrii8c5a3532016-11-04 07:52:02 -07002655 ((['git', 'config', 'branch.feature.rietveldserver'],), CERR1),
tandriide281ae2016-10-12 06:02:30 -07002656 ]
2657
2658 def _buildbucket_retry(*_, **kw):
2659 # self.maxDiff = 10000
2660 body = json.loads(kw['body'])
2661 self.assertEqual(len(body['builds']), 1)
2662 build = body['builds'][0]
2663 params = json.loads(build.pop('parameters_json'))
2664 self.assertEqual(params, {
2665 u'builder_name': u'win',
2666 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2667 u'revision': None}],
2668 u'properties': {
2669 u'category': u'git_cl_try',
2670 u'issue': 123,
2671 u'key': u'val',
2672 u'json': [{u'a': 1}, None],
2673 u'master': u'tryserver.chromium',
2674 u'patch_project': u'depot_tools',
2675 u'patch_storage': u'rietveld',
2676 u'patchset': 20001,
tandriide281ae2016-10-12 06:02:30 -07002677 u'rietveld': u'https://codereview.chromium.org',
2678 }
2679 })
2680 self.assertEqual(build, {
2681 u'bucket': u'master.tryserver.chromium',
2682 u'client_operation_id': u'uuid4',
2683 u'tags': [u'builder:win',
2684 u'buildset:patch/rietveld/codereview.chromium.org/123/20001',
borenet6c0efe62016-10-19 08:13:29 -07002685 u'user_agent:git_cl_try',
2686 u'master:tryserver.chromium'],
tandriide281ae2016-10-12 06:02:30 -07002687 })
2688
2689 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2690
2691 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2692 self.assertEqual(0, git_cl.main([
2693 'try', '-m', 'tryserver.chromium', '-b', 'win',
2694 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2695 self.assertRegexpMatches(
2696 git_cl.sys.stdout.getvalue(),
borenet6c0efe62016-10-19 08:13:29 -07002697 'Tried jobs on:\nBucket: master.tryserver.chromium')
2698
tandrii8c5a3532016-11-04 07:52:02 -07002699 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2700 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2701 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2702
tandrii8c5a3532016-11-04 07:52:02 -07002703 self.calls = [
2704 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2705 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2706 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2707 ((['git', 'config', 'branch.feature.gerritserver'],),
2708 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002709 (('GetChangeDetail', 'chromium-review.googlesource.com', '123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002710 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002711 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002712 'status': 'OPEN',
2713 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002714 'revisions': {
2715 'deadbeaf': {
2716 '_number': 6,
2717 },
2718 'beeeeeef': {
2719 '_number': 7,
2720 'fetch': {'http': {
2721 'url': 'https://chromium.googlesource.com/depot_tools',
2722 'ref': 'refs/changes/56/123456/7'
2723 }},
2724 },
2725 },
2726 }),
2727 ]
2728
2729 def _buildbucket_retry(*_, **kw):
2730 # self.maxDiff = 10000
2731 body = json.loads(kw['body'])
2732 self.assertEqual(len(body['builds']), 1)
2733 build = body['builds'][0]
2734 params = json.loads(build.pop('parameters_json'))
2735 self.assertEqual(params, {
2736 u'builder_name': u'win',
2737 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2738 u'revision': None}],
2739 u'properties': {
2740 u'category': u'git_cl_try',
2741 u'key': u'val',
2742 u'json': [{u'a': 1}, None],
2743 u'master': u'tryserver.chromium',
2744
2745 u'patch_gerrit_url':
2746 u'https://chromium-review.googlesource.com',
2747 u'patch_issue': 123456,
2748 u'patch_project': u'depot_tools',
2749 u'patch_ref': u'refs/changes/56/123456/7',
2750 u'patch_repository_url':
2751 u'https://chromium.googlesource.com/depot_tools',
2752 u'patch_set': 7,
2753 u'patch_storage': u'gerrit',
2754 }
2755 })
2756 self.assertEqual(build, {
2757 u'bucket': u'master.tryserver.chromium',
2758 u'client_operation_id': u'uuid4',
2759 u'tags': [
2760 u'builder:win',
2761 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2762 u'user_agent:git_cl_try',
2763 u'master:tryserver.chromium'],
2764 })
2765
2766 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2767
2768 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2769 self.assertEqual(0, git_cl.main([
2770 'try', '-m', 'tryserver.chromium', '-b', 'win',
2771 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2772 self.assertRegexpMatches(
2773 git_cl.sys.stdout.getvalue(),
2774 'Tried jobs on:\nBucket: master.tryserver.chromium')
2775
borenet6c0efe62016-10-19 08:13:29 -07002776 def test_git_cl_try_buildbucket_bucket_flag(self):
tandrii8c5a3532016-11-04 07:52:02 -07002777 self.mock(git_cl._RietveldChangelistImpl, 'GetIssueProperties',
2778 lambda _: {
2779 'owner_email': 'owner@e.mail',
2780 'private': False,
2781 'closed': False,
2782 'project': 'depot_tools',
2783 'patchsets': [20001],
2784 })
borenet6c0efe62016-10-19 08:13:29 -07002785 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2786 self.calls = [
2787 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2788 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
2789 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2790 ((['git', 'config', 'rietveld.server'],),
2791 'https://codereview.chromium.org'),
borenet6c0efe62016-10-19 08:13:29 -07002792 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
tandrii8c5a3532016-11-04 07:52:02 -07002793 ((['git', 'config', 'branch.feature.rietveldserver'],), CERR1),
borenet6c0efe62016-10-19 08:13:29 -07002794 ]
2795
2796 def _buildbucket_retry(*_, **kw):
borenet6c0efe62016-10-19 08:13:29 -07002797 body = json.loads(kw['body'])
2798 self.assertEqual(len(body['builds']), 1)
2799 build = body['builds'][0]
2800 params = json.loads(build.pop('parameters_json'))
2801 self.assertEqual(params, {
2802 u'builder_name': u'win',
2803 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2804 u'revision': None}],
2805 u'properties': {
2806 u'category': u'git_cl_try',
2807 u'issue': 123,
2808 u'patch_project': u'depot_tools',
2809 u'patch_storage': u'rietveld',
2810 u'patchset': 20001,
borenet6c0efe62016-10-19 08:13:29 -07002811 u'rietveld': u'https://codereview.chromium.org',
2812 }
2813 })
2814 self.assertEqual(build, {
2815 u'bucket': u'test.bucket',
2816 u'client_operation_id': u'uuid4',
2817 u'tags': [u'builder:win',
2818 u'buildset:patch/rietveld/codereview.chromium.org/123/20001',
2819 u'user_agent:git_cl_try'],
2820 })
2821
2822 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2823
2824 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2825 self.assertEqual(0, git_cl.main([
2826 'try', '-B', 'test.bucket', '-b', 'win']))
2827 self.assertRegexpMatches(
2828 git_cl.sys.stdout.getvalue(),
2829 'Tried jobs on:\nBucket: test.bucket')
tandriide281ae2016-10-12 06:02:30 -07002830
qyearsley123a4682016-10-26 09:12:17 -07002831 def test_git_cl_try_bots_on_multiple_masters(self):
2832 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 20001)
2833 self.calls = [
2834 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2835 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
2836 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2837 ((['git', 'config', 'rietveld.server'],),
tandrii8c5a3532016-11-04 07:52:02 -07002838 'https://codereview.chromium.org'),
qyearsley123a4682016-10-26 09:12:17 -07002839 ((['git', 'config', 'branch.feature.rietveldserver'],), CERR1),
2840 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
2841 ]
2842
2843 def _buildbucket_retry(*_, **kw):
2844 body = json.loads(kw['body'])
2845 self.assertEqual(len(body['builds']), 2)
2846
2847 first_build_params = json.loads(body['builds'][0]['parameters_json'])
2848 self.assertEqual(first_build_params['builder_name'], 'builder1')
2849 self.assertEqual(first_build_params['properties']['master'], 'master1')
2850
2851 first_build_params = json.loads(body['builds'][1]['parameters_json'])
2852 self.assertEqual(first_build_params['builder_name'], 'builder2')
2853 self.assertEqual(first_build_params['properties']['master'], 'master2')
2854
2855 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2856
2857 self.mock(git_cl.urllib2, 'urlopen', lambda _: StringIO.StringIO(
2858 json.dumps({'builder1': ['master1'], 'builder2': ['master2']})))
2859
2860 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2861 self.assertEqual(
2862 0, git_cl.main(['try', '-b', 'builder1', '-b', 'builder2']))
2863 self.assertEqual(
2864 git_cl.sys.stdout.getvalue(),
2865 'Tried jobs on:\n'
2866 'Bucket: master.master1\n'
2867 ' builder1: []\n'
2868 'Bucket: master.master2\n'
2869 ' builder2: []\n'
2870 'To see results here, run: git cl try-results\n'
2871 'To see results in browser, run: git cl web\n')
2872
tandrii16e0b4e2016-06-07 10:34:28 -07002873 def _common_GerritCommitMsgHookCheck(self):
2874 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2875 self.mock(git_cl.os.path, 'abspath',
2876 lambda path: self._mocked_call(['abspath', path]))
2877 self.mock(git_cl.os.path, 'exists',
2878 lambda path: self._mocked_call(['exists', path]))
2879 self.mock(git_cl.gclient_utils, 'FileRead',
2880 lambda path: self._mocked_call(['FileRead', path]))
2881 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2882 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2883 self.calls = [
2884 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2885 ((['abspath', '../'],), '/abs/git_repo_root'),
2886 ]
2887 return git_cl.Changelist(codereview='gerrit', issue=123)
2888
2889 def test_GerritCommitMsgHookCheck_custom_hook(self):
2890 cl = self._common_GerritCommitMsgHookCheck()
2891 self.calls += [
2892 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2893 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2894 '#!/bin/sh\necho "custom hook"')
2895 ]
2896 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2897
2898 def test_GerritCommitMsgHookCheck_not_exists(self):
2899 cl = self._common_GerritCommitMsgHookCheck()
2900 self.calls += [
2901 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2902 ]
2903 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2904
2905 def test_GerritCommitMsgHookCheck(self):
2906 cl = self._common_GerritCommitMsgHookCheck()
2907 self.calls += [
2908 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2909 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2910 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002911 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002912 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2913 ''),
2914 ]
2915 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2916
tandriic4344b52016-08-29 06:04:54 -07002917 def test_GerritCmdLand(self):
2918 self.calls += [
2919 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2920 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2921 'deadbeaf'),
2922 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2923 ((['git', 'config', 'branch.feature.gerritserver'],),
2924 'chromium-review.googlesource.com'),
2925 ]
2926 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2927 cl._codereview_impl._GetChangeDetail = lambda _: {
2928 'labels': {},
2929 'current_revision': 'deadbeaf',
2930 }
agable32978d92016-11-01 12:55:02 -07002931 cl._codereview_impl._GetChangeCommit = lambda: {
2932 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002933 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002934 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2935 }
tandriic4344b52016-08-29 06:04:54 -07002936 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002937 out = StringIO.StringIO()
2938 self.mock(sys, 'stdout', out)
tandriic4344b52016-08-29 06:04:54 -07002939 self.assertEqual(0, cl.CMDLand(force=True, bypass_hooks=True, verbose=True))
tandrii8da412c2016-09-07 16:01:07 -07002940 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
agable32978d92016-11-01 12:55:02 -07002941 self.assertRegexpMatches(out.getvalue(), 'Landed as .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002942
tandrii221ab252016-10-06 08:12:04 -07002943 BUILDBUCKET_BUILDS_MAP = {
2944 '9000': {
2945 'id': '9000',
2946 'status': 'STARTED',
2947 'url': 'http://build.cr.org/p/x.y/builders/my-builder/builds/2',
2948 'result_details_json': '{"properties": {}}',
2949 'bucket': 'master.x.y',
2950 'created_by': 'user:someone@chromium.org',
2951 'created_ts': '147200002222000',
2952 'parameters_json': '{"builder_name": "my-builder", "category": ""}',
2953 },
2954 '8000': {
2955 'id': '8000',
2956 'status': 'COMPLETED',
2957 'result': 'FAILURE',
2958 'failure_reason': 'BUILD_FAILURE',
2959 'url': 'http://build.cr.org/p/x.y/builders/my-builder/builds/1',
2960 'result_details_json': '{"properties": {}}',
2961 'bucket': 'master.x.y',
2962 'created_by': 'user:someone@chromium.org',
2963 'created_ts': '147200001111000',
2964 'parameters_json': '{"builder_name": "my-builder", "category": ""}',
2965 },
2966 }
2967
2968 def test_write_try_results_json(self):
2969 expected_output = [
2970 {
2971 'buildbucket_id': '8000',
2972 'bucket': 'master.x.y',
2973 'builder_name': 'my-builder',
2974 'status': 'COMPLETED',
2975 'result': 'FAILURE',
2976 'failure_reason': 'BUILD_FAILURE',
2977 'url': 'http://build.cr.org/p/x.y/builders/my-builder/builds/1',
2978 },
2979 {
2980 'buildbucket_id': '9000',
2981 'bucket': 'master.x.y',
2982 'builder_name': 'my-builder',
2983 'status': 'STARTED',
2984 'result': None,
2985 'failure_reason': None,
2986 'url': 'http://build.cr.org/p/x.y/builders/my-builder/builds/2',
2987 }
2988 ]
2989 self.calls = [(('write_json', 'output.json', expected_output), '')]
2990 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2991
tandrii45b2a582016-10-11 03:14:16 -07002992 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002993 out = StringIO.StringIO()
2994 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002995 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2996 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002997 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2998 self._mocked_call(['get_authenticator_for_host', host]))
2999 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
3000 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07003001
3002 def _setup_fetch_try_jobs_rietveld(self, *request_results):
3003 self._setup_fetch_try_jobs(most_recent_patchset=20001)
tandrii221ab252016-10-06 08:12:04 -07003004 self.calls += [
3005 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
3006 ((['git', 'config', 'branch.feature.rietveldissue'],), '1'),
3007 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
3008 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
3009 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
3010 ((['git', 'config', 'branch.feature.rietveldserver'],),
3011 'codereview.example.com'),
3012 ((['get_authenticator_for_host', 'codereview.example.com'],),
3013 AuthenticatorMock()),
3014 ] + [((['_buildbucket_retry'],), r) for r in request_results]
3015
3016 def test_fetch_try_jobs_none_rietveld(self):
3017 self._setup_fetch_try_jobs_rietveld({})
tandrii45b2a582016-10-11 03:14:16 -07003018 # Simulate that user isn't logged in.
3019 self.mock(AuthenticatorMock, 'has_cached_credentials', lambda _: False)
tandrii221ab252016-10-06 08:12:04 -07003020 self.assertEqual(0, git_cl.main(['try-results']))
tandrii45b2a582016-10-11 03:14:16 -07003021 self.assertRegexpMatches(sys.stdout.getvalue(),
3022 'Warning: Some results might be missing')
tandrii221ab252016-10-06 08:12:04 -07003023 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
3024
3025 def test_fetch_try_jobs_some_rietveld(self):
3026 self._setup_fetch_try_jobs_rietveld({
3027 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
3028 })
3029 self.assertEqual(0, git_cl.main(['try-results']))
tandrii45b2a582016-10-11 03:14:16 -07003030 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
3031 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
3032 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
3033
3034 def _setup_fetch_try_jobs_gerrit(self, *request_results):
3035 self._setup_fetch_try_jobs(most_recent_patchset=13)
3036 self.calls += [
3037 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
3038 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
3039 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05003040 # TODO(tandrii): Uncomment the below if we decide to support checking
3041 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07003042 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05003043 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07003044 ((['git', 'config', 'branch.feature.gerritserver'],),
3045 'https://x-review.googlesource.com'),
3046 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
3047 AuthenticatorMock()),
3048 ] + [((['_buildbucket_retry'],), r) for r in request_results]
3049
3050 def test_fetch_try_jobs_none_gerrit(self):
3051 self._setup_fetch_try_jobs_gerrit({})
3052 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05003053 # TODO(tandrii): Uncomment the below if we decide to support checking
3054 # patchsets for Gerrit.
3055 # self.assertRegexpMatches(
3056 # sys.stdout.getvalue(),
3057 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07003058 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
3059
3060 def test_fetch_try_jobs_some_gerrit(self):
3061 self._setup_fetch_try_jobs_gerrit({
3062 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
3063 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05003064 # TODO(tandrii): Uncomment the below if we decide to support checking
3065 # patchsets for Gerrit.
3066 # self.calls.remove(
3067 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07003068 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
3069
3070 # ... and doesn't result in warning.
3071 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
3072 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07003073 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
3074 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
3075
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003076 def _mock_gerrit_changes_for_detail_cache(self):
3077 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003078
3079 def test_gerrit_change_detail_cache_normalize(self):
3080 self._mock_gerrit_changes_for_detail_cache()
3081 self.calls = [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01003082 (('GetChangeDetail', 'host', '2', ['CASE']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003083 ]
3084 cl = git_cl.Changelist(codereview='gerrit')
3085 self.assertEqual(cl._GetChangeDetail(issue=2, options=['CaSe']), 'b')
3086 self.assertEqual(cl._GetChangeDetail(issue=2, options=['CASE']), 'b')
3087 self.assertEqual(cl._GetChangeDetail(issue='2'), 'b')
3088 self.assertEqual(cl._GetChangeDetail(issue=2), 'b')
3089
3090 def test_gerrit_change_detail_cache_simple(self):
3091 self._mock_gerrit_changes_for_detail_cache()
3092 self.calls = [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01003093 (('GetChangeDetail', 'host', '1', []), 'a'),
3094 (('GetChangeDetail', 'host', '2', []), 'b'),
3095 (('GetChangeDetail', 'host', '2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003096 ]
3097 cl = git_cl.Changelist(issue=1, codereview='gerrit')
3098 self.assertEqual(cl._GetChangeDetail(), 'a') # Miss.
3099 self.assertEqual(cl._GetChangeDetail(), 'a')
3100 self.assertEqual(cl._GetChangeDetail(issue=2), 'b') # Miss.
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003101 self.assertEqual(cl._GetChangeDetail(issue=2, no_cache=True), 'b2') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003102 self.assertEqual(cl._GetChangeDetail(), 'a')
3103 self.assertEqual(cl._GetChangeDetail(issue=2), 'b2')
3104
3105 def test_gerrit_change_detail_cache_options(self):
3106 self._mock_gerrit_changes_for_detail_cache()
3107 self.calls = [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01003108 (('GetChangeDetail', 'host', '1', ['C', 'A', 'B']), 'cab'),
3109 (('GetChangeDetail', 'host', '1', ['A', 'D']), 'ad'),
3110 (('GetChangeDetail', 'host', '1', ['A']), 'a'), # no_cache=True
3111 (('GetChangeDetail', 'host', '1', ['B']), 'b'), # no longer in cache.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003112 ]
3113 cl = git_cl.Changelist(issue=1, codereview='gerrit')
3114 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
3115 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
3116 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
3117 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
3118 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
3119 self.assertEqual(cl._GetChangeDetail(), 'cab')
3120
3121 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
3122 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
3123 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
3124 self.assertEqual(cl._GetChangeDetail(), 'cab')
3125
3126 # Finally, no_cache should invalidate all caches for given change.
3127 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
3128 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
3129
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01003130 def test_gerrit_description_caching(self):
3131 def gen_detail(rev, desc):
3132 return {
3133 'current_revision': rev,
3134 'revisions': {rev: {'commit': {'message': desc}}}
3135 }
3136 self.calls = [
3137 (('GetChangeDetail', 'host', '1',
3138 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
3139 gen_detail('rev1', 'desc1')),
3140 (('GetChangeDetail', 'host', '1',
3141 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
3142 gen_detail('rev2', 'desc2')),
3143 ]
3144
3145 self._mock_gerrit_changes_for_detail_cache()
3146 cl = git_cl.Changelist(issue=1, codereview='gerrit')
3147 self.assertEqual(cl.GetDescription(), 'desc1')
3148 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
3149 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00003150
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003151 def test_print_current_creds(self):
3152 class CookiesAuthenticatorMock(object):
3153 def __init__(self):
3154 self.gitcookies = {
3155 'host.googlesource.com': ('user', 'pass'),
3156 'host-review.googlesource.com': ('user', 'pass'),
3157 }
3158 self.netrc = self
3159 self.netrc.hosts = {
3160 'github.com': ('user2', None, 'pass2'),
3161 'host2.googlesource.com': ('user3', None, 'pass'),
3162 }
3163 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
3164 CookiesAuthenticatorMock)
3165 self.mock(sys, 'stdout', StringIO.StringIO())
3166 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
3167 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
3168 ' Host\t User\t Which file',
3169 '============================\t=====\t===========',
3170 'host-review.googlesource.com\t user\t.gitcookies',
3171 ' host.googlesource.com\t user\t.gitcookies',
3172 ' host2.googlesource.com\tuser3\t .netrc',
3173 ])
3174 sys.stdout.buf = ''
3175 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
3176 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
3177 ' Host\tUser\t Which file',
3178 '============================\t====\t===========',
3179 'host-review.googlesource.com\tuser\t.gitcookies',
3180 ' host.googlesource.com\tuser\t.gitcookies',
3181 ])
3182
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003183 def _common_creds_check_mocks(self):
3184 def exists_mock(path):
3185 dirname = os.path.dirname(path)
3186 if dirname == os.path.expanduser('~'):
3187 dirname = '~'
3188 base = os.path.basename(path)
3189 if base in ('.netrc', '.gitcookies'):
3190 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
3191 # git cl also checks for existence other files not relevant to this test.
3192 return None
3193 self.mock(os.path, 'exists', exists_mock)
3194 self.mock(sys, 'stdout', StringIO.StringIO())
3195
3196 def test_creds_check_gitcookies_not_configured(self):
3197 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003198 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003199 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003200 self.calls = [
3201 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
3202 (('os.path.exists', '~/.netrc'), True),
3203 (('ask_for_data', 'Press Enter to setup .gitcookies, '
3204 'or Ctrl+C to abort'), ''),
3205 ((['git', 'config', '--global', 'http.cookiefile',
3206 os.path.expanduser('~/.gitcookies')], ), ''),
3207 ]
3208 self.assertEqual(0, git_cl.main(['creds-check']))
3209 self.assertRegexpMatches(
3210 sys.stdout.getvalue(),
3211 '^You seem to be using outdated .netrc for git credentials:')
3212 self.assertRegexpMatches(
3213 sys.stdout.getvalue(),
3214 '\nConfigured git to use .gitcookies from')
3215
3216 def test_creds_check_gitcookies_configured_custom_broken(self):
3217 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003218 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003219 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003220 self.calls = [
3221 ((['git', 'config', '--global', 'http.cookiefile'],),
3222 '/custom/.gitcookies'),
3223 (('os.path.exists', '/custom/.gitcookies'), False),
3224 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
3225 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
3226 ((['git', 'config', '--global', 'http.cookiefile',
3227 os.path.expanduser('~/.gitcookies')], ), ''),
3228 ]
3229 self.assertEqual(0, git_cl.main(['creds-check']))
3230 self.assertRegexpMatches(
3231 sys.stdout.getvalue(),
3232 'WARNING: you have configured custom path to .gitcookies: ')
3233 self.assertRegexpMatches(
3234 sys.stdout.getvalue(),
3235 'However, your configured .gitcookies file is missing.')
3236
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003237 def test_git_cl_comment_add_rietveld(self):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01003238 self.mock(git_cl._RietveldChangelistImpl, 'AddComment',
3239 lambda _, message: self._mocked_call('AddComment', message))
3240 self.calls = [
3241 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
3242 ((['git', 'config', 'rietveld.server'],), 'codereview.chromium.org'),
3243 (('AddComment', 'msg'), ''),
3244 ]
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003245 self.assertEqual(0, git_cl.main(['comment', '--rietveld',
3246 '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01003247
3248 def test_git_cl_comment_add_gerrit(self):
3249 self.mock(git_cl.gerrit_util, 'SetReview',
3250 lambda host, change, msg:
3251 self._mocked_call('SetReview', host, change, msg))
3252 self.calls = [
3253 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
3254 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
3255 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3256 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3257 'origin/master'),
3258 ((['git', 'config', 'remote.origin.url'],),
3259 'https://chromium.googlesource.com/infra/infra'),
3260 (('SetReview', 'chromium-review.googlesource.com', 10, 'msg'), None),
3261 ]
3262 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
3263 '-a', 'msg']))
3264
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003265 def test_git_cl_comments_fetch_rietveld(self):
3266 self.mock(sys, 'stdout', StringIO.StringIO())
3267 self.calls = [
3268 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
3269 ((['git', 'config', 'rietveld.server'],), 'codereview.chromium.org'),
3270 ] * 2
3271 self.mock(git_cl._RietveldChangelistImpl, 'GetIssueProperties', lambda _: {
3272 'messages': [
3273 {'text': 'lgtm', 'date': '2017-03-13 20:49:34.515270',
3274 'disapproval': False, 'approval': True, 'sender': 'r@example.com'},
3275 {'text': 'not lgtm', 'date': '2017-03-13 21:50:34.515270',
3276 'disapproval': True, 'approval': False, 'sender': 'r2@example.com'},
3277 # Intentionally wrong order here.
3278 {'text': 'PTAL', 'date': '2000-03-13 20:49:34.515270',
3279 'disapproval': False, 'approval': False,
3280 'sender': 'owner@example.com'},
3281 ],
3282 'owner_email': 'owner@example.com',
3283 })
3284 expected_comments_summary = [
3285 git_cl._CommentSummary(
3286 message='lgtm',
3287 date=datetime.datetime(2017, 3, 13, 20, 49, 34, 515270),
3288 disapproval=False, approval=True, sender='r@example.com'),
3289 git_cl._CommentSummary(
3290 message='not lgtm',
3291 date=datetime.datetime(2017, 3, 13, 21, 50, 34, 515270),
3292 disapproval=True, approval=False, sender='r2@example.com'),
3293 # Note: same order as in whatever Rietveld returns.
3294 git_cl._CommentSummary(
3295 message='PTAL',
3296 date=datetime.datetime(2000, 3, 13, 20, 49, 34, 515270),
3297 disapproval=False, approval=False, sender='owner@example.com'),
3298 ]
3299 cl = git_cl.Changelist(codereview='rietveld', issue=1)
3300 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
3301
3302 with git_cl.gclient_utils.temporary_directory() as tempdir:
3303 out_file = os.path.abspath(os.path.join(tempdir, 'out.json'))
3304 self.assertEqual(0, git_cl.main(['comment', '--rietveld', '-i', '10',
3305 '-j', out_file]))
3306 with open(out_file) as f:
3307 read = json.load(f)
3308 self.assertEqual(len(read), 3)
3309 self.assertEqual(read[0], {
3310 'date': '2000-03-13 20:49:34.515270',
3311 'message': 'PTAL',
3312 'approval': False,
3313 'disapproval': False,
3314 'sender': 'owner@example.com'})
3315 self.assertEqual(read[1]['date'], '2017-03-13 20:49:34.515270')
3316 self.assertEqual(read[2]['date'], '2017-03-13 21:50:34.515270')
3317
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003318 def test_git_cl_comments_fetch_gerrit(self):
3319 self.mock(sys, 'stdout', StringIO.StringIO())
3320 self.calls = [
3321 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
3322 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
3323 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3324 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3325 'origin/master'),
3326 ((['git', 'config', 'remote.origin.url'],),
3327 'https://chromium.googlesource.com/infra/infra'),
3328 (('GetChangeDetail', 'chromium-review.googlesource.com', '1',
3329 ['MESSAGES', 'DETAILED_ACCOUNTS']), {
3330 'owner': {'email': 'owner@example.com'},
3331 'messages': [
3332 {
3333 u'_revision_number': 1,
3334 u'author': {
3335 u'_account_id': 1111084,
3336 u'email': u'commit-bot@chromium.org',
3337 u'name': u'Commit Bot'
3338 },
3339 u'date': u'2017-03-15 20:08:45.000000000',
3340 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
3341 u'message': u'Patch Set 1:\n\nDry run: CQ is trying da patch...',
3342 u'tag': u'autogenerated:cq:dry-run'
3343 },
3344 {
3345 u'_revision_number': 2,
3346 u'author': {
3347 u'_account_id': 11151243,
3348 u'email': u'owner@example.com',
3349 u'name': u'owner'
3350 },
3351 u'date': u'2017-03-16 20:00:41.000000000',
3352 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3353 u'message': u'PTAL',
3354 },
3355 {
3356 u'_revision_number': 2,
3357 u'author': {
3358 u'_account_id': 148512 ,
3359 u'email': u'reviewer@example.com',
3360 u'name': u'reviewer'
3361 },
3362 u'date': u'2017-03-17 05:19:37.500000000',
3363 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
3364 u'message': u'Patch Set 2: Code-Review+1',
3365 },
3366 ]
3367 })
3368 ] * 2
3369 expected_comments_summary = [
3370 git_cl._CommentSummary(
3371 message=u'Patch Set 1:\n\nDry run: CQ is trying da patch...',
3372 date=datetime.datetime(2017, 3, 15, 20, 8, 45, 0),
3373 disapproval=False, approval=False, sender=u'commit-bot@chromium.org'),
3374 git_cl._CommentSummary(
3375 message=u'PTAL',
3376 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
3377 disapproval=False, approval=False, sender=u'owner@example.com'),
3378 git_cl._CommentSummary(
3379 message=u'Patch Set 2: Code-Review+1',
3380 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
3381 disapproval=False, approval=False, sender=u'reviewer@example.com'),
3382 ]
3383 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3384 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
3385
3386 with git_cl.gclient_utils.temporary_directory() as tempdir:
3387 out_file = os.path.abspath(os.path.join(tempdir, 'out.json'))
3388 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '1',
3389 '-j', out_file]))
3390 with open(out_file) as f:
3391 read = json.load(f)
3392 self.assertEqual(len(read), 3)
3393 self.assertEqual(read[0]['date'], u'2017-03-15 20:08:45.000000')
3394 self.assertEqual(read[1]['date'], u'2017-03-16 20:00:41.000000')
3395 self.assertEqual(read[2], {
3396 u'date': u'2017-03-17 05:19:37.500000',
3397 u'message': u'Patch Set 2: Code-Review+1',
3398 u'approval': False,
3399 u'disapproval': False,
3400 u'sender': u'reviewer@example.com'})
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003401
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003402if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003403 logging.basicConfig(
3404 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003405 unittest.main()