blob: 4813edb9d1a9030a34ab55d7c5c8e9352bf7c39e [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
tandriide281ae2016-10-12 06:02:30 -07008import json
maruel@chromium.orgddd59412011-11-30 14:20:38 +00009import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000010import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000011import sys
12import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000013import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014
15sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
16
17from testing_support.auto_stub import TestCase
18
19import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000020import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000021import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000023
tandrii5d48c322016-08-18 16:19:37 -070024def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
25 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
26
27
28CERR1 = callError(1)
29
30
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000031class ChangelistMock(object):
32 # A class variable so we can access it when we don't have access to the
33 # instance that's being set.
34 desc = ""
35 def __init__(self, **kwargs):
36 pass
37 def GetIssue(self):
38 return 1
39 def GetDescription(self):
40 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070041 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000042 ChangelistMock.desc = desc
43
tandrii5d48c322016-08-18 16:19:37 -070044
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000045class PresubmitMock(object):
46 def __init__(self, *args, **kwargs):
47 self.reviewers = []
48 @staticmethod
49 def should_continue():
50 return True
51
52
53class RietveldMock(object):
54 def __init__(self, *args, **kwargs):
55 pass
maruel@chromium.org78936cb2013-04-11 00:17:52 +000056
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000057 @staticmethod
58 def get_description(issue):
59 return 'Issue: %d' % issue
60
maruel@chromium.org78936cb2013-04-11 00:17:52 +000061 @staticmethod
62 def get_issue_properties(_issue, _messages):
63 return {
64 'reviewers': ['joe@chromium.org', 'john@chromium.org'],
65 'messages': [
66 {
67 'approval': True,
68 'sender': 'john@chromium.org',
69 },
70 ],
71 }
72
iannuccie53c9352016-08-17 14:40:40 -070073 @staticmethod
74 def close_issue(_issue):
75 return 'Closed'
76
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000077
78class WatchlistsMock(object):
79 def __init__(self, _):
80 pass
81 @staticmethod
82 def GetWatchersForPaths(_):
83 return ['joe@example.com']
84
85
ukai@chromium.org78c4b982012-02-14 02:20:26 +000086class CodereviewSettingsFileMock(object):
87 def __init__(self):
88 pass
89 # pylint: disable=R0201
90 def read(self):
91 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +000092 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +000093
94
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +000095class AuthenticatorMock(object):
96 def __init__(self, *_args):
97 pass
98 def has_cached_credentials(self):
99 return True
tandrii221ab252016-10-06 08:12:04 -0700100 def authorize(self, http):
101 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000102
103
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000104def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_cookie=False):
105 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
106
107 Usage:
108 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
109 CookiesAuthenticatorMockFactory({'host1': 'cookie1'}))
110
111 OR
112 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
113 CookiesAuthenticatorMockFactory(cookie='cookie'))
114 """
115 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
116 def __init__(self): # pylint: disable=W0231
117 # Intentionally not calling super() because it reads actual cookie files.
118 pass
119 @classmethod
120 def get_gitcookies_path(cls):
121 return '~/.gitcookies'
122 @classmethod
123 def get_netrc_path(cls):
124 return '~/.netrc'
125 def get_auth_header(self, host):
126 if same_cookie:
127 return same_cookie
128 return (hosts_with_creds or {}).get(host)
129 return CookiesAuthenticatorMock
130
kmarshall9249e012016-08-23 12:02:16 -0700131class MockChangelistWithBranchAndIssue():
132 def __init__(self, branch, issue):
133 self.branch = branch
134 self.issue = issue
135 def GetBranch(self):
136 return self.branch
137 def GetIssue(self):
138 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139
tandriic2405f52016-10-10 08:13:15 -0700140
141class SystemExitMock(Exception):
142 pass
143
144
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000145class TestGitClBasic(unittest.TestCase):
146 def _test_ParseIssueUrl(self, func, url, issue, patchset, hostname, fail):
147 parsed = urlparse.urlparse(url)
148 result = func(parsed)
149 if fail:
150 self.assertIsNone(result)
151 return None
152 self.assertIsNotNone(result)
153 self.assertEqual(result.issue, issue)
154 self.assertEqual(result.patchset, patchset)
155 self.assertEqual(result.hostname, hostname)
156 return result
157
158 def test_ParseIssueURL_rietveld(self):
159 def test(url, issue=None, patchset=None, hostname=None, patch_url=None,
160 fail=None):
161 result = self._test_ParseIssueUrl(
162 git_cl._RietveldChangelistImpl.ParseIssueURL,
163 url, issue, patchset, hostname, fail)
164 if not fail:
165 self.assertEqual(result.patch_url, patch_url)
166
167 test('http://codereview.chromium.org/123',
168 123, None, 'codereview.chromium.org')
169 test('https://codereview.chromium.org/123',
170 123, None, 'codereview.chromium.org')
171 test('https://codereview.chromium.org/123/',
172 123, None, 'codereview.chromium.org')
173 test('https://codereview.chromium.org/123/whatever',
174 123, None, 'codereview.chromium.org')
wychen3c1c1722016-08-04 11:46:36 -0700175 test('https://codereview.chromium.org/123/#ps20001',
176 123, 20001, 'codereview.chromium.org')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000177 test('http://codereview.chromium.org/download/issue123_4.diff',
178 123, 4, 'codereview.chromium.org',
179 patch_url='https://codereview.chromium.org/download/issue123_4.diff')
180 # This looks like bad Gerrit, but is actually valid Rietveld.
181 test('https://chrome-review.source.com/123/4/',
182 123, None, 'chrome-review.source.com')
183
184 test('https://codereview.chromium.org/deadbeaf', fail=True)
185 test('https://codereview.chromium.org/api/123', fail=True)
186 test('bad://codereview.chromium.org/123', fail=True)
187 test('http://codereview.chromium.org/download/issue123_4.diffff', fail=True)
188
189 def test_ParseIssueURL_gerrit(self):
190 def test(url, issue=None, patchset=None, hostname=None, fail=None):
191 self._test_ParseIssueUrl(
192 git_cl._GerritChangelistImpl.ParseIssueURL,
193 url, issue, patchset, hostname, fail)
194
195 test('http://chrome-review.source.com/c/123',
196 123, None, 'chrome-review.source.com')
197 test('https://chrome-review.source.com/c/123/',
198 123, None, 'chrome-review.source.com')
199 test('https://chrome-review.source.com/c/123/4',
200 123, 4, 'chrome-review.source.com')
201 test('https://chrome-review.source.com/#/c/123/4',
202 123, 4, 'chrome-review.source.com')
203 test('https://chrome-review.source.com/c/123/4',
204 123, 4, 'chrome-review.source.com')
205 test('https://chrome-review.source.com/123',
206 123, None, 'chrome-review.source.com')
207 test('https://chrome-review.source.com/123/4',
208 123, 4, 'chrome-review.source.com')
209
210 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
211 test('https://chrome-review.source.com/c/abc/', fail=True)
212 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
213
214 def test_ParseIssueNumberArgument(self):
215 def test(arg, issue=None, patchset=None, hostname=None, fail=False):
216 result = git_cl.ParseIssueNumberArgument(arg)
217 self.assertIsNotNone(result)
218 if fail:
219 self.assertFalse(result.valid)
220 else:
221 self.assertEqual(result.issue, issue)
222 self.assertEqual(result.patchset, patchset)
223 self.assertEqual(result.hostname, hostname)
224
225 test('123', 123)
226 test('', fail=True)
227 test('abc', fail=True)
228 test('123/1', fail=True)
229 test('123a', fail=True)
230 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
231 # Rietveld.
232 test('https://codereview.source.com/123',
233 123, None, 'codereview.source.com')
234 test('https://codereview.source.com/www123', fail=True)
235 # Gerrrit.
236 test('https://chrome-review.source.com/c/123/4',
237 123, 4, 'chrome-review.source.com')
238 test('https://chrome-review.source.com/bad/123/4', fail=True)
239
tandriif9aefb72016-07-01 09:06:51 -0700240 def test_get_bug_line_values(self):
241 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
242 self.assertEqual(f('', ''), [])
243 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
244 self.assertEqual(f('v8', '456'), ['v8:456'])
245 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
246 # Not nice, but not worth carying.
247 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
248 ['v8:456', 'chromium:123', 'v8:123'])
249
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000250
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000251class TestGitCl(TestCase):
252 def setUp(self):
253 super(TestGitCl, self).setUp()
254 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700255 self._calls_done = []
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000256 self.mock(subprocess2, 'call', self._mocked_call)
257 self.mock(subprocess2, 'check_call', self._mocked_call)
258 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700259 self.mock(subprocess2, 'communicate',
260 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000261 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000262 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000263 self.mock(git_common, 'get_or_create_merge_base',
264 lambda *a: (
265 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000266 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000267 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000268 self.mock(git_cl, 'ask_for_data', self._mocked_call)
phajdan.jre328cf92016-08-22 04:12:17 -0700269 self.mock(git_cl, 'write_json', lambda path, contents:
270 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000271 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000272 self.mock(git_cl.rietveld, 'Rietveld', RietveldMock)
maruel@chromium.org4bac4b52012-11-27 20:33:52 +0000273 self.mock(git_cl.rietveld, 'CachingRietveld', RietveldMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000274 self.mock(git_cl.upload, 'RealMain', self.fail)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000275 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000276 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000277 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
278 classmethod(lambda _: False))
tandriic2405f52016-10-10 08:13:15 -0700279 self.mock(git_cl, 'DieWithError',
280 lambda msg: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000281 # It's important to reset settings to not have inter-tests interference.
282 git_cl.settings = None
283
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000284
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000285 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000286 try:
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000287 # Note: has_failed returns True if at least 1 test ran so far, current
288 # included, has failed. That means current test may have actually ran
289 # fine, and the check for no leftover calls would be skipped.
wychen@chromium.org445c8962015-04-28 23:30:05 +0000290 if not self.has_failed():
291 self.assertEquals([], self.calls)
292 finally:
293 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000294
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000295 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000296 self.assertTrue(
297 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700298 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000299 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000300 expected_args, result = top
301
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000302 # Also logs otherwise it could get caught in a try/finally and be hard to
303 # diagnose.
304 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700305 N = 5
306 prior_calls = '\n '.join(
307 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
308 for i, c in enumerate(self._calls_done[-N:]))
309 following_calls = '\n '.join(
310 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
311 for i, c in enumerate(self.calls[:N]))
312 extended_msg = (
313 'A few prior calls:\n %s\n\n'
314 'This (expected):\n @%d: %r\n'
315 'This (actual):\n @%d: %r\n\n'
316 'A few following expected calls:\n %s' %
317 (prior_calls, len(self._calls_done), expected_args,
318 len(self._calls_done), args, following_calls))
319 git_cl.logging.error(extended_msg)
320
tandrii99a72f22016-08-17 14:33:24 -0700321 self.fail('@%d\n'
322 ' Expected: %r\n'
323 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700324 len(self._calls_done), expected_args, args))
325
326 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700327 if isinstance(result, Exception):
328 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000329 return result
330
tandrii48df5812016-10-17 03:55:37 -0700331 def test_LoadCodereviewSettingsFromFile_gerrit(self):
332 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
333 self.calls = [
334 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
335 ((['git', 'config', '--unset-all', 'rietveld.private'],), CERR1),
336 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
337 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
338 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
339 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
340 ((['git', 'config', '--unset-all', 'rietveld.force-https-commit-url'],),
341 CERR1),
342 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
343 CERR1),
344 ((['git', 'config', '--unset-all', 'rietveld.project'],), CERR1),
345 ((['git', 'config', '--unset-all', 'rietveld.pending-ref-prefix'],),
346 CERR1),
347 ((['git', 'config', '--unset-all', 'rietveld.git-number-footer'],),
348 CERR1),
349 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
350 CERR1),
351 ((['git', 'config', 'gerrit.host', 'true'],), ''),
352 ]
353 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
354
maruel@chromium.orga3353652011-11-30 14:26:57 +0000355 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000356 def _is_gerrit_calls(cls, gerrit=False):
357 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
358 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
359
360 @classmethod
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000361 def _upload_calls(cls, similarity, find_copies, private):
iannucci@chromium.org79540052012-10-19 23:15:26 +0000362 return (cls._git_base_calls(similarity, find_copies) +
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000363 cls._git_upload_calls(private))
maruel@chromium.orga3353652011-11-30 14:26:57 +0000364
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000365 @classmethod
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000366 def _upload_no_rev_calls(cls, similarity, find_copies):
367 return (cls._git_base_calls(similarity, find_copies) +
368 cls._git_upload_no_rev_calls())
369
370 @classmethod
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000371 def _git_base_calls(cls, similarity, find_copies):
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000372 if similarity is None:
373 similarity = '50'
tandrii33a46ff2016-08-23 05:53:40 -0700374 similarity_call = ((['git', 'config',
tandrii5d48c322016-08-18 16:19:37 -0700375 'branch.master.git-cl-similarity'],), CERR1)
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000376 else:
tandrii33a46ff2016-08-23 05:53:40 -0700377 similarity_call = ((['git', 'config',
tandrii5d48c322016-08-18 16:19:37 -0700378 'branch.master.git-cl-similarity', similarity],), '')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000379
380 if find_copies is None:
381 find_copies = True
tandrii5d48c322016-08-18 16:19:37 -0700382 find_copies_call = ((['git', 'config', '--bool',
383 'branch.master.git-find-copies'],), CERR1)
iannucci@chromium.org79540052012-10-19 23:15:26 +0000384 else:
tandrii5d48c322016-08-18 16:19:37 -0700385 val = str(find_copies).lower()
386 find_copies_call = ((['git', 'config', '--bool',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000387 'branch.master.git-find-copies', val],), '')
388
389 if find_copies:
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000390 stat_call = ((['git', 'diff', '--no-ext-diff', '--stat',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000391 '--find-copies-harder', '-l100000', '-C'+similarity,
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000392 'fake_ancestor_sha', 'HEAD'],), '+dat')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000393 else:
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000394 stat_call = ((['git', 'diff', '--no-ext-diff', '--stat',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000395 '-M'+similarity, 'fake_ancestor_sha', 'HEAD'],), '+dat')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000396
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000397 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000398 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii@chromium.org87985d22016-03-24 17:33:33 +0000399 similarity_call,
400 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
401 find_copies_call,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000402 ] + cls._is_gerrit_calls() + [
tandrii@chromium.org87985d22016-03-24 17:33:33 +0000403 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -0700404 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
405 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000406 ((['git', 'config', 'rietveld.server'],),
407 'codereview.example.com'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000408 ((['git', 'config', 'branch.master.merge'],), 'master'),
409 ((['git', 'config', 'branch.master.remote'],), 'origin'),
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000410 ((['get_or_create_merge_base', 'master', 'master'],),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000411 'fake_ancestor_sha'),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000412 ] + cls._git_sanity_checks('fake_ancestor_sha', 'master') + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000413 ((['git', 'rev-parse', '--show-cdup'],), ''),
414 ((['git', 'rev-parse', 'HEAD'],), '12345'),
415 ((['git', 'diff', '--name-status', '--no-renames', '-r',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000416 'fake_ancestor_sha...', '.'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000417 'M\t.gitignore\n'),
tandrii33a46ff2016-08-23 05:53:40 -0700418 ((['git', 'config', 'branch.master.rietveldpatchset'],), CERR1),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000419 ((['git', 'log', '--pretty=format:%s%n%n%b',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000420 'fake_ancestor_sha...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000421 'foo'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000422 ((['git', 'config', 'user.email'],), 'me@example.com'),
iannucci@chromium.org79540052012-10-19 23:15:26 +0000423 stat_call,
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000424 ((['git', 'log', '--pretty=format:%s\n\n%b',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000425 'fake_ancestor_sha..HEAD'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000426 'desc\n'),
rmistry@google.com90752582014-01-14 21:04:50 +0000427 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
maruel@chromium.orga3353652011-11-30 14:26:57 +0000428 ]
429
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000430 @classmethod
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000431 def _git_upload_no_rev_calls(cls):
432 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000433 ((['git', 'config', 'core.editor'],), ''),
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000434 ]
435
436 @classmethod
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000437 def _git_upload_calls(cls, private):
438 if private:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000439 cc_call = []
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000440 private_call = []
441 else:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000442 cc_call = [((['git', 'config', 'rietveld.cc'],), '')]
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000443 private_call = [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000444 ((['git', 'config', 'rietveld.private'],), '')]
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000445
maruel@chromium.orga3353652011-11-30 14:26:57 +0000446 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000447 ((['git', 'config', 'core.editor'],), ''),
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000448 ] + cc_call + private_call + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000449 ((['git', 'config', 'branch.master.base-url'],), ''),
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000450 ((['git', 'config', 'rietveld.pending-ref-prefix'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000451 ((['git',
bratell@opera.com05fb9112014-07-07 09:30:23 +0000452 'config', '--local', '--get-regexp', '^svn-remote\\.'],),
453 (('', None), 0)),
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000454 ((['git', 'rev-parse', '--show-cdup'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000455 ((['git', 'svn', 'info'],), ''),
sheyang@chromium.org152cf832014-06-11 21:37:49 +0000456 ((['git', 'config', 'rietveld.project'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -0700457 ((['git', 'config', 'branch.master.rietveldissue', '1'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000458 ((['git', 'config', 'branch.master.rietveldserver',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000459 'https://codereview.example.com'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000460 ((['git',
tandrii33a46ff2016-08-23 05:53:40 -0700461 'config', 'branch.master.rietveldpatchset', '2'],), ''),
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000462 ] + cls._git_post_upload_calls()
463
464 @classmethod
465 def _git_post_upload_calls(cls):
466 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000467 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
468 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
469 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000470 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000471 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000472 ]
473
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000474 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000475 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000476 fake_ancestor = 'fake_ancestor'
477 fake_cl = 'fake_cl_for_patch'
478 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000479 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000480 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000481 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000482 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000483 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000484 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000485 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000486 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700487 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000488 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000489 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000490 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000491 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000492 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000493 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000494 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000495 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000496 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000497 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000498 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000499
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000500 @classmethod
501 def _dcommit_calls_1(cls):
502 return [
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000503 ((['git', 'config', 'rietveld.autoupdate'],),
504 ''),
505 ((['git', 'config', 'rietveld.pending-ref-prefix'],),
506 ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000507 ((['git',
bratell@opera.com05fb9112014-07-07 09:30:23 +0000508 'config', '--local', '--get-regexp', '^svn-remote\\.'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000509 ((('svn-remote.svn.url svn://svn.chromium.org/chrome\n'
510 'svn-remote.svn.fetch trunk/src:refs/remotes/origin/master'),
511 None),
512 0)),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000513 ((['git', 'symbolic-ref', 'HEAD'],), 'refs/heads/working'),
tandrii33a46ff2016-08-23 05:53:40 -0700514 ((['git', 'config',
tandrii5d48c322016-08-18 16:19:37 -0700515 'branch.working.git-cl-similarity'],), CERR1),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000516 ((['git', 'symbolic-ref', 'HEAD'],), 'refs/heads/working'),
tandrii5d48c322016-08-18 16:19:37 -0700517 ((['git', 'config', '--bool',
518 'branch.working.git-find-copies'],), CERR1),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000519 ((['git', 'symbolic-ref', 'HEAD'],), 'refs/heads/working'),
520 ((['git',
tandrii33a46ff2016-08-23 05:53:40 -0700521 'config', 'branch.working.rietveldissue'],), '12345'),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000522 ((['git',
523 'config', 'rietveld.server'],), 'codereview.example.com'),
524 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000525 'config', 'branch.working.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000526 ((['git', 'config', 'branch.working.remote'],), 'origin'),
iannucci@chromium.org5724c962014-04-11 09:32:56 +0000527 ((['git', 'config', 'branch.working.merge'],),
528 'refs/heads/master'),
529 ((['git', 'config', 'branch.working.remote'],), 'origin'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000530 ((['git', 'rev-list', '--merges',
szager@chromium.orge84b7542012-06-15 21:26:58 +0000531 '--grep=^SVN changes up to revision [0-9]*$',
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000532 'refs/remotes/origin/master^!'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000533 ((['git', 'rev-list', '^refs/heads/working',
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000534 'refs/remotes/origin/master'],),
535 ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000536 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000537 'log', '--grep=^git-svn-id:', '-1', '--pretty=format:%H'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000538 '3fc18b62c4966193eb435baabe2d18a3810ec82e'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000539 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000540 'rev-list', '^3fc18b62c4966193eb435baabe2d18a3810ec82e',
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000541 'refs/remotes/origin/master'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000542 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000543 'merge-base', 'refs/remotes/origin/master', 'HEAD'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000544 'fake_ancestor_sha'),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000545 ]
546
547 @classmethod
548 def _dcommit_calls_normal(cls):
549 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000550 ((['git', 'rev-parse', '--show-cdup'],), ''),
551 ((['git', 'rev-parse', 'HEAD'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000552 '00ff397798ea57439712ed7e04ab96e13969ef40'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000553 ((['git',
mcgrathr@chromium.org9249f642013-06-03 21:36:18 +0000554 'diff', '--name-status', '--no-renames', '-r', 'fake_ancestor_sha...',
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000555 '.'],),
556 'M\tPRESUBMIT.py'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000557 ((['git',
tandrii33a46ff2016-08-23 05:53:40 -0700558 'config', 'branch.working.rietveldpatchset'],), '31137'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000559 ((['git', 'config', 'branch.working.rietveldserver'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000560 'codereview.example.com'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000561 ((['git', 'config', 'user.email'],), 'author@example.com'),
562 ((['git', 'config', 'rietveld.tree-status-url'],), ''),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000563 ]
564
565 @classmethod
566 def _dcommit_calls_bypassed(cls):
567 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000568 ((['git', 'config', 'branch.working.rietveldserver'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000569 'codereview.example.com'),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000570 ]
571
572 @classmethod
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000573 def _dcommit_calls_3(cls):
574 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000575 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000576 'diff', '--no-ext-diff', '--stat', '--find-copies-harder',
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000577 '-l100000', '-C50', 'fake_ancestor_sha',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000578 'refs/heads/working'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000579 (' PRESUBMIT.py | 2 +-\n'
580 ' 1 files changed, 1 insertions(+), 1 deletions(-)\n')),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000581 ((['git', 'show-ref', '--quiet', '--verify',
tandrii5d48c322016-08-18 16:19:37 -0700582 'refs/heads/git-cl-commit'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000583 ((['git', 'branch', '-D', 'git-cl-commit'],), ''),
584 ((['git', 'show-ref', '--quiet', '--verify',
tandrii5d48c322016-08-18 16:19:37 -0700585 'refs/heads/git-cl-cherry-pick'],), CERR1),
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000586 ((['git', 'rev-parse', '--show-cdup'],), '\n'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000587 ((['git', 'checkout', '-q', '-b', 'git-cl-commit'],), ''),
588 ((['git', 'reset', '--soft', 'fake_ancestor_sha'],), ''),
589 ((['git', 'commit', '-m',
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000590 'Issue: 12345\n\nR=john@chromium.org\n\n'
sergiyb@chromium.org4b39c5f2015-07-07 10:33:12 +0000591 'Review URL: https://codereview.example.com/12345 .'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000592 ''),
kjellander@chromium.org6abc6522014-12-02 07:34:49 +0000593 ((['git', 'config', 'rietveld.force-https-commit-url'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000594 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000595 'svn', 'dcommit', '-C50', '--no-rebase', '--rmdir'],),
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000596 (('', None), 0)),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000597 ((['git', 'checkout', '-q', 'working'],), ''),
598 ((['git', 'branch', '-D', 'git-cl-commit'],), ''),
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000599 ]
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000600
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000601 @staticmethod
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000602 def _cmd_line(description, args, similarity, find_copies, private):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000603 """Returns the upload command line passed to upload.RealMain()."""
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000604 return [
605 'upload', '--assume_yes', '--server',
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +0000606 'https://codereview.example.com',
maruel@chromium.org71e12a92012-02-14 02:34:15 +0000607 '--message', description
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000608 ] + args + [
609 '--cc', 'joe@example.com',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000610 ] + (['--private'] if private else []) + [
iannucci@chromium.org79540052012-10-19 23:15:26 +0000611 '--git_similarity', similarity or '50'
612 ] + (['--git_no_find_copies'] if find_copies == False else []) + [
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000613 'fake_ancestor_sha', 'HEAD'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000614 ]
615
616 def _run_reviewer_test(
617 self,
618 upload_args,
619 expected_description,
620 returned_description,
621 final_description,
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000622 reviewers,
623 private=False):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000624 """Generic reviewer test framework."""
tandrii@chromium.org28253532016-04-14 13:46:56 +0000625 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000626 try:
627 similarity = upload_args[upload_args.index('--similarity')+1]
628 except ValueError:
629 similarity = None
iannucci@chromium.org79540052012-10-19 23:15:26 +0000630
631 if '--find-copies' in upload_args:
632 find_copies = True
633 elif '--no-find-copies' in upload_args:
634 find_copies = False
635 else:
636 find_copies = None
637
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000638 private = '--private' in upload_args
639
640 self.calls = self._upload_calls(similarity, find_copies, private)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000641
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000642 def RunEditor(desc, _, **kwargs):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000643 self.assertEquals(
644 '# Enter a description of the change.\n'
janx@chromium.org104b2db2013-04-18 12:58:40 +0000645 '# This will be displayed on the codereview site.\n'
alancutter@chromium.org63a4d7f2013-05-31 02:22:45 +0000646 '# The first line will also be used as the subject of the review.\n'
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +0000647 '#--------------------This line is 72 characters long'
648 '--------------------\n' +
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000649 expected_description,
650 desc)
651 return returned_description
652 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000653
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000654 def check_upload(args):
iannucci@chromium.org79540052012-10-19 23:15:26 +0000655 cmd_line = self._cmd_line(final_description, reviewers, similarity,
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000656 find_copies, private)
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000657 self.assertEquals(cmd_line, args)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000658 return 1, 2
659 self.mock(git_cl.upload, 'RealMain', check_upload)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000660
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000661 git_cl.main(['upload'] + upload_args)
662
663 def test_no_reviewer(self):
664 self._run_reviewer_test(
665 [],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000666 'desc\n\nBUG=',
667 '# Blah blah comment.\ndesc\n\nBUG=',
668 'desc\n\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000669 [])
670
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000671 def test_keep_similarity(self):
672 self._run_reviewer_test(
673 ['--similarity', '70'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000674 'desc\n\nBUG=',
675 '# Blah blah comment.\ndesc\n\nBUG=',
676 'desc\n\nBUG=',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000677 [])
678
iannucci@chromium.org79540052012-10-19 23:15:26 +0000679 def test_keep_find_copies(self):
680 self._run_reviewer_test(
681 ['--no-find-copies'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000682 'desc\n\nBUG=',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000683 '# Blah blah comment.\ndesc\n\nBUG=\n',
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000684 'desc\n\nBUG=',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000685 [])
686
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000687 def test_private(self):
688 self._run_reviewer_test(
689 ['--private'],
690 'desc\n\nBUG=',
691 '# Blah blah comment.\ndesc\n\nBUG=\n',
692 'desc\n\nBUG=',
693 [])
694
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000695 def test_reviewers_cmd_line(self):
696 # Reviewer is passed as-is
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000697 description = 'desc\n\nR=foo@example.com\nBUG='
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000698 self._run_reviewer_test(
699 ['-r' 'foo@example.com'],
700 description,
701 '\n%s\n' % description,
702 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000703 ['--reviewers=foo@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000704
705 def test_reviewer_tbr_overriden(self):
706 # Reviewer is overriden with TBR
707 # Also verifies the regexp work without a trailing LF
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000708 description = 'Foo Bar\n\nTBR=reviewer@example.com'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000709 self._run_reviewer_test(
710 ['-r' 'foo@example.com'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000711 'desc\n\nR=foo@example.com\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000712 description.strip('\n'),
713 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000714 ['--reviewers=reviewer@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000715
716 def test_reviewer_multiple(self):
717 # Handles multiple R= or TBR= lines.
718 description = (
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000719 'Foo Bar\nTBR=reviewer@example.com\nBUG=\nR=another@example.com')
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000720 self._run_reviewer_test(
721 [],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000722 'desc\n\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000723 description,
724 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000725 ['--reviewers=another@example.com,reviewer@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000726
maruel@chromium.orga3353652011-11-30 14:26:57 +0000727 def test_reviewer_send_mail(self):
728 # --send-mail can be used without -r if R= is used
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000729 description = 'Foo Bar\nR=reviewer@example.com'
maruel@chromium.orga3353652011-11-30 14:26:57 +0000730 self._run_reviewer_test(
731 ['--send-mail'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000732 'desc\n\nBUG=',
maruel@chromium.orga3353652011-11-30 14:26:57 +0000733 description.strip('\n'),
734 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000735 ['--reviewers=reviewer@example.com', '--send_mail'])
maruel@chromium.orga3353652011-11-30 14:26:57 +0000736
737 def test_reviewer_send_mail_no_rev(self):
738 # Fails without a reviewer.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000739 stdout = StringIO.StringIO()
tandriic2405f52016-10-10 08:13:15 -0700740 self.calls = self._upload_no_rev_calls(None, None) + [
741 ((['DieWithError', 'Must specify reviewers to send email.'],),
742 SystemExitMock())
743 ]
744
745 def RunEditor(desc, _, **kwargs):
746 return desc
747 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
748 self.mock(sys, 'stdout', stdout)
749 with self.assertRaises(SystemExitMock):
maruel@chromium.orga3353652011-11-30 14:26:57 +0000750 git_cl.main(['upload', '--send-mail'])
tandriic2405f52016-10-10 08:13:15 -0700751 self.assertEqual(
752 'Using 50% similarity for rename/copy detection. Override with '
753 '--similarity.\n',
754 stdout.getvalue())
maruel@chromium.orga3353652011-11-30 14:26:57 +0000755
tandriif9aefb72016-07-01 09:06:51 -0700756 def test_bug_on_cmd(self):
757 self._run_reviewer_test(
758 ['--bug=500658,proj:123'],
759 'desc\n\nBUG=500658\nBUG=proj:123',
760 '# Blah blah comment.\ndesc\n\nBUG=500658\nBUG=proj:1234',
761 'desc\n\nBUG=500658\nBUG=proj:1234',
762 [])
763
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000764 def test_dcommit(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +0000765 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000766 self.calls = (
767 self._dcommit_calls_1() +
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000768 self._git_sanity_checks('fake_ancestor_sha', 'working') +
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000769 self._dcommit_calls_normal() +
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000770 self._dcommit_calls_3())
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000771 git_cl.main(['dcommit'])
772
773 def test_dcommit_bypass_hooks(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +0000774 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000775 self.calls = (
776 self._dcommit_calls_1() +
777 self._dcommit_calls_bypassed() +
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000778 self._dcommit_calls_3())
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000779 git_cl.main(['dcommit', '--bypass-hooks'])
780
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000781
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000782 @classmethod
tandrii@chromium.org28253532016-04-14 13:46:56 +0000783 def _gerrit_ensure_auth_calls(cls, issue=None, skip_auth_check=False):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000784 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000785 if skip_auth_check:
786 return [((cmd, ), 'true')]
787
tandrii5d48c322016-08-18 16:19:37 -0700788 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000789 if issue:
790 calls.extend([
791 ((['git', 'config', 'branch.master.gerritserver'],), ''),
792 ])
793 calls.extend([
794 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
795 ((['git', 'config', 'branch.master.remote'],), 'origin'),
796 ((['git', 'config', 'remote.origin.url'],),
797 'https://chromium.googlesource.com/my/repo'),
798 ((['git', 'config', 'remote.origin.url'],),
799 'https://chromium.googlesource.com/my/repo'),
800 ])
801 return calls
802
803 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000804 def _gerrit_base_calls(cls, issue=None):
ukai@chromium.orge8077812012-02-03 03:41:46 +0000805 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000806 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -0700807 ((['git', 'config', 'branch.master.git-cl-similarity'],),
tandrii5d48c322016-08-18 16:19:37 -0700808 CERR1),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000809 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii5d48c322016-08-18 16:19:37 -0700810 ((['git', 'config', '--bool', 'branch.master.git-find-copies'],),
811 CERR1),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000812 ] + cls._is_gerrit_calls(True) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000813 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -0700814 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
815 ((['git', 'config', 'branch.master.gerritissue'],),
tandrii5d48c322016-08-18 16:19:37 -0700816 CERR1 if issue is None else str(issue)),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000817 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000818 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000819 ((['get_or_create_merge_base', 'master',
820 'refs/remotes/origin/master'],),
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000821 'fake_ancestor_sha'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000822 # Calls to verify branch point is ancestor
823 ] + (cls._gerrit_ensure_auth_calls(issue=issue) +
824 cls._git_sanity_checks('fake_ancestor_sha', 'master',
825 get_remote_branch=False)) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000826 ((['git', 'rev-parse', '--show-cdup'],), ''),
827 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000828
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000829 ((['git',
mcgrathr@chromium.org9249f642013-06-03 21:36:18 +0000830 'diff', '--name-status', '--no-renames', '-r',
831 'fake_ancestor_sha...', '.'],),
ukai@chromium.orge8077812012-02-03 03:41:46 +0000832 'M\t.gitignore\n'),
tandrii33a46ff2016-08-23 05:53:40 -0700833 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000834 ] + ([] if issue else [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000835 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000836 'log', '--pretty=format:%s%n%n%b', 'fake_ancestor_sha...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000837 'foo'),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000838 ]) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000839 ((['git', 'config', 'user.email'],), 'me@example.com'),
840 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000841 'diff', '--no-ext-diff', '--stat', '--find-copies-harder',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000842 '-l100000', '-C50', 'fake_ancestor_sha', 'HEAD'],),
ukai@chromium.orge8077812012-02-03 03:41:46 +0000843 '+dat'),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000844 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +0000845
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000846 @classmethod
847 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700848 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000849 expected_upstream_ref='origin/refs/heads/master',
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000850 ref_suffix='', notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000851 post_amend_description=None, issue=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000852 if post_amend_description is None:
853 post_amend_description = description
tandriia60502f2016-06-20 02:01:53 -0700854 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000855
tandriia60502f2016-06-20 02:01:53 -0700856 if squash_mode == 'default':
857 calls.extend([
858 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
859 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
860 ])
861 elif squash_mode in ('override_squash', 'override_nosquash'):
862 calls.extend([
863 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
864 'true' if squash_mode == 'override_squash' else 'false'),
865 ])
866 else:
867 assert squash_mode in ('squash', 'nosquash')
868
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000869 # If issue is given, then description is fetched from Gerrit instead.
870 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000871 calls += [
872 ((['git', 'log', '--pretty=format:%s\n\n%b',
873 'fake_ancestor_sha..HEAD'],),
874 description)]
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000875 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000876 calls += [
tandrii@chromium.org10625002016-03-04 20:03:47 +0000877 # DownloadGerritHook(False)
878 ((False, ),
879 ''),
880 # Amending of commit message to get the Change-Id.
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000881 ((['git', 'log', '--pretty=format:%s\n\n%b',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000882 'fake_ancestor_sha..HEAD'],),
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000883 description),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000884 ((['git', 'commit', '--amend', '-m', description],),
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000885 ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000886 ((['git', 'log', '--pretty=format:%s\n\n%b',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000887 'fake_ancestor_sha..HEAD'],),
tandrii@chromium.org10625002016-03-04 20:03:47 +0000888 post_amend_description)
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000889 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000890 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000891 if not issue:
892 # Prompting to edit description on first upload.
893 calls += [
894 ((['git', 'config', 'core.editor'],), ''),
895 ((['RunEditor'],), description),
896 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000897 ref_to_push = 'abcdef0123456789'
898 calls += [
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000899 ((['git', 'config', 'branch.master.merge'],),
900 'refs/heads/master'),
901 ((['git', 'config', 'branch.master.remote'],),
902 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000903 ((['get_or_create_merge_base', 'master',
904 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000905 'origin/master'),
906 ((['git', 'rev-parse', 'HEAD:'],),
907 '0123456789abcdef'),
908 ((['git', 'commit-tree', '0123456789abcdef', '-p',
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000909 'origin/master', '-m', description],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000910 ref_to_push),
911 ]
912 else:
913 ref_to_push = 'HEAD'
914
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000915 calls += [
luqui@chromium.org609f3952015-05-04 22:47:04 +0000916 ((['git', 'rev-list',
917 expected_upstream_ref + '..' + ref_to_push],), ''),
ukai@chromium.orge8077812012-02-03 03:41:46 +0000918 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000919
920 notify_suffix = 'notify=%s' % ('ALL' if notify else 'NONE')
921 if ref_suffix:
922 ref_suffix += ',' + notify_suffix
923 else:
924 ref_suffix = '%' + notify_suffix
tandrii@chromium.org074c2af2016-06-03 23:18:40 +0000925
ukai@chromium.orge8077812012-02-03 03:41:46 +0000926 if reviewers:
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000927 ref_suffix += ',' + ','.join('r=%s' % email
928 for email in sorted(reviewers))
ukai@chromium.orge8077812012-02-03 03:41:46 +0000929 calls += [
tandrii@chromium.org8acd8332016-04-13 12:56:03 +0000930 ((['git', 'push', 'origin',
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +0000931 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000932 ('remote:\n'
933 'remote: Processing changes: (\)\n'
934 'remote: Processing changes: (|)\n'
935 'remote: Processing changes: (/)\n'
936 'remote: Processing changes: (-)\n'
937 'remote: Processing changes: new: 1 (/)\n'
938 'remote: Processing changes: new: 1, done\n'
939 'remote:\n'
940 'remote: New Changes:\n'
941 'remote: https://chromium-review.googlesource.com/123456 XXX.\n'
942 'remote:\n'
943 'To https://chromium.googlesource.com/yyy/zzz\n'
944 ' * [new branch] hhhh -> refs/for/refs/heads/master\n')),
ukai@chromium.orge8077812012-02-03 03:41:46 +0000945 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000946 if squash:
947 calls += [
tandrii33a46ff2016-08-23 05:53:40 -0700948 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -0700949 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000950 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -0700951 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000952 ((['git', 'config', 'branch.master.gerritsquashhash',
953 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000954 ]
tandrii88189772016-09-29 04:29:57 -0700955 calls += [
956 ((['git', 'config', 'rietveld.cc'],), ''),
957 ((['AddReviewers', 'chromium-review.googlesource.com',
958 123456 if squash else None,
959 ['joe@example.com'], False],), ''),
960 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000961 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +0000962 return calls
963
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000964 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +0000965 self,
966 upload_args,
967 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +0000968 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -0700969 squash=True,
970 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +0000971 expected_upstream_ref='origin/refs/heads/master',
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +0000972 ref_suffix='',
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000973 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000974 post_amend_description=None,
975 issue=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000976 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -0700977 if squash_mode is None:
978 if '--no-squash' in upload_args:
979 squash_mode = 'nosquash'
980 elif '--squash' in upload_args:
981 squash_mode = 'squash'
982 else:
983 squash_mode = 'default'
984
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +0000985 reviewers = reviewers or []
tandrii@chromium.org28253532016-04-14 13:46:56 +0000986 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -0700987 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000988 CookiesAuthenticatorMockFactory(same_cookie='same_cred'))
tandrii16e0b4e2016-06-07 10:34:28 -0700989 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
990 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -0700991 self.mock(git_cl.gclient_utils, 'RunEditor',
992 lambda *_, **__: self._mocked_call(['RunEditor']))
993 self.mock(git_cl, 'DownloadGerritHook', self._mocked_call)
tandrii88189772016-09-29 04:29:57 -0700994 self.mock(git_cl.gerrit_util, 'AddReviewers',
995 lambda h, i, add, is_reviewer: self._mocked_call(
996 ['AddReviewers', h, i, add, is_reviewer]))
tandriia60502f2016-06-20 02:01:53 -0700997
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000998 self.calls = self._gerrit_base_calls(issue=issue)
luqui@chromium.org609f3952015-05-04 22:47:04 +0000999 self.calls += self._gerrit_upload_calls(
1000 description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -07001001 squash_mode=squash_mode,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001002 expected_upstream_ref=expected_upstream_ref,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001003 ref_suffix=ref_suffix, notify=notify,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001004 post_amend_description=post_amend_description,
1005 issue=issue)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001006 # Uncomment when debugging.
1007 # print '\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls)))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001008 git_cl.main(['upload'] + upload_args)
1009
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001010 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001011 self._run_gerrit_upload_test(
1012 ['--no-squash'],
1013 'desc\n\nBUG=\n',
1014 [],
1015 squash=False,
1016 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
1017
1018 def test_gerrit_upload_without_change_id_override_nosquash(self):
tandrii@chromium.org10625002016-03-04 20:03:47 +00001019 self.mock(git_cl, 'DownloadGerritHook', self._mocked_call)
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001020 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001021 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001022 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001023 [],
tandriia60502f2016-06-20 02:01:53 -07001024 squash=False,
1025 squash_mode='override_nosquash',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001026 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001027
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001028 def test_gerrit_no_reviewer(self):
1029 self._run_gerrit_upload_test(
1030 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001031 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001032 [],
1033 squash=False,
1034 squash_mode='override_nosquash')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001035
tandriieefe8322016-08-17 10:12:24 -07001036 def test_gerrit_patch_bad_chars(self):
1037 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001038 self._run_gerrit_upload_test(
tandriieefe8322016-08-17 10:12:24 -07001039 ['-f', '-t', 'Don\'t put bad cha,.rs'],
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001040 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandriia60502f2016-06-20 02:01:53 -07001041 squash=False,
1042 squash_mode='override_nosquash',
tandriieefe8322016-08-17 10:12:24 -07001043 ref_suffix='%m=Dont_put_bad_chars')
1044 self.assertIn(
1045 'WARNING: Patchset title may only contain alphanumeric chars '
1046 'and spaces. Cleaned up title:\nDont put bad chars\n',
1047 git_cl.sys.stdout.getvalue())
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001048
ukai@chromium.orge8077812012-02-03 03:41:46 +00001049 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001050 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001051 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001052 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001053 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001054 squash=False,
1055 squash_mode='override_nosquash',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001056 notify=True)
ukai@chromium.orge8077812012-02-03 03:41:46 +00001057
1058 def test_gerrit_reviewer_multiple(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001059 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001060 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001061 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n\n'
1062 'Change-Id: 123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001063 ['reviewer@example.com', 'another@example.com'],
1064 squash=False,
tandrii99a72f22016-08-17 14:33:24 -07001065 squash_mode='override_nosquash',
1066 ref_suffix='%l=Code-Review+1')
tandriia60502f2016-06-20 02:01:53 -07001067
1068 def test_gerrit_upload_squash_first_is_default(self):
1069 # Mock Gerrit CL description to indicate the first upload.
1070 self.mock(git_cl.Changelist, 'GetDescription',
1071 lambda *_: None)
1072 self._run_gerrit_upload_test(
1073 [],
1074 'desc\nBUG=\n\nChange-Id: 123456789',
1075 [],
1076 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001077
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001078 def test_gerrit_upload_squash_first(self):
1079 # Mock Gerrit CL description to indicate the first upload.
1080 self.mock(git_cl.Changelist, 'GetDescription',
1081 lambda *_: None)
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001082 self._run_gerrit_upload_test(
1083 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001084 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001085 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001086 squash=True,
1087 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001088
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001089 def test_gerrit_upload_squash_reupload(self):
1090 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1091 # Mock Gerrit CL description to indicate re-upload.
1092 self.mock(git_cl.Changelist, 'GetDescription',
1093 lambda *args: description)
1094 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
1095 lambda *args: 1)
1096 self.mock(git_cl._GerritChangelistImpl, '_GetChangeDetail',
1097 lambda *args: {'change_id': '123456789'})
1098 self._run_gerrit_upload_test(
1099 ['--squash'],
1100 description,
1101 [],
1102 squash=True,
1103 expected_upstream_ref='origin/master',
1104 issue=123456)
1105
rmistry@google.com2dd99862015-06-22 12:22:18 +00001106 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001107 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001108 def mock_run_git(*args, **_kwargs):
1109 if args[0] == ['for-each-ref',
1110 '--format=%(refname:short) %(upstream:short)',
1111 'refs/heads']:
1112 # Create a local branch dependency tree that looks like this:
1113 # test1 -> test2 -> test3 -> test4 -> test5
1114 # -> test3.1
1115 # test6 -> test0
1116 branch_deps = [
1117 'test2 test1', # test1 -> test2
1118 'test3 test2', # test2 -> test3
1119 'test3.1 test2', # test2 -> test3.1
1120 'test4 test3', # test3 -> test4
1121 'test5 test4', # test4 -> test5
1122 'test6 test0', # test0 -> test6
1123 'test7', # test7
1124 ]
1125 return '\n'.join(branch_deps)
1126 self.mock(git_cl, 'RunGit', mock_run_git)
1127
1128 class RecordCalls:
1129 times_called = 0
1130 record_calls = RecordCalls()
1131 def mock_CMDupload(*args, **_kwargs):
1132 record_calls.times_called += 1
1133 return 0
1134 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1135
1136 self.calls = [
1137 (('[Press enter to continue or ctrl-C to quit]',), ''),
1138 ]
1139
1140 class MockChangelist():
1141 def __init__(self):
1142 pass
1143 def GetBranch(self):
1144 return 'test1'
1145 def GetIssue(self):
1146 return '123'
1147 def GetPatchset(self):
1148 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001149 def IsGerrit(self):
1150 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001151
1152 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1153 # CMDupload should have been called 5 times because of 5 dependent branches.
1154 self.assertEquals(5, record_calls.times_called)
1155 self.assertEquals(0, ret)
1156
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001157 def test_gerrit_change_id(self):
1158 self.calls = [
1159 ((['git', 'write-tree'], ),
1160 'hashtree'),
1161 ((['git', 'rev-parse', 'HEAD~0'], ),
1162 'branch-parent'),
1163 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1164 'A B <a@b.org> 1456848326 +0100'),
1165 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1166 'C D <c@d.org> 1456858326 +0100'),
1167 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1168 'hashchange'),
1169 ]
1170 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1171 self.assertEqual(change_id, 'Ihashchange')
1172
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001173 def test_desecription_append_footer(self):
1174 for init_desc, footer_line, expected_desc in [
1175 # Use unique desc first lines for easy test failure identification.
1176 ('foo', 'R=one', 'foo\n\nR=one'),
1177 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1178 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1179 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1180 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1181 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1182 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1183 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1184 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1185 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1186 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1187 ]:
1188 desc = git_cl.ChangeDescription(init_desc)
1189 desc.append_footer(footer_line)
1190 self.assertEqual(desc.description, expected_desc)
1191
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001192 def test_update_reviewers(self):
1193 data = [
1194 ('foo', [], 'foo'),
agable@chromium.org42c20792013-09-12 17:34:49 +00001195 ('foo\nR=xx', [], 'foo\nR=xx'),
1196 ('foo\nTBR=xx', [], 'foo\nTBR=xx'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001197 ('foo', ['a@c'], 'foo\n\nR=a@c'),
agable@chromium.org42c20792013-09-12 17:34:49 +00001198 ('foo\nR=xx', ['a@c'], 'foo\n\nR=a@c, xx'),
1199 ('foo\nTBR=xx', ['a@c'], 'foo\n\nR=a@c\nTBR=xx'),
1200 ('foo\nTBR=xx\nR=yy', ['a@c'], 'foo\n\nR=a@c, yy\nTBR=xx'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001201 ('foo\nBUG=', ['a@c'], 'foo\nBUG=\nR=a@c'),
agable@chromium.org42c20792013-09-12 17:34:49 +00001202 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], 'foo\n\nR=a@c, xx, bar\nTBR=yy'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001203 ('foo', ['a@c', 'b@c'], 'foo\n\nR=a@c, b@c'),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001204 ('foo\nBar\n\nR=\nBUG=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='),
1205 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='),
1206 # Same as the line before, but full of whitespaces.
1207 (
1208 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'],
1209 'foo\nBar\n\nR=c@c\n BUG =',
1210 ),
1211 # Whitespaces aren't interpreted as new lines.
1212 ('foo BUG=allo R=joe ', ['c@c'], 'foo BUG=allo R=joe\n\nR=c@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001213 ]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001214 expected = [i[2] for i in data]
1215 actual = []
1216 for orig, reviewers, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001217 obj = git_cl.ChangeDescription(orig)
1218 obj.update_reviewers(reviewers)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001219 actual.append(obj.description)
1220 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001221
wittman@chromium.org455dc922015-01-26 20:15:50 +00001222 def test_get_target_ref(self):
1223 # Check remote or remote branch not present.
1224 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master', None))
1225 self.assertEqual(None, git_cl.GetTargetRef(None,
1226 'refs/remotes/origin/master',
1227 'master', None))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001228
wittman@chromium.org455dc922015-01-26 20:15:50 +00001229 # Check default target refs for branches.
1230 self.assertEqual('refs/heads/master',
1231 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
1232 None, None))
1233 self.assertEqual('refs/heads/master',
1234 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
1235 None, None))
1236 self.assertEqual('refs/heads/master',
1237 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
1238 None, None))
1239 self.assertEqual('refs/branch-heads/123',
1240 git_cl.GetTargetRef('origin',
1241 'refs/remotes/branch-heads/123',
1242 None, None))
1243 self.assertEqual('refs/diff/test',
1244 git_cl.GetTargetRef('origin',
1245 'refs/remotes/origin/refs/diff/test',
1246 None, None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001247 self.assertEqual('refs/heads/chrome/m42',
1248 git_cl.GetTargetRef('origin',
1249 'refs/remotes/origin/chrome/m42',
1250 None, None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001251
1252 # Check target refs for user-specified target branch.
1253 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1254 'refs/remotes/branch-heads/123'):
1255 self.assertEqual('refs/branch-heads/123',
1256 git_cl.GetTargetRef('origin',
1257 'refs/remotes/origin/master',
1258 branch, None))
1259 for branch in ('origin/master', 'remotes/origin/master',
1260 'refs/remotes/origin/master'):
1261 self.assertEqual('refs/heads/master',
1262 git_cl.GetTargetRef('origin',
1263 'refs/remotes/branch-heads/123',
1264 branch, None))
1265 for branch in ('master', 'heads/master', 'refs/heads/master'):
1266 self.assertEqual('refs/heads/master',
1267 git_cl.GetTargetRef('origin',
1268 'refs/remotes/branch-heads/123',
1269 branch, None))
1270
1271 # Check target refs for pending prefix.
1272 self.assertEqual('prefix/heads/master',
1273 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
1274 None, 'prefix/'))
1275
wychen@chromium.orga872e752015-04-28 23:42:18 +00001276 def test_patch_when_dirty(self):
1277 # Patch when local tree is dirty
1278 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1279 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1280
1281 def test_diff_when_dirty(self):
1282 # Do 'git cl diff' when local tree is dirty
1283 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1284 self.assertNotEqual(git_cl.main(['diff']), 0)
1285
tandriidf09a462016-08-18 16:23:55 -07001286 def _patch_common(self, is_gerrit=False, force_codereview=False,
1287 new_branch=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001288 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001289 self.mock(git_cl._RietveldChangelistImpl, 'GetMostRecentPatchset',
1290 lambda x: '60001')
1291 self.mock(git_cl._RietveldChangelistImpl, 'GetPatchSetDiff',
1292 lambda *args: None)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001293 self.mock(git_cl._GerritChangelistImpl, '_GetChangeDetail',
1294 lambda *args: {
1295 'current_revision': '7777777777',
1296 'revisions': {
1297 '1111111111': {
1298 '_number': 1,
1299 'fetch': {'http': {
1300 'url': 'https://chromium.googlesource.com/my/repo',
1301 'ref': 'refs/changes/56/123456/1',
1302 }},
1303 },
1304 '7777777777': {
1305 '_number': 7,
1306 'fetch': {'http': {
1307 'url': 'https://chromium.googlesource.com/my/repo',
1308 'ref': 'refs/changes/56/123456/7',
1309 }},
1310 },
1311 },
1312 })
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001313 self.mock(git_cl.Changelist, 'GetDescription',
1314 lambda *args: 'Description')
wychen@chromium.orga872e752015-04-28 23:42:18 +00001315 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1316
tandriidf09a462016-08-18 16:23:55 -07001317 if new_branch:
1318 self.calls = [((['git', 'new-branch', 'master'],), ''),]
1319 else:
1320 self.calls = [((['git', 'symbolic-ref', 'HEAD'],), 'master')]
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001321 if not force_codereview:
1322 # These calls detect codereview to use.
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00001323 self.calls += [
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001324 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -07001325 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1326 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
tandrii5d48c322016-08-18 16:19:37 -07001327 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001328 ]
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001329
1330 if is_gerrit:
1331 if not force_codereview:
1332 self.calls += [
1333 ((['git', 'config', 'gerrit.host'],), 'true'),
1334 ]
1335 else:
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001336 self.calls += [
tandrii5d48c322016-08-18 16:19:37 -07001337 ((['git', 'config', 'gerrit.host'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001338 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
1339 ((['git', 'rev-parse', '--show-cdup'],), ''),
1340 ((['sed', '-e', 's|^--- a/|--- |; s|^+++ b/|+++ |'],), ''),
1341 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001342
tandriidf09a462016-08-18 16:23:55 -07001343 def _common_patch_successful(self, new_branch=False):
1344 self._patch_common(new_branch=new_branch)
wychen@chromium.orga872e752015-04-28 23:42:18 +00001345 self.calls += [
1346 ((['git', 'apply', '--index', '-p0', '--3way'],), ''),
1347 ((['git', 'commit', '-m',
wychen@chromium.org5b3bebb2015-05-28 21:41:43 +00001348 'Description\n\n' +
wychen@chromium.orga872e752015-04-28 23:42:18 +00001349 'patch from issue 123456 at patchset 60001 ' +
1350 '(http://crrev.com/123456#ps60001)'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001351 ((['git', 'config', 'branch.master.rietveldissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001352 ''),
1353 ((['git', 'config', 'branch.master.rietveldserver'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001354 ((['git', 'config', 'branch.master.rietveldserver',
1355 'https://codereview.example.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001356 ((['git', 'config', 'branch.master.rietveldpatchset', '60001'],),
tandrii5d48c322016-08-18 16:19:37 -07001357 ''),
wychen@chromium.orga872e752015-04-28 23:42:18 +00001358 ]
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00001359
1360 def test_patch_successful(self):
1361 self._common_patch_successful()
wychen@chromium.orga872e752015-04-28 23:42:18 +00001362 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1363
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00001364 def test_patch_successful_new_branch(self):
tandriidf09a462016-08-18 16:23:55 -07001365 self._common_patch_successful(new_branch=True)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00001366 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1367
wychen@chromium.orga872e752015-04-28 23:42:18 +00001368 def test_patch_conflict(self):
1369 self._patch_common()
1370 self.calls += [
tandrii5d48c322016-08-18 16:19:37 -07001371 ((['git', 'apply', '--index', '-p0', '--3way'],), CERR1),
wychen@chromium.orga872e752015-04-28 23:42:18 +00001372 ]
1373 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
wittman@chromium.org455dc922015-01-26 20:15:50 +00001374
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001375 def test_gerrit_patch_successful(self):
1376 self._patch_common(is_gerrit=True)
1377 self.calls += [
1378 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1379 'refs/changes/56/123456/7'],), ''),
1380 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001381 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001382 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001383 ((['git', 'config', 'branch.master.gerritserver'],), ''),
1384 ((['git', 'config', 'branch.master.merge'],), 'master'),
1385 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1386 ((['git', 'config', 'remote.origin.url'],),
1387 'https://chromium.googlesource.com/my/repo'),
1388 ((['git', 'config', 'branch.master.gerritserver',
1389 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001390 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001391 ]
1392 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1393
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001394 def test_patch_force_codereview(self):
1395 self._patch_common(is_gerrit=True, force_codereview=True)
1396 self.calls += [
1397 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1398 'refs/changes/56/123456/7'],), ''),
1399 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1400 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -07001401 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001402 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001403 ((['git', 'config', 'branch.master.gerritserver'],), ''),
1404 ((['git', 'config', 'branch.master.merge'],), 'master'),
1405 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1406 ((['git', 'config', 'remote.origin.url'],),
1407 'https://chromium.googlesource.com/my/repo'),
1408 ((['git', 'config', 'branch.master.gerritserver',
1409 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001410 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001411 ]
1412 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456']), 0)
1413
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001414 def test_gerrit_patch_url_successful(self):
1415 self._patch_common(is_gerrit=True)
1416 self.calls += [
1417 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1418 'refs/changes/56/123456/1'],), ''),
1419 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001420 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001421 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001422 ((['git', 'config', 'branch.master.gerritserver',
1423 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001424 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001425 ]
1426 self.assertEqual(git_cl.main(
1427 ['patch', 'https://chromium-review.googlesource.com/#/c/123456/1']), 0)
1428
1429 def test_gerrit_patch_conflict(self):
1430 self._patch_common(is_gerrit=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001431 self.calls += [
1432 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1433 'refs/changes/56/123456/1'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001434 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1435 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1436 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001437 ]
1438 with self.assertRaises(SystemExitMock):
1439 git_cl.main(['patch',
1440 'https://chromium-review.googlesource.com/#/c/123456/1'])
1441
tandriic2405f52016-10-10 08:13:15 -07001442 def test_gerrit_patch_not_exists(self):
1443 url = 'https://chromium-review.googlesource.com'
1444 self.mock(git_cl.gerrit_util, 'GetChangeDetail', lambda _, __, ___: None)
1445 self.calls = [
1446 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
1447 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
1448 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1449 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
1450 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1451 ((['git', 'config', 'gerrit.host'],), 'true'),
1452 ((['DieWithError', 'issue 123456 at ' + url + ' does not exist '
1453 'or you have no access to it'],), SystemExitMock()),
1454 ]
1455 with self.assertRaises(SystemExitMock):
1456 self.assertEqual(1, git_cl.main(['patch', url + '/#/c/123456/1']))
1457
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001458 def _checkout_calls(self):
1459 return [
1460 ((['git', 'config', '--local', '--get-regexp',
1461 'branch\\..*\\.rietveldissue'], ),
1462 ('branch.retrying.rietveldissue 1111111111\n'
1463 'branch.some-fix.rietveldissue 2222222222\n')),
1464 ((['git', 'config', '--local', '--get-regexp',
1465 'branch\\..*\\.gerritissue'], ),
1466 ('branch.ger-branch.gerritissue 123456\n'
1467 'branch.gbranch654.gerritissue 654321\n')),
1468 ]
1469
1470 def test_checkout_gerrit(self):
1471 """Tests git cl checkout <issue>."""
1472 self.calls = self._checkout_calls()
1473 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1474 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1475
1476 def test_checkout_rietveld(self):
1477 """Tests git cl checkout <issue>."""
1478 self.calls = self._checkout_calls()
1479 self.calls += [((['git', 'checkout', 'some-fix'], ), '')]
1480 self.assertEqual(0, git_cl.main(['checkout', '2222222222']))
1481
1482 def test_checkout_not_found(self):
1483 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001484 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001485 self.calls = self._checkout_calls()
1486 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1487
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001488 def test_checkout_no_branch_issues(self):
1489 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001490 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001491 self.calls = [
1492 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001493 'branch\\..*\\.rietveldissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001494 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001495 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001496 ]
1497 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1498
tandrii@chromium.org28253532016-04-14 13:46:56 +00001499 def _test_gerrit_ensure_authenticated_common(self, auth,
1500 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001501 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1502 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1503 self.mock(git_cl, 'DieWithError',
1504 lambda msg: self._mocked_call(['DieWithError', msg]))
1505 self.mock(git_cl, 'ask_for_data',
1506 lambda msg: self._mocked_call(['ask_for_data', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001507 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001508 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00001509 cl.branch = 'master'
1510 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001511 cl.lookedup_issue = True
1512 return cl
1513
1514 def test_gerrit_ensure_authenticated_missing(self):
1515 cl = self._test_gerrit_ensure_authenticated_common(auth={
1516 'chromium.googlesource.com': 'git is ok, but gerrit one is missing',
1517 })
1518 self.calls.append(
1519 ((['DieWithError',
1520 'Credentials for the following hosts are required:\n'
1521 ' chromium-review.googlesource.com\n'
1522 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
1523 'You can (re)generate your credentails by visiting '
1524 'https://chromium-review.googlesource.com/new-password'],), ''),)
1525 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1526
1527 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001528 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001529 cl = self._test_gerrit_ensure_authenticated_common(auth={
1530 'chromium.googlesource.com': 'one',
1531 'chromium-review.googlesource.com': 'other',
1532 })
1533 self.calls.append(
1534 ((['ask_for_data', 'If you know what you are doing, '
qyearsley53f48a12016-09-01 10:45:13 -07001535 'press Enter to continue, Ctrl+C to abort.'],), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001536 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1537
1538 def test_gerrit_ensure_authenticated_ok(self):
1539 cl = self._test_gerrit_ensure_authenticated_common(auth={
1540 'chromium.googlesource.com': 'same',
1541 'chromium-review.googlesource.com': 'same',
1542 })
1543 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1544
tandrii@chromium.org28253532016-04-14 13:46:56 +00001545 def test_gerrit_ensure_authenticated_skipped(self):
1546 cl = self._test_gerrit_ensure_authenticated_common(
1547 auth={}, skip_auth_check=True)
1548 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1549
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001550 def test_cmd_set_commit_rietveld(self):
tandrii4d843592016-07-27 08:22:56 -07001551 self.mock(git_cl._RietveldChangelistImpl, 'SetFlags',
1552 lambda _, v: self._mocked_call(['SetFlags', v]))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001553 self.calls = [
1554 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001555 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001556 ((['git', 'config', 'rietveld.autoupdate'],), ''),
1557 ((['git', 'config', 'rietveld.server'],), ''),
1558 ((['git', 'config', 'rietveld.server'],), ''),
1559 ((['git', 'config', 'branch.feature.rietveldserver'],),
1560 'https://codereview.chromium.org'),
tandrii4d843592016-07-27 08:22:56 -07001561 ((['SetFlags', {'commit': '1', 'cq_dry_run': '0'}], ), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001562 ]
1563 self.assertEqual(0, git_cl.main(['set-commit']))
1564
tandriid9e5ce52016-07-13 02:32:59 -07001565 def _cmd_set_commit_gerrit_common(self, vote):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001566 self.mock(git_cl.gerrit_util, 'SetReview',
1567 lambda h, i, labels: self._mocked_call(
1568 ['SetReview', h, i, labels]))
1569 self.calls = [
1570 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001571 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
1572 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001573 ((['git', 'config', 'branch.feature.gerritserver'],),
1574 'https://chromium-review.googlesource.com'),
1575 ((['SetReview', 'chromium-review.googlesource.com', 123,
tandriid9e5ce52016-07-13 02:32:59 -07001576 {'Commit-Queue': vote}],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001577 ]
tandriid9e5ce52016-07-13 02:32:59 -07001578
1579 def test_cmd_set_commit_gerrit_clear(self):
1580 self._cmd_set_commit_gerrit_common(0)
1581 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1582
1583 def test_cmd_set_commit_gerrit_dry(self):
1584 self._cmd_set_commit_gerrit_common(1)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001585 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1586
tandriid9e5ce52016-07-13 02:32:59 -07001587 def test_cmd_set_commit_gerrit(self):
1588 self._cmd_set_commit_gerrit_common(2)
1589 self.assertEqual(0, git_cl.main(['set-commit']))
1590
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001591 def test_description_display(self):
1592 out = StringIO.StringIO()
1593 self.mock(git_cl.sys, 'stdout', out)
1594
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001595 self.mock(git_cl, 'Changelist', ChangelistMock)
1596 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001597
1598 self.assertEqual(0, git_cl.main(['description', '-d']))
1599 self.assertEqual('foo\n', out.getvalue())
1600
1601 def test_description_rietveld(self):
1602 out = StringIO.StringIO()
1603 self.mock(git_cl.sys, 'stdout', out)
martiniss6eda05f2016-06-30 10:18:35 -07001604 self.mock(git_cl.Changelist, 'GetDescription', lambda *args: 'foobar')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001605
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001606 self.assertEqual(0, git_cl.main([
1607 'description', 'https://code.review.org/123123', '-d', '--rietveld']))
1608 self.assertEqual('foobar\n', out.getvalue())
1609
iannucci3c972b92016-08-17 13:24:10 -07001610 def test_StatusFieldOverrideIssueMissingArgs(self):
1611 out = StringIO.StringIO()
1612 self.mock(git_cl.sys, 'stderr', out)
1613
1614 try:
1615 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
1616 except SystemExit as ex:
1617 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001618 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001619
1620 out = StringIO.StringIO()
1621 self.mock(git_cl.sys, 'stderr', out)
1622
1623 try:
1624 self.assertEqual(git_cl.main(['status', '--issue', '1', '--rietveld']), 0)
1625 except SystemExit as ex:
1626 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001627 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001628
1629 def test_StatusFieldOverrideIssue(self):
1630 out = StringIO.StringIO()
1631 self.mock(git_cl.sys, 'stdout', out)
1632
1633 def assertIssue(cl_self, *_args):
1634 self.assertEquals(cl_self.issue, 1)
1635 return 'foobar'
1636
1637 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
1638 self.calls = [
1639 ((['git', 'config', 'rietveld.autoupdate'],), ''),
1640 ((['git', 'config', 'rietveld.server'],), ''),
1641 ((['git', 'config', 'rietveld.server'],), ''),
1642 ]
iannuccie53c9352016-08-17 14:40:40 -07001643 self.assertEqual(
1644 git_cl.main(['status', '--issue', '1', '--rietveld', '--field', 'desc']),
1645 0)
iannucci3c972b92016-08-17 13:24:10 -07001646 self.assertEqual(out.getvalue(), 'foobar\n')
1647
iannuccie53c9352016-08-17 14:40:40 -07001648 def test_SetCloseOverrideIssue(self):
1649 def assertIssue(cl_self, *_args):
1650 self.assertEquals(cl_self.issue, 1)
1651 return 'foobar'
1652
1653 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
1654 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
1655 self.calls = [
1656 ((['git', 'config', 'rietveld.autoupdate'],), ''),
1657 ((['git', 'config', 'rietveld.server'],), ''),
1658 ((['git', 'config', 'rietveld.server'],), ''),
1659 ]
1660 self.assertEqual(
1661 git_cl.main(['set-close', '--issue', '1', '--rietveld']), 0)
1662
1663 def test_SetCommitOverrideIssue(self):
1664 def assertIssue(cl_self, *_args):
1665 self.assertEquals(cl_self.issue, 1)
1666 return 'foobar'
1667
1668 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
1669 self.mock(git_cl.Changelist, 'SetCQState', lambda *_: None)
1670 self.calls = [
1671 ((['git', 'config', 'rietveld.autoupdate'],), ''),
1672 ((['git', 'config', 'rietveld.server'],), ''),
1673 ((['git', 'config', 'rietveld.server'],), ''),
1674 ((['git', 'symbolic-ref', 'HEAD'],), ''),
1675 ((['git', 'config', 'rietveld.server'],), ''),
1676 ((['git', 'config', 'rietveld.server'],), ''),
1677 ]
1678 self.assertEqual(
1679 git_cl.main(['set-close', '--issue', '1', '--rietveld']), 0)
1680
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001681 def test_description_gerrit(self):
1682 out = StringIO.StringIO()
1683 self.mock(git_cl.sys, 'stdout', out)
martiniss6eda05f2016-06-30 10:18:35 -07001684 self.mock(git_cl.Changelist, 'GetDescription', lambda *args: 'foobar')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001685
1686 self.assertEqual(0, git_cl.main([
1687 'description', 'https://code.review.org/123123', '-d', '--gerrit']))
1688 self.assertEqual('foobar\n', out.getvalue())
1689
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001690 def test_description_set_raw(self):
1691 out = StringIO.StringIO()
1692 self.mock(git_cl.sys, 'stdout', out)
1693
1694 self.mock(git_cl, 'Changelist', ChangelistMock)
1695 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
1696
1697 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
1698 self.assertEqual('hihi', ChangelistMock.desc)
1699
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001700 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001701 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001702
1703 def RunEditor(desc, _, **kwargs):
1704 self.assertEquals(
1705 '# Enter a description of the change.\n'
1706 '# This will be displayed on the codereview site.\n'
1707 '# The first line will also be used as the subject of the review.\n'
1708 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001709 '--------------------\n'
1710 'Some.\n\nBUG=\n\nChange-Id: xxx',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001711 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001712 # Simulate user changing something.
1713 return 'Some.\n\nBUG=123\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001714
dsansomee2d6fd92016-09-08 00:10:47 -07001715 def UpdateDescriptionRemote(_, desc, force=False):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001716 self.assertEquals(desc, 'Some.\n\nBUG=123\n\nChange-Id: xxx')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001717
1718 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1719 self.mock(git_cl.Changelist, 'GetDescription',
1720 lambda *args: current_desc)
1721 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
1722 UpdateDescriptionRemote)
1723 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
1724
1725 self.calls = [
1726 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001727 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07001728 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1729 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001730 ((['git', 'config', 'core.editor'],), 'vi'),
1731 ]
1732 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
1733
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001734 def test_description_set_stdin(self):
1735 out = StringIO.StringIO()
1736 self.mock(git_cl.sys, 'stdout', out)
1737
1738 self.mock(git_cl, 'Changelist', ChangelistMock)
1739 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
1740
1741 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
1742 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
1743
kmarshall3bff56b2016-06-06 18:31:47 -07001744 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07001745 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1746
kmarshall3bff56b2016-06-06 18:31:47 -07001747 self.calls = \
1748 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
1749 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
tandrii33a46ff2016-08-23 05:53:40 -07001750 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
tandrii5d48c322016-08-18 16:19:37 -07001751 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1752 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
tandrii33a46ff2016-08-23 05:53:40 -07001753 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
1754 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
1755 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07001756 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
1757 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
1758 ((['git', 'branch', '-D', 'foo'],), '')]
1759
kmarshall3bff56b2016-06-06 18:31:47 -07001760 self.mock(git_cl, 'get_cl_statuses',
1761 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07001762 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
1763 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
1764 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07001765
1766 self.assertEqual(0, git_cl.main(['archive', '-f']))
1767
1768 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07001769 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07001770 self.calls = \
1771 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
1772 'refs/heads/master'),
tandrii33a46ff2016-08-23 05:53:40 -07001773 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
tandrii5d48c322016-08-18 16:19:37 -07001774 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1775 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
kmarshall3bff56b2016-06-06 18:31:47 -07001776 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
1777
kmarshall9249e012016-08-23 12:02:16 -07001778 self.mock(git_cl, 'get_cl_statuses',
1779 lambda branches, fine_grained, max_processes:
1780 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
1781
1782 self.assertEqual(1, git_cl.main(['archive', '-f']))
1783
1784 def test_archive_dry_run(self):
1785 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1786
1787 self.calls = \
1788 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
1789 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
1790 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
1791 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1792 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
1793 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
1794 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
1795 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
1796 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07001797
1798 self.mock(git_cl, 'get_cl_statuses',
1799 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07001800 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
1801 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
1802 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07001803
kmarshall9249e012016-08-23 12:02:16 -07001804 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
1805
1806 def test_archive_no_tags(self):
1807 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1808
1809 self.calls = \
1810 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
1811 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
1812 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
1813 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1814 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
1815 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
1816 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
1817 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
1818 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
1819 ((['git', 'branch', '-D', 'foo'],), '')]
1820
1821 self.mock(git_cl, 'get_cl_statuses',
1822 lambda branches, fine_grained, max_processes:
1823 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
1824 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
1825 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
1826
1827 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07001828
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001829 def test_cmd_issue_erase_existing(self):
1830 out = StringIO.StringIO()
1831 self.mock(git_cl.sys, 'stdout', out)
1832 self.calls = [
1833 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001834 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
1835 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001836 # Let this command raise exception (retcode=1) - it should be ignored.
1837 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07001838 CERR1),
1839 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
1840 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001841 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
1842 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
1843 ''),
1844 ]
1845 self.assertEqual(0, git_cl.main(['issue', '0']))
1846
phajdan.jre328cf92016-08-22 04:12:17 -07001847 def test_cmd_issue_json(self):
1848 out = StringIO.StringIO()
1849 self.mock(git_cl.sys, 'stdout', out)
1850 self.calls = [
1851 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001852 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
phajdan.jre328cf92016-08-22 04:12:17 -07001853 ((['git', 'config', 'rietveld.autoupdate'],), ''),
1854 ((['git', 'config', 'rietveld.server'],),
1855 'https://codereview.chromium.org'),
1856 ((['git', 'config', 'branch.feature.rietveldserver'],), ''),
1857 (('write_json', 'output.json',
1858 {'issue': 123, 'issue_url': 'https://codereview.chromium.org/123'}),
1859 ''),
1860 ]
1861 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
1862
tandriide281ae2016-10-12 06:02:30 -07001863 def test_git_cl_try_default_cq_dry_run(self):
tandrii9de9ec62016-07-13 03:01:59 -07001864 self.mock(git_cl.Changelist, 'GetChange',
1865 lambda _, *a: (
1866 self._mocked_call(['GetChange']+list(a))))
1867 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
1868 lambda *_, **__: (
1869 self._mocked_call(['DoGetTryMasters'])))
1870 self.mock(git_cl.presubmit_support, 'DoGetTrySlaves',
1871 lambda *_, **__: (
1872 self._mocked_call(['DoGetTrySlaves'])))
1873 self.mock(git_cl._RietveldChangelistImpl, 'SetCQState',
1874 lambda _, s: self._mocked_call(['SetCQState', s]))
1875 self.calls = [
1876 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001877 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
tandrii9de9ec62016-07-13 03:01:59 -07001878 ((['git', 'config', 'rietveld.autoupdate'],), ''),
1879 ((['git', 'config', 'rietveld.server'],),
1880 'https://codereview.chromium.org'),
1881 ((['git', 'config', 'branch.feature.rietveldserver'],), ''),
1882 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
1883 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1884 ((['get_or_create_merge_base', 'feature', 'feature'],),
1885 'fake_ancestor_sha'),
1886 ((['GetChange', 'fake_ancestor_sha', None], ),
1887 git_cl.presubmit_support.GitChange(
1888 '', '', '', '', '', '', '', '')),
1889 ((['git', 'rev-parse', '--show-cdup'],), '../'),
1890 ((['DoGetTryMasters'], ), None),
1891 ((['DoGetTrySlaves'], ), None),
1892 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
1893 ]
1894 out = StringIO.StringIO()
1895 self.mock(git_cl.sys, 'stdout', out)
1896 self.assertEqual(0, git_cl.main(['try']))
1897 self.assertEqual(
1898 out.getvalue(),
1899 'scheduled CQ Dry Run on https://codereview.chromium.org/123\n')
1900
tandriide281ae2016-10-12 06:02:30 -07001901 def test_git_cl_try_buildbucket_with_properties(self):
1902 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 20001)
1903 self.mock(git_cl.Changelist, 'GetIssueOwner', lambda _: 'owner@e.mail')
1904 self.mock(git_cl.Changelist, 'GetIssueProject', lambda _: 'depot_tools')
1905 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
1906 self.calls = [
1907 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
1908 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
1909 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1910 ((['git', 'config', 'rietveld.server'],),
1911 'https://codereview.chromium.org'),
1912 ((['git', 'config', 'branch.feature.rietveldserver'],), CERR1),
1913 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
1914 ]
1915
1916 def _buildbucket_retry(*_, **kw):
1917 # self.maxDiff = 10000
1918 body = json.loads(kw['body'])
1919 self.assertEqual(len(body['builds']), 1)
1920 build = body['builds'][0]
1921 params = json.loads(build.pop('parameters_json'))
1922 self.assertEqual(params, {
1923 u'builder_name': u'win',
1924 u'changes': [{u'author': {u'email': u'owner@e.mail'},
1925 u'revision': None}],
1926 u'properties': {
1927 u'category': u'git_cl_try',
1928 u'issue': 123,
1929 u'key': u'val',
1930 u'json': [{u'a': 1}, None],
1931 u'master': u'tryserver.chromium',
1932 u'patch_project': u'depot_tools',
1933 u'patch_storage': u'rietveld',
1934 u'patchset': 20001,
1935 u'reason': u'feature', # This is a branch name, but why?
1936 u'rietveld': u'https://codereview.chromium.org',
1937 }
1938 })
1939 self.assertEqual(build, {
1940 u'bucket': u'master.tryserver.chromium',
1941 u'client_operation_id': u'uuid4',
1942 u'tags': [u'builder:win',
1943 u'buildset:patch/rietveld/codereview.chromium.org/123/20001',
borenet6c0efe62016-10-19 08:13:29 -07001944 u'user_agent:git_cl_try',
1945 u'master:tryserver.chromium'],
tandriide281ae2016-10-12 06:02:30 -07001946 })
1947
1948 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
1949
1950 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1951 self.assertEqual(0, git_cl.main([
1952 'try', '-m', 'tryserver.chromium', '-b', 'win',
1953 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
1954 self.assertRegexpMatches(
1955 git_cl.sys.stdout.getvalue(),
borenet6c0efe62016-10-19 08:13:29 -07001956 'Tried jobs on:\nBucket: master.tryserver.chromium')
1957
1958 def test_git_cl_try_buildbucket_bucket_flag(self):
1959 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 20001)
1960 self.mock(git_cl.Changelist, 'GetIssueOwner', lambda _: 'owner@e.mail')
1961 self.mock(git_cl.Changelist, 'GetIssueProject', lambda _: 'depot_tools')
1962 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
1963 self.calls = [
1964 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
1965 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
1966 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1967 ((['git', 'config', 'rietveld.server'],),
1968 'https://codereview.chromium.org'),
1969 ((['git', 'config', 'branch.feature.rietveldserver'],), CERR1),
1970 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
1971 ]
1972
1973 def _buildbucket_retry(*_, **kw):
1974 # self.maxDiff = 10000
1975 body = json.loads(kw['body'])
1976 self.assertEqual(len(body['builds']), 1)
1977 build = body['builds'][0]
1978 params = json.loads(build.pop('parameters_json'))
1979 self.assertEqual(params, {
1980 u'builder_name': u'win',
1981 u'changes': [{u'author': {u'email': u'owner@e.mail'},
1982 u'revision': None}],
1983 u'properties': {
1984 u'category': u'git_cl_try',
1985 u'issue': 123,
1986 u'patch_project': u'depot_tools',
1987 u'patch_storage': u'rietveld',
1988 u'patchset': 20001,
1989 u'reason': u'feature', # This is a branch name, but why?
1990 u'rietveld': u'https://codereview.chromium.org',
1991 }
1992 })
1993 self.assertEqual(build, {
1994 u'bucket': u'test.bucket',
1995 u'client_operation_id': u'uuid4',
1996 u'tags': [u'builder:win',
1997 u'buildset:patch/rietveld/codereview.chromium.org/123/20001',
1998 u'user_agent:git_cl_try'],
1999 })
2000
2001 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2002
2003 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2004 self.assertEqual(0, git_cl.main([
2005 'try', '-B', 'test.bucket', '-b', 'win']))
2006 self.assertRegexpMatches(
2007 git_cl.sys.stdout.getvalue(),
2008 'Tried jobs on:\nBucket: test.bucket')
tandriide281ae2016-10-12 06:02:30 -07002009
tandrii16e0b4e2016-06-07 10:34:28 -07002010 def _common_GerritCommitMsgHookCheck(self):
2011 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2012 self.mock(git_cl.os.path, 'abspath',
2013 lambda path: self._mocked_call(['abspath', path]))
2014 self.mock(git_cl.os.path, 'exists',
2015 lambda path: self._mocked_call(['exists', path]))
2016 self.mock(git_cl.gclient_utils, 'FileRead',
2017 lambda path: self._mocked_call(['FileRead', path]))
2018 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2019 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2020 self.calls = [
2021 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2022 ((['abspath', '../'],), '/abs/git_repo_root'),
2023 ]
2024 return git_cl.Changelist(codereview='gerrit', issue=123)
2025
2026 def test_GerritCommitMsgHookCheck_custom_hook(self):
2027 cl = self._common_GerritCommitMsgHookCheck()
2028 self.calls += [
2029 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2030 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2031 '#!/bin/sh\necho "custom hook"')
2032 ]
2033 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2034
2035 def test_GerritCommitMsgHookCheck_not_exists(self):
2036 cl = self._common_GerritCommitMsgHookCheck()
2037 self.calls += [
2038 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2039 ]
2040 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2041
2042 def test_GerritCommitMsgHookCheck(self):
2043 cl = self._common_GerritCommitMsgHookCheck()
2044 self.calls += [
2045 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2046 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2047 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
2048 (('Do you want to remove it now? [Yes/No]',), 'Yes'),
2049 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2050 ''),
2051 ]
2052 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2053
tandriic4344b52016-08-29 06:04:54 -07002054 def test_GerritCmdLand(self):
2055 self.calls += [
2056 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2057 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2058 'deadbeaf'),
2059 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2060 ((['git', 'config', 'branch.feature.gerritserver'],),
2061 'chromium-review.googlesource.com'),
2062 ]
2063 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2064 cl._codereview_impl._GetChangeDetail = lambda _: {
2065 'labels': {},
2066 'current_revision': 'deadbeaf',
2067 }
2068 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002069 out = StringIO.StringIO()
2070 self.mock(sys, 'stdout', out)
tandriic4344b52016-08-29 06:04:54 -07002071 self.assertEqual(0, cl.CMDLand(force=True, bypass_hooks=True, verbose=True))
tandrii8da412c2016-09-07 16:01:07 -07002072 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
tandriic4344b52016-08-29 06:04:54 -07002073
tandrii221ab252016-10-06 08:12:04 -07002074 BUILDBUCKET_BUILDS_MAP = {
2075 '9000': {
2076 'id': '9000',
2077 'status': 'STARTED',
2078 'url': 'http://build.cr.org/p/x.y/builders/my-builder/builds/2',
2079 'result_details_json': '{"properties": {}}',
2080 'bucket': 'master.x.y',
2081 'created_by': 'user:someone@chromium.org',
2082 'created_ts': '147200002222000',
2083 'parameters_json': '{"builder_name": "my-builder", "category": ""}',
2084 },
2085 '8000': {
2086 'id': '8000',
2087 'status': 'COMPLETED',
2088 'result': 'FAILURE',
2089 'failure_reason': 'BUILD_FAILURE',
2090 'url': 'http://build.cr.org/p/x.y/builders/my-builder/builds/1',
2091 'result_details_json': '{"properties": {}}',
2092 'bucket': 'master.x.y',
2093 'created_by': 'user:someone@chromium.org',
2094 'created_ts': '147200001111000',
2095 'parameters_json': '{"builder_name": "my-builder", "category": ""}',
2096 },
2097 }
2098
2099 def test_write_try_results_json(self):
2100 expected_output = [
2101 {
2102 'buildbucket_id': '8000',
2103 'bucket': 'master.x.y',
2104 'builder_name': 'my-builder',
2105 'status': 'COMPLETED',
2106 'result': 'FAILURE',
2107 'failure_reason': 'BUILD_FAILURE',
2108 'url': 'http://build.cr.org/p/x.y/builders/my-builder/builds/1',
2109 },
2110 {
2111 'buildbucket_id': '9000',
2112 'bucket': 'master.x.y',
2113 'builder_name': 'my-builder',
2114 'status': 'STARTED',
2115 'result': None,
2116 'failure_reason': None,
2117 'url': 'http://build.cr.org/p/x.y/builders/my-builder/builds/2',
2118 }
2119 ]
2120 self.calls = [(('write_json', 'output.json', expected_output), '')]
2121 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2122
tandrii45b2a582016-10-11 03:14:16 -07002123 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002124 out = StringIO.StringIO()
2125 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002126 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2127 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002128 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2129 self._mocked_call(['get_authenticator_for_host', host]))
2130 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2131 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002132
2133 def _setup_fetch_try_jobs_rietveld(self, *request_results):
2134 self._setup_fetch_try_jobs(most_recent_patchset=20001)
tandrii221ab252016-10-06 08:12:04 -07002135 self.calls += [
2136 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2137 ((['git', 'config', 'branch.feature.rietveldissue'],), '1'),
2138 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2139 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2140 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
2141 ((['git', 'config', 'branch.feature.rietveldserver'],),
2142 'codereview.example.com'),
2143 ((['get_authenticator_for_host', 'codereview.example.com'],),
2144 AuthenticatorMock()),
2145 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2146
2147 def test_fetch_try_jobs_none_rietveld(self):
2148 self._setup_fetch_try_jobs_rietveld({})
tandrii45b2a582016-10-11 03:14:16 -07002149 # Simulate that user isn't logged in.
2150 self.mock(AuthenticatorMock, 'has_cached_credentials', lambda _: False)
tandrii221ab252016-10-06 08:12:04 -07002151 self.assertEqual(0, git_cl.main(['try-results']))
tandrii45b2a582016-10-11 03:14:16 -07002152 self.assertRegexpMatches(sys.stdout.getvalue(),
2153 'Warning: Some results might be missing')
tandrii221ab252016-10-06 08:12:04 -07002154 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2155
2156 def test_fetch_try_jobs_some_rietveld(self):
2157 self._setup_fetch_try_jobs_rietveld({
2158 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2159 })
2160 self.assertEqual(0, git_cl.main(['try-results']))
tandrii45b2a582016-10-11 03:14:16 -07002161 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
2162 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2163 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2164
2165 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2166 self._setup_fetch_try_jobs(most_recent_patchset=13)
2167 self.calls += [
2168 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2169 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2170 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
2171 # Simulate that Gerrit has more patchsets than local.
2172 ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
2173 ((['git', 'config', 'branch.feature.gerritserver'],),
2174 'https://x-review.googlesource.com'),
2175 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2176 AuthenticatorMock()),
2177 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2178
2179 def test_fetch_try_jobs_none_gerrit(self):
2180 self._setup_fetch_try_jobs_gerrit({})
2181 self.assertEqual(0, git_cl.main(['try-results']))
2182 self.assertRegexpMatches(
2183 sys.stdout.getvalue(),
2184 r'Warning: Codereview server has newer patchsets \(13\)')
2185 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2186
2187 def test_fetch_try_jobs_some_gerrit(self):
2188 self._setup_fetch_try_jobs_gerrit({
2189 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2190 })
2191 # Explicit --patchset means actual local patchset doesn't matter.
2192 self.calls.remove(
2193 ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
2194 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2195
2196 # ... and doesn't result in warning.
2197 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2198 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002199 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2200 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2201
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002202
maruel@chromium.orgddd59412011-11-30 14:20:38 +00002203if __name__ == '__main__':
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002204 git_cl.logging.basicConfig(
2205 level=git_cl.logging.DEBUG if '-v' in sys.argv else git_cl.logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00002206 unittest.main()