commit 05fb911fc19e418f1f6d7d7c3d811cd9d8b29185
author bratell@opera.com <bratell@opera.com@0039d316-1c4b-4281-b951-d872f2087c98> Mon Jul 07 09:30:23 2014 +0000
committer bratell@opera.com <bratell@opera.com@0039d316-1c4b-4281-b951-d872f2087c98> Mon Jul 07 09:30:23 2014 +0000
tree 5b8cb91d02ba8549547d8585efcba0a3adb6d9f5
parent 8e05af1084356bcb19db7ac06384d465eb97f8ad

Revert of Allow git cl also in repos with read-only git-svn. (https://codereview.chromium.org/344013005/)

Reason for revert:
Breaks WebRTC (and possibly other projects actually using https:// for svn access).

Original issue's description:
> Allow git cl also in repos with read-only git-svn.
> 
> If you have read-only git-svn git cl would still try
> to use svn commands, which would then fail. This
> changes git cl to only use git-svn if the remote
> svn repository use the svn:// protocol. It matches
> how chromium works and it allowed me to upload a patch.
> 
> BUG=391430
> 
> R=iannucci
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=281500

TBR=iannucci@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391430

Review URL: https://codereview.chromium.org/375553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@281513 0039d316-1c4b-4281-b951-d872f2087c98

tests/git_cl_test.py

diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index 3af5d30..f7f57b4 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -207,8 +207,8 @@
     ] + cc_call + private_call + [
         ((['git', 'config', 'branch.master.base-url'],), ''),
         ((['git',
-           'config', '--local', '--get-regexp', '^svn-remote\\..*\\.url'],),
-         (('svn-remote.mybranch.url svn://svn.chromium.org/chrome', None), 0)),
+           'config', '--local', '--get-regexp', '^svn-remote\\.'],),
+         (('', None), 0)),
         ((['git', 'rev-parse', '--show-cdup'],), ''),
         ((['git', 'svn', 'info'],), ''),
         ((['git', 'config', 'rietveld.project'],), ''),
@@ -253,7 +253,7 @@
   def _dcommit_calls_1(cls):
     return [
       ((['git',
-         'config', '--local', '--get-regexp', '^svn-remote\\..*\\.url'],),
+         'config', '--local', '--get-regexp', '^svn-remote\\.'],),
        ((('svn-remote.svn.url svn://svn.chromium.org/chrome\n'
           'svn-remote.svn.fetch trunk/src:refs/remotes/origin/master'),
          None),
@@ -775,8 +775,7 @@
          ''),
         ((['git', 'config', 'rietveld.private',],),
          ''),
-        ((['git', 'config', '--local', '--get-regexp',
-           '^svn-remote\\..*\\.url',],),
+        ((['git', 'config', '--local', '--get-regexp', '^svn-remote\\.'],),
          ''),
         ((['git', 'config', 'rietveld.project',],),
          ''),