commit 258e0a653c8481978f0869a860eceb5f643c1cc2
author Andrii Shyshkalov <tandrii@chromium.org> Tue Jan 24 16:50:57 2017 +0100
committer Commit Bot <commit-bot@chromium.org> Tue Jan 24 15:56:01 2017 +0000
tree 685b97f48d58fa9484df4432dc6de3ad2b9c1847
parent 2f8e924184e7d6dff625ae8c7e54ed7c2d9a30a0

Gerrit git cl: cache change detail to save on RPC calls.

R=sergiyb@chromium.org
BUG=681704

Change-Id: I5c320f7e6442a92ae0574e2ca6481a082e82568a
Reviewed-on: https://chromium-review.googlesource.com/430795
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

tests/git_cl_test.py

diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index 2800e3f..d951a78 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -2794,6 +2794,63 @@
     self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
     self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
 
+  def _mock_gerrit_changes_for_detail_cache(self):
+    self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
+    self.mock(git_cl.gerrit_util, 'GetChangeDetail',
+              lambda _, issue, options, **__:
+                  self._mocked_call('RPC', issue, options))
+
+  def test_gerrit_change_detail_cache_normalize(self):
+    self._mock_gerrit_changes_for_detail_cache()
+    self.calls = [
+        (('RPC', '2', ['CASE']), 'b'),
+    ]
+    cl = git_cl.Changelist(codereview='gerrit')
+    self.assertEqual(cl._GetChangeDetail(issue=2, options=['CaSe']), 'b')
+    self.assertEqual(cl._GetChangeDetail(issue=2, options=['CASE']), 'b')
+    self.assertEqual(cl._GetChangeDetail(issue='2'), 'b')
+    self.assertEqual(cl._GetChangeDetail(issue=2), 'b')
+
+  def test_gerrit_change_detail_cache_simple(self):
+    self._mock_gerrit_changes_for_detail_cache()
+    self.calls = [
+        (('RPC', '1', []), 'a'),
+        (('RPC', '2', []), 'b'),
+        (('RPC', '2', []), 'b2'),
+    ]
+    cl = git_cl.Changelist(issue=1, codereview='gerrit')
+    self.assertEqual(cl._GetChangeDetail(), 'a')  # Miss.
+    self.assertEqual(cl._GetChangeDetail(), 'a')
+    self.assertEqual(cl._GetChangeDetail(issue=2), 'b')  # Miss.
+    self.assertEqual(cl._GetChangeDetail(issue=2, no_cache=True), 'b2') # Miss.
+    self.assertEqual(cl._GetChangeDetail(), 'a')
+    self.assertEqual(cl._GetChangeDetail(issue=2), 'b2')
+
+  def test_gerrit_change_detail_cache_options(self):
+    self._mock_gerrit_changes_for_detail_cache()
+    self.calls = [
+        (('RPC', '1', ['C', 'A', 'B']), 'cab'),
+        (('RPC', '1', ['A', 'D']), 'ad'),
+        (('RPC', '1', ['A']), 'a'),  # no_cache=True
+        (('RPC', '1', ['B']), 'b'),  # no longer in cache.
+    ]
+    cl = git_cl.Changelist(issue=1, codereview='gerrit')
+    self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
+    self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
+    self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
+    self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
+    self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
+    self.assertEqual(cl._GetChangeDetail(), 'cab')
+
+    self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
+    self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
+    self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
+    self.assertEqual(cl._GetChangeDetail(), 'cab')
+
+    # Finally, no_cache should invalidate all caches for given change.
+    self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
+    self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
+
 
 if __name__ == '__main__':
   git_cl.logging.basicConfig(