blob: 4c1818207d0e866b1144117d0a81164e4a90cbd5 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000015import os
Edward Lemur85153282020-02-14 22:06:29 +000016import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000017import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070019import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import unittest
21
Edward Lemura8145022020-01-06 18:47:54 +000022if sys.version_info.major == 2:
23 from StringIO import StringIO
24 import mock
25else:
26 from io import StringIO
27 from unittest import mock
28
maruel@chromium.orgddd59412011-11-30 14:20:38 +000029sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
30
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000031import metrics
32# We have to disable monitoring before importing git_cl.
33metrics.DISABLE_METRICS_COLLECTION = True
34
Jamie Madill5e96ad12020-01-13 16:08:35 +000035import clang_format
Eric Boren2fb63102018-10-05 13:05:03 +000036import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000037import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000038import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000039import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000040import git_new_branch
41import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000042import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000043
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000044
Edward Lemur0db01f02019-11-12 22:01:51 +000045def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070046 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
47
48
Edward Lemur4c707a22019-09-24 21:13:43 +000049def _constantFn(return_value):
50 def f(*args, **kwargs):
51 return return_value
52 return f
53
54
tandrii5d48c322016-08-18 16:19:37 -070055CERR1 = callError(1)
56
57
Edward Lemur0db01f02019-11-12 22:01:51 +000058def MakeNamedTemporaryFileMock(test, expected_content):
Aaron Gable9a03ae02017-11-03 11:31:07 -070059 class NamedTemporaryFileMock(object):
60 def __init__(self, *args, **kwargs):
61 self.name = '/tmp/named'
Edward Lemur0db01f02019-11-12 22:01:51 +000062 self.expected_content = expected_content.encode('utf-8', 'replace')
Aaron Gable9a03ae02017-11-03 11:31:07 -070063
64 def __enter__(self):
65 return self
66
67 def __exit__(self, _type, _value, _tb):
68 pass
69
70 def write(self, content):
71 if self.expected_content:
Edward Lemur0db01f02019-11-12 22:01:51 +000072 test.assertEqual(self.expected_content, content)
Aaron Gable9a03ae02017-11-03 11:31:07 -070073
74 def close(self):
75 pass
76
77 return NamedTemporaryFileMock
78
79
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000080class ChangelistMock(object):
81 # A class variable so we can access it when we don't have access to the
82 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000083 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000084 def __init__(self, **kwargs):
85 pass
86 def GetIssue(self):
87 return 1
Edward Lemur6c6827c2020-02-06 21:15:18 +000088 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000089 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070090 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000091 ChangelistMock.desc = desc
92
tandrii5d48c322016-08-18 16:19:37 -070093
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000094class PresubmitMock(object):
95 def __init__(self, *args, **kwargs):
96 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080097 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
98
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000099 @staticmethod
100 def should_continue():
101 return True
102
103
Edward Lemur85153282020-02-14 22:06:29 +0000104class GitMocks(object):
105 def __init__(self, config=None, branchref=None):
106 self.branchref = branchref or 'refs/heads/master'
107 self.config = config or {}
108
109 def GetBranchRef(self, _root):
110 return self.branchref
111
112 def NewBranch(self, branchref):
113 self.branchref = branchref
114
Edward Lemur26964072020-02-19 19:18:51 +0000115 def GetConfig(self, root, key, default=None):
116 if root != '':
117 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000118 return self.config.get(key, default)
119
Edward Lemur26964072020-02-19 19:18:51 +0000120 def SetConfig(self, root, key, value=None):
121 if root != '':
122 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000123 if value:
124 self.config[key] = value
125 return
126 if key not in self.config:
127 raise CERR1
128 del self.config[key]
129
130
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000131class WatchlistsMock(object):
132 def __init__(self, _):
133 pass
134 @staticmethod
135 def GetWatchersForPaths(_):
136 return ['joe@example.com']
137
138
Edward Lemur4c707a22019-09-24 21:13:43 +0000139class CodereviewSettingsFileMock(object):
140 def __init__(self):
141 pass
142 # pylint: disable=no-self-use
143 def read(self):
144 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
145 'GERRIT_HOST: True\n')
146
147
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000148class AuthenticatorMock(object):
149 def __init__(self, *_args):
150 pass
151 def has_cached_credentials(self):
152 return True
tandrii221ab252016-10-06 08:12:04 -0700153 def authorize(self, http):
154 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000155
156
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100157def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000158 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
159
160 Usage:
161 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100162 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000163
164 OR
165 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100166 CookiesAuthenticatorMockFactory(
167 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000168 """
169 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800170 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000171 # Intentionally not calling super() because it reads actual cookie files.
172 pass
173 @classmethod
174 def get_gitcookies_path(cls):
175 return '~/.gitcookies'
176 @classmethod
177 def get_netrc_path(cls):
178 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100179 def _get_auth_for_host(self, host):
180 if same_auth:
181 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000182 return (hosts_with_creds or {}).get(host)
183 return CookiesAuthenticatorMock
184
Aaron Gable9a03ae02017-11-03 11:31:07 -0700185
kmarshall9249e012016-08-23 12:02:16 -0700186class MockChangelistWithBranchAndIssue():
187 def __init__(self, branch, issue):
188 self.branch = branch
189 self.issue = issue
190 def GetBranch(self):
191 return self.branch
192 def GetIssue(self):
193 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000194
tandriic2405f52016-10-10 08:13:15 -0700195
196class SystemExitMock(Exception):
197 pass
198
199
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000200class TestGitClBasic(unittest.TestCase):
Edward Lemur6c6827c2020-02-06 21:15:18 +0000201 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000202 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100203 cl.description = 'x'
204 cl.has_description = True
Edward Lemur6c6827c2020-02-06 21:15:18 +0000205 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700206
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000207 def test_set_preserve_tryjobs(self):
208 d = git_cl.ChangeDescription('Simple.')
209 d.set_preserve_tryjobs()
210 self.assertEqual(d.description.splitlines(), [
211 'Simple.',
212 '',
213 'Cq-Do-Not-Cancel-Tryjobs: true',
214 ])
215 before = d.description
216 d.set_preserve_tryjobs()
217 self.assertEqual(before, d.description)
218
219 d = git_cl.ChangeDescription('\n'.join([
220 'One is enough',
221 '',
222 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
223 'Change-Id: Ideadbeef',
224 ]))
225 d.set_preserve_tryjobs()
226 self.assertEqual(d.description.splitlines(), [
227 'One is enough',
228 '',
229 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
230 'Change-Id: Ideadbeef',
231 'Cq-Do-Not-Cancel-Tryjobs: true',
232 ])
233
tandriif9aefb72016-07-01 09:06:51 -0700234 def test_get_bug_line_values(self):
235 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
236 self.assertEqual(f('', ''), [])
237 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
238 self.assertEqual(f('v8', '456'), ['v8:456'])
239 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
240 # Not nice, but not worth carying.
241 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
242 ['v8:456', 'chromium:123', 'v8:123'])
243
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100244 def _test_git_number(self, parent_msg, dest_ref, child_msg,
245 parent_hash='parenthash'):
246 desc = git_cl.ChangeDescription(child_msg)
247 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
248 return desc.description
249
250 def assertEqualByLine(self, actual, expected):
251 self.assertEqual(actual.splitlines(), expected.splitlines())
252
253 def test_git_number_bad_parent(self):
254 with self.assertRaises(ValueError):
255 self._test_git_number('Parent', 'refs/heads/master', 'Child')
256
257 def test_git_number_bad_parent_footer(self):
258 with self.assertRaises(AssertionError):
259 self._test_git_number(
260 'Parent\n'
261 '\n'
262 'Cr-Commit-Position: wrong',
263 'refs/heads/master', 'Child')
264
265 def test_git_number_bad_lineage_ignored(self):
266 actual = self._test_git_number(
267 'Parent\n'
268 '\n'
269 'Cr-Commit-Position: refs/heads/master@{#1}\n'
270 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
271 'refs/heads/master', 'Child')
272 self.assertEqualByLine(
273 actual,
274 'Child\n'
275 '\n'
276 'Cr-Commit-Position: refs/heads/master@{#2}\n'
277 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
278
279 def test_git_number_same_branch(self):
280 actual = self._test_git_number(
281 'Parent\n'
282 '\n'
283 'Cr-Commit-Position: refs/heads/master@{#12}',
284 dest_ref='refs/heads/master',
285 child_msg='Child')
286 self.assertEqualByLine(
287 actual,
288 'Child\n'
289 '\n'
290 'Cr-Commit-Position: refs/heads/master@{#13}')
291
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200292 def test_git_number_same_branch_mixed_footers(self):
293 actual = self._test_git_number(
294 'Parent\n'
295 '\n'
296 'Cr-Commit-Position: refs/heads/master@{#12}',
297 dest_ref='refs/heads/master',
298 child_msg='Child\n'
299 '\n'
300 'Broken-by: design\n'
301 'BUG=123')
302 self.assertEqualByLine(
303 actual,
304 'Child\n'
305 '\n'
306 'Broken-by: design\n'
307 'BUG=123\n'
308 'Cr-Commit-Position: refs/heads/master@{#13}')
309
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100310 def test_git_number_same_branch_with_originals(self):
311 actual = self._test_git_number(
312 'Parent\n'
313 '\n'
314 'Cr-Commit-Position: refs/heads/master@{#12}',
315 dest_ref='refs/heads/master',
316 child_msg='Child\n'
317 '\n'
318 'Some users are smart and insert their own footers\n'
319 '\n'
320 'Cr-Whatever: value\n'
321 'Cr-Commit-Position: refs/copy/paste@{#22}')
322 self.assertEqualByLine(
323 actual,
324 'Child\n'
325 '\n'
326 'Some users are smart and insert their own footers\n'
327 '\n'
328 'Cr-Original-Whatever: value\n'
329 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
330 'Cr-Commit-Position: refs/heads/master@{#13}')
331
332 def test_git_number_new_branch(self):
333 actual = self._test_git_number(
334 'Parent\n'
335 '\n'
336 'Cr-Commit-Position: refs/heads/master@{#12}',
337 dest_ref='refs/heads/branch',
338 child_msg='Child')
339 self.assertEqualByLine(
340 actual,
341 'Child\n'
342 '\n'
343 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
344 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
345
346 def test_git_number_lineage(self):
347 actual = self._test_git_number(
348 'Parent\n'
349 '\n'
350 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
351 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
352 dest_ref='refs/heads/branch',
353 child_msg='Child')
354 self.assertEqualByLine(
355 actual,
356 'Child\n'
357 '\n'
358 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
359 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
360
361 def test_git_number_moooooooore_lineage(self):
362 actual = self._test_git_number(
363 'Parent\n'
364 '\n'
365 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
366 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
367 dest_ref='refs/heads/mooore',
368 child_msg='Child')
369 self.assertEqualByLine(
370 actual,
371 'Child\n'
372 '\n'
373 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
374 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
375 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
376
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100377 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700378 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100379 actual = self._test_git_number(
380 'CQ commit on fresh new branch + numbering.\n'
381 '\n'
382 'NOTRY=True\n'
383 'NOPRESUBMIT=True\n'
384 'BUG=\n'
385 '\n'
386 'Review-Url: https://codereview.chromium.org/2577703003\n'
387 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
388 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
389 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
390 dest_ref='refs/heads/gnumb-test/cl',
391 child_msg='git cl on fresh new branch + numbering.\n'
392 '\n'
393 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
394 self.assertEqualByLine(
395 actual,
396 'git cl on fresh new branch + numbering.\n'
397 '\n'
398 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
399 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
400 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
401 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
402 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100403
404 def test_git_number_cherry_pick(self):
405 actual = self._test_git_number(
406 'Parent\n'
407 '\n'
408 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
409 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
410 dest_ref='refs/heads/branch',
411 child_msg='Child, which is cherry-pick from master\n'
412 '\n'
413 'Cr-Commit-Position: refs/heads/master@{#100}\n'
414 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
415 self.assertEqualByLine(
416 actual,
417 'Child, which is cherry-pick from master\n'
418 '\n'
419 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
420 '\n'
421 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
422 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
423 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
424
Edward Lemurda4b6c62020-02-13 00:28:40 +0000425 @mock.patch('gerrit_util.GetAccountDetails')
426 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000427 mock_per_account = {
428 'u1': None, # 404, doesn't exist.
429 'u2': {
430 '_account_id': 123124,
431 'avatars': [],
432 'email': 'u2@example.com',
433 'name': 'User Number 2',
434 'status': 'OOO',
435 },
436 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
437 }
438 def GetAccountDetailsMock(_, account):
439 # Poor-man's mock library's side_effect.
440 v = mock_per_account.pop(account)
441 if isinstance(v, Exception):
442 raise v
443 return v
444
Edward Lemurda4b6c62020-02-13 00:28:40 +0000445 mockGetAccountDetails.side_effect = GetAccountDetailsMock
446 actual = git_cl.gerrit_util.ValidAccounts(
447 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000448 self.assertEqual(actual, {
449 'u2': {
450 '_account_id': 123124,
451 'avatars': [],
452 'email': 'u2@example.com',
453 'name': 'User Number 2',
454 'status': 'OOO',
455 },
456 })
457
458
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200459class TestParseIssueURL(unittest.TestCase):
460 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000461 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200462 self.assertIsNotNone(parsed)
463 if fail:
464 self.assertFalse(parsed.valid)
465 return
466 self.assertTrue(parsed.valid)
467 self.assertEqual(parsed.issue, issue)
468 self.assertEqual(parsed.patchset, patchset)
469 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200470
Edward Lemur678a6842019-10-03 22:25:05 +0000471 def test_ParseIssueNumberArgument(self):
472 def test(arg, *args, **kwargs):
473 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200474
Edward Lemur678a6842019-10-03 22:25:05 +0000475 test('123', 123)
476 test('', fail=True)
477 test('abc', fail=True)
478 test('123/1', fail=True)
479 test('123a', fail=True)
480 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200481
Edward Lemur678a6842019-10-03 22:25:05 +0000482 test('https://codereview.source.com/123',
483 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200484 test('http://chrome-review.source.com/c/123',
485 123, None, 'chrome-review.source.com')
486 test('https://chrome-review.source.com/c/123/',
487 123, None, 'chrome-review.source.com')
488 test('https://chrome-review.source.com/c/123/4',
489 123, 4, 'chrome-review.source.com')
490 test('https://chrome-review.source.com/#/c/123/4',
491 123, 4, 'chrome-review.source.com')
492 test('https://chrome-review.source.com/c/123/4',
493 123, 4, 'chrome-review.source.com')
494 test('https://chrome-review.source.com/123',
495 123, None, 'chrome-review.source.com')
496 test('https://chrome-review.source.com/123/4',
497 123, 4, 'chrome-review.source.com')
498
Edward Lemur678a6842019-10-03 22:25:05 +0000499 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200500 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
501 test('https://chrome-review.source.com/c/abc/', fail=True)
502 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
503
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200504
505
Edward Lemurda4b6c62020-02-13 00:28:40 +0000506class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100507 def setUp(self):
508 super(GitCookiesCheckerTest, self).setUp()
509 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100510 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000511 mock.patch('sys.stdout', StringIO()).start()
512 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100513
514 def mock_hosts_creds(self, subhost_identity_pairs):
515 def ensure_googlesource(h):
516 if not h.endswith(self.c._GOOGLESOURCE):
517 assert not h.endswith('.')
518 return h + '.' + self.c._GOOGLESOURCE
519 return h
520 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
521 for h, i in subhost_identity_pairs]
522
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200523 def test_identity_parsing(self):
524 self.assertEqual(self.c._parse_identity('ldap.google.com'),
525 ('ldap', 'google.com'))
526 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
527 ('ldap', 'example.com'))
528 # Specical case because we know there are no subdomains in chromium.org.
529 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
530 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800531 # Pathological: ".period." can be either username OR domain, more likely
532 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200533 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
534 ('note', 'period.example.com'))
535
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100536 def test_analysis_nothing(self):
537 self.c._all_hosts = []
538 self.assertFalse(self.c.has_generic_host())
539 self.assertEqual(set(), self.c.get_conflicting_hosts())
540 self.assertEqual(set(), self.c.get_duplicated_hosts())
541 self.assertEqual(set(), self.c.get_partially_configured_hosts())
542 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
543
544 def test_analysis(self):
545 self.mock_hosts_creds([
546 ('.googlesource.com', 'git-example.chromium.org'),
547
548 ('chromium', 'git-example.google.com'),
549 ('chromium-review', 'git-example.google.com'),
550 ('chrome-internal', 'git-example.chromium.org'),
551 ('chrome-internal-review', 'git-example.chromium.org'),
552 ('conflict', 'git-example.google.com'),
553 ('conflict-review', 'git-example.chromium.org'),
554 ('dup', 'git-example.google.com'),
555 ('dup', 'git-example.google.com'),
556 ('dup-review', 'git-example.google.com'),
557 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200558 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100559 ])
560 self.assertTrue(self.c.has_generic_host())
561 self.assertEqual(set(['conflict.googlesource.com']),
562 self.c.get_conflicting_hosts())
563 self.assertEqual(set(['dup.googlesource.com']),
564 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200565 self.assertEqual(set(['partial.googlesource.com',
566 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100567 self.c.get_partially_configured_hosts())
568 self.assertEqual(set(['chromium.googlesource.com',
569 'chrome-internal.googlesource.com']),
570 self.c.get_hosts_with_wrong_identities())
571
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100572 def test_report_no_problems(self):
573 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100574 self.assertFalse(self.c.find_and_report_problems())
575 self.assertEqual(sys.stdout.getvalue(), '')
576
Edward Lemurda4b6c62020-02-13 00:28:40 +0000577 @mock.patch(
578 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
579 return_value='~/.gitcookies')
580 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100581 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100582 self.assertTrue(self.c.find_and_report_problems())
583 with open(os.path.join(os.path.dirname(__file__),
584 'git_cl_creds_check_report.txt')) as f:
585 expected = f.read()
586 def by_line(text):
587 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700588 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200589 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100590
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800591
Edward Lemurda4b6c62020-02-13 00:28:40 +0000592class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000593 def setUp(self):
594 super(TestGitCl, self).setUp()
595 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700596 self._calls_done = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000597 mock.patch('sys.stdout', StringIO()).start()
598 mock.patch(
599 'git_cl.time_time',
600 lambda: self._mocked_call('time.time')).start()
601 mock.patch(
602 'git_cl.metrics.collector.add_repeated',
603 lambda *a: self._mocked_call('add_repeated', *a)).start()
604 mock.patch('subprocess2.call', self._mocked_call).start()
605 mock.patch('subprocess2.check_call', self._mocked_call).start()
606 mock.patch('subprocess2.check_output', self._mocked_call).start()
607 mock.patch(
608 'subprocess2.communicate',
609 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
610 mock.patch(
611 'git_cl.gclient_utils.CheckCallAndFilter',
612 self._mocked_call).start()
613 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
614 mock.patch(
615 'git_common.get_or_create_merge_base',
616 lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start()
617 mock.patch('git_cl.BranchExists', return_value=True).start()
618 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
619 mock.patch(
620 'git_cl.SaveDescriptionBackup',
621 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
622 mock.patch(
623 'git_cl.ask_for_data',
624 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
625 mock.patch(
626 'git_cl.write_json',
627 lambda *a: self._mocked_call('write_json', *a)).start()
628 mock.patch(
629 'git_cl.presubmit_support.DoPresubmitChecks', PresubmitMock).start()
630 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
631 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000632 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000633 mock.patch(
634 'git_cl.gerrit_util.GetChangeComments',
635 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
636 mock.patch(
637 'git_cl.gerrit_util.GetChangeRobotComments',
638 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
639 mock.patch(
640 'git_cl.gerrit_util.AddReviewers',
641 lambda *a: self._mocked_call('AddReviewers', *a)).start()
642 mock.patch(
643 'git_cl.gerrit_util.SetReview',
644 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
645 self._mocked_call(
646 'SetReview', h, i, msg, labels, notify, ready))).start()
647 mock.patch(
648 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
649 return_value=False).start()
650 mock.patch(
651 'git_cl.gerrit_util.GceAuthenticator.is_gce',
652 return_value=False).start()
653 mock.patch(
654 'git_cl.gerrit_util.ValidAccounts',
655 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000656 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000657 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000658 self.mockGit = GitMocks()
659 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
660 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
661 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000662 mock.patch(
663 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000664 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000665 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000666 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000667 mock.patch(
668 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000669 # It's important to reset settings to not have inter-tests interference.
670 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000671 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000672
673 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000674 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000675 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100676 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000677 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
678 if len(self.calls) > 5:
679 calls += ' ...\n'
680 self.fail(
681 '\n'
682 'There are un-consumed calls after this test has finished:\n' +
683 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000684 finally:
685 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000686
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000687 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000688 self.assertTrue(
689 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700690 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000691 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000692 expected_args, result = top
693
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000694 # Also logs otherwise it could get caught in a try/finally and be hard to
695 # diagnose.
696 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700697 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000698 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700699 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
700 for i, c in enumerate(self._calls_done[-N:]))
701 following_calls = '\n '.join(
702 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
703 for i, c in enumerate(self.calls[:N]))
704 extended_msg = (
705 'A few prior calls:\n %s\n\n'
706 'This (expected):\n @%d: %r\n'
707 'This (actual):\n @%d: %r\n\n'
708 'A few following expected calls:\n %s' %
709 (prior_calls, len(self._calls_done), expected_args,
710 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700711
tandrii99a72f22016-08-17 14:33:24 -0700712 self.fail('@%d\n'
713 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000714 ' Actual: %r\n'
715 '\n'
716 '%s' % (
717 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700718
719 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700720 if isinstance(result, Exception):
721 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000722 # stdout from git commands is supposed to be a bytestream. Convert it here
723 # instead of converting all test output in this file to bytes.
724 if args[0][0] == 'git' and not isinstance(result, bytes):
725 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000726 return result
727
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100728 def test_ask_for_explicit_yes_true(self):
729 self.calls = [
730 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
731 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
732 ]
733 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
734
tandrii48df5812016-10-17 03:55:37 -0700735 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000736 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700737 self.calls = [
738 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700739 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
740 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
741 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
742 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700743 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
744 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700745 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
746 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000747 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
748 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700749 ((['git', 'config', 'gerrit.host', 'true'],), ''),
750 ]
751 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
752
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000753 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100754 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200755 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000756 custom_cl_base=None, short_hostname='chromium',
757 change_id=None):
Edward Lemur26964072020-02-19 19:18:51 +0000758 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200759 if custom_cl_base:
760 ancestor_revision = custom_cl_base
761 else:
762 # Determine ancestor_revision to be merge base.
763 ancestor_revision = 'fake_ancestor_sha'
764 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000765 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
766 ancestor_revision),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200767 ]
768
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100769 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000770 gerrit_util.GetChangeDetail.return_value = {
771 'owner': {'email': (other_cl_owner or 'owner@example.com')},
772 'change_id': (change_id or '123456789'),
773 'current_revision': 'sha1_of_current_revision',
774 'revisions': {'sha1_of_current_revision': {
775 'commit': {'message': fetched_description},
776 }},
777 'status': fetched_status or 'NEW',
778 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100779 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100780 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100781 if other_cl_owner:
782 calls += [
783 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
784 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100785
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100786 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200787 ((['git', 'rev-parse', 'HEAD'],), '12345'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100788 ]
789
790 if not issue:
791 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200792 ((['git', 'log', '--pretty=format:%s%n%n%b',
793 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000794 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100795 ]
796
797 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200798 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000799 (('time.time',), 1000,),
800 (('time.time',), 3000,),
801 (('add_repeated', 'sub_commands', {
802 'execution_time': 2000,
803 'command': 'presubmit',
804 'exit_code': 0
805 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200806 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
807 ([custom_cl_base] if custom_cl_base else
808 [ancestor_revision, 'HEAD']),),
809 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100810 ]
811 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000812
Edward Lemur26964072020-02-19 19:18:51 +0000813 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700814 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000815 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700816 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100817 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000818 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000819 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000820 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000821 final_description=None, gitcookies_exists=True,
Josipe827b0f2020-01-30 00:07:20 +0000822 force=False, edit_description=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000823 if post_amend_description is None:
824 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700825 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200826 # Determined in `_gerrit_base_calls`.
827 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
828
829 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000830
Edward Lemur26964072020-02-19 19:18:51 +0000831 if squash_mode in ('override_squash', 'override_nosquash'):
832 self.mockGit.config['gerrit.override-squash-uploads'] = (
833 'true' if squash_mode == 'override_squash' else 'false')
tandriia60502f2016-06-20 02:01:53 -0700834
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000835 # If issue is given, then description is fetched from Gerrit instead.
836 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000837 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200838 ((['git', 'log', '--pretty=format:%s\n\n%b',
839 ((custom_cl_base + '..') if custom_cl_base else
840 'fake_ancestor_sha..HEAD')],),
841 description),
842 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800843 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000844 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800845 else:
846 if not title:
847 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200848 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
849 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800850 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000851 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000852 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000853 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200854 (('DownloadGerritHook', False), ''),
855 # Amending of commit message to get the Change-Id.
856 ((['git', 'log', '--pretty=format:%s\n\n%b',
857 determined_ancestor_revision + '..HEAD'],),
858 description),
859 ((['git', 'commit', '--amend', '-m', description],), ''),
860 ((['git', 'log', '--pretty=format:%s\n\n%b',
861 determined_ancestor_revision + '..HEAD'],),
862 post_amend_description)
863 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000864 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000865 if force or not issue:
Anthony Polito8b955342019-09-24 19:01:36 +0000866 if not force:
867 calls += [
Anthony Polito8b955342019-09-24 19:01:36 +0000868 ((['RunEditor'],), description),
869 ]
Josipe827b0f2020-01-30 00:07:20 +0000870 # user wants to edit description
871 if edit_description:
872 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000873 ((['RunEditor'],), edit_description),
874 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000875 ref_to_push = 'abcdef0123456789'
876 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200877 ]
878
879 if custom_cl_base is None:
880 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000881 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000882 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200883 ]
884 parent = 'origin/master'
885 else:
886 calls += [
887 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
888 'refs/remotes/origin/master'],),
889 callError(1)), # Means not ancenstor.
890 (('ask_for_data',
891 'Do you take responsibility for cleaning up potential mess '
892 'resulting from proceeding with upload? Press Enter to upload, '
893 'or Ctrl+C to abort'), ''),
894 ]
895 parent = custom_cl_base
896
897 calls += [
898 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
899 '0123456789abcdef'),
900 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -0700901 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200902 ref_to_push),
903 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000904 else:
905 ref_to_push = 'HEAD'
906
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000907 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000908 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200909 ((['git', 'rev-list',
910 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
911 ref_to_push],),
912 '1hashPerLine\n'),
913 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000914
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000915 metrics_arguments = []
916
Aaron Gableafd52772017-06-27 16:40:10 -0700917 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700918 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000919 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700920 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400921 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700922 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000923 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700924 else:
925 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000926 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800927
Aaron Gable70f4e242017-06-26 10:45:59 -0700928 if title:
Aaron Gableafd52772017-06-27 16:40:10 -0700929 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000930 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000931
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000932 if short_hostname == 'chromium':
933 # All reviwers and ccs get into ref_suffix.
934 for r in sorted(reviewers):
935 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000936 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000937 if issue is None:
938 cc += ['chromium-reviews+test-more-cc@chromium.org', 'joe@example.com']
939 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000940 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000941 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000942 reviewers, cc = [], []
943 else:
944 # TODO(crbug/877717): remove this case.
945 calls += [
946 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
947 sorted(reviewers) + ['joe@example.com',
948 'chromium-reviews+test-more-cc@chromium.org'] + cc),
949 {
950 e: {'email': e}
951 for e in (reviewers + ['joe@example.com'] + cc)
952 })
953 ]
954 for r in sorted(reviewers):
955 if r != 'bad-account-or-email':
956 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000957 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000958 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000959 if issue is None:
960 cc += ['joe@example.com']
961 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000962 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000963 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000964 if c in cc:
965 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000966
Edward Lemur687ca902018-12-05 02:30:30 +0000967 for k, v in sorted((labels or {}).items()):
968 ref_suffix += ',l=%s+%d' % (k, v)
969 metrics_arguments.append('l=%s+%d' % (k, v))
970
971 if tbr:
972 calls += [
973 (('GetCodeReviewTbrScore',
974 '%s-review.googlesource.com' % short_hostname,
975 'my/repo'),
976 2,),
977 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000978
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000979 calls += [
980 (('time.time',), 1000,),
981 ((['git', 'push',
982 'https://%s.googlesource.com/my/repo' % short_hostname,
983 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
984 (('remote:\n'
985 'remote: Processing changes: (\)\n'
986 'remote: Processing changes: (|)\n'
987 'remote: Processing changes: (/)\n'
988 'remote: Processing changes: (-)\n'
989 'remote: Processing changes: new: 1 (/)\n'
990 'remote: Processing changes: new: 1, done\n'
991 'remote:\n'
992 'remote: New Changes:\n'
993 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
994 ' XXX\n'
995 'remote:\n'
996 'To https://%s.googlesource.com/my/repo\n'
997 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
998 ) % (short_hostname, short_hostname)),),
999 (('time.time',), 2000,),
1000 (('add_repeated',
1001 'sub_commands',
1002 {
1003 'execution_time': 1000,
1004 'command': 'git push',
1005 'exit_code': 0,
1006 'arguments': sorted(metrics_arguments),
1007 }),
1008 None,),
1009 ]
1010
Edward Lemur1b52d872019-05-09 21:12:12 +00001011 final_description = final_description or post_amend_description.strip()
1012 original_title = original_title or title or '<untitled>'
1013 # Trace-related calls
1014 calls += [
1015 # Write a description with context for the current trace.
1016 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001017 'Thu Mar 16 20:00:41 2017\n'
1018 '%(short_hostname)s-review.googlesource.com\n'
1019 '%(change_id)s\n'
1020 '%(title)s\n'
1021 '%(description)s\n'
1022 '1000\n'
1023 '0\n'
1024 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001025 'short_hostname': short_hostname,
1026 'change_id': change_id,
1027 'description': final_description,
1028 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001029 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001030 }],),
1031 None,
1032 ),
1033 # Read traces and shorten git hashes.
1034 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1035 True,
1036 ),
1037 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1038 ('git-hash: 0123456789012345678901234567890123456789\n'
1039 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1040 ),
1041 ((['FileWrite', 'TEMP_DIR/trace-packet',
1042 'git-hash: 012345\n'
1043 'git-hash: abcdea\n'],),
1044 None,
1045 ),
1046 # Make zip file for the git traces.
1047 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1048 'TEMP_DIR'],),
1049 None,
1050 ),
1051 # Collect git config and gitcookies.
1052 ((['git', 'config', '-l'],),
1053 'git-config-output',
1054 ),
1055 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1056 None,
1057 ),
1058 ((['os.path.isfile', '~/.gitcookies'],),
1059 gitcookies_exists,
1060 ),
1061 ]
1062 if gitcookies_exists:
1063 calls += [
1064 ((['FileRead', '~/.gitcookies'],),
1065 'gitcookies 1/SECRET',
1066 ),
1067 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1068 None,
1069 ),
1070 ]
1071 calls += [
1072 # Make zip file for the git config and gitcookies.
1073 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1074 'TEMP_DIR'],),
1075 None,
1076 ),
1077 ]
1078
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001079 # TODO(crbug/877717): this should never be used.
1080 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001081 calls += [
1082 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001083 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001084 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001085 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1086 notify),
1087 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001088 ]
Edward Lemur26964072020-02-19 19:18:51 +00001089 calls += [
1090 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
1091 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001092 return calls
1093
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001094 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001095 self,
1096 upload_args,
1097 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001098 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001099 squash=True,
1100 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001101 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001102 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001103 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001104 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001105 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001106 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001107 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001108 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001109 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001110 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001111 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001112 labels=None,
1113 change_id=None,
1114 original_title=None,
1115 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001116 gitcookies_exists=True,
1117 force=False,
Josipe827b0f2020-01-30 00:07:20 +00001118 edit_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001119 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001120 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001121 if squash_mode is None:
1122 if '--no-squash' in upload_args:
1123 squash_mode = 'nosquash'
1124 elif '--squash' in upload_args:
1125 squash_mode = 'squash'
1126 else:
1127 squash_mode = 'default'
1128
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001129 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001130 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001131 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001132 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001133 same_auth=('git-owner.example.com', '', 'pass'))).start()
1134 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1135 lambda _, offer_removal: None).start()
1136 mock.patch('git_cl.gclient_utils.RunEditor',
1137 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1138 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
1139 'DownloadGerritHook', force)).start()
1140 mock.patch('git_cl.gclient_utils.FileRead',
1141 lambda path: self._mocked_call(['FileRead', path])).start()
1142 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001143 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001144 ['FileWrite', path, contents])).start()
1145 mock.patch('git_cl.datetime_now',
1146 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1147 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1148 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1149 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001150 '%(now)s\n'
1151 '%(gerrit_host)s\n'
1152 '%(change_id)s\n'
1153 '%(title)s\n'
1154 '%(description)s\n'
1155 '%(execution_time)s\n'
1156 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001157 '%(trace_name)s').start()
1158 mock.patch('git_cl.shutil.make_archive',
1159 lambda *args: self._mocked_call(['make_archive'] +
1160 list(args))).start()
1161 mock.patch('os.path.isfile',
1162 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemurd55c5072020-02-20 01:09:07 +00001163 mock.patch('git_cl.Changelist.GitSanityChecks', return_value=True).start()
tandriia60502f2016-06-20 02:01:53 -07001164
Edward Lemur26964072020-02-19 19:18:51 +00001165 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001166 self.mockGit.config['branch.master.gerritissue'] = (
1167 str(issue) if issue else None)
1168 self.mockGit.config['remote.origin.url'] = (
1169 'https://%s.googlesource.com/my/repo' % short_hostname)
1170
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001171 self.calls = self._gerrit_base_calls(
1172 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001173 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001174 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001175 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001176 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001177 short_hostname=short_hostname,
1178 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001179 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001180 mock.patch(
1181 'tempfile.NamedTemporaryFile',
1182 MakeNamedTemporaryFileMock(
1183 self, expected_content=description)).start()
1184 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001185 self.calls += self._gerrit_upload_calls(
1186 description, reviewers, squash,
1187 squash_mode=squash_mode,
1188 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001189 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001190 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001191 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001192 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001193 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001194 labels=labels,
1195 change_id=change_id,
1196 original_title=original_title,
1197 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001198 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001199 force=force,
1200 edit_description=edit_description)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001201 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001202 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001203 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001204 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001205 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001206 self.assertEqual(
1207 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001208 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001209
Edward Lemur1b52d872019-05-09 21:12:12 +00001210 def test_gerrit_upload_traces_no_gitcookies(self):
1211 self._run_gerrit_upload_test(
1212 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001213 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001214 [],
1215 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001216 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001217 change_id='Ixxx',
1218 gitcookies_exists=False)
1219
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001220 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001221 self._run_gerrit_upload_test(
1222 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001223 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001224 [],
1225 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001226 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001227 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001228
1229 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001230 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001231 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001232 'desc ✔\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001233 [],
tandriia60502f2016-06-20 02:01:53 -07001234 squash=False,
1235 squash_mode='override_nosquash',
Edward Lemur0db01f02019-11-12 22:01:51 +00001236 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001237 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001238
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001239 def test_gerrit_no_reviewer(self):
1240 self._run_gerrit_upload_test(
1241 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001242 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001243 [],
1244 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001245 squash_mode='override_nosquash',
1246 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001247
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001248 def test_gerrit_no_reviewer_non_chromium_host(self):
1249 # TODO(crbug/877717): remove this test case.
1250 self._run_gerrit_upload_test(
1251 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001252 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001253 [],
1254 squash=False,
1255 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001256 short_hostname='other',
1257 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001258
Nick Carter8692b182017-11-06 16:30:38 -08001259 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001260 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001261 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001262 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001263 squash=False,
1264 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001265 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1266 change_id='I123456789',
1267 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001268
ukai@chromium.orge8077812012-02-03 03:41:46 +00001269 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001270 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001271 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001272 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001273 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001274 squash=False,
1275 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001276 notify=True,
1277 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001278 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001279 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001280
Anthony Polito8b955342019-09-24 19:01:36 +00001281 def test_gerrit_upload_force_sets_bug(self):
1282 self._run_gerrit_upload_test(
1283 ['-b', '10000', '-f'],
1284 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1285 [],
1286 force=True,
1287 expected_upstream_ref='origin/master',
1288 fetched_description='desc=\n\nChange-Id: Ixxx',
1289 original_title='Initial upload',
1290 change_id='Ixxx')
1291
1292 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1293 self._run_gerrit_upload_test(
1294 ['-b', '10000', '-f', '-m', 'Title'],
1295 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1296 [],
1297 force=True,
1298 issue='123456',
1299 expected_upstream_ref='origin/master',
1300 fetched_description='desc=\n\nChange-Id: Ixxxx',
1301 original_title='Title',
1302 title='Title',
1303 change_id='Izzzz')
1304
Dan Beamd8b04ca2019-10-10 21:23:26 +00001305 def test_gerrit_upload_force_sets_fixed(self):
1306 self._run_gerrit_upload_test(
1307 ['-x', '10000', '-f'],
1308 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1309 [],
1310 force=True,
1311 expected_upstream_ref='origin/master',
1312 fetched_description='desc=\n\nChange-Id: Ixxx',
1313 original_title='Initial upload',
1314 change_id='Ixxx')
1315
ukai@chromium.orge8077812012-02-03 03:41:46 +00001316 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001317 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1318 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001319 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001320 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001321 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001322 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001323 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001324 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001325 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001326 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001327 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001328 labels={'Code-Review': 2},
1329 change_id='123456789',
1330 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001331
1332 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001333 self._run_gerrit_upload_test(
1334 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001335 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001336 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001337 expected_upstream_ref='origin/master',
1338 change_id='123456789',
1339 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001340
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001341 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001342 self._run_gerrit_upload_test(
1343 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001344 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001345 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001346 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001347 expected_upstream_ref='origin/master',
1348 change_id='123456789',
1349 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001350
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001351 def test_gerrit_upload_squash_first_with_labels(self):
1352 self._run_gerrit_upload_test(
1353 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001354 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001355 [],
1356 squash=True,
1357 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001358 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1359 change_id='123456789',
1360 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001361
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001362 def test_gerrit_upload_squash_first_against_rev(self):
1363 custom_cl_base = 'custom_cl_base_rev_or_branch'
1364 self._run_gerrit_upload_test(
1365 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001366 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001367 [],
1368 squash=True,
1369 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001370 custom_cl_base=custom_cl_base,
1371 change_id='123456789',
1372 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001373 self.assertIn(
1374 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1375 sys.stdout.getvalue())
1376
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001377 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001378 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001379 self._run_gerrit_upload_test(
1380 ['--squash'],
1381 description,
1382 [],
1383 squash=True,
1384 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001385 issue=123456,
1386 change_id='123456789',
1387 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001388
Edward Lemurd55c5072020-02-20 01:09:07 +00001389 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001390 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001391 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001392 with self.assertRaises(SystemExitMock):
1393 self._run_gerrit_upload_test(
1394 ['--squash'],
1395 description,
1396 [],
1397 squash=True,
1398 expected_upstream_ref='origin/master',
1399 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001400 fetched_status='ABANDONED',
1401 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001402 self.assertEqual(
1403 'Change https://chromium-review.googlesource.com/123456 has been '
1404 'abandoned, new uploads are not allowed\n',
1405 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001406
Edward Lemurda4b6c62020-02-13 00:28:40 +00001407 @mock.patch(
1408 'gerrit_util.GetAccountDetails',
1409 return_value={'email': 'yet-another@example.com'})
1410 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001411 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001412 self._run_gerrit_upload_test(
1413 ['--squash'],
1414 description,
1415 [],
1416 squash=True,
1417 expected_upstream_ref='origin/master',
1418 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001419 other_cl_owner='other@example.com',
1420 change_id='123456789',
1421 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001422 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001423 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001424 'authenticate to Gerrit as yet-another@example.com.\n'
1425 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001426 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001427
Josipe827b0f2020-01-30 00:07:20 +00001428 def test_upload_change_description_editor(self):
1429 fetched_description = 'foo\n\nChange-Id: 123456789'
1430 description = 'bar\n\nChange-Id: 123456789'
1431 self._run_gerrit_upload_test(
1432 ['--squash', '--edit-description'],
1433 description,
1434 [],
1435 fetched_description=fetched_description,
1436 squash=True,
1437 expected_upstream_ref='origin/master',
1438 issue=123456,
1439 change_id='123456789',
1440 original_title='User input',
1441 edit_description=description)
1442
Edward Lemurda4b6c62020-02-13 00:28:40 +00001443 @mock.patch('git_cl.RunGit')
1444 @mock.patch('git_cl.CMDupload')
1445 @mock.patch('git_cl.ask_for_data')
1446 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001447 def mock_run_git(*args, **_kwargs):
1448 if args[0] == ['for-each-ref',
1449 '--format=%(refname:short) %(upstream:short)',
1450 'refs/heads']:
1451 # Create a local branch dependency tree that looks like this:
1452 # test1 -> test2 -> test3 -> test4 -> test5
1453 # -> test3.1
1454 # test6 -> test0
1455 branch_deps = [
1456 'test2 test1', # test1 -> test2
1457 'test3 test2', # test2 -> test3
1458 'test3.1 test2', # test2 -> test3.1
1459 'test4 test3', # test3 -> test4
1460 'test5 test4', # test4 -> test5
1461 'test6 test0', # test0 -> test6
1462 'test7', # test7
1463 ]
1464 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001465 git_cl.RunGit.side_effect = mock_run_git
1466 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001467
1468 class MockChangelist():
1469 def __init__(self):
1470 pass
1471 def GetBranch(self):
1472 return 'test1'
1473 def GetIssue(self):
1474 return '123'
1475 def GetPatchset(self):
1476 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001477 def IsGerrit(self):
1478 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001479
1480 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1481 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001482 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
1483 git_cl.ask_for_data.assert_called_once_with(
1484 'This command will checkout all dependent branches '
1485 'and run "git cl upload". Press Enter to continue, '
1486 'or Ctrl+C to abort')
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001487 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001488
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001489 def test_gerrit_change_id(self):
1490 self.calls = [
1491 ((['git', 'write-tree'], ),
1492 'hashtree'),
1493 ((['git', 'rev-parse', 'HEAD~0'], ),
1494 'branch-parent'),
1495 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1496 'A B <a@b.org> 1456848326 +0100'),
1497 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1498 'C D <c@d.org> 1456858326 +0100'),
1499 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1500 'hashchange'),
1501 ]
1502 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1503 self.assertEqual(change_id, 'Ihashchange')
1504
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001505 def test_desecription_append_footer(self):
1506 for init_desc, footer_line, expected_desc in [
1507 # Use unique desc first lines for easy test failure identification.
1508 ('foo', 'R=one', 'foo\n\nR=one'),
1509 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1510 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1511 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1512 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1513 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1514 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1515 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1516 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1517 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1518 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1519 ]:
1520 desc = git_cl.ChangeDescription(init_desc)
1521 desc.append_footer(footer_line)
1522 self.assertEqual(desc.description, expected_desc)
1523
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001524 def test_update_reviewers(self):
1525 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001526 ('foo', [], [],
1527 'foo'),
1528 ('foo\nR=xx', [], [],
1529 'foo\nR=xx'),
1530 ('foo\nTBR=xx', [], [],
1531 'foo\nTBR=xx'),
1532 ('foo', ['a@c'], [],
1533 'foo\n\nR=a@c'),
1534 ('foo\nR=xx', ['a@c'], [],
1535 'foo\n\nR=a@c, xx'),
1536 ('foo\nTBR=xx', ['a@c'], [],
1537 'foo\n\nR=a@c\nTBR=xx'),
1538 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1539 'foo\n\nR=a@c, yy\nTBR=xx'),
1540 ('foo\nBUG=', ['a@c'], [],
1541 'foo\nBUG=\nR=a@c'),
1542 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1543 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1544 ('foo', ['a@c', 'b@c'], [],
1545 'foo\n\nR=a@c, b@c'),
1546 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1547 'foo\nBar\n\nR=c@c\nBUG='),
1548 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1549 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001550 # Same as the line before, but full of whitespaces.
1551 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001552 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001553 'foo\nBar\n\nR=c@c\n BUG =',
1554 ),
1555 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001556 ('foo BUG=allo R=joe ', ['c@c'], [],
1557 'foo BUG=allo R=joe\n\nR=c@c'),
1558 # Redundant TBRs get promoted to Rs
1559 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1560 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001561 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001562 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001563 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001564 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001565 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001566 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001567 actual.append(obj.description)
1568 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001569
Nodir Turakulov23b82142017-11-16 11:04:25 -08001570 def test_get_hash_tags(self):
1571 cases = [
1572 ('', []),
1573 ('a', []),
1574 ('[a]', ['a']),
1575 ('[aa]', ['aa']),
1576 ('[a ]', ['a']),
1577 ('[a- ]', ['a']),
1578 ('[a- b]', ['a-b']),
1579 ('[a--b]', ['a-b']),
1580 ('[a', []),
1581 ('[a]x', ['a']),
1582 ('[aa]x', ['aa']),
1583 ('[a b]', ['a-b']),
1584 ('[a b]', ['a-b']),
1585 ('[a__b]', ['a-b']),
1586 ('[a] x', ['a']),
1587 ('[a][b]', ['a', 'b']),
1588 ('[a] [b]', ['a', 'b']),
1589 ('[a][b]x', ['a', 'b']),
1590 ('[a][b] x', ['a', 'b']),
1591 ('[a]\n[b]', ['a']),
1592 ('[a\nb]', []),
1593 ('[a][', ['a']),
1594 ('Revert "[a] feature"', ['a']),
1595 ('Reland "[a] feature"', ['a']),
1596 ('Revert: [a] feature', ['a']),
1597 ('Reland: [a] feature', ['a']),
1598 ('Revert "Reland: [a] feature"', ['a']),
1599 ('Foo: feature', ['foo']),
1600 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001601 ('Change Foo::Bar', []),
1602 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001603 ('Revert "Foo bar: feature"', ['foo-bar']),
1604 ('Reland "Foo bar: feature"', ['foo-bar']),
1605 ]
1606 for desc, expected in cases:
1607 change_desc = git_cl.ChangeDescription(desc)
1608 actual = change_desc.get_hash_tags()
1609 self.assertEqual(
1610 actual,
1611 expected,
1612 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1613
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001614 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001615 self.assertEqual(None, git_cl.GetTargetRef(None,
1616 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001617 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001618
wittman@chromium.org455dc922015-01-26 20:15:50 +00001619 # Check default target refs for branches.
1620 self.assertEqual('refs/heads/master',
1621 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001622 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001623 self.assertEqual('refs/heads/master',
1624 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001625 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001626 self.assertEqual('refs/heads/master',
1627 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001628 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001629 self.assertEqual('refs/branch-heads/123',
1630 git_cl.GetTargetRef('origin',
1631 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001632 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001633 self.assertEqual('refs/diff/test',
1634 git_cl.GetTargetRef('origin',
1635 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001636 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001637 self.assertEqual('refs/heads/chrome/m42',
1638 git_cl.GetTargetRef('origin',
1639 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001640 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001641
1642 # Check target refs for user-specified target branch.
1643 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1644 'refs/remotes/branch-heads/123'):
1645 self.assertEqual('refs/branch-heads/123',
1646 git_cl.GetTargetRef('origin',
1647 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001648 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001649 for branch in ('origin/master', 'remotes/origin/master',
1650 'refs/remotes/origin/master'):
1651 self.assertEqual('refs/heads/master',
1652 git_cl.GetTargetRef('origin',
1653 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001654 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001655 for branch in ('master', 'heads/master', 'refs/heads/master'):
1656 self.assertEqual('refs/heads/master',
1657 git_cl.GetTargetRef('origin',
1658 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001659 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001660
Edward Lemurda4b6c62020-02-13 00:28:40 +00001661 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1662 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001663 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001664 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1665
Edward Lemur85153282020-02-14 22:06:29 +00001666 def assertIssueAndPatchset(
1667 self, branch='master', issue='123456', patchset='7',
1668 git_short_host='chromium'):
1669 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001670 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001671 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001672 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001673 self.assertEqual(
1674 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001675 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001676
Edward Lemur85153282020-02-14 22:06:29 +00001677 def _patch_common(self, git_short_host='chromium'):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001678 mock.patch('git_cl.IsGitVersionAtLeast', return_value=True).start()
Edward Lemur26964072020-02-19 19:18:51 +00001679 self.mockGit.config['remote.origin.url'] = (
1680 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001681 gerrit_util.GetChangeDetail.return_value = {
1682 'current_revision': '7777777777',
1683 'revisions': {
1684 '1111111111': {
1685 '_number': 1,
1686 'fetch': {'http': {
1687 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1688 'ref': 'refs/changes/56/123456/1',
1689 }},
1690 },
1691 '7777777777': {
1692 '_number': 7,
1693 'fetch': {'http': {
1694 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1695 'ref': 'refs/changes/56/123456/7',
1696 }},
1697 },
1698 },
1699 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001700
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001701 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001702 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001703 self.calls += [
1704 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1705 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001706 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001707 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001708 ]
1709 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001710 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001711
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001712 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001713 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001714 self.calls += [
1715 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1716 'refs/changes/56/123456/7'],), ''),
1717 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001718 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001719 ]
Edward Lemur85153282020-02-14 22:06:29 +00001720 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1721 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001722
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001723 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001724 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001725 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001726 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001727 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001728 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001729 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001730 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001731 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001732 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001733
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001734 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001735 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001736 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001737 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001738 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001739 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001740 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001741 ]
1742 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001743 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001744 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001745
Aaron Gable697a91b2018-01-19 15:20:15 -08001746 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001747 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001748 self.calls += [
1749 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1750 'refs/changes/56/123456/1'],), ''),
1751 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001752 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Aaron Gable697a91b2018-01-19 15:20:15 -08001753 ]
1754 self.assertEqual(git_cl.main(
1755 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1756 0)
Edward Lemur85153282020-02-14 22:06:29 +00001757 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001758
Edward Lemurd55c5072020-02-20 01:09:07 +00001759 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001760 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001761 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001762 self.calls += [
1763 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001764 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001765 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001766 ]
1767 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001768 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001769 self.assertEqual(
1770 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1771 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001772
Edward Lemurda4b6c62020-02-13 00:28:40 +00001773 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001774 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001775 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001776 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001777 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001778 self.mockGit.config['remote.origin.url'] = (
1779 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001780 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001781 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001782 self.assertEqual(
1783 'change 123456 at https://chromium-review.googlesource.com does not '
1784 'exist or you have no access to it\n',
1785 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001786
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001787 def _checkout_calls(self):
1788 return [
1789 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001790 'branch\\..*\\.gerritissue'], ),
1791 ('branch.ger-branch.gerritissue 123456\n'
1792 'branch.gbranch654.gerritissue 654321\n')),
1793 ]
1794
1795 def test_checkout_gerrit(self):
1796 """Tests git cl checkout <issue>."""
1797 self.calls = self._checkout_calls()
1798 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1799 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1800
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001801 def test_checkout_not_found(self):
1802 """Tests git cl checkout <issue>."""
1803 self.calls = self._checkout_calls()
1804 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1805
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001806 def test_checkout_no_branch_issues(self):
1807 """Tests git cl checkout <issue>."""
1808 self.calls = [
1809 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001810 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001811 ]
1812 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1813
Edward Lemur26964072020-02-19 19:18:51 +00001814 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001815 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1816 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001817 self.mockGit.config['remote.origin.url'] = (
1818 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001819 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001820 cl.branch = 'master'
1821 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001822 return cl
1823
Edward Lemurd55c5072020-02-20 01:09:07 +00001824 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001825 def test_gerrit_ensure_authenticated_missing(self):
1826 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001827 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001828 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001829 with self.assertRaises(SystemExitMock):
1830 cl.EnsureAuthenticated(force=False)
1831 self.assertEqual(
1832 'Credentials for the following hosts are required:\n'
1833 ' chromium-review.googlesource.com\n'
1834 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
1835 'You can (re)generate your credentials by visiting '
1836 'https://chromium-review.googlesource.com/new-password\n',
1837 sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001838
1839 def test_gerrit_ensure_authenticated_conflict(self):
1840 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001841 'chromium.googlesource.com':
1842 ('git-one.example.com', None, 'secret1'),
1843 'chromium-review.googlesource.com':
1844 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001845 })
1846 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001847 (('ask_for_data', 'If you know what you are doing '
1848 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001849 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1850
1851 def test_gerrit_ensure_authenticated_ok(self):
1852 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001853 'chromium.googlesource.com':
1854 ('git-same.example.com', None, 'secret'),
1855 'chromium-review.googlesource.com':
1856 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001857 })
1858 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1859
tandrii@chromium.org28253532016-04-14 13:46:56 +00001860 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00001861 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
1862 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00001863 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1864
Eric Boren2fb63102018-10-05 13:05:03 +00001865 def test_gerrit_ensure_authenticated_bearer_token(self):
1866 cl = self._test_gerrit_ensure_authenticated_common(auth={
1867 'chromium.googlesource.com':
1868 ('', None, 'secret'),
1869 'chromium-review.googlesource.com':
1870 ('', None, 'secret'),
1871 })
1872 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1873 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1874 'chromium.googlesource.com')
1875 self.assertTrue('Bearer' in header)
1876
Daniel Chengcf6269b2019-05-18 01:02:12 +00001877 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00001878 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00001879 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001880 (('logging.warning',
1881 'Ignoring branch %(branch)s with non-https remote '
1882 '%(remote)s', {
1883 'branch': 'master',
1884 'remote': 'custom-scheme://repo'}
1885 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001886 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001887 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1888 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1889 mock.patch('logging.warning',
1890 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00001891 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00001892 cl.branch = 'master'
1893 cl.branchref = 'refs/heads/master'
1894 cl.lookedup_issue = True
1895 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1896
Florian Mayerae510e82020-01-30 21:04:48 +00001897 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00001898 self.mockGit.config['remote.origin.url'] = (
1899 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00001900 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001901 (('logging.error',
1902 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1903 'but it doesn\'t exist.', {
1904 'remote': 'origin',
1905 'branch': 'master',
1906 'url': 'git@somehost.example:foo/bar.git'}
1907 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00001908 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001909 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1910 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1911 mock.patch('logging.error',
1912 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00001913 cl = git_cl.Changelist()
1914 cl.branch = 'master'
1915 cl.branchref = 'refs/heads/master'
1916 cl.lookedup_issue = True
1917 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1918
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001919 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00001920 self.mockGit.config['branch.master.gerritissue'] = '123'
1921 self.mockGit.config['branch.master.gerritserver'] = (
1922 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00001923 self.mockGit.config['remote.origin.url'] = (
1924 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001925 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00001926 (('SetReview', 'chromium-review.googlesource.com',
1927 'infra%2Finfra~123', None,
1928 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001929 ]
tandriid9e5ce52016-07-13 02:32:59 -07001930
1931 def test_cmd_set_commit_gerrit_clear(self):
1932 self._cmd_set_commit_gerrit_common(0)
1933 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1934
1935 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001936 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001937 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1938
tandriid9e5ce52016-07-13 02:32:59 -07001939 def test_cmd_set_commit_gerrit(self):
1940 self._cmd_set_commit_gerrit_common(2)
1941 self.assertEqual(0, git_cl.main(['set-commit']))
1942
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001943 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001944 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001945 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001946
1947 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001948 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001949
Edward Lemurda4b6c62020-02-13 00:28:40 +00001950 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07001951 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07001952 try:
1953 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00001954 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001955 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001956 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07001957
1958 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07001959 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001960 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07001961 return 'foobar'
1962
Edward Lemurda4b6c62020-02-13 00:28:40 +00001963 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07001964 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001965 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001966 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001967 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07001968
iannuccie53c9352016-08-17 14:40:40 -07001969 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001970
iannuccie53c9352016-08-17 14:40:40 -07001971 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001972 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07001973 return 'foobar'
1974
Edward Lemurda4b6c62020-02-13 00:28:40 +00001975 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
1976 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07001977 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001978 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001979
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001980 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00001981 self.mockGit.config['remote.origin.url'] = (
1982 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001983 gerrit_util.GetChangeDetail.return_value = {
1984 'current_revision': 'sha1',
1985 'revisions': {'sha1': {
1986 'commit': {'message': 'foobar'},
1987 }},
1988 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001989 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001990 'description',
1991 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
1992 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001993 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001994
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001995 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001996 mock.patch('git_cl.Changelist', ChangelistMock).start()
1997 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001998
1999 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2000 self.assertEqual('hihi', ChangelistMock.desc)
2001
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002002 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002003 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002004
2005 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002006 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002007 '# Enter a description of the change.\n'
2008 '# This will be displayed on the codereview site.\n'
2009 '# The first line will also be used as the subject of the review.\n'
2010 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002011 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002012 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002013 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002014 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002015 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002016
Edward Lemur6c6827c2020-02-06 21:15:18 +00002017 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002018 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002019
Edward Lemurda4b6c62020-02-13 00:28:40 +00002020 mock.patch('git_cl.Changelist.FetchDescription',
2021 lambda *args: current_desc).start()
2022 mock.patch('git_cl.Changelist.UpdateDescription',
2023 UpdateDescription).start()
2024 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002025
Edward Lemur85153282020-02-14 22:06:29 +00002026 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002027 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002028
Dan Beamd8b04ca2019-10-10 21:23:26 +00002029 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2030 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2031
2032 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002033 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002034 '# Enter a description of the change.\n'
2035 '# This will be displayed on the codereview site.\n'
2036 '# The first line will also be used as the subject of the review.\n'
2037 '#--------------------This line is 72 characters long'
2038 '--------------------\n'
2039 'Some.\n\nFixed: 123\nChange-Id: xxx',
2040 desc)
2041 return desc
2042
Edward Lemurda4b6c62020-02-13 00:28:40 +00002043 mock.patch('git_cl.Changelist.FetchDescription',
2044 lambda *args: current_desc).start()
2045 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002046
Edward Lemur85153282020-02-14 22:06:29 +00002047 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002048 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002049
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002050 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002051 mock.patch('git_cl.Changelist', ChangelistMock).start()
2052 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002053
2054 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2055 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2056
kmarshall3bff56b2016-06-06 18:31:47 -07002057 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002058 self.calls = [
2059 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002060 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002061 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002062 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002063 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002064 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002065
Edward Lemurda4b6c62020-02-13 00:28:40 +00002066 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002067 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002068 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2069 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002070 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002071
2072 self.assertEqual(0, git_cl.main(['archive', '-f']))
2073
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002074 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002075 self.calls = [
2076 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2077 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2078 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2079 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002080 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2081 ((['git', 'branch', '-D', 'foo'],), '')
2082 ]
2083
Edward Lemurda4b6c62020-02-13 00:28:40 +00002084 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002085 lambda branches, fine_grained, max_processes:
2086 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2087 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002088 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002089
2090 self.assertEqual(0, git_cl.main(['archive', '-f']))
2091
kmarshall3bff56b2016-06-06 18:31:47 -07002092 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002093 self.calls = [
2094 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2095 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002096 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002097 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002098
Edward Lemurda4b6c62020-02-13 00:28:40 +00002099 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002100 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002101 [(MockChangelistWithBranchAndIssue('master', 1),
2102 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002103
2104 self.assertEqual(1, git_cl.main(['archive', '-f']))
2105
2106 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002107 self.calls = [
2108 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2109 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002110 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002111 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002112
Edward Lemurda4b6c62020-02-13 00:28:40 +00002113 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002114 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002115 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2116 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002117 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002118
kmarshall9249e012016-08-23 12:02:16 -07002119 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2120
2121 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002122 self.calls = [
2123 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2124 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002125 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002126 ((['git', 'branch', '-D', 'foo'],), '')
2127 ]
kmarshall9249e012016-08-23 12:02:16 -07002128
Edward Lemurda4b6c62020-02-13 00:28:40 +00002129 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002130 lambda branches, fine_grained, max_processes:
2131 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2132 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002133 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002134
2135 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002136
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002137 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002138 self.calls = [
2139 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2140 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2141 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002142 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2143 'refs/tags/git-cl-archived-456-foo'),
2144 ((['git', 'branch', '-D', 'foo'],), CERR1),
2145 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2146 'refs/tags/git-cl-archived-456-foo'),
2147 ]
2148
Edward Lemurda4b6c62020-02-13 00:28:40 +00002149 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002150 lambda branches, fine_grained, max_processes:
2151 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2152 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002153 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002154
2155 self.assertEqual(0, git_cl.main(['archive', '-f']))
2156
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002157 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002158 self.mockGit.config['branch.master.gerritissue'] = '123'
2159 self.mockGit.config['branch.master.gerritserver'] = (
2160 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002161 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002162 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002163 ]
2164 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002165 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2166 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002167
Aaron Gable400e9892017-07-12 15:31:21 -07002168 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002169 self.mockGit.config['branch.master.gerritissue'] = '123'
2170 self.mockGit.config['branch.master.gerritserver'] = (
2171 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002172 mock.patch('git_cl.Changelist.FetchDescription',
2173 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002174 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002175 ((['git', 'log', '-1', '--format=%B'],),
2176 'This is a description\n\nChange-Id: Ideadbeef'),
2177 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002178 ]
2179 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002180 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2181 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002182
phajdan.jre328cf92016-08-22 04:12:17 -07002183 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002184 self.mockGit.config['branch.master.gerritissue'] = '123'
2185 self.mockGit.config['branch.master.gerritserver'] = (
2186 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002187 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002188 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002189 {'issue': 123,
2190 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002191 ''),
2192 ]
2193 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2194
tandrii16e0b4e2016-06-07 10:34:28 -07002195 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002196 mock.patch(
2197 'git_cl.os.path.abspath',
2198 lambda path: self._mocked_call(['abspath', path])).start()
2199 mock.patch(
2200 'git_cl.os.path.exists',
2201 lambda path: self._mocked_call(['exists', path])).start()
2202 mock.patch(
2203 'git_cl.gclient_utils.FileRead',
2204 lambda path: self._mocked_call(['FileRead', path])).start()
2205 mock.patch(
2206 'git_cl.gclient_utils.rm_file_or_tree',
2207 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002208 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002209
2210 def test_GerritCommitMsgHookCheck_custom_hook(self):
2211 cl = self._common_GerritCommitMsgHookCheck()
2212 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002213 ((['exists', '.git/hooks/commit-msg'],), True),
2214 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002215 '#!/bin/sh\necho "custom hook"')
2216 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002217 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002218
2219 def test_GerritCommitMsgHookCheck_not_exists(self):
2220 cl = self._common_GerritCommitMsgHookCheck()
2221 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002222 ((['exists', '.git/hooks/commit-msg'],), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002223 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002224 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002225
2226 def test_GerritCommitMsgHookCheck(self):
2227 cl = self._common_GerritCommitMsgHookCheck()
2228 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002229 ((['exists', '.git/hooks/commit-msg'],), True),
2230 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002231 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002232 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002233 ((['rm_file_or_tree', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002234 ''),
2235 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002236 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002237
tandriic4344b52016-08-29 06:04:54 -07002238 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002239 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2240 self.mockGit.config['branch.master.gerritserver'] = (
2241 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002242 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002243 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002244 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002245 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002246 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002247 'labels': {},
2248 'current_revision': 'deadbeaf',
2249 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002250 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002251 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002252 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002253 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2254 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002255 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002256 self.assertEqual(0, cl.CMDLand(force=True,
2257 bypass_hooks=True,
2258 verbose=True,
2259 parallel=False))
Edward Lemur73c76702020-02-06 23:57:18 +00002260 self.assertIn(
2261 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002262 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002263 self.assertIn(
2264 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002265 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002266
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002267 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002268 mock.patch('git_cl.Changelist._GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002269
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002270 def test_gerrit_change_detail_cache_simple(self):
2271 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002272 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002273 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002274 cl1._cached_remote_url = (
2275 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002276 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002277 cl2._cached_remote_url = (
2278 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002279 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2280 self.assertEqual(cl1._GetChangeDetail(), 'a')
2281 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002282
2283 def test_gerrit_change_detail_cache_options(self):
2284 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002285 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002286 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002287 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002288 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2289 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2290 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2291 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2292 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2293 self.assertEqual(cl._GetChangeDetail(), 'cab')
2294
2295 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2296 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2297 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2298 self.assertEqual(cl._GetChangeDetail(), 'cab')
2299
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002300 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002301 gerrit_util.GetChangeDetail.return_value = {
2302 'current_revision': 'rev1',
2303 'revisions': {
2304 'rev1': {'commit': {'message': 'desc1'}},
2305 },
2306 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002307
2308 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002309 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002310 cl._cached_remote_url = (
2311 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002312 self.assertEqual(cl.FetchDescription(), 'desc1')
2313 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002314
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002315 def test_print_current_creds(self):
2316 class CookiesAuthenticatorMock(object):
2317 def __init__(self):
2318 self.gitcookies = {
2319 'host.googlesource.com': ('user', 'pass'),
2320 'host-review.googlesource.com': ('user', 'pass'),
2321 }
2322 self.netrc = self
2323 self.netrc.hosts = {
2324 'github.com': ('user2', None, 'pass2'),
2325 'host2.googlesource.com': ('user3', None, 'pass'),
2326 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002327 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2328 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002329 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2330 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2331 ' Host\t User\t Which file',
2332 '============================\t=====\t===========',
2333 'host-review.googlesource.com\t user\t.gitcookies',
2334 ' host.googlesource.com\t user\t.gitcookies',
2335 ' host2.googlesource.com\tuser3\t .netrc',
2336 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002337 sys.stdout.seek(0)
2338 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002339 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2340 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2341 ' Host\tUser\t Which file',
2342 '============================\t====\t===========',
2343 'host-review.googlesource.com\tuser\t.gitcookies',
2344 ' host.googlesource.com\tuser\t.gitcookies',
2345 ])
2346
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002347 def _common_creds_check_mocks(self):
2348 def exists_mock(path):
2349 dirname = os.path.dirname(path)
2350 if dirname == os.path.expanduser('~'):
2351 dirname = '~'
2352 base = os.path.basename(path)
2353 if base in ('.netrc', '.gitcookies'):
2354 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2355 # git cl also checks for existence other files not relevant to this test.
2356 return None
Edward Lemurda4b6c62020-02-13 00:28:40 +00002357 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002358
2359 def test_creds_check_gitcookies_not_configured(self):
2360 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002361 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2362 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002363 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002364 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002365 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2366 (('os.path.exists', '~/.netrc'), True),
2367 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2368 'or Ctrl+C to abort'), ''),
2369 ((['git', 'config', '--global', 'http.cookiefile',
2370 os.path.expanduser('~/.gitcookies')], ), ''),
2371 ]
2372 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002373 self.assertTrue(
2374 sys.stdout.getvalue().startswith(
2375 'You seem to be using outdated .netrc for git credentials:'))
2376 self.assertIn(
2377 '\nConfigured git to use .gitcookies from',
2378 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002379
2380 def test_creds_check_gitcookies_configured_custom_broken(self):
2381 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002382 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2383 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002384 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002385 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002386 ((['git', 'config', '--global', 'http.cookiefile'],),
2387 '/custom/.gitcookies'),
2388 (('os.path.exists', '/custom/.gitcookies'), False),
2389 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2390 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2391 ((['git', 'config', '--global', 'http.cookiefile',
2392 os.path.expanduser('~/.gitcookies')], ), ''),
2393 ]
2394 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002395 self.assertIn(
2396 'WARNING: You have configured custom path to .gitcookies: ',
2397 sys.stdout.getvalue())
2398 self.assertIn(
2399 'However, your configured .gitcookies file is missing.',
2400 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002401
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002402 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002403 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002404 self.mockGit.config['remote.origin.url'] = (
2405 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002406 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002407 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002408 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002409 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002410 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002411 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002412
Edward Lemurda4b6c62020-02-13 00:28:40 +00002413 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2414 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002415 self.mockGit.config['remote.origin.url'] = (
2416 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002417 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002418 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002419 'current_revision': 'ba5eba11',
2420 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002421 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002422 '_number': 1,
2423 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002424 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002425 '_number': 2,
2426 },
2427 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002428 'messages': [
2429 {
2430 u'_revision_number': 1,
2431 u'author': {
2432 u'_account_id': 1111084,
2433 u'email': u'commit-bot@chromium.org',
2434 u'name': u'Commit Bot'
2435 },
2436 u'date': u'2017-03-15 20:08:45.000000000',
2437 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002438 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002439 u'tag': u'autogenerated:cq:dry-run'
2440 },
2441 {
2442 u'_revision_number': 2,
2443 u'author': {
2444 u'_account_id': 11151243,
2445 u'email': u'owner@example.com',
2446 u'name': u'owner'
2447 },
2448 u'date': u'2017-03-16 20:00:41.000000000',
2449 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2450 u'message': u'PTAL',
2451 },
2452 {
2453 u'_revision_number': 2,
2454 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002455 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002456 u'email': u'reviewer@example.com',
2457 u'name': u'reviewer'
2458 },
2459 u'date': u'2017-03-17 05:19:37.500000000',
2460 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2461 u'message': u'Patch Set 2: Code-Review+1',
2462 },
2463 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002464 }
2465 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002466 (('GetChangeComments', 'chromium-review.googlesource.com',
2467 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002468 '/COMMIT_MSG': [
2469 {
2470 'author': {'email': u'reviewer@example.com'},
2471 'updated': u'2017-03-17 05:19:37.500000000',
2472 'patch_set': 2,
2473 'side': 'REVISION',
2474 'message': 'Please include a bug link',
2475 },
2476 ],
2477 'codereview.settings': [
2478 {
2479 'author': {'email': u'owner@example.com'},
2480 'updated': u'2017-03-16 20:00:41.000000000',
2481 'patch_set': 2,
2482 'side': 'PARENT',
2483 'line': 42,
2484 'message': 'I removed this because it is bad',
2485 },
2486 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002487 }),
2488 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2489 'infra%2Finfra~1'), {}),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002490 ] * 2 + [
2491 (('write_json', 'output.json', [
2492 {
2493 u'date': u'2017-03-16 20:00:41.000000',
2494 u'message': (
2495 u'PTAL\n' +
2496 u'\n' +
2497 u'codereview.settings\n' +
2498 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2499 u'c/1/2/codereview.settings#b42\n' +
2500 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002501 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002502 u'approval': False,
2503 u'disapproval': False,
2504 u'sender': u'owner@example.com'
2505 }, {
2506 u'date': u'2017-03-17 05:19:37.500000',
2507 u'message': (
2508 u'Patch Set 2: Code-Review+1\n' +
2509 u'\n' +
2510 u'/COMMIT_MSG\n' +
2511 u' PS2, File comment: https://chromium-review.googlesource' +
2512 u'.com/c/1/2//COMMIT_MSG#\n' +
2513 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002514 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002515 u'approval': False,
2516 u'disapproval': False,
2517 u'sender': u'reviewer@example.com'
2518 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002519 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002520 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002521 expected_comments_summary = [
2522 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002523 message=(
2524 u'PTAL\n' +
2525 u'\n' +
2526 u'codereview.settings\n' +
2527 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2528 u'c/1/2/codereview.settings#b42\n' +
2529 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002530 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002531 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002532 disapproval=False, approval=False, sender=u'owner@example.com'),
2533 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002534 message=(
2535 u'Patch Set 2: Code-Review+1\n' +
2536 u'\n' +
2537 u'/COMMIT_MSG\n' +
2538 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2539 u'c/1/2//COMMIT_MSG#\n' +
2540 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002541 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002542 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002543 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2544 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002545 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002546 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002547 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002548 self.assertEqual(
2549 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2550
2551 def test_git_cl_comments_robot_comments(self):
2552 # git cl comments also fetches robot comments (which are considered a type
2553 # of autogenerated comment), and unlike other types of comments, only robot
2554 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002555 self.mockGit.config['remote.origin.url'] = (
2556 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002557 gerrit_util.GetChangeDetail.return_value = {
2558 'owner': {'email': 'owner@example.com'},
2559 'current_revision': 'ba5eba11',
2560 'revisions': {
2561 'deadbeaf': {
2562 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002563 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002564 'ba5eba11': {
2565 '_number': 2,
2566 },
2567 },
2568 'messages': [
2569 {
2570 u'_revision_number': 1,
2571 u'author': {
2572 u'_account_id': 1111084,
2573 u'email': u'commit-bot@chromium.org',
2574 u'name': u'Commit Bot'
2575 },
2576 u'date': u'2017-03-15 20:08:45.000000000',
2577 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2578 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2579 u'tag': u'autogenerated:cq:dry-run'
2580 },
2581 {
2582 u'_revision_number': 1,
2583 u'author': {
2584 u'_account_id': 123,
2585 u'email': u'tricium@serviceaccount.com',
2586 u'name': u'Tricium'
2587 },
2588 u'date': u'2017-03-16 20:00:41.000000000',
2589 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2590 u'message': u'(1 comment)',
2591 u'tag': u'autogenerated:tricium',
2592 },
2593 {
2594 u'_revision_number': 1,
2595 u'author': {
2596 u'_account_id': 123,
2597 u'email': u'tricium@serviceaccount.com',
2598 u'name': u'Tricium'
2599 },
2600 u'date': u'2017-03-16 20:00:41.000000000',
2601 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2602 u'message': u'(1 comment)',
2603 u'tag': u'autogenerated:tricium',
2604 },
2605 {
2606 u'_revision_number': 2,
2607 u'author': {
2608 u'_account_id': 123,
2609 u'email': u'tricium@serviceaccount.com',
2610 u'name': u'reviewer'
2611 },
2612 u'date': u'2017-03-17 05:30:37.000000000',
2613 u'tag': u'autogenerated:tricium',
2614 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2615 u'message': u'(1 comment)',
2616 },
2617 ]
2618 }
2619 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002620 (('GetChangeComments', 'chromium-review.googlesource.com',
2621 'infra%2Finfra~1'), {}),
2622 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2623 'infra%2Finfra~1'), {
2624 'codereview.settings': [
2625 {
2626 u'author': {u'email': u'tricium@serviceaccount.com'},
2627 u'updated': u'2017-03-17 05:30:37.000000000',
2628 u'robot_run_id': u'5565031076855808',
2629 u'robot_id': u'Linter/Category',
2630 u'tag': u'autogenerated:tricium',
2631 u'patch_set': 2,
2632 u'side': u'REVISION',
2633 u'message': u'Linter warning message text',
2634 u'line': 32,
2635 },
2636 ],
2637 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002638 ]
2639 expected_comments_summary = [
2640 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2641 message=(
2642 u'(1 comment)\n\ncodereview.settings\n'
2643 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2644 u'c/1/2/codereview.settings#32\n'
2645 u' Linter warning message text\n'),
2646 sender=u'tricium@serviceaccount.com',
2647 autogenerated=True, approval=False, disapproval=False)
2648 ]
2649 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002650 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002651 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002652
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002653 def test_get_remote_url_with_mirror(self):
2654 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002655
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002656 def selective_os_path_isdir_mock(path):
2657 if path == '/cache/this-dir-exists':
2658 return self._mocked_call('os.path.isdir', path)
2659 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002660
Edward Lemurda4b6c62020-02-13 00:28:40 +00002661 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002662
2663 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002664 self.mockGit.config['remote.origin.url'] = (
2665 '/cache/this-dir-exists')
2666 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2667 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002668 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002669 (('os.path.isdir', '/cache/this-dir-exists'),
2670 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002671 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002672 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002673 self.assertEqual(cl.GetRemoteUrl(), url)
2674 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2675
Edward Lemur298f2cf2019-02-22 21:40:39 +00002676 def test_get_remote_url_non_existing_mirror(self):
2677 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002678
Edward Lemur298f2cf2019-02-22 21:40:39 +00002679 def selective_os_path_isdir_mock(path):
2680 if path == '/cache/this-dir-doesnt-exist':
2681 return self._mocked_call('os.path.isdir', path)
2682 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002683
Edward Lemurda4b6c62020-02-13 00:28:40 +00002684 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2685 mock.patch('logging.error',
2686 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002687
Edward Lemur26964072020-02-19 19:18:51 +00002688 self.mockGit.config['remote.origin.url'] = (
2689 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002690 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002691 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2692 False),
2693 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002694 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2695 'but it doesn\'t exist.', {
2696 'remote': 'origin',
2697 'branch': 'master',
2698 'url': '/cache/this-dir-doesnt-exist'}
2699 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002700 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002701 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002702 self.assertIsNone(cl.GetRemoteUrl())
2703
2704 def test_get_remote_url_misconfigured_mirror(self):
2705 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002706
Edward Lemur298f2cf2019-02-22 21:40:39 +00002707 def selective_os_path_isdir_mock(path):
2708 if path == '/cache/this-dir-exists':
2709 return self._mocked_call('os.path.isdir', path)
2710 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002711
Edward Lemurda4b6c62020-02-13 00:28:40 +00002712 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2713 mock.patch('logging.error',
2714 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002715
Edward Lemur26964072020-02-19 19:18:51 +00002716 self.mockGit.config['remote.origin.url'] = (
2717 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002718 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002719 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002720 (('logging.error',
2721 'Remote "%(remote)s" for branch "%(branch)s" points to '
2722 '"%(cache_path)s", but it is misconfigured.\n'
2723 '"%(cache_path)s" must be a git repo and must have a remote named '
2724 '"%(remote)s" pointing to the git host.', {
2725 'remote': 'origin',
2726 'cache_path': '/cache/this-dir-exists',
2727 'branch': 'master'}
2728 ), None),
2729 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002730 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002731 self.assertIsNone(cl.GetRemoteUrl())
2732
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002733 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002734 self.mockGit.config['remote.origin.url'] = (
2735 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002736 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002737 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2738
2739 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002740 mock.patch('logging.error',
2741 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002742
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002743 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002744 (('logging.error',
2745 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2746 'but it doesn\'t exist.', {
2747 'remote': 'origin',
2748 'branch': 'master',
2749 'url': ''}
2750 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002751 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002752 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002753 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002754
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002755
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002756class CMDTestCaseBase(unittest.TestCase):
2757 _STATUSES = [
2758 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
2759 'INFRA_FAILURE', 'CANCELED',
2760 ]
2761 _CHANGE_DETAIL = {
2762 'project': 'depot_tools',
2763 'status': 'OPEN',
2764 'owner': {'email': 'owner@e.mail'},
2765 'current_revision': 'beeeeeef',
2766 'revisions': {
2767 'deadbeaf': {'_number': 6},
2768 'beeeeeef': {
2769 '_number': 7,
2770 'fetch': {'http': {
2771 'url': 'https://chromium.googlesource.com/depot_tools',
2772 'ref': 'refs/changes/56/123456/7'
2773 }},
2774 },
2775 },
2776 }
2777 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002778 'builds': [{
2779 'id': str(100 + idx),
2780 'builder': {
2781 'project': 'chromium',
2782 'bucket': 'try',
2783 'builder': 'bot_' + status.lower(),
2784 },
2785 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
2786 'tags': [],
2787 'status': status,
2788 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002789 }
2790
Edward Lemur4c707a22019-09-24 21:13:43 +00002791 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002792 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00002793 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002794 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
2795 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002796 mock.patch(
2797 'git_cl.Changelist.GetCodereviewServer',
2798 return_value='https://chromium-review.googlesource.com').start()
2799 mock.patch(
2800 'git_cl.Changelist._GetGerritHost',
2801 return_value='chromium-review.googlesource.com').start()
2802 mock.patch(
2803 'git_cl.Changelist.GetMostRecentPatchset',
2804 return_value=7).start()
2805 mock.patch(
2806 'git_cl.Changelist.GetRemoteUrl',
2807 return_value='https://chromium.googlesource.com/depot_tools').start()
2808 mock.patch(
2809 'auth.Authenticator',
2810 return_value=AuthenticatorMock()).start()
2811 mock.patch(
2812 'gerrit_util.GetChangeDetail',
2813 return_value=self._CHANGE_DETAIL).start()
2814 mock.patch(
2815 'git_cl._call_buildbucket',
2816 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002817 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00002818 self.addCleanup(mock.patch.stopall)
2819
Edward Lemur4c707a22019-09-24 21:13:43 +00002820
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002821class CMDTryResultsTestCase(CMDTestCaseBase):
2822 _DEFAULT_REQUEST = {
2823 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002824 "gerritChanges": [{
2825 "project": "depot_tools",
2826 "host": "chromium-review.googlesource.com",
2827 "patchset": 7,
2828 "change": 123456,
2829 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002830 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002831 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
2832 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002833 }
2834
2835 def testNoJobs(self):
2836 git_cl._call_buildbucket.return_value = {}
2837
2838 self.assertEqual(0, git_cl.main(['try-results']))
2839 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
2840 git_cl._call_buildbucket.assert_called_once_with(
2841 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
2842 self._DEFAULT_REQUEST)
2843
2844 def testPrintToStdout(self):
2845 self.assertEqual(0, git_cl.main(['try-results']))
2846 self.assertEqual([
2847 'Successes:',
2848 ' bot_success https://ci.chromium.org/b/103',
2849 'Infra Failures:',
2850 ' bot_infra_failure https://ci.chromium.org/b/105',
2851 'Failures:',
2852 ' bot_failure https://ci.chromium.org/b/104',
2853 'Canceled:',
2854 ' bot_canceled ',
2855 'Started:',
2856 ' bot_started https://ci.chromium.org/b/102',
2857 'Scheduled:',
2858 ' bot_scheduled id=101',
2859 'Other:',
2860 ' bot_status_unspecified id=100',
2861 'Total: 7 tryjobs',
2862 ], sys.stdout.getvalue().splitlines())
2863 git_cl._call_buildbucket.assert_called_once_with(
2864 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
2865 self._DEFAULT_REQUEST)
2866
2867 def testPrintToStdoutWithMasters(self):
2868 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
2869 self.assertEqual([
2870 'Successes:',
2871 ' try bot_success https://ci.chromium.org/b/103',
2872 'Infra Failures:',
2873 ' try bot_infra_failure https://ci.chromium.org/b/105',
2874 'Failures:',
2875 ' try bot_failure https://ci.chromium.org/b/104',
2876 'Canceled:',
2877 ' try bot_canceled ',
2878 'Started:',
2879 ' try bot_started https://ci.chromium.org/b/102',
2880 'Scheduled:',
2881 ' try bot_scheduled id=101',
2882 'Other:',
2883 ' try bot_status_unspecified id=100',
2884 'Total: 7 tryjobs',
2885 ], sys.stdout.getvalue().splitlines())
2886 git_cl._call_buildbucket.assert_called_once_with(
2887 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
2888 self._DEFAULT_REQUEST)
2889
2890 @mock.patch('git_cl.write_json')
2891 def testWriteToJson(self, mockJsonDump):
2892 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
2893 git_cl._call_buildbucket.assert_called_once_with(
2894 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
2895 self._DEFAULT_REQUEST)
2896 mockJsonDump.assert_called_once_with(
2897 'file.json', self._DEFAULT_RESPONSE['builds'])
2898
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002899 def test_filter_failed_for_one_simple(self):
2900 self.assertEqual({}, git_cl._filter_failed_for_retry([]))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002901 self.assertEqual({
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002902 'chromium/try': {
2903 'bot_failure': [],
2904 'bot_infra_failure': []
2905 },
2906 }, git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
2907
2908 def test_filter_failed_for_retry_many_builds(self):
2909
2910 def _build(name, created_sec, status, experimental=False):
2911 assert 0 <= created_sec < 100, created_sec
2912 b = {
2913 'id': 112112,
2914 'builder': {
2915 'project': 'chromium',
2916 'bucket': 'try',
2917 'builder': name,
2918 },
2919 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
2920 'status': status,
2921 'tags': [],
2922 }
2923 if experimental:
2924 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
2925 return b
2926
2927 builds = [
2928 _build('flaky-last-green', 1, 'FAILURE'),
2929 _build('flaky-last-green', 2, 'SUCCESS'),
2930 _build('flaky', 1, 'SUCCESS'),
2931 _build('flaky', 2, 'FAILURE'),
2932 _build('running', 1, 'FAILED'),
2933 _build('running', 2, 'SCHEDULED'),
2934 _build('yep-still-running', 1, 'STARTED'),
2935 _build('yep-still-running', 2, 'FAILURE'),
2936 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
2937 _build('cq-experimental', 2, 'FAILURE', experimental=True),
2938
2939 # Simulate experimental in CQ builder, which developer decided
2940 # to retry manually which resulted in 2nd build non-experimental.
2941 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
2942 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
2943 ]
2944 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
2945 self.assertEqual({
2946 'chromium/try': {
2947 'flaky': [],
2948 'sometimes-experimental': []
2949 },
2950 }, git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002951
2952
2953class CMDTryTestCase(CMDTestCaseBase):
2954
2955 @mock.patch('git_cl.Changelist.SetCQState')
2956 @mock.patch('git_cl._get_bucket_map', return_value={})
2957 def testSetCQDryRunByDefault(self, _mockGetBucketMap, mockSetCQState):
2958 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00002959 self.assertEqual(0, git_cl.main(['try']))
2960 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
2961 self.assertEqual(
2962 sys.stdout.getvalue(),
2963 'Scheduling CQ dry run on: '
2964 'https://chromium-review.googlesource.com/123456\n')
2965
Edward Lemur4c707a22019-09-24 21:13:43 +00002966 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002967 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00002968 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00002969
2970 self.assertEqual(0, git_cl.main([
2971 'try', '-B', 'luci.chromium.try', '-b', 'win',
2972 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2973 self.assertIn(
2974 'Scheduling jobs on:\nBucket: luci.chromium.try',
2975 git_cl.sys.stdout.getvalue())
2976
2977 expected_request = {
2978 "requests": [{
2979 "scheduleBuild": {
2980 "requestId": "uuid4",
2981 "builder": {
2982 "project": "chromium",
2983 "builder": "win",
2984 "bucket": "try",
2985 },
2986 "gerritChanges": [{
2987 "project": "depot_tools",
2988 "host": "chromium-review.googlesource.com",
2989 "patchset": 7,
2990 "change": 123456,
2991 }],
2992 "properties": {
2993 "category": "git_cl_try",
2994 "json": [{"a": 1}, None],
2995 "key": "val",
2996 },
2997 "tags": [
2998 {"value": "win", "key": "builder"},
2999 {"value": "git_cl_try", "key": "user_agent"},
3000 ],
3001 },
3002 }],
3003 }
3004 mockCallBuildbucket.assert_called_with(
3005 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3006
Anthony Polito1a5fe232020-01-24 23:17:52 +00003007 @mock.patch('git_cl._call_buildbucket')
3008 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3009 mockCallBuildbucket.return_value = {}
3010
3011 self.assertEqual(0, git_cl.main([
3012 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3013 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3014 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3015 self.assertIn(
3016 'Scheduling jobs on:\nBucket: luci.chromium.try',
3017 git_cl.sys.stdout.getvalue())
3018
3019 expected_request = {
3020 "requests": [{
3021 "scheduleBuild": {
3022 "requestId": "uuid4",
3023 "builder": {
3024 "project": "chromium",
3025 "builder": "linux",
3026 "bucket": "try",
3027 },
3028 "gerritChanges": [{
3029 "project": "depot_tools",
3030 "host": "chromium-review.googlesource.com",
3031 "patchset": 7,
3032 "change": 123456,
3033 }],
3034 "properties": {
3035 "category": "git_cl_try",
3036 "json": [{"a": 1}, None],
3037 "key": "val",
3038 },
3039 "tags": [
3040 {"value": "linux", "key": "builder"},
3041 {"value": "git_cl_try", "key": "user_agent"},
3042 ],
3043 "gitilesCommit": {
3044 "host": "chromium-review.googlesource.com",
3045 "project": "depot_tools",
3046 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3047 }
3048 },
3049 },
3050 {
3051 "scheduleBuild": {
3052 "requestId": "uuid4",
3053 "builder": {
3054 "project": "chromium",
3055 "builder": "win",
3056 "bucket": "try",
3057 },
3058 "gerritChanges": [{
3059 "project": "depot_tools",
3060 "host": "chromium-review.googlesource.com",
3061 "patchset": 7,
3062 "change": 123456,
3063 }],
3064 "properties": {
3065 "category": "git_cl_try",
3066 "json": [{"a": 1}, None],
3067 "key": "val",
3068 },
3069 "tags": [
3070 {"value": "win", "key": "builder"},
3071 {"value": "git_cl_try", "key": "user_agent"},
3072 ],
3073 "gitilesCommit": {
3074 "host": "chromium-review.googlesource.com",
3075 "project": "depot_tools",
3076 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3077 }
3078 },
3079 }],
3080 }
3081 mockCallBuildbucket.assert_called_with(
3082 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3083
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003084 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur4c707a22019-09-24 21:13:43 +00003085 self.assertEqual(0, git_cl.main([
3086 'try', '-B', 'not-a-bucket', '-b', 'win',
3087 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3088 self.assertIn(
3089 'WARNING Could not parse bucket "not-a-bucket". Skipping.',
3090 git_cl.sys.stdout.getvalue())
3091
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003092 @mock.patch('git_cl._call_buildbucket')
3093 @mock.patch('git_cl.fetch_try_jobs')
3094 def testScheduleOnBuildbucketRetryFailed(
3095 self, mockFetchTryJobs, mockCallBuildbucket):
3096
3097 git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: {
3098 7: [],
3099 6: [{
3100 'id': 112112,
3101 'builder': {
3102 'project': 'chromium',
3103 'bucket': 'try',
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003104 'builder': 'linux',},
3105 'createTime': '2019-10-09T08:00:01.854286Z',
3106 'tags': [],
3107 'status': 'FAILURE',}],}[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003108 mockCallBuildbucket.return_value = {}
3109
3110 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3111 self.assertIn(
3112 'Scheduling jobs on:\nBucket: chromium/try',
3113 git_cl.sys.stdout.getvalue())
3114
3115 expected_request = {
3116 "requests": [{
3117 "scheduleBuild": {
3118 "requestId": "uuid4",
3119 "builder": {
3120 "project": "chromium",
3121 "bucket": "try",
3122 "builder": "linux",
3123 },
3124 "gerritChanges": [{
3125 "project": "depot_tools",
3126 "host": "chromium-review.googlesource.com",
3127 "patchset": 7,
3128 "change": 123456,
3129 }],
3130 "properties": {
3131 "category": "git_cl_try",
3132 },
3133 "tags": [
3134 {"value": "linux", "key": "builder"},
3135 {"value": "git_cl_try", "key": "user_agent"},
3136 {"value": "1", "key": "retry_failed"},
3137 ],
3138 },
3139 }],
3140 }
3141 mockCallBuildbucket.assert_called_with(
3142 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3143
Edward Lemur4c707a22019-09-24 21:13:43 +00003144 def test_parse_bucket(self):
3145 test_cases = [
3146 {
3147 'bucket': 'chromium/try',
3148 'result': ('chromium', 'try'),
3149 },
3150 {
3151 'bucket': 'luci.chromium.try',
3152 'result': ('chromium', 'try'),
3153 'has_warning': True,
3154 },
3155 {
3156 'bucket': 'skia.primary',
3157 'result': ('skia', 'skia.primary'),
3158 'has_warning': True,
3159 },
3160 {
3161 'bucket': 'not-a-bucket',
3162 'result': (None, None),
3163 },
3164 ]
3165
3166 for test_case in test_cases:
3167 git_cl.sys.stdout.truncate(0)
3168 self.assertEqual(
3169 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3170 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003171 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3172 test_case['result'])
3173 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003174
3175
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003176class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003177 def setUp(self):
3178 super(CMDUploadTestCase, self).setUp()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003179 mock.patch('git_cl.fetch_try_jobs').start()
3180 mock.patch('git_cl._trigger_try_jobs', return_value={}).start()
3181 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Anthony Polito46689b02019-11-15 20:56:41 +00003182 mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003183 self.addCleanup(mock.patch.stopall)
3184
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003185 def testWarmUpChangeDetailCache(self):
3186 self.assertEqual(0, git_cl.main(['upload']))
3187 gerrit_util.GetChangeDetail.assert_called_once_with(
3188 'chromium-review.googlesource.com', 'depot_tools~123456',
3189 frozenset([
3190 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3191 'CURRENT_COMMIT']))
3192
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003193 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003194 # This test mocks out the actual upload part, and just asserts that after
3195 # upload, if --retry-failed is added, then the tool will fetch try jobs
3196 # from the previous patchset and trigger the right builders on the latest
3197 # patchset.
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003198 git_cl.fetch_try_jobs.side_effect = [
3199 # Latest patchset: No builds.
3200 [],
3201 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003202 [{
3203 'id': str(100 + idx),
3204 'builder': {
3205 'project': 'chromium',
3206 'bucket': 'try',
3207 'builder': 'bot_' + status.lower(),
3208 },
3209 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3210 'tags': [],
3211 'status': status,
3212 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003213 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003214
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003215 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003216 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003217 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3218 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003219 ], git_cl.fetch_try_jobs.mock_calls)
3220 expected_buckets = {
3221 'chromium/try': {'bot_failure': [], 'bot_infra_failure': []},
3222 }
3223 git_cl._trigger_try_jobs.assert_called_once_with(
Edward Lemur5b929a42019-10-21 17:57:39 +00003224 mock.ANY, expected_buckets, mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003225
Brian Sheedy59b06a82019-10-14 17:03:29 +00003226
Edward Lemurda4b6c62020-02-13 00:28:40 +00003227class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003228
3229 def setUp(self):
3230 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003231 mock.patch('git_cl.RunCommand').start()
3232 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3233 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3234 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003235 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003236 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003237
3238 def tearDown(self):
3239 shutil.rmtree(self._top_dir)
3240 super(CMDFormatTestCase, self).tearDown()
3241
Jamie Madill5e96ad12020-01-13 16:08:35 +00003242 def _make_temp_file(self, fname, contents):
3243 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3244 tf.write('\n'.join(contents))
3245
Brian Sheedy59b06a82019-10-14 17:03:29 +00003246 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003247 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003248
Brian Sheedyb4307d52019-12-02 19:18:17 +00003249 def _check_yapf_filtering(self, files, expected):
3250 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3251 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003252
Jamie Madill5e96ad12020-01-13 16:08:35 +00003253 def testClangFormatDiffFull(self):
3254 self._make_temp_file('test.cc', ['// test'])
3255 git_cl.settings.GetFormatFullByDefault.return_value = False
3256 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3257 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3258
3259 # Diff
3260 git_cl.RunCommand.return_value = ' // test'
3261 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3262 self._top_dir, 'HEAD')
3263 self.assertEqual(2, return_value)
3264
3265 # No diff
3266 git_cl.RunCommand.return_value = '// test'
3267 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3268 self._top_dir, 'HEAD')
3269 self.assertEqual(0, return_value)
3270
3271 def testClangFormatDiff(self):
3272 git_cl.settings.GetFormatFullByDefault.return_value = False
3273 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3274
3275 # Diff
3276 git_cl.RunCommand.return_value = 'error'
3277 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3278 'HEAD')
3279 self.assertEqual(2, return_value)
3280
3281 # No diff
3282 git_cl.RunCommand.return_value = ''
3283 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3284 'HEAD')
3285 self.assertEqual(0, return_value)
3286
Brian Sheedyb4307d52019-12-02 19:18:17 +00003287 def testYapfignoreExplicit(self):
3288 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3289 files = [
3290 'bar.py',
3291 'foo/bar.py',
3292 'foo/baz.py',
3293 'foo/bar/baz.py',
3294 'foo/bar/foobar.py',
3295 ]
3296 expected = [
3297 'bar.py',
3298 'foo/baz.py',
3299 'foo/bar/foobar.py',
3300 ]
3301 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003302
Brian Sheedyb4307d52019-12-02 19:18:17 +00003303 def testYapfignoreSingleWildcards(self):
3304 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3305 files = [
3306 'bar.py', # Matched by *bar.py.
3307 'bar.txt',
3308 'foobar.py', # Matched by *bar.py, foo*.
3309 'foobar.txt', # Matched by foo*.
3310 'bazbar.py', # Matched by *bar.py, baz*.py.
3311 'bazbar.txt',
3312 'foo/baz.txt', # Matched by foo*.
3313 'bar/bar.py', # Matched by *bar.py.
3314 'baz/foo.py', # Matched by baz*.py, foo*.
3315 'baz/foo.txt',
3316 ]
3317 expected = [
3318 'bar.txt',
3319 'bazbar.txt',
3320 'baz/foo.txt',
3321 ]
3322 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003323
Brian Sheedyb4307d52019-12-02 19:18:17 +00003324 def testYapfignoreMultiplewildcards(self):
3325 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3326 files = [
3327 'bar.py', # Matched by *bar*.
3328 'bar.txt', # Matched by *bar*.
3329 'abar.py', # Matched by *bar*.
3330 'foobaz.txt', # Matched by *foo*baz.txt.
3331 'foobaz.py',
3332 'afoobaz.txt', # Matched by *foo*baz.txt.
3333 ]
3334 expected = [
3335 'foobaz.py',
3336 ]
3337 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003338
3339 def testYapfignoreComments(self):
3340 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003341 files = [
3342 'test.py',
3343 'test2.py',
3344 ]
3345 expected = [
3346 'test2.py',
3347 ]
3348 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003349
3350 def testYapfignoreBlankLines(self):
3351 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003352 files = [
3353 'test.py',
3354 'test2.py',
3355 'test3.py',
3356 ]
3357 expected = [
3358 'test3.py',
3359 ]
3360 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003361
3362 def testYapfignoreWhitespace(self):
3363 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003364 files = [
3365 'test.py',
3366 'test2.py',
3367 ]
3368 expected = [
3369 'test2.py',
3370 ]
3371 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003372
Brian Sheedyb4307d52019-12-02 19:18:17 +00003373 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003374 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003375 self._check_yapf_filtering([], [])
3376
3377 def testYapfignoreMissingYapfignore(self):
3378 files = [
3379 'test.py',
3380 ]
3381 expected = [
3382 'test.py',
3383 ]
3384 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003385
3386
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003387if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003388 logging.basicConfig(
3389 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003390 unittest.main()