commit 0d2dea0a5ffe427e47fbc659e7f48b9df4cae477
author Andrii Shyshkalov <tandrii@chromium.org> Mon Jul 17 15:17:55 2017 +0200
committer Commit Bot <commit-bot@chromium.org> Thu Aug 10 17:21:14 2017 +0000
tree 07f69d67dba3f241fa940896631bd7ed5d45c56c
parent 9a289023b5abb2b53c3918fabb3ccf183c2358d2

git cl creds-check: special case parsing of chromium.org emails.

R=phajdan.jr@chromium.org

Change-Id: Ia1380bc0cfff50e82f9a26d3c54e9dc34a38c7b5
Reviewed-on: https://chromium-review.googlesource.com/574528
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

tests/git_cl_test.py

diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index 58a38a2..7ed3b28 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -528,6 +528,18 @@
     self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
                          for h, i in subhost_identity_pairs]
 
+  def test_identity_parsing(self):
+    self.assertEqual(self.c._parse_identity('ldap.google.com'),
+                     ('ldap', 'google.com'))
+    self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
+                     ('ldap', 'example.com'))
+    # Specical case because we know there are no subdomains in chromium.org.
+    self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
+                     ('note.period', 'chromium.org'))
+    # Pathological: .period. can be either ldap OR domain, more likely domain.
+    self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
+                     ('note', 'period.example.com'))
+
   def test_analysis_nothing(self):
     self.c._all_hosts = []
     self.assertFalse(self.c.has_generic_host())