commit 52969c9d1049ffc5daecdb9210ad29f13438449b
author Edward Lemur <ehmaldonado@google.com> Thu Feb 06 18:15:28 2020 +0000
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Feb 06 18:15:28 2020 +0000
tree 70039d02937a066151e83f32778d5eb5a05c59b2
parent 50984a64faecb0ce3df0994b2d9d05b29b5ee7f2

git-cl: Remove _add_codereview_[issue_]select_options and _CODEREVIEW_IMPLEMENTATIONS.

Change-Id: I94922e1abab8acac132e16d255e1a9b95771ea5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2040572
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

tests/git_cl_test.py

diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index 6ad36d5..1c314a1 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -1915,7 +1915,7 @@
       ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
       ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
     ]
-    self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
+    self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
 
   def test_patch_gerrit_guess_by_url(self):
     self.calls += self._get_gerrit_codereview_server_calls(
@@ -2192,7 +2192,7 @@
     self.mock(git_cl.sys, 'stderr', out)
 
     try:
-      self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
+      self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
     except SystemExit as ex:
       self.assertEqual(ex.code, 2)
       self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
@@ -2207,7 +2207,7 @@
 
     self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
     self.assertEqual(
-      git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
+      git_cl.main(['status', '--issue', '1', '--field', 'desc']),
       0)
     self.assertEqual(out.getvalue(), 'foobar\n')
 
@@ -2220,7 +2220,7 @@
     self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
     self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
     self.assertEqual(
-      git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
+      git_cl.main(['set-close', '--issue', '1']), 0)
 
   def test_description(self):
     out = StringIO()
@@ -2288,7 +2288,7 @@
         ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
         ((['git', 'config', 'core.editor'],), 'vi'),
     ]
-    self.assertEqual(0, git_cl.main(['description', '--gerrit']))
+    self.assertEqual(0, git_cl.main(['description']))
 
   def test_description_does_not_append_bug_line_if_fixed_is_present(self):
     current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
@@ -2316,7 +2316,7 @@
         ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
         ((['git', 'config', 'core.editor'],), 'vi'),
     ]
-    self.assertEqual(0, git_cl.main(['description', '--gerrit']))
+    self.assertEqual(0, git_cl.main(['description']))
 
   def test_description_set_stdin(self):
     out = StringIO()
@@ -2748,8 +2748,7 @@
         'msg', None),
        None),
     ]
-    self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
-                                     '-a', 'msg']))
+    self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
 
   def test_git_cl_comments_fetch_gerrit(self):
     self.mock(sys, 'stdout', StringIO())