blob: 286e14cd1500c10f1b4405d2ed87a8c04483a85b [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01009import datetime
tandriide281ae2016-10-12 06:02:30 -070010import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010011import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000012import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
22
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000023import metrics
24# We have to disable monitoring before importing git_cl.
25metrics.DISABLE_METRICS_COLLECTION = True
26
Eric Boren2fb63102018-10-05 13:05:03 +000027import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000028import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000029import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000030import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
65 desc = ""
66 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
skobes6468b902016-10-24 08:45:10 -070086class GitCheckoutMock(object):
87 def __init__(self, *args, **kwargs):
88 pass
89
90 @staticmethod
91 def reset():
92 GitCheckoutMock.conflict = False
93
94 def apply_patch(self, p):
95 if GitCheckoutMock.conflict:
96 raise Exception('failed')
97
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000098
99class WatchlistsMock(object):
100 def __init__(self, _):
101 pass
102 @staticmethod
103 def GetWatchersForPaths(_):
104 return ['joe@example.com']
105
106
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000107class CodereviewSettingsFileMock(object):
108 def __init__(self):
109 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800110 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000111 def read(self):
112 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000113 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000114
115
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000116class AuthenticatorMock(object):
117 def __init__(self, *_args):
118 pass
119 def has_cached_credentials(self):
120 return True
tandrii221ab252016-10-06 08:12:04 -0700121 def authorize(self, http):
122 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000123
124
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100125def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
127
128 Usage:
129 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100130 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000131
132 OR
133 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100134 CookiesAuthenticatorMockFactory(
135 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000136 """
137 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800138 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139 # Intentionally not calling super() because it reads actual cookie files.
140 pass
141 @classmethod
142 def get_gitcookies_path(cls):
143 return '~/.gitcookies'
144 @classmethod
145 def get_netrc_path(cls):
146 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 def _get_auth_for_host(self, host):
148 if same_auth:
149 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000150 return (hosts_with_creds or {}).get(host)
151 return CookiesAuthenticatorMock
152
Aaron Gable9a03ae02017-11-03 11:31:07 -0700153
kmarshall9249e012016-08-23 12:02:16 -0700154class MockChangelistWithBranchAndIssue():
155 def __init__(self, branch, issue):
156 self.branch = branch
157 self.issue = issue
158 def GetBranch(self):
159 return self.branch
160 def GetIssue(self):
161 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162
tandriic2405f52016-10-10 08:13:15 -0700163
164class SystemExitMock(Exception):
165 pass
166
167
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000168class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100169 def test_get_description(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000170 cl = git_cl.Changelist(issue=1, codereview='gerrit',
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100171 codereview_host='host')
172 cl.description = 'x'
173 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800174 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100175 self.assertEquals(cl.GetDescription(), 'x')
176 self.assertEquals(cl.GetDescription(force=True), 'y')
177 self.assertEquals(cl.GetDescription(), 'y')
178
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700179 def test_description_footers(self):
180 cl = git_cl.Changelist(issue=1, codereview='gerrit',
181 codereview_host='host')
182 cl.description = '\n'.join([
183 'This is some message',
184 '',
185 'It has some lines',
186 'and, also',
187 '',
188 'Some: Really',
189 'Awesome: Footers',
190 ])
191 cl.has_description = True
192 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
193 msg, footers = cl.GetDescriptionFooters()
194 self.assertEquals(
195 msg, ['This is some message', '', 'It has some lines', 'and, also'])
196 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
197
198 msg.append('wut')
199 footers.append(('gnarly-dude', 'beans'))
200 cl.UpdateDescriptionFooters(msg, footers)
201 self.assertEquals(cl.GetDescription().splitlines(), [
202 'This is some message',
203 '',
204 'It has some lines',
205 'and, also',
206 'wut'
207 '',
208 'Some: Really',
209 'Awesome: Footers',
210 'Gnarly-Dude: beans',
211 ])
212
tandriif9aefb72016-07-01 09:06:51 -0700213 def test_get_bug_line_values(self):
214 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
215 self.assertEqual(f('', ''), [])
216 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
217 self.assertEqual(f('v8', '456'), ['v8:456'])
218 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
219 # Not nice, but not worth carying.
220 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
221 ['v8:456', 'chromium:123', 'v8:123'])
222
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100223 def _test_git_number(self, parent_msg, dest_ref, child_msg,
224 parent_hash='parenthash'):
225 desc = git_cl.ChangeDescription(child_msg)
226 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
227 return desc.description
228
229 def assertEqualByLine(self, actual, expected):
230 self.assertEqual(actual.splitlines(), expected.splitlines())
231
232 def test_git_number_bad_parent(self):
233 with self.assertRaises(ValueError):
234 self._test_git_number('Parent', 'refs/heads/master', 'Child')
235
236 def test_git_number_bad_parent_footer(self):
237 with self.assertRaises(AssertionError):
238 self._test_git_number(
239 'Parent\n'
240 '\n'
241 'Cr-Commit-Position: wrong',
242 'refs/heads/master', 'Child')
243
244 def test_git_number_bad_lineage_ignored(self):
245 actual = self._test_git_number(
246 'Parent\n'
247 '\n'
248 'Cr-Commit-Position: refs/heads/master@{#1}\n'
249 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
250 'refs/heads/master', 'Child')
251 self.assertEqualByLine(
252 actual,
253 'Child\n'
254 '\n'
255 'Cr-Commit-Position: refs/heads/master@{#2}\n'
256 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
257
258 def test_git_number_same_branch(self):
259 actual = self._test_git_number(
260 'Parent\n'
261 '\n'
262 'Cr-Commit-Position: refs/heads/master@{#12}',
263 dest_ref='refs/heads/master',
264 child_msg='Child')
265 self.assertEqualByLine(
266 actual,
267 'Child\n'
268 '\n'
269 'Cr-Commit-Position: refs/heads/master@{#13}')
270
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200271 def test_git_number_same_branch_mixed_footers(self):
272 actual = self._test_git_number(
273 'Parent\n'
274 '\n'
275 'Cr-Commit-Position: refs/heads/master@{#12}',
276 dest_ref='refs/heads/master',
277 child_msg='Child\n'
278 '\n'
279 'Broken-by: design\n'
280 'BUG=123')
281 self.assertEqualByLine(
282 actual,
283 'Child\n'
284 '\n'
285 'Broken-by: design\n'
286 'BUG=123\n'
287 'Cr-Commit-Position: refs/heads/master@{#13}')
288
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100289 def test_git_number_same_branch_with_originals(self):
290 actual = self._test_git_number(
291 'Parent\n'
292 '\n'
293 'Cr-Commit-Position: refs/heads/master@{#12}',
294 dest_ref='refs/heads/master',
295 child_msg='Child\n'
296 '\n'
297 'Some users are smart and insert their own footers\n'
298 '\n'
299 'Cr-Whatever: value\n'
300 'Cr-Commit-Position: refs/copy/paste@{#22}')
301 self.assertEqualByLine(
302 actual,
303 'Child\n'
304 '\n'
305 'Some users are smart and insert their own footers\n'
306 '\n'
307 'Cr-Original-Whatever: value\n'
308 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
309 'Cr-Commit-Position: refs/heads/master@{#13}')
310
311 def test_git_number_new_branch(self):
312 actual = self._test_git_number(
313 'Parent\n'
314 '\n'
315 'Cr-Commit-Position: refs/heads/master@{#12}',
316 dest_ref='refs/heads/branch',
317 child_msg='Child')
318 self.assertEqualByLine(
319 actual,
320 'Child\n'
321 '\n'
322 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
323 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
324
325 def test_git_number_lineage(self):
326 actual = self._test_git_number(
327 'Parent\n'
328 '\n'
329 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
330 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
331 dest_ref='refs/heads/branch',
332 child_msg='Child')
333 self.assertEqualByLine(
334 actual,
335 'Child\n'
336 '\n'
337 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
338 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
339
340 def test_git_number_moooooooore_lineage(self):
341 actual = self._test_git_number(
342 'Parent\n'
343 '\n'
344 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
345 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
346 dest_ref='refs/heads/mooore',
347 child_msg='Child')
348 self.assertEqualByLine(
349 actual,
350 'Child\n'
351 '\n'
352 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
353 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
354 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
355
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100356 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700357 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100358 actual = self._test_git_number(
359 'CQ commit on fresh new branch + numbering.\n'
360 '\n'
361 'NOTRY=True\n'
362 'NOPRESUBMIT=True\n'
363 'BUG=\n'
364 '\n'
365 'Review-Url: https://codereview.chromium.org/2577703003\n'
366 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
367 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
368 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
369 dest_ref='refs/heads/gnumb-test/cl',
370 child_msg='git cl on fresh new branch + numbering.\n'
371 '\n'
372 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
373 self.assertEqualByLine(
374 actual,
375 'git cl on fresh new branch + numbering.\n'
376 '\n'
377 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
378 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
379 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
380 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
381 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100382
383 def test_git_number_cherry_pick(self):
384 actual = self._test_git_number(
385 'Parent\n'
386 '\n'
387 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
388 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
389 dest_ref='refs/heads/branch',
390 child_msg='Child, which is cherry-pick from master\n'
391 '\n'
392 'Cr-Commit-Position: refs/heads/master@{#100}\n'
393 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
394 self.assertEqualByLine(
395 actual,
396 'Child, which is cherry-pick from master\n'
397 '\n'
398 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
399 '\n'
400 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
401 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
402 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
403
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000404 def test_gerrit_mirror_hack(self):
405 cr = 'chromium-review.googlesource.com'
406 url0 = 'https://%s/a/changes/x?a=b' % cr
407 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
408 try:
409 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
410 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
411 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
412 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
413
414 self.assertNotEqual(url1, url2)
415 self.assertEqual(sorted((url1, url2)), [
416 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
417 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
418 self.assertEqual(url1, url3)
419 finally:
420 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
421
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000422 def test_valid_accounts(self):
423 mock_per_account = {
424 'u1': None, # 404, doesn't exist.
425 'u2': {
426 '_account_id': 123124,
427 'avatars': [],
428 'email': 'u2@example.com',
429 'name': 'User Number 2',
430 'status': 'OOO',
431 },
432 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
433 }
434 def GetAccountDetailsMock(_, account):
435 # Poor-man's mock library's side_effect.
436 v = mock_per_account.pop(account)
437 if isinstance(v, Exception):
438 raise v
439 return v
440
441 original = git_cl.gerrit_util.GetAccountDetails
442 try:
443 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
444 actual = git_cl.gerrit_util.ValidAccounts(
445 'host', ['u1', 'u2', 'u3'], max_threads=1)
446 finally:
447 git_cl.gerrit_util.GetAccountDetails = original
448 self.assertEqual(actual, {
449 'u2': {
450 '_account_id': 123124,
451 'avatars': [],
452 'email': 'u2@example.com',
453 'name': 'User Number 2',
454 'status': 'OOO',
455 },
456 })
457
458
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000459
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200460class TestParseIssueURL(unittest.TestCase):
461 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
462 codereview=None, fail=False):
463 self.assertIsNotNone(parsed)
464 if fail:
465 self.assertFalse(parsed.valid)
466 return
467 self.assertTrue(parsed.valid)
468 self.assertEqual(parsed.issue, issue)
469 self.assertEqual(parsed.patchset, patchset)
470 self.assertEqual(parsed.hostname, hostname)
471 self.assertEqual(parsed.codereview, codereview)
472
473 def _run_and_validate(self, func, url, *args, **kwargs):
474 result = func(urlparse.urlparse(url))
475 if kwargs.pop('fail', False):
476 self.assertIsNone(result)
477 return None
478 self._validate(result, *args, fail=False, **kwargs)
479
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480 def test_gerrit(self):
481 def test(url, issue=None, patchset=None, hostname=None, fail=None):
482 self._test_ParseIssueUrl(
483 git_cl._GerritChangelistImpl.ParseIssueURL,
484 url, issue, patchset, hostname, fail)
485 def test(url, *args, **kwargs):
486 self._run_and_validate(git_cl._GerritChangelistImpl.ParseIssueURL, url,
487 *args, codereview='gerrit', **kwargs)
488
489 test('http://chrome-review.source.com/c/123',
490 123, None, 'chrome-review.source.com')
491 test('https://chrome-review.source.com/c/123/',
492 123, None, 'chrome-review.source.com')
493 test('https://chrome-review.source.com/c/123/4',
494 123, 4, 'chrome-review.source.com')
495 test('https://chrome-review.source.com/#/c/123/4',
496 123, 4, 'chrome-review.source.com')
497 test('https://chrome-review.source.com/c/123/4',
498 123, 4, 'chrome-review.source.com')
499 test('https://chrome-review.source.com/123',
500 123, None, 'chrome-review.source.com')
501 test('https://chrome-review.source.com/123/4',
502 123, 4, 'chrome-review.source.com')
503
504 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
505 test('https://chrome-review.source.com/c/abc/', fail=True)
506 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
507
508 def test_ParseIssueNumberArgument(self):
509 def test(arg, *args, **kwargs):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200510 codereview_hint = kwargs.pop('hint', None)
511 self._validate(git_cl.ParseIssueNumberArgument(arg, codereview_hint),
512 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200513
514 test('123', 123)
515 test('', fail=True)
516 test('abc', fail=True)
517 test('123/1', fail=True)
518 test('123a', fail=True)
519 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000520
521 # Looks like Rietveld and Gerrit, but we should select Gerrit now
522 # w/ or w/o hint.
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200523 test('https://codereview.source.com/123',
524 123, None, 'codereview.source.com', 'gerrit',
525 hint='gerrit')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000526 test('https://codereview.source.com/123',
527 123, None, 'codereview.source.com', 'gerrit')
528
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200529 # Gerrrit.
530 test('https://chrome-review.source.com/c/123/4',
531 123, 4, 'chrome-review.source.com', 'gerrit')
532 test('https://chrome-review.source.com/bad/123/4', fail=True)
533
534
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100535class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100536 def setUp(self):
537 super(GitCookiesCheckerTest, self).setUp()
538 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100539 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100540
541 def mock_hosts_creds(self, subhost_identity_pairs):
542 def ensure_googlesource(h):
543 if not h.endswith(self.c._GOOGLESOURCE):
544 assert not h.endswith('.')
545 return h + '.' + self.c._GOOGLESOURCE
546 return h
547 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
548 for h, i in subhost_identity_pairs]
549
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200550 def test_identity_parsing(self):
551 self.assertEqual(self.c._parse_identity('ldap.google.com'),
552 ('ldap', 'google.com'))
553 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
554 ('ldap', 'example.com'))
555 # Specical case because we know there are no subdomains in chromium.org.
556 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
557 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800558 # Pathological: ".period." can be either username OR domain, more likely
559 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200560 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
561 ('note', 'period.example.com'))
562
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563 def test_analysis_nothing(self):
564 self.c._all_hosts = []
565 self.assertFalse(self.c.has_generic_host())
566 self.assertEqual(set(), self.c.get_conflicting_hosts())
567 self.assertEqual(set(), self.c.get_duplicated_hosts())
568 self.assertEqual(set(), self.c.get_partially_configured_hosts())
569 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
570
571 def test_analysis(self):
572 self.mock_hosts_creds([
573 ('.googlesource.com', 'git-example.chromium.org'),
574
575 ('chromium', 'git-example.google.com'),
576 ('chromium-review', 'git-example.google.com'),
577 ('chrome-internal', 'git-example.chromium.org'),
578 ('chrome-internal-review', 'git-example.chromium.org'),
579 ('conflict', 'git-example.google.com'),
580 ('conflict-review', 'git-example.chromium.org'),
581 ('dup', 'git-example.google.com'),
582 ('dup', 'git-example.google.com'),
583 ('dup-review', 'git-example.google.com'),
584 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200585 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100586 ])
587 self.assertTrue(self.c.has_generic_host())
588 self.assertEqual(set(['conflict.googlesource.com']),
589 self.c.get_conflicting_hosts())
590 self.assertEqual(set(['dup.googlesource.com']),
591 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200592 self.assertEqual(set(['partial.googlesource.com',
593 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100594 self.c.get_partially_configured_hosts())
595 self.assertEqual(set(['chromium.googlesource.com',
596 'chrome-internal.googlesource.com']),
597 self.c.get_hosts_with_wrong_identities())
598
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100599 def test_report_no_problems(self):
600 self.test_analysis_nothing()
601 self.mock(sys, 'stdout', StringIO.StringIO())
602 self.assertFalse(self.c.find_and_report_problems())
603 self.assertEqual(sys.stdout.getvalue(), '')
604
605 def test_report(self):
606 self.test_analysis()
607 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200608 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
609 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100610 self.assertTrue(self.c.find_and_report_problems())
611 with open(os.path.join(os.path.dirname(__file__),
612 'git_cl_creds_check_report.txt')) as f:
613 expected = f.read()
614 def by_line(text):
615 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700616 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200617 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100618
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800619
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000620class TestGitCl(TestCase):
621 def setUp(self):
622 super(TestGitCl, self).setUp()
623 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700624 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000625 self.mock(git_cl, 'time_time',
626 lambda: self._mocked_call('time.time'))
627 self.mock(git_cl.metrics.collector, 'add_repeated',
628 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000629 self.mock(subprocess2, 'call', self._mocked_call)
630 self.mock(subprocess2, 'check_call', self._mocked_call)
631 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700632 self.mock(subprocess2, 'communicate',
633 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000634 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000635 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000636 self.mock(git_common, 'get_or_create_merge_base',
637 lambda *a: (
638 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000639 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000640 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000641 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
642 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100643 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000644 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700645 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000646 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000647 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
skobes6468b902016-10-24 08:45:10 -0700648 self.mock(git_cl.checkout, 'GitCheckout', GitCheckoutMock)
649 GitCheckoutMock.reset()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000650 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000651 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100652 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
653 lambda *args, **kwargs: self._mocked_call(
654 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700655 self.mock(git_cl.gerrit_util, 'GetChangeComments',
656 lambda *args, **kwargs: self._mocked_call(
657 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000658 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
659 lambda *args, **kwargs: self._mocked_call(
660 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100661 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700662 lambda h, i, reviewers, ccs, notify: self._mocked_call(
663 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700664 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700665 lambda h, i, msg=None, labels=None, notify=None:
666 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700667 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
668 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000669 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
670 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000671 self.mock(git_cl.gerrit_util, 'ValidAccounts',
672 lambda host, accounts:
673 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700674 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100675 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000676 # It's important to reset settings to not have inter-tests interference.
677 git_cl.settings = None
678
679 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000680 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100681 self.assertEquals([], self.calls)
682 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000683 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100684 raise
685 # Sadly, has_failed() returns True if this OR any other tests before this
686 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200687 git_cl.logging.error(
688 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100689 'There are un-consumed self.calls after this test has finished.\n'
690 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700691 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200692 'If you are already running only this test, then **first** fix the '
693 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100694 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700695 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100696 'and follow instructions above.\n' +
697 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000698 finally:
699 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000700
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000701 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000702 self.assertTrue(
703 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700704 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000705 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000706 expected_args, result = top
707
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000708 # Also logs otherwise it could get caught in a try/finally and be hard to
709 # diagnose.
710 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700711 N = 5
712 prior_calls = '\n '.join(
713 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
714 for i, c in enumerate(self._calls_done[-N:]))
715 following_calls = '\n '.join(
716 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
717 for i, c in enumerate(self.calls[:N]))
718 extended_msg = (
719 'A few prior calls:\n %s\n\n'
720 'This (expected):\n @%d: %r\n'
721 'This (actual):\n @%d: %r\n\n'
722 'A few following expected calls:\n %s' %
723 (prior_calls, len(self._calls_done), expected_args,
724 len(self._calls_done), args, following_calls))
725 git_cl.logging.error(extended_msg)
726
tandrii99a72f22016-08-17 14:33:24 -0700727 self.fail('@%d\n'
728 ' Expected: %r\n'
729 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700730 len(self._calls_done), expected_args, args))
731
732 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700733 if isinstance(result, Exception):
734 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000735 return result
736
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100737 def test_ask_for_explicit_yes_true(self):
738 self.calls = [
739 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
740 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
741 ]
742 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
743
tandrii48df5812016-10-17 03:55:37 -0700744 def test_LoadCodereviewSettingsFromFile_gerrit(self):
745 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
746 self.calls = [
747 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700748 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
749 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
750 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
751 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700752 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
753 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700754 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
755 CERR1),
756 ((['git', 'config', 'gerrit.host', 'true'],), ''),
757 ]
758 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
759
maruel@chromium.orga3353652011-11-30 14:26:57 +0000760 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000761 def _is_gerrit_calls(cls, gerrit=False):
762 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
763 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
764
765 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000766 def _git_post_upload_calls(cls):
767 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000768 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
769 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
770 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000771 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000772 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000773 ]
774
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000775 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000776 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000777 fake_ancestor = 'fake_ancestor'
778 fake_cl = 'fake_cl_for_patch'
779 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000780 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000781 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000782 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000783 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000784 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000785 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000786 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000787 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700788 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000789 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000790 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000791 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000792 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000793 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000794 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000795 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000796 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000797 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000798 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000799 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000800
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000801 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000802 def _gerrit_ensure_auth_calls(
803 cls, issue=None, skip_auth_check=False, short_hostname='chromium'):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000804 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000805 if skip_auth_check:
806 return [((cmd, ), 'true')]
807
tandrii5d48c322016-08-18 16:19:37 -0700808 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000809 calls.extend([
810 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
811 ((['git', 'config', 'branch.master.remote'],), 'origin'),
812 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000813 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000814 ])
Daniel Chengcf6269b2019-05-18 01:02:12 +0000815 if issue:
816 calls.extend([
817 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
818 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000819 return calls
820
821 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100822 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200823 fetched_status=None, other_cl_owner=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000824 custom_cl_base=None, short_hostname='chromium'):
Aaron Gable13101a62018-02-09 13:20:41 -0800825 calls = cls._is_gerrit_calls(True)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100826 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200827 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200828 ((['git', 'config', 'branch.master.gerritissue'],),
829 CERR1 if issue is None else str(issue)),
830 ]
831
832 if custom_cl_base:
833 ancestor_revision = custom_cl_base
834 else:
835 # Determine ancestor_revision to be merge base.
836 ancestor_revision = 'fake_ancestor_sha'
837 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000838 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000839 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000840 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200841 'refs/remotes/origin/master'],), ancestor_revision),
842 ]
843
844 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000845 calls += cls._gerrit_ensure_auth_calls(
846 issue=issue, short_hostname=short_hostname)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100847
848 if issue:
849 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000850 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000851 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000852 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
853 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100854 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100855 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100856 'change_id': '123456789',
857 'current_revision': 'sha1_of_current_revision',
858 'revisions': { 'sha1_of_current_revision': {
859 'commit': {'message': fetched_description},
860 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100861 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100862 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100863 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100864 if fetched_status == 'ABANDONED':
865 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000866 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100867 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000868 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100869 ]
870 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100871 if other_cl_owner:
872 calls += [
873 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
874 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100875
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200876 calls += cls._git_sanity_checks(ancestor_revision, 'master',
877 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100878 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200879 ((['git', 'rev-parse', '--show-cdup'],), ''),
880 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000881
Aaron Gable7817f022017-12-12 09:43:17 -0800882 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
883 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200884 'M\t.gitignore\n'),
885 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100886 ]
887
888 if not issue:
889 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200890 ((['git', 'log', '--pretty=format:%s%n%n%b',
891 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000892 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100893 ]
894
895 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200896 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000897 (('time.time',), 1000,),
898 (('time.time',), 3000,),
899 (('add_repeated', 'sub_commands', {
900 'execution_time': 2000,
901 'command': 'presubmit',
902 'exit_code': 0
903 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200904 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
905 ([custom_cl_base] if custom_cl_base else
906 [ancestor_revision, 'HEAD']),),
907 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100908 ]
909 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000910
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000911 @classmethod
912 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700913 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000914 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700915 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100916 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000917 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000918 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000919 labels=None, change_id=None, original_title=None,
920 final_description=None, gitcookies_exists=True):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000921 if post_amend_description is None:
922 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700923 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200924 # Determined in `_gerrit_base_calls`.
925 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
926
927 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000928
tandriia60502f2016-06-20 02:01:53 -0700929 if squash_mode == 'default':
930 calls.extend([
931 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
932 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
933 ])
934 elif squash_mode in ('override_squash', 'override_nosquash'):
935 calls.extend([
936 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
937 'true' if squash_mode == 'override_squash' else 'false'),
938 ])
939 else:
940 assert squash_mode in ('squash', 'nosquash')
941
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000942 # If issue is given, then description is fetched from Gerrit instead.
943 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000944 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200945 ((['git', 'log', '--pretty=format:%s\n\n%b',
946 ((custom_cl_base + '..') if custom_cl_base else
947 'fake_ancestor_sha..HEAD')],),
948 description),
949 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800950 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000951 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800952 else:
953 if not title:
954 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200955 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
956 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800957 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000958 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000959 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000960 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200961 (('DownloadGerritHook', False), ''),
962 # Amending of commit message to get the Change-Id.
963 ((['git', 'log', '--pretty=format:%s\n\n%b',
964 determined_ancestor_revision + '..HEAD'],),
965 description),
966 ((['git', 'commit', '--amend', '-m', description],), ''),
967 ((['git', 'log', '--pretty=format:%s\n\n%b',
968 determined_ancestor_revision + '..HEAD'],),
969 post_amend_description)
970 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000971 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000972 if not issue:
973 # Prompting to edit description on first upload.
974 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000975 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200976 ((['git', 'config', 'core.editor'],), ''),
977 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000978 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000979 ref_to_push = 'abcdef0123456789'
980 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200981 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
982 ((['git', 'config', 'branch.master.remote'],), 'origin'),
983 ]
984
985 if custom_cl_base is None:
986 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000987 ((['get_or_create_merge_base', 'master',
988 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000989 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200990 ]
991 parent = 'origin/master'
992 else:
993 calls += [
994 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
995 'refs/remotes/origin/master'],),
996 callError(1)), # Means not ancenstor.
997 (('ask_for_data',
998 'Do you take responsibility for cleaning up potential mess '
999 'resulting from proceeding with upload? Press Enter to upload, '
1000 'or Ctrl+C to abort'), ''),
1001 ]
1002 parent = custom_cl_base
1003
1004 calls += [
1005 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
1006 '0123456789abcdef'),
1007 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001008 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001009 ref_to_push),
1010 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001011 else:
1012 ref_to_push = 'HEAD'
1013
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001014 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001015 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001016 ((['git', 'rev-list',
1017 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1018 ref_to_push],),
1019 '1hashPerLine\n'),
1020 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001021
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001022 metrics_arguments = []
1023
Aaron Gableafd52772017-06-27 16:40:10 -07001024 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001025 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001026 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001027 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001028 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001029 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001030 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001031 else:
1032 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001033 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001034
Aaron Gable70f4e242017-06-26 10:45:59 -07001035 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001036 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001037 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001038
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001039 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001040 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001041 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001042 if short_hostname == 'chromium':
1043 # All reviwers and ccs get into ref_suffix.
1044 for r in sorted(reviewers):
1045 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001046 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001047 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1048 'joe@example.com'] + cc):
1049 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001050 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001051 reviewers, cc = [], []
1052 else:
1053 # TODO(crbug/877717): remove this case.
1054 calls += [
1055 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1056 sorted(reviewers) + ['joe@example.com',
1057 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1058 {
1059 e: {'email': e}
1060 for e in (reviewers + ['joe@example.com'] + cc)
1061 })
1062 ]
1063 for r in sorted(reviewers):
1064 if r != 'bad-account-or-email':
1065 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001066 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001067 reviewers.remove(r)
1068 for c in sorted(['joe@example.com'] + cc):
1069 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001070 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001071 if c in cc:
1072 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001073
Edward Lemur687ca902018-12-05 02:30:30 +00001074 for k, v in sorted((labels or {}).items()):
1075 ref_suffix += ',l=%s+%d' % (k, v)
1076 metrics_arguments.append('l=%s+%d' % (k, v))
1077
1078 if tbr:
1079 calls += [
1080 (('GetCodeReviewTbrScore',
1081 '%s-review.googlesource.com' % short_hostname,
1082 'my/repo'),
1083 2,),
1084 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001085
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001086 calls += [
1087 (('time.time',), 1000,),
1088 ((['git', 'push',
1089 'https://%s.googlesource.com/my/repo' % short_hostname,
1090 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1091 (('remote:\n'
1092 'remote: Processing changes: (\)\n'
1093 'remote: Processing changes: (|)\n'
1094 'remote: Processing changes: (/)\n'
1095 'remote: Processing changes: (-)\n'
1096 'remote: Processing changes: new: 1 (/)\n'
1097 'remote: Processing changes: new: 1, done\n'
1098 'remote:\n'
1099 'remote: New Changes:\n'
1100 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1101 ' XXX\n'
1102 'remote:\n'
1103 'To https://%s.googlesource.com/my/repo\n'
1104 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1105 ) % (short_hostname, short_hostname)),),
1106 (('time.time',), 2000,),
1107 (('add_repeated',
1108 'sub_commands',
1109 {
1110 'execution_time': 1000,
1111 'command': 'git push',
1112 'exit_code': 0,
1113 'arguments': sorted(metrics_arguments),
1114 }),
1115 None,),
1116 ]
1117
Edward Lemur1b52d872019-05-09 21:12:12 +00001118 final_description = final_description or post_amend_description.strip()
1119 original_title = original_title or title or '<untitled>'
1120 # Trace-related calls
1121 calls += [
1122 # Write a description with context for the current trace.
1123 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001124 'Thu Mar 16 20:00:41 2017\n'
1125 '%(short_hostname)s-review.googlesource.com\n'
1126 '%(change_id)s\n'
1127 '%(title)s\n'
1128 '%(description)s\n'
1129 '1000\n'
1130 '0\n'
1131 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001132 'short_hostname': short_hostname,
1133 'change_id': change_id,
1134 'description': final_description,
1135 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001136 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001137 }],),
1138 None,
1139 ),
1140 # Read traces and shorten git hashes.
1141 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1142 True,
1143 ),
1144 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1145 ('git-hash: 0123456789012345678901234567890123456789\n'
1146 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1147 ),
1148 ((['FileWrite', 'TEMP_DIR/trace-packet',
1149 'git-hash: 012345\n'
1150 'git-hash: abcdea\n'],),
1151 None,
1152 ),
1153 # Make zip file for the git traces.
1154 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1155 'TEMP_DIR'],),
1156 None,
1157 ),
1158 # Collect git config and gitcookies.
1159 ((['git', 'config', '-l'],),
1160 'git-config-output',
1161 ),
1162 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1163 None,
1164 ),
1165 ((['os.path.isfile', '~/.gitcookies'],),
1166 gitcookies_exists,
1167 ),
1168 ]
1169 if gitcookies_exists:
1170 calls += [
1171 ((['FileRead', '~/.gitcookies'],),
1172 'gitcookies 1/SECRET',
1173 ),
1174 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1175 None,
1176 ),
1177 ]
1178 calls += [
1179 # Make zip file for the git config and gitcookies.
1180 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1181 'TEMP_DIR'],),
1182 None,
1183 ),
1184 ]
1185
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001186 if squash:
1187 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001188 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001189 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001190 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001191 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001192 ((['git', 'config', 'branch.master.gerritsquashhash',
1193 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001194 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001195 # TODO(crbug/877717): this should never be used.
1196 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001197 calls += [
1198 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001199 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001200 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001201 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1202 notify),
1203 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001204 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001205 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001206 return calls
1207
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001208 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001209 self,
1210 upload_args,
1211 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001212 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001213 squash=True,
1214 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001215 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001216 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001217 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001218 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001219 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001220 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001221 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001222 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001223 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001224 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001225 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001226 labels=None,
1227 change_id=None,
1228 original_title=None,
1229 final_description=None,
1230 gitcookies_exists=True):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001231 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001232 if squash_mode is None:
1233 if '--no-squash' in upload_args:
1234 squash_mode = 'nosquash'
1235 elif '--squash' in upload_args:
1236 squash_mode = 'squash'
1237 else:
1238 squash_mode = 'default'
1239
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001240 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001241 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001242 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001243 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001244 CookiesAuthenticatorMockFactory(
1245 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001246 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1247 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001248 self.mock(git_cl.gclient_utils, 'RunEditor',
1249 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001250 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1251 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001252 self.mock(git_cl.gclient_utils, 'FileRead',
1253 lambda path: self._mocked_call(['FileRead', path]))
1254 self.mock(git_cl.gclient_utils, 'FileWrite',
1255 lambda path, contents: self._mocked_call(
1256 ['FileWrite', path, contents]))
1257 self.mock(git_cl, 'datetime_now',
1258 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1259 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1260 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
Edward Lemur75391d42019-05-14 23:35:56 +00001261 self.mock(git_cl, 'TRACES_README_FORMAT',
1262 '%(now)s\n'
1263 '%(gerrit_host)s\n'
1264 '%(change_id)s\n'
1265 '%(title)s\n'
1266 '%(description)s\n'
1267 '%(execution_time)s\n'
1268 '%(exit_code)s\n'
1269 '%(trace_name)s')
Edward Lemur1b52d872019-05-09 21:12:12 +00001270 self.mock(git_cl.shutil, 'make_archive',
1271 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1272 self.mock(os.path, 'isfile',
1273 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001274
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001275 self.calls = self._gerrit_base_calls(
1276 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001277 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001278 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001279 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001280 custom_cl_base=custom_cl_base,
1281 short_hostname=short_hostname)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001282 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001283 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1284 expected_content=description))
1285 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001286 self.calls += self._gerrit_upload_calls(
1287 description, reviewers, squash,
1288 squash_mode=squash_mode,
1289 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001290 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001291 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001292 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001293 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001294 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001295 labels=labels,
1296 change_id=change_id,
1297 original_title=original_title,
1298 final_description=final_description,
1299 gitcookies_exists=gitcookies_exists)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001300 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001301 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001302 git_cl.main(['upload'] + upload_args)
1303
Edward Lemur1b52d872019-05-09 21:12:12 +00001304 def test_gerrit_upload_traces_no_gitcookies(self):
1305 self._run_gerrit_upload_test(
1306 ['--no-squash'],
1307 'desc\n\nBUG=\n',
1308 [],
1309 squash=False,
1310 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1311 change_id='Ixxx',
1312 gitcookies_exists=False)
1313
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001314 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001315 self._run_gerrit_upload_test(
1316 ['--no-squash'],
1317 'desc\n\nBUG=\n',
1318 [],
1319 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001320 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1321 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001322
1323 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001324 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001325 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001326 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001327 [],
tandriia60502f2016-06-20 02:01:53 -07001328 squash=False,
1329 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001330 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1331 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001332
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001333 def test_gerrit_no_reviewer(self):
1334 self._run_gerrit_upload_test(
1335 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001336 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001337 [],
1338 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001339 squash_mode='override_nosquash',
1340 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001341
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001342 def test_gerrit_no_reviewer_non_chromium_host(self):
1343 # TODO(crbug/877717): remove this test case.
1344 self._run_gerrit_upload_test(
1345 [],
1346 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1347 [],
1348 squash=False,
1349 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001350 short_hostname='other',
1351 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001352
Nick Carter8692b182017-11-06 16:30:38 -08001353 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001354 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1355 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001356 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001357 'desc\n\nBUG=\n\nChange-Id: I123456789',
1358 squash=False,
1359 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001360 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1361 change_id='I123456789',
1362 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001363
ukai@chromium.orge8077812012-02-03 03:41:46 +00001364 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001365 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001366 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001367 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001368 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001369 squash=False,
1370 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001371 notify=True,
1372 change_id='I123456789',
1373 final_description=
1374 'desc\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001375
1376 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001377 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1378 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001379 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001380 [],
bradnelsond975b302016-10-23 12:20:23 -07001381 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1382 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001383 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001384 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001385 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001386 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001387 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001388 labels={'Code-Review': 2},
1389 change_id='123456789',
1390 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001391
1392 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001393 self._run_gerrit_upload_test(
1394 [],
1395 'desc\nBUG=\n\nChange-Id: 123456789',
1396 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001397 expected_upstream_ref='origin/master',
1398 change_id='123456789',
1399 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001400
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001401 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001402 self._run_gerrit_upload_test(
1403 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001404 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001405 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001406 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001407 expected_upstream_ref='origin/master',
1408 change_id='123456789',
1409 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001410
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001411 def test_gerrit_upload_squash_first_with_labels(self):
1412 self._run_gerrit_upload_test(
1413 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1414 'desc\nBUG=\n\nChange-Id: 123456789',
1415 [],
1416 squash=True,
1417 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001418 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1419 change_id='123456789',
1420 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001421
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001422 def test_gerrit_upload_squash_first_against_rev(self):
1423 custom_cl_base = 'custom_cl_base_rev_or_branch'
1424 self._run_gerrit_upload_test(
1425 ['--squash', custom_cl_base],
1426 'desc\nBUG=\n\nChange-Id: 123456789',
1427 [],
1428 squash=True,
1429 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001430 custom_cl_base=custom_cl_base,
1431 change_id='123456789',
1432 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001433 self.assertIn(
1434 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1435 sys.stdout.getvalue())
1436
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001437 def test_gerrit_upload_squash_reupload(self):
1438 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001439 self._run_gerrit_upload_test(
1440 ['--squash'],
1441 description,
1442 [],
1443 squash=True,
1444 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001445 issue=123456,
1446 change_id='123456789',
1447 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001448
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001449 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1450 self.mock(git_cl, 'DieWithError',
1451 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1452 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1453 with self.assertRaises(SystemExitMock):
1454 self._run_gerrit_upload_test(
1455 ['--squash'],
1456 description,
1457 [],
1458 squash=True,
1459 expected_upstream_ref='origin/master',
1460 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001461 fetched_status='ABANDONED',
1462 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001463
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001464 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1465 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1466 lambda *_, **__: {'email': 'yet-another@example.com'})
1467 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1468 self._run_gerrit_upload_test(
1469 ['--squash'],
1470 description,
1471 [],
1472 squash=True,
1473 expected_upstream_ref='origin/master',
1474 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001475 other_cl_owner='other@example.com',
1476 change_id='123456789',
1477 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001478 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001479 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001480 'authenticate to Gerrit as yet-another@example.com.\n'
1481 'Uploading may fail due to lack of permissions',
1482 git_cl.sys.stdout.getvalue())
1483
rmistry@google.com2dd99862015-06-22 12:22:18 +00001484 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001485 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001486 def mock_run_git(*args, **_kwargs):
1487 if args[0] == ['for-each-ref',
1488 '--format=%(refname:short) %(upstream:short)',
1489 'refs/heads']:
1490 # Create a local branch dependency tree that looks like this:
1491 # test1 -> test2 -> test3 -> test4 -> test5
1492 # -> test3.1
1493 # test6 -> test0
1494 branch_deps = [
1495 'test2 test1', # test1 -> test2
1496 'test3 test2', # test2 -> test3
1497 'test3.1 test2', # test2 -> test3.1
1498 'test4 test3', # test3 -> test4
1499 'test5 test4', # test4 -> test5
1500 'test6 test0', # test0 -> test6
1501 'test7', # test7
1502 ]
1503 return '\n'.join(branch_deps)
1504 self.mock(git_cl, 'RunGit', mock_run_git)
1505
1506 class RecordCalls:
1507 times_called = 0
1508 record_calls = RecordCalls()
1509 def mock_CMDupload(*args, **_kwargs):
1510 record_calls.times_called += 1
1511 return 0
1512 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1513
1514 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001515 (('ask_for_data', 'This command will checkout all dependent branches '
1516 'and run "git cl upload". Press Enter to continue, '
1517 'or Ctrl+C to abort'), ''),
1518 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001519
1520 class MockChangelist():
1521 def __init__(self):
1522 pass
1523 def GetBranch(self):
1524 return 'test1'
1525 def GetIssue(self):
1526 return '123'
1527 def GetPatchset(self):
1528 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001529 def IsGerrit(self):
1530 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001531
1532 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1533 # CMDupload should have been called 5 times because of 5 dependent branches.
1534 self.assertEquals(5, record_calls.times_called)
1535 self.assertEquals(0, ret)
1536
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001537 def test_gerrit_change_id(self):
1538 self.calls = [
1539 ((['git', 'write-tree'], ),
1540 'hashtree'),
1541 ((['git', 'rev-parse', 'HEAD~0'], ),
1542 'branch-parent'),
1543 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1544 'A B <a@b.org> 1456848326 +0100'),
1545 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1546 'C D <c@d.org> 1456858326 +0100'),
1547 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1548 'hashchange'),
1549 ]
1550 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1551 self.assertEqual(change_id, 'Ihashchange')
1552
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001553 def test_desecription_append_footer(self):
1554 for init_desc, footer_line, expected_desc in [
1555 # Use unique desc first lines for easy test failure identification.
1556 ('foo', 'R=one', 'foo\n\nR=one'),
1557 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1558 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1559 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1560 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1561 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1562 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1563 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1564 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1565 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1566 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1567 ]:
1568 desc = git_cl.ChangeDescription(init_desc)
1569 desc.append_footer(footer_line)
1570 self.assertEqual(desc.description, expected_desc)
1571
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001572 def test_update_reviewers(self):
1573 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001574 ('foo', [], [],
1575 'foo'),
1576 ('foo\nR=xx', [], [],
1577 'foo\nR=xx'),
1578 ('foo\nTBR=xx', [], [],
1579 'foo\nTBR=xx'),
1580 ('foo', ['a@c'], [],
1581 'foo\n\nR=a@c'),
1582 ('foo\nR=xx', ['a@c'], [],
1583 'foo\n\nR=a@c, xx'),
1584 ('foo\nTBR=xx', ['a@c'], [],
1585 'foo\n\nR=a@c\nTBR=xx'),
1586 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1587 'foo\n\nR=a@c, yy\nTBR=xx'),
1588 ('foo\nBUG=', ['a@c'], [],
1589 'foo\nBUG=\nR=a@c'),
1590 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1591 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1592 ('foo', ['a@c', 'b@c'], [],
1593 'foo\n\nR=a@c, b@c'),
1594 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1595 'foo\nBar\n\nR=c@c\nBUG='),
1596 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1597 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001598 # Same as the line before, but full of whitespaces.
1599 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001600 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001601 'foo\nBar\n\nR=c@c\n BUG =',
1602 ),
1603 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001604 ('foo BUG=allo R=joe ', ['c@c'], [],
1605 'foo BUG=allo R=joe\n\nR=c@c'),
1606 # Redundant TBRs get promoted to Rs
1607 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1608 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001609 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001610 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001611 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001612 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001613 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001614 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001615 actual.append(obj.description)
1616 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001617
Nodir Turakulov23b82142017-11-16 11:04:25 -08001618 def test_get_hash_tags(self):
1619 cases = [
1620 ('', []),
1621 ('a', []),
1622 ('[a]', ['a']),
1623 ('[aa]', ['aa']),
1624 ('[a ]', ['a']),
1625 ('[a- ]', ['a']),
1626 ('[a- b]', ['a-b']),
1627 ('[a--b]', ['a-b']),
1628 ('[a', []),
1629 ('[a]x', ['a']),
1630 ('[aa]x', ['aa']),
1631 ('[a b]', ['a-b']),
1632 ('[a b]', ['a-b']),
1633 ('[a__b]', ['a-b']),
1634 ('[a] x', ['a']),
1635 ('[a][b]', ['a', 'b']),
1636 ('[a] [b]', ['a', 'b']),
1637 ('[a][b]x', ['a', 'b']),
1638 ('[a][b] x', ['a', 'b']),
1639 ('[a]\n[b]', ['a']),
1640 ('[a\nb]', []),
1641 ('[a][', ['a']),
1642 ('Revert "[a] feature"', ['a']),
1643 ('Reland "[a] feature"', ['a']),
1644 ('Revert: [a] feature', ['a']),
1645 ('Reland: [a] feature', ['a']),
1646 ('Revert "Reland: [a] feature"', ['a']),
1647 ('Foo: feature', ['foo']),
1648 ('Foo Bar: feature', ['foo-bar']),
1649 ('Revert "Foo bar: feature"', ['foo-bar']),
1650 ('Reland "Foo bar: feature"', ['foo-bar']),
1651 ]
1652 for desc, expected in cases:
1653 change_desc = git_cl.ChangeDescription(desc)
1654 actual = change_desc.get_hash_tags()
1655 self.assertEqual(
1656 actual,
1657 expected,
1658 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1659
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001660
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001661 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001662 self.assertEqual(None, git_cl.GetTargetRef(None,
1663 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001664 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001665
wittman@chromium.org455dc922015-01-26 20:15:50 +00001666 # Check default target refs for branches.
1667 self.assertEqual('refs/heads/master',
1668 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001669 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001670 self.assertEqual('refs/heads/master',
1671 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001672 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001673 self.assertEqual('refs/heads/master',
1674 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001675 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001676 self.assertEqual('refs/branch-heads/123',
1677 git_cl.GetTargetRef('origin',
1678 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001679 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001680 self.assertEqual('refs/diff/test',
1681 git_cl.GetTargetRef('origin',
1682 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001683 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001684 self.assertEqual('refs/heads/chrome/m42',
1685 git_cl.GetTargetRef('origin',
1686 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001687 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001688
1689 # Check target refs for user-specified target branch.
1690 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1691 'refs/remotes/branch-heads/123'):
1692 self.assertEqual('refs/branch-heads/123',
1693 git_cl.GetTargetRef('origin',
1694 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001695 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001696 for branch in ('origin/master', 'remotes/origin/master',
1697 'refs/remotes/origin/master'):
1698 self.assertEqual('refs/heads/master',
1699 git_cl.GetTargetRef('origin',
1700 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001701 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001702 for branch in ('master', 'heads/master', 'refs/heads/master'):
1703 self.assertEqual('refs/heads/master',
1704 git_cl.GetTargetRef('origin',
1705 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001706 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001707
wychen@chromium.orga872e752015-04-28 23:42:18 +00001708 def test_patch_when_dirty(self):
1709 # Patch when local tree is dirty
1710 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1711 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1712
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001713 @staticmethod
1714 def _get_gerrit_codereview_server_calls(branch, value=None,
1715 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001716 detect_branch=True,
1717 detect_server=True):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001718 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1719
1720 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1721 """
1722 calls = []
1723 if detect_branch:
1724 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001725 if detect_server:
1726 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1727 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001728 if value is None:
1729 calls += [
1730 ((['git', 'config', 'branch.' + branch + '.merge'],),
1731 'refs/heads' + branch),
1732 ((['git', 'config', 'branch.' + branch + '.remote'],),
1733 'origin'),
1734 ((['git', 'config', 'remote.origin.url'],),
1735 'https://%s.googlesource.com/my/repo' % git_short_host),
1736 ]
1737 return calls
1738
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001739 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001740 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001741 detect_gerrit_server=False,
1742 actual_codereview=None,
1743 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001744 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001745 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1746
tandriidf09a462016-08-18 16:23:55 -07001747 if new_branch:
1748 self.calls = [((['git', 'new-branch', 'master'],), ''),]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001749
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001750 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001751 self.calls += [
1752 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001753 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001754 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001755
1756 if not force_codereview and not codereview_in_url:
1757 # These calls detect codereview to use.
1758 self.calls += [
1759 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001760 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001761 ]
1762 if detect_gerrit_server:
1763 self.calls += self._get_gerrit_codereview_server_calls(
1764 'master', git_short_host=git_short_host,
1765 detect_branch=not new_branch and force_codereview)
1766 actual_codereview = 'gerrit'
1767
1768 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001769 self.calls += [
1770 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001771 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001772 {
1773 'current_revision': '7777777777',
1774 'revisions': {
1775 '1111111111': {
1776 '_number': 1,
1777 'fetch': {'http': {
1778 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1779 'ref': 'refs/changes/56/123456/1',
1780 }},
1781 },
1782 '7777777777': {
1783 '_number': 7,
1784 'fetch': {'http': {
1785 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1786 'ref': 'refs/changes/56/123456/7',
1787 }},
1788 },
1789 },
1790 }),
1791 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001792
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001793 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001794 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001795 self.calls += [
1796 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1797 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001798 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001799 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001800 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001801 ((['git', 'config', 'branch.master.gerritserver',
1802 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001803 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001804 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1805 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1806 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001807 ]
1808 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1809
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001810 def test_patch_gerrit_new_branch(self):
1811 self._patch_common(
1812 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1813 self.calls += [
1814 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1815 'refs/changes/56/123456/7'],), ''),
1816 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1817 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1818 ''),
1819 ((['git', 'config', 'branch.master.gerritserver',
1820 'https://chromium-review.googlesource.com'],), ''),
1821 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1822 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1823 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1824 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1825 ]
1826 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1827
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001828 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001829 self._patch_common(
1830 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001831 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001832 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001833 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001834 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001835 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001836 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001837 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001838 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001839 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001840 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1841 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1842 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001843 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001844 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001845
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001846 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001847 self.calls += self._get_gerrit_codereview_server_calls(
1848 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001849 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001850 actual_codereview='gerrit', git_short_host='else',
1851 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001852 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001853 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001854 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001855 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001856 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001857 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001858 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001859 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001860 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001861 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1862 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1863 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001864 ]
1865 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001866 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001867
Aaron Gable697a91b2018-01-19 15:20:15 -08001868 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001869 self.calls += self._get_gerrit_codereview_server_calls(
1870 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001871 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001872 actual_codereview='gerrit', git_short_host='else',
1873 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001874 self.calls += [
1875 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1876 'refs/changes/56/123456/1'],), ''),
1877 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1878 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1879 ''),
1880 ((['git', 'config', 'branch.master.gerritserver',
1881 'https://else-review.googlesource.com'],), ''),
1882 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1883 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1884 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1885 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1886 ]
1887 self.assertEqual(git_cl.main(
1888 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1889 0)
1890
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001891 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001892 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001893 self.calls += [
1894 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001895 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001896 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1897 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1898 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001899 ]
1900 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001901 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001902
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001903 def test_patch_gerrit_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001904 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001905 raise git_cl.gerrit_util.GerritError(404, '')
1906 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1907
tandriic2405f52016-10-10 08:13:15 -07001908 self.calls = [
1909 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandriic2405f52016-10-10 08:13:15 -07001910 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001911 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1912 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1913 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1914 ((['git', 'config', 'remote.origin.url'],),
1915 'https://chromium.googlesource.com/my/repo'),
1916 ((['DieWithError',
1917 'change 123456 at https://chromium-review.googlesource.com does not '
1918 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001919 ]
1920 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001921 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001922
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001923 def _checkout_calls(self):
1924 return [
1925 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001926 'branch\\..*\\.gerritissue'], ),
1927 ('branch.ger-branch.gerritissue 123456\n'
1928 'branch.gbranch654.gerritissue 654321\n')),
1929 ]
1930
1931 def test_checkout_gerrit(self):
1932 """Tests git cl checkout <issue>."""
1933 self.calls = self._checkout_calls()
1934 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1935 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1936
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001937 def test_checkout_not_found(self):
1938 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001939 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001940 self.calls = self._checkout_calls()
1941 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1942
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001943 def test_checkout_no_branch_issues(self):
1944 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001945 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001946 self.calls = [
1947 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001948 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001949 ]
1950 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1951
tandrii@chromium.org28253532016-04-14 13:46:56 +00001952 def _test_gerrit_ensure_authenticated_common(self, auth,
1953 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001954 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1955 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1956 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001957 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001958 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001959 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00001960 cl.branch = 'master'
1961 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001962 cl.lookedup_issue = True
1963 return cl
1964
1965 def test_gerrit_ensure_authenticated_missing(self):
1966 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001967 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001968 })
1969 self.calls.append(
1970 ((['DieWithError',
1971 'Credentials for the following hosts are required:\n'
1972 ' chromium-review.googlesource.com\n'
1973 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01001974 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001975 'https://chromium-review.googlesource.com/new-password'],), ''),)
1976 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1977
1978 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001979 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001980 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001981 'chromium.googlesource.com':
1982 ('git-one.example.com', None, 'secret1'),
1983 'chromium-review.googlesource.com':
1984 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001985 })
1986 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001987 (('ask_for_data', 'If you know what you are doing '
1988 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001989 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1990
1991 def test_gerrit_ensure_authenticated_ok(self):
1992 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001993 'chromium.googlesource.com':
1994 ('git-same.example.com', None, 'secret'),
1995 'chromium-review.googlesource.com':
1996 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001997 })
1998 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1999
tandrii@chromium.org28253532016-04-14 13:46:56 +00002000 def test_gerrit_ensure_authenticated_skipped(self):
2001 cl = self._test_gerrit_ensure_authenticated_common(
2002 auth={}, skip_auth_check=True)
2003 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2004
Eric Boren2fb63102018-10-05 13:05:03 +00002005 def test_gerrit_ensure_authenticated_bearer_token(self):
2006 cl = self._test_gerrit_ensure_authenticated_common(auth={
2007 'chromium.googlesource.com':
2008 ('', None, 'secret'),
2009 'chromium-review.googlesource.com':
2010 ('', None, 'secret'),
2011 })
2012 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2013 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2014 'chromium.googlesource.com')
2015 self.assertTrue('Bearer' in header)
2016
Daniel Chengcf6269b2019-05-18 01:02:12 +00002017 def test_gerrit_ensure_authenticated_non_https(self):
2018 self.calls = [
2019 ((['git', 'config', '--bool',
2020 'gerrit.skip-ensure-authenticated'],), CERR1),
2021 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2022 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2023 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
2024 ]
2025 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2026 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
2027 cl = git_cl.Changelist(codereview='gerrit')
2028 cl.branch = 'master'
2029 cl.branchref = 'refs/heads/master'
2030 cl.lookedup_issue = True
2031 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2032
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002033 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002034 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002035 lambda h, i, labels, notify=None:
2036 self._mocked_call(['SetReview', h, i, labels, notify]))
2037
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002038 self.calls = [
2039 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002040 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002041 ((['git', 'config', 'branch.feature.gerritserver'],),
2042 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002043 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2044 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2045 ((['git', 'config', 'remote.origin.url'],),
2046 'https://chromium.googlesource.com/infra/infra.git'),
2047 ((['SetReview', 'chromium-review.googlesource.com',
2048 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002049 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002050 ]
tandriid9e5ce52016-07-13 02:32:59 -07002051
2052 def test_cmd_set_commit_gerrit_clear(self):
2053 self._cmd_set_commit_gerrit_common(0)
2054 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2055
2056 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002057 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002058 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2059
tandriid9e5ce52016-07-13 02:32:59 -07002060 def test_cmd_set_commit_gerrit(self):
2061 self._cmd_set_commit_gerrit_common(2)
2062 self.assertEqual(0, git_cl.main(['set-commit']))
2063
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002064 def test_description_display(self):
2065 out = StringIO.StringIO()
2066 self.mock(git_cl.sys, 'stdout', out)
2067
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002068 self.mock(git_cl, 'Changelist', ChangelistMock)
2069 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002070
2071 self.assertEqual(0, git_cl.main(['description', '-d']))
2072 self.assertEqual('foo\n', out.getvalue())
2073
iannucci3c972b92016-08-17 13:24:10 -07002074 def test_StatusFieldOverrideIssueMissingArgs(self):
2075 out = StringIO.StringIO()
2076 self.mock(git_cl.sys, 'stderr', out)
2077
2078 try:
2079 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2080 except SystemExit as ex:
2081 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002082 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002083
2084 out = StringIO.StringIO()
2085 self.mock(git_cl.sys, 'stderr', out)
2086
2087 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002088 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002089 except SystemExit as ex:
2090 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002091 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002092
2093 def test_StatusFieldOverrideIssue(self):
2094 out = StringIO.StringIO()
2095 self.mock(git_cl.sys, 'stdout', out)
2096
2097 def assertIssue(cl_self, *_args):
2098 self.assertEquals(cl_self.issue, 1)
2099 return 'foobar'
2100
2101 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002102 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002103 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002104 0)
iannucci3c972b92016-08-17 13:24:10 -07002105 self.assertEqual(out.getvalue(), 'foobar\n')
2106
iannuccie53c9352016-08-17 14:40:40 -07002107 def test_SetCloseOverrideIssue(self):
2108 def assertIssue(cl_self, *_args):
2109 self.assertEquals(cl_self.issue, 1)
2110 return 'foobar'
2111
2112 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2113 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002114 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002115 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002116
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002117 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002118 out = StringIO.StringIO()
2119 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002120 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002121 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2122 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2123 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2124 ((['git', 'config', 'remote.origin.url'],),
2125 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002126 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002127 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002128 {
2129 'current_revision': 'sha1',
2130 'revisions': {'sha1': {
2131 'commit': {'message': 'foobar'},
2132 }},
2133 }),
2134 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002135 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002136 'description',
2137 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2138 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002139 self.assertEqual('foobar\n', out.getvalue())
2140
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002141 def test_description_set_raw(self):
2142 out = StringIO.StringIO()
2143 self.mock(git_cl.sys, 'stdout', out)
2144
2145 self.mock(git_cl, 'Changelist', ChangelistMock)
2146 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2147
2148 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2149 self.assertEqual('hihi', ChangelistMock.desc)
2150
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002151 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002152 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002153
2154 def RunEditor(desc, _, **kwargs):
2155 self.assertEquals(
2156 '# Enter a description of the change.\n'
2157 '# This will be displayed on the codereview site.\n'
2158 '# The first line will also be used as the subject of the review.\n'
2159 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002160 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002161 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002162 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002163 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002164 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002165
dsansomee2d6fd92016-09-08 00:10:47 -07002166 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002167 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002168
2169 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2170 self.mock(git_cl.Changelist, 'GetDescription',
2171 lambda *args: current_desc)
2172 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2173 UpdateDescriptionRemote)
2174 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2175
2176 self.calls = [
2177 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002178 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002179 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2180 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002181 ((['git', 'config', 'core.editor'],), 'vi'),
2182 ]
2183 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2184
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002185 def test_description_set_stdin(self):
2186 out = StringIO.StringIO()
2187 self.mock(git_cl.sys, 'stdout', out)
2188
2189 self.mock(git_cl, 'Changelist', ChangelistMock)
2190 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2191
2192 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2193 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2194
kmarshall3bff56b2016-06-06 18:31:47 -07002195 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002196 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2197
kmarshall3bff56b2016-06-06 18:31:47 -07002198 self.calls = \
2199 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2200 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002201 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2202 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
tandrii33a46ff2016-08-23 05:53:40 -07002203 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002204 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2205 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2206 ((['git', 'branch', '-D', 'foo'],), '')]
2207
kmarshall3bff56b2016-06-06 18:31:47 -07002208 self.mock(git_cl, 'get_cl_statuses',
2209 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002210 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2211 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2212 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002213
2214 self.assertEqual(0, git_cl.main(['archive', '-f']))
2215
2216 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002217 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002218 self.calls = \
2219 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2220 'refs/heads/master'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002221 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
kmarshall3bff56b2016-06-06 18:31:47 -07002222 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2223
kmarshall9249e012016-08-23 12:02:16 -07002224 self.mock(git_cl, 'get_cl_statuses',
2225 lambda branches, fine_grained, max_processes:
2226 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2227
2228 self.assertEqual(1, git_cl.main(['archive', '-f']))
2229
2230 def test_archive_dry_run(self):
2231 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2232
2233 self.calls = \
2234 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2235 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002236 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2237 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002238 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2239 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002240
2241 self.mock(git_cl, 'get_cl_statuses',
2242 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002243 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2244 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2245 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002246
kmarshall9249e012016-08-23 12:02:16 -07002247 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2248
2249 def test_archive_no_tags(self):
2250 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2251
2252 self.calls = \
2253 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2254 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002255 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
2256 ((['git', 'config', 'branch.foo.gerritissue'],), '456'),
2257 ((['git', 'config', 'branch.bar.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002258 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2259 ((['git', 'branch', '-D', 'foo'],), '')]
2260
2261 self.mock(git_cl, 'get_cl_statuses',
2262 lambda branches, fine_grained, max_processes:
2263 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2264 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2265 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2266
2267 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002268
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002269 def test_cmd_issue_erase_existing(self):
2270 out = StringIO.StringIO()
2271 self.mock(git_cl.sys, 'stdout', out)
2272 self.calls = [
2273 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002274 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002275 # Let this command raise exception (retcode=1) - it should be ignored.
2276 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002277 CERR1),
2278 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2279 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002280 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2281 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2282 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002283 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002284 ]
2285 self.assertEqual(0, git_cl.main(['issue', '0']))
2286
Aaron Gable400e9892017-07-12 15:31:21 -07002287 def test_cmd_issue_erase_existing_with_change_id(self):
2288 out = StringIO.StringIO()
2289 self.mock(git_cl.sys, 'stdout', out)
2290 self.mock(git_cl.Changelist, 'GetDescription',
2291 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2292 self.calls = [
2293 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002294 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
Aaron Gable400e9892017-07-12 15:31:21 -07002295 # Let this command raise exception (retcode=1) - it should be ignored.
2296 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2297 CERR1),
2298 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2299 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2300 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2301 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2302 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002303 ((['git', 'log', '-1', '--format=%B'],),
2304 'This is a description\n\nChange-Id: Ideadbeef'),
2305 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002306 ]
2307 self.assertEqual(0, git_cl.main(['issue', '0']))
2308
phajdan.jre328cf92016-08-22 04:12:17 -07002309 def test_cmd_issue_json(self):
2310 out = StringIO.StringIO()
2311 self.mock(git_cl.sys, 'stdout', out)
2312 self.calls = [
2313 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002314 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2315 ((['git', 'config', 'branch.feature.gerritserver'],),
2316 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002317 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002318 {'issue': 123,
2319 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002320 ''),
2321 ]
2322 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2323
tandrii8c5a3532016-11-04 07:52:02 -07002324 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2325 self.mock(git_cl.Changelist, 'GetChange',
2326 lambda _, *a: (
2327 self._mocked_call(['GetChange']+list(a))))
2328 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2329 lambda *_, **__: (
2330 self._mocked_call(['DoGetTryMasters'])))
2331 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2332 lambda _, s: self._mocked_call(['SetCQState', s]))
2333
tandrii8c5a3532016-11-04 07:52:02 -07002334 self.calls = [
2335 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002336 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2337 ((['git', 'config', 'branch.feature.gerritserver'],),
2338 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002339 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2340 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2341 ((['git', 'config', 'remote.origin.url'],),
2342 'https://chromium.googlesource.com/depot_tools'),
2343 (('GetChangeDetail', 'chromium-review.googlesource.com',
2344 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002345 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2346 'project': 'depot_tools',
2347 'status': 'OPEN',
2348 'owner': {'email': 'owner@e.mail'},
2349 'revisions': {
2350 'deadbeaf': {
2351 '_number': 6,
2352 },
2353 'beeeeeef': {
2354 '_number': 7,
2355 'fetch': {'http': {
2356 'url': 'https://chromium.googlesource.com/depot_tools',
2357 'ref': 'refs/changes/56/123456/7'
2358 }},
2359 },
2360 },
2361 }),
tandrii8c5a3532016-11-04 07:52:02 -07002362 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2363 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2364 ((['get_or_create_merge_base', 'feature', 'feature'],),
2365 'fake_ancestor_sha'),
2366 ((['GetChange', 'fake_ancestor_sha', None], ),
2367 git_cl.presubmit_support.GitChange(
2368 '', '', '', '', '', '', '', '')),
2369 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2370 ((['DoGetTryMasters'], ), None),
2371 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2372 ]
2373 out = StringIO.StringIO()
2374 self.mock(git_cl.sys, 'stdout', out)
2375 self.assertEqual(0, git_cl.main(['try']))
2376 self.assertEqual(
2377 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002378 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002379 'https://chromium-review.googlesource.com/123456\n')
2380
tandrii8c5a3532016-11-04 07:52:02 -07002381 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2382 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2383 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2384
tandrii8c5a3532016-11-04 07:52:02 -07002385 self.calls = [
2386 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002387 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2388 ((['git', 'config', 'branch.feature.gerritserver'],),
2389 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002390 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2391 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2392 ((['git', 'config', 'remote.origin.url'],),
2393 'https://chromium.googlesource.com/depot_tools'),
2394 (('GetChangeDetail', 'chromium-review.googlesource.com',
2395 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002396 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002397 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002398 'status': 'OPEN',
2399 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002400 'revisions': {
2401 'deadbeaf': {
2402 '_number': 6,
2403 },
2404 'beeeeeef': {
2405 '_number': 7,
2406 'fetch': {'http': {
2407 'url': 'https://chromium.googlesource.com/depot_tools',
2408 'ref': 'refs/changes/56/123456/7'
2409 }},
2410 },
2411 },
2412 }),
2413 ]
2414
2415 def _buildbucket_retry(*_, **kw):
2416 # self.maxDiff = 10000
2417 body = json.loads(kw['body'])
2418 self.assertEqual(len(body['builds']), 1)
2419 build = body['builds'][0]
2420 params = json.loads(build.pop('parameters_json'))
2421 self.assertEqual(params, {
2422 u'builder_name': u'win',
2423 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2424 u'revision': None}],
2425 u'properties': {
2426 u'category': u'git_cl_try',
2427 u'key': u'val',
2428 u'json': [{u'a': 1}, None],
tandrii8c5a3532016-11-04 07:52:02 -07002429
2430 u'patch_gerrit_url':
2431 u'https://chromium-review.googlesource.com',
2432 u'patch_issue': 123456,
2433 u'patch_project': u'depot_tools',
2434 u'patch_ref': u'refs/changes/56/123456/7',
2435 u'patch_repository_url':
2436 u'https://chromium.googlesource.com/depot_tools',
2437 u'patch_set': 7,
2438 u'patch_storage': u'gerrit',
2439 }
2440 })
2441 self.assertEqual(build, {
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002442 u'bucket': u'luci.chromium.try',
tandrii8c5a3532016-11-04 07:52:02 -07002443 u'client_operation_id': u'uuid4',
2444 u'tags': [
2445 u'builder:win',
2446 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2447 u'user_agent:git_cl_try',
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002448 ],
tandrii8c5a3532016-11-04 07:52:02 -07002449 })
2450
2451 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2452
2453 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2454 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002455 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002456 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2457 self.assertRegexpMatches(
2458 git_cl.sys.stdout.getvalue(),
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002459 'Tried jobs on:\nBucket: luci.chromium.try')
tandriide281ae2016-10-12 06:02:30 -07002460
qyearsley123a4682016-10-26 09:12:17 -07002461 def test_git_cl_try_bots_on_multiple_masters(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002462 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2463 self.mock(git_cl.Changelist, 'GetChange',
2464 lambda _, *a: (
2465 self._mocked_call(['GetChange']+list(a))))
2466 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2467 lambda *_, **__: (
2468 self._mocked_call(['DoGetTryMasters'])))
2469 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2470 lambda _, s: self._mocked_call(['SetCQState', s]))
2471
qyearsley123a4682016-10-26 09:12:17 -07002472 self.calls = [
2473 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002474 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2475 ((['git', 'config', 'branch.feature.gerritserver'],),
2476 'https://chromium-review.googlesource.com'),
2477 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2478 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2479 ((['git', 'config', 'remote.origin.url'],),
2480 'https://chromium.googlesource.com/depot_tools'),
2481 (('GetChangeDetail', 'chromium-review.googlesource.com',
2482 'depot_tools~123456',
2483 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2484 'project': 'depot_tools',
2485 'status': 'OPEN',
2486 'owner': {'email': 'owner@e.mail'},
2487 'revisions': {
2488 'deadbeaf': {
2489 '_number': 6,
2490 },
2491 'beeeeeef': {
2492 '_number': 7,
2493 'fetch': {'http': {
2494 'url': 'https://chromium.googlesource.com/depot_tools',
2495 'ref': 'refs/changes/56/123456/7'
2496 }},
2497 },
2498 },
2499 }),
qyearsley123a4682016-10-26 09:12:17 -07002500 ]
2501
2502 def _buildbucket_retry(*_, **kw):
2503 body = json.loads(kw['body'])
2504 self.assertEqual(len(body['builds']), 2)
2505
Nodir Turakulovb422e682018-02-20 22:51:30 -08002506 self.assertEqual(body['builds'][0]['bucket'], 'bucket1')
2507 params = json.loads(body['builds'][0]['parameters_json'])
2508 self.assertEqual(params['builder_name'], 'builder1')
qyearsley123a4682016-10-26 09:12:17 -07002509
Nodir Turakulovb422e682018-02-20 22:51:30 -08002510 self.assertEqual(body['builds'][1]['bucket'], 'bucket2')
2511 params = json.loads(body['builds'][1]['parameters_json'])
2512 self.assertEqual(params['builder_name'], 'builder2')
qyearsley123a4682016-10-26 09:12:17 -07002513
2514 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2515
2516 self.mock(git_cl.urllib2, 'urlopen', lambda _: StringIO.StringIO(
Nodir Turakulovb422e682018-02-20 22:51:30 -08002517 json.dumps({
2518 'builder1': {'bucket': 'bucket1'},
2519 'builder2': {'bucket': 'bucket2'},
2520 })))
qyearsley123a4682016-10-26 09:12:17 -07002521
2522 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2523 self.assertEqual(
2524 0, git_cl.main(['try', '-b', 'builder1', '-b', 'builder2']))
2525 self.assertEqual(
2526 git_cl.sys.stdout.getvalue(),
2527 'Tried jobs on:\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002528 'Bucket: bucket1\n'
qyearsley123a4682016-10-26 09:12:17 -07002529 ' builder1: []\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002530 'Bucket: bucket2\n'
qyearsley123a4682016-10-26 09:12:17 -07002531 ' builder2: []\n'
2532 'To see results here, run: git cl try-results\n'
2533 'To see results in browser, run: git cl web\n')
2534
tandrii16e0b4e2016-06-07 10:34:28 -07002535 def _common_GerritCommitMsgHookCheck(self):
2536 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2537 self.mock(git_cl.os.path, 'abspath',
2538 lambda path: self._mocked_call(['abspath', path]))
2539 self.mock(git_cl.os.path, 'exists',
2540 lambda path: self._mocked_call(['exists', path]))
2541 self.mock(git_cl.gclient_utils, 'FileRead',
2542 lambda path: self._mocked_call(['FileRead', path]))
2543 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2544 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2545 self.calls = [
2546 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2547 ((['abspath', '../'],), '/abs/git_repo_root'),
2548 ]
2549 return git_cl.Changelist(codereview='gerrit', issue=123)
2550
2551 def test_GerritCommitMsgHookCheck_custom_hook(self):
2552 cl = self._common_GerritCommitMsgHookCheck()
2553 self.calls += [
2554 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2555 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2556 '#!/bin/sh\necho "custom hook"')
2557 ]
2558 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2559
2560 def test_GerritCommitMsgHookCheck_not_exists(self):
2561 cl = self._common_GerritCommitMsgHookCheck()
2562 self.calls += [
2563 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2564 ]
2565 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2566
2567 def test_GerritCommitMsgHookCheck(self):
2568 cl = self._common_GerritCommitMsgHookCheck()
2569 self.calls += [
2570 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2571 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2572 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002573 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002574 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2575 ''),
2576 ]
2577 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2578
tandriic4344b52016-08-29 06:04:54 -07002579 def test_GerritCmdLand(self):
2580 self.calls += [
2581 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2582 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2583 'deadbeaf'),
2584 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2585 ((['git', 'config', 'branch.feature.gerritserver'],),
2586 'chromium-review.googlesource.com'),
2587 ]
2588 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2589 cl._codereview_impl._GetChangeDetail = lambda _: {
2590 'labels': {},
2591 'current_revision': 'deadbeaf',
2592 }
agable32978d92016-11-01 12:55:02 -07002593 cl._codereview_impl._GetChangeCommit = lambda: {
2594 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002595 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002596 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2597 }
tandriic4344b52016-08-29 06:04:54 -07002598 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002599 out = StringIO.StringIO()
2600 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002601 self.assertEqual(0, cl.CMDLand(force=True,
2602 bypass_hooks=True,
2603 verbose=True,
2604 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002605 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002606 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002607
tandrii221ab252016-10-06 08:12:04 -07002608 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002609 '9000': {
2610 'id': '9000',
2611 'bucket': 'master.x.y',
2612 'created_by': 'user:someone@chromium.org',
2613 'created_ts': '147200002222000',
2614 'experimental': False,
2615 'parameters_json': json.dumps({
2616 'builder_name': 'my-bot',
2617 'properties': {'category': 'cq'},
2618 }),
2619 'status': 'STARTED',
2620 'tags': [
2621 'build_address:x.y/my-bot/2',
2622 'builder:my-bot',
2623 'experimental:false',
2624 'user_agent:cq',
2625 ],
2626 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2627 },
2628 '8000': {
2629 'id': '8000',
2630 'bucket': 'master.x.y',
2631 'created_by': 'user:someone@chromium.org',
2632 'created_ts': '147200001111000',
2633 'experimental': False,
2634 'failure_reason': 'BUILD_FAILURE',
2635 'parameters_json': json.dumps({
2636 'builder_name': 'my-bot',
2637 'properties': {'category': 'cq'},
2638 }),
2639 'result_details_json': json.dumps({
2640 'properties': {'buildnumber': 1},
2641 }),
2642 'result': 'FAILURE',
2643 'status': 'COMPLETED',
2644 'tags': [
2645 'build_address:x.y/my-bot/1',
2646 'builder:my-bot',
2647 'experimental:false',
2648 'user_agent:cq',
2649 ],
2650 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2651 },
2652 }
tandrii221ab252016-10-06 08:12:04 -07002653
2654 def test_write_try_results_json(self):
2655 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002656 {
2657 'bucket': 'master.x.y',
2658 'buildbucket_id': '8000',
2659 'builder_name': 'my-bot',
2660 'created_ts': '147200001111000',
2661 'experimental': False,
2662 'failure_reason': 'BUILD_FAILURE',
2663 'result': 'FAILURE',
2664 'status': 'COMPLETED',
2665 'tags': [
2666 'build_address:x.y/my-bot/1',
2667 'builder:my-bot',
2668 'experimental:false',
2669 'user_agent:cq',
2670 ],
2671 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2672 },
2673 {
2674 'bucket': 'master.x.y',
2675 'buildbucket_id': '9000',
2676 'builder_name': 'my-bot',
2677 'created_ts': '147200002222000',
2678 'experimental': False,
2679 'failure_reason': None,
2680 'result': None,
2681 'status': 'STARTED',
2682 'tags': [
2683 'build_address:x.y/my-bot/2',
2684 'builder:my-bot',
2685 'experimental:false',
2686 'user_agent:cq',
2687 ],
2688 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2689 },
tandrii221ab252016-10-06 08:12:04 -07002690 ]
2691 self.calls = [(('write_json', 'output.json', expected_output), '')]
2692 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2693
tandrii45b2a582016-10-11 03:14:16 -07002694 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002695 out = StringIO.StringIO()
2696 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002697 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2698 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002699 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2700 self._mocked_call(['get_authenticator_for_host', host]))
2701 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2702 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002703
tandrii45b2a582016-10-11 03:14:16 -07002704 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2705 self._setup_fetch_try_jobs(most_recent_patchset=13)
2706 self.calls += [
2707 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii45b2a582016-10-11 03:14:16 -07002708 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002709 # TODO(tandrii): Uncomment the below if we decide to support checking
2710 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002711 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002712 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002713 ((['git', 'config', 'branch.feature.gerritserver'],),
2714 'https://x-review.googlesource.com'),
2715 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2716 AuthenticatorMock()),
2717 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2718
2719 def test_fetch_try_jobs_none_gerrit(self):
2720 self._setup_fetch_try_jobs_gerrit({})
2721 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002722 # TODO(tandrii): Uncomment the below if we decide to support checking
2723 # patchsets for Gerrit.
2724 # self.assertRegexpMatches(
2725 # sys.stdout.getvalue(),
2726 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07002727 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2728
2729 def test_fetch_try_jobs_some_gerrit(self):
2730 self._setup_fetch_try_jobs_gerrit({
2731 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2732 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002733 # TODO(tandrii): Uncomment the below if we decide to support checking
2734 # patchsets for Gerrit.
2735 # self.calls.remove(
2736 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002737 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2738
2739 # ... and doesn't result in warning.
2740 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2741 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002742 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2743 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2744
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002745 def _mock_gerrit_changes_for_detail_cache(self):
2746 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002747
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002748 def test_gerrit_change_detail_cache_simple(self):
2749 self._mock_gerrit_changes_for_detail_cache()
2750 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002751 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2752 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2753 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002754 ]
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002755 cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002756 cl1._cached_remote_url = (
2757 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002758 cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002759 cl2._cached_remote_url = (
2760 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002761 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2762 self.assertEqual(cl1._GetChangeDetail(), 'a')
2763 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2764 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2765 self.assertEqual(cl1._GetChangeDetail(), 'a')
2766 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002767
2768 def test_gerrit_change_detail_cache_options(self):
2769 self._mock_gerrit_changes_for_detail_cache()
2770 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002771 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2772 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2773 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2774 # no longer in cache.
2775 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002776 ]
2777 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002778 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002779 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2780 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2781 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2782 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2783 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2784 self.assertEqual(cl._GetChangeDetail(), 'cab')
2785
2786 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2787 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2788 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2789 self.assertEqual(cl._GetChangeDetail(), 'cab')
2790
2791 # Finally, no_cache should invalidate all caches for given change.
2792 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2793 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2794
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002795 def test_gerrit_description_caching(self):
2796 def gen_detail(rev, desc):
2797 return {
2798 'current_revision': rev,
2799 'revisions': {rev: {'commit': {'message': desc}}}
2800 }
2801 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002802 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002803 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2804 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002805 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002806 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2807 gen_detail('rev2', 'desc2')),
2808 ]
2809
2810 self._mock_gerrit_changes_for_detail_cache()
2811 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002812 cl._cached_remote_url = (
2813 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002814 self.assertEqual(cl.GetDescription(), 'desc1')
2815 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2816 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002817
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002818 def test_print_current_creds(self):
2819 class CookiesAuthenticatorMock(object):
2820 def __init__(self):
2821 self.gitcookies = {
2822 'host.googlesource.com': ('user', 'pass'),
2823 'host-review.googlesource.com': ('user', 'pass'),
2824 }
2825 self.netrc = self
2826 self.netrc.hosts = {
2827 'github.com': ('user2', None, 'pass2'),
2828 'host2.googlesource.com': ('user3', None, 'pass'),
2829 }
2830 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2831 CookiesAuthenticatorMock)
2832 self.mock(sys, 'stdout', StringIO.StringIO())
2833 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2834 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2835 ' Host\t User\t Which file',
2836 '============================\t=====\t===========',
2837 'host-review.googlesource.com\t user\t.gitcookies',
2838 ' host.googlesource.com\t user\t.gitcookies',
2839 ' host2.googlesource.com\tuser3\t .netrc',
2840 ])
2841 sys.stdout.buf = ''
2842 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2843 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2844 ' Host\tUser\t Which file',
2845 '============================\t====\t===========',
2846 'host-review.googlesource.com\tuser\t.gitcookies',
2847 ' host.googlesource.com\tuser\t.gitcookies',
2848 ])
2849
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002850 def _common_creds_check_mocks(self):
2851 def exists_mock(path):
2852 dirname = os.path.dirname(path)
2853 if dirname == os.path.expanduser('~'):
2854 dirname = '~'
2855 base = os.path.basename(path)
2856 if base in ('.netrc', '.gitcookies'):
2857 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2858 # git cl also checks for existence other files not relevant to this test.
2859 return None
2860 self.mock(os.path, 'exists', exists_mock)
2861 self.mock(sys, 'stdout', StringIO.StringIO())
2862
2863 def test_creds_check_gitcookies_not_configured(self):
2864 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002865 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002866 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002867 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002868 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002869 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2870 (('os.path.exists', '~/.netrc'), True),
2871 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2872 'or Ctrl+C to abort'), ''),
2873 ((['git', 'config', '--global', 'http.cookiefile',
2874 os.path.expanduser('~/.gitcookies')], ), ''),
2875 ]
2876 self.assertEqual(0, git_cl.main(['creds-check']))
2877 self.assertRegexpMatches(
2878 sys.stdout.getvalue(),
2879 '^You seem to be using outdated .netrc for git credentials:')
2880 self.assertRegexpMatches(
2881 sys.stdout.getvalue(),
2882 '\nConfigured git to use .gitcookies from')
2883
2884 def test_creds_check_gitcookies_configured_custom_broken(self):
2885 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002886 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002887 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002888 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002889 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002890 ((['git', 'config', '--global', 'http.cookiefile'],),
2891 '/custom/.gitcookies'),
2892 (('os.path.exists', '/custom/.gitcookies'), False),
2893 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2894 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2895 ((['git', 'config', '--global', 'http.cookiefile',
2896 os.path.expanduser('~/.gitcookies')], ), ''),
2897 ]
2898 self.assertEqual(0, git_cl.main(['creds-check']))
2899 self.assertRegexpMatches(
2900 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002901 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002902 self.assertRegexpMatches(
2903 sys.stdout.getvalue(),
2904 'However, your configured .gitcookies file is missing.')
2905
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002906 def test_git_cl_comment_add_gerrit(self):
2907 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002908 lambda host, change, msg, ready:
2909 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002910 self.calls = [
2911 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2912 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2913 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2914 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2915 'origin/master'),
2916 ((['git', 'config', 'remote.origin.url'],),
2917 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002918 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2919 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002920 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002921 ]
2922 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2923 '-a', 'msg']))
2924
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002925 def test_git_cl_comments_fetch_gerrit(self):
2926 self.mock(sys, 'stdout', StringIO.StringIO())
2927 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002928 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2929 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002930 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2931 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2932 'origin/master'),
2933 ((['git', 'config', 'remote.origin.url'],),
2934 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002935 (('GetChangeDetail', 'chromium-review.googlesource.com',
2936 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002937 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2938 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002939 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002940 'current_revision': 'ba5eba11',
2941 'revisions': {
2942 'deadbeaf': {
2943 '_number': 1,
2944 },
2945 'ba5eba11': {
2946 '_number': 2,
2947 },
2948 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002949 'messages': [
2950 {
2951 u'_revision_number': 1,
2952 u'author': {
2953 u'_account_id': 1111084,
2954 u'email': u'commit-bot@chromium.org',
2955 u'name': u'Commit Bot'
2956 },
2957 u'date': u'2017-03-15 20:08:45.000000000',
2958 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002959 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002960 u'tag': u'autogenerated:cq:dry-run'
2961 },
2962 {
2963 u'_revision_number': 2,
2964 u'author': {
2965 u'_account_id': 11151243,
2966 u'email': u'owner@example.com',
2967 u'name': u'owner'
2968 },
2969 u'date': u'2017-03-16 20:00:41.000000000',
2970 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2971 u'message': u'PTAL',
2972 },
2973 {
2974 u'_revision_number': 2,
2975 u'author': {
2976 u'_account_id': 148512 ,
2977 u'email': u'reviewer@example.com',
2978 u'name': u'reviewer'
2979 },
2980 u'date': u'2017-03-17 05:19:37.500000000',
2981 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2982 u'message': u'Patch Set 2: Code-Review+1',
2983 },
2984 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002985 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002986 (('GetChangeComments', 'chromium-review.googlesource.com',
2987 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002988 '/COMMIT_MSG': [
2989 {
2990 'author': {'email': u'reviewer@example.com'},
2991 'updated': u'2017-03-17 05:19:37.500000000',
2992 'patch_set': 2,
2993 'side': 'REVISION',
2994 'message': 'Please include a bug link',
2995 },
2996 ],
2997 'codereview.settings': [
2998 {
2999 'author': {'email': u'owner@example.com'},
3000 'updated': u'2017-03-16 20:00:41.000000000',
3001 'patch_set': 2,
3002 'side': 'PARENT',
3003 'line': 42,
3004 'message': 'I removed this because it is bad',
3005 },
3006 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003007 }),
3008 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
3009 'infra%2Finfra~1'), {}),
3010 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00003011 ] * 2 + [
3012 (('write_json', 'output.json', [
3013 {
3014 u'date': u'2017-03-16 20:00:41.000000',
3015 u'message': (
3016 u'PTAL\n' +
3017 u'\n' +
3018 u'codereview.settings\n' +
3019 u' Base, Line 42: https://chromium-review.googlesource.com/' +
3020 u'c/1/2/codereview.settings#b42\n' +
3021 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003022 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00003023 u'approval': False,
3024 u'disapproval': False,
3025 u'sender': u'owner@example.com'
3026 }, {
3027 u'date': u'2017-03-17 05:19:37.500000',
3028 u'message': (
3029 u'Patch Set 2: Code-Review+1\n' +
3030 u'\n' +
3031 u'/COMMIT_MSG\n' +
3032 u' PS2, File comment: https://chromium-review.googlesource' +
3033 u'.com/c/1/2//COMMIT_MSG#\n' +
3034 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003035 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00003036 u'approval': False,
3037 u'disapproval': False,
3038 u'sender': u'reviewer@example.com'
3039 }
3040 ]),'')
3041 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003042 expected_comments_summary = [
3043 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003044 message=(
3045 u'PTAL\n' +
3046 u'\n' +
3047 u'codereview.settings\n' +
3048 u' Base, Line 42: https://chromium-review.googlesource.com/' +
3049 u'c/1/2/codereview.settings#b42\n' +
3050 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003051 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003052 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003053 disapproval=False, approval=False, sender=u'owner@example.com'),
3054 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003055 message=(
3056 u'Patch Set 2: Code-Review+1\n' +
3057 u'\n' +
3058 u'/COMMIT_MSG\n' +
3059 u' PS2, File comment: https://chromium-review.googlesource.com/' +
3060 u'c/1/2//COMMIT_MSG#\n' +
3061 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003062 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003063 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003064 disapproval=False, approval=False, sender=u'reviewer@example.com'),
3065 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003066 cl = git_cl.Changelist(
3067 codereview='gerrit', issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003068 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003069 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
3070 self.assertEqual(
3071 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
3072
3073 def test_git_cl_comments_robot_comments(self):
3074 # git cl comments also fetches robot comments (which are considered a type
3075 # of autogenerated comment), and unlike other types of comments, only robot
3076 # comments from the latest patchset are shown.
3077 self.mock(sys, 'stdout', StringIO.StringIO())
3078 self.calls = [
3079 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
3080 ((['git', 'config', 'branch.foo.merge'],), ''),
3081 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3082 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3083 'origin/master'),
3084 ((['git', 'config', 'remote.origin.url'],),
3085 'https://chromium.googlesource.com/infra/infra'),
3086 (('GetChangeDetail', 'chromium-review.googlesource.com',
3087 'infra%2Finfra~1',
3088 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
3089 'CURRENT_COMMIT']), {
3090 'owner': {'email': 'owner@example.com'},
3091 'current_revision': 'ba5eba11',
3092 'revisions': {
3093 'deadbeaf': {
3094 '_number': 1,
3095 },
3096 'ba5eba11': {
3097 '_number': 2,
3098 },
3099 },
3100 'messages': [
3101 {
3102 u'_revision_number': 1,
3103 u'author': {
3104 u'_account_id': 1111084,
3105 u'email': u'commit-bot@chromium.org',
3106 u'name': u'Commit Bot'
3107 },
3108 u'date': u'2017-03-15 20:08:45.000000000',
3109 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
3110 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
3111 u'tag': u'autogenerated:cq:dry-run'
3112 },
3113 {
3114 u'_revision_number': 1,
3115 u'author': {
3116 u'_account_id': 123,
3117 u'email': u'tricium@serviceaccount.com',
3118 u'name': u'Tricium'
3119 },
3120 u'date': u'2017-03-16 20:00:41.000000000',
3121 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3122 u'message': u'(1 comment)',
3123 u'tag': u'autogenerated:tricium',
3124 },
3125 {
3126 u'_revision_number': 1,
3127 u'author': {
3128 u'_account_id': 123,
3129 u'email': u'tricium@serviceaccount.com',
3130 u'name': u'Tricium'
3131 },
3132 u'date': u'2017-03-16 20:00:41.000000000',
3133 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3134 u'message': u'(1 comment)',
3135 u'tag': u'autogenerated:tricium',
3136 },
3137 {
3138 u'_revision_number': 2,
3139 u'author': {
3140 u'_account_id': 123 ,
3141 u'email': u'tricium@serviceaccount.com',
3142 u'name': u'reviewer'
3143 },
3144 u'date': u'2017-03-17 05:30:37.000000000',
3145 u'tag': u'autogenerated:tricium',
3146 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
3147 u'message': u'(1 comment)',
3148 },
3149 ]
3150 }),
3151 (('GetChangeComments', 'chromium-review.googlesource.com',
3152 'infra%2Finfra~1'), {}),
3153 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
3154 'infra%2Finfra~1'), {
3155 'codereview.settings': [
3156 {
3157 u'author': {u'email': u'tricium@serviceaccount.com'},
3158 u'updated': u'2017-03-17 05:30:37.000000000',
3159 u'robot_run_id': u'5565031076855808',
3160 u'robot_id': u'Linter/Category',
3161 u'tag': u'autogenerated:tricium',
3162 u'patch_set': 2,
3163 u'side': u'REVISION',
3164 u'message': u'Linter warning message text',
3165 u'line': 32,
3166 },
3167 ],
3168 }),
3169 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
3170 ]
3171 expected_comments_summary = [
3172 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
3173 message=(
3174 u'(1 comment)\n\ncodereview.settings\n'
3175 u' PS2, Line 32: https://chromium-review.googlesource.com/'
3176 u'c/1/2/codereview.settings#32\n'
3177 u' Linter warning message text\n'),
3178 sender=u'tricium@serviceaccount.com',
3179 autogenerated=True, approval=False, disapproval=False)
3180 ]
3181 cl = git_cl.Changelist(
3182 codereview='gerrit', issue=1, branchref='refs/heads/foo')
3183 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003184
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003185 def test_get_remote_url_with_mirror(self):
3186 original_os_path_isdir = os.path.isdir
3187 def selective_os_path_isdir_mock(path):
3188 if path == '/cache/this-dir-exists':
3189 return self._mocked_call('os.path.isdir', path)
3190 return original_os_path_isdir(path)
3191 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3192
3193 url = 'https://chromium.googlesource.com/my/repo'
3194 self.calls = [
3195 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3196 ((['git', 'config', 'branch.master.merge'],), 'master'),
3197 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3198 ((['git', 'config', 'remote.origin.url'],),
3199 '/cache/this-dir-exists'),
3200 (('os.path.isdir', '/cache/this-dir-exists'),
3201 True),
3202 # Runs in /cache/this-dir-exists.
3203 ((['git', 'config', 'remote.origin.url'],),
3204 url),
3205 ]
3206 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3207 self.assertEqual(cl.GetRemoteUrl(), url)
3208 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3209
Edward Lemur298f2cf2019-02-22 21:40:39 +00003210 def test_get_remote_url_non_existing_mirror(self):
3211 original_os_path_isdir = os.path.isdir
3212 def selective_os_path_isdir_mock(path):
3213 if path == '/cache/this-dir-doesnt-exist':
3214 return self._mocked_call('os.path.isdir', path)
3215 return original_os_path_isdir(path)
3216 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3217 self.mock(logging, 'error',
3218 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
3219
3220 self.calls = [
3221 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3222 ((['git', 'config', 'branch.master.merge'],), 'master'),
3223 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3224 ((['git', 'config', 'remote.origin.url'],),
3225 '/cache/this-dir-doesnt-exist'),
3226 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3227 False),
3228 (('logging.error',
3229 'Remote "origin" for branch "/cache/this-dir-doesnt-exist" points to'
3230 ' "master", but it doesn\'t exist.'), None),
3231 ]
3232 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3233 self.assertIsNone(cl.GetRemoteUrl())
3234
3235 def test_get_remote_url_misconfigured_mirror(self):
3236 original_os_path_isdir = os.path.isdir
3237 def selective_os_path_isdir_mock(path):
3238 if path == '/cache/this-dir-exists':
3239 return self._mocked_call('os.path.isdir', path)
3240 return original_os_path_isdir(path)
3241 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3242 self.mock(logging, 'error',
3243 lambda *a: self._mocked_call('logging.error', *a))
3244
3245 self.calls = [
3246 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3247 ((['git', 'config', 'branch.master.merge'],), 'master'),
3248 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3249 ((['git', 'config', 'remote.origin.url'],),
3250 '/cache/this-dir-exists'),
3251 (('os.path.isdir', '/cache/this-dir-exists'), True),
3252 # Runs in /cache/this-dir-exists.
3253 ((['git', 'config', 'remote.origin.url'],), ''),
3254 (('logging.error',
3255 'Remote "%(remote)s" for branch "%(branch)s" points to '
3256 '"%(cache_path)s", but it is misconfigured.\n'
3257 '"%(cache_path)s" must be a git repo and must have a remote named '
3258 '"%(remote)s" pointing to the git host.', {
3259 'remote': 'origin',
3260 'cache_path': '/cache/this-dir-exists',
3261 'branch': 'master'}
3262 ), None),
3263 ]
3264 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3265 self.assertIsNone(cl.GetRemoteUrl())
3266
3267
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003268 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003269 self.calls = [
3270 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3271 ((['git', 'config', 'branch.master.merge'],), 'master'),
3272 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3273 ((['git', 'config', 'remote.origin.url'],),
3274 'https://chromium.googlesource.com/a/my/repo.git/'),
3275 ]
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003276 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3277 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3278
3279 def test_gerrit_change_identifier_without_project(self):
3280 self.calls = [
3281 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3282 ((['git', 'config', 'branch.master.merge'],), 'master'),
3283 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3284 ((['git', 'config', 'remote.origin.url'],), CERR1),
3285 ]
3286 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3287 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003288
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003289
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003290if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003291 logging.basicConfig(
3292 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003293 unittest.main()