blob: 8521e71389ee7c4c76cd4cc290d9a8a1d3fd2509 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01009import datetime
tandriide281ae2016-10-12 06:02:30 -070010import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010011import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000012import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
22
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000023import metrics
24# We have to disable monitoring before importing git_cl.
25metrics.DISABLE_METRICS_COLLECTION = True
26
Eric Boren2fb63102018-10-05 13:05:03 +000027import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000028import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000029import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000030import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
65 desc = ""
66 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
skobes6468b902016-10-24 08:45:10 -070086class GitCheckoutMock(object):
87 def __init__(self, *args, **kwargs):
88 pass
89
90 @staticmethod
91 def reset():
92 GitCheckoutMock.conflict = False
93
94 def apply_patch(self, p):
95 if GitCheckoutMock.conflict:
96 raise Exception('failed')
97
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000098
99class WatchlistsMock(object):
100 def __init__(self, _):
101 pass
102 @staticmethod
103 def GetWatchersForPaths(_):
104 return ['joe@example.com']
105
106
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000107class CodereviewSettingsFileMock(object):
108 def __init__(self):
109 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800110 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000111 def read(self):
112 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000113 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000114
115
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000116class AuthenticatorMock(object):
117 def __init__(self, *_args):
118 pass
119 def has_cached_credentials(self):
120 return True
tandrii221ab252016-10-06 08:12:04 -0700121 def authorize(self, http):
122 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000123
124
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100125def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
127
128 Usage:
129 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100130 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000131
132 OR
133 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100134 CookiesAuthenticatorMockFactory(
135 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000136 """
137 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800138 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139 # Intentionally not calling super() because it reads actual cookie files.
140 pass
141 @classmethod
142 def get_gitcookies_path(cls):
143 return '~/.gitcookies'
144 @classmethod
145 def get_netrc_path(cls):
146 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 def _get_auth_for_host(self, host):
148 if same_auth:
149 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000150 return (hosts_with_creds or {}).get(host)
151 return CookiesAuthenticatorMock
152
Aaron Gable9a03ae02017-11-03 11:31:07 -0700153
kmarshall9249e012016-08-23 12:02:16 -0700154class MockChangelistWithBranchAndIssue():
155 def __init__(self, branch, issue):
156 self.branch = branch
157 self.issue = issue
158 def GetBranch(self):
159 return self.branch
160 def GetIssue(self):
161 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162
tandriic2405f52016-10-10 08:13:15 -0700163
164class SystemExitMock(Exception):
165 pass
166
167
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000168class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100169 def test_get_description(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000170 cl = git_cl.Changelist(issue=1, codereview='gerrit',
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100171 codereview_host='host')
172 cl.description = 'x'
173 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800174 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100175 self.assertEquals(cl.GetDescription(), 'x')
176 self.assertEquals(cl.GetDescription(force=True), 'y')
177 self.assertEquals(cl.GetDescription(), 'y')
178
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700179 def test_description_footers(self):
180 cl = git_cl.Changelist(issue=1, codereview='gerrit',
181 codereview_host='host')
182 cl.description = '\n'.join([
183 'This is some message',
184 '',
185 'It has some lines',
186 'and, also',
187 '',
188 'Some: Really',
189 'Awesome: Footers',
190 ])
191 cl.has_description = True
192 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
193 msg, footers = cl.GetDescriptionFooters()
194 self.assertEquals(
195 msg, ['This is some message', '', 'It has some lines', 'and, also'])
196 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
197
198 msg.append('wut')
199 footers.append(('gnarly-dude', 'beans'))
200 cl.UpdateDescriptionFooters(msg, footers)
201 self.assertEquals(cl.GetDescription().splitlines(), [
202 'This is some message',
203 '',
204 'It has some lines',
205 'and, also',
206 'wut'
207 '',
208 'Some: Really',
209 'Awesome: Footers',
210 'Gnarly-Dude: beans',
211 ])
212
tandriif9aefb72016-07-01 09:06:51 -0700213 def test_get_bug_line_values(self):
214 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
215 self.assertEqual(f('', ''), [])
216 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
217 self.assertEqual(f('v8', '456'), ['v8:456'])
218 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
219 # Not nice, but not worth carying.
220 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
221 ['v8:456', 'chromium:123', 'v8:123'])
222
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100223 def _test_git_number(self, parent_msg, dest_ref, child_msg,
224 parent_hash='parenthash'):
225 desc = git_cl.ChangeDescription(child_msg)
226 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
227 return desc.description
228
229 def assertEqualByLine(self, actual, expected):
230 self.assertEqual(actual.splitlines(), expected.splitlines())
231
232 def test_git_number_bad_parent(self):
233 with self.assertRaises(ValueError):
234 self._test_git_number('Parent', 'refs/heads/master', 'Child')
235
236 def test_git_number_bad_parent_footer(self):
237 with self.assertRaises(AssertionError):
238 self._test_git_number(
239 'Parent\n'
240 '\n'
241 'Cr-Commit-Position: wrong',
242 'refs/heads/master', 'Child')
243
244 def test_git_number_bad_lineage_ignored(self):
245 actual = self._test_git_number(
246 'Parent\n'
247 '\n'
248 'Cr-Commit-Position: refs/heads/master@{#1}\n'
249 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
250 'refs/heads/master', 'Child')
251 self.assertEqualByLine(
252 actual,
253 'Child\n'
254 '\n'
255 'Cr-Commit-Position: refs/heads/master@{#2}\n'
256 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
257
258 def test_git_number_same_branch(self):
259 actual = self._test_git_number(
260 'Parent\n'
261 '\n'
262 'Cr-Commit-Position: refs/heads/master@{#12}',
263 dest_ref='refs/heads/master',
264 child_msg='Child')
265 self.assertEqualByLine(
266 actual,
267 'Child\n'
268 '\n'
269 'Cr-Commit-Position: refs/heads/master@{#13}')
270
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200271 def test_git_number_same_branch_mixed_footers(self):
272 actual = self._test_git_number(
273 'Parent\n'
274 '\n'
275 'Cr-Commit-Position: refs/heads/master@{#12}',
276 dest_ref='refs/heads/master',
277 child_msg='Child\n'
278 '\n'
279 'Broken-by: design\n'
280 'BUG=123')
281 self.assertEqualByLine(
282 actual,
283 'Child\n'
284 '\n'
285 'Broken-by: design\n'
286 'BUG=123\n'
287 'Cr-Commit-Position: refs/heads/master@{#13}')
288
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100289 def test_git_number_same_branch_with_originals(self):
290 actual = self._test_git_number(
291 'Parent\n'
292 '\n'
293 'Cr-Commit-Position: refs/heads/master@{#12}',
294 dest_ref='refs/heads/master',
295 child_msg='Child\n'
296 '\n'
297 'Some users are smart and insert their own footers\n'
298 '\n'
299 'Cr-Whatever: value\n'
300 'Cr-Commit-Position: refs/copy/paste@{#22}')
301 self.assertEqualByLine(
302 actual,
303 'Child\n'
304 '\n'
305 'Some users are smart and insert their own footers\n'
306 '\n'
307 'Cr-Original-Whatever: value\n'
308 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
309 'Cr-Commit-Position: refs/heads/master@{#13}')
310
311 def test_git_number_new_branch(self):
312 actual = self._test_git_number(
313 'Parent\n'
314 '\n'
315 'Cr-Commit-Position: refs/heads/master@{#12}',
316 dest_ref='refs/heads/branch',
317 child_msg='Child')
318 self.assertEqualByLine(
319 actual,
320 'Child\n'
321 '\n'
322 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
323 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
324
325 def test_git_number_lineage(self):
326 actual = self._test_git_number(
327 'Parent\n'
328 '\n'
329 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
330 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
331 dest_ref='refs/heads/branch',
332 child_msg='Child')
333 self.assertEqualByLine(
334 actual,
335 'Child\n'
336 '\n'
337 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
338 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
339
340 def test_git_number_moooooooore_lineage(self):
341 actual = self._test_git_number(
342 'Parent\n'
343 '\n'
344 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
345 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
346 dest_ref='refs/heads/mooore',
347 child_msg='Child')
348 self.assertEqualByLine(
349 actual,
350 'Child\n'
351 '\n'
352 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
353 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
354 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
355
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100356 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700357 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100358 actual = self._test_git_number(
359 'CQ commit on fresh new branch + numbering.\n'
360 '\n'
361 'NOTRY=True\n'
362 'NOPRESUBMIT=True\n'
363 'BUG=\n'
364 '\n'
365 'Review-Url: https://codereview.chromium.org/2577703003\n'
366 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
367 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
368 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
369 dest_ref='refs/heads/gnumb-test/cl',
370 child_msg='git cl on fresh new branch + numbering.\n'
371 '\n'
372 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
373 self.assertEqualByLine(
374 actual,
375 'git cl on fresh new branch + numbering.\n'
376 '\n'
377 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
378 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
379 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
380 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
381 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100382
383 def test_git_number_cherry_pick(self):
384 actual = self._test_git_number(
385 'Parent\n'
386 '\n'
387 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
388 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
389 dest_ref='refs/heads/branch',
390 child_msg='Child, which is cherry-pick from master\n'
391 '\n'
392 'Cr-Commit-Position: refs/heads/master@{#100}\n'
393 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
394 self.assertEqualByLine(
395 actual,
396 'Child, which is cherry-pick from master\n'
397 '\n'
398 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
399 '\n'
400 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
401 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
402 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
403
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000404 def test_gerrit_mirror_hack(self):
405 cr = 'chromium-review.googlesource.com'
406 url0 = 'https://%s/a/changes/x?a=b' % cr
407 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
408 try:
409 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
410 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
411 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
412 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
413
414 self.assertNotEqual(url1, url2)
415 self.assertEqual(sorted((url1, url2)), [
416 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
417 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
418 self.assertEqual(url1, url3)
419 finally:
420 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
421
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000422 def test_valid_accounts(self):
423 mock_per_account = {
424 'u1': None, # 404, doesn't exist.
425 'u2': {
426 '_account_id': 123124,
427 'avatars': [],
428 'email': 'u2@example.com',
429 'name': 'User Number 2',
430 'status': 'OOO',
431 },
432 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
433 }
434 def GetAccountDetailsMock(_, account):
435 # Poor-man's mock library's side_effect.
436 v = mock_per_account.pop(account)
437 if isinstance(v, Exception):
438 raise v
439 return v
440
441 original = git_cl.gerrit_util.GetAccountDetails
442 try:
443 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
444 actual = git_cl.gerrit_util.ValidAccounts(
445 'host', ['u1', 'u2', 'u3'], max_threads=1)
446 finally:
447 git_cl.gerrit_util.GetAccountDetails = original
448 self.assertEqual(actual, {
449 'u2': {
450 '_account_id': 123124,
451 'avatars': [],
452 'email': 'u2@example.com',
453 'name': 'User Number 2',
454 'status': 'OOO',
455 },
456 })
457
458
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000459
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200460class TestParseIssueURL(unittest.TestCase):
461 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
462 codereview=None, fail=False):
463 self.assertIsNotNone(parsed)
464 if fail:
465 self.assertFalse(parsed.valid)
466 return
467 self.assertTrue(parsed.valid)
468 self.assertEqual(parsed.issue, issue)
469 self.assertEqual(parsed.patchset, patchset)
470 self.assertEqual(parsed.hostname, hostname)
471 self.assertEqual(parsed.codereview, codereview)
472
473 def _run_and_validate(self, func, url, *args, **kwargs):
474 result = func(urlparse.urlparse(url))
475 if kwargs.pop('fail', False):
476 self.assertIsNone(result)
477 return None
478 self._validate(result, *args, fail=False, **kwargs)
479
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480 def test_gerrit(self):
481 def test(url, issue=None, patchset=None, hostname=None, fail=None):
482 self._test_ParseIssueUrl(
483 git_cl._GerritChangelistImpl.ParseIssueURL,
484 url, issue, patchset, hostname, fail)
485 def test(url, *args, **kwargs):
486 self._run_and_validate(git_cl._GerritChangelistImpl.ParseIssueURL, url,
487 *args, codereview='gerrit', **kwargs)
488
489 test('http://chrome-review.source.com/c/123',
490 123, None, 'chrome-review.source.com')
491 test('https://chrome-review.source.com/c/123/',
492 123, None, 'chrome-review.source.com')
493 test('https://chrome-review.source.com/c/123/4',
494 123, 4, 'chrome-review.source.com')
495 test('https://chrome-review.source.com/#/c/123/4',
496 123, 4, 'chrome-review.source.com')
497 test('https://chrome-review.source.com/c/123/4',
498 123, 4, 'chrome-review.source.com')
499 test('https://chrome-review.source.com/123',
500 123, None, 'chrome-review.source.com')
501 test('https://chrome-review.source.com/123/4',
502 123, 4, 'chrome-review.source.com')
503
504 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
505 test('https://chrome-review.source.com/c/abc/', fail=True)
506 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
507
508 def test_ParseIssueNumberArgument(self):
509 def test(arg, *args, **kwargs):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200510 codereview_hint = kwargs.pop('hint', None)
511 self._validate(git_cl.ParseIssueNumberArgument(arg, codereview_hint),
512 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200513
514 test('123', 123)
515 test('', fail=True)
516 test('abc', fail=True)
517 test('123/1', fail=True)
518 test('123a', fail=True)
519 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000520
521 # Looks like Rietveld and Gerrit, but we should select Gerrit now
522 # w/ or w/o hint.
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200523 test('https://codereview.source.com/123',
524 123, None, 'codereview.source.com', 'gerrit',
525 hint='gerrit')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000526 test('https://codereview.source.com/123',
527 123, None, 'codereview.source.com', 'gerrit')
528
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200529 # Gerrrit.
530 test('https://chrome-review.source.com/c/123/4',
531 123, 4, 'chrome-review.source.com', 'gerrit')
532 test('https://chrome-review.source.com/bad/123/4', fail=True)
533
534
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100535class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100536 def setUp(self):
537 super(GitCookiesCheckerTest, self).setUp()
538 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100539 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100540
541 def mock_hosts_creds(self, subhost_identity_pairs):
542 def ensure_googlesource(h):
543 if not h.endswith(self.c._GOOGLESOURCE):
544 assert not h.endswith('.')
545 return h + '.' + self.c._GOOGLESOURCE
546 return h
547 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
548 for h, i in subhost_identity_pairs]
549
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200550 def test_identity_parsing(self):
551 self.assertEqual(self.c._parse_identity('ldap.google.com'),
552 ('ldap', 'google.com'))
553 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
554 ('ldap', 'example.com'))
555 # Specical case because we know there are no subdomains in chromium.org.
556 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
557 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800558 # Pathological: ".period." can be either username OR domain, more likely
559 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200560 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
561 ('note', 'period.example.com'))
562
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563 def test_analysis_nothing(self):
564 self.c._all_hosts = []
565 self.assertFalse(self.c.has_generic_host())
566 self.assertEqual(set(), self.c.get_conflicting_hosts())
567 self.assertEqual(set(), self.c.get_duplicated_hosts())
568 self.assertEqual(set(), self.c.get_partially_configured_hosts())
569 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
570
571 def test_analysis(self):
572 self.mock_hosts_creds([
573 ('.googlesource.com', 'git-example.chromium.org'),
574
575 ('chromium', 'git-example.google.com'),
576 ('chromium-review', 'git-example.google.com'),
577 ('chrome-internal', 'git-example.chromium.org'),
578 ('chrome-internal-review', 'git-example.chromium.org'),
579 ('conflict', 'git-example.google.com'),
580 ('conflict-review', 'git-example.chromium.org'),
581 ('dup', 'git-example.google.com'),
582 ('dup', 'git-example.google.com'),
583 ('dup-review', 'git-example.google.com'),
584 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200585 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100586 ])
587 self.assertTrue(self.c.has_generic_host())
588 self.assertEqual(set(['conflict.googlesource.com']),
589 self.c.get_conflicting_hosts())
590 self.assertEqual(set(['dup.googlesource.com']),
591 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200592 self.assertEqual(set(['partial.googlesource.com',
593 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100594 self.c.get_partially_configured_hosts())
595 self.assertEqual(set(['chromium.googlesource.com',
596 'chrome-internal.googlesource.com']),
597 self.c.get_hosts_with_wrong_identities())
598
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100599 def test_report_no_problems(self):
600 self.test_analysis_nothing()
601 self.mock(sys, 'stdout', StringIO.StringIO())
602 self.assertFalse(self.c.find_and_report_problems())
603 self.assertEqual(sys.stdout.getvalue(), '')
604
605 def test_report(self):
606 self.test_analysis()
607 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200608 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
609 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100610 self.assertTrue(self.c.find_and_report_problems())
611 with open(os.path.join(os.path.dirname(__file__),
612 'git_cl_creds_check_report.txt')) as f:
613 expected = f.read()
614 def by_line(text):
615 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700616 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200617 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100618
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800619
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000620class TestGitCl(TestCase):
621 def setUp(self):
622 super(TestGitCl, self).setUp()
623 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700624 self._calls_done = []
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000625 self.mock(subprocess2, 'call', self._mocked_call)
626 self.mock(subprocess2, 'check_call', self._mocked_call)
627 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700628 self.mock(subprocess2, 'communicate',
629 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000630 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000631 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000632 self.mock(git_common, 'get_or_create_merge_base',
633 lambda *a: (
634 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000635 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000636 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000637 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
638 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100639 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000640 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700641 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000642 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000643 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
skobes6468b902016-10-24 08:45:10 -0700644 self.mock(git_cl.checkout, 'GitCheckout', GitCheckoutMock)
645 GitCheckoutMock.reset()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000646 self.mock(git_cl.upload, 'RealMain', self.fail)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000647 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000648 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100649 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
650 lambda *args, **kwargs: self._mocked_call(
651 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700652 self.mock(git_cl.gerrit_util, 'GetChangeComments',
653 lambda *args, **kwargs: self._mocked_call(
654 'GetChangeComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100655 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700656 lambda h, i, reviewers, ccs, notify: self._mocked_call(
657 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700658 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700659 lambda h, i, msg=None, labels=None, notify=None:
660 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700661 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
662 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000663 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
664 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000665 self.mock(git_cl.gerrit_util, 'ValidAccounts',
666 lambda host, accounts:
667 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700668 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100669 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000670 # It's important to reset settings to not have inter-tests interference.
671 git_cl.settings = None
672
673 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000674 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100675 self.assertEquals([], self.calls)
676 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000677 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100678 raise
679 # Sadly, has_failed() returns True if this OR any other tests before this
680 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200681 git_cl.logging.error(
682 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100683 'There are un-consumed self.calls after this test has finished.\n'
684 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700685 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200686 'If you are already running only this test, then **first** fix the '
687 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100688 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700689 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100690 'and follow instructions above.\n' +
691 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000692 finally:
693 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000694
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000695 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000696 self.assertTrue(
697 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700698 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000699 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000700 expected_args, result = top
701
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000702 # Also logs otherwise it could get caught in a try/finally and be hard to
703 # diagnose.
704 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700705 N = 5
706 prior_calls = '\n '.join(
707 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
708 for i, c in enumerate(self._calls_done[-N:]))
709 following_calls = '\n '.join(
710 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
711 for i, c in enumerate(self.calls[:N]))
712 extended_msg = (
713 'A few prior calls:\n %s\n\n'
714 'This (expected):\n @%d: %r\n'
715 'This (actual):\n @%d: %r\n\n'
716 'A few following expected calls:\n %s' %
717 (prior_calls, len(self._calls_done), expected_args,
718 len(self._calls_done), args, following_calls))
719 git_cl.logging.error(extended_msg)
720
tandrii99a72f22016-08-17 14:33:24 -0700721 self.fail('@%d\n'
722 ' Expected: %r\n'
723 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700724 len(self._calls_done), expected_args, args))
725
726 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700727 if isinstance(result, Exception):
728 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000729 return result
730
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100731 def test_ask_for_explicit_yes_true(self):
732 self.calls = [
733 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
734 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
735 ]
736 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
737
tandrii48df5812016-10-17 03:55:37 -0700738 def test_LoadCodereviewSettingsFromFile_gerrit(self):
739 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
740 self.calls = [
741 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
742 ((['git', 'config', '--unset-all', 'rietveld.private'],), CERR1),
743 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
744 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
745 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
746 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700747 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
748 CERR1),
749 ((['git', 'config', '--unset-all', 'rietveld.project'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700750 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
751 CERR1),
752 ((['git', 'config', 'gerrit.host', 'true'],), ''),
753 ]
754 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
755
maruel@chromium.orga3353652011-11-30 14:26:57 +0000756 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000757 def _is_gerrit_calls(cls, gerrit=False):
758 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
759 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
760
761 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000762 def _git_post_upload_calls(cls):
763 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000764 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
765 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
766 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000767 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000768 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000769 ]
770
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000771 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000772 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000773 fake_ancestor = 'fake_ancestor'
774 fake_cl = 'fake_cl_for_patch'
775 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000776 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000777 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000778 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000779 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000780 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000781 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000782 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000783 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700784 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000785 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000786 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000787 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000788 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000789 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000790 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000791 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000792 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000793 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000794 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000795 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000796
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000797 @classmethod
tandrii@chromium.org28253532016-04-14 13:46:56 +0000798 def _gerrit_ensure_auth_calls(cls, issue=None, skip_auth_check=False):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000799 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000800 if skip_auth_check:
801 return [((cmd, ), 'true')]
802
tandrii5d48c322016-08-18 16:19:37 -0700803 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000804 if issue:
805 calls.extend([
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100806 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000807 ])
808 calls.extend([
809 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
810 ((['git', 'config', 'branch.master.remote'],), 'origin'),
811 ((['git', 'config', 'remote.origin.url'],),
812 'https://chromium.googlesource.com/my/repo'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000813 ])
814 return calls
815
816 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100817 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200818 fetched_status=None, other_cl_owner=None,
819 custom_cl_base=None):
Aaron Gable13101a62018-02-09 13:20:41 -0800820 calls = cls._is_gerrit_calls(True)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100821 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200822 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
823 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
824 ((['git', 'config', 'branch.master.gerritissue'],),
825 CERR1 if issue is None else str(issue)),
826 ]
827
828 if custom_cl_base:
829 ancestor_revision = custom_cl_base
830 else:
831 # Determine ancestor_revision to be merge base.
832 ancestor_revision = 'fake_ancestor_sha'
833 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000834 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000835 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000836 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200837 'refs/remotes/origin/master'],), ancestor_revision),
838 ]
839
840 # Calls to verify branch point is ancestor
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100841 calls += cls._gerrit_ensure_auth_calls(issue=issue)
842
843 if issue:
844 calls += [
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100845 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000846 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000847 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
848 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100849 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100850 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100851 'change_id': '123456789',
852 'current_revision': 'sha1_of_current_revision',
853 'revisions': { 'sha1_of_current_revision': {
854 'commit': {'message': fetched_description},
855 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100856 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100857 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100858 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100859 if fetched_status == 'ABANDONED':
860 calls += [
861 (('DieWithError', 'Change https://chromium-review.googlesource.com/'
862 '123456 has been abandoned, new uploads are not '
863 'allowed'), SystemExitMock()),
864 ]
865 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100866 if other_cl_owner:
867 calls += [
868 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
869 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100870
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200871 calls += cls._git_sanity_checks(ancestor_revision, 'master',
872 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100873 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200874 ((['git', 'rev-parse', '--show-cdup'],), ''),
875 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000876
Aaron Gable7817f022017-12-12 09:43:17 -0800877 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
878 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200879 'M\t.gitignore\n'),
880 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100881 ]
882
883 if not issue:
884 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200885 ((['git', 'log', '--pretty=format:%s%n%n%b',
886 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000887 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100888 ]
889
890 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200891 ((['git', 'config', 'user.email'],), 'me@example.com'),
892 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
893 ([custom_cl_base] if custom_cl_base else
894 [ancestor_revision, 'HEAD']),),
895 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100896 ]
897 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000898
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000899 @classmethod
900 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700901 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000902 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700903 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100904 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +0000905 custom_cl_base=None, tbr=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000906 if post_amend_description is None:
907 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700908 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200909 # Determined in `_gerrit_base_calls`.
910 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
911
912 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000913
tandriia60502f2016-06-20 02:01:53 -0700914 if squash_mode == 'default':
915 calls.extend([
916 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
917 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
918 ])
919 elif squash_mode in ('override_squash', 'override_nosquash'):
920 calls.extend([
921 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
922 'true' if squash_mode == 'override_squash' else 'false'),
923 ])
924 else:
925 assert squash_mode in ('squash', 'nosquash')
926
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000927 # If issue is given, then description is fetched from Gerrit instead.
928 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000929 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200930 ((['git', 'log', '--pretty=format:%s\n\n%b',
931 ((custom_cl_base + '..') if custom_cl_base else
932 'fake_ancestor_sha..HEAD')],),
933 description),
934 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800935 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000936 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800937 else:
938 if not title:
939 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200940 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
941 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800942 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000943 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000944 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000945 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200946 (('DownloadGerritHook', False), ''),
947 # Amending of commit message to get the Change-Id.
948 ((['git', 'log', '--pretty=format:%s\n\n%b',
949 determined_ancestor_revision + '..HEAD'],),
950 description),
951 ((['git', 'commit', '--amend', '-m', description],), ''),
952 ((['git', 'log', '--pretty=format:%s\n\n%b',
953 determined_ancestor_revision + '..HEAD'],),
954 post_amend_description)
955 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000956 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000957 if not issue:
958 # Prompting to edit description on first upload.
959 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200960 ((['git', 'config', 'core.editor'],), ''),
961 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000962 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000963 ref_to_push = 'abcdef0123456789'
964 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200965 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
966 ((['git', 'config', 'branch.master.remote'],), 'origin'),
967 ]
968
969 if custom_cl_base is None:
970 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000971 ((['get_or_create_merge_base', 'master',
972 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000973 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200974 ]
975 parent = 'origin/master'
976 else:
977 calls += [
978 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
979 'refs/remotes/origin/master'],),
980 callError(1)), # Means not ancenstor.
981 (('ask_for_data',
982 'Do you take responsibility for cleaning up potential mess '
983 'resulting from proceeding with upload? Press Enter to upload, '
984 'or Ctrl+C to abort'), ''),
985 ]
986 parent = custom_cl_base
987
988 calls += [
989 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
990 '0123456789abcdef'),
991 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -0700992 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200993 ref_to_push),
994 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000995 else:
996 ref_to_push = 'HEAD'
997
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000998 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000999 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001000 ((['git', 'rev-list',
1001 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1002 ref_to_push],),
1003 '1hashPerLine\n'),
1004 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001005
Aaron Gableafd52772017-06-27 16:40:10 -07001006 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001007 ref_suffix = '%ready,notify=ALL'
1008 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001009 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001010 ref_suffix = '%wip'
1011 else:
1012 ref_suffix = '%notify=NONE'
Aaron Gable9b713dd2016-12-14 16:04:21 -08001013
Aaron Gable70f4e242017-06-26 10:45:59 -07001014 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001015 ref_suffix += ',m=' + title
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001016
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001017 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001018 ((['git', 'config', 'rietveld.cc'],), ''),
1019 (('ValidAccounts', 'chromium-review.googlesource.com',
1020 sorted(reviewers) + ['joe@example.com',
1021 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1022 {
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001023 e: {'email': e}
1024 for e in (reviewers + ['joe@example.com'] + cc)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001025 }),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001026 ]
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001027 for r in sorted(reviewers):
1028 if r != 'bad-account-or-email':
1029 ref_suffix += ',r=%s' % r
1030 reviewers.remove(r)
1031 for c in sorted(['joe@example.com'] + cc):
1032 ref_suffix += ',cc=%s' % c
1033 if c in cc:
1034 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001035
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001036 calls.append((
1037 (['git', 'push',
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001038 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001039 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1040 ('remote:\n'
1041 'remote: Processing changes: (\)\n'
1042 'remote: Processing changes: (|)\n'
1043 'remote: Processing changes: (/)\n'
1044 'remote: Processing changes: (-)\n'
1045 'remote: Processing changes: new: 1 (/)\n'
1046 'remote: Processing changes: new: 1, done\n'
1047 'remote:\n'
1048 'remote: New Changes:\n'
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001049 'remote: https://chromium-review.googlesource.com/#/c/my/repo/+/123456'
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001050 ' XXX\n'
1051 'remote:\n'
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001052 'To https://chromium.googlesource.com/my/repo\n'
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001053 ' * [new branch] hhhh -> refs/for/refs/heads/master\n')
1054 ))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001055 if squash:
1056 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001057 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001058 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001059 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001060 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001061 ((['git', 'config', 'branch.master.gerritsquashhash',
1062 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001063 ]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001064 if squash:
1065 calls += [
1066 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001067 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001068 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001069 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1070 notify),
1071 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001072 ]
Aaron Gablefd238082017-06-07 13:42:34 -07001073 if tbr:
1074 calls += [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001075 (('GetChangeDetail', 'chromium-review.googlesource.com',
1076 'my%2Frepo~123456', ['LABELS']), {
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001077 'labels': {
1078 'Code-Review': {
1079 'default_value': 0,
1080 'all': [],
1081 'values': {
1082 '+2': 'lgtm, approved',
1083 '+1': 'lgtm, but someone else must approve',
1084 ' 0': 'No score',
1085 '-1': 'Don\'t submit as-is',
1086 }
1087 }
1088 }
1089 }),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001090 (('SetReview',
1091 'chromium-review.googlesource.com',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001092 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001093 'Self-approving for TBR',
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001094 {'Code-Review': 2}, None), ''),
Aaron Gablefd238082017-06-07 13:42:34 -07001095 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001096 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001097 return calls
1098
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001099 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001100 self,
1101 upload_args,
1102 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001103 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001104 squash=True,
1105 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001106 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001107 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001108 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001109 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001110 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001111 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001112 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001113 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001114 custom_cl_base=None,
1115 tbr=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001116 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001117 if squash_mode is None:
1118 if '--no-squash' in upload_args:
1119 squash_mode = 'nosquash'
1120 elif '--squash' in upload_args:
1121 squash_mode = 'squash'
1122 else:
1123 squash_mode = 'default'
1124
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001125 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001126 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001127 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001128 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001129 CookiesAuthenticatorMockFactory(
1130 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001131 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1132 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001133 self.mock(git_cl.gclient_utils, 'RunEditor',
1134 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001135 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1136 'DownloadGerritHook', force))
tandriia60502f2016-06-20 02:01:53 -07001137
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001138 self.calls = self._gerrit_base_calls(
1139 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001140 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001141 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001142 other_cl_owner=other_cl_owner,
1143 custom_cl_base=custom_cl_base)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001144 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001145 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1146 expected_content=description))
1147 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001148 self.calls += self._gerrit_upload_calls(
1149 description, reviewers, squash,
1150 squash_mode=squash_mode,
1151 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001152 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001153 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001154 issue=issue, cc=cc,
Aaron Gablefd238082017-06-07 13:42:34 -07001155 custom_cl_base=custom_cl_base, tbr=tbr)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001156 # Uncomment when debugging.
1157 # print '\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls)))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001158 git_cl.main(['upload'] + upload_args)
1159
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001160 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001161 self._run_gerrit_upload_test(
1162 ['--no-squash'],
1163 'desc\n\nBUG=\n',
1164 [],
1165 squash=False,
1166 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
1167
1168 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001169 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001170 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001171 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001172 [],
tandriia60502f2016-06-20 02:01:53 -07001173 squash=False,
1174 squash_mode='override_nosquash',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001175 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001176
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001177 def test_gerrit_no_reviewer(self):
1178 self._run_gerrit_upload_test(
1179 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001180 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001181 [],
1182 squash=False,
1183 squash_mode='override_nosquash')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001184
Nick Carter8692b182017-11-06 16:30:38 -08001185 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001186 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1187 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001188 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001189 'desc\n\nBUG=\n\nChange-Id: I123456789',
1190 squash=False,
1191 squash_mode='override_nosquash',
Nick Carter8692b182017-11-06 16:30:38 -08001192 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001193
ukai@chromium.orge8077812012-02-03 03:41:46 +00001194 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001195 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001196 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001197 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001198 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001199 squash=False,
1200 squash_mode='override_nosquash',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001201 notify=True)
ukai@chromium.orge8077812012-02-03 03:41:46 +00001202
1203 def test_gerrit_reviewer_multiple(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001204 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001205 [],
bradnelsond975b302016-10-23 12:20:23 -07001206 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1207 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001208 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001209 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001210 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001211 cc=['more@example.com', 'people@example.com'],
1212 tbr='reviewer@example.com')
tandriia60502f2016-06-20 02:01:53 -07001213
1214 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001215 self._run_gerrit_upload_test(
1216 [],
1217 'desc\nBUG=\n\nChange-Id: 123456789',
1218 [],
1219 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001220
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001221 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001222 self._run_gerrit_upload_test(
1223 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001224 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001225 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001226 squash=True,
1227 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001228
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001229 def test_gerrit_upload_squash_first_against_rev(self):
1230 custom_cl_base = 'custom_cl_base_rev_or_branch'
1231 self._run_gerrit_upload_test(
1232 ['--squash', custom_cl_base],
1233 'desc\nBUG=\n\nChange-Id: 123456789',
1234 [],
1235 squash=True,
1236 expected_upstream_ref='origin/master',
1237 custom_cl_base=custom_cl_base)
1238 self.assertIn(
1239 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1240 sys.stdout.getvalue())
1241
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001242 def test_gerrit_upload_squash_reupload(self):
1243 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001244 self._run_gerrit_upload_test(
1245 ['--squash'],
1246 description,
1247 [],
1248 squash=True,
1249 expected_upstream_ref='origin/master',
1250 issue=123456)
1251
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001252 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1253 self.mock(git_cl, 'DieWithError',
1254 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1255 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1256 with self.assertRaises(SystemExitMock):
1257 self._run_gerrit_upload_test(
1258 ['--squash'],
1259 description,
1260 [],
1261 squash=True,
1262 expected_upstream_ref='origin/master',
1263 issue=123456,
1264 fetched_status='ABANDONED')
1265
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001266 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1267 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1268 lambda *_, **__: {'email': 'yet-another@example.com'})
1269 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1270 self._run_gerrit_upload_test(
1271 ['--squash'],
1272 description,
1273 [],
1274 squash=True,
1275 expected_upstream_ref='origin/master',
1276 issue=123456,
1277 other_cl_owner='other@example.com')
1278 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001279 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001280 'authenticate to Gerrit as yet-another@example.com.\n'
1281 'Uploading may fail due to lack of permissions',
1282 git_cl.sys.stdout.getvalue())
1283
rmistry@google.com2dd99862015-06-22 12:22:18 +00001284 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001285 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001286 def mock_run_git(*args, **_kwargs):
1287 if args[0] == ['for-each-ref',
1288 '--format=%(refname:short) %(upstream:short)',
1289 'refs/heads']:
1290 # Create a local branch dependency tree that looks like this:
1291 # test1 -> test2 -> test3 -> test4 -> test5
1292 # -> test3.1
1293 # test6 -> test0
1294 branch_deps = [
1295 'test2 test1', # test1 -> test2
1296 'test3 test2', # test2 -> test3
1297 'test3.1 test2', # test2 -> test3.1
1298 'test4 test3', # test3 -> test4
1299 'test5 test4', # test4 -> test5
1300 'test6 test0', # test0 -> test6
1301 'test7', # test7
1302 ]
1303 return '\n'.join(branch_deps)
1304 self.mock(git_cl, 'RunGit', mock_run_git)
1305
1306 class RecordCalls:
1307 times_called = 0
1308 record_calls = RecordCalls()
1309 def mock_CMDupload(*args, **_kwargs):
1310 record_calls.times_called += 1
1311 return 0
1312 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1313
1314 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001315 (('ask_for_data', 'This command will checkout all dependent branches '
1316 'and run "git cl upload". Press Enter to continue, '
1317 'or Ctrl+C to abort'), ''),
1318 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001319
1320 class MockChangelist():
1321 def __init__(self):
1322 pass
1323 def GetBranch(self):
1324 return 'test1'
1325 def GetIssue(self):
1326 return '123'
1327 def GetPatchset(self):
1328 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001329 def IsGerrit(self):
1330 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001331
1332 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1333 # CMDupload should have been called 5 times because of 5 dependent branches.
1334 self.assertEquals(5, record_calls.times_called)
1335 self.assertEquals(0, ret)
1336
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001337 def test_gerrit_change_id(self):
1338 self.calls = [
1339 ((['git', 'write-tree'], ),
1340 'hashtree'),
1341 ((['git', 'rev-parse', 'HEAD~0'], ),
1342 'branch-parent'),
1343 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1344 'A B <a@b.org> 1456848326 +0100'),
1345 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1346 'C D <c@d.org> 1456858326 +0100'),
1347 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1348 'hashchange'),
1349 ]
1350 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1351 self.assertEqual(change_id, 'Ihashchange')
1352
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001353 def test_desecription_append_footer(self):
1354 for init_desc, footer_line, expected_desc in [
1355 # Use unique desc first lines for easy test failure identification.
1356 ('foo', 'R=one', 'foo\n\nR=one'),
1357 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1358 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1359 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1360 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1361 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1362 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1363 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1364 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1365 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1366 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1367 ]:
1368 desc = git_cl.ChangeDescription(init_desc)
1369 desc.append_footer(footer_line)
1370 self.assertEqual(desc.description, expected_desc)
1371
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001372 def test_update_reviewers(self):
1373 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001374 ('foo', [], [],
1375 'foo'),
1376 ('foo\nR=xx', [], [],
1377 'foo\nR=xx'),
1378 ('foo\nTBR=xx', [], [],
1379 'foo\nTBR=xx'),
1380 ('foo', ['a@c'], [],
1381 'foo\n\nR=a@c'),
1382 ('foo\nR=xx', ['a@c'], [],
1383 'foo\n\nR=a@c, xx'),
1384 ('foo\nTBR=xx', ['a@c'], [],
1385 'foo\n\nR=a@c\nTBR=xx'),
1386 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1387 'foo\n\nR=a@c, yy\nTBR=xx'),
1388 ('foo\nBUG=', ['a@c'], [],
1389 'foo\nBUG=\nR=a@c'),
1390 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1391 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1392 ('foo', ['a@c', 'b@c'], [],
1393 'foo\n\nR=a@c, b@c'),
1394 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1395 'foo\nBar\n\nR=c@c\nBUG='),
1396 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1397 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001398 # Same as the line before, but full of whitespaces.
1399 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001400 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001401 'foo\nBar\n\nR=c@c\n BUG =',
1402 ),
1403 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001404 ('foo BUG=allo R=joe ', ['c@c'], [],
1405 'foo BUG=allo R=joe\n\nR=c@c'),
1406 # Redundant TBRs get promoted to Rs
1407 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1408 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001409 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001410 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001411 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001412 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001413 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001414 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001415 actual.append(obj.description)
1416 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001417
Nodir Turakulov23b82142017-11-16 11:04:25 -08001418 def test_get_hash_tags(self):
1419 cases = [
1420 ('', []),
1421 ('a', []),
1422 ('[a]', ['a']),
1423 ('[aa]', ['aa']),
1424 ('[a ]', ['a']),
1425 ('[a- ]', ['a']),
1426 ('[a- b]', ['a-b']),
1427 ('[a--b]', ['a-b']),
1428 ('[a', []),
1429 ('[a]x', ['a']),
1430 ('[aa]x', ['aa']),
1431 ('[a b]', ['a-b']),
1432 ('[a b]', ['a-b']),
1433 ('[a__b]', ['a-b']),
1434 ('[a] x', ['a']),
1435 ('[a][b]', ['a', 'b']),
1436 ('[a] [b]', ['a', 'b']),
1437 ('[a][b]x', ['a', 'b']),
1438 ('[a][b] x', ['a', 'b']),
1439 ('[a]\n[b]', ['a']),
1440 ('[a\nb]', []),
1441 ('[a][', ['a']),
1442 ('Revert "[a] feature"', ['a']),
1443 ('Reland "[a] feature"', ['a']),
1444 ('Revert: [a] feature', ['a']),
1445 ('Reland: [a] feature', ['a']),
1446 ('Revert "Reland: [a] feature"', ['a']),
1447 ('Foo: feature', ['foo']),
1448 ('Foo Bar: feature', ['foo-bar']),
1449 ('Revert "Foo bar: feature"', ['foo-bar']),
1450 ('Reland "Foo bar: feature"', ['foo-bar']),
1451 ]
1452 for desc, expected in cases:
1453 change_desc = git_cl.ChangeDescription(desc)
1454 actual = change_desc.get_hash_tags()
1455 self.assertEqual(
1456 actual,
1457 expected,
1458 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1459
wittman@chromium.org455dc922015-01-26 20:15:50 +00001460 def test_get_target_ref(self):
1461 # Check remote or remote branch not present.
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001462 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001463 self.assertEqual(None, git_cl.GetTargetRef(None,
1464 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001465 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001466
wittman@chromium.org455dc922015-01-26 20:15:50 +00001467 # Check default target refs for branches.
1468 self.assertEqual('refs/heads/master',
1469 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001470 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001471 self.assertEqual('refs/heads/master',
1472 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001473 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001474 self.assertEqual('refs/heads/master',
1475 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001476 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001477 self.assertEqual('refs/branch-heads/123',
1478 git_cl.GetTargetRef('origin',
1479 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001480 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001481 self.assertEqual('refs/diff/test',
1482 git_cl.GetTargetRef('origin',
1483 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001484 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001485 self.assertEqual('refs/heads/chrome/m42',
1486 git_cl.GetTargetRef('origin',
1487 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001488 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001489
1490 # Check target refs for user-specified target branch.
1491 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1492 'refs/remotes/branch-heads/123'):
1493 self.assertEqual('refs/branch-heads/123',
1494 git_cl.GetTargetRef('origin',
1495 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001496 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001497 for branch in ('origin/master', 'remotes/origin/master',
1498 'refs/remotes/origin/master'):
1499 self.assertEqual('refs/heads/master',
1500 git_cl.GetTargetRef('origin',
1501 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001502 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001503 for branch in ('master', 'heads/master', 'refs/heads/master'):
1504 self.assertEqual('refs/heads/master',
1505 git_cl.GetTargetRef('origin',
1506 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001507 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001508
wychen@chromium.orga872e752015-04-28 23:42:18 +00001509 def test_patch_when_dirty(self):
1510 # Patch when local tree is dirty
1511 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1512 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1513
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001514 @staticmethod
1515 def _get_gerrit_codereview_server_calls(branch, value=None,
1516 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001517 detect_branch=True,
1518 detect_server=True):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001519 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1520
1521 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1522 """
1523 calls = []
1524 if detect_branch:
1525 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001526 if detect_server:
1527 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1528 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001529 if value is None:
1530 calls += [
1531 ((['git', 'config', 'branch.' + branch + '.merge'],),
1532 'refs/heads' + branch),
1533 ((['git', 'config', 'branch.' + branch + '.remote'],),
1534 'origin'),
1535 ((['git', 'config', 'remote.origin.url'],),
1536 'https://%s.googlesource.com/my/repo' % git_short_host),
1537 ]
1538 return calls
1539
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001540 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001541 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001542 detect_gerrit_server=False,
1543 actual_codereview=None,
1544 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001545 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001546 self.mock(git_cl._RietveldChangelistImpl, 'GetMostRecentPatchset',
1547 lambda x: '60001')
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001548 self.mock(git_cl._RietveldChangelistImpl, 'FetchDescription',
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001549 lambda *a, **kw: 'Description')
wychen@chromium.orga872e752015-04-28 23:42:18 +00001550 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1551
tandriidf09a462016-08-18 16:23:55 -07001552 if new_branch:
1553 self.calls = [((['git', 'new-branch', 'master'],), ''),]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001554
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001555 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001556 self.calls += [
1557 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001558 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001559 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001560
1561 if not force_codereview and not codereview_in_url:
1562 # These calls detect codereview to use.
1563 self.calls += [
1564 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
1565 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1566 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
1567 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1568 ((['git', 'config', 'gerrit.host'],), 'true'),
1569 ]
1570 if detect_gerrit_server:
1571 self.calls += self._get_gerrit_codereview_server_calls(
1572 'master', git_short_host=git_short_host,
1573 detect_branch=not new_branch and force_codereview)
1574 actual_codereview = 'gerrit'
1575
1576 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001577 self.calls += [
1578 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001579 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001580 {
1581 'current_revision': '7777777777',
1582 'revisions': {
1583 '1111111111': {
1584 '_number': 1,
1585 'fetch': {'http': {
1586 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1587 'ref': 'refs/changes/56/123456/1',
1588 }},
1589 },
1590 '7777777777': {
1591 '_number': 7,
1592 'fetch': {'http': {
1593 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1594 'ref': 'refs/changes/56/123456/7',
1595 }},
1596 },
1597 },
1598 }),
1599 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001600
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001601 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001602 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001603 self.calls += [
1604 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1605 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001606 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001607 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001608 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001609 ((['git', 'config', 'branch.master.gerritserver',
1610 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001611 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001612 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1613 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1614 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001615 ]
1616 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1617
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001618 def test_patch_gerrit_new_branch(self):
1619 self._patch_common(
1620 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1621 self.calls += [
1622 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1623 'refs/changes/56/123456/7'],), ''),
1624 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1625 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1626 ''),
1627 ((['git', 'config', 'branch.master.gerritserver',
1628 'https://chromium-review.googlesource.com'],), ''),
1629 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1630 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1631 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1632 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1633 ]
1634 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1635
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001636 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001637 self._patch_common(
1638 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001639 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001640 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001641 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001642 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001643 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001644 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001645 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001646 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001647 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001648 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1649 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1650 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001651 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001652 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001653
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001654 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001655 self.calls += self._get_gerrit_codereview_server_calls(
1656 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001657 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001658 actual_codereview='gerrit', git_short_host='else',
1659 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001660 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001661 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001662 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001663 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001664 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001665 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001666 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001667 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001668 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001669 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1670 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1671 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001672 ]
1673 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001674 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001675
Aaron Gable697a91b2018-01-19 15:20:15 -08001676 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001677 self.calls += self._get_gerrit_codereview_server_calls(
1678 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001679 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001680 actual_codereview='gerrit', git_short_host='else',
1681 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001682 self.calls += [
1683 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1684 'refs/changes/56/123456/1'],), ''),
1685 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1686 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1687 ''),
1688 ((['git', 'config', 'branch.master.gerritserver',
1689 'https://else-review.googlesource.com'],), ''),
1690 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1691 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1692 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1693 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1694 ]
1695 self.assertEqual(git_cl.main(
1696 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1697 0)
1698
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001699 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001700 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001701 self.calls += [
1702 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001703 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001704 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1705 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1706 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001707 ]
1708 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001709 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001710
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001711 def test_patch_gerrit_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001712 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001713 raise git_cl.gerrit_util.GerritError(404, '')
1714 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1715
tandriic2405f52016-10-10 08:13:15 -07001716 self.calls = [
1717 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandriic2405f52016-10-10 08:13:15 -07001718 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1719 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
1720 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1721 ((['git', 'config', 'gerrit.host'],), 'true'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001722 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1723 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1724 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1725 ((['git', 'config', 'remote.origin.url'],),
1726 'https://chromium.googlesource.com/my/repo'),
1727 ((['DieWithError',
1728 'change 123456 at https://chromium-review.googlesource.com does not '
1729 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001730 ]
1731 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001732 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001733
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001734 def _checkout_calls(self):
1735 return [
1736 ((['git', 'config', '--local', '--get-regexp',
1737 'branch\\..*\\.rietveldissue'], ),
1738 ('branch.retrying.rietveldissue 1111111111\n'
1739 'branch.some-fix.rietveldissue 2222222222\n')),
1740 ((['git', 'config', '--local', '--get-regexp',
1741 'branch\\..*\\.gerritissue'], ),
1742 ('branch.ger-branch.gerritissue 123456\n'
1743 'branch.gbranch654.gerritissue 654321\n')),
1744 ]
1745
1746 def test_checkout_gerrit(self):
1747 """Tests git cl checkout <issue>."""
1748 self.calls = self._checkout_calls()
1749 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1750 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1751
1752 def test_checkout_rietveld(self):
1753 """Tests git cl checkout <issue>."""
1754 self.calls = self._checkout_calls()
1755 self.calls += [((['git', 'checkout', 'some-fix'], ), '')]
1756 self.assertEqual(0, git_cl.main(['checkout', '2222222222']))
1757
1758 def test_checkout_not_found(self):
1759 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001760 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001761 self.calls = self._checkout_calls()
1762 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1763
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001764 def test_checkout_no_branch_issues(self):
1765 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001766 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001767 self.calls = [
1768 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001769 'branch\\..*\\.rietveldissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001770 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001771 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001772 ]
1773 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1774
tandrii@chromium.org28253532016-04-14 13:46:56 +00001775 def _test_gerrit_ensure_authenticated_common(self, auth,
1776 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001777 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1778 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1779 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001780 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001781 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001782 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00001783 cl.branch = 'master'
1784 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001785 cl.lookedup_issue = True
1786 return cl
1787
1788 def test_gerrit_ensure_authenticated_missing(self):
1789 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001790 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001791 })
1792 self.calls.append(
1793 ((['DieWithError',
1794 'Credentials for the following hosts are required:\n'
1795 ' chromium-review.googlesource.com\n'
1796 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01001797 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001798 'https://chromium-review.googlesource.com/new-password'],), ''),)
1799 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1800
1801 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001802 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001803 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001804 'chromium.googlesource.com':
1805 ('git-one.example.com', None, 'secret1'),
1806 'chromium-review.googlesource.com':
1807 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001808 })
1809 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001810 (('ask_for_data', 'If you know what you are doing '
1811 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001812 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1813
1814 def test_gerrit_ensure_authenticated_ok(self):
1815 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001816 'chromium.googlesource.com':
1817 ('git-same.example.com', None, 'secret'),
1818 'chromium-review.googlesource.com':
1819 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001820 })
1821 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1822
tandrii@chromium.org28253532016-04-14 13:46:56 +00001823 def test_gerrit_ensure_authenticated_skipped(self):
1824 cl = self._test_gerrit_ensure_authenticated_common(
1825 auth={}, skip_auth_check=True)
1826 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1827
Eric Boren2fb63102018-10-05 13:05:03 +00001828 def test_gerrit_ensure_authenticated_bearer_token(self):
1829 cl = self._test_gerrit_ensure_authenticated_common(auth={
1830 'chromium.googlesource.com':
1831 ('', None, 'secret'),
1832 'chromium-review.googlesource.com':
1833 ('', None, 'secret'),
1834 })
1835 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1836 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1837 'chromium.googlesource.com')
1838 self.assertTrue('Bearer' in header)
1839
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001840 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001841 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001842 lambda h, i, labels, notify=None:
1843 self._mocked_call(['SetReview', h, i, labels, notify]))
1844
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001845 self.calls = [
1846 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001847 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
1848 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001849 ((['git', 'config', 'branch.feature.gerritserver'],),
1850 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001851 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
1852 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1853 ((['git', 'config', 'remote.origin.url'],),
1854 'https://chromium.googlesource.com/infra/infra.git'),
1855 ((['SetReview', 'chromium-review.googlesource.com',
1856 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001857 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001858 ]
tandriid9e5ce52016-07-13 02:32:59 -07001859
1860 def test_cmd_set_commit_gerrit_clear(self):
1861 self._cmd_set_commit_gerrit_common(0)
1862 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1863
1864 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001865 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001866 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1867
tandriid9e5ce52016-07-13 02:32:59 -07001868 def test_cmd_set_commit_gerrit(self):
1869 self._cmd_set_commit_gerrit_common(2)
1870 self.assertEqual(0, git_cl.main(['set-commit']))
1871
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001872 def test_description_display(self):
1873 out = StringIO.StringIO()
1874 self.mock(git_cl.sys, 'stdout', out)
1875
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001876 self.mock(git_cl, 'Changelist', ChangelistMock)
1877 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001878
1879 self.assertEqual(0, git_cl.main(['description', '-d']))
1880 self.assertEqual('foo\n', out.getvalue())
1881
iannucci3c972b92016-08-17 13:24:10 -07001882 def test_StatusFieldOverrideIssueMissingArgs(self):
1883 out = StringIO.StringIO()
1884 self.mock(git_cl.sys, 'stderr', out)
1885
1886 try:
1887 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
1888 except SystemExit as ex:
1889 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001890 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001891
1892 out = StringIO.StringIO()
1893 self.mock(git_cl.sys, 'stderr', out)
1894
1895 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001896 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07001897 except SystemExit as ex:
1898 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001899 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001900
1901 def test_StatusFieldOverrideIssue(self):
1902 out = StringIO.StringIO()
1903 self.mock(git_cl.sys, 'stdout', out)
1904
1905 def assertIssue(cl_self, *_args):
1906 self.assertEquals(cl_self.issue, 1)
1907 return 'foobar'
1908
1909 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07001910 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001911 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001912 0)
iannucci3c972b92016-08-17 13:24:10 -07001913 self.assertEqual(out.getvalue(), 'foobar\n')
1914
iannuccie53c9352016-08-17 14:40:40 -07001915 def test_SetCloseOverrideIssue(self):
1916 def assertIssue(cl_self, *_args):
1917 self.assertEquals(cl_self.issue, 1)
1918 return 'foobar'
1919
1920 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
1921 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07001922 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001923 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001924
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001925 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001926 out = StringIO.StringIO()
1927 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001928 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001929 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
1930 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
1931 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1932 ((['git', 'config', 'remote.origin.url'],),
1933 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001934 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001935 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001936 {
1937 'current_revision': 'sha1',
1938 'revisions': {'sha1': {
1939 'commit': {'message': 'foobar'},
1940 }},
1941 }),
1942 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001943 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001944 'description',
1945 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
1946 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001947 self.assertEqual('foobar\n', out.getvalue())
1948
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001949 def test_description_set_raw(self):
1950 out = StringIO.StringIO()
1951 self.mock(git_cl.sys, 'stdout', out)
1952
1953 self.mock(git_cl, 'Changelist', ChangelistMock)
1954 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
1955
1956 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
1957 self.assertEqual('hihi', ChangelistMock.desc)
1958
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001959 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001960 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001961
1962 def RunEditor(desc, _, **kwargs):
1963 self.assertEquals(
1964 '# Enter a description of the change.\n'
1965 '# This will be displayed on the codereview site.\n'
1966 '# The first line will also be used as the subject of the review.\n'
1967 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001968 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07001969 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001970 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001971 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07001972 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001973
dsansomee2d6fd92016-09-08 00:10:47 -07001974 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07001975 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001976
1977 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1978 self.mock(git_cl.Changelist, 'GetDescription',
1979 lambda *args: current_desc)
1980 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
1981 UpdateDescriptionRemote)
1982 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
1983
1984 self.calls = [
1985 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001986 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07001987 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1988 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001989 ((['git', 'config', 'core.editor'],), 'vi'),
1990 ]
1991 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
1992
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001993 def test_description_set_stdin(self):
1994 out = StringIO.StringIO()
1995 self.mock(git_cl.sys, 'stdout', out)
1996
1997 self.mock(git_cl, 'Changelist', ChangelistMock)
1998 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
1999
2000 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2001 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2002
kmarshall3bff56b2016-06-06 18:31:47 -07002003 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002004 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2005
kmarshall3bff56b2016-06-06 18:31:47 -07002006 self.calls = \
2007 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2008 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
tandrii33a46ff2016-08-23 05:53:40 -07002009 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
tandrii5d48c322016-08-18 16:19:37 -07002010 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2011 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
tandrii33a46ff2016-08-23 05:53:40 -07002012 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2013 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2014 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002015 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2016 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2017 ((['git', 'branch', '-D', 'foo'],), '')]
2018
kmarshall3bff56b2016-06-06 18:31:47 -07002019 self.mock(git_cl, 'get_cl_statuses',
2020 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002021 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2022 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2023 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002024
2025 self.assertEqual(0, git_cl.main(['archive', '-f']))
2026
2027 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002028 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002029 self.calls = \
2030 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2031 'refs/heads/master'),
tandrii33a46ff2016-08-23 05:53:40 -07002032 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
tandrii5d48c322016-08-18 16:19:37 -07002033 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2034 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
kmarshall3bff56b2016-06-06 18:31:47 -07002035 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2036
kmarshall9249e012016-08-23 12:02:16 -07002037 self.mock(git_cl, 'get_cl_statuses',
2038 lambda branches, fine_grained, max_processes:
2039 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2040
2041 self.assertEqual(1, git_cl.main(['archive', '-f']))
2042
2043 def test_archive_dry_run(self):
2044 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2045
2046 self.calls = \
2047 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2048 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2049 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
2050 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2051 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2052 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2053 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2054 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2055 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002056
2057 self.mock(git_cl, 'get_cl_statuses',
2058 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002059 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2060 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2061 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002062
kmarshall9249e012016-08-23 12:02:16 -07002063 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2064
2065 def test_archive_no_tags(self):
2066 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2067
2068 self.calls = \
2069 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2070 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2071 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
2072 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2073 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2074 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2075 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2076 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2077 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2078 ((['git', 'branch', '-D', 'foo'],), '')]
2079
2080 self.mock(git_cl, 'get_cl_statuses',
2081 lambda branches, fine_grained, max_processes:
2082 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2083 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2084 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2085
2086 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002087
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002088 def test_cmd_issue_erase_existing(self):
2089 out = StringIO.StringIO()
2090 self.mock(git_cl.sys, 'stdout', out)
2091 self.calls = [
2092 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002093 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2094 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002095 # Let this command raise exception (retcode=1) - it should be ignored.
2096 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002097 CERR1),
2098 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2099 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002100 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2101 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2102 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002103 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002104 ]
2105 self.assertEqual(0, git_cl.main(['issue', '0']))
2106
Aaron Gable400e9892017-07-12 15:31:21 -07002107 def test_cmd_issue_erase_existing_with_change_id(self):
2108 out = StringIO.StringIO()
2109 self.mock(git_cl.sys, 'stdout', out)
2110 self.mock(git_cl.Changelist, 'GetDescription',
2111 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2112 self.calls = [
2113 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2114 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2115 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
Aaron Gable400e9892017-07-12 15:31:21 -07002116 # Let this command raise exception (retcode=1) - it should be ignored.
2117 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2118 CERR1),
2119 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2120 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2121 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2122 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2123 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002124 ((['git', 'log', '-1', '--format=%B'],),
2125 'This is a description\n\nChange-Id: Ideadbeef'),
2126 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002127 ]
2128 self.assertEqual(0, git_cl.main(['issue', '0']))
2129
phajdan.jre328cf92016-08-22 04:12:17 -07002130 def test_cmd_issue_json(self):
2131 out = StringIO.StringIO()
2132 self.mock(git_cl.sys, 'stdout', out)
2133 self.calls = [
2134 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002135 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
phajdan.jre328cf92016-08-22 04:12:17 -07002136 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2137 ((['git', 'config', 'rietveld.server'],),
2138 'https://codereview.chromium.org'),
2139 ((['git', 'config', 'branch.feature.rietveldserver'],), ''),
2140 (('write_json', 'output.json',
2141 {'issue': 123, 'issue_url': 'https://codereview.chromium.org/123'}),
2142 ''),
2143 ]
2144 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2145
tandrii8c5a3532016-11-04 07:52:02 -07002146 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2147 self.mock(git_cl.Changelist, 'GetChange',
2148 lambda _, *a: (
2149 self._mocked_call(['GetChange']+list(a))))
2150 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2151 lambda *_, **__: (
2152 self._mocked_call(['DoGetTryMasters'])))
2153 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2154 lambda _, s: self._mocked_call(['SetCQState', s]))
2155
tandrii8c5a3532016-11-04 07:52:02 -07002156 self.calls = [
2157 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2158 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2159 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2160 ((['git', 'config', 'branch.feature.gerritserver'],),
2161 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002162 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2163 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2164 ((['git', 'config', 'remote.origin.url'],),
2165 'https://chromium.googlesource.com/depot_tools'),
2166 (('GetChangeDetail', 'chromium-review.googlesource.com',
2167 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002168 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2169 'project': 'depot_tools',
2170 'status': 'OPEN',
2171 'owner': {'email': 'owner@e.mail'},
2172 'revisions': {
2173 'deadbeaf': {
2174 '_number': 6,
2175 },
2176 'beeeeeef': {
2177 '_number': 7,
2178 'fetch': {'http': {
2179 'url': 'https://chromium.googlesource.com/depot_tools',
2180 'ref': 'refs/changes/56/123456/7'
2181 }},
2182 },
2183 },
2184 }),
tandrii8c5a3532016-11-04 07:52:02 -07002185 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2186 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2187 ((['get_or_create_merge_base', 'feature', 'feature'],),
2188 'fake_ancestor_sha'),
2189 ((['GetChange', 'fake_ancestor_sha', None], ),
2190 git_cl.presubmit_support.GitChange(
2191 '', '', '', '', '', '', '', '')),
2192 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2193 ((['DoGetTryMasters'], ), None),
2194 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2195 ]
2196 out = StringIO.StringIO()
2197 self.mock(git_cl.sys, 'stdout', out)
2198 self.assertEqual(0, git_cl.main(['try']))
2199 self.assertEqual(
2200 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002201 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002202 'https://chromium-review.googlesource.com/123456\n')
2203
tandrii8c5a3532016-11-04 07:52:02 -07002204 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2205 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2206 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2207
tandrii8c5a3532016-11-04 07:52:02 -07002208 self.calls = [
2209 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2210 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2211 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2212 ((['git', 'config', 'branch.feature.gerritserver'],),
2213 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002214 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2215 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2216 ((['git', 'config', 'remote.origin.url'],),
2217 'https://chromium.googlesource.com/depot_tools'),
2218 (('GetChangeDetail', 'chromium-review.googlesource.com',
2219 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002220 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002221 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002222 'status': 'OPEN',
2223 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002224 'revisions': {
2225 'deadbeaf': {
2226 '_number': 6,
2227 },
2228 'beeeeeef': {
2229 '_number': 7,
2230 'fetch': {'http': {
2231 'url': 'https://chromium.googlesource.com/depot_tools',
2232 'ref': 'refs/changes/56/123456/7'
2233 }},
2234 },
2235 },
2236 }),
2237 ]
2238
2239 def _buildbucket_retry(*_, **kw):
2240 # self.maxDiff = 10000
2241 body = json.loads(kw['body'])
2242 self.assertEqual(len(body['builds']), 1)
2243 build = body['builds'][0]
2244 params = json.loads(build.pop('parameters_json'))
2245 self.assertEqual(params, {
2246 u'builder_name': u'win',
2247 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2248 u'revision': None}],
2249 u'properties': {
2250 u'category': u'git_cl_try',
2251 u'key': u'val',
2252 u'json': [{u'a': 1}, None],
tandrii8c5a3532016-11-04 07:52:02 -07002253
2254 u'patch_gerrit_url':
2255 u'https://chromium-review.googlesource.com',
2256 u'patch_issue': 123456,
2257 u'patch_project': u'depot_tools',
2258 u'patch_ref': u'refs/changes/56/123456/7',
2259 u'patch_repository_url':
2260 u'https://chromium.googlesource.com/depot_tools',
2261 u'patch_set': 7,
2262 u'patch_storage': u'gerrit',
2263 }
2264 })
2265 self.assertEqual(build, {
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002266 u'bucket': u'luci.chromium.try',
tandrii8c5a3532016-11-04 07:52:02 -07002267 u'client_operation_id': u'uuid4',
2268 u'tags': [
2269 u'builder:win',
2270 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2271 u'user_agent:git_cl_try',
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002272 ],
tandrii8c5a3532016-11-04 07:52:02 -07002273 })
2274
2275 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2276
2277 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2278 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002279 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002280 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2281 self.assertRegexpMatches(
2282 git_cl.sys.stdout.getvalue(),
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002283 'Tried jobs on:\nBucket: luci.chromium.try')
tandriide281ae2016-10-12 06:02:30 -07002284
qyearsley123a4682016-10-26 09:12:17 -07002285 def test_git_cl_try_bots_on_multiple_masters(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002286 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2287 self.mock(git_cl.Changelist, 'GetChange',
2288 lambda _, *a: (
2289 self._mocked_call(['GetChange']+list(a))))
2290 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2291 lambda *_, **__: (
2292 self._mocked_call(['DoGetTryMasters'])))
2293 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2294 lambda _, s: self._mocked_call(['SetCQState', s]))
2295
qyearsley123a4682016-10-26 09:12:17 -07002296 self.calls = [
2297 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002298 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2299 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2300 ((['git', 'config', 'branch.feature.gerritserver'],),
2301 'https://chromium-review.googlesource.com'),
2302 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2303 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2304 ((['git', 'config', 'remote.origin.url'],),
2305 'https://chromium.googlesource.com/depot_tools'),
2306 (('GetChangeDetail', 'chromium-review.googlesource.com',
2307 'depot_tools~123456',
2308 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2309 'project': 'depot_tools',
2310 'status': 'OPEN',
2311 'owner': {'email': 'owner@e.mail'},
2312 'revisions': {
2313 'deadbeaf': {
2314 '_number': 6,
2315 },
2316 'beeeeeef': {
2317 '_number': 7,
2318 'fetch': {'http': {
2319 'url': 'https://chromium.googlesource.com/depot_tools',
2320 'ref': 'refs/changes/56/123456/7'
2321 }},
2322 },
2323 },
2324 }),
qyearsley123a4682016-10-26 09:12:17 -07002325 ]
2326
2327 def _buildbucket_retry(*_, **kw):
2328 body = json.loads(kw['body'])
2329 self.assertEqual(len(body['builds']), 2)
2330
Nodir Turakulovb422e682018-02-20 22:51:30 -08002331 self.assertEqual(body['builds'][0]['bucket'], 'bucket1')
2332 params = json.loads(body['builds'][0]['parameters_json'])
2333 self.assertEqual(params['builder_name'], 'builder1')
qyearsley123a4682016-10-26 09:12:17 -07002334
Nodir Turakulovb422e682018-02-20 22:51:30 -08002335 self.assertEqual(body['builds'][1]['bucket'], 'bucket2')
2336 params = json.loads(body['builds'][1]['parameters_json'])
2337 self.assertEqual(params['builder_name'], 'builder2')
qyearsley123a4682016-10-26 09:12:17 -07002338
2339 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2340
2341 self.mock(git_cl.urllib2, 'urlopen', lambda _: StringIO.StringIO(
Nodir Turakulovb422e682018-02-20 22:51:30 -08002342 json.dumps({
2343 'builder1': {'bucket': 'bucket1'},
2344 'builder2': {'bucket': 'bucket2'},
2345 })))
qyearsley123a4682016-10-26 09:12:17 -07002346
2347 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2348 self.assertEqual(
2349 0, git_cl.main(['try', '-b', 'builder1', '-b', 'builder2']))
2350 self.assertEqual(
2351 git_cl.sys.stdout.getvalue(),
2352 'Tried jobs on:\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002353 'Bucket: bucket1\n'
qyearsley123a4682016-10-26 09:12:17 -07002354 ' builder1: []\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002355 'Bucket: bucket2\n'
qyearsley123a4682016-10-26 09:12:17 -07002356 ' builder2: []\n'
2357 'To see results here, run: git cl try-results\n'
2358 'To see results in browser, run: git cl web\n')
2359
tandrii16e0b4e2016-06-07 10:34:28 -07002360 def _common_GerritCommitMsgHookCheck(self):
2361 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2362 self.mock(git_cl.os.path, 'abspath',
2363 lambda path: self._mocked_call(['abspath', path]))
2364 self.mock(git_cl.os.path, 'exists',
2365 lambda path: self._mocked_call(['exists', path]))
2366 self.mock(git_cl.gclient_utils, 'FileRead',
2367 lambda path: self._mocked_call(['FileRead', path]))
2368 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2369 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2370 self.calls = [
2371 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2372 ((['abspath', '../'],), '/abs/git_repo_root'),
2373 ]
2374 return git_cl.Changelist(codereview='gerrit', issue=123)
2375
2376 def test_GerritCommitMsgHookCheck_custom_hook(self):
2377 cl = self._common_GerritCommitMsgHookCheck()
2378 self.calls += [
2379 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2380 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2381 '#!/bin/sh\necho "custom hook"')
2382 ]
2383 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2384
2385 def test_GerritCommitMsgHookCheck_not_exists(self):
2386 cl = self._common_GerritCommitMsgHookCheck()
2387 self.calls += [
2388 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2389 ]
2390 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2391
2392 def test_GerritCommitMsgHookCheck(self):
2393 cl = self._common_GerritCommitMsgHookCheck()
2394 self.calls += [
2395 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2396 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2397 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002398 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002399 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2400 ''),
2401 ]
2402 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2403
tandriic4344b52016-08-29 06:04:54 -07002404 def test_GerritCmdLand(self):
2405 self.calls += [
2406 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2407 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2408 'deadbeaf'),
2409 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2410 ((['git', 'config', 'branch.feature.gerritserver'],),
2411 'chromium-review.googlesource.com'),
2412 ]
2413 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2414 cl._codereview_impl._GetChangeDetail = lambda _: {
2415 'labels': {},
2416 'current_revision': 'deadbeaf',
2417 }
agable32978d92016-11-01 12:55:02 -07002418 cl._codereview_impl._GetChangeCommit = lambda: {
2419 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002420 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002421 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2422 }
tandriic4344b52016-08-29 06:04:54 -07002423 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002424 out = StringIO.StringIO()
2425 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002426 self.assertEqual(0, cl.CMDLand(force=True,
2427 bypass_hooks=True,
2428 verbose=True,
2429 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002430 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002431 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002432
tandrii221ab252016-10-06 08:12:04 -07002433 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002434 '9000': {
2435 'id': '9000',
2436 'bucket': 'master.x.y',
2437 'created_by': 'user:someone@chromium.org',
2438 'created_ts': '147200002222000',
2439 'experimental': False,
2440 'parameters_json': json.dumps({
2441 'builder_name': 'my-bot',
2442 'properties': {'category': 'cq'},
2443 }),
2444 'status': 'STARTED',
2445 'tags': [
2446 'build_address:x.y/my-bot/2',
2447 'builder:my-bot',
2448 'experimental:false',
2449 'user_agent:cq',
2450 ],
2451 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2452 },
2453 '8000': {
2454 'id': '8000',
2455 'bucket': 'master.x.y',
2456 'created_by': 'user:someone@chromium.org',
2457 'created_ts': '147200001111000',
2458 'experimental': False,
2459 'failure_reason': 'BUILD_FAILURE',
2460 'parameters_json': json.dumps({
2461 'builder_name': 'my-bot',
2462 'properties': {'category': 'cq'},
2463 }),
2464 'result_details_json': json.dumps({
2465 'properties': {'buildnumber': 1},
2466 }),
2467 'result': 'FAILURE',
2468 'status': 'COMPLETED',
2469 'tags': [
2470 'build_address:x.y/my-bot/1',
2471 'builder:my-bot',
2472 'experimental:false',
2473 'user_agent:cq',
2474 ],
2475 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2476 },
2477 }
tandrii221ab252016-10-06 08:12:04 -07002478
2479 def test_write_try_results_json(self):
2480 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002481 {
2482 'bucket': 'master.x.y',
2483 'buildbucket_id': '8000',
2484 'builder_name': 'my-bot',
2485 'created_ts': '147200001111000',
2486 'experimental': False,
2487 'failure_reason': 'BUILD_FAILURE',
2488 'result': 'FAILURE',
2489 'status': 'COMPLETED',
2490 'tags': [
2491 'build_address:x.y/my-bot/1',
2492 'builder:my-bot',
2493 'experimental:false',
2494 'user_agent:cq',
2495 ],
2496 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2497 },
2498 {
2499 'bucket': 'master.x.y',
2500 'buildbucket_id': '9000',
2501 'builder_name': 'my-bot',
2502 'created_ts': '147200002222000',
2503 'experimental': False,
2504 'failure_reason': None,
2505 'result': None,
2506 'status': 'STARTED',
2507 'tags': [
2508 'build_address:x.y/my-bot/2',
2509 'builder:my-bot',
2510 'experimental:false',
2511 'user_agent:cq',
2512 ],
2513 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2514 },
tandrii221ab252016-10-06 08:12:04 -07002515 ]
2516 self.calls = [(('write_json', 'output.json', expected_output), '')]
2517 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2518
tandrii45b2a582016-10-11 03:14:16 -07002519 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002520 out = StringIO.StringIO()
2521 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002522 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2523 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002524 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2525 self._mocked_call(['get_authenticator_for_host', host]))
2526 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2527 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002528
2529 def _setup_fetch_try_jobs_rietveld(self, *request_results):
2530 self._setup_fetch_try_jobs(most_recent_patchset=20001)
tandrii221ab252016-10-06 08:12:04 -07002531 self.calls += [
2532 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2533 ((['git', 'config', 'branch.feature.rietveldissue'],), '1'),
2534 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2535 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2536 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
2537 ((['git', 'config', 'branch.feature.rietveldserver'],),
2538 'codereview.example.com'),
2539 ((['get_authenticator_for_host', 'codereview.example.com'],),
2540 AuthenticatorMock()),
2541 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2542
2543 def test_fetch_try_jobs_none_rietveld(self):
2544 self._setup_fetch_try_jobs_rietveld({})
tandrii45b2a582016-10-11 03:14:16 -07002545 # Simulate that user isn't logged in.
2546 self.mock(AuthenticatorMock, 'has_cached_credentials', lambda _: False)
tandrii221ab252016-10-06 08:12:04 -07002547 self.assertEqual(0, git_cl.main(['try-results']))
tandrii45b2a582016-10-11 03:14:16 -07002548 self.assertRegexpMatches(sys.stdout.getvalue(),
2549 'Warning: Some results might be missing')
tandrii221ab252016-10-06 08:12:04 -07002550 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2551
2552 def test_fetch_try_jobs_some_rietveld(self):
2553 self._setup_fetch_try_jobs_rietveld({
2554 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2555 })
2556 self.assertEqual(0, git_cl.main(['try-results']))
tandrii45b2a582016-10-11 03:14:16 -07002557 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
2558 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2559 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2560
2561 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2562 self._setup_fetch_try_jobs(most_recent_patchset=13)
2563 self.calls += [
2564 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2565 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2566 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002567 # TODO(tandrii): Uncomment the below if we decide to support checking
2568 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002569 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002570 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002571 ((['git', 'config', 'branch.feature.gerritserver'],),
2572 'https://x-review.googlesource.com'),
2573 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2574 AuthenticatorMock()),
2575 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2576
2577 def test_fetch_try_jobs_none_gerrit(self):
2578 self._setup_fetch_try_jobs_gerrit({})
2579 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002580 # TODO(tandrii): Uncomment the below if we decide to support checking
2581 # patchsets for Gerrit.
2582 # self.assertRegexpMatches(
2583 # sys.stdout.getvalue(),
2584 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07002585 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2586
2587 def test_fetch_try_jobs_some_gerrit(self):
2588 self._setup_fetch_try_jobs_gerrit({
2589 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2590 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002591 # TODO(tandrii): Uncomment the below if we decide to support checking
2592 # patchsets for Gerrit.
2593 # self.calls.remove(
2594 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002595 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2596
2597 # ... and doesn't result in warning.
2598 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2599 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002600 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2601 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2602
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002603 def _mock_gerrit_changes_for_detail_cache(self):
2604 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002605
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002606 def test_gerrit_change_detail_cache_simple(self):
2607 self._mock_gerrit_changes_for_detail_cache()
2608 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002609 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2610 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2611 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002612 ]
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002613 cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002614 cl1._cached_remote_url = (
2615 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002616 cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002617 cl2._cached_remote_url = (
2618 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002619 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2620 self.assertEqual(cl1._GetChangeDetail(), 'a')
2621 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2622 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2623 self.assertEqual(cl1._GetChangeDetail(), 'a')
2624 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002625
2626 def test_gerrit_change_detail_cache_options(self):
2627 self._mock_gerrit_changes_for_detail_cache()
2628 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002629 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2630 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2631 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2632 # no longer in cache.
2633 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002634 ]
2635 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002636 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002637 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2638 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2639 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2640 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2641 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2642 self.assertEqual(cl._GetChangeDetail(), 'cab')
2643
2644 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2645 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2646 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2647 self.assertEqual(cl._GetChangeDetail(), 'cab')
2648
2649 # Finally, no_cache should invalidate all caches for given change.
2650 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2651 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2652
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002653 def test_gerrit_description_caching(self):
2654 def gen_detail(rev, desc):
2655 return {
2656 'current_revision': rev,
2657 'revisions': {rev: {'commit': {'message': desc}}}
2658 }
2659 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002660 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002661 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2662 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002663 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002664 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2665 gen_detail('rev2', 'desc2')),
2666 ]
2667
2668 self._mock_gerrit_changes_for_detail_cache()
2669 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002670 cl._cached_remote_url = (
2671 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002672 self.assertEqual(cl.GetDescription(), 'desc1')
2673 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2674 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002675
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002676 def test_print_current_creds(self):
2677 class CookiesAuthenticatorMock(object):
2678 def __init__(self):
2679 self.gitcookies = {
2680 'host.googlesource.com': ('user', 'pass'),
2681 'host-review.googlesource.com': ('user', 'pass'),
2682 }
2683 self.netrc = self
2684 self.netrc.hosts = {
2685 'github.com': ('user2', None, 'pass2'),
2686 'host2.googlesource.com': ('user3', None, 'pass'),
2687 }
2688 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2689 CookiesAuthenticatorMock)
2690 self.mock(sys, 'stdout', StringIO.StringIO())
2691 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2692 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2693 ' Host\t User\t Which file',
2694 '============================\t=====\t===========',
2695 'host-review.googlesource.com\t user\t.gitcookies',
2696 ' host.googlesource.com\t user\t.gitcookies',
2697 ' host2.googlesource.com\tuser3\t .netrc',
2698 ])
2699 sys.stdout.buf = ''
2700 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2701 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2702 ' Host\tUser\t Which file',
2703 '============================\t====\t===========',
2704 'host-review.googlesource.com\tuser\t.gitcookies',
2705 ' host.googlesource.com\tuser\t.gitcookies',
2706 ])
2707
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002708 def _common_creds_check_mocks(self):
2709 def exists_mock(path):
2710 dirname = os.path.dirname(path)
2711 if dirname == os.path.expanduser('~'):
2712 dirname = '~'
2713 base = os.path.basename(path)
2714 if base in ('.netrc', '.gitcookies'):
2715 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2716 # git cl also checks for existence other files not relevant to this test.
2717 return None
2718 self.mock(os.path, 'exists', exists_mock)
2719 self.mock(sys, 'stdout', StringIO.StringIO())
2720
2721 def test_creds_check_gitcookies_not_configured(self):
2722 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002723 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002724 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002725 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002726 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002727 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2728 (('os.path.exists', '~/.netrc'), True),
2729 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2730 'or Ctrl+C to abort'), ''),
2731 ((['git', 'config', '--global', 'http.cookiefile',
2732 os.path.expanduser('~/.gitcookies')], ), ''),
2733 ]
2734 self.assertEqual(0, git_cl.main(['creds-check']))
2735 self.assertRegexpMatches(
2736 sys.stdout.getvalue(),
2737 '^You seem to be using outdated .netrc for git credentials:')
2738 self.assertRegexpMatches(
2739 sys.stdout.getvalue(),
2740 '\nConfigured git to use .gitcookies from')
2741
2742 def test_creds_check_gitcookies_configured_custom_broken(self):
2743 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002744 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002745 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002746 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002747 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002748 ((['git', 'config', '--global', 'http.cookiefile'],),
2749 '/custom/.gitcookies'),
2750 (('os.path.exists', '/custom/.gitcookies'), False),
2751 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2752 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2753 ((['git', 'config', '--global', 'http.cookiefile',
2754 os.path.expanduser('~/.gitcookies')], ), ''),
2755 ]
2756 self.assertEqual(0, git_cl.main(['creds-check']))
2757 self.assertRegexpMatches(
2758 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002759 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002760 self.assertRegexpMatches(
2761 sys.stdout.getvalue(),
2762 'However, your configured .gitcookies file is missing.')
2763
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002764 def test_git_cl_comment_add_gerrit(self):
2765 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002766 lambda host, change, msg, ready:
2767 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002768 self.calls = [
2769 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2770 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2771 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2772 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2773 'origin/master'),
2774 ((['git', 'config', 'remote.origin.url'],),
2775 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002776 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2777 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002778 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002779 ]
2780 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2781 '-a', 'msg']))
2782
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002783 def test_git_cl_comments_fetch_gerrit(self):
2784 self.mock(sys, 'stdout', StringIO.StringIO())
2785 self.calls = [
2786 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2787 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2788 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2789 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2790 'origin/master'),
2791 ((['git', 'config', 'remote.origin.url'],),
2792 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002793 (('GetChangeDetail', 'chromium-review.googlesource.com',
2794 'infra%2Finfra~1',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002795 ['MESSAGES', 'DETAILED_ACCOUNTS']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002796 'owner': {'email': 'owner@example.com'},
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002797 'messages': [
2798 {
2799 u'_revision_number': 1,
2800 u'author': {
2801 u'_account_id': 1111084,
2802 u'email': u'commit-bot@chromium.org',
2803 u'name': u'Commit Bot'
2804 },
2805 u'date': u'2017-03-15 20:08:45.000000000',
2806 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002807 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002808 u'tag': u'autogenerated:cq:dry-run'
2809 },
2810 {
2811 u'_revision_number': 2,
2812 u'author': {
2813 u'_account_id': 11151243,
2814 u'email': u'owner@example.com',
2815 u'name': u'owner'
2816 },
2817 u'date': u'2017-03-16 20:00:41.000000000',
2818 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2819 u'message': u'PTAL',
2820 },
2821 {
2822 u'_revision_number': 2,
2823 u'author': {
2824 u'_account_id': 148512 ,
2825 u'email': u'reviewer@example.com',
2826 u'name': u'reviewer'
2827 },
2828 u'date': u'2017-03-17 05:19:37.500000000',
2829 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2830 u'message': u'Patch Set 2: Code-Review+1',
2831 },
2832 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002833 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002834 (('GetChangeComments', 'chromium-review.googlesource.com',
2835 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002836 '/COMMIT_MSG': [
2837 {
2838 'author': {'email': u'reviewer@example.com'},
2839 'updated': u'2017-03-17 05:19:37.500000000',
2840 'patch_set': 2,
2841 'side': 'REVISION',
2842 'message': 'Please include a bug link',
2843 },
2844 ],
2845 'codereview.settings': [
2846 {
2847 'author': {'email': u'owner@example.com'},
2848 'updated': u'2017-03-16 20:00:41.000000000',
2849 'patch_set': 2,
2850 'side': 'PARENT',
2851 'line': 42,
2852 'message': 'I removed this because it is bad',
2853 },
2854 ]
Leszek Swirski45b20c42018-09-17 17:05:26 +00002855 })
2856 ] * 2 + [
2857 (('write_json', 'output.json', [
2858 {
2859 u'date': u'2017-03-16 20:00:41.000000',
2860 u'message': (
2861 u'PTAL\n' +
2862 u'\n' +
2863 u'codereview.settings\n' +
2864 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2865 u'c/1/2/codereview.settings#b42\n' +
2866 u' I removed this because it is bad\n'),
2867 u'approval': False,
2868 u'disapproval': False,
2869 u'sender': u'owner@example.com'
2870 }, {
2871 u'date': u'2017-03-17 05:19:37.500000',
2872 u'message': (
2873 u'Patch Set 2: Code-Review+1\n' +
2874 u'\n' +
2875 u'/COMMIT_MSG\n' +
2876 u' PS2, File comment: https://chromium-review.googlesource' +
2877 u'.com/c/1/2//COMMIT_MSG#\n' +
2878 u' Please include a bug link\n'),
2879 u'approval': False,
2880 u'disapproval': False,
2881 u'sender': u'reviewer@example.com'
2882 }
2883 ]),'')
2884 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002885 expected_comments_summary = [
2886 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002887 message=(
2888 u'PTAL\n' +
2889 u'\n' +
2890 u'codereview.settings\n' +
2891 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2892 u'c/1/2/codereview.settings#b42\n' +
2893 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002894 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2895 disapproval=False, approval=False, sender=u'owner@example.com'),
2896 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002897 message=(
2898 u'Patch Set 2: Code-Review+1\n' +
2899 u'\n' +
2900 u'/COMMIT_MSG\n' +
2901 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2902 u'c/1/2//COMMIT_MSG#\n' +
2903 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002904 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
2905 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2906 ]
2907 cl = git_cl.Changelist(codereview='gerrit', issue=1)
2908 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov642641d2018-10-16 05:54:41 +00002909 self.assertEqual(0, git_cl.main(['comment', '-i', '1',
Leszek Swirski45b20c42018-09-17 17:05:26 +00002910 '-j', 'output.json']))
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002911
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002912 def test_get_remote_url_with_mirror(self):
2913 original_os_path_isdir = os.path.isdir
2914 def selective_os_path_isdir_mock(path):
2915 if path == '/cache/this-dir-exists':
2916 return self._mocked_call('os.path.isdir', path)
2917 return original_os_path_isdir(path)
2918 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2919
2920 url = 'https://chromium.googlesource.com/my/repo'
2921 self.calls = [
2922 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2923 ((['git', 'config', 'branch.master.merge'],), 'master'),
2924 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2925 ((['git', 'config', 'remote.origin.url'],),
2926 '/cache/this-dir-exists'),
2927 (('os.path.isdir', '/cache/this-dir-exists'),
2928 True),
2929 # Runs in /cache/this-dir-exists.
2930 ((['git', 'config', 'remote.origin.url'],),
2931 url),
2932 ]
2933 cl = git_cl.Changelist(codereview='gerrit', issue=1)
2934 self.assertEqual(cl.GetRemoteUrl(), url)
2935 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2936
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002937 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002938 self.calls = [
2939 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2940 ((['git', 'config', 'branch.master.merge'],), 'master'),
2941 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2942 ((['git', 'config', 'remote.origin.url'],),
2943 'https://chromium.googlesource.com/a/my/repo.git/'),
2944 ]
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002945 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
2946 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2947
2948 def test_gerrit_change_identifier_without_project(self):
2949 self.calls = [
2950 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2951 ((['git', 'config', 'branch.master.merge'],), 'master'),
2952 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2953 ((['git', 'config', 'remote.origin.url'],), CERR1),
2954 ]
2955 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
2956 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002957
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002958
maruel@chromium.orgddd59412011-11-30 14:20:38 +00002959if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01002960 logging.basicConfig(
2961 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00002962 unittest.main()