blob: 1672b0016b9ac338554cfb21b5907cc11ab39430 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01009import datetime
tandriide281ae2016-10-12 06:02:30 -070010import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010011import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000012import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
22
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000023import metrics
24# We have to disable monitoring before importing git_cl.
25metrics.DISABLE_METRICS_COLLECTION = True
26
maruel@chromium.orgddd59412011-11-30 14:20:38 +000027import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000028import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000029import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000030import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031
tandrii5d48c322016-08-18 16:19:37 -070032def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
33 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
34
35
36CERR1 = callError(1)
37
38
Aaron Gable9a03ae02017-11-03 11:31:07 -070039def MakeNamedTemporaryFileMock(expected_content):
40 class NamedTemporaryFileMock(object):
41 def __init__(self, *args, **kwargs):
42 self.name = '/tmp/named'
43 self.expected_content = expected_content
44
45 def __enter__(self):
46 return self
47
48 def __exit__(self, _type, _value, _tb):
49 pass
50
51 def write(self, content):
52 if self.expected_content:
53 assert content == self.expected_content
54
55 def close(self):
56 pass
57
58 return NamedTemporaryFileMock
59
60
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000061class ChangelistMock(object):
62 # A class variable so we can access it when we don't have access to the
63 # instance that's being set.
64 desc = ""
65 def __init__(self, **kwargs):
66 pass
67 def GetIssue(self):
68 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080069 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000070 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070071 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000072 ChangelistMock.desc = desc
73
tandrii5d48c322016-08-18 16:19:37 -070074
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000075class PresubmitMock(object):
76 def __init__(self, *args, **kwargs):
77 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080078 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
79
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000080 @staticmethod
81 def should_continue():
82 return True
83
84
85class RietveldMock(object):
86 def __init__(self, *args, **kwargs):
87 pass
maruel@chromium.org78936cb2013-04-11 00:17:52 +000088
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000089 @staticmethod
Kenneth Russell61e2ed42017-02-15 11:47:13 -080090 def get_description(issue, force=False):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000091 return 'Issue: %d' % issue
92
maruel@chromium.org78936cb2013-04-11 00:17:52 +000093 @staticmethod
94 def get_issue_properties(_issue, _messages):
95 return {
96 'reviewers': ['joe@chromium.org', 'john@chromium.org'],
97 'messages': [
98 {
99 'approval': True,
Aaron Gablea1bab272017-04-11 16:38:18 -0700100 'disapproval': False,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000101 'sender': 'john@chromium.org',
102 },
103 ],
Andrii Shyshkalov06a25022016-11-24 16:47:00 +0100104 'patchsets': [1, 20001],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000105 }
106
iannuccie53c9352016-08-17 14:40:40 -0700107 @staticmethod
108 def close_issue(_issue):
109 return 'Closed'
110
skobes6468b902016-10-24 08:45:10 -0700111 @staticmethod
112 def get_patch(issue, patchset):
113 return 'patch set from issue %s patchset %s' % (issue, patchset)
114
Andrii Shyshkalov06a25022016-11-24 16:47:00 +0100115 @staticmethod
116 def update_description(_issue, _description):
117 return 'Updated'
118
119 @staticmethod
120 def add_comment(_issue, _comment):
121 return 'Commented'
122
123
skobes6468b902016-10-24 08:45:10 -0700124class GitCheckoutMock(object):
125 def __init__(self, *args, **kwargs):
126 pass
127
128 @staticmethod
129 def reset():
130 GitCheckoutMock.conflict = False
131
132 def apply_patch(self, p):
133 if GitCheckoutMock.conflict:
134 raise Exception('failed')
135
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000136
137class WatchlistsMock(object):
138 def __init__(self, _):
139 pass
140 @staticmethod
141 def GetWatchersForPaths(_):
142 return ['joe@example.com']
143
144
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000145class CodereviewSettingsFileMock(object):
146 def __init__(self):
147 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800148 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000149 def read(self):
150 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000151 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000152
153
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000154class AuthenticatorMock(object):
155 def __init__(self, *_args):
156 pass
157 def has_cached_credentials(self):
158 return True
tandrii221ab252016-10-06 08:12:04 -0700159 def authorize(self, http):
160 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000161
162
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100163def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000164 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
165
166 Usage:
167 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100168 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000169
170 OR
171 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100172 CookiesAuthenticatorMockFactory(
173 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000174 """
175 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800176 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000177 # Intentionally not calling super() because it reads actual cookie files.
178 pass
179 @classmethod
180 def get_gitcookies_path(cls):
181 return '~/.gitcookies'
182 @classmethod
183 def get_netrc_path(cls):
184 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100185 def _get_auth_for_host(self, host):
186 if same_auth:
187 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000188 return (hosts_with_creds or {}).get(host)
189 return CookiesAuthenticatorMock
190
Aaron Gable9a03ae02017-11-03 11:31:07 -0700191
kmarshall9249e012016-08-23 12:02:16 -0700192class MockChangelistWithBranchAndIssue():
193 def __init__(self, branch, issue):
194 self.branch = branch
195 self.issue = issue
196 def GetBranch(self):
197 return self.branch
198 def GetIssue(self):
199 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000200
tandriic2405f52016-10-10 08:13:15 -0700201
202class SystemExitMock(Exception):
203 pass
204
205
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000206class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100207 def test_get_description(self):
208 cl = git_cl.Changelist(issue=1, codereview='rietveld',
209 codereview_host='host')
210 cl.description = 'x'
211 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800212 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100213 self.assertEquals(cl.GetDescription(), 'x')
214 self.assertEquals(cl.GetDescription(force=True), 'y')
215 self.assertEquals(cl.GetDescription(), 'y')
216
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700217 def test_description_footers(self):
218 cl = git_cl.Changelist(issue=1, codereview='gerrit',
219 codereview_host='host')
220 cl.description = '\n'.join([
221 'This is some message',
222 '',
223 'It has some lines',
224 'and, also',
225 '',
226 'Some: Really',
227 'Awesome: Footers',
228 ])
229 cl.has_description = True
230 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
231 msg, footers = cl.GetDescriptionFooters()
232 self.assertEquals(
233 msg, ['This is some message', '', 'It has some lines', 'and, also'])
234 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
235
236 msg.append('wut')
237 footers.append(('gnarly-dude', 'beans'))
238 cl.UpdateDescriptionFooters(msg, footers)
239 self.assertEquals(cl.GetDescription().splitlines(), [
240 'This is some message',
241 '',
242 'It has some lines',
243 'and, also',
244 'wut'
245 '',
246 'Some: Really',
247 'Awesome: Footers',
248 'Gnarly-Dude: beans',
249 ])
250
tandriif9aefb72016-07-01 09:06:51 -0700251 def test_get_bug_line_values(self):
252 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
253 self.assertEqual(f('', ''), [])
254 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
255 self.assertEqual(f('v8', '456'), ['v8:456'])
256 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
257 # Not nice, but not worth carying.
258 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
259 ['v8:456', 'chromium:123', 'v8:123'])
260
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100261 def _test_git_number(self, parent_msg, dest_ref, child_msg,
262 parent_hash='parenthash'):
263 desc = git_cl.ChangeDescription(child_msg)
264 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
265 return desc.description
266
267 def assertEqualByLine(self, actual, expected):
268 self.assertEqual(actual.splitlines(), expected.splitlines())
269
270 def test_git_number_bad_parent(self):
271 with self.assertRaises(ValueError):
272 self._test_git_number('Parent', 'refs/heads/master', 'Child')
273
274 def test_git_number_bad_parent_footer(self):
275 with self.assertRaises(AssertionError):
276 self._test_git_number(
277 'Parent\n'
278 '\n'
279 'Cr-Commit-Position: wrong',
280 'refs/heads/master', 'Child')
281
282 def test_git_number_bad_lineage_ignored(self):
283 actual = self._test_git_number(
284 'Parent\n'
285 '\n'
286 'Cr-Commit-Position: refs/heads/master@{#1}\n'
287 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
288 'refs/heads/master', 'Child')
289 self.assertEqualByLine(
290 actual,
291 'Child\n'
292 '\n'
293 'Cr-Commit-Position: refs/heads/master@{#2}\n'
294 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
295
296 def test_git_number_same_branch(self):
297 actual = self._test_git_number(
298 'Parent\n'
299 '\n'
300 'Cr-Commit-Position: refs/heads/master@{#12}',
301 dest_ref='refs/heads/master',
302 child_msg='Child')
303 self.assertEqualByLine(
304 actual,
305 'Child\n'
306 '\n'
307 'Cr-Commit-Position: refs/heads/master@{#13}')
308
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200309 def test_git_number_same_branch_mixed_footers(self):
310 actual = self._test_git_number(
311 'Parent\n'
312 '\n'
313 'Cr-Commit-Position: refs/heads/master@{#12}',
314 dest_ref='refs/heads/master',
315 child_msg='Child\n'
316 '\n'
317 'Broken-by: design\n'
318 'BUG=123')
319 self.assertEqualByLine(
320 actual,
321 'Child\n'
322 '\n'
323 'Broken-by: design\n'
324 'BUG=123\n'
325 'Cr-Commit-Position: refs/heads/master@{#13}')
326
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100327 def test_git_number_same_branch_with_originals(self):
328 actual = self._test_git_number(
329 'Parent\n'
330 '\n'
331 'Cr-Commit-Position: refs/heads/master@{#12}',
332 dest_ref='refs/heads/master',
333 child_msg='Child\n'
334 '\n'
335 'Some users are smart and insert their own footers\n'
336 '\n'
337 'Cr-Whatever: value\n'
338 'Cr-Commit-Position: refs/copy/paste@{#22}')
339 self.assertEqualByLine(
340 actual,
341 'Child\n'
342 '\n'
343 'Some users are smart and insert their own footers\n'
344 '\n'
345 'Cr-Original-Whatever: value\n'
346 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
347 'Cr-Commit-Position: refs/heads/master@{#13}')
348
349 def test_git_number_new_branch(self):
350 actual = self._test_git_number(
351 'Parent\n'
352 '\n'
353 'Cr-Commit-Position: refs/heads/master@{#12}',
354 dest_ref='refs/heads/branch',
355 child_msg='Child')
356 self.assertEqualByLine(
357 actual,
358 'Child\n'
359 '\n'
360 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
361 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
362
363 def test_git_number_lineage(self):
364 actual = self._test_git_number(
365 'Parent\n'
366 '\n'
367 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
368 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
369 dest_ref='refs/heads/branch',
370 child_msg='Child')
371 self.assertEqualByLine(
372 actual,
373 'Child\n'
374 '\n'
375 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
376 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
377
378 def test_git_number_moooooooore_lineage(self):
379 actual = self._test_git_number(
380 'Parent\n'
381 '\n'
382 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
383 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
384 dest_ref='refs/heads/mooore',
385 child_msg='Child')
386 self.assertEqualByLine(
387 actual,
388 'Child\n'
389 '\n'
390 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
391 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
392 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
393
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100394 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700395 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100396 actual = self._test_git_number(
397 'CQ commit on fresh new branch + numbering.\n'
398 '\n'
399 'NOTRY=True\n'
400 'NOPRESUBMIT=True\n'
401 'BUG=\n'
402 '\n'
403 'Review-Url: https://codereview.chromium.org/2577703003\n'
404 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
405 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
406 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
407 dest_ref='refs/heads/gnumb-test/cl',
408 child_msg='git cl on fresh new branch + numbering.\n'
409 '\n'
410 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
411 self.assertEqualByLine(
412 actual,
413 'git cl on fresh new branch + numbering.\n'
414 '\n'
415 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
416 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
417 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
418 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
419 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100420
421 def test_git_number_cherry_pick(self):
422 actual = self._test_git_number(
423 'Parent\n'
424 '\n'
425 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
426 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
427 dest_ref='refs/heads/branch',
428 child_msg='Child, which is cherry-pick from master\n'
429 '\n'
430 'Cr-Commit-Position: refs/heads/master@{#100}\n'
431 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
432 self.assertEqualByLine(
433 actual,
434 'Child, which is cherry-pick from master\n'
435 '\n'
436 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
437 '\n'
438 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
439 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
440 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
441
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000442 def test_gerrit_mirror_hack(self):
443 cr = 'chromium-review.googlesource.com'
444 url0 = 'https://%s/a/changes/x?a=b' % cr
445 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
446 try:
447 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
448 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
449 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
450 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
451
452 self.assertNotEqual(url1, url2)
453 self.assertEqual(sorted((url1, url2)), [
454 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
455 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
456 self.assertEqual(url1, url3)
457 finally:
458 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
459
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000460
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200461class TestParseIssueURL(unittest.TestCase):
462 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
463 codereview=None, fail=False):
464 self.assertIsNotNone(parsed)
465 if fail:
466 self.assertFalse(parsed.valid)
467 return
468 self.assertTrue(parsed.valid)
469 self.assertEqual(parsed.issue, issue)
470 self.assertEqual(parsed.patchset, patchset)
471 self.assertEqual(parsed.hostname, hostname)
472 self.assertEqual(parsed.codereview, codereview)
473
474 def _run_and_validate(self, func, url, *args, **kwargs):
475 result = func(urlparse.urlparse(url))
476 if kwargs.pop('fail', False):
477 self.assertIsNone(result)
478 return None
479 self._validate(result, *args, fail=False, **kwargs)
480
481 def test_rietveld(self):
482 def test(url, *args, **kwargs):
483 self._run_and_validate(git_cl._RietveldChangelistImpl.ParseIssueURL, url,
484 *args, codereview='rietveld', **kwargs)
485
486 test('http://codereview.chromium.org/123',
487 123, None, 'codereview.chromium.org')
488 test('https://codereview.chromium.org/123',
489 123, None, 'codereview.chromium.org')
490 test('https://codereview.chromium.org/123/',
491 123, None, 'codereview.chromium.org')
492 test('https://codereview.chromium.org/123/whatever',
493 123, None, 'codereview.chromium.org')
494 test('https://codereview.chromium.org/123/#ps20001',
495 123, 20001, 'codereview.chromium.org')
496 test('http://codereview.chromium.org/download/issue123_4.diff',
497 123, 4, 'codereview.chromium.org')
498 # This looks like bad Gerrit, but is actually valid Rietveld, too.
499 test('https://chrome-review.source.com/123/4/',
500 123, None, 'chrome-review.source.com')
501
502 test('https://codereview.chromium.org/deadbeaf', fail=True)
503 test('https://codereview.chromium.org/api/123', fail=True)
504 test('bad://codereview.chromium.org/123', fail=True)
505 test('http://codereview.chromium.org/download/issue123_4.diffff', fail=True)
506
507 def test_gerrit(self):
508 def test(url, issue=None, patchset=None, hostname=None, fail=None):
509 self._test_ParseIssueUrl(
510 git_cl._GerritChangelistImpl.ParseIssueURL,
511 url, issue, patchset, hostname, fail)
512 def test(url, *args, **kwargs):
513 self._run_and_validate(git_cl._GerritChangelistImpl.ParseIssueURL, url,
514 *args, codereview='gerrit', **kwargs)
515
516 test('http://chrome-review.source.com/c/123',
517 123, None, 'chrome-review.source.com')
518 test('https://chrome-review.source.com/c/123/',
519 123, None, 'chrome-review.source.com')
520 test('https://chrome-review.source.com/c/123/4',
521 123, 4, 'chrome-review.source.com')
522 test('https://chrome-review.source.com/#/c/123/4',
523 123, 4, 'chrome-review.source.com')
524 test('https://chrome-review.source.com/c/123/4',
525 123, 4, 'chrome-review.source.com')
526 test('https://chrome-review.source.com/123',
527 123, None, 'chrome-review.source.com')
528 test('https://chrome-review.source.com/123/4',
529 123, 4, 'chrome-review.source.com')
530
531 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
532 test('https://chrome-review.source.com/c/abc/', fail=True)
533 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
534
535 def test_ParseIssueNumberArgument(self):
536 def test(arg, *args, **kwargs):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200537 codereview_hint = kwargs.pop('hint', None)
538 self._validate(git_cl.ParseIssueNumberArgument(arg, codereview_hint),
539 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200540
541 test('123', 123)
542 test('', fail=True)
543 test('abc', fail=True)
544 test('123/1', fail=True)
545 test('123a', fail=True)
546 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
547 # Rietveld.
548 test('https://codereview.source.com/www123', fail=True)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200549 # Matches both, but we take Rietveld now by default.
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200550 test('https://codereview.source.com/123',
551 123, None, 'codereview.source.com', 'rietveld')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200552 # Matches both, but we take Gerrit if specifically requested.
553 test('https://codereview.source.com/123',
554 123, None, 'codereview.source.com', 'gerrit',
555 hint='gerrit')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200556 # Gerrrit.
557 test('https://chrome-review.source.com/c/123/4',
558 123, 4, 'chrome-review.source.com', 'gerrit')
559 test('https://chrome-review.source.com/bad/123/4', fail=True)
560
561
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100562class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563 def setUp(self):
564 super(GitCookiesCheckerTest, self).setUp()
565 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100566 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100567
568 def mock_hosts_creds(self, subhost_identity_pairs):
569 def ensure_googlesource(h):
570 if not h.endswith(self.c._GOOGLESOURCE):
571 assert not h.endswith('.')
572 return h + '.' + self.c._GOOGLESOURCE
573 return h
574 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
575 for h, i in subhost_identity_pairs]
576
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200577 def test_identity_parsing(self):
578 self.assertEqual(self.c._parse_identity('ldap.google.com'),
579 ('ldap', 'google.com'))
580 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
581 ('ldap', 'example.com'))
582 # Specical case because we know there are no subdomains in chromium.org.
583 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
584 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800585 # Pathological: ".period." can be either username OR domain, more likely
586 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200587 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
588 ('note', 'period.example.com'))
589
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100590 def test_analysis_nothing(self):
591 self.c._all_hosts = []
592 self.assertFalse(self.c.has_generic_host())
593 self.assertEqual(set(), self.c.get_conflicting_hosts())
594 self.assertEqual(set(), self.c.get_duplicated_hosts())
595 self.assertEqual(set(), self.c.get_partially_configured_hosts())
596 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
597
598 def test_analysis(self):
599 self.mock_hosts_creds([
600 ('.googlesource.com', 'git-example.chromium.org'),
601
602 ('chromium', 'git-example.google.com'),
603 ('chromium-review', 'git-example.google.com'),
604 ('chrome-internal', 'git-example.chromium.org'),
605 ('chrome-internal-review', 'git-example.chromium.org'),
606 ('conflict', 'git-example.google.com'),
607 ('conflict-review', 'git-example.chromium.org'),
608 ('dup', 'git-example.google.com'),
609 ('dup', 'git-example.google.com'),
610 ('dup-review', 'git-example.google.com'),
611 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200612 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100613 ])
614 self.assertTrue(self.c.has_generic_host())
615 self.assertEqual(set(['conflict.googlesource.com']),
616 self.c.get_conflicting_hosts())
617 self.assertEqual(set(['dup.googlesource.com']),
618 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200619 self.assertEqual(set(['partial.googlesource.com',
620 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100621 self.c.get_partially_configured_hosts())
622 self.assertEqual(set(['chromium.googlesource.com',
623 'chrome-internal.googlesource.com']),
624 self.c.get_hosts_with_wrong_identities())
625
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100626 def test_report_no_problems(self):
627 self.test_analysis_nothing()
628 self.mock(sys, 'stdout', StringIO.StringIO())
629 self.assertFalse(self.c.find_and_report_problems())
630 self.assertEqual(sys.stdout.getvalue(), '')
631
632 def test_report(self):
633 self.test_analysis()
634 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200635 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
636 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100637 self.assertTrue(self.c.find_and_report_problems())
638 with open(os.path.join(os.path.dirname(__file__),
639 'git_cl_creds_check_report.txt')) as f:
640 expected = f.read()
641 def by_line(text):
642 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700643 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200644 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100645
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800646
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000647class TestGitCl(TestCase):
648 def setUp(self):
649 super(TestGitCl, self).setUp()
650 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700651 self._calls_done = []
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000652 self.mock(subprocess2, 'call', self._mocked_call)
653 self.mock(subprocess2, 'check_call', self._mocked_call)
654 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700655 self.mock(subprocess2, 'communicate',
656 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000657 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000658 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000659 self.mock(git_common, 'get_or_create_merge_base',
660 lambda *a: (
661 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000662 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000663 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000664 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
665 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100666 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000667 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700668 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000669 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000670 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000671 self.mock(git_cl.rietveld, 'Rietveld', RietveldMock)
maruel@chromium.org4bac4b52012-11-27 20:33:52 +0000672 self.mock(git_cl.rietveld, 'CachingRietveld', RietveldMock)
skobes6468b902016-10-24 08:45:10 -0700673 self.mock(git_cl.checkout, 'GitCheckout', GitCheckoutMock)
674 GitCheckoutMock.reset()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000675 self.mock(git_cl.upload, 'RealMain', self.fail)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000676 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000677 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100678 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
679 lambda *args, **kwargs: self._mocked_call(
680 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700681 self.mock(git_cl.gerrit_util, 'GetChangeComments',
682 lambda *args, **kwargs: self._mocked_call(
683 'GetChangeComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100684 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700685 lambda h, i, reviewers, ccs, notify: self._mocked_call(
686 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700687 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700688 lambda h, i, msg=None, labels=None, notify=None:
689 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700690 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
691 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000692 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
693 classmethod(lambda _: False))
tandriic2405f52016-10-10 08:13:15 -0700694 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100695 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000696 # It's important to reset settings to not have inter-tests interference.
697 git_cl.settings = None
698
699 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000700 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100701 self.assertEquals([], self.calls)
702 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000703 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100704 raise
705 # Sadly, has_failed() returns True if this OR any other tests before this
706 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200707 git_cl.logging.error(
708 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100709 'There are un-consumed self.calls after this test has finished.\n'
710 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700711 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200712 'If you are already running only this test, then **first** fix the '
713 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100714 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700715 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100716 'and follow instructions above.\n' +
717 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000718 finally:
719 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000720
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000721 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000722 self.assertTrue(
723 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700724 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000725 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000726 expected_args, result = top
727
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000728 # Also logs otherwise it could get caught in a try/finally and be hard to
729 # diagnose.
730 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700731 N = 5
732 prior_calls = '\n '.join(
733 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
734 for i, c in enumerate(self._calls_done[-N:]))
735 following_calls = '\n '.join(
736 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
737 for i, c in enumerate(self.calls[:N]))
738 extended_msg = (
739 'A few prior calls:\n %s\n\n'
740 'This (expected):\n @%d: %r\n'
741 'This (actual):\n @%d: %r\n\n'
742 'A few following expected calls:\n %s' %
743 (prior_calls, len(self._calls_done), expected_args,
744 len(self._calls_done), args, following_calls))
745 git_cl.logging.error(extended_msg)
746
tandrii99a72f22016-08-17 14:33:24 -0700747 self.fail('@%d\n'
748 ' Expected: %r\n'
749 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700750 len(self._calls_done), expected_args, args))
751
752 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700753 if isinstance(result, Exception):
754 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000755 return result
756
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100757 def test_ask_for_explicit_yes_true(self):
758 self.calls = [
759 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
760 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
761 ]
762 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
763
tandrii48df5812016-10-17 03:55:37 -0700764 def test_LoadCodereviewSettingsFromFile_gerrit(self):
765 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
766 self.calls = [
767 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
768 ((['git', 'config', '--unset-all', 'rietveld.private'],), CERR1),
769 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
770 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
771 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
772 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700773 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
774 CERR1),
775 ((['git', 'config', '--unset-all', 'rietveld.project'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700776 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
777 CERR1),
778 ((['git', 'config', 'gerrit.host', 'true'],), ''),
779 ]
780 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
781
maruel@chromium.orga3353652011-11-30 14:26:57 +0000782 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000783 def _is_gerrit_calls(cls, gerrit=False):
784 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
785 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
786
787 @classmethod
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +0000788 def _upload_calls(cls, private, no_autocc):
Aaron Gable13101a62018-02-09 13:20:41 -0800789 return (cls._rietveld_git_base_calls() +
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +0000790 cls._git_upload_calls(private, no_autocc))
maruel@chromium.orga3353652011-11-30 14:26:57 +0000791
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000792 @classmethod
Aaron Gable13101a62018-02-09 13:20:41 -0800793 def _rietveld_upload_no_rev_calls(cls):
794 return (cls._rietveld_git_base_calls() + [
Andrii Shyshkalov73827d12017-04-12 15:05:11 +0200795 ((['git', 'config', 'core.editor'],), ''),
796 ])
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000797
798 @classmethod
Aaron Gable13101a62018-02-09 13:20:41 -0800799 def _rietveld_git_base_calls(cls):
800 stat_call = ((['git', 'diff', '--no-ext-diff', '--stat',
801 '-l100000', '-C50', 'fake_ancestor_sha', 'HEAD'],), '+dat')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000802
Aaron Gable13101a62018-02-09 13:20:41 -0800803 return cls._is_gerrit_calls() + [
tandrii@chromium.org87985d22016-03-24 17:33:33 +0000804 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -0700805 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
806 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000807 ((['git', 'config', 'rietveld.server'],),
808 'codereview.example.com'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000809 ((['git', 'config', 'branch.master.merge'],), 'master'),
810 ((['git', 'config', 'branch.master.remote'],), 'origin'),
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000811 ((['get_or_create_merge_base', 'master', 'master'],),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000812 'fake_ancestor_sha'),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000813 ] + cls._git_sanity_checks('fake_ancestor_sha', 'master') + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000814 ((['git', 'rev-parse', '--show-cdup'],), ''),
815 ((['git', 'rev-parse', 'HEAD'],), '12345'),
Aaron Gable7817f022017-12-12 09:43:17 -0800816 ((['git', '-c', 'core.quotePath=false', 'diff',
817 '--name-status', '--no-renames', '-r', 'fake_ancestor_sha...', '.'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000818 'M\t.gitignore\n'),
tandrii33a46ff2016-08-23 05:53:40 -0700819 ((['git', 'config', 'branch.master.rietveldpatchset'],), CERR1),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000820 ((['git', 'log', '--pretty=format:%s%n%n%b',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000821 'fake_ancestor_sha...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000822 'foo'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000823 ((['git', 'config', 'user.email'],), 'me@example.com'),
iannucci@chromium.org79540052012-10-19 23:15:26 +0000824 stat_call,
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000825 ((['git', 'log', '--pretty=format:%s\n\n%b',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000826 'fake_ancestor_sha..HEAD'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000827 'desc\n'),
Aaron Gable3a16ed12017-03-23 10:51:55 -0700828 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
maruel@chromium.orga3353652011-11-30 14:26:57 +0000829 ]
830
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000831 @classmethod
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +0000832 def _git_upload_calls(cls, private, no_autocc):
833 if private or no_autocc:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000834 cc_call = []
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000835 else:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000836 cc_call = [((['git', 'config', 'rietveld.cc'],), '')]
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +0000837
838 if private:
839 private_call = []
840 else:
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000841 private_call = [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000842 ((['git', 'config', 'rietveld.private'],), '')]
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000843
maruel@chromium.orga3353652011-11-30 14:26:57 +0000844 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000845 ((['git', 'config', 'core.editor'],), ''),
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000846 ] + cc_call + private_call + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000847 ((['git', 'config', 'branch.master.base-url'],), ''),
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800848 ((['git', 'config', 'remote.origin.url'],), ''),
sheyang@chromium.org152cf832014-06-11 21:37:49 +0000849 ((['git', 'config', 'rietveld.project'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -0700850 ((['git', 'config', 'branch.master.rietveldissue', '1'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000851 ((['git', 'config', 'branch.master.rietveldserver',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000852 'https://codereview.example.com'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000853 ((['git',
tandrii33a46ff2016-08-23 05:53:40 -0700854 'config', 'branch.master.rietveldpatchset', '2'],), ''),
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000855 ] + cls._git_post_upload_calls()
856
857 @classmethod
858 def _git_post_upload_calls(cls):
859 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000860 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
861 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
862 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000863 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000864 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000865 ]
866
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000867 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000868 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000869 fake_ancestor = 'fake_ancestor'
870 fake_cl = 'fake_cl_for_patch'
871 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000872 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000873 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000874 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000875 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000876 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000877 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000878 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000879 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700880 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000881 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000882 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000883 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000884 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000885 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000886 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000887 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000888 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000889 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000890 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000891 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000892
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000893 @staticmethod
Aaron Gable13101a62018-02-09 13:20:41 -0800894 def _cmd_line(description, args, private, cc):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000895 """Returns the upload command line passed to upload.RealMain()."""
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000896 return [
Daniel Cheng7227d212017-11-17 08:12:37 -0800897 'upload', '--assume_yes', '--server', 'https://codereview.example.com',
maruel@chromium.org71e12a92012-02-14 02:34:15 +0000898 '--message', description
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000899 ] + args + [
Daniel Cheng7227d212017-11-17 08:12:37 -0800900 '--cc',
901 ','.join(
902 ['joe@example.com', 'chromium-reviews+test-more-cc@chromium.org'] +
903 cc),
Aaron Gable13101a62018-02-09 13:20:41 -0800904 ] + (['--private'] if private else []) + ['fake_ancestor_sha', 'HEAD']
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000905
906 def _run_reviewer_test(
907 self,
908 upload_args,
909 expected_description,
910 returned_description,
911 final_description,
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000912 reviewers,
bradnelsond975b302016-10-23 12:20:23 -0700913 cc=None):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000914 """Generic reviewer test framework."""
tandrii@chromium.org28253532016-04-14 13:46:56 +0000915 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
iannucci@chromium.org79540052012-10-19 23:15:26 +0000916
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000917 private = '--private' in upload_args
bradnelsond975b302016-10-23 12:20:23 -0700918 cc = cc or []
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +0000919 no_autocc = '--no-autocc' in upload_args
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000920
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +0000921 self.calls = self._upload_calls(private, no_autocc)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000922
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000923 def RunEditor(desc, _, **kwargs):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000924 self.assertEquals(
925 '# Enter a description of the change.\n'
janx@chromium.org104b2db2013-04-18 12:58:40 +0000926 '# This will be displayed on the codereview site.\n'
alancutter@chromium.org63a4d7f2013-05-31 02:22:45 +0000927 '# The first line will also be used as the subject of the review.\n'
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +0000928 '#--------------------This line is 72 characters long'
929 '--------------------\n' +
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000930 expected_description,
931 desc)
932 return returned_description
933 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000934
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000935 def check_upload(args):
Aaron Gable13101a62018-02-09 13:20:41 -0800936 cmd_line = self._cmd_line(final_description, reviewers, private, cc)
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000937 self.assertEquals(cmd_line, args)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000938 return 1, 2
939 self.mock(git_cl.upload, 'RealMain', check_upload)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000940
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000941 git_cl.main(['upload'] + upload_args)
942
943 def test_no_reviewer(self):
944 self._run_reviewer_test(
945 [],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000946 'desc\n\nBUG=',
947 '# Blah blah comment.\ndesc\n\nBUG=',
948 'desc\n\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000949 [])
950
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000951 def test_private(self):
952 self._run_reviewer_test(
953 ['--private'],
954 'desc\n\nBUG=',
955 '# Blah blah comment.\ndesc\n\nBUG=\n',
956 'desc\n\nBUG=',
957 [])
958
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +0000959 def test_no_autocc(self):
960 self._run_reviewer_test(
961 ['--no-autocc'],
962 'desc\n\nBUG=',
963 '# Blah blah comment.\ndesc\n\nBUG=\n',
964 'desc\n\nBUG=',
965 [])
966
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000967 def test_reviewers_cmd_line(self):
968 # Reviewer is passed as-is
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000969 description = 'desc\n\nR=foo@example.com\nBUG='
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000970 self._run_reviewer_test(
971 ['-r' 'foo@example.com'],
972 description,
973 '\n%s\n' % description,
974 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000975 ['--reviewers=foo@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000976
977 def test_reviewer_tbr_overriden(self):
978 # Reviewer is overriden with TBR
979 # Also verifies the regexp work without a trailing LF
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000980 description = 'Foo Bar\n\nTBR=reviewer@example.com'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000981 self._run_reviewer_test(
982 ['-r' 'foo@example.com'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000983 'desc\n\nR=foo@example.com\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000984 description.strip('\n'),
985 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000986 ['--reviewers=reviewer@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000987
988 def test_reviewer_multiple(self):
989 # Handles multiple R= or TBR= lines.
990 description = (
bradnelsond975b302016-10-23 12:20:23 -0700991 'Foo Bar\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
992 'CC=more@example.com,people@example.com')
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000993 self._run_reviewer_test(
994 [],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000995 'desc\n\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000996 description,
997 description,
bradnelsond975b302016-10-23 12:20:23 -0700998 ['--reviewers=another@example.com,reviewer@example.com'],
999 cc=['more@example.com', 'people@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001000
maruel@chromium.orga3353652011-11-30 14:26:57 +00001001 def test_reviewer_send_mail(self):
1002 # --send-mail can be used without -r if R= is used
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001003 description = 'Foo Bar\nR=reviewer@example.com'
maruel@chromium.orga3353652011-11-30 14:26:57 +00001004 self._run_reviewer_test(
1005 ['--send-mail'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001006 'desc\n\nBUG=',
maruel@chromium.orga3353652011-11-30 14:26:57 +00001007 description.strip('\n'),
1008 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001009 ['--reviewers=reviewer@example.com', '--send_mail'])
maruel@chromium.orga3353652011-11-30 14:26:57 +00001010
1011 def test_reviewer_send_mail_no_rev(self):
1012 # Fails without a reviewer.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00001013 stdout = StringIO.StringIO()
Aaron Gable13101a62018-02-09 13:20:41 -08001014 self.calls = self._rietveld_upload_no_rev_calls() + [
tandriic2405f52016-10-10 08:13:15 -07001015 ((['DieWithError', 'Must specify reviewers to send email.'],),
1016 SystemExitMock())
1017 ]
1018
1019 def RunEditor(desc, _, **kwargs):
1020 return desc
1021 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
1022 self.mock(sys, 'stdout', stdout)
1023 with self.assertRaises(SystemExitMock):
maruel@chromium.orga3353652011-11-30 14:26:57 +00001024 git_cl.main(['upload', '--send-mail'])
Aaron Gablec4c40d12017-05-22 11:49:53 -07001025 self.assertEqual(
1026 '=====================================\n'
1027 'NOTICE: Rietveld is being deprecated. '
1028 'You can upload changes to Gerrit with\n'
1029 ' git cl upload --gerrit\n'
1030 'or set Gerrit to be your default code review tool with\n'
1031 ' git config gerrit.host true\n'
1032 '=====================================\n',
1033 stdout.getvalue())
maruel@chromium.orga3353652011-11-30 14:26:57 +00001034
tandriif9aefb72016-07-01 09:06:51 -07001035 def test_bug_on_cmd(self):
1036 self._run_reviewer_test(
1037 ['--bug=500658,proj:123'],
1038 'desc\n\nBUG=500658\nBUG=proj:123',
1039 '# Blah blah comment.\ndesc\n\nBUG=500658\nBUG=proj:1234',
1040 'desc\n\nBUG=500658\nBUG=proj:1234',
1041 [])
1042
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001043 @classmethod
tandrii@chromium.org28253532016-04-14 13:46:56 +00001044 def _gerrit_ensure_auth_calls(cls, issue=None, skip_auth_check=False):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00001045 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +00001046 if skip_auth_check:
1047 return [((cmd, ), 'true')]
1048
tandrii5d48c322016-08-18 16:19:37 -07001049 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001050 if issue:
1051 calls.extend([
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001052 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001053 ])
1054 calls.extend([
1055 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1056 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1057 ((['git', 'config', 'remote.origin.url'],),
1058 'https://chromium.googlesource.com/my/repo'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001059 ])
1060 return calls
1061
1062 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001063 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001064 fetched_status=None, other_cl_owner=None,
1065 custom_cl_base=None):
Aaron Gable13101a62018-02-09 13:20:41 -08001066 calls = cls._is_gerrit_calls(True)
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001067 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001068 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
1069 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1070 ((['git', 'config', 'branch.master.gerritissue'],),
1071 CERR1 if issue is None else str(issue)),
1072 ]
1073
1074 if custom_cl_base:
1075 ancestor_revision = custom_cl_base
1076 else:
1077 # Determine ancestor_revision to be merge base.
1078 ancestor_revision = 'fake_ancestor_sha'
1079 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001080 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001081 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001082 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001083 'refs/remotes/origin/master'],), ancestor_revision),
1084 ]
1085
1086 # Calls to verify branch point is ancestor
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001087 calls += cls._gerrit_ensure_auth_calls(issue=issue)
1088
1089 if issue:
1090 calls += [
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001091 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001092 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +00001093 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
1094 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001095 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001096 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001097 'change_id': '123456789',
1098 'current_revision': 'sha1_of_current_revision',
1099 'revisions': { 'sha1_of_current_revision': {
1100 'commit': {'message': fetched_description},
1101 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001102 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001103 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001104 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001105 if fetched_status == 'ABANDONED':
1106 calls += [
1107 (('DieWithError', 'Change https://chromium-review.googlesource.com/'
1108 '123456 has been abandoned, new uploads are not '
1109 'allowed'), SystemExitMock()),
1110 ]
1111 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001112 if other_cl_owner:
1113 calls += [
1114 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
1115 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001116
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001117 calls += cls._git_sanity_checks(ancestor_revision, 'master',
1118 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001119 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001120 ((['git', 'rev-parse', '--show-cdup'],), ''),
1121 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001122
Aaron Gable7817f022017-12-12 09:43:17 -08001123 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
1124 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001125 'M\t.gitignore\n'),
1126 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001127 ]
1128
1129 if not issue:
1130 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001131 ((['git', 'log', '--pretty=format:%s%n%n%b',
1132 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001133 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001134 ]
1135
1136 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001137 ((['git', 'config', 'user.email'],), 'me@example.com'),
1138 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
1139 ([custom_cl_base] if custom_cl_base else
1140 [ancestor_revision, 'HEAD']),),
1141 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001142 ]
1143 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +00001144
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001145 @classmethod
1146 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -07001147 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001148 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001149 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001150 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001151 custom_cl_base=None, tbr=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +00001152 if post_amend_description is None:
1153 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -07001154 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001155 # Determined in `_gerrit_base_calls`.
1156 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
1157
1158 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001159
tandriia60502f2016-06-20 02:01:53 -07001160 if squash_mode == 'default':
1161 calls.extend([
1162 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
1163 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
1164 ])
1165 elif squash_mode in ('override_squash', 'override_nosquash'):
1166 calls.extend([
1167 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
1168 'true' if squash_mode == 'override_squash' else 'false'),
1169 ])
1170 else:
1171 assert squash_mode in ('squash', 'nosquash')
1172
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001173 # If issue is given, then description is fetched from Gerrit instead.
1174 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001175 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001176 ((['git', 'log', '--pretty=format:%s\n\n%b',
1177 ((custom_cl_base + '..') if custom_cl_base else
1178 'fake_ancestor_sha..HEAD')],),
1179 description),
1180 ]
Aaron Gableb56ad332017-01-06 15:24:31 -08001181 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001182 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -08001183 else:
1184 if not title:
1185 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001186 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
1187 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -08001188 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001189 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +00001190 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001191 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001192 (('DownloadGerritHook', False), ''),
1193 # Amending of commit message to get the Change-Id.
1194 ((['git', 'log', '--pretty=format:%s\n\n%b',
1195 determined_ancestor_revision + '..HEAD'],),
1196 description),
1197 ((['git', 'commit', '--amend', '-m', description],), ''),
1198 ((['git', 'log', '--pretty=format:%s\n\n%b',
1199 determined_ancestor_revision + '..HEAD'],),
1200 post_amend_description)
1201 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001202 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001203 if not issue:
1204 # Prompting to edit description on first upload.
1205 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001206 ((['git', 'config', 'core.editor'],), ''),
1207 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001208 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001209 ref_to_push = 'abcdef0123456789'
1210 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001211 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1212 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1213 ]
1214
1215 if custom_cl_base is None:
1216 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001217 ((['get_or_create_merge_base', 'master',
1218 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001219 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001220 ]
1221 parent = 'origin/master'
1222 else:
1223 calls += [
1224 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
1225 'refs/remotes/origin/master'],),
1226 callError(1)), # Means not ancenstor.
1227 (('ask_for_data',
1228 'Do you take responsibility for cleaning up potential mess '
1229 'resulting from proceeding with upload? Press Enter to upload, '
1230 'or Ctrl+C to abort'), ''),
1231 ]
1232 parent = custom_cl_base
1233
1234 calls += [
1235 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
1236 '0123456789abcdef'),
1237 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001238 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001239 ref_to_push),
1240 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001241 else:
1242 ref_to_push = 'HEAD'
1243
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001244 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001245 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001246 ((['git', 'rev-list',
1247 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1248 ref_to_push],),
1249 '1hashPerLine\n'),
1250 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001251
Aaron Gableafd52772017-06-27 16:40:10 -07001252 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001253 ref_suffix = '%ready,notify=ALL'
1254 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001255 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001256 ref_suffix = '%wip'
1257 else:
1258 ref_suffix = '%notify=NONE'
Aaron Gable9b713dd2016-12-14 16:04:21 -08001259
Aaron Gable70f4e242017-06-26 10:45:59 -07001260 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001261 ref_suffix += ',m=' + title
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001262
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001263 calls.append((
1264 (['git', 'push',
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001265 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001266 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1267 ('remote:\n'
1268 'remote: Processing changes: (\)\n'
1269 'remote: Processing changes: (|)\n'
1270 'remote: Processing changes: (/)\n'
1271 'remote: Processing changes: (-)\n'
1272 'remote: Processing changes: new: 1 (/)\n'
1273 'remote: Processing changes: new: 1, done\n'
1274 'remote:\n'
1275 'remote: New Changes:\n'
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001276 'remote: https://chromium-review.googlesource.com/#/c/my/repo/+/123456'
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001277 ' XXX\n'
1278 'remote:\n'
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001279 'To https://chromium.googlesource.com/my/repo\n'
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001280 ' * [new branch] hhhh -> refs/for/refs/heads/master\n')
1281 ))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001282 if squash:
1283 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001284 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001285 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001286 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001287 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001288 ((['git', 'config', 'branch.master.gerritsquashhash',
1289 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001290 ]
tandrii88189772016-09-29 04:29:57 -07001291 calls += [
1292 ((['git', 'config', 'rietveld.cc'],), ''),
tandrii88189772016-09-29 04:29:57 -07001293 ]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001294 if squash:
1295 calls += [
1296 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001297 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001298 sorted(reviewers),
1299 ['joe@example.com', 'chromium-reviews+test-more-cc@chromium.org'] +
1300 cc, notify), ''),
1301 ]
Aaron Gablefd238082017-06-07 13:42:34 -07001302 if tbr:
1303 calls += [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001304 (('GetChangeDetail', 'chromium-review.googlesource.com',
1305 'my%2Frepo~123456', ['LABELS']), {
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001306 'labels': {
1307 'Code-Review': {
1308 'default_value': 0,
1309 'all': [],
1310 'values': {
1311 '+2': 'lgtm, approved',
1312 '+1': 'lgtm, but someone else must approve',
1313 ' 0': 'No score',
1314 '-1': 'Don\'t submit as-is',
1315 }
1316 }
1317 }
1318 }),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001319 (('SetReview',
1320 'chromium-review.googlesource.com',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001321 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001322 'Self-approving for TBR',
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001323 {'Code-Review': 2}, None), ''),
Aaron Gablefd238082017-06-07 13:42:34 -07001324 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001325 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001326 return calls
1327
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001328 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001329 self,
1330 upload_args,
1331 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001332 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001333 squash=True,
1334 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001335 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001336 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001337 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001338 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001339 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001340 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001341 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001342 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001343 custom_cl_base=None,
1344 tbr=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001345 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001346 if squash_mode is None:
1347 if '--no-squash' in upload_args:
1348 squash_mode = 'nosquash'
1349 elif '--squash' in upload_args:
1350 squash_mode = 'squash'
1351 else:
1352 squash_mode = 'default'
1353
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001354 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001355 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001356 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001357 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001358 CookiesAuthenticatorMockFactory(
1359 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001360 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1361 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001362 self.mock(git_cl.gclient_utils, 'RunEditor',
1363 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001364 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1365 'DownloadGerritHook', force))
tandriia60502f2016-06-20 02:01:53 -07001366
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001367 self.calls = self._gerrit_base_calls(
1368 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001369 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001370 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001371 other_cl_owner=other_cl_owner,
1372 custom_cl_base=custom_cl_base)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001373 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001374 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1375 expected_content=description))
1376 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001377 self.calls += self._gerrit_upload_calls(
1378 description, reviewers, squash,
1379 squash_mode=squash_mode,
1380 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001381 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001382 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001383 issue=issue, cc=cc,
Aaron Gablefd238082017-06-07 13:42:34 -07001384 custom_cl_base=custom_cl_base, tbr=tbr)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001385 # Uncomment when debugging.
1386 # print '\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls)))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001387 git_cl.main(['upload'] + upload_args)
1388
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001389 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001390 self._run_gerrit_upload_test(
1391 ['--no-squash'],
1392 'desc\n\nBUG=\n',
1393 [],
1394 squash=False,
1395 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
1396
1397 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001398 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001399 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001400 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001401 [],
tandriia60502f2016-06-20 02:01:53 -07001402 squash=False,
1403 squash_mode='override_nosquash',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001404 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001405
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001406 def test_gerrit_no_reviewer(self):
1407 self._run_gerrit_upload_test(
1408 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001409 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001410 [],
1411 squash=False,
1412 squash_mode='override_nosquash')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001413
Nick Carter8692b182017-11-06 16:30:38 -08001414 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001415 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1416 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001417 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001418 'desc\n\nBUG=\n\nChange-Id: I123456789',
1419 squash=False,
1420 squash_mode='override_nosquash',
Nick Carter8692b182017-11-06 16:30:38 -08001421 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001422
ukai@chromium.orge8077812012-02-03 03:41:46 +00001423 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001424 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001425 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001426 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001427 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001428 squash=False,
1429 squash_mode='override_nosquash',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001430 notify=True)
ukai@chromium.orge8077812012-02-03 03:41:46 +00001431
1432 def test_gerrit_reviewer_multiple(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001433 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001434 [],
bradnelsond975b302016-10-23 12:20:23 -07001435 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1436 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001437 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001438 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001439 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001440 cc=['more@example.com', 'people@example.com'],
1441 tbr='reviewer@example.com')
tandriia60502f2016-06-20 02:01:53 -07001442
1443 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001444 self._run_gerrit_upload_test(
1445 [],
1446 'desc\nBUG=\n\nChange-Id: 123456789',
1447 [],
1448 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001449
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001450 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001451 self._run_gerrit_upload_test(
1452 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001453 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001454 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001455 squash=True,
1456 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001457
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001458 def test_gerrit_upload_squash_first_against_rev(self):
1459 custom_cl_base = 'custom_cl_base_rev_or_branch'
1460 self._run_gerrit_upload_test(
1461 ['--squash', custom_cl_base],
1462 'desc\nBUG=\n\nChange-Id: 123456789',
1463 [],
1464 squash=True,
1465 expected_upstream_ref='origin/master',
1466 custom_cl_base=custom_cl_base)
1467 self.assertIn(
1468 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1469 sys.stdout.getvalue())
1470
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001471 def test_gerrit_upload_squash_reupload(self):
1472 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001473 self._run_gerrit_upload_test(
1474 ['--squash'],
1475 description,
1476 [],
1477 squash=True,
1478 expected_upstream_ref='origin/master',
1479 issue=123456)
1480
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001481 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1482 self.mock(git_cl, 'DieWithError',
1483 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1484 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1485 with self.assertRaises(SystemExitMock):
1486 self._run_gerrit_upload_test(
1487 ['--squash'],
1488 description,
1489 [],
1490 squash=True,
1491 expected_upstream_ref='origin/master',
1492 issue=123456,
1493 fetched_status='ABANDONED')
1494
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001495 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1496 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1497 lambda *_, **__: {'email': 'yet-another@example.com'})
1498 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1499 self._run_gerrit_upload_test(
1500 ['--squash'],
1501 description,
1502 [],
1503 squash=True,
1504 expected_upstream_ref='origin/master',
1505 issue=123456,
1506 other_cl_owner='other@example.com')
1507 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001508 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001509 'authenticate to Gerrit as yet-another@example.com.\n'
1510 'Uploading may fail due to lack of permissions',
1511 git_cl.sys.stdout.getvalue())
1512
rmistry@google.com2dd99862015-06-22 12:22:18 +00001513 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001514 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001515 def mock_run_git(*args, **_kwargs):
1516 if args[0] == ['for-each-ref',
1517 '--format=%(refname:short) %(upstream:short)',
1518 'refs/heads']:
1519 # Create a local branch dependency tree that looks like this:
1520 # test1 -> test2 -> test3 -> test4 -> test5
1521 # -> test3.1
1522 # test6 -> test0
1523 branch_deps = [
1524 'test2 test1', # test1 -> test2
1525 'test3 test2', # test2 -> test3
1526 'test3.1 test2', # test2 -> test3.1
1527 'test4 test3', # test3 -> test4
1528 'test5 test4', # test4 -> test5
1529 'test6 test0', # test0 -> test6
1530 'test7', # test7
1531 ]
1532 return '\n'.join(branch_deps)
1533 self.mock(git_cl, 'RunGit', mock_run_git)
1534
1535 class RecordCalls:
1536 times_called = 0
1537 record_calls = RecordCalls()
1538 def mock_CMDupload(*args, **_kwargs):
1539 record_calls.times_called += 1
1540 return 0
1541 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1542
1543 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001544 (('ask_for_data', 'This command will checkout all dependent branches '
1545 'and run "git cl upload". Press Enter to continue, '
1546 'or Ctrl+C to abort'), ''),
1547 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001548
1549 class MockChangelist():
1550 def __init__(self):
1551 pass
1552 def GetBranch(self):
1553 return 'test1'
1554 def GetIssue(self):
1555 return '123'
1556 def GetPatchset(self):
1557 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001558 def IsGerrit(self):
1559 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001560
1561 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1562 # CMDupload should have been called 5 times because of 5 dependent branches.
1563 self.assertEquals(5, record_calls.times_called)
1564 self.assertEquals(0, ret)
1565
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001566 def test_gerrit_change_id(self):
1567 self.calls = [
1568 ((['git', 'write-tree'], ),
1569 'hashtree'),
1570 ((['git', 'rev-parse', 'HEAD~0'], ),
1571 'branch-parent'),
1572 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1573 'A B <a@b.org> 1456848326 +0100'),
1574 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1575 'C D <c@d.org> 1456858326 +0100'),
1576 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1577 'hashchange'),
1578 ]
1579 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1580 self.assertEqual(change_id, 'Ihashchange')
1581
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001582 def test_desecription_append_footer(self):
1583 for init_desc, footer_line, expected_desc in [
1584 # Use unique desc first lines for easy test failure identification.
1585 ('foo', 'R=one', 'foo\n\nR=one'),
1586 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1587 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1588 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1589 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1590 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1591 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1592 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1593 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1594 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1595 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1596 ]:
1597 desc = git_cl.ChangeDescription(init_desc)
1598 desc.append_footer(footer_line)
1599 self.assertEqual(desc.description, expected_desc)
1600
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001601 def test_update_reviewers(self):
1602 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001603 ('foo', [], [],
1604 'foo'),
1605 ('foo\nR=xx', [], [],
1606 'foo\nR=xx'),
1607 ('foo\nTBR=xx', [], [],
1608 'foo\nTBR=xx'),
1609 ('foo', ['a@c'], [],
1610 'foo\n\nR=a@c'),
1611 ('foo\nR=xx', ['a@c'], [],
1612 'foo\n\nR=a@c, xx'),
1613 ('foo\nTBR=xx', ['a@c'], [],
1614 'foo\n\nR=a@c\nTBR=xx'),
1615 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1616 'foo\n\nR=a@c, yy\nTBR=xx'),
1617 ('foo\nBUG=', ['a@c'], [],
1618 'foo\nBUG=\nR=a@c'),
1619 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1620 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1621 ('foo', ['a@c', 'b@c'], [],
1622 'foo\n\nR=a@c, b@c'),
1623 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1624 'foo\nBar\n\nR=c@c\nBUG='),
1625 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1626 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001627 # Same as the line before, but full of whitespaces.
1628 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001629 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001630 'foo\nBar\n\nR=c@c\n BUG =',
1631 ),
1632 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001633 ('foo BUG=allo R=joe ', ['c@c'], [],
1634 'foo BUG=allo R=joe\n\nR=c@c'),
1635 # Redundant TBRs get promoted to Rs
1636 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1637 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001638 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001639 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001640 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001641 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001642 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001643 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001644 actual.append(obj.description)
1645 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001646
Nodir Turakulov23b82142017-11-16 11:04:25 -08001647 def test_get_hash_tags(self):
1648 cases = [
1649 ('', []),
1650 ('a', []),
1651 ('[a]', ['a']),
1652 ('[aa]', ['aa']),
1653 ('[a ]', ['a']),
1654 ('[a- ]', ['a']),
1655 ('[a- b]', ['a-b']),
1656 ('[a--b]', ['a-b']),
1657 ('[a', []),
1658 ('[a]x', ['a']),
1659 ('[aa]x', ['aa']),
1660 ('[a b]', ['a-b']),
1661 ('[a b]', ['a-b']),
1662 ('[a__b]', ['a-b']),
1663 ('[a] x', ['a']),
1664 ('[a][b]', ['a', 'b']),
1665 ('[a] [b]', ['a', 'b']),
1666 ('[a][b]x', ['a', 'b']),
1667 ('[a][b] x', ['a', 'b']),
1668 ('[a]\n[b]', ['a']),
1669 ('[a\nb]', []),
1670 ('[a][', ['a']),
1671 ('Revert "[a] feature"', ['a']),
1672 ('Reland "[a] feature"', ['a']),
1673 ('Revert: [a] feature', ['a']),
1674 ('Reland: [a] feature', ['a']),
1675 ('Revert "Reland: [a] feature"', ['a']),
1676 ('Foo: feature', ['foo']),
1677 ('Foo Bar: feature', ['foo-bar']),
1678 ('Revert "Foo bar: feature"', ['foo-bar']),
1679 ('Reland "Foo bar: feature"', ['foo-bar']),
1680 ]
1681 for desc, expected in cases:
1682 change_desc = git_cl.ChangeDescription(desc)
1683 actual = change_desc.get_hash_tags()
1684 self.assertEqual(
1685 actual,
1686 expected,
1687 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1688
wittman@chromium.org455dc922015-01-26 20:15:50 +00001689 def test_get_target_ref(self):
1690 # Check remote or remote branch not present.
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001691 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001692 self.assertEqual(None, git_cl.GetTargetRef(None,
1693 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001694 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001695
wittman@chromium.org455dc922015-01-26 20:15:50 +00001696 # Check default target refs for branches.
1697 self.assertEqual('refs/heads/master',
1698 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001699 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001700 self.assertEqual('refs/heads/master',
1701 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001702 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001703 self.assertEqual('refs/heads/master',
1704 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001705 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001706 self.assertEqual('refs/branch-heads/123',
1707 git_cl.GetTargetRef('origin',
1708 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001709 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001710 self.assertEqual('refs/diff/test',
1711 git_cl.GetTargetRef('origin',
1712 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001713 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001714 self.assertEqual('refs/heads/chrome/m42',
1715 git_cl.GetTargetRef('origin',
1716 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001717 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001718
1719 # Check target refs for user-specified target branch.
1720 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1721 'refs/remotes/branch-heads/123'):
1722 self.assertEqual('refs/branch-heads/123',
1723 git_cl.GetTargetRef('origin',
1724 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001725 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001726 for branch in ('origin/master', 'remotes/origin/master',
1727 'refs/remotes/origin/master'):
1728 self.assertEqual('refs/heads/master',
1729 git_cl.GetTargetRef('origin',
1730 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001731 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001732 for branch in ('master', 'heads/master', 'refs/heads/master'):
1733 self.assertEqual('refs/heads/master',
1734 git_cl.GetTargetRef('origin',
1735 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001736 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001737
wychen@chromium.orga872e752015-04-28 23:42:18 +00001738 def test_patch_when_dirty(self):
1739 # Patch when local tree is dirty
1740 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1741 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1742
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001743 @staticmethod
1744 def _get_gerrit_codereview_server_calls(branch, value=None,
1745 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001746 detect_branch=True,
1747 detect_server=True):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001748 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1749
1750 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1751 """
1752 calls = []
1753 if detect_branch:
1754 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001755 if detect_server:
1756 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1757 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001758 if value is None:
1759 calls += [
1760 ((['git', 'config', 'branch.' + branch + '.merge'],),
1761 'refs/heads' + branch),
1762 ((['git', 'config', 'branch.' + branch + '.remote'],),
1763 'origin'),
1764 ((['git', 'config', 'remote.origin.url'],),
1765 'https://%s.googlesource.com/my/repo' % git_short_host),
1766 ]
1767 return calls
1768
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001769 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001770 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001771 detect_gerrit_server=False,
1772 actual_codereview=None,
1773 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001774 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001775 self.mock(git_cl._RietveldChangelistImpl, 'GetMostRecentPatchset',
1776 lambda x: '60001')
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001777 self.mock(git_cl._RietveldChangelistImpl, 'FetchDescription',
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001778 lambda *a, **kw: 'Description')
wychen@chromium.orga872e752015-04-28 23:42:18 +00001779 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1780
tandriidf09a462016-08-18 16:23:55 -07001781 if new_branch:
1782 self.calls = [((['git', 'new-branch', 'master'],), ''),]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001783
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001784 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001785 self.calls += [
1786 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001787 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001788 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001789
1790 if not force_codereview and not codereview_in_url:
1791 # These calls detect codereview to use.
1792 self.calls += [
1793 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
1794 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1795 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
1796 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1797 ((['git', 'config', 'gerrit.host'],), 'true'),
1798 ]
1799 if detect_gerrit_server:
1800 self.calls += self._get_gerrit_codereview_server_calls(
1801 'master', git_short_host=git_short_host,
1802 detect_branch=not new_branch and force_codereview)
1803 actual_codereview = 'gerrit'
1804
1805 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001806 self.calls += [
1807 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001808 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001809 {
1810 'current_revision': '7777777777',
1811 'revisions': {
1812 '1111111111': {
1813 '_number': 1,
1814 'fetch': {'http': {
1815 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1816 'ref': 'refs/changes/56/123456/1',
1817 }},
1818 },
1819 '7777777777': {
1820 '_number': 7,
1821 'fetch': {'http': {
1822 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1823 'ref': 'refs/changes/56/123456/7',
1824 }},
1825 },
1826 },
1827 }),
1828 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001829
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001830 def test_patch_rietveld_guess_by_url(self):
1831 self._patch_common(actual_codereview='rietveld', codereview_in_url=True)
wychen@chromium.orga872e752015-04-28 23:42:18 +00001832 self.calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001833 ((['git', 'config', 'branch.master.rietveldissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001834 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001835 ((['git', 'config', 'branch.master.rietveldserver',
1836 'https://codereview.example.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001837 ((['git', 'config', 'branch.master.rietveldpatchset', '60001'],),
tandrii5d48c322016-08-18 16:19:37 -07001838 ''),
Aaron Gabled343c632017-03-15 11:02:26 -07001839 ((['git', 'commit', '-m',
1840 'Description\n\n' +
1841 'patch from issue 123456 at patchset 60001 ' +
1842 '(http://crrev.com/123456#ps60001)'],), ''),
wychen@chromium.orga872e752015-04-28 23:42:18 +00001843 ]
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001844 self.assertEqual(git_cl.main(
1845 ['patch', 'https://codereview.example.com/123456']), 0)
1846
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001847 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001848 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001849 self.calls += [
1850 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1851 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001852 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001853 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001854 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001855 ((['git', 'config', 'branch.master.gerritserver',
1856 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001857 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001858 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1859 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1860 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001861 ]
1862 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1863
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001864 def test_patch_gerrit_new_branch(self):
1865 self._patch_common(
1866 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1867 self.calls += [
1868 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1869 'refs/changes/56/123456/7'],), ''),
1870 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1871 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1872 ''),
1873 ((['git', 'config', 'branch.master.gerritserver',
1874 'https://chromium-review.googlesource.com'],), ''),
1875 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1876 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1877 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1878 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1879 ]
1880 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1881
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001882 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001883 self._patch_common(
1884 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001885 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001886 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001887 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001888 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001889 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001890 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001891 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001892 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001893 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001894 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1895 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1896 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001897 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001898 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001899
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001900 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001901 self.calls += self._get_gerrit_codereview_server_calls(
1902 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001903 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001904 actual_codereview='gerrit', git_short_host='else',
1905 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001906 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001907 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001908 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001909 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001910 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001911 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001912 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001913 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001914 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001915 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1916 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1917 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001918 ]
1919 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001920 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001921
Aaron Gable697a91b2018-01-19 15:20:15 -08001922 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001923 self.calls += self._get_gerrit_codereview_server_calls(
1924 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001925 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001926 actual_codereview='gerrit', git_short_host='else',
1927 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001928 self.calls += [
1929 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1930 'refs/changes/56/123456/1'],), ''),
1931 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1932 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1933 ''),
1934 ((['git', 'config', 'branch.master.gerritserver',
1935 'https://else-review.googlesource.com'],), ''),
1936 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1937 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1938 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1939 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1940 ]
1941 self.assertEqual(git_cl.main(
1942 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1943 0)
1944
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001945 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001946 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001947 self.calls += [
1948 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001949 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001950 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1951 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1952 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001953 ]
1954 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001955 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001956
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001957 def test_patch_gerrit_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001958 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001959 raise git_cl.gerrit_util.GerritError(404, '')
1960 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1961
tandriic2405f52016-10-10 08:13:15 -07001962 self.calls = [
1963 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandriic2405f52016-10-10 08:13:15 -07001964 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1965 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
1966 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1967 ((['git', 'config', 'gerrit.host'],), 'true'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001968 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1969 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1970 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1971 ((['git', 'config', 'remote.origin.url'],),
1972 'https://chromium.googlesource.com/my/repo'),
1973 ((['DieWithError',
1974 'change 123456 at https://chromium-review.googlesource.com does not '
1975 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001976 ]
1977 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001978 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001979
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001980 def _checkout_calls(self):
1981 return [
1982 ((['git', 'config', '--local', '--get-regexp',
1983 'branch\\..*\\.rietveldissue'], ),
1984 ('branch.retrying.rietveldissue 1111111111\n'
1985 'branch.some-fix.rietveldissue 2222222222\n')),
1986 ((['git', 'config', '--local', '--get-regexp',
1987 'branch\\..*\\.gerritissue'], ),
1988 ('branch.ger-branch.gerritissue 123456\n'
1989 'branch.gbranch654.gerritissue 654321\n')),
1990 ]
1991
1992 def test_checkout_gerrit(self):
1993 """Tests git cl checkout <issue>."""
1994 self.calls = self._checkout_calls()
1995 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1996 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1997
1998 def test_checkout_rietveld(self):
1999 """Tests git cl checkout <issue>."""
2000 self.calls = self._checkout_calls()
2001 self.calls += [((['git', 'checkout', 'some-fix'], ), '')]
2002 self.assertEqual(0, git_cl.main(['checkout', '2222222222']))
2003
2004 def test_checkout_not_found(self):
2005 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00002006 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002007 self.calls = self._checkout_calls()
2008 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2009
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002010 def test_checkout_no_branch_issues(self):
2011 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00002012 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002013 self.calls = [
2014 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07002015 'branch\\..*\\.rietveldissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002016 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07002017 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002018 ]
2019 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2020
tandrii@chromium.org28253532016-04-14 13:46:56 +00002021 def _test_gerrit_ensure_authenticated_common(self, auth,
2022 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002023 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2024 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
2025 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11002026 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00002027 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002028 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00002029 cl.branch = 'master'
2030 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002031 cl.lookedup_issue = True
2032 return cl
2033
2034 def test_gerrit_ensure_authenticated_missing(self):
2035 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002036 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002037 })
2038 self.calls.append(
2039 ((['DieWithError',
2040 'Credentials for the following hosts are required:\n'
2041 ' chromium-review.googlesource.com\n'
2042 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002043 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002044 'https://chromium-review.googlesource.com/new-password'],), ''),)
2045 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2046
2047 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00002048 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002049 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002050 'chromium.googlesource.com':
2051 ('git-one.example.com', None, 'secret1'),
2052 'chromium-review.googlesource.com':
2053 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002054 })
2055 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002056 (('ask_for_data', 'If you know what you are doing '
2057 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002058 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2059
2060 def test_gerrit_ensure_authenticated_ok(self):
2061 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002062 'chromium.googlesource.com':
2063 ('git-same.example.com', None, 'secret'),
2064 'chromium-review.googlesource.com':
2065 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002066 })
2067 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2068
tandrii@chromium.org28253532016-04-14 13:46:56 +00002069 def test_gerrit_ensure_authenticated_skipped(self):
2070 cl = self._test_gerrit_ensure_authenticated_common(
2071 auth={}, skip_auth_check=True)
2072 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2073
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002074 def test_cmd_set_commit_rietveld(self):
tandrii4d843592016-07-27 08:22:56 -07002075 self.mock(git_cl._RietveldChangelistImpl, 'SetFlags',
2076 lambda _, v: self._mocked_call(['SetFlags', v]))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002077 self.calls = [
2078 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002079 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002080 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2081 ((['git', 'config', 'rietveld.server'],), ''),
2082 ((['git', 'config', 'rietveld.server'],), ''),
2083 ((['git', 'config', 'branch.feature.rietveldserver'],),
2084 'https://codereview.chromium.org'),
tandrii4d843592016-07-27 08:22:56 -07002085 ((['SetFlags', {'commit': '1', 'cq_dry_run': '0'}], ), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002086 ]
2087 self.assertEqual(0, git_cl.main(['set-commit']))
2088
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002089 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002090 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002091 lambda h, i, labels, notify=None:
2092 self._mocked_call(['SetReview', h, i, labels, notify]))
2093
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002094 self.calls = [
2095 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002096 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2097 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002098 ((['git', 'config', 'branch.feature.gerritserver'],),
2099 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002100 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2101 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2102 ((['git', 'config', 'remote.origin.url'],),
2103 'https://chromium.googlesource.com/infra/infra.git'),
2104 ((['SetReview', 'chromium-review.googlesource.com',
2105 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002106 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002107 ]
tandriid9e5ce52016-07-13 02:32:59 -07002108
2109 def test_cmd_set_commit_gerrit_clear(self):
2110 self._cmd_set_commit_gerrit_common(0)
2111 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2112
2113 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002114 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002115 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2116
tandriid9e5ce52016-07-13 02:32:59 -07002117 def test_cmd_set_commit_gerrit(self):
2118 self._cmd_set_commit_gerrit_common(2)
2119 self.assertEqual(0, git_cl.main(['set-commit']))
2120
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002121 def test_description_display(self):
2122 out = StringIO.StringIO()
2123 self.mock(git_cl.sys, 'stdout', out)
2124
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002125 self.mock(git_cl, 'Changelist', ChangelistMock)
2126 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002127
2128 self.assertEqual(0, git_cl.main(['description', '-d']))
2129 self.assertEqual('foo\n', out.getvalue())
2130
2131 def test_description_rietveld(self):
2132 out = StringIO.StringIO()
2133 self.mock(git_cl.sys, 'stdout', out)
martiniss6eda05f2016-06-30 10:18:35 -07002134 self.mock(git_cl.Changelist, 'GetDescription', lambda *args: 'foobar')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002135
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002136 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02002137 'description', '-d', '--rietveld', 'https://code.review.org/123123']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002138 self.assertEqual('foobar\n', out.getvalue())
2139
iannucci3c972b92016-08-17 13:24:10 -07002140 def test_StatusFieldOverrideIssueMissingArgs(self):
2141 out = StringIO.StringIO()
2142 self.mock(git_cl.sys, 'stderr', out)
2143
2144 try:
2145 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2146 except SystemExit as ex:
2147 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002148 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002149
2150 out = StringIO.StringIO()
2151 self.mock(git_cl.sys, 'stderr', out)
2152
2153 try:
2154 self.assertEqual(git_cl.main(['status', '--issue', '1', '--rietveld']), 0)
2155 except SystemExit as ex:
2156 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002157 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002158
2159 def test_StatusFieldOverrideIssue(self):
2160 out = StringIO.StringIO()
2161 self.mock(git_cl.sys, 'stdout', out)
2162
2163 def assertIssue(cl_self, *_args):
2164 self.assertEquals(cl_self.issue, 1)
2165 return 'foobar'
2166
2167 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2168 self.calls = [
2169 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2170 ((['git', 'config', 'rietveld.server'],), ''),
2171 ((['git', 'config', 'rietveld.server'],), ''),
2172 ]
iannuccie53c9352016-08-17 14:40:40 -07002173 self.assertEqual(
2174 git_cl.main(['status', '--issue', '1', '--rietveld', '--field', 'desc']),
2175 0)
iannucci3c972b92016-08-17 13:24:10 -07002176 self.assertEqual(out.getvalue(), 'foobar\n')
2177
iannuccie53c9352016-08-17 14:40:40 -07002178 def test_SetCloseOverrideIssue(self):
2179 def assertIssue(cl_self, *_args):
2180 self.assertEquals(cl_self.issue, 1)
2181 return 'foobar'
2182
2183 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2184 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
2185 self.calls = [
2186 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2187 ((['git', 'config', 'rietveld.server'],), ''),
2188 ((['git', 'config', 'rietveld.server'],), ''),
2189 ]
2190 self.assertEqual(
2191 git_cl.main(['set-close', '--issue', '1', '--rietveld']), 0)
2192
2193 def test_SetCommitOverrideIssue(self):
2194 def assertIssue(cl_self, *_args):
2195 self.assertEquals(cl_self.issue, 1)
2196 return 'foobar'
2197
2198 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2199 self.mock(git_cl.Changelist, 'SetCQState', lambda *_: None)
2200 self.calls = [
2201 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2202 ((['git', 'config', 'rietveld.server'],), ''),
2203 ((['git', 'config', 'rietveld.server'],), ''),
2204 ((['git', 'symbolic-ref', 'HEAD'],), ''),
2205 ((['git', 'config', 'rietveld.server'],), ''),
2206 ((['git', 'config', 'rietveld.server'],), ''),
2207 ]
2208 self.assertEqual(
2209 git_cl.main(['set-close', '--issue', '1', '--rietveld']), 0)
2210
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002211 def test_description_gerrit(self):
2212 out = StringIO.StringIO()
2213 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002214 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002215 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2216 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2217 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2218 ((['git', 'config', 'remote.origin.url'],),
2219 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002220 (('GetChangeDetail', 'code.review.org',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002221 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002222 {
2223 'current_revision': 'sha1',
2224 'revisions': {'sha1': {
2225 'commit': {'message': 'foobar'},
2226 }},
2227 }),
2228 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002229 self.assertEqual(0, git_cl.main([
2230 'description', 'https://code.review.org/123123', '-d', '--gerrit']))
2231 self.assertEqual('foobar\n', out.getvalue())
2232
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002233 def test_description_set_raw(self):
2234 out = StringIO.StringIO()
2235 self.mock(git_cl.sys, 'stdout', out)
2236
2237 self.mock(git_cl, 'Changelist', ChangelistMock)
2238 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2239
2240 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2241 self.assertEqual('hihi', ChangelistMock.desc)
2242
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002243 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002244 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002245
2246 def RunEditor(desc, _, **kwargs):
2247 self.assertEquals(
2248 '# Enter a description of the change.\n'
2249 '# This will be displayed on the codereview site.\n'
2250 '# The first line will also be used as the subject of the review.\n'
2251 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002252 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002253 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002254 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002255 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002256 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002257
dsansomee2d6fd92016-09-08 00:10:47 -07002258 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002259 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002260
2261 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2262 self.mock(git_cl.Changelist, 'GetDescription',
2263 lambda *args: current_desc)
2264 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2265 UpdateDescriptionRemote)
2266 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2267
2268 self.calls = [
2269 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002270 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002271 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2272 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002273 ((['git', 'config', 'core.editor'],), 'vi'),
2274 ]
2275 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2276
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002277 def test_description_set_stdin(self):
2278 out = StringIO.StringIO()
2279 self.mock(git_cl.sys, 'stdout', out)
2280
2281 self.mock(git_cl, 'Changelist', ChangelistMock)
2282 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2283
2284 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2285 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2286
kmarshall3bff56b2016-06-06 18:31:47 -07002287 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002288 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2289
kmarshall3bff56b2016-06-06 18:31:47 -07002290 self.calls = \
2291 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2292 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
tandrii33a46ff2016-08-23 05:53:40 -07002293 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
tandrii5d48c322016-08-18 16:19:37 -07002294 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2295 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
tandrii33a46ff2016-08-23 05:53:40 -07002296 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2297 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2298 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002299 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2300 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2301 ((['git', 'branch', '-D', 'foo'],), '')]
2302
kmarshall3bff56b2016-06-06 18:31:47 -07002303 self.mock(git_cl, 'get_cl_statuses',
2304 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002305 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2306 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2307 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002308
2309 self.assertEqual(0, git_cl.main(['archive', '-f']))
2310
2311 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002312 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002313 self.calls = \
2314 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2315 'refs/heads/master'),
tandrii33a46ff2016-08-23 05:53:40 -07002316 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
tandrii5d48c322016-08-18 16:19:37 -07002317 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2318 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
kmarshall3bff56b2016-06-06 18:31:47 -07002319 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2320
kmarshall9249e012016-08-23 12:02:16 -07002321 self.mock(git_cl, 'get_cl_statuses',
2322 lambda branches, fine_grained, max_processes:
2323 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2324
2325 self.assertEqual(1, git_cl.main(['archive', '-f']))
2326
2327 def test_archive_dry_run(self):
2328 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2329
2330 self.calls = \
2331 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2332 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2333 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
2334 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2335 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2336 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2337 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2338 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2339 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002340
2341 self.mock(git_cl, 'get_cl_statuses',
2342 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002343 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2344 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2345 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002346
kmarshall9249e012016-08-23 12:02:16 -07002347 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2348
2349 def test_archive_no_tags(self):
2350 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2351
2352 self.calls = \
2353 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2354 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2355 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
2356 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2357 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2358 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2359 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2360 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2361 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2362 ((['git', 'branch', '-D', 'foo'],), '')]
2363
2364 self.mock(git_cl, 'get_cl_statuses',
2365 lambda branches, fine_grained, max_processes:
2366 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2367 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2368 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2369
2370 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002371
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002372 def test_cmd_issue_erase_existing(self):
2373 out = StringIO.StringIO()
2374 self.mock(git_cl.sys, 'stdout', out)
2375 self.calls = [
2376 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002377 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2378 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002379 # Let this command raise exception (retcode=1) - it should be ignored.
2380 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002381 CERR1),
2382 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2383 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002384 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2385 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2386 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002387 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002388 ]
2389 self.assertEqual(0, git_cl.main(['issue', '0']))
2390
Aaron Gable400e9892017-07-12 15:31:21 -07002391 def test_cmd_issue_erase_existing_with_change_id(self):
2392 out = StringIO.StringIO()
2393 self.mock(git_cl.sys, 'stdout', out)
2394 self.mock(git_cl.Changelist, 'GetDescription',
2395 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2396 self.calls = [
2397 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2398 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2399 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
Aaron Gable400e9892017-07-12 15:31:21 -07002400 # Let this command raise exception (retcode=1) - it should be ignored.
2401 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2402 CERR1),
2403 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2404 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2405 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2406 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2407 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002408 ((['git', 'log', '-1', '--format=%B'],),
2409 'This is a description\n\nChange-Id: Ideadbeef'),
2410 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002411 ]
2412 self.assertEqual(0, git_cl.main(['issue', '0']))
2413
phajdan.jre328cf92016-08-22 04:12:17 -07002414 def test_cmd_issue_json(self):
2415 out = StringIO.StringIO()
2416 self.mock(git_cl.sys, 'stdout', out)
2417 self.calls = [
2418 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002419 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
phajdan.jre328cf92016-08-22 04:12:17 -07002420 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2421 ((['git', 'config', 'rietveld.server'],),
2422 'https://codereview.chromium.org'),
2423 ((['git', 'config', 'branch.feature.rietveldserver'],), ''),
2424 (('write_json', 'output.json',
2425 {'issue': 123, 'issue_url': 'https://codereview.chromium.org/123'}),
2426 ''),
2427 ]
2428 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2429
tandriide281ae2016-10-12 06:02:30 -07002430 def test_git_cl_try_default_cq_dry_run(self):
tandrii9de9ec62016-07-13 03:01:59 -07002431 self.mock(git_cl.Changelist, 'GetChange',
2432 lambda _, *a: (
2433 self._mocked_call(['GetChange']+list(a))))
2434 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2435 lambda *_, **__: (
2436 self._mocked_call(['DoGetTryMasters'])))
tandrii9de9ec62016-07-13 03:01:59 -07002437 self.mock(git_cl._RietveldChangelistImpl, 'SetCQState',
2438 lambda _, s: self._mocked_call(['SetCQState', s]))
2439 self.calls = [
2440 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002441 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
tandrii9de9ec62016-07-13 03:01:59 -07002442 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2443 ((['git', 'config', 'rietveld.server'],),
2444 'https://codereview.chromium.org'),
2445 ((['git', 'config', 'branch.feature.rietveldserver'],), ''),
2446 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2447 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2448 ((['get_or_create_merge_base', 'feature', 'feature'],),
2449 'fake_ancestor_sha'),
2450 ((['GetChange', 'fake_ancestor_sha', None], ),
2451 git_cl.presubmit_support.GitChange(
2452 '', '', '', '', '', '', '', '')),
2453 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2454 ((['DoGetTryMasters'], ), None),
tandrii9de9ec62016-07-13 03:01:59 -07002455 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2456 ]
2457 out = StringIO.StringIO()
2458 self.mock(git_cl.sys, 'stdout', out)
2459 self.assertEqual(0, git_cl.main(['try']))
2460 self.assertEqual(
2461 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002462 'Scheduling CQ dry run on: https://codereview.chromium.org/123\n')
tandrii9de9ec62016-07-13 03:01:59 -07002463
tandrii8c5a3532016-11-04 07:52:02 -07002464 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2465 self.mock(git_cl.Changelist, 'GetChange',
2466 lambda _, *a: (
2467 self._mocked_call(['GetChange']+list(a))))
2468 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2469 lambda *_, **__: (
2470 self._mocked_call(['DoGetTryMasters'])))
2471 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2472 lambda _, s: self._mocked_call(['SetCQState', s]))
2473
tandrii8c5a3532016-11-04 07:52:02 -07002474 self.calls = [
2475 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2476 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2477 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2478 ((['git', 'config', 'branch.feature.gerritserver'],),
2479 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002480 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2481 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2482 ((['git', 'config', 'remote.origin.url'],),
2483 'https://chromium.googlesource.com/depot_tools'),
2484 (('GetChangeDetail', 'chromium-review.googlesource.com',
2485 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002486 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2487 'project': 'depot_tools',
2488 'status': 'OPEN',
2489 'owner': {'email': 'owner@e.mail'},
2490 'revisions': {
2491 'deadbeaf': {
2492 '_number': 6,
2493 },
2494 'beeeeeef': {
2495 '_number': 7,
2496 'fetch': {'http': {
2497 'url': 'https://chromium.googlesource.com/depot_tools',
2498 'ref': 'refs/changes/56/123456/7'
2499 }},
2500 },
2501 },
2502 }),
tandrii8c5a3532016-11-04 07:52:02 -07002503 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2504 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2505 ((['get_or_create_merge_base', 'feature', 'feature'],),
2506 'fake_ancestor_sha'),
2507 ((['GetChange', 'fake_ancestor_sha', None], ),
2508 git_cl.presubmit_support.GitChange(
2509 '', '', '', '', '', '', '', '')),
2510 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2511 ((['DoGetTryMasters'], ), None),
2512 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2513 ]
2514 out = StringIO.StringIO()
2515 self.mock(git_cl.sys, 'stdout', out)
2516 self.assertEqual(0, git_cl.main(['try']))
2517 self.assertEqual(
2518 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002519 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002520 'https://chromium-review.googlesource.com/123456\n')
2521
2522 def test_git_cl_try_buildbucket_with_properties_rietveld(self):
2523 self.mock(git_cl._RietveldChangelistImpl, 'GetIssueProperties',
2524 lambda _: {
2525 'owner_email': 'owner@e.mail',
2526 'private': False,
2527 'closed': False,
2528 'project': 'depot_tools',
2529 'patchsets': [20001],
2530 })
tandriide281ae2016-10-12 06:02:30 -07002531 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2532 self.calls = [
2533 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2534 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
2535 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2536 ((['git', 'config', 'rietveld.server'],),
2537 'https://codereview.chromium.org'),
tandriide281ae2016-10-12 06:02:30 -07002538 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
tandrii8c5a3532016-11-04 07:52:02 -07002539 ((['git', 'config', 'branch.feature.rietveldserver'],), CERR1),
tandriide281ae2016-10-12 06:02:30 -07002540 ]
2541
2542 def _buildbucket_retry(*_, **kw):
2543 # self.maxDiff = 10000
2544 body = json.loads(kw['body'])
2545 self.assertEqual(len(body['builds']), 1)
2546 build = body['builds'][0]
2547 params = json.loads(build.pop('parameters_json'))
2548 self.assertEqual(params, {
2549 u'builder_name': u'win',
2550 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2551 u'revision': None}],
2552 u'properties': {
2553 u'category': u'git_cl_try',
2554 u'issue': 123,
2555 u'key': u'val',
2556 u'json': [{u'a': 1}, None],
2557 u'master': u'tryserver.chromium',
2558 u'patch_project': u'depot_tools',
2559 u'patch_storage': u'rietveld',
2560 u'patchset': 20001,
tandriide281ae2016-10-12 06:02:30 -07002561 u'rietveld': u'https://codereview.chromium.org',
2562 }
2563 })
2564 self.assertEqual(build, {
2565 u'bucket': u'master.tryserver.chromium',
2566 u'client_operation_id': u'uuid4',
2567 u'tags': [u'builder:win',
2568 u'buildset:patch/rietveld/codereview.chromium.org/123/20001',
borenet6c0efe62016-10-19 08:13:29 -07002569 u'user_agent:git_cl_try',
2570 u'master:tryserver.chromium'],
tandriide281ae2016-10-12 06:02:30 -07002571 })
2572
2573 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2574
2575 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2576 self.assertEqual(0, git_cl.main([
2577 'try', '-m', 'tryserver.chromium', '-b', 'win',
2578 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2579 self.assertRegexpMatches(
2580 git_cl.sys.stdout.getvalue(),
borenet6c0efe62016-10-19 08:13:29 -07002581 'Tried jobs on:\nBucket: master.tryserver.chromium')
2582
tandrii8c5a3532016-11-04 07:52:02 -07002583 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2584 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2585 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2586
tandrii8c5a3532016-11-04 07:52:02 -07002587 self.calls = [
2588 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2589 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2590 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2591 ((['git', 'config', 'branch.feature.gerritserver'],),
2592 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002593 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2594 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2595 ((['git', 'config', 'remote.origin.url'],),
2596 'https://chromium.googlesource.com/depot_tools'),
2597 (('GetChangeDetail', 'chromium-review.googlesource.com',
2598 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002599 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002600 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002601 'status': 'OPEN',
2602 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002603 'revisions': {
2604 'deadbeaf': {
2605 '_number': 6,
2606 },
2607 'beeeeeef': {
2608 '_number': 7,
2609 'fetch': {'http': {
2610 'url': 'https://chromium.googlesource.com/depot_tools',
2611 'ref': 'refs/changes/56/123456/7'
2612 }},
2613 },
2614 },
2615 }),
2616 ]
2617
2618 def _buildbucket_retry(*_, **kw):
2619 # self.maxDiff = 10000
2620 body = json.loads(kw['body'])
2621 self.assertEqual(len(body['builds']), 1)
2622 build = body['builds'][0]
2623 params = json.loads(build.pop('parameters_json'))
2624 self.assertEqual(params, {
2625 u'builder_name': u'win',
2626 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2627 u'revision': None}],
2628 u'properties': {
2629 u'category': u'git_cl_try',
2630 u'key': u'val',
2631 u'json': [{u'a': 1}, None],
2632 u'master': u'tryserver.chromium',
2633
2634 u'patch_gerrit_url':
2635 u'https://chromium-review.googlesource.com',
2636 u'patch_issue': 123456,
2637 u'patch_project': u'depot_tools',
2638 u'patch_ref': u'refs/changes/56/123456/7',
2639 u'patch_repository_url':
2640 u'https://chromium.googlesource.com/depot_tools',
2641 u'patch_set': 7,
2642 u'patch_storage': u'gerrit',
2643 }
2644 })
2645 self.assertEqual(build, {
2646 u'bucket': u'master.tryserver.chromium',
2647 u'client_operation_id': u'uuid4',
2648 u'tags': [
2649 u'builder:win',
2650 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2651 u'user_agent:git_cl_try',
2652 u'master:tryserver.chromium'],
2653 })
2654
2655 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2656
2657 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2658 self.assertEqual(0, git_cl.main([
2659 'try', '-m', 'tryserver.chromium', '-b', 'win',
2660 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2661 self.assertRegexpMatches(
2662 git_cl.sys.stdout.getvalue(),
2663 'Tried jobs on:\nBucket: master.tryserver.chromium')
2664
borenet6c0efe62016-10-19 08:13:29 -07002665 def test_git_cl_try_buildbucket_bucket_flag(self):
tandrii8c5a3532016-11-04 07:52:02 -07002666 self.mock(git_cl._RietveldChangelistImpl, 'GetIssueProperties',
2667 lambda _: {
2668 'owner_email': 'owner@e.mail',
2669 'private': False,
2670 'closed': False,
2671 'project': 'depot_tools',
2672 'patchsets': [20001],
2673 })
borenet6c0efe62016-10-19 08:13:29 -07002674 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2675 self.calls = [
2676 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2677 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
2678 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2679 ((['git', 'config', 'rietveld.server'],),
2680 'https://codereview.chromium.org'),
borenet6c0efe62016-10-19 08:13:29 -07002681 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
tandrii8c5a3532016-11-04 07:52:02 -07002682 ((['git', 'config', 'branch.feature.rietveldserver'],), CERR1),
borenet6c0efe62016-10-19 08:13:29 -07002683 ]
2684
2685 def _buildbucket_retry(*_, **kw):
borenet6c0efe62016-10-19 08:13:29 -07002686 body = json.loads(kw['body'])
2687 self.assertEqual(len(body['builds']), 1)
2688 build = body['builds'][0]
2689 params = json.loads(build.pop('parameters_json'))
2690 self.assertEqual(params, {
2691 u'builder_name': u'win',
2692 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2693 u'revision': None}],
2694 u'properties': {
2695 u'category': u'git_cl_try',
2696 u'issue': 123,
2697 u'patch_project': u'depot_tools',
2698 u'patch_storage': u'rietveld',
2699 u'patchset': 20001,
borenet6c0efe62016-10-19 08:13:29 -07002700 u'rietveld': u'https://codereview.chromium.org',
2701 }
2702 })
2703 self.assertEqual(build, {
2704 u'bucket': u'test.bucket',
2705 u'client_operation_id': u'uuid4',
2706 u'tags': [u'builder:win',
2707 u'buildset:patch/rietveld/codereview.chromium.org/123/20001',
2708 u'user_agent:git_cl_try'],
2709 })
2710
2711 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2712
2713 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2714 self.assertEqual(0, git_cl.main([
2715 'try', '-B', 'test.bucket', '-b', 'win']))
2716 self.assertRegexpMatches(
2717 git_cl.sys.stdout.getvalue(),
2718 'Tried jobs on:\nBucket: test.bucket')
tandriide281ae2016-10-12 06:02:30 -07002719
qyearsley123a4682016-10-26 09:12:17 -07002720 def test_git_cl_try_bots_on_multiple_masters(self):
2721 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 20001)
2722 self.calls = [
2723 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2724 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
2725 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2726 ((['git', 'config', 'rietveld.server'],),
tandrii8c5a3532016-11-04 07:52:02 -07002727 'https://codereview.chromium.org'),
qyearsley123a4682016-10-26 09:12:17 -07002728 ((['git', 'config', 'branch.feature.rietveldserver'],), CERR1),
2729 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
2730 ]
2731
2732 def _buildbucket_retry(*_, **kw):
2733 body = json.loads(kw['body'])
2734 self.assertEqual(len(body['builds']), 2)
2735
Nodir Turakulovb422e682018-02-20 22:51:30 -08002736 self.assertEqual(body['builds'][0]['bucket'], 'bucket1')
2737 params = json.loads(body['builds'][0]['parameters_json'])
2738 self.assertEqual(params['builder_name'], 'builder1')
qyearsley123a4682016-10-26 09:12:17 -07002739
Nodir Turakulovb422e682018-02-20 22:51:30 -08002740 self.assertEqual(body['builds'][1]['bucket'], 'bucket2')
2741 params = json.loads(body['builds'][1]['parameters_json'])
2742 self.assertEqual(params['builder_name'], 'builder2')
qyearsley123a4682016-10-26 09:12:17 -07002743
2744 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2745
2746 self.mock(git_cl.urllib2, 'urlopen', lambda _: StringIO.StringIO(
Nodir Turakulovb422e682018-02-20 22:51:30 -08002747 json.dumps({
2748 'builder1': {'bucket': 'bucket1'},
2749 'builder2': {'bucket': 'bucket2'},
2750 })))
qyearsley123a4682016-10-26 09:12:17 -07002751
2752 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2753 self.assertEqual(
2754 0, git_cl.main(['try', '-b', 'builder1', '-b', 'builder2']))
2755 self.assertEqual(
2756 git_cl.sys.stdout.getvalue(),
2757 'Tried jobs on:\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002758 'Bucket: bucket1\n'
qyearsley123a4682016-10-26 09:12:17 -07002759 ' builder1: []\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002760 'Bucket: bucket2\n'
qyearsley123a4682016-10-26 09:12:17 -07002761 ' builder2: []\n'
2762 'To see results here, run: git cl try-results\n'
2763 'To see results in browser, run: git cl web\n')
2764
tandrii16e0b4e2016-06-07 10:34:28 -07002765 def _common_GerritCommitMsgHookCheck(self):
2766 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2767 self.mock(git_cl.os.path, 'abspath',
2768 lambda path: self._mocked_call(['abspath', path]))
2769 self.mock(git_cl.os.path, 'exists',
2770 lambda path: self._mocked_call(['exists', path]))
2771 self.mock(git_cl.gclient_utils, 'FileRead',
2772 lambda path: self._mocked_call(['FileRead', path]))
2773 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2774 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2775 self.calls = [
2776 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2777 ((['abspath', '../'],), '/abs/git_repo_root'),
2778 ]
2779 return git_cl.Changelist(codereview='gerrit', issue=123)
2780
2781 def test_GerritCommitMsgHookCheck_custom_hook(self):
2782 cl = self._common_GerritCommitMsgHookCheck()
2783 self.calls += [
2784 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2785 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2786 '#!/bin/sh\necho "custom hook"')
2787 ]
2788 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2789
2790 def test_GerritCommitMsgHookCheck_not_exists(self):
2791 cl = self._common_GerritCommitMsgHookCheck()
2792 self.calls += [
2793 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2794 ]
2795 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2796
2797 def test_GerritCommitMsgHookCheck(self):
2798 cl = self._common_GerritCommitMsgHookCheck()
2799 self.calls += [
2800 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2801 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2802 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002803 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002804 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2805 ''),
2806 ]
2807 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2808
tandriic4344b52016-08-29 06:04:54 -07002809 def test_GerritCmdLand(self):
2810 self.calls += [
2811 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2812 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2813 'deadbeaf'),
2814 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2815 ((['git', 'config', 'branch.feature.gerritserver'],),
2816 'chromium-review.googlesource.com'),
2817 ]
2818 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2819 cl._codereview_impl._GetChangeDetail = lambda _: {
2820 'labels': {},
2821 'current_revision': 'deadbeaf',
2822 }
agable32978d92016-11-01 12:55:02 -07002823 cl._codereview_impl._GetChangeCommit = lambda: {
2824 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002825 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002826 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2827 }
tandriic4344b52016-08-29 06:04:54 -07002828 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002829 out = StringIO.StringIO()
2830 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002831 self.assertEqual(0, cl.CMDLand(force=True,
2832 bypass_hooks=True,
2833 verbose=True,
2834 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002835 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002836 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002837
tandrii221ab252016-10-06 08:12:04 -07002838 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002839 '9000': {
2840 'id': '9000',
2841 'bucket': 'master.x.y',
2842 'created_by': 'user:someone@chromium.org',
2843 'created_ts': '147200002222000',
2844 'experimental': False,
2845 'parameters_json': json.dumps({
2846 'builder_name': 'my-bot',
2847 'properties': {'category': 'cq'},
2848 }),
2849 'status': 'STARTED',
2850 'tags': [
2851 'build_address:x.y/my-bot/2',
2852 'builder:my-bot',
2853 'experimental:false',
2854 'user_agent:cq',
2855 ],
2856 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2857 },
2858 '8000': {
2859 'id': '8000',
2860 'bucket': 'master.x.y',
2861 'created_by': 'user:someone@chromium.org',
2862 'created_ts': '147200001111000',
2863 'experimental': False,
2864 'failure_reason': 'BUILD_FAILURE',
2865 'parameters_json': json.dumps({
2866 'builder_name': 'my-bot',
2867 'properties': {'category': 'cq'},
2868 }),
2869 'result_details_json': json.dumps({
2870 'properties': {'buildnumber': 1},
2871 }),
2872 'result': 'FAILURE',
2873 'status': 'COMPLETED',
2874 'tags': [
2875 'build_address:x.y/my-bot/1',
2876 'builder:my-bot',
2877 'experimental:false',
2878 'user_agent:cq',
2879 ],
2880 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2881 },
2882 }
tandrii221ab252016-10-06 08:12:04 -07002883
2884 def test_write_try_results_json(self):
2885 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002886 {
2887 'bucket': 'master.x.y',
2888 'buildbucket_id': '8000',
2889 'builder_name': 'my-bot',
2890 'created_ts': '147200001111000',
2891 'experimental': False,
2892 'failure_reason': 'BUILD_FAILURE',
2893 'result': 'FAILURE',
2894 'status': 'COMPLETED',
2895 'tags': [
2896 'build_address:x.y/my-bot/1',
2897 'builder:my-bot',
2898 'experimental:false',
2899 'user_agent:cq',
2900 ],
2901 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2902 },
2903 {
2904 'bucket': 'master.x.y',
2905 'buildbucket_id': '9000',
2906 'builder_name': 'my-bot',
2907 'created_ts': '147200002222000',
2908 'experimental': False,
2909 'failure_reason': None,
2910 'result': None,
2911 'status': 'STARTED',
2912 'tags': [
2913 'build_address:x.y/my-bot/2',
2914 'builder:my-bot',
2915 'experimental:false',
2916 'user_agent:cq',
2917 ],
2918 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2919 },
tandrii221ab252016-10-06 08:12:04 -07002920 ]
2921 self.calls = [(('write_json', 'output.json', expected_output), '')]
2922 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2923
tandrii45b2a582016-10-11 03:14:16 -07002924 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002925 out = StringIO.StringIO()
2926 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002927 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2928 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002929 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2930 self._mocked_call(['get_authenticator_for_host', host]))
2931 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2932 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002933
2934 def _setup_fetch_try_jobs_rietveld(self, *request_results):
2935 self._setup_fetch_try_jobs(most_recent_patchset=20001)
tandrii221ab252016-10-06 08:12:04 -07002936 self.calls += [
2937 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2938 ((['git', 'config', 'branch.feature.rietveldissue'],), '1'),
2939 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2940 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2941 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
2942 ((['git', 'config', 'branch.feature.rietveldserver'],),
2943 'codereview.example.com'),
2944 ((['get_authenticator_for_host', 'codereview.example.com'],),
2945 AuthenticatorMock()),
2946 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2947
2948 def test_fetch_try_jobs_none_rietveld(self):
2949 self._setup_fetch_try_jobs_rietveld({})
tandrii45b2a582016-10-11 03:14:16 -07002950 # Simulate that user isn't logged in.
2951 self.mock(AuthenticatorMock, 'has_cached_credentials', lambda _: False)
tandrii221ab252016-10-06 08:12:04 -07002952 self.assertEqual(0, git_cl.main(['try-results']))
tandrii45b2a582016-10-11 03:14:16 -07002953 self.assertRegexpMatches(sys.stdout.getvalue(),
2954 'Warning: Some results might be missing')
tandrii221ab252016-10-06 08:12:04 -07002955 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2956
2957 def test_fetch_try_jobs_some_rietveld(self):
2958 self._setup_fetch_try_jobs_rietveld({
2959 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2960 })
2961 self.assertEqual(0, git_cl.main(['try-results']))
tandrii45b2a582016-10-11 03:14:16 -07002962 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
2963 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2964 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2965
2966 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2967 self._setup_fetch_try_jobs(most_recent_patchset=13)
2968 self.calls += [
2969 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2970 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2971 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002972 # TODO(tandrii): Uncomment the below if we decide to support checking
2973 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002974 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002975 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002976 ((['git', 'config', 'branch.feature.gerritserver'],),
2977 'https://x-review.googlesource.com'),
2978 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2979 AuthenticatorMock()),
2980 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2981
2982 def test_fetch_try_jobs_none_gerrit(self):
2983 self._setup_fetch_try_jobs_gerrit({})
2984 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002985 # TODO(tandrii): Uncomment the below if we decide to support checking
2986 # patchsets for Gerrit.
2987 # self.assertRegexpMatches(
2988 # sys.stdout.getvalue(),
2989 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07002990 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2991
2992 def test_fetch_try_jobs_some_gerrit(self):
2993 self._setup_fetch_try_jobs_gerrit({
2994 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2995 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002996 # TODO(tandrii): Uncomment the below if we decide to support checking
2997 # patchsets for Gerrit.
2998 # self.calls.remove(
2999 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07003000 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
3001
3002 # ... and doesn't result in warning.
3003 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
3004 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07003005 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
3006 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
3007
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003008 def _mock_gerrit_changes_for_detail_cache(self):
3009 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003010
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003011 def test_gerrit_change_detail_cache_simple(self):
3012 self._mock_gerrit_changes_for_detail_cache()
3013 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003014 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
3015 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
3016 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003017 ]
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00003018 cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003019 cl1._cached_remote_url = (
3020 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00003021 cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003022 cl2._cached_remote_url = (
3023 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00003024 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
3025 self.assertEqual(cl1._GetChangeDetail(), 'a')
3026 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
3027 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
3028 self.assertEqual(cl1._GetChangeDetail(), 'a')
3029 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003030
3031 def test_gerrit_change_detail_cache_options(self):
3032 self._mock_gerrit_changes_for_detail_cache()
3033 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003034 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
3035 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
3036 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
3037 # no longer in cache.
3038 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003039 ]
3040 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003041 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003042 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
3043 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
3044 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
3045 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
3046 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
3047 self.assertEqual(cl._GetChangeDetail(), 'cab')
3048
3049 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
3050 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
3051 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
3052 self.assertEqual(cl._GetChangeDetail(), 'cab')
3053
3054 # Finally, no_cache should invalidate all caches for given change.
3055 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
3056 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
3057
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01003058 def test_gerrit_description_caching(self):
3059 def gen_detail(rev, desc):
3060 return {
3061 'current_revision': rev,
3062 'revisions': {rev: {'commit': {'message': desc}}}
3063 }
3064 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003065 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01003066 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
3067 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003068 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01003069 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
3070 gen_detail('rev2', 'desc2')),
3071 ]
3072
3073 self._mock_gerrit_changes_for_detail_cache()
3074 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003075 cl._cached_remote_url = (
3076 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01003077 self.assertEqual(cl.GetDescription(), 'desc1')
3078 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
3079 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00003080
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003081 def test_print_current_creds(self):
3082 class CookiesAuthenticatorMock(object):
3083 def __init__(self):
3084 self.gitcookies = {
3085 'host.googlesource.com': ('user', 'pass'),
3086 'host-review.googlesource.com': ('user', 'pass'),
3087 }
3088 self.netrc = self
3089 self.netrc.hosts = {
3090 'github.com': ('user2', None, 'pass2'),
3091 'host2.googlesource.com': ('user3', None, 'pass'),
3092 }
3093 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
3094 CookiesAuthenticatorMock)
3095 self.mock(sys, 'stdout', StringIO.StringIO())
3096 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
3097 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
3098 ' Host\t User\t Which file',
3099 '============================\t=====\t===========',
3100 'host-review.googlesource.com\t user\t.gitcookies',
3101 ' host.googlesource.com\t user\t.gitcookies',
3102 ' host2.googlesource.com\tuser3\t .netrc',
3103 ])
3104 sys.stdout.buf = ''
3105 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
3106 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
3107 ' Host\tUser\t Which file',
3108 '============================\t====\t===========',
3109 'host-review.googlesource.com\tuser\t.gitcookies',
3110 ' host.googlesource.com\tuser\t.gitcookies',
3111 ])
3112
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003113 def _common_creds_check_mocks(self):
3114 def exists_mock(path):
3115 dirname = os.path.dirname(path)
3116 if dirname == os.path.expanduser('~'):
3117 dirname = '~'
3118 base = os.path.basename(path)
3119 if base in ('.netrc', '.gitcookies'):
3120 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
3121 # git cl also checks for existence other files not relevant to this test.
3122 return None
3123 self.mock(os.path, 'exists', exists_mock)
3124 self.mock(sys, 'stdout', StringIO.StringIO())
3125
3126 def test_creds_check_gitcookies_not_configured(self):
3127 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003128 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003129 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003130 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08003131 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003132 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
3133 (('os.path.exists', '~/.netrc'), True),
3134 (('ask_for_data', 'Press Enter to setup .gitcookies, '
3135 'or Ctrl+C to abort'), ''),
3136 ((['git', 'config', '--global', 'http.cookiefile',
3137 os.path.expanduser('~/.gitcookies')], ), ''),
3138 ]
3139 self.assertEqual(0, git_cl.main(['creds-check']))
3140 self.assertRegexpMatches(
3141 sys.stdout.getvalue(),
3142 '^You seem to be using outdated .netrc for git credentials:')
3143 self.assertRegexpMatches(
3144 sys.stdout.getvalue(),
3145 '\nConfigured git to use .gitcookies from')
3146
3147 def test_creds_check_gitcookies_configured_custom_broken(self):
3148 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003149 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003150 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003151 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08003152 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003153 ((['git', 'config', '--global', 'http.cookiefile'],),
3154 '/custom/.gitcookies'),
3155 (('os.path.exists', '/custom/.gitcookies'), False),
3156 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
3157 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
3158 ((['git', 'config', '--global', 'http.cookiefile',
3159 os.path.expanduser('~/.gitcookies')], ), ''),
3160 ]
3161 self.assertEqual(0, git_cl.main(['creds-check']))
3162 self.assertRegexpMatches(
3163 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003164 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003165 self.assertRegexpMatches(
3166 sys.stdout.getvalue(),
3167 'However, your configured .gitcookies file is missing.')
3168
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003169 def test_git_cl_comment_add_rietveld(self):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01003170 self.mock(git_cl._RietveldChangelistImpl, 'AddComment',
Aaron Gable636b13f2017-07-14 10:42:48 -07003171 lambda _, message, publish: self._mocked_call(
3172 'AddComment', message, publish))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01003173 self.calls = [
3174 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
3175 ((['git', 'config', 'rietveld.server'],), 'codereview.chromium.org'),
Aaron Gable636b13f2017-07-14 10:42:48 -07003176 (('AddComment', 'msg', None), ''),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01003177 ]
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003178 self.assertEqual(0, git_cl.main(['comment', '--rietveld',
3179 '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01003180
3181 def test_git_cl_comment_add_gerrit(self):
3182 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07003183 lambda host, change, msg, ready:
3184 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01003185 self.calls = [
3186 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
3187 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
3188 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3189 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3190 'origin/master'),
3191 ((['git', 'config', 'remote.origin.url'],),
3192 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00003193 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
3194 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07003195 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01003196 ]
3197 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
3198 '-a', 'msg']))
3199
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003200 def test_git_cl_comments_fetch_rietveld(self):
3201 self.mock(sys, 'stdout', StringIO.StringIO())
3202 self.calls = [
3203 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
3204 ((['git', 'config', 'rietveld.server'],), 'codereview.chromium.org'),
Leszek Swirski45b20c42018-09-17 17:05:26 +00003205 ] * 2 + [
3206 (('write_json', 'output.json', [
3207 {
3208 'date': '2000-03-13 20:49:34.515270',
3209 'message': 'PTAL',
3210 'approval': False,
3211 'disapproval': False,
3212 'sender': 'owner@example.com'
3213 }, {
3214 'date': '2017-03-13 20:49:34.515270',
3215 'message': 'lgtm',
3216 'approval': True,
3217 'disapproval': False,
3218 'sender': 'r@example.com'
3219 }, {
3220 'date': '2017-03-13 21:50:34.515270',
3221 'message': 'not lgtm',
3222 'approval': False,
3223 'disapproval': True,
3224 'sender': 'r2@example.com'
3225 }
3226 ]),'')
3227 ]
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003228 self.mock(git_cl._RietveldChangelistImpl, 'GetIssueProperties', lambda _: {
3229 'messages': [
3230 {'text': 'lgtm', 'date': '2017-03-13 20:49:34.515270',
3231 'disapproval': False, 'approval': True, 'sender': 'r@example.com'},
3232 {'text': 'not lgtm', 'date': '2017-03-13 21:50:34.515270',
3233 'disapproval': True, 'approval': False, 'sender': 'r2@example.com'},
3234 # Intentionally wrong order here.
3235 {'text': 'PTAL', 'date': '2000-03-13 20:49:34.515270',
3236 'disapproval': False, 'approval': False,
3237 'sender': 'owner@example.com'},
3238 ],
3239 'owner_email': 'owner@example.com',
3240 })
3241 expected_comments_summary = [
3242 git_cl._CommentSummary(
3243 message='lgtm',
3244 date=datetime.datetime(2017, 3, 13, 20, 49, 34, 515270),
3245 disapproval=False, approval=True, sender='r@example.com'),
3246 git_cl._CommentSummary(
3247 message='not lgtm',
3248 date=datetime.datetime(2017, 3, 13, 21, 50, 34, 515270),
3249 disapproval=True, approval=False, sender='r2@example.com'),
3250 # Note: same order as in whatever Rietveld returns.
3251 git_cl._CommentSummary(
3252 message='PTAL',
3253 date=datetime.datetime(2000, 3, 13, 20, 49, 34, 515270),
3254 disapproval=False, approval=False, sender='owner@example.com'),
3255 ]
3256 cl = git_cl.Changelist(codereview='rietveld', issue=1)
3257 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Leszek Swirski45b20c42018-09-17 17:05:26 +00003258 self.assertEqual(0, git_cl.main(['comment', '--rietveld', '-i', '10',
3259 '-j', 'output.json']))
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003260
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003261 def test_git_cl_comments_fetch_gerrit(self):
3262 self.mock(sys, 'stdout', StringIO.StringIO())
3263 self.calls = [
3264 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
3265 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
3266 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3267 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3268 'origin/master'),
3269 ((['git', 'config', 'remote.origin.url'],),
3270 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003271 (('GetChangeDetail', 'chromium-review.googlesource.com',
3272 'infra%2Finfra~1',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003273 ['MESSAGES', 'DETAILED_ACCOUNTS']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003274 'owner': {'email': 'owner@example.com'},
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003275 'messages': [
3276 {
3277 u'_revision_number': 1,
3278 u'author': {
3279 u'_account_id': 1111084,
3280 u'email': u'commit-bot@chromium.org',
3281 u'name': u'Commit Bot'
3282 },
3283 u'date': u'2017-03-15 20:08:45.000000000',
3284 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07003285 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003286 u'tag': u'autogenerated:cq:dry-run'
3287 },
3288 {
3289 u'_revision_number': 2,
3290 u'author': {
3291 u'_account_id': 11151243,
3292 u'email': u'owner@example.com',
3293 u'name': u'owner'
3294 },
3295 u'date': u'2017-03-16 20:00:41.000000000',
3296 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3297 u'message': u'PTAL',
3298 },
3299 {
3300 u'_revision_number': 2,
3301 u'author': {
3302 u'_account_id': 148512 ,
3303 u'email': u'reviewer@example.com',
3304 u'name': u'reviewer'
3305 },
3306 u'date': u'2017-03-17 05:19:37.500000000',
3307 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
3308 u'message': u'Patch Set 2: Code-Review+1',
3309 },
3310 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003311 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00003312 (('GetChangeComments', 'chromium-review.googlesource.com',
3313 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003314 '/COMMIT_MSG': [
3315 {
3316 'author': {'email': u'reviewer@example.com'},
3317 'updated': u'2017-03-17 05:19:37.500000000',
3318 'patch_set': 2,
3319 'side': 'REVISION',
3320 'message': 'Please include a bug link',
3321 },
3322 ],
3323 'codereview.settings': [
3324 {
3325 'author': {'email': u'owner@example.com'},
3326 'updated': u'2017-03-16 20:00:41.000000000',
3327 'patch_set': 2,
3328 'side': 'PARENT',
3329 'line': 42,
3330 'message': 'I removed this because it is bad',
3331 },
3332 ]
Leszek Swirski45b20c42018-09-17 17:05:26 +00003333 })
3334 ] * 2 + [
3335 (('write_json', 'output.json', [
3336 {
3337 u'date': u'2017-03-16 20:00:41.000000',
3338 u'message': (
3339 u'PTAL\n' +
3340 u'\n' +
3341 u'codereview.settings\n' +
3342 u' Base, Line 42: https://chromium-review.googlesource.com/' +
3343 u'c/1/2/codereview.settings#b42\n' +
3344 u' I removed this because it is bad\n'),
3345 u'approval': False,
3346 u'disapproval': False,
3347 u'sender': u'owner@example.com'
3348 }, {
3349 u'date': u'2017-03-17 05:19:37.500000',
3350 u'message': (
3351 u'Patch Set 2: Code-Review+1\n' +
3352 u'\n' +
3353 u'/COMMIT_MSG\n' +
3354 u' PS2, File comment: https://chromium-review.googlesource' +
3355 u'.com/c/1/2//COMMIT_MSG#\n' +
3356 u' Please include a bug link\n'),
3357 u'approval': False,
3358 u'disapproval': False,
3359 u'sender': u'reviewer@example.com'
3360 }
3361 ]),'')
3362 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003363 expected_comments_summary = [
3364 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003365 message=(
3366 u'PTAL\n' +
3367 u'\n' +
3368 u'codereview.settings\n' +
3369 u' Base, Line 42: https://chromium-review.googlesource.com/' +
3370 u'c/1/2/codereview.settings#b42\n' +
3371 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003372 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
3373 disapproval=False, approval=False, sender=u'owner@example.com'),
3374 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003375 message=(
3376 u'Patch Set 2: Code-Review+1\n' +
3377 u'\n' +
3378 u'/COMMIT_MSG\n' +
3379 u' PS2, File comment: https://chromium-review.googlesource.com/' +
3380 u'c/1/2//COMMIT_MSG#\n' +
3381 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003382 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
3383 disapproval=False, approval=False, sender=u'reviewer@example.com'),
3384 ]
3385 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3386 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Leszek Swirski45b20c42018-09-17 17:05:26 +00003387 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '1',
3388 '-j', 'output.json']))
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003389
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003390 def test_get_remote_url_with_mirror(self):
3391 original_os_path_isdir = os.path.isdir
3392 def selective_os_path_isdir_mock(path):
3393 if path == '/cache/this-dir-exists':
3394 return self._mocked_call('os.path.isdir', path)
3395 return original_os_path_isdir(path)
3396 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3397
3398 url = 'https://chromium.googlesource.com/my/repo'
3399 self.calls = [
3400 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3401 ((['git', 'config', 'branch.master.merge'],), 'master'),
3402 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3403 ((['git', 'config', 'remote.origin.url'],),
3404 '/cache/this-dir-exists'),
3405 (('os.path.isdir', '/cache/this-dir-exists'),
3406 True),
3407 # Runs in /cache/this-dir-exists.
3408 ((['git', 'config', 'remote.origin.url'],),
3409 url),
3410 ]
3411 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3412 self.assertEqual(cl.GetRemoteUrl(), url)
3413 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3414
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003415 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003416 self.calls = [
3417 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3418 ((['git', 'config', 'branch.master.merge'],), 'master'),
3419 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3420 ((['git', 'config', 'remote.origin.url'],),
3421 'https://chromium.googlesource.com/a/my/repo.git/'),
3422 ]
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003423 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3424 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3425
3426 def test_gerrit_change_identifier_without_project(self):
3427 self.calls = [
3428 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3429 ((['git', 'config', 'branch.master.merge'],), 'master'),
3430 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3431 ((['git', 'config', 'remote.origin.url'],), CERR1),
3432 ]
3433 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3434 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003435
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003436
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003437if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003438 logging.basicConfig(
3439 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003440 unittest.main()