blob: a267e9549b4d276445bb0897b1bdb3d863a23e98 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01009import datetime
tandriide281ae2016-10-12 06:02:30 -070010import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010011import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000012import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
22
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000023import metrics
24# We have to disable monitoring before importing git_cl.
25metrics.DISABLE_METRICS_COLLECTION = True
26
maruel@chromium.orgddd59412011-11-30 14:20:38 +000027import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000028import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000029import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000030import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031
tandrii5d48c322016-08-18 16:19:37 -070032def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
33 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
34
35
36CERR1 = callError(1)
37
38
Aaron Gable9a03ae02017-11-03 11:31:07 -070039def MakeNamedTemporaryFileMock(expected_content):
40 class NamedTemporaryFileMock(object):
41 def __init__(self, *args, **kwargs):
42 self.name = '/tmp/named'
43 self.expected_content = expected_content
44
45 def __enter__(self):
46 return self
47
48 def __exit__(self, _type, _value, _tb):
49 pass
50
51 def write(self, content):
52 if self.expected_content:
53 assert content == self.expected_content
54
55 def close(self):
56 pass
57
58 return NamedTemporaryFileMock
59
60
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000061class ChangelistMock(object):
62 # A class variable so we can access it when we don't have access to the
63 # instance that's being set.
64 desc = ""
65 def __init__(self, **kwargs):
66 pass
67 def GetIssue(self):
68 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080069 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000070 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070071 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000072 ChangelistMock.desc = desc
73
tandrii5d48c322016-08-18 16:19:37 -070074
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000075class PresubmitMock(object):
76 def __init__(self, *args, **kwargs):
77 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080078 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
79
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000080 @staticmethod
81 def should_continue():
82 return True
83
84
85class RietveldMock(object):
86 def __init__(self, *args, **kwargs):
87 pass
maruel@chromium.org78936cb2013-04-11 00:17:52 +000088
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000089 @staticmethod
Kenneth Russell61e2ed42017-02-15 11:47:13 -080090 def get_description(issue, force=False):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000091 return 'Issue: %d' % issue
92
maruel@chromium.org78936cb2013-04-11 00:17:52 +000093 @staticmethod
94 def get_issue_properties(_issue, _messages):
95 return {
96 'reviewers': ['joe@chromium.org', 'john@chromium.org'],
97 'messages': [
98 {
99 'approval': True,
Aaron Gablea1bab272017-04-11 16:38:18 -0700100 'disapproval': False,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000101 'sender': 'john@chromium.org',
102 },
103 ],
Andrii Shyshkalov06a25022016-11-24 16:47:00 +0100104 'patchsets': [1, 20001],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000105 }
106
iannuccie53c9352016-08-17 14:40:40 -0700107 @staticmethod
108 def close_issue(_issue):
109 return 'Closed'
110
skobes6468b902016-10-24 08:45:10 -0700111 @staticmethod
112 def get_patch(issue, patchset):
113 return 'patch set from issue %s patchset %s' % (issue, patchset)
114
Andrii Shyshkalov06a25022016-11-24 16:47:00 +0100115 @staticmethod
116 def update_description(_issue, _description):
117 return 'Updated'
118
119 @staticmethod
120 def add_comment(_issue, _comment):
121 return 'Commented'
122
123
skobes6468b902016-10-24 08:45:10 -0700124class GitCheckoutMock(object):
125 def __init__(self, *args, **kwargs):
126 pass
127
128 @staticmethod
129 def reset():
130 GitCheckoutMock.conflict = False
131
132 def apply_patch(self, p):
133 if GitCheckoutMock.conflict:
134 raise Exception('failed')
135
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000136
137class WatchlistsMock(object):
138 def __init__(self, _):
139 pass
140 @staticmethod
141 def GetWatchersForPaths(_):
142 return ['joe@example.com']
143
144
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000145class CodereviewSettingsFileMock(object):
146 def __init__(self):
147 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800148 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000149 def read(self):
150 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000151 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000152
153
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000154class AuthenticatorMock(object):
155 def __init__(self, *_args):
156 pass
157 def has_cached_credentials(self):
158 return True
tandrii221ab252016-10-06 08:12:04 -0700159 def authorize(self, http):
160 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000161
162
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100163def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000164 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
165
166 Usage:
167 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100168 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000169
170 OR
171 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100172 CookiesAuthenticatorMockFactory(
173 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000174 """
175 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800176 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000177 # Intentionally not calling super() because it reads actual cookie files.
178 pass
179 @classmethod
180 def get_gitcookies_path(cls):
181 return '~/.gitcookies'
182 @classmethod
183 def get_netrc_path(cls):
184 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100185 def _get_auth_for_host(self, host):
186 if same_auth:
187 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000188 return (hosts_with_creds or {}).get(host)
189 return CookiesAuthenticatorMock
190
Aaron Gable9a03ae02017-11-03 11:31:07 -0700191
kmarshall9249e012016-08-23 12:02:16 -0700192class MockChangelistWithBranchAndIssue():
193 def __init__(self, branch, issue):
194 self.branch = branch
195 self.issue = issue
196 def GetBranch(self):
197 return self.branch
198 def GetIssue(self):
199 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000200
tandriic2405f52016-10-10 08:13:15 -0700201
202class SystemExitMock(Exception):
203 pass
204
205
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000206class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100207 def test_get_description(self):
208 cl = git_cl.Changelist(issue=1, codereview='rietveld',
209 codereview_host='host')
210 cl.description = 'x'
211 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800212 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100213 self.assertEquals(cl.GetDescription(), 'x')
214 self.assertEquals(cl.GetDescription(force=True), 'y')
215 self.assertEquals(cl.GetDescription(), 'y')
216
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700217 def test_description_footers(self):
218 cl = git_cl.Changelist(issue=1, codereview='gerrit',
219 codereview_host='host')
220 cl.description = '\n'.join([
221 'This is some message',
222 '',
223 'It has some lines',
224 'and, also',
225 '',
226 'Some: Really',
227 'Awesome: Footers',
228 ])
229 cl.has_description = True
230 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
231 msg, footers = cl.GetDescriptionFooters()
232 self.assertEquals(
233 msg, ['This is some message', '', 'It has some lines', 'and, also'])
234 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
235
236 msg.append('wut')
237 footers.append(('gnarly-dude', 'beans'))
238 cl.UpdateDescriptionFooters(msg, footers)
239 self.assertEquals(cl.GetDescription().splitlines(), [
240 'This is some message',
241 '',
242 'It has some lines',
243 'and, also',
244 'wut'
245 '',
246 'Some: Really',
247 'Awesome: Footers',
248 'Gnarly-Dude: beans',
249 ])
250
tandriif9aefb72016-07-01 09:06:51 -0700251 def test_get_bug_line_values(self):
252 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
253 self.assertEqual(f('', ''), [])
254 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
255 self.assertEqual(f('v8', '456'), ['v8:456'])
256 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
257 # Not nice, but not worth carying.
258 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
259 ['v8:456', 'chromium:123', 'v8:123'])
260
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100261 def _test_git_number(self, parent_msg, dest_ref, child_msg,
262 parent_hash='parenthash'):
263 desc = git_cl.ChangeDescription(child_msg)
264 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
265 return desc.description
266
267 def assertEqualByLine(self, actual, expected):
268 self.assertEqual(actual.splitlines(), expected.splitlines())
269
270 def test_git_number_bad_parent(self):
271 with self.assertRaises(ValueError):
272 self._test_git_number('Parent', 'refs/heads/master', 'Child')
273
274 def test_git_number_bad_parent_footer(self):
275 with self.assertRaises(AssertionError):
276 self._test_git_number(
277 'Parent\n'
278 '\n'
279 'Cr-Commit-Position: wrong',
280 'refs/heads/master', 'Child')
281
282 def test_git_number_bad_lineage_ignored(self):
283 actual = self._test_git_number(
284 'Parent\n'
285 '\n'
286 'Cr-Commit-Position: refs/heads/master@{#1}\n'
287 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
288 'refs/heads/master', 'Child')
289 self.assertEqualByLine(
290 actual,
291 'Child\n'
292 '\n'
293 'Cr-Commit-Position: refs/heads/master@{#2}\n'
294 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
295
296 def test_git_number_same_branch(self):
297 actual = self._test_git_number(
298 'Parent\n'
299 '\n'
300 'Cr-Commit-Position: refs/heads/master@{#12}',
301 dest_ref='refs/heads/master',
302 child_msg='Child')
303 self.assertEqualByLine(
304 actual,
305 'Child\n'
306 '\n'
307 'Cr-Commit-Position: refs/heads/master@{#13}')
308
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200309 def test_git_number_same_branch_mixed_footers(self):
310 actual = self._test_git_number(
311 'Parent\n'
312 '\n'
313 'Cr-Commit-Position: refs/heads/master@{#12}',
314 dest_ref='refs/heads/master',
315 child_msg='Child\n'
316 '\n'
317 'Broken-by: design\n'
318 'BUG=123')
319 self.assertEqualByLine(
320 actual,
321 'Child\n'
322 '\n'
323 'Broken-by: design\n'
324 'BUG=123\n'
325 'Cr-Commit-Position: refs/heads/master@{#13}')
326
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100327 def test_git_number_same_branch_with_originals(self):
328 actual = self._test_git_number(
329 'Parent\n'
330 '\n'
331 'Cr-Commit-Position: refs/heads/master@{#12}',
332 dest_ref='refs/heads/master',
333 child_msg='Child\n'
334 '\n'
335 'Some users are smart and insert their own footers\n'
336 '\n'
337 'Cr-Whatever: value\n'
338 'Cr-Commit-Position: refs/copy/paste@{#22}')
339 self.assertEqualByLine(
340 actual,
341 'Child\n'
342 '\n'
343 'Some users are smart and insert their own footers\n'
344 '\n'
345 'Cr-Original-Whatever: value\n'
346 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
347 'Cr-Commit-Position: refs/heads/master@{#13}')
348
349 def test_git_number_new_branch(self):
350 actual = self._test_git_number(
351 'Parent\n'
352 '\n'
353 'Cr-Commit-Position: refs/heads/master@{#12}',
354 dest_ref='refs/heads/branch',
355 child_msg='Child')
356 self.assertEqualByLine(
357 actual,
358 'Child\n'
359 '\n'
360 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
361 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
362
363 def test_git_number_lineage(self):
364 actual = self._test_git_number(
365 'Parent\n'
366 '\n'
367 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
368 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
369 dest_ref='refs/heads/branch',
370 child_msg='Child')
371 self.assertEqualByLine(
372 actual,
373 'Child\n'
374 '\n'
375 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
376 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
377
378 def test_git_number_moooooooore_lineage(self):
379 actual = self._test_git_number(
380 'Parent\n'
381 '\n'
382 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
383 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
384 dest_ref='refs/heads/mooore',
385 child_msg='Child')
386 self.assertEqualByLine(
387 actual,
388 'Child\n'
389 '\n'
390 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
391 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
392 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
393
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100394 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700395 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100396 actual = self._test_git_number(
397 'CQ commit on fresh new branch + numbering.\n'
398 '\n'
399 'NOTRY=True\n'
400 'NOPRESUBMIT=True\n'
401 'BUG=\n'
402 '\n'
403 'Review-Url: https://codereview.chromium.org/2577703003\n'
404 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
405 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
406 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
407 dest_ref='refs/heads/gnumb-test/cl',
408 child_msg='git cl on fresh new branch + numbering.\n'
409 '\n'
410 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
411 self.assertEqualByLine(
412 actual,
413 'git cl on fresh new branch + numbering.\n'
414 '\n'
415 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
416 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
417 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
418 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
419 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100420
421 def test_git_number_cherry_pick(self):
422 actual = self._test_git_number(
423 'Parent\n'
424 '\n'
425 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
426 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
427 dest_ref='refs/heads/branch',
428 child_msg='Child, which is cherry-pick from master\n'
429 '\n'
430 'Cr-Commit-Position: refs/heads/master@{#100}\n'
431 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
432 self.assertEqualByLine(
433 actual,
434 'Child, which is cherry-pick from master\n'
435 '\n'
436 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
437 '\n'
438 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
439 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
440 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
441
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000442 def test_gerrit_mirror_hack(self):
443 cr = 'chromium-review.googlesource.com'
444 url0 = 'https://%s/a/changes/x?a=b' % cr
445 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
446 try:
447 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
448 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
449 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
450 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
451
452 self.assertNotEqual(url1, url2)
453 self.assertEqual(sorted((url1, url2)), [
454 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
455 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
456 self.assertEqual(url1, url3)
457 finally:
458 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
459
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000460
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200461class TestParseIssueURL(unittest.TestCase):
462 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
463 codereview=None, fail=False):
464 self.assertIsNotNone(parsed)
465 if fail:
466 self.assertFalse(parsed.valid)
467 return
468 self.assertTrue(parsed.valid)
469 self.assertEqual(parsed.issue, issue)
470 self.assertEqual(parsed.patchset, patchset)
471 self.assertEqual(parsed.hostname, hostname)
472 self.assertEqual(parsed.codereview, codereview)
473
474 def _run_and_validate(self, func, url, *args, **kwargs):
475 result = func(urlparse.urlparse(url))
476 if kwargs.pop('fail', False):
477 self.assertIsNone(result)
478 return None
479 self._validate(result, *args, fail=False, **kwargs)
480
481 def test_rietveld(self):
482 def test(url, *args, **kwargs):
483 self._run_and_validate(git_cl._RietveldChangelistImpl.ParseIssueURL, url,
484 *args, codereview='rietveld', **kwargs)
485
486 test('http://codereview.chromium.org/123',
487 123, None, 'codereview.chromium.org')
488 test('https://codereview.chromium.org/123',
489 123, None, 'codereview.chromium.org')
490 test('https://codereview.chromium.org/123/',
491 123, None, 'codereview.chromium.org')
492 test('https://codereview.chromium.org/123/whatever',
493 123, None, 'codereview.chromium.org')
494 test('https://codereview.chromium.org/123/#ps20001',
495 123, 20001, 'codereview.chromium.org')
496 test('http://codereview.chromium.org/download/issue123_4.diff',
497 123, 4, 'codereview.chromium.org')
498 # This looks like bad Gerrit, but is actually valid Rietveld, too.
499 test('https://chrome-review.source.com/123/4/',
500 123, None, 'chrome-review.source.com')
501
502 test('https://codereview.chromium.org/deadbeaf', fail=True)
503 test('https://codereview.chromium.org/api/123', fail=True)
504 test('bad://codereview.chromium.org/123', fail=True)
505 test('http://codereview.chromium.org/download/issue123_4.diffff', fail=True)
506
507 def test_gerrit(self):
508 def test(url, issue=None, patchset=None, hostname=None, fail=None):
509 self._test_ParseIssueUrl(
510 git_cl._GerritChangelistImpl.ParseIssueURL,
511 url, issue, patchset, hostname, fail)
512 def test(url, *args, **kwargs):
513 self._run_and_validate(git_cl._GerritChangelistImpl.ParseIssueURL, url,
514 *args, codereview='gerrit', **kwargs)
515
516 test('http://chrome-review.source.com/c/123',
517 123, None, 'chrome-review.source.com')
518 test('https://chrome-review.source.com/c/123/',
519 123, None, 'chrome-review.source.com')
520 test('https://chrome-review.source.com/c/123/4',
521 123, 4, 'chrome-review.source.com')
522 test('https://chrome-review.source.com/#/c/123/4',
523 123, 4, 'chrome-review.source.com')
524 test('https://chrome-review.source.com/c/123/4',
525 123, 4, 'chrome-review.source.com')
526 test('https://chrome-review.source.com/123',
527 123, None, 'chrome-review.source.com')
528 test('https://chrome-review.source.com/123/4',
529 123, 4, 'chrome-review.source.com')
530
531 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
532 test('https://chrome-review.source.com/c/abc/', fail=True)
533 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
534
535 def test_ParseIssueNumberArgument(self):
536 def test(arg, *args, **kwargs):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200537 codereview_hint = kwargs.pop('hint', None)
538 self._validate(git_cl.ParseIssueNumberArgument(arg, codereview_hint),
539 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200540
541 test('123', 123)
542 test('', fail=True)
543 test('abc', fail=True)
544 test('123/1', fail=True)
545 test('123a', fail=True)
546 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
547 # Rietveld.
548 test('https://codereview.source.com/www123', fail=True)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200549 # Matches both, but we take Rietveld now by default.
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200550 test('https://codereview.source.com/123',
551 123, None, 'codereview.source.com', 'rietveld')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200552 # Matches both, but we take Gerrit if specifically requested.
553 test('https://codereview.source.com/123',
554 123, None, 'codereview.source.com', 'gerrit',
555 hint='gerrit')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200556 # Gerrrit.
557 test('https://chrome-review.source.com/c/123/4',
558 123, 4, 'chrome-review.source.com', 'gerrit')
559 test('https://chrome-review.source.com/bad/123/4', fail=True)
560
561
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100562class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563 def setUp(self):
564 super(GitCookiesCheckerTest, self).setUp()
565 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100566 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100567
568 def mock_hosts_creds(self, subhost_identity_pairs):
569 def ensure_googlesource(h):
570 if not h.endswith(self.c._GOOGLESOURCE):
571 assert not h.endswith('.')
572 return h + '.' + self.c._GOOGLESOURCE
573 return h
574 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
575 for h, i in subhost_identity_pairs]
576
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200577 def test_identity_parsing(self):
578 self.assertEqual(self.c._parse_identity('ldap.google.com'),
579 ('ldap', 'google.com'))
580 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
581 ('ldap', 'example.com'))
582 # Specical case because we know there are no subdomains in chromium.org.
583 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
584 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800585 # Pathological: ".period." can be either username OR domain, more likely
586 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200587 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
588 ('note', 'period.example.com'))
589
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100590 def test_analysis_nothing(self):
591 self.c._all_hosts = []
592 self.assertFalse(self.c.has_generic_host())
593 self.assertEqual(set(), self.c.get_conflicting_hosts())
594 self.assertEqual(set(), self.c.get_duplicated_hosts())
595 self.assertEqual(set(), self.c.get_partially_configured_hosts())
596 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
597
598 def test_analysis(self):
599 self.mock_hosts_creds([
600 ('.googlesource.com', 'git-example.chromium.org'),
601
602 ('chromium', 'git-example.google.com'),
603 ('chromium-review', 'git-example.google.com'),
604 ('chrome-internal', 'git-example.chromium.org'),
605 ('chrome-internal-review', 'git-example.chromium.org'),
606 ('conflict', 'git-example.google.com'),
607 ('conflict-review', 'git-example.chromium.org'),
608 ('dup', 'git-example.google.com'),
609 ('dup', 'git-example.google.com'),
610 ('dup-review', 'git-example.google.com'),
611 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200612 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100613 ])
614 self.assertTrue(self.c.has_generic_host())
615 self.assertEqual(set(['conflict.googlesource.com']),
616 self.c.get_conflicting_hosts())
617 self.assertEqual(set(['dup.googlesource.com']),
618 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200619 self.assertEqual(set(['partial.googlesource.com',
620 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100621 self.c.get_partially_configured_hosts())
622 self.assertEqual(set(['chromium.googlesource.com',
623 'chrome-internal.googlesource.com']),
624 self.c.get_hosts_with_wrong_identities())
625
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100626 def test_report_no_problems(self):
627 self.test_analysis_nothing()
628 self.mock(sys, 'stdout', StringIO.StringIO())
629 self.assertFalse(self.c.find_and_report_problems())
630 self.assertEqual(sys.stdout.getvalue(), '')
631
632 def test_report(self):
633 self.test_analysis()
634 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200635 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
636 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100637 self.assertTrue(self.c.find_and_report_problems())
638 with open(os.path.join(os.path.dirname(__file__),
639 'git_cl_creds_check_report.txt')) as f:
640 expected = f.read()
641 def by_line(text):
642 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700643 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200644 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100645
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800646
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000647class TestGitCl(TestCase):
648 def setUp(self):
649 super(TestGitCl, self).setUp()
650 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700651 self._calls_done = []
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000652 self.mock(subprocess2, 'call', self._mocked_call)
653 self.mock(subprocess2, 'check_call', self._mocked_call)
654 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700655 self.mock(subprocess2, 'communicate',
656 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000657 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000658 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000659 self.mock(git_common, 'get_or_create_merge_base',
660 lambda *a: (
661 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000662 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000663 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100664 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
665 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700666 self.mock(git_cl, 'write_json', lambda path, contents:
667 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000668 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000669 self.mock(git_cl.rietveld, 'Rietveld', RietveldMock)
maruel@chromium.org4bac4b52012-11-27 20:33:52 +0000670 self.mock(git_cl.rietveld, 'CachingRietveld', RietveldMock)
skobes6468b902016-10-24 08:45:10 -0700671 self.mock(git_cl.checkout, 'GitCheckout', GitCheckoutMock)
672 GitCheckoutMock.reset()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000673 self.mock(git_cl.upload, 'RealMain', self.fail)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000674 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000675 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100676 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
677 lambda *args, **kwargs: self._mocked_call(
678 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700679 self.mock(git_cl.gerrit_util, 'GetChangeComments',
680 lambda *args, **kwargs: self._mocked_call(
681 'GetChangeComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100682 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700683 lambda h, i, reviewers, ccs, notify: self._mocked_call(
684 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700685 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700686 lambda h, i, msg=None, labels=None, notify=None:
687 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700688 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
689 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000690 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
691 classmethod(lambda _: False))
tandriic2405f52016-10-10 08:13:15 -0700692 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100693 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000694 # It's important to reset settings to not have inter-tests interference.
695 git_cl.settings = None
696
697 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000698 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100699 self.assertEquals([], self.calls)
700 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000701 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100702 raise
703 # Sadly, has_failed() returns True if this OR any other tests before this
704 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200705 git_cl.logging.error(
706 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100707 'There are un-consumed self.calls after this test has finished.\n'
708 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700709 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200710 'If you are already running only this test, then **first** fix the '
711 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100712 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700713 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100714 'and follow instructions above.\n' +
715 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000716 finally:
717 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000718
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000719 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000720 self.assertTrue(
721 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700722 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000723 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000724 expected_args, result = top
725
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000726 # Also logs otherwise it could get caught in a try/finally and be hard to
727 # diagnose.
728 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700729 N = 5
730 prior_calls = '\n '.join(
731 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
732 for i, c in enumerate(self._calls_done[-N:]))
733 following_calls = '\n '.join(
734 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
735 for i, c in enumerate(self.calls[:N]))
736 extended_msg = (
737 'A few prior calls:\n %s\n\n'
738 'This (expected):\n @%d: %r\n'
739 'This (actual):\n @%d: %r\n\n'
740 'A few following expected calls:\n %s' %
741 (prior_calls, len(self._calls_done), expected_args,
742 len(self._calls_done), args, following_calls))
743 git_cl.logging.error(extended_msg)
744
tandrii99a72f22016-08-17 14:33:24 -0700745 self.fail('@%d\n'
746 ' Expected: %r\n'
747 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700748 len(self._calls_done), expected_args, args))
749
750 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700751 if isinstance(result, Exception):
752 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000753 return result
754
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100755 def test_ask_for_explicit_yes_true(self):
756 self.calls = [
757 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
758 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
759 ]
760 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
761
tandrii48df5812016-10-17 03:55:37 -0700762 def test_LoadCodereviewSettingsFromFile_gerrit(self):
763 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
764 self.calls = [
765 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
766 ((['git', 'config', '--unset-all', 'rietveld.private'],), CERR1),
767 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
768 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
769 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
770 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700771 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
772 CERR1),
773 ((['git', 'config', '--unset-all', 'rietveld.project'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700774 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
775 CERR1),
776 ((['git', 'config', 'gerrit.host', 'true'],), ''),
777 ]
778 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
779
maruel@chromium.orga3353652011-11-30 14:26:57 +0000780 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000781 def _is_gerrit_calls(cls, gerrit=False):
782 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
783 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
784
785 @classmethod
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +0000786 def _upload_calls(cls, private, no_autocc):
Aaron Gable13101a62018-02-09 13:20:41 -0800787 return (cls._rietveld_git_base_calls() +
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +0000788 cls._git_upload_calls(private, no_autocc))
maruel@chromium.orga3353652011-11-30 14:26:57 +0000789
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000790 @classmethod
Aaron Gable13101a62018-02-09 13:20:41 -0800791 def _rietveld_upload_no_rev_calls(cls):
792 return (cls._rietveld_git_base_calls() + [
Andrii Shyshkalov73827d12017-04-12 15:05:11 +0200793 ((['git', 'config', 'core.editor'],), ''),
794 ])
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000795
796 @classmethod
Aaron Gable13101a62018-02-09 13:20:41 -0800797 def _rietveld_git_base_calls(cls):
798 stat_call = ((['git', 'diff', '--no-ext-diff', '--stat',
799 '-l100000', '-C50', 'fake_ancestor_sha', 'HEAD'],), '+dat')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000800
Aaron Gable13101a62018-02-09 13:20:41 -0800801 return cls._is_gerrit_calls() + [
tandrii@chromium.org87985d22016-03-24 17:33:33 +0000802 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -0700803 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
804 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000805 ((['git', 'config', 'rietveld.server'],),
806 'codereview.example.com'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000807 ((['git', 'config', 'branch.master.merge'],), 'master'),
808 ((['git', 'config', 'branch.master.remote'],), 'origin'),
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000809 ((['get_or_create_merge_base', 'master', 'master'],),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000810 'fake_ancestor_sha'),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000811 ] + cls._git_sanity_checks('fake_ancestor_sha', 'master') + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000812 ((['git', 'rev-parse', '--show-cdup'],), ''),
813 ((['git', 'rev-parse', 'HEAD'],), '12345'),
Aaron Gable7817f022017-12-12 09:43:17 -0800814 ((['git', '-c', 'core.quotePath=false', 'diff',
815 '--name-status', '--no-renames', '-r', 'fake_ancestor_sha...', '.'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000816 'M\t.gitignore\n'),
tandrii33a46ff2016-08-23 05:53:40 -0700817 ((['git', 'config', 'branch.master.rietveldpatchset'],), CERR1),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000818 ((['git', 'log', '--pretty=format:%s%n%n%b',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000819 'fake_ancestor_sha...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000820 'foo'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000821 ((['git', 'config', 'user.email'],), 'me@example.com'),
iannucci@chromium.org79540052012-10-19 23:15:26 +0000822 stat_call,
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000823 ((['git', 'log', '--pretty=format:%s\n\n%b',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000824 'fake_ancestor_sha..HEAD'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000825 'desc\n'),
Aaron Gable3a16ed12017-03-23 10:51:55 -0700826 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
maruel@chromium.orga3353652011-11-30 14:26:57 +0000827 ]
828
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000829 @classmethod
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +0000830 def _git_upload_calls(cls, private, no_autocc):
831 if private or no_autocc:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000832 cc_call = []
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000833 else:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000834 cc_call = [((['git', 'config', 'rietveld.cc'],), '')]
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +0000835
836 if private:
837 private_call = []
838 else:
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000839 private_call = [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000840 ((['git', 'config', 'rietveld.private'],), '')]
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000841
maruel@chromium.orga3353652011-11-30 14:26:57 +0000842 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000843 ((['git', 'config', 'core.editor'],), ''),
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000844 ] + cc_call + private_call + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000845 ((['git', 'config', 'branch.master.base-url'],), ''),
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800846 ((['git', 'config', 'remote.origin.url'],), ''),
sheyang@chromium.org152cf832014-06-11 21:37:49 +0000847 ((['git', 'config', 'rietveld.project'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -0700848 ((['git', 'config', 'branch.master.rietveldissue', '1'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000849 ((['git', 'config', 'branch.master.rietveldserver',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000850 'https://codereview.example.com'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000851 ((['git',
tandrii33a46ff2016-08-23 05:53:40 -0700852 'config', 'branch.master.rietveldpatchset', '2'],), ''),
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000853 ] + cls._git_post_upload_calls()
854
855 @classmethod
856 def _git_post_upload_calls(cls):
857 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000858 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
859 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
860 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000861 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000862 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000863 ]
864
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000865 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000866 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000867 fake_ancestor = 'fake_ancestor'
868 fake_cl = 'fake_cl_for_patch'
869 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000870 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000871 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000872 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000873 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000874 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000875 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000876 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000877 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700878 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000879 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000880 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000881 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000882 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000883 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000884 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000885 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000886 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000887 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000888 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000889 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000890
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000891 @staticmethod
Aaron Gable13101a62018-02-09 13:20:41 -0800892 def _cmd_line(description, args, private, cc):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000893 """Returns the upload command line passed to upload.RealMain()."""
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000894 return [
Daniel Cheng7227d212017-11-17 08:12:37 -0800895 'upload', '--assume_yes', '--server', 'https://codereview.example.com',
maruel@chromium.org71e12a92012-02-14 02:34:15 +0000896 '--message', description
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000897 ] + args + [
Daniel Cheng7227d212017-11-17 08:12:37 -0800898 '--cc',
899 ','.join(
900 ['joe@example.com', 'chromium-reviews+test-more-cc@chromium.org'] +
901 cc),
Aaron Gable13101a62018-02-09 13:20:41 -0800902 ] + (['--private'] if private else []) + ['fake_ancestor_sha', 'HEAD']
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000903
904 def _run_reviewer_test(
905 self,
906 upload_args,
907 expected_description,
908 returned_description,
909 final_description,
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000910 reviewers,
bradnelsond975b302016-10-23 12:20:23 -0700911 cc=None):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000912 """Generic reviewer test framework."""
tandrii@chromium.org28253532016-04-14 13:46:56 +0000913 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
iannucci@chromium.org79540052012-10-19 23:15:26 +0000914
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000915 private = '--private' in upload_args
bradnelsond975b302016-10-23 12:20:23 -0700916 cc = cc or []
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +0000917 no_autocc = '--no-autocc' in upload_args
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000918
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +0000919 self.calls = self._upload_calls(private, no_autocc)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000920
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000921 def RunEditor(desc, _, **kwargs):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000922 self.assertEquals(
923 '# Enter a description of the change.\n'
janx@chromium.org104b2db2013-04-18 12:58:40 +0000924 '# This will be displayed on the codereview site.\n'
alancutter@chromium.org63a4d7f2013-05-31 02:22:45 +0000925 '# The first line will also be used as the subject of the review.\n'
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +0000926 '#--------------------This line is 72 characters long'
927 '--------------------\n' +
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000928 expected_description,
929 desc)
930 return returned_description
931 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000932
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000933 def check_upload(args):
Aaron Gable13101a62018-02-09 13:20:41 -0800934 cmd_line = self._cmd_line(final_description, reviewers, private, cc)
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000935 self.assertEquals(cmd_line, args)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000936 return 1, 2
937 self.mock(git_cl.upload, 'RealMain', check_upload)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000938
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000939 git_cl.main(['upload'] + upload_args)
940
941 def test_no_reviewer(self):
942 self._run_reviewer_test(
943 [],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000944 'desc\n\nBUG=',
945 '# Blah blah comment.\ndesc\n\nBUG=',
946 'desc\n\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000947 [])
948
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000949 def test_private(self):
950 self._run_reviewer_test(
951 ['--private'],
952 'desc\n\nBUG=',
953 '# Blah blah comment.\ndesc\n\nBUG=\n',
954 'desc\n\nBUG=',
955 [])
956
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +0000957 def test_no_autocc(self):
958 self._run_reviewer_test(
959 ['--no-autocc'],
960 'desc\n\nBUG=',
961 '# Blah blah comment.\ndesc\n\nBUG=\n',
962 'desc\n\nBUG=',
963 [])
964
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000965 def test_reviewers_cmd_line(self):
966 # Reviewer is passed as-is
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000967 description = 'desc\n\nR=foo@example.com\nBUG='
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000968 self._run_reviewer_test(
969 ['-r' 'foo@example.com'],
970 description,
971 '\n%s\n' % description,
972 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000973 ['--reviewers=foo@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000974
975 def test_reviewer_tbr_overriden(self):
976 # Reviewer is overriden with TBR
977 # Also verifies the regexp work without a trailing LF
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000978 description = 'Foo Bar\n\nTBR=reviewer@example.com'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000979 self._run_reviewer_test(
980 ['-r' 'foo@example.com'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000981 'desc\n\nR=foo@example.com\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000982 description.strip('\n'),
983 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000984 ['--reviewers=reviewer@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000985
986 def test_reviewer_multiple(self):
987 # Handles multiple R= or TBR= lines.
988 description = (
bradnelsond975b302016-10-23 12:20:23 -0700989 'Foo Bar\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
990 'CC=more@example.com,people@example.com')
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000991 self._run_reviewer_test(
992 [],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000993 'desc\n\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000994 description,
995 description,
bradnelsond975b302016-10-23 12:20:23 -0700996 ['--reviewers=another@example.com,reviewer@example.com'],
997 cc=['more@example.com', 'people@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000998
maruel@chromium.orga3353652011-11-30 14:26:57 +0000999 def test_reviewer_send_mail(self):
1000 # --send-mail can be used without -r if R= is used
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001001 description = 'Foo Bar\nR=reviewer@example.com'
maruel@chromium.orga3353652011-11-30 14:26:57 +00001002 self._run_reviewer_test(
1003 ['--send-mail'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001004 'desc\n\nBUG=',
maruel@chromium.orga3353652011-11-30 14:26:57 +00001005 description.strip('\n'),
1006 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001007 ['--reviewers=reviewer@example.com', '--send_mail'])
maruel@chromium.orga3353652011-11-30 14:26:57 +00001008
1009 def test_reviewer_send_mail_no_rev(self):
1010 # Fails without a reviewer.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00001011 stdout = StringIO.StringIO()
Aaron Gable13101a62018-02-09 13:20:41 -08001012 self.calls = self._rietveld_upload_no_rev_calls() + [
tandriic2405f52016-10-10 08:13:15 -07001013 ((['DieWithError', 'Must specify reviewers to send email.'],),
1014 SystemExitMock())
1015 ]
1016
1017 def RunEditor(desc, _, **kwargs):
1018 return desc
1019 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
1020 self.mock(sys, 'stdout', stdout)
1021 with self.assertRaises(SystemExitMock):
maruel@chromium.orga3353652011-11-30 14:26:57 +00001022 git_cl.main(['upload', '--send-mail'])
Aaron Gablec4c40d12017-05-22 11:49:53 -07001023 self.assertEqual(
1024 '=====================================\n'
1025 'NOTICE: Rietveld is being deprecated. '
1026 'You can upload changes to Gerrit with\n'
1027 ' git cl upload --gerrit\n'
1028 'or set Gerrit to be your default code review tool with\n'
1029 ' git config gerrit.host true\n'
1030 '=====================================\n',
1031 stdout.getvalue())
maruel@chromium.orga3353652011-11-30 14:26:57 +00001032
tandriif9aefb72016-07-01 09:06:51 -07001033 def test_bug_on_cmd(self):
1034 self._run_reviewer_test(
1035 ['--bug=500658,proj:123'],
1036 'desc\n\nBUG=500658\nBUG=proj:123',
1037 '# Blah blah comment.\ndesc\n\nBUG=500658\nBUG=proj:1234',
1038 'desc\n\nBUG=500658\nBUG=proj:1234',
1039 [])
1040
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001041 @classmethod
tandrii@chromium.org28253532016-04-14 13:46:56 +00001042 def _gerrit_ensure_auth_calls(cls, issue=None, skip_auth_check=False):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00001043 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +00001044 if skip_auth_check:
1045 return [((cmd, ), 'true')]
1046
tandrii5d48c322016-08-18 16:19:37 -07001047 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001048 if issue:
1049 calls.extend([
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001050 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001051 ])
1052 calls.extend([
1053 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1054 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1055 ((['git', 'config', 'remote.origin.url'],),
1056 'https://chromium.googlesource.com/my/repo'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001057 ])
1058 return calls
1059
1060 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001061 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001062 fetched_status=None, other_cl_owner=None,
1063 custom_cl_base=None):
Aaron Gable13101a62018-02-09 13:20:41 -08001064 calls = cls._is_gerrit_calls(True)
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001065 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001066 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
1067 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1068 ((['git', 'config', 'branch.master.gerritissue'],),
1069 CERR1 if issue is None else str(issue)),
1070 ]
1071
1072 if custom_cl_base:
1073 ancestor_revision = custom_cl_base
1074 else:
1075 # Determine ancestor_revision to be merge base.
1076 ancestor_revision = 'fake_ancestor_sha'
1077 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001078 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001079 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001080 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001081 'refs/remotes/origin/master'],), ancestor_revision),
1082 ]
1083
1084 # Calls to verify branch point is ancestor
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001085 calls += cls._gerrit_ensure_auth_calls(issue=issue)
1086
1087 if issue:
1088 calls += [
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001089 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001090 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +00001091 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
1092 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001093 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001094 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001095 'change_id': '123456789',
1096 'current_revision': 'sha1_of_current_revision',
1097 'revisions': { 'sha1_of_current_revision': {
1098 'commit': {'message': fetched_description},
1099 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001100 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001101 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001102 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001103 if fetched_status == 'ABANDONED':
1104 calls += [
1105 (('DieWithError', 'Change https://chromium-review.googlesource.com/'
1106 '123456 has been abandoned, new uploads are not '
1107 'allowed'), SystemExitMock()),
1108 ]
1109 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001110 if other_cl_owner:
1111 calls += [
1112 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
1113 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001114
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001115 calls += cls._git_sanity_checks(ancestor_revision, 'master',
1116 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001117 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001118 ((['git', 'rev-parse', '--show-cdup'],), ''),
1119 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001120
Aaron Gable7817f022017-12-12 09:43:17 -08001121 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
1122 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001123 'M\t.gitignore\n'),
1124 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001125 ]
1126
1127 if not issue:
1128 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001129 ((['git', 'log', '--pretty=format:%s%n%n%b',
1130 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001131 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001132 ]
1133
1134 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001135 ((['git', 'config', 'user.email'],), 'me@example.com'),
1136 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
1137 ([custom_cl_base] if custom_cl_base else
1138 [ancestor_revision, 'HEAD']),),
1139 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +01001140 ]
1141 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +00001142
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001143 @classmethod
1144 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -07001145 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001146 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001147 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001148 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001149 custom_cl_base=None, tbr=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +00001150 if post_amend_description is None:
1151 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -07001152 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001153 # Determined in `_gerrit_base_calls`.
1154 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
1155
1156 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001157
tandriia60502f2016-06-20 02:01:53 -07001158 if squash_mode == 'default':
1159 calls.extend([
1160 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
1161 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
1162 ])
1163 elif squash_mode in ('override_squash', 'override_nosquash'):
1164 calls.extend([
1165 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
1166 'true' if squash_mode == 'override_squash' else 'false'),
1167 ])
1168 else:
1169 assert squash_mode in ('squash', 'nosquash')
1170
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001171 # If issue is given, then description is fetched from Gerrit instead.
1172 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001173 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001174 ((['git', 'log', '--pretty=format:%s\n\n%b',
1175 ((custom_cl_base + '..') if custom_cl_base else
1176 'fake_ancestor_sha..HEAD')],),
1177 description),
1178 ]
Aaron Gableb56ad332017-01-06 15:24:31 -08001179 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001180 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -08001181 else:
1182 if not title:
1183 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001184 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
1185 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -08001186 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001187 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +00001188 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001189 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001190 (('DownloadGerritHook', False), ''),
1191 # Amending of commit message to get the Change-Id.
1192 ((['git', 'log', '--pretty=format:%s\n\n%b',
1193 determined_ancestor_revision + '..HEAD'],),
1194 description),
1195 ((['git', 'commit', '--amend', '-m', description],), ''),
1196 ((['git', 'log', '--pretty=format:%s\n\n%b',
1197 determined_ancestor_revision + '..HEAD'],),
1198 post_amend_description)
1199 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001200 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001201 if not issue:
1202 # Prompting to edit description on first upload.
1203 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001204 ((['git', 'config', 'core.editor'],), ''),
1205 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001206 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001207 ref_to_push = 'abcdef0123456789'
1208 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001209 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1210 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1211 ]
1212
1213 if custom_cl_base is None:
1214 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001215 ((['get_or_create_merge_base', 'master',
1216 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001217 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001218 ]
1219 parent = 'origin/master'
1220 else:
1221 calls += [
1222 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
1223 'refs/remotes/origin/master'],),
1224 callError(1)), # Means not ancenstor.
1225 (('ask_for_data',
1226 'Do you take responsibility for cleaning up potential mess '
1227 'resulting from proceeding with upload? Press Enter to upload, '
1228 'or Ctrl+C to abort'), ''),
1229 ]
1230 parent = custom_cl_base
1231
1232 calls += [
1233 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
1234 '0123456789abcdef'),
1235 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001236 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001237 ref_to_push),
1238 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001239 else:
1240 ref_to_push = 'HEAD'
1241
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001242 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001243 ((['git', 'rev-list',
1244 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1245 ref_to_push],),
1246 '1hashPerLine\n'),
1247 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001248
Aaron Gableafd52772017-06-27 16:40:10 -07001249 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001250 ref_suffix = '%ready,notify=ALL'
1251 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001252 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001253 ref_suffix = '%wip'
1254 else:
1255 ref_suffix = '%notify=NONE'
Aaron Gable9b713dd2016-12-14 16:04:21 -08001256
Aaron Gable70f4e242017-06-26 10:45:59 -07001257 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001258 ref_suffix += ',m=' + title
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001259
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001260 calls.append((
1261 (['git', 'push',
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001262 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001263 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1264 ('remote:\n'
1265 'remote: Processing changes: (\)\n'
1266 'remote: Processing changes: (|)\n'
1267 'remote: Processing changes: (/)\n'
1268 'remote: Processing changes: (-)\n'
1269 'remote: Processing changes: new: 1 (/)\n'
1270 'remote: Processing changes: new: 1, done\n'
1271 'remote:\n'
1272 'remote: New Changes:\n'
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001273 'remote: https://chromium-review.googlesource.com/#/c/my/repo/+/123456'
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001274 ' XXX\n'
1275 'remote:\n'
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001276 'To https://chromium.googlesource.com/my/repo\n'
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001277 ' * [new branch] hhhh -> refs/for/refs/heads/master\n')
1278 ))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001279 if squash:
1280 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001281 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001282 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001283 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001284 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001285 ((['git', 'config', 'branch.master.gerritsquashhash',
1286 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001287 ]
tandrii88189772016-09-29 04:29:57 -07001288 calls += [
1289 ((['git', 'config', 'rietveld.cc'],), ''),
tandrii88189772016-09-29 04:29:57 -07001290 ]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001291 if squash:
1292 calls += [
1293 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001294 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001295 sorted(reviewers),
1296 ['joe@example.com', 'chromium-reviews+test-more-cc@chromium.org'] +
1297 cc, notify), ''),
1298 ]
Aaron Gablefd238082017-06-07 13:42:34 -07001299 if tbr:
1300 calls += [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001301 (('GetChangeDetail', 'chromium-review.googlesource.com',
1302 'my%2Frepo~123456', ['LABELS']), {
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001303 'labels': {
1304 'Code-Review': {
1305 'default_value': 0,
1306 'all': [],
1307 'values': {
1308 '+2': 'lgtm, approved',
1309 '+1': 'lgtm, but someone else must approve',
1310 ' 0': 'No score',
1311 '-1': 'Don\'t submit as-is',
1312 }
1313 }
1314 }
1315 }),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001316 (('SetReview',
1317 'chromium-review.googlesource.com',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001318 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001319 'Self-approving for TBR',
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001320 {'Code-Review': 2}, None), ''),
Aaron Gablefd238082017-06-07 13:42:34 -07001321 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001322 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001323 return calls
1324
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001325 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001326 self,
1327 upload_args,
1328 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001329 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001330 squash=True,
1331 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001332 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001333 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001334 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001335 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001336 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001337 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001338 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001339 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001340 custom_cl_base=None,
1341 tbr=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001342 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001343 if squash_mode is None:
1344 if '--no-squash' in upload_args:
1345 squash_mode = 'nosquash'
1346 elif '--squash' in upload_args:
1347 squash_mode = 'squash'
1348 else:
1349 squash_mode = 'default'
1350
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001351 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001352 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001353 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001354 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001355 CookiesAuthenticatorMockFactory(
1356 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001357 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1358 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001359 self.mock(git_cl.gclient_utils, 'RunEditor',
1360 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001361 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1362 'DownloadGerritHook', force))
tandriia60502f2016-06-20 02:01:53 -07001363
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001364 self.calls = self._gerrit_base_calls(
1365 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001366 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001367 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001368 other_cl_owner=other_cl_owner,
1369 custom_cl_base=custom_cl_base)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001370 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001371 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1372 expected_content=description))
1373 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001374 self.calls += self._gerrit_upload_calls(
1375 description, reviewers, squash,
1376 squash_mode=squash_mode,
1377 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001378 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001379 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001380 issue=issue, cc=cc,
Aaron Gablefd238082017-06-07 13:42:34 -07001381 custom_cl_base=custom_cl_base, tbr=tbr)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001382 # Uncomment when debugging.
1383 # print '\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls)))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001384 git_cl.main(['upload'] + upload_args)
1385
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001386 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001387 self._run_gerrit_upload_test(
1388 ['--no-squash'],
1389 'desc\n\nBUG=\n',
1390 [],
1391 squash=False,
1392 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
1393
1394 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001395 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001396 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001397 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001398 [],
tandriia60502f2016-06-20 02:01:53 -07001399 squash=False,
1400 squash_mode='override_nosquash',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001401 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001402
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001403 def test_gerrit_no_reviewer(self):
1404 self._run_gerrit_upload_test(
1405 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001406 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001407 [],
1408 squash=False,
1409 squash_mode='override_nosquash')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001410
Nick Carter8692b182017-11-06 16:30:38 -08001411 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001412 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1413 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001414 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001415 'desc\n\nBUG=\n\nChange-Id: I123456789',
1416 squash=False,
1417 squash_mode='override_nosquash',
Nick Carter8692b182017-11-06 16:30:38 -08001418 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001419
ukai@chromium.orge8077812012-02-03 03:41:46 +00001420 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001421 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001422 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001423 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001424 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001425 squash=False,
1426 squash_mode='override_nosquash',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001427 notify=True)
ukai@chromium.orge8077812012-02-03 03:41:46 +00001428
1429 def test_gerrit_reviewer_multiple(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001430 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001431 [],
bradnelsond975b302016-10-23 12:20:23 -07001432 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1433 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001434 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001435 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001436 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001437 cc=['more@example.com', 'people@example.com'],
1438 tbr='reviewer@example.com')
tandriia60502f2016-06-20 02:01:53 -07001439
1440 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001441 self._run_gerrit_upload_test(
1442 [],
1443 'desc\nBUG=\n\nChange-Id: 123456789',
1444 [],
1445 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001446
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001447 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001448 self._run_gerrit_upload_test(
1449 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001450 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001451 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001452 squash=True,
1453 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001454
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001455 def test_gerrit_upload_squash_first_against_rev(self):
1456 custom_cl_base = 'custom_cl_base_rev_or_branch'
1457 self._run_gerrit_upload_test(
1458 ['--squash', custom_cl_base],
1459 'desc\nBUG=\n\nChange-Id: 123456789',
1460 [],
1461 squash=True,
1462 expected_upstream_ref='origin/master',
1463 custom_cl_base=custom_cl_base)
1464 self.assertIn(
1465 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1466 sys.stdout.getvalue())
1467
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001468 def test_gerrit_upload_squash_reupload(self):
1469 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001470 self._run_gerrit_upload_test(
1471 ['--squash'],
1472 description,
1473 [],
1474 squash=True,
1475 expected_upstream_ref='origin/master',
1476 issue=123456)
1477
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001478 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1479 self.mock(git_cl, 'DieWithError',
1480 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1481 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1482 with self.assertRaises(SystemExitMock):
1483 self._run_gerrit_upload_test(
1484 ['--squash'],
1485 description,
1486 [],
1487 squash=True,
1488 expected_upstream_ref='origin/master',
1489 issue=123456,
1490 fetched_status='ABANDONED')
1491
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001492 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1493 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1494 lambda *_, **__: {'email': 'yet-another@example.com'})
1495 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1496 self._run_gerrit_upload_test(
1497 ['--squash'],
1498 description,
1499 [],
1500 squash=True,
1501 expected_upstream_ref='origin/master',
1502 issue=123456,
1503 other_cl_owner='other@example.com')
1504 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001505 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001506 'authenticate to Gerrit as yet-another@example.com.\n'
1507 'Uploading may fail due to lack of permissions',
1508 git_cl.sys.stdout.getvalue())
1509
rmistry@google.com2dd99862015-06-22 12:22:18 +00001510 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001511 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001512 def mock_run_git(*args, **_kwargs):
1513 if args[0] == ['for-each-ref',
1514 '--format=%(refname:short) %(upstream:short)',
1515 'refs/heads']:
1516 # Create a local branch dependency tree that looks like this:
1517 # test1 -> test2 -> test3 -> test4 -> test5
1518 # -> test3.1
1519 # test6 -> test0
1520 branch_deps = [
1521 'test2 test1', # test1 -> test2
1522 'test3 test2', # test2 -> test3
1523 'test3.1 test2', # test2 -> test3.1
1524 'test4 test3', # test3 -> test4
1525 'test5 test4', # test4 -> test5
1526 'test6 test0', # test0 -> test6
1527 'test7', # test7
1528 ]
1529 return '\n'.join(branch_deps)
1530 self.mock(git_cl, 'RunGit', mock_run_git)
1531
1532 class RecordCalls:
1533 times_called = 0
1534 record_calls = RecordCalls()
1535 def mock_CMDupload(*args, **_kwargs):
1536 record_calls.times_called += 1
1537 return 0
1538 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1539
1540 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001541 (('ask_for_data', 'This command will checkout all dependent branches '
1542 'and run "git cl upload". Press Enter to continue, '
1543 'or Ctrl+C to abort'), ''),
1544 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001545
1546 class MockChangelist():
1547 def __init__(self):
1548 pass
1549 def GetBranch(self):
1550 return 'test1'
1551 def GetIssue(self):
1552 return '123'
1553 def GetPatchset(self):
1554 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001555 def IsGerrit(self):
1556 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001557
1558 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1559 # CMDupload should have been called 5 times because of 5 dependent branches.
1560 self.assertEquals(5, record_calls.times_called)
1561 self.assertEquals(0, ret)
1562
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001563 def test_gerrit_change_id(self):
1564 self.calls = [
1565 ((['git', 'write-tree'], ),
1566 'hashtree'),
1567 ((['git', 'rev-parse', 'HEAD~0'], ),
1568 'branch-parent'),
1569 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1570 'A B <a@b.org> 1456848326 +0100'),
1571 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1572 'C D <c@d.org> 1456858326 +0100'),
1573 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1574 'hashchange'),
1575 ]
1576 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1577 self.assertEqual(change_id, 'Ihashchange')
1578
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001579 def test_desecription_append_footer(self):
1580 for init_desc, footer_line, expected_desc in [
1581 # Use unique desc first lines for easy test failure identification.
1582 ('foo', 'R=one', 'foo\n\nR=one'),
1583 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1584 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1585 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1586 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1587 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1588 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1589 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1590 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1591 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1592 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1593 ]:
1594 desc = git_cl.ChangeDescription(init_desc)
1595 desc.append_footer(footer_line)
1596 self.assertEqual(desc.description, expected_desc)
1597
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001598 def test_update_reviewers(self):
1599 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001600 ('foo', [], [],
1601 'foo'),
1602 ('foo\nR=xx', [], [],
1603 'foo\nR=xx'),
1604 ('foo\nTBR=xx', [], [],
1605 'foo\nTBR=xx'),
1606 ('foo', ['a@c'], [],
1607 'foo\n\nR=a@c'),
1608 ('foo\nR=xx', ['a@c'], [],
1609 'foo\n\nR=a@c, xx'),
1610 ('foo\nTBR=xx', ['a@c'], [],
1611 'foo\n\nR=a@c\nTBR=xx'),
1612 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1613 'foo\n\nR=a@c, yy\nTBR=xx'),
1614 ('foo\nBUG=', ['a@c'], [],
1615 'foo\nBUG=\nR=a@c'),
1616 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1617 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1618 ('foo', ['a@c', 'b@c'], [],
1619 'foo\n\nR=a@c, b@c'),
1620 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1621 'foo\nBar\n\nR=c@c\nBUG='),
1622 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1623 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001624 # Same as the line before, but full of whitespaces.
1625 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001626 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001627 'foo\nBar\n\nR=c@c\n BUG =',
1628 ),
1629 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001630 ('foo BUG=allo R=joe ', ['c@c'], [],
1631 'foo BUG=allo R=joe\n\nR=c@c'),
1632 # Redundant TBRs get promoted to Rs
1633 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1634 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001635 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001636 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001637 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001638 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001639 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001640 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001641 actual.append(obj.description)
1642 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001643
Nodir Turakulov23b82142017-11-16 11:04:25 -08001644 def test_get_hash_tags(self):
1645 cases = [
1646 ('', []),
1647 ('a', []),
1648 ('[a]', ['a']),
1649 ('[aa]', ['aa']),
1650 ('[a ]', ['a']),
1651 ('[a- ]', ['a']),
1652 ('[a- b]', ['a-b']),
1653 ('[a--b]', ['a-b']),
1654 ('[a', []),
1655 ('[a]x', ['a']),
1656 ('[aa]x', ['aa']),
1657 ('[a b]', ['a-b']),
1658 ('[a b]', ['a-b']),
1659 ('[a__b]', ['a-b']),
1660 ('[a] x', ['a']),
1661 ('[a][b]', ['a', 'b']),
1662 ('[a] [b]', ['a', 'b']),
1663 ('[a][b]x', ['a', 'b']),
1664 ('[a][b] x', ['a', 'b']),
1665 ('[a]\n[b]', ['a']),
1666 ('[a\nb]', []),
1667 ('[a][', ['a']),
1668 ('Revert "[a] feature"', ['a']),
1669 ('Reland "[a] feature"', ['a']),
1670 ('Revert: [a] feature', ['a']),
1671 ('Reland: [a] feature', ['a']),
1672 ('Revert "Reland: [a] feature"', ['a']),
1673 ('Foo: feature', ['foo']),
1674 ('Foo Bar: feature', ['foo-bar']),
1675 ('Revert "Foo bar: feature"', ['foo-bar']),
1676 ('Reland "Foo bar: feature"', ['foo-bar']),
1677 ]
1678 for desc, expected in cases:
1679 change_desc = git_cl.ChangeDescription(desc)
1680 actual = change_desc.get_hash_tags()
1681 self.assertEqual(
1682 actual,
1683 expected,
1684 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1685
wittman@chromium.org455dc922015-01-26 20:15:50 +00001686 def test_get_target_ref(self):
1687 # Check remote or remote branch not present.
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001688 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001689 self.assertEqual(None, git_cl.GetTargetRef(None,
1690 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001691 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001692
wittman@chromium.org455dc922015-01-26 20:15:50 +00001693 # Check default target refs for branches.
1694 self.assertEqual('refs/heads/master',
1695 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001696 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001697 self.assertEqual('refs/heads/master',
1698 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001699 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001700 self.assertEqual('refs/heads/master',
1701 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001702 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001703 self.assertEqual('refs/branch-heads/123',
1704 git_cl.GetTargetRef('origin',
1705 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001706 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001707 self.assertEqual('refs/diff/test',
1708 git_cl.GetTargetRef('origin',
1709 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001710 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001711 self.assertEqual('refs/heads/chrome/m42',
1712 git_cl.GetTargetRef('origin',
1713 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001714 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001715
1716 # Check target refs for user-specified target branch.
1717 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1718 'refs/remotes/branch-heads/123'):
1719 self.assertEqual('refs/branch-heads/123',
1720 git_cl.GetTargetRef('origin',
1721 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001722 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001723 for branch in ('origin/master', 'remotes/origin/master',
1724 'refs/remotes/origin/master'):
1725 self.assertEqual('refs/heads/master',
1726 git_cl.GetTargetRef('origin',
1727 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001728 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001729 for branch in ('master', 'heads/master', 'refs/heads/master'):
1730 self.assertEqual('refs/heads/master',
1731 git_cl.GetTargetRef('origin',
1732 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001733 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001734
wychen@chromium.orga872e752015-04-28 23:42:18 +00001735 def test_patch_when_dirty(self):
1736 # Patch when local tree is dirty
1737 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1738 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1739
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001740 @staticmethod
1741 def _get_gerrit_codereview_server_calls(branch, value=None,
1742 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001743 detect_branch=True,
1744 detect_server=True):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001745 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1746
1747 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1748 """
1749 calls = []
1750 if detect_branch:
1751 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001752 if detect_server:
1753 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1754 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001755 if value is None:
1756 calls += [
1757 ((['git', 'config', 'branch.' + branch + '.merge'],),
1758 'refs/heads' + branch),
1759 ((['git', 'config', 'branch.' + branch + '.remote'],),
1760 'origin'),
1761 ((['git', 'config', 'remote.origin.url'],),
1762 'https://%s.googlesource.com/my/repo' % git_short_host),
1763 ]
1764 return calls
1765
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001766 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001767 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001768 detect_gerrit_server=False,
1769 actual_codereview=None,
1770 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001771 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001772 self.mock(git_cl._RietveldChangelistImpl, 'GetMostRecentPatchset',
1773 lambda x: '60001')
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001774 self.mock(git_cl._RietveldChangelistImpl, 'FetchDescription',
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001775 lambda *a, **kw: 'Description')
wychen@chromium.orga872e752015-04-28 23:42:18 +00001776 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1777
tandriidf09a462016-08-18 16:23:55 -07001778 if new_branch:
1779 self.calls = [((['git', 'new-branch', 'master'],), ''),]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001780
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001781 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001782 self.calls += [
1783 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001784 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001785 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001786
1787 if not force_codereview and not codereview_in_url:
1788 # These calls detect codereview to use.
1789 self.calls += [
1790 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
1791 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1792 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
1793 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1794 ((['git', 'config', 'gerrit.host'],), 'true'),
1795 ]
1796 if detect_gerrit_server:
1797 self.calls += self._get_gerrit_codereview_server_calls(
1798 'master', git_short_host=git_short_host,
1799 detect_branch=not new_branch and force_codereview)
1800 actual_codereview = 'gerrit'
1801
1802 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001803 self.calls += [
1804 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001805 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001806 {
1807 'current_revision': '7777777777',
1808 'revisions': {
1809 '1111111111': {
1810 '_number': 1,
1811 'fetch': {'http': {
1812 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1813 'ref': 'refs/changes/56/123456/1',
1814 }},
1815 },
1816 '7777777777': {
1817 '_number': 7,
1818 'fetch': {'http': {
1819 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1820 'ref': 'refs/changes/56/123456/7',
1821 }},
1822 },
1823 },
1824 }),
1825 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001826
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001827 def test_patch_rietveld_guess_by_url(self):
1828 self._patch_common(actual_codereview='rietveld', codereview_in_url=True)
wychen@chromium.orga872e752015-04-28 23:42:18 +00001829 self.calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001830 ((['git', 'config', 'branch.master.rietveldissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001831 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001832 ((['git', 'config', 'branch.master.rietveldserver',
1833 'https://codereview.example.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001834 ((['git', 'config', 'branch.master.rietveldpatchset', '60001'],),
tandrii5d48c322016-08-18 16:19:37 -07001835 ''),
Aaron Gabled343c632017-03-15 11:02:26 -07001836 ((['git', 'commit', '-m',
1837 'Description\n\n' +
1838 'patch from issue 123456 at patchset 60001 ' +
1839 '(http://crrev.com/123456#ps60001)'],), ''),
wychen@chromium.orga872e752015-04-28 23:42:18 +00001840 ]
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001841 self.assertEqual(git_cl.main(
1842 ['patch', 'https://codereview.example.com/123456']), 0)
1843
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001844 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001845 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001846 self.calls += [
1847 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1848 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001849 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001850 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001851 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001852 ((['git', 'config', 'branch.master.gerritserver',
1853 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001854 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001855 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1856 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1857 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001858 ]
1859 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1860
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001861 def test_patch_gerrit_new_branch(self):
1862 self._patch_common(
1863 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1864 self.calls += [
1865 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1866 'refs/changes/56/123456/7'],), ''),
1867 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1868 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1869 ''),
1870 ((['git', 'config', 'branch.master.gerritserver',
1871 'https://chromium-review.googlesource.com'],), ''),
1872 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1873 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1874 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1875 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1876 ]
1877 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1878
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001879 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001880 self._patch_common(
1881 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001882 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001883 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001884 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001885 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001886 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001887 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001888 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001889 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001890 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001891 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1892 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1893 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001894 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001895 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001896
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001897 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001898 self.calls += self._get_gerrit_codereview_server_calls(
1899 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001900 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001901 actual_codereview='gerrit', git_short_host='else',
1902 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001903 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001904 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001905 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001906 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001907 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001908 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001909 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001910 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001911 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001912 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1913 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1914 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001915 ]
1916 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001917 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001918
Aaron Gable697a91b2018-01-19 15:20:15 -08001919 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001920 self.calls += self._get_gerrit_codereview_server_calls(
1921 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001922 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001923 actual_codereview='gerrit', git_short_host='else',
1924 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001925 self.calls += [
1926 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1927 'refs/changes/56/123456/1'],), ''),
1928 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1929 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1930 ''),
1931 ((['git', 'config', 'branch.master.gerritserver',
1932 'https://else-review.googlesource.com'],), ''),
1933 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1934 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1935 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1936 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1937 ]
1938 self.assertEqual(git_cl.main(
1939 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1940 0)
1941
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001942 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001943 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001944 self.calls += [
1945 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001946 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001947 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1948 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1949 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001950 ]
1951 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001952 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001953
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001954 def test_patch_gerrit_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001955 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001956 raise git_cl.gerrit_util.GerritError(404, '')
1957 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1958
tandriic2405f52016-10-10 08:13:15 -07001959 self.calls = [
1960 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandriic2405f52016-10-10 08:13:15 -07001961 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1962 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
1963 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1964 ((['git', 'config', 'gerrit.host'],), 'true'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001965 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1966 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1967 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1968 ((['git', 'config', 'remote.origin.url'],),
1969 'https://chromium.googlesource.com/my/repo'),
1970 ((['DieWithError',
1971 'change 123456 at https://chromium-review.googlesource.com does not '
1972 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001973 ]
1974 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001975 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001976
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001977 def _checkout_calls(self):
1978 return [
1979 ((['git', 'config', '--local', '--get-regexp',
1980 'branch\\..*\\.rietveldissue'], ),
1981 ('branch.retrying.rietveldissue 1111111111\n'
1982 'branch.some-fix.rietveldissue 2222222222\n')),
1983 ((['git', 'config', '--local', '--get-regexp',
1984 'branch\\..*\\.gerritissue'], ),
1985 ('branch.ger-branch.gerritissue 123456\n'
1986 'branch.gbranch654.gerritissue 654321\n')),
1987 ]
1988
1989 def test_checkout_gerrit(self):
1990 """Tests git cl checkout <issue>."""
1991 self.calls = self._checkout_calls()
1992 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1993 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1994
1995 def test_checkout_rietveld(self):
1996 """Tests git cl checkout <issue>."""
1997 self.calls = self._checkout_calls()
1998 self.calls += [((['git', 'checkout', 'some-fix'], ), '')]
1999 self.assertEqual(0, git_cl.main(['checkout', '2222222222']))
2000
2001 def test_checkout_not_found(self):
2002 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00002003 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002004 self.calls = self._checkout_calls()
2005 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2006
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002007 def test_checkout_no_branch_issues(self):
2008 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00002009 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002010 self.calls = [
2011 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07002012 'branch\\..*\\.rietveldissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002013 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07002014 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002015 ]
2016 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2017
tandrii@chromium.org28253532016-04-14 13:46:56 +00002018 def _test_gerrit_ensure_authenticated_common(self, auth,
2019 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002020 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2021 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
2022 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11002023 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00002024 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002025 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00002026 cl.branch = 'master'
2027 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002028 cl.lookedup_issue = True
2029 return cl
2030
2031 def test_gerrit_ensure_authenticated_missing(self):
2032 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002033 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002034 })
2035 self.calls.append(
2036 ((['DieWithError',
2037 'Credentials for the following hosts are required:\n'
2038 ' chromium-review.googlesource.com\n'
2039 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002040 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002041 'https://chromium-review.googlesource.com/new-password'],), ''),)
2042 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2043
2044 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00002045 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002046 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002047 'chromium.googlesource.com':
2048 ('git-one.example.com', None, 'secret1'),
2049 'chromium-review.googlesource.com':
2050 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002051 })
2052 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002053 (('ask_for_data', 'If you know what you are doing '
2054 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002055 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2056
2057 def test_gerrit_ensure_authenticated_ok(self):
2058 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002059 'chromium.googlesource.com':
2060 ('git-same.example.com', None, 'secret'),
2061 'chromium-review.googlesource.com':
2062 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002063 })
2064 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2065
tandrii@chromium.org28253532016-04-14 13:46:56 +00002066 def test_gerrit_ensure_authenticated_skipped(self):
2067 cl = self._test_gerrit_ensure_authenticated_common(
2068 auth={}, skip_auth_check=True)
2069 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2070
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002071 def test_cmd_set_commit_rietveld(self):
tandrii4d843592016-07-27 08:22:56 -07002072 self.mock(git_cl._RietveldChangelistImpl, 'SetFlags',
2073 lambda _, v: self._mocked_call(['SetFlags', v]))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002074 self.calls = [
2075 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002076 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002077 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2078 ((['git', 'config', 'rietveld.server'],), ''),
2079 ((['git', 'config', 'rietveld.server'],), ''),
2080 ((['git', 'config', 'branch.feature.rietveldserver'],),
2081 'https://codereview.chromium.org'),
tandrii4d843592016-07-27 08:22:56 -07002082 ((['SetFlags', {'commit': '1', 'cq_dry_run': '0'}], ), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002083 ]
2084 self.assertEqual(0, git_cl.main(['set-commit']))
2085
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002086 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002087 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002088 lambda h, i, labels, notify=None:
2089 self._mocked_call(['SetReview', h, i, labels, notify]))
2090
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002091 self.calls = [
2092 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002093 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2094 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002095 ((['git', 'config', 'branch.feature.gerritserver'],),
2096 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002097 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2098 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2099 ((['git', 'config', 'remote.origin.url'],),
2100 'https://chromium.googlesource.com/infra/infra.git'),
2101 ((['SetReview', 'chromium-review.googlesource.com',
2102 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002103 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002104 ]
tandriid9e5ce52016-07-13 02:32:59 -07002105
2106 def test_cmd_set_commit_gerrit_clear(self):
2107 self._cmd_set_commit_gerrit_common(0)
2108 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2109
2110 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002111 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002112 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2113
tandriid9e5ce52016-07-13 02:32:59 -07002114 def test_cmd_set_commit_gerrit(self):
2115 self._cmd_set_commit_gerrit_common(2)
2116 self.assertEqual(0, git_cl.main(['set-commit']))
2117
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002118 def test_description_display(self):
2119 out = StringIO.StringIO()
2120 self.mock(git_cl.sys, 'stdout', out)
2121
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002122 self.mock(git_cl, 'Changelist', ChangelistMock)
2123 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002124
2125 self.assertEqual(0, git_cl.main(['description', '-d']))
2126 self.assertEqual('foo\n', out.getvalue())
2127
2128 def test_description_rietveld(self):
2129 out = StringIO.StringIO()
2130 self.mock(git_cl.sys, 'stdout', out)
martiniss6eda05f2016-06-30 10:18:35 -07002131 self.mock(git_cl.Changelist, 'GetDescription', lambda *args: 'foobar')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002132
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002133 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02002134 'description', '-d', '--rietveld', 'https://code.review.org/123123']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002135 self.assertEqual('foobar\n', out.getvalue())
2136
iannucci3c972b92016-08-17 13:24:10 -07002137 def test_StatusFieldOverrideIssueMissingArgs(self):
2138 out = StringIO.StringIO()
2139 self.mock(git_cl.sys, 'stderr', out)
2140
2141 try:
2142 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2143 except SystemExit as ex:
2144 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002145 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002146
2147 out = StringIO.StringIO()
2148 self.mock(git_cl.sys, 'stderr', out)
2149
2150 try:
2151 self.assertEqual(git_cl.main(['status', '--issue', '1', '--rietveld']), 0)
2152 except SystemExit as ex:
2153 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002154 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002155
2156 def test_StatusFieldOverrideIssue(self):
2157 out = StringIO.StringIO()
2158 self.mock(git_cl.sys, 'stdout', out)
2159
2160 def assertIssue(cl_self, *_args):
2161 self.assertEquals(cl_self.issue, 1)
2162 return 'foobar'
2163
2164 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2165 self.calls = [
2166 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2167 ((['git', 'config', 'rietveld.server'],), ''),
2168 ((['git', 'config', 'rietveld.server'],), ''),
2169 ]
iannuccie53c9352016-08-17 14:40:40 -07002170 self.assertEqual(
2171 git_cl.main(['status', '--issue', '1', '--rietveld', '--field', 'desc']),
2172 0)
iannucci3c972b92016-08-17 13:24:10 -07002173 self.assertEqual(out.getvalue(), 'foobar\n')
2174
iannuccie53c9352016-08-17 14:40:40 -07002175 def test_SetCloseOverrideIssue(self):
2176 def assertIssue(cl_self, *_args):
2177 self.assertEquals(cl_self.issue, 1)
2178 return 'foobar'
2179
2180 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2181 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
2182 self.calls = [
2183 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2184 ((['git', 'config', 'rietveld.server'],), ''),
2185 ((['git', 'config', 'rietveld.server'],), ''),
2186 ]
2187 self.assertEqual(
2188 git_cl.main(['set-close', '--issue', '1', '--rietveld']), 0)
2189
2190 def test_SetCommitOverrideIssue(self):
2191 def assertIssue(cl_self, *_args):
2192 self.assertEquals(cl_self.issue, 1)
2193 return 'foobar'
2194
2195 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2196 self.mock(git_cl.Changelist, 'SetCQState', lambda *_: None)
2197 self.calls = [
2198 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2199 ((['git', 'config', 'rietveld.server'],), ''),
2200 ((['git', 'config', 'rietveld.server'],), ''),
2201 ((['git', 'symbolic-ref', 'HEAD'],), ''),
2202 ((['git', 'config', 'rietveld.server'],), ''),
2203 ((['git', 'config', 'rietveld.server'],), ''),
2204 ]
2205 self.assertEqual(
2206 git_cl.main(['set-close', '--issue', '1', '--rietveld']), 0)
2207
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002208 def test_description_gerrit(self):
2209 out = StringIO.StringIO()
2210 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002211 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002212 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2213 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2214 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2215 ((['git', 'config', 'remote.origin.url'],),
2216 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002217 (('GetChangeDetail', 'code.review.org',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002218 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002219 {
2220 'current_revision': 'sha1',
2221 'revisions': {'sha1': {
2222 'commit': {'message': 'foobar'},
2223 }},
2224 }),
2225 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002226 self.assertEqual(0, git_cl.main([
2227 'description', 'https://code.review.org/123123', '-d', '--gerrit']))
2228 self.assertEqual('foobar\n', out.getvalue())
2229
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002230 def test_description_set_raw(self):
2231 out = StringIO.StringIO()
2232 self.mock(git_cl.sys, 'stdout', out)
2233
2234 self.mock(git_cl, 'Changelist', ChangelistMock)
2235 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2236
2237 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2238 self.assertEqual('hihi', ChangelistMock.desc)
2239
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002240 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002241 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002242
2243 def RunEditor(desc, _, **kwargs):
2244 self.assertEquals(
2245 '# Enter a description of the change.\n'
2246 '# This will be displayed on the codereview site.\n'
2247 '# The first line will also be used as the subject of the review.\n'
2248 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002249 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002250 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002251 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002252 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002253 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002254
dsansomee2d6fd92016-09-08 00:10:47 -07002255 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002256 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002257
2258 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2259 self.mock(git_cl.Changelist, 'GetDescription',
2260 lambda *args: current_desc)
2261 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2262 UpdateDescriptionRemote)
2263 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2264
2265 self.calls = [
2266 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002267 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002268 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2269 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002270 ((['git', 'config', 'core.editor'],), 'vi'),
2271 ]
2272 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2273
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002274 def test_description_set_stdin(self):
2275 out = StringIO.StringIO()
2276 self.mock(git_cl.sys, 'stdout', out)
2277
2278 self.mock(git_cl, 'Changelist', ChangelistMock)
2279 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2280
2281 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2282 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2283
kmarshall3bff56b2016-06-06 18:31:47 -07002284 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002285 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2286
kmarshall3bff56b2016-06-06 18:31:47 -07002287 self.calls = \
2288 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2289 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
tandrii33a46ff2016-08-23 05:53:40 -07002290 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
tandrii5d48c322016-08-18 16:19:37 -07002291 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2292 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
tandrii33a46ff2016-08-23 05:53:40 -07002293 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2294 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2295 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002296 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2297 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2298 ((['git', 'branch', '-D', 'foo'],), '')]
2299
kmarshall3bff56b2016-06-06 18:31:47 -07002300 self.mock(git_cl, 'get_cl_statuses',
2301 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002302 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2303 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2304 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002305
2306 self.assertEqual(0, git_cl.main(['archive', '-f']))
2307
2308 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002309 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002310 self.calls = \
2311 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2312 'refs/heads/master'),
tandrii33a46ff2016-08-23 05:53:40 -07002313 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
tandrii5d48c322016-08-18 16:19:37 -07002314 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2315 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
kmarshall3bff56b2016-06-06 18:31:47 -07002316 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2317
kmarshall9249e012016-08-23 12:02:16 -07002318 self.mock(git_cl, 'get_cl_statuses',
2319 lambda branches, fine_grained, max_processes:
2320 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2321
2322 self.assertEqual(1, git_cl.main(['archive', '-f']))
2323
2324 def test_archive_dry_run(self):
2325 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2326
2327 self.calls = \
2328 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2329 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2330 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
2331 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2332 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2333 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2334 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2335 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2336 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002337
2338 self.mock(git_cl, 'get_cl_statuses',
2339 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002340 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2341 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2342 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002343
kmarshall9249e012016-08-23 12:02:16 -07002344 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2345
2346 def test_archive_no_tags(self):
2347 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2348
2349 self.calls = \
2350 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2351 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2352 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
2353 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2354 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2355 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2356 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2357 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2358 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2359 ((['git', 'branch', '-D', 'foo'],), '')]
2360
2361 self.mock(git_cl, 'get_cl_statuses',
2362 lambda branches, fine_grained, max_processes:
2363 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2364 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2365 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2366
2367 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002368
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002369 def test_cmd_issue_erase_existing(self):
2370 out = StringIO.StringIO()
2371 self.mock(git_cl.sys, 'stdout', out)
2372 self.calls = [
2373 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002374 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2375 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002376 # Let this command raise exception (retcode=1) - it should be ignored.
2377 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002378 CERR1),
2379 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2380 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002381 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2382 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2383 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002384 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002385 ]
2386 self.assertEqual(0, git_cl.main(['issue', '0']))
2387
Aaron Gable400e9892017-07-12 15:31:21 -07002388 def test_cmd_issue_erase_existing_with_change_id(self):
2389 out = StringIO.StringIO()
2390 self.mock(git_cl.sys, 'stdout', out)
2391 self.mock(git_cl.Changelist, 'GetDescription',
2392 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2393 self.calls = [
2394 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2395 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2396 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
Aaron Gable400e9892017-07-12 15:31:21 -07002397 # Let this command raise exception (retcode=1) - it should be ignored.
2398 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2399 CERR1),
2400 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2401 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2402 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2403 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2404 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002405 ((['git', 'log', '-1', '--format=%B'],),
2406 'This is a description\n\nChange-Id: Ideadbeef'),
2407 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002408 ]
2409 self.assertEqual(0, git_cl.main(['issue', '0']))
2410
phajdan.jre328cf92016-08-22 04:12:17 -07002411 def test_cmd_issue_json(self):
2412 out = StringIO.StringIO()
2413 self.mock(git_cl.sys, 'stdout', out)
2414 self.calls = [
2415 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002416 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
phajdan.jre328cf92016-08-22 04:12:17 -07002417 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2418 ((['git', 'config', 'rietveld.server'],),
2419 'https://codereview.chromium.org'),
2420 ((['git', 'config', 'branch.feature.rietveldserver'],), ''),
2421 (('write_json', 'output.json',
2422 {'issue': 123, 'issue_url': 'https://codereview.chromium.org/123'}),
2423 ''),
2424 ]
2425 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2426
tandriide281ae2016-10-12 06:02:30 -07002427 def test_git_cl_try_default_cq_dry_run(self):
tandrii9de9ec62016-07-13 03:01:59 -07002428 self.mock(git_cl.Changelist, 'GetChange',
2429 lambda _, *a: (
2430 self._mocked_call(['GetChange']+list(a))))
2431 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2432 lambda *_, **__: (
2433 self._mocked_call(['DoGetTryMasters'])))
tandrii9de9ec62016-07-13 03:01:59 -07002434 self.mock(git_cl._RietveldChangelistImpl, 'SetCQState',
2435 lambda _, s: self._mocked_call(['SetCQState', s]))
2436 self.calls = [
2437 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002438 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
tandrii9de9ec62016-07-13 03:01:59 -07002439 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2440 ((['git', 'config', 'rietveld.server'],),
2441 'https://codereview.chromium.org'),
2442 ((['git', 'config', 'branch.feature.rietveldserver'],), ''),
2443 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2444 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2445 ((['get_or_create_merge_base', 'feature', 'feature'],),
2446 'fake_ancestor_sha'),
2447 ((['GetChange', 'fake_ancestor_sha', None], ),
2448 git_cl.presubmit_support.GitChange(
2449 '', '', '', '', '', '', '', '')),
2450 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2451 ((['DoGetTryMasters'], ), None),
tandrii9de9ec62016-07-13 03:01:59 -07002452 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2453 ]
2454 out = StringIO.StringIO()
2455 self.mock(git_cl.sys, 'stdout', out)
2456 self.assertEqual(0, git_cl.main(['try']))
2457 self.assertEqual(
2458 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002459 'Scheduling CQ dry run on: https://codereview.chromium.org/123\n')
tandrii9de9ec62016-07-13 03:01:59 -07002460
tandrii8c5a3532016-11-04 07:52:02 -07002461 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2462 self.mock(git_cl.Changelist, 'GetChange',
2463 lambda _, *a: (
2464 self._mocked_call(['GetChange']+list(a))))
2465 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2466 lambda *_, **__: (
2467 self._mocked_call(['DoGetTryMasters'])))
2468 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2469 lambda _, s: self._mocked_call(['SetCQState', s]))
2470
tandrii8c5a3532016-11-04 07:52:02 -07002471 self.calls = [
2472 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2473 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2474 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2475 ((['git', 'config', 'branch.feature.gerritserver'],),
2476 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002477 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2478 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2479 ((['git', 'config', 'remote.origin.url'],),
2480 'https://chromium.googlesource.com/depot_tools'),
2481 (('GetChangeDetail', 'chromium-review.googlesource.com',
2482 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002483 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2484 'project': 'depot_tools',
2485 'status': 'OPEN',
2486 'owner': {'email': 'owner@e.mail'},
2487 'revisions': {
2488 'deadbeaf': {
2489 '_number': 6,
2490 },
2491 'beeeeeef': {
2492 '_number': 7,
2493 'fetch': {'http': {
2494 'url': 'https://chromium.googlesource.com/depot_tools',
2495 'ref': 'refs/changes/56/123456/7'
2496 }},
2497 },
2498 },
2499 }),
tandrii8c5a3532016-11-04 07:52:02 -07002500 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2501 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2502 ((['get_or_create_merge_base', 'feature', 'feature'],),
2503 'fake_ancestor_sha'),
2504 ((['GetChange', 'fake_ancestor_sha', None], ),
2505 git_cl.presubmit_support.GitChange(
2506 '', '', '', '', '', '', '', '')),
2507 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2508 ((['DoGetTryMasters'], ), None),
2509 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2510 ]
2511 out = StringIO.StringIO()
2512 self.mock(git_cl.sys, 'stdout', out)
2513 self.assertEqual(0, git_cl.main(['try']))
2514 self.assertEqual(
2515 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002516 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002517 'https://chromium-review.googlesource.com/123456\n')
2518
2519 def test_git_cl_try_buildbucket_with_properties_rietveld(self):
2520 self.mock(git_cl._RietveldChangelistImpl, 'GetIssueProperties',
2521 lambda _: {
2522 'owner_email': 'owner@e.mail',
2523 'private': False,
2524 'closed': False,
2525 'project': 'depot_tools',
2526 'patchsets': [20001],
2527 })
tandriide281ae2016-10-12 06:02:30 -07002528 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2529 self.calls = [
2530 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2531 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
2532 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2533 ((['git', 'config', 'rietveld.server'],),
2534 'https://codereview.chromium.org'),
tandriide281ae2016-10-12 06:02:30 -07002535 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
tandrii8c5a3532016-11-04 07:52:02 -07002536 ((['git', 'config', 'branch.feature.rietveldserver'],), CERR1),
tandriide281ae2016-10-12 06:02:30 -07002537 ]
2538
2539 def _buildbucket_retry(*_, **kw):
2540 # self.maxDiff = 10000
2541 body = json.loads(kw['body'])
2542 self.assertEqual(len(body['builds']), 1)
2543 build = body['builds'][0]
2544 params = json.loads(build.pop('parameters_json'))
2545 self.assertEqual(params, {
2546 u'builder_name': u'win',
2547 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2548 u'revision': None}],
2549 u'properties': {
2550 u'category': u'git_cl_try',
2551 u'issue': 123,
2552 u'key': u'val',
2553 u'json': [{u'a': 1}, None],
2554 u'master': u'tryserver.chromium',
2555 u'patch_project': u'depot_tools',
2556 u'patch_storage': u'rietveld',
2557 u'patchset': 20001,
tandriide281ae2016-10-12 06:02:30 -07002558 u'rietveld': u'https://codereview.chromium.org',
2559 }
2560 })
2561 self.assertEqual(build, {
2562 u'bucket': u'master.tryserver.chromium',
2563 u'client_operation_id': u'uuid4',
2564 u'tags': [u'builder:win',
2565 u'buildset:patch/rietveld/codereview.chromium.org/123/20001',
borenet6c0efe62016-10-19 08:13:29 -07002566 u'user_agent:git_cl_try',
2567 u'master:tryserver.chromium'],
tandriide281ae2016-10-12 06:02:30 -07002568 })
2569
2570 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2571
2572 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2573 self.assertEqual(0, git_cl.main([
2574 'try', '-m', 'tryserver.chromium', '-b', 'win',
2575 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2576 self.assertRegexpMatches(
2577 git_cl.sys.stdout.getvalue(),
borenet6c0efe62016-10-19 08:13:29 -07002578 'Tried jobs on:\nBucket: master.tryserver.chromium')
2579
tandrii8c5a3532016-11-04 07:52:02 -07002580 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2581 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2582 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2583
tandrii8c5a3532016-11-04 07:52:02 -07002584 self.calls = [
2585 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2586 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2587 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2588 ((['git', 'config', 'branch.feature.gerritserver'],),
2589 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002590 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2591 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2592 ((['git', 'config', 'remote.origin.url'],),
2593 'https://chromium.googlesource.com/depot_tools'),
2594 (('GetChangeDetail', 'chromium-review.googlesource.com',
2595 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002596 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002597 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002598 'status': 'OPEN',
2599 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002600 'revisions': {
2601 'deadbeaf': {
2602 '_number': 6,
2603 },
2604 'beeeeeef': {
2605 '_number': 7,
2606 'fetch': {'http': {
2607 'url': 'https://chromium.googlesource.com/depot_tools',
2608 'ref': 'refs/changes/56/123456/7'
2609 }},
2610 },
2611 },
2612 }),
2613 ]
2614
2615 def _buildbucket_retry(*_, **kw):
2616 # self.maxDiff = 10000
2617 body = json.loads(kw['body'])
2618 self.assertEqual(len(body['builds']), 1)
2619 build = body['builds'][0]
2620 params = json.loads(build.pop('parameters_json'))
2621 self.assertEqual(params, {
2622 u'builder_name': u'win',
2623 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2624 u'revision': None}],
2625 u'properties': {
2626 u'category': u'git_cl_try',
2627 u'key': u'val',
2628 u'json': [{u'a': 1}, None],
2629 u'master': u'tryserver.chromium',
2630
2631 u'patch_gerrit_url':
2632 u'https://chromium-review.googlesource.com',
2633 u'patch_issue': 123456,
2634 u'patch_project': u'depot_tools',
2635 u'patch_ref': u'refs/changes/56/123456/7',
2636 u'patch_repository_url':
2637 u'https://chromium.googlesource.com/depot_tools',
2638 u'patch_set': 7,
2639 u'patch_storage': u'gerrit',
2640 }
2641 })
2642 self.assertEqual(build, {
2643 u'bucket': u'master.tryserver.chromium',
2644 u'client_operation_id': u'uuid4',
2645 u'tags': [
2646 u'builder:win',
2647 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2648 u'user_agent:git_cl_try',
2649 u'master:tryserver.chromium'],
2650 })
2651
2652 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2653
2654 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2655 self.assertEqual(0, git_cl.main([
2656 'try', '-m', 'tryserver.chromium', '-b', 'win',
2657 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2658 self.assertRegexpMatches(
2659 git_cl.sys.stdout.getvalue(),
2660 'Tried jobs on:\nBucket: master.tryserver.chromium')
2661
borenet6c0efe62016-10-19 08:13:29 -07002662 def test_git_cl_try_buildbucket_bucket_flag(self):
tandrii8c5a3532016-11-04 07:52:02 -07002663 self.mock(git_cl._RietveldChangelistImpl, 'GetIssueProperties',
2664 lambda _: {
2665 'owner_email': 'owner@e.mail',
2666 'private': False,
2667 'closed': False,
2668 'project': 'depot_tools',
2669 'patchsets': [20001],
2670 })
borenet6c0efe62016-10-19 08:13:29 -07002671 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2672 self.calls = [
2673 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2674 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
2675 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2676 ((['git', 'config', 'rietveld.server'],),
2677 'https://codereview.chromium.org'),
borenet6c0efe62016-10-19 08:13:29 -07002678 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
tandrii8c5a3532016-11-04 07:52:02 -07002679 ((['git', 'config', 'branch.feature.rietveldserver'],), CERR1),
borenet6c0efe62016-10-19 08:13:29 -07002680 ]
2681
2682 def _buildbucket_retry(*_, **kw):
borenet6c0efe62016-10-19 08:13:29 -07002683 body = json.loads(kw['body'])
2684 self.assertEqual(len(body['builds']), 1)
2685 build = body['builds'][0]
2686 params = json.loads(build.pop('parameters_json'))
2687 self.assertEqual(params, {
2688 u'builder_name': u'win',
2689 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2690 u'revision': None}],
2691 u'properties': {
2692 u'category': u'git_cl_try',
2693 u'issue': 123,
2694 u'patch_project': u'depot_tools',
2695 u'patch_storage': u'rietveld',
2696 u'patchset': 20001,
borenet6c0efe62016-10-19 08:13:29 -07002697 u'rietveld': u'https://codereview.chromium.org',
2698 }
2699 })
2700 self.assertEqual(build, {
2701 u'bucket': u'test.bucket',
2702 u'client_operation_id': u'uuid4',
2703 u'tags': [u'builder:win',
2704 u'buildset:patch/rietveld/codereview.chromium.org/123/20001',
2705 u'user_agent:git_cl_try'],
2706 })
2707
2708 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2709
2710 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2711 self.assertEqual(0, git_cl.main([
2712 'try', '-B', 'test.bucket', '-b', 'win']))
2713 self.assertRegexpMatches(
2714 git_cl.sys.stdout.getvalue(),
2715 'Tried jobs on:\nBucket: test.bucket')
tandriide281ae2016-10-12 06:02:30 -07002716
qyearsley123a4682016-10-26 09:12:17 -07002717 def test_git_cl_try_bots_on_multiple_masters(self):
2718 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 20001)
2719 self.calls = [
2720 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2721 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
2722 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2723 ((['git', 'config', 'rietveld.server'],),
tandrii8c5a3532016-11-04 07:52:02 -07002724 'https://codereview.chromium.org'),
qyearsley123a4682016-10-26 09:12:17 -07002725 ((['git', 'config', 'branch.feature.rietveldserver'],), CERR1),
2726 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
2727 ]
2728
2729 def _buildbucket_retry(*_, **kw):
2730 body = json.loads(kw['body'])
2731 self.assertEqual(len(body['builds']), 2)
2732
Nodir Turakulovb422e682018-02-20 22:51:30 -08002733 self.assertEqual(body['builds'][0]['bucket'], 'bucket1')
2734 params = json.loads(body['builds'][0]['parameters_json'])
2735 self.assertEqual(params['builder_name'], 'builder1')
qyearsley123a4682016-10-26 09:12:17 -07002736
Nodir Turakulovb422e682018-02-20 22:51:30 -08002737 self.assertEqual(body['builds'][1]['bucket'], 'bucket2')
2738 params = json.loads(body['builds'][1]['parameters_json'])
2739 self.assertEqual(params['builder_name'], 'builder2')
qyearsley123a4682016-10-26 09:12:17 -07002740
2741 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2742
2743 self.mock(git_cl.urllib2, 'urlopen', lambda _: StringIO.StringIO(
Nodir Turakulovb422e682018-02-20 22:51:30 -08002744 json.dumps({
2745 'builder1': {'bucket': 'bucket1'},
2746 'builder2': {'bucket': 'bucket2'},
2747 })))
qyearsley123a4682016-10-26 09:12:17 -07002748
2749 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2750 self.assertEqual(
2751 0, git_cl.main(['try', '-b', 'builder1', '-b', 'builder2']))
2752 self.assertEqual(
2753 git_cl.sys.stdout.getvalue(),
2754 'Tried jobs on:\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002755 'Bucket: bucket1\n'
qyearsley123a4682016-10-26 09:12:17 -07002756 ' builder1: []\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002757 'Bucket: bucket2\n'
qyearsley123a4682016-10-26 09:12:17 -07002758 ' builder2: []\n'
2759 'To see results here, run: git cl try-results\n'
2760 'To see results in browser, run: git cl web\n')
2761
tandrii16e0b4e2016-06-07 10:34:28 -07002762 def _common_GerritCommitMsgHookCheck(self):
2763 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2764 self.mock(git_cl.os.path, 'abspath',
2765 lambda path: self._mocked_call(['abspath', path]))
2766 self.mock(git_cl.os.path, 'exists',
2767 lambda path: self._mocked_call(['exists', path]))
2768 self.mock(git_cl.gclient_utils, 'FileRead',
2769 lambda path: self._mocked_call(['FileRead', path]))
2770 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2771 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2772 self.calls = [
2773 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2774 ((['abspath', '../'],), '/abs/git_repo_root'),
2775 ]
2776 return git_cl.Changelist(codereview='gerrit', issue=123)
2777
2778 def test_GerritCommitMsgHookCheck_custom_hook(self):
2779 cl = self._common_GerritCommitMsgHookCheck()
2780 self.calls += [
2781 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2782 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2783 '#!/bin/sh\necho "custom hook"')
2784 ]
2785 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2786
2787 def test_GerritCommitMsgHookCheck_not_exists(self):
2788 cl = self._common_GerritCommitMsgHookCheck()
2789 self.calls += [
2790 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2791 ]
2792 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2793
2794 def test_GerritCommitMsgHookCheck(self):
2795 cl = self._common_GerritCommitMsgHookCheck()
2796 self.calls += [
2797 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2798 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2799 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002800 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002801 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2802 ''),
2803 ]
2804 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2805
tandriic4344b52016-08-29 06:04:54 -07002806 def test_GerritCmdLand(self):
2807 self.calls += [
2808 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2809 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2810 'deadbeaf'),
2811 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2812 ((['git', 'config', 'branch.feature.gerritserver'],),
2813 'chromium-review.googlesource.com'),
2814 ]
2815 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2816 cl._codereview_impl._GetChangeDetail = lambda _: {
2817 'labels': {},
2818 'current_revision': 'deadbeaf',
2819 }
agable32978d92016-11-01 12:55:02 -07002820 cl._codereview_impl._GetChangeCommit = lambda: {
2821 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002822 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002823 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2824 }
tandriic4344b52016-08-29 06:04:54 -07002825 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002826 out = StringIO.StringIO()
2827 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002828 self.assertEqual(0, cl.CMDLand(force=True,
2829 bypass_hooks=True,
2830 verbose=True,
2831 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002832 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002833 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002834
tandrii221ab252016-10-06 08:12:04 -07002835 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002836 '9000': {
2837 'id': '9000',
2838 'bucket': 'master.x.y',
2839 'created_by': 'user:someone@chromium.org',
2840 'created_ts': '147200002222000',
2841 'experimental': False,
2842 'parameters_json': json.dumps({
2843 'builder_name': 'my-bot',
2844 'properties': {'category': 'cq'},
2845 }),
2846 'status': 'STARTED',
2847 'tags': [
2848 'build_address:x.y/my-bot/2',
2849 'builder:my-bot',
2850 'experimental:false',
2851 'user_agent:cq',
2852 ],
2853 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2854 },
2855 '8000': {
2856 'id': '8000',
2857 'bucket': 'master.x.y',
2858 'created_by': 'user:someone@chromium.org',
2859 'created_ts': '147200001111000',
2860 'experimental': False,
2861 'failure_reason': 'BUILD_FAILURE',
2862 'parameters_json': json.dumps({
2863 'builder_name': 'my-bot',
2864 'properties': {'category': 'cq'},
2865 }),
2866 'result_details_json': json.dumps({
2867 'properties': {'buildnumber': 1},
2868 }),
2869 'result': 'FAILURE',
2870 'status': 'COMPLETED',
2871 'tags': [
2872 'build_address:x.y/my-bot/1',
2873 'builder:my-bot',
2874 'experimental:false',
2875 'user_agent:cq',
2876 ],
2877 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2878 },
2879 }
tandrii221ab252016-10-06 08:12:04 -07002880
2881 def test_write_try_results_json(self):
2882 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002883 {
2884 'bucket': 'master.x.y',
2885 'buildbucket_id': '8000',
2886 'builder_name': 'my-bot',
2887 'created_ts': '147200001111000',
2888 'experimental': False,
2889 'failure_reason': 'BUILD_FAILURE',
2890 'result': 'FAILURE',
2891 'status': 'COMPLETED',
2892 'tags': [
2893 'build_address:x.y/my-bot/1',
2894 'builder:my-bot',
2895 'experimental:false',
2896 'user_agent:cq',
2897 ],
2898 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2899 },
2900 {
2901 'bucket': 'master.x.y',
2902 'buildbucket_id': '9000',
2903 'builder_name': 'my-bot',
2904 'created_ts': '147200002222000',
2905 'experimental': False,
2906 'failure_reason': None,
2907 'result': None,
2908 'status': 'STARTED',
2909 'tags': [
2910 'build_address:x.y/my-bot/2',
2911 'builder:my-bot',
2912 'experimental:false',
2913 'user_agent:cq',
2914 ],
2915 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2916 },
tandrii221ab252016-10-06 08:12:04 -07002917 ]
2918 self.calls = [(('write_json', 'output.json', expected_output), '')]
2919 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2920
tandrii45b2a582016-10-11 03:14:16 -07002921 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002922 out = StringIO.StringIO()
2923 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002924 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2925 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002926 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2927 self._mocked_call(['get_authenticator_for_host', host]))
2928 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2929 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002930
2931 def _setup_fetch_try_jobs_rietveld(self, *request_results):
2932 self._setup_fetch_try_jobs(most_recent_patchset=20001)
tandrii221ab252016-10-06 08:12:04 -07002933 self.calls += [
2934 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2935 ((['git', 'config', 'branch.feature.rietveldissue'],), '1'),
2936 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2937 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2938 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
2939 ((['git', 'config', 'branch.feature.rietveldserver'],),
2940 'codereview.example.com'),
2941 ((['get_authenticator_for_host', 'codereview.example.com'],),
2942 AuthenticatorMock()),
2943 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2944
2945 def test_fetch_try_jobs_none_rietveld(self):
2946 self._setup_fetch_try_jobs_rietveld({})
tandrii45b2a582016-10-11 03:14:16 -07002947 # Simulate that user isn't logged in.
2948 self.mock(AuthenticatorMock, 'has_cached_credentials', lambda _: False)
tandrii221ab252016-10-06 08:12:04 -07002949 self.assertEqual(0, git_cl.main(['try-results']))
tandrii45b2a582016-10-11 03:14:16 -07002950 self.assertRegexpMatches(sys.stdout.getvalue(),
2951 'Warning: Some results might be missing')
tandrii221ab252016-10-06 08:12:04 -07002952 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2953
2954 def test_fetch_try_jobs_some_rietveld(self):
2955 self._setup_fetch_try_jobs_rietveld({
2956 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2957 })
2958 self.assertEqual(0, git_cl.main(['try-results']))
tandrii45b2a582016-10-11 03:14:16 -07002959 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
2960 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2961 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2962
2963 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2964 self._setup_fetch_try_jobs(most_recent_patchset=13)
2965 self.calls += [
2966 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2967 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2968 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002969 # TODO(tandrii): Uncomment the below if we decide to support checking
2970 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002971 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002972 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002973 ((['git', 'config', 'branch.feature.gerritserver'],),
2974 'https://x-review.googlesource.com'),
2975 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2976 AuthenticatorMock()),
2977 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2978
2979 def test_fetch_try_jobs_none_gerrit(self):
2980 self._setup_fetch_try_jobs_gerrit({})
2981 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002982 # TODO(tandrii): Uncomment the below if we decide to support checking
2983 # patchsets for Gerrit.
2984 # self.assertRegexpMatches(
2985 # sys.stdout.getvalue(),
2986 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07002987 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2988
2989 def test_fetch_try_jobs_some_gerrit(self):
2990 self._setup_fetch_try_jobs_gerrit({
2991 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2992 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002993 # TODO(tandrii): Uncomment the below if we decide to support checking
2994 # patchsets for Gerrit.
2995 # self.calls.remove(
2996 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002997 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2998
2999 # ... and doesn't result in warning.
3000 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
3001 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07003002 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
3003 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
3004
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003005 def _mock_gerrit_changes_for_detail_cache(self):
3006 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003007
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003008 def test_gerrit_change_detail_cache_simple(self):
3009 self._mock_gerrit_changes_for_detail_cache()
3010 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003011 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
3012 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
3013 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003014 ]
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00003015 cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003016 cl1._cached_remote_url = (
3017 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00003018 cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003019 cl2._cached_remote_url = (
3020 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00003021 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
3022 self.assertEqual(cl1._GetChangeDetail(), 'a')
3023 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
3024 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
3025 self.assertEqual(cl1._GetChangeDetail(), 'a')
3026 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003027
3028 def test_gerrit_change_detail_cache_options(self):
3029 self._mock_gerrit_changes_for_detail_cache()
3030 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003031 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
3032 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
3033 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
3034 # no longer in cache.
3035 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003036 ]
3037 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003038 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01003039 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
3040 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
3041 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
3042 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
3043 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
3044 self.assertEqual(cl._GetChangeDetail(), 'cab')
3045
3046 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
3047 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
3048 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
3049 self.assertEqual(cl._GetChangeDetail(), 'cab')
3050
3051 # Finally, no_cache should invalidate all caches for given change.
3052 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
3053 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
3054
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01003055 def test_gerrit_description_caching(self):
3056 def gen_detail(rev, desc):
3057 return {
3058 'current_revision': rev,
3059 'revisions': {rev: {'commit': {'message': desc}}}
3060 }
3061 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003062 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01003063 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
3064 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003065 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01003066 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
3067 gen_detail('rev2', 'desc2')),
3068 ]
3069
3070 self._mock_gerrit_changes_for_detail_cache()
3071 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003072 cl._cached_remote_url = (
3073 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01003074 self.assertEqual(cl.GetDescription(), 'desc1')
3075 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
3076 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00003077
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003078 def test_print_current_creds(self):
3079 class CookiesAuthenticatorMock(object):
3080 def __init__(self):
3081 self.gitcookies = {
3082 'host.googlesource.com': ('user', 'pass'),
3083 'host-review.googlesource.com': ('user', 'pass'),
3084 }
3085 self.netrc = self
3086 self.netrc.hosts = {
3087 'github.com': ('user2', None, 'pass2'),
3088 'host2.googlesource.com': ('user3', None, 'pass'),
3089 }
3090 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
3091 CookiesAuthenticatorMock)
3092 self.mock(sys, 'stdout', StringIO.StringIO())
3093 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
3094 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
3095 ' Host\t User\t Which file',
3096 '============================\t=====\t===========',
3097 'host-review.googlesource.com\t user\t.gitcookies',
3098 ' host.googlesource.com\t user\t.gitcookies',
3099 ' host2.googlesource.com\tuser3\t .netrc',
3100 ])
3101 sys.stdout.buf = ''
3102 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
3103 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
3104 ' Host\tUser\t Which file',
3105 '============================\t====\t===========',
3106 'host-review.googlesource.com\tuser\t.gitcookies',
3107 ' host.googlesource.com\tuser\t.gitcookies',
3108 ])
3109
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003110 def _common_creds_check_mocks(self):
3111 def exists_mock(path):
3112 dirname = os.path.dirname(path)
3113 if dirname == os.path.expanduser('~'):
3114 dirname = '~'
3115 base = os.path.basename(path)
3116 if base in ('.netrc', '.gitcookies'):
3117 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
3118 # git cl also checks for existence other files not relevant to this test.
3119 return None
3120 self.mock(os.path, 'exists', exists_mock)
3121 self.mock(sys, 'stdout', StringIO.StringIO())
3122
3123 def test_creds_check_gitcookies_not_configured(self):
3124 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003125 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003126 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003127 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08003128 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003129 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
3130 (('os.path.exists', '~/.netrc'), True),
3131 (('ask_for_data', 'Press Enter to setup .gitcookies, '
3132 'or Ctrl+C to abort'), ''),
3133 ((['git', 'config', '--global', 'http.cookiefile',
3134 os.path.expanduser('~/.gitcookies')], ), ''),
3135 ]
3136 self.assertEqual(0, git_cl.main(['creds-check']))
3137 self.assertRegexpMatches(
3138 sys.stdout.getvalue(),
3139 '^You seem to be using outdated .netrc for git credentials:')
3140 self.assertRegexpMatches(
3141 sys.stdout.getvalue(),
3142 '\nConfigured git to use .gitcookies from')
3143
3144 def test_creds_check_gitcookies_configured_custom_broken(self):
3145 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003146 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003147 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003148 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08003149 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003150 ((['git', 'config', '--global', 'http.cookiefile'],),
3151 '/custom/.gitcookies'),
3152 (('os.path.exists', '/custom/.gitcookies'), False),
3153 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
3154 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
3155 ((['git', 'config', '--global', 'http.cookiefile',
3156 os.path.expanduser('~/.gitcookies')], ), ''),
3157 ]
3158 self.assertEqual(0, git_cl.main(['creds-check']))
3159 self.assertRegexpMatches(
3160 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003161 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003162 self.assertRegexpMatches(
3163 sys.stdout.getvalue(),
3164 'However, your configured .gitcookies file is missing.')
3165
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003166 def test_git_cl_comment_add_rietveld(self):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01003167 self.mock(git_cl._RietveldChangelistImpl, 'AddComment',
Aaron Gable636b13f2017-07-14 10:42:48 -07003168 lambda _, message, publish: self._mocked_call(
3169 'AddComment', message, publish))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01003170 self.calls = [
3171 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
3172 ((['git', 'config', 'rietveld.server'],), 'codereview.chromium.org'),
Aaron Gable636b13f2017-07-14 10:42:48 -07003173 (('AddComment', 'msg', None), ''),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01003174 ]
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003175 self.assertEqual(0, git_cl.main(['comment', '--rietveld',
3176 '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01003177
3178 def test_git_cl_comment_add_gerrit(self):
3179 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07003180 lambda host, change, msg, ready:
3181 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01003182 self.calls = [
3183 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
3184 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
3185 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3186 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3187 'origin/master'),
3188 ((['git', 'config', 'remote.origin.url'],),
3189 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00003190 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
3191 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07003192 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01003193 ]
3194 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
3195 '-a', 'msg']))
3196
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003197 def test_git_cl_comments_fetch_rietveld(self):
3198 self.mock(sys, 'stdout', StringIO.StringIO())
3199 self.calls = [
3200 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
3201 ((['git', 'config', 'rietveld.server'],), 'codereview.chromium.org'),
Leszek Swirski45b20c42018-09-17 17:05:26 +00003202 ] * 2 + [
3203 (('write_json', 'output.json', [
3204 {
3205 'date': '2000-03-13 20:49:34.515270',
3206 'message': 'PTAL',
3207 'approval': False,
3208 'disapproval': False,
3209 'sender': 'owner@example.com'
3210 }, {
3211 'date': '2017-03-13 20:49:34.515270',
3212 'message': 'lgtm',
3213 'approval': True,
3214 'disapproval': False,
3215 'sender': 'r@example.com'
3216 }, {
3217 'date': '2017-03-13 21:50:34.515270',
3218 'message': 'not lgtm',
3219 'approval': False,
3220 'disapproval': True,
3221 'sender': 'r2@example.com'
3222 }
3223 ]),'')
3224 ]
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003225 self.mock(git_cl._RietveldChangelistImpl, 'GetIssueProperties', lambda _: {
3226 'messages': [
3227 {'text': 'lgtm', 'date': '2017-03-13 20:49:34.515270',
3228 'disapproval': False, 'approval': True, 'sender': 'r@example.com'},
3229 {'text': 'not lgtm', 'date': '2017-03-13 21:50:34.515270',
3230 'disapproval': True, 'approval': False, 'sender': 'r2@example.com'},
3231 # Intentionally wrong order here.
3232 {'text': 'PTAL', 'date': '2000-03-13 20:49:34.515270',
3233 'disapproval': False, 'approval': False,
3234 'sender': 'owner@example.com'},
3235 ],
3236 'owner_email': 'owner@example.com',
3237 })
3238 expected_comments_summary = [
3239 git_cl._CommentSummary(
3240 message='lgtm',
3241 date=datetime.datetime(2017, 3, 13, 20, 49, 34, 515270),
3242 disapproval=False, approval=True, sender='r@example.com'),
3243 git_cl._CommentSummary(
3244 message='not lgtm',
3245 date=datetime.datetime(2017, 3, 13, 21, 50, 34, 515270),
3246 disapproval=True, approval=False, sender='r2@example.com'),
3247 # Note: same order as in whatever Rietveld returns.
3248 git_cl._CommentSummary(
3249 message='PTAL',
3250 date=datetime.datetime(2000, 3, 13, 20, 49, 34, 515270),
3251 disapproval=False, approval=False, sender='owner@example.com'),
3252 ]
3253 cl = git_cl.Changelist(codereview='rietveld', issue=1)
3254 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Leszek Swirski45b20c42018-09-17 17:05:26 +00003255 self.assertEqual(0, git_cl.main(['comment', '--rietveld', '-i', '10',
3256 '-j', 'output.json']))
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003257
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003258 def test_git_cl_comments_fetch_gerrit(self):
3259 self.mock(sys, 'stdout', StringIO.StringIO())
3260 self.calls = [
3261 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
3262 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
3263 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3264 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3265 'origin/master'),
3266 ((['git', 'config', 'remote.origin.url'],),
3267 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00003268 (('GetChangeDetail', 'chromium-review.googlesource.com',
3269 'infra%2Finfra~1',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003270 ['MESSAGES', 'DETAILED_ACCOUNTS']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003271 'owner': {'email': 'owner@example.com'},
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003272 'messages': [
3273 {
3274 u'_revision_number': 1,
3275 u'author': {
3276 u'_account_id': 1111084,
3277 u'email': u'commit-bot@chromium.org',
3278 u'name': u'Commit Bot'
3279 },
3280 u'date': u'2017-03-15 20:08:45.000000000',
3281 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07003282 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003283 u'tag': u'autogenerated:cq:dry-run'
3284 },
3285 {
3286 u'_revision_number': 2,
3287 u'author': {
3288 u'_account_id': 11151243,
3289 u'email': u'owner@example.com',
3290 u'name': u'owner'
3291 },
3292 u'date': u'2017-03-16 20:00:41.000000000',
3293 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3294 u'message': u'PTAL',
3295 },
3296 {
3297 u'_revision_number': 2,
3298 u'author': {
3299 u'_account_id': 148512 ,
3300 u'email': u'reviewer@example.com',
3301 u'name': u'reviewer'
3302 },
3303 u'date': u'2017-03-17 05:19:37.500000000',
3304 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
3305 u'message': u'Patch Set 2: Code-Review+1',
3306 },
3307 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003308 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00003309 (('GetChangeComments', 'chromium-review.googlesource.com',
3310 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003311 '/COMMIT_MSG': [
3312 {
3313 'author': {'email': u'reviewer@example.com'},
3314 'updated': u'2017-03-17 05:19:37.500000000',
3315 'patch_set': 2,
3316 'side': 'REVISION',
3317 'message': 'Please include a bug link',
3318 },
3319 ],
3320 'codereview.settings': [
3321 {
3322 'author': {'email': u'owner@example.com'},
3323 'updated': u'2017-03-16 20:00:41.000000000',
3324 'patch_set': 2,
3325 'side': 'PARENT',
3326 'line': 42,
3327 'message': 'I removed this because it is bad',
3328 },
3329 ]
Leszek Swirski45b20c42018-09-17 17:05:26 +00003330 })
3331 ] * 2 + [
3332 (('write_json', 'output.json', [
3333 {
3334 u'date': u'2017-03-16 20:00:41.000000',
3335 u'message': (
3336 u'PTAL\n' +
3337 u'\n' +
3338 u'codereview.settings\n' +
3339 u' Base, Line 42: https://chromium-review.googlesource.com/' +
3340 u'c/1/2/codereview.settings#b42\n' +
3341 u' I removed this because it is bad\n'),
3342 u'approval': False,
3343 u'disapproval': False,
3344 u'sender': u'owner@example.com'
3345 }, {
3346 u'date': u'2017-03-17 05:19:37.500000',
3347 u'message': (
3348 u'Patch Set 2: Code-Review+1\n' +
3349 u'\n' +
3350 u'/COMMIT_MSG\n' +
3351 u' PS2, File comment: https://chromium-review.googlesource' +
3352 u'.com/c/1/2//COMMIT_MSG#\n' +
3353 u' Please include a bug link\n'),
3354 u'approval': False,
3355 u'disapproval': False,
3356 u'sender': u'reviewer@example.com'
3357 }
3358 ]),'')
3359 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003360 expected_comments_summary = [
3361 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003362 message=(
3363 u'PTAL\n' +
3364 u'\n' +
3365 u'codereview.settings\n' +
3366 u' Base, Line 42: https://chromium-review.googlesource.com/' +
3367 u'c/1/2/codereview.settings#b42\n' +
3368 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003369 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
3370 disapproval=False, approval=False, sender=u'owner@example.com'),
3371 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003372 message=(
3373 u'Patch Set 2: Code-Review+1\n' +
3374 u'\n' +
3375 u'/COMMIT_MSG\n' +
3376 u' PS2, File comment: https://chromium-review.googlesource.com/' +
3377 u'c/1/2//COMMIT_MSG#\n' +
3378 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003379 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
3380 disapproval=False, approval=False, sender=u'reviewer@example.com'),
3381 ]
3382 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3383 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Leszek Swirski45b20c42018-09-17 17:05:26 +00003384 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '1',
3385 '-j', 'output.json']))
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003386
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003387 def test_get_remote_url_with_mirror(self):
3388 original_os_path_isdir = os.path.isdir
3389 def selective_os_path_isdir_mock(path):
3390 if path == '/cache/this-dir-exists':
3391 return self._mocked_call('os.path.isdir', path)
3392 return original_os_path_isdir(path)
3393 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3394
3395 url = 'https://chromium.googlesource.com/my/repo'
3396 self.calls = [
3397 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3398 ((['git', 'config', 'branch.master.merge'],), 'master'),
3399 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3400 ((['git', 'config', 'remote.origin.url'],),
3401 '/cache/this-dir-exists'),
3402 (('os.path.isdir', '/cache/this-dir-exists'),
3403 True),
3404 # Runs in /cache/this-dir-exists.
3405 ((['git', 'config', 'remote.origin.url'],),
3406 url),
3407 ]
3408 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3409 self.assertEqual(cl.GetRemoteUrl(), url)
3410 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3411
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003412 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003413 self.calls = [
3414 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3415 ((['git', 'config', 'branch.master.merge'],), 'master'),
3416 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3417 ((['git', 'config', 'remote.origin.url'],),
3418 'https://chromium.googlesource.com/a/my/repo.git/'),
3419 ]
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003420 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3421 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3422
3423 def test_gerrit_change_identifier_without_project(self):
3424 self.calls = [
3425 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3426 ((['git', 'config', 'branch.master.merge'],), 'master'),
3427 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3428 ((['git', 'config', 'remote.origin.url'],), CERR1),
3429 ]
3430 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3431 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003432
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003433
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003434if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003435 logging.basicConfig(
3436 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003437 unittest.main()