commit b7214602e3f1c8be21f7ab8541725593f05777a1
author Andrii Shyshkalov <tandrii@chromium.org> Wed Aug 22 23:20:26 2018 +0000
committer Commit Bot <commit-bot@chromium.org> Wed Aug 22 23:20:26 2018 +0000
tree f5db4f8f3810fed065951d344ec1c1ae7975b7bf
parent 29361ca11fa37bfe9961af093edaf60c37d2db96

git cl: remove unused issue kwarg.

R=ehmaldonado

Change-Id: I5be27cb025f8237cef0186c90eb7b99d000076d9
Reviewed-on: https://chromium-review.googlesource.com/1185986
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

tests/git_cl_test.py

diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index 2cf4329..3bc4495 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -3114,17 +3114,6 @@
   def _mock_gerrit_changes_for_detail_cache(self):
     self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
 
-  def test_gerrit_change_detail_cache_normalize(self):
-    self._mock_gerrit_changes_for_detail_cache()
-    self.calls = [
-        (('GetChangeDetail', 'host', '2', ['CASE']), 'b'),
-    ]
-    cl = git_cl.Changelist(codereview='gerrit')
-    self.assertEqual(cl._GetChangeDetail(issue=2, options=['CaSe']), 'b')
-    self.assertEqual(cl._GetChangeDetail(issue=2, options=['CASE']), 'b')
-    self.assertEqual(cl._GetChangeDetail(issue='2'), 'b')
-    self.assertEqual(cl._GetChangeDetail(issue=2), 'b')
-
   def test_gerrit_change_detail_cache_simple(self):
     self._mock_gerrit_changes_for_detail_cache()
     self.calls = [
@@ -3132,13 +3121,14 @@
         (('GetChangeDetail', 'host', '2', []), 'b'),
         (('GetChangeDetail', 'host', '2', []), 'b2'),
     ]
-    cl = git_cl.Changelist(issue=1, codereview='gerrit')
-    self.assertEqual(cl._GetChangeDetail(), 'a')  # Miss.
-    self.assertEqual(cl._GetChangeDetail(), 'a')
-    self.assertEqual(cl._GetChangeDetail(issue=2), 'b')  # Miss.
-    self.assertEqual(cl._GetChangeDetail(issue=2, no_cache=True), 'b2')  # Miss.
-    self.assertEqual(cl._GetChangeDetail(), 'a')
-    self.assertEqual(cl._GetChangeDetail(issue=2), 'b2')
+    cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
+    cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
+    self.assertEqual(cl1._GetChangeDetail(), 'a')  # Miss.
+    self.assertEqual(cl1._GetChangeDetail(), 'a')
+    self.assertEqual(cl2._GetChangeDetail(), 'b')  # Miss.
+    self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2')  # Miss.
+    self.assertEqual(cl1._GetChangeDetail(), 'a')
+    self.assertEqual(cl2._GetChangeDetail(), 'b2')
 
   def test_gerrit_change_detail_cache_options(self):
     self._mock_gerrit_changes_for_detail_cache()