Simplify notify behavior in git-cl
Change-Id: I872658970c04cdadda2b0eaffd95e10717c09493
Reviewed-on: https://chromium-review.googlesource.com/575009
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index 17edd8f..52ee43b 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -623,8 +623,8 @@
lambda h, i, reviewers, ccs, notify: self._mocked_call(
'AddReviewers', h, i, reviewers, ccs, notify))
self.mock(git_cl.gerrit_util, 'SetReview',
- lambda h, i, labels, notify: self._mocked_call(
- 'SetReview', h, i, labels, notify))
+ lambda h, i, msg=None, labels=None, notify=None:
+ self._mocked_call('SetReview', h, i, msg, labels, notify))
self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
classmethod(lambda _: False))
self.mock(git_cl, 'DieWithError',
@@ -1605,7 +1605,8 @@
if tbr:
calls += [
(('SetReview', 'chromium-review.googlesource.com',
- 123456 if squash else None, {'Code-Review': 1}, notify), ''),
+ 123456 if squash else None, 'Self-approving for TBR',
+ {'Code-Review': 1}, None), ''),
]
calls += cls._git_post_upload_calls()
return calls