commit afd527777845559fe305399a362702f2e2d7e4ab
author Aaron Gable <agable@chromium.org> Tue Jun 27 16:40:10 2017 -0700
committer Commit Bot <commit-bot@chromium.org> Tue Jun 27 23:46:07 2017 +0000
tree 58bf7fceabfbbb00eb7a9442655acb9b8503a2a4
parent 70f4e24d1524e7556ac7328e62daf4ab42bb8d06

git-cl-upload: make it possible to exit WIP mode

The previous CL forgot that the lack of '%wip' doesn't
mark a change ready-to-review, you have to explicitly pass
'%ready' in the refspec to do that.

TBR=tandrii@chromium.org

Bug: 721836
Change-Id: Iea82222d64edf1b73fefa9bca3feec4188e35ab3
Reviewed-on: https://chromium-review.googlesource.com/551005
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

tests/git_cl_test.py

diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index d7938db..b1c5f7c 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -1519,15 +1519,12 @@
       '1hashPerLine\n'),
     ]
 
-    ref_suffix = ''
-    if not notify:
-      ref_suffix = '%wip'
+    ref_suffix = '%wip'
+    if notify:
+      ref_suffix = '%ready'
 
     if title:
-      if ref_suffix:
-        ref_suffix += ',m=' + title
-      else:
-        ref_suffix = '%m=' + title
+      ref_suffix += ',m=' + title
 
     if git_mirror is None:
       calls += [