blob: 91b68568c126adbc30851bc81495e1cf8c455083 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01009import datetime
tandriide281ae2016-10-12 06:02:30 -070010import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010011import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000012import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
22
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000023import metrics
24# We have to disable monitoring before importing git_cl.
25metrics.DISABLE_METRICS_COLLECTION = True
26
Eric Boren2fb63102018-10-05 13:05:03 +000027import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000028import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000029import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000030import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
65 desc = ""
66 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
skobes6468b902016-10-24 08:45:10 -070086class GitCheckoutMock(object):
87 def __init__(self, *args, **kwargs):
88 pass
89
90 @staticmethod
91 def reset():
92 GitCheckoutMock.conflict = False
93
94 def apply_patch(self, p):
95 if GitCheckoutMock.conflict:
96 raise Exception('failed')
97
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000098
99class WatchlistsMock(object):
100 def __init__(self, _):
101 pass
102 @staticmethod
103 def GetWatchersForPaths(_):
104 return ['joe@example.com']
105
106
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000107class CodereviewSettingsFileMock(object):
108 def __init__(self):
109 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800110 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000111 def read(self):
112 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000113 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000114
115
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000116class AuthenticatorMock(object):
117 def __init__(self, *_args):
118 pass
119 def has_cached_credentials(self):
120 return True
tandrii221ab252016-10-06 08:12:04 -0700121 def authorize(self, http):
122 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000123
124
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100125def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
127
128 Usage:
129 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100130 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000131
132 OR
133 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100134 CookiesAuthenticatorMockFactory(
135 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000136 """
137 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800138 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139 # Intentionally not calling super() because it reads actual cookie files.
140 pass
141 @classmethod
142 def get_gitcookies_path(cls):
143 return '~/.gitcookies'
144 @classmethod
145 def get_netrc_path(cls):
146 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 def _get_auth_for_host(self, host):
148 if same_auth:
149 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000150 return (hosts_with_creds or {}).get(host)
151 return CookiesAuthenticatorMock
152
Aaron Gable9a03ae02017-11-03 11:31:07 -0700153
kmarshall9249e012016-08-23 12:02:16 -0700154class MockChangelistWithBranchAndIssue():
155 def __init__(self, branch, issue):
156 self.branch = branch
157 self.issue = issue
158 def GetBranch(self):
159 return self.branch
160 def GetIssue(self):
161 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162
tandriic2405f52016-10-10 08:13:15 -0700163
164class SystemExitMock(Exception):
165 pass
166
167
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000168class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100169 def test_get_description(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000170 cl = git_cl.Changelist(issue=1, codereview='gerrit',
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100171 codereview_host='host')
172 cl.description = 'x'
173 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800174 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100175 self.assertEquals(cl.GetDescription(), 'x')
176 self.assertEquals(cl.GetDescription(force=True), 'y')
177 self.assertEquals(cl.GetDescription(), 'y')
178
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700179 def test_description_footers(self):
180 cl = git_cl.Changelist(issue=1, codereview='gerrit',
181 codereview_host='host')
182 cl.description = '\n'.join([
183 'This is some message',
184 '',
185 'It has some lines',
186 'and, also',
187 '',
188 'Some: Really',
189 'Awesome: Footers',
190 ])
191 cl.has_description = True
192 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
193 msg, footers = cl.GetDescriptionFooters()
194 self.assertEquals(
195 msg, ['This is some message', '', 'It has some lines', 'and, also'])
196 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
197
198 msg.append('wut')
199 footers.append(('gnarly-dude', 'beans'))
200 cl.UpdateDescriptionFooters(msg, footers)
201 self.assertEquals(cl.GetDescription().splitlines(), [
202 'This is some message',
203 '',
204 'It has some lines',
205 'and, also',
206 'wut'
207 '',
208 'Some: Really',
209 'Awesome: Footers',
210 'Gnarly-Dude: beans',
211 ])
212
tandriif9aefb72016-07-01 09:06:51 -0700213 def test_get_bug_line_values(self):
214 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
215 self.assertEqual(f('', ''), [])
216 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
217 self.assertEqual(f('v8', '456'), ['v8:456'])
218 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
219 # Not nice, but not worth carying.
220 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
221 ['v8:456', 'chromium:123', 'v8:123'])
222
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100223 def _test_git_number(self, parent_msg, dest_ref, child_msg,
224 parent_hash='parenthash'):
225 desc = git_cl.ChangeDescription(child_msg)
226 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
227 return desc.description
228
229 def assertEqualByLine(self, actual, expected):
230 self.assertEqual(actual.splitlines(), expected.splitlines())
231
232 def test_git_number_bad_parent(self):
233 with self.assertRaises(ValueError):
234 self._test_git_number('Parent', 'refs/heads/master', 'Child')
235
236 def test_git_number_bad_parent_footer(self):
237 with self.assertRaises(AssertionError):
238 self._test_git_number(
239 'Parent\n'
240 '\n'
241 'Cr-Commit-Position: wrong',
242 'refs/heads/master', 'Child')
243
244 def test_git_number_bad_lineage_ignored(self):
245 actual = self._test_git_number(
246 'Parent\n'
247 '\n'
248 'Cr-Commit-Position: refs/heads/master@{#1}\n'
249 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
250 'refs/heads/master', 'Child')
251 self.assertEqualByLine(
252 actual,
253 'Child\n'
254 '\n'
255 'Cr-Commit-Position: refs/heads/master@{#2}\n'
256 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
257
258 def test_git_number_same_branch(self):
259 actual = self._test_git_number(
260 'Parent\n'
261 '\n'
262 'Cr-Commit-Position: refs/heads/master@{#12}',
263 dest_ref='refs/heads/master',
264 child_msg='Child')
265 self.assertEqualByLine(
266 actual,
267 'Child\n'
268 '\n'
269 'Cr-Commit-Position: refs/heads/master@{#13}')
270
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200271 def test_git_number_same_branch_mixed_footers(self):
272 actual = self._test_git_number(
273 'Parent\n'
274 '\n'
275 'Cr-Commit-Position: refs/heads/master@{#12}',
276 dest_ref='refs/heads/master',
277 child_msg='Child\n'
278 '\n'
279 'Broken-by: design\n'
280 'BUG=123')
281 self.assertEqualByLine(
282 actual,
283 'Child\n'
284 '\n'
285 'Broken-by: design\n'
286 'BUG=123\n'
287 'Cr-Commit-Position: refs/heads/master@{#13}')
288
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100289 def test_git_number_same_branch_with_originals(self):
290 actual = self._test_git_number(
291 'Parent\n'
292 '\n'
293 'Cr-Commit-Position: refs/heads/master@{#12}',
294 dest_ref='refs/heads/master',
295 child_msg='Child\n'
296 '\n'
297 'Some users are smart and insert their own footers\n'
298 '\n'
299 'Cr-Whatever: value\n'
300 'Cr-Commit-Position: refs/copy/paste@{#22}')
301 self.assertEqualByLine(
302 actual,
303 'Child\n'
304 '\n'
305 'Some users are smart and insert their own footers\n'
306 '\n'
307 'Cr-Original-Whatever: value\n'
308 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
309 'Cr-Commit-Position: refs/heads/master@{#13}')
310
311 def test_git_number_new_branch(self):
312 actual = self._test_git_number(
313 'Parent\n'
314 '\n'
315 'Cr-Commit-Position: refs/heads/master@{#12}',
316 dest_ref='refs/heads/branch',
317 child_msg='Child')
318 self.assertEqualByLine(
319 actual,
320 'Child\n'
321 '\n'
322 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
323 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
324
325 def test_git_number_lineage(self):
326 actual = self._test_git_number(
327 'Parent\n'
328 '\n'
329 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
330 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
331 dest_ref='refs/heads/branch',
332 child_msg='Child')
333 self.assertEqualByLine(
334 actual,
335 'Child\n'
336 '\n'
337 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
338 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
339
340 def test_git_number_moooooooore_lineage(self):
341 actual = self._test_git_number(
342 'Parent\n'
343 '\n'
344 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
345 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
346 dest_ref='refs/heads/mooore',
347 child_msg='Child')
348 self.assertEqualByLine(
349 actual,
350 'Child\n'
351 '\n'
352 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
353 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
354 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
355
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100356 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700357 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100358 actual = self._test_git_number(
359 'CQ commit on fresh new branch + numbering.\n'
360 '\n'
361 'NOTRY=True\n'
362 'NOPRESUBMIT=True\n'
363 'BUG=\n'
364 '\n'
365 'Review-Url: https://codereview.chromium.org/2577703003\n'
366 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
367 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
368 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
369 dest_ref='refs/heads/gnumb-test/cl',
370 child_msg='git cl on fresh new branch + numbering.\n'
371 '\n'
372 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
373 self.assertEqualByLine(
374 actual,
375 'git cl on fresh new branch + numbering.\n'
376 '\n'
377 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
378 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
379 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
380 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
381 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100382
383 def test_git_number_cherry_pick(self):
384 actual = self._test_git_number(
385 'Parent\n'
386 '\n'
387 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
388 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
389 dest_ref='refs/heads/branch',
390 child_msg='Child, which is cherry-pick from master\n'
391 '\n'
392 'Cr-Commit-Position: refs/heads/master@{#100}\n'
393 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
394 self.assertEqualByLine(
395 actual,
396 'Child, which is cherry-pick from master\n'
397 '\n'
398 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
399 '\n'
400 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
401 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
402 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
403
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000404 def test_gerrit_mirror_hack(self):
405 cr = 'chromium-review.googlesource.com'
406 url0 = 'https://%s/a/changes/x?a=b' % cr
407 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
408 try:
409 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
410 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
411 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
412 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
413
414 self.assertNotEqual(url1, url2)
415 self.assertEqual(sorted((url1, url2)), [
416 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
417 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
418 self.assertEqual(url1, url3)
419 finally:
420 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
421
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000422 def test_valid_accounts(self):
423 mock_per_account = {
424 'u1': None, # 404, doesn't exist.
425 'u2': {
426 '_account_id': 123124,
427 'avatars': [],
428 'email': 'u2@example.com',
429 'name': 'User Number 2',
430 'status': 'OOO',
431 },
432 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
433 }
434 def GetAccountDetailsMock(_, account):
435 # Poor-man's mock library's side_effect.
436 v = mock_per_account.pop(account)
437 if isinstance(v, Exception):
438 raise v
439 return v
440
441 original = git_cl.gerrit_util.GetAccountDetails
442 try:
443 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
444 actual = git_cl.gerrit_util.ValidAccounts(
445 'host', ['u1', 'u2', 'u3'], max_threads=1)
446 finally:
447 git_cl.gerrit_util.GetAccountDetails = original
448 self.assertEqual(actual, {
449 'u2': {
450 '_account_id': 123124,
451 'avatars': [],
452 'email': 'u2@example.com',
453 'name': 'User Number 2',
454 'status': 'OOO',
455 },
456 })
457
458
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000459
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200460class TestParseIssueURL(unittest.TestCase):
461 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
462 codereview=None, fail=False):
463 self.assertIsNotNone(parsed)
464 if fail:
465 self.assertFalse(parsed.valid)
466 return
467 self.assertTrue(parsed.valid)
468 self.assertEqual(parsed.issue, issue)
469 self.assertEqual(parsed.patchset, patchset)
470 self.assertEqual(parsed.hostname, hostname)
471 self.assertEqual(parsed.codereview, codereview)
472
473 def _run_and_validate(self, func, url, *args, **kwargs):
474 result = func(urlparse.urlparse(url))
475 if kwargs.pop('fail', False):
476 self.assertIsNone(result)
477 return None
478 self._validate(result, *args, fail=False, **kwargs)
479
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480 def test_gerrit(self):
481 def test(url, issue=None, patchset=None, hostname=None, fail=None):
482 self._test_ParseIssueUrl(
483 git_cl._GerritChangelistImpl.ParseIssueURL,
484 url, issue, patchset, hostname, fail)
485 def test(url, *args, **kwargs):
486 self._run_and_validate(git_cl._GerritChangelistImpl.ParseIssueURL, url,
487 *args, codereview='gerrit', **kwargs)
488
489 test('http://chrome-review.source.com/c/123',
490 123, None, 'chrome-review.source.com')
491 test('https://chrome-review.source.com/c/123/',
492 123, None, 'chrome-review.source.com')
493 test('https://chrome-review.source.com/c/123/4',
494 123, 4, 'chrome-review.source.com')
495 test('https://chrome-review.source.com/#/c/123/4',
496 123, 4, 'chrome-review.source.com')
497 test('https://chrome-review.source.com/c/123/4',
498 123, 4, 'chrome-review.source.com')
499 test('https://chrome-review.source.com/123',
500 123, None, 'chrome-review.source.com')
501 test('https://chrome-review.source.com/123/4',
502 123, 4, 'chrome-review.source.com')
503
504 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
505 test('https://chrome-review.source.com/c/abc/', fail=True)
506 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
507
508 def test_ParseIssueNumberArgument(self):
509 def test(arg, *args, **kwargs):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200510 codereview_hint = kwargs.pop('hint', None)
511 self._validate(git_cl.ParseIssueNumberArgument(arg, codereview_hint),
512 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200513
514 test('123', 123)
515 test('', fail=True)
516 test('abc', fail=True)
517 test('123/1', fail=True)
518 test('123a', fail=True)
519 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000520
521 # Looks like Rietveld and Gerrit, but we should select Gerrit now
522 # w/ or w/o hint.
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200523 test('https://codereview.source.com/123',
524 123, None, 'codereview.source.com', 'gerrit',
525 hint='gerrit')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000526 test('https://codereview.source.com/123',
527 123, None, 'codereview.source.com', 'gerrit')
528
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200529 # Gerrrit.
530 test('https://chrome-review.source.com/c/123/4',
531 123, 4, 'chrome-review.source.com', 'gerrit')
532 test('https://chrome-review.source.com/bad/123/4', fail=True)
533
534
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100535class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100536 def setUp(self):
537 super(GitCookiesCheckerTest, self).setUp()
538 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100539 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100540
541 def mock_hosts_creds(self, subhost_identity_pairs):
542 def ensure_googlesource(h):
543 if not h.endswith(self.c._GOOGLESOURCE):
544 assert not h.endswith('.')
545 return h + '.' + self.c._GOOGLESOURCE
546 return h
547 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
548 for h, i in subhost_identity_pairs]
549
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200550 def test_identity_parsing(self):
551 self.assertEqual(self.c._parse_identity('ldap.google.com'),
552 ('ldap', 'google.com'))
553 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
554 ('ldap', 'example.com'))
555 # Specical case because we know there are no subdomains in chromium.org.
556 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
557 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800558 # Pathological: ".period." can be either username OR domain, more likely
559 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200560 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
561 ('note', 'period.example.com'))
562
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563 def test_analysis_nothing(self):
564 self.c._all_hosts = []
565 self.assertFalse(self.c.has_generic_host())
566 self.assertEqual(set(), self.c.get_conflicting_hosts())
567 self.assertEqual(set(), self.c.get_duplicated_hosts())
568 self.assertEqual(set(), self.c.get_partially_configured_hosts())
569 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
570
571 def test_analysis(self):
572 self.mock_hosts_creds([
573 ('.googlesource.com', 'git-example.chromium.org'),
574
575 ('chromium', 'git-example.google.com'),
576 ('chromium-review', 'git-example.google.com'),
577 ('chrome-internal', 'git-example.chromium.org'),
578 ('chrome-internal-review', 'git-example.chromium.org'),
579 ('conflict', 'git-example.google.com'),
580 ('conflict-review', 'git-example.chromium.org'),
581 ('dup', 'git-example.google.com'),
582 ('dup', 'git-example.google.com'),
583 ('dup-review', 'git-example.google.com'),
584 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200585 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100586 ])
587 self.assertTrue(self.c.has_generic_host())
588 self.assertEqual(set(['conflict.googlesource.com']),
589 self.c.get_conflicting_hosts())
590 self.assertEqual(set(['dup.googlesource.com']),
591 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200592 self.assertEqual(set(['partial.googlesource.com',
593 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100594 self.c.get_partially_configured_hosts())
595 self.assertEqual(set(['chromium.googlesource.com',
596 'chrome-internal.googlesource.com']),
597 self.c.get_hosts_with_wrong_identities())
598
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100599 def test_report_no_problems(self):
600 self.test_analysis_nothing()
601 self.mock(sys, 'stdout', StringIO.StringIO())
602 self.assertFalse(self.c.find_and_report_problems())
603 self.assertEqual(sys.stdout.getvalue(), '')
604
605 def test_report(self):
606 self.test_analysis()
607 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200608 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
609 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100610 self.assertTrue(self.c.find_and_report_problems())
611 with open(os.path.join(os.path.dirname(__file__),
612 'git_cl_creds_check_report.txt')) as f:
613 expected = f.read()
614 def by_line(text):
615 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700616 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200617 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100618
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800619
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000620class TestGitCl(TestCase):
621 def setUp(self):
622 super(TestGitCl, self).setUp()
623 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700624 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000625 self.mock(git_cl, 'time_time',
626 lambda: self._mocked_call('time.time'))
627 self.mock(git_cl.metrics.collector, 'add_repeated',
628 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000629 self.mock(subprocess2, 'call', self._mocked_call)
630 self.mock(subprocess2, 'check_call', self._mocked_call)
631 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700632 self.mock(subprocess2, 'communicate',
633 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000634 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000635 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000636 self.mock(git_common, 'get_or_create_merge_base',
637 lambda *a: (
638 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000639 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000640 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000641 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
642 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100643 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000644 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700645 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000646 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000647 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
skobes6468b902016-10-24 08:45:10 -0700648 self.mock(git_cl.checkout, 'GitCheckout', GitCheckoutMock)
649 GitCheckoutMock.reset()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000650 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000651 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100652 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
653 lambda *args, **kwargs: self._mocked_call(
654 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700655 self.mock(git_cl.gerrit_util, 'GetChangeComments',
656 lambda *args, **kwargs: self._mocked_call(
657 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000658 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
659 lambda *args, **kwargs: self._mocked_call(
660 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100661 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700662 lambda h, i, reviewers, ccs, notify: self._mocked_call(
663 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700664 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700665 lambda h, i, msg=None, labels=None, notify=None:
666 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700667 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
668 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000669 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
670 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000671 self.mock(git_cl.gerrit_util, 'ValidAccounts',
672 lambda host, accounts:
673 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700674 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100675 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000676 # It's important to reset settings to not have inter-tests interference.
677 git_cl.settings = None
678
679 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000680 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100681 self.assertEquals([], self.calls)
682 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000683 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100684 raise
685 # Sadly, has_failed() returns True if this OR any other tests before this
686 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200687 git_cl.logging.error(
688 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100689 'There are un-consumed self.calls after this test has finished.\n'
690 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700691 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200692 'If you are already running only this test, then **first** fix the '
693 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100694 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700695 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100696 'and follow instructions above.\n' +
697 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000698 finally:
699 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000700
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000701 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000702 self.assertTrue(
703 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700704 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000705 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000706 expected_args, result = top
707
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000708 # Also logs otherwise it could get caught in a try/finally and be hard to
709 # diagnose.
710 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700711 N = 5
712 prior_calls = '\n '.join(
713 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
714 for i, c in enumerate(self._calls_done[-N:]))
715 following_calls = '\n '.join(
716 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
717 for i, c in enumerate(self.calls[:N]))
718 extended_msg = (
719 'A few prior calls:\n %s\n\n'
720 'This (expected):\n @%d: %r\n'
721 'This (actual):\n @%d: %r\n\n'
722 'A few following expected calls:\n %s' %
723 (prior_calls, len(self._calls_done), expected_args,
724 len(self._calls_done), args, following_calls))
725 git_cl.logging.error(extended_msg)
726
tandrii99a72f22016-08-17 14:33:24 -0700727 self.fail('@%d\n'
728 ' Expected: %r\n'
729 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700730 len(self._calls_done), expected_args, args))
731
732 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700733 if isinstance(result, Exception):
734 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000735 return result
736
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100737 def test_ask_for_explicit_yes_true(self):
738 self.calls = [
739 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
740 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
741 ]
742 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
743
tandrii48df5812016-10-17 03:55:37 -0700744 def test_LoadCodereviewSettingsFromFile_gerrit(self):
745 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
746 self.calls = [
747 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700748 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
749 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
750 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
751 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700752 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
753 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700754 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
755 CERR1),
756 ((['git', 'config', 'gerrit.host', 'true'],), ''),
757 ]
758 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
759
maruel@chromium.orga3353652011-11-30 14:26:57 +0000760 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000761 def _is_gerrit_calls(cls, gerrit=False):
762 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
763 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
764
765 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000766 def _git_post_upload_calls(cls):
767 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000768 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
769 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
770 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000771 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000772 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000773 ]
774
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000775 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000776 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000777 fake_ancestor = 'fake_ancestor'
778 fake_cl = 'fake_cl_for_patch'
779 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000780 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000781 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000782 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000783 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000784 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000785 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000786 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000787 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700788 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000789 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000790 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000791 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000792 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000793 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000794 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000795 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000796 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000797 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000798 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000799 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000800
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000801 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000802 def _gerrit_ensure_auth_calls(
803 cls, issue=None, skip_auth_check=False, short_hostname='chromium'):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000804 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000805 if skip_auth_check:
806 return [((cmd, ), 'true')]
807
tandrii5d48c322016-08-18 16:19:37 -0700808 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000809 if issue:
810 calls.extend([
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100811 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000812 ])
813 calls.extend([
814 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
815 ((['git', 'config', 'branch.master.remote'],), 'origin'),
816 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000817 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000818 ])
819 return calls
820
821 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100822 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200823 fetched_status=None, other_cl_owner=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000824 custom_cl_base=None, short_hostname='chromium'):
Aaron Gable13101a62018-02-09 13:20:41 -0800825 calls = cls._is_gerrit_calls(True)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100826 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200827 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200828 ((['git', 'config', 'branch.master.gerritissue'],),
829 CERR1 if issue is None else str(issue)),
830 ]
831
832 if custom_cl_base:
833 ancestor_revision = custom_cl_base
834 else:
835 # Determine ancestor_revision to be merge base.
836 ancestor_revision = 'fake_ancestor_sha'
837 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000838 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000839 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000840 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200841 'refs/remotes/origin/master'],), ancestor_revision),
842 ]
843
844 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000845 calls += cls._gerrit_ensure_auth_calls(
846 issue=issue, short_hostname=short_hostname)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100847
848 if issue:
849 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000850 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000851 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000852 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
853 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100854 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100855 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100856 'change_id': '123456789',
857 'current_revision': 'sha1_of_current_revision',
858 'revisions': { 'sha1_of_current_revision': {
859 'commit': {'message': fetched_description},
860 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100861 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100862 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100863 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100864 if fetched_status == 'ABANDONED':
865 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000866 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100867 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000868 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100869 ]
870 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100871 if other_cl_owner:
872 calls += [
873 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
874 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100875
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200876 calls += cls._git_sanity_checks(ancestor_revision, 'master',
877 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100878 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200879 ((['git', 'rev-parse', '--show-cdup'],), ''),
880 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000881
Aaron Gable7817f022017-12-12 09:43:17 -0800882 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
883 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200884 'M\t.gitignore\n'),
885 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100886 ]
887
888 if not issue:
889 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200890 ((['git', 'log', '--pretty=format:%s%n%n%b',
891 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000892 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100893 ]
894
895 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200896 ((['git', 'config', 'user.email'],), 'me@example.com'),
897 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
898 ([custom_cl_base] if custom_cl_base else
899 [ancestor_revision, 'HEAD']),),
900 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100901 ]
902 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000903
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000904 @classmethod
905 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700906 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000907 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700908 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100909 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000910 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000911 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000912 labels=None, change_id=None, original_title=None,
913 final_description=None, gitcookies_exists=True):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000914 if post_amend_description is None:
915 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700916 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200917 # Determined in `_gerrit_base_calls`.
918 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
919
920 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000921
tandriia60502f2016-06-20 02:01:53 -0700922 if squash_mode == 'default':
923 calls.extend([
924 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
925 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
926 ])
927 elif squash_mode in ('override_squash', 'override_nosquash'):
928 calls.extend([
929 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
930 'true' if squash_mode == 'override_squash' else 'false'),
931 ])
932 else:
933 assert squash_mode in ('squash', 'nosquash')
934
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000935 # If issue is given, then description is fetched from Gerrit instead.
936 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000937 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200938 ((['git', 'log', '--pretty=format:%s\n\n%b',
939 ((custom_cl_base + '..') if custom_cl_base else
940 'fake_ancestor_sha..HEAD')],),
941 description),
942 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800943 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000944 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800945 else:
946 if not title:
947 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200948 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
949 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800950 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000951 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000952 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000953 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200954 (('DownloadGerritHook', False), ''),
955 # Amending of commit message to get the Change-Id.
956 ((['git', 'log', '--pretty=format:%s\n\n%b',
957 determined_ancestor_revision + '..HEAD'],),
958 description),
959 ((['git', 'commit', '--amend', '-m', description],), ''),
960 ((['git', 'log', '--pretty=format:%s\n\n%b',
961 determined_ancestor_revision + '..HEAD'],),
962 post_amend_description)
963 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000964 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000965 if not issue:
966 # Prompting to edit description on first upload.
967 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000968 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200969 ((['git', 'config', 'core.editor'],), ''),
970 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000971 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000972 ref_to_push = 'abcdef0123456789'
973 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200974 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
975 ((['git', 'config', 'branch.master.remote'],), 'origin'),
976 ]
977
978 if custom_cl_base is None:
979 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000980 ((['get_or_create_merge_base', 'master',
981 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000982 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200983 ]
984 parent = 'origin/master'
985 else:
986 calls += [
987 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
988 'refs/remotes/origin/master'],),
989 callError(1)), # Means not ancenstor.
990 (('ask_for_data',
991 'Do you take responsibility for cleaning up potential mess '
992 'resulting from proceeding with upload? Press Enter to upload, '
993 'or Ctrl+C to abort'), ''),
994 ]
995 parent = custom_cl_base
996
997 calls += [
998 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
999 '0123456789abcdef'),
1000 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001001 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001002 ref_to_push),
1003 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001004 else:
1005 ref_to_push = 'HEAD'
1006
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001007 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001008 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001009 ((['git', 'rev-list',
1010 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1011 ref_to_push],),
1012 '1hashPerLine\n'),
1013 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001014
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001015 metrics_arguments = []
1016
Aaron Gableafd52772017-06-27 16:40:10 -07001017 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001018 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001019 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001020 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001021 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001022 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001023 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001024 else:
1025 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001026 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001027
Aaron Gable70f4e242017-06-26 10:45:59 -07001028 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001029 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001030 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001031
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001032 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001033 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001034 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001035 if short_hostname == 'chromium':
1036 # All reviwers and ccs get into ref_suffix.
1037 for r in sorted(reviewers):
1038 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001039 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001040 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1041 'joe@example.com'] + cc):
1042 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001043 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001044 reviewers, cc = [], []
1045 else:
1046 # TODO(crbug/877717): remove this case.
1047 calls += [
1048 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1049 sorted(reviewers) + ['joe@example.com',
1050 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1051 {
1052 e: {'email': e}
1053 for e in (reviewers + ['joe@example.com'] + cc)
1054 })
1055 ]
1056 for r in sorted(reviewers):
1057 if r != 'bad-account-or-email':
1058 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001059 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001060 reviewers.remove(r)
1061 for c in sorted(['joe@example.com'] + cc):
1062 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001063 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001064 if c in cc:
1065 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001066
Edward Lemur687ca902018-12-05 02:30:30 +00001067 for k, v in sorted((labels or {}).items()):
1068 ref_suffix += ',l=%s+%d' % (k, v)
1069 metrics_arguments.append('l=%s+%d' % (k, v))
1070
1071 if tbr:
1072 calls += [
1073 (('GetCodeReviewTbrScore',
1074 '%s-review.googlesource.com' % short_hostname,
1075 'my/repo'),
1076 2,),
1077 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001078
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001079 calls += [
1080 (('time.time',), 1000,),
1081 ((['git', 'push',
1082 'https://%s.googlesource.com/my/repo' % short_hostname,
1083 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1084 (('remote:\n'
1085 'remote: Processing changes: (\)\n'
1086 'remote: Processing changes: (|)\n'
1087 'remote: Processing changes: (/)\n'
1088 'remote: Processing changes: (-)\n'
1089 'remote: Processing changes: new: 1 (/)\n'
1090 'remote: Processing changes: new: 1, done\n'
1091 'remote:\n'
1092 'remote: New Changes:\n'
1093 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1094 ' XXX\n'
1095 'remote:\n'
1096 'To https://%s.googlesource.com/my/repo\n'
1097 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1098 ) % (short_hostname, short_hostname)),),
1099 (('time.time',), 2000,),
1100 (('add_repeated',
1101 'sub_commands',
1102 {
1103 'execution_time': 1000,
1104 'command': 'git push',
1105 'exit_code': 0,
1106 'arguments': sorted(metrics_arguments),
1107 }),
1108 None,),
1109 ]
1110
Edward Lemur1b52d872019-05-09 21:12:12 +00001111 final_description = final_description or post_amend_description.strip()
1112 original_title = original_title or title or '<untitled>'
1113 # Trace-related calls
1114 calls += [
1115 # Write a description with context for the current trace.
1116 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
1117 'Date: Thu Mar 16 20:00:41 2017\n\n'
1118 'Change: https://%(short_hostname)s-review.googlesource.com/'
1119 'q/%(change_id)s\n'
1120 'Title: %(title)s\n\n'
1121 '%(description)s\n\n'
1122 'Execution time: 1000\n'
1123 'Exit code: 0\n\n'
1124 'When filing a bug for this push, be sure to include the traces '
1125 'found at:\n'
1126 ' TRACES_DIR/20170316T200041.000000-traces.zip\n'
1127 'Consider including the git config and gitcookies, which we have '
1128 'packed for \nyou at:\n'
1129 ' TRACES_DIR/20170316T200041.000000-git-info.zip\n' % {
1130 'short_hostname': short_hostname,
1131 'change_id': change_id,
1132 'description': final_description,
1133 'title': original_title,
1134 }],),
1135 None,
1136 ),
1137 # Read traces and shorten git hashes.
1138 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1139 True,
1140 ),
1141 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1142 ('git-hash: 0123456789012345678901234567890123456789\n'
1143 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1144 ),
1145 ((['FileWrite', 'TEMP_DIR/trace-packet',
1146 'git-hash: 012345\n'
1147 'git-hash: abcdea\n'],),
1148 None,
1149 ),
1150 # Make zip file for the git traces.
1151 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1152 'TEMP_DIR'],),
1153 None,
1154 ),
1155 # Collect git config and gitcookies.
1156 ((['git', 'config', '-l'],),
1157 'git-config-output',
1158 ),
1159 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1160 None,
1161 ),
1162 ((['os.path.isfile', '~/.gitcookies'],),
1163 gitcookies_exists,
1164 ),
1165 ]
1166 if gitcookies_exists:
1167 calls += [
1168 ((['FileRead', '~/.gitcookies'],),
1169 'gitcookies 1/SECRET',
1170 ),
1171 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1172 None,
1173 ),
1174 ]
1175 calls += [
1176 # Make zip file for the git config and gitcookies.
1177 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1178 'TEMP_DIR'],),
1179 None,
1180 ),
1181 ]
1182
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001183 if squash:
1184 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001185 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001186 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001187 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001188 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001189 ((['git', 'config', 'branch.master.gerritsquashhash',
1190 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001191 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001192 # TODO(crbug/877717): this should never be used.
1193 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001194 calls += [
1195 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001196 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001197 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001198 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1199 notify),
1200 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001201 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001202 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001203 return calls
1204
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001205 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001206 self,
1207 upload_args,
1208 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001209 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001210 squash=True,
1211 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001212 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001213 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001214 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001215 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001216 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001217 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001218 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001219 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001220 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001221 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001222 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001223 labels=None,
1224 change_id=None,
1225 original_title=None,
1226 final_description=None,
1227 gitcookies_exists=True):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001228 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001229 if squash_mode is None:
1230 if '--no-squash' in upload_args:
1231 squash_mode = 'nosquash'
1232 elif '--squash' in upload_args:
1233 squash_mode = 'squash'
1234 else:
1235 squash_mode = 'default'
1236
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001237 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001238 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001239 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001240 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001241 CookiesAuthenticatorMockFactory(
1242 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001243 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1244 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001245 self.mock(git_cl.gclient_utils, 'RunEditor',
1246 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001247 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1248 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001249 self.mock(git_cl.gclient_utils, 'FileRead',
1250 lambda path: self._mocked_call(['FileRead', path]))
1251 self.mock(git_cl.gclient_utils, 'FileWrite',
1252 lambda path, contents: self._mocked_call(
1253 ['FileWrite', path, contents]))
1254 self.mock(git_cl, 'datetime_now',
1255 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1256 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1257 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
1258 self.mock(git_cl.shutil, 'make_archive',
1259 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1260 self.mock(os.path, 'isfile',
1261 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001262
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001263 self.calls = self._gerrit_base_calls(
1264 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001265 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001266 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001267 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001268 custom_cl_base=custom_cl_base,
1269 short_hostname=short_hostname)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001270 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001271 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1272 expected_content=description))
1273 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001274 self.calls += self._gerrit_upload_calls(
1275 description, reviewers, squash,
1276 squash_mode=squash_mode,
1277 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001278 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001279 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001280 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001281 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001282 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001283 labels=labels,
1284 change_id=change_id,
1285 original_title=original_title,
1286 final_description=final_description,
1287 gitcookies_exists=gitcookies_exists)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001288 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001289 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001290 git_cl.main(['upload'] + upload_args)
1291
Edward Lemur1b52d872019-05-09 21:12:12 +00001292 def test_gerrit_upload_traces_no_gitcookies(self):
1293 self._run_gerrit_upload_test(
1294 ['--no-squash'],
1295 'desc\n\nBUG=\n',
1296 [],
1297 squash=False,
1298 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1299 change_id='Ixxx',
1300 gitcookies_exists=False)
1301
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001302 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001303 self._run_gerrit_upload_test(
1304 ['--no-squash'],
1305 'desc\n\nBUG=\n',
1306 [],
1307 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001308 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1309 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001310
1311 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001312 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001313 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001314 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001315 [],
tandriia60502f2016-06-20 02:01:53 -07001316 squash=False,
1317 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001318 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1319 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001320
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001321 def test_gerrit_no_reviewer(self):
1322 self._run_gerrit_upload_test(
1323 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001324 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001325 [],
1326 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001327 squash_mode='override_nosquash',
1328 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001329
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001330 def test_gerrit_no_reviewer_non_chromium_host(self):
1331 # TODO(crbug/877717): remove this test case.
1332 self._run_gerrit_upload_test(
1333 [],
1334 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1335 [],
1336 squash=False,
1337 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001338 short_hostname='other',
1339 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001340
Nick Carter8692b182017-11-06 16:30:38 -08001341 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001342 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1343 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001344 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001345 'desc\n\nBUG=\n\nChange-Id: I123456789',
1346 squash=False,
1347 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001348 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1349 change_id='I123456789',
1350 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001351
ukai@chromium.orge8077812012-02-03 03:41:46 +00001352 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001353 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001354 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001355 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001356 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001357 squash=False,
1358 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001359 notify=True,
1360 change_id='I123456789',
1361 final_description=
1362 'desc\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001363
1364 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001365 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1366 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001367 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001368 [],
bradnelsond975b302016-10-23 12:20:23 -07001369 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1370 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001371 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001372 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001373 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001374 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001375 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001376 labels={'Code-Review': 2},
1377 change_id='123456789',
1378 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001379
1380 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001381 self._run_gerrit_upload_test(
1382 [],
1383 'desc\nBUG=\n\nChange-Id: 123456789',
1384 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001385 expected_upstream_ref='origin/master',
1386 change_id='123456789',
1387 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001388
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001389 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001390 self._run_gerrit_upload_test(
1391 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001392 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001393 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001394 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001395 expected_upstream_ref='origin/master',
1396 change_id='123456789',
1397 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001398
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001399 def test_gerrit_upload_squash_first_with_labels(self):
1400 self._run_gerrit_upload_test(
1401 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1402 'desc\nBUG=\n\nChange-Id: 123456789',
1403 [],
1404 squash=True,
1405 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001406 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1407 change_id='123456789',
1408 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001409
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001410 def test_gerrit_upload_squash_first_against_rev(self):
1411 custom_cl_base = 'custom_cl_base_rev_or_branch'
1412 self._run_gerrit_upload_test(
1413 ['--squash', custom_cl_base],
1414 'desc\nBUG=\n\nChange-Id: 123456789',
1415 [],
1416 squash=True,
1417 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001418 custom_cl_base=custom_cl_base,
1419 change_id='123456789',
1420 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001421 self.assertIn(
1422 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1423 sys.stdout.getvalue())
1424
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001425 def test_gerrit_upload_squash_reupload(self):
1426 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001427 self._run_gerrit_upload_test(
1428 ['--squash'],
1429 description,
1430 [],
1431 squash=True,
1432 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001433 issue=123456,
1434 change_id='123456789',
1435 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001436
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001437 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1438 self.mock(git_cl, 'DieWithError',
1439 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1440 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1441 with self.assertRaises(SystemExitMock):
1442 self._run_gerrit_upload_test(
1443 ['--squash'],
1444 description,
1445 [],
1446 squash=True,
1447 expected_upstream_ref='origin/master',
1448 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001449 fetched_status='ABANDONED',
1450 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001451
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001452 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1453 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1454 lambda *_, **__: {'email': 'yet-another@example.com'})
1455 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1456 self._run_gerrit_upload_test(
1457 ['--squash'],
1458 description,
1459 [],
1460 squash=True,
1461 expected_upstream_ref='origin/master',
1462 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001463 other_cl_owner='other@example.com',
1464 change_id='123456789',
1465 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001466 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001467 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001468 'authenticate to Gerrit as yet-another@example.com.\n'
1469 'Uploading may fail due to lack of permissions',
1470 git_cl.sys.stdout.getvalue())
1471
rmistry@google.com2dd99862015-06-22 12:22:18 +00001472 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001473 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001474 def mock_run_git(*args, **_kwargs):
1475 if args[0] == ['for-each-ref',
1476 '--format=%(refname:short) %(upstream:short)',
1477 'refs/heads']:
1478 # Create a local branch dependency tree that looks like this:
1479 # test1 -> test2 -> test3 -> test4 -> test5
1480 # -> test3.1
1481 # test6 -> test0
1482 branch_deps = [
1483 'test2 test1', # test1 -> test2
1484 'test3 test2', # test2 -> test3
1485 'test3.1 test2', # test2 -> test3.1
1486 'test4 test3', # test3 -> test4
1487 'test5 test4', # test4 -> test5
1488 'test6 test0', # test0 -> test6
1489 'test7', # test7
1490 ]
1491 return '\n'.join(branch_deps)
1492 self.mock(git_cl, 'RunGit', mock_run_git)
1493
1494 class RecordCalls:
1495 times_called = 0
1496 record_calls = RecordCalls()
1497 def mock_CMDupload(*args, **_kwargs):
1498 record_calls.times_called += 1
1499 return 0
1500 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1501
1502 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001503 (('ask_for_data', 'This command will checkout all dependent branches '
1504 'and run "git cl upload". Press Enter to continue, '
1505 'or Ctrl+C to abort'), ''),
1506 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001507
1508 class MockChangelist():
1509 def __init__(self):
1510 pass
1511 def GetBranch(self):
1512 return 'test1'
1513 def GetIssue(self):
1514 return '123'
1515 def GetPatchset(self):
1516 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001517 def IsGerrit(self):
1518 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001519
1520 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1521 # CMDupload should have been called 5 times because of 5 dependent branches.
1522 self.assertEquals(5, record_calls.times_called)
1523 self.assertEquals(0, ret)
1524
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001525 def test_gerrit_change_id(self):
1526 self.calls = [
1527 ((['git', 'write-tree'], ),
1528 'hashtree'),
1529 ((['git', 'rev-parse', 'HEAD~0'], ),
1530 'branch-parent'),
1531 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1532 'A B <a@b.org> 1456848326 +0100'),
1533 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1534 'C D <c@d.org> 1456858326 +0100'),
1535 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1536 'hashchange'),
1537 ]
1538 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1539 self.assertEqual(change_id, 'Ihashchange')
1540
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001541 def test_desecription_append_footer(self):
1542 for init_desc, footer_line, expected_desc in [
1543 # Use unique desc first lines for easy test failure identification.
1544 ('foo', 'R=one', 'foo\n\nR=one'),
1545 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1546 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1547 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1548 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1549 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1550 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1551 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1552 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1553 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1554 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1555 ]:
1556 desc = git_cl.ChangeDescription(init_desc)
1557 desc.append_footer(footer_line)
1558 self.assertEqual(desc.description, expected_desc)
1559
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001560 def test_update_reviewers(self):
1561 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001562 ('foo', [], [],
1563 'foo'),
1564 ('foo\nR=xx', [], [],
1565 'foo\nR=xx'),
1566 ('foo\nTBR=xx', [], [],
1567 'foo\nTBR=xx'),
1568 ('foo', ['a@c'], [],
1569 'foo\n\nR=a@c'),
1570 ('foo\nR=xx', ['a@c'], [],
1571 'foo\n\nR=a@c, xx'),
1572 ('foo\nTBR=xx', ['a@c'], [],
1573 'foo\n\nR=a@c\nTBR=xx'),
1574 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1575 'foo\n\nR=a@c, yy\nTBR=xx'),
1576 ('foo\nBUG=', ['a@c'], [],
1577 'foo\nBUG=\nR=a@c'),
1578 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1579 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1580 ('foo', ['a@c', 'b@c'], [],
1581 'foo\n\nR=a@c, b@c'),
1582 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1583 'foo\nBar\n\nR=c@c\nBUG='),
1584 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1585 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001586 # Same as the line before, but full of whitespaces.
1587 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001588 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001589 'foo\nBar\n\nR=c@c\n BUG =',
1590 ),
1591 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001592 ('foo BUG=allo R=joe ', ['c@c'], [],
1593 'foo BUG=allo R=joe\n\nR=c@c'),
1594 # Redundant TBRs get promoted to Rs
1595 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1596 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001597 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001598 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001599 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001600 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001601 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001602 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001603 actual.append(obj.description)
1604 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001605
Nodir Turakulov23b82142017-11-16 11:04:25 -08001606 def test_get_hash_tags(self):
1607 cases = [
1608 ('', []),
1609 ('a', []),
1610 ('[a]', ['a']),
1611 ('[aa]', ['aa']),
1612 ('[a ]', ['a']),
1613 ('[a- ]', ['a']),
1614 ('[a- b]', ['a-b']),
1615 ('[a--b]', ['a-b']),
1616 ('[a', []),
1617 ('[a]x', ['a']),
1618 ('[aa]x', ['aa']),
1619 ('[a b]', ['a-b']),
1620 ('[a b]', ['a-b']),
1621 ('[a__b]', ['a-b']),
1622 ('[a] x', ['a']),
1623 ('[a][b]', ['a', 'b']),
1624 ('[a] [b]', ['a', 'b']),
1625 ('[a][b]x', ['a', 'b']),
1626 ('[a][b] x', ['a', 'b']),
1627 ('[a]\n[b]', ['a']),
1628 ('[a\nb]', []),
1629 ('[a][', ['a']),
1630 ('Revert "[a] feature"', ['a']),
1631 ('Reland "[a] feature"', ['a']),
1632 ('Revert: [a] feature', ['a']),
1633 ('Reland: [a] feature', ['a']),
1634 ('Revert "Reland: [a] feature"', ['a']),
1635 ('Foo: feature', ['foo']),
1636 ('Foo Bar: feature', ['foo-bar']),
1637 ('Revert "Foo bar: feature"', ['foo-bar']),
1638 ('Reland "Foo bar: feature"', ['foo-bar']),
1639 ]
1640 for desc, expected in cases:
1641 change_desc = git_cl.ChangeDescription(desc)
1642 actual = change_desc.get_hash_tags()
1643 self.assertEqual(
1644 actual,
1645 expected,
1646 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1647
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001648
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001649 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001650 self.assertEqual(None, git_cl.GetTargetRef(None,
1651 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001652 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001653
wittman@chromium.org455dc922015-01-26 20:15:50 +00001654 # Check default target refs for branches.
1655 self.assertEqual('refs/heads/master',
1656 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001657 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001658 self.assertEqual('refs/heads/master',
1659 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001660 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001661 self.assertEqual('refs/heads/master',
1662 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001663 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001664 self.assertEqual('refs/branch-heads/123',
1665 git_cl.GetTargetRef('origin',
1666 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001667 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001668 self.assertEqual('refs/diff/test',
1669 git_cl.GetTargetRef('origin',
1670 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001671 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001672 self.assertEqual('refs/heads/chrome/m42',
1673 git_cl.GetTargetRef('origin',
1674 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001675 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001676
1677 # Check target refs for user-specified target branch.
1678 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1679 'refs/remotes/branch-heads/123'):
1680 self.assertEqual('refs/branch-heads/123',
1681 git_cl.GetTargetRef('origin',
1682 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001683 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001684 for branch in ('origin/master', 'remotes/origin/master',
1685 'refs/remotes/origin/master'):
1686 self.assertEqual('refs/heads/master',
1687 git_cl.GetTargetRef('origin',
1688 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001689 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001690 for branch in ('master', 'heads/master', 'refs/heads/master'):
1691 self.assertEqual('refs/heads/master',
1692 git_cl.GetTargetRef('origin',
1693 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001694 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001695
wychen@chromium.orga872e752015-04-28 23:42:18 +00001696 def test_patch_when_dirty(self):
1697 # Patch when local tree is dirty
1698 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1699 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1700
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001701 @staticmethod
1702 def _get_gerrit_codereview_server_calls(branch, value=None,
1703 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001704 detect_branch=True,
1705 detect_server=True):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001706 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1707
1708 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1709 """
1710 calls = []
1711 if detect_branch:
1712 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001713 if detect_server:
1714 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1715 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001716 if value is None:
1717 calls += [
1718 ((['git', 'config', 'branch.' + branch + '.merge'],),
1719 'refs/heads' + branch),
1720 ((['git', 'config', 'branch.' + branch + '.remote'],),
1721 'origin'),
1722 ((['git', 'config', 'remote.origin.url'],),
1723 'https://%s.googlesource.com/my/repo' % git_short_host),
1724 ]
1725 return calls
1726
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001727 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001728 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001729 detect_gerrit_server=False,
1730 actual_codereview=None,
1731 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001732 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001733 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1734
tandriidf09a462016-08-18 16:23:55 -07001735 if new_branch:
1736 self.calls = [((['git', 'new-branch', 'master'],), ''),]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001737
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001738 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001739 self.calls += [
1740 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001741 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001742 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001743
1744 if not force_codereview and not codereview_in_url:
1745 # These calls detect codereview to use.
1746 self.calls += [
1747 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001748 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001749 ]
1750 if detect_gerrit_server:
1751 self.calls += self._get_gerrit_codereview_server_calls(
1752 'master', git_short_host=git_short_host,
1753 detect_branch=not new_branch and force_codereview)
1754 actual_codereview = 'gerrit'
1755
1756 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001757 self.calls += [
1758 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001759 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001760 {
1761 'current_revision': '7777777777',
1762 'revisions': {
1763 '1111111111': {
1764 '_number': 1,
1765 'fetch': {'http': {
1766 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1767 'ref': 'refs/changes/56/123456/1',
1768 }},
1769 },
1770 '7777777777': {
1771 '_number': 7,
1772 'fetch': {'http': {
1773 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1774 'ref': 'refs/changes/56/123456/7',
1775 }},
1776 },
1777 },
1778 }),
1779 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001780
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001781 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001782 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001783 self.calls += [
1784 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1785 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001786 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001787 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001788 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001789 ((['git', 'config', 'branch.master.gerritserver',
1790 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001791 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001792 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1793 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1794 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001795 ]
1796 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1797
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001798 def test_patch_gerrit_new_branch(self):
1799 self._patch_common(
1800 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1801 self.calls += [
1802 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1803 'refs/changes/56/123456/7'],), ''),
1804 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1805 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1806 ''),
1807 ((['git', 'config', 'branch.master.gerritserver',
1808 'https://chromium-review.googlesource.com'],), ''),
1809 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1810 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1811 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1812 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1813 ]
1814 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1815
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001816 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001817 self._patch_common(
1818 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001819 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001820 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001821 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001822 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001823 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001824 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001825 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001826 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001827 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001828 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1829 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1830 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001831 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001832 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001833
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001834 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001835 self.calls += self._get_gerrit_codereview_server_calls(
1836 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001837 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001838 actual_codereview='gerrit', git_short_host='else',
1839 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001840 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001841 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001842 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001843 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001844 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001845 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001846 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001847 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001848 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001849 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1850 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1851 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001852 ]
1853 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001854 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001855
Aaron Gable697a91b2018-01-19 15:20:15 -08001856 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001857 self.calls += self._get_gerrit_codereview_server_calls(
1858 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001859 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001860 actual_codereview='gerrit', git_short_host='else',
1861 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001862 self.calls += [
1863 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1864 'refs/changes/56/123456/1'],), ''),
1865 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1866 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1867 ''),
1868 ((['git', 'config', 'branch.master.gerritserver',
1869 'https://else-review.googlesource.com'],), ''),
1870 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1871 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1872 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1873 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1874 ]
1875 self.assertEqual(git_cl.main(
1876 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1877 0)
1878
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001879 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001880 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001881 self.calls += [
1882 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001883 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001884 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1885 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1886 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001887 ]
1888 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001889 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001890
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001891 def test_patch_gerrit_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001892 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001893 raise git_cl.gerrit_util.GerritError(404, '')
1894 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1895
tandriic2405f52016-10-10 08:13:15 -07001896 self.calls = [
1897 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandriic2405f52016-10-10 08:13:15 -07001898 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001899 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1900 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1901 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1902 ((['git', 'config', 'remote.origin.url'],),
1903 'https://chromium.googlesource.com/my/repo'),
1904 ((['DieWithError',
1905 'change 123456 at https://chromium-review.googlesource.com does not '
1906 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001907 ]
1908 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001909 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001910
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001911 def _checkout_calls(self):
1912 return [
1913 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001914 'branch\\..*\\.gerritissue'], ),
1915 ('branch.ger-branch.gerritissue 123456\n'
1916 'branch.gbranch654.gerritissue 654321\n')),
1917 ]
1918
1919 def test_checkout_gerrit(self):
1920 """Tests git cl checkout <issue>."""
1921 self.calls = self._checkout_calls()
1922 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1923 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1924
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001925 def test_checkout_not_found(self):
1926 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001927 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001928 self.calls = self._checkout_calls()
1929 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1930
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001931 def test_checkout_no_branch_issues(self):
1932 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001933 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001934 self.calls = [
1935 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001936 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001937 ]
1938 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1939
tandrii@chromium.org28253532016-04-14 13:46:56 +00001940 def _test_gerrit_ensure_authenticated_common(self, auth,
1941 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001942 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1943 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1944 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001945 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001946 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001947 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00001948 cl.branch = 'master'
1949 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001950 cl.lookedup_issue = True
1951 return cl
1952
1953 def test_gerrit_ensure_authenticated_missing(self):
1954 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001955 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001956 })
1957 self.calls.append(
1958 ((['DieWithError',
1959 'Credentials for the following hosts are required:\n'
1960 ' chromium-review.googlesource.com\n'
1961 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01001962 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001963 'https://chromium-review.googlesource.com/new-password'],), ''),)
1964 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1965
1966 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001967 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001968 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001969 'chromium.googlesource.com':
1970 ('git-one.example.com', None, 'secret1'),
1971 'chromium-review.googlesource.com':
1972 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001973 })
1974 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001975 (('ask_for_data', 'If you know what you are doing '
1976 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001977 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1978
1979 def test_gerrit_ensure_authenticated_ok(self):
1980 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001981 'chromium.googlesource.com':
1982 ('git-same.example.com', None, 'secret'),
1983 'chromium-review.googlesource.com':
1984 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001985 })
1986 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1987
tandrii@chromium.org28253532016-04-14 13:46:56 +00001988 def test_gerrit_ensure_authenticated_skipped(self):
1989 cl = self._test_gerrit_ensure_authenticated_common(
1990 auth={}, skip_auth_check=True)
1991 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1992
Eric Boren2fb63102018-10-05 13:05:03 +00001993 def test_gerrit_ensure_authenticated_bearer_token(self):
1994 cl = self._test_gerrit_ensure_authenticated_common(auth={
1995 'chromium.googlesource.com':
1996 ('', None, 'secret'),
1997 'chromium-review.googlesource.com':
1998 ('', None, 'secret'),
1999 })
2000 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2001 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2002 'chromium.googlesource.com')
2003 self.assertTrue('Bearer' in header)
2004
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002005 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002006 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002007 lambda h, i, labels, notify=None:
2008 self._mocked_call(['SetReview', h, i, labels, notify]))
2009
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002010 self.calls = [
2011 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002012 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002013 ((['git', 'config', 'branch.feature.gerritserver'],),
2014 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002015 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2016 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2017 ((['git', 'config', 'remote.origin.url'],),
2018 'https://chromium.googlesource.com/infra/infra.git'),
2019 ((['SetReview', 'chromium-review.googlesource.com',
2020 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002021 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002022 ]
tandriid9e5ce52016-07-13 02:32:59 -07002023
2024 def test_cmd_set_commit_gerrit_clear(self):
2025 self._cmd_set_commit_gerrit_common(0)
2026 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2027
2028 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002029 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002030 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2031
tandriid9e5ce52016-07-13 02:32:59 -07002032 def test_cmd_set_commit_gerrit(self):
2033 self._cmd_set_commit_gerrit_common(2)
2034 self.assertEqual(0, git_cl.main(['set-commit']))
2035
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002036 def test_description_display(self):
2037 out = StringIO.StringIO()
2038 self.mock(git_cl.sys, 'stdout', out)
2039
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002040 self.mock(git_cl, 'Changelist', ChangelistMock)
2041 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002042
2043 self.assertEqual(0, git_cl.main(['description', '-d']))
2044 self.assertEqual('foo\n', out.getvalue())
2045
iannucci3c972b92016-08-17 13:24:10 -07002046 def test_StatusFieldOverrideIssueMissingArgs(self):
2047 out = StringIO.StringIO()
2048 self.mock(git_cl.sys, 'stderr', out)
2049
2050 try:
2051 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2052 except SystemExit as ex:
2053 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002054 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002055
2056 out = StringIO.StringIO()
2057 self.mock(git_cl.sys, 'stderr', out)
2058
2059 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002060 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002061 except SystemExit as ex:
2062 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002063 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002064
2065 def test_StatusFieldOverrideIssue(self):
2066 out = StringIO.StringIO()
2067 self.mock(git_cl.sys, 'stdout', out)
2068
2069 def assertIssue(cl_self, *_args):
2070 self.assertEquals(cl_self.issue, 1)
2071 return 'foobar'
2072
2073 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002074 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002075 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002076 0)
iannucci3c972b92016-08-17 13:24:10 -07002077 self.assertEqual(out.getvalue(), 'foobar\n')
2078
iannuccie53c9352016-08-17 14:40:40 -07002079 def test_SetCloseOverrideIssue(self):
2080 def assertIssue(cl_self, *_args):
2081 self.assertEquals(cl_self.issue, 1)
2082 return 'foobar'
2083
2084 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2085 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002086 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002087 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002088
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002089 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002090 out = StringIO.StringIO()
2091 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002092 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002093 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2094 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2095 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2096 ((['git', 'config', 'remote.origin.url'],),
2097 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002098 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002099 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002100 {
2101 'current_revision': 'sha1',
2102 'revisions': {'sha1': {
2103 'commit': {'message': 'foobar'},
2104 }},
2105 }),
2106 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002107 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002108 'description',
2109 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2110 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002111 self.assertEqual('foobar\n', out.getvalue())
2112
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002113 def test_description_set_raw(self):
2114 out = StringIO.StringIO()
2115 self.mock(git_cl.sys, 'stdout', out)
2116
2117 self.mock(git_cl, 'Changelist', ChangelistMock)
2118 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2119
2120 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2121 self.assertEqual('hihi', ChangelistMock.desc)
2122
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002123 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002124 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002125
2126 def RunEditor(desc, _, **kwargs):
2127 self.assertEquals(
2128 '# Enter a description of the change.\n'
2129 '# This will be displayed on the codereview site.\n'
2130 '# The first line will also be used as the subject of the review.\n'
2131 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002132 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002133 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002134 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002135 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002136 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002137
dsansomee2d6fd92016-09-08 00:10:47 -07002138 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002139 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002140
2141 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2142 self.mock(git_cl.Changelist, 'GetDescription',
2143 lambda *args: current_desc)
2144 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2145 UpdateDescriptionRemote)
2146 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2147
2148 self.calls = [
2149 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002150 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002151 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2152 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002153 ((['git', 'config', 'core.editor'],), 'vi'),
2154 ]
2155 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2156
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002157 def test_description_set_stdin(self):
2158 out = StringIO.StringIO()
2159 self.mock(git_cl.sys, 'stdout', out)
2160
2161 self.mock(git_cl, 'Changelist', ChangelistMock)
2162 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2163
2164 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2165 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2166
kmarshall3bff56b2016-06-06 18:31:47 -07002167 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002168 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2169
kmarshall3bff56b2016-06-06 18:31:47 -07002170 self.calls = \
2171 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2172 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002173 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2174 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
tandrii33a46ff2016-08-23 05:53:40 -07002175 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002176 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2177 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2178 ((['git', 'branch', '-D', 'foo'],), '')]
2179
kmarshall3bff56b2016-06-06 18:31:47 -07002180 self.mock(git_cl, 'get_cl_statuses',
2181 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002182 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2183 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2184 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002185
2186 self.assertEqual(0, git_cl.main(['archive', '-f']))
2187
2188 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002189 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002190 self.calls = \
2191 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2192 'refs/heads/master'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002193 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
kmarshall3bff56b2016-06-06 18:31:47 -07002194 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2195
kmarshall9249e012016-08-23 12:02:16 -07002196 self.mock(git_cl, 'get_cl_statuses',
2197 lambda branches, fine_grained, max_processes:
2198 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2199
2200 self.assertEqual(1, git_cl.main(['archive', '-f']))
2201
2202 def test_archive_dry_run(self):
2203 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2204
2205 self.calls = \
2206 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2207 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002208 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2209 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002210 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2211 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002212
2213 self.mock(git_cl, 'get_cl_statuses',
2214 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002215 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2216 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2217 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002218
kmarshall9249e012016-08-23 12:02:16 -07002219 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2220
2221 def test_archive_no_tags(self):
2222 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2223
2224 self.calls = \
2225 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2226 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002227 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
2228 ((['git', 'config', 'branch.foo.gerritissue'],), '456'),
2229 ((['git', 'config', 'branch.bar.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002230 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2231 ((['git', 'branch', '-D', 'foo'],), '')]
2232
2233 self.mock(git_cl, 'get_cl_statuses',
2234 lambda branches, fine_grained, max_processes:
2235 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2236 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2237 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2238
2239 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002240
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002241 def test_cmd_issue_erase_existing(self):
2242 out = StringIO.StringIO()
2243 self.mock(git_cl.sys, 'stdout', out)
2244 self.calls = [
2245 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002246 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002247 # Let this command raise exception (retcode=1) - it should be ignored.
2248 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002249 CERR1),
2250 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2251 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002252 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2253 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2254 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002255 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002256 ]
2257 self.assertEqual(0, git_cl.main(['issue', '0']))
2258
Aaron Gable400e9892017-07-12 15:31:21 -07002259 def test_cmd_issue_erase_existing_with_change_id(self):
2260 out = StringIO.StringIO()
2261 self.mock(git_cl.sys, 'stdout', out)
2262 self.mock(git_cl.Changelist, 'GetDescription',
2263 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2264 self.calls = [
2265 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002266 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
Aaron Gable400e9892017-07-12 15:31:21 -07002267 # Let this command raise exception (retcode=1) - it should be ignored.
2268 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2269 CERR1),
2270 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2271 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2272 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2273 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2274 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002275 ((['git', 'log', '-1', '--format=%B'],),
2276 'This is a description\n\nChange-Id: Ideadbeef'),
2277 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002278 ]
2279 self.assertEqual(0, git_cl.main(['issue', '0']))
2280
phajdan.jre328cf92016-08-22 04:12:17 -07002281 def test_cmd_issue_json(self):
2282 out = StringIO.StringIO()
2283 self.mock(git_cl.sys, 'stdout', out)
2284 self.calls = [
2285 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002286 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2287 ((['git', 'config', 'branch.feature.gerritserver'],),
2288 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002289 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002290 {'issue': 123,
2291 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002292 ''),
2293 ]
2294 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2295
tandrii8c5a3532016-11-04 07:52:02 -07002296 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2297 self.mock(git_cl.Changelist, 'GetChange',
2298 lambda _, *a: (
2299 self._mocked_call(['GetChange']+list(a))))
2300 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2301 lambda *_, **__: (
2302 self._mocked_call(['DoGetTryMasters'])))
2303 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2304 lambda _, s: self._mocked_call(['SetCQState', s]))
2305
tandrii8c5a3532016-11-04 07:52:02 -07002306 self.calls = [
2307 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002308 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2309 ((['git', 'config', 'branch.feature.gerritserver'],),
2310 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002311 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2312 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2313 ((['git', 'config', 'remote.origin.url'],),
2314 'https://chromium.googlesource.com/depot_tools'),
2315 (('GetChangeDetail', 'chromium-review.googlesource.com',
2316 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002317 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2318 'project': 'depot_tools',
2319 'status': 'OPEN',
2320 'owner': {'email': 'owner@e.mail'},
2321 'revisions': {
2322 'deadbeaf': {
2323 '_number': 6,
2324 },
2325 'beeeeeef': {
2326 '_number': 7,
2327 'fetch': {'http': {
2328 'url': 'https://chromium.googlesource.com/depot_tools',
2329 'ref': 'refs/changes/56/123456/7'
2330 }},
2331 },
2332 },
2333 }),
tandrii8c5a3532016-11-04 07:52:02 -07002334 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2335 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2336 ((['get_or_create_merge_base', 'feature', 'feature'],),
2337 'fake_ancestor_sha'),
2338 ((['GetChange', 'fake_ancestor_sha', None], ),
2339 git_cl.presubmit_support.GitChange(
2340 '', '', '', '', '', '', '', '')),
2341 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2342 ((['DoGetTryMasters'], ), None),
2343 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2344 ]
2345 out = StringIO.StringIO()
2346 self.mock(git_cl.sys, 'stdout', out)
2347 self.assertEqual(0, git_cl.main(['try']))
2348 self.assertEqual(
2349 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002350 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002351 'https://chromium-review.googlesource.com/123456\n')
2352
tandrii8c5a3532016-11-04 07:52:02 -07002353 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2354 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2355 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2356
tandrii8c5a3532016-11-04 07:52:02 -07002357 self.calls = [
2358 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002359 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2360 ((['git', 'config', 'branch.feature.gerritserver'],),
2361 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002362 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2363 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2364 ((['git', 'config', 'remote.origin.url'],),
2365 'https://chromium.googlesource.com/depot_tools'),
2366 (('GetChangeDetail', 'chromium-review.googlesource.com',
2367 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002368 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002369 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002370 'status': 'OPEN',
2371 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002372 'revisions': {
2373 'deadbeaf': {
2374 '_number': 6,
2375 },
2376 'beeeeeef': {
2377 '_number': 7,
2378 'fetch': {'http': {
2379 'url': 'https://chromium.googlesource.com/depot_tools',
2380 'ref': 'refs/changes/56/123456/7'
2381 }},
2382 },
2383 },
2384 }),
2385 ]
2386
2387 def _buildbucket_retry(*_, **kw):
2388 # self.maxDiff = 10000
2389 body = json.loads(kw['body'])
2390 self.assertEqual(len(body['builds']), 1)
2391 build = body['builds'][0]
2392 params = json.loads(build.pop('parameters_json'))
2393 self.assertEqual(params, {
2394 u'builder_name': u'win',
2395 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2396 u'revision': None}],
2397 u'properties': {
2398 u'category': u'git_cl_try',
2399 u'key': u'val',
2400 u'json': [{u'a': 1}, None],
tandrii8c5a3532016-11-04 07:52:02 -07002401
2402 u'patch_gerrit_url':
2403 u'https://chromium-review.googlesource.com',
2404 u'patch_issue': 123456,
2405 u'patch_project': u'depot_tools',
2406 u'patch_ref': u'refs/changes/56/123456/7',
2407 u'patch_repository_url':
2408 u'https://chromium.googlesource.com/depot_tools',
2409 u'patch_set': 7,
2410 u'patch_storage': u'gerrit',
2411 }
2412 })
2413 self.assertEqual(build, {
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002414 u'bucket': u'luci.chromium.try',
tandrii8c5a3532016-11-04 07:52:02 -07002415 u'client_operation_id': u'uuid4',
2416 u'tags': [
2417 u'builder:win',
2418 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2419 u'user_agent:git_cl_try',
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002420 ],
tandrii8c5a3532016-11-04 07:52:02 -07002421 })
2422
2423 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2424
2425 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2426 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002427 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002428 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2429 self.assertRegexpMatches(
2430 git_cl.sys.stdout.getvalue(),
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002431 'Tried jobs on:\nBucket: luci.chromium.try')
tandriide281ae2016-10-12 06:02:30 -07002432
qyearsley123a4682016-10-26 09:12:17 -07002433 def test_git_cl_try_bots_on_multiple_masters(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002434 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2435 self.mock(git_cl.Changelist, 'GetChange',
2436 lambda _, *a: (
2437 self._mocked_call(['GetChange']+list(a))))
2438 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2439 lambda *_, **__: (
2440 self._mocked_call(['DoGetTryMasters'])))
2441 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2442 lambda _, s: self._mocked_call(['SetCQState', s]))
2443
qyearsley123a4682016-10-26 09:12:17 -07002444 self.calls = [
2445 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002446 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2447 ((['git', 'config', 'branch.feature.gerritserver'],),
2448 'https://chromium-review.googlesource.com'),
2449 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2450 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2451 ((['git', 'config', 'remote.origin.url'],),
2452 'https://chromium.googlesource.com/depot_tools'),
2453 (('GetChangeDetail', 'chromium-review.googlesource.com',
2454 'depot_tools~123456',
2455 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2456 'project': 'depot_tools',
2457 'status': 'OPEN',
2458 'owner': {'email': 'owner@e.mail'},
2459 'revisions': {
2460 'deadbeaf': {
2461 '_number': 6,
2462 },
2463 'beeeeeef': {
2464 '_number': 7,
2465 'fetch': {'http': {
2466 'url': 'https://chromium.googlesource.com/depot_tools',
2467 'ref': 'refs/changes/56/123456/7'
2468 }},
2469 },
2470 },
2471 }),
qyearsley123a4682016-10-26 09:12:17 -07002472 ]
2473
2474 def _buildbucket_retry(*_, **kw):
2475 body = json.loads(kw['body'])
2476 self.assertEqual(len(body['builds']), 2)
2477
Nodir Turakulovb422e682018-02-20 22:51:30 -08002478 self.assertEqual(body['builds'][0]['bucket'], 'bucket1')
2479 params = json.loads(body['builds'][0]['parameters_json'])
2480 self.assertEqual(params['builder_name'], 'builder1')
qyearsley123a4682016-10-26 09:12:17 -07002481
Nodir Turakulovb422e682018-02-20 22:51:30 -08002482 self.assertEqual(body['builds'][1]['bucket'], 'bucket2')
2483 params = json.loads(body['builds'][1]['parameters_json'])
2484 self.assertEqual(params['builder_name'], 'builder2')
qyearsley123a4682016-10-26 09:12:17 -07002485
2486 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2487
2488 self.mock(git_cl.urllib2, 'urlopen', lambda _: StringIO.StringIO(
Nodir Turakulovb422e682018-02-20 22:51:30 -08002489 json.dumps({
2490 'builder1': {'bucket': 'bucket1'},
2491 'builder2': {'bucket': 'bucket2'},
2492 })))
qyearsley123a4682016-10-26 09:12:17 -07002493
2494 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2495 self.assertEqual(
2496 0, git_cl.main(['try', '-b', 'builder1', '-b', 'builder2']))
2497 self.assertEqual(
2498 git_cl.sys.stdout.getvalue(),
2499 'Tried jobs on:\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002500 'Bucket: bucket1\n'
qyearsley123a4682016-10-26 09:12:17 -07002501 ' builder1: []\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002502 'Bucket: bucket2\n'
qyearsley123a4682016-10-26 09:12:17 -07002503 ' builder2: []\n'
2504 'To see results here, run: git cl try-results\n'
2505 'To see results in browser, run: git cl web\n')
2506
tandrii16e0b4e2016-06-07 10:34:28 -07002507 def _common_GerritCommitMsgHookCheck(self):
2508 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2509 self.mock(git_cl.os.path, 'abspath',
2510 lambda path: self._mocked_call(['abspath', path]))
2511 self.mock(git_cl.os.path, 'exists',
2512 lambda path: self._mocked_call(['exists', path]))
2513 self.mock(git_cl.gclient_utils, 'FileRead',
2514 lambda path: self._mocked_call(['FileRead', path]))
2515 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2516 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2517 self.calls = [
2518 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2519 ((['abspath', '../'],), '/abs/git_repo_root'),
2520 ]
2521 return git_cl.Changelist(codereview='gerrit', issue=123)
2522
2523 def test_GerritCommitMsgHookCheck_custom_hook(self):
2524 cl = self._common_GerritCommitMsgHookCheck()
2525 self.calls += [
2526 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2527 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2528 '#!/bin/sh\necho "custom hook"')
2529 ]
2530 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2531
2532 def test_GerritCommitMsgHookCheck_not_exists(self):
2533 cl = self._common_GerritCommitMsgHookCheck()
2534 self.calls += [
2535 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2536 ]
2537 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2538
2539 def test_GerritCommitMsgHookCheck(self):
2540 cl = self._common_GerritCommitMsgHookCheck()
2541 self.calls += [
2542 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2543 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2544 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002545 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002546 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2547 ''),
2548 ]
2549 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2550
tandriic4344b52016-08-29 06:04:54 -07002551 def test_GerritCmdLand(self):
2552 self.calls += [
2553 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2554 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2555 'deadbeaf'),
2556 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2557 ((['git', 'config', 'branch.feature.gerritserver'],),
2558 'chromium-review.googlesource.com'),
2559 ]
2560 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2561 cl._codereview_impl._GetChangeDetail = lambda _: {
2562 'labels': {},
2563 'current_revision': 'deadbeaf',
2564 }
agable32978d92016-11-01 12:55:02 -07002565 cl._codereview_impl._GetChangeCommit = lambda: {
2566 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002567 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002568 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2569 }
tandriic4344b52016-08-29 06:04:54 -07002570 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002571 out = StringIO.StringIO()
2572 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002573 self.assertEqual(0, cl.CMDLand(force=True,
2574 bypass_hooks=True,
2575 verbose=True,
2576 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002577 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002578 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002579
tandrii221ab252016-10-06 08:12:04 -07002580 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002581 '9000': {
2582 'id': '9000',
2583 'bucket': 'master.x.y',
2584 'created_by': 'user:someone@chromium.org',
2585 'created_ts': '147200002222000',
2586 'experimental': False,
2587 'parameters_json': json.dumps({
2588 'builder_name': 'my-bot',
2589 'properties': {'category': 'cq'},
2590 }),
2591 'status': 'STARTED',
2592 'tags': [
2593 'build_address:x.y/my-bot/2',
2594 'builder:my-bot',
2595 'experimental:false',
2596 'user_agent:cq',
2597 ],
2598 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2599 },
2600 '8000': {
2601 'id': '8000',
2602 'bucket': 'master.x.y',
2603 'created_by': 'user:someone@chromium.org',
2604 'created_ts': '147200001111000',
2605 'experimental': False,
2606 'failure_reason': 'BUILD_FAILURE',
2607 'parameters_json': json.dumps({
2608 'builder_name': 'my-bot',
2609 'properties': {'category': 'cq'},
2610 }),
2611 'result_details_json': json.dumps({
2612 'properties': {'buildnumber': 1},
2613 }),
2614 'result': 'FAILURE',
2615 'status': 'COMPLETED',
2616 'tags': [
2617 'build_address:x.y/my-bot/1',
2618 'builder:my-bot',
2619 'experimental:false',
2620 'user_agent:cq',
2621 ],
2622 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2623 },
2624 }
tandrii221ab252016-10-06 08:12:04 -07002625
2626 def test_write_try_results_json(self):
2627 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002628 {
2629 'bucket': 'master.x.y',
2630 'buildbucket_id': '8000',
2631 'builder_name': 'my-bot',
2632 'created_ts': '147200001111000',
2633 'experimental': False,
2634 'failure_reason': 'BUILD_FAILURE',
2635 'result': 'FAILURE',
2636 'status': 'COMPLETED',
2637 'tags': [
2638 'build_address:x.y/my-bot/1',
2639 'builder:my-bot',
2640 'experimental:false',
2641 'user_agent:cq',
2642 ],
2643 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2644 },
2645 {
2646 'bucket': 'master.x.y',
2647 'buildbucket_id': '9000',
2648 'builder_name': 'my-bot',
2649 'created_ts': '147200002222000',
2650 'experimental': False,
2651 'failure_reason': None,
2652 'result': None,
2653 'status': 'STARTED',
2654 'tags': [
2655 'build_address:x.y/my-bot/2',
2656 'builder:my-bot',
2657 'experimental:false',
2658 'user_agent:cq',
2659 ],
2660 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2661 },
tandrii221ab252016-10-06 08:12:04 -07002662 ]
2663 self.calls = [(('write_json', 'output.json', expected_output), '')]
2664 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2665
tandrii45b2a582016-10-11 03:14:16 -07002666 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002667 out = StringIO.StringIO()
2668 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002669 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2670 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002671 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2672 self._mocked_call(['get_authenticator_for_host', host]))
2673 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2674 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002675
tandrii45b2a582016-10-11 03:14:16 -07002676 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2677 self._setup_fetch_try_jobs(most_recent_patchset=13)
2678 self.calls += [
2679 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii45b2a582016-10-11 03:14:16 -07002680 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002681 # TODO(tandrii): Uncomment the below if we decide to support checking
2682 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002683 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002684 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002685 ((['git', 'config', 'branch.feature.gerritserver'],),
2686 'https://x-review.googlesource.com'),
2687 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2688 AuthenticatorMock()),
2689 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2690
2691 def test_fetch_try_jobs_none_gerrit(self):
2692 self._setup_fetch_try_jobs_gerrit({})
2693 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002694 # TODO(tandrii): Uncomment the below if we decide to support checking
2695 # patchsets for Gerrit.
2696 # self.assertRegexpMatches(
2697 # sys.stdout.getvalue(),
2698 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07002699 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2700
2701 def test_fetch_try_jobs_some_gerrit(self):
2702 self._setup_fetch_try_jobs_gerrit({
2703 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2704 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002705 # TODO(tandrii): Uncomment the below if we decide to support checking
2706 # patchsets for Gerrit.
2707 # self.calls.remove(
2708 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002709 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2710
2711 # ... and doesn't result in warning.
2712 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2713 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002714 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2715 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2716
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002717 def _mock_gerrit_changes_for_detail_cache(self):
2718 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002719
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002720 def test_gerrit_change_detail_cache_simple(self):
2721 self._mock_gerrit_changes_for_detail_cache()
2722 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002723 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2724 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2725 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002726 ]
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002727 cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002728 cl1._cached_remote_url = (
2729 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002730 cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002731 cl2._cached_remote_url = (
2732 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002733 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2734 self.assertEqual(cl1._GetChangeDetail(), 'a')
2735 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2736 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2737 self.assertEqual(cl1._GetChangeDetail(), 'a')
2738 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002739
2740 def test_gerrit_change_detail_cache_options(self):
2741 self._mock_gerrit_changes_for_detail_cache()
2742 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002743 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2744 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2745 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2746 # no longer in cache.
2747 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002748 ]
2749 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002750 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002751 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2752 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2753 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2754 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2755 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2756 self.assertEqual(cl._GetChangeDetail(), 'cab')
2757
2758 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2759 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2760 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2761 self.assertEqual(cl._GetChangeDetail(), 'cab')
2762
2763 # Finally, no_cache should invalidate all caches for given change.
2764 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2765 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2766
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002767 def test_gerrit_description_caching(self):
2768 def gen_detail(rev, desc):
2769 return {
2770 'current_revision': rev,
2771 'revisions': {rev: {'commit': {'message': desc}}}
2772 }
2773 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002774 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002775 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2776 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002777 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002778 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2779 gen_detail('rev2', 'desc2')),
2780 ]
2781
2782 self._mock_gerrit_changes_for_detail_cache()
2783 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002784 cl._cached_remote_url = (
2785 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002786 self.assertEqual(cl.GetDescription(), 'desc1')
2787 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2788 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002789
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002790 def test_print_current_creds(self):
2791 class CookiesAuthenticatorMock(object):
2792 def __init__(self):
2793 self.gitcookies = {
2794 'host.googlesource.com': ('user', 'pass'),
2795 'host-review.googlesource.com': ('user', 'pass'),
2796 }
2797 self.netrc = self
2798 self.netrc.hosts = {
2799 'github.com': ('user2', None, 'pass2'),
2800 'host2.googlesource.com': ('user3', None, 'pass'),
2801 }
2802 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2803 CookiesAuthenticatorMock)
2804 self.mock(sys, 'stdout', StringIO.StringIO())
2805 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2806 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2807 ' Host\t User\t Which file',
2808 '============================\t=====\t===========',
2809 'host-review.googlesource.com\t user\t.gitcookies',
2810 ' host.googlesource.com\t user\t.gitcookies',
2811 ' host2.googlesource.com\tuser3\t .netrc',
2812 ])
2813 sys.stdout.buf = ''
2814 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2815 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2816 ' Host\tUser\t Which file',
2817 '============================\t====\t===========',
2818 'host-review.googlesource.com\tuser\t.gitcookies',
2819 ' host.googlesource.com\tuser\t.gitcookies',
2820 ])
2821
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002822 def _common_creds_check_mocks(self):
2823 def exists_mock(path):
2824 dirname = os.path.dirname(path)
2825 if dirname == os.path.expanduser('~'):
2826 dirname = '~'
2827 base = os.path.basename(path)
2828 if base in ('.netrc', '.gitcookies'):
2829 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2830 # git cl also checks for existence other files not relevant to this test.
2831 return None
2832 self.mock(os.path, 'exists', exists_mock)
2833 self.mock(sys, 'stdout', StringIO.StringIO())
2834
2835 def test_creds_check_gitcookies_not_configured(self):
2836 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002837 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002838 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002839 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002840 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002841 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2842 (('os.path.exists', '~/.netrc'), True),
2843 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2844 'or Ctrl+C to abort'), ''),
2845 ((['git', 'config', '--global', 'http.cookiefile',
2846 os.path.expanduser('~/.gitcookies')], ), ''),
2847 ]
2848 self.assertEqual(0, git_cl.main(['creds-check']))
2849 self.assertRegexpMatches(
2850 sys.stdout.getvalue(),
2851 '^You seem to be using outdated .netrc for git credentials:')
2852 self.assertRegexpMatches(
2853 sys.stdout.getvalue(),
2854 '\nConfigured git to use .gitcookies from')
2855
2856 def test_creds_check_gitcookies_configured_custom_broken(self):
2857 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002858 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002859 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002860 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002861 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002862 ((['git', 'config', '--global', 'http.cookiefile'],),
2863 '/custom/.gitcookies'),
2864 (('os.path.exists', '/custom/.gitcookies'), False),
2865 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2866 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2867 ((['git', 'config', '--global', 'http.cookiefile',
2868 os.path.expanduser('~/.gitcookies')], ), ''),
2869 ]
2870 self.assertEqual(0, git_cl.main(['creds-check']))
2871 self.assertRegexpMatches(
2872 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002873 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002874 self.assertRegexpMatches(
2875 sys.stdout.getvalue(),
2876 'However, your configured .gitcookies file is missing.')
2877
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002878 def test_git_cl_comment_add_gerrit(self):
2879 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002880 lambda host, change, msg, ready:
2881 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002882 self.calls = [
2883 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2884 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2885 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2886 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2887 'origin/master'),
2888 ((['git', 'config', 'remote.origin.url'],),
2889 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002890 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2891 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002892 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002893 ]
2894 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2895 '-a', 'msg']))
2896
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002897 def test_git_cl_comments_fetch_gerrit(self):
2898 self.mock(sys, 'stdout', StringIO.StringIO())
2899 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002900 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2901 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002902 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2903 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2904 'origin/master'),
2905 ((['git', 'config', 'remote.origin.url'],),
2906 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002907 (('GetChangeDetail', 'chromium-review.googlesource.com',
2908 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002909 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2910 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002911 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002912 'current_revision': 'ba5eba11',
2913 'revisions': {
2914 'deadbeaf': {
2915 '_number': 1,
2916 },
2917 'ba5eba11': {
2918 '_number': 2,
2919 },
2920 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002921 'messages': [
2922 {
2923 u'_revision_number': 1,
2924 u'author': {
2925 u'_account_id': 1111084,
2926 u'email': u'commit-bot@chromium.org',
2927 u'name': u'Commit Bot'
2928 },
2929 u'date': u'2017-03-15 20:08:45.000000000',
2930 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002931 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002932 u'tag': u'autogenerated:cq:dry-run'
2933 },
2934 {
2935 u'_revision_number': 2,
2936 u'author': {
2937 u'_account_id': 11151243,
2938 u'email': u'owner@example.com',
2939 u'name': u'owner'
2940 },
2941 u'date': u'2017-03-16 20:00:41.000000000',
2942 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2943 u'message': u'PTAL',
2944 },
2945 {
2946 u'_revision_number': 2,
2947 u'author': {
2948 u'_account_id': 148512 ,
2949 u'email': u'reviewer@example.com',
2950 u'name': u'reviewer'
2951 },
2952 u'date': u'2017-03-17 05:19:37.500000000',
2953 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2954 u'message': u'Patch Set 2: Code-Review+1',
2955 },
2956 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002957 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002958 (('GetChangeComments', 'chromium-review.googlesource.com',
2959 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002960 '/COMMIT_MSG': [
2961 {
2962 'author': {'email': u'reviewer@example.com'},
2963 'updated': u'2017-03-17 05:19:37.500000000',
2964 'patch_set': 2,
2965 'side': 'REVISION',
2966 'message': 'Please include a bug link',
2967 },
2968 ],
2969 'codereview.settings': [
2970 {
2971 'author': {'email': u'owner@example.com'},
2972 'updated': u'2017-03-16 20:00:41.000000000',
2973 'patch_set': 2,
2974 'side': 'PARENT',
2975 'line': 42,
2976 'message': 'I removed this because it is bad',
2977 },
2978 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002979 }),
2980 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2981 'infra%2Finfra~1'), {}),
2982 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002983 ] * 2 + [
2984 (('write_json', 'output.json', [
2985 {
2986 u'date': u'2017-03-16 20:00:41.000000',
2987 u'message': (
2988 u'PTAL\n' +
2989 u'\n' +
2990 u'codereview.settings\n' +
2991 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2992 u'c/1/2/codereview.settings#b42\n' +
2993 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002994 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002995 u'approval': False,
2996 u'disapproval': False,
2997 u'sender': u'owner@example.com'
2998 }, {
2999 u'date': u'2017-03-17 05:19:37.500000',
3000 u'message': (
3001 u'Patch Set 2: Code-Review+1\n' +
3002 u'\n' +
3003 u'/COMMIT_MSG\n' +
3004 u' PS2, File comment: https://chromium-review.googlesource' +
3005 u'.com/c/1/2//COMMIT_MSG#\n' +
3006 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003007 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00003008 u'approval': False,
3009 u'disapproval': False,
3010 u'sender': u'reviewer@example.com'
3011 }
3012 ]),'')
3013 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003014 expected_comments_summary = [
3015 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003016 message=(
3017 u'PTAL\n' +
3018 u'\n' +
3019 u'codereview.settings\n' +
3020 u' Base, Line 42: https://chromium-review.googlesource.com/' +
3021 u'c/1/2/codereview.settings#b42\n' +
3022 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003023 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003024 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003025 disapproval=False, approval=False, sender=u'owner@example.com'),
3026 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003027 message=(
3028 u'Patch Set 2: Code-Review+1\n' +
3029 u'\n' +
3030 u'/COMMIT_MSG\n' +
3031 u' PS2, File comment: https://chromium-review.googlesource.com/' +
3032 u'c/1/2//COMMIT_MSG#\n' +
3033 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003034 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003035 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003036 disapproval=False, approval=False, sender=u'reviewer@example.com'),
3037 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003038 cl = git_cl.Changelist(
3039 codereview='gerrit', issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003040 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003041 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
3042 self.assertEqual(
3043 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
3044
3045 def test_git_cl_comments_robot_comments(self):
3046 # git cl comments also fetches robot comments (which are considered a type
3047 # of autogenerated comment), and unlike other types of comments, only robot
3048 # comments from the latest patchset are shown.
3049 self.mock(sys, 'stdout', StringIO.StringIO())
3050 self.calls = [
3051 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
3052 ((['git', 'config', 'branch.foo.merge'],), ''),
3053 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3054 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3055 'origin/master'),
3056 ((['git', 'config', 'remote.origin.url'],),
3057 'https://chromium.googlesource.com/infra/infra'),
3058 (('GetChangeDetail', 'chromium-review.googlesource.com',
3059 'infra%2Finfra~1',
3060 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
3061 'CURRENT_COMMIT']), {
3062 'owner': {'email': 'owner@example.com'},
3063 'current_revision': 'ba5eba11',
3064 'revisions': {
3065 'deadbeaf': {
3066 '_number': 1,
3067 },
3068 'ba5eba11': {
3069 '_number': 2,
3070 },
3071 },
3072 'messages': [
3073 {
3074 u'_revision_number': 1,
3075 u'author': {
3076 u'_account_id': 1111084,
3077 u'email': u'commit-bot@chromium.org',
3078 u'name': u'Commit Bot'
3079 },
3080 u'date': u'2017-03-15 20:08:45.000000000',
3081 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
3082 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
3083 u'tag': u'autogenerated:cq:dry-run'
3084 },
3085 {
3086 u'_revision_number': 1,
3087 u'author': {
3088 u'_account_id': 123,
3089 u'email': u'tricium@serviceaccount.com',
3090 u'name': u'Tricium'
3091 },
3092 u'date': u'2017-03-16 20:00:41.000000000',
3093 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3094 u'message': u'(1 comment)',
3095 u'tag': u'autogenerated:tricium',
3096 },
3097 {
3098 u'_revision_number': 1,
3099 u'author': {
3100 u'_account_id': 123,
3101 u'email': u'tricium@serviceaccount.com',
3102 u'name': u'Tricium'
3103 },
3104 u'date': u'2017-03-16 20:00:41.000000000',
3105 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3106 u'message': u'(1 comment)',
3107 u'tag': u'autogenerated:tricium',
3108 },
3109 {
3110 u'_revision_number': 2,
3111 u'author': {
3112 u'_account_id': 123 ,
3113 u'email': u'tricium@serviceaccount.com',
3114 u'name': u'reviewer'
3115 },
3116 u'date': u'2017-03-17 05:30:37.000000000',
3117 u'tag': u'autogenerated:tricium',
3118 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
3119 u'message': u'(1 comment)',
3120 },
3121 ]
3122 }),
3123 (('GetChangeComments', 'chromium-review.googlesource.com',
3124 'infra%2Finfra~1'), {}),
3125 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
3126 'infra%2Finfra~1'), {
3127 'codereview.settings': [
3128 {
3129 u'author': {u'email': u'tricium@serviceaccount.com'},
3130 u'updated': u'2017-03-17 05:30:37.000000000',
3131 u'robot_run_id': u'5565031076855808',
3132 u'robot_id': u'Linter/Category',
3133 u'tag': u'autogenerated:tricium',
3134 u'patch_set': 2,
3135 u'side': u'REVISION',
3136 u'message': u'Linter warning message text',
3137 u'line': 32,
3138 },
3139 ],
3140 }),
3141 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
3142 ]
3143 expected_comments_summary = [
3144 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
3145 message=(
3146 u'(1 comment)\n\ncodereview.settings\n'
3147 u' PS2, Line 32: https://chromium-review.googlesource.com/'
3148 u'c/1/2/codereview.settings#32\n'
3149 u' Linter warning message text\n'),
3150 sender=u'tricium@serviceaccount.com',
3151 autogenerated=True, approval=False, disapproval=False)
3152 ]
3153 cl = git_cl.Changelist(
3154 codereview='gerrit', issue=1, branchref='refs/heads/foo')
3155 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003156
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003157 def test_get_remote_url_with_mirror(self):
3158 original_os_path_isdir = os.path.isdir
3159 def selective_os_path_isdir_mock(path):
3160 if path == '/cache/this-dir-exists':
3161 return self._mocked_call('os.path.isdir', path)
3162 return original_os_path_isdir(path)
3163 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3164
3165 url = 'https://chromium.googlesource.com/my/repo'
3166 self.calls = [
3167 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3168 ((['git', 'config', 'branch.master.merge'],), 'master'),
3169 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3170 ((['git', 'config', 'remote.origin.url'],),
3171 '/cache/this-dir-exists'),
3172 (('os.path.isdir', '/cache/this-dir-exists'),
3173 True),
3174 # Runs in /cache/this-dir-exists.
3175 ((['git', 'config', 'remote.origin.url'],),
3176 url),
3177 ]
3178 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3179 self.assertEqual(cl.GetRemoteUrl(), url)
3180 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3181
Edward Lemur298f2cf2019-02-22 21:40:39 +00003182 def test_get_remote_url_non_existing_mirror(self):
3183 original_os_path_isdir = os.path.isdir
3184 def selective_os_path_isdir_mock(path):
3185 if path == '/cache/this-dir-doesnt-exist':
3186 return self._mocked_call('os.path.isdir', path)
3187 return original_os_path_isdir(path)
3188 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3189 self.mock(logging, 'error',
3190 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
3191
3192 self.calls = [
3193 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3194 ((['git', 'config', 'branch.master.merge'],), 'master'),
3195 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3196 ((['git', 'config', 'remote.origin.url'],),
3197 '/cache/this-dir-doesnt-exist'),
3198 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3199 False),
3200 (('logging.error',
3201 'Remote "origin" for branch "/cache/this-dir-doesnt-exist" points to'
3202 ' "master", but it doesn\'t exist.'), None),
3203 ]
3204 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3205 self.assertIsNone(cl.GetRemoteUrl())
3206
3207 def test_get_remote_url_misconfigured_mirror(self):
3208 original_os_path_isdir = os.path.isdir
3209 def selective_os_path_isdir_mock(path):
3210 if path == '/cache/this-dir-exists':
3211 return self._mocked_call('os.path.isdir', path)
3212 return original_os_path_isdir(path)
3213 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3214 self.mock(logging, 'error',
3215 lambda *a: self._mocked_call('logging.error', *a))
3216
3217 self.calls = [
3218 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3219 ((['git', 'config', 'branch.master.merge'],), 'master'),
3220 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3221 ((['git', 'config', 'remote.origin.url'],),
3222 '/cache/this-dir-exists'),
3223 (('os.path.isdir', '/cache/this-dir-exists'), True),
3224 # Runs in /cache/this-dir-exists.
3225 ((['git', 'config', 'remote.origin.url'],), ''),
3226 (('logging.error',
3227 'Remote "%(remote)s" for branch "%(branch)s" points to '
3228 '"%(cache_path)s", but it is misconfigured.\n'
3229 '"%(cache_path)s" must be a git repo and must have a remote named '
3230 '"%(remote)s" pointing to the git host.', {
3231 'remote': 'origin',
3232 'cache_path': '/cache/this-dir-exists',
3233 'branch': 'master'}
3234 ), None),
3235 ]
3236 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3237 self.assertIsNone(cl.GetRemoteUrl())
3238
3239
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003240 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003241 self.calls = [
3242 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3243 ((['git', 'config', 'branch.master.merge'],), 'master'),
3244 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3245 ((['git', 'config', 'remote.origin.url'],),
3246 'https://chromium.googlesource.com/a/my/repo.git/'),
3247 ]
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003248 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3249 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3250
3251 def test_gerrit_change_identifier_without_project(self):
3252 self.calls = [
3253 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3254 ((['git', 'config', 'branch.master.merge'],), 'master'),
3255 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3256 ((['git', 'config', 'remote.origin.url'],), CERR1),
3257 ]
3258 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3259 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003260
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003261
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003262if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003263 logging.basicConfig(
3264 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003265 unittest.main()