blob: 90a31534a375801bc2ae2627ec7a74099a266eec [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01009import datetime
tandriide281ae2016-10-12 06:02:30 -070010import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010011import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000012import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
22
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000023import metrics
24# We have to disable monitoring before importing git_cl.
25metrics.DISABLE_METRICS_COLLECTION = True
26
Eric Boren2fb63102018-10-05 13:05:03 +000027import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000028import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000029import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000030import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
65 desc = ""
66 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
skobes6468b902016-10-24 08:45:10 -070086class GitCheckoutMock(object):
87 def __init__(self, *args, **kwargs):
88 pass
89
90 @staticmethod
91 def reset():
92 GitCheckoutMock.conflict = False
93
94 def apply_patch(self, p):
95 if GitCheckoutMock.conflict:
96 raise Exception('failed')
97
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000098
99class WatchlistsMock(object):
100 def __init__(self, _):
101 pass
102 @staticmethod
103 def GetWatchersForPaths(_):
104 return ['joe@example.com']
105
106
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000107class CodereviewSettingsFileMock(object):
108 def __init__(self):
109 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800110 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000111 def read(self):
112 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000113 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000114
115
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000116class AuthenticatorMock(object):
117 def __init__(self, *_args):
118 pass
119 def has_cached_credentials(self):
120 return True
tandrii221ab252016-10-06 08:12:04 -0700121 def authorize(self, http):
122 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000123
124
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100125def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
127
128 Usage:
129 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100130 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000131
132 OR
133 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100134 CookiesAuthenticatorMockFactory(
135 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000136 """
137 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800138 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139 # Intentionally not calling super() because it reads actual cookie files.
140 pass
141 @classmethod
142 def get_gitcookies_path(cls):
143 return '~/.gitcookies'
144 @classmethod
145 def get_netrc_path(cls):
146 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 def _get_auth_for_host(self, host):
148 if same_auth:
149 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000150 return (hosts_with_creds or {}).get(host)
151 return CookiesAuthenticatorMock
152
Aaron Gable9a03ae02017-11-03 11:31:07 -0700153
kmarshall9249e012016-08-23 12:02:16 -0700154class MockChangelistWithBranchAndIssue():
155 def __init__(self, branch, issue):
156 self.branch = branch
157 self.issue = issue
158 def GetBranch(self):
159 return self.branch
160 def GetIssue(self):
161 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162
tandriic2405f52016-10-10 08:13:15 -0700163
164class SystemExitMock(Exception):
165 pass
166
167
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000168class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100169 def test_get_description(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000170 cl = git_cl.Changelist(issue=1, codereview='gerrit',
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100171 codereview_host='host')
172 cl.description = 'x'
173 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800174 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100175 self.assertEquals(cl.GetDescription(), 'x')
176 self.assertEquals(cl.GetDescription(force=True), 'y')
177 self.assertEquals(cl.GetDescription(), 'y')
178
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700179 def test_description_footers(self):
180 cl = git_cl.Changelist(issue=1, codereview='gerrit',
181 codereview_host='host')
182 cl.description = '\n'.join([
183 'This is some message',
184 '',
185 'It has some lines',
186 'and, also',
187 '',
188 'Some: Really',
189 'Awesome: Footers',
190 ])
191 cl.has_description = True
192 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
193 msg, footers = cl.GetDescriptionFooters()
194 self.assertEquals(
195 msg, ['This is some message', '', 'It has some lines', 'and, also'])
196 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
197
198 msg.append('wut')
199 footers.append(('gnarly-dude', 'beans'))
200 cl.UpdateDescriptionFooters(msg, footers)
201 self.assertEquals(cl.GetDescription().splitlines(), [
202 'This is some message',
203 '',
204 'It has some lines',
205 'and, also',
206 'wut'
207 '',
208 'Some: Really',
209 'Awesome: Footers',
210 'Gnarly-Dude: beans',
211 ])
212
tandriif9aefb72016-07-01 09:06:51 -0700213 def test_get_bug_line_values(self):
214 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
215 self.assertEqual(f('', ''), [])
216 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
217 self.assertEqual(f('v8', '456'), ['v8:456'])
218 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
219 # Not nice, but not worth carying.
220 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
221 ['v8:456', 'chromium:123', 'v8:123'])
222
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100223 def _test_git_number(self, parent_msg, dest_ref, child_msg,
224 parent_hash='parenthash'):
225 desc = git_cl.ChangeDescription(child_msg)
226 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
227 return desc.description
228
229 def assertEqualByLine(self, actual, expected):
230 self.assertEqual(actual.splitlines(), expected.splitlines())
231
232 def test_git_number_bad_parent(self):
233 with self.assertRaises(ValueError):
234 self._test_git_number('Parent', 'refs/heads/master', 'Child')
235
236 def test_git_number_bad_parent_footer(self):
237 with self.assertRaises(AssertionError):
238 self._test_git_number(
239 'Parent\n'
240 '\n'
241 'Cr-Commit-Position: wrong',
242 'refs/heads/master', 'Child')
243
244 def test_git_number_bad_lineage_ignored(self):
245 actual = self._test_git_number(
246 'Parent\n'
247 '\n'
248 'Cr-Commit-Position: refs/heads/master@{#1}\n'
249 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
250 'refs/heads/master', 'Child')
251 self.assertEqualByLine(
252 actual,
253 'Child\n'
254 '\n'
255 'Cr-Commit-Position: refs/heads/master@{#2}\n'
256 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
257
258 def test_git_number_same_branch(self):
259 actual = self._test_git_number(
260 'Parent\n'
261 '\n'
262 'Cr-Commit-Position: refs/heads/master@{#12}',
263 dest_ref='refs/heads/master',
264 child_msg='Child')
265 self.assertEqualByLine(
266 actual,
267 'Child\n'
268 '\n'
269 'Cr-Commit-Position: refs/heads/master@{#13}')
270
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200271 def test_git_number_same_branch_mixed_footers(self):
272 actual = self._test_git_number(
273 'Parent\n'
274 '\n'
275 'Cr-Commit-Position: refs/heads/master@{#12}',
276 dest_ref='refs/heads/master',
277 child_msg='Child\n'
278 '\n'
279 'Broken-by: design\n'
280 'BUG=123')
281 self.assertEqualByLine(
282 actual,
283 'Child\n'
284 '\n'
285 'Broken-by: design\n'
286 'BUG=123\n'
287 'Cr-Commit-Position: refs/heads/master@{#13}')
288
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100289 def test_git_number_same_branch_with_originals(self):
290 actual = self._test_git_number(
291 'Parent\n'
292 '\n'
293 'Cr-Commit-Position: refs/heads/master@{#12}',
294 dest_ref='refs/heads/master',
295 child_msg='Child\n'
296 '\n'
297 'Some users are smart and insert their own footers\n'
298 '\n'
299 'Cr-Whatever: value\n'
300 'Cr-Commit-Position: refs/copy/paste@{#22}')
301 self.assertEqualByLine(
302 actual,
303 'Child\n'
304 '\n'
305 'Some users are smart and insert their own footers\n'
306 '\n'
307 'Cr-Original-Whatever: value\n'
308 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
309 'Cr-Commit-Position: refs/heads/master@{#13}')
310
311 def test_git_number_new_branch(self):
312 actual = self._test_git_number(
313 'Parent\n'
314 '\n'
315 'Cr-Commit-Position: refs/heads/master@{#12}',
316 dest_ref='refs/heads/branch',
317 child_msg='Child')
318 self.assertEqualByLine(
319 actual,
320 'Child\n'
321 '\n'
322 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
323 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
324
325 def test_git_number_lineage(self):
326 actual = self._test_git_number(
327 'Parent\n'
328 '\n'
329 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
330 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
331 dest_ref='refs/heads/branch',
332 child_msg='Child')
333 self.assertEqualByLine(
334 actual,
335 'Child\n'
336 '\n'
337 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
338 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
339
340 def test_git_number_moooooooore_lineage(self):
341 actual = self._test_git_number(
342 'Parent\n'
343 '\n'
344 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
345 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
346 dest_ref='refs/heads/mooore',
347 child_msg='Child')
348 self.assertEqualByLine(
349 actual,
350 'Child\n'
351 '\n'
352 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
353 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
354 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
355
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100356 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700357 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100358 actual = self._test_git_number(
359 'CQ commit on fresh new branch + numbering.\n'
360 '\n'
361 'NOTRY=True\n'
362 'NOPRESUBMIT=True\n'
363 'BUG=\n'
364 '\n'
365 'Review-Url: https://codereview.chromium.org/2577703003\n'
366 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
367 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
368 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
369 dest_ref='refs/heads/gnumb-test/cl',
370 child_msg='git cl on fresh new branch + numbering.\n'
371 '\n'
372 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
373 self.assertEqualByLine(
374 actual,
375 'git cl on fresh new branch + numbering.\n'
376 '\n'
377 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
378 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
379 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
380 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
381 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100382
383 def test_git_number_cherry_pick(self):
384 actual = self._test_git_number(
385 'Parent\n'
386 '\n'
387 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
388 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
389 dest_ref='refs/heads/branch',
390 child_msg='Child, which is cherry-pick from master\n'
391 '\n'
392 'Cr-Commit-Position: refs/heads/master@{#100}\n'
393 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
394 self.assertEqualByLine(
395 actual,
396 'Child, which is cherry-pick from master\n'
397 '\n'
398 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
399 '\n'
400 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
401 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
402 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
403
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000404 def test_gerrit_mirror_hack(self):
405 cr = 'chromium-review.googlesource.com'
406 url0 = 'https://%s/a/changes/x?a=b' % cr
407 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
408 try:
409 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
410 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
411 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
412 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
413
414 self.assertNotEqual(url1, url2)
415 self.assertEqual(sorted((url1, url2)), [
416 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
417 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
418 self.assertEqual(url1, url3)
419 finally:
420 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
421
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000422 def test_valid_accounts(self):
423 mock_per_account = {
424 'u1': None, # 404, doesn't exist.
425 'u2': {
426 '_account_id': 123124,
427 'avatars': [],
428 'email': 'u2@example.com',
429 'name': 'User Number 2',
430 'status': 'OOO',
431 },
432 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
433 }
434 def GetAccountDetailsMock(_, account):
435 # Poor-man's mock library's side_effect.
436 v = mock_per_account.pop(account)
437 if isinstance(v, Exception):
438 raise v
439 return v
440
441 original = git_cl.gerrit_util.GetAccountDetails
442 try:
443 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
444 actual = git_cl.gerrit_util.ValidAccounts(
445 'host', ['u1', 'u2', 'u3'], max_threads=1)
446 finally:
447 git_cl.gerrit_util.GetAccountDetails = original
448 self.assertEqual(actual, {
449 'u2': {
450 '_account_id': 123124,
451 'avatars': [],
452 'email': 'u2@example.com',
453 'name': 'User Number 2',
454 'status': 'OOO',
455 },
456 })
457
458
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000459
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200460class TestParseIssueURL(unittest.TestCase):
461 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
462 codereview=None, fail=False):
463 self.assertIsNotNone(parsed)
464 if fail:
465 self.assertFalse(parsed.valid)
466 return
467 self.assertTrue(parsed.valid)
468 self.assertEqual(parsed.issue, issue)
469 self.assertEqual(parsed.patchset, patchset)
470 self.assertEqual(parsed.hostname, hostname)
471 self.assertEqual(parsed.codereview, codereview)
472
473 def _run_and_validate(self, func, url, *args, **kwargs):
474 result = func(urlparse.urlparse(url))
475 if kwargs.pop('fail', False):
476 self.assertIsNone(result)
477 return None
478 self._validate(result, *args, fail=False, **kwargs)
479
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480 def test_gerrit(self):
481 def test(url, issue=None, patchset=None, hostname=None, fail=None):
482 self._test_ParseIssueUrl(
483 git_cl._GerritChangelistImpl.ParseIssueURL,
484 url, issue, patchset, hostname, fail)
485 def test(url, *args, **kwargs):
486 self._run_and_validate(git_cl._GerritChangelistImpl.ParseIssueURL, url,
487 *args, codereview='gerrit', **kwargs)
488
489 test('http://chrome-review.source.com/c/123',
490 123, None, 'chrome-review.source.com')
491 test('https://chrome-review.source.com/c/123/',
492 123, None, 'chrome-review.source.com')
493 test('https://chrome-review.source.com/c/123/4',
494 123, 4, 'chrome-review.source.com')
495 test('https://chrome-review.source.com/#/c/123/4',
496 123, 4, 'chrome-review.source.com')
497 test('https://chrome-review.source.com/c/123/4',
498 123, 4, 'chrome-review.source.com')
499 test('https://chrome-review.source.com/123',
500 123, None, 'chrome-review.source.com')
501 test('https://chrome-review.source.com/123/4',
502 123, 4, 'chrome-review.source.com')
503
504 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
505 test('https://chrome-review.source.com/c/abc/', fail=True)
506 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
507
508 def test_ParseIssueNumberArgument(self):
509 def test(arg, *args, **kwargs):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200510 codereview_hint = kwargs.pop('hint', None)
511 self._validate(git_cl.ParseIssueNumberArgument(arg, codereview_hint),
512 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200513
514 test('123', 123)
515 test('', fail=True)
516 test('abc', fail=True)
517 test('123/1', fail=True)
518 test('123a', fail=True)
519 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000520
521 # Looks like Rietveld and Gerrit, but we should select Gerrit now
522 # w/ or w/o hint.
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200523 test('https://codereview.source.com/123',
524 123, None, 'codereview.source.com', 'gerrit',
525 hint='gerrit')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000526 test('https://codereview.source.com/123',
527 123, None, 'codereview.source.com', 'gerrit')
528
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200529 # Gerrrit.
530 test('https://chrome-review.source.com/c/123/4',
531 123, 4, 'chrome-review.source.com', 'gerrit')
532 test('https://chrome-review.source.com/bad/123/4', fail=True)
533
534
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100535class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100536 def setUp(self):
537 super(GitCookiesCheckerTest, self).setUp()
538 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100539 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100540
541 def mock_hosts_creds(self, subhost_identity_pairs):
542 def ensure_googlesource(h):
543 if not h.endswith(self.c._GOOGLESOURCE):
544 assert not h.endswith('.')
545 return h + '.' + self.c._GOOGLESOURCE
546 return h
547 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
548 for h, i in subhost_identity_pairs]
549
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200550 def test_identity_parsing(self):
551 self.assertEqual(self.c._parse_identity('ldap.google.com'),
552 ('ldap', 'google.com'))
553 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
554 ('ldap', 'example.com'))
555 # Specical case because we know there are no subdomains in chromium.org.
556 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
557 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800558 # Pathological: ".period." can be either username OR domain, more likely
559 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200560 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
561 ('note', 'period.example.com'))
562
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563 def test_analysis_nothing(self):
564 self.c._all_hosts = []
565 self.assertFalse(self.c.has_generic_host())
566 self.assertEqual(set(), self.c.get_conflicting_hosts())
567 self.assertEqual(set(), self.c.get_duplicated_hosts())
568 self.assertEqual(set(), self.c.get_partially_configured_hosts())
569 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
570
571 def test_analysis(self):
572 self.mock_hosts_creds([
573 ('.googlesource.com', 'git-example.chromium.org'),
574
575 ('chromium', 'git-example.google.com'),
576 ('chromium-review', 'git-example.google.com'),
577 ('chrome-internal', 'git-example.chromium.org'),
578 ('chrome-internal-review', 'git-example.chromium.org'),
579 ('conflict', 'git-example.google.com'),
580 ('conflict-review', 'git-example.chromium.org'),
581 ('dup', 'git-example.google.com'),
582 ('dup', 'git-example.google.com'),
583 ('dup-review', 'git-example.google.com'),
584 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200585 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100586 ])
587 self.assertTrue(self.c.has_generic_host())
588 self.assertEqual(set(['conflict.googlesource.com']),
589 self.c.get_conflicting_hosts())
590 self.assertEqual(set(['dup.googlesource.com']),
591 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200592 self.assertEqual(set(['partial.googlesource.com',
593 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100594 self.c.get_partially_configured_hosts())
595 self.assertEqual(set(['chromium.googlesource.com',
596 'chrome-internal.googlesource.com']),
597 self.c.get_hosts_with_wrong_identities())
598
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100599 def test_report_no_problems(self):
600 self.test_analysis_nothing()
601 self.mock(sys, 'stdout', StringIO.StringIO())
602 self.assertFalse(self.c.find_and_report_problems())
603 self.assertEqual(sys.stdout.getvalue(), '')
604
605 def test_report(self):
606 self.test_analysis()
607 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200608 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
609 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100610 self.assertTrue(self.c.find_and_report_problems())
611 with open(os.path.join(os.path.dirname(__file__),
612 'git_cl_creds_check_report.txt')) as f:
613 expected = f.read()
614 def by_line(text):
615 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700616 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200617 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100618
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800619
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000620class TestGitCl(TestCase):
621 def setUp(self):
622 super(TestGitCl, self).setUp()
623 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700624 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000625 self.mock(git_cl, 'time_time',
626 lambda: self._mocked_call('time.time'))
627 self.mock(git_cl.metrics.collector, 'add_repeated',
628 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000629 self.mock(subprocess2, 'call', self._mocked_call)
630 self.mock(subprocess2, 'check_call', self._mocked_call)
631 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700632 self.mock(subprocess2, 'communicate',
633 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000634 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000635 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000636 self.mock(git_common, 'get_or_create_merge_base',
637 lambda *a: (
638 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000639 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000640 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000641 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
642 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100643 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000644 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700645 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000646 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000647 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
skobes6468b902016-10-24 08:45:10 -0700648 self.mock(git_cl.checkout, 'GitCheckout', GitCheckoutMock)
649 GitCheckoutMock.reset()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000650 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000651 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100652 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
653 lambda *args, **kwargs: self._mocked_call(
654 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700655 self.mock(git_cl.gerrit_util, 'GetChangeComments',
656 lambda *args, **kwargs: self._mocked_call(
657 'GetChangeComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100658 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700659 lambda h, i, reviewers, ccs, notify: self._mocked_call(
660 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700661 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700662 lambda h, i, msg=None, labels=None, notify=None:
663 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700664 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
665 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000666 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
667 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000668 self.mock(git_cl.gerrit_util, 'ValidAccounts',
669 lambda host, accounts:
670 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700671 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100672 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000673 # It's important to reset settings to not have inter-tests interference.
674 git_cl.settings = None
675
676 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000677 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100678 self.assertEquals([], self.calls)
679 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000680 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100681 raise
682 # Sadly, has_failed() returns True if this OR any other tests before this
683 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200684 git_cl.logging.error(
685 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100686 'There are un-consumed self.calls after this test has finished.\n'
687 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700688 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200689 'If you are already running only this test, then **first** fix the '
690 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100691 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700692 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100693 'and follow instructions above.\n' +
694 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000695 finally:
696 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000697
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000698 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000699 self.assertTrue(
700 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700701 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000702 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000703 expected_args, result = top
704
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000705 # Also logs otherwise it could get caught in a try/finally and be hard to
706 # diagnose.
707 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700708 N = 5
709 prior_calls = '\n '.join(
710 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
711 for i, c in enumerate(self._calls_done[-N:]))
712 following_calls = '\n '.join(
713 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
714 for i, c in enumerate(self.calls[:N]))
715 extended_msg = (
716 'A few prior calls:\n %s\n\n'
717 'This (expected):\n @%d: %r\n'
718 'This (actual):\n @%d: %r\n\n'
719 'A few following expected calls:\n %s' %
720 (prior_calls, len(self._calls_done), expected_args,
721 len(self._calls_done), args, following_calls))
722 git_cl.logging.error(extended_msg)
723
tandrii99a72f22016-08-17 14:33:24 -0700724 self.fail('@%d\n'
725 ' Expected: %r\n'
726 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700727 len(self._calls_done), expected_args, args))
728
729 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700730 if isinstance(result, Exception):
731 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000732 return result
733
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100734 def test_ask_for_explicit_yes_true(self):
735 self.calls = [
736 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
737 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
738 ]
739 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
740
tandrii48df5812016-10-17 03:55:37 -0700741 def test_LoadCodereviewSettingsFromFile_gerrit(self):
742 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
743 self.calls = [
744 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
745 ((['git', 'config', '--unset-all', 'rietveld.private'],), CERR1),
746 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
747 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
748 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
749 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700750 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
751 CERR1),
752 ((['git', 'config', '--unset-all', 'rietveld.project'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700753 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
754 CERR1),
755 ((['git', 'config', 'gerrit.host', 'true'],), ''),
756 ]
757 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
758
maruel@chromium.orga3353652011-11-30 14:26:57 +0000759 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000760 def _is_gerrit_calls(cls, gerrit=False):
761 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
762 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
763
764 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000765 def _git_post_upload_calls(cls):
766 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000767 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
768 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
769 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000770 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000771 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000772 ]
773
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000774 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000775 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000776 fake_ancestor = 'fake_ancestor'
777 fake_cl = 'fake_cl_for_patch'
778 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000779 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000780 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000781 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000782 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000783 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000784 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000785 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000786 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700787 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000788 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000789 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000790 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000791 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000792 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000793 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000794 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000795 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000796 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000797 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000798 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000799
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000800 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000801 def _gerrit_ensure_auth_calls(
802 cls, issue=None, skip_auth_check=False, short_hostname='chromium'):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000803 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000804 if skip_auth_check:
805 return [((cmd, ), 'true')]
806
tandrii5d48c322016-08-18 16:19:37 -0700807 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000808 if issue:
809 calls.extend([
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100810 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000811 ])
812 calls.extend([
813 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
814 ((['git', 'config', 'branch.master.remote'],), 'origin'),
815 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000816 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000817 ])
818 return calls
819
820 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100821 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200822 fetched_status=None, other_cl_owner=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000823 custom_cl_base=None, short_hostname='chromium'):
Aaron Gable13101a62018-02-09 13:20:41 -0800824 calls = cls._is_gerrit_calls(True)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100825 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200826 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200827 ((['git', 'config', 'branch.master.gerritissue'],),
828 CERR1 if issue is None else str(issue)),
829 ]
830
831 if custom_cl_base:
832 ancestor_revision = custom_cl_base
833 else:
834 # Determine ancestor_revision to be merge base.
835 ancestor_revision = 'fake_ancestor_sha'
836 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000837 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000838 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000839 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200840 'refs/remotes/origin/master'],), ancestor_revision),
841 ]
842
843 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000844 calls += cls._gerrit_ensure_auth_calls(
845 issue=issue, short_hostname=short_hostname)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100846
847 if issue:
848 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000849 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000850 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000851 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
852 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100853 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100854 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100855 'change_id': '123456789',
856 'current_revision': 'sha1_of_current_revision',
857 'revisions': { 'sha1_of_current_revision': {
858 'commit': {'message': fetched_description},
859 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100860 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100861 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100862 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100863 if fetched_status == 'ABANDONED':
864 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000865 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100866 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000867 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100868 ]
869 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100870 if other_cl_owner:
871 calls += [
872 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
873 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100874
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200875 calls += cls._git_sanity_checks(ancestor_revision, 'master',
876 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100877 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200878 ((['git', 'rev-parse', '--show-cdup'],), ''),
879 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000880
Aaron Gable7817f022017-12-12 09:43:17 -0800881 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
882 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200883 'M\t.gitignore\n'),
884 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100885 ]
886
887 if not issue:
888 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200889 ((['git', 'log', '--pretty=format:%s%n%n%b',
890 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000891 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100892 ]
893
894 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200895 ((['git', 'config', 'user.email'],), 'me@example.com'),
896 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
897 ([custom_cl_base] if custom_cl_base else
898 [ancestor_revision, 'HEAD']),),
899 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100900 ]
901 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000902
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000903 @classmethod
904 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700905 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000906 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700907 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100908 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000909 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000910 short_hostname='chromium',
911 labels=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000912 if post_amend_description is None:
913 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700914 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200915 # Determined in `_gerrit_base_calls`.
916 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
917
918 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000919
tandriia60502f2016-06-20 02:01:53 -0700920 if squash_mode == 'default':
921 calls.extend([
922 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
923 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
924 ])
925 elif squash_mode in ('override_squash', 'override_nosquash'):
926 calls.extend([
927 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
928 'true' if squash_mode == 'override_squash' else 'false'),
929 ])
930 else:
931 assert squash_mode in ('squash', 'nosquash')
932
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000933 # If issue is given, then description is fetched from Gerrit instead.
934 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000935 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200936 ((['git', 'log', '--pretty=format:%s\n\n%b',
937 ((custom_cl_base + '..') if custom_cl_base else
938 'fake_ancestor_sha..HEAD')],),
939 description),
940 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800941 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000942 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800943 else:
944 if not title:
945 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200946 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
947 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800948 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000949 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000950 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000951 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200952 (('DownloadGerritHook', False), ''),
953 # Amending of commit message to get the Change-Id.
954 ((['git', 'log', '--pretty=format:%s\n\n%b',
955 determined_ancestor_revision + '..HEAD'],),
956 description),
957 ((['git', 'commit', '--amend', '-m', description],), ''),
958 ((['git', 'log', '--pretty=format:%s\n\n%b',
959 determined_ancestor_revision + '..HEAD'],),
960 post_amend_description)
961 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000962 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000963 if not issue:
964 # Prompting to edit description on first upload.
965 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200966 ((['git', 'config', 'core.editor'],), ''),
967 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000968 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000969 ref_to_push = 'abcdef0123456789'
970 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200971 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
972 ((['git', 'config', 'branch.master.remote'],), 'origin'),
973 ]
974
975 if custom_cl_base is None:
976 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000977 ((['get_or_create_merge_base', 'master',
978 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000979 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200980 ]
981 parent = 'origin/master'
982 else:
983 calls += [
984 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
985 'refs/remotes/origin/master'],),
986 callError(1)), # Means not ancenstor.
987 (('ask_for_data',
988 'Do you take responsibility for cleaning up potential mess '
989 'resulting from proceeding with upload? Press Enter to upload, '
990 'or Ctrl+C to abort'), ''),
991 ]
992 parent = custom_cl_base
993
994 calls += [
995 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
996 '0123456789abcdef'),
997 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -0700998 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200999 ref_to_push),
1000 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001001 else:
1002 ref_to_push = 'HEAD'
1003
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001004 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001005 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001006 ((['git', 'rev-list',
1007 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1008 ref_to_push],),
1009 '1hashPerLine\n'),
1010 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001011
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001012 metrics_arguments = []
1013
Aaron Gableafd52772017-06-27 16:40:10 -07001014 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001015 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001016 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001017 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001018 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001019 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001020 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001021 else:
1022 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001023 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001024
Aaron Gable70f4e242017-06-26 10:45:59 -07001025 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001026 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001027 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001028
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001029 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001030 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001031 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001032 if short_hostname == 'chromium':
1033 # All reviwers and ccs get into ref_suffix.
1034 for r in sorted(reviewers):
1035 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001036 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001037 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1038 'joe@example.com'] + cc):
1039 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001040 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001041 reviewers, cc = [], []
1042 else:
1043 # TODO(crbug/877717): remove this case.
1044 calls += [
1045 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1046 sorted(reviewers) + ['joe@example.com',
1047 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1048 {
1049 e: {'email': e}
1050 for e in (reviewers + ['joe@example.com'] + cc)
1051 })
1052 ]
1053 for r in sorted(reviewers):
1054 if r != 'bad-account-or-email':
1055 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001056 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001057 reviewers.remove(r)
1058 for c in sorted(['joe@example.com'] + cc):
1059 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001060 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001061 if c in cc:
1062 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001063
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001064 if not tbr:
1065 for k, v in sorted((labels or {}).items()):
1066 ref_suffix += ',l=%s+%d' % (k, v)
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001067 metrics_arguments.append('l=%s+%d' % (k, v))
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001068
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001069 calls += [
1070 (('time.time',), 1000,),
1071 ((['git', 'push',
1072 'https://%s.googlesource.com/my/repo' % short_hostname,
1073 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1074 (('remote:\n'
1075 'remote: Processing changes: (\)\n'
1076 'remote: Processing changes: (|)\n'
1077 'remote: Processing changes: (/)\n'
1078 'remote: Processing changes: (-)\n'
1079 'remote: Processing changes: new: 1 (/)\n'
1080 'remote: Processing changes: new: 1, done\n'
1081 'remote:\n'
1082 'remote: New Changes:\n'
1083 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1084 ' XXX\n'
1085 'remote:\n'
1086 'To https://%s.googlesource.com/my/repo\n'
1087 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1088 ) % (short_hostname, short_hostname)),),
1089 (('time.time',), 2000,),
1090 (('add_repeated',
1091 'sub_commands',
1092 {
1093 'execution_time': 1000,
1094 'command': 'git push',
1095 'exit_code': 0,
1096 'arguments': sorted(metrics_arguments),
1097 }),
1098 None,),
1099 ]
1100
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001101 if squash:
1102 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001103 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001104 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001105 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001106 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001107 ((['git', 'config', 'branch.master.gerritsquashhash',
1108 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001109 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001110 # TODO(crbug/877717): this should never be used.
1111 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001112 calls += [
1113 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001114 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001115 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001116 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1117 notify),
1118 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001119 ]
Aaron Gablefd238082017-06-07 13:42:34 -07001120 if tbr:
1121 calls += [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001122 (('GetChangeDetail', 'chromium-review.googlesource.com',
1123 'my%2Frepo~123456', ['LABELS']), {
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001124 'labels': {
1125 'Code-Review': {
1126 'default_value': 0,
1127 'all': [],
1128 'values': {
1129 '+2': 'lgtm, approved',
1130 '+1': 'lgtm, but someone else must approve',
1131 ' 0': 'No score',
1132 '-1': 'Don\'t submit as-is',
1133 }
1134 }
1135 }
1136 }),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001137 (('SetReview',
1138 'chromium-review.googlesource.com',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001139 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001140 'Self-approving for TBR',
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001141 {'Code-Review': 2}, None), ''),
Aaron Gablefd238082017-06-07 13:42:34 -07001142 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001143 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001144 return calls
1145
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001146 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001147 self,
1148 upload_args,
1149 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001150 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001151 squash=True,
1152 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001153 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001154 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001155 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001156 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001157 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001158 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001159 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001160 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001161 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001162 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001163 short_hostname='chromium',
1164 labels=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001165 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001166 if squash_mode is None:
1167 if '--no-squash' in upload_args:
1168 squash_mode = 'nosquash'
1169 elif '--squash' in upload_args:
1170 squash_mode = 'squash'
1171 else:
1172 squash_mode = 'default'
1173
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001174 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001175 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001176 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001177 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001178 CookiesAuthenticatorMockFactory(
1179 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001180 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1181 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001182 self.mock(git_cl.gclient_utils, 'RunEditor',
1183 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001184 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1185 'DownloadGerritHook', force))
tandriia60502f2016-06-20 02:01:53 -07001186
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001187 self.calls = self._gerrit_base_calls(
1188 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001189 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001190 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001191 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001192 custom_cl_base=custom_cl_base,
1193 short_hostname=short_hostname)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001194 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001195 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1196 expected_content=description))
1197 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001198 self.calls += self._gerrit_upload_calls(
1199 description, reviewers, squash,
1200 squash_mode=squash_mode,
1201 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001202 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001203 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001204 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001205 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001206 short_hostname=short_hostname,
1207 labels=labels)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001208 # Uncomment when debugging.
1209 # print '\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls)))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001210 git_cl.main(['upload'] + upload_args)
1211
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001212 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001213 self._run_gerrit_upload_test(
1214 ['--no-squash'],
1215 'desc\n\nBUG=\n',
1216 [],
1217 squash=False,
1218 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
1219
1220 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001221 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001222 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001223 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001224 [],
tandriia60502f2016-06-20 02:01:53 -07001225 squash=False,
1226 squash_mode='override_nosquash',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001227 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001228
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001229 def test_gerrit_no_reviewer(self):
1230 self._run_gerrit_upload_test(
1231 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001232 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001233 [],
1234 squash=False,
1235 squash_mode='override_nosquash')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001236
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001237 def test_gerrit_no_reviewer_non_chromium_host(self):
1238 # TODO(crbug/877717): remove this test case.
1239 self._run_gerrit_upload_test(
1240 [],
1241 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1242 [],
1243 squash=False,
1244 squash_mode='override_nosquash',
1245 short_hostname='other')
1246
Nick Carter8692b182017-11-06 16:30:38 -08001247 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001248 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1249 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001250 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001251 'desc\n\nBUG=\n\nChange-Id: I123456789',
1252 squash=False,
1253 squash_mode='override_nosquash',
Nick Carter8692b182017-11-06 16:30:38 -08001254 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001255
ukai@chromium.orge8077812012-02-03 03:41:46 +00001256 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001257 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001258 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001259 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001260 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001261 squash=False,
1262 squash_mode='override_nosquash',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001263 notify=True)
ukai@chromium.orge8077812012-02-03 03:41:46 +00001264
1265 def test_gerrit_reviewer_multiple(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001266 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001267 [],
bradnelsond975b302016-10-23 12:20:23 -07001268 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1269 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001270 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001271 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001272 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001273 cc=['more@example.com', 'people@example.com'],
1274 tbr='reviewer@example.com')
tandriia60502f2016-06-20 02:01:53 -07001275
1276 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001277 self._run_gerrit_upload_test(
1278 [],
1279 'desc\nBUG=\n\nChange-Id: 123456789',
1280 [],
1281 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001282
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001283 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001284 self._run_gerrit_upload_test(
1285 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001286 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001287 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001288 squash=True,
1289 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001290
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001291 def test_gerrit_upload_squash_first_with_labels(self):
1292 self._run_gerrit_upload_test(
1293 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1294 'desc\nBUG=\n\nChange-Id: 123456789',
1295 [],
1296 squash=True,
1297 expected_upstream_ref='origin/master',
1298 labels={'Commit-Queue': 1, 'Auto-Submit': 1})
1299
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001300 def test_gerrit_upload_squash_first_against_rev(self):
1301 custom_cl_base = 'custom_cl_base_rev_or_branch'
1302 self._run_gerrit_upload_test(
1303 ['--squash', custom_cl_base],
1304 'desc\nBUG=\n\nChange-Id: 123456789',
1305 [],
1306 squash=True,
1307 expected_upstream_ref='origin/master',
1308 custom_cl_base=custom_cl_base)
1309 self.assertIn(
1310 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1311 sys.stdout.getvalue())
1312
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001313 def test_gerrit_upload_squash_reupload(self):
1314 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001315 self._run_gerrit_upload_test(
1316 ['--squash'],
1317 description,
1318 [],
1319 squash=True,
1320 expected_upstream_ref='origin/master',
1321 issue=123456)
1322
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001323 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1324 self.mock(git_cl, 'DieWithError',
1325 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1326 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1327 with self.assertRaises(SystemExitMock):
1328 self._run_gerrit_upload_test(
1329 ['--squash'],
1330 description,
1331 [],
1332 squash=True,
1333 expected_upstream_ref='origin/master',
1334 issue=123456,
1335 fetched_status='ABANDONED')
1336
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001337 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1338 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1339 lambda *_, **__: {'email': 'yet-another@example.com'})
1340 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1341 self._run_gerrit_upload_test(
1342 ['--squash'],
1343 description,
1344 [],
1345 squash=True,
1346 expected_upstream_ref='origin/master',
1347 issue=123456,
1348 other_cl_owner='other@example.com')
1349 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001350 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001351 'authenticate to Gerrit as yet-another@example.com.\n'
1352 'Uploading may fail due to lack of permissions',
1353 git_cl.sys.stdout.getvalue())
1354
rmistry@google.com2dd99862015-06-22 12:22:18 +00001355 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001356 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001357 def mock_run_git(*args, **_kwargs):
1358 if args[0] == ['for-each-ref',
1359 '--format=%(refname:short) %(upstream:short)',
1360 'refs/heads']:
1361 # Create a local branch dependency tree that looks like this:
1362 # test1 -> test2 -> test3 -> test4 -> test5
1363 # -> test3.1
1364 # test6 -> test0
1365 branch_deps = [
1366 'test2 test1', # test1 -> test2
1367 'test3 test2', # test2 -> test3
1368 'test3.1 test2', # test2 -> test3.1
1369 'test4 test3', # test3 -> test4
1370 'test5 test4', # test4 -> test5
1371 'test6 test0', # test0 -> test6
1372 'test7', # test7
1373 ]
1374 return '\n'.join(branch_deps)
1375 self.mock(git_cl, 'RunGit', mock_run_git)
1376
1377 class RecordCalls:
1378 times_called = 0
1379 record_calls = RecordCalls()
1380 def mock_CMDupload(*args, **_kwargs):
1381 record_calls.times_called += 1
1382 return 0
1383 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1384
1385 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001386 (('ask_for_data', 'This command will checkout all dependent branches '
1387 'and run "git cl upload". Press Enter to continue, '
1388 'or Ctrl+C to abort'), ''),
1389 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001390
1391 class MockChangelist():
1392 def __init__(self):
1393 pass
1394 def GetBranch(self):
1395 return 'test1'
1396 def GetIssue(self):
1397 return '123'
1398 def GetPatchset(self):
1399 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001400 def IsGerrit(self):
1401 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001402
1403 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1404 # CMDupload should have been called 5 times because of 5 dependent branches.
1405 self.assertEquals(5, record_calls.times_called)
1406 self.assertEquals(0, ret)
1407
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001408 def test_gerrit_change_id(self):
1409 self.calls = [
1410 ((['git', 'write-tree'], ),
1411 'hashtree'),
1412 ((['git', 'rev-parse', 'HEAD~0'], ),
1413 'branch-parent'),
1414 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1415 'A B <a@b.org> 1456848326 +0100'),
1416 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1417 'C D <c@d.org> 1456858326 +0100'),
1418 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1419 'hashchange'),
1420 ]
1421 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1422 self.assertEqual(change_id, 'Ihashchange')
1423
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001424 def test_desecription_append_footer(self):
1425 for init_desc, footer_line, expected_desc in [
1426 # Use unique desc first lines for easy test failure identification.
1427 ('foo', 'R=one', 'foo\n\nR=one'),
1428 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1429 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1430 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1431 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1432 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1433 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1434 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1435 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1436 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1437 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1438 ]:
1439 desc = git_cl.ChangeDescription(init_desc)
1440 desc.append_footer(footer_line)
1441 self.assertEqual(desc.description, expected_desc)
1442
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001443 def test_update_reviewers(self):
1444 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001445 ('foo', [], [],
1446 'foo'),
1447 ('foo\nR=xx', [], [],
1448 'foo\nR=xx'),
1449 ('foo\nTBR=xx', [], [],
1450 'foo\nTBR=xx'),
1451 ('foo', ['a@c'], [],
1452 'foo\n\nR=a@c'),
1453 ('foo\nR=xx', ['a@c'], [],
1454 'foo\n\nR=a@c, xx'),
1455 ('foo\nTBR=xx', ['a@c'], [],
1456 'foo\n\nR=a@c\nTBR=xx'),
1457 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1458 'foo\n\nR=a@c, yy\nTBR=xx'),
1459 ('foo\nBUG=', ['a@c'], [],
1460 'foo\nBUG=\nR=a@c'),
1461 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1462 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1463 ('foo', ['a@c', 'b@c'], [],
1464 'foo\n\nR=a@c, b@c'),
1465 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1466 'foo\nBar\n\nR=c@c\nBUG='),
1467 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1468 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001469 # Same as the line before, but full of whitespaces.
1470 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001471 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001472 'foo\nBar\n\nR=c@c\n BUG =',
1473 ),
1474 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001475 ('foo BUG=allo R=joe ', ['c@c'], [],
1476 'foo BUG=allo R=joe\n\nR=c@c'),
1477 # Redundant TBRs get promoted to Rs
1478 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1479 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001480 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001481 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001482 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001483 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001484 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001485 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001486 actual.append(obj.description)
1487 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001488
Nodir Turakulov23b82142017-11-16 11:04:25 -08001489 def test_get_hash_tags(self):
1490 cases = [
1491 ('', []),
1492 ('a', []),
1493 ('[a]', ['a']),
1494 ('[aa]', ['aa']),
1495 ('[a ]', ['a']),
1496 ('[a- ]', ['a']),
1497 ('[a- b]', ['a-b']),
1498 ('[a--b]', ['a-b']),
1499 ('[a', []),
1500 ('[a]x', ['a']),
1501 ('[aa]x', ['aa']),
1502 ('[a b]', ['a-b']),
1503 ('[a b]', ['a-b']),
1504 ('[a__b]', ['a-b']),
1505 ('[a] x', ['a']),
1506 ('[a][b]', ['a', 'b']),
1507 ('[a] [b]', ['a', 'b']),
1508 ('[a][b]x', ['a', 'b']),
1509 ('[a][b] x', ['a', 'b']),
1510 ('[a]\n[b]', ['a']),
1511 ('[a\nb]', []),
1512 ('[a][', ['a']),
1513 ('Revert "[a] feature"', ['a']),
1514 ('Reland "[a] feature"', ['a']),
1515 ('Revert: [a] feature', ['a']),
1516 ('Reland: [a] feature', ['a']),
1517 ('Revert "Reland: [a] feature"', ['a']),
1518 ('Foo: feature', ['foo']),
1519 ('Foo Bar: feature', ['foo-bar']),
1520 ('Revert "Foo bar: feature"', ['foo-bar']),
1521 ('Reland "Foo bar: feature"', ['foo-bar']),
1522 ]
1523 for desc, expected in cases:
1524 change_desc = git_cl.ChangeDescription(desc)
1525 actual = change_desc.get_hash_tags()
1526 self.assertEqual(
1527 actual,
1528 expected,
1529 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1530
wittman@chromium.org455dc922015-01-26 20:15:50 +00001531 def test_get_target_ref(self):
1532 # Check remote or remote branch not present.
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001533 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001534 self.assertEqual(None, git_cl.GetTargetRef(None,
1535 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001536 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001537
wittman@chromium.org455dc922015-01-26 20:15:50 +00001538 # Check default target refs for branches.
1539 self.assertEqual('refs/heads/master',
1540 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001541 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001542 self.assertEqual('refs/heads/master',
1543 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001544 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001545 self.assertEqual('refs/heads/master',
1546 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001547 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001548 self.assertEqual('refs/branch-heads/123',
1549 git_cl.GetTargetRef('origin',
1550 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001551 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001552 self.assertEqual('refs/diff/test',
1553 git_cl.GetTargetRef('origin',
1554 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001555 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001556 self.assertEqual('refs/heads/chrome/m42',
1557 git_cl.GetTargetRef('origin',
1558 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001559 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001560
1561 # Check target refs for user-specified target branch.
1562 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1563 'refs/remotes/branch-heads/123'):
1564 self.assertEqual('refs/branch-heads/123',
1565 git_cl.GetTargetRef('origin',
1566 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001567 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001568 for branch in ('origin/master', 'remotes/origin/master',
1569 'refs/remotes/origin/master'):
1570 self.assertEqual('refs/heads/master',
1571 git_cl.GetTargetRef('origin',
1572 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001573 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001574 for branch in ('master', 'heads/master', 'refs/heads/master'):
1575 self.assertEqual('refs/heads/master',
1576 git_cl.GetTargetRef('origin',
1577 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001578 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001579
wychen@chromium.orga872e752015-04-28 23:42:18 +00001580 def test_patch_when_dirty(self):
1581 # Patch when local tree is dirty
1582 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1583 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1584
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001585 @staticmethod
1586 def _get_gerrit_codereview_server_calls(branch, value=None,
1587 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001588 detect_branch=True,
1589 detect_server=True):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001590 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1591
1592 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1593 """
1594 calls = []
1595 if detect_branch:
1596 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001597 if detect_server:
1598 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1599 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001600 if value is None:
1601 calls += [
1602 ((['git', 'config', 'branch.' + branch + '.merge'],),
1603 'refs/heads' + branch),
1604 ((['git', 'config', 'branch.' + branch + '.remote'],),
1605 'origin'),
1606 ((['git', 'config', 'remote.origin.url'],),
1607 'https://%s.googlesource.com/my/repo' % git_short_host),
1608 ]
1609 return calls
1610
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001611 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001612 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001613 detect_gerrit_server=False,
1614 actual_codereview=None,
1615 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001616 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001617 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1618
tandriidf09a462016-08-18 16:23:55 -07001619 if new_branch:
1620 self.calls = [((['git', 'new-branch', 'master'],), ''),]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001621
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001622 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001623 self.calls += [
1624 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001625 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001626 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001627
1628 if not force_codereview and not codereview_in_url:
1629 # These calls detect codereview to use.
1630 self.calls += [
1631 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001632 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
1633 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1634 ((['git', 'config', 'gerrit.host'],), 'true'),
1635 ]
1636 if detect_gerrit_server:
1637 self.calls += self._get_gerrit_codereview_server_calls(
1638 'master', git_short_host=git_short_host,
1639 detect_branch=not new_branch and force_codereview)
1640 actual_codereview = 'gerrit'
1641
1642 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001643 self.calls += [
1644 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001645 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001646 {
1647 'current_revision': '7777777777',
1648 'revisions': {
1649 '1111111111': {
1650 '_number': 1,
1651 'fetch': {'http': {
1652 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1653 'ref': 'refs/changes/56/123456/1',
1654 }},
1655 },
1656 '7777777777': {
1657 '_number': 7,
1658 'fetch': {'http': {
1659 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1660 'ref': 'refs/changes/56/123456/7',
1661 }},
1662 },
1663 },
1664 }),
1665 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001666
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001667 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001668 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001669 self.calls += [
1670 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1671 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001672 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001673 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001674 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001675 ((['git', 'config', 'branch.master.gerritserver',
1676 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001677 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001678 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1679 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1680 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001681 ]
1682 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1683
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001684 def test_patch_gerrit_new_branch(self):
1685 self._patch_common(
1686 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1687 self.calls += [
1688 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1689 'refs/changes/56/123456/7'],), ''),
1690 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1691 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1692 ''),
1693 ((['git', 'config', 'branch.master.gerritserver',
1694 'https://chromium-review.googlesource.com'],), ''),
1695 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1696 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1697 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1698 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1699 ]
1700 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1701
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001702 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001703 self._patch_common(
1704 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001705 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001706 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001707 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001708 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001709 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001710 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001711 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001712 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001713 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001714 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1715 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1716 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001717 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001718 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001719
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001720 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001721 self.calls += self._get_gerrit_codereview_server_calls(
1722 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001723 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001724 actual_codereview='gerrit', git_short_host='else',
1725 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001726 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001727 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001728 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001729 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001730 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001731 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001732 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001733 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001734 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001735 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1736 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1737 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001738 ]
1739 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001740 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001741
Aaron Gable697a91b2018-01-19 15:20:15 -08001742 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001743 self.calls += self._get_gerrit_codereview_server_calls(
1744 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001745 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001746 actual_codereview='gerrit', git_short_host='else',
1747 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001748 self.calls += [
1749 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1750 'refs/changes/56/123456/1'],), ''),
1751 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1752 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1753 ''),
1754 ((['git', 'config', 'branch.master.gerritserver',
1755 'https://else-review.googlesource.com'],), ''),
1756 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1757 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1758 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1759 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1760 ]
1761 self.assertEqual(git_cl.main(
1762 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1763 0)
1764
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001765 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001766 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001767 self.calls += [
1768 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001769 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001770 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1771 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1772 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001773 ]
1774 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001775 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001776
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001777 def test_patch_gerrit_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001778 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001779 raise git_cl.gerrit_util.GerritError(404, '')
1780 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1781
tandriic2405f52016-10-10 08:13:15 -07001782 self.calls = [
1783 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandriic2405f52016-10-10 08:13:15 -07001784 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
1785 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1786 ((['git', 'config', 'gerrit.host'],), 'true'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001787 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1788 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1789 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1790 ((['git', 'config', 'remote.origin.url'],),
1791 'https://chromium.googlesource.com/my/repo'),
1792 ((['DieWithError',
1793 'change 123456 at https://chromium-review.googlesource.com does not '
1794 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001795 ]
1796 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001797 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001798
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001799 def _checkout_calls(self):
1800 return [
1801 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001802 'branch\\..*\\.gerritissue'], ),
1803 ('branch.ger-branch.gerritissue 123456\n'
1804 'branch.gbranch654.gerritissue 654321\n')),
1805 ]
1806
1807 def test_checkout_gerrit(self):
1808 """Tests git cl checkout <issue>."""
1809 self.calls = self._checkout_calls()
1810 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1811 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1812
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001813 def test_checkout_not_found(self):
1814 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001815 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001816 self.calls = self._checkout_calls()
1817 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1818
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001819 def test_checkout_no_branch_issues(self):
1820 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001821 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001822 self.calls = [
1823 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001824 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001825 ]
1826 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1827
tandrii@chromium.org28253532016-04-14 13:46:56 +00001828 def _test_gerrit_ensure_authenticated_common(self, auth,
1829 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001830 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1831 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1832 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001833 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001834 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001835 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00001836 cl.branch = 'master'
1837 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001838 cl.lookedup_issue = True
1839 return cl
1840
1841 def test_gerrit_ensure_authenticated_missing(self):
1842 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001843 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001844 })
1845 self.calls.append(
1846 ((['DieWithError',
1847 'Credentials for the following hosts are required:\n'
1848 ' chromium-review.googlesource.com\n'
1849 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01001850 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001851 'https://chromium-review.googlesource.com/new-password'],), ''),)
1852 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1853
1854 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001855 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001856 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001857 'chromium.googlesource.com':
1858 ('git-one.example.com', None, 'secret1'),
1859 'chromium-review.googlesource.com':
1860 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001861 })
1862 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001863 (('ask_for_data', 'If you know what you are doing '
1864 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001865 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1866
1867 def test_gerrit_ensure_authenticated_ok(self):
1868 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001869 'chromium.googlesource.com':
1870 ('git-same.example.com', None, 'secret'),
1871 'chromium-review.googlesource.com':
1872 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001873 })
1874 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1875
tandrii@chromium.org28253532016-04-14 13:46:56 +00001876 def test_gerrit_ensure_authenticated_skipped(self):
1877 cl = self._test_gerrit_ensure_authenticated_common(
1878 auth={}, skip_auth_check=True)
1879 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1880
Eric Boren2fb63102018-10-05 13:05:03 +00001881 def test_gerrit_ensure_authenticated_bearer_token(self):
1882 cl = self._test_gerrit_ensure_authenticated_common(auth={
1883 'chromium.googlesource.com':
1884 ('', None, 'secret'),
1885 'chromium-review.googlesource.com':
1886 ('', None, 'secret'),
1887 })
1888 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1889 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1890 'chromium.googlesource.com')
1891 self.assertTrue('Bearer' in header)
1892
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001893 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001894 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001895 lambda h, i, labels, notify=None:
1896 self._mocked_call(['SetReview', h, i, labels, notify]))
1897
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001898 self.calls = [
1899 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001900 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001901 ((['git', 'config', 'branch.feature.gerritserver'],),
1902 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001903 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
1904 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1905 ((['git', 'config', 'remote.origin.url'],),
1906 'https://chromium.googlesource.com/infra/infra.git'),
1907 ((['SetReview', 'chromium-review.googlesource.com',
1908 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001909 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001910 ]
tandriid9e5ce52016-07-13 02:32:59 -07001911
1912 def test_cmd_set_commit_gerrit_clear(self):
1913 self._cmd_set_commit_gerrit_common(0)
1914 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1915
1916 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001917 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001918 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1919
tandriid9e5ce52016-07-13 02:32:59 -07001920 def test_cmd_set_commit_gerrit(self):
1921 self._cmd_set_commit_gerrit_common(2)
1922 self.assertEqual(0, git_cl.main(['set-commit']))
1923
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001924 def test_description_display(self):
1925 out = StringIO.StringIO()
1926 self.mock(git_cl.sys, 'stdout', out)
1927
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001928 self.mock(git_cl, 'Changelist', ChangelistMock)
1929 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001930
1931 self.assertEqual(0, git_cl.main(['description', '-d']))
1932 self.assertEqual('foo\n', out.getvalue())
1933
iannucci3c972b92016-08-17 13:24:10 -07001934 def test_StatusFieldOverrideIssueMissingArgs(self):
1935 out = StringIO.StringIO()
1936 self.mock(git_cl.sys, 'stderr', out)
1937
1938 try:
1939 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
1940 except SystemExit as ex:
1941 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001942 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001943
1944 out = StringIO.StringIO()
1945 self.mock(git_cl.sys, 'stderr', out)
1946
1947 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001948 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07001949 except SystemExit as ex:
1950 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001951 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001952
1953 def test_StatusFieldOverrideIssue(self):
1954 out = StringIO.StringIO()
1955 self.mock(git_cl.sys, 'stdout', out)
1956
1957 def assertIssue(cl_self, *_args):
1958 self.assertEquals(cl_self.issue, 1)
1959 return 'foobar'
1960
1961 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07001962 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001963 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001964 0)
iannucci3c972b92016-08-17 13:24:10 -07001965 self.assertEqual(out.getvalue(), 'foobar\n')
1966
iannuccie53c9352016-08-17 14:40:40 -07001967 def test_SetCloseOverrideIssue(self):
1968 def assertIssue(cl_self, *_args):
1969 self.assertEquals(cl_self.issue, 1)
1970 return 'foobar'
1971
1972 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
1973 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07001974 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001975 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001976
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001977 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001978 out = StringIO.StringIO()
1979 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001980 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001981 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
1982 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
1983 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1984 ((['git', 'config', 'remote.origin.url'],),
1985 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001986 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001987 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001988 {
1989 'current_revision': 'sha1',
1990 'revisions': {'sha1': {
1991 'commit': {'message': 'foobar'},
1992 }},
1993 }),
1994 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001995 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001996 'description',
1997 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
1998 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001999 self.assertEqual('foobar\n', out.getvalue())
2000
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002001 def test_description_set_raw(self):
2002 out = StringIO.StringIO()
2003 self.mock(git_cl.sys, 'stdout', out)
2004
2005 self.mock(git_cl, 'Changelist', ChangelistMock)
2006 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2007
2008 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2009 self.assertEqual('hihi', ChangelistMock.desc)
2010
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002011 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002012 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002013
2014 def RunEditor(desc, _, **kwargs):
2015 self.assertEquals(
2016 '# Enter a description of the change.\n'
2017 '# This will be displayed on the codereview site.\n'
2018 '# The first line will also be used as the subject of the review.\n'
2019 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002020 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002021 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002022 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002023 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002024 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002025
dsansomee2d6fd92016-09-08 00:10:47 -07002026 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002027 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002028
2029 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2030 self.mock(git_cl.Changelist, 'GetDescription',
2031 lambda *args: current_desc)
2032 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2033 UpdateDescriptionRemote)
2034 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2035
2036 self.calls = [
2037 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002038 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002039 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2040 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002041 ((['git', 'config', 'core.editor'],), 'vi'),
2042 ]
2043 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2044
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002045 def test_description_set_stdin(self):
2046 out = StringIO.StringIO()
2047 self.mock(git_cl.sys, 'stdout', out)
2048
2049 self.mock(git_cl, 'Changelist', ChangelistMock)
2050 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2051
2052 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2053 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2054
kmarshall3bff56b2016-06-06 18:31:47 -07002055 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002056 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2057
kmarshall3bff56b2016-06-06 18:31:47 -07002058 self.calls = \
2059 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2060 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002061 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2062 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
tandrii5d48c322016-08-18 16:19:37 -07002063 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002064 ((['git', 'config', 'gerrit.host'],), 'true'),
tandrii33a46ff2016-08-23 05:53:40 -07002065 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002066 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2067 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2068 ((['git', 'branch', '-D', 'foo'],), '')]
2069
kmarshall3bff56b2016-06-06 18:31:47 -07002070 self.mock(git_cl, 'get_cl_statuses',
2071 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002072 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2073 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2074 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002075
2076 self.assertEqual(0, git_cl.main(['archive', '-f']))
2077
2078 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002079 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002080 self.calls = \
2081 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2082 'refs/heads/master'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002083 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
kmarshall3bff56b2016-06-06 18:31:47 -07002084 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2085
kmarshall9249e012016-08-23 12:02:16 -07002086 self.mock(git_cl, 'get_cl_statuses',
2087 lambda branches, fine_grained, max_processes:
2088 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2089
2090 self.assertEqual(1, git_cl.main(['archive', '-f']))
2091
2092 def test_archive_dry_run(self):
2093 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2094
2095 self.calls = \
2096 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2097 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002098 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2099 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002100 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002101 ((['git', 'config', 'gerrit.host'],), 'true'),
kmarshall9249e012016-08-23 12:02:16 -07002102 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2103 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002104
2105 self.mock(git_cl, 'get_cl_statuses',
2106 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002107 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2108 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2109 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002110
kmarshall9249e012016-08-23 12:02:16 -07002111 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2112
2113 def test_archive_no_tags(self):
2114 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2115
2116 self.calls = \
2117 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2118 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002119 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
2120 ((['git', 'config', 'branch.foo.gerritissue'],), '456'),
2121 ((['git', 'config', 'branch.bar.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002122 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002123 ((['git', 'config', 'gerrit.host'],), 'true'),
kmarshall9249e012016-08-23 12:02:16 -07002124 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2125 ((['git', 'branch', '-D', 'foo'],), '')]
2126
2127 self.mock(git_cl, 'get_cl_statuses',
2128 lambda branches, fine_grained, max_processes:
2129 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2130 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2131 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2132
2133 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002134
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002135 def test_cmd_issue_erase_existing(self):
2136 out = StringIO.StringIO()
2137 self.mock(git_cl.sys, 'stdout', out)
2138 self.calls = [
2139 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002140 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002141 # Let this command raise exception (retcode=1) - it should be ignored.
2142 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002143 CERR1),
2144 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2145 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002146 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2147 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2148 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002149 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002150 ]
2151 self.assertEqual(0, git_cl.main(['issue', '0']))
2152
Aaron Gable400e9892017-07-12 15:31:21 -07002153 def test_cmd_issue_erase_existing_with_change_id(self):
2154 out = StringIO.StringIO()
2155 self.mock(git_cl.sys, 'stdout', out)
2156 self.mock(git_cl.Changelist, 'GetDescription',
2157 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2158 self.calls = [
2159 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002160 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
Aaron Gable400e9892017-07-12 15:31:21 -07002161 # Let this command raise exception (retcode=1) - it should be ignored.
2162 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2163 CERR1),
2164 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2165 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2166 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2167 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2168 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002169 ((['git', 'log', '-1', '--format=%B'],),
2170 'This is a description\n\nChange-Id: Ideadbeef'),
2171 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002172 ]
2173 self.assertEqual(0, git_cl.main(['issue', '0']))
2174
phajdan.jre328cf92016-08-22 04:12:17 -07002175 def test_cmd_issue_json(self):
2176 out = StringIO.StringIO()
2177 self.mock(git_cl.sys, 'stdout', out)
2178 self.calls = [
2179 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002180 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2181 ((['git', 'config', 'branch.feature.gerritserver'],),
2182 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002183 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002184 {'issue': 123,
2185 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002186 ''),
2187 ]
2188 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2189
tandrii8c5a3532016-11-04 07:52:02 -07002190 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2191 self.mock(git_cl.Changelist, 'GetChange',
2192 lambda _, *a: (
2193 self._mocked_call(['GetChange']+list(a))))
2194 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2195 lambda *_, **__: (
2196 self._mocked_call(['DoGetTryMasters'])))
2197 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2198 lambda _, s: self._mocked_call(['SetCQState', s]))
2199
tandrii8c5a3532016-11-04 07:52:02 -07002200 self.calls = [
2201 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002202 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2203 ((['git', 'config', 'branch.feature.gerritserver'],),
2204 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002205 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2206 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2207 ((['git', 'config', 'remote.origin.url'],),
2208 'https://chromium.googlesource.com/depot_tools'),
2209 (('GetChangeDetail', 'chromium-review.googlesource.com',
2210 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002211 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2212 'project': 'depot_tools',
2213 'status': 'OPEN',
2214 'owner': {'email': 'owner@e.mail'},
2215 'revisions': {
2216 'deadbeaf': {
2217 '_number': 6,
2218 },
2219 'beeeeeef': {
2220 '_number': 7,
2221 'fetch': {'http': {
2222 'url': 'https://chromium.googlesource.com/depot_tools',
2223 'ref': 'refs/changes/56/123456/7'
2224 }},
2225 },
2226 },
2227 }),
tandrii8c5a3532016-11-04 07:52:02 -07002228 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2229 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2230 ((['get_or_create_merge_base', 'feature', 'feature'],),
2231 'fake_ancestor_sha'),
2232 ((['GetChange', 'fake_ancestor_sha', None], ),
2233 git_cl.presubmit_support.GitChange(
2234 '', '', '', '', '', '', '', '')),
2235 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2236 ((['DoGetTryMasters'], ), None),
2237 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2238 ]
2239 out = StringIO.StringIO()
2240 self.mock(git_cl.sys, 'stdout', out)
2241 self.assertEqual(0, git_cl.main(['try']))
2242 self.assertEqual(
2243 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002244 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002245 'https://chromium-review.googlesource.com/123456\n')
2246
tandrii8c5a3532016-11-04 07:52:02 -07002247 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2248 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2249 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2250
tandrii8c5a3532016-11-04 07:52:02 -07002251 self.calls = [
2252 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002253 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2254 ((['git', 'config', 'branch.feature.gerritserver'],),
2255 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002256 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2257 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2258 ((['git', 'config', 'remote.origin.url'],),
2259 'https://chromium.googlesource.com/depot_tools'),
2260 (('GetChangeDetail', 'chromium-review.googlesource.com',
2261 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002262 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002263 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002264 'status': 'OPEN',
2265 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002266 'revisions': {
2267 'deadbeaf': {
2268 '_number': 6,
2269 },
2270 'beeeeeef': {
2271 '_number': 7,
2272 'fetch': {'http': {
2273 'url': 'https://chromium.googlesource.com/depot_tools',
2274 'ref': 'refs/changes/56/123456/7'
2275 }},
2276 },
2277 },
2278 }),
2279 ]
2280
2281 def _buildbucket_retry(*_, **kw):
2282 # self.maxDiff = 10000
2283 body = json.loads(kw['body'])
2284 self.assertEqual(len(body['builds']), 1)
2285 build = body['builds'][0]
2286 params = json.loads(build.pop('parameters_json'))
2287 self.assertEqual(params, {
2288 u'builder_name': u'win',
2289 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2290 u'revision': None}],
2291 u'properties': {
2292 u'category': u'git_cl_try',
2293 u'key': u'val',
2294 u'json': [{u'a': 1}, None],
tandrii8c5a3532016-11-04 07:52:02 -07002295
2296 u'patch_gerrit_url':
2297 u'https://chromium-review.googlesource.com',
2298 u'patch_issue': 123456,
2299 u'patch_project': u'depot_tools',
2300 u'patch_ref': u'refs/changes/56/123456/7',
2301 u'patch_repository_url':
2302 u'https://chromium.googlesource.com/depot_tools',
2303 u'patch_set': 7,
2304 u'patch_storage': u'gerrit',
2305 }
2306 })
2307 self.assertEqual(build, {
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002308 u'bucket': u'luci.chromium.try',
tandrii8c5a3532016-11-04 07:52:02 -07002309 u'client_operation_id': u'uuid4',
2310 u'tags': [
2311 u'builder:win',
2312 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2313 u'user_agent:git_cl_try',
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002314 ],
tandrii8c5a3532016-11-04 07:52:02 -07002315 })
2316
2317 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2318
2319 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2320 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002321 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002322 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2323 self.assertRegexpMatches(
2324 git_cl.sys.stdout.getvalue(),
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002325 'Tried jobs on:\nBucket: luci.chromium.try')
tandriide281ae2016-10-12 06:02:30 -07002326
qyearsley123a4682016-10-26 09:12:17 -07002327 def test_git_cl_try_bots_on_multiple_masters(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002328 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2329 self.mock(git_cl.Changelist, 'GetChange',
2330 lambda _, *a: (
2331 self._mocked_call(['GetChange']+list(a))))
2332 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2333 lambda *_, **__: (
2334 self._mocked_call(['DoGetTryMasters'])))
2335 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2336 lambda _, s: self._mocked_call(['SetCQState', s]))
2337
qyearsley123a4682016-10-26 09:12:17 -07002338 self.calls = [
2339 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002340 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2341 ((['git', 'config', 'branch.feature.gerritserver'],),
2342 'https://chromium-review.googlesource.com'),
2343 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2344 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2345 ((['git', 'config', 'remote.origin.url'],),
2346 'https://chromium.googlesource.com/depot_tools'),
2347 (('GetChangeDetail', 'chromium-review.googlesource.com',
2348 'depot_tools~123456',
2349 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2350 'project': 'depot_tools',
2351 'status': 'OPEN',
2352 'owner': {'email': 'owner@e.mail'},
2353 'revisions': {
2354 'deadbeaf': {
2355 '_number': 6,
2356 },
2357 'beeeeeef': {
2358 '_number': 7,
2359 'fetch': {'http': {
2360 'url': 'https://chromium.googlesource.com/depot_tools',
2361 'ref': 'refs/changes/56/123456/7'
2362 }},
2363 },
2364 },
2365 }),
qyearsley123a4682016-10-26 09:12:17 -07002366 ]
2367
2368 def _buildbucket_retry(*_, **kw):
2369 body = json.loads(kw['body'])
2370 self.assertEqual(len(body['builds']), 2)
2371
Nodir Turakulovb422e682018-02-20 22:51:30 -08002372 self.assertEqual(body['builds'][0]['bucket'], 'bucket1')
2373 params = json.loads(body['builds'][0]['parameters_json'])
2374 self.assertEqual(params['builder_name'], 'builder1')
qyearsley123a4682016-10-26 09:12:17 -07002375
Nodir Turakulovb422e682018-02-20 22:51:30 -08002376 self.assertEqual(body['builds'][1]['bucket'], 'bucket2')
2377 params = json.loads(body['builds'][1]['parameters_json'])
2378 self.assertEqual(params['builder_name'], 'builder2')
qyearsley123a4682016-10-26 09:12:17 -07002379
2380 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2381
2382 self.mock(git_cl.urllib2, 'urlopen', lambda _: StringIO.StringIO(
Nodir Turakulovb422e682018-02-20 22:51:30 -08002383 json.dumps({
2384 'builder1': {'bucket': 'bucket1'},
2385 'builder2': {'bucket': 'bucket2'},
2386 })))
qyearsley123a4682016-10-26 09:12:17 -07002387
2388 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2389 self.assertEqual(
2390 0, git_cl.main(['try', '-b', 'builder1', '-b', 'builder2']))
2391 self.assertEqual(
2392 git_cl.sys.stdout.getvalue(),
2393 'Tried jobs on:\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002394 'Bucket: bucket1\n'
qyearsley123a4682016-10-26 09:12:17 -07002395 ' builder1: []\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002396 'Bucket: bucket2\n'
qyearsley123a4682016-10-26 09:12:17 -07002397 ' builder2: []\n'
2398 'To see results here, run: git cl try-results\n'
2399 'To see results in browser, run: git cl web\n')
2400
tandrii16e0b4e2016-06-07 10:34:28 -07002401 def _common_GerritCommitMsgHookCheck(self):
2402 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2403 self.mock(git_cl.os.path, 'abspath',
2404 lambda path: self._mocked_call(['abspath', path]))
2405 self.mock(git_cl.os.path, 'exists',
2406 lambda path: self._mocked_call(['exists', path]))
2407 self.mock(git_cl.gclient_utils, 'FileRead',
2408 lambda path: self._mocked_call(['FileRead', path]))
2409 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2410 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2411 self.calls = [
2412 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2413 ((['abspath', '../'],), '/abs/git_repo_root'),
2414 ]
2415 return git_cl.Changelist(codereview='gerrit', issue=123)
2416
2417 def test_GerritCommitMsgHookCheck_custom_hook(self):
2418 cl = self._common_GerritCommitMsgHookCheck()
2419 self.calls += [
2420 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2421 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2422 '#!/bin/sh\necho "custom hook"')
2423 ]
2424 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2425
2426 def test_GerritCommitMsgHookCheck_not_exists(self):
2427 cl = self._common_GerritCommitMsgHookCheck()
2428 self.calls += [
2429 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2430 ]
2431 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2432
2433 def test_GerritCommitMsgHookCheck(self):
2434 cl = self._common_GerritCommitMsgHookCheck()
2435 self.calls += [
2436 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2437 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2438 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002439 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002440 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2441 ''),
2442 ]
2443 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2444
tandriic4344b52016-08-29 06:04:54 -07002445 def test_GerritCmdLand(self):
2446 self.calls += [
2447 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2448 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2449 'deadbeaf'),
2450 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2451 ((['git', 'config', 'branch.feature.gerritserver'],),
2452 'chromium-review.googlesource.com'),
2453 ]
2454 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2455 cl._codereview_impl._GetChangeDetail = lambda _: {
2456 'labels': {},
2457 'current_revision': 'deadbeaf',
2458 }
agable32978d92016-11-01 12:55:02 -07002459 cl._codereview_impl._GetChangeCommit = lambda: {
2460 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002461 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002462 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2463 }
tandriic4344b52016-08-29 06:04:54 -07002464 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002465 out = StringIO.StringIO()
2466 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002467 self.assertEqual(0, cl.CMDLand(force=True,
2468 bypass_hooks=True,
2469 verbose=True,
2470 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002471 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002472 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002473
tandrii221ab252016-10-06 08:12:04 -07002474 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002475 '9000': {
2476 'id': '9000',
2477 'bucket': 'master.x.y',
2478 'created_by': 'user:someone@chromium.org',
2479 'created_ts': '147200002222000',
2480 'experimental': False,
2481 'parameters_json': json.dumps({
2482 'builder_name': 'my-bot',
2483 'properties': {'category': 'cq'},
2484 }),
2485 'status': 'STARTED',
2486 'tags': [
2487 'build_address:x.y/my-bot/2',
2488 'builder:my-bot',
2489 'experimental:false',
2490 'user_agent:cq',
2491 ],
2492 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2493 },
2494 '8000': {
2495 'id': '8000',
2496 'bucket': 'master.x.y',
2497 'created_by': 'user:someone@chromium.org',
2498 'created_ts': '147200001111000',
2499 'experimental': False,
2500 'failure_reason': 'BUILD_FAILURE',
2501 'parameters_json': json.dumps({
2502 'builder_name': 'my-bot',
2503 'properties': {'category': 'cq'},
2504 }),
2505 'result_details_json': json.dumps({
2506 'properties': {'buildnumber': 1},
2507 }),
2508 'result': 'FAILURE',
2509 'status': 'COMPLETED',
2510 'tags': [
2511 'build_address:x.y/my-bot/1',
2512 'builder:my-bot',
2513 'experimental:false',
2514 'user_agent:cq',
2515 ],
2516 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2517 },
2518 }
tandrii221ab252016-10-06 08:12:04 -07002519
2520 def test_write_try_results_json(self):
2521 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002522 {
2523 'bucket': 'master.x.y',
2524 'buildbucket_id': '8000',
2525 'builder_name': 'my-bot',
2526 'created_ts': '147200001111000',
2527 'experimental': False,
2528 'failure_reason': 'BUILD_FAILURE',
2529 'result': 'FAILURE',
2530 'status': 'COMPLETED',
2531 'tags': [
2532 'build_address:x.y/my-bot/1',
2533 'builder:my-bot',
2534 'experimental:false',
2535 'user_agent:cq',
2536 ],
2537 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2538 },
2539 {
2540 'bucket': 'master.x.y',
2541 'buildbucket_id': '9000',
2542 'builder_name': 'my-bot',
2543 'created_ts': '147200002222000',
2544 'experimental': False,
2545 'failure_reason': None,
2546 'result': None,
2547 'status': 'STARTED',
2548 'tags': [
2549 'build_address:x.y/my-bot/2',
2550 'builder:my-bot',
2551 'experimental:false',
2552 'user_agent:cq',
2553 ],
2554 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2555 },
tandrii221ab252016-10-06 08:12:04 -07002556 ]
2557 self.calls = [(('write_json', 'output.json', expected_output), '')]
2558 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2559
tandrii45b2a582016-10-11 03:14:16 -07002560 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002561 out = StringIO.StringIO()
2562 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002563 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2564 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002565 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2566 self._mocked_call(['get_authenticator_for_host', host]))
2567 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2568 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002569
tandrii45b2a582016-10-11 03:14:16 -07002570 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2571 self._setup_fetch_try_jobs(most_recent_patchset=13)
2572 self.calls += [
2573 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii45b2a582016-10-11 03:14:16 -07002574 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002575 # TODO(tandrii): Uncomment the below if we decide to support checking
2576 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002577 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002578 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002579 ((['git', 'config', 'branch.feature.gerritserver'],),
2580 'https://x-review.googlesource.com'),
2581 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2582 AuthenticatorMock()),
2583 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2584
2585 def test_fetch_try_jobs_none_gerrit(self):
2586 self._setup_fetch_try_jobs_gerrit({})
2587 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002588 # TODO(tandrii): Uncomment the below if we decide to support checking
2589 # patchsets for Gerrit.
2590 # self.assertRegexpMatches(
2591 # sys.stdout.getvalue(),
2592 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07002593 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2594
2595 def test_fetch_try_jobs_some_gerrit(self):
2596 self._setup_fetch_try_jobs_gerrit({
2597 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2598 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002599 # TODO(tandrii): Uncomment the below if we decide to support checking
2600 # patchsets for Gerrit.
2601 # self.calls.remove(
2602 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002603 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2604
2605 # ... and doesn't result in warning.
2606 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2607 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002608 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2609 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2610
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002611 def _mock_gerrit_changes_for_detail_cache(self):
2612 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002613
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002614 def test_gerrit_change_detail_cache_simple(self):
2615 self._mock_gerrit_changes_for_detail_cache()
2616 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002617 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2618 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2619 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002620 ]
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002621 cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002622 cl1._cached_remote_url = (
2623 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002624 cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002625 cl2._cached_remote_url = (
2626 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002627 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2628 self.assertEqual(cl1._GetChangeDetail(), 'a')
2629 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2630 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2631 self.assertEqual(cl1._GetChangeDetail(), 'a')
2632 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002633
2634 def test_gerrit_change_detail_cache_options(self):
2635 self._mock_gerrit_changes_for_detail_cache()
2636 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002637 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2638 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2639 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2640 # no longer in cache.
2641 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002642 ]
2643 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002644 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002645 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2646 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2647 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2648 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2649 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2650 self.assertEqual(cl._GetChangeDetail(), 'cab')
2651
2652 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2653 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2654 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2655 self.assertEqual(cl._GetChangeDetail(), 'cab')
2656
2657 # Finally, no_cache should invalidate all caches for given change.
2658 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2659 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2660
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002661 def test_gerrit_description_caching(self):
2662 def gen_detail(rev, desc):
2663 return {
2664 'current_revision': rev,
2665 'revisions': {rev: {'commit': {'message': desc}}}
2666 }
2667 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002668 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002669 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2670 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002671 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002672 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2673 gen_detail('rev2', 'desc2')),
2674 ]
2675
2676 self._mock_gerrit_changes_for_detail_cache()
2677 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002678 cl._cached_remote_url = (
2679 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002680 self.assertEqual(cl.GetDescription(), 'desc1')
2681 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2682 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002683
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002684 def test_print_current_creds(self):
2685 class CookiesAuthenticatorMock(object):
2686 def __init__(self):
2687 self.gitcookies = {
2688 'host.googlesource.com': ('user', 'pass'),
2689 'host-review.googlesource.com': ('user', 'pass'),
2690 }
2691 self.netrc = self
2692 self.netrc.hosts = {
2693 'github.com': ('user2', None, 'pass2'),
2694 'host2.googlesource.com': ('user3', None, 'pass'),
2695 }
2696 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2697 CookiesAuthenticatorMock)
2698 self.mock(sys, 'stdout', StringIO.StringIO())
2699 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2700 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2701 ' Host\t User\t Which file',
2702 '============================\t=====\t===========',
2703 'host-review.googlesource.com\t user\t.gitcookies',
2704 ' host.googlesource.com\t user\t.gitcookies',
2705 ' host2.googlesource.com\tuser3\t .netrc',
2706 ])
2707 sys.stdout.buf = ''
2708 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2709 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2710 ' Host\tUser\t Which file',
2711 '============================\t====\t===========',
2712 'host-review.googlesource.com\tuser\t.gitcookies',
2713 ' host.googlesource.com\tuser\t.gitcookies',
2714 ])
2715
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002716 def _common_creds_check_mocks(self):
2717 def exists_mock(path):
2718 dirname = os.path.dirname(path)
2719 if dirname == os.path.expanduser('~'):
2720 dirname = '~'
2721 base = os.path.basename(path)
2722 if base in ('.netrc', '.gitcookies'):
2723 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2724 # git cl also checks for existence other files not relevant to this test.
2725 return None
2726 self.mock(os.path, 'exists', exists_mock)
2727 self.mock(sys, 'stdout', StringIO.StringIO())
2728
2729 def test_creds_check_gitcookies_not_configured(self):
2730 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002731 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002732 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002733 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002734 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002735 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2736 (('os.path.exists', '~/.netrc'), True),
2737 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2738 'or Ctrl+C to abort'), ''),
2739 ((['git', 'config', '--global', 'http.cookiefile',
2740 os.path.expanduser('~/.gitcookies')], ), ''),
2741 ]
2742 self.assertEqual(0, git_cl.main(['creds-check']))
2743 self.assertRegexpMatches(
2744 sys.stdout.getvalue(),
2745 '^You seem to be using outdated .netrc for git credentials:')
2746 self.assertRegexpMatches(
2747 sys.stdout.getvalue(),
2748 '\nConfigured git to use .gitcookies from')
2749
2750 def test_creds_check_gitcookies_configured_custom_broken(self):
2751 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002752 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002753 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002754 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002755 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002756 ((['git', 'config', '--global', 'http.cookiefile'],),
2757 '/custom/.gitcookies'),
2758 (('os.path.exists', '/custom/.gitcookies'), False),
2759 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2760 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2761 ((['git', 'config', '--global', 'http.cookiefile',
2762 os.path.expanduser('~/.gitcookies')], ), ''),
2763 ]
2764 self.assertEqual(0, git_cl.main(['creds-check']))
2765 self.assertRegexpMatches(
2766 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002767 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002768 self.assertRegexpMatches(
2769 sys.stdout.getvalue(),
2770 'However, your configured .gitcookies file is missing.')
2771
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002772 def test_git_cl_comment_add_gerrit(self):
2773 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002774 lambda host, change, msg, ready:
2775 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002776 self.calls = [
2777 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2778 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2779 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2780 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2781 'origin/master'),
2782 ((['git', 'config', 'remote.origin.url'],),
2783 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002784 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2785 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002786 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002787 ]
2788 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2789 '-a', 'msg']))
2790
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002791 def test_git_cl_comments_fetch_gerrit(self):
2792 self.mock(sys, 'stdout', StringIO.StringIO())
2793 self.calls = [
2794 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2795 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2796 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2797 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2798 'origin/master'),
2799 ((['git', 'config', 'remote.origin.url'],),
2800 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002801 (('GetChangeDetail', 'chromium-review.googlesource.com',
2802 'infra%2Finfra~1',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002803 ['MESSAGES', 'DETAILED_ACCOUNTS']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002804 'owner': {'email': 'owner@example.com'},
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002805 'messages': [
2806 {
2807 u'_revision_number': 1,
2808 u'author': {
2809 u'_account_id': 1111084,
2810 u'email': u'commit-bot@chromium.org',
2811 u'name': u'Commit Bot'
2812 },
2813 u'date': u'2017-03-15 20:08:45.000000000',
2814 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002815 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002816 u'tag': u'autogenerated:cq:dry-run'
2817 },
2818 {
2819 u'_revision_number': 2,
2820 u'author': {
2821 u'_account_id': 11151243,
2822 u'email': u'owner@example.com',
2823 u'name': u'owner'
2824 },
2825 u'date': u'2017-03-16 20:00:41.000000000',
2826 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2827 u'message': u'PTAL',
2828 },
2829 {
2830 u'_revision_number': 2,
2831 u'author': {
2832 u'_account_id': 148512 ,
2833 u'email': u'reviewer@example.com',
2834 u'name': u'reviewer'
2835 },
2836 u'date': u'2017-03-17 05:19:37.500000000',
2837 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2838 u'message': u'Patch Set 2: Code-Review+1',
2839 },
2840 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002841 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002842 (('GetChangeComments', 'chromium-review.googlesource.com',
2843 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002844 '/COMMIT_MSG': [
2845 {
2846 'author': {'email': u'reviewer@example.com'},
2847 'updated': u'2017-03-17 05:19:37.500000000',
2848 'patch_set': 2,
2849 'side': 'REVISION',
2850 'message': 'Please include a bug link',
2851 },
2852 ],
2853 'codereview.settings': [
2854 {
2855 'author': {'email': u'owner@example.com'},
2856 'updated': u'2017-03-16 20:00:41.000000000',
2857 'patch_set': 2,
2858 'side': 'PARENT',
2859 'line': 42,
2860 'message': 'I removed this because it is bad',
2861 },
2862 ]
Leszek Swirski45b20c42018-09-17 17:05:26 +00002863 })
2864 ] * 2 + [
2865 (('write_json', 'output.json', [
2866 {
2867 u'date': u'2017-03-16 20:00:41.000000',
2868 u'message': (
2869 u'PTAL\n' +
2870 u'\n' +
2871 u'codereview.settings\n' +
2872 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2873 u'c/1/2/codereview.settings#b42\n' +
2874 u' I removed this because it is bad\n'),
2875 u'approval': False,
2876 u'disapproval': False,
2877 u'sender': u'owner@example.com'
2878 }, {
2879 u'date': u'2017-03-17 05:19:37.500000',
2880 u'message': (
2881 u'Patch Set 2: Code-Review+1\n' +
2882 u'\n' +
2883 u'/COMMIT_MSG\n' +
2884 u' PS2, File comment: https://chromium-review.googlesource' +
2885 u'.com/c/1/2//COMMIT_MSG#\n' +
2886 u' Please include a bug link\n'),
2887 u'approval': False,
2888 u'disapproval': False,
2889 u'sender': u'reviewer@example.com'
2890 }
2891 ]),'')
2892 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002893 expected_comments_summary = [
2894 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002895 message=(
2896 u'PTAL\n' +
2897 u'\n' +
2898 u'codereview.settings\n' +
2899 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2900 u'c/1/2/codereview.settings#b42\n' +
2901 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002902 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2903 disapproval=False, approval=False, sender=u'owner@example.com'),
2904 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002905 message=(
2906 u'Patch Set 2: Code-Review+1\n' +
2907 u'\n' +
2908 u'/COMMIT_MSG\n' +
2909 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2910 u'c/1/2//COMMIT_MSG#\n' +
2911 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002912 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
2913 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2914 ]
2915 cl = git_cl.Changelist(codereview='gerrit', issue=1)
2916 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov642641d2018-10-16 05:54:41 +00002917 self.assertEqual(0, git_cl.main(['comment', '-i', '1',
Leszek Swirski45b20c42018-09-17 17:05:26 +00002918 '-j', 'output.json']))
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002919
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002920 def test_get_remote_url_with_mirror(self):
2921 original_os_path_isdir = os.path.isdir
2922 def selective_os_path_isdir_mock(path):
2923 if path == '/cache/this-dir-exists':
2924 return self._mocked_call('os.path.isdir', path)
2925 return original_os_path_isdir(path)
2926 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2927
2928 url = 'https://chromium.googlesource.com/my/repo'
2929 self.calls = [
2930 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2931 ((['git', 'config', 'branch.master.merge'],), 'master'),
2932 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2933 ((['git', 'config', 'remote.origin.url'],),
2934 '/cache/this-dir-exists'),
2935 (('os.path.isdir', '/cache/this-dir-exists'),
2936 True),
2937 # Runs in /cache/this-dir-exists.
2938 ((['git', 'config', 'remote.origin.url'],),
2939 url),
2940 ]
2941 cl = git_cl.Changelist(codereview='gerrit', issue=1)
2942 self.assertEqual(cl.GetRemoteUrl(), url)
2943 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2944
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002945 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002946 self.calls = [
2947 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2948 ((['git', 'config', 'branch.master.merge'],), 'master'),
2949 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2950 ((['git', 'config', 'remote.origin.url'],),
2951 'https://chromium.googlesource.com/a/my/repo.git/'),
2952 ]
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002953 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
2954 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2955
2956 def test_gerrit_change_identifier_without_project(self):
2957 self.calls = [
2958 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2959 ((['git', 'config', 'branch.master.merge'],), 'master'),
2960 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2961 ((['git', 'config', 'remote.origin.url'],), CERR1),
2962 ]
2963 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
2964 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002965
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002966
maruel@chromium.orgddd59412011-11-30 14:20:38 +00002967if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01002968 logging.basicConfig(
2969 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00002970 unittest.main()