blob: f71a5d5dd300e03985a3ca77a605a2e70ab1f462 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01009import datetime
tandriide281ae2016-10-12 06:02:30 -070010import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010011import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000012import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
22
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000023import metrics
24# We have to disable monitoring before importing git_cl.
25metrics.DISABLE_METRICS_COLLECTION = True
26
Eric Boren2fb63102018-10-05 13:05:03 +000027import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000028import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000029import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000030import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
65 desc = ""
66 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
skobes6468b902016-10-24 08:45:10 -070086class GitCheckoutMock(object):
87 def __init__(self, *args, **kwargs):
88 pass
89
90 @staticmethod
91 def reset():
92 GitCheckoutMock.conflict = False
93
94 def apply_patch(self, p):
95 if GitCheckoutMock.conflict:
96 raise Exception('failed')
97
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000098
99class WatchlistsMock(object):
100 def __init__(self, _):
101 pass
102 @staticmethod
103 def GetWatchersForPaths(_):
104 return ['joe@example.com']
105
106
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000107class CodereviewSettingsFileMock(object):
108 def __init__(self):
109 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800110 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000111 def read(self):
112 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000113 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000114
115
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000116class AuthenticatorMock(object):
117 def __init__(self, *_args):
118 pass
119 def has_cached_credentials(self):
120 return True
tandrii221ab252016-10-06 08:12:04 -0700121 def authorize(self, http):
122 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000123
124
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100125def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
127
128 Usage:
129 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100130 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000131
132 OR
133 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100134 CookiesAuthenticatorMockFactory(
135 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000136 """
137 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800138 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139 # Intentionally not calling super() because it reads actual cookie files.
140 pass
141 @classmethod
142 def get_gitcookies_path(cls):
143 return '~/.gitcookies'
144 @classmethod
145 def get_netrc_path(cls):
146 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 def _get_auth_for_host(self, host):
148 if same_auth:
149 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000150 return (hosts_with_creds or {}).get(host)
151 return CookiesAuthenticatorMock
152
Aaron Gable9a03ae02017-11-03 11:31:07 -0700153
kmarshall9249e012016-08-23 12:02:16 -0700154class MockChangelistWithBranchAndIssue():
155 def __init__(self, branch, issue):
156 self.branch = branch
157 self.issue = issue
158 def GetBranch(self):
159 return self.branch
160 def GetIssue(self):
161 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162
tandriic2405f52016-10-10 08:13:15 -0700163
164class SystemExitMock(Exception):
165 pass
166
167
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000168class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100169 def test_get_description(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000170 cl = git_cl.Changelist(issue=1, codereview='gerrit',
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100171 codereview_host='host')
172 cl.description = 'x'
173 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800174 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100175 self.assertEquals(cl.GetDescription(), 'x')
176 self.assertEquals(cl.GetDescription(force=True), 'y')
177 self.assertEquals(cl.GetDescription(), 'y')
178
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700179 def test_description_footers(self):
180 cl = git_cl.Changelist(issue=1, codereview='gerrit',
181 codereview_host='host')
182 cl.description = '\n'.join([
183 'This is some message',
184 '',
185 'It has some lines',
186 'and, also',
187 '',
188 'Some: Really',
189 'Awesome: Footers',
190 ])
191 cl.has_description = True
192 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
193 msg, footers = cl.GetDescriptionFooters()
194 self.assertEquals(
195 msg, ['This is some message', '', 'It has some lines', 'and, also'])
196 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
197
198 msg.append('wut')
199 footers.append(('gnarly-dude', 'beans'))
200 cl.UpdateDescriptionFooters(msg, footers)
201 self.assertEquals(cl.GetDescription().splitlines(), [
202 'This is some message',
203 '',
204 'It has some lines',
205 'and, also',
206 'wut'
207 '',
208 'Some: Really',
209 'Awesome: Footers',
210 'Gnarly-Dude: beans',
211 ])
212
tandriif9aefb72016-07-01 09:06:51 -0700213 def test_get_bug_line_values(self):
214 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
215 self.assertEqual(f('', ''), [])
216 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
217 self.assertEqual(f('v8', '456'), ['v8:456'])
218 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
219 # Not nice, but not worth carying.
220 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
221 ['v8:456', 'chromium:123', 'v8:123'])
222
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100223 def _test_git_number(self, parent_msg, dest_ref, child_msg,
224 parent_hash='parenthash'):
225 desc = git_cl.ChangeDescription(child_msg)
226 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
227 return desc.description
228
229 def assertEqualByLine(self, actual, expected):
230 self.assertEqual(actual.splitlines(), expected.splitlines())
231
232 def test_git_number_bad_parent(self):
233 with self.assertRaises(ValueError):
234 self._test_git_number('Parent', 'refs/heads/master', 'Child')
235
236 def test_git_number_bad_parent_footer(self):
237 with self.assertRaises(AssertionError):
238 self._test_git_number(
239 'Parent\n'
240 '\n'
241 'Cr-Commit-Position: wrong',
242 'refs/heads/master', 'Child')
243
244 def test_git_number_bad_lineage_ignored(self):
245 actual = self._test_git_number(
246 'Parent\n'
247 '\n'
248 'Cr-Commit-Position: refs/heads/master@{#1}\n'
249 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
250 'refs/heads/master', 'Child')
251 self.assertEqualByLine(
252 actual,
253 'Child\n'
254 '\n'
255 'Cr-Commit-Position: refs/heads/master@{#2}\n'
256 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
257
258 def test_git_number_same_branch(self):
259 actual = self._test_git_number(
260 'Parent\n'
261 '\n'
262 'Cr-Commit-Position: refs/heads/master@{#12}',
263 dest_ref='refs/heads/master',
264 child_msg='Child')
265 self.assertEqualByLine(
266 actual,
267 'Child\n'
268 '\n'
269 'Cr-Commit-Position: refs/heads/master@{#13}')
270
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200271 def test_git_number_same_branch_mixed_footers(self):
272 actual = self._test_git_number(
273 'Parent\n'
274 '\n'
275 'Cr-Commit-Position: refs/heads/master@{#12}',
276 dest_ref='refs/heads/master',
277 child_msg='Child\n'
278 '\n'
279 'Broken-by: design\n'
280 'BUG=123')
281 self.assertEqualByLine(
282 actual,
283 'Child\n'
284 '\n'
285 'Broken-by: design\n'
286 'BUG=123\n'
287 'Cr-Commit-Position: refs/heads/master@{#13}')
288
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100289 def test_git_number_same_branch_with_originals(self):
290 actual = self._test_git_number(
291 'Parent\n'
292 '\n'
293 'Cr-Commit-Position: refs/heads/master@{#12}',
294 dest_ref='refs/heads/master',
295 child_msg='Child\n'
296 '\n'
297 'Some users are smart and insert their own footers\n'
298 '\n'
299 'Cr-Whatever: value\n'
300 'Cr-Commit-Position: refs/copy/paste@{#22}')
301 self.assertEqualByLine(
302 actual,
303 'Child\n'
304 '\n'
305 'Some users are smart and insert their own footers\n'
306 '\n'
307 'Cr-Original-Whatever: value\n'
308 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
309 'Cr-Commit-Position: refs/heads/master@{#13}')
310
311 def test_git_number_new_branch(self):
312 actual = self._test_git_number(
313 'Parent\n'
314 '\n'
315 'Cr-Commit-Position: refs/heads/master@{#12}',
316 dest_ref='refs/heads/branch',
317 child_msg='Child')
318 self.assertEqualByLine(
319 actual,
320 'Child\n'
321 '\n'
322 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
323 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
324
325 def test_git_number_lineage(self):
326 actual = self._test_git_number(
327 'Parent\n'
328 '\n'
329 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
330 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
331 dest_ref='refs/heads/branch',
332 child_msg='Child')
333 self.assertEqualByLine(
334 actual,
335 'Child\n'
336 '\n'
337 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
338 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
339
340 def test_git_number_moooooooore_lineage(self):
341 actual = self._test_git_number(
342 'Parent\n'
343 '\n'
344 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
345 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
346 dest_ref='refs/heads/mooore',
347 child_msg='Child')
348 self.assertEqualByLine(
349 actual,
350 'Child\n'
351 '\n'
352 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
353 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
354 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
355
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100356 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700357 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100358 actual = self._test_git_number(
359 'CQ commit on fresh new branch + numbering.\n'
360 '\n'
361 'NOTRY=True\n'
362 'NOPRESUBMIT=True\n'
363 'BUG=\n'
364 '\n'
365 'Review-Url: https://codereview.chromium.org/2577703003\n'
366 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
367 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
368 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
369 dest_ref='refs/heads/gnumb-test/cl',
370 child_msg='git cl on fresh new branch + numbering.\n'
371 '\n'
372 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
373 self.assertEqualByLine(
374 actual,
375 'git cl on fresh new branch + numbering.\n'
376 '\n'
377 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
378 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
379 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
380 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
381 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100382
383 def test_git_number_cherry_pick(self):
384 actual = self._test_git_number(
385 'Parent\n'
386 '\n'
387 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
388 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
389 dest_ref='refs/heads/branch',
390 child_msg='Child, which is cherry-pick from master\n'
391 '\n'
392 'Cr-Commit-Position: refs/heads/master@{#100}\n'
393 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
394 self.assertEqualByLine(
395 actual,
396 'Child, which is cherry-pick from master\n'
397 '\n'
398 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
399 '\n'
400 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
401 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
402 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
403
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000404 def test_gerrit_mirror_hack(self):
405 cr = 'chromium-review.googlesource.com'
406 url0 = 'https://%s/a/changes/x?a=b' % cr
407 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
408 try:
409 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
410 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
411 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
412 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
413
414 self.assertNotEqual(url1, url2)
415 self.assertEqual(sorted((url1, url2)), [
416 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
417 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
418 self.assertEqual(url1, url3)
419 finally:
420 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
421
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000422 def test_valid_accounts(self):
423 mock_per_account = {
424 'u1': None, # 404, doesn't exist.
425 'u2': {
426 '_account_id': 123124,
427 'avatars': [],
428 'email': 'u2@example.com',
429 'name': 'User Number 2',
430 'status': 'OOO',
431 },
432 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
433 }
434 def GetAccountDetailsMock(_, account):
435 # Poor-man's mock library's side_effect.
436 v = mock_per_account.pop(account)
437 if isinstance(v, Exception):
438 raise v
439 return v
440
441 original = git_cl.gerrit_util.GetAccountDetails
442 try:
443 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
444 actual = git_cl.gerrit_util.ValidAccounts(
445 'host', ['u1', 'u2', 'u3'], max_threads=1)
446 finally:
447 git_cl.gerrit_util.GetAccountDetails = original
448 self.assertEqual(actual, {
449 'u2': {
450 '_account_id': 123124,
451 'avatars': [],
452 'email': 'u2@example.com',
453 'name': 'User Number 2',
454 'status': 'OOO',
455 },
456 })
457
458
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000459
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200460class TestParseIssueURL(unittest.TestCase):
461 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
462 codereview=None, fail=False):
463 self.assertIsNotNone(parsed)
464 if fail:
465 self.assertFalse(parsed.valid)
466 return
467 self.assertTrue(parsed.valid)
468 self.assertEqual(parsed.issue, issue)
469 self.assertEqual(parsed.patchset, patchset)
470 self.assertEqual(parsed.hostname, hostname)
471 self.assertEqual(parsed.codereview, codereview)
472
473 def _run_and_validate(self, func, url, *args, **kwargs):
474 result = func(urlparse.urlparse(url))
475 if kwargs.pop('fail', False):
476 self.assertIsNone(result)
477 return None
478 self._validate(result, *args, fail=False, **kwargs)
479
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480 def test_gerrit(self):
481 def test(url, issue=None, patchset=None, hostname=None, fail=None):
482 self._test_ParseIssueUrl(
483 git_cl._GerritChangelistImpl.ParseIssueURL,
484 url, issue, patchset, hostname, fail)
485 def test(url, *args, **kwargs):
486 self._run_and_validate(git_cl._GerritChangelistImpl.ParseIssueURL, url,
487 *args, codereview='gerrit', **kwargs)
488
489 test('http://chrome-review.source.com/c/123',
490 123, None, 'chrome-review.source.com')
491 test('https://chrome-review.source.com/c/123/',
492 123, None, 'chrome-review.source.com')
493 test('https://chrome-review.source.com/c/123/4',
494 123, 4, 'chrome-review.source.com')
495 test('https://chrome-review.source.com/#/c/123/4',
496 123, 4, 'chrome-review.source.com')
497 test('https://chrome-review.source.com/c/123/4',
498 123, 4, 'chrome-review.source.com')
499 test('https://chrome-review.source.com/123',
500 123, None, 'chrome-review.source.com')
501 test('https://chrome-review.source.com/123/4',
502 123, 4, 'chrome-review.source.com')
503
504 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
505 test('https://chrome-review.source.com/c/abc/', fail=True)
506 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
507
508 def test_ParseIssueNumberArgument(self):
509 def test(arg, *args, **kwargs):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200510 codereview_hint = kwargs.pop('hint', None)
511 self._validate(git_cl.ParseIssueNumberArgument(arg, codereview_hint),
512 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200513
514 test('123', 123)
515 test('', fail=True)
516 test('abc', fail=True)
517 test('123/1', fail=True)
518 test('123a', fail=True)
519 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000520
521 # Looks like Rietveld and Gerrit, but we should select Gerrit now
522 # w/ or w/o hint.
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200523 test('https://codereview.source.com/123',
524 123, None, 'codereview.source.com', 'gerrit',
525 hint='gerrit')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000526 test('https://codereview.source.com/123',
527 123, None, 'codereview.source.com', 'gerrit')
528
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200529 # Gerrrit.
530 test('https://chrome-review.source.com/c/123/4',
531 123, 4, 'chrome-review.source.com', 'gerrit')
532 test('https://chrome-review.source.com/bad/123/4', fail=True)
533
534
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100535class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100536 def setUp(self):
537 super(GitCookiesCheckerTest, self).setUp()
538 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100539 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100540
541 def mock_hosts_creds(self, subhost_identity_pairs):
542 def ensure_googlesource(h):
543 if not h.endswith(self.c._GOOGLESOURCE):
544 assert not h.endswith('.')
545 return h + '.' + self.c._GOOGLESOURCE
546 return h
547 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
548 for h, i in subhost_identity_pairs]
549
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200550 def test_identity_parsing(self):
551 self.assertEqual(self.c._parse_identity('ldap.google.com'),
552 ('ldap', 'google.com'))
553 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
554 ('ldap', 'example.com'))
555 # Specical case because we know there are no subdomains in chromium.org.
556 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
557 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800558 # Pathological: ".period." can be either username OR domain, more likely
559 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200560 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
561 ('note', 'period.example.com'))
562
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563 def test_analysis_nothing(self):
564 self.c._all_hosts = []
565 self.assertFalse(self.c.has_generic_host())
566 self.assertEqual(set(), self.c.get_conflicting_hosts())
567 self.assertEqual(set(), self.c.get_duplicated_hosts())
568 self.assertEqual(set(), self.c.get_partially_configured_hosts())
569 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
570
571 def test_analysis(self):
572 self.mock_hosts_creds([
573 ('.googlesource.com', 'git-example.chromium.org'),
574
575 ('chromium', 'git-example.google.com'),
576 ('chromium-review', 'git-example.google.com'),
577 ('chrome-internal', 'git-example.chromium.org'),
578 ('chrome-internal-review', 'git-example.chromium.org'),
579 ('conflict', 'git-example.google.com'),
580 ('conflict-review', 'git-example.chromium.org'),
581 ('dup', 'git-example.google.com'),
582 ('dup', 'git-example.google.com'),
583 ('dup-review', 'git-example.google.com'),
584 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200585 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100586 ])
587 self.assertTrue(self.c.has_generic_host())
588 self.assertEqual(set(['conflict.googlesource.com']),
589 self.c.get_conflicting_hosts())
590 self.assertEqual(set(['dup.googlesource.com']),
591 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200592 self.assertEqual(set(['partial.googlesource.com',
593 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100594 self.c.get_partially_configured_hosts())
595 self.assertEqual(set(['chromium.googlesource.com',
596 'chrome-internal.googlesource.com']),
597 self.c.get_hosts_with_wrong_identities())
598
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100599 def test_report_no_problems(self):
600 self.test_analysis_nothing()
601 self.mock(sys, 'stdout', StringIO.StringIO())
602 self.assertFalse(self.c.find_and_report_problems())
603 self.assertEqual(sys.stdout.getvalue(), '')
604
605 def test_report(self):
606 self.test_analysis()
607 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200608 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
609 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100610 self.assertTrue(self.c.find_and_report_problems())
611 with open(os.path.join(os.path.dirname(__file__),
612 'git_cl_creds_check_report.txt')) as f:
613 expected = f.read()
614 def by_line(text):
615 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700616 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200617 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100618
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800619
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000620class TestGitCl(TestCase):
621 def setUp(self):
622 super(TestGitCl, self).setUp()
623 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700624 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000625 self.mock(git_cl, 'time_time',
626 lambda: self._mocked_call('time.time'))
627 self.mock(git_cl.metrics.collector, 'add_repeated',
628 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000629 self.mock(subprocess2, 'call', self._mocked_call)
630 self.mock(subprocess2, 'check_call', self._mocked_call)
631 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700632 self.mock(subprocess2, 'communicate',
633 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000634 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000635 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000636 self.mock(git_common, 'get_or_create_merge_base',
637 lambda *a: (
638 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000639 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000640 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000641 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
642 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100643 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000644 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700645 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000646 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000647 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
skobes6468b902016-10-24 08:45:10 -0700648 self.mock(git_cl.checkout, 'GitCheckout', GitCheckoutMock)
649 GitCheckoutMock.reset()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000650 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000651 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100652 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
653 lambda *args, **kwargs: self._mocked_call(
654 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700655 self.mock(git_cl.gerrit_util, 'GetChangeComments',
656 lambda *args, **kwargs: self._mocked_call(
657 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000658 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
659 lambda *args, **kwargs: self._mocked_call(
660 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100661 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700662 lambda h, i, reviewers, ccs, notify: self._mocked_call(
663 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700664 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700665 lambda h, i, msg=None, labels=None, notify=None:
666 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700667 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
668 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000669 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
670 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000671 self.mock(git_cl.gerrit_util, 'ValidAccounts',
672 lambda host, accounts:
673 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700674 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100675 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000676 # It's important to reset settings to not have inter-tests interference.
677 git_cl.settings = None
678
679 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000680 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100681 self.assertEquals([], self.calls)
682 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000683 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100684 raise
685 # Sadly, has_failed() returns True if this OR any other tests before this
686 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200687 git_cl.logging.error(
688 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100689 'There are un-consumed self.calls after this test has finished.\n'
690 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700691 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200692 'If you are already running only this test, then **first** fix the '
693 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100694 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700695 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100696 'and follow instructions above.\n' +
697 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000698 finally:
699 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000700
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000701 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000702 self.assertTrue(
703 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700704 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000705 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000706 expected_args, result = top
707
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000708 # Also logs otherwise it could get caught in a try/finally and be hard to
709 # diagnose.
710 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700711 N = 5
712 prior_calls = '\n '.join(
713 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
714 for i, c in enumerate(self._calls_done[-N:]))
715 following_calls = '\n '.join(
716 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
717 for i, c in enumerate(self.calls[:N]))
718 extended_msg = (
719 'A few prior calls:\n %s\n\n'
720 'This (expected):\n @%d: %r\n'
721 'This (actual):\n @%d: %r\n\n'
722 'A few following expected calls:\n %s' %
723 (prior_calls, len(self._calls_done), expected_args,
724 len(self._calls_done), args, following_calls))
725 git_cl.logging.error(extended_msg)
726
tandrii99a72f22016-08-17 14:33:24 -0700727 self.fail('@%d\n'
728 ' Expected: %r\n'
729 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700730 len(self._calls_done), expected_args, args))
731
732 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700733 if isinstance(result, Exception):
734 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000735 return result
736
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100737 def test_ask_for_explicit_yes_true(self):
738 self.calls = [
739 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
740 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
741 ]
742 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
743
tandrii48df5812016-10-17 03:55:37 -0700744 def test_LoadCodereviewSettingsFromFile_gerrit(self):
745 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
746 self.calls = [
747 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700748 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
749 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
750 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
751 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700752 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
753 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700754 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
755 CERR1),
756 ((['git', 'config', 'gerrit.host', 'true'],), ''),
757 ]
758 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
759
maruel@chromium.orga3353652011-11-30 14:26:57 +0000760 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000761 def _is_gerrit_calls(cls, gerrit=False):
762 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
763 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
764
765 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000766 def _git_post_upload_calls(cls):
767 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000768 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
769 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
770 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000771 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000772 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000773 ]
774
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000775 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000776 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000777 fake_ancestor = 'fake_ancestor'
778 fake_cl = 'fake_cl_for_patch'
779 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000780 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000781 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000782 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000783 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000784 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000785 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000786 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000787 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700788 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000789 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000790 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000791 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000792 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000793 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000794 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000795 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000796 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000797 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000798 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000799 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000800
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000801 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000802 def _gerrit_ensure_auth_calls(
803 cls, issue=None, skip_auth_check=False, short_hostname='chromium'):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000804 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000805 if skip_auth_check:
806 return [((cmd, ), 'true')]
807
tandrii5d48c322016-08-18 16:19:37 -0700808 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000809 if issue:
810 calls.extend([
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100811 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000812 ])
813 calls.extend([
814 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
815 ((['git', 'config', 'branch.master.remote'],), 'origin'),
816 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000817 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000818 ])
819 return calls
820
821 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100822 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200823 fetched_status=None, other_cl_owner=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000824 custom_cl_base=None, short_hostname='chromium'):
Aaron Gable13101a62018-02-09 13:20:41 -0800825 calls = cls._is_gerrit_calls(True)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100826 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200827 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200828 ((['git', 'config', 'branch.master.gerritissue'],),
829 CERR1 if issue is None else str(issue)),
830 ]
831
832 if custom_cl_base:
833 ancestor_revision = custom_cl_base
834 else:
835 # Determine ancestor_revision to be merge base.
836 ancestor_revision = 'fake_ancestor_sha'
837 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000838 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000839 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000840 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200841 'refs/remotes/origin/master'],), ancestor_revision),
842 ]
843
844 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000845 calls += cls._gerrit_ensure_auth_calls(
846 issue=issue, short_hostname=short_hostname)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100847
848 if issue:
849 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000850 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000851 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000852 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
853 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100854 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100855 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100856 'change_id': '123456789',
857 'current_revision': 'sha1_of_current_revision',
858 'revisions': { 'sha1_of_current_revision': {
859 'commit': {'message': fetched_description},
860 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100861 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100862 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100863 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100864 if fetched_status == 'ABANDONED':
865 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000866 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100867 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000868 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100869 ]
870 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100871 if other_cl_owner:
872 calls += [
873 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
874 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100875
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200876 calls += cls._git_sanity_checks(ancestor_revision, 'master',
877 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100878 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200879 ((['git', 'rev-parse', '--show-cdup'],), ''),
880 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000881
Aaron Gable7817f022017-12-12 09:43:17 -0800882 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
883 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200884 'M\t.gitignore\n'),
885 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100886 ]
887
888 if not issue:
889 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200890 ((['git', 'log', '--pretty=format:%s%n%n%b',
891 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000892 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100893 ]
894
895 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200896 ((['git', 'config', 'user.email'],), 'me@example.com'),
897 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
898 ([custom_cl_base] if custom_cl_base else
899 [ancestor_revision, 'HEAD']),),
900 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100901 ]
902 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000903
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000904 @classmethod
905 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700906 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000907 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700908 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100909 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000910 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000911 short_hostname='chromium',
912 labels=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000913 if post_amend_description is None:
914 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700915 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200916 # Determined in `_gerrit_base_calls`.
917 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
918
919 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000920
tandriia60502f2016-06-20 02:01:53 -0700921 if squash_mode == 'default':
922 calls.extend([
923 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
924 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
925 ])
926 elif squash_mode in ('override_squash', 'override_nosquash'):
927 calls.extend([
928 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
929 'true' if squash_mode == 'override_squash' else 'false'),
930 ])
931 else:
932 assert squash_mode in ('squash', 'nosquash')
933
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000934 # If issue is given, then description is fetched from Gerrit instead.
935 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000936 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200937 ((['git', 'log', '--pretty=format:%s\n\n%b',
938 ((custom_cl_base + '..') if custom_cl_base else
939 'fake_ancestor_sha..HEAD')],),
940 description),
941 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800942 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000943 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800944 else:
945 if not title:
946 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200947 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
948 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800949 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000950 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000951 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000952 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200953 (('DownloadGerritHook', False), ''),
954 # Amending of commit message to get the Change-Id.
955 ((['git', 'log', '--pretty=format:%s\n\n%b',
956 determined_ancestor_revision + '..HEAD'],),
957 description),
958 ((['git', 'commit', '--amend', '-m', description],), ''),
959 ((['git', 'log', '--pretty=format:%s\n\n%b',
960 determined_ancestor_revision + '..HEAD'],),
961 post_amend_description)
962 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000963 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000964 if not issue:
965 # Prompting to edit description on first upload.
966 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200967 ((['git', 'config', 'core.editor'],), ''),
968 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000969 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000970 ref_to_push = 'abcdef0123456789'
971 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200972 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
973 ((['git', 'config', 'branch.master.remote'],), 'origin'),
974 ]
975
976 if custom_cl_base is None:
977 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000978 ((['get_or_create_merge_base', 'master',
979 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000980 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200981 ]
982 parent = 'origin/master'
983 else:
984 calls += [
985 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
986 'refs/remotes/origin/master'],),
987 callError(1)), # Means not ancenstor.
988 (('ask_for_data',
989 'Do you take responsibility for cleaning up potential mess '
990 'resulting from proceeding with upload? Press Enter to upload, '
991 'or Ctrl+C to abort'), ''),
992 ]
993 parent = custom_cl_base
994
995 calls += [
996 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
997 '0123456789abcdef'),
998 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -0700999 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001000 ref_to_push),
1001 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001002 else:
1003 ref_to_push = 'HEAD'
1004
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001005 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001006 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001007 ((['git', 'rev-list',
1008 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1009 ref_to_push],),
1010 '1hashPerLine\n'),
1011 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001012
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001013 metrics_arguments = []
1014
Aaron Gableafd52772017-06-27 16:40:10 -07001015 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001016 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001017 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001018 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001019 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001020 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001021 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001022 else:
1023 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001024 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001025
Aaron Gable70f4e242017-06-26 10:45:59 -07001026 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001027 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001028 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001029
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001030 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001031 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001032 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001033 if short_hostname == 'chromium':
1034 # All reviwers and ccs get into ref_suffix.
1035 for r in sorted(reviewers):
1036 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001037 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001038 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1039 'joe@example.com'] + cc):
1040 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001041 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001042 reviewers, cc = [], []
1043 else:
1044 # TODO(crbug/877717): remove this case.
1045 calls += [
1046 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1047 sorted(reviewers) + ['joe@example.com',
1048 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1049 {
1050 e: {'email': e}
1051 for e in (reviewers + ['joe@example.com'] + cc)
1052 })
1053 ]
1054 for r in sorted(reviewers):
1055 if r != 'bad-account-or-email':
1056 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001057 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001058 reviewers.remove(r)
1059 for c in sorted(['joe@example.com'] + cc):
1060 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001061 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001062 if c in cc:
1063 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001064
Edward Lemur687ca902018-12-05 02:30:30 +00001065 for k, v in sorted((labels or {}).items()):
1066 ref_suffix += ',l=%s+%d' % (k, v)
1067 metrics_arguments.append('l=%s+%d' % (k, v))
1068
1069 if tbr:
1070 calls += [
1071 (('GetCodeReviewTbrScore',
1072 '%s-review.googlesource.com' % short_hostname,
1073 'my/repo'),
1074 2,),
1075 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001076
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001077 calls += [
1078 (('time.time',), 1000,),
1079 ((['git', 'push',
1080 'https://%s.googlesource.com/my/repo' % short_hostname,
1081 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1082 (('remote:\n'
1083 'remote: Processing changes: (\)\n'
1084 'remote: Processing changes: (|)\n'
1085 'remote: Processing changes: (/)\n'
1086 'remote: Processing changes: (-)\n'
1087 'remote: Processing changes: new: 1 (/)\n'
1088 'remote: Processing changes: new: 1, done\n'
1089 'remote:\n'
1090 'remote: New Changes:\n'
1091 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1092 ' XXX\n'
1093 'remote:\n'
1094 'To https://%s.googlesource.com/my/repo\n'
1095 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1096 ) % (short_hostname, short_hostname)),),
1097 (('time.time',), 2000,),
1098 (('add_repeated',
1099 'sub_commands',
1100 {
1101 'execution_time': 1000,
1102 'command': 'git push',
1103 'exit_code': 0,
1104 'arguments': sorted(metrics_arguments),
1105 }),
1106 None,),
1107 ]
1108
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001109 if squash:
1110 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001111 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001112 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001113 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001114 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001115 ((['git', 'config', 'branch.master.gerritsquashhash',
1116 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001117 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001118 # TODO(crbug/877717): this should never be used.
1119 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001120 calls += [
1121 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001122 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001123 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001124 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1125 notify),
1126 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001127 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001128 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001129 return calls
1130
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001131 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001132 self,
1133 upload_args,
1134 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001135 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001136 squash=True,
1137 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001138 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001139 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001140 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001141 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001142 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001143 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001144 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001145 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001146 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001147 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001148 short_hostname='chromium',
1149 labels=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001150 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001151 if squash_mode is None:
1152 if '--no-squash' in upload_args:
1153 squash_mode = 'nosquash'
1154 elif '--squash' in upload_args:
1155 squash_mode = 'squash'
1156 else:
1157 squash_mode = 'default'
1158
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001159 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001160 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001161 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001162 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001163 CookiesAuthenticatorMockFactory(
1164 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001165 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1166 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001167 self.mock(git_cl.gclient_utils, 'RunEditor',
1168 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001169 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1170 'DownloadGerritHook', force))
tandriia60502f2016-06-20 02:01:53 -07001171
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001172 self.calls = self._gerrit_base_calls(
1173 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001174 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001175 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001176 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001177 custom_cl_base=custom_cl_base,
1178 short_hostname=short_hostname)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001179 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001180 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1181 expected_content=description))
1182 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001183 self.calls += self._gerrit_upload_calls(
1184 description, reviewers, squash,
1185 squash_mode=squash_mode,
1186 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001187 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001188 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001189 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001190 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001191 short_hostname=short_hostname,
1192 labels=labels)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001193 # Uncomment when debugging.
1194 # print '\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls)))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001195 git_cl.main(['upload'] + upload_args)
1196
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001197 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001198 self._run_gerrit_upload_test(
1199 ['--no-squash'],
1200 'desc\n\nBUG=\n',
1201 [],
1202 squash=False,
1203 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
1204
1205 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001206 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001207 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001208 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001209 [],
tandriia60502f2016-06-20 02:01:53 -07001210 squash=False,
1211 squash_mode='override_nosquash',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001212 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001213
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001214 def test_gerrit_no_reviewer(self):
1215 self._run_gerrit_upload_test(
1216 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001217 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001218 [],
1219 squash=False,
1220 squash_mode='override_nosquash')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001221
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001222 def test_gerrit_no_reviewer_non_chromium_host(self):
1223 # TODO(crbug/877717): remove this test case.
1224 self._run_gerrit_upload_test(
1225 [],
1226 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1227 [],
1228 squash=False,
1229 squash_mode='override_nosquash',
1230 short_hostname='other')
1231
Nick Carter8692b182017-11-06 16:30:38 -08001232 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001233 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1234 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001235 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001236 'desc\n\nBUG=\n\nChange-Id: I123456789',
1237 squash=False,
1238 squash_mode='override_nosquash',
Nick Carter8692b182017-11-06 16:30:38 -08001239 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001240
ukai@chromium.orge8077812012-02-03 03:41:46 +00001241 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001242 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001243 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001244 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001245 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001246 squash=False,
1247 squash_mode='override_nosquash',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001248 notify=True)
ukai@chromium.orge8077812012-02-03 03:41:46 +00001249
1250 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001251 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1252 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001253 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001254 [],
bradnelsond975b302016-10-23 12:20:23 -07001255 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1256 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001257 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001258 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001259 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001260 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001261 tbr='reviewer@example.com',
1262 labels={'Code-Review': 2})
tandriia60502f2016-06-20 02:01:53 -07001263
1264 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001265 self._run_gerrit_upload_test(
1266 [],
1267 'desc\nBUG=\n\nChange-Id: 123456789',
1268 [],
1269 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001270
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001271 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001272 self._run_gerrit_upload_test(
1273 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001274 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001275 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001276 squash=True,
1277 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001278
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001279 def test_gerrit_upload_squash_first_with_labels(self):
1280 self._run_gerrit_upload_test(
1281 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1282 'desc\nBUG=\n\nChange-Id: 123456789',
1283 [],
1284 squash=True,
1285 expected_upstream_ref='origin/master',
1286 labels={'Commit-Queue': 1, 'Auto-Submit': 1})
1287
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001288 def test_gerrit_upload_squash_first_against_rev(self):
1289 custom_cl_base = 'custom_cl_base_rev_or_branch'
1290 self._run_gerrit_upload_test(
1291 ['--squash', custom_cl_base],
1292 'desc\nBUG=\n\nChange-Id: 123456789',
1293 [],
1294 squash=True,
1295 expected_upstream_ref='origin/master',
1296 custom_cl_base=custom_cl_base)
1297 self.assertIn(
1298 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1299 sys.stdout.getvalue())
1300
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001301 def test_gerrit_upload_squash_reupload(self):
1302 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001303 self._run_gerrit_upload_test(
1304 ['--squash'],
1305 description,
1306 [],
1307 squash=True,
1308 expected_upstream_ref='origin/master',
1309 issue=123456)
1310
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001311 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1312 self.mock(git_cl, 'DieWithError',
1313 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1314 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1315 with self.assertRaises(SystemExitMock):
1316 self._run_gerrit_upload_test(
1317 ['--squash'],
1318 description,
1319 [],
1320 squash=True,
1321 expected_upstream_ref='origin/master',
1322 issue=123456,
1323 fetched_status='ABANDONED')
1324
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001325 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1326 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1327 lambda *_, **__: {'email': 'yet-another@example.com'})
1328 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1329 self._run_gerrit_upload_test(
1330 ['--squash'],
1331 description,
1332 [],
1333 squash=True,
1334 expected_upstream_ref='origin/master',
1335 issue=123456,
1336 other_cl_owner='other@example.com')
1337 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001338 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001339 'authenticate to Gerrit as yet-another@example.com.\n'
1340 'Uploading may fail due to lack of permissions',
1341 git_cl.sys.stdout.getvalue())
1342
rmistry@google.com2dd99862015-06-22 12:22:18 +00001343 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001344 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001345 def mock_run_git(*args, **_kwargs):
1346 if args[0] == ['for-each-ref',
1347 '--format=%(refname:short) %(upstream:short)',
1348 'refs/heads']:
1349 # Create a local branch dependency tree that looks like this:
1350 # test1 -> test2 -> test3 -> test4 -> test5
1351 # -> test3.1
1352 # test6 -> test0
1353 branch_deps = [
1354 'test2 test1', # test1 -> test2
1355 'test3 test2', # test2 -> test3
1356 'test3.1 test2', # test2 -> test3.1
1357 'test4 test3', # test3 -> test4
1358 'test5 test4', # test4 -> test5
1359 'test6 test0', # test0 -> test6
1360 'test7', # test7
1361 ]
1362 return '\n'.join(branch_deps)
1363 self.mock(git_cl, 'RunGit', mock_run_git)
1364
1365 class RecordCalls:
1366 times_called = 0
1367 record_calls = RecordCalls()
1368 def mock_CMDupload(*args, **_kwargs):
1369 record_calls.times_called += 1
1370 return 0
1371 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1372
1373 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001374 (('ask_for_data', 'This command will checkout all dependent branches '
1375 'and run "git cl upload". Press Enter to continue, '
1376 'or Ctrl+C to abort'), ''),
1377 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001378
1379 class MockChangelist():
1380 def __init__(self):
1381 pass
1382 def GetBranch(self):
1383 return 'test1'
1384 def GetIssue(self):
1385 return '123'
1386 def GetPatchset(self):
1387 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001388 def IsGerrit(self):
1389 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001390
1391 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1392 # CMDupload should have been called 5 times because of 5 dependent branches.
1393 self.assertEquals(5, record_calls.times_called)
1394 self.assertEquals(0, ret)
1395
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001396 def test_gerrit_change_id(self):
1397 self.calls = [
1398 ((['git', 'write-tree'], ),
1399 'hashtree'),
1400 ((['git', 'rev-parse', 'HEAD~0'], ),
1401 'branch-parent'),
1402 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1403 'A B <a@b.org> 1456848326 +0100'),
1404 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1405 'C D <c@d.org> 1456858326 +0100'),
1406 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1407 'hashchange'),
1408 ]
1409 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1410 self.assertEqual(change_id, 'Ihashchange')
1411
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001412 def test_desecription_append_footer(self):
1413 for init_desc, footer_line, expected_desc in [
1414 # Use unique desc first lines for easy test failure identification.
1415 ('foo', 'R=one', 'foo\n\nR=one'),
1416 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1417 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1418 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1419 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1420 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1421 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1422 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1423 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1424 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1425 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1426 ]:
1427 desc = git_cl.ChangeDescription(init_desc)
1428 desc.append_footer(footer_line)
1429 self.assertEqual(desc.description, expected_desc)
1430
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001431 def test_update_reviewers(self):
1432 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001433 ('foo', [], [],
1434 'foo'),
1435 ('foo\nR=xx', [], [],
1436 'foo\nR=xx'),
1437 ('foo\nTBR=xx', [], [],
1438 'foo\nTBR=xx'),
1439 ('foo', ['a@c'], [],
1440 'foo\n\nR=a@c'),
1441 ('foo\nR=xx', ['a@c'], [],
1442 'foo\n\nR=a@c, xx'),
1443 ('foo\nTBR=xx', ['a@c'], [],
1444 'foo\n\nR=a@c\nTBR=xx'),
1445 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1446 'foo\n\nR=a@c, yy\nTBR=xx'),
1447 ('foo\nBUG=', ['a@c'], [],
1448 'foo\nBUG=\nR=a@c'),
1449 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1450 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1451 ('foo', ['a@c', 'b@c'], [],
1452 'foo\n\nR=a@c, b@c'),
1453 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1454 'foo\nBar\n\nR=c@c\nBUG='),
1455 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1456 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001457 # Same as the line before, but full of whitespaces.
1458 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001459 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001460 'foo\nBar\n\nR=c@c\n BUG =',
1461 ),
1462 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001463 ('foo BUG=allo R=joe ', ['c@c'], [],
1464 'foo BUG=allo R=joe\n\nR=c@c'),
1465 # Redundant TBRs get promoted to Rs
1466 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1467 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001468 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001469 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001470 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001471 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001472 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001473 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001474 actual.append(obj.description)
1475 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001476
Nodir Turakulov23b82142017-11-16 11:04:25 -08001477 def test_get_hash_tags(self):
1478 cases = [
1479 ('', []),
1480 ('a', []),
1481 ('[a]', ['a']),
1482 ('[aa]', ['aa']),
1483 ('[a ]', ['a']),
1484 ('[a- ]', ['a']),
1485 ('[a- b]', ['a-b']),
1486 ('[a--b]', ['a-b']),
1487 ('[a', []),
1488 ('[a]x', ['a']),
1489 ('[aa]x', ['aa']),
1490 ('[a b]', ['a-b']),
1491 ('[a b]', ['a-b']),
1492 ('[a__b]', ['a-b']),
1493 ('[a] x', ['a']),
1494 ('[a][b]', ['a', 'b']),
1495 ('[a] [b]', ['a', 'b']),
1496 ('[a][b]x', ['a', 'b']),
1497 ('[a][b] x', ['a', 'b']),
1498 ('[a]\n[b]', ['a']),
1499 ('[a\nb]', []),
1500 ('[a][', ['a']),
1501 ('Revert "[a] feature"', ['a']),
1502 ('Reland "[a] feature"', ['a']),
1503 ('Revert: [a] feature', ['a']),
1504 ('Reland: [a] feature', ['a']),
1505 ('Revert "Reland: [a] feature"', ['a']),
1506 ('Foo: feature', ['foo']),
1507 ('Foo Bar: feature', ['foo-bar']),
1508 ('Revert "Foo bar: feature"', ['foo-bar']),
1509 ('Reland "Foo bar: feature"', ['foo-bar']),
1510 ]
1511 for desc, expected in cases:
1512 change_desc = git_cl.ChangeDescription(desc)
1513 actual = change_desc.get_hash_tags()
1514 self.assertEqual(
1515 actual,
1516 expected,
1517 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1518
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001519
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001520 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001521 self.assertEqual(None, git_cl.GetTargetRef(None,
1522 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001523 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001524
wittman@chromium.org455dc922015-01-26 20:15:50 +00001525 # Check default target refs for branches.
1526 self.assertEqual('refs/heads/master',
1527 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001528 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001529 self.assertEqual('refs/heads/master',
1530 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001531 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001532 self.assertEqual('refs/heads/master',
1533 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001534 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001535 self.assertEqual('refs/branch-heads/123',
1536 git_cl.GetTargetRef('origin',
1537 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001538 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001539 self.assertEqual('refs/diff/test',
1540 git_cl.GetTargetRef('origin',
1541 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001542 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001543 self.assertEqual('refs/heads/chrome/m42',
1544 git_cl.GetTargetRef('origin',
1545 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001546 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001547
1548 # Check target refs for user-specified target branch.
1549 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1550 'refs/remotes/branch-heads/123'):
1551 self.assertEqual('refs/branch-heads/123',
1552 git_cl.GetTargetRef('origin',
1553 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001554 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001555 for branch in ('origin/master', 'remotes/origin/master',
1556 'refs/remotes/origin/master'):
1557 self.assertEqual('refs/heads/master',
1558 git_cl.GetTargetRef('origin',
1559 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001560 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001561 for branch in ('master', 'heads/master', 'refs/heads/master'):
1562 self.assertEqual('refs/heads/master',
1563 git_cl.GetTargetRef('origin',
1564 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001565 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001566
wychen@chromium.orga872e752015-04-28 23:42:18 +00001567 def test_patch_when_dirty(self):
1568 # Patch when local tree is dirty
1569 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1570 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1571
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001572 @staticmethod
1573 def _get_gerrit_codereview_server_calls(branch, value=None,
1574 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001575 detect_branch=True,
1576 detect_server=True):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001577 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1578
1579 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1580 """
1581 calls = []
1582 if detect_branch:
1583 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001584 if detect_server:
1585 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1586 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001587 if value is None:
1588 calls += [
1589 ((['git', 'config', 'branch.' + branch + '.merge'],),
1590 'refs/heads' + branch),
1591 ((['git', 'config', 'branch.' + branch + '.remote'],),
1592 'origin'),
1593 ((['git', 'config', 'remote.origin.url'],),
1594 'https://%s.googlesource.com/my/repo' % git_short_host),
1595 ]
1596 return calls
1597
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001598 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001599 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001600 detect_gerrit_server=False,
1601 actual_codereview=None,
1602 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001603 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001604 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1605
tandriidf09a462016-08-18 16:23:55 -07001606 if new_branch:
1607 self.calls = [((['git', 'new-branch', 'master'],), ''),]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001608
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001609 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001610 self.calls += [
1611 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001612 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001613 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001614
1615 if not force_codereview and not codereview_in_url:
1616 # These calls detect codereview to use.
1617 self.calls += [
1618 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001619 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001620 ]
1621 if detect_gerrit_server:
1622 self.calls += self._get_gerrit_codereview_server_calls(
1623 'master', git_short_host=git_short_host,
1624 detect_branch=not new_branch and force_codereview)
1625 actual_codereview = 'gerrit'
1626
1627 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001628 self.calls += [
1629 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001630 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001631 {
1632 'current_revision': '7777777777',
1633 'revisions': {
1634 '1111111111': {
1635 '_number': 1,
1636 'fetch': {'http': {
1637 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1638 'ref': 'refs/changes/56/123456/1',
1639 }},
1640 },
1641 '7777777777': {
1642 '_number': 7,
1643 'fetch': {'http': {
1644 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1645 'ref': 'refs/changes/56/123456/7',
1646 }},
1647 },
1648 },
1649 }),
1650 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001651
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001652 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001653 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001654 self.calls += [
1655 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1656 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001657 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001658 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001659 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001660 ((['git', 'config', 'branch.master.gerritserver',
1661 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001662 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001663 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1664 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1665 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001666 ]
1667 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1668
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001669 def test_patch_gerrit_new_branch(self):
1670 self._patch_common(
1671 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1672 self.calls += [
1673 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1674 'refs/changes/56/123456/7'],), ''),
1675 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1676 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1677 ''),
1678 ((['git', 'config', 'branch.master.gerritserver',
1679 'https://chromium-review.googlesource.com'],), ''),
1680 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1681 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1682 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1683 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1684 ]
1685 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1686
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001687 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001688 self._patch_common(
1689 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001690 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001691 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001692 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001693 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001694 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001695 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001696 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001697 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001698 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001699 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1700 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1701 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001702 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001703 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001704
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001705 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001706 self.calls += self._get_gerrit_codereview_server_calls(
1707 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001708 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001709 actual_codereview='gerrit', git_short_host='else',
1710 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001711 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001712 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001713 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001714 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001715 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001716 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001717 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001718 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001719 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001720 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1721 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1722 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001723 ]
1724 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001725 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001726
Aaron Gable697a91b2018-01-19 15:20:15 -08001727 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001728 self.calls += self._get_gerrit_codereview_server_calls(
1729 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001730 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001731 actual_codereview='gerrit', git_short_host='else',
1732 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001733 self.calls += [
1734 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1735 'refs/changes/56/123456/1'],), ''),
1736 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1737 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1738 ''),
1739 ((['git', 'config', 'branch.master.gerritserver',
1740 'https://else-review.googlesource.com'],), ''),
1741 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1742 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1743 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1744 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1745 ]
1746 self.assertEqual(git_cl.main(
1747 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1748 0)
1749
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001750 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001751 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001752 self.calls += [
1753 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001754 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001755 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1756 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1757 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001758 ]
1759 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001760 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001761
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001762 def test_patch_gerrit_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001763 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001764 raise git_cl.gerrit_util.GerritError(404, '')
1765 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1766
tandriic2405f52016-10-10 08:13:15 -07001767 self.calls = [
1768 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandriic2405f52016-10-10 08:13:15 -07001769 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001770 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1771 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1772 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1773 ((['git', 'config', 'remote.origin.url'],),
1774 'https://chromium.googlesource.com/my/repo'),
1775 ((['DieWithError',
1776 'change 123456 at https://chromium-review.googlesource.com does not '
1777 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001778 ]
1779 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001780 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001781
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001782 def _checkout_calls(self):
1783 return [
1784 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001785 'branch\\..*\\.gerritissue'], ),
1786 ('branch.ger-branch.gerritissue 123456\n'
1787 'branch.gbranch654.gerritissue 654321\n')),
1788 ]
1789
1790 def test_checkout_gerrit(self):
1791 """Tests git cl checkout <issue>."""
1792 self.calls = self._checkout_calls()
1793 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1794 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1795
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001796 def test_checkout_not_found(self):
1797 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001798 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001799 self.calls = self._checkout_calls()
1800 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1801
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001802 def test_checkout_no_branch_issues(self):
1803 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001804 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001805 self.calls = [
1806 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001807 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001808 ]
1809 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1810
tandrii@chromium.org28253532016-04-14 13:46:56 +00001811 def _test_gerrit_ensure_authenticated_common(self, auth,
1812 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001813 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1814 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1815 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001816 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001817 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001818 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00001819 cl.branch = 'master'
1820 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001821 cl.lookedup_issue = True
1822 return cl
1823
1824 def test_gerrit_ensure_authenticated_missing(self):
1825 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001826 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001827 })
1828 self.calls.append(
1829 ((['DieWithError',
1830 'Credentials for the following hosts are required:\n'
1831 ' chromium-review.googlesource.com\n'
1832 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01001833 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001834 'https://chromium-review.googlesource.com/new-password'],), ''),)
1835 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1836
1837 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001838 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001839 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001840 'chromium.googlesource.com':
1841 ('git-one.example.com', None, 'secret1'),
1842 'chromium-review.googlesource.com':
1843 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001844 })
1845 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001846 (('ask_for_data', 'If you know what you are doing '
1847 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001848 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1849
1850 def test_gerrit_ensure_authenticated_ok(self):
1851 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001852 'chromium.googlesource.com':
1853 ('git-same.example.com', None, 'secret'),
1854 'chromium-review.googlesource.com':
1855 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001856 })
1857 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1858
tandrii@chromium.org28253532016-04-14 13:46:56 +00001859 def test_gerrit_ensure_authenticated_skipped(self):
1860 cl = self._test_gerrit_ensure_authenticated_common(
1861 auth={}, skip_auth_check=True)
1862 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1863
Eric Boren2fb63102018-10-05 13:05:03 +00001864 def test_gerrit_ensure_authenticated_bearer_token(self):
1865 cl = self._test_gerrit_ensure_authenticated_common(auth={
1866 'chromium.googlesource.com':
1867 ('', None, 'secret'),
1868 'chromium-review.googlesource.com':
1869 ('', None, 'secret'),
1870 })
1871 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1872 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1873 'chromium.googlesource.com')
1874 self.assertTrue('Bearer' in header)
1875
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001876 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001877 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001878 lambda h, i, labels, notify=None:
1879 self._mocked_call(['SetReview', h, i, labels, notify]))
1880
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001881 self.calls = [
1882 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001883 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001884 ((['git', 'config', 'branch.feature.gerritserver'],),
1885 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001886 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
1887 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1888 ((['git', 'config', 'remote.origin.url'],),
1889 'https://chromium.googlesource.com/infra/infra.git'),
1890 ((['SetReview', 'chromium-review.googlesource.com',
1891 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001892 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001893 ]
tandriid9e5ce52016-07-13 02:32:59 -07001894
1895 def test_cmd_set_commit_gerrit_clear(self):
1896 self._cmd_set_commit_gerrit_common(0)
1897 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1898
1899 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001900 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001901 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1902
tandriid9e5ce52016-07-13 02:32:59 -07001903 def test_cmd_set_commit_gerrit(self):
1904 self._cmd_set_commit_gerrit_common(2)
1905 self.assertEqual(0, git_cl.main(['set-commit']))
1906
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001907 def test_description_display(self):
1908 out = StringIO.StringIO()
1909 self.mock(git_cl.sys, 'stdout', out)
1910
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001911 self.mock(git_cl, 'Changelist', ChangelistMock)
1912 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001913
1914 self.assertEqual(0, git_cl.main(['description', '-d']))
1915 self.assertEqual('foo\n', out.getvalue())
1916
iannucci3c972b92016-08-17 13:24:10 -07001917 def test_StatusFieldOverrideIssueMissingArgs(self):
1918 out = StringIO.StringIO()
1919 self.mock(git_cl.sys, 'stderr', out)
1920
1921 try:
1922 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
1923 except SystemExit as ex:
1924 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001925 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001926
1927 out = StringIO.StringIO()
1928 self.mock(git_cl.sys, 'stderr', out)
1929
1930 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001931 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07001932 except SystemExit as ex:
1933 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001934 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001935
1936 def test_StatusFieldOverrideIssue(self):
1937 out = StringIO.StringIO()
1938 self.mock(git_cl.sys, 'stdout', out)
1939
1940 def assertIssue(cl_self, *_args):
1941 self.assertEquals(cl_self.issue, 1)
1942 return 'foobar'
1943
1944 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07001945 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001946 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001947 0)
iannucci3c972b92016-08-17 13:24:10 -07001948 self.assertEqual(out.getvalue(), 'foobar\n')
1949
iannuccie53c9352016-08-17 14:40:40 -07001950 def test_SetCloseOverrideIssue(self):
1951 def assertIssue(cl_self, *_args):
1952 self.assertEquals(cl_self.issue, 1)
1953 return 'foobar'
1954
1955 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
1956 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07001957 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00001958 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001959
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001960 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001961 out = StringIO.StringIO()
1962 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001963 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001964 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
1965 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
1966 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
1967 ((['git', 'config', 'remote.origin.url'],),
1968 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001969 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001970 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001971 {
1972 'current_revision': 'sha1',
1973 'revisions': {'sha1': {
1974 'commit': {'message': 'foobar'},
1975 }},
1976 }),
1977 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001978 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001979 'description',
1980 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
1981 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001982 self.assertEqual('foobar\n', out.getvalue())
1983
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001984 def test_description_set_raw(self):
1985 out = StringIO.StringIO()
1986 self.mock(git_cl.sys, 'stdout', out)
1987
1988 self.mock(git_cl, 'Changelist', ChangelistMock)
1989 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
1990
1991 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
1992 self.assertEqual('hihi', ChangelistMock.desc)
1993
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001994 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001995 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001996
1997 def RunEditor(desc, _, **kwargs):
1998 self.assertEquals(
1999 '# Enter a description of the change.\n'
2000 '# This will be displayed on the codereview site.\n'
2001 '# The first line will also be used as the subject of the review.\n'
2002 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002003 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002004 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002005 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002006 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002007 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002008
dsansomee2d6fd92016-09-08 00:10:47 -07002009 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002010 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002011
2012 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2013 self.mock(git_cl.Changelist, 'GetDescription',
2014 lambda *args: current_desc)
2015 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2016 UpdateDescriptionRemote)
2017 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2018
2019 self.calls = [
2020 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002021 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002022 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2023 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002024 ((['git', 'config', 'core.editor'],), 'vi'),
2025 ]
2026 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2027
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002028 def test_description_set_stdin(self):
2029 out = StringIO.StringIO()
2030 self.mock(git_cl.sys, 'stdout', out)
2031
2032 self.mock(git_cl, 'Changelist', ChangelistMock)
2033 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2034
2035 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2036 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2037
kmarshall3bff56b2016-06-06 18:31:47 -07002038 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002039 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2040
kmarshall3bff56b2016-06-06 18:31:47 -07002041 self.calls = \
2042 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2043 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002044 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2045 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
tandrii33a46ff2016-08-23 05:53:40 -07002046 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002047 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2048 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2049 ((['git', 'branch', '-D', 'foo'],), '')]
2050
kmarshall3bff56b2016-06-06 18:31:47 -07002051 self.mock(git_cl, 'get_cl_statuses',
2052 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002053 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2054 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2055 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002056
2057 self.assertEqual(0, git_cl.main(['archive', '-f']))
2058
2059 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002060 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002061 self.calls = \
2062 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2063 'refs/heads/master'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002064 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
kmarshall3bff56b2016-06-06 18:31:47 -07002065 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2066
kmarshall9249e012016-08-23 12:02:16 -07002067 self.mock(git_cl, 'get_cl_statuses',
2068 lambda branches, fine_grained, max_processes:
2069 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2070
2071 self.assertEqual(1, git_cl.main(['archive', '-f']))
2072
2073 def test_archive_dry_run(self):
2074 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2075
2076 self.calls = \
2077 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2078 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002079 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2080 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002081 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2082 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002083
2084 self.mock(git_cl, 'get_cl_statuses',
2085 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002086 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2087 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2088 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002089
kmarshall9249e012016-08-23 12:02:16 -07002090 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2091
2092 def test_archive_no_tags(self):
2093 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2094
2095 self.calls = \
2096 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2097 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002098 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
2099 ((['git', 'config', 'branch.foo.gerritissue'],), '456'),
2100 ((['git', 'config', 'branch.bar.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002101 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2102 ((['git', 'branch', '-D', 'foo'],), '')]
2103
2104 self.mock(git_cl, 'get_cl_statuses',
2105 lambda branches, fine_grained, max_processes:
2106 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2107 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2108 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2109
2110 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002111
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002112 def test_cmd_issue_erase_existing(self):
2113 out = StringIO.StringIO()
2114 self.mock(git_cl.sys, 'stdout', out)
2115 self.calls = [
2116 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002117 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002118 # Let this command raise exception (retcode=1) - it should be ignored.
2119 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002120 CERR1),
2121 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2122 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002123 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2124 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2125 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002126 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002127 ]
2128 self.assertEqual(0, git_cl.main(['issue', '0']))
2129
Aaron Gable400e9892017-07-12 15:31:21 -07002130 def test_cmd_issue_erase_existing_with_change_id(self):
2131 out = StringIO.StringIO()
2132 self.mock(git_cl.sys, 'stdout', out)
2133 self.mock(git_cl.Changelist, 'GetDescription',
2134 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2135 self.calls = [
2136 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002137 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
Aaron Gable400e9892017-07-12 15:31:21 -07002138 # Let this command raise exception (retcode=1) - it should be ignored.
2139 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2140 CERR1),
2141 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2142 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2143 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2144 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2145 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002146 ((['git', 'log', '-1', '--format=%B'],),
2147 'This is a description\n\nChange-Id: Ideadbeef'),
2148 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002149 ]
2150 self.assertEqual(0, git_cl.main(['issue', '0']))
2151
phajdan.jre328cf92016-08-22 04:12:17 -07002152 def test_cmd_issue_json(self):
2153 out = StringIO.StringIO()
2154 self.mock(git_cl.sys, 'stdout', out)
2155 self.calls = [
2156 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002157 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2158 ((['git', 'config', 'branch.feature.gerritserver'],),
2159 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002160 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002161 {'issue': 123,
2162 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002163 ''),
2164 ]
2165 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2166
tandrii8c5a3532016-11-04 07:52:02 -07002167 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2168 self.mock(git_cl.Changelist, 'GetChange',
2169 lambda _, *a: (
2170 self._mocked_call(['GetChange']+list(a))))
2171 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2172 lambda *_, **__: (
2173 self._mocked_call(['DoGetTryMasters'])))
2174 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2175 lambda _, s: self._mocked_call(['SetCQState', s]))
2176
tandrii8c5a3532016-11-04 07:52:02 -07002177 self.calls = [
2178 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002179 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2180 ((['git', 'config', 'branch.feature.gerritserver'],),
2181 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002182 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2183 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2184 ((['git', 'config', 'remote.origin.url'],),
2185 'https://chromium.googlesource.com/depot_tools'),
2186 (('GetChangeDetail', 'chromium-review.googlesource.com',
2187 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002188 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2189 'project': 'depot_tools',
2190 'status': 'OPEN',
2191 'owner': {'email': 'owner@e.mail'},
2192 'revisions': {
2193 'deadbeaf': {
2194 '_number': 6,
2195 },
2196 'beeeeeef': {
2197 '_number': 7,
2198 'fetch': {'http': {
2199 'url': 'https://chromium.googlesource.com/depot_tools',
2200 'ref': 'refs/changes/56/123456/7'
2201 }},
2202 },
2203 },
2204 }),
tandrii8c5a3532016-11-04 07:52:02 -07002205 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2206 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2207 ((['get_or_create_merge_base', 'feature', 'feature'],),
2208 'fake_ancestor_sha'),
2209 ((['GetChange', 'fake_ancestor_sha', None], ),
2210 git_cl.presubmit_support.GitChange(
2211 '', '', '', '', '', '', '', '')),
2212 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2213 ((['DoGetTryMasters'], ), None),
2214 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2215 ]
2216 out = StringIO.StringIO()
2217 self.mock(git_cl.sys, 'stdout', out)
2218 self.assertEqual(0, git_cl.main(['try']))
2219 self.assertEqual(
2220 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002221 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002222 'https://chromium-review.googlesource.com/123456\n')
2223
tandrii8c5a3532016-11-04 07:52:02 -07002224 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2225 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2226 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2227
tandrii8c5a3532016-11-04 07:52:02 -07002228 self.calls = [
2229 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002230 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2231 ((['git', 'config', 'branch.feature.gerritserver'],),
2232 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002233 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2234 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2235 ((['git', 'config', 'remote.origin.url'],),
2236 'https://chromium.googlesource.com/depot_tools'),
2237 (('GetChangeDetail', 'chromium-review.googlesource.com',
2238 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002239 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002240 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002241 'status': 'OPEN',
2242 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002243 'revisions': {
2244 'deadbeaf': {
2245 '_number': 6,
2246 },
2247 'beeeeeef': {
2248 '_number': 7,
2249 'fetch': {'http': {
2250 'url': 'https://chromium.googlesource.com/depot_tools',
2251 'ref': 'refs/changes/56/123456/7'
2252 }},
2253 },
2254 },
2255 }),
2256 ]
2257
2258 def _buildbucket_retry(*_, **kw):
2259 # self.maxDiff = 10000
2260 body = json.loads(kw['body'])
2261 self.assertEqual(len(body['builds']), 1)
2262 build = body['builds'][0]
2263 params = json.loads(build.pop('parameters_json'))
2264 self.assertEqual(params, {
2265 u'builder_name': u'win',
2266 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2267 u'revision': None}],
2268 u'properties': {
2269 u'category': u'git_cl_try',
2270 u'key': u'val',
2271 u'json': [{u'a': 1}, None],
tandrii8c5a3532016-11-04 07:52:02 -07002272
2273 u'patch_gerrit_url':
2274 u'https://chromium-review.googlesource.com',
2275 u'patch_issue': 123456,
2276 u'patch_project': u'depot_tools',
2277 u'patch_ref': u'refs/changes/56/123456/7',
2278 u'patch_repository_url':
2279 u'https://chromium.googlesource.com/depot_tools',
2280 u'patch_set': 7,
2281 u'patch_storage': u'gerrit',
2282 }
2283 })
2284 self.assertEqual(build, {
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002285 u'bucket': u'luci.chromium.try',
tandrii8c5a3532016-11-04 07:52:02 -07002286 u'client_operation_id': u'uuid4',
2287 u'tags': [
2288 u'builder:win',
2289 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2290 u'user_agent:git_cl_try',
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002291 ],
tandrii8c5a3532016-11-04 07:52:02 -07002292 })
2293
2294 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2295
2296 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2297 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002298 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002299 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2300 self.assertRegexpMatches(
2301 git_cl.sys.stdout.getvalue(),
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002302 'Tried jobs on:\nBucket: luci.chromium.try')
tandriide281ae2016-10-12 06:02:30 -07002303
qyearsley123a4682016-10-26 09:12:17 -07002304 def test_git_cl_try_bots_on_multiple_masters(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002305 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2306 self.mock(git_cl.Changelist, 'GetChange',
2307 lambda _, *a: (
2308 self._mocked_call(['GetChange']+list(a))))
2309 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2310 lambda *_, **__: (
2311 self._mocked_call(['DoGetTryMasters'])))
2312 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2313 lambda _, s: self._mocked_call(['SetCQState', s]))
2314
qyearsley123a4682016-10-26 09:12:17 -07002315 self.calls = [
2316 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002317 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2318 ((['git', 'config', 'branch.feature.gerritserver'],),
2319 'https://chromium-review.googlesource.com'),
2320 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2321 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2322 ((['git', 'config', 'remote.origin.url'],),
2323 'https://chromium.googlesource.com/depot_tools'),
2324 (('GetChangeDetail', 'chromium-review.googlesource.com',
2325 'depot_tools~123456',
2326 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2327 'project': 'depot_tools',
2328 'status': 'OPEN',
2329 'owner': {'email': 'owner@e.mail'},
2330 'revisions': {
2331 'deadbeaf': {
2332 '_number': 6,
2333 },
2334 'beeeeeef': {
2335 '_number': 7,
2336 'fetch': {'http': {
2337 'url': 'https://chromium.googlesource.com/depot_tools',
2338 'ref': 'refs/changes/56/123456/7'
2339 }},
2340 },
2341 },
2342 }),
qyearsley123a4682016-10-26 09:12:17 -07002343 ]
2344
2345 def _buildbucket_retry(*_, **kw):
2346 body = json.loads(kw['body'])
2347 self.assertEqual(len(body['builds']), 2)
2348
Nodir Turakulovb422e682018-02-20 22:51:30 -08002349 self.assertEqual(body['builds'][0]['bucket'], 'bucket1')
2350 params = json.loads(body['builds'][0]['parameters_json'])
2351 self.assertEqual(params['builder_name'], 'builder1')
qyearsley123a4682016-10-26 09:12:17 -07002352
Nodir Turakulovb422e682018-02-20 22:51:30 -08002353 self.assertEqual(body['builds'][1]['bucket'], 'bucket2')
2354 params = json.loads(body['builds'][1]['parameters_json'])
2355 self.assertEqual(params['builder_name'], 'builder2')
qyearsley123a4682016-10-26 09:12:17 -07002356
2357 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2358
2359 self.mock(git_cl.urllib2, 'urlopen', lambda _: StringIO.StringIO(
Nodir Turakulovb422e682018-02-20 22:51:30 -08002360 json.dumps({
2361 'builder1': {'bucket': 'bucket1'},
2362 'builder2': {'bucket': 'bucket2'},
2363 })))
qyearsley123a4682016-10-26 09:12:17 -07002364
2365 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2366 self.assertEqual(
2367 0, git_cl.main(['try', '-b', 'builder1', '-b', 'builder2']))
2368 self.assertEqual(
2369 git_cl.sys.stdout.getvalue(),
2370 'Tried jobs on:\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002371 'Bucket: bucket1\n'
qyearsley123a4682016-10-26 09:12:17 -07002372 ' builder1: []\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002373 'Bucket: bucket2\n'
qyearsley123a4682016-10-26 09:12:17 -07002374 ' builder2: []\n'
2375 'To see results here, run: git cl try-results\n'
2376 'To see results in browser, run: git cl web\n')
2377
tandrii16e0b4e2016-06-07 10:34:28 -07002378 def _common_GerritCommitMsgHookCheck(self):
2379 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2380 self.mock(git_cl.os.path, 'abspath',
2381 lambda path: self._mocked_call(['abspath', path]))
2382 self.mock(git_cl.os.path, 'exists',
2383 lambda path: self._mocked_call(['exists', path]))
2384 self.mock(git_cl.gclient_utils, 'FileRead',
2385 lambda path: self._mocked_call(['FileRead', path]))
2386 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2387 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2388 self.calls = [
2389 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2390 ((['abspath', '../'],), '/abs/git_repo_root'),
2391 ]
2392 return git_cl.Changelist(codereview='gerrit', issue=123)
2393
2394 def test_GerritCommitMsgHookCheck_custom_hook(self):
2395 cl = self._common_GerritCommitMsgHookCheck()
2396 self.calls += [
2397 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2398 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2399 '#!/bin/sh\necho "custom hook"')
2400 ]
2401 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2402
2403 def test_GerritCommitMsgHookCheck_not_exists(self):
2404 cl = self._common_GerritCommitMsgHookCheck()
2405 self.calls += [
2406 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2407 ]
2408 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2409
2410 def test_GerritCommitMsgHookCheck(self):
2411 cl = self._common_GerritCommitMsgHookCheck()
2412 self.calls += [
2413 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2414 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2415 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002416 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002417 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2418 ''),
2419 ]
2420 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2421
tandriic4344b52016-08-29 06:04:54 -07002422 def test_GerritCmdLand(self):
2423 self.calls += [
2424 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2425 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2426 'deadbeaf'),
2427 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2428 ((['git', 'config', 'branch.feature.gerritserver'],),
2429 'chromium-review.googlesource.com'),
2430 ]
2431 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2432 cl._codereview_impl._GetChangeDetail = lambda _: {
2433 'labels': {},
2434 'current_revision': 'deadbeaf',
2435 }
agable32978d92016-11-01 12:55:02 -07002436 cl._codereview_impl._GetChangeCommit = lambda: {
2437 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002438 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002439 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2440 }
tandriic4344b52016-08-29 06:04:54 -07002441 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002442 out = StringIO.StringIO()
2443 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002444 self.assertEqual(0, cl.CMDLand(force=True,
2445 bypass_hooks=True,
2446 verbose=True,
2447 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002448 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002449 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002450
tandrii221ab252016-10-06 08:12:04 -07002451 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002452 '9000': {
2453 'id': '9000',
2454 'bucket': 'master.x.y',
2455 'created_by': 'user:someone@chromium.org',
2456 'created_ts': '147200002222000',
2457 'experimental': False,
2458 'parameters_json': json.dumps({
2459 'builder_name': 'my-bot',
2460 'properties': {'category': 'cq'},
2461 }),
2462 'status': 'STARTED',
2463 'tags': [
2464 'build_address:x.y/my-bot/2',
2465 'builder:my-bot',
2466 'experimental:false',
2467 'user_agent:cq',
2468 ],
2469 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2470 },
2471 '8000': {
2472 'id': '8000',
2473 'bucket': 'master.x.y',
2474 'created_by': 'user:someone@chromium.org',
2475 'created_ts': '147200001111000',
2476 'experimental': False,
2477 'failure_reason': 'BUILD_FAILURE',
2478 'parameters_json': json.dumps({
2479 'builder_name': 'my-bot',
2480 'properties': {'category': 'cq'},
2481 }),
2482 'result_details_json': json.dumps({
2483 'properties': {'buildnumber': 1},
2484 }),
2485 'result': 'FAILURE',
2486 'status': 'COMPLETED',
2487 'tags': [
2488 'build_address:x.y/my-bot/1',
2489 'builder:my-bot',
2490 'experimental:false',
2491 'user_agent:cq',
2492 ],
2493 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2494 },
2495 }
tandrii221ab252016-10-06 08:12:04 -07002496
2497 def test_write_try_results_json(self):
2498 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002499 {
2500 'bucket': 'master.x.y',
2501 'buildbucket_id': '8000',
2502 'builder_name': 'my-bot',
2503 'created_ts': '147200001111000',
2504 'experimental': False,
2505 'failure_reason': 'BUILD_FAILURE',
2506 'result': 'FAILURE',
2507 'status': 'COMPLETED',
2508 'tags': [
2509 'build_address:x.y/my-bot/1',
2510 'builder:my-bot',
2511 'experimental:false',
2512 'user_agent:cq',
2513 ],
2514 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2515 },
2516 {
2517 'bucket': 'master.x.y',
2518 'buildbucket_id': '9000',
2519 'builder_name': 'my-bot',
2520 'created_ts': '147200002222000',
2521 'experimental': False,
2522 'failure_reason': None,
2523 'result': None,
2524 'status': 'STARTED',
2525 'tags': [
2526 'build_address:x.y/my-bot/2',
2527 'builder:my-bot',
2528 'experimental:false',
2529 'user_agent:cq',
2530 ],
2531 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2532 },
tandrii221ab252016-10-06 08:12:04 -07002533 ]
2534 self.calls = [(('write_json', 'output.json', expected_output), '')]
2535 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2536
tandrii45b2a582016-10-11 03:14:16 -07002537 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002538 out = StringIO.StringIO()
2539 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002540 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2541 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002542 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2543 self._mocked_call(['get_authenticator_for_host', host]))
2544 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2545 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002546
tandrii45b2a582016-10-11 03:14:16 -07002547 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2548 self._setup_fetch_try_jobs(most_recent_patchset=13)
2549 self.calls += [
2550 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii45b2a582016-10-11 03:14:16 -07002551 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002552 # TODO(tandrii): Uncomment the below if we decide to support checking
2553 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002554 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002555 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002556 ((['git', 'config', 'branch.feature.gerritserver'],),
2557 'https://x-review.googlesource.com'),
2558 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2559 AuthenticatorMock()),
2560 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2561
2562 def test_fetch_try_jobs_none_gerrit(self):
2563 self._setup_fetch_try_jobs_gerrit({})
2564 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002565 # TODO(tandrii): Uncomment the below if we decide to support checking
2566 # patchsets for Gerrit.
2567 # self.assertRegexpMatches(
2568 # sys.stdout.getvalue(),
2569 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07002570 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2571
2572 def test_fetch_try_jobs_some_gerrit(self):
2573 self._setup_fetch_try_jobs_gerrit({
2574 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2575 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002576 # TODO(tandrii): Uncomment the below if we decide to support checking
2577 # patchsets for Gerrit.
2578 # self.calls.remove(
2579 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002580 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2581
2582 # ... and doesn't result in warning.
2583 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2584 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002585 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2586 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2587
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002588 def _mock_gerrit_changes_for_detail_cache(self):
2589 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002590
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002591 def test_gerrit_change_detail_cache_simple(self):
2592 self._mock_gerrit_changes_for_detail_cache()
2593 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002594 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2595 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2596 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002597 ]
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002598 cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002599 cl1._cached_remote_url = (
2600 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002601 cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002602 cl2._cached_remote_url = (
2603 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002604 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2605 self.assertEqual(cl1._GetChangeDetail(), 'a')
2606 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2607 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2608 self.assertEqual(cl1._GetChangeDetail(), 'a')
2609 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002610
2611 def test_gerrit_change_detail_cache_options(self):
2612 self._mock_gerrit_changes_for_detail_cache()
2613 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002614 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2615 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2616 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2617 # no longer in cache.
2618 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002619 ]
2620 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002621 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002622 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2623 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2624 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2625 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2626 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2627 self.assertEqual(cl._GetChangeDetail(), 'cab')
2628
2629 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2630 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2631 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2632 self.assertEqual(cl._GetChangeDetail(), 'cab')
2633
2634 # Finally, no_cache should invalidate all caches for given change.
2635 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2636 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2637
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002638 def test_gerrit_description_caching(self):
2639 def gen_detail(rev, desc):
2640 return {
2641 'current_revision': rev,
2642 'revisions': {rev: {'commit': {'message': desc}}}
2643 }
2644 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002645 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002646 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2647 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002648 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002649 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2650 gen_detail('rev2', 'desc2')),
2651 ]
2652
2653 self._mock_gerrit_changes_for_detail_cache()
2654 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002655 cl._cached_remote_url = (
2656 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002657 self.assertEqual(cl.GetDescription(), 'desc1')
2658 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2659 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002660
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002661 def test_print_current_creds(self):
2662 class CookiesAuthenticatorMock(object):
2663 def __init__(self):
2664 self.gitcookies = {
2665 'host.googlesource.com': ('user', 'pass'),
2666 'host-review.googlesource.com': ('user', 'pass'),
2667 }
2668 self.netrc = self
2669 self.netrc.hosts = {
2670 'github.com': ('user2', None, 'pass2'),
2671 'host2.googlesource.com': ('user3', None, 'pass'),
2672 }
2673 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2674 CookiesAuthenticatorMock)
2675 self.mock(sys, 'stdout', StringIO.StringIO())
2676 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2677 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2678 ' Host\t User\t Which file',
2679 '============================\t=====\t===========',
2680 'host-review.googlesource.com\t user\t.gitcookies',
2681 ' host.googlesource.com\t user\t.gitcookies',
2682 ' host2.googlesource.com\tuser3\t .netrc',
2683 ])
2684 sys.stdout.buf = ''
2685 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2686 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2687 ' Host\tUser\t Which file',
2688 '============================\t====\t===========',
2689 'host-review.googlesource.com\tuser\t.gitcookies',
2690 ' host.googlesource.com\tuser\t.gitcookies',
2691 ])
2692
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002693 def _common_creds_check_mocks(self):
2694 def exists_mock(path):
2695 dirname = os.path.dirname(path)
2696 if dirname == os.path.expanduser('~'):
2697 dirname = '~'
2698 base = os.path.basename(path)
2699 if base in ('.netrc', '.gitcookies'):
2700 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2701 # git cl also checks for existence other files not relevant to this test.
2702 return None
2703 self.mock(os.path, 'exists', exists_mock)
2704 self.mock(sys, 'stdout', StringIO.StringIO())
2705
2706 def test_creds_check_gitcookies_not_configured(self):
2707 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002708 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002709 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002710 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002711 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002712 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2713 (('os.path.exists', '~/.netrc'), True),
2714 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2715 'or Ctrl+C to abort'), ''),
2716 ((['git', 'config', '--global', 'http.cookiefile',
2717 os.path.expanduser('~/.gitcookies')], ), ''),
2718 ]
2719 self.assertEqual(0, git_cl.main(['creds-check']))
2720 self.assertRegexpMatches(
2721 sys.stdout.getvalue(),
2722 '^You seem to be using outdated .netrc for git credentials:')
2723 self.assertRegexpMatches(
2724 sys.stdout.getvalue(),
2725 '\nConfigured git to use .gitcookies from')
2726
2727 def test_creds_check_gitcookies_configured_custom_broken(self):
2728 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002729 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002730 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002731 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002732 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002733 ((['git', 'config', '--global', 'http.cookiefile'],),
2734 '/custom/.gitcookies'),
2735 (('os.path.exists', '/custom/.gitcookies'), False),
2736 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2737 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2738 ((['git', 'config', '--global', 'http.cookiefile',
2739 os.path.expanduser('~/.gitcookies')], ), ''),
2740 ]
2741 self.assertEqual(0, git_cl.main(['creds-check']))
2742 self.assertRegexpMatches(
2743 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002744 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002745 self.assertRegexpMatches(
2746 sys.stdout.getvalue(),
2747 'However, your configured .gitcookies file is missing.')
2748
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002749 def test_git_cl_comment_add_gerrit(self):
2750 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002751 lambda host, change, msg, ready:
2752 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002753 self.calls = [
2754 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2755 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2756 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2757 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2758 'origin/master'),
2759 ((['git', 'config', 'remote.origin.url'],),
2760 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002761 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2762 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002763 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002764 ]
2765 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2766 '-a', 'msg']))
2767
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002768 def test_git_cl_comments_fetch_gerrit(self):
2769 self.mock(sys, 'stdout', StringIO.StringIO())
2770 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002771 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2772 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002773 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2774 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2775 'origin/master'),
2776 ((['git', 'config', 'remote.origin.url'],),
2777 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002778 (('GetChangeDetail', 'chromium-review.googlesource.com',
2779 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002780 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2781 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002782 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002783 'current_revision': 'ba5eba11',
2784 'revisions': {
2785 'deadbeaf': {
2786 '_number': 1,
2787 },
2788 'ba5eba11': {
2789 '_number': 2,
2790 },
2791 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002792 'messages': [
2793 {
2794 u'_revision_number': 1,
2795 u'author': {
2796 u'_account_id': 1111084,
2797 u'email': u'commit-bot@chromium.org',
2798 u'name': u'Commit Bot'
2799 },
2800 u'date': u'2017-03-15 20:08:45.000000000',
2801 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002802 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002803 u'tag': u'autogenerated:cq:dry-run'
2804 },
2805 {
2806 u'_revision_number': 2,
2807 u'author': {
2808 u'_account_id': 11151243,
2809 u'email': u'owner@example.com',
2810 u'name': u'owner'
2811 },
2812 u'date': u'2017-03-16 20:00:41.000000000',
2813 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2814 u'message': u'PTAL',
2815 },
2816 {
2817 u'_revision_number': 2,
2818 u'author': {
2819 u'_account_id': 148512 ,
2820 u'email': u'reviewer@example.com',
2821 u'name': u'reviewer'
2822 },
2823 u'date': u'2017-03-17 05:19:37.500000000',
2824 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2825 u'message': u'Patch Set 2: Code-Review+1',
2826 },
2827 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002828 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002829 (('GetChangeComments', 'chromium-review.googlesource.com',
2830 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002831 '/COMMIT_MSG': [
2832 {
2833 'author': {'email': u'reviewer@example.com'},
2834 'updated': u'2017-03-17 05:19:37.500000000',
2835 'patch_set': 2,
2836 'side': 'REVISION',
2837 'message': 'Please include a bug link',
2838 },
2839 ],
2840 'codereview.settings': [
2841 {
2842 'author': {'email': u'owner@example.com'},
2843 'updated': u'2017-03-16 20:00:41.000000000',
2844 'patch_set': 2,
2845 'side': 'PARENT',
2846 'line': 42,
2847 'message': 'I removed this because it is bad',
2848 },
2849 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002850 }),
2851 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2852 'infra%2Finfra~1'), {}),
2853 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002854 ] * 2 + [
2855 (('write_json', 'output.json', [
2856 {
2857 u'date': u'2017-03-16 20:00:41.000000',
2858 u'message': (
2859 u'PTAL\n' +
2860 u'\n' +
2861 u'codereview.settings\n' +
2862 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2863 u'c/1/2/codereview.settings#b42\n' +
2864 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002865 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002866 u'approval': False,
2867 u'disapproval': False,
2868 u'sender': u'owner@example.com'
2869 }, {
2870 u'date': u'2017-03-17 05:19:37.500000',
2871 u'message': (
2872 u'Patch Set 2: Code-Review+1\n' +
2873 u'\n' +
2874 u'/COMMIT_MSG\n' +
2875 u' PS2, File comment: https://chromium-review.googlesource' +
2876 u'.com/c/1/2//COMMIT_MSG#\n' +
2877 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002878 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002879 u'approval': False,
2880 u'disapproval': False,
2881 u'sender': u'reviewer@example.com'
2882 }
2883 ]),'')
2884 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002885 expected_comments_summary = [
2886 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002887 message=(
2888 u'PTAL\n' +
2889 u'\n' +
2890 u'codereview.settings\n' +
2891 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2892 u'c/1/2/codereview.settings#b42\n' +
2893 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002894 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002895 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002896 disapproval=False, approval=False, sender=u'owner@example.com'),
2897 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002898 message=(
2899 u'Patch Set 2: Code-Review+1\n' +
2900 u'\n' +
2901 u'/COMMIT_MSG\n' +
2902 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2903 u'c/1/2//COMMIT_MSG#\n' +
2904 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002905 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002906 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002907 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2908 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002909 cl = git_cl.Changelist(
2910 codereview='gerrit', issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002911 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002912 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
2913 self.assertEqual(
2914 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2915
2916 def test_git_cl_comments_robot_comments(self):
2917 # git cl comments also fetches robot comments (which are considered a type
2918 # of autogenerated comment), and unlike other types of comments, only robot
2919 # comments from the latest patchset are shown.
2920 self.mock(sys, 'stdout', StringIO.StringIO())
2921 self.calls = [
2922 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2923 ((['git', 'config', 'branch.foo.merge'],), ''),
2924 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2925 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2926 'origin/master'),
2927 ((['git', 'config', 'remote.origin.url'],),
2928 'https://chromium.googlesource.com/infra/infra'),
2929 (('GetChangeDetail', 'chromium-review.googlesource.com',
2930 'infra%2Finfra~1',
2931 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2932 'CURRENT_COMMIT']), {
2933 'owner': {'email': 'owner@example.com'},
2934 'current_revision': 'ba5eba11',
2935 'revisions': {
2936 'deadbeaf': {
2937 '_number': 1,
2938 },
2939 'ba5eba11': {
2940 '_number': 2,
2941 },
2942 },
2943 'messages': [
2944 {
2945 u'_revision_number': 1,
2946 u'author': {
2947 u'_account_id': 1111084,
2948 u'email': u'commit-bot@chromium.org',
2949 u'name': u'Commit Bot'
2950 },
2951 u'date': u'2017-03-15 20:08:45.000000000',
2952 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2953 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2954 u'tag': u'autogenerated:cq:dry-run'
2955 },
2956 {
2957 u'_revision_number': 1,
2958 u'author': {
2959 u'_account_id': 123,
2960 u'email': u'tricium@serviceaccount.com',
2961 u'name': u'Tricium'
2962 },
2963 u'date': u'2017-03-16 20:00:41.000000000',
2964 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2965 u'message': u'(1 comment)',
2966 u'tag': u'autogenerated:tricium',
2967 },
2968 {
2969 u'_revision_number': 1,
2970 u'author': {
2971 u'_account_id': 123,
2972 u'email': u'tricium@serviceaccount.com',
2973 u'name': u'Tricium'
2974 },
2975 u'date': u'2017-03-16 20:00:41.000000000',
2976 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2977 u'message': u'(1 comment)',
2978 u'tag': u'autogenerated:tricium',
2979 },
2980 {
2981 u'_revision_number': 2,
2982 u'author': {
2983 u'_account_id': 123 ,
2984 u'email': u'tricium@serviceaccount.com',
2985 u'name': u'reviewer'
2986 },
2987 u'date': u'2017-03-17 05:30:37.000000000',
2988 u'tag': u'autogenerated:tricium',
2989 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2990 u'message': u'(1 comment)',
2991 },
2992 ]
2993 }),
2994 (('GetChangeComments', 'chromium-review.googlesource.com',
2995 'infra%2Finfra~1'), {}),
2996 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2997 'infra%2Finfra~1'), {
2998 'codereview.settings': [
2999 {
3000 u'author': {u'email': u'tricium@serviceaccount.com'},
3001 u'updated': u'2017-03-17 05:30:37.000000000',
3002 u'robot_run_id': u'5565031076855808',
3003 u'robot_id': u'Linter/Category',
3004 u'tag': u'autogenerated:tricium',
3005 u'patch_set': 2,
3006 u'side': u'REVISION',
3007 u'message': u'Linter warning message text',
3008 u'line': 32,
3009 },
3010 ],
3011 }),
3012 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
3013 ]
3014 expected_comments_summary = [
3015 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
3016 message=(
3017 u'(1 comment)\n\ncodereview.settings\n'
3018 u' PS2, Line 32: https://chromium-review.googlesource.com/'
3019 u'c/1/2/codereview.settings#32\n'
3020 u' Linter warning message text\n'),
3021 sender=u'tricium@serviceaccount.com',
3022 autogenerated=True, approval=False, disapproval=False)
3023 ]
3024 cl = git_cl.Changelist(
3025 codereview='gerrit', issue=1, branchref='refs/heads/foo')
3026 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003027
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003028 def test_get_remote_url_with_mirror(self):
3029 original_os_path_isdir = os.path.isdir
3030 def selective_os_path_isdir_mock(path):
3031 if path == '/cache/this-dir-exists':
3032 return self._mocked_call('os.path.isdir', path)
3033 return original_os_path_isdir(path)
3034 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3035
3036 url = 'https://chromium.googlesource.com/my/repo'
3037 self.calls = [
3038 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3039 ((['git', 'config', 'branch.master.merge'],), 'master'),
3040 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3041 ((['git', 'config', 'remote.origin.url'],),
3042 '/cache/this-dir-exists'),
3043 (('os.path.isdir', '/cache/this-dir-exists'),
3044 True),
3045 # Runs in /cache/this-dir-exists.
3046 ((['git', 'config', 'remote.origin.url'],),
3047 url),
3048 ]
3049 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3050 self.assertEqual(cl.GetRemoteUrl(), url)
3051 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3052
Edward Lemur298f2cf2019-02-22 21:40:39 +00003053 def test_get_remote_url_non_existing_mirror(self):
3054 original_os_path_isdir = os.path.isdir
3055 def selective_os_path_isdir_mock(path):
3056 if path == '/cache/this-dir-doesnt-exist':
3057 return self._mocked_call('os.path.isdir', path)
3058 return original_os_path_isdir(path)
3059 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3060 self.mock(logging, 'error',
3061 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
3062
3063 self.calls = [
3064 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3065 ((['git', 'config', 'branch.master.merge'],), 'master'),
3066 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3067 ((['git', 'config', 'remote.origin.url'],),
3068 '/cache/this-dir-doesnt-exist'),
3069 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3070 False),
3071 (('logging.error',
3072 'Remote "origin" for branch "/cache/this-dir-doesnt-exist" points to'
3073 ' "master", but it doesn\'t exist.'), None),
3074 ]
3075 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3076 self.assertIsNone(cl.GetRemoteUrl())
3077
3078 def test_get_remote_url_misconfigured_mirror(self):
3079 original_os_path_isdir = os.path.isdir
3080 def selective_os_path_isdir_mock(path):
3081 if path == '/cache/this-dir-exists':
3082 return self._mocked_call('os.path.isdir', path)
3083 return original_os_path_isdir(path)
3084 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3085 self.mock(logging, 'error',
3086 lambda *a: self._mocked_call('logging.error', *a))
3087
3088 self.calls = [
3089 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3090 ((['git', 'config', 'branch.master.merge'],), 'master'),
3091 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3092 ((['git', 'config', 'remote.origin.url'],),
3093 '/cache/this-dir-exists'),
3094 (('os.path.isdir', '/cache/this-dir-exists'), True),
3095 # Runs in /cache/this-dir-exists.
3096 ((['git', 'config', 'remote.origin.url'],), ''),
3097 (('logging.error',
3098 'Remote "%(remote)s" for branch "%(branch)s" points to '
3099 '"%(cache_path)s", but it is misconfigured.\n'
3100 '"%(cache_path)s" must be a git repo and must have a remote named '
3101 '"%(remote)s" pointing to the git host.', {
3102 'remote': 'origin',
3103 'cache_path': '/cache/this-dir-exists',
3104 'branch': 'master'}
3105 ), None),
3106 ]
3107 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3108 self.assertIsNone(cl.GetRemoteUrl())
3109
3110
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003111 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003112 self.calls = [
3113 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3114 ((['git', 'config', 'branch.master.merge'],), 'master'),
3115 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3116 ((['git', 'config', 'remote.origin.url'],),
3117 'https://chromium.googlesource.com/a/my/repo.git/'),
3118 ]
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003119 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3120 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3121
3122 def test_gerrit_change_identifier_without_project(self):
3123 self.calls = [
3124 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3125 ((['git', 'config', 'branch.master.merge'],), 'master'),
3126 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3127 ((['git', 'config', 'remote.origin.url'],), CERR1),
3128 ]
3129 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3130 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003131
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003132
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003133if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003134 logging.basicConfig(
3135 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003136 unittest.main()