blob: f1cdf4d62347eb348251e301e5ca77e7a1f79596 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01008import datetime
tandriide281ae2016-10-12 06:02:30 -07009import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010010import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000011import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000012import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000013import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070014import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000015import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000016import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017
18sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
19
20from testing_support.auto_stub import TestCase
21
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000022import metrics
23# We have to disable monitoring before importing git_cl.
24metrics.DISABLE_METRICS_COLLECTION = True
25
Eric Boren2fb63102018-10-05 13:05:03 +000026import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000027import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000028import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000029import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000030import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000065 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000066 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000086class WatchlistsMock(object):
87 def __init__(self, _):
88 pass
89 @staticmethod
90 def GetWatchersForPaths(_):
91 return ['joe@example.com']
92
93
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +000094class AuthenticatorMock(object):
95 def __init__(self, *_args):
96 pass
97 def has_cached_credentials(self):
98 return True
tandrii221ab252016-10-06 08:12:04 -070099 def authorize(self, http):
100 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000101
102
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100103def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000104 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
105
106 Usage:
107 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100108 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000109
110 OR
111 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100112 CookiesAuthenticatorMockFactory(
113 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000114 """
115 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800116 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000117 # Intentionally not calling super() because it reads actual cookie files.
118 pass
119 @classmethod
120 def get_gitcookies_path(cls):
121 return '~/.gitcookies'
122 @classmethod
123 def get_netrc_path(cls):
124 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100125 def _get_auth_for_host(self, host):
126 if same_auth:
127 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000128 return (hosts_with_creds or {}).get(host)
129 return CookiesAuthenticatorMock
130
Aaron Gable9a03ae02017-11-03 11:31:07 -0700131
kmarshall9249e012016-08-23 12:02:16 -0700132class MockChangelistWithBranchAndIssue():
133 def __init__(self, branch, issue):
134 self.branch = branch
135 self.issue = issue
136 def GetBranch(self):
137 return self.branch
138 def GetIssue(self):
139 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000140
tandriic2405f52016-10-10 08:13:15 -0700141
142class SystemExitMock(Exception):
143 pass
144
145
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000146class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100147 def test_get_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000148 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100149 cl.description = 'x'
150 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000151 cl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100152 self.assertEquals(cl.GetDescription(), 'x')
153 self.assertEquals(cl.GetDescription(force=True), 'y')
154 self.assertEquals(cl.GetDescription(), 'y')
155
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700156 def test_description_footers(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000157 cl = git_cl.Changelist(issue=1, codereview_host='host')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700158 cl.description = '\n'.join([
159 'This is some message',
160 '',
161 'It has some lines',
162 'and, also',
163 '',
164 'Some: Really',
165 'Awesome: Footers',
166 ])
167 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000168 cl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700169 msg, footers = cl.GetDescriptionFooters()
170 self.assertEquals(
171 msg, ['This is some message', '', 'It has some lines', 'and, also'])
172 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
173
174 msg.append('wut')
175 footers.append(('gnarly-dude', 'beans'))
176 cl.UpdateDescriptionFooters(msg, footers)
177 self.assertEquals(cl.GetDescription().splitlines(), [
178 'This is some message',
179 '',
180 'It has some lines',
181 'and, also',
182 'wut'
183 '',
184 'Some: Really',
185 'Awesome: Footers',
186 'Gnarly-Dude: beans',
187 ])
188
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000189 def test_set_preserve_tryjobs(self):
190 d = git_cl.ChangeDescription('Simple.')
191 d.set_preserve_tryjobs()
192 self.assertEqual(d.description.splitlines(), [
193 'Simple.',
194 '',
195 'Cq-Do-Not-Cancel-Tryjobs: true',
196 ])
197 before = d.description
198 d.set_preserve_tryjobs()
199 self.assertEqual(before, d.description)
200
201 d = git_cl.ChangeDescription('\n'.join([
202 'One is enough',
203 '',
204 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
205 'Change-Id: Ideadbeef',
206 ]))
207 d.set_preserve_tryjobs()
208 self.assertEqual(d.description.splitlines(), [
209 'One is enough',
210 '',
211 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
212 'Change-Id: Ideadbeef',
213 'Cq-Do-Not-Cancel-Tryjobs: true',
214 ])
215
tandriif9aefb72016-07-01 09:06:51 -0700216 def test_get_bug_line_values(self):
217 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
218 self.assertEqual(f('', ''), [])
219 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
220 self.assertEqual(f('v8', '456'), ['v8:456'])
221 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
222 # Not nice, but not worth carying.
223 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
224 ['v8:456', 'chromium:123', 'v8:123'])
225
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100226 def _test_git_number(self, parent_msg, dest_ref, child_msg,
227 parent_hash='parenthash'):
228 desc = git_cl.ChangeDescription(child_msg)
229 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
230 return desc.description
231
232 def assertEqualByLine(self, actual, expected):
233 self.assertEqual(actual.splitlines(), expected.splitlines())
234
235 def test_git_number_bad_parent(self):
236 with self.assertRaises(ValueError):
237 self._test_git_number('Parent', 'refs/heads/master', 'Child')
238
239 def test_git_number_bad_parent_footer(self):
240 with self.assertRaises(AssertionError):
241 self._test_git_number(
242 'Parent\n'
243 '\n'
244 'Cr-Commit-Position: wrong',
245 'refs/heads/master', 'Child')
246
247 def test_git_number_bad_lineage_ignored(self):
248 actual = self._test_git_number(
249 'Parent\n'
250 '\n'
251 'Cr-Commit-Position: refs/heads/master@{#1}\n'
252 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
253 'refs/heads/master', 'Child')
254 self.assertEqualByLine(
255 actual,
256 'Child\n'
257 '\n'
258 'Cr-Commit-Position: refs/heads/master@{#2}\n'
259 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
260
261 def test_git_number_same_branch(self):
262 actual = self._test_git_number(
263 'Parent\n'
264 '\n'
265 'Cr-Commit-Position: refs/heads/master@{#12}',
266 dest_ref='refs/heads/master',
267 child_msg='Child')
268 self.assertEqualByLine(
269 actual,
270 'Child\n'
271 '\n'
272 'Cr-Commit-Position: refs/heads/master@{#13}')
273
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200274 def test_git_number_same_branch_mixed_footers(self):
275 actual = self._test_git_number(
276 'Parent\n'
277 '\n'
278 'Cr-Commit-Position: refs/heads/master@{#12}',
279 dest_ref='refs/heads/master',
280 child_msg='Child\n'
281 '\n'
282 'Broken-by: design\n'
283 'BUG=123')
284 self.assertEqualByLine(
285 actual,
286 'Child\n'
287 '\n'
288 'Broken-by: design\n'
289 'BUG=123\n'
290 'Cr-Commit-Position: refs/heads/master@{#13}')
291
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100292 def test_git_number_same_branch_with_originals(self):
293 actual = self._test_git_number(
294 'Parent\n'
295 '\n'
296 'Cr-Commit-Position: refs/heads/master@{#12}',
297 dest_ref='refs/heads/master',
298 child_msg='Child\n'
299 '\n'
300 'Some users are smart and insert their own footers\n'
301 '\n'
302 'Cr-Whatever: value\n'
303 'Cr-Commit-Position: refs/copy/paste@{#22}')
304 self.assertEqualByLine(
305 actual,
306 'Child\n'
307 '\n'
308 'Some users are smart and insert their own footers\n'
309 '\n'
310 'Cr-Original-Whatever: value\n'
311 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
312 'Cr-Commit-Position: refs/heads/master@{#13}')
313
314 def test_git_number_new_branch(self):
315 actual = self._test_git_number(
316 'Parent\n'
317 '\n'
318 'Cr-Commit-Position: refs/heads/master@{#12}',
319 dest_ref='refs/heads/branch',
320 child_msg='Child')
321 self.assertEqualByLine(
322 actual,
323 'Child\n'
324 '\n'
325 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
326 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
327
328 def test_git_number_lineage(self):
329 actual = self._test_git_number(
330 'Parent\n'
331 '\n'
332 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
333 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
334 dest_ref='refs/heads/branch',
335 child_msg='Child')
336 self.assertEqualByLine(
337 actual,
338 'Child\n'
339 '\n'
340 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
341 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
342
343 def test_git_number_moooooooore_lineage(self):
344 actual = self._test_git_number(
345 'Parent\n'
346 '\n'
347 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
348 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
349 dest_ref='refs/heads/mooore',
350 child_msg='Child')
351 self.assertEqualByLine(
352 actual,
353 'Child\n'
354 '\n'
355 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
356 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
357 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
358
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100359 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700360 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100361 actual = self._test_git_number(
362 'CQ commit on fresh new branch + numbering.\n'
363 '\n'
364 'NOTRY=True\n'
365 'NOPRESUBMIT=True\n'
366 'BUG=\n'
367 '\n'
368 'Review-Url: https://codereview.chromium.org/2577703003\n'
369 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
370 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
371 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
372 dest_ref='refs/heads/gnumb-test/cl',
373 child_msg='git cl on fresh new branch + numbering.\n'
374 '\n'
375 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
376 self.assertEqualByLine(
377 actual,
378 'git cl on fresh new branch + numbering.\n'
379 '\n'
380 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
381 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
382 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
383 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
384 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100385
386 def test_git_number_cherry_pick(self):
387 actual = self._test_git_number(
388 'Parent\n'
389 '\n'
390 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
391 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
392 dest_ref='refs/heads/branch',
393 child_msg='Child, which is cherry-pick from master\n'
394 '\n'
395 'Cr-Commit-Position: refs/heads/master@{#100}\n'
396 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
397 self.assertEqualByLine(
398 actual,
399 'Child, which is cherry-pick from master\n'
400 '\n'
401 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
402 '\n'
403 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
404 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
405 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
406
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000407 def test_gerrit_mirror_hack(self):
408 cr = 'chromium-review.googlesource.com'
409 url0 = 'https://%s/a/changes/x?a=b' % cr
410 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
411 try:
412 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
413 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
414 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
415 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
416
417 self.assertNotEqual(url1, url2)
418 self.assertEqual(sorted((url1, url2)), [
419 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
420 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
421 self.assertEqual(url1, url3)
422 finally:
423 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
424
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000425 def test_valid_accounts(self):
426 mock_per_account = {
427 'u1': None, # 404, doesn't exist.
428 'u2': {
429 '_account_id': 123124,
430 'avatars': [],
431 'email': 'u2@example.com',
432 'name': 'User Number 2',
433 'status': 'OOO',
434 },
435 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
436 }
437 def GetAccountDetailsMock(_, account):
438 # Poor-man's mock library's side_effect.
439 v = mock_per_account.pop(account)
440 if isinstance(v, Exception):
441 raise v
442 return v
443
444 original = git_cl.gerrit_util.GetAccountDetails
445 try:
446 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
447 actual = git_cl.gerrit_util.ValidAccounts(
448 'host', ['u1', 'u2', 'u3'], max_threads=1)
449 finally:
450 git_cl.gerrit_util.GetAccountDetails = original
451 self.assertEqual(actual, {
452 'u2': {
453 '_account_id': 123124,
454 'avatars': [],
455 'email': 'u2@example.com',
456 'name': 'User Number 2',
457 'status': 'OOO',
458 },
459 })
460
461
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200462class TestParseIssueURL(unittest.TestCase):
463 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000464 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200465 self.assertIsNotNone(parsed)
466 if fail:
467 self.assertFalse(parsed.valid)
468 return
469 self.assertTrue(parsed.valid)
470 self.assertEqual(parsed.issue, issue)
471 self.assertEqual(parsed.patchset, patchset)
472 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200473
474 def _run_and_validate(self, func, url, *args, **kwargs):
475 result = func(urlparse.urlparse(url))
476 if kwargs.pop('fail', False):
477 self.assertIsNone(result)
478 return None
479 self._validate(result, *args, fail=False, **kwargs)
480
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200481 def test_gerrit(self):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200482 def test(url, *args, **kwargs):
Edward Lemur125d60a2019-09-13 18:25:41 +0000483 self._run_and_validate(git_cl.Changelist.ParseIssueURL, url,
Edward Lemurf38bc172019-09-03 21:02:13 +0000484 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200485
486 test('http://chrome-review.source.com/c/123',
487 123, None, 'chrome-review.source.com')
488 test('https://chrome-review.source.com/c/123/',
489 123, None, 'chrome-review.source.com')
490 test('https://chrome-review.source.com/c/123/4',
491 123, 4, 'chrome-review.source.com')
492 test('https://chrome-review.source.com/#/c/123/4',
493 123, 4, 'chrome-review.source.com')
494 test('https://chrome-review.source.com/c/123/4',
495 123, 4, 'chrome-review.source.com')
496 test('https://chrome-review.source.com/123',
497 123, None, 'chrome-review.source.com')
498 test('https://chrome-review.source.com/123/4',
499 123, 4, 'chrome-review.source.com')
500
501 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
502 test('https://chrome-review.source.com/c/abc/', fail=True)
503 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
504
505 def test_ParseIssueNumberArgument(self):
506 def test(arg, *args, **kwargs):
Edward Lemurf38bc172019-09-03 21:02:13 +0000507 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200508
509 test('123', 123)
510 test('', fail=True)
511 test('abc', fail=True)
512 test('123/1', fail=True)
513 test('123a', fail=True)
514 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000515
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200516 test('https://codereview.source.com/123',
Edward Lemurf38bc172019-09-03 21:02:13 +0000517 123, None, 'codereview.source.com')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000518
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200519 # Gerrrit.
520 test('https://chrome-review.source.com/c/123/4',
Edward Lemurf38bc172019-09-03 21:02:13 +0000521 123, 4, 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200522 test('https://chrome-review.source.com/bad/123/4', fail=True)
523
524
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100525class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100526 def setUp(self):
527 super(GitCookiesCheckerTest, self).setUp()
528 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100529 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100530
531 def mock_hosts_creds(self, subhost_identity_pairs):
532 def ensure_googlesource(h):
533 if not h.endswith(self.c._GOOGLESOURCE):
534 assert not h.endswith('.')
535 return h + '.' + self.c._GOOGLESOURCE
536 return h
537 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
538 for h, i in subhost_identity_pairs]
539
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200540 def test_identity_parsing(self):
541 self.assertEqual(self.c._parse_identity('ldap.google.com'),
542 ('ldap', 'google.com'))
543 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
544 ('ldap', 'example.com'))
545 # Specical case because we know there are no subdomains in chromium.org.
546 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
547 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800548 # Pathological: ".period." can be either username OR domain, more likely
549 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200550 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
551 ('note', 'period.example.com'))
552
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100553 def test_analysis_nothing(self):
554 self.c._all_hosts = []
555 self.assertFalse(self.c.has_generic_host())
556 self.assertEqual(set(), self.c.get_conflicting_hosts())
557 self.assertEqual(set(), self.c.get_duplicated_hosts())
558 self.assertEqual(set(), self.c.get_partially_configured_hosts())
559 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
560
561 def test_analysis(self):
562 self.mock_hosts_creds([
563 ('.googlesource.com', 'git-example.chromium.org'),
564
565 ('chromium', 'git-example.google.com'),
566 ('chromium-review', 'git-example.google.com'),
567 ('chrome-internal', 'git-example.chromium.org'),
568 ('chrome-internal-review', 'git-example.chromium.org'),
569 ('conflict', 'git-example.google.com'),
570 ('conflict-review', 'git-example.chromium.org'),
571 ('dup', 'git-example.google.com'),
572 ('dup', 'git-example.google.com'),
573 ('dup-review', 'git-example.google.com'),
574 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200575 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100576 ])
577 self.assertTrue(self.c.has_generic_host())
578 self.assertEqual(set(['conflict.googlesource.com']),
579 self.c.get_conflicting_hosts())
580 self.assertEqual(set(['dup.googlesource.com']),
581 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200582 self.assertEqual(set(['partial.googlesource.com',
583 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100584 self.c.get_partially_configured_hosts())
585 self.assertEqual(set(['chromium.googlesource.com',
586 'chrome-internal.googlesource.com']),
587 self.c.get_hosts_with_wrong_identities())
588
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100589 def test_report_no_problems(self):
590 self.test_analysis_nothing()
591 self.mock(sys, 'stdout', StringIO.StringIO())
592 self.assertFalse(self.c.find_and_report_problems())
593 self.assertEqual(sys.stdout.getvalue(), '')
594
595 def test_report(self):
596 self.test_analysis()
597 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200598 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
599 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100600 self.assertTrue(self.c.find_and_report_problems())
601 with open(os.path.join(os.path.dirname(__file__),
602 'git_cl_creds_check_report.txt')) as f:
603 expected = f.read()
604 def by_line(text):
605 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700606 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200607 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100608
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800609
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000610class TestGitCl(TestCase):
611 def setUp(self):
612 super(TestGitCl, self).setUp()
613 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700614 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000615 self.mock(git_cl, 'time_time',
616 lambda: self._mocked_call('time.time'))
617 self.mock(git_cl.metrics.collector, 'add_repeated',
618 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000619 self.mock(subprocess2, 'call', self._mocked_call)
620 self.mock(subprocess2, 'check_call', self._mocked_call)
621 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700622 self.mock(subprocess2, 'communicate',
623 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000624 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000625 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000626 self.mock(git_common, 'get_or_create_merge_base',
627 lambda *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000628 self._mocked_call(['get_or_create_merge_base'] + list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000629 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000630 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000631 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
632 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100633 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000634 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700635 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000636 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000637 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000638 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000639 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100640 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
641 lambda *args, **kwargs: self._mocked_call(
642 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700643 self.mock(git_cl.gerrit_util, 'GetChangeComments',
644 lambda *args, **kwargs: self._mocked_call(
645 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000646 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
647 lambda *args, **kwargs: self._mocked_call(
648 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100649 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700650 lambda h, i, reviewers, ccs, notify: self._mocked_call(
651 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700652 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700653 lambda h, i, msg=None, labels=None, notify=None:
654 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700655 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
656 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000657 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
658 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000659 self.mock(git_cl.gerrit_util, 'ValidAccounts',
660 lambda host, accounts:
661 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700662 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100663 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000664 # It's important to reset settings to not have inter-tests interference.
665 git_cl.settings = None
666
667 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000668 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100669 self.assertEquals([], self.calls)
670 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000671 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100672 raise
673 # Sadly, has_failed() returns True if this OR any other tests before this
674 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200675 git_cl.logging.error(
676 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100677 'There are un-consumed self.calls after this test has finished.\n'
678 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700679 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200680 'If you are already running only this test, then **first** fix the '
681 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100682 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700683 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100684 'and follow instructions above.\n' +
685 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000686 finally:
687 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000688
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000689 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000690 self.assertTrue(
691 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700692 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000693 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000694 expected_args, result = top
695
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000696 # Also logs otherwise it could get caught in a try/finally and be hard to
697 # diagnose.
698 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700699 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000700 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700701 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
702 for i, c in enumerate(self._calls_done[-N:]))
703 following_calls = '\n '.join(
704 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
705 for i, c in enumerate(self.calls[:N]))
706 extended_msg = (
707 'A few prior calls:\n %s\n\n'
708 'This (expected):\n @%d: %r\n'
709 'This (actual):\n @%d: %r\n\n'
710 'A few following expected calls:\n %s' %
711 (prior_calls, len(self._calls_done), expected_args,
712 len(self._calls_done), args, following_calls))
713 git_cl.logging.error(extended_msg)
714
tandrii99a72f22016-08-17 14:33:24 -0700715 self.fail('@%d\n'
716 ' Expected: %r\n'
717 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700718 len(self._calls_done), expected_args, args))
719
720 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700721 if isinstance(result, Exception):
722 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000723 return result
724
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100725 def test_ask_for_explicit_yes_true(self):
726 self.calls = [
727 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
728 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
729 ]
730 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
731
tandrii48df5812016-10-17 03:55:37 -0700732 def test_LoadCodereviewSettingsFromFile_gerrit(self):
733 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
734 self.calls = [
735 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700736 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
737 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
738 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
739 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700740 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
741 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700742 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
743 CERR1),
744 ((['git', 'config', 'gerrit.host', 'true'],), ''),
745 ]
746 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
747
maruel@chromium.orga3353652011-11-30 14:26:57 +0000748 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000749 def _is_gerrit_calls(cls, gerrit=False):
750 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
751 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
752
753 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000754 def _git_post_upload_calls(cls):
755 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000756 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
757 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
758 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000759 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000760 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000761 ]
762
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000763 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000764 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000765 fake_ancestor = 'fake_ancestor'
766 fake_cl = 'fake_cl_for_patch'
767 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000768 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000769 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000770 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000771 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000772 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000773 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000774 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000775 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700776 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000777 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000778 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000779 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000780 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000781 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000782 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000783 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000784 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000785 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000786 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000787 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000788
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000789 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000790 def _gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000791 cls, issue=None, skip_auth_check=False, short_hostname='chromium',
792 custom_cl_base=None):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000793 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000794 if skip_auth_check:
795 return [((cmd, ), 'true')]
796
tandrii5d48c322016-08-18 16:19:37 -0700797 calls = [((cmd, ), CERR1)]
Edward Lemurf38bc172019-09-03 21:02:13 +0000798
799 if custom_cl_base:
800 calls += [
801 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
802 ]
803
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000804 calls.extend([
805 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
806 ((['git', 'config', 'branch.master.remote'],), 'origin'),
807 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000808 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000809 ])
Edward Lemurf38bc172019-09-03 21:02:13 +0000810
811 calls += [
812 ((['git', 'config', 'branch.master.gerritissue'],),
813 CERR1 if issue is None else str(issue)),
814 ]
815
Daniel Chengcf6269b2019-05-18 01:02:12 +0000816 if issue:
817 calls.extend([
818 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
819 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000820 return calls
821
822 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100823 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200824 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000825 custom_cl_base=None, short_hostname='chromium',
826 change_id=None):
Aaron Gable13101a62018-02-09 13:20:41 -0800827 calls = cls._is_gerrit_calls(True)
Edward Lemurf38bc172019-09-03 21:02:13 +0000828 if not custom_cl_base:
829 calls += [
830 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
831 ]
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200832
833 if custom_cl_base:
834 ancestor_revision = custom_cl_base
835 else:
836 # Determine ancestor_revision to be merge base.
837 ancestor_revision = 'fake_ancestor_sha'
838 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000839 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000840 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000841 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200842 'refs/remotes/origin/master'],), ancestor_revision),
843 ]
844
845 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000846 calls += cls._gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000847 issue=issue, short_hostname=short_hostname,
848 custom_cl_base=custom_cl_base)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100849
850 if issue:
851 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000852 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000853 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000854 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
855 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100856 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100857 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Anthony Polito8b955342019-09-24 19:01:36 +0000858 'change_id': (change_id or '123456789'),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100859 'current_revision': 'sha1_of_current_revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000860 'revisions': {'sha1_of_current_revision': {
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100861 'commit': {'message': fetched_description},
862 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100863 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100864 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100865 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100866 if fetched_status == 'ABANDONED':
867 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000868 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100869 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000870 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100871 ]
872 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100873 if other_cl_owner:
874 calls += [
875 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
876 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100877
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200878 calls += cls._git_sanity_checks(ancestor_revision, 'master',
879 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100880 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200881 ((['git', 'rev-parse', '--show-cdup'],), ''),
882 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000883
Aaron Gable7817f022017-12-12 09:43:17 -0800884 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
885 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200886 'M\t.gitignore\n'),
887 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100888 ]
889
890 if not issue:
891 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200892 ((['git', 'log', '--pretty=format:%s%n%n%b',
893 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000894 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100895 ]
896
897 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200898 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000899 (('time.time',), 1000,),
900 (('time.time',), 3000,),
901 (('add_repeated', 'sub_commands', {
902 'execution_time': 2000,
903 'command': 'presubmit',
904 'exit_code': 0
905 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200906 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
907 ([custom_cl_base] if custom_cl_base else
908 [ancestor_revision, 'HEAD']),),
909 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100910 ]
911 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000912
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000913 @classmethod
914 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700915 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000916 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700917 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100918 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000919 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000920 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000921 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000922 final_description=None, gitcookies_exists=True,
923 force=False):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000924 if post_amend_description is None:
925 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700926 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200927 # Determined in `_gerrit_base_calls`.
928 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
929
930 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000931
tandriia60502f2016-06-20 02:01:53 -0700932 if squash_mode == 'default':
933 calls.extend([
934 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
935 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
936 ])
937 elif squash_mode in ('override_squash', 'override_nosquash'):
938 calls.extend([
939 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
940 'true' if squash_mode == 'override_squash' else 'false'),
941 ])
942 else:
943 assert squash_mode in ('squash', 'nosquash')
944
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000945 # If issue is given, then description is fetched from Gerrit instead.
946 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000947 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200948 ((['git', 'log', '--pretty=format:%s\n\n%b',
949 ((custom_cl_base + '..') if custom_cl_base else
950 'fake_ancestor_sha..HEAD')],),
951 description),
952 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800953 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000954 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800955 else:
956 if not title:
957 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200958 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
959 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800960 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000961 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000962 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000963 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200964 (('DownloadGerritHook', False), ''),
965 # Amending of commit message to get the Change-Id.
966 ((['git', 'log', '--pretty=format:%s\n\n%b',
967 determined_ancestor_revision + '..HEAD'],),
968 description),
969 ((['git', 'commit', '--amend', '-m', description],), ''),
970 ((['git', 'log', '--pretty=format:%s\n\n%b',
971 determined_ancestor_revision + '..HEAD'],),
972 post_amend_description)
973 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000974 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000975 if force or not issue:
976 if issue:
977 calls += [
978 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
979 ]
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000980 # Prompting to edit description on first upload.
981 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000982 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000983 ]
Anthony Polito8b955342019-09-24 19:01:36 +0000984 if not force:
985 calls += [
986 ((['git', 'config', 'core.editor'],), ''),
987 ((['RunEditor'],), description),
988 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000989 ref_to_push = 'abcdef0123456789'
990 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200991 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
992 ((['git', 'config', 'branch.master.remote'],), 'origin'),
993 ]
994
995 if custom_cl_base is None:
996 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000997 ((['get_or_create_merge_base', 'master',
998 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000999 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001000 ]
1001 parent = 'origin/master'
1002 else:
1003 calls += [
1004 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
1005 'refs/remotes/origin/master'],),
1006 callError(1)), # Means not ancenstor.
1007 (('ask_for_data',
1008 'Do you take responsibility for cleaning up potential mess '
1009 'resulting from proceeding with upload? Press Enter to upload, '
1010 'or Ctrl+C to abort'), ''),
1011 ]
1012 parent = custom_cl_base
1013
1014 calls += [
1015 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
1016 '0123456789abcdef'),
1017 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001018 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001019 ref_to_push),
1020 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001021 else:
1022 ref_to_push = 'HEAD'
1023
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001024 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001025 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001026 ((['git', 'rev-list',
1027 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1028 ref_to_push],),
1029 '1hashPerLine\n'),
1030 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001031
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001032 metrics_arguments = []
1033
Aaron Gableafd52772017-06-27 16:40:10 -07001034 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001035 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001036 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001037 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001038 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001039 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001040 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001041 else:
1042 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001043 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001044
Aaron Gable70f4e242017-06-26 10:45:59 -07001045 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001046 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001047 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001048
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001049 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001050 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001051 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001052 if short_hostname == 'chromium':
1053 # All reviwers and ccs get into ref_suffix.
1054 for r in sorted(reviewers):
1055 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001056 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001057 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1058 'joe@example.com'] + cc):
1059 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001060 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001061 reviewers, cc = [], []
1062 else:
1063 # TODO(crbug/877717): remove this case.
1064 calls += [
1065 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1066 sorted(reviewers) + ['joe@example.com',
1067 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1068 {
1069 e: {'email': e}
1070 for e in (reviewers + ['joe@example.com'] + cc)
1071 })
1072 ]
1073 for r in sorted(reviewers):
1074 if r != 'bad-account-or-email':
1075 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001076 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001077 reviewers.remove(r)
1078 for c in sorted(['joe@example.com'] + cc):
1079 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001080 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001081 if c in cc:
1082 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001083
Edward Lemur687ca902018-12-05 02:30:30 +00001084 for k, v in sorted((labels or {}).items()):
1085 ref_suffix += ',l=%s+%d' % (k, v)
1086 metrics_arguments.append('l=%s+%d' % (k, v))
1087
1088 if tbr:
1089 calls += [
1090 (('GetCodeReviewTbrScore',
1091 '%s-review.googlesource.com' % short_hostname,
1092 'my/repo'),
1093 2,),
1094 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001095
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001096 calls += [
1097 (('time.time',), 1000,),
1098 ((['git', 'push',
1099 'https://%s.googlesource.com/my/repo' % short_hostname,
1100 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1101 (('remote:\n'
1102 'remote: Processing changes: (\)\n'
1103 'remote: Processing changes: (|)\n'
1104 'remote: Processing changes: (/)\n'
1105 'remote: Processing changes: (-)\n'
1106 'remote: Processing changes: new: 1 (/)\n'
1107 'remote: Processing changes: new: 1, done\n'
1108 'remote:\n'
1109 'remote: New Changes:\n'
1110 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1111 ' XXX\n'
1112 'remote:\n'
1113 'To https://%s.googlesource.com/my/repo\n'
1114 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1115 ) % (short_hostname, short_hostname)),),
1116 (('time.time',), 2000,),
1117 (('add_repeated',
1118 'sub_commands',
1119 {
1120 'execution_time': 1000,
1121 'command': 'git push',
1122 'exit_code': 0,
1123 'arguments': sorted(metrics_arguments),
1124 }),
1125 None,),
1126 ]
1127
Edward Lemur1b52d872019-05-09 21:12:12 +00001128 final_description = final_description or post_amend_description.strip()
1129 original_title = original_title or title or '<untitled>'
1130 # Trace-related calls
1131 calls += [
1132 # Write a description with context for the current trace.
1133 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001134 'Thu Mar 16 20:00:41 2017\n'
1135 '%(short_hostname)s-review.googlesource.com\n'
1136 '%(change_id)s\n'
1137 '%(title)s\n'
1138 '%(description)s\n'
1139 '1000\n'
1140 '0\n'
1141 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001142 'short_hostname': short_hostname,
1143 'change_id': change_id,
1144 'description': final_description,
1145 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001146 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001147 }],),
1148 None,
1149 ),
1150 # Read traces and shorten git hashes.
1151 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1152 True,
1153 ),
1154 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1155 ('git-hash: 0123456789012345678901234567890123456789\n'
1156 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1157 ),
1158 ((['FileWrite', 'TEMP_DIR/trace-packet',
1159 'git-hash: 012345\n'
1160 'git-hash: abcdea\n'],),
1161 None,
1162 ),
1163 # Make zip file for the git traces.
1164 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1165 'TEMP_DIR'],),
1166 None,
1167 ),
1168 # Collect git config and gitcookies.
1169 ((['git', 'config', '-l'],),
1170 'git-config-output',
1171 ),
1172 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1173 None,
1174 ),
1175 ((['os.path.isfile', '~/.gitcookies'],),
1176 gitcookies_exists,
1177 ),
1178 ]
1179 if gitcookies_exists:
1180 calls += [
1181 ((['FileRead', '~/.gitcookies'],),
1182 'gitcookies 1/SECRET',
1183 ),
1184 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1185 None,
1186 ),
1187 ]
1188 calls += [
1189 # Make zip file for the git config and gitcookies.
1190 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1191 'TEMP_DIR'],),
1192 None,
1193 ),
1194 ]
1195
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001196 if squash:
1197 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001198 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001199 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001200 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001201 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001202 ((['git', 'config', 'branch.master.gerritsquashhash',
1203 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001204 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001205 # TODO(crbug/877717): this should never be used.
1206 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001207 calls += [
1208 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001209 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001210 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001211 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1212 notify),
1213 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001214 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001215 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001216 return calls
1217
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001218 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001219 self,
1220 upload_args,
1221 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001222 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001223 squash=True,
1224 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001225 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001226 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001227 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001228 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001229 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001230 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001231 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001232 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001233 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001234 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001235 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001236 labels=None,
1237 change_id=None,
1238 original_title=None,
1239 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001240 gitcookies_exists=True,
1241 force=False,
1242 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001243 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001244 if squash_mode is None:
1245 if '--no-squash' in upload_args:
1246 squash_mode = 'nosquash'
1247 elif '--squash' in upload_args:
1248 squash_mode = 'squash'
1249 else:
1250 squash_mode = 'default'
1251
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001252 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001253 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001254 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001255 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001256 CookiesAuthenticatorMockFactory(
1257 same_auth=('git-owner.example.com', '', 'pass')))
Edward Lemur125d60a2019-09-13 18:25:41 +00001258 self.mock(git_cl.Changelist, '_GerritCommitMsgHookCheck',
tandrii16e0b4e2016-06-07 10:34:28 -07001259 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001260 self.mock(git_cl.gclient_utils, 'RunEditor',
1261 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001262 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1263 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001264 self.mock(git_cl.gclient_utils, 'FileRead',
1265 lambda path: self._mocked_call(['FileRead', path]))
1266 self.mock(git_cl.gclient_utils, 'FileWrite',
1267 lambda path, contents: self._mocked_call(
1268 ['FileWrite', path, contents]))
1269 self.mock(git_cl, 'datetime_now',
1270 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1271 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1272 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
Edward Lemur75391d42019-05-14 23:35:56 +00001273 self.mock(git_cl, 'TRACES_README_FORMAT',
1274 '%(now)s\n'
1275 '%(gerrit_host)s\n'
1276 '%(change_id)s\n'
1277 '%(title)s\n'
1278 '%(description)s\n'
1279 '%(execution_time)s\n'
1280 '%(exit_code)s\n'
1281 '%(trace_name)s')
Edward Lemur1b52d872019-05-09 21:12:12 +00001282 self.mock(git_cl.shutil, 'make_archive',
1283 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1284 self.mock(os.path, 'isfile',
1285 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001286
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001287 self.calls = self._gerrit_base_calls(
1288 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001289 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001290 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001291 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001292 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001293 short_hostname=short_hostname,
1294 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001295 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001296 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1297 expected_content=description))
1298 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001299 self.calls += self._gerrit_upload_calls(
1300 description, reviewers, squash,
1301 squash_mode=squash_mode,
1302 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001303 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001304 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001305 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001306 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001307 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001308 labels=labels,
1309 change_id=change_id,
1310 original_title=original_title,
1311 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001312 gitcookies_exists=gitcookies_exists,
1313 force=force)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001314 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001315 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001316 git_cl.main(['upload'] + upload_args)
1317
Edward Lemur1b52d872019-05-09 21:12:12 +00001318 def test_gerrit_upload_traces_no_gitcookies(self):
1319 self._run_gerrit_upload_test(
1320 ['--no-squash'],
1321 'desc\n\nBUG=\n',
1322 [],
1323 squash=False,
1324 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1325 change_id='Ixxx',
1326 gitcookies_exists=False)
1327
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001328 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001329 self._run_gerrit_upload_test(
1330 ['--no-squash'],
1331 'desc\n\nBUG=\n',
1332 [],
1333 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001334 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1335 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001336
1337 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001338 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001339 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001340 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001341 [],
tandriia60502f2016-06-20 02:01:53 -07001342 squash=False,
1343 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001344 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1345 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001346
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001347 def test_gerrit_no_reviewer(self):
1348 self._run_gerrit_upload_test(
1349 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001350 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001351 [],
1352 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001353 squash_mode='override_nosquash',
1354 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001355
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001356 def test_gerrit_no_reviewer_non_chromium_host(self):
1357 # TODO(crbug/877717): remove this test case.
1358 self._run_gerrit_upload_test(
1359 [],
1360 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1361 [],
1362 squash=False,
1363 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001364 short_hostname='other',
1365 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001366
Nick Carter8692b182017-11-06 16:30:38 -08001367 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001368 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1369 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001370 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001371 'desc\n\nBUG=\n\nChange-Id: I123456789',
1372 squash=False,
1373 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001374 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1375 change_id='I123456789',
1376 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001377
ukai@chromium.orge8077812012-02-03 03:41:46 +00001378 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001379 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001380 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001381 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001382 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001383 squash=False,
1384 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001385 notify=True,
1386 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001387 final_description=(
1388 'desc\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001389
Anthony Polito8b955342019-09-24 19:01:36 +00001390 def test_gerrit_upload_force_sets_bug(self):
1391 self._run_gerrit_upload_test(
1392 ['-b', '10000', '-f'],
1393 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1394 [],
1395 force=True,
1396 expected_upstream_ref='origin/master',
1397 fetched_description='desc=\n\nChange-Id: Ixxx',
1398 original_title='Initial upload',
1399 change_id='Ixxx')
1400
1401 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1402 self._run_gerrit_upload_test(
1403 ['-b', '10000', '-f', '-m', 'Title'],
1404 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1405 [],
1406 force=True,
1407 issue='123456',
1408 expected_upstream_ref='origin/master',
1409 fetched_description='desc=\n\nChange-Id: Ixxxx',
1410 original_title='Title',
1411 title='Title',
1412 change_id='Izzzz')
1413
ukai@chromium.orge8077812012-02-03 03:41:46 +00001414 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001415 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1416 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001417 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001418 [],
bradnelsond975b302016-10-23 12:20:23 -07001419 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1420 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001421 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001422 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001423 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001424 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001425 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001426 labels={'Code-Review': 2},
1427 change_id='123456789',
1428 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001429
1430 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001431 self._run_gerrit_upload_test(
1432 [],
1433 'desc\nBUG=\n\nChange-Id: 123456789',
1434 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001435 expected_upstream_ref='origin/master',
1436 change_id='123456789',
1437 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001438
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001439 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001440 self._run_gerrit_upload_test(
1441 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001442 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001443 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001444 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001445 expected_upstream_ref='origin/master',
1446 change_id='123456789',
1447 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001448
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001449 def test_gerrit_upload_squash_first_with_labels(self):
1450 self._run_gerrit_upload_test(
1451 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1452 'desc\nBUG=\n\nChange-Id: 123456789',
1453 [],
1454 squash=True,
1455 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001456 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1457 change_id='123456789',
1458 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001459
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001460 def test_gerrit_upload_squash_first_against_rev(self):
1461 custom_cl_base = 'custom_cl_base_rev_or_branch'
1462 self._run_gerrit_upload_test(
1463 ['--squash', custom_cl_base],
1464 'desc\nBUG=\n\nChange-Id: 123456789',
1465 [],
1466 squash=True,
1467 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001468 custom_cl_base=custom_cl_base,
1469 change_id='123456789',
1470 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001471 self.assertIn(
1472 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1473 sys.stdout.getvalue())
1474
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001475 def test_gerrit_upload_squash_reupload(self):
1476 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001477 self._run_gerrit_upload_test(
1478 ['--squash'],
1479 description,
1480 [],
1481 squash=True,
1482 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001483 issue=123456,
1484 change_id='123456789',
1485 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001486
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001487 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1488 self.mock(git_cl, 'DieWithError',
1489 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1490 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1491 with self.assertRaises(SystemExitMock):
1492 self._run_gerrit_upload_test(
1493 ['--squash'],
1494 description,
1495 [],
1496 squash=True,
1497 expected_upstream_ref='origin/master',
1498 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001499 fetched_status='ABANDONED',
1500 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001501
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001502 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1503 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1504 lambda *_, **__: {'email': 'yet-another@example.com'})
1505 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1506 self._run_gerrit_upload_test(
1507 ['--squash'],
1508 description,
1509 [],
1510 squash=True,
1511 expected_upstream_ref='origin/master',
1512 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001513 other_cl_owner='other@example.com',
1514 change_id='123456789',
1515 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001516 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001517 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001518 'authenticate to Gerrit as yet-another@example.com.\n'
1519 'Uploading may fail due to lack of permissions',
1520 git_cl.sys.stdout.getvalue())
1521
rmistry@google.com2dd99862015-06-22 12:22:18 +00001522 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001523 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001524 def mock_run_git(*args, **_kwargs):
1525 if args[0] == ['for-each-ref',
1526 '--format=%(refname:short) %(upstream:short)',
1527 'refs/heads']:
1528 # Create a local branch dependency tree that looks like this:
1529 # test1 -> test2 -> test3 -> test4 -> test5
1530 # -> test3.1
1531 # test6 -> test0
1532 branch_deps = [
1533 'test2 test1', # test1 -> test2
1534 'test3 test2', # test2 -> test3
1535 'test3.1 test2', # test2 -> test3.1
1536 'test4 test3', # test3 -> test4
1537 'test5 test4', # test4 -> test5
1538 'test6 test0', # test0 -> test6
1539 'test7', # test7
1540 ]
1541 return '\n'.join(branch_deps)
1542 self.mock(git_cl, 'RunGit', mock_run_git)
1543
1544 class RecordCalls:
1545 times_called = 0
1546 record_calls = RecordCalls()
1547 def mock_CMDupload(*args, **_kwargs):
1548 record_calls.times_called += 1
1549 return 0
1550 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1551
1552 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001553 (('ask_for_data', 'This command will checkout all dependent branches '
1554 'and run "git cl upload". Press Enter to continue, '
1555 'or Ctrl+C to abort'), ''),
1556 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001557
1558 class MockChangelist():
1559 def __init__(self):
1560 pass
1561 def GetBranch(self):
1562 return 'test1'
1563 def GetIssue(self):
1564 return '123'
1565 def GetPatchset(self):
1566 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001567 def IsGerrit(self):
1568 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001569
1570 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1571 # CMDupload should have been called 5 times because of 5 dependent branches.
1572 self.assertEquals(5, record_calls.times_called)
1573 self.assertEquals(0, ret)
1574
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001575 def test_gerrit_change_id(self):
1576 self.calls = [
1577 ((['git', 'write-tree'], ),
1578 'hashtree'),
1579 ((['git', 'rev-parse', 'HEAD~0'], ),
1580 'branch-parent'),
1581 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1582 'A B <a@b.org> 1456848326 +0100'),
1583 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1584 'C D <c@d.org> 1456858326 +0100'),
1585 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1586 'hashchange'),
1587 ]
1588 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1589 self.assertEqual(change_id, 'Ihashchange')
1590
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001591 def test_desecription_append_footer(self):
1592 for init_desc, footer_line, expected_desc in [
1593 # Use unique desc first lines for easy test failure identification.
1594 ('foo', 'R=one', 'foo\n\nR=one'),
1595 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1596 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1597 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1598 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1599 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1600 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1601 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1602 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1603 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1604 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1605 ]:
1606 desc = git_cl.ChangeDescription(init_desc)
1607 desc.append_footer(footer_line)
1608 self.assertEqual(desc.description, expected_desc)
1609
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001610 def test_update_reviewers(self):
1611 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001612 ('foo', [], [],
1613 'foo'),
1614 ('foo\nR=xx', [], [],
1615 'foo\nR=xx'),
1616 ('foo\nTBR=xx', [], [],
1617 'foo\nTBR=xx'),
1618 ('foo', ['a@c'], [],
1619 'foo\n\nR=a@c'),
1620 ('foo\nR=xx', ['a@c'], [],
1621 'foo\n\nR=a@c, xx'),
1622 ('foo\nTBR=xx', ['a@c'], [],
1623 'foo\n\nR=a@c\nTBR=xx'),
1624 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1625 'foo\n\nR=a@c, yy\nTBR=xx'),
1626 ('foo\nBUG=', ['a@c'], [],
1627 'foo\nBUG=\nR=a@c'),
1628 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1629 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1630 ('foo', ['a@c', 'b@c'], [],
1631 'foo\n\nR=a@c, b@c'),
1632 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1633 'foo\nBar\n\nR=c@c\nBUG='),
1634 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1635 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001636 # Same as the line before, but full of whitespaces.
1637 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001638 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001639 'foo\nBar\n\nR=c@c\n BUG =',
1640 ),
1641 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001642 ('foo BUG=allo R=joe ', ['c@c'], [],
1643 'foo BUG=allo R=joe\n\nR=c@c'),
1644 # Redundant TBRs get promoted to Rs
1645 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1646 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001647 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001648 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001649 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001650 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001651 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001652 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001653 actual.append(obj.description)
1654 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001655
Nodir Turakulov23b82142017-11-16 11:04:25 -08001656 def test_get_hash_tags(self):
1657 cases = [
1658 ('', []),
1659 ('a', []),
1660 ('[a]', ['a']),
1661 ('[aa]', ['aa']),
1662 ('[a ]', ['a']),
1663 ('[a- ]', ['a']),
1664 ('[a- b]', ['a-b']),
1665 ('[a--b]', ['a-b']),
1666 ('[a', []),
1667 ('[a]x', ['a']),
1668 ('[aa]x', ['aa']),
1669 ('[a b]', ['a-b']),
1670 ('[a b]', ['a-b']),
1671 ('[a__b]', ['a-b']),
1672 ('[a] x', ['a']),
1673 ('[a][b]', ['a', 'b']),
1674 ('[a] [b]', ['a', 'b']),
1675 ('[a][b]x', ['a', 'b']),
1676 ('[a][b] x', ['a', 'b']),
1677 ('[a]\n[b]', ['a']),
1678 ('[a\nb]', []),
1679 ('[a][', ['a']),
1680 ('Revert "[a] feature"', ['a']),
1681 ('Reland "[a] feature"', ['a']),
1682 ('Revert: [a] feature', ['a']),
1683 ('Reland: [a] feature', ['a']),
1684 ('Revert "Reland: [a] feature"', ['a']),
1685 ('Foo: feature', ['foo']),
1686 ('Foo Bar: feature', ['foo-bar']),
1687 ('Revert "Foo bar: feature"', ['foo-bar']),
1688 ('Reland "Foo bar: feature"', ['foo-bar']),
1689 ]
1690 for desc, expected in cases:
1691 change_desc = git_cl.ChangeDescription(desc)
1692 actual = change_desc.get_hash_tags()
1693 self.assertEqual(
1694 actual,
1695 expected,
1696 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1697
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001698 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001699 self.assertEqual(None, git_cl.GetTargetRef(None,
1700 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001701 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001702
wittman@chromium.org455dc922015-01-26 20:15:50 +00001703 # Check default target refs for branches.
1704 self.assertEqual('refs/heads/master',
1705 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001706 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001707 self.assertEqual('refs/heads/master',
1708 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001709 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001710 self.assertEqual('refs/heads/master',
1711 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001712 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001713 self.assertEqual('refs/branch-heads/123',
1714 git_cl.GetTargetRef('origin',
1715 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001716 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001717 self.assertEqual('refs/diff/test',
1718 git_cl.GetTargetRef('origin',
1719 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001720 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001721 self.assertEqual('refs/heads/chrome/m42',
1722 git_cl.GetTargetRef('origin',
1723 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001724 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001725
1726 # Check target refs for user-specified target branch.
1727 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1728 'refs/remotes/branch-heads/123'):
1729 self.assertEqual('refs/branch-heads/123',
1730 git_cl.GetTargetRef('origin',
1731 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001732 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001733 for branch in ('origin/master', 'remotes/origin/master',
1734 'refs/remotes/origin/master'):
1735 self.assertEqual('refs/heads/master',
1736 git_cl.GetTargetRef('origin',
1737 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001738 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001739 for branch in ('master', 'heads/master', 'refs/heads/master'):
1740 self.assertEqual('refs/heads/master',
1741 git_cl.GetTargetRef('origin',
1742 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001743 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001744
wychen@chromium.orga872e752015-04-28 23:42:18 +00001745 def test_patch_when_dirty(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001746 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001747 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1748 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1749
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001750 @staticmethod
1751 def _get_gerrit_codereview_server_calls(branch, value=None,
1752 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001753 detect_branch=True,
1754 detect_server=True):
Edward Lemur125d60a2019-09-13 18:25:41 +00001755 """Returns calls executed by Changelist.GetCodereviewServer.
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001756
1757 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1758 """
1759 calls = []
1760 if detect_branch:
1761 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001762 if detect_server:
1763 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1764 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001765 if value is None:
1766 calls += [
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001767 ((['git', 'config', 'branch.' + branch + '.merge'],),
1768 'refs/heads' + branch),
1769 ((['git', 'config', 'branch.' + branch + '.remote'],),
1770 'origin'),
1771 ((['git', 'config', 'remote.origin.url'],),
1772 'https://%s.googlesource.com/my/repo' % git_short_host),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001773 ]
1774 return calls
1775
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001776 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001777 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001778 detect_gerrit_server=False,
1779 actual_codereview=None,
1780 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001781 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001782 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1783
tandriidf09a462016-08-18 16:23:55 -07001784 if new_branch:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001785 self.calls = [((['git', 'new-branch', 'master'],), '')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001786
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001787 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001788 self.calls += [
1789 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001790 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001791 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001792
1793 if not force_codereview and not codereview_in_url:
1794 # These calls detect codereview to use.
1795 self.calls += [
1796 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001797 ]
1798 if detect_gerrit_server:
1799 self.calls += self._get_gerrit_codereview_server_calls(
1800 'master', git_short_host=git_short_host,
1801 detect_branch=not new_branch and force_codereview)
1802 actual_codereview = 'gerrit'
1803
1804 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001805 self.calls += [
1806 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001807 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001808 {
1809 'current_revision': '7777777777',
1810 'revisions': {
1811 '1111111111': {
1812 '_number': 1,
1813 'fetch': {'http': {
1814 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1815 'ref': 'refs/changes/56/123456/1',
1816 }},
1817 },
1818 '7777777777': {
1819 '_number': 7,
1820 'fetch': {'http': {
1821 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1822 'ref': 'refs/changes/56/123456/7',
1823 }},
1824 },
1825 },
1826 }),
1827 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001828
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001829 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001830 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001831 self.calls += [
1832 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1833 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001834 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001835 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001836 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001837 ((['git', 'config', 'branch.master.gerritserver',
1838 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001839 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001840 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1841 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1842 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001843 ]
1844 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1845
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001846 def test_patch_gerrit_new_branch(self):
1847 self._patch_common(
1848 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1849 self.calls += [
1850 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1851 'refs/changes/56/123456/7'],), ''),
1852 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1853 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1854 ''),
1855 ((['git', 'config', 'branch.master.gerritserver',
1856 'https://chromium-review.googlesource.com'],), ''),
1857 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1858 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1859 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1860 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1861 ]
1862 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1863
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001864 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001865 self._patch_common(
1866 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001867 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001868 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001869 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001870 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001871 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001872 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001873 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001874 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001875 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001876 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1877 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1878 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001879 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001880 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001881
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001882 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001883 self.calls += self._get_gerrit_codereview_server_calls(
1884 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001885 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001886 actual_codereview='gerrit', git_short_host='else',
1887 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001888 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001889 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001890 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001891 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001892 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001893 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001894 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001895 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001896 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001897 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1898 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1899 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001900 ]
1901 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001902 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001903
Aaron Gable697a91b2018-01-19 15:20:15 -08001904 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001905 self.calls += self._get_gerrit_codereview_server_calls(
1906 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001907 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001908 actual_codereview='gerrit', git_short_host='else',
1909 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001910 self.calls += [
1911 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1912 'refs/changes/56/123456/1'],), ''),
1913 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1914 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1915 ''),
1916 ((['git', 'config', 'branch.master.gerritserver',
1917 'https://else-review.googlesource.com'],), ''),
1918 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1919 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1920 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1921 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1922 ]
1923 self.assertEqual(git_cl.main(
1924 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1925 0)
1926
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001927 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001928 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001929 self.calls += [
1930 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001931 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001932 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1933 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1934 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001935 ]
1936 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001937 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001938
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001939 def test_patch_gerrit_not_exists(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001940
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001941 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001942 raise git_cl.gerrit_util.GerritError(404, '')
1943 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1944
tandriic2405f52016-10-10 08:13:15 -07001945 self.calls = [
1946 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001947 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1948 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1949 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1950 ((['git', 'config', 'remote.origin.url'],),
1951 'https://chromium.googlesource.com/my/repo'),
1952 ((['DieWithError',
1953 'change 123456 at https://chromium-review.googlesource.com does not '
1954 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001955 ]
1956 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001957 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001958
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001959 def _checkout_calls(self):
1960 return [
1961 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001962 'branch\\..*\\.gerritissue'], ),
1963 ('branch.ger-branch.gerritissue 123456\n'
1964 'branch.gbranch654.gerritissue 654321\n')),
1965 ]
1966
1967 def test_checkout_gerrit(self):
1968 """Tests git cl checkout <issue>."""
1969 self.calls = self._checkout_calls()
1970 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1971 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1972
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001973 def test_checkout_not_found(self):
1974 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001975 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001976 self.calls = self._checkout_calls()
1977 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1978
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001979 def test_checkout_no_branch_issues(self):
1980 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001981 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001982 self.calls = [
1983 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001984 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001985 ]
1986 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1987
tandrii@chromium.org28253532016-04-14 13:46:56 +00001988 def _test_gerrit_ensure_authenticated_common(self, auth,
1989 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001990 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1991 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1992 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001993 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001994 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
Edward Lemurf38bc172019-09-03 21:02:13 +00001995 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001996 cl.branch = 'master'
1997 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001998 return cl
1999
2000 def test_gerrit_ensure_authenticated_missing(self):
2001 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002002 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002003 })
2004 self.calls.append(
2005 ((['DieWithError',
2006 'Credentials for the following hosts are required:\n'
2007 ' chromium-review.googlesource.com\n'
2008 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002009 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002010 'https://chromium-review.googlesource.com/new-password'],), ''),)
2011 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2012
2013 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00002014 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002015 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002016 'chromium.googlesource.com':
2017 ('git-one.example.com', None, 'secret1'),
2018 'chromium-review.googlesource.com':
2019 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002020 })
2021 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002022 (('ask_for_data', 'If you know what you are doing '
2023 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002024 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2025
2026 def test_gerrit_ensure_authenticated_ok(self):
2027 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002028 'chromium.googlesource.com':
2029 ('git-same.example.com', None, 'secret'),
2030 'chromium-review.googlesource.com':
2031 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002032 })
2033 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2034
tandrii@chromium.org28253532016-04-14 13:46:56 +00002035 def test_gerrit_ensure_authenticated_skipped(self):
2036 cl = self._test_gerrit_ensure_authenticated_common(
2037 auth={}, skip_auth_check=True)
2038 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2039
Eric Boren2fb63102018-10-05 13:05:03 +00002040 def test_gerrit_ensure_authenticated_bearer_token(self):
2041 cl = self._test_gerrit_ensure_authenticated_common(auth={
2042 'chromium.googlesource.com':
2043 ('', None, 'secret'),
2044 'chromium-review.googlesource.com':
2045 ('', None, 'secret'),
2046 })
2047 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2048 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2049 'chromium.googlesource.com')
2050 self.assertTrue('Bearer' in header)
2051
Daniel Chengcf6269b2019-05-18 01:02:12 +00002052 def test_gerrit_ensure_authenticated_non_https(self):
2053 self.calls = [
2054 ((['git', 'config', '--bool',
2055 'gerrit.skip-ensure-authenticated'],), CERR1),
2056 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2057 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2058 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
2059 ]
2060 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2061 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
Edward Lemurf38bc172019-09-03 21:02:13 +00002062 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002063 cl.branch = 'master'
2064 cl.branchref = 'refs/heads/master'
2065 cl.lookedup_issue = True
2066 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2067
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002068 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002069 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002070 lambda h, i, labels, notify=None:
2071 self._mocked_call(['SetReview', h, i, labels, notify]))
2072
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002073 self.calls = [
2074 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002075 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002076 ((['git', 'config', 'branch.feature.gerritserver'],),
2077 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002078 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2079 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2080 ((['git', 'config', 'remote.origin.url'],),
2081 'https://chromium.googlesource.com/infra/infra.git'),
2082 ((['SetReview', 'chromium-review.googlesource.com',
2083 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002084 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002085 ]
tandriid9e5ce52016-07-13 02:32:59 -07002086
2087 def test_cmd_set_commit_gerrit_clear(self):
2088 self._cmd_set_commit_gerrit_common(0)
2089 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2090
2091 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002092 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002093 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2094
tandriid9e5ce52016-07-13 02:32:59 -07002095 def test_cmd_set_commit_gerrit(self):
2096 self._cmd_set_commit_gerrit_common(2)
2097 self.assertEqual(0, git_cl.main(['set-commit']))
2098
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002099 def test_description_display(self):
2100 out = StringIO.StringIO()
2101 self.mock(git_cl.sys, 'stdout', out)
2102
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002103 self.mock(git_cl, 'Changelist', ChangelistMock)
2104 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002105
2106 self.assertEqual(0, git_cl.main(['description', '-d']))
2107 self.assertEqual('foo\n', out.getvalue())
2108
iannucci3c972b92016-08-17 13:24:10 -07002109 def test_StatusFieldOverrideIssueMissingArgs(self):
2110 out = StringIO.StringIO()
2111 self.mock(git_cl.sys, 'stderr', out)
2112
2113 try:
2114 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2115 except SystemExit as ex:
2116 self.assertEqual(ex.code, 2)
Edward Lemurf38bc172019-09-03 21:02:13 +00002117 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002118
2119 out = StringIO.StringIO()
2120 self.mock(git_cl.sys, 'stderr', out)
2121
2122 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002123 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002124 except SystemExit as ex:
2125 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002126 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002127
2128 def test_StatusFieldOverrideIssue(self):
2129 out = StringIO.StringIO()
2130 self.mock(git_cl.sys, 'stdout', out)
2131
2132 def assertIssue(cl_self, *_args):
2133 self.assertEquals(cl_self.issue, 1)
2134 return 'foobar'
2135
2136 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002137 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002138 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002139 0)
iannucci3c972b92016-08-17 13:24:10 -07002140 self.assertEqual(out.getvalue(), 'foobar\n')
2141
iannuccie53c9352016-08-17 14:40:40 -07002142 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002143
iannuccie53c9352016-08-17 14:40:40 -07002144 def assertIssue(cl_self, *_args):
2145 self.assertEquals(cl_self.issue, 1)
2146 return 'foobar'
2147
2148 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2149 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002150 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002151 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002152
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002153 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002154 out = StringIO.StringIO()
2155 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002156 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002157 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2158 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2159 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2160 ((['git', 'config', 'remote.origin.url'],),
2161 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002162 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002163 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002164 {
2165 'current_revision': 'sha1',
2166 'revisions': {'sha1': {
2167 'commit': {'message': 'foobar'},
2168 }},
2169 }),
2170 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002171 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002172 'description',
2173 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2174 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002175 self.assertEqual('foobar\n', out.getvalue())
2176
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002177 def test_description_set_raw(self):
2178 out = StringIO.StringIO()
2179 self.mock(git_cl.sys, 'stdout', out)
2180
2181 self.mock(git_cl, 'Changelist', ChangelistMock)
2182 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2183
2184 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2185 self.assertEqual('hihi', ChangelistMock.desc)
2186
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002187 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002188 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002189
2190 def RunEditor(desc, _, **kwargs):
2191 self.assertEquals(
2192 '# Enter a description of the change.\n'
2193 '# This will be displayed on the codereview site.\n'
2194 '# The first line will also be used as the subject of the review.\n'
2195 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002196 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002197 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002198 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002199 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002200 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002201
dsansomee2d6fd92016-09-08 00:10:47 -07002202 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002203 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002204
2205 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2206 self.mock(git_cl.Changelist, 'GetDescription',
2207 lambda *args: current_desc)
Edward Lemur125d60a2019-09-13 18:25:41 +00002208 self.mock(git_cl.Changelist, 'UpdateDescriptionRemote',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002209 UpdateDescriptionRemote)
2210 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2211
2212 self.calls = [
2213 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002214 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002215 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2216 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002217 ((['git', 'config', 'core.editor'],), 'vi'),
2218 ]
2219 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2220
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002221 def test_description_set_stdin(self):
2222 out = StringIO.StringIO()
2223 self.mock(git_cl.sys, 'stdout', out)
2224
2225 self.mock(git_cl, 'Changelist', ChangelistMock)
2226 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2227
2228 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2229 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2230
kmarshall3bff56b2016-06-06 18:31:47 -07002231 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002232 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2233
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002234 self.calls = [
2235 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002236 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002237 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2238 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002239 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002240 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002241
kmarshall3bff56b2016-06-06 18:31:47 -07002242 self.mock(git_cl, 'get_cl_statuses',
2243 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002244 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2245 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2246 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002247
2248 self.assertEqual(0, git_cl.main(['archive', '-f']))
2249
2250 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002251 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002252 self.calls = [
2253 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2254 'refs/heads/master'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002255 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2256 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002257
kmarshall9249e012016-08-23 12:02:16 -07002258 self.mock(git_cl, 'get_cl_statuses',
2259 lambda branches, fine_grained, max_processes:
2260 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2261
2262 self.assertEqual(1, git_cl.main(['archive', '-f']))
2263
2264 def test_archive_dry_run(self):
2265 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2266
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002267 self.calls = [
2268 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2269 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002270 ((['git', 'symbolic-ref', 'HEAD'],), 'master')
2271 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002272
2273 self.mock(git_cl, 'get_cl_statuses',
2274 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002275 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2276 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2277 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002278
kmarshall9249e012016-08-23 12:02:16 -07002279 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2280
2281 def test_archive_no_tags(self):
2282 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2283
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002284 self.calls = [
2285 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2286 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002287 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2288 ((['git', 'branch', '-D', 'foo'],), '')
2289 ]
kmarshall9249e012016-08-23 12:02:16 -07002290
2291 self.mock(git_cl, 'get_cl_statuses',
2292 lambda branches, fine_grained, max_processes:
2293 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2294 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2295 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2296
2297 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002298
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002299 def test_cmd_issue_erase_existing(self):
2300 out = StringIO.StringIO()
2301 self.mock(git_cl.sys, 'stdout', out)
2302 self.calls = [
2303 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002304 # Let this command raise exception (retcode=1) - it should be ignored.
2305 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002306 CERR1),
2307 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2308 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002309 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2310 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2311 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002312 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002313 ]
2314 self.assertEqual(0, git_cl.main(['issue', '0']))
2315
Aaron Gable400e9892017-07-12 15:31:21 -07002316 def test_cmd_issue_erase_existing_with_change_id(self):
2317 out = StringIO.StringIO()
2318 self.mock(git_cl.sys, 'stdout', out)
2319 self.mock(git_cl.Changelist, 'GetDescription',
2320 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2321 self.calls = [
2322 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002323 # Let this command raise exception (retcode=1) - it should be ignored.
2324 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2325 CERR1),
2326 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2327 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2328 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2329 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2330 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002331 ((['git', 'log', '-1', '--format=%B'],),
2332 'This is a description\n\nChange-Id: Ideadbeef'),
2333 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002334 ]
2335 self.assertEqual(0, git_cl.main(['issue', '0']))
2336
phajdan.jre328cf92016-08-22 04:12:17 -07002337 def test_cmd_issue_json(self):
2338 out = StringIO.StringIO()
2339 self.mock(git_cl.sys, 'stdout', out)
2340 self.calls = [
2341 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002342 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2343 ((['git', 'config', 'branch.feature.gerritserver'],),
2344 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002345 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002346 {'issue': 123,
2347 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002348 ''),
2349 ]
2350 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2351
tandrii8c5a3532016-11-04 07:52:02 -07002352 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2353 self.mock(git_cl.Changelist, 'GetChange',
2354 lambda _, *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002355 self._mocked_call(['GetChange'] + list(a))))
tandrii8c5a3532016-11-04 07:52:02 -07002356 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2357 lambda *_, **__: (
2358 self._mocked_call(['DoGetTryMasters'])))
Edward Lemur125d60a2019-09-13 18:25:41 +00002359 self.mock(git_cl.Changelist, 'SetCQState',
tandrii8c5a3532016-11-04 07:52:02 -07002360 lambda _, s: self._mocked_call(['SetCQState', s]))
2361
tandrii8c5a3532016-11-04 07:52:02 -07002362 self.calls = [
2363 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002364 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2365 ((['git', 'config', 'branch.feature.gerritserver'],),
2366 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002367 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2368 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2369 ((['git', 'config', 'remote.origin.url'],),
2370 'https://chromium.googlesource.com/depot_tools'),
2371 (('GetChangeDetail', 'chromium-review.googlesource.com',
2372 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002373 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2374 'project': 'depot_tools',
2375 'status': 'OPEN',
2376 'owner': {'email': 'owner@e.mail'},
2377 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002378 'deadbeaf': {
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002379 '_number': 6,
2380 },
2381 'beeeeeef': {
2382 '_number': 7,
2383 'fetch': {'http': {
2384 'url': 'https://chromium.googlesource.com/depot_tools',
2385 'ref': 'refs/changes/56/123456/7'
2386 }},
2387 },
2388 },
2389 }),
tandrii8c5a3532016-11-04 07:52:02 -07002390 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2391 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2392 ((['get_or_create_merge_base', 'feature', 'feature'],),
2393 'fake_ancestor_sha'),
2394 ((['GetChange', 'fake_ancestor_sha', None], ),
2395 git_cl.presubmit_support.GitChange(
2396 '', '', '', '', '', '', '', '')),
2397 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2398 ((['DoGetTryMasters'], ), None),
Edward Lemur125d60a2019-09-13 18:25:41 +00002399 ((['SetCQState', git_cl._CQState.DRY_RUN], ), 0),
tandrii8c5a3532016-11-04 07:52:02 -07002400 ]
2401 out = StringIO.StringIO()
2402 self.mock(git_cl.sys, 'stdout', out)
2403 self.assertEqual(0, git_cl.main(['try']))
2404 self.assertEqual(
2405 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002406 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002407 'https://chromium-review.googlesource.com/123456\n')
2408
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002409 def test_parse_bucket(self):
2410 self.assertEqual(git_cl._parse_bucket('chromium/try'), ('chromium', 'try'))
2411 self.assertEqual(
2412 git_cl._parse_bucket('luci.chromium.try'), ('chromium', 'try'))
2413 self.assertEqual(git_cl._parse_bucket('not-a-bucket'), (None, None))
2414 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2415 self.assertEqual(
2416 git_cl._parse_bucket('skia.primary'),
2417 ('skia', 'skia.primary'))
2418 self.assertIn(
2419 'WARNING Please specify buckets',
2420 git_cl.sys.stdout.getvalue())
2421
2422 def test_git_cl_try_buildbucket_with_wrong_bucket(self):
tandrii8c5a3532016-11-04 07:52:02 -07002423 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2424 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2425
tandrii8c5a3532016-11-04 07:52:02 -07002426 self.calls = [
2427 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002428 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2429 ((['git', 'config', 'branch.feature.gerritserver'],),
2430 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002431 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2432 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2433 ((['git', 'config', 'remote.origin.url'],),
2434 'https://chromium.googlesource.com/depot_tools'),
2435 (('GetChangeDetail', 'chromium-review.googlesource.com',
2436 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002437 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002438 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002439 'status': 'OPEN',
2440 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002441 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002442 'deadbeaf': {
tandrii8c5a3532016-11-04 07:52:02 -07002443 '_number': 6,
2444 },
2445 'beeeeeef': {
2446 '_number': 7,
2447 'fetch': {'http': {
2448 'url': 'https://chromium.googlesource.com/depot_tools',
2449 'ref': 'refs/changes/56/123456/7'
2450 }},
2451 },
2452 },
2453 }),
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002454 ((['git', 'config', 'branch.feature.gerritpatchset'],), '7'),
tandrii8c5a3532016-11-04 07:52:02 -07002455 ]
2456
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002457 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2458 self.assertEqual(0, git_cl.main([
2459 'try', '-B', 'not-a-bucket', '-b', 'win',
2460 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2461 self.assertIn(
2462 'Could not parse bucket "not-a-bucket"',
2463 git_cl.sys.stdout.getvalue())
Edward Lemur2c210a42019-09-16 23:58:35 +00002464
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002465 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2466 def _mock_call_buildbucket(_http, buildbucket_host, method, request=None):
2467 bb_request = {
2468 "requests": [{
2469 "scheduleBuild": {
2470 "requestId": "uuid4",
2471 "builder": {
2472 "project": "chromium",
2473 "builder": "win",
2474 "bucket": "try",
2475 },
2476 "gerritChanges": [{
2477 "project": "depot_tools",
2478 "host": "chromium-review.googlesource.com",
2479 "patchset": 7,
2480 "change": 123456,
2481 }],
2482 "properties": {
2483 "category": "git_cl_try",
2484 "json": [{"a": 1}, None],
2485 "key": "val",
2486 },
2487 "tags": [
2488 {"value": "win", "key": "builder"},
2489 {"value": "git_cl_try", "key": "user_agent"},
2490 ],
2491 },
2492 }],
2493 }
2494 self.assertEqual(method, 'Batch')
2495 self.assertEqual(buildbucket_host, 'cr-buildbucket.appspot.com')
2496 self.assertEqual(request, bb_request)
2497 return {}
Edward Lemur2c210a42019-09-16 23:58:35 +00002498
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002499 self.mock(git_cl, '_call_buildbucket', _mock_call_buildbucket)
2500 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2501 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2502
2503 self.calls = [
2504 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2505 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2506 ((['git', 'config', 'branch.feature.gerritserver'],),
2507 'https://chromium-review.googlesource.com'),
2508 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2509 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2510 ((['git', 'config', 'remote.origin.url'],),
2511 'https://chromium.googlesource.com/depot_tools'),
2512 (('GetChangeDetail', 'chromium-review.googlesource.com',
2513 'depot_tools~123456',
2514 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2515 'project': 'depot_tools',
2516 'status': 'OPEN',
2517 'owner': {'email': 'owner@e.mail'},
2518 'revisions': {
2519 'deadbeaf': {
2520 '_number': 6,
2521 },
2522 'beeeeeef': {
2523 '_number': 7,
2524 'fetch': {'http': {
2525 'url': 'https://chromium.googlesource.com/depot_tools',
2526 'ref': 'refs/changes/56/123456/7'
2527 }},
2528 },
2529 },
2530 }),
2531 ((['git', 'config', 'branch.feature.gerritpatchset'],), '7'),
2532 ]
Edward Lemur2c210a42019-09-16 23:58:35 +00002533
tandrii8c5a3532016-11-04 07:52:02 -07002534 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2535 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002536 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002537 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002538 self.assertIn(
2539 'Scheduling jobs on:\nBucket: luci.chromium.try',
2540 git_cl.sys.stdout.getvalue())
tandriide281ae2016-10-12 06:02:30 -07002541
tandrii16e0b4e2016-06-07 10:34:28 -07002542 def _common_GerritCommitMsgHookCheck(self):
2543 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2544 self.mock(git_cl.os.path, 'abspath',
2545 lambda path: self._mocked_call(['abspath', path]))
2546 self.mock(git_cl.os.path, 'exists',
2547 lambda path: self._mocked_call(['exists', path]))
2548 self.mock(git_cl.gclient_utils, 'FileRead',
2549 lambda path: self._mocked_call(['FileRead', path]))
2550 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2551 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2552 self.calls = [
2553 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2554 ((['abspath', '../'],), '/abs/git_repo_root'),
2555 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002556 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002557
2558 def test_GerritCommitMsgHookCheck_custom_hook(self):
2559 cl = self._common_GerritCommitMsgHookCheck()
2560 self.calls += [
2561 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2562 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2563 '#!/bin/sh\necho "custom hook"')
2564 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002565 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002566
2567 def test_GerritCommitMsgHookCheck_not_exists(self):
2568 cl = self._common_GerritCommitMsgHookCheck()
2569 self.calls += [
2570 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2571 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002572 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002573
2574 def test_GerritCommitMsgHookCheck(self):
2575 cl = self._common_GerritCommitMsgHookCheck()
2576 self.calls += [
2577 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2578 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2579 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002580 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002581 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2582 ''),
2583 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002584 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002585
tandriic4344b52016-08-29 06:04:54 -07002586 def test_GerritCmdLand(self):
2587 self.calls += [
2588 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2589 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2590 'deadbeaf'),
2591 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2592 ((['git', 'config', 'branch.feature.gerritserver'],),
2593 'chromium-review.googlesource.com'),
2594 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002595 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002596 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002597 'labels': {},
2598 'current_revision': 'deadbeaf',
2599 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002600 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002601 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002602 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002603 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2604 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002605 cl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002606 out = StringIO.StringIO()
2607 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002608 self.assertEqual(0, cl.CMDLand(force=True,
2609 bypass_hooks=True,
2610 verbose=True,
2611 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002612 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002613 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002614
tandrii221ab252016-10-06 08:12:04 -07002615 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002616 '9000': {
2617 'id': '9000',
2618 'bucket': 'master.x.y',
2619 'created_by': 'user:someone@chromium.org',
2620 'created_ts': '147200002222000',
2621 'experimental': False,
2622 'parameters_json': json.dumps({
2623 'builder_name': 'my-bot',
2624 'properties': {'category': 'cq'},
2625 }),
2626 'status': 'STARTED',
2627 'tags': [
2628 'build_address:x.y/my-bot/2',
2629 'builder:my-bot',
2630 'experimental:false',
2631 'user_agent:cq',
2632 ],
2633 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2634 },
2635 '8000': {
2636 'id': '8000',
2637 'bucket': 'master.x.y',
2638 'created_by': 'user:someone@chromium.org',
2639 'created_ts': '147200001111000',
2640 'experimental': False,
2641 'failure_reason': 'BUILD_FAILURE',
2642 'parameters_json': json.dumps({
2643 'builder_name': 'my-bot',
2644 'properties': {'category': 'cq'},
2645 }),
2646 'result_details_json': json.dumps({
2647 'properties': {'buildnumber': 1},
2648 }),
2649 'result': 'FAILURE',
2650 'status': 'COMPLETED',
2651 'tags': [
2652 'build_address:x.y/my-bot/1',
2653 'builder:my-bot',
2654 'experimental:false',
2655 'user_agent:cq',
2656 ],
2657 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2658 },
2659 }
tandrii221ab252016-10-06 08:12:04 -07002660
2661 def test_write_try_results_json(self):
2662 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002663 {
2664 'bucket': 'master.x.y',
2665 'buildbucket_id': '8000',
2666 'builder_name': 'my-bot',
2667 'created_ts': '147200001111000',
2668 'experimental': False,
2669 'failure_reason': 'BUILD_FAILURE',
2670 'result': 'FAILURE',
2671 'status': 'COMPLETED',
2672 'tags': [
2673 'build_address:x.y/my-bot/1',
2674 'builder:my-bot',
2675 'experimental:false',
2676 'user_agent:cq',
2677 ],
2678 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2679 },
2680 {
2681 'bucket': 'master.x.y',
2682 'buildbucket_id': '9000',
2683 'builder_name': 'my-bot',
2684 'created_ts': '147200002222000',
2685 'experimental': False,
2686 'failure_reason': None,
2687 'result': None,
2688 'status': 'STARTED',
2689 'tags': [
2690 'build_address:x.y/my-bot/2',
2691 'builder:my-bot',
2692 'experimental:false',
2693 'user_agent:cq',
2694 ],
2695 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2696 },
tandrii221ab252016-10-06 08:12:04 -07002697 ]
2698 self.calls = [(('write_json', 'output.json', expected_output), '')]
2699 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2700
tandrii45b2a582016-10-11 03:14:16 -07002701 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002702 out = StringIO.StringIO()
2703 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002704 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2705 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002706 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2707 self._mocked_call(['get_authenticator_for_host', host]))
2708 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2709 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002710
tandrii45b2a582016-10-11 03:14:16 -07002711 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2712 self._setup_fetch_try_jobs(most_recent_patchset=13)
2713 self.calls += [
2714 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii45b2a582016-10-11 03:14:16 -07002715 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002716 # TODO(tandrii): Uncomment the below if we decide to support checking
2717 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002718 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002719 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002720 ((['git', 'config', 'branch.feature.gerritserver'],),
2721 'https://x-review.googlesource.com'),
2722 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2723 AuthenticatorMock()),
2724 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2725
2726 def test_fetch_try_jobs_none_gerrit(self):
2727 self._setup_fetch_try_jobs_gerrit({})
2728 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002729 # TODO(tandrii): Uncomment the below if we decide to support checking
2730 # patchsets for Gerrit.
2731 # self.assertRegexpMatches(
2732 # sys.stdout.getvalue(),
2733 # r'Warning: Codereview server has newer patchsets \(13\)')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002734 self.assertRegexpMatches(sys.stdout.getvalue(), 'No tryjobs')
tandrii45b2a582016-10-11 03:14:16 -07002735
2736 def test_fetch_try_jobs_some_gerrit(self):
2737 self._setup_fetch_try_jobs_gerrit({
2738 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2739 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002740 # TODO(tandrii): Uncomment the below if we decide to support checking
2741 # patchsets for Gerrit.
2742 # self.calls.remove(
2743 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002744 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2745
2746 # ... and doesn't result in warning.
2747 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2748 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002749 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002750 self.assertRegexpMatches(sys.stdout.getvalue(), '2 tryjobs')
tandrii221ab252016-10-06 08:12:04 -07002751
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002752 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemur125d60a2019-09-13 18:25:41 +00002753 self.mock(git_cl.Changelist, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002754
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002755 def test_gerrit_change_detail_cache_simple(self):
2756 self._mock_gerrit_changes_for_detail_cache()
2757 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002758 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2759 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2760 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002761 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002762 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002763 cl1._cached_remote_url = (
2764 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002765 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002766 cl2._cached_remote_url = (
2767 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002768 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2769 self.assertEqual(cl1._GetChangeDetail(), 'a')
2770 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2771 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2772 self.assertEqual(cl1._GetChangeDetail(), 'a')
2773 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002774
2775 def test_gerrit_change_detail_cache_options(self):
2776 self._mock_gerrit_changes_for_detail_cache()
2777 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002778 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2779 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2780 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2781 # no longer in cache.
2782 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002783 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002784 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002785 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002786 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2787 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2788 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2789 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2790 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2791 self.assertEqual(cl._GetChangeDetail(), 'cab')
2792
2793 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2794 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2795 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2796 self.assertEqual(cl._GetChangeDetail(), 'cab')
2797
2798 # Finally, no_cache should invalidate all caches for given change.
2799 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2800 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2801
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002802 def test_gerrit_description_caching(self):
2803 def gen_detail(rev, desc):
2804 return {
2805 'current_revision': rev,
2806 'revisions': {rev: {'commit': {'message': desc}}}
2807 }
2808 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002809 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002810 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2811 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002812 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002813 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2814 gen_detail('rev2', 'desc2')),
2815 ]
2816
2817 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002818 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002819 cl._cached_remote_url = (
2820 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002821 self.assertEqual(cl.GetDescription(), 'desc1')
2822 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2823 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002824
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002825 def test_print_current_creds(self):
2826 class CookiesAuthenticatorMock(object):
2827 def __init__(self):
2828 self.gitcookies = {
2829 'host.googlesource.com': ('user', 'pass'),
2830 'host-review.googlesource.com': ('user', 'pass'),
2831 }
2832 self.netrc = self
2833 self.netrc.hosts = {
2834 'github.com': ('user2', None, 'pass2'),
2835 'host2.googlesource.com': ('user3', None, 'pass'),
2836 }
2837 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2838 CookiesAuthenticatorMock)
2839 self.mock(sys, 'stdout', StringIO.StringIO())
2840 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2841 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2842 ' Host\t User\t Which file',
2843 '============================\t=====\t===========',
2844 'host-review.googlesource.com\t user\t.gitcookies',
2845 ' host.googlesource.com\t user\t.gitcookies',
2846 ' host2.googlesource.com\tuser3\t .netrc',
2847 ])
2848 sys.stdout.buf = ''
2849 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2850 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2851 ' Host\tUser\t Which file',
2852 '============================\t====\t===========',
2853 'host-review.googlesource.com\tuser\t.gitcookies',
2854 ' host.googlesource.com\tuser\t.gitcookies',
2855 ])
2856
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002857 def _common_creds_check_mocks(self):
2858 def exists_mock(path):
2859 dirname = os.path.dirname(path)
2860 if dirname == os.path.expanduser('~'):
2861 dirname = '~'
2862 base = os.path.basename(path)
2863 if base in ('.netrc', '.gitcookies'):
2864 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2865 # git cl also checks for existence other files not relevant to this test.
2866 return None
2867 self.mock(os.path, 'exists', exists_mock)
2868 self.mock(sys, 'stdout', StringIO.StringIO())
2869
2870 def test_creds_check_gitcookies_not_configured(self):
2871 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002872 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002873 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002874 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002875 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002876 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2877 (('os.path.exists', '~/.netrc'), True),
2878 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2879 'or Ctrl+C to abort'), ''),
2880 ((['git', 'config', '--global', 'http.cookiefile',
2881 os.path.expanduser('~/.gitcookies')], ), ''),
2882 ]
2883 self.assertEqual(0, git_cl.main(['creds-check']))
2884 self.assertRegexpMatches(
2885 sys.stdout.getvalue(),
2886 '^You seem to be using outdated .netrc for git credentials:')
2887 self.assertRegexpMatches(
2888 sys.stdout.getvalue(),
2889 '\nConfigured git to use .gitcookies from')
2890
2891 def test_creds_check_gitcookies_configured_custom_broken(self):
2892 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002893 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002894 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002895 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002896 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002897 ((['git', 'config', '--global', 'http.cookiefile'],),
2898 '/custom/.gitcookies'),
2899 (('os.path.exists', '/custom/.gitcookies'), False),
2900 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2901 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2902 ((['git', 'config', '--global', 'http.cookiefile',
2903 os.path.expanduser('~/.gitcookies')], ), ''),
2904 ]
2905 self.assertEqual(0, git_cl.main(['creds-check']))
2906 self.assertRegexpMatches(
2907 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002908 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002909 self.assertRegexpMatches(
2910 sys.stdout.getvalue(),
2911 'However, your configured .gitcookies file is missing.')
2912
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002913 def test_git_cl_comment_add_gerrit(self):
2914 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002915 lambda host, change, msg, ready:
2916 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002917 self.calls = [
2918 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2919 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2920 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2921 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2922 'origin/master'),
2923 ((['git', 'config', 'remote.origin.url'],),
2924 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002925 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2926 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002927 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002928 ]
2929 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2930 '-a', 'msg']))
2931
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002932 def test_git_cl_comments_fetch_gerrit(self):
2933 self.mock(sys, 'stdout', StringIO.StringIO())
2934 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002935 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2936 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002937 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2938 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2939 'origin/master'),
2940 ((['git', 'config', 'remote.origin.url'],),
2941 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002942 (('GetChangeDetail', 'chromium-review.googlesource.com',
2943 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002944 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2945 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002946 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002947 'current_revision': 'ba5eba11',
2948 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002949 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002950 '_number': 1,
2951 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002952 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002953 '_number': 2,
2954 },
2955 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002956 'messages': [
2957 {
2958 u'_revision_number': 1,
2959 u'author': {
2960 u'_account_id': 1111084,
2961 u'email': u'commit-bot@chromium.org',
2962 u'name': u'Commit Bot'
2963 },
2964 u'date': u'2017-03-15 20:08:45.000000000',
2965 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002966 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002967 u'tag': u'autogenerated:cq:dry-run'
2968 },
2969 {
2970 u'_revision_number': 2,
2971 u'author': {
2972 u'_account_id': 11151243,
2973 u'email': u'owner@example.com',
2974 u'name': u'owner'
2975 },
2976 u'date': u'2017-03-16 20:00:41.000000000',
2977 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2978 u'message': u'PTAL',
2979 },
2980 {
2981 u'_revision_number': 2,
2982 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002983 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002984 u'email': u'reviewer@example.com',
2985 u'name': u'reviewer'
2986 },
2987 u'date': u'2017-03-17 05:19:37.500000000',
2988 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2989 u'message': u'Patch Set 2: Code-Review+1',
2990 },
2991 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002992 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002993 (('GetChangeComments', 'chromium-review.googlesource.com',
2994 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002995 '/COMMIT_MSG': [
2996 {
2997 'author': {'email': u'reviewer@example.com'},
2998 'updated': u'2017-03-17 05:19:37.500000000',
2999 'patch_set': 2,
3000 'side': 'REVISION',
3001 'message': 'Please include a bug link',
3002 },
3003 ],
3004 'codereview.settings': [
3005 {
3006 'author': {'email': u'owner@example.com'},
3007 'updated': u'2017-03-16 20:00:41.000000000',
3008 'patch_set': 2,
3009 'side': 'PARENT',
3010 'line': 42,
3011 'message': 'I removed this because it is bad',
3012 },
3013 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003014 }),
3015 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
3016 'infra%2Finfra~1'), {}),
3017 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00003018 ] * 2 + [
3019 (('write_json', 'output.json', [
3020 {
3021 u'date': u'2017-03-16 20:00:41.000000',
3022 u'message': (
3023 u'PTAL\n' +
3024 u'\n' +
3025 u'codereview.settings\n' +
3026 u' Base, Line 42: https://chromium-review.googlesource.com/' +
3027 u'c/1/2/codereview.settings#b42\n' +
3028 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003029 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00003030 u'approval': False,
3031 u'disapproval': False,
3032 u'sender': u'owner@example.com'
3033 }, {
3034 u'date': u'2017-03-17 05:19:37.500000',
3035 u'message': (
3036 u'Patch Set 2: Code-Review+1\n' +
3037 u'\n' +
3038 u'/COMMIT_MSG\n' +
3039 u' PS2, File comment: https://chromium-review.googlesource' +
3040 u'.com/c/1/2//COMMIT_MSG#\n' +
3041 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003042 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00003043 u'approval': False,
3044 u'disapproval': False,
3045 u'sender': u'reviewer@example.com'
3046 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003047 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00003048 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003049 expected_comments_summary = [
3050 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003051 message=(
3052 u'PTAL\n' +
3053 u'\n' +
3054 u'codereview.settings\n' +
3055 u' Base, Line 42: https://chromium-review.googlesource.com/' +
3056 u'c/1/2/codereview.settings#b42\n' +
3057 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003058 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003059 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003060 disapproval=False, approval=False, sender=u'owner@example.com'),
3061 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003062 message=(
3063 u'Patch Set 2: Code-Review+1\n' +
3064 u'\n' +
3065 u'/COMMIT_MSG\n' +
3066 u' PS2, File comment: https://chromium-review.googlesource.com/' +
3067 u'c/1/2//COMMIT_MSG#\n' +
3068 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003069 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003070 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003071 disapproval=False, approval=False, sender=u'reviewer@example.com'),
3072 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003073 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00003074 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003075 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003076 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
3077 self.assertEqual(
3078 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
3079
3080 def test_git_cl_comments_robot_comments(self):
3081 # git cl comments also fetches robot comments (which are considered a type
3082 # of autogenerated comment), and unlike other types of comments, only robot
3083 # comments from the latest patchset are shown.
3084 self.mock(sys, 'stdout', StringIO.StringIO())
3085 self.calls = [
3086 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
3087 ((['git', 'config', 'branch.foo.merge'],), ''),
3088 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3089 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3090 'origin/master'),
3091 ((['git', 'config', 'remote.origin.url'],),
3092 'https://chromium.googlesource.com/infra/infra'),
3093 (('GetChangeDetail', 'chromium-review.googlesource.com',
3094 'infra%2Finfra~1',
3095 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
3096 'CURRENT_COMMIT']), {
3097 'owner': {'email': 'owner@example.com'},
3098 'current_revision': 'ba5eba11',
3099 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003100 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003101 '_number': 1,
3102 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003103 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003104 '_number': 2,
3105 },
3106 },
3107 'messages': [
3108 {
3109 u'_revision_number': 1,
3110 u'author': {
3111 u'_account_id': 1111084,
3112 u'email': u'commit-bot@chromium.org',
3113 u'name': u'Commit Bot'
3114 },
3115 u'date': u'2017-03-15 20:08:45.000000000',
3116 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
3117 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
3118 u'tag': u'autogenerated:cq:dry-run'
3119 },
3120 {
3121 u'_revision_number': 1,
3122 u'author': {
3123 u'_account_id': 123,
3124 u'email': u'tricium@serviceaccount.com',
3125 u'name': u'Tricium'
3126 },
3127 u'date': u'2017-03-16 20:00:41.000000000',
3128 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3129 u'message': u'(1 comment)',
3130 u'tag': u'autogenerated:tricium',
3131 },
3132 {
3133 u'_revision_number': 1,
3134 u'author': {
3135 u'_account_id': 123,
3136 u'email': u'tricium@serviceaccount.com',
3137 u'name': u'Tricium'
3138 },
3139 u'date': u'2017-03-16 20:00:41.000000000',
3140 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3141 u'message': u'(1 comment)',
3142 u'tag': u'autogenerated:tricium',
3143 },
3144 {
3145 u'_revision_number': 2,
3146 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003147 u'_account_id': 123,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003148 u'email': u'tricium@serviceaccount.com',
3149 u'name': u'reviewer'
3150 },
3151 u'date': u'2017-03-17 05:30:37.000000000',
3152 u'tag': u'autogenerated:tricium',
3153 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
3154 u'message': u'(1 comment)',
3155 },
3156 ]
3157 }),
3158 (('GetChangeComments', 'chromium-review.googlesource.com',
3159 'infra%2Finfra~1'), {}),
3160 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
3161 'infra%2Finfra~1'), {
3162 'codereview.settings': [
3163 {
3164 u'author': {u'email': u'tricium@serviceaccount.com'},
3165 u'updated': u'2017-03-17 05:30:37.000000000',
3166 u'robot_run_id': u'5565031076855808',
3167 u'robot_id': u'Linter/Category',
3168 u'tag': u'autogenerated:tricium',
3169 u'patch_set': 2,
3170 u'side': u'REVISION',
3171 u'message': u'Linter warning message text',
3172 u'line': 32,
3173 },
3174 ],
3175 }),
3176 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
3177 ]
3178 expected_comments_summary = [
3179 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
3180 message=(
3181 u'(1 comment)\n\ncodereview.settings\n'
3182 u' PS2, Line 32: https://chromium-review.googlesource.com/'
3183 u'c/1/2/codereview.settings#32\n'
3184 u' Linter warning message text\n'),
3185 sender=u'tricium@serviceaccount.com',
3186 autogenerated=True, approval=False, disapproval=False)
3187 ]
3188 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00003189 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003190 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003191
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003192 def test_get_remote_url_with_mirror(self):
3193 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003194
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003195 def selective_os_path_isdir_mock(path):
3196 if path == '/cache/this-dir-exists':
3197 return self._mocked_call('os.path.isdir', path)
3198 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003199
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003200 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3201
3202 url = 'https://chromium.googlesource.com/my/repo'
3203 self.calls = [
3204 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3205 ((['git', 'config', 'branch.master.merge'],), 'master'),
3206 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3207 ((['git', 'config', 'remote.origin.url'],),
3208 '/cache/this-dir-exists'),
3209 (('os.path.isdir', '/cache/this-dir-exists'),
3210 True),
3211 # Runs in /cache/this-dir-exists.
3212 ((['git', 'config', 'remote.origin.url'],),
3213 url),
3214 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003215 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003216 self.assertEqual(cl.GetRemoteUrl(), url)
3217 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3218
Edward Lemur298f2cf2019-02-22 21:40:39 +00003219 def test_get_remote_url_non_existing_mirror(self):
3220 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003221
Edward Lemur298f2cf2019-02-22 21:40:39 +00003222 def selective_os_path_isdir_mock(path):
3223 if path == '/cache/this-dir-doesnt-exist':
3224 return self._mocked_call('os.path.isdir', path)
3225 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003226
Edward Lemur298f2cf2019-02-22 21:40:39 +00003227 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3228 self.mock(logging, 'error',
3229 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
3230
3231 self.calls = [
3232 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3233 ((['git', 'config', 'branch.master.merge'],), 'master'),
3234 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3235 ((['git', 'config', 'remote.origin.url'],),
3236 '/cache/this-dir-doesnt-exist'),
3237 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3238 False),
3239 (('logging.error',
Daniel Bratell4a60db42019-09-16 17:02:52 +00003240 'Remote "origin" for branch "master" points to'
3241 ' "/cache/this-dir-doesnt-exist", but it doesn\'t exist.'), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00003242 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003243 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003244 self.assertIsNone(cl.GetRemoteUrl())
3245
3246 def test_get_remote_url_misconfigured_mirror(self):
3247 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003248
Edward Lemur298f2cf2019-02-22 21:40:39 +00003249 def selective_os_path_isdir_mock(path):
3250 if path == '/cache/this-dir-exists':
3251 return self._mocked_call('os.path.isdir', path)
3252 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003253
Edward Lemur298f2cf2019-02-22 21:40:39 +00003254 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3255 self.mock(logging, 'error',
3256 lambda *a: self._mocked_call('logging.error', *a))
3257
3258 self.calls = [
3259 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3260 ((['git', 'config', 'branch.master.merge'],), 'master'),
3261 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3262 ((['git', 'config', 'remote.origin.url'],),
3263 '/cache/this-dir-exists'),
3264 (('os.path.isdir', '/cache/this-dir-exists'), True),
3265 # Runs in /cache/this-dir-exists.
3266 ((['git', 'config', 'remote.origin.url'],), ''),
3267 (('logging.error',
3268 'Remote "%(remote)s" for branch "%(branch)s" points to '
3269 '"%(cache_path)s", but it is misconfigured.\n'
3270 '"%(cache_path)s" must be a git repo and must have a remote named '
3271 '"%(remote)s" pointing to the git host.', {
3272 'remote': 'origin',
3273 'cache_path': '/cache/this-dir-exists',
3274 'branch': 'master'}
3275 ), None),
3276 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003277 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003278 self.assertIsNone(cl.GetRemoteUrl())
3279
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003280 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003281 self.calls = [
3282 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3283 ((['git', 'config', 'branch.master.merge'],), 'master'),
3284 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3285 ((['git', 'config', 'remote.origin.url'],),
3286 'https://chromium.googlesource.com/a/my/repo.git/'),
3287 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003288 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003289 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3290
3291 def test_gerrit_change_identifier_without_project(self):
3292 self.calls = [
3293 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3294 ((['git', 'config', 'branch.master.merge'],), 'master'),
3295 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3296 ((['git', 'config', 'remote.origin.url'],), CERR1),
3297 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003298 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003299 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003300
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003301
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003302if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003303 logging.basicConfig(
3304 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003305 unittest.main()