blob: 9c2bdefb85a2659c4d519c57c05c6fb40c0eb070 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01008import datetime
tandriide281ae2016-10-12 06:02:30 -07009import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010010import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000011import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000012import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000013import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070014import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000015import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000016import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017
18sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
19
20from testing_support.auto_stub import TestCase
21
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000022import metrics
23# We have to disable monitoring before importing git_cl.
24metrics.DISABLE_METRICS_COLLECTION = True
25
Eric Boren2fb63102018-10-05 13:05:03 +000026import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000027import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000028import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000029import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000030import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000065 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000066 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000086class WatchlistsMock(object):
87 def __init__(self, _):
88 pass
89 @staticmethod
90 def GetWatchersForPaths(_):
91 return ['joe@example.com']
92
93
ukai@chromium.org78c4b982012-02-14 02:20:26 +000094class CodereviewSettingsFileMock(object):
95 def __init__(self):
96 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -080097 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +000098 def read(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000099 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
100 'GERRIT_HOST: True\n')
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000101
102
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000103class AuthenticatorMock(object):
104 def __init__(self, *_args):
105 pass
106 def has_cached_credentials(self):
107 return True
tandrii221ab252016-10-06 08:12:04 -0700108 def authorize(self, http):
109 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000110
111
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100112def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000113 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
114
115 Usage:
116 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100117 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000118
119 OR
120 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100121 CookiesAuthenticatorMockFactory(
122 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000123 """
124 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800125 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126 # Intentionally not calling super() because it reads actual cookie files.
127 pass
128 @classmethod
129 def get_gitcookies_path(cls):
130 return '~/.gitcookies'
131 @classmethod
132 def get_netrc_path(cls):
133 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100134 def _get_auth_for_host(self, host):
135 if same_auth:
136 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000137 return (hosts_with_creds or {}).get(host)
138 return CookiesAuthenticatorMock
139
Aaron Gable9a03ae02017-11-03 11:31:07 -0700140
kmarshall9249e012016-08-23 12:02:16 -0700141class MockChangelistWithBranchAndIssue():
142 def __init__(self, branch, issue):
143 self.branch = branch
144 self.issue = issue
145 def GetBranch(self):
146 return self.branch
147 def GetIssue(self):
148 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000149
tandriic2405f52016-10-10 08:13:15 -0700150
151class SystemExitMock(Exception):
152 pass
153
154
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000155class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100156 def test_get_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000157 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100158 cl.description = 'x'
159 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000160 cl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100161 self.assertEquals(cl.GetDescription(), 'x')
162 self.assertEquals(cl.GetDescription(force=True), 'y')
163 self.assertEquals(cl.GetDescription(), 'y')
164
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700165 def test_description_footers(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000166 cl = git_cl.Changelist(issue=1, codereview_host='host')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700167 cl.description = '\n'.join([
168 'This is some message',
169 '',
170 'It has some lines',
171 'and, also',
172 '',
173 'Some: Really',
174 'Awesome: Footers',
175 ])
176 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000177 cl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700178 msg, footers = cl.GetDescriptionFooters()
179 self.assertEquals(
180 msg, ['This is some message', '', 'It has some lines', 'and, also'])
181 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
182
183 msg.append('wut')
184 footers.append(('gnarly-dude', 'beans'))
185 cl.UpdateDescriptionFooters(msg, footers)
186 self.assertEquals(cl.GetDescription().splitlines(), [
187 'This is some message',
188 '',
189 'It has some lines',
190 'and, also',
191 'wut'
192 '',
193 'Some: Really',
194 'Awesome: Footers',
195 'Gnarly-Dude: beans',
196 ])
197
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000198 def test_set_preserve_tryjobs(self):
199 d = git_cl.ChangeDescription('Simple.')
200 d.set_preserve_tryjobs()
201 self.assertEqual(d.description.splitlines(), [
202 'Simple.',
203 '',
204 'Cq-Do-Not-Cancel-Tryjobs: true',
205 ])
206 before = d.description
207 d.set_preserve_tryjobs()
208 self.assertEqual(before, d.description)
209
210 d = git_cl.ChangeDescription('\n'.join([
211 'One is enough',
212 '',
213 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
214 'Change-Id: Ideadbeef',
215 ]))
216 d.set_preserve_tryjobs()
217 self.assertEqual(d.description.splitlines(), [
218 'One is enough',
219 '',
220 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
221 'Change-Id: Ideadbeef',
222 'Cq-Do-Not-Cancel-Tryjobs: true',
223 ])
224
tandriif9aefb72016-07-01 09:06:51 -0700225 def test_get_bug_line_values(self):
226 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
227 self.assertEqual(f('', ''), [])
228 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
229 self.assertEqual(f('v8', '456'), ['v8:456'])
230 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
231 # Not nice, but not worth carying.
232 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
233 ['v8:456', 'chromium:123', 'v8:123'])
234
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100235 def _test_git_number(self, parent_msg, dest_ref, child_msg,
236 parent_hash='parenthash'):
237 desc = git_cl.ChangeDescription(child_msg)
238 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
239 return desc.description
240
241 def assertEqualByLine(self, actual, expected):
242 self.assertEqual(actual.splitlines(), expected.splitlines())
243
244 def test_git_number_bad_parent(self):
245 with self.assertRaises(ValueError):
246 self._test_git_number('Parent', 'refs/heads/master', 'Child')
247
248 def test_git_number_bad_parent_footer(self):
249 with self.assertRaises(AssertionError):
250 self._test_git_number(
251 'Parent\n'
252 '\n'
253 'Cr-Commit-Position: wrong',
254 'refs/heads/master', 'Child')
255
256 def test_git_number_bad_lineage_ignored(self):
257 actual = self._test_git_number(
258 'Parent\n'
259 '\n'
260 'Cr-Commit-Position: refs/heads/master@{#1}\n'
261 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
262 'refs/heads/master', 'Child')
263 self.assertEqualByLine(
264 actual,
265 'Child\n'
266 '\n'
267 'Cr-Commit-Position: refs/heads/master@{#2}\n'
268 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
269
270 def test_git_number_same_branch(self):
271 actual = self._test_git_number(
272 'Parent\n'
273 '\n'
274 'Cr-Commit-Position: refs/heads/master@{#12}',
275 dest_ref='refs/heads/master',
276 child_msg='Child')
277 self.assertEqualByLine(
278 actual,
279 'Child\n'
280 '\n'
281 'Cr-Commit-Position: refs/heads/master@{#13}')
282
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200283 def test_git_number_same_branch_mixed_footers(self):
284 actual = self._test_git_number(
285 'Parent\n'
286 '\n'
287 'Cr-Commit-Position: refs/heads/master@{#12}',
288 dest_ref='refs/heads/master',
289 child_msg='Child\n'
290 '\n'
291 'Broken-by: design\n'
292 'BUG=123')
293 self.assertEqualByLine(
294 actual,
295 'Child\n'
296 '\n'
297 'Broken-by: design\n'
298 'BUG=123\n'
299 'Cr-Commit-Position: refs/heads/master@{#13}')
300
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100301 def test_git_number_same_branch_with_originals(self):
302 actual = self._test_git_number(
303 'Parent\n'
304 '\n'
305 'Cr-Commit-Position: refs/heads/master@{#12}',
306 dest_ref='refs/heads/master',
307 child_msg='Child\n'
308 '\n'
309 'Some users are smart and insert their own footers\n'
310 '\n'
311 'Cr-Whatever: value\n'
312 'Cr-Commit-Position: refs/copy/paste@{#22}')
313 self.assertEqualByLine(
314 actual,
315 'Child\n'
316 '\n'
317 'Some users are smart and insert their own footers\n'
318 '\n'
319 'Cr-Original-Whatever: value\n'
320 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
321 'Cr-Commit-Position: refs/heads/master@{#13}')
322
323 def test_git_number_new_branch(self):
324 actual = self._test_git_number(
325 'Parent\n'
326 '\n'
327 'Cr-Commit-Position: refs/heads/master@{#12}',
328 dest_ref='refs/heads/branch',
329 child_msg='Child')
330 self.assertEqualByLine(
331 actual,
332 'Child\n'
333 '\n'
334 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
335 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
336
337 def test_git_number_lineage(self):
338 actual = self._test_git_number(
339 'Parent\n'
340 '\n'
341 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
342 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
343 dest_ref='refs/heads/branch',
344 child_msg='Child')
345 self.assertEqualByLine(
346 actual,
347 'Child\n'
348 '\n'
349 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
350 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
351
352 def test_git_number_moooooooore_lineage(self):
353 actual = self._test_git_number(
354 'Parent\n'
355 '\n'
356 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
357 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
358 dest_ref='refs/heads/mooore',
359 child_msg='Child')
360 self.assertEqualByLine(
361 actual,
362 'Child\n'
363 '\n'
364 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
365 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
366 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
367
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100368 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700369 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100370 actual = self._test_git_number(
371 'CQ commit on fresh new branch + numbering.\n'
372 '\n'
373 'NOTRY=True\n'
374 'NOPRESUBMIT=True\n'
375 'BUG=\n'
376 '\n'
377 'Review-Url: https://codereview.chromium.org/2577703003\n'
378 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
379 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
380 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
381 dest_ref='refs/heads/gnumb-test/cl',
382 child_msg='git cl on fresh new branch + numbering.\n'
383 '\n'
384 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
385 self.assertEqualByLine(
386 actual,
387 'git cl on fresh new branch + numbering.\n'
388 '\n'
389 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
390 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
391 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
392 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
393 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100394
395 def test_git_number_cherry_pick(self):
396 actual = self._test_git_number(
397 'Parent\n'
398 '\n'
399 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
400 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
401 dest_ref='refs/heads/branch',
402 child_msg='Child, which is cherry-pick from master\n'
403 '\n'
404 'Cr-Commit-Position: refs/heads/master@{#100}\n'
405 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
406 self.assertEqualByLine(
407 actual,
408 'Child, which is cherry-pick from master\n'
409 '\n'
410 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
411 '\n'
412 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
413 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
414 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
415
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000416 def test_gerrit_mirror_hack(self):
417 cr = 'chromium-review.googlesource.com'
418 url0 = 'https://%s/a/changes/x?a=b' % cr
419 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
420 try:
421 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
422 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
423 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
424 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
425
426 self.assertNotEqual(url1, url2)
427 self.assertEqual(sorted((url1, url2)), [
428 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
429 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
430 self.assertEqual(url1, url3)
431 finally:
432 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
433
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000434 def test_valid_accounts(self):
435 mock_per_account = {
436 'u1': None, # 404, doesn't exist.
437 'u2': {
438 '_account_id': 123124,
439 'avatars': [],
440 'email': 'u2@example.com',
441 'name': 'User Number 2',
442 'status': 'OOO',
443 },
444 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
445 }
446 def GetAccountDetailsMock(_, account):
447 # Poor-man's mock library's side_effect.
448 v = mock_per_account.pop(account)
449 if isinstance(v, Exception):
450 raise v
451 return v
452
453 original = git_cl.gerrit_util.GetAccountDetails
454 try:
455 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
456 actual = git_cl.gerrit_util.ValidAccounts(
457 'host', ['u1', 'u2', 'u3'], max_threads=1)
458 finally:
459 git_cl.gerrit_util.GetAccountDetails = original
460 self.assertEqual(actual, {
461 'u2': {
462 '_account_id': 123124,
463 'avatars': [],
464 'email': 'u2@example.com',
465 'name': 'User Number 2',
466 'status': 'OOO',
467 },
468 })
469
470
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200471class TestParseIssueURL(unittest.TestCase):
472 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000473 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200474 self.assertIsNotNone(parsed)
475 if fail:
476 self.assertFalse(parsed.valid)
477 return
478 self.assertTrue(parsed.valid)
479 self.assertEqual(parsed.issue, issue)
480 self.assertEqual(parsed.patchset, patchset)
481 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200482
483 def _run_and_validate(self, func, url, *args, **kwargs):
484 result = func(urlparse.urlparse(url))
485 if kwargs.pop('fail', False):
486 self.assertIsNone(result)
487 return None
488 self._validate(result, *args, fail=False, **kwargs)
489
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200490 def test_gerrit(self):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200491 def test(url, *args, **kwargs):
Edward Lemur125d60a2019-09-13 18:25:41 +0000492 self._run_and_validate(git_cl.Changelist.ParseIssueURL, url,
Edward Lemurf38bc172019-09-03 21:02:13 +0000493 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200494
495 test('http://chrome-review.source.com/c/123',
496 123, None, 'chrome-review.source.com')
497 test('https://chrome-review.source.com/c/123/',
498 123, None, 'chrome-review.source.com')
499 test('https://chrome-review.source.com/c/123/4',
500 123, 4, 'chrome-review.source.com')
501 test('https://chrome-review.source.com/#/c/123/4',
502 123, 4, 'chrome-review.source.com')
503 test('https://chrome-review.source.com/c/123/4',
504 123, 4, 'chrome-review.source.com')
505 test('https://chrome-review.source.com/123',
506 123, None, 'chrome-review.source.com')
507 test('https://chrome-review.source.com/123/4',
508 123, 4, 'chrome-review.source.com')
509
510 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
511 test('https://chrome-review.source.com/c/abc/', fail=True)
512 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
513
514 def test_ParseIssueNumberArgument(self):
515 def test(arg, *args, **kwargs):
Edward Lemurf38bc172019-09-03 21:02:13 +0000516 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200517
518 test('123', 123)
519 test('', fail=True)
520 test('abc', fail=True)
521 test('123/1', fail=True)
522 test('123a', fail=True)
523 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000524
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200525 test('https://codereview.source.com/123',
Edward Lemurf38bc172019-09-03 21:02:13 +0000526 123, None, 'codereview.source.com')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000527
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200528 # Gerrrit.
529 test('https://chrome-review.source.com/c/123/4',
Edward Lemurf38bc172019-09-03 21:02:13 +0000530 123, 4, 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200531 test('https://chrome-review.source.com/bad/123/4', fail=True)
532
533
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100534class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100535 def setUp(self):
536 super(GitCookiesCheckerTest, self).setUp()
537 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100538 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100539
540 def mock_hosts_creds(self, subhost_identity_pairs):
541 def ensure_googlesource(h):
542 if not h.endswith(self.c._GOOGLESOURCE):
543 assert not h.endswith('.')
544 return h + '.' + self.c._GOOGLESOURCE
545 return h
546 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
547 for h, i in subhost_identity_pairs]
548
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200549 def test_identity_parsing(self):
550 self.assertEqual(self.c._parse_identity('ldap.google.com'),
551 ('ldap', 'google.com'))
552 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
553 ('ldap', 'example.com'))
554 # Specical case because we know there are no subdomains in chromium.org.
555 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
556 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800557 # Pathological: ".period." can be either username OR domain, more likely
558 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200559 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
560 ('note', 'period.example.com'))
561
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100562 def test_analysis_nothing(self):
563 self.c._all_hosts = []
564 self.assertFalse(self.c.has_generic_host())
565 self.assertEqual(set(), self.c.get_conflicting_hosts())
566 self.assertEqual(set(), self.c.get_duplicated_hosts())
567 self.assertEqual(set(), self.c.get_partially_configured_hosts())
568 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
569
570 def test_analysis(self):
571 self.mock_hosts_creds([
572 ('.googlesource.com', 'git-example.chromium.org'),
573
574 ('chromium', 'git-example.google.com'),
575 ('chromium-review', 'git-example.google.com'),
576 ('chrome-internal', 'git-example.chromium.org'),
577 ('chrome-internal-review', 'git-example.chromium.org'),
578 ('conflict', 'git-example.google.com'),
579 ('conflict-review', 'git-example.chromium.org'),
580 ('dup', 'git-example.google.com'),
581 ('dup', 'git-example.google.com'),
582 ('dup-review', 'git-example.google.com'),
583 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200584 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100585 ])
586 self.assertTrue(self.c.has_generic_host())
587 self.assertEqual(set(['conflict.googlesource.com']),
588 self.c.get_conflicting_hosts())
589 self.assertEqual(set(['dup.googlesource.com']),
590 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200591 self.assertEqual(set(['partial.googlesource.com',
592 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100593 self.c.get_partially_configured_hosts())
594 self.assertEqual(set(['chromium.googlesource.com',
595 'chrome-internal.googlesource.com']),
596 self.c.get_hosts_with_wrong_identities())
597
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100598 def test_report_no_problems(self):
599 self.test_analysis_nothing()
600 self.mock(sys, 'stdout', StringIO.StringIO())
601 self.assertFalse(self.c.find_and_report_problems())
602 self.assertEqual(sys.stdout.getvalue(), '')
603
604 def test_report(self):
605 self.test_analysis()
606 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200607 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
608 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100609 self.assertTrue(self.c.find_and_report_problems())
610 with open(os.path.join(os.path.dirname(__file__),
611 'git_cl_creds_check_report.txt')) as f:
612 expected = f.read()
613 def by_line(text):
614 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700615 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200616 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100617
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800618
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000619class TestGitCl(TestCase):
620 def setUp(self):
621 super(TestGitCl, self).setUp()
622 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700623 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000624 self.mock(git_cl, 'time_time',
625 lambda: self._mocked_call('time.time'))
626 self.mock(git_cl.metrics.collector, 'add_repeated',
627 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000628 self.mock(subprocess2, 'call', self._mocked_call)
629 self.mock(subprocess2, 'check_call', self._mocked_call)
630 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700631 self.mock(subprocess2, 'communicate',
632 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000633 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000634 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000635 self.mock(git_common, 'get_or_create_merge_base',
636 lambda *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000637 self._mocked_call(['get_or_create_merge_base'] + list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000638 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000639 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000640 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
641 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100642 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000643 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700644 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000645 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000646 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000647 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000648 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100649 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
650 lambda *args, **kwargs: self._mocked_call(
651 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700652 self.mock(git_cl.gerrit_util, 'GetChangeComments',
653 lambda *args, **kwargs: self._mocked_call(
654 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000655 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
656 lambda *args, **kwargs: self._mocked_call(
657 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100658 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700659 lambda h, i, reviewers, ccs, notify: self._mocked_call(
660 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700661 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700662 lambda h, i, msg=None, labels=None, notify=None:
663 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700664 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
665 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000666 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
667 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000668 self.mock(git_cl.gerrit_util, 'ValidAccounts',
669 lambda host, accounts:
670 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700671 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100672 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000673 # It's important to reset settings to not have inter-tests interference.
674 git_cl.settings = None
675
676 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000677 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100678 self.assertEquals([], self.calls)
679 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000680 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100681 raise
682 # Sadly, has_failed() returns True if this OR any other tests before this
683 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200684 git_cl.logging.error(
685 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100686 'There are un-consumed self.calls after this test has finished.\n'
687 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700688 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200689 'If you are already running only this test, then **first** fix the '
690 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100691 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700692 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100693 'and follow instructions above.\n' +
694 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000695 finally:
696 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000697
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000698 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000699 self.assertTrue(
700 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700701 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000702 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000703 expected_args, result = top
704
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000705 # Also logs otherwise it could get caught in a try/finally and be hard to
706 # diagnose.
707 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700708 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000709 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700710 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
711 for i, c in enumerate(self._calls_done[-N:]))
712 following_calls = '\n '.join(
713 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
714 for i, c in enumerate(self.calls[:N]))
715 extended_msg = (
716 'A few prior calls:\n %s\n\n'
717 'This (expected):\n @%d: %r\n'
718 'This (actual):\n @%d: %r\n\n'
719 'A few following expected calls:\n %s' %
720 (prior_calls, len(self._calls_done), expected_args,
721 len(self._calls_done), args, following_calls))
722 git_cl.logging.error(extended_msg)
723
tandrii99a72f22016-08-17 14:33:24 -0700724 self.fail('@%d\n'
725 ' Expected: %r\n'
726 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700727 len(self._calls_done), expected_args, args))
728
729 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700730 if isinstance(result, Exception):
731 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000732 return result
733
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100734 def test_ask_for_explicit_yes_true(self):
735 self.calls = [
736 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
737 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
738 ]
739 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
740
tandrii48df5812016-10-17 03:55:37 -0700741 def test_LoadCodereviewSettingsFromFile_gerrit(self):
742 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
743 self.calls = [
744 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700745 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
746 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
747 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
748 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700749 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
750 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700751 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
752 CERR1),
753 ((['git', 'config', 'gerrit.host', 'true'],), ''),
754 ]
755 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
756
maruel@chromium.orga3353652011-11-30 14:26:57 +0000757 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000758 def _is_gerrit_calls(cls, gerrit=False):
759 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
760 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
761
762 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000763 def _git_post_upload_calls(cls):
764 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000765 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
766 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
767 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000768 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000769 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000770 ]
771
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000772 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000773 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000774 fake_ancestor = 'fake_ancestor'
775 fake_cl = 'fake_cl_for_patch'
776 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000777 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000778 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000779 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000780 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000781 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000782 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000783 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000784 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700785 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000786 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000787 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000788 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000789 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000790 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000791 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000792 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000793 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000794 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000795 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000796 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000797
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000798 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000799 def _gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000800 cls, issue=None, skip_auth_check=False, short_hostname='chromium',
801 custom_cl_base=None):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000802 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000803 if skip_auth_check:
804 return [((cmd, ), 'true')]
805
tandrii5d48c322016-08-18 16:19:37 -0700806 calls = [((cmd, ), CERR1)]
Edward Lemurf38bc172019-09-03 21:02:13 +0000807
808 if custom_cl_base:
809 calls += [
810 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
811 ]
812
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000813 calls.extend([
814 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
815 ((['git', 'config', 'branch.master.remote'],), 'origin'),
816 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000817 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000818 ])
Edward Lemurf38bc172019-09-03 21:02:13 +0000819
820 calls += [
821 ((['git', 'config', 'branch.master.gerritissue'],),
822 CERR1 if issue is None else str(issue)),
823 ]
824
Daniel Chengcf6269b2019-05-18 01:02:12 +0000825 if issue:
826 calls.extend([
827 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
828 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000829 return calls
830
831 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100832 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200833 fetched_status=None, other_cl_owner=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000834 custom_cl_base=None, short_hostname='chromium'):
Aaron Gable13101a62018-02-09 13:20:41 -0800835 calls = cls._is_gerrit_calls(True)
Edward Lemurf38bc172019-09-03 21:02:13 +0000836 if not custom_cl_base:
837 calls += [
838 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
839 ]
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200840
841 if custom_cl_base:
842 ancestor_revision = custom_cl_base
843 else:
844 # Determine ancestor_revision to be merge base.
845 ancestor_revision = 'fake_ancestor_sha'
846 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000847 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000848 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000849 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200850 'refs/remotes/origin/master'],), ancestor_revision),
851 ]
852
853 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000854 calls += cls._gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000855 issue=issue, short_hostname=short_hostname,
856 custom_cl_base=custom_cl_base)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100857
858 if issue:
859 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000860 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000861 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000862 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
863 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100864 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100865 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100866 'change_id': '123456789',
867 'current_revision': 'sha1_of_current_revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000868 'revisions': {'sha1_of_current_revision': {
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100869 'commit': {'message': fetched_description},
870 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100871 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100872 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100873 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100874 if fetched_status == 'ABANDONED':
875 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000876 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100877 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000878 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100879 ]
880 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100881 if other_cl_owner:
882 calls += [
883 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
884 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100885
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200886 calls += cls._git_sanity_checks(ancestor_revision, 'master',
887 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100888 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200889 ((['git', 'rev-parse', '--show-cdup'],), ''),
890 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000891
Aaron Gable7817f022017-12-12 09:43:17 -0800892 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
893 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200894 'M\t.gitignore\n'),
895 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100896 ]
897
898 if not issue:
899 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200900 ((['git', 'log', '--pretty=format:%s%n%n%b',
901 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000902 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100903 ]
904
905 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200906 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000907 (('time.time',), 1000,),
908 (('time.time',), 3000,),
909 (('add_repeated', 'sub_commands', {
910 'execution_time': 2000,
911 'command': 'presubmit',
912 'exit_code': 0
913 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200914 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
915 ([custom_cl_base] if custom_cl_base else
916 [ancestor_revision, 'HEAD']),),
917 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100918 ]
919 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000920
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000921 @classmethod
922 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700923 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000924 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700925 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100926 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000927 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000928 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000929 labels=None, change_id=None, original_title=None,
930 final_description=None, gitcookies_exists=True):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000931 if post_amend_description is None:
932 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700933 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200934 # Determined in `_gerrit_base_calls`.
935 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
936
937 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000938
tandriia60502f2016-06-20 02:01:53 -0700939 if squash_mode == 'default':
940 calls.extend([
941 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
942 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
943 ])
944 elif squash_mode in ('override_squash', 'override_nosquash'):
945 calls.extend([
946 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
947 'true' if squash_mode == 'override_squash' else 'false'),
948 ])
949 else:
950 assert squash_mode in ('squash', 'nosquash')
951
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000952 # If issue is given, then description is fetched from Gerrit instead.
953 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000954 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200955 ((['git', 'log', '--pretty=format:%s\n\n%b',
956 ((custom_cl_base + '..') if custom_cl_base else
957 'fake_ancestor_sha..HEAD')],),
958 description),
959 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800960 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000961 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800962 else:
963 if not title:
964 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200965 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
966 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800967 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000968 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000969 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000970 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200971 (('DownloadGerritHook', False), ''),
972 # Amending of commit message to get the Change-Id.
973 ((['git', 'log', '--pretty=format:%s\n\n%b',
974 determined_ancestor_revision + '..HEAD'],),
975 description),
976 ((['git', 'commit', '--amend', '-m', description],), ''),
977 ((['git', 'log', '--pretty=format:%s\n\n%b',
978 determined_ancestor_revision + '..HEAD'],),
979 post_amend_description)
980 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000981 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000982 if not issue:
983 # Prompting to edit description on first upload.
984 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000985 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200986 ((['git', 'config', 'core.editor'],), ''),
987 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000988 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000989 ref_to_push = 'abcdef0123456789'
990 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200991 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
992 ((['git', 'config', 'branch.master.remote'],), 'origin'),
993 ]
994
995 if custom_cl_base is None:
996 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000997 ((['get_or_create_merge_base', 'master',
998 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000999 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001000 ]
1001 parent = 'origin/master'
1002 else:
1003 calls += [
1004 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
1005 'refs/remotes/origin/master'],),
1006 callError(1)), # Means not ancenstor.
1007 (('ask_for_data',
1008 'Do you take responsibility for cleaning up potential mess '
1009 'resulting from proceeding with upload? Press Enter to upload, '
1010 'or Ctrl+C to abort'), ''),
1011 ]
1012 parent = custom_cl_base
1013
1014 calls += [
1015 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
1016 '0123456789abcdef'),
1017 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001018 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001019 ref_to_push),
1020 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001021 else:
1022 ref_to_push = 'HEAD'
1023
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001024 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001025 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001026 ((['git', 'rev-list',
1027 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1028 ref_to_push],),
1029 '1hashPerLine\n'),
1030 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001031
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001032 metrics_arguments = []
1033
Aaron Gableafd52772017-06-27 16:40:10 -07001034 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001035 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001036 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001037 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001038 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001039 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001040 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001041 else:
1042 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001043 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001044
Aaron Gable70f4e242017-06-26 10:45:59 -07001045 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001046 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001047 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001048
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001049 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001050 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001051 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001052 if short_hostname == 'chromium':
1053 # All reviwers and ccs get into ref_suffix.
1054 for r in sorted(reviewers):
1055 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001056 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001057 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1058 'joe@example.com'] + cc):
1059 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001060 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001061 reviewers, cc = [], []
1062 else:
1063 # TODO(crbug/877717): remove this case.
1064 calls += [
1065 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1066 sorted(reviewers) + ['joe@example.com',
1067 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1068 {
1069 e: {'email': e}
1070 for e in (reviewers + ['joe@example.com'] + cc)
1071 })
1072 ]
1073 for r in sorted(reviewers):
1074 if r != 'bad-account-or-email':
1075 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001076 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001077 reviewers.remove(r)
1078 for c in sorted(['joe@example.com'] + cc):
1079 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001080 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001081 if c in cc:
1082 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001083
Edward Lemur687ca902018-12-05 02:30:30 +00001084 for k, v in sorted((labels or {}).items()):
1085 ref_suffix += ',l=%s+%d' % (k, v)
1086 metrics_arguments.append('l=%s+%d' % (k, v))
1087
1088 if tbr:
1089 calls += [
1090 (('GetCodeReviewTbrScore',
1091 '%s-review.googlesource.com' % short_hostname,
1092 'my/repo'),
1093 2,),
1094 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001095
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001096 calls += [
1097 (('time.time',), 1000,),
1098 ((['git', 'push',
1099 'https://%s.googlesource.com/my/repo' % short_hostname,
1100 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1101 (('remote:\n'
1102 'remote: Processing changes: (\)\n'
1103 'remote: Processing changes: (|)\n'
1104 'remote: Processing changes: (/)\n'
1105 'remote: Processing changes: (-)\n'
1106 'remote: Processing changes: new: 1 (/)\n'
1107 'remote: Processing changes: new: 1, done\n'
1108 'remote:\n'
1109 'remote: New Changes:\n'
1110 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1111 ' XXX\n'
1112 'remote:\n'
1113 'To https://%s.googlesource.com/my/repo\n'
1114 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1115 ) % (short_hostname, short_hostname)),),
1116 (('time.time',), 2000,),
1117 (('add_repeated',
1118 'sub_commands',
1119 {
1120 'execution_time': 1000,
1121 'command': 'git push',
1122 'exit_code': 0,
1123 'arguments': sorted(metrics_arguments),
1124 }),
1125 None,),
1126 ]
1127
Edward Lemur1b52d872019-05-09 21:12:12 +00001128 final_description = final_description or post_amend_description.strip()
1129 original_title = original_title or title or '<untitled>'
1130 # Trace-related calls
1131 calls += [
1132 # Write a description with context for the current trace.
1133 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001134 'Thu Mar 16 20:00:41 2017\n'
1135 '%(short_hostname)s-review.googlesource.com\n'
1136 '%(change_id)s\n'
1137 '%(title)s\n'
1138 '%(description)s\n'
1139 '1000\n'
1140 '0\n'
1141 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001142 'short_hostname': short_hostname,
1143 'change_id': change_id,
1144 'description': final_description,
1145 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001146 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001147 }],),
1148 None,
1149 ),
1150 # Read traces and shorten git hashes.
1151 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1152 True,
1153 ),
1154 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1155 ('git-hash: 0123456789012345678901234567890123456789\n'
1156 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1157 ),
1158 ((['FileWrite', 'TEMP_DIR/trace-packet',
1159 'git-hash: 012345\n'
1160 'git-hash: abcdea\n'],),
1161 None,
1162 ),
1163 # Make zip file for the git traces.
1164 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1165 'TEMP_DIR'],),
1166 None,
1167 ),
1168 # Collect git config and gitcookies.
1169 ((['git', 'config', '-l'],),
1170 'git-config-output',
1171 ),
1172 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1173 None,
1174 ),
1175 ((['os.path.isfile', '~/.gitcookies'],),
1176 gitcookies_exists,
1177 ),
1178 ]
1179 if gitcookies_exists:
1180 calls += [
1181 ((['FileRead', '~/.gitcookies'],),
1182 'gitcookies 1/SECRET',
1183 ),
1184 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1185 None,
1186 ),
1187 ]
1188 calls += [
1189 # Make zip file for the git config and gitcookies.
1190 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1191 'TEMP_DIR'],),
1192 None,
1193 ),
1194 ]
1195
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001196 if squash:
1197 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001198 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001199 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001200 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001201 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001202 ((['git', 'config', 'branch.master.gerritsquashhash',
1203 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001204 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001205 # TODO(crbug/877717): this should never be used.
1206 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001207 calls += [
1208 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001209 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001210 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001211 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1212 notify),
1213 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001214 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001215 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001216 return calls
1217
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001218 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001219 self,
1220 upload_args,
1221 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001222 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001223 squash=True,
1224 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001225 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001226 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001227 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001228 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001229 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001230 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001231 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001232 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001233 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001234 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001235 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001236 labels=None,
1237 change_id=None,
1238 original_title=None,
1239 final_description=None,
1240 gitcookies_exists=True):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001241 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001242 if squash_mode is None:
1243 if '--no-squash' in upload_args:
1244 squash_mode = 'nosquash'
1245 elif '--squash' in upload_args:
1246 squash_mode = 'squash'
1247 else:
1248 squash_mode = 'default'
1249
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001250 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001251 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001252 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001253 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001254 CookiesAuthenticatorMockFactory(
1255 same_auth=('git-owner.example.com', '', 'pass')))
Edward Lemur125d60a2019-09-13 18:25:41 +00001256 self.mock(git_cl.Changelist, '_GerritCommitMsgHookCheck',
tandrii16e0b4e2016-06-07 10:34:28 -07001257 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001258 self.mock(git_cl.gclient_utils, 'RunEditor',
1259 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001260 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1261 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001262 self.mock(git_cl.gclient_utils, 'FileRead',
1263 lambda path: self._mocked_call(['FileRead', path]))
1264 self.mock(git_cl.gclient_utils, 'FileWrite',
1265 lambda path, contents: self._mocked_call(
1266 ['FileWrite', path, contents]))
1267 self.mock(git_cl, 'datetime_now',
1268 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1269 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1270 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
Edward Lemur75391d42019-05-14 23:35:56 +00001271 self.mock(git_cl, 'TRACES_README_FORMAT',
1272 '%(now)s\n'
1273 '%(gerrit_host)s\n'
1274 '%(change_id)s\n'
1275 '%(title)s\n'
1276 '%(description)s\n'
1277 '%(execution_time)s\n'
1278 '%(exit_code)s\n'
1279 '%(trace_name)s')
Edward Lemur1b52d872019-05-09 21:12:12 +00001280 self.mock(git_cl.shutil, 'make_archive',
1281 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1282 self.mock(os.path, 'isfile',
1283 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001284
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001285 self.calls = self._gerrit_base_calls(
1286 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001287 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001288 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001289 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001290 custom_cl_base=custom_cl_base,
1291 short_hostname=short_hostname)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001292 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001293 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1294 expected_content=description))
1295 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001296 self.calls += self._gerrit_upload_calls(
1297 description, reviewers, squash,
1298 squash_mode=squash_mode,
1299 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001300 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001301 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001302 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001303 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001304 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001305 labels=labels,
1306 change_id=change_id,
1307 original_title=original_title,
1308 final_description=final_description,
1309 gitcookies_exists=gitcookies_exists)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001310 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001311 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001312 git_cl.main(['upload'] + upload_args)
1313
Edward Lemur1b52d872019-05-09 21:12:12 +00001314 def test_gerrit_upload_traces_no_gitcookies(self):
1315 self._run_gerrit_upload_test(
1316 ['--no-squash'],
1317 'desc\n\nBUG=\n',
1318 [],
1319 squash=False,
1320 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1321 change_id='Ixxx',
1322 gitcookies_exists=False)
1323
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001324 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001325 self._run_gerrit_upload_test(
1326 ['--no-squash'],
1327 'desc\n\nBUG=\n',
1328 [],
1329 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001330 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1331 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001332
1333 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001334 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001335 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001336 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001337 [],
tandriia60502f2016-06-20 02:01:53 -07001338 squash=False,
1339 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001340 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1341 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001342
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001343 def test_gerrit_no_reviewer(self):
1344 self._run_gerrit_upload_test(
1345 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001346 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001347 [],
1348 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001349 squash_mode='override_nosquash',
1350 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001351
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001352 def test_gerrit_no_reviewer_non_chromium_host(self):
1353 # TODO(crbug/877717): remove this test case.
1354 self._run_gerrit_upload_test(
1355 [],
1356 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1357 [],
1358 squash=False,
1359 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001360 short_hostname='other',
1361 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001362
Nick Carter8692b182017-11-06 16:30:38 -08001363 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001364 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1365 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001366 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001367 'desc\n\nBUG=\n\nChange-Id: I123456789',
1368 squash=False,
1369 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001370 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1371 change_id='I123456789',
1372 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001373
ukai@chromium.orge8077812012-02-03 03:41:46 +00001374 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001375 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001376 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001377 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001378 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001379 squash=False,
1380 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001381 notify=True,
1382 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001383 final_description=(
1384 'desc\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001385
1386 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001387 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1388 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001389 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001390 [],
bradnelsond975b302016-10-23 12:20:23 -07001391 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1392 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001393 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001394 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001395 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001396 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001397 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001398 labels={'Code-Review': 2},
1399 change_id='123456789',
1400 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001401
1402 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001403 self._run_gerrit_upload_test(
1404 [],
1405 'desc\nBUG=\n\nChange-Id: 123456789',
1406 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001407 expected_upstream_ref='origin/master',
1408 change_id='123456789',
1409 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001410
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001411 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001412 self._run_gerrit_upload_test(
1413 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001414 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001415 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001416 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001417 expected_upstream_ref='origin/master',
1418 change_id='123456789',
1419 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001420
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001421 def test_gerrit_upload_squash_first_with_labels(self):
1422 self._run_gerrit_upload_test(
1423 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1424 'desc\nBUG=\n\nChange-Id: 123456789',
1425 [],
1426 squash=True,
1427 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001428 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1429 change_id='123456789',
1430 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001431
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001432 def test_gerrit_upload_squash_first_against_rev(self):
1433 custom_cl_base = 'custom_cl_base_rev_or_branch'
1434 self._run_gerrit_upload_test(
1435 ['--squash', custom_cl_base],
1436 'desc\nBUG=\n\nChange-Id: 123456789',
1437 [],
1438 squash=True,
1439 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001440 custom_cl_base=custom_cl_base,
1441 change_id='123456789',
1442 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001443 self.assertIn(
1444 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1445 sys.stdout.getvalue())
1446
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001447 def test_gerrit_upload_squash_reupload(self):
1448 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001449 self._run_gerrit_upload_test(
1450 ['--squash'],
1451 description,
1452 [],
1453 squash=True,
1454 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001455 issue=123456,
1456 change_id='123456789',
1457 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001458
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001459 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1460 self.mock(git_cl, 'DieWithError',
1461 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1462 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1463 with self.assertRaises(SystemExitMock):
1464 self._run_gerrit_upload_test(
1465 ['--squash'],
1466 description,
1467 [],
1468 squash=True,
1469 expected_upstream_ref='origin/master',
1470 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001471 fetched_status='ABANDONED',
1472 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001473
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001474 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1475 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1476 lambda *_, **__: {'email': 'yet-another@example.com'})
1477 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1478 self._run_gerrit_upload_test(
1479 ['--squash'],
1480 description,
1481 [],
1482 squash=True,
1483 expected_upstream_ref='origin/master',
1484 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001485 other_cl_owner='other@example.com',
1486 change_id='123456789',
1487 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001488 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001489 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001490 'authenticate to Gerrit as yet-another@example.com.\n'
1491 'Uploading may fail due to lack of permissions',
1492 git_cl.sys.stdout.getvalue())
1493
rmistry@google.com2dd99862015-06-22 12:22:18 +00001494 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001495 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001496 def mock_run_git(*args, **_kwargs):
1497 if args[0] == ['for-each-ref',
1498 '--format=%(refname:short) %(upstream:short)',
1499 'refs/heads']:
1500 # Create a local branch dependency tree that looks like this:
1501 # test1 -> test2 -> test3 -> test4 -> test5
1502 # -> test3.1
1503 # test6 -> test0
1504 branch_deps = [
1505 'test2 test1', # test1 -> test2
1506 'test3 test2', # test2 -> test3
1507 'test3.1 test2', # test2 -> test3.1
1508 'test4 test3', # test3 -> test4
1509 'test5 test4', # test4 -> test5
1510 'test6 test0', # test0 -> test6
1511 'test7', # test7
1512 ]
1513 return '\n'.join(branch_deps)
1514 self.mock(git_cl, 'RunGit', mock_run_git)
1515
1516 class RecordCalls:
1517 times_called = 0
1518 record_calls = RecordCalls()
1519 def mock_CMDupload(*args, **_kwargs):
1520 record_calls.times_called += 1
1521 return 0
1522 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1523
1524 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001525 (('ask_for_data', 'This command will checkout all dependent branches '
1526 'and run "git cl upload". Press Enter to continue, '
1527 'or Ctrl+C to abort'), ''),
1528 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001529
1530 class MockChangelist():
1531 def __init__(self):
1532 pass
1533 def GetBranch(self):
1534 return 'test1'
1535 def GetIssue(self):
1536 return '123'
1537 def GetPatchset(self):
1538 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001539 def IsGerrit(self):
1540 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001541
1542 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1543 # CMDupload should have been called 5 times because of 5 dependent branches.
1544 self.assertEquals(5, record_calls.times_called)
1545 self.assertEquals(0, ret)
1546
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001547 def test_gerrit_change_id(self):
1548 self.calls = [
1549 ((['git', 'write-tree'], ),
1550 'hashtree'),
1551 ((['git', 'rev-parse', 'HEAD~0'], ),
1552 'branch-parent'),
1553 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1554 'A B <a@b.org> 1456848326 +0100'),
1555 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1556 'C D <c@d.org> 1456858326 +0100'),
1557 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1558 'hashchange'),
1559 ]
1560 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1561 self.assertEqual(change_id, 'Ihashchange')
1562
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001563 def test_desecription_append_footer(self):
1564 for init_desc, footer_line, expected_desc in [
1565 # Use unique desc first lines for easy test failure identification.
1566 ('foo', 'R=one', 'foo\n\nR=one'),
1567 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1568 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1569 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1570 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1571 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1572 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1573 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1574 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1575 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1576 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1577 ]:
1578 desc = git_cl.ChangeDescription(init_desc)
1579 desc.append_footer(footer_line)
1580 self.assertEqual(desc.description, expected_desc)
1581
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001582 def test_update_reviewers(self):
1583 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001584 ('foo', [], [],
1585 'foo'),
1586 ('foo\nR=xx', [], [],
1587 'foo\nR=xx'),
1588 ('foo\nTBR=xx', [], [],
1589 'foo\nTBR=xx'),
1590 ('foo', ['a@c'], [],
1591 'foo\n\nR=a@c'),
1592 ('foo\nR=xx', ['a@c'], [],
1593 'foo\n\nR=a@c, xx'),
1594 ('foo\nTBR=xx', ['a@c'], [],
1595 'foo\n\nR=a@c\nTBR=xx'),
1596 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1597 'foo\n\nR=a@c, yy\nTBR=xx'),
1598 ('foo\nBUG=', ['a@c'], [],
1599 'foo\nBUG=\nR=a@c'),
1600 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1601 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1602 ('foo', ['a@c', 'b@c'], [],
1603 'foo\n\nR=a@c, b@c'),
1604 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1605 'foo\nBar\n\nR=c@c\nBUG='),
1606 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1607 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001608 # Same as the line before, but full of whitespaces.
1609 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001610 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001611 'foo\nBar\n\nR=c@c\n BUG =',
1612 ),
1613 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001614 ('foo BUG=allo R=joe ', ['c@c'], [],
1615 'foo BUG=allo R=joe\n\nR=c@c'),
1616 # Redundant TBRs get promoted to Rs
1617 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1618 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001619 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001620 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001621 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001622 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001623 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001624 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001625 actual.append(obj.description)
1626 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001627
Nodir Turakulov23b82142017-11-16 11:04:25 -08001628 def test_get_hash_tags(self):
1629 cases = [
1630 ('', []),
1631 ('a', []),
1632 ('[a]', ['a']),
1633 ('[aa]', ['aa']),
1634 ('[a ]', ['a']),
1635 ('[a- ]', ['a']),
1636 ('[a- b]', ['a-b']),
1637 ('[a--b]', ['a-b']),
1638 ('[a', []),
1639 ('[a]x', ['a']),
1640 ('[aa]x', ['aa']),
1641 ('[a b]', ['a-b']),
1642 ('[a b]', ['a-b']),
1643 ('[a__b]', ['a-b']),
1644 ('[a] x', ['a']),
1645 ('[a][b]', ['a', 'b']),
1646 ('[a] [b]', ['a', 'b']),
1647 ('[a][b]x', ['a', 'b']),
1648 ('[a][b] x', ['a', 'b']),
1649 ('[a]\n[b]', ['a']),
1650 ('[a\nb]', []),
1651 ('[a][', ['a']),
1652 ('Revert "[a] feature"', ['a']),
1653 ('Reland "[a] feature"', ['a']),
1654 ('Revert: [a] feature', ['a']),
1655 ('Reland: [a] feature', ['a']),
1656 ('Revert "Reland: [a] feature"', ['a']),
1657 ('Foo: feature', ['foo']),
1658 ('Foo Bar: feature', ['foo-bar']),
1659 ('Revert "Foo bar: feature"', ['foo-bar']),
1660 ('Reland "Foo bar: feature"', ['foo-bar']),
1661 ]
1662 for desc, expected in cases:
1663 change_desc = git_cl.ChangeDescription(desc)
1664 actual = change_desc.get_hash_tags()
1665 self.assertEqual(
1666 actual,
1667 expected,
1668 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1669
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001670 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001671 self.assertEqual(None, git_cl.GetTargetRef(None,
1672 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001673 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001674
wittman@chromium.org455dc922015-01-26 20:15:50 +00001675 # Check default target refs for branches.
1676 self.assertEqual('refs/heads/master',
1677 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001678 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001679 self.assertEqual('refs/heads/master',
1680 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001681 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001682 self.assertEqual('refs/heads/master',
1683 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001684 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001685 self.assertEqual('refs/branch-heads/123',
1686 git_cl.GetTargetRef('origin',
1687 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001688 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001689 self.assertEqual('refs/diff/test',
1690 git_cl.GetTargetRef('origin',
1691 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001692 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001693 self.assertEqual('refs/heads/chrome/m42',
1694 git_cl.GetTargetRef('origin',
1695 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001696 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001697
1698 # Check target refs for user-specified target branch.
1699 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1700 'refs/remotes/branch-heads/123'):
1701 self.assertEqual('refs/branch-heads/123',
1702 git_cl.GetTargetRef('origin',
1703 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001704 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001705 for branch in ('origin/master', 'remotes/origin/master',
1706 'refs/remotes/origin/master'):
1707 self.assertEqual('refs/heads/master',
1708 git_cl.GetTargetRef('origin',
1709 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001710 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001711 for branch in ('master', 'heads/master', 'refs/heads/master'):
1712 self.assertEqual('refs/heads/master',
1713 git_cl.GetTargetRef('origin',
1714 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001715 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001716
wychen@chromium.orga872e752015-04-28 23:42:18 +00001717 def test_patch_when_dirty(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001718 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001719 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1720 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1721
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001722 @staticmethod
1723 def _get_gerrit_codereview_server_calls(branch, value=None,
1724 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001725 detect_branch=True,
1726 detect_server=True):
Edward Lemur125d60a2019-09-13 18:25:41 +00001727 """Returns calls executed by Changelist.GetCodereviewServer.
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001728
1729 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1730 """
1731 calls = []
1732 if detect_branch:
1733 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001734 if detect_server:
1735 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1736 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001737 if value is None:
1738 calls += [
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001739 ((['git', 'config', 'branch.' + branch + '.merge'],),
1740 'refs/heads' + branch),
1741 ((['git', 'config', 'branch.' + branch + '.remote'],),
1742 'origin'),
1743 ((['git', 'config', 'remote.origin.url'],),
1744 'https://%s.googlesource.com/my/repo' % git_short_host),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001745 ]
1746 return calls
1747
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001748 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001749 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001750 detect_gerrit_server=False,
1751 actual_codereview=None,
1752 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001753 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001754 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1755
tandriidf09a462016-08-18 16:23:55 -07001756 if new_branch:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001757 self.calls = [((['git', 'new-branch', 'master'],), '')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001758
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001759 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001760 self.calls += [
1761 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001762 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001763 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001764
1765 if not force_codereview and not codereview_in_url:
1766 # These calls detect codereview to use.
1767 self.calls += [
1768 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001769 ]
1770 if detect_gerrit_server:
1771 self.calls += self._get_gerrit_codereview_server_calls(
1772 'master', git_short_host=git_short_host,
1773 detect_branch=not new_branch and force_codereview)
1774 actual_codereview = 'gerrit'
1775
1776 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001777 self.calls += [
1778 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001779 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001780 {
1781 'current_revision': '7777777777',
1782 'revisions': {
1783 '1111111111': {
1784 '_number': 1,
1785 'fetch': {'http': {
1786 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1787 'ref': 'refs/changes/56/123456/1',
1788 }},
1789 },
1790 '7777777777': {
1791 '_number': 7,
1792 'fetch': {'http': {
1793 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1794 'ref': 'refs/changes/56/123456/7',
1795 }},
1796 },
1797 },
1798 }),
1799 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001800
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001801 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001802 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001803 self.calls += [
1804 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1805 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001806 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001807 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001808 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001809 ((['git', 'config', 'branch.master.gerritserver',
1810 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001811 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001812 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1813 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1814 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001815 ]
1816 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1817
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001818 def test_patch_gerrit_new_branch(self):
1819 self._patch_common(
1820 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1821 self.calls += [
1822 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1823 'refs/changes/56/123456/7'],), ''),
1824 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1825 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1826 ''),
1827 ((['git', 'config', 'branch.master.gerritserver',
1828 'https://chromium-review.googlesource.com'],), ''),
1829 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1830 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1831 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1832 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1833 ]
1834 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1835
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001836 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001837 self._patch_common(
1838 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001839 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001840 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001841 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001842 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001843 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001844 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001845 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001846 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001847 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001848 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1849 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1850 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001851 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001852 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001853
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001854 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001855 self.calls += self._get_gerrit_codereview_server_calls(
1856 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001857 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001858 actual_codereview='gerrit', git_short_host='else',
1859 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001860 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001861 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001862 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001863 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001864 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001865 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001866 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001867 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001868 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001869 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1870 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1871 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001872 ]
1873 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001874 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001875
Aaron Gable697a91b2018-01-19 15:20:15 -08001876 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001877 self.calls += self._get_gerrit_codereview_server_calls(
1878 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001879 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001880 actual_codereview='gerrit', git_short_host='else',
1881 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001882 self.calls += [
1883 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1884 'refs/changes/56/123456/1'],), ''),
1885 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1886 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1887 ''),
1888 ((['git', 'config', 'branch.master.gerritserver',
1889 'https://else-review.googlesource.com'],), ''),
1890 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1891 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1892 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1893 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1894 ]
1895 self.assertEqual(git_cl.main(
1896 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1897 0)
1898
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001899 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001900 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001901 self.calls += [
1902 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001903 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001904 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1905 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1906 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001907 ]
1908 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001909 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001910
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001911 def test_patch_gerrit_not_exists(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001912
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001913 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001914 raise git_cl.gerrit_util.GerritError(404, '')
1915 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1916
tandriic2405f52016-10-10 08:13:15 -07001917 self.calls = [
1918 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001919 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1920 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1921 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1922 ((['git', 'config', 'remote.origin.url'],),
1923 'https://chromium.googlesource.com/my/repo'),
1924 ((['DieWithError',
1925 'change 123456 at https://chromium-review.googlesource.com does not '
1926 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001927 ]
1928 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001929 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001930
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001931 def _checkout_calls(self):
1932 return [
1933 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001934 'branch\\..*\\.gerritissue'], ),
1935 ('branch.ger-branch.gerritissue 123456\n'
1936 'branch.gbranch654.gerritissue 654321\n')),
1937 ]
1938
1939 def test_checkout_gerrit(self):
1940 """Tests git cl checkout <issue>."""
1941 self.calls = self._checkout_calls()
1942 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1943 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1944
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001945 def test_checkout_not_found(self):
1946 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001947 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001948 self.calls = self._checkout_calls()
1949 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1950
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001951 def test_checkout_no_branch_issues(self):
1952 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001953 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001954 self.calls = [
1955 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001956 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001957 ]
1958 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1959
tandrii@chromium.org28253532016-04-14 13:46:56 +00001960 def _test_gerrit_ensure_authenticated_common(self, auth,
1961 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001962 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1963 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1964 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001965 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001966 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
Edward Lemurf38bc172019-09-03 21:02:13 +00001967 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001968 cl.branch = 'master'
1969 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001970 return cl
1971
1972 def test_gerrit_ensure_authenticated_missing(self):
1973 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001974 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001975 })
1976 self.calls.append(
1977 ((['DieWithError',
1978 'Credentials for the following hosts are required:\n'
1979 ' chromium-review.googlesource.com\n'
1980 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01001981 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001982 'https://chromium-review.googlesource.com/new-password'],), ''),)
1983 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1984
1985 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001986 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001987 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001988 'chromium.googlesource.com':
1989 ('git-one.example.com', None, 'secret1'),
1990 'chromium-review.googlesource.com':
1991 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001992 })
1993 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001994 (('ask_for_data', 'If you know what you are doing '
1995 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001996 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1997
1998 def test_gerrit_ensure_authenticated_ok(self):
1999 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002000 'chromium.googlesource.com':
2001 ('git-same.example.com', None, 'secret'),
2002 'chromium-review.googlesource.com':
2003 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002004 })
2005 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2006
tandrii@chromium.org28253532016-04-14 13:46:56 +00002007 def test_gerrit_ensure_authenticated_skipped(self):
2008 cl = self._test_gerrit_ensure_authenticated_common(
2009 auth={}, skip_auth_check=True)
2010 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2011
Eric Boren2fb63102018-10-05 13:05:03 +00002012 def test_gerrit_ensure_authenticated_bearer_token(self):
2013 cl = self._test_gerrit_ensure_authenticated_common(auth={
2014 'chromium.googlesource.com':
2015 ('', None, 'secret'),
2016 'chromium-review.googlesource.com':
2017 ('', None, 'secret'),
2018 })
2019 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2020 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2021 'chromium.googlesource.com')
2022 self.assertTrue('Bearer' in header)
2023
Daniel Chengcf6269b2019-05-18 01:02:12 +00002024 def test_gerrit_ensure_authenticated_non_https(self):
2025 self.calls = [
2026 ((['git', 'config', '--bool',
2027 'gerrit.skip-ensure-authenticated'],), CERR1),
2028 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2029 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2030 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
2031 ]
2032 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2033 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
Edward Lemurf38bc172019-09-03 21:02:13 +00002034 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002035 cl.branch = 'master'
2036 cl.branchref = 'refs/heads/master'
2037 cl.lookedup_issue = True
2038 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2039
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002040 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002041 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002042 lambda h, i, labels, notify=None:
2043 self._mocked_call(['SetReview', h, i, labels, notify]))
2044
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002045 self.calls = [
2046 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002047 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002048 ((['git', 'config', 'branch.feature.gerritserver'],),
2049 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002050 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2051 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2052 ((['git', 'config', 'remote.origin.url'],),
2053 'https://chromium.googlesource.com/infra/infra.git'),
2054 ((['SetReview', 'chromium-review.googlesource.com',
2055 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002056 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002057 ]
tandriid9e5ce52016-07-13 02:32:59 -07002058
2059 def test_cmd_set_commit_gerrit_clear(self):
2060 self._cmd_set_commit_gerrit_common(0)
2061 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2062
2063 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002064 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002065 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2066
tandriid9e5ce52016-07-13 02:32:59 -07002067 def test_cmd_set_commit_gerrit(self):
2068 self._cmd_set_commit_gerrit_common(2)
2069 self.assertEqual(0, git_cl.main(['set-commit']))
2070
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002071 def test_description_display(self):
2072 out = StringIO.StringIO()
2073 self.mock(git_cl.sys, 'stdout', out)
2074
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002075 self.mock(git_cl, 'Changelist', ChangelistMock)
2076 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002077
2078 self.assertEqual(0, git_cl.main(['description', '-d']))
2079 self.assertEqual('foo\n', out.getvalue())
2080
iannucci3c972b92016-08-17 13:24:10 -07002081 def test_StatusFieldOverrideIssueMissingArgs(self):
2082 out = StringIO.StringIO()
2083 self.mock(git_cl.sys, 'stderr', out)
2084
2085 try:
2086 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2087 except SystemExit as ex:
2088 self.assertEqual(ex.code, 2)
Edward Lemurf38bc172019-09-03 21:02:13 +00002089 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002090
2091 out = StringIO.StringIO()
2092 self.mock(git_cl.sys, 'stderr', out)
2093
2094 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002095 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002096 except SystemExit as ex:
2097 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002098 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002099
2100 def test_StatusFieldOverrideIssue(self):
2101 out = StringIO.StringIO()
2102 self.mock(git_cl.sys, 'stdout', out)
2103
2104 def assertIssue(cl_self, *_args):
2105 self.assertEquals(cl_self.issue, 1)
2106 return 'foobar'
2107
2108 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002109 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002110 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002111 0)
iannucci3c972b92016-08-17 13:24:10 -07002112 self.assertEqual(out.getvalue(), 'foobar\n')
2113
iannuccie53c9352016-08-17 14:40:40 -07002114 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002115
iannuccie53c9352016-08-17 14:40:40 -07002116 def assertIssue(cl_self, *_args):
2117 self.assertEquals(cl_self.issue, 1)
2118 return 'foobar'
2119
2120 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2121 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002122 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002123 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002124
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002125 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002126 out = StringIO.StringIO()
2127 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002128 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002129 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2130 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2131 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2132 ((['git', 'config', 'remote.origin.url'],),
2133 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002134 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002135 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002136 {
2137 'current_revision': 'sha1',
2138 'revisions': {'sha1': {
2139 'commit': {'message': 'foobar'},
2140 }},
2141 }),
2142 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002143 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002144 'description',
2145 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2146 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002147 self.assertEqual('foobar\n', out.getvalue())
2148
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002149 def test_description_set_raw(self):
2150 out = StringIO.StringIO()
2151 self.mock(git_cl.sys, 'stdout', out)
2152
2153 self.mock(git_cl, 'Changelist', ChangelistMock)
2154 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2155
2156 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2157 self.assertEqual('hihi', ChangelistMock.desc)
2158
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002159 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002160 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002161
2162 def RunEditor(desc, _, **kwargs):
2163 self.assertEquals(
2164 '# Enter a description of the change.\n'
2165 '# This will be displayed on the codereview site.\n'
2166 '# The first line will also be used as the subject of the review.\n'
2167 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002168 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002169 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002170 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002171 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002172 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002173
dsansomee2d6fd92016-09-08 00:10:47 -07002174 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002175 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002176
2177 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2178 self.mock(git_cl.Changelist, 'GetDescription',
2179 lambda *args: current_desc)
Edward Lemur125d60a2019-09-13 18:25:41 +00002180 self.mock(git_cl.Changelist, 'UpdateDescriptionRemote',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002181 UpdateDescriptionRemote)
2182 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2183
2184 self.calls = [
2185 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002186 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002187 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2188 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002189 ((['git', 'config', 'core.editor'],), 'vi'),
2190 ]
2191 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2192
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002193 def test_description_set_stdin(self):
2194 out = StringIO.StringIO()
2195 self.mock(git_cl.sys, 'stdout', out)
2196
2197 self.mock(git_cl, 'Changelist', ChangelistMock)
2198 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2199
2200 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2201 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2202
kmarshall3bff56b2016-06-06 18:31:47 -07002203 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002204 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2205
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002206 self.calls = [
2207 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002208 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002209 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2210 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002211 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002212 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002213
kmarshall3bff56b2016-06-06 18:31:47 -07002214 self.mock(git_cl, 'get_cl_statuses',
2215 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002216 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2217 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2218 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002219
2220 self.assertEqual(0, git_cl.main(['archive', '-f']))
2221
2222 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002223 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002224 self.calls = [
2225 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2226 'refs/heads/master'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002227 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2228 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002229
kmarshall9249e012016-08-23 12:02:16 -07002230 self.mock(git_cl, 'get_cl_statuses',
2231 lambda branches, fine_grained, max_processes:
2232 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2233
2234 self.assertEqual(1, git_cl.main(['archive', '-f']))
2235
2236 def test_archive_dry_run(self):
2237 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2238
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002239 self.calls = [
2240 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2241 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002242 ((['git', 'symbolic-ref', 'HEAD'],), 'master')
2243 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002244
2245 self.mock(git_cl, 'get_cl_statuses',
2246 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002247 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2248 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2249 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002250
kmarshall9249e012016-08-23 12:02:16 -07002251 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2252
2253 def test_archive_no_tags(self):
2254 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2255
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002256 self.calls = [
2257 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2258 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002259 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2260 ((['git', 'branch', '-D', 'foo'],), '')
2261 ]
kmarshall9249e012016-08-23 12:02:16 -07002262
2263 self.mock(git_cl, 'get_cl_statuses',
2264 lambda branches, fine_grained, max_processes:
2265 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2266 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2267 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2268
2269 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002270
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002271 def test_cmd_issue_erase_existing(self):
2272 out = StringIO.StringIO()
2273 self.mock(git_cl.sys, 'stdout', out)
2274 self.calls = [
2275 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002276 # Let this command raise exception (retcode=1) - it should be ignored.
2277 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002278 CERR1),
2279 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2280 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002281 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2282 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2283 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002284 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002285 ]
2286 self.assertEqual(0, git_cl.main(['issue', '0']))
2287
Aaron Gable400e9892017-07-12 15:31:21 -07002288 def test_cmd_issue_erase_existing_with_change_id(self):
2289 out = StringIO.StringIO()
2290 self.mock(git_cl.sys, 'stdout', out)
2291 self.mock(git_cl.Changelist, 'GetDescription',
2292 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2293 self.calls = [
2294 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002295 # Let this command raise exception (retcode=1) - it should be ignored.
2296 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2297 CERR1),
2298 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2299 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2300 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2301 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2302 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002303 ((['git', 'log', '-1', '--format=%B'],),
2304 'This is a description\n\nChange-Id: Ideadbeef'),
2305 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002306 ]
2307 self.assertEqual(0, git_cl.main(['issue', '0']))
2308
phajdan.jre328cf92016-08-22 04:12:17 -07002309 def test_cmd_issue_json(self):
2310 out = StringIO.StringIO()
2311 self.mock(git_cl.sys, 'stdout', out)
2312 self.calls = [
2313 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002314 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2315 ((['git', 'config', 'branch.feature.gerritserver'],),
2316 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002317 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002318 {'issue': 123,
2319 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002320 ''),
2321 ]
2322 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2323
tandrii8c5a3532016-11-04 07:52:02 -07002324 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2325 self.mock(git_cl.Changelist, 'GetChange',
2326 lambda _, *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002327 self._mocked_call(['GetChange'] + list(a))))
tandrii8c5a3532016-11-04 07:52:02 -07002328 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2329 lambda *_, **__: (
2330 self._mocked_call(['DoGetTryMasters'])))
Edward Lemur125d60a2019-09-13 18:25:41 +00002331 self.mock(git_cl.Changelist, 'SetCQState',
tandrii8c5a3532016-11-04 07:52:02 -07002332 lambda _, s: self._mocked_call(['SetCQState', s]))
2333
tandrii8c5a3532016-11-04 07:52:02 -07002334 self.calls = [
2335 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002336 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2337 ((['git', 'config', 'branch.feature.gerritserver'],),
2338 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002339 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2340 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2341 ((['git', 'config', 'remote.origin.url'],),
2342 'https://chromium.googlesource.com/depot_tools'),
2343 (('GetChangeDetail', 'chromium-review.googlesource.com',
2344 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002345 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2346 'project': 'depot_tools',
2347 'status': 'OPEN',
2348 'owner': {'email': 'owner@e.mail'},
2349 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002350 'deadbeaf': {
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002351 '_number': 6,
2352 },
2353 'beeeeeef': {
2354 '_number': 7,
2355 'fetch': {'http': {
2356 'url': 'https://chromium.googlesource.com/depot_tools',
2357 'ref': 'refs/changes/56/123456/7'
2358 }},
2359 },
2360 },
2361 }),
tandrii8c5a3532016-11-04 07:52:02 -07002362 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2363 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2364 ((['get_or_create_merge_base', 'feature', 'feature'],),
2365 'fake_ancestor_sha'),
2366 ((['GetChange', 'fake_ancestor_sha', None], ),
2367 git_cl.presubmit_support.GitChange(
2368 '', '', '', '', '', '', '', '')),
2369 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2370 ((['DoGetTryMasters'], ), None),
Edward Lemur125d60a2019-09-13 18:25:41 +00002371 ((['SetCQState', git_cl._CQState.DRY_RUN], ), 0),
tandrii8c5a3532016-11-04 07:52:02 -07002372 ]
2373 out = StringIO.StringIO()
2374 self.mock(git_cl.sys, 'stdout', out)
2375 self.assertEqual(0, git_cl.main(['try']))
2376 self.assertEqual(
2377 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002378 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002379 'https://chromium-review.googlesource.com/123456\n')
2380
tandrii8c5a3532016-11-04 07:52:02 -07002381 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2382 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2383 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
Edward Lemur5b6ae8b2019-09-12 23:27:24 +00002384 def mocked_call_with_stdin(*a, **kw):
2385 args = list(a)
2386 if kw.get('stdin'):
2387 args.append(kw['stdin'])
2388 return ([self._mocked_call(*args), ''], 0)
2389
2390 self.mock(subprocess2, 'communicate', mocked_call_with_stdin)
2391
2392 bb_request = json.dumps({
2393 "requests": [{
2394 "scheduleBuild": {
2395 "requestId": "uuid4",
2396 "builder": {
2397 "project": "luci",
2398 "builder": "win",
2399 "bucket": "chromium.try",
2400 },
2401 "gerritChanges": [{
2402 "project": "depot_tools",
2403 "host": "chromium-review.googlesource.com",
2404 "patchset": 7,
2405 "change": 123456,
2406 }],
2407 "properties": {
2408 "category": "git_cl_try",
2409 "json": [{"a": 1}, None],
2410 "key": "val",
2411 },
2412 "tags": [
2413 {"value": "win", "key": "builder"},
2414 {"value": "git_cl_try", "key": "user_agent"},
2415 ],
2416 },
2417 }],
2418 }, sort_keys=True)
2419
tandrii8c5a3532016-11-04 07:52:02 -07002420
tandrii8c5a3532016-11-04 07:52:02 -07002421 self.calls = [
2422 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002423 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2424 ((['git', 'config', 'branch.feature.gerritserver'],),
2425 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002426 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2427 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2428 ((['git', 'config', 'remote.origin.url'],),
2429 'https://chromium.googlesource.com/depot_tools'),
2430 (('GetChangeDetail', 'chromium-review.googlesource.com',
2431 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002432 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002433 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002434 'status': 'OPEN',
2435 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002436 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002437 'deadbeaf': {
tandrii8c5a3532016-11-04 07:52:02 -07002438 '_number': 6,
2439 },
2440 'beeeeeef': {
2441 '_number': 7,
2442 'fetch': {'http': {
2443 'url': 'https://chromium.googlesource.com/depot_tools',
2444 'ref': 'refs/changes/56/123456/7'
2445 }},
2446 },
2447 },
2448 }),
Edward Lemur5b6ae8b2019-09-12 23:27:24 +00002449 ((['bb', 'auth-info'],), ''),
2450 ((['git', 'config', 'branch.feature.gerritpatchset'],), '7'),
2451 ((['bb', 'batch', '-host', 'cr-buildbucket.appspot.com'],
2452 bb_request,), ''),
tandrii8c5a3532016-11-04 07:52:02 -07002453 ]
2454
tandrii8c5a3532016-11-04 07:52:02 -07002455 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2456 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002457 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002458 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2459 self.assertRegexpMatches(
2460 git_cl.sys.stdout.getvalue(),
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002461 'Tried jobs on:\nBucket: luci.chromium.try')
tandriide281ae2016-10-12 06:02:30 -07002462
tandrii16e0b4e2016-06-07 10:34:28 -07002463 def _common_GerritCommitMsgHookCheck(self):
2464 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2465 self.mock(git_cl.os.path, 'abspath',
2466 lambda path: self._mocked_call(['abspath', path]))
2467 self.mock(git_cl.os.path, 'exists',
2468 lambda path: self._mocked_call(['exists', path]))
2469 self.mock(git_cl.gclient_utils, 'FileRead',
2470 lambda path: self._mocked_call(['FileRead', path]))
2471 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2472 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2473 self.calls = [
2474 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2475 ((['abspath', '../'],), '/abs/git_repo_root'),
2476 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002477 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002478
2479 def test_GerritCommitMsgHookCheck_custom_hook(self):
2480 cl = self._common_GerritCommitMsgHookCheck()
2481 self.calls += [
2482 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2483 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2484 '#!/bin/sh\necho "custom hook"')
2485 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002486 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002487
2488 def test_GerritCommitMsgHookCheck_not_exists(self):
2489 cl = self._common_GerritCommitMsgHookCheck()
2490 self.calls += [
2491 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2492 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002493 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002494
2495 def test_GerritCommitMsgHookCheck(self):
2496 cl = self._common_GerritCommitMsgHookCheck()
2497 self.calls += [
2498 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2499 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2500 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002501 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002502 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2503 ''),
2504 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002505 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002506
tandriic4344b52016-08-29 06:04:54 -07002507 def test_GerritCmdLand(self):
2508 self.calls += [
2509 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2510 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2511 'deadbeaf'),
2512 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2513 ((['git', 'config', 'branch.feature.gerritserver'],),
2514 'chromium-review.googlesource.com'),
2515 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002516 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002517 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002518 'labels': {},
2519 'current_revision': 'deadbeaf',
2520 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002521 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002522 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002523 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002524 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2525 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002526 cl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002527 out = StringIO.StringIO()
2528 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002529 self.assertEqual(0, cl.CMDLand(force=True,
2530 bypass_hooks=True,
2531 verbose=True,
2532 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002533 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002534 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002535
tandrii221ab252016-10-06 08:12:04 -07002536 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002537 '9000': {
2538 'id': '9000',
2539 'bucket': 'master.x.y',
2540 'created_by': 'user:someone@chromium.org',
2541 'created_ts': '147200002222000',
2542 'experimental': False,
2543 'parameters_json': json.dumps({
2544 'builder_name': 'my-bot',
2545 'properties': {'category': 'cq'},
2546 }),
2547 'status': 'STARTED',
2548 'tags': [
2549 'build_address:x.y/my-bot/2',
2550 'builder:my-bot',
2551 'experimental:false',
2552 'user_agent:cq',
2553 ],
2554 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2555 },
2556 '8000': {
2557 'id': '8000',
2558 'bucket': 'master.x.y',
2559 'created_by': 'user:someone@chromium.org',
2560 'created_ts': '147200001111000',
2561 'experimental': False,
2562 'failure_reason': 'BUILD_FAILURE',
2563 'parameters_json': json.dumps({
2564 'builder_name': 'my-bot',
2565 'properties': {'category': 'cq'},
2566 }),
2567 'result_details_json': json.dumps({
2568 'properties': {'buildnumber': 1},
2569 }),
2570 'result': 'FAILURE',
2571 'status': 'COMPLETED',
2572 'tags': [
2573 'build_address:x.y/my-bot/1',
2574 'builder:my-bot',
2575 'experimental:false',
2576 'user_agent:cq',
2577 ],
2578 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2579 },
2580 }
tandrii221ab252016-10-06 08:12:04 -07002581
2582 def test_write_try_results_json(self):
2583 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002584 {
2585 'bucket': 'master.x.y',
2586 'buildbucket_id': '8000',
2587 'builder_name': 'my-bot',
2588 'created_ts': '147200001111000',
2589 'experimental': False,
2590 'failure_reason': 'BUILD_FAILURE',
2591 'result': 'FAILURE',
2592 'status': 'COMPLETED',
2593 'tags': [
2594 'build_address:x.y/my-bot/1',
2595 'builder:my-bot',
2596 'experimental:false',
2597 'user_agent:cq',
2598 ],
2599 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2600 },
2601 {
2602 'bucket': 'master.x.y',
2603 'buildbucket_id': '9000',
2604 'builder_name': 'my-bot',
2605 'created_ts': '147200002222000',
2606 'experimental': False,
2607 'failure_reason': None,
2608 'result': None,
2609 'status': 'STARTED',
2610 'tags': [
2611 'build_address:x.y/my-bot/2',
2612 'builder:my-bot',
2613 'experimental:false',
2614 'user_agent:cq',
2615 ],
2616 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2617 },
tandrii221ab252016-10-06 08:12:04 -07002618 ]
2619 self.calls = [(('write_json', 'output.json', expected_output), '')]
2620 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2621
tandrii45b2a582016-10-11 03:14:16 -07002622 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002623 out = StringIO.StringIO()
2624 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002625 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2626 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002627 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2628 self._mocked_call(['get_authenticator_for_host', host]))
2629 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2630 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002631
tandrii45b2a582016-10-11 03:14:16 -07002632 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2633 self._setup_fetch_try_jobs(most_recent_patchset=13)
2634 self.calls += [
2635 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii45b2a582016-10-11 03:14:16 -07002636 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002637 # TODO(tandrii): Uncomment the below if we decide to support checking
2638 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002639 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002640 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002641 ((['git', 'config', 'branch.feature.gerritserver'],),
2642 'https://x-review.googlesource.com'),
2643 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2644 AuthenticatorMock()),
2645 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2646
2647 def test_fetch_try_jobs_none_gerrit(self):
2648 self._setup_fetch_try_jobs_gerrit({})
2649 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002650 # TODO(tandrii): Uncomment the below if we decide to support checking
2651 # patchsets for Gerrit.
2652 # self.assertRegexpMatches(
2653 # sys.stdout.getvalue(),
2654 # r'Warning: Codereview server has newer patchsets \(13\)')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002655 self.assertRegexpMatches(sys.stdout.getvalue(), 'No tryjobs')
tandrii45b2a582016-10-11 03:14:16 -07002656
2657 def test_fetch_try_jobs_some_gerrit(self):
2658 self._setup_fetch_try_jobs_gerrit({
2659 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2660 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002661 # TODO(tandrii): Uncomment the below if we decide to support checking
2662 # patchsets for Gerrit.
2663 # self.calls.remove(
2664 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002665 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2666
2667 # ... and doesn't result in warning.
2668 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2669 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002670 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002671 self.assertRegexpMatches(sys.stdout.getvalue(), '2 tryjobs')
tandrii221ab252016-10-06 08:12:04 -07002672
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002673 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemur125d60a2019-09-13 18:25:41 +00002674 self.mock(git_cl.Changelist, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002675
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002676 def test_gerrit_change_detail_cache_simple(self):
2677 self._mock_gerrit_changes_for_detail_cache()
2678 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002679 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2680 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2681 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002682 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002683 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002684 cl1._cached_remote_url = (
2685 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002686 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002687 cl2._cached_remote_url = (
2688 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002689 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2690 self.assertEqual(cl1._GetChangeDetail(), 'a')
2691 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2692 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2693 self.assertEqual(cl1._GetChangeDetail(), 'a')
2694 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002695
2696 def test_gerrit_change_detail_cache_options(self):
2697 self._mock_gerrit_changes_for_detail_cache()
2698 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002699 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2700 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2701 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2702 # no longer in cache.
2703 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002704 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002705 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002706 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002707 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2708 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2709 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2710 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2711 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2712 self.assertEqual(cl._GetChangeDetail(), 'cab')
2713
2714 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2715 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2716 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2717 self.assertEqual(cl._GetChangeDetail(), 'cab')
2718
2719 # Finally, no_cache should invalidate all caches for given change.
2720 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2721 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2722
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002723 def test_gerrit_description_caching(self):
2724 def gen_detail(rev, desc):
2725 return {
2726 'current_revision': rev,
2727 'revisions': {rev: {'commit': {'message': desc}}}
2728 }
2729 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002730 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002731 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2732 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002733 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002734 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2735 gen_detail('rev2', 'desc2')),
2736 ]
2737
2738 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002739 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002740 cl._cached_remote_url = (
2741 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002742 self.assertEqual(cl.GetDescription(), 'desc1')
2743 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2744 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002745
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002746 def test_print_current_creds(self):
2747 class CookiesAuthenticatorMock(object):
2748 def __init__(self):
2749 self.gitcookies = {
2750 'host.googlesource.com': ('user', 'pass'),
2751 'host-review.googlesource.com': ('user', 'pass'),
2752 }
2753 self.netrc = self
2754 self.netrc.hosts = {
2755 'github.com': ('user2', None, 'pass2'),
2756 'host2.googlesource.com': ('user3', None, 'pass'),
2757 }
2758 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2759 CookiesAuthenticatorMock)
2760 self.mock(sys, 'stdout', StringIO.StringIO())
2761 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2762 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2763 ' Host\t User\t Which file',
2764 '============================\t=====\t===========',
2765 'host-review.googlesource.com\t user\t.gitcookies',
2766 ' host.googlesource.com\t user\t.gitcookies',
2767 ' host2.googlesource.com\tuser3\t .netrc',
2768 ])
2769 sys.stdout.buf = ''
2770 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2771 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2772 ' Host\tUser\t Which file',
2773 '============================\t====\t===========',
2774 'host-review.googlesource.com\tuser\t.gitcookies',
2775 ' host.googlesource.com\tuser\t.gitcookies',
2776 ])
2777
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002778 def _common_creds_check_mocks(self):
2779 def exists_mock(path):
2780 dirname = os.path.dirname(path)
2781 if dirname == os.path.expanduser('~'):
2782 dirname = '~'
2783 base = os.path.basename(path)
2784 if base in ('.netrc', '.gitcookies'):
2785 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2786 # git cl also checks for existence other files not relevant to this test.
2787 return None
2788 self.mock(os.path, 'exists', exists_mock)
2789 self.mock(sys, 'stdout', StringIO.StringIO())
2790
2791 def test_creds_check_gitcookies_not_configured(self):
2792 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002793 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002794 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002795 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002796 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002797 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2798 (('os.path.exists', '~/.netrc'), True),
2799 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2800 'or Ctrl+C to abort'), ''),
2801 ((['git', 'config', '--global', 'http.cookiefile',
2802 os.path.expanduser('~/.gitcookies')], ), ''),
2803 ]
2804 self.assertEqual(0, git_cl.main(['creds-check']))
2805 self.assertRegexpMatches(
2806 sys.stdout.getvalue(),
2807 '^You seem to be using outdated .netrc for git credentials:')
2808 self.assertRegexpMatches(
2809 sys.stdout.getvalue(),
2810 '\nConfigured git to use .gitcookies from')
2811
2812 def test_creds_check_gitcookies_configured_custom_broken(self):
2813 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002814 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002815 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002816 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002817 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002818 ((['git', 'config', '--global', 'http.cookiefile'],),
2819 '/custom/.gitcookies'),
2820 (('os.path.exists', '/custom/.gitcookies'), False),
2821 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2822 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2823 ((['git', 'config', '--global', 'http.cookiefile',
2824 os.path.expanduser('~/.gitcookies')], ), ''),
2825 ]
2826 self.assertEqual(0, git_cl.main(['creds-check']))
2827 self.assertRegexpMatches(
2828 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002829 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002830 self.assertRegexpMatches(
2831 sys.stdout.getvalue(),
2832 'However, your configured .gitcookies file is missing.')
2833
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002834 def test_git_cl_comment_add_gerrit(self):
2835 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002836 lambda host, change, msg, ready:
2837 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002838 self.calls = [
2839 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2840 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2841 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2842 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2843 'origin/master'),
2844 ((['git', 'config', 'remote.origin.url'],),
2845 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002846 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2847 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002848 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002849 ]
2850 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2851 '-a', 'msg']))
2852
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002853 def test_git_cl_comments_fetch_gerrit(self):
2854 self.mock(sys, 'stdout', StringIO.StringIO())
2855 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002856 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2857 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002858 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2859 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2860 'origin/master'),
2861 ((['git', 'config', 'remote.origin.url'],),
2862 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002863 (('GetChangeDetail', 'chromium-review.googlesource.com',
2864 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002865 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2866 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002867 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002868 'current_revision': 'ba5eba11',
2869 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002870 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002871 '_number': 1,
2872 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002873 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002874 '_number': 2,
2875 },
2876 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002877 'messages': [
2878 {
2879 u'_revision_number': 1,
2880 u'author': {
2881 u'_account_id': 1111084,
2882 u'email': u'commit-bot@chromium.org',
2883 u'name': u'Commit Bot'
2884 },
2885 u'date': u'2017-03-15 20:08:45.000000000',
2886 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002887 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002888 u'tag': u'autogenerated:cq:dry-run'
2889 },
2890 {
2891 u'_revision_number': 2,
2892 u'author': {
2893 u'_account_id': 11151243,
2894 u'email': u'owner@example.com',
2895 u'name': u'owner'
2896 },
2897 u'date': u'2017-03-16 20:00:41.000000000',
2898 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2899 u'message': u'PTAL',
2900 },
2901 {
2902 u'_revision_number': 2,
2903 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002904 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002905 u'email': u'reviewer@example.com',
2906 u'name': u'reviewer'
2907 },
2908 u'date': u'2017-03-17 05:19:37.500000000',
2909 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2910 u'message': u'Patch Set 2: Code-Review+1',
2911 },
2912 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002913 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002914 (('GetChangeComments', 'chromium-review.googlesource.com',
2915 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002916 '/COMMIT_MSG': [
2917 {
2918 'author': {'email': u'reviewer@example.com'},
2919 'updated': u'2017-03-17 05:19:37.500000000',
2920 'patch_set': 2,
2921 'side': 'REVISION',
2922 'message': 'Please include a bug link',
2923 },
2924 ],
2925 'codereview.settings': [
2926 {
2927 'author': {'email': u'owner@example.com'},
2928 'updated': u'2017-03-16 20:00:41.000000000',
2929 'patch_set': 2,
2930 'side': 'PARENT',
2931 'line': 42,
2932 'message': 'I removed this because it is bad',
2933 },
2934 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002935 }),
2936 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2937 'infra%2Finfra~1'), {}),
2938 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002939 ] * 2 + [
2940 (('write_json', 'output.json', [
2941 {
2942 u'date': u'2017-03-16 20:00:41.000000',
2943 u'message': (
2944 u'PTAL\n' +
2945 u'\n' +
2946 u'codereview.settings\n' +
2947 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2948 u'c/1/2/codereview.settings#b42\n' +
2949 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002950 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002951 u'approval': False,
2952 u'disapproval': False,
2953 u'sender': u'owner@example.com'
2954 }, {
2955 u'date': u'2017-03-17 05:19:37.500000',
2956 u'message': (
2957 u'Patch Set 2: Code-Review+1\n' +
2958 u'\n' +
2959 u'/COMMIT_MSG\n' +
2960 u' PS2, File comment: https://chromium-review.googlesource' +
2961 u'.com/c/1/2//COMMIT_MSG#\n' +
2962 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002963 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002964 u'approval': False,
2965 u'disapproval': False,
2966 u'sender': u'reviewer@example.com'
2967 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002968 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002969 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002970 expected_comments_summary = [
2971 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002972 message=(
2973 u'PTAL\n' +
2974 u'\n' +
2975 u'codereview.settings\n' +
2976 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2977 u'c/1/2/codereview.settings#b42\n' +
2978 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002979 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002980 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002981 disapproval=False, approval=False, sender=u'owner@example.com'),
2982 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002983 message=(
2984 u'Patch Set 2: Code-Review+1\n' +
2985 u'\n' +
2986 u'/COMMIT_MSG\n' +
2987 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2988 u'c/1/2//COMMIT_MSG#\n' +
2989 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002990 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002991 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002992 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2993 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002994 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002995 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002996 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002997 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
2998 self.assertEqual(
2999 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
3000
3001 def test_git_cl_comments_robot_comments(self):
3002 # git cl comments also fetches robot comments (which are considered a type
3003 # of autogenerated comment), and unlike other types of comments, only robot
3004 # comments from the latest patchset are shown.
3005 self.mock(sys, 'stdout', StringIO.StringIO())
3006 self.calls = [
3007 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
3008 ((['git', 'config', 'branch.foo.merge'],), ''),
3009 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3010 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3011 'origin/master'),
3012 ((['git', 'config', 'remote.origin.url'],),
3013 'https://chromium.googlesource.com/infra/infra'),
3014 (('GetChangeDetail', 'chromium-review.googlesource.com',
3015 'infra%2Finfra~1',
3016 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
3017 'CURRENT_COMMIT']), {
3018 'owner': {'email': 'owner@example.com'},
3019 'current_revision': 'ba5eba11',
3020 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003021 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003022 '_number': 1,
3023 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003024 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003025 '_number': 2,
3026 },
3027 },
3028 'messages': [
3029 {
3030 u'_revision_number': 1,
3031 u'author': {
3032 u'_account_id': 1111084,
3033 u'email': u'commit-bot@chromium.org',
3034 u'name': u'Commit Bot'
3035 },
3036 u'date': u'2017-03-15 20:08:45.000000000',
3037 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
3038 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
3039 u'tag': u'autogenerated:cq:dry-run'
3040 },
3041 {
3042 u'_revision_number': 1,
3043 u'author': {
3044 u'_account_id': 123,
3045 u'email': u'tricium@serviceaccount.com',
3046 u'name': u'Tricium'
3047 },
3048 u'date': u'2017-03-16 20:00:41.000000000',
3049 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3050 u'message': u'(1 comment)',
3051 u'tag': u'autogenerated:tricium',
3052 },
3053 {
3054 u'_revision_number': 1,
3055 u'author': {
3056 u'_account_id': 123,
3057 u'email': u'tricium@serviceaccount.com',
3058 u'name': u'Tricium'
3059 },
3060 u'date': u'2017-03-16 20:00:41.000000000',
3061 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3062 u'message': u'(1 comment)',
3063 u'tag': u'autogenerated:tricium',
3064 },
3065 {
3066 u'_revision_number': 2,
3067 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003068 u'_account_id': 123,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003069 u'email': u'tricium@serviceaccount.com',
3070 u'name': u'reviewer'
3071 },
3072 u'date': u'2017-03-17 05:30:37.000000000',
3073 u'tag': u'autogenerated:tricium',
3074 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
3075 u'message': u'(1 comment)',
3076 },
3077 ]
3078 }),
3079 (('GetChangeComments', 'chromium-review.googlesource.com',
3080 'infra%2Finfra~1'), {}),
3081 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
3082 'infra%2Finfra~1'), {
3083 'codereview.settings': [
3084 {
3085 u'author': {u'email': u'tricium@serviceaccount.com'},
3086 u'updated': u'2017-03-17 05:30:37.000000000',
3087 u'robot_run_id': u'5565031076855808',
3088 u'robot_id': u'Linter/Category',
3089 u'tag': u'autogenerated:tricium',
3090 u'patch_set': 2,
3091 u'side': u'REVISION',
3092 u'message': u'Linter warning message text',
3093 u'line': 32,
3094 },
3095 ],
3096 }),
3097 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
3098 ]
3099 expected_comments_summary = [
3100 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
3101 message=(
3102 u'(1 comment)\n\ncodereview.settings\n'
3103 u' PS2, Line 32: https://chromium-review.googlesource.com/'
3104 u'c/1/2/codereview.settings#32\n'
3105 u' Linter warning message text\n'),
3106 sender=u'tricium@serviceaccount.com',
3107 autogenerated=True, approval=False, disapproval=False)
3108 ]
3109 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00003110 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003111 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003112
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003113 def test_get_remote_url_with_mirror(self):
3114 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003115
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003116 def selective_os_path_isdir_mock(path):
3117 if path == '/cache/this-dir-exists':
3118 return self._mocked_call('os.path.isdir', path)
3119 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003120
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003121 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3122
3123 url = 'https://chromium.googlesource.com/my/repo'
3124 self.calls = [
3125 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3126 ((['git', 'config', 'branch.master.merge'],), 'master'),
3127 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3128 ((['git', 'config', 'remote.origin.url'],),
3129 '/cache/this-dir-exists'),
3130 (('os.path.isdir', '/cache/this-dir-exists'),
3131 True),
3132 # Runs in /cache/this-dir-exists.
3133 ((['git', 'config', 'remote.origin.url'],),
3134 url),
3135 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003136 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003137 self.assertEqual(cl.GetRemoteUrl(), url)
3138 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3139
Edward Lemur298f2cf2019-02-22 21:40:39 +00003140 def test_get_remote_url_non_existing_mirror(self):
3141 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003142
Edward Lemur298f2cf2019-02-22 21:40:39 +00003143 def selective_os_path_isdir_mock(path):
3144 if path == '/cache/this-dir-doesnt-exist':
3145 return self._mocked_call('os.path.isdir', path)
3146 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003147
Edward Lemur298f2cf2019-02-22 21:40:39 +00003148 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3149 self.mock(logging, 'error',
3150 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
3151
3152 self.calls = [
3153 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3154 ((['git', 'config', 'branch.master.merge'],), 'master'),
3155 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3156 ((['git', 'config', 'remote.origin.url'],),
3157 '/cache/this-dir-doesnt-exist'),
3158 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3159 False),
3160 (('logging.error',
3161 'Remote "origin" for branch "/cache/this-dir-doesnt-exist" points to'
3162 ' "master", but it doesn\'t exist.'), None),
3163 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003164 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003165 self.assertIsNone(cl.GetRemoteUrl())
3166
3167 def test_get_remote_url_misconfigured_mirror(self):
3168 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003169
Edward Lemur298f2cf2019-02-22 21:40:39 +00003170 def selective_os_path_isdir_mock(path):
3171 if path == '/cache/this-dir-exists':
3172 return self._mocked_call('os.path.isdir', path)
3173 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003174
Edward Lemur298f2cf2019-02-22 21:40:39 +00003175 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3176 self.mock(logging, 'error',
3177 lambda *a: self._mocked_call('logging.error', *a))
3178
3179 self.calls = [
3180 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3181 ((['git', 'config', 'branch.master.merge'],), 'master'),
3182 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3183 ((['git', 'config', 'remote.origin.url'],),
3184 '/cache/this-dir-exists'),
3185 (('os.path.isdir', '/cache/this-dir-exists'), True),
3186 # Runs in /cache/this-dir-exists.
3187 ((['git', 'config', 'remote.origin.url'],), ''),
3188 (('logging.error',
3189 'Remote "%(remote)s" for branch "%(branch)s" points to '
3190 '"%(cache_path)s", but it is misconfigured.\n'
3191 '"%(cache_path)s" must be a git repo and must have a remote named '
3192 '"%(remote)s" pointing to the git host.', {
3193 'remote': 'origin',
3194 'cache_path': '/cache/this-dir-exists',
3195 'branch': 'master'}
3196 ), None),
3197 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003198 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003199 self.assertIsNone(cl.GetRemoteUrl())
3200
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003201 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003202 self.calls = [
3203 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3204 ((['git', 'config', 'branch.master.merge'],), 'master'),
3205 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3206 ((['git', 'config', 'remote.origin.url'],),
3207 'https://chromium.googlesource.com/a/my/repo.git/'),
3208 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003209 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003210 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3211
3212 def test_gerrit_change_identifier_without_project(self):
3213 self.calls = [
3214 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3215 ((['git', 'config', 'branch.master.merge'],), 'master'),
3216 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3217 ((['git', 'config', 'remote.origin.url'],), CERR1),
3218 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003219 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003220 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003221
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003222
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003223if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003224 logging.basicConfig(
3225 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003226 unittest.main()