blob: 84da763213ec4d0cad6f41b2847cc64058a62290 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01009import datetime
tandriide281ae2016-10-12 06:02:30 -070010import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010011import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000012import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
22
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000023import metrics
24# We have to disable monitoring before importing git_cl.
25metrics.DISABLE_METRICS_COLLECTION = True
26
Eric Boren2fb63102018-10-05 13:05:03 +000027import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000028import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000029import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000030import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
65 desc = ""
66 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
skobes6468b902016-10-24 08:45:10 -070086class GitCheckoutMock(object):
87 def __init__(self, *args, **kwargs):
88 pass
89
90 @staticmethod
91 def reset():
92 GitCheckoutMock.conflict = False
93
94 def apply_patch(self, p):
95 if GitCheckoutMock.conflict:
96 raise Exception('failed')
97
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000098
99class WatchlistsMock(object):
100 def __init__(self, _):
101 pass
102 @staticmethod
103 def GetWatchersForPaths(_):
104 return ['joe@example.com']
105
106
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000107class CodereviewSettingsFileMock(object):
108 def __init__(self):
109 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800110 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000111 def read(self):
112 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000113 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000114
115
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000116class AuthenticatorMock(object):
117 def __init__(self, *_args):
118 pass
119 def has_cached_credentials(self):
120 return True
tandrii221ab252016-10-06 08:12:04 -0700121 def authorize(self, http):
122 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000123
124
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100125def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
127
128 Usage:
129 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100130 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000131
132 OR
133 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100134 CookiesAuthenticatorMockFactory(
135 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000136 """
137 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800138 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139 # Intentionally not calling super() because it reads actual cookie files.
140 pass
141 @classmethod
142 def get_gitcookies_path(cls):
143 return '~/.gitcookies'
144 @classmethod
145 def get_netrc_path(cls):
146 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 def _get_auth_for_host(self, host):
148 if same_auth:
149 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000150 return (hosts_with_creds or {}).get(host)
151 return CookiesAuthenticatorMock
152
Aaron Gable9a03ae02017-11-03 11:31:07 -0700153
kmarshall9249e012016-08-23 12:02:16 -0700154class MockChangelistWithBranchAndIssue():
155 def __init__(self, branch, issue):
156 self.branch = branch
157 self.issue = issue
158 def GetBranch(self):
159 return self.branch
160 def GetIssue(self):
161 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162
tandriic2405f52016-10-10 08:13:15 -0700163
164class SystemExitMock(Exception):
165 pass
166
167
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000168class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100169 def test_get_description(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000170 cl = git_cl.Changelist(issue=1, codereview='gerrit',
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100171 codereview_host='host')
172 cl.description = 'x'
173 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800174 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100175 self.assertEquals(cl.GetDescription(), 'x')
176 self.assertEquals(cl.GetDescription(force=True), 'y')
177 self.assertEquals(cl.GetDescription(), 'y')
178
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700179 def test_description_footers(self):
180 cl = git_cl.Changelist(issue=1, codereview='gerrit',
181 codereview_host='host')
182 cl.description = '\n'.join([
183 'This is some message',
184 '',
185 'It has some lines',
186 'and, also',
187 '',
188 'Some: Really',
189 'Awesome: Footers',
190 ])
191 cl.has_description = True
192 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
193 msg, footers = cl.GetDescriptionFooters()
194 self.assertEquals(
195 msg, ['This is some message', '', 'It has some lines', 'and, also'])
196 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
197
198 msg.append('wut')
199 footers.append(('gnarly-dude', 'beans'))
200 cl.UpdateDescriptionFooters(msg, footers)
201 self.assertEquals(cl.GetDescription().splitlines(), [
202 'This is some message',
203 '',
204 'It has some lines',
205 'and, also',
206 'wut'
207 '',
208 'Some: Really',
209 'Awesome: Footers',
210 'Gnarly-Dude: beans',
211 ])
212
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000213 def test_set_preserve_tryjobs(self):
214 d = git_cl.ChangeDescription('Simple.')
215 d.set_preserve_tryjobs()
216 self.assertEqual(d.description.splitlines(), [
217 'Simple.',
218 '',
219 'Cq-Do-Not-Cancel-Tryjobs: true',
220 ])
221 before = d.description
222 d.set_preserve_tryjobs()
223 self.assertEqual(before, d.description)
224
225 d = git_cl.ChangeDescription('\n'.join([
226 'One is enough',
227 '',
228 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
229 'Change-Id: Ideadbeef',
230 ]))
231 d.set_preserve_tryjobs()
232 self.assertEqual(d.description.splitlines(), [
233 'One is enough',
234 '',
235 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
236 'Change-Id: Ideadbeef',
237 'Cq-Do-Not-Cancel-Tryjobs: true',
238 ])
239
240
tandriif9aefb72016-07-01 09:06:51 -0700241 def test_get_bug_line_values(self):
242 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
243 self.assertEqual(f('', ''), [])
244 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
245 self.assertEqual(f('v8', '456'), ['v8:456'])
246 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
247 # Not nice, but not worth carying.
248 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
249 ['v8:456', 'chromium:123', 'v8:123'])
250
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100251 def _test_git_number(self, parent_msg, dest_ref, child_msg,
252 parent_hash='parenthash'):
253 desc = git_cl.ChangeDescription(child_msg)
254 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
255 return desc.description
256
257 def assertEqualByLine(self, actual, expected):
258 self.assertEqual(actual.splitlines(), expected.splitlines())
259
260 def test_git_number_bad_parent(self):
261 with self.assertRaises(ValueError):
262 self._test_git_number('Parent', 'refs/heads/master', 'Child')
263
264 def test_git_number_bad_parent_footer(self):
265 with self.assertRaises(AssertionError):
266 self._test_git_number(
267 'Parent\n'
268 '\n'
269 'Cr-Commit-Position: wrong',
270 'refs/heads/master', 'Child')
271
272 def test_git_number_bad_lineage_ignored(self):
273 actual = self._test_git_number(
274 'Parent\n'
275 '\n'
276 'Cr-Commit-Position: refs/heads/master@{#1}\n'
277 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
278 'refs/heads/master', 'Child')
279 self.assertEqualByLine(
280 actual,
281 'Child\n'
282 '\n'
283 'Cr-Commit-Position: refs/heads/master@{#2}\n'
284 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
285
286 def test_git_number_same_branch(self):
287 actual = self._test_git_number(
288 'Parent\n'
289 '\n'
290 'Cr-Commit-Position: refs/heads/master@{#12}',
291 dest_ref='refs/heads/master',
292 child_msg='Child')
293 self.assertEqualByLine(
294 actual,
295 'Child\n'
296 '\n'
297 'Cr-Commit-Position: refs/heads/master@{#13}')
298
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200299 def test_git_number_same_branch_mixed_footers(self):
300 actual = self._test_git_number(
301 'Parent\n'
302 '\n'
303 'Cr-Commit-Position: refs/heads/master@{#12}',
304 dest_ref='refs/heads/master',
305 child_msg='Child\n'
306 '\n'
307 'Broken-by: design\n'
308 'BUG=123')
309 self.assertEqualByLine(
310 actual,
311 'Child\n'
312 '\n'
313 'Broken-by: design\n'
314 'BUG=123\n'
315 'Cr-Commit-Position: refs/heads/master@{#13}')
316
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100317 def test_git_number_same_branch_with_originals(self):
318 actual = self._test_git_number(
319 'Parent\n'
320 '\n'
321 'Cr-Commit-Position: refs/heads/master@{#12}',
322 dest_ref='refs/heads/master',
323 child_msg='Child\n'
324 '\n'
325 'Some users are smart and insert their own footers\n'
326 '\n'
327 'Cr-Whatever: value\n'
328 'Cr-Commit-Position: refs/copy/paste@{#22}')
329 self.assertEqualByLine(
330 actual,
331 'Child\n'
332 '\n'
333 'Some users are smart and insert their own footers\n'
334 '\n'
335 'Cr-Original-Whatever: value\n'
336 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
337 'Cr-Commit-Position: refs/heads/master@{#13}')
338
339 def test_git_number_new_branch(self):
340 actual = self._test_git_number(
341 'Parent\n'
342 '\n'
343 'Cr-Commit-Position: refs/heads/master@{#12}',
344 dest_ref='refs/heads/branch',
345 child_msg='Child')
346 self.assertEqualByLine(
347 actual,
348 'Child\n'
349 '\n'
350 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
351 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
352
353 def test_git_number_lineage(self):
354 actual = self._test_git_number(
355 'Parent\n'
356 '\n'
357 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
358 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
359 dest_ref='refs/heads/branch',
360 child_msg='Child')
361 self.assertEqualByLine(
362 actual,
363 'Child\n'
364 '\n'
365 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
366 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
367
368 def test_git_number_moooooooore_lineage(self):
369 actual = self._test_git_number(
370 'Parent\n'
371 '\n'
372 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
373 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
374 dest_ref='refs/heads/mooore',
375 child_msg='Child')
376 self.assertEqualByLine(
377 actual,
378 'Child\n'
379 '\n'
380 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
381 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
382 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
383
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100384 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700385 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100386 actual = self._test_git_number(
387 'CQ commit on fresh new branch + numbering.\n'
388 '\n'
389 'NOTRY=True\n'
390 'NOPRESUBMIT=True\n'
391 'BUG=\n'
392 '\n'
393 'Review-Url: https://codereview.chromium.org/2577703003\n'
394 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
395 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
396 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
397 dest_ref='refs/heads/gnumb-test/cl',
398 child_msg='git cl on fresh new branch + numbering.\n'
399 '\n'
400 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
401 self.assertEqualByLine(
402 actual,
403 'git cl on fresh new branch + numbering.\n'
404 '\n'
405 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
406 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
407 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
408 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
409 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100410
411 def test_git_number_cherry_pick(self):
412 actual = self._test_git_number(
413 'Parent\n'
414 '\n'
415 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
416 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
417 dest_ref='refs/heads/branch',
418 child_msg='Child, which is cherry-pick from master\n'
419 '\n'
420 'Cr-Commit-Position: refs/heads/master@{#100}\n'
421 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
422 self.assertEqualByLine(
423 actual,
424 'Child, which is cherry-pick from master\n'
425 '\n'
426 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
427 '\n'
428 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
429 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
430 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
431
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000432 def test_gerrit_mirror_hack(self):
433 cr = 'chromium-review.googlesource.com'
434 url0 = 'https://%s/a/changes/x?a=b' % cr
435 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
436 try:
437 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
438 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
439 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
440 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
441
442 self.assertNotEqual(url1, url2)
443 self.assertEqual(sorted((url1, url2)), [
444 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
445 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
446 self.assertEqual(url1, url3)
447 finally:
448 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
449
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000450 def test_valid_accounts(self):
451 mock_per_account = {
452 'u1': None, # 404, doesn't exist.
453 'u2': {
454 '_account_id': 123124,
455 'avatars': [],
456 'email': 'u2@example.com',
457 'name': 'User Number 2',
458 'status': 'OOO',
459 },
460 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
461 }
462 def GetAccountDetailsMock(_, account):
463 # Poor-man's mock library's side_effect.
464 v = mock_per_account.pop(account)
465 if isinstance(v, Exception):
466 raise v
467 return v
468
469 original = git_cl.gerrit_util.GetAccountDetails
470 try:
471 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
472 actual = git_cl.gerrit_util.ValidAccounts(
473 'host', ['u1', 'u2', 'u3'], max_threads=1)
474 finally:
475 git_cl.gerrit_util.GetAccountDetails = original
476 self.assertEqual(actual, {
477 'u2': {
478 '_account_id': 123124,
479 'avatars': [],
480 'email': 'u2@example.com',
481 'name': 'User Number 2',
482 'status': 'OOO',
483 },
484 })
485
486
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000487
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200488class TestParseIssueURL(unittest.TestCase):
489 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
490 codereview=None, fail=False):
491 self.assertIsNotNone(parsed)
492 if fail:
493 self.assertFalse(parsed.valid)
494 return
495 self.assertTrue(parsed.valid)
496 self.assertEqual(parsed.issue, issue)
497 self.assertEqual(parsed.patchset, patchset)
498 self.assertEqual(parsed.hostname, hostname)
499 self.assertEqual(parsed.codereview, codereview)
500
501 def _run_and_validate(self, func, url, *args, **kwargs):
502 result = func(urlparse.urlparse(url))
503 if kwargs.pop('fail', False):
504 self.assertIsNone(result)
505 return None
506 self._validate(result, *args, fail=False, **kwargs)
507
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200508 def test_gerrit(self):
509 def test(url, issue=None, patchset=None, hostname=None, fail=None):
510 self._test_ParseIssueUrl(
511 git_cl._GerritChangelistImpl.ParseIssueURL,
512 url, issue, patchset, hostname, fail)
513 def test(url, *args, **kwargs):
514 self._run_and_validate(git_cl._GerritChangelistImpl.ParseIssueURL, url,
515 *args, codereview='gerrit', **kwargs)
516
517 test('http://chrome-review.source.com/c/123',
518 123, None, 'chrome-review.source.com')
519 test('https://chrome-review.source.com/c/123/',
520 123, None, 'chrome-review.source.com')
521 test('https://chrome-review.source.com/c/123/4',
522 123, 4, 'chrome-review.source.com')
523 test('https://chrome-review.source.com/#/c/123/4',
524 123, 4, 'chrome-review.source.com')
525 test('https://chrome-review.source.com/c/123/4',
526 123, 4, 'chrome-review.source.com')
527 test('https://chrome-review.source.com/123',
528 123, None, 'chrome-review.source.com')
529 test('https://chrome-review.source.com/123/4',
530 123, 4, 'chrome-review.source.com')
531
532 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
533 test('https://chrome-review.source.com/c/abc/', fail=True)
534 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
535
536 def test_ParseIssueNumberArgument(self):
537 def test(arg, *args, **kwargs):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200538 codereview_hint = kwargs.pop('hint', None)
539 self._validate(git_cl.ParseIssueNumberArgument(arg, codereview_hint),
540 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200541
542 test('123', 123)
543 test('', fail=True)
544 test('abc', fail=True)
545 test('123/1', fail=True)
546 test('123a', fail=True)
547 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000548
549 # Looks like Rietveld and Gerrit, but we should select Gerrit now
550 # w/ or w/o hint.
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200551 test('https://codereview.source.com/123',
552 123, None, 'codereview.source.com', 'gerrit',
553 hint='gerrit')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000554 test('https://codereview.source.com/123',
555 123, None, 'codereview.source.com', 'gerrit')
556
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200557 # Gerrrit.
558 test('https://chrome-review.source.com/c/123/4',
559 123, 4, 'chrome-review.source.com', 'gerrit')
560 test('https://chrome-review.source.com/bad/123/4', fail=True)
561
562
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100563class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100564 def setUp(self):
565 super(GitCookiesCheckerTest, self).setUp()
566 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100567 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100568
569 def mock_hosts_creds(self, subhost_identity_pairs):
570 def ensure_googlesource(h):
571 if not h.endswith(self.c._GOOGLESOURCE):
572 assert not h.endswith('.')
573 return h + '.' + self.c._GOOGLESOURCE
574 return h
575 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
576 for h, i in subhost_identity_pairs]
577
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200578 def test_identity_parsing(self):
579 self.assertEqual(self.c._parse_identity('ldap.google.com'),
580 ('ldap', 'google.com'))
581 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
582 ('ldap', 'example.com'))
583 # Specical case because we know there are no subdomains in chromium.org.
584 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
585 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800586 # Pathological: ".period." can be either username OR domain, more likely
587 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200588 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
589 ('note', 'period.example.com'))
590
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100591 def test_analysis_nothing(self):
592 self.c._all_hosts = []
593 self.assertFalse(self.c.has_generic_host())
594 self.assertEqual(set(), self.c.get_conflicting_hosts())
595 self.assertEqual(set(), self.c.get_duplicated_hosts())
596 self.assertEqual(set(), self.c.get_partially_configured_hosts())
597 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
598
599 def test_analysis(self):
600 self.mock_hosts_creds([
601 ('.googlesource.com', 'git-example.chromium.org'),
602
603 ('chromium', 'git-example.google.com'),
604 ('chromium-review', 'git-example.google.com'),
605 ('chrome-internal', 'git-example.chromium.org'),
606 ('chrome-internal-review', 'git-example.chromium.org'),
607 ('conflict', 'git-example.google.com'),
608 ('conflict-review', 'git-example.chromium.org'),
609 ('dup', 'git-example.google.com'),
610 ('dup', 'git-example.google.com'),
611 ('dup-review', 'git-example.google.com'),
612 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200613 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100614 ])
615 self.assertTrue(self.c.has_generic_host())
616 self.assertEqual(set(['conflict.googlesource.com']),
617 self.c.get_conflicting_hosts())
618 self.assertEqual(set(['dup.googlesource.com']),
619 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200620 self.assertEqual(set(['partial.googlesource.com',
621 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100622 self.c.get_partially_configured_hosts())
623 self.assertEqual(set(['chromium.googlesource.com',
624 'chrome-internal.googlesource.com']),
625 self.c.get_hosts_with_wrong_identities())
626
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100627 def test_report_no_problems(self):
628 self.test_analysis_nothing()
629 self.mock(sys, 'stdout', StringIO.StringIO())
630 self.assertFalse(self.c.find_and_report_problems())
631 self.assertEqual(sys.stdout.getvalue(), '')
632
633 def test_report(self):
634 self.test_analysis()
635 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200636 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
637 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100638 self.assertTrue(self.c.find_and_report_problems())
639 with open(os.path.join(os.path.dirname(__file__),
640 'git_cl_creds_check_report.txt')) as f:
641 expected = f.read()
642 def by_line(text):
643 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700644 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200645 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100646
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800647
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000648class TestGitCl(TestCase):
649 def setUp(self):
650 super(TestGitCl, self).setUp()
651 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700652 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000653 self.mock(git_cl, 'time_time',
654 lambda: self._mocked_call('time.time'))
655 self.mock(git_cl.metrics.collector, 'add_repeated',
656 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000657 self.mock(subprocess2, 'call', self._mocked_call)
658 self.mock(subprocess2, 'check_call', self._mocked_call)
659 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700660 self.mock(subprocess2, 'communicate',
661 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000662 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000663 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000664 self.mock(git_common, 'get_or_create_merge_base',
665 lambda *a: (
666 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000667 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000668 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000669 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
670 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100671 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000672 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700673 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000674 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000675 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
skobes6468b902016-10-24 08:45:10 -0700676 self.mock(git_cl.checkout, 'GitCheckout', GitCheckoutMock)
677 GitCheckoutMock.reset()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000678 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000679 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100680 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
681 lambda *args, **kwargs: self._mocked_call(
682 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700683 self.mock(git_cl.gerrit_util, 'GetChangeComments',
684 lambda *args, **kwargs: self._mocked_call(
685 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000686 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
687 lambda *args, **kwargs: self._mocked_call(
688 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100689 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700690 lambda h, i, reviewers, ccs, notify: self._mocked_call(
691 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700692 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700693 lambda h, i, msg=None, labels=None, notify=None:
694 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700695 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
696 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000697 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
698 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000699 self.mock(git_cl.gerrit_util, 'ValidAccounts',
700 lambda host, accounts:
701 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700702 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100703 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000704 # It's important to reset settings to not have inter-tests interference.
705 git_cl.settings = None
706
707 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000708 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100709 self.assertEquals([], self.calls)
710 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000711 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100712 raise
713 # Sadly, has_failed() returns True if this OR any other tests before this
714 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200715 git_cl.logging.error(
716 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100717 'There are un-consumed self.calls after this test has finished.\n'
718 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700719 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200720 'If you are already running only this test, then **first** fix the '
721 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100722 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700723 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100724 'and follow instructions above.\n' +
725 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000726 finally:
727 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000728
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000729 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000730 self.assertTrue(
731 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700732 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000733 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000734 expected_args, result = top
735
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000736 # Also logs otherwise it could get caught in a try/finally and be hard to
737 # diagnose.
738 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700739 N = 5
740 prior_calls = '\n '.join(
741 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
742 for i, c in enumerate(self._calls_done[-N:]))
743 following_calls = '\n '.join(
744 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
745 for i, c in enumerate(self.calls[:N]))
746 extended_msg = (
747 'A few prior calls:\n %s\n\n'
748 'This (expected):\n @%d: %r\n'
749 'This (actual):\n @%d: %r\n\n'
750 'A few following expected calls:\n %s' %
751 (prior_calls, len(self._calls_done), expected_args,
752 len(self._calls_done), args, following_calls))
753 git_cl.logging.error(extended_msg)
754
tandrii99a72f22016-08-17 14:33:24 -0700755 self.fail('@%d\n'
756 ' Expected: %r\n'
757 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700758 len(self._calls_done), expected_args, args))
759
760 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700761 if isinstance(result, Exception):
762 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000763 return result
764
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100765 def test_ask_for_explicit_yes_true(self):
766 self.calls = [
767 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
768 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
769 ]
770 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
771
tandrii48df5812016-10-17 03:55:37 -0700772 def test_LoadCodereviewSettingsFromFile_gerrit(self):
773 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
774 self.calls = [
775 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700776 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
777 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
778 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
779 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700780 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
781 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700782 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
783 CERR1),
784 ((['git', 'config', 'gerrit.host', 'true'],), ''),
785 ]
786 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
787
maruel@chromium.orga3353652011-11-30 14:26:57 +0000788 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000789 def _is_gerrit_calls(cls, gerrit=False):
790 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
791 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
792
793 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000794 def _git_post_upload_calls(cls):
795 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000796 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
797 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
798 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000799 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000800 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000801 ]
802
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000803 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000804 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000805 fake_ancestor = 'fake_ancestor'
806 fake_cl = 'fake_cl_for_patch'
807 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000808 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000809 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000810 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000811 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000812 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000813 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000814 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000815 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700816 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000817 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000818 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000819 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000820 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000821 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000822 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000823 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000824 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000825 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000826 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000827 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000828
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000829 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000830 def _gerrit_ensure_auth_calls(
831 cls, issue=None, skip_auth_check=False, short_hostname='chromium'):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000832 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000833 if skip_auth_check:
834 return [((cmd, ), 'true')]
835
tandrii5d48c322016-08-18 16:19:37 -0700836 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000837 calls.extend([
838 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
839 ((['git', 'config', 'branch.master.remote'],), 'origin'),
840 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000841 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000842 ])
Daniel Chengcf6269b2019-05-18 01:02:12 +0000843 if issue:
844 calls.extend([
845 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
846 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000847 return calls
848
849 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100850 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200851 fetched_status=None, other_cl_owner=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000852 custom_cl_base=None, short_hostname='chromium'):
Aaron Gable13101a62018-02-09 13:20:41 -0800853 calls = cls._is_gerrit_calls(True)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100854 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200855 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200856 ((['git', 'config', 'branch.master.gerritissue'],),
857 CERR1 if issue is None else str(issue)),
858 ]
859
860 if custom_cl_base:
861 ancestor_revision = custom_cl_base
862 else:
863 # Determine ancestor_revision to be merge base.
864 ancestor_revision = 'fake_ancestor_sha'
865 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000866 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000867 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000868 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200869 'refs/remotes/origin/master'],), ancestor_revision),
870 ]
871
872 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000873 calls += cls._gerrit_ensure_auth_calls(
874 issue=issue, short_hostname=short_hostname)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100875
876 if issue:
877 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000878 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000879 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000880 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
881 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100882 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100883 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100884 'change_id': '123456789',
885 'current_revision': 'sha1_of_current_revision',
886 'revisions': { 'sha1_of_current_revision': {
887 'commit': {'message': fetched_description},
888 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100889 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100890 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100891 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100892 if fetched_status == 'ABANDONED':
893 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000894 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100895 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000896 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100897 ]
898 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100899 if other_cl_owner:
900 calls += [
901 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
902 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100903
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200904 calls += cls._git_sanity_checks(ancestor_revision, 'master',
905 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100906 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200907 ((['git', 'rev-parse', '--show-cdup'],), ''),
908 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000909
Aaron Gable7817f022017-12-12 09:43:17 -0800910 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
911 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200912 'M\t.gitignore\n'),
913 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100914 ]
915
916 if not issue:
917 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200918 ((['git', 'log', '--pretty=format:%s%n%n%b',
919 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000920 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100921 ]
922
923 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200924 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000925 (('time.time',), 1000,),
926 (('time.time',), 3000,),
927 (('add_repeated', 'sub_commands', {
928 'execution_time': 2000,
929 'command': 'presubmit',
930 'exit_code': 0
931 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200932 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
933 ([custom_cl_base] if custom_cl_base else
934 [ancestor_revision, 'HEAD']),),
935 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100936 ]
937 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000938
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000939 @classmethod
940 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700941 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000942 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700943 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100944 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000945 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000946 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000947 labels=None, change_id=None, original_title=None,
948 final_description=None, gitcookies_exists=True):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000949 if post_amend_description is None:
950 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700951 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200952 # Determined in `_gerrit_base_calls`.
953 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
954
955 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000956
tandriia60502f2016-06-20 02:01:53 -0700957 if squash_mode == 'default':
958 calls.extend([
959 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
960 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
961 ])
962 elif squash_mode in ('override_squash', 'override_nosquash'):
963 calls.extend([
964 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
965 'true' if squash_mode == 'override_squash' else 'false'),
966 ])
967 else:
968 assert squash_mode in ('squash', 'nosquash')
969
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000970 # If issue is given, then description is fetched from Gerrit instead.
971 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000972 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200973 ((['git', 'log', '--pretty=format:%s\n\n%b',
974 ((custom_cl_base + '..') if custom_cl_base else
975 'fake_ancestor_sha..HEAD')],),
976 description),
977 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800978 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000979 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800980 else:
981 if not title:
982 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200983 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
984 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800985 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000986 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000987 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000988 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200989 (('DownloadGerritHook', False), ''),
990 # Amending of commit message to get the Change-Id.
991 ((['git', 'log', '--pretty=format:%s\n\n%b',
992 determined_ancestor_revision + '..HEAD'],),
993 description),
994 ((['git', 'commit', '--amend', '-m', description],), ''),
995 ((['git', 'log', '--pretty=format:%s\n\n%b',
996 determined_ancestor_revision + '..HEAD'],),
997 post_amend_description)
998 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000999 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001000 if not issue:
1001 # Prompting to edit description on first upload.
1002 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +00001003 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001004 ((['git', 'config', 'core.editor'],), ''),
1005 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001006 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001007 ref_to_push = 'abcdef0123456789'
1008 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001009 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1010 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1011 ]
1012
1013 if custom_cl_base is None:
1014 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001015 ((['get_or_create_merge_base', 'master',
1016 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001017 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001018 ]
1019 parent = 'origin/master'
1020 else:
1021 calls += [
1022 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
1023 'refs/remotes/origin/master'],),
1024 callError(1)), # Means not ancenstor.
1025 (('ask_for_data',
1026 'Do you take responsibility for cleaning up potential mess '
1027 'resulting from proceeding with upload? Press Enter to upload, '
1028 'or Ctrl+C to abort'), ''),
1029 ]
1030 parent = custom_cl_base
1031
1032 calls += [
1033 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
1034 '0123456789abcdef'),
1035 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001036 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001037 ref_to_push),
1038 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001039 else:
1040 ref_to_push = 'HEAD'
1041
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001042 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001043 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001044 ((['git', 'rev-list',
1045 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1046 ref_to_push],),
1047 '1hashPerLine\n'),
1048 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001049
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001050 metrics_arguments = []
1051
Aaron Gableafd52772017-06-27 16:40:10 -07001052 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001053 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001054 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001055 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001056 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001057 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001058 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001059 else:
1060 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001061 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001062
Aaron Gable70f4e242017-06-26 10:45:59 -07001063 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001064 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001065 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001066
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001067 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001068 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001069 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001070 if short_hostname == 'chromium':
1071 # All reviwers and ccs get into ref_suffix.
1072 for r in sorted(reviewers):
1073 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001074 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001075 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1076 'joe@example.com'] + cc):
1077 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001078 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001079 reviewers, cc = [], []
1080 else:
1081 # TODO(crbug/877717): remove this case.
1082 calls += [
1083 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1084 sorted(reviewers) + ['joe@example.com',
1085 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1086 {
1087 e: {'email': e}
1088 for e in (reviewers + ['joe@example.com'] + cc)
1089 })
1090 ]
1091 for r in sorted(reviewers):
1092 if r != 'bad-account-or-email':
1093 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001094 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001095 reviewers.remove(r)
1096 for c in sorted(['joe@example.com'] + cc):
1097 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001098 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001099 if c in cc:
1100 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001101
Edward Lemur687ca902018-12-05 02:30:30 +00001102 for k, v in sorted((labels or {}).items()):
1103 ref_suffix += ',l=%s+%d' % (k, v)
1104 metrics_arguments.append('l=%s+%d' % (k, v))
1105
1106 if tbr:
1107 calls += [
1108 (('GetCodeReviewTbrScore',
1109 '%s-review.googlesource.com' % short_hostname,
1110 'my/repo'),
1111 2,),
1112 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001113
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001114 calls += [
1115 (('time.time',), 1000,),
1116 ((['git', 'push',
1117 'https://%s.googlesource.com/my/repo' % short_hostname,
1118 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1119 (('remote:\n'
1120 'remote: Processing changes: (\)\n'
1121 'remote: Processing changes: (|)\n'
1122 'remote: Processing changes: (/)\n'
1123 'remote: Processing changes: (-)\n'
1124 'remote: Processing changes: new: 1 (/)\n'
1125 'remote: Processing changes: new: 1, done\n'
1126 'remote:\n'
1127 'remote: New Changes:\n'
1128 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1129 ' XXX\n'
1130 'remote:\n'
1131 'To https://%s.googlesource.com/my/repo\n'
1132 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1133 ) % (short_hostname, short_hostname)),),
1134 (('time.time',), 2000,),
1135 (('add_repeated',
1136 'sub_commands',
1137 {
1138 'execution_time': 1000,
1139 'command': 'git push',
1140 'exit_code': 0,
1141 'arguments': sorted(metrics_arguments),
1142 }),
1143 None,),
1144 ]
1145
Edward Lemur1b52d872019-05-09 21:12:12 +00001146 final_description = final_description or post_amend_description.strip()
1147 original_title = original_title or title or '<untitled>'
1148 # Trace-related calls
1149 calls += [
1150 # Write a description with context for the current trace.
1151 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001152 'Thu Mar 16 20:00:41 2017\n'
1153 '%(short_hostname)s-review.googlesource.com\n'
1154 '%(change_id)s\n'
1155 '%(title)s\n'
1156 '%(description)s\n'
1157 '1000\n'
1158 '0\n'
1159 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001160 'short_hostname': short_hostname,
1161 'change_id': change_id,
1162 'description': final_description,
1163 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001164 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001165 }],),
1166 None,
1167 ),
1168 # Read traces and shorten git hashes.
1169 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1170 True,
1171 ),
1172 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1173 ('git-hash: 0123456789012345678901234567890123456789\n'
1174 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1175 ),
1176 ((['FileWrite', 'TEMP_DIR/trace-packet',
1177 'git-hash: 012345\n'
1178 'git-hash: abcdea\n'],),
1179 None,
1180 ),
1181 # Make zip file for the git traces.
1182 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1183 'TEMP_DIR'],),
1184 None,
1185 ),
1186 # Collect git config and gitcookies.
1187 ((['git', 'config', '-l'],),
1188 'git-config-output',
1189 ),
1190 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1191 None,
1192 ),
1193 ((['os.path.isfile', '~/.gitcookies'],),
1194 gitcookies_exists,
1195 ),
1196 ]
1197 if gitcookies_exists:
1198 calls += [
1199 ((['FileRead', '~/.gitcookies'],),
1200 'gitcookies 1/SECRET',
1201 ),
1202 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1203 None,
1204 ),
1205 ]
1206 calls += [
1207 # Make zip file for the git config and gitcookies.
1208 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1209 'TEMP_DIR'],),
1210 None,
1211 ),
1212 ]
1213
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001214 if squash:
1215 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001216 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001217 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001218 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001219 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001220 ((['git', 'config', 'branch.master.gerritsquashhash',
1221 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001222 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001223 # TODO(crbug/877717): this should never be used.
1224 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001225 calls += [
1226 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001227 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001228 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001229 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1230 notify),
1231 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001232 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001233 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001234 return calls
1235
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001236 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001237 self,
1238 upload_args,
1239 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001240 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001241 squash=True,
1242 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001243 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001244 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001245 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001246 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001247 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001248 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001249 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001250 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001251 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001252 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001253 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001254 labels=None,
1255 change_id=None,
1256 original_title=None,
1257 final_description=None,
1258 gitcookies_exists=True):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001259 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001260 if squash_mode is None:
1261 if '--no-squash' in upload_args:
1262 squash_mode = 'nosquash'
1263 elif '--squash' in upload_args:
1264 squash_mode = 'squash'
1265 else:
1266 squash_mode = 'default'
1267
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001268 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001269 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001270 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001271 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001272 CookiesAuthenticatorMockFactory(
1273 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001274 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1275 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001276 self.mock(git_cl.gclient_utils, 'RunEditor',
1277 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001278 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1279 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001280 self.mock(git_cl.gclient_utils, 'FileRead',
1281 lambda path: self._mocked_call(['FileRead', path]))
1282 self.mock(git_cl.gclient_utils, 'FileWrite',
1283 lambda path, contents: self._mocked_call(
1284 ['FileWrite', path, contents]))
1285 self.mock(git_cl, 'datetime_now',
1286 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1287 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1288 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
Edward Lemur75391d42019-05-14 23:35:56 +00001289 self.mock(git_cl, 'TRACES_README_FORMAT',
1290 '%(now)s\n'
1291 '%(gerrit_host)s\n'
1292 '%(change_id)s\n'
1293 '%(title)s\n'
1294 '%(description)s\n'
1295 '%(execution_time)s\n'
1296 '%(exit_code)s\n'
1297 '%(trace_name)s')
Edward Lemur1b52d872019-05-09 21:12:12 +00001298 self.mock(git_cl.shutil, 'make_archive',
1299 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1300 self.mock(os.path, 'isfile',
1301 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001302
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001303 self.calls = self._gerrit_base_calls(
1304 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001305 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001306 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001307 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001308 custom_cl_base=custom_cl_base,
1309 short_hostname=short_hostname)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001310 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001311 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1312 expected_content=description))
1313 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001314 self.calls += self._gerrit_upload_calls(
1315 description, reviewers, squash,
1316 squash_mode=squash_mode,
1317 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001318 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001319 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001320 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001321 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001322 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001323 labels=labels,
1324 change_id=change_id,
1325 original_title=original_title,
1326 final_description=final_description,
1327 gitcookies_exists=gitcookies_exists)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001328 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001329 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001330 git_cl.main(['upload'] + upload_args)
1331
Edward Lemur1b52d872019-05-09 21:12:12 +00001332 def test_gerrit_upload_traces_no_gitcookies(self):
1333 self._run_gerrit_upload_test(
1334 ['--no-squash'],
1335 'desc\n\nBUG=\n',
1336 [],
1337 squash=False,
1338 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1339 change_id='Ixxx',
1340 gitcookies_exists=False)
1341
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001342 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001343 self._run_gerrit_upload_test(
1344 ['--no-squash'],
1345 'desc\n\nBUG=\n',
1346 [],
1347 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001348 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1349 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001350
1351 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001352 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001353 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001354 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001355 [],
tandriia60502f2016-06-20 02:01:53 -07001356 squash=False,
1357 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001358 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1359 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001360
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001361 def test_gerrit_no_reviewer(self):
1362 self._run_gerrit_upload_test(
1363 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001364 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001365 [],
1366 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001367 squash_mode='override_nosquash',
1368 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001369
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001370 def test_gerrit_no_reviewer_non_chromium_host(self):
1371 # TODO(crbug/877717): remove this test case.
1372 self._run_gerrit_upload_test(
1373 [],
1374 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1375 [],
1376 squash=False,
1377 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001378 short_hostname='other',
1379 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001380
Nick Carter8692b182017-11-06 16:30:38 -08001381 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001382 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1383 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001384 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001385 'desc\n\nBUG=\n\nChange-Id: I123456789',
1386 squash=False,
1387 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001388 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1389 change_id='I123456789',
1390 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001391
ukai@chromium.orge8077812012-02-03 03:41:46 +00001392 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001393 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001394 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001395 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001396 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001397 squash=False,
1398 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001399 notify=True,
1400 change_id='I123456789',
1401 final_description=
1402 'desc\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001403
1404 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001405 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1406 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001407 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001408 [],
bradnelsond975b302016-10-23 12:20:23 -07001409 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1410 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001411 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001412 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001413 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001414 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001415 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001416 labels={'Code-Review': 2},
1417 change_id='123456789',
1418 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001419
1420 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001421 self._run_gerrit_upload_test(
1422 [],
1423 'desc\nBUG=\n\nChange-Id: 123456789',
1424 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001425 expected_upstream_ref='origin/master',
1426 change_id='123456789',
1427 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001428
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001429 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001430 self._run_gerrit_upload_test(
1431 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001432 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001433 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001434 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001435 expected_upstream_ref='origin/master',
1436 change_id='123456789',
1437 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001438
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001439 def test_gerrit_upload_squash_first_with_labels(self):
1440 self._run_gerrit_upload_test(
1441 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1442 'desc\nBUG=\n\nChange-Id: 123456789',
1443 [],
1444 squash=True,
1445 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001446 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1447 change_id='123456789',
1448 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001449
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001450 def test_gerrit_upload_squash_first_against_rev(self):
1451 custom_cl_base = 'custom_cl_base_rev_or_branch'
1452 self._run_gerrit_upload_test(
1453 ['--squash', custom_cl_base],
1454 'desc\nBUG=\n\nChange-Id: 123456789',
1455 [],
1456 squash=True,
1457 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001458 custom_cl_base=custom_cl_base,
1459 change_id='123456789',
1460 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001461 self.assertIn(
1462 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1463 sys.stdout.getvalue())
1464
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001465 def test_gerrit_upload_squash_reupload(self):
1466 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001467 self._run_gerrit_upload_test(
1468 ['--squash'],
1469 description,
1470 [],
1471 squash=True,
1472 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001473 issue=123456,
1474 change_id='123456789',
1475 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001476
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001477 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1478 self.mock(git_cl, 'DieWithError',
1479 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1480 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1481 with self.assertRaises(SystemExitMock):
1482 self._run_gerrit_upload_test(
1483 ['--squash'],
1484 description,
1485 [],
1486 squash=True,
1487 expected_upstream_ref='origin/master',
1488 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001489 fetched_status='ABANDONED',
1490 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001491
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001492 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1493 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1494 lambda *_, **__: {'email': 'yet-another@example.com'})
1495 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1496 self._run_gerrit_upload_test(
1497 ['--squash'],
1498 description,
1499 [],
1500 squash=True,
1501 expected_upstream_ref='origin/master',
1502 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001503 other_cl_owner='other@example.com',
1504 change_id='123456789',
1505 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001506 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001507 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001508 'authenticate to Gerrit as yet-another@example.com.\n'
1509 'Uploading may fail due to lack of permissions',
1510 git_cl.sys.stdout.getvalue())
1511
rmistry@google.com2dd99862015-06-22 12:22:18 +00001512 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001513 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001514 def mock_run_git(*args, **_kwargs):
1515 if args[0] == ['for-each-ref',
1516 '--format=%(refname:short) %(upstream:short)',
1517 'refs/heads']:
1518 # Create a local branch dependency tree that looks like this:
1519 # test1 -> test2 -> test3 -> test4 -> test5
1520 # -> test3.1
1521 # test6 -> test0
1522 branch_deps = [
1523 'test2 test1', # test1 -> test2
1524 'test3 test2', # test2 -> test3
1525 'test3.1 test2', # test2 -> test3.1
1526 'test4 test3', # test3 -> test4
1527 'test5 test4', # test4 -> test5
1528 'test6 test0', # test0 -> test6
1529 'test7', # test7
1530 ]
1531 return '\n'.join(branch_deps)
1532 self.mock(git_cl, 'RunGit', mock_run_git)
1533
1534 class RecordCalls:
1535 times_called = 0
1536 record_calls = RecordCalls()
1537 def mock_CMDupload(*args, **_kwargs):
1538 record_calls.times_called += 1
1539 return 0
1540 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1541
1542 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001543 (('ask_for_data', 'This command will checkout all dependent branches '
1544 'and run "git cl upload". Press Enter to continue, '
1545 'or Ctrl+C to abort'), ''),
1546 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001547
1548 class MockChangelist():
1549 def __init__(self):
1550 pass
1551 def GetBranch(self):
1552 return 'test1'
1553 def GetIssue(self):
1554 return '123'
1555 def GetPatchset(self):
1556 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001557 def IsGerrit(self):
1558 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001559
1560 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1561 # CMDupload should have been called 5 times because of 5 dependent branches.
1562 self.assertEquals(5, record_calls.times_called)
1563 self.assertEquals(0, ret)
1564
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001565 def test_gerrit_change_id(self):
1566 self.calls = [
1567 ((['git', 'write-tree'], ),
1568 'hashtree'),
1569 ((['git', 'rev-parse', 'HEAD~0'], ),
1570 'branch-parent'),
1571 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1572 'A B <a@b.org> 1456848326 +0100'),
1573 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1574 'C D <c@d.org> 1456858326 +0100'),
1575 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1576 'hashchange'),
1577 ]
1578 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1579 self.assertEqual(change_id, 'Ihashchange')
1580
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001581 def test_desecription_append_footer(self):
1582 for init_desc, footer_line, expected_desc in [
1583 # Use unique desc first lines for easy test failure identification.
1584 ('foo', 'R=one', 'foo\n\nR=one'),
1585 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1586 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1587 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1588 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1589 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1590 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1591 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1592 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1593 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1594 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1595 ]:
1596 desc = git_cl.ChangeDescription(init_desc)
1597 desc.append_footer(footer_line)
1598 self.assertEqual(desc.description, expected_desc)
1599
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001600 def test_update_reviewers(self):
1601 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001602 ('foo', [], [],
1603 'foo'),
1604 ('foo\nR=xx', [], [],
1605 'foo\nR=xx'),
1606 ('foo\nTBR=xx', [], [],
1607 'foo\nTBR=xx'),
1608 ('foo', ['a@c'], [],
1609 'foo\n\nR=a@c'),
1610 ('foo\nR=xx', ['a@c'], [],
1611 'foo\n\nR=a@c, xx'),
1612 ('foo\nTBR=xx', ['a@c'], [],
1613 'foo\n\nR=a@c\nTBR=xx'),
1614 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1615 'foo\n\nR=a@c, yy\nTBR=xx'),
1616 ('foo\nBUG=', ['a@c'], [],
1617 'foo\nBUG=\nR=a@c'),
1618 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1619 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1620 ('foo', ['a@c', 'b@c'], [],
1621 'foo\n\nR=a@c, b@c'),
1622 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1623 'foo\nBar\n\nR=c@c\nBUG='),
1624 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1625 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001626 # Same as the line before, but full of whitespaces.
1627 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001628 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001629 'foo\nBar\n\nR=c@c\n BUG =',
1630 ),
1631 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001632 ('foo BUG=allo R=joe ', ['c@c'], [],
1633 'foo BUG=allo R=joe\n\nR=c@c'),
1634 # Redundant TBRs get promoted to Rs
1635 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1636 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001637 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001638 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001639 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001640 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001641 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001642 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001643 actual.append(obj.description)
1644 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001645
Nodir Turakulov23b82142017-11-16 11:04:25 -08001646 def test_get_hash_tags(self):
1647 cases = [
1648 ('', []),
1649 ('a', []),
1650 ('[a]', ['a']),
1651 ('[aa]', ['aa']),
1652 ('[a ]', ['a']),
1653 ('[a- ]', ['a']),
1654 ('[a- b]', ['a-b']),
1655 ('[a--b]', ['a-b']),
1656 ('[a', []),
1657 ('[a]x', ['a']),
1658 ('[aa]x', ['aa']),
1659 ('[a b]', ['a-b']),
1660 ('[a b]', ['a-b']),
1661 ('[a__b]', ['a-b']),
1662 ('[a] x', ['a']),
1663 ('[a][b]', ['a', 'b']),
1664 ('[a] [b]', ['a', 'b']),
1665 ('[a][b]x', ['a', 'b']),
1666 ('[a][b] x', ['a', 'b']),
1667 ('[a]\n[b]', ['a']),
1668 ('[a\nb]', []),
1669 ('[a][', ['a']),
1670 ('Revert "[a] feature"', ['a']),
1671 ('Reland "[a] feature"', ['a']),
1672 ('Revert: [a] feature', ['a']),
1673 ('Reland: [a] feature', ['a']),
1674 ('Revert "Reland: [a] feature"', ['a']),
1675 ('Foo: feature', ['foo']),
1676 ('Foo Bar: feature', ['foo-bar']),
1677 ('Revert "Foo bar: feature"', ['foo-bar']),
1678 ('Reland "Foo bar: feature"', ['foo-bar']),
1679 ]
1680 for desc, expected in cases:
1681 change_desc = git_cl.ChangeDescription(desc)
1682 actual = change_desc.get_hash_tags()
1683 self.assertEqual(
1684 actual,
1685 expected,
1686 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1687
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001688
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001689 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001690 self.assertEqual(None, git_cl.GetTargetRef(None,
1691 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001692 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001693
wittman@chromium.org455dc922015-01-26 20:15:50 +00001694 # Check default target refs for branches.
1695 self.assertEqual('refs/heads/master',
1696 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001697 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001698 self.assertEqual('refs/heads/master',
1699 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001700 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001701 self.assertEqual('refs/heads/master',
1702 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001703 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001704 self.assertEqual('refs/branch-heads/123',
1705 git_cl.GetTargetRef('origin',
1706 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001707 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001708 self.assertEqual('refs/diff/test',
1709 git_cl.GetTargetRef('origin',
1710 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001711 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001712 self.assertEqual('refs/heads/chrome/m42',
1713 git_cl.GetTargetRef('origin',
1714 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001715 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001716
1717 # Check target refs for user-specified target branch.
1718 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1719 'refs/remotes/branch-heads/123'):
1720 self.assertEqual('refs/branch-heads/123',
1721 git_cl.GetTargetRef('origin',
1722 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001723 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001724 for branch in ('origin/master', 'remotes/origin/master',
1725 'refs/remotes/origin/master'):
1726 self.assertEqual('refs/heads/master',
1727 git_cl.GetTargetRef('origin',
1728 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001729 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001730 for branch in ('master', 'heads/master', 'refs/heads/master'):
1731 self.assertEqual('refs/heads/master',
1732 git_cl.GetTargetRef('origin',
1733 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001734 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001735
wychen@chromium.orga872e752015-04-28 23:42:18 +00001736 def test_patch_when_dirty(self):
1737 # Patch when local tree is dirty
1738 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1739 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1740
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001741 @staticmethod
1742 def _get_gerrit_codereview_server_calls(branch, value=None,
1743 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001744 detect_branch=True,
1745 detect_server=True):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001746 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1747
1748 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1749 """
1750 calls = []
1751 if detect_branch:
1752 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001753 if detect_server:
1754 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1755 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001756 if value is None:
1757 calls += [
1758 ((['git', 'config', 'branch.' + branch + '.merge'],),
1759 'refs/heads' + branch),
1760 ((['git', 'config', 'branch.' + branch + '.remote'],),
1761 'origin'),
1762 ((['git', 'config', 'remote.origin.url'],),
1763 'https://%s.googlesource.com/my/repo' % git_short_host),
1764 ]
1765 return calls
1766
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001767 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001768 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001769 detect_gerrit_server=False,
1770 actual_codereview=None,
1771 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001772 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001773 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1774
tandriidf09a462016-08-18 16:23:55 -07001775 if new_branch:
1776 self.calls = [((['git', 'new-branch', 'master'],), ''),]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001777
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001778 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001779 self.calls += [
1780 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001781 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001782 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001783
1784 if not force_codereview and not codereview_in_url:
1785 # These calls detect codereview to use.
1786 self.calls += [
1787 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001788 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001789 ]
1790 if detect_gerrit_server:
1791 self.calls += self._get_gerrit_codereview_server_calls(
1792 'master', git_short_host=git_short_host,
1793 detect_branch=not new_branch and force_codereview)
1794 actual_codereview = 'gerrit'
1795
1796 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001797 self.calls += [
1798 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001799 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001800 {
1801 'current_revision': '7777777777',
1802 'revisions': {
1803 '1111111111': {
1804 '_number': 1,
1805 'fetch': {'http': {
1806 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1807 'ref': 'refs/changes/56/123456/1',
1808 }},
1809 },
1810 '7777777777': {
1811 '_number': 7,
1812 'fetch': {'http': {
1813 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1814 'ref': 'refs/changes/56/123456/7',
1815 }},
1816 },
1817 },
1818 }),
1819 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001820
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001821 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001822 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001823 self.calls += [
1824 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1825 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001826 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001827 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001828 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001829 ((['git', 'config', 'branch.master.gerritserver',
1830 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001831 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001832 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1833 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1834 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001835 ]
1836 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1837
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001838 def test_patch_gerrit_new_branch(self):
1839 self._patch_common(
1840 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1841 self.calls += [
1842 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1843 'refs/changes/56/123456/7'],), ''),
1844 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1845 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1846 ''),
1847 ((['git', 'config', 'branch.master.gerritserver',
1848 'https://chromium-review.googlesource.com'],), ''),
1849 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1850 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1851 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1852 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1853 ]
1854 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1855
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001856 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001857 self._patch_common(
1858 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001859 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001860 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001861 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001862 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001863 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001864 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001865 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001866 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001867 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001868 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1869 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1870 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001871 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001872 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001873
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001874 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001875 self.calls += self._get_gerrit_codereview_server_calls(
1876 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001877 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001878 actual_codereview='gerrit', git_short_host='else',
1879 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001880 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001881 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001882 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001883 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001884 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001885 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001886 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001887 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001888 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001889 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1890 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1891 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001892 ]
1893 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001894 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001895
Aaron Gable697a91b2018-01-19 15:20:15 -08001896 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001897 self.calls += self._get_gerrit_codereview_server_calls(
1898 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001899 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001900 actual_codereview='gerrit', git_short_host='else',
1901 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001902 self.calls += [
1903 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1904 'refs/changes/56/123456/1'],), ''),
1905 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1906 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1907 ''),
1908 ((['git', 'config', 'branch.master.gerritserver',
1909 'https://else-review.googlesource.com'],), ''),
1910 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1911 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1912 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1913 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1914 ]
1915 self.assertEqual(git_cl.main(
1916 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1917 0)
1918
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001919 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001920 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001921 self.calls += [
1922 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001923 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001924 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1925 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1926 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001927 ]
1928 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001929 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001930
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001931 def test_patch_gerrit_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001932 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001933 raise git_cl.gerrit_util.GerritError(404, '')
1934 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1935
tandriic2405f52016-10-10 08:13:15 -07001936 self.calls = [
1937 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandriic2405f52016-10-10 08:13:15 -07001938 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001939 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1940 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1941 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1942 ((['git', 'config', 'remote.origin.url'],),
1943 'https://chromium.googlesource.com/my/repo'),
1944 ((['DieWithError',
1945 'change 123456 at https://chromium-review.googlesource.com does not '
1946 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001947 ]
1948 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001949 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001950
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001951 def _checkout_calls(self):
1952 return [
1953 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001954 'branch\\..*\\.gerritissue'], ),
1955 ('branch.ger-branch.gerritissue 123456\n'
1956 'branch.gbranch654.gerritissue 654321\n')),
1957 ]
1958
1959 def test_checkout_gerrit(self):
1960 """Tests git cl checkout <issue>."""
1961 self.calls = self._checkout_calls()
1962 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1963 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1964
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001965 def test_checkout_not_found(self):
1966 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001967 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001968 self.calls = self._checkout_calls()
1969 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1970
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001971 def test_checkout_no_branch_issues(self):
1972 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001973 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001974 self.calls = [
1975 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001976 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001977 ]
1978 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1979
tandrii@chromium.org28253532016-04-14 13:46:56 +00001980 def _test_gerrit_ensure_authenticated_common(self, auth,
1981 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001982 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1983 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1984 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001985 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001986 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001987 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00001988 cl.branch = 'master'
1989 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001990 cl.lookedup_issue = True
1991 return cl
1992
1993 def test_gerrit_ensure_authenticated_missing(self):
1994 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001995 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001996 })
1997 self.calls.append(
1998 ((['DieWithError',
1999 'Credentials for the following hosts are required:\n'
2000 ' chromium-review.googlesource.com\n'
2001 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002002 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002003 'https://chromium-review.googlesource.com/new-password'],), ''),)
2004 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2005
2006 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00002007 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002008 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002009 'chromium.googlesource.com':
2010 ('git-one.example.com', None, 'secret1'),
2011 'chromium-review.googlesource.com':
2012 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002013 })
2014 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002015 (('ask_for_data', 'If you know what you are doing '
2016 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002017 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2018
2019 def test_gerrit_ensure_authenticated_ok(self):
2020 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002021 'chromium.googlesource.com':
2022 ('git-same.example.com', None, 'secret'),
2023 'chromium-review.googlesource.com':
2024 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002025 })
2026 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2027
tandrii@chromium.org28253532016-04-14 13:46:56 +00002028 def test_gerrit_ensure_authenticated_skipped(self):
2029 cl = self._test_gerrit_ensure_authenticated_common(
2030 auth={}, skip_auth_check=True)
2031 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2032
Eric Boren2fb63102018-10-05 13:05:03 +00002033 def test_gerrit_ensure_authenticated_bearer_token(self):
2034 cl = self._test_gerrit_ensure_authenticated_common(auth={
2035 'chromium.googlesource.com':
2036 ('', None, 'secret'),
2037 'chromium-review.googlesource.com':
2038 ('', None, 'secret'),
2039 })
2040 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2041 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2042 'chromium.googlesource.com')
2043 self.assertTrue('Bearer' in header)
2044
Daniel Chengcf6269b2019-05-18 01:02:12 +00002045 def test_gerrit_ensure_authenticated_non_https(self):
2046 self.calls = [
2047 ((['git', 'config', '--bool',
2048 'gerrit.skip-ensure-authenticated'],), CERR1),
2049 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2050 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2051 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
2052 ]
2053 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2054 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
2055 cl = git_cl.Changelist(codereview='gerrit')
2056 cl.branch = 'master'
2057 cl.branchref = 'refs/heads/master'
2058 cl.lookedup_issue = True
2059 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2060
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002061 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002062 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002063 lambda h, i, labels, notify=None:
2064 self._mocked_call(['SetReview', h, i, labels, notify]))
2065
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002066 self.calls = [
2067 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002068 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002069 ((['git', 'config', 'branch.feature.gerritserver'],),
2070 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002071 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2072 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2073 ((['git', 'config', 'remote.origin.url'],),
2074 'https://chromium.googlesource.com/infra/infra.git'),
2075 ((['SetReview', 'chromium-review.googlesource.com',
2076 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002077 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002078 ]
tandriid9e5ce52016-07-13 02:32:59 -07002079
2080 def test_cmd_set_commit_gerrit_clear(self):
2081 self._cmd_set_commit_gerrit_common(0)
2082 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2083
2084 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002085 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002086 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2087
tandriid9e5ce52016-07-13 02:32:59 -07002088 def test_cmd_set_commit_gerrit(self):
2089 self._cmd_set_commit_gerrit_common(2)
2090 self.assertEqual(0, git_cl.main(['set-commit']))
2091
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002092 def test_description_display(self):
2093 out = StringIO.StringIO()
2094 self.mock(git_cl.sys, 'stdout', out)
2095
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002096 self.mock(git_cl, 'Changelist', ChangelistMock)
2097 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002098
2099 self.assertEqual(0, git_cl.main(['description', '-d']))
2100 self.assertEqual('foo\n', out.getvalue())
2101
iannucci3c972b92016-08-17 13:24:10 -07002102 def test_StatusFieldOverrideIssueMissingArgs(self):
2103 out = StringIO.StringIO()
2104 self.mock(git_cl.sys, 'stderr', out)
2105
2106 try:
2107 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2108 except SystemExit as ex:
2109 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002110 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002111
2112 out = StringIO.StringIO()
2113 self.mock(git_cl.sys, 'stderr', out)
2114
2115 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002116 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002117 except SystemExit as ex:
2118 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002119 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002120
2121 def test_StatusFieldOverrideIssue(self):
2122 out = StringIO.StringIO()
2123 self.mock(git_cl.sys, 'stdout', out)
2124
2125 def assertIssue(cl_self, *_args):
2126 self.assertEquals(cl_self.issue, 1)
2127 return 'foobar'
2128
2129 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002130 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002131 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002132 0)
iannucci3c972b92016-08-17 13:24:10 -07002133 self.assertEqual(out.getvalue(), 'foobar\n')
2134
iannuccie53c9352016-08-17 14:40:40 -07002135 def test_SetCloseOverrideIssue(self):
2136 def assertIssue(cl_self, *_args):
2137 self.assertEquals(cl_self.issue, 1)
2138 return 'foobar'
2139
2140 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2141 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002142 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002143 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002144
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002145 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002146 out = StringIO.StringIO()
2147 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002148 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002149 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2150 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2151 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2152 ((['git', 'config', 'remote.origin.url'],),
2153 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002154 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002155 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002156 {
2157 'current_revision': 'sha1',
2158 'revisions': {'sha1': {
2159 'commit': {'message': 'foobar'},
2160 }},
2161 }),
2162 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002163 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002164 'description',
2165 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2166 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002167 self.assertEqual('foobar\n', out.getvalue())
2168
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002169 def test_description_set_raw(self):
2170 out = StringIO.StringIO()
2171 self.mock(git_cl.sys, 'stdout', out)
2172
2173 self.mock(git_cl, 'Changelist', ChangelistMock)
2174 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2175
2176 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2177 self.assertEqual('hihi', ChangelistMock.desc)
2178
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002179 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002180 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002181
2182 def RunEditor(desc, _, **kwargs):
2183 self.assertEquals(
2184 '# Enter a description of the change.\n'
2185 '# This will be displayed on the codereview site.\n'
2186 '# The first line will also be used as the subject of the review.\n'
2187 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002188 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002189 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002190 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002191 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002192 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002193
dsansomee2d6fd92016-09-08 00:10:47 -07002194 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002195 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002196
2197 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2198 self.mock(git_cl.Changelist, 'GetDescription',
2199 lambda *args: current_desc)
2200 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2201 UpdateDescriptionRemote)
2202 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2203
2204 self.calls = [
2205 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002206 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002207 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2208 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002209 ((['git', 'config', 'core.editor'],), 'vi'),
2210 ]
2211 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2212
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002213 def test_description_set_stdin(self):
2214 out = StringIO.StringIO()
2215 self.mock(git_cl.sys, 'stdout', out)
2216
2217 self.mock(git_cl, 'Changelist', ChangelistMock)
2218 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2219
2220 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2221 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2222
kmarshall3bff56b2016-06-06 18:31:47 -07002223 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002224 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2225
kmarshall3bff56b2016-06-06 18:31:47 -07002226 self.calls = \
2227 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2228 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002229 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2230 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
tandrii33a46ff2016-08-23 05:53:40 -07002231 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002232 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2233 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2234 ((['git', 'branch', '-D', 'foo'],), '')]
2235
kmarshall3bff56b2016-06-06 18:31:47 -07002236 self.mock(git_cl, 'get_cl_statuses',
2237 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002238 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2239 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2240 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002241
2242 self.assertEqual(0, git_cl.main(['archive', '-f']))
2243
2244 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002245 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002246 self.calls = \
2247 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2248 'refs/heads/master'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002249 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
kmarshall3bff56b2016-06-06 18:31:47 -07002250 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2251
kmarshall9249e012016-08-23 12:02:16 -07002252 self.mock(git_cl, 'get_cl_statuses',
2253 lambda branches, fine_grained, max_processes:
2254 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2255
2256 self.assertEqual(1, git_cl.main(['archive', '-f']))
2257
2258 def test_archive_dry_run(self):
2259 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2260
2261 self.calls = \
2262 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2263 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002264 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2265 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002266 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2267 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002268
2269 self.mock(git_cl, 'get_cl_statuses',
2270 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002271 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2272 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2273 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002274
kmarshall9249e012016-08-23 12:02:16 -07002275 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2276
2277 def test_archive_no_tags(self):
2278 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2279
2280 self.calls = \
2281 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2282 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002283 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
2284 ((['git', 'config', 'branch.foo.gerritissue'],), '456'),
2285 ((['git', 'config', 'branch.bar.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002286 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2287 ((['git', 'branch', '-D', 'foo'],), '')]
2288
2289 self.mock(git_cl, 'get_cl_statuses',
2290 lambda branches, fine_grained, max_processes:
2291 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2292 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2293 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2294
2295 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002296
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002297 def test_cmd_issue_erase_existing(self):
2298 out = StringIO.StringIO()
2299 self.mock(git_cl.sys, 'stdout', out)
2300 self.calls = [
2301 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002302 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002303 # Let this command raise exception (retcode=1) - it should be ignored.
2304 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002305 CERR1),
2306 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2307 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002308 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2309 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2310 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002311 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002312 ]
2313 self.assertEqual(0, git_cl.main(['issue', '0']))
2314
Aaron Gable400e9892017-07-12 15:31:21 -07002315 def test_cmd_issue_erase_existing_with_change_id(self):
2316 out = StringIO.StringIO()
2317 self.mock(git_cl.sys, 'stdout', out)
2318 self.mock(git_cl.Changelist, 'GetDescription',
2319 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2320 self.calls = [
2321 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002322 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
Aaron Gable400e9892017-07-12 15:31:21 -07002323 # Let this command raise exception (retcode=1) - it should be ignored.
2324 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2325 CERR1),
2326 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2327 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2328 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2329 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2330 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002331 ((['git', 'log', '-1', '--format=%B'],),
2332 'This is a description\n\nChange-Id: Ideadbeef'),
2333 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002334 ]
2335 self.assertEqual(0, git_cl.main(['issue', '0']))
2336
phajdan.jre328cf92016-08-22 04:12:17 -07002337 def test_cmd_issue_json(self):
2338 out = StringIO.StringIO()
2339 self.mock(git_cl.sys, 'stdout', out)
2340 self.calls = [
2341 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002342 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2343 ((['git', 'config', 'branch.feature.gerritserver'],),
2344 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002345 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002346 {'issue': 123,
2347 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002348 ''),
2349 ]
2350 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2351
tandrii8c5a3532016-11-04 07:52:02 -07002352 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2353 self.mock(git_cl.Changelist, 'GetChange',
2354 lambda _, *a: (
2355 self._mocked_call(['GetChange']+list(a))))
2356 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2357 lambda *_, **__: (
2358 self._mocked_call(['DoGetTryMasters'])))
2359 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2360 lambda _, s: self._mocked_call(['SetCQState', s]))
2361
tandrii8c5a3532016-11-04 07:52:02 -07002362 self.calls = [
2363 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002364 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2365 ((['git', 'config', 'branch.feature.gerritserver'],),
2366 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002367 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2368 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2369 ((['git', 'config', 'remote.origin.url'],),
2370 'https://chromium.googlesource.com/depot_tools'),
2371 (('GetChangeDetail', 'chromium-review.googlesource.com',
2372 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002373 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2374 'project': 'depot_tools',
2375 'status': 'OPEN',
2376 'owner': {'email': 'owner@e.mail'},
2377 'revisions': {
2378 'deadbeaf': {
2379 '_number': 6,
2380 },
2381 'beeeeeef': {
2382 '_number': 7,
2383 'fetch': {'http': {
2384 'url': 'https://chromium.googlesource.com/depot_tools',
2385 'ref': 'refs/changes/56/123456/7'
2386 }},
2387 },
2388 },
2389 }),
tandrii8c5a3532016-11-04 07:52:02 -07002390 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2391 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2392 ((['get_or_create_merge_base', 'feature', 'feature'],),
2393 'fake_ancestor_sha'),
2394 ((['GetChange', 'fake_ancestor_sha', None], ),
2395 git_cl.presubmit_support.GitChange(
2396 '', '', '', '', '', '', '', '')),
2397 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2398 ((['DoGetTryMasters'], ), None),
2399 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2400 ]
2401 out = StringIO.StringIO()
2402 self.mock(git_cl.sys, 'stdout', out)
2403 self.assertEqual(0, git_cl.main(['try']))
2404 self.assertEqual(
2405 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002406 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002407 'https://chromium-review.googlesource.com/123456\n')
2408
tandrii8c5a3532016-11-04 07:52:02 -07002409 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2410 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2411 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2412
tandrii8c5a3532016-11-04 07:52:02 -07002413 self.calls = [
2414 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002415 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2416 ((['git', 'config', 'branch.feature.gerritserver'],),
2417 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002418 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2419 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2420 ((['git', 'config', 'remote.origin.url'],),
2421 'https://chromium.googlesource.com/depot_tools'),
2422 (('GetChangeDetail', 'chromium-review.googlesource.com',
2423 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002424 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002425 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002426 'status': 'OPEN',
2427 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002428 'revisions': {
2429 'deadbeaf': {
2430 '_number': 6,
2431 },
2432 'beeeeeef': {
2433 '_number': 7,
2434 'fetch': {'http': {
2435 'url': 'https://chromium.googlesource.com/depot_tools',
2436 'ref': 'refs/changes/56/123456/7'
2437 }},
2438 },
2439 },
2440 }),
2441 ]
2442
2443 def _buildbucket_retry(*_, **kw):
2444 # self.maxDiff = 10000
2445 body = json.loads(kw['body'])
2446 self.assertEqual(len(body['builds']), 1)
2447 build = body['builds'][0]
2448 params = json.loads(build.pop('parameters_json'))
2449 self.assertEqual(params, {
2450 u'builder_name': u'win',
2451 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2452 u'revision': None}],
2453 u'properties': {
2454 u'category': u'git_cl_try',
2455 u'key': u'val',
2456 u'json': [{u'a': 1}, None],
tandrii8c5a3532016-11-04 07:52:02 -07002457
2458 u'patch_gerrit_url':
2459 u'https://chromium-review.googlesource.com',
2460 u'patch_issue': 123456,
2461 u'patch_project': u'depot_tools',
2462 u'patch_ref': u'refs/changes/56/123456/7',
2463 u'patch_repository_url':
2464 u'https://chromium.googlesource.com/depot_tools',
2465 u'patch_set': 7,
2466 u'patch_storage': u'gerrit',
2467 }
2468 })
2469 self.assertEqual(build, {
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002470 u'bucket': u'luci.chromium.try',
tandrii8c5a3532016-11-04 07:52:02 -07002471 u'client_operation_id': u'uuid4',
2472 u'tags': [
2473 u'builder:win',
2474 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2475 u'user_agent:git_cl_try',
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002476 ],
tandrii8c5a3532016-11-04 07:52:02 -07002477 })
2478
2479 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2480
2481 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2482 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002483 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002484 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2485 self.assertRegexpMatches(
2486 git_cl.sys.stdout.getvalue(),
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002487 'Tried jobs on:\nBucket: luci.chromium.try')
tandriide281ae2016-10-12 06:02:30 -07002488
qyearsley123a4682016-10-26 09:12:17 -07002489 def test_git_cl_try_bots_on_multiple_masters(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002490 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2491 self.mock(git_cl.Changelist, 'GetChange',
2492 lambda _, *a: (
2493 self._mocked_call(['GetChange']+list(a))))
2494 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2495 lambda *_, **__: (
2496 self._mocked_call(['DoGetTryMasters'])))
2497 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2498 lambda _, s: self._mocked_call(['SetCQState', s]))
2499
qyearsley123a4682016-10-26 09:12:17 -07002500 self.calls = [
2501 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +00002502 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2503 ((['git', 'config', 'branch.feature.gerritserver'],),
2504 'https://chromium-review.googlesource.com'),
2505 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2506 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2507 ((['git', 'config', 'remote.origin.url'],),
2508 'https://chromium.googlesource.com/depot_tools'),
2509 (('GetChangeDetail', 'chromium-review.googlesource.com',
2510 'depot_tools~123456',
2511 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2512 'project': 'depot_tools',
2513 'status': 'OPEN',
2514 'owner': {'email': 'owner@e.mail'},
2515 'revisions': {
2516 'deadbeaf': {
2517 '_number': 6,
2518 },
2519 'beeeeeef': {
2520 '_number': 7,
2521 'fetch': {'http': {
2522 'url': 'https://chromium.googlesource.com/depot_tools',
2523 'ref': 'refs/changes/56/123456/7'
2524 }},
2525 },
2526 },
2527 }),
qyearsley123a4682016-10-26 09:12:17 -07002528 ]
2529
2530 def _buildbucket_retry(*_, **kw):
2531 body = json.loads(kw['body'])
2532 self.assertEqual(len(body['builds']), 2)
2533
Nodir Turakulovb422e682018-02-20 22:51:30 -08002534 self.assertEqual(body['builds'][0]['bucket'], 'bucket1')
2535 params = json.loads(body['builds'][0]['parameters_json'])
2536 self.assertEqual(params['builder_name'], 'builder1')
qyearsley123a4682016-10-26 09:12:17 -07002537
Nodir Turakulovb422e682018-02-20 22:51:30 -08002538 self.assertEqual(body['builds'][1]['bucket'], 'bucket2')
2539 params = json.loads(body['builds'][1]['parameters_json'])
2540 self.assertEqual(params['builder_name'], 'builder2')
qyearsley123a4682016-10-26 09:12:17 -07002541
2542 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2543
2544 self.mock(git_cl.urllib2, 'urlopen', lambda _: StringIO.StringIO(
Nodir Turakulovb422e682018-02-20 22:51:30 -08002545 json.dumps({
2546 'builder1': {'bucket': 'bucket1'},
2547 'builder2': {'bucket': 'bucket2'},
2548 })))
qyearsley123a4682016-10-26 09:12:17 -07002549
2550 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2551 self.assertEqual(
2552 0, git_cl.main(['try', '-b', 'builder1', '-b', 'builder2']))
2553 self.assertEqual(
2554 git_cl.sys.stdout.getvalue(),
2555 'Tried jobs on:\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002556 'Bucket: bucket1\n'
qyearsley123a4682016-10-26 09:12:17 -07002557 ' builder1: []\n'
Nodir Turakulovb422e682018-02-20 22:51:30 -08002558 'Bucket: bucket2\n'
qyearsley123a4682016-10-26 09:12:17 -07002559 ' builder2: []\n'
2560 'To see results here, run: git cl try-results\n'
2561 'To see results in browser, run: git cl web\n')
2562
tandrii16e0b4e2016-06-07 10:34:28 -07002563 def _common_GerritCommitMsgHookCheck(self):
2564 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2565 self.mock(git_cl.os.path, 'abspath',
2566 lambda path: self._mocked_call(['abspath', path]))
2567 self.mock(git_cl.os.path, 'exists',
2568 lambda path: self._mocked_call(['exists', path]))
2569 self.mock(git_cl.gclient_utils, 'FileRead',
2570 lambda path: self._mocked_call(['FileRead', path]))
2571 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2572 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2573 self.calls = [
2574 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2575 ((['abspath', '../'],), '/abs/git_repo_root'),
2576 ]
2577 return git_cl.Changelist(codereview='gerrit', issue=123)
2578
2579 def test_GerritCommitMsgHookCheck_custom_hook(self):
2580 cl = self._common_GerritCommitMsgHookCheck()
2581 self.calls += [
2582 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2583 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2584 '#!/bin/sh\necho "custom hook"')
2585 ]
2586 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2587
2588 def test_GerritCommitMsgHookCheck_not_exists(self):
2589 cl = self._common_GerritCommitMsgHookCheck()
2590 self.calls += [
2591 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2592 ]
2593 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2594
2595 def test_GerritCommitMsgHookCheck(self):
2596 cl = self._common_GerritCommitMsgHookCheck()
2597 self.calls += [
2598 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2599 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2600 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002601 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002602 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2603 ''),
2604 ]
2605 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2606
tandriic4344b52016-08-29 06:04:54 -07002607 def test_GerritCmdLand(self):
2608 self.calls += [
2609 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2610 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2611 'deadbeaf'),
2612 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2613 ((['git', 'config', 'branch.feature.gerritserver'],),
2614 'chromium-review.googlesource.com'),
2615 ]
2616 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2617 cl._codereview_impl._GetChangeDetail = lambda _: {
2618 'labels': {},
2619 'current_revision': 'deadbeaf',
2620 }
agable32978d92016-11-01 12:55:02 -07002621 cl._codereview_impl._GetChangeCommit = lambda: {
2622 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002623 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002624 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2625 }
tandriic4344b52016-08-29 06:04:54 -07002626 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002627 out = StringIO.StringIO()
2628 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002629 self.assertEqual(0, cl.CMDLand(force=True,
2630 bypass_hooks=True,
2631 verbose=True,
2632 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002633 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002634 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002635
tandrii221ab252016-10-06 08:12:04 -07002636 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002637 '9000': {
2638 'id': '9000',
2639 'bucket': 'master.x.y',
2640 'created_by': 'user:someone@chromium.org',
2641 'created_ts': '147200002222000',
2642 'experimental': False,
2643 'parameters_json': json.dumps({
2644 'builder_name': 'my-bot',
2645 'properties': {'category': 'cq'},
2646 }),
2647 'status': 'STARTED',
2648 'tags': [
2649 'build_address:x.y/my-bot/2',
2650 'builder:my-bot',
2651 'experimental:false',
2652 'user_agent:cq',
2653 ],
2654 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2655 },
2656 '8000': {
2657 'id': '8000',
2658 'bucket': 'master.x.y',
2659 'created_by': 'user:someone@chromium.org',
2660 'created_ts': '147200001111000',
2661 'experimental': False,
2662 'failure_reason': 'BUILD_FAILURE',
2663 'parameters_json': json.dumps({
2664 'builder_name': 'my-bot',
2665 'properties': {'category': 'cq'},
2666 }),
2667 'result_details_json': json.dumps({
2668 'properties': {'buildnumber': 1},
2669 }),
2670 'result': 'FAILURE',
2671 'status': 'COMPLETED',
2672 'tags': [
2673 'build_address:x.y/my-bot/1',
2674 'builder:my-bot',
2675 'experimental:false',
2676 'user_agent:cq',
2677 ],
2678 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2679 },
2680 }
tandrii221ab252016-10-06 08:12:04 -07002681
2682 def test_write_try_results_json(self):
2683 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002684 {
2685 'bucket': 'master.x.y',
2686 'buildbucket_id': '8000',
2687 'builder_name': 'my-bot',
2688 'created_ts': '147200001111000',
2689 'experimental': False,
2690 'failure_reason': 'BUILD_FAILURE',
2691 'result': 'FAILURE',
2692 'status': 'COMPLETED',
2693 'tags': [
2694 'build_address:x.y/my-bot/1',
2695 'builder:my-bot',
2696 'experimental:false',
2697 'user_agent:cq',
2698 ],
2699 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2700 },
2701 {
2702 'bucket': 'master.x.y',
2703 'buildbucket_id': '9000',
2704 'builder_name': 'my-bot',
2705 'created_ts': '147200002222000',
2706 'experimental': False,
2707 'failure_reason': None,
2708 'result': None,
2709 'status': 'STARTED',
2710 'tags': [
2711 'build_address:x.y/my-bot/2',
2712 'builder:my-bot',
2713 'experimental:false',
2714 'user_agent:cq',
2715 ],
2716 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2717 },
tandrii221ab252016-10-06 08:12:04 -07002718 ]
2719 self.calls = [(('write_json', 'output.json', expected_output), '')]
2720 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2721
tandrii45b2a582016-10-11 03:14:16 -07002722 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002723 out = StringIO.StringIO()
2724 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002725 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2726 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002727 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2728 self._mocked_call(['get_authenticator_for_host', host]))
2729 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2730 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002731
tandrii45b2a582016-10-11 03:14:16 -07002732 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2733 self._setup_fetch_try_jobs(most_recent_patchset=13)
2734 self.calls += [
2735 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii45b2a582016-10-11 03:14:16 -07002736 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002737 # TODO(tandrii): Uncomment the below if we decide to support checking
2738 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002739 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002740 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002741 ((['git', 'config', 'branch.feature.gerritserver'],),
2742 'https://x-review.googlesource.com'),
2743 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2744 AuthenticatorMock()),
2745 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2746
2747 def test_fetch_try_jobs_none_gerrit(self):
2748 self._setup_fetch_try_jobs_gerrit({})
2749 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002750 # TODO(tandrii): Uncomment the below if we decide to support checking
2751 # patchsets for Gerrit.
2752 # self.assertRegexpMatches(
2753 # sys.stdout.getvalue(),
2754 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07002755 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2756
2757 def test_fetch_try_jobs_some_gerrit(self):
2758 self._setup_fetch_try_jobs_gerrit({
2759 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2760 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002761 # TODO(tandrii): Uncomment the below if we decide to support checking
2762 # patchsets for Gerrit.
2763 # self.calls.remove(
2764 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002765 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2766
2767 # ... and doesn't result in warning.
2768 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2769 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002770 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2771 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2772
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002773 def _mock_gerrit_changes_for_detail_cache(self):
2774 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002775
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002776 def test_gerrit_change_detail_cache_simple(self):
2777 self._mock_gerrit_changes_for_detail_cache()
2778 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002779 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2780 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2781 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002782 ]
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002783 cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002784 cl1._cached_remote_url = (
2785 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002786 cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002787 cl2._cached_remote_url = (
2788 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002789 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2790 self.assertEqual(cl1._GetChangeDetail(), 'a')
2791 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2792 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2793 self.assertEqual(cl1._GetChangeDetail(), 'a')
2794 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002795
2796 def test_gerrit_change_detail_cache_options(self):
2797 self._mock_gerrit_changes_for_detail_cache()
2798 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002799 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2800 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2801 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2802 # no longer in cache.
2803 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002804 ]
2805 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002806 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002807 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2808 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2809 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2810 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2811 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2812 self.assertEqual(cl._GetChangeDetail(), 'cab')
2813
2814 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2815 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2816 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2817 self.assertEqual(cl._GetChangeDetail(), 'cab')
2818
2819 # Finally, no_cache should invalidate all caches for given change.
2820 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2821 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2822
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002823 def test_gerrit_description_caching(self):
2824 def gen_detail(rev, desc):
2825 return {
2826 'current_revision': rev,
2827 'revisions': {rev: {'commit': {'message': desc}}}
2828 }
2829 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002830 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002831 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2832 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002833 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002834 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2835 gen_detail('rev2', 'desc2')),
2836 ]
2837
2838 self._mock_gerrit_changes_for_detail_cache()
2839 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002840 cl._cached_remote_url = (
2841 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002842 self.assertEqual(cl.GetDescription(), 'desc1')
2843 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2844 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002845
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002846 def test_print_current_creds(self):
2847 class CookiesAuthenticatorMock(object):
2848 def __init__(self):
2849 self.gitcookies = {
2850 'host.googlesource.com': ('user', 'pass'),
2851 'host-review.googlesource.com': ('user', 'pass'),
2852 }
2853 self.netrc = self
2854 self.netrc.hosts = {
2855 'github.com': ('user2', None, 'pass2'),
2856 'host2.googlesource.com': ('user3', None, 'pass'),
2857 }
2858 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2859 CookiesAuthenticatorMock)
2860 self.mock(sys, 'stdout', StringIO.StringIO())
2861 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2862 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2863 ' Host\t User\t Which file',
2864 '============================\t=====\t===========',
2865 'host-review.googlesource.com\t user\t.gitcookies',
2866 ' host.googlesource.com\t user\t.gitcookies',
2867 ' host2.googlesource.com\tuser3\t .netrc',
2868 ])
2869 sys.stdout.buf = ''
2870 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2871 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2872 ' Host\tUser\t Which file',
2873 '============================\t====\t===========',
2874 'host-review.googlesource.com\tuser\t.gitcookies',
2875 ' host.googlesource.com\tuser\t.gitcookies',
2876 ])
2877
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002878 def _common_creds_check_mocks(self):
2879 def exists_mock(path):
2880 dirname = os.path.dirname(path)
2881 if dirname == os.path.expanduser('~'):
2882 dirname = '~'
2883 base = os.path.basename(path)
2884 if base in ('.netrc', '.gitcookies'):
2885 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2886 # git cl also checks for existence other files not relevant to this test.
2887 return None
2888 self.mock(os.path, 'exists', exists_mock)
2889 self.mock(sys, 'stdout', StringIO.StringIO())
2890
2891 def test_creds_check_gitcookies_not_configured(self):
2892 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002893 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002894 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002895 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002896 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002897 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2898 (('os.path.exists', '~/.netrc'), True),
2899 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2900 'or Ctrl+C to abort'), ''),
2901 ((['git', 'config', '--global', 'http.cookiefile',
2902 os.path.expanduser('~/.gitcookies')], ), ''),
2903 ]
2904 self.assertEqual(0, git_cl.main(['creds-check']))
2905 self.assertRegexpMatches(
2906 sys.stdout.getvalue(),
2907 '^You seem to be using outdated .netrc for git credentials:')
2908 self.assertRegexpMatches(
2909 sys.stdout.getvalue(),
2910 '\nConfigured git to use .gitcookies from')
2911
2912 def test_creds_check_gitcookies_configured_custom_broken(self):
2913 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002914 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002915 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002916 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002917 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002918 ((['git', 'config', '--global', 'http.cookiefile'],),
2919 '/custom/.gitcookies'),
2920 (('os.path.exists', '/custom/.gitcookies'), False),
2921 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2922 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2923 ((['git', 'config', '--global', 'http.cookiefile',
2924 os.path.expanduser('~/.gitcookies')], ), ''),
2925 ]
2926 self.assertEqual(0, git_cl.main(['creds-check']))
2927 self.assertRegexpMatches(
2928 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002929 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002930 self.assertRegexpMatches(
2931 sys.stdout.getvalue(),
2932 'However, your configured .gitcookies file is missing.')
2933
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002934 def test_git_cl_comment_add_gerrit(self):
2935 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002936 lambda host, change, msg, ready:
2937 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002938 self.calls = [
2939 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2940 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2941 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2942 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2943 'origin/master'),
2944 ((['git', 'config', 'remote.origin.url'],),
2945 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002946 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2947 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002948 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002949 ]
2950 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2951 '-a', 'msg']))
2952
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002953 def test_git_cl_comments_fetch_gerrit(self):
2954 self.mock(sys, 'stdout', StringIO.StringIO())
2955 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002956 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2957 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002958 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2959 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2960 'origin/master'),
2961 ((['git', 'config', 'remote.origin.url'],),
2962 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002963 (('GetChangeDetail', 'chromium-review.googlesource.com',
2964 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002965 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2966 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002967 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002968 'current_revision': 'ba5eba11',
2969 'revisions': {
2970 'deadbeaf': {
2971 '_number': 1,
2972 },
2973 'ba5eba11': {
2974 '_number': 2,
2975 },
2976 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002977 'messages': [
2978 {
2979 u'_revision_number': 1,
2980 u'author': {
2981 u'_account_id': 1111084,
2982 u'email': u'commit-bot@chromium.org',
2983 u'name': u'Commit Bot'
2984 },
2985 u'date': u'2017-03-15 20:08:45.000000000',
2986 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002987 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002988 u'tag': u'autogenerated:cq:dry-run'
2989 },
2990 {
2991 u'_revision_number': 2,
2992 u'author': {
2993 u'_account_id': 11151243,
2994 u'email': u'owner@example.com',
2995 u'name': u'owner'
2996 },
2997 u'date': u'2017-03-16 20:00:41.000000000',
2998 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2999 u'message': u'PTAL',
3000 },
3001 {
3002 u'_revision_number': 2,
3003 u'author': {
3004 u'_account_id': 148512 ,
3005 u'email': u'reviewer@example.com',
3006 u'name': u'reviewer'
3007 },
3008 u'date': u'2017-03-17 05:19:37.500000000',
3009 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
3010 u'message': u'Patch Set 2: Code-Review+1',
3011 },
3012 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003013 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00003014 (('GetChangeComments', 'chromium-review.googlesource.com',
3015 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003016 '/COMMIT_MSG': [
3017 {
3018 'author': {'email': u'reviewer@example.com'},
3019 'updated': u'2017-03-17 05:19:37.500000000',
3020 'patch_set': 2,
3021 'side': 'REVISION',
3022 'message': 'Please include a bug link',
3023 },
3024 ],
3025 'codereview.settings': [
3026 {
3027 'author': {'email': u'owner@example.com'},
3028 'updated': u'2017-03-16 20:00:41.000000000',
3029 'patch_set': 2,
3030 'side': 'PARENT',
3031 'line': 42,
3032 'message': 'I removed this because it is bad',
3033 },
3034 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003035 }),
3036 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
3037 'infra%2Finfra~1'), {}),
3038 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00003039 ] * 2 + [
3040 (('write_json', 'output.json', [
3041 {
3042 u'date': u'2017-03-16 20:00:41.000000',
3043 u'message': (
3044 u'PTAL\n' +
3045 u'\n' +
3046 u'codereview.settings\n' +
3047 u' Base, Line 42: https://chromium-review.googlesource.com/' +
3048 u'c/1/2/codereview.settings#b42\n' +
3049 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003050 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00003051 u'approval': False,
3052 u'disapproval': False,
3053 u'sender': u'owner@example.com'
3054 }, {
3055 u'date': u'2017-03-17 05:19:37.500000',
3056 u'message': (
3057 u'Patch Set 2: Code-Review+1\n' +
3058 u'\n' +
3059 u'/COMMIT_MSG\n' +
3060 u' PS2, File comment: https://chromium-review.googlesource' +
3061 u'.com/c/1/2//COMMIT_MSG#\n' +
3062 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003063 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00003064 u'approval': False,
3065 u'disapproval': False,
3066 u'sender': u'reviewer@example.com'
3067 }
3068 ]),'')
3069 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003070 expected_comments_summary = [
3071 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003072 message=(
3073 u'PTAL\n' +
3074 u'\n' +
3075 u'codereview.settings\n' +
3076 u' Base, Line 42: https://chromium-review.googlesource.com/' +
3077 u'c/1/2/codereview.settings#b42\n' +
3078 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003079 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003080 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003081 disapproval=False, approval=False, sender=u'owner@example.com'),
3082 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003083 message=(
3084 u'Patch Set 2: Code-Review+1\n' +
3085 u'\n' +
3086 u'/COMMIT_MSG\n' +
3087 u' PS2, File comment: https://chromium-review.googlesource.com/' +
3088 u'c/1/2//COMMIT_MSG#\n' +
3089 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003090 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003091 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003092 disapproval=False, approval=False, sender=u'reviewer@example.com'),
3093 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003094 cl = git_cl.Changelist(
3095 codereview='gerrit', issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003096 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003097 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
3098 self.assertEqual(
3099 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
3100
3101 def test_git_cl_comments_robot_comments(self):
3102 # git cl comments also fetches robot comments (which are considered a type
3103 # of autogenerated comment), and unlike other types of comments, only robot
3104 # comments from the latest patchset are shown.
3105 self.mock(sys, 'stdout', StringIO.StringIO())
3106 self.calls = [
3107 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
3108 ((['git', 'config', 'branch.foo.merge'],), ''),
3109 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3110 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3111 'origin/master'),
3112 ((['git', 'config', 'remote.origin.url'],),
3113 'https://chromium.googlesource.com/infra/infra'),
3114 (('GetChangeDetail', 'chromium-review.googlesource.com',
3115 'infra%2Finfra~1',
3116 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
3117 'CURRENT_COMMIT']), {
3118 'owner': {'email': 'owner@example.com'},
3119 'current_revision': 'ba5eba11',
3120 'revisions': {
3121 'deadbeaf': {
3122 '_number': 1,
3123 },
3124 'ba5eba11': {
3125 '_number': 2,
3126 },
3127 },
3128 'messages': [
3129 {
3130 u'_revision_number': 1,
3131 u'author': {
3132 u'_account_id': 1111084,
3133 u'email': u'commit-bot@chromium.org',
3134 u'name': u'Commit Bot'
3135 },
3136 u'date': u'2017-03-15 20:08:45.000000000',
3137 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
3138 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
3139 u'tag': u'autogenerated:cq:dry-run'
3140 },
3141 {
3142 u'_revision_number': 1,
3143 u'author': {
3144 u'_account_id': 123,
3145 u'email': u'tricium@serviceaccount.com',
3146 u'name': u'Tricium'
3147 },
3148 u'date': u'2017-03-16 20:00:41.000000000',
3149 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3150 u'message': u'(1 comment)',
3151 u'tag': u'autogenerated:tricium',
3152 },
3153 {
3154 u'_revision_number': 1,
3155 u'author': {
3156 u'_account_id': 123,
3157 u'email': u'tricium@serviceaccount.com',
3158 u'name': u'Tricium'
3159 },
3160 u'date': u'2017-03-16 20:00:41.000000000',
3161 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3162 u'message': u'(1 comment)',
3163 u'tag': u'autogenerated:tricium',
3164 },
3165 {
3166 u'_revision_number': 2,
3167 u'author': {
3168 u'_account_id': 123 ,
3169 u'email': u'tricium@serviceaccount.com',
3170 u'name': u'reviewer'
3171 },
3172 u'date': u'2017-03-17 05:30:37.000000000',
3173 u'tag': u'autogenerated:tricium',
3174 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
3175 u'message': u'(1 comment)',
3176 },
3177 ]
3178 }),
3179 (('GetChangeComments', 'chromium-review.googlesource.com',
3180 'infra%2Finfra~1'), {}),
3181 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
3182 'infra%2Finfra~1'), {
3183 'codereview.settings': [
3184 {
3185 u'author': {u'email': u'tricium@serviceaccount.com'},
3186 u'updated': u'2017-03-17 05:30:37.000000000',
3187 u'robot_run_id': u'5565031076855808',
3188 u'robot_id': u'Linter/Category',
3189 u'tag': u'autogenerated:tricium',
3190 u'patch_set': 2,
3191 u'side': u'REVISION',
3192 u'message': u'Linter warning message text',
3193 u'line': 32,
3194 },
3195 ],
3196 }),
3197 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
3198 ]
3199 expected_comments_summary = [
3200 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
3201 message=(
3202 u'(1 comment)\n\ncodereview.settings\n'
3203 u' PS2, Line 32: https://chromium-review.googlesource.com/'
3204 u'c/1/2/codereview.settings#32\n'
3205 u' Linter warning message text\n'),
3206 sender=u'tricium@serviceaccount.com',
3207 autogenerated=True, approval=False, disapproval=False)
3208 ]
3209 cl = git_cl.Changelist(
3210 codereview='gerrit', issue=1, branchref='refs/heads/foo')
3211 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003212
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003213 def test_get_remote_url_with_mirror(self):
3214 original_os_path_isdir = os.path.isdir
3215 def selective_os_path_isdir_mock(path):
3216 if path == '/cache/this-dir-exists':
3217 return self._mocked_call('os.path.isdir', path)
3218 return original_os_path_isdir(path)
3219 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3220
3221 url = 'https://chromium.googlesource.com/my/repo'
3222 self.calls = [
3223 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3224 ((['git', 'config', 'branch.master.merge'],), 'master'),
3225 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3226 ((['git', 'config', 'remote.origin.url'],),
3227 '/cache/this-dir-exists'),
3228 (('os.path.isdir', '/cache/this-dir-exists'),
3229 True),
3230 # Runs in /cache/this-dir-exists.
3231 ((['git', 'config', 'remote.origin.url'],),
3232 url),
3233 ]
3234 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3235 self.assertEqual(cl.GetRemoteUrl(), url)
3236 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3237
Edward Lemur298f2cf2019-02-22 21:40:39 +00003238 def test_get_remote_url_non_existing_mirror(self):
3239 original_os_path_isdir = os.path.isdir
3240 def selective_os_path_isdir_mock(path):
3241 if path == '/cache/this-dir-doesnt-exist':
3242 return self._mocked_call('os.path.isdir', path)
3243 return original_os_path_isdir(path)
3244 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3245 self.mock(logging, 'error',
3246 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
3247
3248 self.calls = [
3249 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3250 ((['git', 'config', 'branch.master.merge'],), 'master'),
3251 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3252 ((['git', 'config', 'remote.origin.url'],),
3253 '/cache/this-dir-doesnt-exist'),
3254 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3255 False),
3256 (('logging.error',
3257 'Remote "origin" for branch "/cache/this-dir-doesnt-exist" points to'
3258 ' "master", but it doesn\'t exist.'), None),
3259 ]
3260 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3261 self.assertIsNone(cl.GetRemoteUrl())
3262
3263 def test_get_remote_url_misconfigured_mirror(self):
3264 original_os_path_isdir = os.path.isdir
3265 def selective_os_path_isdir_mock(path):
3266 if path == '/cache/this-dir-exists':
3267 return self._mocked_call('os.path.isdir', path)
3268 return original_os_path_isdir(path)
3269 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3270 self.mock(logging, 'error',
3271 lambda *a: self._mocked_call('logging.error', *a))
3272
3273 self.calls = [
3274 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3275 ((['git', 'config', 'branch.master.merge'],), 'master'),
3276 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3277 ((['git', 'config', 'remote.origin.url'],),
3278 '/cache/this-dir-exists'),
3279 (('os.path.isdir', '/cache/this-dir-exists'), True),
3280 # Runs in /cache/this-dir-exists.
3281 ((['git', 'config', 'remote.origin.url'],), ''),
3282 (('logging.error',
3283 'Remote "%(remote)s" for branch "%(branch)s" points to '
3284 '"%(cache_path)s", but it is misconfigured.\n'
3285 '"%(cache_path)s" must be a git repo and must have a remote named '
3286 '"%(remote)s" pointing to the git host.', {
3287 'remote': 'origin',
3288 'cache_path': '/cache/this-dir-exists',
3289 'branch': 'master'}
3290 ), None),
3291 ]
3292 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3293 self.assertIsNone(cl.GetRemoteUrl())
3294
3295
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003296 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003297 self.calls = [
3298 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3299 ((['git', 'config', 'branch.master.merge'],), 'master'),
3300 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3301 ((['git', 'config', 'remote.origin.url'],),
3302 'https://chromium.googlesource.com/a/my/repo.git/'),
3303 ]
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003304 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3305 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3306
3307 def test_gerrit_change_identifier_without_project(self):
3308 self.calls = [
3309 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3310 ((['git', 'config', 'branch.master.merge'],), 'master'),
3311 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3312 ((['git', 'config', 'remote.origin.url'],), CERR1),
3313 ]
3314 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3315 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003316
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003317
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003318if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003319 logging.basicConfig(
3320 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003321 unittest.main()