blob: 1c314a13c4b5d04cc4ed2a50d8e1b4ca8c39b780 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur0db01f02019-11-12 22:01:51 +00009from __future__ import unicode_literals
10
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010011import datetime
tandriide281ae2016-10-12 06:02:30 -070012import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010013import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import os
Brian Sheedy59b06a82019-10-14 17:03:29 +000015import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070017import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018import unittest
19
Edward Lemura8145022020-01-06 18:47:54 +000020if sys.version_info.major == 2:
21 from StringIO import StringIO
22 import mock
23else:
24 from io import StringIO
25 from unittest import mock
26
maruel@chromium.orgddd59412011-11-30 14:20:38 +000027sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
28
29from testing_support.auto_stub import TestCase
30
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000031import metrics
32# We have to disable monitoring before importing git_cl.
33metrics.DISABLE_METRICS_COLLECTION = True
34
Jamie Madill5e96ad12020-01-13 16:08:35 +000035import clang_format
Eric Boren2fb63102018-10-05 13:05:03 +000036import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000037import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000038import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000039import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000040import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000041
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000042
Edward Lemur0db01f02019-11-12 22:01:51 +000043def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070044 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
45
46
Edward Lemur4c707a22019-09-24 21:13:43 +000047def _constantFn(return_value):
48 def f(*args, **kwargs):
49 return return_value
50 return f
51
52
tandrii5d48c322016-08-18 16:19:37 -070053CERR1 = callError(1)
54
55
Edward Lemur0db01f02019-11-12 22:01:51 +000056def MakeNamedTemporaryFileMock(test, expected_content):
Aaron Gable9a03ae02017-11-03 11:31:07 -070057 class NamedTemporaryFileMock(object):
58 def __init__(self, *args, **kwargs):
59 self.name = '/tmp/named'
Edward Lemur0db01f02019-11-12 22:01:51 +000060 self.expected_content = expected_content.encode('utf-8', 'replace')
Aaron Gable9a03ae02017-11-03 11:31:07 -070061
62 def __enter__(self):
63 return self
64
65 def __exit__(self, _type, _value, _tb):
66 pass
67
68 def write(self, content):
69 if self.expected_content:
Edward Lemur0db01f02019-11-12 22:01:51 +000070 test.assertEqual(self.expected_content, content)
Aaron Gable9a03ae02017-11-03 11:31:07 -070071
72 def close(self):
73 pass
74
75 return NamedTemporaryFileMock
76
77
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000078class ChangelistMock(object):
79 # A class variable so we can access it when we don't have access to the
80 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000081 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000082 def __init__(self, **kwargs):
83 pass
84 def GetIssue(self):
85 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080086 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000087 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070088 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000089 ChangelistMock.desc = desc
90
tandrii5d48c322016-08-18 16:19:37 -070091
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000092class PresubmitMock(object):
93 def __init__(self, *args, **kwargs):
94 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080095 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
96
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000097 @staticmethod
98 def should_continue():
99 return True
100
101
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000102class WatchlistsMock(object):
103 def __init__(self, _):
104 pass
105 @staticmethod
106 def GetWatchersForPaths(_):
107 return ['joe@example.com']
108
109
Edward Lemur4c707a22019-09-24 21:13:43 +0000110class CodereviewSettingsFileMock(object):
111 def __init__(self):
112 pass
113 # pylint: disable=no-self-use
114 def read(self):
115 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
116 'GERRIT_HOST: True\n')
117
118
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000119class AuthenticatorMock(object):
120 def __init__(self, *_args):
121 pass
122 def has_cached_credentials(self):
123 return True
tandrii221ab252016-10-06 08:12:04 -0700124 def authorize(self, http):
125 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000126
127
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100128def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000129 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
130
131 Usage:
132 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100133 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000134
135 OR
136 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100137 CookiesAuthenticatorMockFactory(
138 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139 """
140 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800141 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000142 # Intentionally not calling super() because it reads actual cookie files.
143 pass
144 @classmethod
145 def get_gitcookies_path(cls):
146 return '~/.gitcookies'
147 @classmethod
148 def get_netrc_path(cls):
149 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100150 def _get_auth_for_host(self, host):
151 if same_auth:
152 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000153 return (hosts_with_creds or {}).get(host)
154 return CookiesAuthenticatorMock
155
Aaron Gable9a03ae02017-11-03 11:31:07 -0700156
kmarshall9249e012016-08-23 12:02:16 -0700157class MockChangelistWithBranchAndIssue():
158 def __init__(self, branch, issue):
159 self.branch = branch
160 self.issue = issue
161 def GetBranch(self):
162 return self.branch
163 def GetIssue(self):
164 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000165
tandriic2405f52016-10-10 08:13:15 -0700166
167class SystemExitMock(Exception):
168 pass
169
170
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000171class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100172 def test_get_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000173 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100174 cl.description = 'x'
175 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000176 cl.FetchDescription = lambda *a, **kw: 'y'
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000177 self.assertEqual(cl.GetDescription(), 'x')
178 self.assertEqual(cl.GetDescription(force=True), 'y')
179 self.assertEqual(cl.GetDescription(), 'y')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100180
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700181 def test_description_footers(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000182 cl = git_cl.Changelist(issue=1, codereview_host='host')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700183 cl.description = '\n'.join([
184 'This is some message',
185 '',
186 'It has some lines',
187 'and, also',
188 '',
189 'Some: Really',
190 'Awesome: Footers',
191 ])
192 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000193 cl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700194 msg, footers = cl.GetDescriptionFooters()
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000195 self.assertEqual(
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700196 msg, ['This is some message', '', 'It has some lines', 'and, also'])
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000197 self.assertEqual(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700198
199 msg.append('wut')
200 footers.append(('gnarly-dude', 'beans'))
201 cl.UpdateDescriptionFooters(msg, footers)
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000202 self.assertEqual(cl.GetDescription().splitlines(), [
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700203 'This is some message',
204 '',
205 'It has some lines',
206 'and, also',
207 'wut'
208 '',
209 'Some: Really',
210 'Awesome: Footers',
211 'Gnarly-Dude: beans',
212 ])
213
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000214 def test_set_preserve_tryjobs(self):
215 d = git_cl.ChangeDescription('Simple.')
216 d.set_preserve_tryjobs()
217 self.assertEqual(d.description.splitlines(), [
218 'Simple.',
219 '',
220 'Cq-Do-Not-Cancel-Tryjobs: true',
221 ])
222 before = d.description
223 d.set_preserve_tryjobs()
224 self.assertEqual(before, d.description)
225
226 d = git_cl.ChangeDescription('\n'.join([
227 'One is enough',
228 '',
229 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
230 'Change-Id: Ideadbeef',
231 ]))
232 d.set_preserve_tryjobs()
233 self.assertEqual(d.description.splitlines(), [
234 'One is enough',
235 '',
236 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
237 'Change-Id: Ideadbeef',
238 'Cq-Do-Not-Cancel-Tryjobs: true',
239 ])
240
tandriif9aefb72016-07-01 09:06:51 -0700241 def test_get_bug_line_values(self):
242 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
243 self.assertEqual(f('', ''), [])
244 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
245 self.assertEqual(f('v8', '456'), ['v8:456'])
246 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
247 # Not nice, but not worth carying.
248 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
249 ['v8:456', 'chromium:123', 'v8:123'])
250
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100251 def _test_git_number(self, parent_msg, dest_ref, child_msg,
252 parent_hash='parenthash'):
253 desc = git_cl.ChangeDescription(child_msg)
254 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
255 return desc.description
256
257 def assertEqualByLine(self, actual, expected):
258 self.assertEqual(actual.splitlines(), expected.splitlines())
259
260 def test_git_number_bad_parent(self):
261 with self.assertRaises(ValueError):
262 self._test_git_number('Parent', 'refs/heads/master', 'Child')
263
264 def test_git_number_bad_parent_footer(self):
265 with self.assertRaises(AssertionError):
266 self._test_git_number(
267 'Parent\n'
268 '\n'
269 'Cr-Commit-Position: wrong',
270 'refs/heads/master', 'Child')
271
272 def test_git_number_bad_lineage_ignored(self):
273 actual = self._test_git_number(
274 'Parent\n'
275 '\n'
276 'Cr-Commit-Position: refs/heads/master@{#1}\n'
277 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
278 'refs/heads/master', 'Child')
279 self.assertEqualByLine(
280 actual,
281 'Child\n'
282 '\n'
283 'Cr-Commit-Position: refs/heads/master@{#2}\n'
284 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
285
286 def test_git_number_same_branch(self):
287 actual = self._test_git_number(
288 'Parent\n'
289 '\n'
290 'Cr-Commit-Position: refs/heads/master@{#12}',
291 dest_ref='refs/heads/master',
292 child_msg='Child')
293 self.assertEqualByLine(
294 actual,
295 'Child\n'
296 '\n'
297 'Cr-Commit-Position: refs/heads/master@{#13}')
298
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200299 def test_git_number_same_branch_mixed_footers(self):
300 actual = self._test_git_number(
301 'Parent\n'
302 '\n'
303 'Cr-Commit-Position: refs/heads/master@{#12}',
304 dest_ref='refs/heads/master',
305 child_msg='Child\n'
306 '\n'
307 'Broken-by: design\n'
308 'BUG=123')
309 self.assertEqualByLine(
310 actual,
311 'Child\n'
312 '\n'
313 'Broken-by: design\n'
314 'BUG=123\n'
315 'Cr-Commit-Position: refs/heads/master@{#13}')
316
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100317 def test_git_number_same_branch_with_originals(self):
318 actual = self._test_git_number(
319 'Parent\n'
320 '\n'
321 'Cr-Commit-Position: refs/heads/master@{#12}',
322 dest_ref='refs/heads/master',
323 child_msg='Child\n'
324 '\n'
325 'Some users are smart and insert their own footers\n'
326 '\n'
327 'Cr-Whatever: value\n'
328 'Cr-Commit-Position: refs/copy/paste@{#22}')
329 self.assertEqualByLine(
330 actual,
331 'Child\n'
332 '\n'
333 'Some users are smart and insert their own footers\n'
334 '\n'
335 'Cr-Original-Whatever: value\n'
336 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
337 'Cr-Commit-Position: refs/heads/master@{#13}')
338
339 def test_git_number_new_branch(self):
340 actual = self._test_git_number(
341 'Parent\n'
342 '\n'
343 'Cr-Commit-Position: refs/heads/master@{#12}',
344 dest_ref='refs/heads/branch',
345 child_msg='Child')
346 self.assertEqualByLine(
347 actual,
348 'Child\n'
349 '\n'
350 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
351 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
352
353 def test_git_number_lineage(self):
354 actual = self._test_git_number(
355 'Parent\n'
356 '\n'
357 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
358 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
359 dest_ref='refs/heads/branch',
360 child_msg='Child')
361 self.assertEqualByLine(
362 actual,
363 'Child\n'
364 '\n'
365 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
366 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
367
368 def test_git_number_moooooooore_lineage(self):
369 actual = self._test_git_number(
370 'Parent\n'
371 '\n'
372 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
373 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
374 dest_ref='refs/heads/mooore',
375 child_msg='Child')
376 self.assertEqualByLine(
377 actual,
378 'Child\n'
379 '\n'
380 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
381 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
382 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
383
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100384 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700385 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100386 actual = self._test_git_number(
387 'CQ commit on fresh new branch + numbering.\n'
388 '\n'
389 'NOTRY=True\n'
390 'NOPRESUBMIT=True\n'
391 'BUG=\n'
392 '\n'
393 'Review-Url: https://codereview.chromium.org/2577703003\n'
394 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
395 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
396 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
397 dest_ref='refs/heads/gnumb-test/cl',
398 child_msg='git cl on fresh new branch + numbering.\n'
399 '\n'
400 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
401 self.assertEqualByLine(
402 actual,
403 'git cl on fresh new branch + numbering.\n'
404 '\n'
405 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
406 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
407 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
408 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
409 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100410
411 def test_git_number_cherry_pick(self):
412 actual = self._test_git_number(
413 'Parent\n'
414 '\n'
415 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
416 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
417 dest_ref='refs/heads/branch',
418 child_msg='Child, which is cherry-pick from master\n'
419 '\n'
420 'Cr-Commit-Position: refs/heads/master@{#100}\n'
421 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
422 self.assertEqualByLine(
423 actual,
424 'Child, which is cherry-pick from master\n'
425 '\n'
426 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
427 '\n'
428 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
429 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
430 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
431
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000432 def test_valid_accounts(self):
433 mock_per_account = {
434 'u1': None, # 404, doesn't exist.
435 'u2': {
436 '_account_id': 123124,
437 'avatars': [],
438 'email': 'u2@example.com',
439 'name': 'User Number 2',
440 'status': 'OOO',
441 },
442 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
443 }
444 def GetAccountDetailsMock(_, account):
445 # Poor-man's mock library's side_effect.
446 v = mock_per_account.pop(account)
447 if isinstance(v, Exception):
448 raise v
449 return v
450
451 original = git_cl.gerrit_util.GetAccountDetails
452 try:
453 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
454 actual = git_cl.gerrit_util.ValidAccounts(
455 'host', ['u1', 'u2', 'u3'], max_threads=1)
456 finally:
457 git_cl.gerrit_util.GetAccountDetails = original
458 self.assertEqual(actual, {
459 'u2': {
460 '_account_id': 123124,
461 'avatars': [],
462 'email': 'u2@example.com',
463 'name': 'User Number 2',
464 'status': 'OOO',
465 },
466 })
467
468
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200469class TestParseIssueURL(unittest.TestCase):
470 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000471 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200472 self.assertIsNotNone(parsed)
473 if fail:
474 self.assertFalse(parsed.valid)
475 return
476 self.assertTrue(parsed.valid)
477 self.assertEqual(parsed.issue, issue)
478 self.assertEqual(parsed.patchset, patchset)
479 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480
Edward Lemur678a6842019-10-03 22:25:05 +0000481 def test_ParseIssueNumberArgument(self):
482 def test(arg, *args, **kwargs):
483 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200484
Edward Lemur678a6842019-10-03 22:25:05 +0000485 test('123', 123)
486 test('', fail=True)
487 test('abc', fail=True)
488 test('123/1', fail=True)
489 test('123a', fail=True)
490 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200491
Edward Lemur678a6842019-10-03 22:25:05 +0000492 test('https://codereview.source.com/123',
493 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200494 test('http://chrome-review.source.com/c/123',
495 123, None, 'chrome-review.source.com')
496 test('https://chrome-review.source.com/c/123/',
497 123, None, 'chrome-review.source.com')
498 test('https://chrome-review.source.com/c/123/4',
499 123, 4, 'chrome-review.source.com')
500 test('https://chrome-review.source.com/#/c/123/4',
501 123, 4, 'chrome-review.source.com')
502 test('https://chrome-review.source.com/c/123/4',
503 123, 4, 'chrome-review.source.com')
504 test('https://chrome-review.source.com/123',
505 123, None, 'chrome-review.source.com')
506 test('https://chrome-review.source.com/123/4',
507 123, 4, 'chrome-review.source.com')
508
Edward Lemur678a6842019-10-03 22:25:05 +0000509 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200510 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
511 test('https://chrome-review.source.com/c/abc/', fail=True)
512 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
513
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200514
515
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100516class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100517 def setUp(self):
518 super(GitCookiesCheckerTest, self).setUp()
519 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100520 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100521
522 def mock_hosts_creds(self, subhost_identity_pairs):
523 def ensure_googlesource(h):
524 if not h.endswith(self.c._GOOGLESOURCE):
525 assert not h.endswith('.')
526 return h + '.' + self.c._GOOGLESOURCE
527 return h
528 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
529 for h, i in subhost_identity_pairs]
530
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200531 def test_identity_parsing(self):
532 self.assertEqual(self.c._parse_identity('ldap.google.com'),
533 ('ldap', 'google.com'))
534 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
535 ('ldap', 'example.com'))
536 # Specical case because we know there are no subdomains in chromium.org.
537 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
538 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800539 # Pathological: ".period." can be either username OR domain, more likely
540 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200541 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
542 ('note', 'period.example.com'))
543
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100544 def test_analysis_nothing(self):
545 self.c._all_hosts = []
546 self.assertFalse(self.c.has_generic_host())
547 self.assertEqual(set(), self.c.get_conflicting_hosts())
548 self.assertEqual(set(), self.c.get_duplicated_hosts())
549 self.assertEqual(set(), self.c.get_partially_configured_hosts())
550 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
551
552 def test_analysis(self):
553 self.mock_hosts_creds([
554 ('.googlesource.com', 'git-example.chromium.org'),
555
556 ('chromium', 'git-example.google.com'),
557 ('chromium-review', 'git-example.google.com'),
558 ('chrome-internal', 'git-example.chromium.org'),
559 ('chrome-internal-review', 'git-example.chromium.org'),
560 ('conflict', 'git-example.google.com'),
561 ('conflict-review', 'git-example.chromium.org'),
562 ('dup', 'git-example.google.com'),
563 ('dup', 'git-example.google.com'),
564 ('dup-review', 'git-example.google.com'),
565 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200566 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100567 ])
568 self.assertTrue(self.c.has_generic_host())
569 self.assertEqual(set(['conflict.googlesource.com']),
570 self.c.get_conflicting_hosts())
571 self.assertEqual(set(['dup.googlesource.com']),
572 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200573 self.assertEqual(set(['partial.googlesource.com',
574 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100575 self.c.get_partially_configured_hosts())
576 self.assertEqual(set(['chromium.googlesource.com',
577 'chrome-internal.googlesource.com']),
578 self.c.get_hosts_with_wrong_identities())
579
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100580 def test_report_no_problems(self):
581 self.test_analysis_nothing()
Edward Lemur79d4f992019-11-11 23:49:02 +0000582 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100583 self.assertFalse(self.c.find_and_report_problems())
584 self.assertEqual(sys.stdout.getvalue(), '')
585
586 def test_report(self):
587 self.test_analysis()
Edward Lemur79d4f992019-11-11 23:49:02 +0000588 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200589 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
590 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100591 self.assertTrue(self.c.find_and_report_problems())
592 with open(os.path.join(os.path.dirname(__file__),
593 'git_cl_creds_check_report.txt')) as f:
594 expected = f.read()
595 def by_line(text):
596 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700597 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200598 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100599
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800600
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000601class TestGitCl(TestCase):
602 def setUp(self):
603 super(TestGitCl, self).setUp()
604 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700605 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000606 self.mock(git_cl, 'time_time',
607 lambda: self._mocked_call('time.time'))
608 self.mock(git_cl.metrics.collector, 'add_repeated',
609 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000610 self.mock(subprocess2, 'call', self._mocked_call)
611 self.mock(subprocess2, 'check_call', self._mocked_call)
612 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700613 self.mock(subprocess2, 'communicate',
614 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000615 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000616 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000617 self.mock(git_common, 'get_or_create_merge_base',
618 lambda *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000619 self._mocked_call(['get_or_create_merge_base'] + list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000620 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000621 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000622 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
623 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100624 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000625 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700626 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000627 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000628 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000629 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
Edward Lemur5b929a42019-10-21 17:57:39 +0000630 self.mock(git_cl.auth, 'Authenticator', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100631 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
632 lambda *args, **kwargs: self._mocked_call(
633 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700634 self.mock(git_cl.gerrit_util, 'GetChangeComments',
635 lambda *args, **kwargs: self._mocked_call(
636 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000637 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
638 lambda *args, **kwargs: self._mocked_call(
639 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100640 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700641 lambda h, i, reviewers, ccs, notify: self._mocked_call(
642 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700643 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700644 lambda h, i, msg=None, labels=None, notify=None:
645 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700646 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
647 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000648 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
649 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000650 self.mock(git_cl.gerrit_util, 'ValidAccounts',
651 lambda host, accounts:
652 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700653 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100654 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000655 # It's important to reset settings to not have inter-tests interference.
656 git_cl.settings = None
657
658 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000659 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000660 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100661 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000662 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100663 raise
664 # Sadly, has_failed() returns True if this OR any other tests before this
665 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200666 git_cl.logging.error(
667 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100668 'There are un-consumed self.calls after this test has finished.\n'
669 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700670 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200671 'If you are already running only this test, then **first** fix the '
672 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100673 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700674 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100675 'and follow instructions above.\n' +
676 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000677 finally:
678 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000679
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000680 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000681 self.assertTrue(
682 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700683 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000684 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000685 expected_args, result = top
686
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000687 # Also logs otherwise it could get caught in a try/finally and be hard to
688 # diagnose.
689 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700690 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000691 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700692 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
693 for i, c in enumerate(self._calls_done[-N:]))
694 following_calls = '\n '.join(
695 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
696 for i, c in enumerate(self.calls[:N]))
697 extended_msg = (
698 'A few prior calls:\n %s\n\n'
699 'This (expected):\n @%d: %r\n'
700 'This (actual):\n @%d: %r\n\n'
701 'A few following expected calls:\n %s' %
702 (prior_calls, len(self._calls_done), expected_args,
703 len(self._calls_done), args, following_calls))
704 git_cl.logging.error(extended_msg)
705
tandrii99a72f22016-08-17 14:33:24 -0700706 self.fail('@%d\n'
707 ' Expected: %r\n'
708 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700709 len(self._calls_done), expected_args, args))
710
711 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700712 if isinstance(result, Exception):
713 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000714 # stdout from git commands is supposed to be a bytestream. Convert it here
715 # instead of converting all test output in this file to bytes.
716 if args[0][0] == 'git' and not isinstance(result, bytes):
717 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000718 return result
719
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100720 def test_ask_for_explicit_yes_true(self):
721 self.calls = [
722 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
723 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
724 ]
725 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
726
tandrii48df5812016-10-17 03:55:37 -0700727 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000728 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700729 self.calls = [
730 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700731 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
732 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
733 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
734 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700735 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
736 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700737 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
738 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000739 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
740 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700741 ((['git', 'config', 'gerrit.host', 'true'],), ''),
742 ]
743 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
744
maruel@chromium.orga3353652011-11-30 14:26:57 +0000745 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000746 def _is_gerrit_calls(cls, gerrit=False):
747 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
748 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
749
750 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000751 def _git_post_upload_calls(cls):
752 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000753 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
754 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
755 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000756 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000757 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000758 ]
759
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000760 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000761 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000762 fake_ancestor = 'fake_ancestor'
763 fake_cl = 'fake_cl_for_patch'
764 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000765 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000766 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000767 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000768 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000769 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000770 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000771 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000772 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700773 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000774 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000775 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000776 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000777 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000778 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000779 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000780 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000781 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000782 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000783 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000784 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000785
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000786 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000787 def _gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000788 cls, issue=None, skip_auth_check=False, short_hostname='chromium',
789 custom_cl_base=None):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000790 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000791 if skip_auth_check:
792 return [((cmd, ), 'true')]
793
tandrii5d48c322016-08-18 16:19:37 -0700794 calls = [((cmd, ), CERR1)]
Edward Lemurf38bc172019-09-03 21:02:13 +0000795
796 if custom_cl_base:
797 calls += [
798 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
799 ]
800
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000801 calls.extend([
802 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
803 ((['git', 'config', 'branch.master.remote'],), 'origin'),
804 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000805 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000806 ])
Edward Lemurf38bc172019-09-03 21:02:13 +0000807
808 calls += [
809 ((['git', 'config', 'branch.master.gerritissue'],),
810 CERR1 if issue is None else str(issue)),
811 ]
812
Daniel Chengcf6269b2019-05-18 01:02:12 +0000813 if issue:
814 calls.extend([
815 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
816 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000817 return calls
818
819 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100820 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200821 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000822 custom_cl_base=None, short_hostname='chromium',
823 change_id=None):
Aaron Gable13101a62018-02-09 13:20:41 -0800824 calls = cls._is_gerrit_calls(True)
Edward Lemurf38bc172019-09-03 21:02:13 +0000825 if not custom_cl_base:
826 calls += [
827 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
828 ]
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200829
830 if custom_cl_base:
831 ancestor_revision = custom_cl_base
832 else:
833 # Determine ancestor_revision to be merge base.
834 ancestor_revision = 'fake_ancestor_sha'
835 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000836 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000837 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000838 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200839 'refs/remotes/origin/master'],), ancestor_revision),
840 ]
841
842 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000843 calls += cls._gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000844 issue=issue, short_hostname=short_hostname,
845 custom_cl_base=custom_cl_base)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100846
847 if issue:
848 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000849 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000850 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000851 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
852 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100853 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100854 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Anthony Polito8b955342019-09-24 19:01:36 +0000855 'change_id': (change_id or '123456789'),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100856 'current_revision': 'sha1_of_current_revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000857 'revisions': {'sha1_of_current_revision': {
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100858 'commit': {'message': fetched_description},
859 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100860 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100861 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100862 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100863 if fetched_status == 'ABANDONED':
864 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000865 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100866 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000867 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100868 ]
869 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100870 if other_cl_owner:
871 calls += [
872 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
873 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100874
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200875 calls += cls._git_sanity_checks(ancestor_revision, 'master',
876 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100877 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200878 ((['git', 'rev-parse', '--show-cdup'],), ''),
879 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000880
Aaron Gable7817f022017-12-12 09:43:17 -0800881 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
882 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200883 'M\t.gitignore\n'),
884 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100885 ]
886
887 if not issue:
888 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200889 ((['git', 'log', '--pretty=format:%s%n%n%b',
890 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000891 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100892 ]
893
894 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200895 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000896 (('time.time',), 1000,),
897 (('time.time',), 3000,),
898 (('add_repeated', 'sub_commands', {
899 'execution_time': 2000,
900 'command': 'presubmit',
901 'exit_code': 0
902 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200903 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
904 ([custom_cl_base] if custom_cl_base else
905 [ancestor_revision, 'HEAD']),),
906 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100907 ]
908 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000909
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000910 @classmethod
911 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700912 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000913 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700914 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100915 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000916 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000917 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000918 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000919 final_description=None, gitcookies_exists=True,
Josipe827b0f2020-01-30 00:07:20 +0000920 force=False, edit_description=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000921 if post_amend_description is None:
922 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700923 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200924 # Determined in `_gerrit_base_calls`.
925 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
926
927 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000928
tandriia60502f2016-06-20 02:01:53 -0700929 if squash_mode == 'default':
930 calls.extend([
931 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
932 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
933 ])
934 elif squash_mode in ('override_squash', 'override_nosquash'):
935 calls.extend([
936 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
937 'true' if squash_mode == 'override_squash' else 'false'),
938 ])
939 else:
940 assert squash_mode in ('squash', 'nosquash')
941
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000942 # If issue is given, then description is fetched from Gerrit instead.
943 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000944 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200945 ((['git', 'log', '--pretty=format:%s\n\n%b',
946 ((custom_cl_base + '..') if custom_cl_base else
947 'fake_ancestor_sha..HEAD')],),
948 description),
949 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800950 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000951 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800952 else:
953 if not title:
954 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200955 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
956 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800957 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000958 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000959 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000960 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200961 (('DownloadGerritHook', False), ''),
962 # Amending of commit message to get the Change-Id.
963 ((['git', 'log', '--pretty=format:%s\n\n%b',
964 determined_ancestor_revision + '..HEAD'],),
965 description),
966 ((['git', 'commit', '--amend', '-m', description],), ''),
967 ((['git', 'log', '--pretty=format:%s\n\n%b',
968 determined_ancestor_revision + '..HEAD'],),
969 post_amend_description)
970 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000971 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000972 if force or not issue:
973 if issue:
974 calls += [
975 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
976 ]
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000977 # Prompting to edit description on first upload.
978 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000979 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000980 ]
Anthony Polito8b955342019-09-24 19:01:36 +0000981 if not force:
982 calls += [
983 ((['git', 'config', 'core.editor'],), ''),
984 ((['RunEditor'],), description),
985 ]
Josipe827b0f2020-01-30 00:07:20 +0000986 # user wants to edit description
987 if edit_description:
988 calls += [
989 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
990 ((['git', 'config', 'core.editor'],), ''),
991 ((['RunEditor'],), edit_description),
992 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000993 ref_to_push = 'abcdef0123456789'
994 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200995 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
996 ((['git', 'config', 'branch.master.remote'],), 'origin'),
997 ]
998
999 if custom_cl_base is None:
1000 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001001 ((['get_or_create_merge_base', 'master',
1002 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001003 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001004 ]
1005 parent = 'origin/master'
1006 else:
1007 calls += [
1008 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
1009 'refs/remotes/origin/master'],),
1010 callError(1)), # Means not ancenstor.
1011 (('ask_for_data',
1012 'Do you take responsibility for cleaning up potential mess '
1013 'resulting from proceeding with upload? Press Enter to upload, '
1014 'or Ctrl+C to abort'), ''),
1015 ]
1016 parent = custom_cl_base
1017
1018 calls += [
1019 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
1020 '0123456789abcdef'),
1021 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001022 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001023 ref_to_push),
1024 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001025 else:
1026 ref_to_push = 'HEAD'
1027
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001028 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001029 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001030 ((['git', 'rev-list',
1031 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1032 ref_to_push],),
1033 '1hashPerLine\n'),
1034 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001035
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001036 metrics_arguments = []
1037
Aaron Gableafd52772017-06-27 16:40:10 -07001038 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001039 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001040 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001041 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001042 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001043 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001044 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001045 else:
1046 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001047 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001048
Aaron Gable70f4e242017-06-26 10:45:59 -07001049 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001050 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001051 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001052
Edward Lemur4508b422019-10-03 21:56:35 +00001053 if issue is None:
1054 calls += [
1055 ((['git', 'config', 'rietveld.cc'],), ''),
1056 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001057 if short_hostname == 'chromium':
1058 # All reviwers and ccs get into ref_suffix.
1059 for r in sorted(reviewers):
1060 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001061 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +00001062 if issue is None:
1063 cc += ['chromium-reviews+test-more-cc@chromium.org', 'joe@example.com']
1064 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001065 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001066 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001067 reviewers, cc = [], []
1068 else:
1069 # TODO(crbug/877717): remove this case.
1070 calls += [
1071 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1072 sorted(reviewers) + ['joe@example.com',
1073 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1074 {
1075 e: {'email': e}
1076 for e in (reviewers + ['joe@example.com'] + cc)
1077 })
1078 ]
1079 for r in sorted(reviewers):
1080 if r != 'bad-account-or-email':
1081 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001082 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001083 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +00001084 if issue is None:
1085 cc += ['joe@example.com']
1086 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001087 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001088 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001089 if c in cc:
1090 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001091
Edward Lemur687ca902018-12-05 02:30:30 +00001092 for k, v in sorted((labels or {}).items()):
1093 ref_suffix += ',l=%s+%d' % (k, v)
1094 metrics_arguments.append('l=%s+%d' % (k, v))
1095
1096 if tbr:
1097 calls += [
1098 (('GetCodeReviewTbrScore',
1099 '%s-review.googlesource.com' % short_hostname,
1100 'my/repo'),
1101 2,),
1102 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001103
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001104 calls += [
1105 (('time.time',), 1000,),
1106 ((['git', 'push',
1107 'https://%s.googlesource.com/my/repo' % short_hostname,
1108 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1109 (('remote:\n'
1110 'remote: Processing changes: (\)\n'
1111 'remote: Processing changes: (|)\n'
1112 'remote: Processing changes: (/)\n'
1113 'remote: Processing changes: (-)\n'
1114 'remote: Processing changes: new: 1 (/)\n'
1115 'remote: Processing changes: new: 1, done\n'
1116 'remote:\n'
1117 'remote: New Changes:\n'
1118 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1119 ' XXX\n'
1120 'remote:\n'
1121 'To https://%s.googlesource.com/my/repo\n'
1122 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1123 ) % (short_hostname, short_hostname)),),
1124 (('time.time',), 2000,),
1125 (('add_repeated',
1126 'sub_commands',
1127 {
1128 'execution_time': 1000,
1129 'command': 'git push',
1130 'exit_code': 0,
1131 'arguments': sorted(metrics_arguments),
1132 }),
1133 None,),
1134 ]
1135
Edward Lemur1b52d872019-05-09 21:12:12 +00001136 final_description = final_description or post_amend_description.strip()
1137 original_title = original_title or title or '<untitled>'
1138 # Trace-related calls
1139 calls += [
1140 # Write a description with context for the current trace.
1141 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001142 'Thu Mar 16 20:00:41 2017\n'
1143 '%(short_hostname)s-review.googlesource.com\n'
1144 '%(change_id)s\n'
1145 '%(title)s\n'
1146 '%(description)s\n'
1147 '1000\n'
1148 '0\n'
1149 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001150 'short_hostname': short_hostname,
1151 'change_id': change_id,
1152 'description': final_description,
1153 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001154 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001155 }],),
1156 None,
1157 ),
1158 # Read traces and shorten git hashes.
1159 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1160 True,
1161 ),
1162 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1163 ('git-hash: 0123456789012345678901234567890123456789\n'
1164 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1165 ),
1166 ((['FileWrite', 'TEMP_DIR/trace-packet',
1167 'git-hash: 012345\n'
1168 'git-hash: abcdea\n'],),
1169 None,
1170 ),
1171 # Make zip file for the git traces.
1172 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1173 'TEMP_DIR'],),
1174 None,
1175 ),
1176 # Collect git config and gitcookies.
1177 ((['git', 'config', '-l'],),
1178 'git-config-output',
1179 ),
1180 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1181 None,
1182 ),
1183 ((['os.path.isfile', '~/.gitcookies'],),
1184 gitcookies_exists,
1185 ),
1186 ]
1187 if gitcookies_exists:
1188 calls += [
1189 ((['FileRead', '~/.gitcookies'],),
1190 'gitcookies 1/SECRET',
1191 ),
1192 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1193 None,
1194 ),
1195 ]
1196 calls += [
1197 # Make zip file for the git config and gitcookies.
1198 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1199 'TEMP_DIR'],),
1200 None,
1201 ),
1202 ]
1203
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001204 if squash:
1205 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001206 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001207 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001208 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001209 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001210 ((['git', 'config', 'branch.master.gerritsquashhash',
1211 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001212 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001213 # TODO(crbug/877717): this should never be used.
1214 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001215 calls += [
1216 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001217 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001218 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001219 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1220 notify),
1221 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001222 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001223 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001224 return calls
1225
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001226 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001227 self,
1228 upload_args,
1229 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001230 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001231 squash=True,
1232 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001233 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001234 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001235 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001236 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001237 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001238 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001239 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001240 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001241 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001242 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001243 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001244 labels=None,
1245 change_id=None,
1246 original_title=None,
1247 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001248 gitcookies_exists=True,
1249 force=False,
Josipe827b0f2020-01-30 00:07:20 +00001250 edit_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001251 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001252 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001253 if squash_mode is None:
1254 if '--no-squash' in upload_args:
1255 squash_mode = 'nosquash'
1256 elif '--squash' in upload_args:
1257 squash_mode = 'squash'
1258 else:
1259 squash_mode = 'default'
1260
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001261 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001262 cc = cc or []
Edward Lemur79d4f992019-11-11 23:49:02 +00001263 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001264 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001265 CookiesAuthenticatorMockFactory(
1266 same_auth=('git-owner.example.com', '', 'pass')))
Edward Lemur125d60a2019-09-13 18:25:41 +00001267 self.mock(git_cl.Changelist, '_GerritCommitMsgHookCheck',
tandrii16e0b4e2016-06-07 10:34:28 -07001268 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001269 self.mock(git_cl.gclient_utils, 'RunEditor',
1270 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001271 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1272 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001273 self.mock(git_cl.gclient_utils, 'FileRead',
1274 lambda path: self._mocked_call(['FileRead', path]))
1275 self.mock(git_cl.gclient_utils, 'FileWrite',
1276 lambda path, contents: self._mocked_call(
1277 ['FileWrite', path, contents]))
1278 self.mock(git_cl, 'datetime_now',
1279 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1280 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1281 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
Edward Lemur75391d42019-05-14 23:35:56 +00001282 self.mock(git_cl, 'TRACES_README_FORMAT',
1283 '%(now)s\n'
1284 '%(gerrit_host)s\n'
1285 '%(change_id)s\n'
1286 '%(title)s\n'
1287 '%(description)s\n'
1288 '%(execution_time)s\n'
1289 '%(exit_code)s\n'
1290 '%(trace_name)s')
Edward Lemur1b52d872019-05-09 21:12:12 +00001291 self.mock(git_cl.shutil, 'make_archive',
1292 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1293 self.mock(os.path, 'isfile',
1294 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001295
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001296 self.calls = self._gerrit_base_calls(
1297 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001298 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001299 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001300 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001301 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001302 short_hostname=short_hostname,
1303 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001304 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001305 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
Edward Lemur0db01f02019-11-12 22:01:51 +00001306 self, expected_content=description))
Aaron Gable9a03ae02017-11-03 11:31:07 -07001307 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001308 self.calls += self._gerrit_upload_calls(
1309 description, reviewers, squash,
1310 squash_mode=squash_mode,
1311 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001312 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001313 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001314 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001315 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001316 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001317 labels=labels,
1318 change_id=change_id,
1319 original_title=original_title,
1320 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001321 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001322 force=force,
1323 edit_description=edit_description)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001324 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001325 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001326 git_cl.main(['upload'] + upload_args)
1327
Edward Lemur1b52d872019-05-09 21:12:12 +00001328 def test_gerrit_upload_traces_no_gitcookies(self):
1329 self._run_gerrit_upload_test(
1330 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001331 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001332 [],
1333 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001334 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001335 change_id='Ixxx',
1336 gitcookies_exists=False)
1337
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001338 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001339 self._run_gerrit_upload_test(
1340 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001341 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001342 [],
1343 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001344 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001345 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001346
1347 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001348 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001349 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001350 'desc ✔\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001351 [],
tandriia60502f2016-06-20 02:01:53 -07001352 squash=False,
1353 squash_mode='override_nosquash',
Edward Lemur0db01f02019-11-12 22:01:51 +00001354 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001355 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001356
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001357 def test_gerrit_no_reviewer(self):
1358 self._run_gerrit_upload_test(
1359 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001360 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001361 [],
1362 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001363 squash_mode='override_nosquash',
1364 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001365
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001366 def test_gerrit_no_reviewer_non_chromium_host(self):
1367 # TODO(crbug/877717): remove this test case.
1368 self._run_gerrit_upload_test(
1369 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001370 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001371 [],
1372 squash=False,
1373 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001374 short_hostname='other',
1375 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001376
Nick Carter8692b182017-11-06 16:30:38 -08001377 def test_gerrit_patchset_title_special_chars(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00001378 self.mock(git_cl.sys, 'stdout', StringIO())
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001379 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001380 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001381 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001382 squash=False,
1383 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001384 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1385 change_id='I123456789',
1386 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001387
ukai@chromium.orge8077812012-02-03 03:41:46 +00001388 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001389 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001390 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001391 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001392 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001393 squash=False,
1394 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001395 notify=True,
1396 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001397 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001398 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001399
Anthony Polito8b955342019-09-24 19:01:36 +00001400 def test_gerrit_upload_force_sets_bug(self):
1401 self._run_gerrit_upload_test(
1402 ['-b', '10000', '-f'],
1403 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1404 [],
1405 force=True,
1406 expected_upstream_ref='origin/master',
1407 fetched_description='desc=\n\nChange-Id: Ixxx',
1408 original_title='Initial upload',
1409 change_id='Ixxx')
1410
1411 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1412 self._run_gerrit_upload_test(
1413 ['-b', '10000', '-f', '-m', 'Title'],
1414 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1415 [],
1416 force=True,
1417 issue='123456',
1418 expected_upstream_ref='origin/master',
1419 fetched_description='desc=\n\nChange-Id: Ixxxx',
1420 original_title='Title',
1421 title='Title',
1422 change_id='Izzzz')
1423
Dan Beamd8b04ca2019-10-10 21:23:26 +00001424 def test_gerrit_upload_force_sets_fixed(self):
1425 self._run_gerrit_upload_test(
1426 ['-x', '10000', '-f'],
1427 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1428 [],
1429 force=True,
1430 expected_upstream_ref='origin/master',
1431 fetched_description='desc=\n\nChange-Id: Ixxx',
1432 original_title='Initial upload',
1433 change_id='Ixxx')
1434
ukai@chromium.orge8077812012-02-03 03:41:46 +00001435 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001436 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1437 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001438 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001439 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001440 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001441 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001442 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001443 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001444 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001445 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001446 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001447 labels={'Code-Review': 2},
1448 change_id='123456789',
1449 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001450
1451 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001452 self._run_gerrit_upload_test(
1453 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001454 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001455 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001456 expected_upstream_ref='origin/master',
1457 change_id='123456789',
1458 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001459
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001460 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001461 self._run_gerrit_upload_test(
1462 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001463 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001464 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001465 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001466 expected_upstream_ref='origin/master',
1467 change_id='123456789',
1468 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001469
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001470 def test_gerrit_upload_squash_first_with_labels(self):
1471 self._run_gerrit_upload_test(
1472 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001473 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001474 [],
1475 squash=True,
1476 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001477 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1478 change_id='123456789',
1479 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001480
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001481 def test_gerrit_upload_squash_first_against_rev(self):
1482 custom_cl_base = 'custom_cl_base_rev_or_branch'
1483 self._run_gerrit_upload_test(
1484 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001485 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001486 [],
1487 squash=True,
1488 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001489 custom_cl_base=custom_cl_base,
1490 change_id='123456789',
1491 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001492 self.assertIn(
1493 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1494 sys.stdout.getvalue())
1495
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001496 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001497 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001498 self._run_gerrit_upload_test(
1499 ['--squash'],
1500 description,
1501 [],
1502 squash=True,
1503 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001504 issue=123456,
1505 change_id='123456789',
1506 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001507
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001508 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1509 self.mock(git_cl, 'DieWithError',
1510 lambda msg, change=None: self._mocked_call('DieWithError', msg))
Edward Lemur0db01f02019-11-12 22:01:51 +00001511 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001512 with self.assertRaises(SystemExitMock):
1513 self._run_gerrit_upload_test(
1514 ['--squash'],
1515 description,
1516 [],
1517 squash=True,
1518 expected_upstream_ref='origin/master',
1519 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001520 fetched_status='ABANDONED',
1521 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001522
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001523 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1524 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1525 lambda *_, **__: {'email': 'yet-another@example.com'})
Edward Lemur0db01f02019-11-12 22:01:51 +00001526 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001527 self._run_gerrit_upload_test(
1528 ['--squash'],
1529 description,
1530 [],
1531 squash=True,
1532 expected_upstream_ref='origin/master',
1533 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001534 other_cl_owner='other@example.com',
1535 change_id='123456789',
1536 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001537 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001538 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001539 'authenticate to Gerrit as yet-another@example.com.\n'
1540 'Uploading may fail due to lack of permissions',
1541 git_cl.sys.stdout.getvalue())
1542
Josipe827b0f2020-01-30 00:07:20 +00001543 def test_upload_change_description_editor(self):
1544 fetched_description = 'foo\n\nChange-Id: 123456789'
1545 description = 'bar\n\nChange-Id: 123456789'
1546 self._run_gerrit_upload_test(
1547 ['--squash', '--edit-description'],
1548 description,
1549 [],
1550 fetched_description=fetched_description,
1551 squash=True,
1552 expected_upstream_ref='origin/master',
1553 issue=123456,
1554 change_id='123456789',
1555 original_title='User input',
1556 edit_description=description)
1557
rmistry@google.com2dd99862015-06-22 12:22:18 +00001558 def test_upload_branch_deps(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00001559 self.mock(git_cl.sys, 'stdout', StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001560 def mock_run_git(*args, **_kwargs):
1561 if args[0] == ['for-each-ref',
1562 '--format=%(refname:short) %(upstream:short)',
1563 'refs/heads']:
1564 # Create a local branch dependency tree that looks like this:
1565 # test1 -> test2 -> test3 -> test4 -> test5
1566 # -> test3.1
1567 # test6 -> test0
1568 branch_deps = [
1569 'test2 test1', # test1 -> test2
1570 'test3 test2', # test2 -> test3
1571 'test3.1 test2', # test2 -> test3.1
1572 'test4 test3', # test3 -> test4
1573 'test5 test4', # test4 -> test5
1574 'test6 test0', # test0 -> test6
1575 'test7', # test7
1576 ]
1577 return '\n'.join(branch_deps)
1578 self.mock(git_cl, 'RunGit', mock_run_git)
1579
1580 class RecordCalls:
1581 times_called = 0
1582 record_calls = RecordCalls()
1583 def mock_CMDupload(*args, **_kwargs):
1584 record_calls.times_called += 1
1585 return 0
1586 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1587
1588 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001589 (('ask_for_data', 'This command will checkout all dependent branches '
1590 'and run "git cl upload". Press Enter to continue, '
1591 'or Ctrl+C to abort'), ''),
1592 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001593
1594 class MockChangelist():
1595 def __init__(self):
1596 pass
1597 def GetBranch(self):
1598 return 'test1'
1599 def GetIssue(self):
1600 return '123'
1601 def GetPatchset(self):
1602 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001603 def IsGerrit(self):
1604 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001605
1606 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1607 # CMDupload should have been called 5 times because of 5 dependent branches.
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001608 self.assertEqual(5, record_calls.times_called)
1609 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001610
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001611 def test_gerrit_change_id(self):
1612 self.calls = [
1613 ((['git', 'write-tree'], ),
1614 'hashtree'),
1615 ((['git', 'rev-parse', 'HEAD~0'], ),
1616 'branch-parent'),
1617 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1618 'A B <a@b.org> 1456848326 +0100'),
1619 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1620 'C D <c@d.org> 1456858326 +0100'),
1621 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1622 'hashchange'),
1623 ]
1624 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1625 self.assertEqual(change_id, 'Ihashchange')
1626
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001627 def test_desecription_append_footer(self):
1628 for init_desc, footer_line, expected_desc in [
1629 # Use unique desc first lines for easy test failure identification.
1630 ('foo', 'R=one', 'foo\n\nR=one'),
1631 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1632 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1633 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1634 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1635 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1636 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1637 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1638 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1639 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1640 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1641 ]:
1642 desc = git_cl.ChangeDescription(init_desc)
1643 desc.append_footer(footer_line)
1644 self.assertEqual(desc.description, expected_desc)
1645
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001646 def test_update_reviewers(self):
1647 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001648 ('foo', [], [],
1649 'foo'),
1650 ('foo\nR=xx', [], [],
1651 'foo\nR=xx'),
1652 ('foo\nTBR=xx', [], [],
1653 'foo\nTBR=xx'),
1654 ('foo', ['a@c'], [],
1655 'foo\n\nR=a@c'),
1656 ('foo\nR=xx', ['a@c'], [],
1657 'foo\n\nR=a@c, xx'),
1658 ('foo\nTBR=xx', ['a@c'], [],
1659 'foo\n\nR=a@c\nTBR=xx'),
1660 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1661 'foo\n\nR=a@c, yy\nTBR=xx'),
1662 ('foo\nBUG=', ['a@c'], [],
1663 'foo\nBUG=\nR=a@c'),
1664 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1665 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1666 ('foo', ['a@c', 'b@c'], [],
1667 'foo\n\nR=a@c, b@c'),
1668 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1669 'foo\nBar\n\nR=c@c\nBUG='),
1670 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1671 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001672 # Same as the line before, but full of whitespaces.
1673 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001674 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001675 'foo\nBar\n\nR=c@c\n BUG =',
1676 ),
1677 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001678 ('foo BUG=allo R=joe ', ['c@c'], [],
1679 'foo BUG=allo R=joe\n\nR=c@c'),
1680 # Redundant TBRs get promoted to Rs
1681 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1682 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001683 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001684 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001685 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001686 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001687 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001688 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001689 actual.append(obj.description)
1690 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001691
Nodir Turakulov23b82142017-11-16 11:04:25 -08001692 def test_get_hash_tags(self):
1693 cases = [
1694 ('', []),
1695 ('a', []),
1696 ('[a]', ['a']),
1697 ('[aa]', ['aa']),
1698 ('[a ]', ['a']),
1699 ('[a- ]', ['a']),
1700 ('[a- b]', ['a-b']),
1701 ('[a--b]', ['a-b']),
1702 ('[a', []),
1703 ('[a]x', ['a']),
1704 ('[aa]x', ['aa']),
1705 ('[a b]', ['a-b']),
1706 ('[a b]', ['a-b']),
1707 ('[a__b]', ['a-b']),
1708 ('[a] x', ['a']),
1709 ('[a][b]', ['a', 'b']),
1710 ('[a] [b]', ['a', 'b']),
1711 ('[a][b]x', ['a', 'b']),
1712 ('[a][b] x', ['a', 'b']),
1713 ('[a]\n[b]', ['a']),
1714 ('[a\nb]', []),
1715 ('[a][', ['a']),
1716 ('Revert "[a] feature"', ['a']),
1717 ('Reland "[a] feature"', ['a']),
1718 ('Revert: [a] feature', ['a']),
1719 ('Reland: [a] feature', ['a']),
1720 ('Revert "Reland: [a] feature"', ['a']),
1721 ('Foo: feature', ['foo']),
1722 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001723 ('Change Foo::Bar', []),
1724 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001725 ('Revert "Foo bar: feature"', ['foo-bar']),
1726 ('Reland "Foo bar: feature"', ['foo-bar']),
1727 ]
1728 for desc, expected in cases:
1729 change_desc = git_cl.ChangeDescription(desc)
1730 actual = change_desc.get_hash_tags()
1731 self.assertEqual(
1732 actual,
1733 expected,
1734 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1735
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001736 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001737 self.assertEqual(None, git_cl.GetTargetRef(None,
1738 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001739 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001740
wittman@chromium.org455dc922015-01-26 20:15:50 +00001741 # Check default target refs for branches.
1742 self.assertEqual('refs/heads/master',
1743 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001744 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001745 self.assertEqual('refs/heads/master',
1746 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001747 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001748 self.assertEqual('refs/heads/master',
1749 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001750 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001751 self.assertEqual('refs/branch-heads/123',
1752 git_cl.GetTargetRef('origin',
1753 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001754 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001755 self.assertEqual('refs/diff/test',
1756 git_cl.GetTargetRef('origin',
1757 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001758 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001759 self.assertEqual('refs/heads/chrome/m42',
1760 git_cl.GetTargetRef('origin',
1761 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001762 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001763
1764 # Check target refs for user-specified target branch.
1765 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1766 'refs/remotes/branch-heads/123'):
1767 self.assertEqual('refs/branch-heads/123',
1768 git_cl.GetTargetRef('origin',
1769 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001770 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001771 for branch in ('origin/master', 'remotes/origin/master',
1772 'refs/remotes/origin/master'):
1773 self.assertEqual('refs/heads/master',
1774 git_cl.GetTargetRef('origin',
1775 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001776 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001777 for branch in ('master', 'heads/master', 'refs/heads/master'):
1778 self.assertEqual('refs/heads/master',
1779 git_cl.GetTargetRef('origin',
1780 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001781 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001782
wychen@chromium.orga872e752015-04-28 23:42:18 +00001783 def test_patch_when_dirty(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001784 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001785 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1786 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1787
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001788 @staticmethod
1789 def _get_gerrit_codereview_server_calls(branch, value=None,
1790 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001791 detect_branch=True,
1792 detect_server=True):
Edward Lemur125d60a2019-09-13 18:25:41 +00001793 """Returns calls executed by Changelist.GetCodereviewServer.
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001794
1795 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1796 """
1797 calls = []
1798 if detect_branch:
1799 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001800 if detect_server:
1801 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1802 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001803 if value is None:
1804 calls += [
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001805 ((['git', 'config', 'branch.' + branch + '.merge'],),
1806 'refs/heads' + branch),
1807 ((['git', 'config', 'branch.' + branch + '.remote'],),
1808 'origin'),
1809 ((['git', 'config', 'remote.origin.url'],),
1810 'https://%s.googlesource.com/my/repo' % git_short_host),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001811 ]
1812 return calls
1813
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001814 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001815 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001816 detect_gerrit_server=False,
1817 actual_codereview=None,
1818 codereview_in_url=False):
Edward Lemur79d4f992019-11-11 23:49:02 +00001819 self.mock(git_cl.sys, 'stdout', StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001820 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1821
tandriidf09a462016-08-18 16:23:55 -07001822 if new_branch:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001823 self.calls = [((['git', 'new-branch', 'master'],), '')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001824
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001825 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001826 self.calls += [
1827 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001828 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001829 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001830
1831 if not force_codereview and not codereview_in_url:
1832 # These calls detect codereview to use.
1833 self.calls += [
1834 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001835 ]
1836 if detect_gerrit_server:
1837 self.calls += self._get_gerrit_codereview_server_calls(
1838 'master', git_short_host=git_short_host,
1839 detect_branch=not new_branch and force_codereview)
1840 actual_codereview = 'gerrit'
1841
1842 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001843 self.calls += [
1844 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001845 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001846 {
1847 'current_revision': '7777777777',
1848 'revisions': {
1849 '1111111111': {
1850 '_number': 1,
1851 'fetch': {'http': {
1852 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1853 'ref': 'refs/changes/56/123456/1',
1854 }},
1855 },
1856 '7777777777': {
1857 '_number': 7,
1858 'fetch': {'http': {
1859 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1860 'ref': 'refs/changes/56/123456/7',
1861 }},
1862 },
1863 },
1864 }),
1865 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001866
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001867 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001868 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001869 self.calls += [
1870 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1871 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001872 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001873 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001874 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001875 ((['git', 'config', 'branch.master.gerritserver',
1876 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001877 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001878 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1879 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1880 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001881 ]
1882 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1883
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001884 def test_patch_gerrit_new_branch(self):
1885 self._patch_common(
1886 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1887 self.calls += [
1888 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1889 'refs/changes/56/123456/7'],), ''),
1890 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1891 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1892 ''),
1893 ((['git', 'config', 'branch.master.gerritserver',
1894 'https://chromium-review.googlesource.com'],), ''),
1895 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1896 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1897 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1898 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1899 ]
1900 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1901
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001902 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001903 self._patch_common(
1904 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001905 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001906 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001907 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001908 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001909 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001910 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001911 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001912 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001913 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001914 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1915 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1916 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001917 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001918 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001919
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001920 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001921 self.calls += self._get_gerrit_codereview_server_calls(
1922 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001923 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001924 actual_codereview='gerrit', git_short_host='else',
1925 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001926 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001927 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001928 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001929 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001930 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001931 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001932 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001933 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001934 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001935 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1936 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1937 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001938 ]
1939 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001940 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001941
Aaron Gable697a91b2018-01-19 15:20:15 -08001942 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001943 self.calls += self._get_gerrit_codereview_server_calls(
1944 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001945 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001946 actual_codereview='gerrit', git_short_host='else',
1947 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001948 self.calls += [
1949 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1950 'refs/changes/56/123456/1'],), ''),
1951 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1952 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1953 ''),
1954 ((['git', 'config', 'branch.master.gerritserver',
1955 'https://else-review.googlesource.com'],), ''),
1956 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1957 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1958 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1959 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1960 ]
1961 self.assertEqual(git_cl.main(
1962 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1963 0)
1964
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001965 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001966 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001967 self.calls += [
1968 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001969 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001970 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1971 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1972 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001973 ]
1974 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001975 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001976
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001977 def test_patch_gerrit_not_exists(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001978
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001979 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001980 raise git_cl.gerrit_util.GerritError(404, '')
1981 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1982
tandriic2405f52016-10-10 08:13:15 -07001983 self.calls = [
1984 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001985 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1986 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1987 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1988 ((['git', 'config', 'remote.origin.url'],),
1989 'https://chromium.googlesource.com/my/repo'),
1990 ((['DieWithError',
1991 'change 123456 at https://chromium-review.googlesource.com does not '
1992 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001993 ]
1994 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001995 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001996
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001997 def _checkout_calls(self):
1998 return [
1999 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002000 'branch\\..*\\.gerritissue'], ),
2001 ('branch.ger-branch.gerritissue 123456\n'
2002 'branch.gbranch654.gerritissue 654321\n')),
2003 ]
2004
2005 def test_checkout_gerrit(self):
2006 """Tests git cl checkout <issue>."""
2007 self.calls = self._checkout_calls()
2008 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
2009 self.assertEqual(0, git_cl.main(['checkout', '123456']))
2010
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002011 def test_checkout_not_found(self):
2012 """Tests git cl checkout <issue>."""
Edward Lemur79d4f992019-11-11 23:49:02 +00002013 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002014 self.calls = self._checkout_calls()
2015 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2016
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002017 def test_checkout_no_branch_issues(self):
2018 """Tests git cl checkout <issue>."""
Edward Lemur79d4f992019-11-11 23:49:02 +00002019 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002020 self.calls = [
2021 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07002022 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002023 ]
2024 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2025
tandrii@chromium.org28253532016-04-14 13:46:56 +00002026 def _test_gerrit_ensure_authenticated_common(self, auth,
2027 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002028 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2029 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
2030 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11002031 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00002032 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
Edward Lemurf38bc172019-09-03 21:02:13 +00002033 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00002034 cl.branch = 'master'
2035 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002036 return cl
2037
2038 def test_gerrit_ensure_authenticated_missing(self):
2039 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002040 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002041 })
2042 self.calls.append(
2043 ((['DieWithError',
2044 'Credentials for the following hosts are required:\n'
2045 ' chromium-review.googlesource.com\n'
2046 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002047 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002048 'https://chromium-review.googlesource.com/new-password'],), ''),)
2049 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2050
2051 def test_gerrit_ensure_authenticated_conflict(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002052 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002053 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002054 'chromium.googlesource.com':
2055 ('git-one.example.com', None, 'secret1'),
2056 'chromium-review.googlesource.com':
2057 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002058 })
2059 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002060 (('ask_for_data', 'If you know what you are doing '
2061 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002062 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2063
2064 def test_gerrit_ensure_authenticated_ok(self):
2065 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002066 'chromium.googlesource.com':
2067 ('git-same.example.com', None, 'secret'),
2068 'chromium-review.googlesource.com':
2069 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002070 })
2071 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2072
tandrii@chromium.org28253532016-04-14 13:46:56 +00002073 def test_gerrit_ensure_authenticated_skipped(self):
2074 cl = self._test_gerrit_ensure_authenticated_common(
2075 auth={}, skip_auth_check=True)
2076 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2077
Eric Boren2fb63102018-10-05 13:05:03 +00002078 def test_gerrit_ensure_authenticated_bearer_token(self):
2079 cl = self._test_gerrit_ensure_authenticated_common(auth={
2080 'chromium.googlesource.com':
2081 ('', None, 'secret'),
2082 'chromium-review.googlesource.com':
2083 ('', None, 'secret'),
2084 })
2085 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2086 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2087 'chromium.googlesource.com')
2088 self.assertTrue('Bearer' in header)
2089
Daniel Chengcf6269b2019-05-18 01:02:12 +00002090 def test_gerrit_ensure_authenticated_non_https(self):
2091 self.calls = [
2092 ((['git', 'config', '--bool',
2093 'gerrit.skip-ensure-authenticated'],), CERR1),
2094 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2095 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2096 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
Josip906bfde2020-01-31 22:38:49 +00002097 (('logging.warning',
2098 'Ignoring branch %(branch)s with non-https remote '
2099 '%(remote)s', {
2100 'branch': 'master',
2101 'remote': 'custom-scheme://repo'}
2102 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00002103 ]
2104 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2105 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
Josip906bfde2020-01-31 22:38:49 +00002106 self.mock(logging, 'warning',
2107 lambda *a: self._mocked_call('logging.warning', *a))
Edward Lemurf38bc172019-09-03 21:02:13 +00002108 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002109 cl.branch = 'master'
2110 cl.branchref = 'refs/heads/master'
2111 cl.lookedup_issue = True
2112 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2113
Florian Mayerae510e82020-01-30 21:04:48 +00002114 def test_gerrit_ensure_authenticated_non_url(self):
2115 self.calls = [
2116 ((['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated'], ),
2117 CERR1),
2118 ((['git', 'config', 'branch.master.merge'], ), 'refs/heads/master'),
2119 ((['git', 'config', 'branch.master.remote'], ), 'origin'),
2120 ((['git', 'config', 'remote.origin.url'], ),
2121 'git@somehost.example:foo/bar.git'),
Josip906bfde2020-01-31 22:38:49 +00002122 (('logging.error',
2123 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2124 'but it doesn\'t exist.', {
2125 'remote': 'origin',
2126 'branch': 'master',
2127 'url': 'git@somehost.example:foo/bar.git'}
2128 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00002129 ]
2130 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2131 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
Josip906bfde2020-01-31 22:38:49 +00002132 self.mock(logging, 'error',
2133 lambda *a: self._mocked_call('logging.error', *a))
Florian Mayerae510e82020-01-30 21:04:48 +00002134 cl = git_cl.Changelist()
2135 cl.branch = 'master'
2136 cl.branchref = 'refs/heads/master'
2137 cl.lookedup_issue = True
2138 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2139
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002140 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002141 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002142 lambda h, i, labels, notify=None:
2143 self._mocked_call(['SetReview', h, i, labels, notify]))
2144
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002145 self.calls = [
2146 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002147 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002148 ((['git', 'config', 'branch.feature.gerritserver'],),
2149 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002150 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2151 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2152 ((['git', 'config', 'remote.origin.url'],),
2153 'https://chromium.googlesource.com/infra/infra.git'),
2154 ((['SetReview', 'chromium-review.googlesource.com',
2155 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002156 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002157 ]
tandriid9e5ce52016-07-13 02:32:59 -07002158
2159 def test_cmd_set_commit_gerrit_clear(self):
2160 self._cmd_set_commit_gerrit_common(0)
2161 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2162
2163 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002164 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002165 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2166
tandriid9e5ce52016-07-13 02:32:59 -07002167 def test_cmd_set_commit_gerrit(self):
2168 self._cmd_set_commit_gerrit_common(2)
2169 self.assertEqual(0, git_cl.main(['set-commit']))
2170
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002171 def test_description_display(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002172 out = StringIO()
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002173 self.mock(git_cl.sys, 'stdout', out)
2174
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002175 self.mock(git_cl, 'Changelist', ChangelistMock)
2176 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002177
2178 self.assertEqual(0, git_cl.main(['description', '-d']))
2179 self.assertEqual('foo\n', out.getvalue())
2180
iannucci3c972b92016-08-17 13:24:10 -07002181 def test_StatusFieldOverrideIssueMissingArgs(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002182 out = StringIO()
iannucci3c972b92016-08-17 13:24:10 -07002183 self.mock(git_cl.sys, 'stderr', out)
2184
2185 try:
2186 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2187 except SystemExit as ex:
2188 self.assertEqual(ex.code, 2)
Edward Lemurf38bc172019-09-03 21:02:13 +00002189 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002190
Edward Lemur79d4f992019-11-11 23:49:02 +00002191 out = StringIO()
iannucci3c972b92016-08-17 13:24:10 -07002192 self.mock(git_cl.sys, 'stderr', out)
2193
2194 try:
Edward Lemur52969c92020-02-06 18:15:28 +00002195 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002196 except SystemExit as ex:
2197 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002198 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002199
2200 def test_StatusFieldOverrideIssue(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002201 out = StringIO()
iannucci3c972b92016-08-17 13:24:10 -07002202 self.mock(git_cl.sys, 'stdout', out)
2203
2204 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002205 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002206 return 'foobar'
2207
2208 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002209 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002210 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002211 0)
iannucci3c972b92016-08-17 13:24:10 -07002212 self.assertEqual(out.getvalue(), 'foobar\n')
2213
iannuccie53c9352016-08-17 14:40:40 -07002214 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002215
iannuccie53c9352016-08-17 14:40:40 -07002216 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002217 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002218 return 'foobar'
2219
2220 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2221 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002222 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002223 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002224
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002225 def test_description(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002226 out = StringIO()
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002227 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002228 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002229 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2230 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2231 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2232 ((['git', 'config', 'remote.origin.url'],),
2233 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002234 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002235 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002236 {
2237 'current_revision': 'sha1',
2238 'revisions': {'sha1': {
2239 'commit': {'message': 'foobar'},
2240 }},
2241 }),
2242 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002243 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002244 'description',
2245 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2246 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002247 self.assertEqual('foobar\n', out.getvalue())
2248
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002249 def test_description_set_raw(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002250 out = StringIO()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002251 self.mock(git_cl.sys, 'stdout', out)
2252
2253 self.mock(git_cl, 'Changelist', ChangelistMock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002254 self.mock(git_cl.sys, 'stdin', StringIO('hihi'))
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002255
2256 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2257 self.assertEqual('hihi', ChangelistMock.desc)
2258
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002259 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002260 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002261
2262 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002263 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002264 '# Enter a description of the change.\n'
2265 '# This will be displayed on the codereview site.\n'
2266 '# The first line will also be used as the subject of the review.\n'
2267 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002268 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002269 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002270 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002271 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002272 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002273
dsansomee2d6fd92016-09-08 00:10:47 -07002274 def UpdateDescriptionRemote(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002275 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002276
Edward Lemur79d4f992019-11-11 23:49:02 +00002277 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002278 self.mock(git_cl.Changelist, 'GetDescription',
2279 lambda *args: current_desc)
Edward Lemur125d60a2019-09-13 18:25:41 +00002280 self.mock(git_cl.Changelist, 'UpdateDescriptionRemote',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002281 UpdateDescriptionRemote)
2282 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2283
2284 self.calls = [
2285 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002286 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002287 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2288 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002289 ((['git', 'config', 'core.editor'],), 'vi'),
2290 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002291 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002292
Dan Beamd8b04ca2019-10-10 21:23:26 +00002293 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2294 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2295
2296 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002297 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002298 '# Enter a description of the change.\n'
2299 '# This will be displayed on the codereview site.\n'
2300 '# The first line will also be used as the subject of the review.\n'
2301 '#--------------------This line is 72 characters long'
2302 '--------------------\n'
2303 'Some.\n\nFixed: 123\nChange-Id: xxx',
2304 desc)
2305 return desc
2306
Edward Lemur79d4f992019-11-11 23:49:02 +00002307 self.mock(git_cl.sys, 'stdout', StringIO())
Dan Beamd8b04ca2019-10-10 21:23:26 +00002308 self.mock(git_cl.Changelist, 'GetDescription',
2309 lambda *args: current_desc)
2310 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2311
2312 self.calls = [
2313 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2314 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2315 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2316 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
2317 ((['git', 'config', 'core.editor'],), 'vi'),
2318 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002319 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002320
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002321 def test_description_set_stdin(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002322 out = StringIO()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002323 self.mock(git_cl.sys, 'stdout', out)
2324
2325 self.mock(git_cl, 'Changelist', ChangelistMock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002326 self.mock(git_cl.sys, 'stdin', StringIO('hi \r\n\t there\n\nman'))
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002327
2328 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2329 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2330
kmarshall3bff56b2016-06-06 18:31:47 -07002331 def test_archive(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002332 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii1c67da62016-06-10 07:35:53 -07002333
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002334 self.calls = [
2335 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002336 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002337 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002338 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2339 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002340 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002341 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002342
kmarshall3bff56b2016-06-06 18:31:47 -07002343 self.mock(git_cl, 'get_cl_statuses',
2344 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002345 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2346 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2347 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002348
2349 self.assertEqual(0, git_cl.main(['archive', '-f']))
2350
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002351 def test_archive_tag_collision(self):
2352 self.mock(git_cl.sys, 'stdout', StringIO())
2353
2354 self.calls = [
2355 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2356 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2357 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2358 'refs/tags/git-cl-archived-456-foo'),
2359 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2360 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2361 ((['git', 'branch', '-D', 'foo'],), '')
2362 ]
2363
2364 self.mock(git_cl, 'get_cl_statuses',
2365 lambda branches, fine_grained, max_processes:
2366 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2367 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2368 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2369
2370 self.assertEqual(0, git_cl.main(['archive', '-f']))
2371
kmarshall3bff56b2016-06-06 18:31:47 -07002372 def test_archive_current_branch_fails(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002373 self.mock(git_cl.sys, 'stdout', StringIO())
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002374 self.calls = [
2375 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2376 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002377 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002378 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2379 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002380
kmarshall9249e012016-08-23 12:02:16 -07002381 self.mock(git_cl, 'get_cl_statuses',
2382 lambda branches, fine_grained, max_processes:
2383 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2384
2385 self.assertEqual(1, git_cl.main(['archive', '-f']))
2386
2387 def test_archive_dry_run(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002388 self.mock(git_cl.sys, 'stdout', StringIO())
kmarshall9249e012016-08-23 12:02:16 -07002389
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002390 self.calls = [
2391 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2392 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002393 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002394 ((['git', 'symbolic-ref', 'HEAD'],), 'master')
2395 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002396
2397 self.mock(git_cl, 'get_cl_statuses',
2398 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002399 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2400 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2401 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002402
kmarshall9249e012016-08-23 12:02:16 -07002403 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2404
2405 def test_archive_no_tags(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002406 self.mock(git_cl.sys, 'stdout', StringIO())
kmarshall9249e012016-08-23 12:02:16 -07002407
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002408 self.calls = [
2409 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2410 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002411 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002412 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2413 ((['git', 'branch', '-D', 'foo'],), '')
2414 ]
kmarshall9249e012016-08-23 12:02:16 -07002415
2416 self.mock(git_cl, 'get_cl_statuses',
2417 lambda branches, fine_grained, max_processes:
2418 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2419 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2420 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2421
2422 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002423
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002424 def test_archive_tag_cleanup_on_branch_deletion_error(self):
2425 self.mock(git_cl.sys, 'stdout', StringIO())
2426
2427 self.calls = [
2428 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2429 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2430 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
2431 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2432 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2433 'refs/tags/git-cl-archived-456-foo'),
2434 ((['git', 'branch', '-D', 'foo'],), CERR1),
2435 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2436 'refs/tags/git-cl-archived-456-foo'),
2437 ]
2438
2439 self.mock(git_cl, 'get_cl_statuses',
2440 lambda branches, fine_grained, max_processes:
2441 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2442 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2443 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2444
2445 self.assertEqual(0, git_cl.main(['archive', '-f']))
2446
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002447 def test_cmd_issue_erase_existing(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002448 out = StringIO()
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002449 self.mock(git_cl.sys, 'stdout', out)
2450 self.calls = [
2451 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002452 # Let this command raise exception (retcode=1) - it should be ignored.
2453 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002454 CERR1),
2455 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2456 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002457 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2458 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2459 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002460 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002461 ]
2462 self.assertEqual(0, git_cl.main(['issue', '0']))
2463
Aaron Gable400e9892017-07-12 15:31:21 -07002464 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002465 out = StringIO()
Aaron Gable400e9892017-07-12 15:31:21 -07002466 self.mock(git_cl.sys, 'stdout', out)
2467 self.mock(git_cl.Changelist, 'GetDescription',
2468 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2469 self.calls = [
2470 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002471 # Let this command raise exception (retcode=1) - it should be ignored.
2472 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2473 CERR1),
2474 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2475 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2476 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2477 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2478 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002479 ((['git', 'log', '-1', '--format=%B'],),
2480 'This is a description\n\nChange-Id: Ideadbeef'),
2481 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002482 ]
2483 self.assertEqual(0, git_cl.main(['issue', '0']))
2484
phajdan.jre328cf92016-08-22 04:12:17 -07002485 def test_cmd_issue_json(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002486 out = StringIO()
phajdan.jre328cf92016-08-22 04:12:17 -07002487 self.mock(git_cl.sys, 'stdout', out)
2488 self.calls = [
2489 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002490 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2491 ((['git', 'config', 'branch.feature.gerritserver'],),
2492 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002493 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002494 {'issue': 123,
2495 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002496 ''),
2497 ]
2498 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2499
tandrii16e0b4e2016-06-07 10:34:28 -07002500 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002501 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07002502 self.mock(git_cl.os.path, 'abspath',
2503 lambda path: self._mocked_call(['abspath', path]))
2504 self.mock(git_cl.os.path, 'exists',
2505 lambda path: self._mocked_call(['exists', path]))
2506 self.mock(git_cl.gclient_utils, 'FileRead',
2507 lambda path: self._mocked_call(['FileRead', path]))
2508 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2509 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2510 self.calls = [
2511 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2512 ((['abspath', '../'],), '/abs/git_repo_root'),
2513 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002514 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002515
2516 def test_GerritCommitMsgHookCheck_custom_hook(self):
2517 cl = self._common_GerritCommitMsgHookCheck()
2518 self.calls += [
2519 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2520 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2521 '#!/bin/sh\necho "custom hook"')
2522 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002523 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002524
2525 def test_GerritCommitMsgHookCheck_not_exists(self):
2526 cl = self._common_GerritCommitMsgHookCheck()
2527 self.calls += [
2528 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2529 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002530 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002531
2532 def test_GerritCommitMsgHookCheck(self):
2533 cl = self._common_GerritCommitMsgHookCheck()
2534 self.calls += [
2535 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2536 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2537 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002538 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002539 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2540 ''),
2541 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002542 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002543
tandriic4344b52016-08-29 06:04:54 -07002544 def test_GerritCmdLand(self):
2545 self.calls += [
2546 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2547 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2548 'deadbeaf'),
2549 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2550 ((['git', 'config', 'branch.feature.gerritserver'],),
2551 'chromium-review.googlesource.com'),
2552 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002553 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002554 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002555 'labels': {},
2556 'current_revision': 'deadbeaf',
2557 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002558 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002559 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002560 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002561 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2562 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002563 cl.SubmitIssue = lambda wait_for_merge: None
Edward Lemur79d4f992019-11-11 23:49:02 +00002564 out = StringIO()
tandrii8da412c2016-09-07 16:01:07 -07002565 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002566 self.assertEqual(0, cl.CMDLand(force=True,
2567 bypass_hooks=True,
2568 verbose=True,
2569 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002570 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002571 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002572
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002573 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemur125d60a2019-09-13 18:25:41 +00002574 self.mock(git_cl.Changelist, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002575
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002576 def test_gerrit_change_detail_cache_simple(self):
2577 self._mock_gerrit_changes_for_detail_cache()
2578 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002579 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2580 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2581 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002582 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002583 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002584 cl1._cached_remote_url = (
2585 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002586 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002587 cl2._cached_remote_url = (
2588 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002589 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2590 self.assertEqual(cl1._GetChangeDetail(), 'a')
2591 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2592 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2593 self.assertEqual(cl1._GetChangeDetail(), 'a')
2594 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002595
2596 def test_gerrit_change_detail_cache_options(self):
2597 self._mock_gerrit_changes_for_detail_cache()
2598 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002599 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2600 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2601 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2602 # no longer in cache.
2603 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002604 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002605 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002606 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002607 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2608 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2609 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2610 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2611 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2612 self.assertEqual(cl._GetChangeDetail(), 'cab')
2613
2614 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2615 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2616 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2617 self.assertEqual(cl._GetChangeDetail(), 'cab')
2618
2619 # Finally, no_cache should invalidate all caches for given change.
2620 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2621 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2622
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002623 def test_gerrit_description_caching(self):
2624 def gen_detail(rev, desc):
2625 return {
2626 'current_revision': rev,
2627 'revisions': {rev: {'commit': {'message': desc}}}
2628 }
2629 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002630 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002631 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2632 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002633 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002634 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2635 gen_detail('rev2', 'desc2')),
2636 ]
2637
2638 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002639 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002640 cl._cached_remote_url = (
2641 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002642 self.assertEqual(cl.GetDescription(), 'desc1')
2643 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2644 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002645
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002646 def test_print_current_creds(self):
2647 class CookiesAuthenticatorMock(object):
2648 def __init__(self):
2649 self.gitcookies = {
2650 'host.googlesource.com': ('user', 'pass'),
2651 'host-review.googlesource.com': ('user', 'pass'),
2652 }
2653 self.netrc = self
2654 self.netrc.hosts = {
2655 'github.com': ('user2', None, 'pass2'),
2656 'host2.googlesource.com': ('user3', None, 'pass'),
2657 }
2658 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2659 CookiesAuthenticatorMock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002660 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002661 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2662 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2663 ' Host\t User\t Which file',
2664 '============================\t=====\t===========',
2665 'host-review.googlesource.com\t user\t.gitcookies',
2666 ' host.googlesource.com\t user\t.gitcookies',
2667 ' host2.googlesource.com\tuser3\t .netrc',
2668 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002669 sys.stdout.seek(0)
2670 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002671 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2672 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2673 ' Host\tUser\t Which file',
2674 '============================\t====\t===========',
2675 'host-review.googlesource.com\tuser\t.gitcookies',
2676 ' host.googlesource.com\tuser\t.gitcookies',
2677 ])
2678
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002679 def _common_creds_check_mocks(self):
2680 def exists_mock(path):
2681 dirname = os.path.dirname(path)
2682 if dirname == os.path.expanduser('~'):
2683 dirname = '~'
2684 base = os.path.basename(path)
2685 if base in ('.netrc', '.gitcookies'):
2686 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2687 # git cl also checks for existence other files not relevant to this test.
2688 return None
2689 self.mock(os.path, 'exists', exists_mock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002690 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002691
2692 def test_creds_check_gitcookies_not_configured(self):
2693 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002694 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002695 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002696 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002697 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002698 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2699 (('os.path.exists', '~/.netrc'), True),
2700 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2701 'or Ctrl+C to abort'), ''),
2702 ((['git', 'config', '--global', 'http.cookiefile',
2703 os.path.expanduser('~/.gitcookies')], ), ''),
2704 ]
2705 self.assertEqual(0, git_cl.main(['creds-check']))
2706 self.assertRegexpMatches(
2707 sys.stdout.getvalue(),
2708 '^You seem to be using outdated .netrc for git credentials:')
2709 self.assertRegexpMatches(
2710 sys.stdout.getvalue(),
2711 '\nConfigured git to use .gitcookies from')
2712
2713 def test_creds_check_gitcookies_configured_custom_broken(self):
2714 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002715 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002716 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002717 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002718 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002719 ((['git', 'config', '--global', 'http.cookiefile'],),
2720 '/custom/.gitcookies'),
2721 (('os.path.exists', '/custom/.gitcookies'), False),
2722 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2723 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2724 ((['git', 'config', '--global', 'http.cookiefile',
2725 os.path.expanduser('~/.gitcookies')], ), ''),
2726 ]
2727 self.assertEqual(0, git_cl.main(['creds-check']))
2728 self.assertRegexpMatches(
2729 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002730 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002731 self.assertRegexpMatches(
2732 sys.stdout.getvalue(),
2733 'However, your configured .gitcookies file is missing.')
2734
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002735 def test_git_cl_comment_add_gerrit(self):
2736 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002737 lambda host, change, msg, ready:
2738 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002739 self.calls = [
2740 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2741 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2742 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2743 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2744 'origin/master'),
2745 ((['git', 'config', 'remote.origin.url'],),
2746 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002747 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2748 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002749 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002750 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002751 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002752
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002753 def test_git_cl_comments_fetch_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002754 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002755 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002756 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2757 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002758 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2759 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2760 'origin/master'),
2761 ((['git', 'config', 'remote.origin.url'],),
2762 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002763 (('GetChangeDetail', 'chromium-review.googlesource.com',
2764 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002765 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2766 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002767 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002768 'current_revision': 'ba5eba11',
2769 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002770 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002771 '_number': 1,
2772 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002773 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002774 '_number': 2,
2775 },
2776 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002777 'messages': [
2778 {
2779 u'_revision_number': 1,
2780 u'author': {
2781 u'_account_id': 1111084,
2782 u'email': u'commit-bot@chromium.org',
2783 u'name': u'Commit Bot'
2784 },
2785 u'date': u'2017-03-15 20:08:45.000000000',
2786 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002787 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002788 u'tag': u'autogenerated:cq:dry-run'
2789 },
2790 {
2791 u'_revision_number': 2,
2792 u'author': {
2793 u'_account_id': 11151243,
2794 u'email': u'owner@example.com',
2795 u'name': u'owner'
2796 },
2797 u'date': u'2017-03-16 20:00:41.000000000',
2798 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2799 u'message': u'PTAL',
2800 },
2801 {
2802 u'_revision_number': 2,
2803 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002804 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002805 u'email': u'reviewer@example.com',
2806 u'name': u'reviewer'
2807 },
2808 u'date': u'2017-03-17 05:19:37.500000000',
2809 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2810 u'message': u'Patch Set 2: Code-Review+1',
2811 },
2812 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002813 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002814 (('GetChangeComments', 'chromium-review.googlesource.com',
2815 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002816 '/COMMIT_MSG': [
2817 {
2818 'author': {'email': u'reviewer@example.com'},
2819 'updated': u'2017-03-17 05:19:37.500000000',
2820 'patch_set': 2,
2821 'side': 'REVISION',
2822 'message': 'Please include a bug link',
2823 },
2824 ],
2825 'codereview.settings': [
2826 {
2827 'author': {'email': u'owner@example.com'},
2828 'updated': u'2017-03-16 20:00:41.000000000',
2829 'patch_set': 2,
2830 'side': 'PARENT',
2831 'line': 42,
2832 'message': 'I removed this because it is bad',
2833 },
2834 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002835 }),
2836 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2837 'infra%2Finfra~1'), {}),
2838 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002839 ] * 2 + [
2840 (('write_json', 'output.json', [
2841 {
2842 u'date': u'2017-03-16 20:00:41.000000',
2843 u'message': (
2844 u'PTAL\n' +
2845 u'\n' +
2846 u'codereview.settings\n' +
2847 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2848 u'c/1/2/codereview.settings#b42\n' +
2849 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002850 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002851 u'approval': False,
2852 u'disapproval': False,
2853 u'sender': u'owner@example.com'
2854 }, {
2855 u'date': u'2017-03-17 05:19:37.500000',
2856 u'message': (
2857 u'Patch Set 2: Code-Review+1\n' +
2858 u'\n' +
2859 u'/COMMIT_MSG\n' +
2860 u' PS2, File comment: https://chromium-review.googlesource' +
2861 u'.com/c/1/2//COMMIT_MSG#\n' +
2862 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002863 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002864 u'approval': False,
2865 u'disapproval': False,
2866 u'sender': u'reviewer@example.com'
2867 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002868 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002869 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002870 expected_comments_summary = [
2871 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002872 message=(
2873 u'PTAL\n' +
2874 u'\n' +
2875 u'codereview.settings\n' +
2876 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2877 u'c/1/2/codereview.settings#b42\n' +
2878 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002879 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002880 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002881 disapproval=False, approval=False, sender=u'owner@example.com'),
2882 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002883 message=(
2884 u'Patch Set 2: Code-Review+1\n' +
2885 u'\n' +
2886 u'/COMMIT_MSG\n' +
2887 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2888 u'c/1/2//COMMIT_MSG#\n' +
2889 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002890 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002891 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002892 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2893 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002894 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002895 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002896 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002897 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
2898 self.assertEqual(
2899 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2900
2901 def test_git_cl_comments_robot_comments(self):
2902 # git cl comments also fetches robot comments (which are considered a type
2903 # of autogenerated comment), and unlike other types of comments, only robot
2904 # comments from the latest patchset are shown.
Edward Lemur79d4f992019-11-11 23:49:02 +00002905 self.mock(sys, 'stdout', StringIO())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002906 self.calls = [
2907 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2908 ((['git', 'config', 'branch.foo.merge'],), ''),
2909 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2910 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2911 'origin/master'),
2912 ((['git', 'config', 'remote.origin.url'],),
2913 'https://chromium.googlesource.com/infra/infra'),
2914 (('GetChangeDetail', 'chromium-review.googlesource.com',
2915 'infra%2Finfra~1',
2916 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2917 'CURRENT_COMMIT']), {
2918 'owner': {'email': 'owner@example.com'},
2919 'current_revision': 'ba5eba11',
2920 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002921 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002922 '_number': 1,
2923 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002924 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002925 '_number': 2,
2926 },
2927 },
2928 'messages': [
2929 {
2930 u'_revision_number': 1,
2931 u'author': {
2932 u'_account_id': 1111084,
2933 u'email': u'commit-bot@chromium.org',
2934 u'name': u'Commit Bot'
2935 },
2936 u'date': u'2017-03-15 20:08:45.000000000',
2937 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2938 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2939 u'tag': u'autogenerated:cq:dry-run'
2940 },
2941 {
2942 u'_revision_number': 1,
2943 u'author': {
2944 u'_account_id': 123,
2945 u'email': u'tricium@serviceaccount.com',
2946 u'name': u'Tricium'
2947 },
2948 u'date': u'2017-03-16 20:00:41.000000000',
2949 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2950 u'message': u'(1 comment)',
2951 u'tag': u'autogenerated:tricium',
2952 },
2953 {
2954 u'_revision_number': 1,
2955 u'author': {
2956 u'_account_id': 123,
2957 u'email': u'tricium@serviceaccount.com',
2958 u'name': u'Tricium'
2959 },
2960 u'date': u'2017-03-16 20:00:41.000000000',
2961 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2962 u'message': u'(1 comment)',
2963 u'tag': u'autogenerated:tricium',
2964 },
2965 {
2966 u'_revision_number': 2,
2967 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002968 u'_account_id': 123,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002969 u'email': u'tricium@serviceaccount.com',
2970 u'name': u'reviewer'
2971 },
2972 u'date': u'2017-03-17 05:30:37.000000000',
2973 u'tag': u'autogenerated:tricium',
2974 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2975 u'message': u'(1 comment)',
2976 },
2977 ]
2978 }),
2979 (('GetChangeComments', 'chromium-review.googlesource.com',
2980 'infra%2Finfra~1'), {}),
2981 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2982 'infra%2Finfra~1'), {
2983 'codereview.settings': [
2984 {
2985 u'author': {u'email': u'tricium@serviceaccount.com'},
2986 u'updated': u'2017-03-17 05:30:37.000000000',
2987 u'robot_run_id': u'5565031076855808',
2988 u'robot_id': u'Linter/Category',
2989 u'tag': u'autogenerated:tricium',
2990 u'patch_set': 2,
2991 u'side': u'REVISION',
2992 u'message': u'Linter warning message text',
2993 u'line': 32,
2994 },
2995 ],
2996 }),
2997 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
2998 ]
2999 expected_comments_summary = [
3000 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
3001 message=(
3002 u'(1 comment)\n\ncodereview.settings\n'
3003 u' PS2, Line 32: https://chromium-review.googlesource.com/'
3004 u'c/1/2/codereview.settings#32\n'
3005 u' Linter warning message text\n'),
3006 sender=u'tricium@serviceaccount.com',
3007 autogenerated=True, approval=False, disapproval=False)
3008 ]
3009 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00003010 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003011 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003012
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003013 def test_get_remote_url_with_mirror(self):
3014 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003015
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003016 def selective_os_path_isdir_mock(path):
3017 if path == '/cache/this-dir-exists':
3018 return self._mocked_call('os.path.isdir', path)
3019 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003020
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003021 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3022
3023 url = 'https://chromium.googlesource.com/my/repo'
3024 self.calls = [
3025 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3026 ((['git', 'config', 'branch.master.merge'],), 'master'),
3027 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3028 ((['git', 'config', 'remote.origin.url'],),
3029 '/cache/this-dir-exists'),
3030 (('os.path.isdir', '/cache/this-dir-exists'),
3031 True),
3032 # Runs in /cache/this-dir-exists.
3033 ((['git', 'config', 'remote.origin.url'],),
3034 url),
3035 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003036 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003037 self.assertEqual(cl.GetRemoteUrl(), url)
3038 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3039
Edward Lemur298f2cf2019-02-22 21:40:39 +00003040 def test_get_remote_url_non_existing_mirror(self):
3041 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003042
Edward Lemur298f2cf2019-02-22 21:40:39 +00003043 def selective_os_path_isdir_mock(path):
3044 if path == '/cache/this-dir-doesnt-exist':
3045 return self._mocked_call('os.path.isdir', path)
3046 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003047
Edward Lemur298f2cf2019-02-22 21:40:39 +00003048 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3049 self.mock(logging, 'error',
Josip906bfde2020-01-31 22:38:49 +00003050 lambda *a: self._mocked_call('logging.error', *a))
Edward Lemur298f2cf2019-02-22 21:40:39 +00003051
3052 self.calls = [
3053 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3054 ((['git', 'config', 'branch.master.merge'],), 'master'),
3055 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3056 ((['git', 'config', 'remote.origin.url'],),
3057 '/cache/this-dir-doesnt-exist'),
3058 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3059 False),
3060 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00003061 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
3062 'but it doesn\'t exist.', {
3063 'remote': 'origin',
3064 'branch': 'master',
3065 'url': '/cache/this-dir-doesnt-exist'}
3066 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00003067 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003068 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003069 self.assertIsNone(cl.GetRemoteUrl())
3070
3071 def test_get_remote_url_misconfigured_mirror(self):
3072 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003073
Edward Lemur298f2cf2019-02-22 21:40:39 +00003074 def selective_os_path_isdir_mock(path):
3075 if path == '/cache/this-dir-exists':
3076 return self._mocked_call('os.path.isdir', path)
3077 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003078
Edward Lemur298f2cf2019-02-22 21:40:39 +00003079 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3080 self.mock(logging, 'error',
3081 lambda *a: self._mocked_call('logging.error', *a))
3082
3083 self.calls = [
3084 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3085 ((['git', 'config', 'branch.master.merge'],), 'master'),
3086 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3087 ((['git', 'config', 'remote.origin.url'],),
3088 '/cache/this-dir-exists'),
3089 (('os.path.isdir', '/cache/this-dir-exists'), True),
3090 # Runs in /cache/this-dir-exists.
3091 ((['git', 'config', 'remote.origin.url'],), ''),
3092 (('logging.error',
3093 'Remote "%(remote)s" for branch "%(branch)s" points to '
3094 '"%(cache_path)s", but it is misconfigured.\n'
3095 '"%(cache_path)s" must be a git repo and must have a remote named '
3096 '"%(remote)s" pointing to the git host.', {
3097 'remote': 'origin',
3098 'cache_path': '/cache/this-dir-exists',
3099 'branch': 'master'}
3100 ), None),
3101 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003102 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003103 self.assertIsNone(cl.GetRemoteUrl())
3104
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003105 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003106 self.calls = [
3107 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3108 ((['git', 'config', 'branch.master.merge'],), 'master'),
3109 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3110 ((['git', 'config', 'remote.origin.url'],),
3111 'https://chromium.googlesource.com/a/my/repo.git/'),
3112 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003113 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003114 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3115
3116 def test_gerrit_change_identifier_without_project(self):
Josip906bfde2020-01-31 22:38:49 +00003117 self.mock(logging, 'error',
3118 lambda *a: self._mocked_call('logging.error', *a))
3119
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003120 self.calls = [
3121 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3122 ((['git', 'config', 'branch.master.merge'],), 'master'),
3123 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3124 ((['git', 'config', 'remote.origin.url'],), CERR1),
Josip906bfde2020-01-31 22:38:49 +00003125 (('logging.error',
3126 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
3127 'but it doesn\'t exist.', {
3128 'remote': 'origin',
3129 'branch': 'master',
3130 'url': ''}
3131 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003132 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003133 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003134 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003135
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003136
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003137class CMDTestCaseBase(unittest.TestCase):
3138 _STATUSES = [
3139 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3140 'INFRA_FAILURE', 'CANCELED',
3141 ]
3142 _CHANGE_DETAIL = {
3143 'project': 'depot_tools',
3144 'status': 'OPEN',
3145 'owner': {'email': 'owner@e.mail'},
3146 'current_revision': 'beeeeeef',
3147 'revisions': {
3148 'deadbeaf': {'_number': 6},
3149 'beeeeeef': {
3150 '_number': 7,
3151 'fetch': {'http': {
3152 'url': 'https://chromium.googlesource.com/depot_tools',
3153 'ref': 'refs/changes/56/123456/7'
3154 }},
3155 },
3156 },
3157 }
3158 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003159 'builds': [{
3160 'id': str(100 + idx),
3161 'builder': {
3162 'project': 'chromium',
3163 'bucket': 'try',
3164 'builder': 'bot_' + status.lower(),
3165 },
3166 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3167 'tags': [],
3168 'status': status,
3169 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003170 }
3171
Edward Lemur4c707a22019-09-24 21:13:43 +00003172 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003173 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003174 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003175 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3176 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003177 mock.patch('git_cl.Changelist.GetCodereviewServer',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003178 return_value='https://chromium-review.googlesource.com').start()
3179 mock.patch('git_cl.Changelist.GetMostRecentPatchset',
3180 return_value=7).start()
Edward Lemur5b929a42019-10-21 17:57:39 +00003181 mock.patch('git_cl.auth.Authenticator',
Edward Lemurb4a587d2019-10-09 23:56:38 +00003182 return_value=AuthenticatorMock()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003183 mock.patch('git_cl.Changelist._GetChangeDetail',
3184 return_value=self._CHANGE_DETAIL).start()
3185 mock.patch('git_cl._call_buildbucket',
3186 return_value = self._DEFAULT_RESPONSE).start()
3187 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003188 self.addCleanup(mock.patch.stopall)
3189
Edward Lemur4c707a22019-09-24 21:13:43 +00003190
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003191class CMDTryResultsTestCase(CMDTestCaseBase):
3192 _DEFAULT_REQUEST = {
3193 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003194 "gerritChanges": [{
3195 "project": "depot_tools",
3196 "host": "chromium-review.googlesource.com",
3197 "patchset": 7,
3198 "change": 123456,
3199 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003200 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003201 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3202 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003203 }
3204
3205 def testNoJobs(self):
3206 git_cl._call_buildbucket.return_value = {}
3207
3208 self.assertEqual(0, git_cl.main(['try-results']))
3209 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3210 git_cl._call_buildbucket.assert_called_once_with(
3211 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3212 self._DEFAULT_REQUEST)
3213
3214 def testPrintToStdout(self):
3215 self.assertEqual(0, git_cl.main(['try-results']))
3216 self.assertEqual([
3217 'Successes:',
3218 ' bot_success https://ci.chromium.org/b/103',
3219 'Infra Failures:',
3220 ' bot_infra_failure https://ci.chromium.org/b/105',
3221 'Failures:',
3222 ' bot_failure https://ci.chromium.org/b/104',
3223 'Canceled:',
3224 ' bot_canceled ',
3225 'Started:',
3226 ' bot_started https://ci.chromium.org/b/102',
3227 'Scheduled:',
3228 ' bot_scheduled id=101',
3229 'Other:',
3230 ' bot_status_unspecified id=100',
3231 'Total: 7 tryjobs',
3232 ], sys.stdout.getvalue().splitlines())
3233 git_cl._call_buildbucket.assert_called_once_with(
3234 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3235 self._DEFAULT_REQUEST)
3236
3237 def testPrintToStdoutWithMasters(self):
3238 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3239 self.assertEqual([
3240 'Successes:',
3241 ' try bot_success https://ci.chromium.org/b/103',
3242 'Infra Failures:',
3243 ' try bot_infra_failure https://ci.chromium.org/b/105',
3244 'Failures:',
3245 ' try bot_failure https://ci.chromium.org/b/104',
3246 'Canceled:',
3247 ' try bot_canceled ',
3248 'Started:',
3249 ' try bot_started https://ci.chromium.org/b/102',
3250 'Scheduled:',
3251 ' try bot_scheduled id=101',
3252 'Other:',
3253 ' try bot_status_unspecified id=100',
3254 'Total: 7 tryjobs',
3255 ], sys.stdout.getvalue().splitlines())
3256 git_cl._call_buildbucket.assert_called_once_with(
3257 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3258 self._DEFAULT_REQUEST)
3259
3260 @mock.patch('git_cl.write_json')
3261 def testWriteToJson(self, mockJsonDump):
3262 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3263 git_cl._call_buildbucket.assert_called_once_with(
3264 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3265 self._DEFAULT_REQUEST)
3266 mockJsonDump.assert_called_once_with(
3267 'file.json', self._DEFAULT_RESPONSE['builds'])
3268
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003269 def test_filter_failed_for_one_simple(self):
3270 self.assertEqual({}, git_cl._filter_failed_for_retry([]))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003271 self.assertEqual({
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003272 'chromium/try': {
3273 'bot_failure': [],
3274 'bot_infra_failure': []
3275 },
3276 }, git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
3277
3278 def test_filter_failed_for_retry_many_builds(self):
3279
3280 def _build(name, created_sec, status, experimental=False):
3281 assert 0 <= created_sec < 100, created_sec
3282 b = {
3283 'id': 112112,
3284 'builder': {
3285 'project': 'chromium',
3286 'bucket': 'try',
3287 'builder': name,
3288 },
3289 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3290 'status': status,
3291 'tags': [],
3292 }
3293 if experimental:
3294 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3295 return b
3296
3297 builds = [
3298 _build('flaky-last-green', 1, 'FAILURE'),
3299 _build('flaky-last-green', 2, 'SUCCESS'),
3300 _build('flaky', 1, 'SUCCESS'),
3301 _build('flaky', 2, 'FAILURE'),
3302 _build('running', 1, 'FAILED'),
3303 _build('running', 2, 'SCHEDULED'),
3304 _build('yep-still-running', 1, 'STARTED'),
3305 _build('yep-still-running', 2, 'FAILURE'),
3306 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3307 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3308
3309 # Simulate experimental in CQ builder, which developer decided
3310 # to retry manually which resulted in 2nd build non-experimental.
3311 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3312 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3313 ]
3314 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
3315 self.assertEqual({
3316 'chromium/try': {
3317 'flaky': [],
3318 'sometimes-experimental': []
3319 },
3320 }, git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003321
3322
3323class CMDTryTestCase(CMDTestCaseBase):
3324
3325 @mock.patch('git_cl.Changelist.SetCQState')
3326 @mock.patch('git_cl._get_bucket_map', return_value={})
3327 def testSetCQDryRunByDefault(self, _mockGetBucketMap, mockSetCQState):
3328 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003329 self.assertEqual(0, git_cl.main(['try']))
3330 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3331 self.assertEqual(
3332 sys.stdout.getvalue(),
3333 'Scheduling CQ dry run on: '
3334 'https://chromium-review.googlesource.com/123456\n')
3335
Edward Lemur4c707a22019-09-24 21:13:43 +00003336 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003337 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003338 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003339
3340 self.assertEqual(0, git_cl.main([
3341 'try', '-B', 'luci.chromium.try', '-b', 'win',
3342 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3343 self.assertIn(
3344 'Scheduling jobs on:\nBucket: luci.chromium.try',
3345 git_cl.sys.stdout.getvalue())
3346
3347 expected_request = {
3348 "requests": [{
3349 "scheduleBuild": {
3350 "requestId": "uuid4",
3351 "builder": {
3352 "project": "chromium",
3353 "builder": "win",
3354 "bucket": "try",
3355 },
3356 "gerritChanges": [{
3357 "project": "depot_tools",
3358 "host": "chromium-review.googlesource.com",
3359 "patchset": 7,
3360 "change": 123456,
3361 }],
3362 "properties": {
3363 "category": "git_cl_try",
3364 "json": [{"a": 1}, None],
3365 "key": "val",
3366 },
3367 "tags": [
3368 {"value": "win", "key": "builder"},
3369 {"value": "git_cl_try", "key": "user_agent"},
3370 ],
3371 },
3372 }],
3373 }
3374 mockCallBuildbucket.assert_called_with(
3375 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3376
Anthony Polito1a5fe232020-01-24 23:17:52 +00003377 @mock.patch('git_cl._call_buildbucket')
3378 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3379 mockCallBuildbucket.return_value = {}
3380
3381 self.assertEqual(0, git_cl.main([
3382 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3383 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3384 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3385 self.assertIn(
3386 'Scheduling jobs on:\nBucket: luci.chromium.try',
3387 git_cl.sys.stdout.getvalue())
3388
3389 expected_request = {
3390 "requests": [{
3391 "scheduleBuild": {
3392 "requestId": "uuid4",
3393 "builder": {
3394 "project": "chromium",
3395 "builder": "linux",
3396 "bucket": "try",
3397 },
3398 "gerritChanges": [{
3399 "project": "depot_tools",
3400 "host": "chromium-review.googlesource.com",
3401 "patchset": 7,
3402 "change": 123456,
3403 }],
3404 "properties": {
3405 "category": "git_cl_try",
3406 "json": [{"a": 1}, None],
3407 "key": "val",
3408 },
3409 "tags": [
3410 {"value": "linux", "key": "builder"},
3411 {"value": "git_cl_try", "key": "user_agent"},
3412 ],
3413 "gitilesCommit": {
3414 "host": "chromium-review.googlesource.com",
3415 "project": "depot_tools",
3416 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3417 }
3418 },
3419 },
3420 {
3421 "scheduleBuild": {
3422 "requestId": "uuid4",
3423 "builder": {
3424 "project": "chromium",
3425 "builder": "win",
3426 "bucket": "try",
3427 },
3428 "gerritChanges": [{
3429 "project": "depot_tools",
3430 "host": "chromium-review.googlesource.com",
3431 "patchset": 7,
3432 "change": 123456,
3433 }],
3434 "properties": {
3435 "category": "git_cl_try",
3436 "json": [{"a": 1}, None],
3437 "key": "val",
3438 },
3439 "tags": [
3440 {"value": "win", "key": "builder"},
3441 {"value": "git_cl_try", "key": "user_agent"},
3442 ],
3443 "gitilesCommit": {
3444 "host": "chromium-review.googlesource.com",
3445 "project": "depot_tools",
3446 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3447 }
3448 },
3449 }],
3450 }
3451 mockCallBuildbucket.assert_called_with(
3452 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3453
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003454 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur4c707a22019-09-24 21:13:43 +00003455 self.assertEqual(0, git_cl.main([
3456 'try', '-B', 'not-a-bucket', '-b', 'win',
3457 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3458 self.assertIn(
3459 'WARNING Could not parse bucket "not-a-bucket". Skipping.',
3460 git_cl.sys.stdout.getvalue())
3461
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003462 @mock.patch('git_cl._call_buildbucket')
3463 @mock.patch('git_cl.fetch_try_jobs')
3464 def testScheduleOnBuildbucketRetryFailed(
3465 self, mockFetchTryJobs, mockCallBuildbucket):
3466
3467 git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: {
3468 7: [],
3469 6: [{
3470 'id': 112112,
3471 'builder': {
3472 'project': 'chromium',
3473 'bucket': 'try',
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003474 'builder': 'linux',},
3475 'createTime': '2019-10-09T08:00:01.854286Z',
3476 'tags': [],
3477 'status': 'FAILURE',}],}[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003478 mockCallBuildbucket.return_value = {}
3479
3480 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3481 self.assertIn(
3482 'Scheduling jobs on:\nBucket: chromium/try',
3483 git_cl.sys.stdout.getvalue())
3484
3485 expected_request = {
3486 "requests": [{
3487 "scheduleBuild": {
3488 "requestId": "uuid4",
3489 "builder": {
3490 "project": "chromium",
3491 "bucket": "try",
3492 "builder": "linux",
3493 },
3494 "gerritChanges": [{
3495 "project": "depot_tools",
3496 "host": "chromium-review.googlesource.com",
3497 "patchset": 7,
3498 "change": 123456,
3499 }],
3500 "properties": {
3501 "category": "git_cl_try",
3502 },
3503 "tags": [
3504 {"value": "linux", "key": "builder"},
3505 {"value": "git_cl_try", "key": "user_agent"},
3506 {"value": "1", "key": "retry_failed"},
3507 ],
3508 },
3509 }],
3510 }
3511 mockCallBuildbucket.assert_called_with(
3512 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3513
Edward Lemur4c707a22019-09-24 21:13:43 +00003514 def test_parse_bucket(self):
3515 test_cases = [
3516 {
3517 'bucket': 'chromium/try',
3518 'result': ('chromium', 'try'),
3519 },
3520 {
3521 'bucket': 'luci.chromium.try',
3522 'result': ('chromium', 'try'),
3523 'has_warning': True,
3524 },
3525 {
3526 'bucket': 'skia.primary',
3527 'result': ('skia', 'skia.primary'),
3528 'has_warning': True,
3529 },
3530 {
3531 'bucket': 'not-a-bucket',
3532 'result': (None, None),
3533 },
3534 ]
3535
3536 for test_case in test_cases:
3537 git_cl.sys.stdout.truncate(0)
3538 self.assertEqual(
3539 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3540 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003541 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3542 test_case['result'])
3543 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003544
3545
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003546class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003547 def setUp(self):
3548 super(CMDUploadTestCase, self).setUp()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003549 mock.patch('git_cl.fetch_try_jobs').start()
3550 mock.patch('git_cl._trigger_try_jobs', return_value={}).start()
3551 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Anthony Polito46689b02019-11-15 20:56:41 +00003552 mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003553 self.addCleanup(mock.patch.stopall)
3554
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003555 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003556 # This test mocks out the actual upload part, and just asserts that after
3557 # upload, if --retry-failed is added, then the tool will fetch try jobs
3558 # from the previous patchset and trigger the right builders on the latest
3559 # patchset.
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003560 git_cl.fetch_try_jobs.side_effect = [
3561 # Latest patchset: No builds.
3562 [],
3563 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003564 [{
3565 'id': str(100 + idx),
3566 'builder': {
3567 'project': 'chromium',
3568 'bucket': 'try',
3569 'builder': 'bot_' + status.lower(),
3570 },
3571 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3572 'tags': [],
3573 'status': status,
3574 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003575 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003576
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003577 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003578 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003579 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3580 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003581 ], git_cl.fetch_try_jobs.mock_calls)
3582 expected_buckets = {
3583 'chromium/try': {'bot_failure': [], 'bot_infra_failure': []},
3584 }
3585 git_cl._trigger_try_jobs.assert_called_once_with(
Edward Lemur5b929a42019-10-21 17:57:39 +00003586 mock.ANY, expected_buckets, mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003587
Brian Sheedy59b06a82019-10-14 17:03:29 +00003588
3589class CMDFormatTestCase(TestCase):
3590
3591 def setUp(self):
3592 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003593 mock.patch('git_cl.RunCommand').start()
3594 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3595 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3596 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003597 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003598 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003599
3600 def tearDown(self):
3601 shutil.rmtree(self._top_dir)
3602 super(CMDFormatTestCase, self).tearDown()
3603
Jamie Madill5e96ad12020-01-13 16:08:35 +00003604 def _make_temp_file(self, fname, contents):
3605 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3606 tf.write('\n'.join(contents))
3607
Brian Sheedy59b06a82019-10-14 17:03:29 +00003608 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003609 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003610
Brian Sheedyb4307d52019-12-02 19:18:17 +00003611 def _check_yapf_filtering(self, files, expected):
3612 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3613 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003614
Jamie Madill5e96ad12020-01-13 16:08:35 +00003615 def testClangFormatDiffFull(self):
3616 self._make_temp_file('test.cc', ['// test'])
3617 git_cl.settings.GetFormatFullByDefault.return_value = False
3618 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3619 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3620
3621 # Diff
3622 git_cl.RunCommand.return_value = ' // test'
3623 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3624 self._top_dir, 'HEAD')
3625 self.assertEqual(2, return_value)
3626
3627 # No diff
3628 git_cl.RunCommand.return_value = '// test'
3629 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3630 self._top_dir, 'HEAD')
3631 self.assertEqual(0, return_value)
3632
3633 def testClangFormatDiff(self):
3634 git_cl.settings.GetFormatFullByDefault.return_value = False
3635 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3636
3637 # Diff
3638 git_cl.RunCommand.return_value = 'error'
3639 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3640 'HEAD')
3641 self.assertEqual(2, return_value)
3642
3643 # No diff
3644 git_cl.RunCommand.return_value = ''
3645 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3646 'HEAD')
3647 self.assertEqual(0, return_value)
3648
Brian Sheedyb4307d52019-12-02 19:18:17 +00003649 def testYapfignoreExplicit(self):
3650 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3651 files = [
3652 'bar.py',
3653 'foo/bar.py',
3654 'foo/baz.py',
3655 'foo/bar/baz.py',
3656 'foo/bar/foobar.py',
3657 ]
3658 expected = [
3659 'bar.py',
3660 'foo/baz.py',
3661 'foo/bar/foobar.py',
3662 ]
3663 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003664
Brian Sheedyb4307d52019-12-02 19:18:17 +00003665 def testYapfignoreSingleWildcards(self):
3666 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3667 files = [
3668 'bar.py', # Matched by *bar.py.
3669 'bar.txt',
3670 'foobar.py', # Matched by *bar.py, foo*.
3671 'foobar.txt', # Matched by foo*.
3672 'bazbar.py', # Matched by *bar.py, baz*.py.
3673 'bazbar.txt',
3674 'foo/baz.txt', # Matched by foo*.
3675 'bar/bar.py', # Matched by *bar.py.
3676 'baz/foo.py', # Matched by baz*.py, foo*.
3677 'baz/foo.txt',
3678 ]
3679 expected = [
3680 'bar.txt',
3681 'bazbar.txt',
3682 'baz/foo.txt',
3683 ]
3684 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003685
Brian Sheedyb4307d52019-12-02 19:18:17 +00003686 def testYapfignoreMultiplewildcards(self):
3687 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3688 files = [
3689 'bar.py', # Matched by *bar*.
3690 'bar.txt', # Matched by *bar*.
3691 'abar.py', # Matched by *bar*.
3692 'foobaz.txt', # Matched by *foo*baz.txt.
3693 'foobaz.py',
3694 'afoobaz.txt', # Matched by *foo*baz.txt.
3695 ]
3696 expected = [
3697 'foobaz.py',
3698 ]
3699 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003700
3701 def testYapfignoreComments(self):
3702 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003703 files = [
3704 'test.py',
3705 'test2.py',
3706 ]
3707 expected = [
3708 'test2.py',
3709 ]
3710 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003711
3712 def testYapfignoreBlankLines(self):
3713 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003714 files = [
3715 'test.py',
3716 'test2.py',
3717 'test3.py',
3718 ]
3719 expected = [
3720 'test3.py',
3721 ]
3722 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003723
3724 def testYapfignoreWhitespace(self):
3725 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003726 files = [
3727 'test.py',
3728 'test2.py',
3729 ]
3730 expected = [
3731 'test2.py',
3732 ]
3733 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003734
Brian Sheedyb4307d52019-12-02 19:18:17 +00003735 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003736 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003737 self._check_yapf_filtering([], [])
3738
3739 def testYapfignoreMissingYapfignore(self):
3740 files = [
3741 'test.py',
3742 ]
3743 expected = [
3744 'test.py',
3745 ]
3746 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003747
3748
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003749if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003750 logging.basicConfig(
3751 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003752 unittest.main()