commit dc4d19eeb67ac1935a1730b263fab07bdf3ccb0e
author Jamie Madill <jmadill@chromium.org> Thu Oct 24 21:50:02 2019 +0000
committer Commit Bot <commit-bot@chromium.org> Thu Oct 24 21:50:02 2019 +0000
tree 0be7ff15f4120379e6b20631dd60041646e5083f
parent de9e3cabe60e57f3b7f923e59aed8cb4f87e2f0a

git-cl: Add 'format-full-by-default' setting.

Lets the client repository make 'git cl format' use the
'--full' option by default. This solves issues when using less
common clang-format options that don't behave well with small
diffs. For example, AlignConsecutiveAssignments.

This is a replacement for the 'diff-lines-of-context' setting.

Bug: angleproject:4003
Change-Id: I81dc3b4992a7420e7235da88ec78e51ec4c0d24f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1879148
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

tests/git_cl_test.py

diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index f6e5d6f..e1b2266 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -724,6 +724,8 @@
         CERR1),
       ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
         CERR1),
+      ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
+        CERR1),
       ((['git', 'config', 'gerrit.host', 'true'],), ''),
     ]
     self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))