blob: f6e5d6fef6a7293d43dc06a8acb770d4399d53c4 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01008import datetime
tandriide281ae2016-10-12 06:02:30 -07009import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010010import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000011import os
Brian Sheedy59b06a82019-10-14 17:03:29 +000012import shutil
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
Edward Lemur4c707a22019-09-24 21:13:43 +000022from third_party import mock
maruel@chromium.orgddd59412011-11-30 14:20:38 +000023
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000024import metrics
25# We have to disable monitoring before importing git_cl.
26metrics.DISABLE_METRICS_COLLECTION = True
27
Eric Boren2fb63102018-10-05 13:05:03 +000028import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000029import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000030import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000031import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000032import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000033
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000034
tandrii5d48c322016-08-18 16:19:37 -070035def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
36 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
37
38
Edward Lemur4c707a22019-09-24 21:13:43 +000039def _constantFn(return_value):
40 def f(*args, **kwargs):
41 return return_value
42 return f
43
44
tandrii5d48c322016-08-18 16:19:37 -070045CERR1 = callError(1)
46
47
Aaron Gable9a03ae02017-11-03 11:31:07 -070048def MakeNamedTemporaryFileMock(expected_content):
49 class NamedTemporaryFileMock(object):
50 def __init__(self, *args, **kwargs):
51 self.name = '/tmp/named'
52 self.expected_content = expected_content
53
54 def __enter__(self):
55 return self
56
57 def __exit__(self, _type, _value, _tb):
58 pass
59
60 def write(self, content):
61 if self.expected_content:
62 assert content == self.expected_content
63
64 def close(self):
65 pass
66
67 return NamedTemporaryFileMock
68
69
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000070class ChangelistMock(object):
71 # A class variable so we can access it when we don't have access to the
72 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000073 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000074 def __init__(self, **kwargs):
75 pass
76 def GetIssue(self):
77 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080078 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000079 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070080 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000081 ChangelistMock.desc = desc
82
tandrii5d48c322016-08-18 16:19:37 -070083
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000084class PresubmitMock(object):
85 def __init__(self, *args, **kwargs):
86 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080087 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
88
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000089 @staticmethod
90 def should_continue():
91 return True
92
93
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000094class WatchlistsMock(object):
95 def __init__(self, _):
96 pass
97 @staticmethod
98 def GetWatchersForPaths(_):
99 return ['joe@example.com']
100
101
Edward Lemur4c707a22019-09-24 21:13:43 +0000102class CodereviewSettingsFileMock(object):
103 def __init__(self):
104 pass
105 # pylint: disable=no-self-use
106 def read(self):
107 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
108 'GERRIT_HOST: True\n')
109
110
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000111class AuthenticatorMock(object):
112 def __init__(self, *_args):
113 pass
114 def has_cached_credentials(self):
115 return True
tandrii221ab252016-10-06 08:12:04 -0700116 def authorize(self, http):
117 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000118
119
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100120def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000121 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
122
123 Usage:
124 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100125 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126
127 OR
128 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100129 CookiesAuthenticatorMockFactory(
130 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000131 """
132 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800133 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000134 # Intentionally not calling super() because it reads actual cookie files.
135 pass
136 @classmethod
137 def get_gitcookies_path(cls):
138 return '~/.gitcookies'
139 @classmethod
140 def get_netrc_path(cls):
141 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100142 def _get_auth_for_host(self, host):
143 if same_auth:
144 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000145 return (hosts_with_creds or {}).get(host)
146 return CookiesAuthenticatorMock
147
Aaron Gable9a03ae02017-11-03 11:31:07 -0700148
kmarshall9249e012016-08-23 12:02:16 -0700149class MockChangelistWithBranchAndIssue():
150 def __init__(self, branch, issue):
151 self.branch = branch
152 self.issue = issue
153 def GetBranch(self):
154 return self.branch
155 def GetIssue(self):
156 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000157
tandriic2405f52016-10-10 08:13:15 -0700158
159class SystemExitMock(Exception):
160 pass
161
162
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000163class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100164 def test_get_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000165 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100166 cl.description = 'x'
167 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000168 cl.FetchDescription = lambda *a, **kw: 'y'
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000169 self.assertEqual(cl.GetDescription(), 'x')
170 self.assertEqual(cl.GetDescription(force=True), 'y')
171 self.assertEqual(cl.GetDescription(), 'y')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100172
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700173 def test_description_footers(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000174 cl = git_cl.Changelist(issue=1, codereview_host='host')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700175 cl.description = '\n'.join([
176 'This is some message',
177 '',
178 'It has some lines',
179 'and, also',
180 '',
181 'Some: Really',
182 'Awesome: Footers',
183 ])
184 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000185 cl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700186 msg, footers = cl.GetDescriptionFooters()
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000187 self.assertEqual(
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700188 msg, ['This is some message', '', 'It has some lines', 'and, also'])
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000189 self.assertEqual(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700190
191 msg.append('wut')
192 footers.append(('gnarly-dude', 'beans'))
193 cl.UpdateDescriptionFooters(msg, footers)
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000194 self.assertEqual(cl.GetDescription().splitlines(), [
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700195 'This is some message',
196 '',
197 'It has some lines',
198 'and, also',
199 'wut'
200 '',
201 'Some: Really',
202 'Awesome: Footers',
203 'Gnarly-Dude: beans',
204 ])
205
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000206 def test_set_preserve_tryjobs(self):
207 d = git_cl.ChangeDescription('Simple.')
208 d.set_preserve_tryjobs()
209 self.assertEqual(d.description.splitlines(), [
210 'Simple.',
211 '',
212 'Cq-Do-Not-Cancel-Tryjobs: true',
213 ])
214 before = d.description
215 d.set_preserve_tryjobs()
216 self.assertEqual(before, d.description)
217
218 d = git_cl.ChangeDescription('\n'.join([
219 'One is enough',
220 '',
221 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
222 'Change-Id: Ideadbeef',
223 ]))
224 d.set_preserve_tryjobs()
225 self.assertEqual(d.description.splitlines(), [
226 'One is enough',
227 '',
228 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
229 'Change-Id: Ideadbeef',
230 'Cq-Do-Not-Cancel-Tryjobs: true',
231 ])
232
tandriif9aefb72016-07-01 09:06:51 -0700233 def test_get_bug_line_values(self):
234 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
235 self.assertEqual(f('', ''), [])
236 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
237 self.assertEqual(f('v8', '456'), ['v8:456'])
238 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
239 # Not nice, but not worth carying.
240 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
241 ['v8:456', 'chromium:123', 'v8:123'])
242
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100243 def _test_git_number(self, parent_msg, dest_ref, child_msg,
244 parent_hash='parenthash'):
245 desc = git_cl.ChangeDescription(child_msg)
246 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
247 return desc.description
248
249 def assertEqualByLine(self, actual, expected):
250 self.assertEqual(actual.splitlines(), expected.splitlines())
251
252 def test_git_number_bad_parent(self):
253 with self.assertRaises(ValueError):
254 self._test_git_number('Parent', 'refs/heads/master', 'Child')
255
256 def test_git_number_bad_parent_footer(self):
257 with self.assertRaises(AssertionError):
258 self._test_git_number(
259 'Parent\n'
260 '\n'
261 'Cr-Commit-Position: wrong',
262 'refs/heads/master', 'Child')
263
264 def test_git_number_bad_lineage_ignored(self):
265 actual = self._test_git_number(
266 'Parent\n'
267 '\n'
268 'Cr-Commit-Position: refs/heads/master@{#1}\n'
269 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
270 'refs/heads/master', 'Child')
271 self.assertEqualByLine(
272 actual,
273 'Child\n'
274 '\n'
275 'Cr-Commit-Position: refs/heads/master@{#2}\n'
276 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
277
278 def test_git_number_same_branch(self):
279 actual = self._test_git_number(
280 'Parent\n'
281 '\n'
282 'Cr-Commit-Position: refs/heads/master@{#12}',
283 dest_ref='refs/heads/master',
284 child_msg='Child')
285 self.assertEqualByLine(
286 actual,
287 'Child\n'
288 '\n'
289 'Cr-Commit-Position: refs/heads/master@{#13}')
290
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200291 def test_git_number_same_branch_mixed_footers(self):
292 actual = self._test_git_number(
293 'Parent\n'
294 '\n'
295 'Cr-Commit-Position: refs/heads/master@{#12}',
296 dest_ref='refs/heads/master',
297 child_msg='Child\n'
298 '\n'
299 'Broken-by: design\n'
300 'BUG=123')
301 self.assertEqualByLine(
302 actual,
303 'Child\n'
304 '\n'
305 'Broken-by: design\n'
306 'BUG=123\n'
307 'Cr-Commit-Position: refs/heads/master@{#13}')
308
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100309 def test_git_number_same_branch_with_originals(self):
310 actual = self._test_git_number(
311 'Parent\n'
312 '\n'
313 'Cr-Commit-Position: refs/heads/master@{#12}',
314 dest_ref='refs/heads/master',
315 child_msg='Child\n'
316 '\n'
317 'Some users are smart and insert their own footers\n'
318 '\n'
319 'Cr-Whatever: value\n'
320 'Cr-Commit-Position: refs/copy/paste@{#22}')
321 self.assertEqualByLine(
322 actual,
323 'Child\n'
324 '\n'
325 'Some users are smart and insert their own footers\n'
326 '\n'
327 'Cr-Original-Whatever: value\n'
328 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
329 'Cr-Commit-Position: refs/heads/master@{#13}')
330
331 def test_git_number_new_branch(self):
332 actual = self._test_git_number(
333 'Parent\n'
334 '\n'
335 'Cr-Commit-Position: refs/heads/master@{#12}',
336 dest_ref='refs/heads/branch',
337 child_msg='Child')
338 self.assertEqualByLine(
339 actual,
340 'Child\n'
341 '\n'
342 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
343 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
344
345 def test_git_number_lineage(self):
346 actual = self._test_git_number(
347 'Parent\n'
348 '\n'
349 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
350 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
351 dest_ref='refs/heads/branch',
352 child_msg='Child')
353 self.assertEqualByLine(
354 actual,
355 'Child\n'
356 '\n'
357 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
358 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
359
360 def test_git_number_moooooooore_lineage(self):
361 actual = self._test_git_number(
362 'Parent\n'
363 '\n'
364 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
365 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
366 dest_ref='refs/heads/mooore',
367 child_msg='Child')
368 self.assertEqualByLine(
369 actual,
370 'Child\n'
371 '\n'
372 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
373 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
374 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
375
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100376 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700377 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100378 actual = self._test_git_number(
379 'CQ commit on fresh new branch + numbering.\n'
380 '\n'
381 'NOTRY=True\n'
382 'NOPRESUBMIT=True\n'
383 'BUG=\n'
384 '\n'
385 'Review-Url: https://codereview.chromium.org/2577703003\n'
386 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
387 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
388 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
389 dest_ref='refs/heads/gnumb-test/cl',
390 child_msg='git cl on fresh new branch + numbering.\n'
391 '\n'
392 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
393 self.assertEqualByLine(
394 actual,
395 'git cl on fresh new branch + numbering.\n'
396 '\n'
397 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
398 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
399 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
400 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
401 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100402
403 def test_git_number_cherry_pick(self):
404 actual = self._test_git_number(
405 'Parent\n'
406 '\n'
407 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
408 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
409 dest_ref='refs/heads/branch',
410 child_msg='Child, which is cherry-pick from master\n'
411 '\n'
412 'Cr-Commit-Position: refs/heads/master@{#100}\n'
413 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
414 self.assertEqualByLine(
415 actual,
416 'Child, which is cherry-pick from master\n'
417 '\n'
418 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
419 '\n'
420 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
421 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
422 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
423
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000424 def test_valid_accounts(self):
425 mock_per_account = {
426 'u1': None, # 404, doesn't exist.
427 'u2': {
428 '_account_id': 123124,
429 'avatars': [],
430 'email': 'u2@example.com',
431 'name': 'User Number 2',
432 'status': 'OOO',
433 },
434 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
435 }
436 def GetAccountDetailsMock(_, account):
437 # Poor-man's mock library's side_effect.
438 v = mock_per_account.pop(account)
439 if isinstance(v, Exception):
440 raise v
441 return v
442
443 original = git_cl.gerrit_util.GetAccountDetails
444 try:
445 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
446 actual = git_cl.gerrit_util.ValidAccounts(
447 'host', ['u1', 'u2', 'u3'], max_threads=1)
448 finally:
449 git_cl.gerrit_util.GetAccountDetails = original
450 self.assertEqual(actual, {
451 'u2': {
452 '_account_id': 123124,
453 'avatars': [],
454 'email': 'u2@example.com',
455 'name': 'User Number 2',
456 'status': 'OOO',
457 },
458 })
459
460
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200461class TestParseIssueURL(unittest.TestCase):
462 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000463 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200464 self.assertIsNotNone(parsed)
465 if fail:
466 self.assertFalse(parsed.valid)
467 return
468 self.assertTrue(parsed.valid)
469 self.assertEqual(parsed.issue, issue)
470 self.assertEqual(parsed.patchset, patchset)
471 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200472
Edward Lemur678a6842019-10-03 22:25:05 +0000473 def test_ParseIssueNumberArgument(self):
474 def test(arg, *args, **kwargs):
475 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200476
Edward Lemur678a6842019-10-03 22:25:05 +0000477 test('123', 123)
478 test('', fail=True)
479 test('abc', fail=True)
480 test('123/1', fail=True)
481 test('123a', fail=True)
482 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200483
Edward Lemur678a6842019-10-03 22:25:05 +0000484 test('https://codereview.source.com/123',
485 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200486 test('http://chrome-review.source.com/c/123',
487 123, None, 'chrome-review.source.com')
488 test('https://chrome-review.source.com/c/123/',
489 123, None, 'chrome-review.source.com')
490 test('https://chrome-review.source.com/c/123/4',
491 123, 4, 'chrome-review.source.com')
492 test('https://chrome-review.source.com/#/c/123/4',
493 123, 4, 'chrome-review.source.com')
494 test('https://chrome-review.source.com/c/123/4',
495 123, 4, 'chrome-review.source.com')
496 test('https://chrome-review.source.com/123',
497 123, None, 'chrome-review.source.com')
498 test('https://chrome-review.source.com/123/4',
499 123, 4, 'chrome-review.source.com')
500
Edward Lemur678a6842019-10-03 22:25:05 +0000501 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200502 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
503 test('https://chrome-review.source.com/c/abc/', fail=True)
504 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
505
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200506
507
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100508class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100509 def setUp(self):
510 super(GitCookiesCheckerTest, self).setUp()
511 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100512 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100513
514 def mock_hosts_creds(self, subhost_identity_pairs):
515 def ensure_googlesource(h):
516 if not h.endswith(self.c._GOOGLESOURCE):
517 assert not h.endswith('.')
518 return h + '.' + self.c._GOOGLESOURCE
519 return h
520 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
521 for h, i in subhost_identity_pairs]
522
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200523 def test_identity_parsing(self):
524 self.assertEqual(self.c._parse_identity('ldap.google.com'),
525 ('ldap', 'google.com'))
526 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
527 ('ldap', 'example.com'))
528 # Specical case because we know there are no subdomains in chromium.org.
529 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
530 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800531 # Pathological: ".period." can be either username OR domain, more likely
532 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200533 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
534 ('note', 'period.example.com'))
535
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100536 def test_analysis_nothing(self):
537 self.c._all_hosts = []
538 self.assertFalse(self.c.has_generic_host())
539 self.assertEqual(set(), self.c.get_conflicting_hosts())
540 self.assertEqual(set(), self.c.get_duplicated_hosts())
541 self.assertEqual(set(), self.c.get_partially_configured_hosts())
542 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
543
544 def test_analysis(self):
545 self.mock_hosts_creds([
546 ('.googlesource.com', 'git-example.chromium.org'),
547
548 ('chromium', 'git-example.google.com'),
549 ('chromium-review', 'git-example.google.com'),
550 ('chrome-internal', 'git-example.chromium.org'),
551 ('chrome-internal-review', 'git-example.chromium.org'),
552 ('conflict', 'git-example.google.com'),
553 ('conflict-review', 'git-example.chromium.org'),
554 ('dup', 'git-example.google.com'),
555 ('dup', 'git-example.google.com'),
556 ('dup-review', 'git-example.google.com'),
557 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200558 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100559 ])
560 self.assertTrue(self.c.has_generic_host())
561 self.assertEqual(set(['conflict.googlesource.com']),
562 self.c.get_conflicting_hosts())
563 self.assertEqual(set(['dup.googlesource.com']),
564 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200565 self.assertEqual(set(['partial.googlesource.com',
566 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100567 self.c.get_partially_configured_hosts())
568 self.assertEqual(set(['chromium.googlesource.com',
569 'chrome-internal.googlesource.com']),
570 self.c.get_hosts_with_wrong_identities())
571
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100572 def test_report_no_problems(self):
573 self.test_analysis_nothing()
574 self.mock(sys, 'stdout', StringIO.StringIO())
575 self.assertFalse(self.c.find_and_report_problems())
576 self.assertEqual(sys.stdout.getvalue(), '')
577
578 def test_report(self):
579 self.test_analysis()
580 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200581 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
582 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100583 self.assertTrue(self.c.find_and_report_problems())
584 with open(os.path.join(os.path.dirname(__file__),
585 'git_cl_creds_check_report.txt')) as f:
586 expected = f.read()
587 def by_line(text):
588 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700589 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200590 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100591
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800592
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000593class TestGitCl(TestCase):
594 def setUp(self):
595 super(TestGitCl, self).setUp()
596 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700597 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000598 self.mock(git_cl, 'time_time',
599 lambda: self._mocked_call('time.time'))
600 self.mock(git_cl.metrics.collector, 'add_repeated',
601 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000602 self.mock(subprocess2, 'call', self._mocked_call)
603 self.mock(subprocess2, 'check_call', self._mocked_call)
604 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700605 self.mock(subprocess2, 'communicate',
606 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000607 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000608 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000609 self.mock(git_common, 'get_or_create_merge_base',
610 lambda *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000611 self._mocked_call(['get_or_create_merge_base'] + list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000612 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000613 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000614 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
615 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100616 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000617 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700618 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000619 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000620 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000621 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
Edward Lemur5b929a42019-10-21 17:57:39 +0000622 self.mock(git_cl.auth, 'Authenticator', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100623 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
624 lambda *args, **kwargs: self._mocked_call(
625 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700626 self.mock(git_cl.gerrit_util, 'GetChangeComments',
627 lambda *args, **kwargs: self._mocked_call(
628 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000629 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
630 lambda *args, **kwargs: self._mocked_call(
631 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100632 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700633 lambda h, i, reviewers, ccs, notify: self._mocked_call(
634 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700635 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700636 lambda h, i, msg=None, labels=None, notify=None:
637 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700638 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
639 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000640 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
641 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000642 self.mock(git_cl.gerrit_util, 'ValidAccounts',
643 lambda host, accounts:
644 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700645 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100646 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000647 # It's important to reset settings to not have inter-tests interference.
648 git_cl.settings = None
649
650 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000651 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000652 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100653 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000654 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100655 raise
656 # Sadly, has_failed() returns True if this OR any other tests before this
657 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200658 git_cl.logging.error(
659 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100660 'There are un-consumed self.calls after this test has finished.\n'
661 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700662 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200663 'If you are already running only this test, then **first** fix the '
664 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100665 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700666 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100667 'and follow instructions above.\n' +
668 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000669 finally:
670 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000671
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000672 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000673 self.assertTrue(
674 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700675 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000676 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000677 expected_args, result = top
678
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000679 # Also logs otherwise it could get caught in a try/finally and be hard to
680 # diagnose.
681 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700682 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000683 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700684 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
685 for i, c in enumerate(self._calls_done[-N:]))
686 following_calls = '\n '.join(
687 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
688 for i, c in enumerate(self.calls[:N]))
689 extended_msg = (
690 'A few prior calls:\n %s\n\n'
691 'This (expected):\n @%d: %r\n'
692 'This (actual):\n @%d: %r\n\n'
693 'A few following expected calls:\n %s' %
694 (prior_calls, len(self._calls_done), expected_args,
695 len(self._calls_done), args, following_calls))
696 git_cl.logging.error(extended_msg)
697
tandrii99a72f22016-08-17 14:33:24 -0700698 self.fail('@%d\n'
699 ' Expected: %r\n'
700 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700701 len(self._calls_done), expected_args, args))
702
703 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700704 if isinstance(result, Exception):
705 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000706 return result
707
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100708 def test_ask_for_explicit_yes_true(self):
709 self.calls = [
710 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
711 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
712 ]
713 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
714
tandrii48df5812016-10-17 03:55:37 -0700715 def test_LoadCodereviewSettingsFromFile_gerrit(self):
716 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
717 self.calls = [
718 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700719 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
720 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
721 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
722 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700723 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
724 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700725 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
726 CERR1),
727 ((['git', 'config', 'gerrit.host', 'true'],), ''),
728 ]
729 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
730
maruel@chromium.orga3353652011-11-30 14:26:57 +0000731 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000732 def _is_gerrit_calls(cls, gerrit=False):
733 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
734 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
735
736 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000737 def _git_post_upload_calls(cls):
738 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000739 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
740 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
741 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000742 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000743 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000744 ]
745
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000746 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000747 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000748 fake_ancestor = 'fake_ancestor'
749 fake_cl = 'fake_cl_for_patch'
750 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000751 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000752 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000753 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000754 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000755 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000756 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000757 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000758 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700759 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000760 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000761 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000762 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000763 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000764 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000765 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000766 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000767 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000768 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000769 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000770 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000771
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000772 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000773 def _gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000774 cls, issue=None, skip_auth_check=False, short_hostname='chromium',
775 custom_cl_base=None):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000776 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000777 if skip_auth_check:
778 return [((cmd, ), 'true')]
779
tandrii5d48c322016-08-18 16:19:37 -0700780 calls = [((cmd, ), CERR1)]
Edward Lemurf38bc172019-09-03 21:02:13 +0000781
782 if custom_cl_base:
783 calls += [
784 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
785 ]
786
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000787 calls.extend([
788 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
789 ((['git', 'config', 'branch.master.remote'],), 'origin'),
790 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000791 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000792 ])
Edward Lemurf38bc172019-09-03 21:02:13 +0000793
794 calls += [
795 ((['git', 'config', 'branch.master.gerritissue'],),
796 CERR1 if issue is None else str(issue)),
797 ]
798
Daniel Chengcf6269b2019-05-18 01:02:12 +0000799 if issue:
800 calls.extend([
801 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
802 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000803 return calls
804
805 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100806 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200807 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000808 custom_cl_base=None, short_hostname='chromium',
809 change_id=None):
Aaron Gable13101a62018-02-09 13:20:41 -0800810 calls = cls._is_gerrit_calls(True)
Edward Lemurf38bc172019-09-03 21:02:13 +0000811 if not custom_cl_base:
812 calls += [
813 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
814 ]
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200815
816 if custom_cl_base:
817 ancestor_revision = custom_cl_base
818 else:
819 # Determine ancestor_revision to be merge base.
820 ancestor_revision = 'fake_ancestor_sha'
821 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000822 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000823 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000824 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200825 'refs/remotes/origin/master'],), ancestor_revision),
826 ]
827
828 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000829 calls += cls._gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000830 issue=issue, short_hostname=short_hostname,
831 custom_cl_base=custom_cl_base)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100832
833 if issue:
834 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000835 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000836 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000837 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
838 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100839 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100840 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Anthony Polito8b955342019-09-24 19:01:36 +0000841 'change_id': (change_id or '123456789'),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100842 'current_revision': 'sha1_of_current_revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000843 'revisions': {'sha1_of_current_revision': {
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100844 'commit': {'message': fetched_description},
845 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100846 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100847 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100848 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100849 if fetched_status == 'ABANDONED':
850 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000851 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100852 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000853 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100854 ]
855 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100856 if other_cl_owner:
857 calls += [
858 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
859 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100860
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200861 calls += cls._git_sanity_checks(ancestor_revision, 'master',
862 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100863 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200864 ((['git', 'rev-parse', '--show-cdup'],), ''),
865 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000866
Aaron Gable7817f022017-12-12 09:43:17 -0800867 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
868 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200869 'M\t.gitignore\n'),
870 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100871 ]
872
873 if not issue:
874 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200875 ((['git', 'log', '--pretty=format:%s%n%n%b',
876 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000877 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100878 ]
879
880 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200881 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000882 (('time.time',), 1000,),
883 (('time.time',), 3000,),
884 (('add_repeated', 'sub_commands', {
885 'execution_time': 2000,
886 'command': 'presubmit',
887 'exit_code': 0
888 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200889 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
890 ([custom_cl_base] if custom_cl_base else
891 [ancestor_revision, 'HEAD']),),
892 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100893 ]
894 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000895
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000896 @classmethod
897 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700898 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000899 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700900 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100901 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000902 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000903 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000904 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000905 final_description=None, gitcookies_exists=True,
906 force=False):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000907 if post_amend_description is None:
908 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700909 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200910 # Determined in `_gerrit_base_calls`.
911 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
912
913 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000914
tandriia60502f2016-06-20 02:01:53 -0700915 if squash_mode == 'default':
916 calls.extend([
917 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
918 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
919 ])
920 elif squash_mode in ('override_squash', 'override_nosquash'):
921 calls.extend([
922 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
923 'true' if squash_mode == 'override_squash' else 'false'),
924 ])
925 else:
926 assert squash_mode in ('squash', 'nosquash')
927
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000928 # If issue is given, then description is fetched from Gerrit instead.
929 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000930 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200931 ((['git', 'log', '--pretty=format:%s\n\n%b',
932 ((custom_cl_base + '..') if custom_cl_base else
933 'fake_ancestor_sha..HEAD')],),
934 description),
935 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800936 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000937 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800938 else:
939 if not title:
940 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200941 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
942 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800943 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000944 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000945 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000946 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200947 (('DownloadGerritHook', False), ''),
948 # Amending of commit message to get the Change-Id.
949 ((['git', 'log', '--pretty=format:%s\n\n%b',
950 determined_ancestor_revision + '..HEAD'],),
951 description),
952 ((['git', 'commit', '--amend', '-m', description],), ''),
953 ((['git', 'log', '--pretty=format:%s\n\n%b',
954 determined_ancestor_revision + '..HEAD'],),
955 post_amend_description)
956 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000957 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000958 if force or not issue:
959 if issue:
960 calls += [
961 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
962 ]
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000963 # Prompting to edit description on first upload.
964 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000965 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000966 ]
Anthony Polito8b955342019-09-24 19:01:36 +0000967 if not force:
968 calls += [
969 ((['git', 'config', 'core.editor'],), ''),
970 ((['RunEditor'],), description),
971 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000972 ref_to_push = 'abcdef0123456789'
973 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200974 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
975 ((['git', 'config', 'branch.master.remote'],), 'origin'),
976 ]
977
978 if custom_cl_base is None:
979 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000980 ((['get_or_create_merge_base', 'master',
981 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000982 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200983 ]
984 parent = 'origin/master'
985 else:
986 calls += [
987 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
988 'refs/remotes/origin/master'],),
989 callError(1)), # Means not ancenstor.
990 (('ask_for_data',
991 'Do you take responsibility for cleaning up potential mess '
992 'resulting from proceeding with upload? Press Enter to upload, '
993 'or Ctrl+C to abort'), ''),
994 ]
995 parent = custom_cl_base
996
997 calls += [
998 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
999 '0123456789abcdef'),
1000 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001001 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001002 ref_to_push),
1003 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001004 else:
1005 ref_to_push = 'HEAD'
1006
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001007 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001008 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001009 ((['git', 'rev-list',
1010 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1011 ref_to_push],),
1012 '1hashPerLine\n'),
1013 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001014
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001015 metrics_arguments = []
1016
Aaron Gableafd52772017-06-27 16:40:10 -07001017 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001018 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001019 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001020 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001021 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001022 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001023 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001024 else:
1025 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001026 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001027
Aaron Gable70f4e242017-06-26 10:45:59 -07001028 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001029 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001030 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001031
Edward Lemur4508b422019-10-03 21:56:35 +00001032 if issue is None:
1033 calls += [
1034 ((['git', 'config', 'rietveld.cc'],), ''),
1035 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001036 if short_hostname == 'chromium':
1037 # All reviwers and ccs get into ref_suffix.
1038 for r in sorted(reviewers):
1039 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001040 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +00001041 if issue is None:
1042 cc += ['chromium-reviews+test-more-cc@chromium.org', 'joe@example.com']
1043 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001044 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001045 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001046 reviewers, cc = [], []
1047 else:
1048 # TODO(crbug/877717): remove this case.
1049 calls += [
1050 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1051 sorted(reviewers) + ['joe@example.com',
1052 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1053 {
1054 e: {'email': e}
1055 for e in (reviewers + ['joe@example.com'] + cc)
1056 })
1057 ]
1058 for r in sorted(reviewers):
1059 if r != 'bad-account-or-email':
1060 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001061 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001062 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +00001063 if issue is None:
1064 cc += ['joe@example.com']
1065 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001066 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001067 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001068 if c in cc:
1069 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001070
Edward Lemur687ca902018-12-05 02:30:30 +00001071 for k, v in sorted((labels or {}).items()):
1072 ref_suffix += ',l=%s+%d' % (k, v)
1073 metrics_arguments.append('l=%s+%d' % (k, v))
1074
1075 if tbr:
1076 calls += [
1077 (('GetCodeReviewTbrScore',
1078 '%s-review.googlesource.com' % short_hostname,
1079 'my/repo'),
1080 2,),
1081 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001082
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001083 calls += [
1084 (('time.time',), 1000,),
1085 ((['git', 'push',
1086 'https://%s.googlesource.com/my/repo' % short_hostname,
1087 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1088 (('remote:\n'
1089 'remote: Processing changes: (\)\n'
1090 'remote: Processing changes: (|)\n'
1091 'remote: Processing changes: (/)\n'
1092 'remote: Processing changes: (-)\n'
1093 'remote: Processing changes: new: 1 (/)\n'
1094 'remote: Processing changes: new: 1, done\n'
1095 'remote:\n'
1096 'remote: New Changes:\n'
1097 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1098 ' XXX\n'
1099 'remote:\n'
1100 'To https://%s.googlesource.com/my/repo\n'
1101 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1102 ) % (short_hostname, short_hostname)),),
1103 (('time.time',), 2000,),
1104 (('add_repeated',
1105 'sub_commands',
1106 {
1107 'execution_time': 1000,
1108 'command': 'git push',
1109 'exit_code': 0,
1110 'arguments': sorted(metrics_arguments),
1111 }),
1112 None,),
1113 ]
1114
Edward Lemur1b52d872019-05-09 21:12:12 +00001115 final_description = final_description or post_amend_description.strip()
1116 original_title = original_title or title or '<untitled>'
1117 # Trace-related calls
1118 calls += [
1119 # Write a description with context for the current trace.
1120 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001121 'Thu Mar 16 20:00:41 2017\n'
1122 '%(short_hostname)s-review.googlesource.com\n'
1123 '%(change_id)s\n'
1124 '%(title)s\n'
1125 '%(description)s\n'
1126 '1000\n'
1127 '0\n'
1128 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001129 'short_hostname': short_hostname,
1130 'change_id': change_id,
1131 'description': final_description,
1132 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001133 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001134 }],),
1135 None,
1136 ),
1137 # Read traces and shorten git hashes.
1138 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1139 True,
1140 ),
1141 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1142 ('git-hash: 0123456789012345678901234567890123456789\n'
1143 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1144 ),
1145 ((['FileWrite', 'TEMP_DIR/trace-packet',
1146 'git-hash: 012345\n'
1147 'git-hash: abcdea\n'],),
1148 None,
1149 ),
1150 # Make zip file for the git traces.
1151 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1152 'TEMP_DIR'],),
1153 None,
1154 ),
1155 # Collect git config and gitcookies.
1156 ((['git', 'config', '-l'],),
1157 'git-config-output',
1158 ),
1159 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1160 None,
1161 ),
1162 ((['os.path.isfile', '~/.gitcookies'],),
1163 gitcookies_exists,
1164 ),
1165 ]
1166 if gitcookies_exists:
1167 calls += [
1168 ((['FileRead', '~/.gitcookies'],),
1169 'gitcookies 1/SECRET',
1170 ),
1171 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1172 None,
1173 ),
1174 ]
1175 calls += [
1176 # Make zip file for the git config and gitcookies.
1177 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1178 'TEMP_DIR'],),
1179 None,
1180 ),
1181 ]
1182
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001183 if squash:
1184 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001185 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001186 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001187 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001188 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001189 ((['git', 'config', 'branch.master.gerritsquashhash',
1190 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001191 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001192 # TODO(crbug/877717): this should never be used.
1193 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001194 calls += [
1195 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001196 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001197 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001198 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1199 notify),
1200 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001201 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001202 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001203 return calls
1204
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001205 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001206 self,
1207 upload_args,
1208 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001209 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001210 squash=True,
1211 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001212 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001213 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001214 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001215 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001216 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001217 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001218 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001219 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001220 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001221 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001222 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001223 labels=None,
1224 change_id=None,
1225 original_title=None,
1226 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001227 gitcookies_exists=True,
1228 force=False,
1229 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001230 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001231 if squash_mode is None:
1232 if '--no-squash' in upload_args:
1233 squash_mode = 'nosquash'
1234 elif '--squash' in upload_args:
1235 squash_mode = 'squash'
1236 else:
1237 squash_mode = 'default'
1238
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001239 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001240 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001241 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001242 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001243 CookiesAuthenticatorMockFactory(
1244 same_auth=('git-owner.example.com', '', 'pass')))
Edward Lemur125d60a2019-09-13 18:25:41 +00001245 self.mock(git_cl.Changelist, '_GerritCommitMsgHookCheck',
tandrii16e0b4e2016-06-07 10:34:28 -07001246 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001247 self.mock(git_cl.gclient_utils, 'RunEditor',
1248 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001249 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1250 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001251 self.mock(git_cl.gclient_utils, 'FileRead',
1252 lambda path: self._mocked_call(['FileRead', path]))
1253 self.mock(git_cl.gclient_utils, 'FileWrite',
1254 lambda path, contents: self._mocked_call(
1255 ['FileWrite', path, contents]))
1256 self.mock(git_cl, 'datetime_now',
1257 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1258 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1259 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
Edward Lemur75391d42019-05-14 23:35:56 +00001260 self.mock(git_cl, 'TRACES_README_FORMAT',
1261 '%(now)s\n'
1262 '%(gerrit_host)s\n'
1263 '%(change_id)s\n'
1264 '%(title)s\n'
1265 '%(description)s\n'
1266 '%(execution_time)s\n'
1267 '%(exit_code)s\n'
1268 '%(trace_name)s')
Edward Lemur1b52d872019-05-09 21:12:12 +00001269 self.mock(git_cl.shutil, 'make_archive',
1270 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1271 self.mock(os.path, 'isfile',
1272 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001273
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001274 self.calls = self._gerrit_base_calls(
1275 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001276 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001277 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001278 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001279 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001280 short_hostname=short_hostname,
1281 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001282 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001283 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1284 expected_content=description))
1285 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001286 self.calls += self._gerrit_upload_calls(
1287 description, reviewers, squash,
1288 squash_mode=squash_mode,
1289 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001290 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001291 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001292 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001293 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001294 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001295 labels=labels,
1296 change_id=change_id,
1297 original_title=original_title,
1298 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001299 gitcookies_exists=gitcookies_exists,
1300 force=force)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001301 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001302 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001303 git_cl.main(['upload'] + upload_args)
1304
Edward Lemur1b52d872019-05-09 21:12:12 +00001305 def test_gerrit_upload_traces_no_gitcookies(self):
1306 self._run_gerrit_upload_test(
1307 ['--no-squash'],
1308 'desc\n\nBUG=\n',
1309 [],
1310 squash=False,
1311 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1312 change_id='Ixxx',
1313 gitcookies_exists=False)
1314
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001315 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001316 self._run_gerrit_upload_test(
1317 ['--no-squash'],
1318 'desc\n\nBUG=\n',
1319 [],
1320 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001321 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1322 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001323
1324 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001325 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001326 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001327 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001328 [],
tandriia60502f2016-06-20 02:01:53 -07001329 squash=False,
1330 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001331 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1332 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001333
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001334 def test_gerrit_no_reviewer(self):
1335 self._run_gerrit_upload_test(
1336 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001337 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001338 [],
1339 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001340 squash_mode='override_nosquash',
1341 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001342
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001343 def test_gerrit_no_reviewer_non_chromium_host(self):
1344 # TODO(crbug/877717): remove this test case.
1345 self._run_gerrit_upload_test(
1346 [],
1347 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1348 [],
1349 squash=False,
1350 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001351 short_hostname='other',
1352 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001353
Nick Carter8692b182017-11-06 16:30:38 -08001354 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001355 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1356 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001357 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001358 'desc\n\nBUG=\n\nChange-Id: I123456789',
1359 squash=False,
1360 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001361 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1362 change_id='I123456789',
1363 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001364
ukai@chromium.orge8077812012-02-03 03:41:46 +00001365 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001366 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001367 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001368 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001369 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001370 squash=False,
1371 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001372 notify=True,
1373 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001374 final_description=(
1375 'desc\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001376
Anthony Polito8b955342019-09-24 19:01:36 +00001377 def test_gerrit_upload_force_sets_bug(self):
1378 self._run_gerrit_upload_test(
1379 ['-b', '10000', '-f'],
1380 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1381 [],
1382 force=True,
1383 expected_upstream_ref='origin/master',
1384 fetched_description='desc=\n\nChange-Id: Ixxx',
1385 original_title='Initial upload',
1386 change_id='Ixxx')
1387
1388 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1389 self._run_gerrit_upload_test(
1390 ['-b', '10000', '-f', '-m', 'Title'],
1391 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1392 [],
1393 force=True,
1394 issue='123456',
1395 expected_upstream_ref='origin/master',
1396 fetched_description='desc=\n\nChange-Id: Ixxxx',
1397 original_title='Title',
1398 title='Title',
1399 change_id='Izzzz')
1400
Dan Beamd8b04ca2019-10-10 21:23:26 +00001401 def test_gerrit_upload_force_sets_fixed(self):
1402 self._run_gerrit_upload_test(
1403 ['-x', '10000', '-f'],
1404 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1405 [],
1406 force=True,
1407 expected_upstream_ref='origin/master',
1408 fetched_description='desc=\n\nChange-Id: Ixxx',
1409 original_title='Initial upload',
1410 change_id='Ixxx')
1411
ukai@chromium.orge8077812012-02-03 03:41:46 +00001412 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001413 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1414 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001415 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001416 [],
bradnelsond975b302016-10-23 12:20:23 -07001417 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1418 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001419 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001420 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001421 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001422 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001423 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001424 labels={'Code-Review': 2},
1425 change_id='123456789',
1426 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001427
1428 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001429 self._run_gerrit_upload_test(
1430 [],
1431 'desc\nBUG=\n\nChange-Id: 123456789',
1432 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001433 expected_upstream_ref='origin/master',
1434 change_id='123456789',
1435 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001436
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001437 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001438 self._run_gerrit_upload_test(
1439 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001440 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001441 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001442 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001443 expected_upstream_ref='origin/master',
1444 change_id='123456789',
1445 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001446
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001447 def test_gerrit_upload_squash_first_with_labels(self):
1448 self._run_gerrit_upload_test(
1449 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1450 'desc\nBUG=\n\nChange-Id: 123456789',
1451 [],
1452 squash=True,
1453 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001454 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1455 change_id='123456789',
1456 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001457
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001458 def test_gerrit_upload_squash_first_against_rev(self):
1459 custom_cl_base = 'custom_cl_base_rev_or_branch'
1460 self._run_gerrit_upload_test(
1461 ['--squash', custom_cl_base],
1462 'desc\nBUG=\n\nChange-Id: 123456789',
1463 [],
1464 squash=True,
1465 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001466 custom_cl_base=custom_cl_base,
1467 change_id='123456789',
1468 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001469 self.assertIn(
1470 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1471 sys.stdout.getvalue())
1472
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001473 def test_gerrit_upload_squash_reupload(self):
1474 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001475 self._run_gerrit_upload_test(
1476 ['--squash'],
1477 description,
1478 [],
1479 squash=True,
1480 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001481 issue=123456,
1482 change_id='123456789',
1483 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001484
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001485 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1486 self.mock(git_cl, 'DieWithError',
1487 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1488 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1489 with self.assertRaises(SystemExitMock):
1490 self._run_gerrit_upload_test(
1491 ['--squash'],
1492 description,
1493 [],
1494 squash=True,
1495 expected_upstream_ref='origin/master',
1496 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001497 fetched_status='ABANDONED',
1498 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001499
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001500 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1501 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1502 lambda *_, **__: {'email': 'yet-another@example.com'})
1503 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1504 self._run_gerrit_upload_test(
1505 ['--squash'],
1506 description,
1507 [],
1508 squash=True,
1509 expected_upstream_ref='origin/master',
1510 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001511 other_cl_owner='other@example.com',
1512 change_id='123456789',
1513 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001514 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001515 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001516 'authenticate to Gerrit as yet-another@example.com.\n'
1517 'Uploading may fail due to lack of permissions',
1518 git_cl.sys.stdout.getvalue())
1519
rmistry@google.com2dd99862015-06-22 12:22:18 +00001520 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001521 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001522 def mock_run_git(*args, **_kwargs):
1523 if args[0] == ['for-each-ref',
1524 '--format=%(refname:short) %(upstream:short)',
1525 'refs/heads']:
1526 # Create a local branch dependency tree that looks like this:
1527 # test1 -> test2 -> test3 -> test4 -> test5
1528 # -> test3.1
1529 # test6 -> test0
1530 branch_deps = [
1531 'test2 test1', # test1 -> test2
1532 'test3 test2', # test2 -> test3
1533 'test3.1 test2', # test2 -> test3.1
1534 'test4 test3', # test3 -> test4
1535 'test5 test4', # test4 -> test5
1536 'test6 test0', # test0 -> test6
1537 'test7', # test7
1538 ]
1539 return '\n'.join(branch_deps)
1540 self.mock(git_cl, 'RunGit', mock_run_git)
1541
1542 class RecordCalls:
1543 times_called = 0
1544 record_calls = RecordCalls()
1545 def mock_CMDupload(*args, **_kwargs):
1546 record_calls.times_called += 1
1547 return 0
1548 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1549
1550 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001551 (('ask_for_data', 'This command will checkout all dependent branches '
1552 'and run "git cl upload". Press Enter to continue, '
1553 'or Ctrl+C to abort'), ''),
1554 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001555
1556 class MockChangelist():
1557 def __init__(self):
1558 pass
1559 def GetBranch(self):
1560 return 'test1'
1561 def GetIssue(self):
1562 return '123'
1563 def GetPatchset(self):
1564 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001565 def IsGerrit(self):
1566 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001567
1568 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1569 # CMDupload should have been called 5 times because of 5 dependent branches.
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001570 self.assertEqual(5, record_calls.times_called)
1571 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001572
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001573 def test_gerrit_change_id(self):
1574 self.calls = [
1575 ((['git', 'write-tree'], ),
1576 'hashtree'),
1577 ((['git', 'rev-parse', 'HEAD~0'], ),
1578 'branch-parent'),
1579 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1580 'A B <a@b.org> 1456848326 +0100'),
1581 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1582 'C D <c@d.org> 1456858326 +0100'),
1583 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1584 'hashchange'),
1585 ]
1586 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1587 self.assertEqual(change_id, 'Ihashchange')
1588
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001589 def test_desecription_append_footer(self):
1590 for init_desc, footer_line, expected_desc in [
1591 # Use unique desc first lines for easy test failure identification.
1592 ('foo', 'R=one', 'foo\n\nR=one'),
1593 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1594 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1595 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1596 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1597 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1598 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1599 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1600 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1601 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1602 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1603 ]:
1604 desc = git_cl.ChangeDescription(init_desc)
1605 desc.append_footer(footer_line)
1606 self.assertEqual(desc.description, expected_desc)
1607
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001608 def test_update_reviewers(self):
1609 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001610 ('foo', [], [],
1611 'foo'),
1612 ('foo\nR=xx', [], [],
1613 'foo\nR=xx'),
1614 ('foo\nTBR=xx', [], [],
1615 'foo\nTBR=xx'),
1616 ('foo', ['a@c'], [],
1617 'foo\n\nR=a@c'),
1618 ('foo\nR=xx', ['a@c'], [],
1619 'foo\n\nR=a@c, xx'),
1620 ('foo\nTBR=xx', ['a@c'], [],
1621 'foo\n\nR=a@c\nTBR=xx'),
1622 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1623 'foo\n\nR=a@c, yy\nTBR=xx'),
1624 ('foo\nBUG=', ['a@c'], [],
1625 'foo\nBUG=\nR=a@c'),
1626 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1627 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1628 ('foo', ['a@c', 'b@c'], [],
1629 'foo\n\nR=a@c, b@c'),
1630 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1631 'foo\nBar\n\nR=c@c\nBUG='),
1632 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1633 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001634 # Same as the line before, but full of whitespaces.
1635 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001636 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001637 'foo\nBar\n\nR=c@c\n BUG =',
1638 ),
1639 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001640 ('foo BUG=allo R=joe ', ['c@c'], [],
1641 'foo BUG=allo R=joe\n\nR=c@c'),
1642 # Redundant TBRs get promoted to Rs
1643 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1644 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001645 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001646 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001647 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001648 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001649 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001650 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001651 actual.append(obj.description)
1652 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001653
Nodir Turakulov23b82142017-11-16 11:04:25 -08001654 def test_get_hash_tags(self):
1655 cases = [
1656 ('', []),
1657 ('a', []),
1658 ('[a]', ['a']),
1659 ('[aa]', ['aa']),
1660 ('[a ]', ['a']),
1661 ('[a- ]', ['a']),
1662 ('[a- b]', ['a-b']),
1663 ('[a--b]', ['a-b']),
1664 ('[a', []),
1665 ('[a]x', ['a']),
1666 ('[aa]x', ['aa']),
1667 ('[a b]', ['a-b']),
1668 ('[a b]', ['a-b']),
1669 ('[a__b]', ['a-b']),
1670 ('[a] x', ['a']),
1671 ('[a][b]', ['a', 'b']),
1672 ('[a] [b]', ['a', 'b']),
1673 ('[a][b]x', ['a', 'b']),
1674 ('[a][b] x', ['a', 'b']),
1675 ('[a]\n[b]', ['a']),
1676 ('[a\nb]', []),
1677 ('[a][', ['a']),
1678 ('Revert "[a] feature"', ['a']),
1679 ('Reland "[a] feature"', ['a']),
1680 ('Revert: [a] feature', ['a']),
1681 ('Reland: [a] feature', ['a']),
1682 ('Revert "Reland: [a] feature"', ['a']),
1683 ('Foo: feature', ['foo']),
1684 ('Foo Bar: feature', ['foo-bar']),
1685 ('Revert "Foo bar: feature"', ['foo-bar']),
1686 ('Reland "Foo bar: feature"', ['foo-bar']),
1687 ]
1688 for desc, expected in cases:
1689 change_desc = git_cl.ChangeDescription(desc)
1690 actual = change_desc.get_hash_tags()
1691 self.assertEqual(
1692 actual,
1693 expected,
1694 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1695
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001696 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001697 self.assertEqual(None, git_cl.GetTargetRef(None,
1698 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001699 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001700
wittman@chromium.org455dc922015-01-26 20:15:50 +00001701 # Check default target refs for branches.
1702 self.assertEqual('refs/heads/master',
1703 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001704 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001705 self.assertEqual('refs/heads/master',
1706 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001707 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001708 self.assertEqual('refs/heads/master',
1709 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001710 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001711 self.assertEqual('refs/branch-heads/123',
1712 git_cl.GetTargetRef('origin',
1713 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001714 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001715 self.assertEqual('refs/diff/test',
1716 git_cl.GetTargetRef('origin',
1717 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001718 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001719 self.assertEqual('refs/heads/chrome/m42',
1720 git_cl.GetTargetRef('origin',
1721 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001722 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001723
1724 # Check target refs for user-specified target branch.
1725 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1726 'refs/remotes/branch-heads/123'):
1727 self.assertEqual('refs/branch-heads/123',
1728 git_cl.GetTargetRef('origin',
1729 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001730 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001731 for branch in ('origin/master', 'remotes/origin/master',
1732 'refs/remotes/origin/master'):
1733 self.assertEqual('refs/heads/master',
1734 git_cl.GetTargetRef('origin',
1735 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001736 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001737 for branch in ('master', 'heads/master', 'refs/heads/master'):
1738 self.assertEqual('refs/heads/master',
1739 git_cl.GetTargetRef('origin',
1740 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001741 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001742
wychen@chromium.orga872e752015-04-28 23:42:18 +00001743 def test_patch_when_dirty(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001744 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001745 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1746 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1747
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001748 @staticmethod
1749 def _get_gerrit_codereview_server_calls(branch, value=None,
1750 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001751 detect_branch=True,
1752 detect_server=True):
Edward Lemur125d60a2019-09-13 18:25:41 +00001753 """Returns calls executed by Changelist.GetCodereviewServer.
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001754
1755 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1756 """
1757 calls = []
1758 if detect_branch:
1759 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001760 if detect_server:
1761 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1762 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001763 if value is None:
1764 calls += [
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001765 ((['git', 'config', 'branch.' + branch + '.merge'],),
1766 'refs/heads' + branch),
1767 ((['git', 'config', 'branch.' + branch + '.remote'],),
1768 'origin'),
1769 ((['git', 'config', 'remote.origin.url'],),
1770 'https://%s.googlesource.com/my/repo' % git_short_host),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001771 ]
1772 return calls
1773
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001774 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001775 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001776 detect_gerrit_server=False,
1777 actual_codereview=None,
1778 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001779 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001780 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1781
tandriidf09a462016-08-18 16:23:55 -07001782 if new_branch:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001783 self.calls = [((['git', 'new-branch', 'master'],), '')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001784
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001785 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001786 self.calls += [
1787 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001788 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001789 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001790
1791 if not force_codereview and not codereview_in_url:
1792 # These calls detect codereview to use.
1793 self.calls += [
1794 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001795 ]
1796 if detect_gerrit_server:
1797 self.calls += self._get_gerrit_codereview_server_calls(
1798 'master', git_short_host=git_short_host,
1799 detect_branch=not new_branch and force_codereview)
1800 actual_codereview = 'gerrit'
1801
1802 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001803 self.calls += [
1804 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001805 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001806 {
1807 'current_revision': '7777777777',
1808 'revisions': {
1809 '1111111111': {
1810 '_number': 1,
1811 'fetch': {'http': {
1812 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1813 'ref': 'refs/changes/56/123456/1',
1814 }},
1815 },
1816 '7777777777': {
1817 '_number': 7,
1818 'fetch': {'http': {
1819 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1820 'ref': 'refs/changes/56/123456/7',
1821 }},
1822 },
1823 },
1824 }),
1825 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001826
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001827 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001828 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001829 self.calls += [
1830 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1831 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001832 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001833 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001834 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001835 ((['git', 'config', 'branch.master.gerritserver',
1836 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001837 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001838 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1839 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1840 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001841 ]
1842 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1843
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001844 def test_patch_gerrit_new_branch(self):
1845 self._patch_common(
1846 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1847 self.calls += [
1848 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1849 'refs/changes/56/123456/7'],), ''),
1850 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1851 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1852 ''),
1853 ((['git', 'config', 'branch.master.gerritserver',
1854 'https://chromium-review.googlesource.com'],), ''),
1855 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1856 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1857 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1858 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1859 ]
1860 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1861
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001862 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001863 self._patch_common(
1864 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001865 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001866 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001867 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001868 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001869 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001870 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001871 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001872 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001873 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001874 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1875 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1876 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001877 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001878 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001879
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001880 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001881 self.calls += self._get_gerrit_codereview_server_calls(
1882 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001883 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001884 actual_codereview='gerrit', git_short_host='else',
1885 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001886 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001887 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001888 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001889 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001890 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001891 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001892 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001893 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001894 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001895 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1896 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1897 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001898 ]
1899 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001900 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001901
Aaron Gable697a91b2018-01-19 15:20:15 -08001902 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001903 self.calls += self._get_gerrit_codereview_server_calls(
1904 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001905 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001906 actual_codereview='gerrit', git_short_host='else',
1907 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001908 self.calls += [
1909 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1910 'refs/changes/56/123456/1'],), ''),
1911 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1912 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1913 ''),
1914 ((['git', 'config', 'branch.master.gerritserver',
1915 'https://else-review.googlesource.com'],), ''),
1916 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1917 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1918 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1919 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1920 ]
1921 self.assertEqual(git_cl.main(
1922 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1923 0)
1924
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001925 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001926 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001927 self.calls += [
1928 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001929 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001930 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1931 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1932 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001933 ]
1934 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001935 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001936
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001937 def test_patch_gerrit_not_exists(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001938
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001939 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001940 raise git_cl.gerrit_util.GerritError(404, '')
1941 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1942
tandriic2405f52016-10-10 08:13:15 -07001943 self.calls = [
1944 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001945 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1946 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1947 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1948 ((['git', 'config', 'remote.origin.url'],),
1949 'https://chromium.googlesource.com/my/repo'),
1950 ((['DieWithError',
1951 'change 123456 at https://chromium-review.googlesource.com does not '
1952 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001953 ]
1954 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001955 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001956
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001957 def _checkout_calls(self):
1958 return [
1959 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001960 'branch\\..*\\.gerritissue'], ),
1961 ('branch.ger-branch.gerritissue 123456\n'
1962 'branch.gbranch654.gerritissue 654321\n')),
1963 ]
1964
1965 def test_checkout_gerrit(self):
1966 """Tests git cl checkout <issue>."""
1967 self.calls = self._checkout_calls()
1968 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1969 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1970
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001971 def test_checkout_not_found(self):
1972 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001973 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001974 self.calls = self._checkout_calls()
1975 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1976
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001977 def test_checkout_no_branch_issues(self):
1978 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001979 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001980 self.calls = [
1981 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001982 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001983 ]
1984 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1985
tandrii@chromium.org28253532016-04-14 13:46:56 +00001986 def _test_gerrit_ensure_authenticated_common(self, auth,
1987 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001988 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1989 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1990 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001991 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001992 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
Edward Lemurf38bc172019-09-03 21:02:13 +00001993 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001994 cl.branch = 'master'
1995 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001996 return cl
1997
1998 def test_gerrit_ensure_authenticated_missing(self):
1999 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002000 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002001 })
2002 self.calls.append(
2003 ((['DieWithError',
2004 'Credentials for the following hosts are required:\n'
2005 ' chromium-review.googlesource.com\n'
2006 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002007 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002008 'https://chromium-review.googlesource.com/new-password'],), ''),)
2009 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2010
2011 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00002012 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002013 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002014 'chromium.googlesource.com':
2015 ('git-one.example.com', None, 'secret1'),
2016 'chromium-review.googlesource.com':
2017 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002018 })
2019 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002020 (('ask_for_data', 'If you know what you are doing '
2021 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002022 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2023
2024 def test_gerrit_ensure_authenticated_ok(self):
2025 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002026 'chromium.googlesource.com':
2027 ('git-same.example.com', None, 'secret'),
2028 'chromium-review.googlesource.com':
2029 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002030 })
2031 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2032
tandrii@chromium.org28253532016-04-14 13:46:56 +00002033 def test_gerrit_ensure_authenticated_skipped(self):
2034 cl = self._test_gerrit_ensure_authenticated_common(
2035 auth={}, skip_auth_check=True)
2036 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2037
Eric Boren2fb63102018-10-05 13:05:03 +00002038 def test_gerrit_ensure_authenticated_bearer_token(self):
2039 cl = self._test_gerrit_ensure_authenticated_common(auth={
2040 'chromium.googlesource.com':
2041 ('', None, 'secret'),
2042 'chromium-review.googlesource.com':
2043 ('', None, 'secret'),
2044 })
2045 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2046 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2047 'chromium.googlesource.com')
2048 self.assertTrue('Bearer' in header)
2049
Daniel Chengcf6269b2019-05-18 01:02:12 +00002050 def test_gerrit_ensure_authenticated_non_https(self):
2051 self.calls = [
2052 ((['git', 'config', '--bool',
2053 'gerrit.skip-ensure-authenticated'],), CERR1),
2054 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2055 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2056 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
2057 ]
2058 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2059 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
Edward Lemurf38bc172019-09-03 21:02:13 +00002060 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002061 cl.branch = 'master'
2062 cl.branchref = 'refs/heads/master'
2063 cl.lookedup_issue = True
2064 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2065
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002066 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002067 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002068 lambda h, i, labels, notify=None:
2069 self._mocked_call(['SetReview', h, i, labels, notify]))
2070
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002071 self.calls = [
2072 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002073 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002074 ((['git', 'config', 'branch.feature.gerritserver'],),
2075 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002076 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2077 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2078 ((['git', 'config', 'remote.origin.url'],),
2079 'https://chromium.googlesource.com/infra/infra.git'),
2080 ((['SetReview', 'chromium-review.googlesource.com',
2081 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002082 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002083 ]
tandriid9e5ce52016-07-13 02:32:59 -07002084
2085 def test_cmd_set_commit_gerrit_clear(self):
2086 self._cmd_set_commit_gerrit_common(0)
2087 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2088
2089 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002090 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002091 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2092
tandriid9e5ce52016-07-13 02:32:59 -07002093 def test_cmd_set_commit_gerrit(self):
2094 self._cmd_set_commit_gerrit_common(2)
2095 self.assertEqual(0, git_cl.main(['set-commit']))
2096
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002097 def test_description_display(self):
2098 out = StringIO.StringIO()
2099 self.mock(git_cl.sys, 'stdout', out)
2100
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002101 self.mock(git_cl, 'Changelist', ChangelistMock)
2102 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002103
2104 self.assertEqual(0, git_cl.main(['description', '-d']))
2105 self.assertEqual('foo\n', out.getvalue())
2106
iannucci3c972b92016-08-17 13:24:10 -07002107 def test_StatusFieldOverrideIssueMissingArgs(self):
2108 out = StringIO.StringIO()
2109 self.mock(git_cl.sys, 'stderr', out)
2110
2111 try:
2112 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2113 except SystemExit as ex:
2114 self.assertEqual(ex.code, 2)
Edward Lemurf38bc172019-09-03 21:02:13 +00002115 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002116
2117 out = StringIO.StringIO()
2118 self.mock(git_cl.sys, 'stderr', out)
2119
2120 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002121 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002122 except SystemExit as ex:
2123 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002124 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002125
2126 def test_StatusFieldOverrideIssue(self):
2127 out = StringIO.StringIO()
2128 self.mock(git_cl.sys, 'stdout', out)
2129
2130 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002131 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002132 return 'foobar'
2133
2134 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002135 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002136 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002137 0)
iannucci3c972b92016-08-17 13:24:10 -07002138 self.assertEqual(out.getvalue(), 'foobar\n')
2139
iannuccie53c9352016-08-17 14:40:40 -07002140 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002141
iannuccie53c9352016-08-17 14:40:40 -07002142 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002143 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002144 return 'foobar'
2145
2146 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2147 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002148 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002149 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002150
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002151 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002152 out = StringIO.StringIO()
2153 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002154 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002155 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2156 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2157 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2158 ((['git', 'config', 'remote.origin.url'],),
2159 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002160 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002161 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002162 {
2163 'current_revision': 'sha1',
2164 'revisions': {'sha1': {
2165 'commit': {'message': 'foobar'},
2166 }},
2167 }),
2168 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002169 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002170 'description',
2171 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2172 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002173 self.assertEqual('foobar\n', out.getvalue())
2174
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002175 def test_description_set_raw(self):
2176 out = StringIO.StringIO()
2177 self.mock(git_cl.sys, 'stdout', out)
2178
2179 self.mock(git_cl, 'Changelist', ChangelistMock)
2180 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2181
2182 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2183 self.assertEqual('hihi', ChangelistMock.desc)
2184
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002185 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002186 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002187
2188 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002189 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002190 '# Enter a description of the change.\n'
2191 '# This will be displayed on the codereview site.\n'
2192 '# The first line will also be used as the subject of the review.\n'
2193 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002194 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002195 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002196 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002197 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002198 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002199
dsansomee2d6fd92016-09-08 00:10:47 -07002200 def UpdateDescriptionRemote(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002201 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002202
2203 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2204 self.mock(git_cl.Changelist, 'GetDescription',
2205 lambda *args: current_desc)
Edward Lemur125d60a2019-09-13 18:25:41 +00002206 self.mock(git_cl.Changelist, 'UpdateDescriptionRemote',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002207 UpdateDescriptionRemote)
2208 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2209
2210 self.calls = [
2211 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002212 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002213 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2214 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002215 ((['git', 'config', 'core.editor'],), 'vi'),
2216 ]
2217 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2218
Dan Beamd8b04ca2019-10-10 21:23:26 +00002219 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2220 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2221
2222 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002223 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002224 '# Enter a description of the change.\n'
2225 '# This will be displayed on the codereview site.\n'
2226 '# The first line will also be used as the subject of the review.\n'
2227 '#--------------------This line is 72 characters long'
2228 '--------------------\n'
2229 'Some.\n\nFixed: 123\nChange-Id: xxx',
2230 desc)
2231 return desc
2232
2233 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2234 self.mock(git_cl.Changelist, 'GetDescription',
2235 lambda *args: current_desc)
2236 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2237
2238 self.calls = [
2239 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2240 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2241 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2242 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
2243 ((['git', 'config', 'core.editor'],), 'vi'),
2244 ]
2245 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2246
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002247 def test_description_set_stdin(self):
2248 out = StringIO.StringIO()
2249 self.mock(git_cl.sys, 'stdout', out)
2250
2251 self.mock(git_cl, 'Changelist', ChangelistMock)
2252 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2253
2254 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2255 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2256
kmarshall3bff56b2016-06-06 18:31:47 -07002257 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002258 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2259
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002260 self.calls = [
2261 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002262 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002263 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2264 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002265 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002266 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002267
kmarshall3bff56b2016-06-06 18:31:47 -07002268 self.mock(git_cl, 'get_cl_statuses',
2269 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002270 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2271 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2272 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002273
2274 self.assertEqual(0, git_cl.main(['archive', '-f']))
2275
2276 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002277 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002278 self.calls = [
2279 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2280 'refs/heads/master'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002281 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2282 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002283
kmarshall9249e012016-08-23 12:02:16 -07002284 self.mock(git_cl, 'get_cl_statuses',
2285 lambda branches, fine_grained, max_processes:
2286 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2287
2288 self.assertEqual(1, git_cl.main(['archive', '-f']))
2289
2290 def test_archive_dry_run(self):
2291 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2292
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002293 self.calls = [
2294 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2295 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002296 ((['git', 'symbolic-ref', 'HEAD'],), 'master')
2297 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002298
2299 self.mock(git_cl, 'get_cl_statuses',
2300 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002301 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2302 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2303 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002304
kmarshall9249e012016-08-23 12:02:16 -07002305 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2306
2307 def test_archive_no_tags(self):
2308 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2309
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002310 self.calls = [
2311 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2312 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002313 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2314 ((['git', 'branch', '-D', 'foo'],), '')
2315 ]
kmarshall9249e012016-08-23 12:02:16 -07002316
2317 self.mock(git_cl, 'get_cl_statuses',
2318 lambda branches, fine_grained, max_processes:
2319 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2320 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2321 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2322
2323 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002324
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002325 def test_cmd_issue_erase_existing(self):
2326 out = StringIO.StringIO()
2327 self.mock(git_cl.sys, 'stdout', out)
2328 self.calls = [
2329 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002330 # Let this command raise exception (retcode=1) - it should be ignored.
2331 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002332 CERR1),
2333 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2334 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002335 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2336 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2337 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002338 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002339 ]
2340 self.assertEqual(0, git_cl.main(['issue', '0']))
2341
Aaron Gable400e9892017-07-12 15:31:21 -07002342 def test_cmd_issue_erase_existing_with_change_id(self):
2343 out = StringIO.StringIO()
2344 self.mock(git_cl.sys, 'stdout', out)
2345 self.mock(git_cl.Changelist, 'GetDescription',
2346 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2347 self.calls = [
2348 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002349 # Let this command raise exception (retcode=1) - it should be ignored.
2350 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2351 CERR1),
2352 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2353 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2354 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2355 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2356 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002357 ((['git', 'log', '-1', '--format=%B'],),
2358 'This is a description\n\nChange-Id: Ideadbeef'),
2359 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002360 ]
2361 self.assertEqual(0, git_cl.main(['issue', '0']))
2362
phajdan.jre328cf92016-08-22 04:12:17 -07002363 def test_cmd_issue_json(self):
2364 out = StringIO.StringIO()
2365 self.mock(git_cl.sys, 'stdout', out)
2366 self.calls = [
2367 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002368 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2369 ((['git', 'config', 'branch.feature.gerritserver'],),
2370 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002371 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002372 {'issue': 123,
2373 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002374 ''),
2375 ]
2376 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2377
tandrii16e0b4e2016-06-07 10:34:28 -07002378 def _common_GerritCommitMsgHookCheck(self):
2379 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2380 self.mock(git_cl.os.path, 'abspath',
2381 lambda path: self._mocked_call(['abspath', path]))
2382 self.mock(git_cl.os.path, 'exists',
2383 lambda path: self._mocked_call(['exists', path]))
2384 self.mock(git_cl.gclient_utils, 'FileRead',
2385 lambda path: self._mocked_call(['FileRead', path]))
2386 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2387 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2388 self.calls = [
2389 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2390 ((['abspath', '../'],), '/abs/git_repo_root'),
2391 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002392 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002393
2394 def test_GerritCommitMsgHookCheck_custom_hook(self):
2395 cl = self._common_GerritCommitMsgHookCheck()
2396 self.calls += [
2397 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2398 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2399 '#!/bin/sh\necho "custom hook"')
2400 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002401 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002402
2403 def test_GerritCommitMsgHookCheck_not_exists(self):
2404 cl = self._common_GerritCommitMsgHookCheck()
2405 self.calls += [
2406 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2407 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002408 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002409
2410 def test_GerritCommitMsgHookCheck(self):
2411 cl = self._common_GerritCommitMsgHookCheck()
2412 self.calls += [
2413 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2414 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2415 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002416 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002417 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2418 ''),
2419 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002420 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002421
tandriic4344b52016-08-29 06:04:54 -07002422 def test_GerritCmdLand(self):
2423 self.calls += [
2424 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2425 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2426 'deadbeaf'),
2427 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2428 ((['git', 'config', 'branch.feature.gerritserver'],),
2429 'chromium-review.googlesource.com'),
2430 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002431 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002432 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002433 'labels': {},
2434 'current_revision': 'deadbeaf',
2435 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002436 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002437 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002438 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002439 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2440 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002441 cl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002442 out = StringIO.StringIO()
2443 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002444 self.assertEqual(0, cl.CMDLand(force=True,
2445 bypass_hooks=True,
2446 verbose=True,
2447 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002448 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002449 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002450
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002451 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemur125d60a2019-09-13 18:25:41 +00002452 self.mock(git_cl.Changelist, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002453
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002454 def test_gerrit_change_detail_cache_simple(self):
2455 self._mock_gerrit_changes_for_detail_cache()
2456 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002457 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2458 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2459 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002460 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002461 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002462 cl1._cached_remote_url = (
2463 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002464 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002465 cl2._cached_remote_url = (
2466 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002467 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2468 self.assertEqual(cl1._GetChangeDetail(), 'a')
2469 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2470 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2471 self.assertEqual(cl1._GetChangeDetail(), 'a')
2472 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002473
2474 def test_gerrit_change_detail_cache_options(self):
2475 self._mock_gerrit_changes_for_detail_cache()
2476 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002477 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2478 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2479 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2480 # no longer in cache.
2481 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002482 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002483 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002484 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002485 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2486 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2487 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2488 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2489 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2490 self.assertEqual(cl._GetChangeDetail(), 'cab')
2491
2492 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2493 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2494 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2495 self.assertEqual(cl._GetChangeDetail(), 'cab')
2496
2497 # Finally, no_cache should invalidate all caches for given change.
2498 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2499 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2500
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002501 def test_gerrit_description_caching(self):
2502 def gen_detail(rev, desc):
2503 return {
2504 'current_revision': rev,
2505 'revisions': {rev: {'commit': {'message': desc}}}
2506 }
2507 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002508 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002509 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2510 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002511 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002512 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2513 gen_detail('rev2', 'desc2')),
2514 ]
2515
2516 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002517 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002518 cl._cached_remote_url = (
2519 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002520 self.assertEqual(cl.GetDescription(), 'desc1')
2521 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2522 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002523
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002524 def test_print_current_creds(self):
2525 class CookiesAuthenticatorMock(object):
2526 def __init__(self):
2527 self.gitcookies = {
2528 'host.googlesource.com': ('user', 'pass'),
2529 'host-review.googlesource.com': ('user', 'pass'),
2530 }
2531 self.netrc = self
2532 self.netrc.hosts = {
2533 'github.com': ('user2', None, 'pass2'),
2534 'host2.googlesource.com': ('user3', None, 'pass'),
2535 }
2536 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2537 CookiesAuthenticatorMock)
2538 self.mock(sys, 'stdout', StringIO.StringIO())
2539 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2540 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2541 ' Host\t User\t Which file',
2542 '============================\t=====\t===========',
2543 'host-review.googlesource.com\t user\t.gitcookies',
2544 ' host.googlesource.com\t user\t.gitcookies',
2545 ' host2.googlesource.com\tuser3\t .netrc',
2546 ])
2547 sys.stdout.buf = ''
2548 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2549 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2550 ' Host\tUser\t Which file',
2551 '============================\t====\t===========',
2552 'host-review.googlesource.com\tuser\t.gitcookies',
2553 ' host.googlesource.com\tuser\t.gitcookies',
2554 ])
2555
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002556 def _common_creds_check_mocks(self):
2557 def exists_mock(path):
2558 dirname = os.path.dirname(path)
2559 if dirname == os.path.expanduser('~'):
2560 dirname = '~'
2561 base = os.path.basename(path)
2562 if base in ('.netrc', '.gitcookies'):
2563 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2564 # git cl also checks for existence other files not relevant to this test.
2565 return None
2566 self.mock(os.path, 'exists', exists_mock)
2567 self.mock(sys, 'stdout', StringIO.StringIO())
2568
2569 def test_creds_check_gitcookies_not_configured(self):
2570 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002571 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002572 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002573 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002574 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002575 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2576 (('os.path.exists', '~/.netrc'), True),
2577 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2578 'or Ctrl+C to abort'), ''),
2579 ((['git', 'config', '--global', 'http.cookiefile',
2580 os.path.expanduser('~/.gitcookies')], ), ''),
2581 ]
2582 self.assertEqual(0, git_cl.main(['creds-check']))
2583 self.assertRegexpMatches(
2584 sys.stdout.getvalue(),
2585 '^You seem to be using outdated .netrc for git credentials:')
2586 self.assertRegexpMatches(
2587 sys.stdout.getvalue(),
2588 '\nConfigured git to use .gitcookies from')
2589
2590 def test_creds_check_gitcookies_configured_custom_broken(self):
2591 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002592 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002593 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002594 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002595 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002596 ((['git', 'config', '--global', 'http.cookiefile'],),
2597 '/custom/.gitcookies'),
2598 (('os.path.exists', '/custom/.gitcookies'), False),
2599 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2600 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2601 ((['git', 'config', '--global', 'http.cookiefile',
2602 os.path.expanduser('~/.gitcookies')], ), ''),
2603 ]
2604 self.assertEqual(0, git_cl.main(['creds-check']))
2605 self.assertRegexpMatches(
2606 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002607 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002608 self.assertRegexpMatches(
2609 sys.stdout.getvalue(),
2610 'However, your configured .gitcookies file is missing.')
2611
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002612 def test_git_cl_comment_add_gerrit(self):
2613 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002614 lambda host, change, msg, ready:
2615 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002616 self.calls = [
2617 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2618 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2619 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2620 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2621 'origin/master'),
2622 ((['git', 'config', 'remote.origin.url'],),
2623 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002624 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2625 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002626 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002627 ]
2628 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2629 '-a', 'msg']))
2630
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002631 def test_git_cl_comments_fetch_gerrit(self):
2632 self.mock(sys, 'stdout', StringIO.StringIO())
2633 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002634 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2635 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002636 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2637 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2638 'origin/master'),
2639 ((['git', 'config', 'remote.origin.url'],),
2640 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002641 (('GetChangeDetail', 'chromium-review.googlesource.com',
2642 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002643 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2644 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002645 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002646 'current_revision': 'ba5eba11',
2647 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002648 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002649 '_number': 1,
2650 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002651 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002652 '_number': 2,
2653 },
2654 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002655 'messages': [
2656 {
2657 u'_revision_number': 1,
2658 u'author': {
2659 u'_account_id': 1111084,
2660 u'email': u'commit-bot@chromium.org',
2661 u'name': u'Commit Bot'
2662 },
2663 u'date': u'2017-03-15 20:08:45.000000000',
2664 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002665 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002666 u'tag': u'autogenerated:cq:dry-run'
2667 },
2668 {
2669 u'_revision_number': 2,
2670 u'author': {
2671 u'_account_id': 11151243,
2672 u'email': u'owner@example.com',
2673 u'name': u'owner'
2674 },
2675 u'date': u'2017-03-16 20:00:41.000000000',
2676 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2677 u'message': u'PTAL',
2678 },
2679 {
2680 u'_revision_number': 2,
2681 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002682 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002683 u'email': u'reviewer@example.com',
2684 u'name': u'reviewer'
2685 },
2686 u'date': u'2017-03-17 05:19:37.500000000',
2687 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2688 u'message': u'Patch Set 2: Code-Review+1',
2689 },
2690 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002691 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002692 (('GetChangeComments', 'chromium-review.googlesource.com',
2693 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002694 '/COMMIT_MSG': [
2695 {
2696 'author': {'email': u'reviewer@example.com'},
2697 'updated': u'2017-03-17 05:19:37.500000000',
2698 'patch_set': 2,
2699 'side': 'REVISION',
2700 'message': 'Please include a bug link',
2701 },
2702 ],
2703 'codereview.settings': [
2704 {
2705 'author': {'email': u'owner@example.com'},
2706 'updated': u'2017-03-16 20:00:41.000000000',
2707 'patch_set': 2,
2708 'side': 'PARENT',
2709 'line': 42,
2710 'message': 'I removed this because it is bad',
2711 },
2712 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002713 }),
2714 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2715 'infra%2Finfra~1'), {}),
2716 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002717 ] * 2 + [
2718 (('write_json', 'output.json', [
2719 {
2720 u'date': u'2017-03-16 20:00:41.000000',
2721 u'message': (
2722 u'PTAL\n' +
2723 u'\n' +
2724 u'codereview.settings\n' +
2725 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2726 u'c/1/2/codereview.settings#b42\n' +
2727 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002728 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002729 u'approval': False,
2730 u'disapproval': False,
2731 u'sender': u'owner@example.com'
2732 }, {
2733 u'date': u'2017-03-17 05:19:37.500000',
2734 u'message': (
2735 u'Patch Set 2: Code-Review+1\n' +
2736 u'\n' +
2737 u'/COMMIT_MSG\n' +
2738 u' PS2, File comment: https://chromium-review.googlesource' +
2739 u'.com/c/1/2//COMMIT_MSG#\n' +
2740 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002741 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002742 u'approval': False,
2743 u'disapproval': False,
2744 u'sender': u'reviewer@example.com'
2745 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002746 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002747 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002748 expected_comments_summary = [
2749 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002750 message=(
2751 u'PTAL\n' +
2752 u'\n' +
2753 u'codereview.settings\n' +
2754 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2755 u'c/1/2/codereview.settings#b42\n' +
2756 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002757 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002758 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002759 disapproval=False, approval=False, sender=u'owner@example.com'),
2760 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002761 message=(
2762 u'Patch Set 2: Code-Review+1\n' +
2763 u'\n' +
2764 u'/COMMIT_MSG\n' +
2765 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2766 u'c/1/2//COMMIT_MSG#\n' +
2767 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002768 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002769 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002770 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2771 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002772 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002773 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002774 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002775 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
2776 self.assertEqual(
2777 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2778
2779 def test_git_cl_comments_robot_comments(self):
2780 # git cl comments also fetches robot comments (which are considered a type
2781 # of autogenerated comment), and unlike other types of comments, only robot
2782 # comments from the latest patchset are shown.
2783 self.mock(sys, 'stdout', StringIO.StringIO())
2784 self.calls = [
2785 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2786 ((['git', 'config', 'branch.foo.merge'],), ''),
2787 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2788 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2789 'origin/master'),
2790 ((['git', 'config', 'remote.origin.url'],),
2791 'https://chromium.googlesource.com/infra/infra'),
2792 (('GetChangeDetail', 'chromium-review.googlesource.com',
2793 'infra%2Finfra~1',
2794 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2795 'CURRENT_COMMIT']), {
2796 'owner': {'email': 'owner@example.com'},
2797 'current_revision': 'ba5eba11',
2798 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002799 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002800 '_number': 1,
2801 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002802 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002803 '_number': 2,
2804 },
2805 },
2806 'messages': [
2807 {
2808 u'_revision_number': 1,
2809 u'author': {
2810 u'_account_id': 1111084,
2811 u'email': u'commit-bot@chromium.org',
2812 u'name': u'Commit Bot'
2813 },
2814 u'date': u'2017-03-15 20:08:45.000000000',
2815 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2816 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2817 u'tag': u'autogenerated:cq:dry-run'
2818 },
2819 {
2820 u'_revision_number': 1,
2821 u'author': {
2822 u'_account_id': 123,
2823 u'email': u'tricium@serviceaccount.com',
2824 u'name': u'Tricium'
2825 },
2826 u'date': u'2017-03-16 20:00:41.000000000',
2827 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2828 u'message': u'(1 comment)',
2829 u'tag': u'autogenerated:tricium',
2830 },
2831 {
2832 u'_revision_number': 1,
2833 u'author': {
2834 u'_account_id': 123,
2835 u'email': u'tricium@serviceaccount.com',
2836 u'name': u'Tricium'
2837 },
2838 u'date': u'2017-03-16 20:00:41.000000000',
2839 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2840 u'message': u'(1 comment)',
2841 u'tag': u'autogenerated:tricium',
2842 },
2843 {
2844 u'_revision_number': 2,
2845 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002846 u'_account_id': 123,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002847 u'email': u'tricium@serviceaccount.com',
2848 u'name': u'reviewer'
2849 },
2850 u'date': u'2017-03-17 05:30:37.000000000',
2851 u'tag': u'autogenerated:tricium',
2852 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2853 u'message': u'(1 comment)',
2854 },
2855 ]
2856 }),
2857 (('GetChangeComments', 'chromium-review.googlesource.com',
2858 'infra%2Finfra~1'), {}),
2859 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2860 'infra%2Finfra~1'), {
2861 'codereview.settings': [
2862 {
2863 u'author': {u'email': u'tricium@serviceaccount.com'},
2864 u'updated': u'2017-03-17 05:30:37.000000000',
2865 u'robot_run_id': u'5565031076855808',
2866 u'robot_id': u'Linter/Category',
2867 u'tag': u'autogenerated:tricium',
2868 u'patch_set': 2,
2869 u'side': u'REVISION',
2870 u'message': u'Linter warning message text',
2871 u'line': 32,
2872 },
2873 ],
2874 }),
2875 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
2876 ]
2877 expected_comments_summary = [
2878 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2879 message=(
2880 u'(1 comment)\n\ncodereview.settings\n'
2881 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2882 u'c/1/2/codereview.settings#32\n'
2883 u' Linter warning message text\n'),
2884 sender=u'tricium@serviceaccount.com',
2885 autogenerated=True, approval=False, disapproval=False)
2886 ]
2887 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002888 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002889 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002890
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002891 def test_get_remote_url_with_mirror(self):
2892 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002893
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002894 def selective_os_path_isdir_mock(path):
2895 if path == '/cache/this-dir-exists':
2896 return self._mocked_call('os.path.isdir', path)
2897 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002898
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002899 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2900
2901 url = 'https://chromium.googlesource.com/my/repo'
2902 self.calls = [
2903 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2904 ((['git', 'config', 'branch.master.merge'],), 'master'),
2905 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2906 ((['git', 'config', 'remote.origin.url'],),
2907 '/cache/this-dir-exists'),
2908 (('os.path.isdir', '/cache/this-dir-exists'),
2909 True),
2910 # Runs in /cache/this-dir-exists.
2911 ((['git', 'config', 'remote.origin.url'],),
2912 url),
2913 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002914 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002915 self.assertEqual(cl.GetRemoteUrl(), url)
2916 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2917
Edward Lemur298f2cf2019-02-22 21:40:39 +00002918 def test_get_remote_url_non_existing_mirror(self):
2919 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002920
Edward Lemur298f2cf2019-02-22 21:40:39 +00002921 def selective_os_path_isdir_mock(path):
2922 if path == '/cache/this-dir-doesnt-exist':
2923 return self._mocked_call('os.path.isdir', path)
2924 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002925
Edward Lemur298f2cf2019-02-22 21:40:39 +00002926 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2927 self.mock(logging, 'error',
2928 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
2929
2930 self.calls = [
2931 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2932 ((['git', 'config', 'branch.master.merge'],), 'master'),
2933 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2934 ((['git', 'config', 'remote.origin.url'],),
2935 '/cache/this-dir-doesnt-exist'),
2936 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2937 False),
2938 (('logging.error',
Daniel Bratell4a60db42019-09-16 17:02:52 +00002939 'Remote "origin" for branch "master" points to'
2940 ' "/cache/this-dir-doesnt-exist", but it doesn\'t exist.'), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002941 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002942 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002943 self.assertIsNone(cl.GetRemoteUrl())
2944
2945 def test_get_remote_url_misconfigured_mirror(self):
2946 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002947
Edward Lemur298f2cf2019-02-22 21:40:39 +00002948 def selective_os_path_isdir_mock(path):
2949 if path == '/cache/this-dir-exists':
2950 return self._mocked_call('os.path.isdir', path)
2951 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002952
Edward Lemur298f2cf2019-02-22 21:40:39 +00002953 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2954 self.mock(logging, 'error',
2955 lambda *a: self._mocked_call('logging.error', *a))
2956
2957 self.calls = [
2958 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2959 ((['git', 'config', 'branch.master.merge'],), 'master'),
2960 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2961 ((['git', 'config', 'remote.origin.url'],),
2962 '/cache/this-dir-exists'),
2963 (('os.path.isdir', '/cache/this-dir-exists'), True),
2964 # Runs in /cache/this-dir-exists.
2965 ((['git', 'config', 'remote.origin.url'],), ''),
2966 (('logging.error',
2967 'Remote "%(remote)s" for branch "%(branch)s" points to '
2968 '"%(cache_path)s", but it is misconfigured.\n'
2969 '"%(cache_path)s" must be a git repo and must have a remote named '
2970 '"%(remote)s" pointing to the git host.', {
2971 'remote': 'origin',
2972 'cache_path': '/cache/this-dir-exists',
2973 'branch': 'master'}
2974 ), None),
2975 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002976 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002977 self.assertIsNone(cl.GetRemoteUrl())
2978
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002979 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002980 self.calls = [
2981 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2982 ((['git', 'config', 'branch.master.merge'],), 'master'),
2983 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2984 ((['git', 'config', 'remote.origin.url'],),
2985 'https://chromium.googlesource.com/a/my/repo.git/'),
2986 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002987 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002988 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2989
2990 def test_gerrit_change_identifier_without_project(self):
2991 self.calls = [
2992 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2993 ((['git', 'config', 'branch.master.merge'],), 'master'),
2994 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2995 ((['git', 'config', 'remote.origin.url'],), CERR1),
2996 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002997 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002998 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002999
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003000
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003001class CMDTestCaseBase(unittest.TestCase):
3002 _STATUSES = [
3003 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3004 'INFRA_FAILURE', 'CANCELED',
3005 ]
3006 _CHANGE_DETAIL = {
3007 'project': 'depot_tools',
3008 'status': 'OPEN',
3009 'owner': {'email': 'owner@e.mail'},
3010 'current_revision': 'beeeeeef',
3011 'revisions': {
3012 'deadbeaf': {'_number': 6},
3013 'beeeeeef': {
3014 '_number': 7,
3015 'fetch': {'http': {
3016 'url': 'https://chromium.googlesource.com/depot_tools',
3017 'ref': 'refs/changes/56/123456/7'
3018 }},
3019 },
3020 },
3021 }
3022 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003023 'builds': [{
3024 'id': str(100 + idx),
3025 'builder': {
3026 'project': 'chromium',
3027 'bucket': 'try',
3028 'builder': 'bot_' + status.lower(),
3029 },
3030 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3031 'tags': [],
3032 'status': status,
3033 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003034 }
3035
Edward Lemur4c707a22019-09-24 21:13:43 +00003036 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003037 super(CMDTestCaseBase, self).setUp()
Edward Lemur4c707a22019-09-24 21:13:43 +00003038 mock.patch('git_cl.sys.stdout', StringIO.StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003039 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3040 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003041 mock.patch('git_cl.Changelist.GetCodereviewServer',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003042 return_value='https://chromium-review.googlesource.com').start()
3043 mock.patch('git_cl.Changelist.GetMostRecentPatchset',
3044 return_value=7).start()
Edward Lemur5b929a42019-10-21 17:57:39 +00003045 mock.patch('git_cl.auth.Authenticator',
Edward Lemurb4a587d2019-10-09 23:56:38 +00003046 return_value=AuthenticatorMock()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003047 mock.patch('git_cl.Changelist._GetChangeDetail',
3048 return_value=self._CHANGE_DETAIL).start()
3049 mock.patch('git_cl._call_buildbucket',
3050 return_value = self._DEFAULT_RESPONSE).start()
3051 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003052 self.addCleanup(mock.patch.stopall)
3053
Edward Lemur4c707a22019-09-24 21:13:43 +00003054
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003055class CMDTryResultsTestCase(CMDTestCaseBase):
3056 _DEFAULT_REQUEST = {
3057 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003058 "gerritChanges": [{
3059 "project": "depot_tools",
3060 "host": "chromium-review.googlesource.com",
3061 "patchset": 7,
3062 "change": 123456,
3063 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003064 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003065 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3066 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003067 }
3068
3069 def testNoJobs(self):
3070 git_cl._call_buildbucket.return_value = {}
3071
3072 self.assertEqual(0, git_cl.main(['try-results']))
3073 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3074 git_cl._call_buildbucket.assert_called_once_with(
3075 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3076 self._DEFAULT_REQUEST)
3077
3078 def testPrintToStdout(self):
3079 self.assertEqual(0, git_cl.main(['try-results']))
3080 self.assertEqual([
3081 'Successes:',
3082 ' bot_success https://ci.chromium.org/b/103',
3083 'Infra Failures:',
3084 ' bot_infra_failure https://ci.chromium.org/b/105',
3085 'Failures:',
3086 ' bot_failure https://ci.chromium.org/b/104',
3087 'Canceled:',
3088 ' bot_canceled ',
3089 'Started:',
3090 ' bot_started https://ci.chromium.org/b/102',
3091 'Scheduled:',
3092 ' bot_scheduled id=101',
3093 'Other:',
3094 ' bot_status_unspecified id=100',
3095 'Total: 7 tryjobs',
3096 ], sys.stdout.getvalue().splitlines())
3097 git_cl._call_buildbucket.assert_called_once_with(
3098 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3099 self._DEFAULT_REQUEST)
3100
3101 def testPrintToStdoutWithMasters(self):
3102 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3103 self.assertEqual([
3104 'Successes:',
3105 ' try bot_success https://ci.chromium.org/b/103',
3106 'Infra Failures:',
3107 ' try bot_infra_failure https://ci.chromium.org/b/105',
3108 'Failures:',
3109 ' try bot_failure https://ci.chromium.org/b/104',
3110 'Canceled:',
3111 ' try bot_canceled ',
3112 'Started:',
3113 ' try bot_started https://ci.chromium.org/b/102',
3114 'Scheduled:',
3115 ' try bot_scheduled id=101',
3116 'Other:',
3117 ' try bot_status_unspecified id=100',
3118 'Total: 7 tryjobs',
3119 ], sys.stdout.getvalue().splitlines())
3120 git_cl._call_buildbucket.assert_called_once_with(
3121 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3122 self._DEFAULT_REQUEST)
3123
3124 @mock.patch('git_cl.write_json')
3125 def testWriteToJson(self, mockJsonDump):
3126 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3127 git_cl._call_buildbucket.assert_called_once_with(
3128 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3129 self._DEFAULT_REQUEST)
3130 mockJsonDump.assert_called_once_with(
3131 'file.json', self._DEFAULT_RESPONSE['builds'])
3132
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003133 def test_filter_failed_for_one_simple(self):
3134 self.assertEqual({}, git_cl._filter_failed_for_retry([]))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003135 self.assertEqual({
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003136 'chromium/try': {
3137 'bot_failure': [],
3138 'bot_infra_failure': []
3139 },
3140 }, git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
3141
3142 def test_filter_failed_for_retry_many_builds(self):
3143
3144 def _build(name, created_sec, status, experimental=False):
3145 assert 0 <= created_sec < 100, created_sec
3146 b = {
3147 'id': 112112,
3148 'builder': {
3149 'project': 'chromium',
3150 'bucket': 'try',
3151 'builder': name,
3152 },
3153 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3154 'status': status,
3155 'tags': [],
3156 }
3157 if experimental:
3158 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3159 return b
3160
3161 builds = [
3162 _build('flaky-last-green', 1, 'FAILURE'),
3163 _build('flaky-last-green', 2, 'SUCCESS'),
3164 _build('flaky', 1, 'SUCCESS'),
3165 _build('flaky', 2, 'FAILURE'),
3166 _build('running', 1, 'FAILED'),
3167 _build('running', 2, 'SCHEDULED'),
3168 _build('yep-still-running', 1, 'STARTED'),
3169 _build('yep-still-running', 2, 'FAILURE'),
3170 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3171 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3172
3173 # Simulate experimental in CQ builder, which developer decided
3174 # to retry manually which resulted in 2nd build non-experimental.
3175 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3176 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3177 ]
3178 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
3179 self.assertEqual({
3180 'chromium/try': {
3181 'flaky': [],
3182 'sometimes-experimental': []
3183 },
3184 }, git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003185
3186
3187class CMDTryTestCase(CMDTestCaseBase):
3188
3189 @mock.patch('git_cl.Changelist.SetCQState')
3190 @mock.patch('git_cl._get_bucket_map', return_value={})
3191 def testSetCQDryRunByDefault(self, _mockGetBucketMap, mockSetCQState):
3192 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003193 self.assertEqual(0, git_cl.main(['try']))
3194 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3195 self.assertEqual(
3196 sys.stdout.getvalue(),
3197 'Scheduling CQ dry run on: '
3198 'https://chromium-review.googlesource.com/123456\n')
3199
Edward Lemur4c707a22019-09-24 21:13:43 +00003200 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003201 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003202 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003203
3204 self.assertEqual(0, git_cl.main([
3205 'try', '-B', 'luci.chromium.try', '-b', 'win',
3206 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3207 self.assertIn(
3208 'Scheduling jobs on:\nBucket: luci.chromium.try',
3209 git_cl.sys.stdout.getvalue())
3210
3211 expected_request = {
3212 "requests": [{
3213 "scheduleBuild": {
3214 "requestId": "uuid4",
3215 "builder": {
3216 "project": "chromium",
3217 "builder": "win",
3218 "bucket": "try",
3219 },
3220 "gerritChanges": [{
3221 "project": "depot_tools",
3222 "host": "chromium-review.googlesource.com",
3223 "patchset": 7,
3224 "change": 123456,
3225 }],
3226 "properties": {
3227 "category": "git_cl_try",
3228 "json": [{"a": 1}, None],
3229 "key": "val",
3230 },
3231 "tags": [
3232 {"value": "win", "key": "builder"},
3233 {"value": "git_cl_try", "key": "user_agent"},
3234 ],
3235 },
3236 }],
3237 }
3238 mockCallBuildbucket.assert_called_with(
3239 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3240
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003241 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur4c707a22019-09-24 21:13:43 +00003242 self.assertEqual(0, git_cl.main([
3243 'try', '-B', 'not-a-bucket', '-b', 'win',
3244 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3245 self.assertIn(
3246 'WARNING Could not parse bucket "not-a-bucket". Skipping.',
3247 git_cl.sys.stdout.getvalue())
3248
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003249 @mock.patch('git_cl._call_buildbucket')
3250 @mock.patch('git_cl.fetch_try_jobs')
3251 def testScheduleOnBuildbucketRetryFailed(
3252 self, mockFetchTryJobs, mockCallBuildbucket):
3253
3254 git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: {
3255 7: [],
3256 6: [{
3257 'id': 112112,
3258 'builder': {
3259 'project': 'chromium',
3260 'bucket': 'try',
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003261 'builder': 'linux',},
3262 'createTime': '2019-10-09T08:00:01.854286Z',
3263 'tags': [],
3264 'status': 'FAILURE',}],}[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003265 mockCallBuildbucket.return_value = {}
3266
3267 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3268 self.assertIn(
3269 'Scheduling jobs on:\nBucket: chromium/try',
3270 git_cl.sys.stdout.getvalue())
3271
3272 expected_request = {
3273 "requests": [{
3274 "scheduleBuild": {
3275 "requestId": "uuid4",
3276 "builder": {
3277 "project": "chromium",
3278 "bucket": "try",
3279 "builder": "linux",
3280 },
3281 "gerritChanges": [{
3282 "project": "depot_tools",
3283 "host": "chromium-review.googlesource.com",
3284 "patchset": 7,
3285 "change": 123456,
3286 }],
3287 "properties": {
3288 "category": "git_cl_try",
3289 },
3290 "tags": [
3291 {"value": "linux", "key": "builder"},
3292 {"value": "git_cl_try", "key": "user_agent"},
3293 {"value": "1", "key": "retry_failed"},
3294 ],
3295 },
3296 }],
3297 }
3298 mockCallBuildbucket.assert_called_with(
3299 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3300
Edward Lemur4c707a22019-09-24 21:13:43 +00003301 def test_parse_bucket(self):
3302 test_cases = [
3303 {
3304 'bucket': 'chromium/try',
3305 'result': ('chromium', 'try'),
3306 },
3307 {
3308 'bucket': 'luci.chromium.try',
3309 'result': ('chromium', 'try'),
3310 'has_warning': True,
3311 },
3312 {
3313 'bucket': 'skia.primary',
3314 'result': ('skia', 'skia.primary'),
3315 'has_warning': True,
3316 },
3317 {
3318 'bucket': 'not-a-bucket',
3319 'result': (None, None),
3320 },
3321 ]
3322
3323 for test_case in test_cases:
3324 git_cl.sys.stdout.truncate(0)
3325 self.assertEqual(
3326 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3327 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003328 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3329 test_case['result'])
3330 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003331
3332
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003333class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003334 def setUp(self):
3335 super(CMDUploadTestCase, self).setUp()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003336 mock.patch('git_cl.fetch_try_jobs').start()
3337 mock.patch('git_cl._trigger_try_jobs', return_value={}).start()
3338 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003339 self.addCleanup(mock.patch.stopall)
3340
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003341 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003342 # This test mocks out the actual upload part, and just asserts that after
3343 # upload, if --retry-failed is added, then the tool will fetch try jobs
3344 # from the previous patchset and trigger the right builders on the latest
3345 # patchset.
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003346 git_cl.fetch_try_jobs.side_effect = [
3347 # Latest patchset: No builds.
3348 [],
3349 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003350 [{
3351 'id': str(100 + idx),
3352 'builder': {
3353 'project': 'chromium',
3354 'bucket': 'try',
3355 'builder': 'bot_' + status.lower(),
3356 },
3357 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3358 'tags': [],
3359 'status': status,
3360 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003361 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003362
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003363 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003364 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003365 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3366 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003367 ], git_cl.fetch_try_jobs.mock_calls)
3368 expected_buckets = {
3369 'chromium/try': {'bot_failure': [], 'bot_infra_failure': []},
3370 }
3371 git_cl._trigger_try_jobs.assert_called_once_with(
Edward Lemur5b929a42019-10-21 17:57:39 +00003372 mock.ANY, expected_buckets, mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003373
Brian Sheedy59b06a82019-10-14 17:03:29 +00003374
3375class CMDFormatTestCase(TestCase):
3376
3377 def setUp(self):
3378 super(CMDFormatTestCase, self).setUp()
3379 self._top_dir = tempfile.mkdtemp()
3380
3381 def tearDown(self):
3382 shutil.rmtree(self._top_dir)
3383 super(CMDFormatTestCase, self).tearDown()
3384
3385 def _make_yapfignore(self, contents):
3386 with open(os.path.join(self._top_dir, '.yapfignore'), 'w') as yapfignore:
3387 yapfignore.write('\n'.join(contents))
3388
3389 def _make_files(self, file_dict):
3390 for directory, files in file_dict.iteritems():
3391 subdir = os.path.join(self._top_dir, directory)
3392 if not os.path.exists(subdir):
3393 os.makedirs(subdir)
3394 for f in files:
3395 with open(os.path.join(subdir, f), 'w'):
3396 pass
3397
3398 def testYapfignoreBasic(self):
3399 self._make_yapfignore(['test.py', '*/bar.py'])
3400 self._make_files({
3401 '.': ['test.py', 'bar.py'],
3402 'foo': ['bar.py'],
3403 })
3404 self.assertEqual(
3405 set(['test.py', 'foo/bar.py']),
3406 git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3407
3408 def testYapfignoreMissingYapfignore(self):
3409 self.assertEqual(set(), git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3410
3411 def testYapfignoreMissingFile(self):
3412 self._make_yapfignore(['test.py', 'test2.py', 'test3.py'])
3413 self._make_files({
3414 '.': ['test.py', 'test3.py'],
3415 })
3416 self.assertEqual(
3417 set(['test.py', 'test3.py']),
3418 git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3419
3420 def testYapfignoreComments(self):
3421 self._make_yapfignore(['test.py', '#test2.py'])
3422 self._make_files({
3423 '.': ['test.py', 'test2.py'],
3424 })
3425 self.assertEqual(
3426 set(['test.py']), git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3427
3428 def testYapfignoreBlankLines(self):
3429 self._make_yapfignore(['test.py', '', '', 'test2.py'])
3430 self._make_files({'.': ['test.py', 'test2.py']})
3431 self.assertEqual(
3432 set(['test.py', 'test2.py']),
3433 git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3434
3435 def testYapfignoreWhitespace(self):
3436 self._make_yapfignore([' test.py '])
3437 self._make_files({'.': ['test.py']})
3438 self.assertEqual(
3439 set(['test.py']), git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3440
3441 def testYapfignoreMultiWildcard(self):
3442 self._make_yapfignore(['*es*.py'])
3443 self._make_files({
3444 '.': ['test.py', 'test2.py'],
3445 })
3446 self.assertEqual(
3447 set(['test.py', 'test2.py']),
3448 git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3449
3450 def testYapfignoreRestoresDirectory(self):
3451 self._make_yapfignore(['test.py'])
3452 self._make_files({
3453 '.': ['test.py'],
3454 })
3455 old_cwd = os.getcwd()
3456 self.assertEqual(
3457 set(['test.py']), git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3458 self.assertEqual(old_cwd, os.getcwd())
3459
3460
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003461if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003462 logging.basicConfig(
3463 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003464 unittest.main()