blob: 64a729e879e53cd7976a15ac4a9f23ad5166d0c5 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur0db01f02019-11-12 22:01:51 +00009from __future__ import unicode_literals
10
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010011import datetime
tandriide281ae2016-10-12 06:02:30 -070012import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010013import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import os
Brian Sheedy59b06a82019-10-14 17:03:29 +000015import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070017import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018import unittest
19
Edward Lemura8145022020-01-06 18:47:54 +000020if sys.version_info.major == 2:
21 from StringIO import StringIO
22 import mock
23else:
24 from io import StringIO
25 from unittest import mock
26
maruel@chromium.orgddd59412011-11-30 14:20:38 +000027sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
28
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000029import metrics
30# We have to disable monitoring before importing git_cl.
31metrics.DISABLE_METRICS_COLLECTION = True
32
Jamie Madill5e96ad12020-01-13 16:08:35 +000033import clang_format
Eric Boren2fb63102018-10-05 13:05:03 +000034import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000035import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000036import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000037import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000038import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000039
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000040
Edward Lemur0db01f02019-11-12 22:01:51 +000041def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070042 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
43
44
Edward Lemur4c707a22019-09-24 21:13:43 +000045def _constantFn(return_value):
46 def f(*args, **kwargs):
47 return return_value
48 return f
49
50
tandrii5d48c322016-08-18 16:19:37 -070051CERR1 = callError(1)
52
53
Edward Lemur0db01f02019-11-12 22:01:51 +000054def MakeNamedTemporaryFileMock(test, expected_content):
Aaron Gable9a03ae02017-11-03 11:31:07 -070055 class NamedTemporaryFileMock(object):
56 def __init__(self, *args, **kwargs):
57 self.name = '/tmp/named'
Edward Lemur0db01f02019-11-12 22:01:51 +000058 self.expected_content = expected_content.encode('utf-8', 'replace')
Aaron Gable9a03ae02017-11-03 11:31:07 -070059
60 def __enter__(self):
61 return self
62
63 def __exit__(self, _type, _value, _tb):
64 pass
65
66 def write(self, content):
67 if self.expected_content:
Edward Lemur0db01f02019-11-12 22:01:51 +000068 test.assertEqual(self.expected_content, content)
Aaron Gable9a03ae02017-11-03 11:31:07 -070069
70 def close(self):
71 pass
72
73 return NamedTemporaryFileMock
74
75
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000076class ChangelistMock(object):
77 # A class variable so we can access it when we don't have access to the
78 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000079 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000080 def __init__(self, **kwargs):
81 pass
82 def GetIssue(self):
83 return 1
Edward Lemur6c6827c2020-02-06 21:15:18 +000084 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000085 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070086 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000087 ChangelistMock.desc = desc
88
tandrii5d48c322016-08-18 16:19:37 -070089
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000090class PresubmitMock(object):
91 def __init__(self, *args, **kwargs):
92 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080093 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
94
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000095 @staticmethod
96 def should_continue():
97 return True
98
99
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000100class WatchlistsMock(object):
101 def __init__(self, _):
102 pass
103 @staticmethod
104 def GetWatchersForPaths(_):
105 return ['joe@example.com']
106
107
Edward Lemur4c707a22019-09-24 21:13:43 +0000108class CodereviewSettingsFileMock(object):
109 def __init__(self):
110 pass
111 # pylint: disable=no-self-use
112 def read(self):
113 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
114 'GERRIT_HOST: True\n')
115
116
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000117class AuthenticatorMock(object):
118 def __init__(self, *_args):
119 pass
120 def has_cached_credentials(self):
121 return True
tandrii221ab252016-10-06 08:12:04 -0700122 def authorize(self, http):
123 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000124
125
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100126def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000127 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
128
129 Usage:
130 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100131 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000132
133 OR
134 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100135 CookiesAuthenticatorMockFactory(
136 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000137 """
138 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800139 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000140 # Intentionally not calling super() because it reads actual cookie files.
141 pass
142 @classmethod
143 def get_gitcookies_path(cls):
144 return '~/.gitcookies'
145 @classmethod
146 def get_netrc_path(cls):
147 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100148 def _get_auth_for_host(self, host):
149 if same_auth:
150 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000151 return (hosts_with_creds or {}).get(host)
152 return CookiesAuthenticatorMock
153
Aaron Gable9a03ae02017-11-03 11:31:07 -0700154
kmarshall9249e012016-08-23 12:02:16 -0700155class MockChangelistWithBranchAndIssue():
156 def __init__(self, branch, issue):
157 self.branch = branch
158 self.issue = issue
159 def GetBranch(self):
160 return self.branch
161 def GetIssue(self):
162 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000163
tandriic2405f52016-10-10 08:13:15 -0700164
165class SystemExitMock(Exception):
166 pass
167
168
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000169class TestGitClBasic(unittest.TestCase):
Edward Lemur6c6827c2020-02-06 21:15:18 +0000170 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000171 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100172 cl.description = 'x'
173 cl.has_description = True
Edward Lemur6c6827c2020-02-06 21:15:18 +0000174 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700175
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000176 def test_set_preserve_tryjobs(self):
177 d = git_cl.ChangeDescription('Simple.')
178 d.set_preserve_tryjobs()
179 self.assertEqual(d.description.splitlines(), [
180 'Simple.',
181 '',
182 'Cq-Do-Not-Cancel-Tryjobs: true',
183 ])
184 before = d.description
185 d.set_preserve_tryjobs()
186 self.assertEqual(before, d.description)
187
188 d = git_cl.ChangeDescription('\n'.join([
189 'One is enough',
190 '',
191 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
192 'Change-Id: Ideadbeef',
193 ]))
194 d.set_preserve_tryjobs()
195 self.assertEqual(d.description.splitlines(), [
196 'One is enough',
197 '',
198 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
199 'Change-Id: Ideadbeef',
200 'Cq-Do-Not-Cancel-Tryjobs: true',
201 ])
202
tandriif9aefb72016-07-01 09:06:51 -0700203 def test_get_bug_line_values(self):
204 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
205 self.assertEqual(f('', ''), [])
206 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
207 self.assertEqual(f('v8', '456'), ['v8:456'])
208 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
209 # Not nice, but not worth carying.
210 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
211 ['v8:456', 'chromium:123', 'v8:123'])
212
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100213 def _test_git_number(self, parent_msg, dest_ref, child_msg,
214 parent_hash='parenthash'):
215 desc = git_cl.ChangeDescription(child_msg)
216 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
217 return desc.description
218
219 def assertEqualByLine(self, actual, expected):
220 self.assertEqual(actual.splitlines(), expected.splitlines())
221
222 def test_git_number_bad_parent(self):
223 with self.assertRaises(ValueError):
224 self._test_git_number('Parent', 'refs/heads/master', 'Child')
225
226 def test_git_number_bad_parent_footer(self):
227 with self.assertRaises(AssertionError):
228 self._test_git_number(
229 'Parent\n'
230 '\n'
231 'Cr-Commit-Position: wrong',
232 'refs/heads/master', 'Child')
233
234 def test_git_number_bad_lineage_ignored(self):
235 actual = self._test_git_number(
236 'Parent\n'
237 '\n'
238 'Cr-Commit-Position: refs/heads/master@{#1}\n'
239 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
240 'refs/heads/master', 'Child')
241 self.assertEqualByLine(
242 actual,
243 'Child\n'
244 '\n'
245 'Cr-Commit-Position: refs/heads/master@{#2}\n'
246 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
247
248 def test_git_number_same_branch(self):
249 actual = self._test_git_number(
250 'Parent\n'
251 '\n'
252 'Cr-Commit-Position: refs/heads/master@{#12}',
253 dest_ref='refs/heads/master',
254 child_msg='Child')
255 self.assertEqualByLine(
256 actual,
257 'Child\n'
258 '\n'
259 'Cr-Commit-Position: refs/heads/master@{#13}')
260
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200261 def test_git_number_same_branch_mixed_footers(self):
262 actual = self._test_git_number(
263 'Parent\n'
264 '\n'
265 'Cr-Commit-Position: refs/heads/master@{#12}',
266 dest_ref='refs/heads/master',
267 child_msg='Child\n'
268 '\n'
269 'Broken-by: design\n'
270 'BUG=123')
271 self.assertEqualByLine(
272 actual,
273 'Child\n'
274 '\n'
275 'Broken-by: design\n'
276 'BUG=123\n'
277 'Cr-Commit-Position: refs/heads/master@{#13}')
278
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100279 def test_git_number_same_branch_with_originals(self):
280 actual = self._test_git_number(
281 'Parent\n'
282 '\n'
283 'Cr-Commit-Position: refs/heads/master@{#12}',
284 dest_ref='refs/heads/master',
285 child_msg='Child\n'
286 '\n'
287 'Some users are smart and insert their own footers\n'
288 '\n'
289 'Cr-Whatever: value\n'
290 'Cr-Commit-Position: refs/copy/paste@{#22}')
291 self.assertEqualByLine(
292 actual,
293 'Child\n'
294 '\n'
295 'Some users are smart and insert their own footers\n'
296 '\n'
297 'Cr-Original-Whatever: value\n'
298 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
299 'Cr-Commit-Position: refs/heads/master@{#13}')
300
301 def test_git_number_new_branch(self):
302 actual = self._test_git_number(
303 'Parent\n'
304 '\n'
305 'Cr-Commit-Position: refs/heads/master@{#12}',
306 dest_ref='refs/heads/branch',
307 child_msg='Child')
308 self.assertEqualByLine(
309 actual,
310 'Child\n'
311 '\n'
312 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
313 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
314
315 def test_git_number_lineage(self):
316 actual = self._test_git_number(
317 'Parent\n'
318 '\n'
319 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
320 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
321 dest_ref='refs/heads/branch',
322 child_msg='Child')
323 self.assertEqualByLine(
324 actual,
325 'Child\n'
326 '\n'
327 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
328 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
329
330 def test_git_number_moooooooore_lineage(self):
331 actual = self._test_git_number(
332 'Parent\n'
333 '\n'
334 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
335 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
336 dest_ref='refs/heads/mooore',
337 child_msg='Child')
338 self.assertEqualByLine(
339 actual,
340 'Child\n'
341 '\n'
342 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
343 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
344 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
345
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100346 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700347 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100348 actual = self._test_git_number(
349 'CQ commit on fresh new branch + numbering.\n'
350 '\n'
351 'NOTRY=True\n'
352 'NOPRESUBMIT=True\n'
353 'BUG=\n'
354 '\n'
355 'Review-Url: https://codereview.chromium.org/2577703003\n'
356 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
357 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
358 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
359 dest_ref='refs/heads/gnumb-test/cl',
360 child_msg='git cl on fresh new branch + numbering.\n'
361 '\n'
362 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
363 self.assertEqualByLine(
364 actual,
365 'git cl on fresh new branch + numbering.\n'
366 '\n'
367 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
368 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
369 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
370 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
371 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100372
373 def test_git_number_cherry_pick(self):
374 actual = self._test_git_number(
375 'Parent\n'
376 '\n'
377 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
378 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
379 dest_ref='refs/heads/branch',
380 child_msg='Child, which is cherry-pick from master\n'
381 '\n'
382 'Cr-Commit-Position: refs/heads/master@{#100}\n'
383 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
384 self.assertEqualByLine(
385 actual,
386 'Child, which is cherry-pick from master\n'
387 '\n'
388 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
389 '\n'
390 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
391 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
392 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
393
Edward Lemurda4b6c62020-02-13 00:28:40 +0000394 @mock.patch('gerrit_util.GetAccountDetails')
395 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000396 mock_per_account = {
397 'u1': None, # 404, doesn't exist.
398 'u2': {
399 '_account_id': 123124,
400 'avatars': [],
401 'email': 'u2@example.com',
402 'name': 'User Number 2',
403 'status': 'OOO',
404 },
405 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
406 }
407 def GetAccountDetailsMock(_, account):
408 # Poor-man's mock library's side_effect.
409 v = mock_per_account.pop(account)
410 if isinstance(v, Exception):
411 raise v
412 return v
413
Edward Lemurda4b6c62020-02-13 00:28:40 +0000414 mockGetAccountDetails.side_effect = GetAccountDetailsMock
415 actual = git_cl.gerrit_util.ValidAccounts(
416 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000417 self.assertEqual(actual, {
418 'u2': {
419 '_account_id': 123124,
420 'avatars': [],
421 'email': 'u2@example.com',
422 'name': 'User Number 2',
423 'status': 'OOO',
424 },
425 })
426
427
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200428class TestParseIssueURL(unittest.TestCase):
429 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000430 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200431 self.assertIsNotNone(parsed)
432 if fail:
433 self.assertFalse(parsed.valid)
434 return
435 self.assertTrue(parsed.valid)
436 self.assertEqual(parsed.issue, issue)
437 self.assertEqual(parsed.patchset, patchset)
438 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200439
Edward Lemur678a6842019-10-03 22:25:05 +0000440 def test_ParseIssueNumberArgument(self):
441 def test(arg, *args, **kwargs):
442 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200443
Edward Lemur678a6842019-10-03 22:25:05 +0000444 test('123', 123)
445 test('', fail=True)
446 test('abc', fail=True)
447 test('123/1', fail=True)
448 test('123a', fail=True)
449 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200450
Edward Lemur678a6842019-10-03 22:25:05 +0000451 test('https://codereview.source.com/123',
452 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200453 test('http://chrome-review.source.com/c/123',
454 123, None, 'chrome-review.source.com')
455 test('https://chrome-review.source.com/c/123/',
456 123, None, 'chrome-review.source.com')
457 test('https://chrome-review.source.com/c/123/4',
458 123, 4, 'chrome-review.source.com')
459 test('https://chrome-review.source.com/#/c/123/4',
460 123, 4, 'chrome-review.source.com')
461 test('https://chrome-review.source.com/c/123/4',
462 123, 4, 'chrome-review.source.com')
463 test('https://chrome-review.source.com/123',
464 123, None, 'chrome-review.source.com')
465 test('https://chrome-review.source.com/123/4',
466 123, 4, 'chrome-review.source.com')
467
Edward Lemur678a6842019-10-03 22:25:05 +0000468 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200469 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
470 test('https://chrome-review.source.com/c/abc/', fail=True)
471 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
472
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200473
474
Edward Lemurda4b6c62020-02-13 00:28:40 +0000475class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100476 def setUp(self):
477 super(GitCookiesCheckerTest, self).setUp()
478 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100479 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000480 mock.patch('sys.stdout', StringIO()).start()
481 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100482
483 def mock_hosts_creds(self, subhost_identity_pairs):
484 def ensure_googlesource(h):
485 if not h.endswith(self.c._GOOGLESOURCE):
486 assert not h.endswith('.')
487 return h + '.' + self.c._GOOGLESOURCE
488 return h
489 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
490 for h, i in subhost_identity_pairs]
491
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200492 def test_identity_parsing(self):
493 self.assertEqual(self.c._parse_identity('ldap.google.com'),
494 ('ldap', 'google.com'))
495 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
496 ('ldap', 'example.com'))
497 # Specical case because we know there are no subdomains in chromium.org.
498 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
499 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800500 # Pathological: ".period." can be either username OR domain, more likely
501 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200502 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
503 ('note', 'period.example.com'))
504
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100505 def test_analysis_nothing(self):
506 self.c._all_hosts = []
507 self.assertFalse(self.c.has_generic_host())
508 self.assertEqual(set(), self.c.get_conflicting_hosts())
509 self.assertEqual(set(), self.c.get_duplicated_hosts())
510 self.assertEqual(set(), self.c.get_partially_configured_hosts())
511 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
512
513 def test_analysis(self):
514 self.mock_hosts_creds([
515 ('.googlesource.com', 'git-example.chromium.org'),
516
517 ('chromium', 'git-example.google.com'),
518 ('chromium-review', 'git-example.google.com'),
519 ('chrome-internal', 'git-example.chromium.org'),
520 ('chrome-internal-review', 'git-example.chromium.org'),
521 ('conflict', 'git-example.google.com'),
522 ('conflict-review', 'git-example.chromium.org'),
523 ('dup', 'git-example.google.com'),
524 ('dup', 'git-example.google.com'),
525 ('dup-review', 'git-example.google.com'),
526 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200527 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100528 ])
529 self.assertTrue(self.c.has_generic_host())
530 self.assertEqual(set(['conflict.googlesource.com']),
531 self.c.get_conflicting_hosts())
532 self.assertEqual(set(['dup.googlesource.com']),
533 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200534 self.assertEqual(set(['partial.googlesource.com',
535 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100536 self.c.get_partially_configured_hosts())
537 self.assertEqual(set(['chromium.googlesource.com',
538 'chrome-internal.googlesource.com']),
539 self.c.get_hosts_with_wrong_identities())
540
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100541 def test_report_no_problems(self):
542 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100543 self.assertFalse(self.c.find_and_report_problems())
544 self.assertEqual(sys.stdout.getvalue(), '')
545
Edward Lemurda4b6c62020-02-13 00:28:40 +0000546 @mock.patch(
547 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
548 return_value='~/.gitcookies')
549 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100550 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100551 self.assertTrue(self.c.find_and_report_problems())
552 with open(os.path.join(os.path.dirname(__file__),
553 'git_cl_creds_check_report.txt')) as f:
554 expected = f.read()
555 def by_line(text):
556 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700557 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200558 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100559
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800560
Edward Lemurda4b6c62020-02-13 00:28:40 +0000561class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000562 def setUp(self):
563 super(TestGitCl, self).setUp()
564 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700565 self._calls_done = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000566 mock.patch('sys.stdout', StringIO()).start()
567 mock.patch(
568 'git_cl.time_time',
569 lambda: self._mocked_call('time.time')).start()
570 mock.patch(
571 'git_cl.metrics.collector.add_repeated',
572 lambda *a: self._mocked_call('add_repeated', *a)).start()
573 mock.patch('subprocess2.call', self._mocked_call).start()
574 mock.patch('subprocess2.check_call', self._mocked_call).start()
575 mock.patch('subprocess2.check_output', self._mocked_call).start()
576 mock.patch(
577 'subprocess2.communicate',
578 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
579 mock.patch(
580 'git_cl.gclient_utils.CheckCallAndFilter',
581 self._mocked_call).start()
582 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
583 mock.patch(
584 'git_common.get_or_create_merge_base',
585 lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start()
586 mock.patch('git_cl.BranchExists', return_value=True).start()
587 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
588 mock.patch(
589 'git_cl.SaveDescriptionBackup',
590 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
591 mock.patch(
592 'git_cl.ask_for_data',
593 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
594 mock.patch(
595 'git_cl.write_json',
596 lambda *a: self._mocked_call('write_json', *a)).start()
597 mock.patch(
598 'git_cl.presubmit_support.DoPresubmitChecks', PresubmitMock).start()
599 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
600 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
601 mock.patch(
602 'git_cl.gerrit_util.GetChangeDetail',
603 lambda *a: self._mocked_call('GetChangeDetail', *a)).start()
604 mock.patch(
605 'git_cl.gerrit_util.GetChangeComments',
606 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
607 mock.patch(
608 'git_cl.gerrit_util.GetChangeRobotComments',
609 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
610 mock.patch(
611 'git_cl.gerrit_util.AddReviewers',
612 lambda *a: self._mocked_call('AddReviewers', *a)).start()
613 mock.patch(
614 'git_cl.gerrit_util.SetReview',
615 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
616 self._mocked_call(
617 'SetReview', h, i, msg, labels, notify, ready))).start()
618 mock.patch(
619 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
620 return_value=False).start()
621 mock.patch(
622 'git_cl.gerrit_util.GceAuthenticator.is_gce',
623 return_value=False).start()
624 mock.patch(
625 'git_cl.gerrit_util.ValidAccounts',
626 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
627 mock.patch(
628 'git_cl.DieWithError',
629 lambda msg, change=None: self._mocked_call('DieWithError', msg)).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000630 # It's important to reset settings to not have inter-tests interference.
631 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000632 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000633
634 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000635 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000636 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100637 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000638 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100639 raise
640 # Sadly, has_failed() returns True if this OR any other tests before this
641 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200642 git_cl.logging.error(
643 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100644 'There are un-consumed self.calls after this test has finished.\n'
645 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700646 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200647 'If you are already running only this test, then **first** fix the '
648 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100649 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700650 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100651 'and follow instructions above.\n' +
652 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000653 finally:
654 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000655
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000656 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000657 self.assertTrue(
658 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700659 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000660 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000661 expected_args, result = top
662
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000663 # Also logs otherwise it could get caught in a try/finally and be hard to
664 # diagnose.
665 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700666 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000667 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700668 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
669 for i, c in enumerate(self._calls_done[-N:]))
670 following_calls = '\n '.join(
671 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
672 for i, c in enumerate(self.calls[:N]))
673 extended_msg = (
674 'A few prior calls:\n %s\n\n'
675 'This (expected):\n @%d: %r\n'
676 'This (actual):\n @%d: %r\n\n'
677 'A few following expected calls:\n %s' %
678 (prior_calls, len(self._calls_done), expected_args,
679 len(self._calls_done), args, following_calls))
680 git_cl.logging.error(extended_msg)
681
tandrii99a72f22016-08-17 14:33:24 -0700682 self.fail('@%d\n'
683 ' Expected: %r\n'
684 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700685 len(self._calls_done), expected_args, args))
686
687 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700688 if isinstance(result, Exception):
689 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000690 # stdout from git commands is supposed to be a bytestream. Convert it here
691 # instead of converting all test output in this file to bytes.
692 if args[0][0] == 'git' and not isinstance(result, bytes):
693 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000694 return result
695
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100696 def test_ask_for_explicit_yes_true(self):
697 self.calls = [
698 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
699 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
700 ]
701 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
702
tandrii48df5812016-10-17 03:55:37 -0700703 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000704 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700705 self.calls = [
706 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700707 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
708 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
709 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
710 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700711 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
712 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700713 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
714 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000715 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
716 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700717 ((['git', 'config', 'gerrit.host', 'true'],), ''),
718 ]
719 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
720
maruel@chromium.orga3353652011-11-30 14:26:57 +0000721 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000722 def _is_gerrit_calls(cls, gerrit=False):
723 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
724 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
725
726 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000727 def _git_post_upload_calls(cls):
728 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000729 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
730 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
731 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000732 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000733 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000734 ]
735
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000736 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000737 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000738 fake_ancestor = 'fake_ancestor'
739 fake_cl = 'fake_cl_for_patch'
740 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000741 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000742 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000743 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000744 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000745 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000746 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000747 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000748 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700749 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000750 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000751 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000752 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000753 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000754 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000755 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000756 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000757 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000758 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000759 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000760 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000761
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000762 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000763 def _gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000764 cls, issue=None, skip_auth_check=False, short_hostname='chromium',
765 custom_cl_base=None):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000766 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000767 if skip_auth_check:
768 return [((cmd, ), 'true')]
769
tandrii5d48c322016-08-18 16:19:37 -0700770 calls = [((cmd, ), CERR1)]
Edward Lemurf38bc172019-09-03 21:02:13 +0000771
772 if custom_cl_base:
773 calls += [
774 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
775 ]
776
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000777 calls.extend([
778 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
779 ((['git', 'config', 'branch.master.remote'],), 'origin'),
780 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000781 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000782 ])
Edward Lemurf38bc172019-09-03 21:02:13 +0000783
784 calls += [
785 ((['git', 'config', 'branch.master.gerritissue'],),
786 CERR1 if issue is None else str(issue)),
787 ]
788
Daniel Chengcf6269b2019-05-18 01:02:12 +0000789 if issue:
790 calls.extend([
791 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
792 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000793 return calls
794
795 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100796 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200797 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000798 custom_cl_base=None, short_hostname='chromium',
799 change_id=None):
Aaron Gable13101a62018-02-09 13:20:41 -0800800 calls = cls._is_gerrit_calls(True)
Edward Lemurf38bc172019-09-03 21:02:13 +0000801 if not custom_cl_base:
802 calls += [
803 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
804 ]
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200805
806 if custom_cl_base:
807 ancestor_revision = custom_cl_base
808 else:
809 # Determine ancestor_revision to be merge base.
810 ancestor_revision = 'fake_ancestor_sha'
811 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000812 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000813 ((['git', 'config', 'branch.master.remote'],), 'origin'),
Edward Lemurda4b6c62020-02-13 00:28:40 +0000814 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
815 ancestor_revision),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200816 ]
817
818 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000819 calls += cls._gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000820 issue=issue, short_hostname=short_hostname,
821 custom_cl_base=custom_cl_base)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100822
823 if issue:
824 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000825 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000826 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000827 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
828 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100829 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100830 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Anthony Polito8b955342019-09-24 19:01:36 +0000831 'change_id': (change_id or '123456789'),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100832 'current_revision': 'sha1_of_current_revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000833 'revisions': {'sha1_of_current_revision': {
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100834 'commit': {'message': fetched_description},
835 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100836 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100837 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100838 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100839 if fetched_status == 'ABANDONED':
840 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000841 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100842 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000843 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100844 ]
845 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100846 if other_cl_owner:
847 calls += [
848 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
849 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100850
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200851 calls += cls._git_sanity_checks(ancestor_revision, 'master',
852 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100853 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200854 ((['git', 'rev-parse', '--show-cdup'],), ''),
855 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000856
Aaron Gable7817f022017-12-12 09:43:17 -0800857 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
Edward Lemur7f6dec02020-02-06 20:23:58 +0000858 '--no-renames', '-r', ancestor_revision + '...'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200859 'M\t.gitignore\n'),
860 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100861 ]
862
863 if not issue:
864 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200865 ((['git', 'log', '--pretty=format:%s%n%n%b',
866 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000867 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100868 ]
869
870 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200871 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000872 (('time.time',), 1000,),
873 (('time.time',), 3000,),
874 (('add_repeated', 'sub_commands', {
875 'execution_time': 2000,
876 'command': 'presubmit',
877 'exit_code': 0
878 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200879 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
880 ([custom_cl_base] if custom_cl_base else
881 [ancestor_revision, 'HEAD']),),
882 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100883 ]
884 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000885
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000886 @classmethod
887 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700888 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000889 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700890 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100891 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000892 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000893 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000894 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000895 final_description=None, gitcookies_exists=True,
Josipe827b0f2020-01-30 00:07:20 +0000896 force=False, edit_description=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000897 if post_amend_description is None:
898 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700899 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200900 # Determined in `_gerrit_base_calls`.
901 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
902
903 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000904
tandriia60502f2016-06-20 02:01:53 -0700905 if squash_mode == 'default':
906 calls.extend([
907 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
908 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
909 ])
910 elif squash_mode in ('override_squash', 'override_nosquash'):
911 calls.extend([
912 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
913 'true' if squash_mode == 'override_squash' else 'false'),
914 ])
915 else:
916 assert squash_mode in ('squash', 'nosquash')
917
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000918 # If issue is given, then description is fetched from Gerrit instead.
919 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000920 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200921 ((['git', 'log', '--pretty=format:%s\n\n%b',
922 ((custom_cl_base + '..') if custom_cl_base else
923 'fake_ancestor_sha..HEAD')],),
924 description),
925 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800926 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000927 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800928 else:
929 if not title:
930 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200931 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
932 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800933 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000934 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000935 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000936 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200937 (('DownloadGerritHook', False), ''),
938 # Amending of commit message to get the Change-Id.
939 ((['git', 'log', '--pretty=format:%s\n\n%b',
940 determined_ancestor_revision + '..HEAD'],),
941 description),
942 ((['git', 'commit', '--amend', '-m', description],), ''),
943 ((['git', 'log', '--pretty=format:%s\n\n%b',
944 determined_ancestor_revision + '..HEAD'],),
945 post_amend_description)
946 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000947 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000948 if force or not issue:
949 if issue:
950 calls += [
951 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
952 ]
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000953 # Prompting to edit description on first upload.
954 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000955 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000956 ]
Anthony Polito8b955342019-09-24 19:01:36 +0000957 if not force:
958 calls += [
959 ((['git', 'config', 'core.editor'],), ''),
960 ((['RunEditor'],), description),
961 ]
Josipe827b0f2020-01-30 00:07:20 +0000962 # user wants to edit description
963 if edit_description:
964 calls += [
965 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
966 ((['git', 'config', 'core.editor'],), ''),
967 ((['RunEditor'],), edit_description),
968 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000969 ref_to_push = 'abcdef0123456789'
970 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200971 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
972 ((['git', 'config', 'branch.master.remote'],), 'origin'),
973 ]
974
975 if custom_cl_base is None:
976 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000977 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000978 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200979 ]
980 parent = 'origin/master'
981 else:
982 calls += [
983 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
984 'refs/remotes/origin/master'],),
985 callError(1)), # Means not ancenstor.
986 (('ask_for_data',
987 'Do you take responsibility for cleaning up potential mess '
988 'resulting from proceeding with upload? Press Enter to upload, '
989 'or Ctrl+C to abort'), ''),
990 ]
991 parent = custom_cl_base
992
993 calls += [
994 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
995 '0123456789abcdef'),
996 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -0700997 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200998 ref_to_push),
999 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001000 else:
1001 ref_to_push = 'HEAD'
1002
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001003 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001004 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001005 ((['git', 'rev-list',
1006 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1007 ref_to_push],),
1008 '1hashPerLine\n'),
1009 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001010
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001011 metrics_arguments = []
1012
Aaron Gableafd52772017-06-27 16:40:10 -07001013 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001014 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001015 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001016 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001017 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001018 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001019 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001020 else:
1021 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001022 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001023
Aaron Gable70f4e242017-06-26 10:45:59 -07001024 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001025 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001026 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001027
Edward Lemur4508b422019-10-03 21:56:35 +00001028 if issue is None:
1029 calls += [
1030 ((['git', 'config', 'rietveld.cc'],), ''),
1031 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001032 if short_hostname == 'chromium':
1033 # All reviwers and ccs get into ref_suffix.
1034 for r in sorted(reviewers):
1035 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001036 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +00001037 if issue is None:
1038 cc += ['chromium-reviews+test-more-cc@chromium.org', 'joe@example.com']
1039 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001040 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001041 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001042 reviewers, cc = [], []
1043 else:
1044 # TODO(crbug/877717): remove this case.
1045 calls += [
1046 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1047 sorted(reviewers) + ['joe@example.com',
1048 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1049 {
1050 e: {'email': e}
1051 for e in (reviewers + ['joe@example.com'] + cc)
1052 })
1053 ]
1054 for r in sorted(reviewers):
1055 if r != 'bad-account-or-email':
1056 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001057 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001058 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +00001059 if issue is None:
1060 cc += ['joe@example.com']
1061 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001062 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001063 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001064 if c in cc:
1065 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001066
Edward Lemur687ca902018-12-05 02:30:30 +00001067 for k, v in sorted((labels or {}).items()):
1068 ref_suffix += ',l=%s+%d' % (k, v)
1069 metrics_arguments.append('l=%s+%d' % (k, v))
1070
1071 if tbr:
1072 calls += [
1073 (('GetCodeReviewTbrScore',
1074 '%s-review.googlesource.com' % short_hostname,
1075 'my/repo'),
1076 2,),
1077 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001078
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001079 calls += [
1080 (('time.time',), 1000,),
1081 ((['git', 'push',
1082 'https://%s.googlesource.com/my/repo' % short_hostname,
1083 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1084 (('remote:\n'
1085 'remote: Processing changes: (\)\n'
1086 'remote: Processing changes: (|)\n'
1087 'remote: Processing changes: (/)\n'
1088 'remote: Processing changes: (-)\n'
1089 'remote: Processing changes: new: 1 (/)\n'
1090 'remote: Processing changes: new: 1, done\n'
1091 'remote:\n'
1092 'remote: New Changes:\n'
1093 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1094 ' XXX\n'
1095 'remote:\n'
1096 'To https://%s.googlesource.com/my/repo\n'
1097 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1098 ) % (short_hostname, short_hostname)),),
1099 (('time.time',), 2000,),
1100 (('add_repeated',
1101 'sub_commands',
1102 {
1103 'execution_time': 1000,
1104 'command': 'git push',
1105 'exit_code': 0,
1106 'arguments': sorted(metrics_arguments),
1107 }),
1108 None,),
1109 ]
1110
Edward Lemur1b52d872019-05-09 21:12:12 +00001111 final_description = final_description or post_amend_description.strip()
1112 original_title = original_title or title or '<untitled>'
1113 # Trace-related calls
1114 calls += [
1115 # Write a description with context for the current trace.
1116 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001117 'Thu Mar 16 20:00:41 2017\n'
1118 '%(short_hostname)s-review.googlesource.com\n'
1119 '%(change_id)s\n'
1120 '%(title)s\n'
1121 '%(description)s\n'
1122 '1000\n'
1123 '0\n'
1124 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001125 'short_hostname': short_hostname,
1126 'change_id': change_id,
1127 'description': final_description,
1128 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001129 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001130 }],),
1131 None,
1132 ),
1133 # Read traces and shorten git hashes.
1134 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1135 True,
1136 ),
1137 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1138 ('git-hash: 0123456789012345678901234567890123456789\n'
1139 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1140 ),
1141 ((['FileWrite', 'TEMP_DIR/trace-packet',
1142 'git-hash: 012345\n'
1143 'git-hash: abcdea\n'],),
1144 None,
1145 ),
1146 # Make zip file for the git traces.
1147 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1148 'TEMP_DIR'],),
1149 None,
1150 ),
1151 # Collect git config and gitcookies.
1152 ((['git', 'config', '-l'],),
1153 'git-config-output',
1154 ),
1155 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1156 None,
1157 ),
1158 ((['os.path.isfile', '~/.gitcookies'],),
1159 gitcookies_exists,
1160 ),
1161 ]
1162 if gitcookies_exists:
1163 calls += [
1164 ((['FileRead', '~/.gitcookies'],),
1165 'gitcookies 1/SECRET',
1166 ),
1167 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1168 None,
1169 ),
1170 ]
1171 calls += [
1172 # Make zip file for the git config and gitcookies.
1173 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1174 'TEMP_DIR'],),
1175 None,
1176 ),
1177 ]
1178
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001179 if squash:
1180 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001181 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001182 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001183 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001184 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001185 ((['git', 'config', 'branch.master.gerritsquashhash',
1186 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001187 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001188 # TODO(crbug/877717): this should never be used.
1189 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001190 calls += [
1191 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001192 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001193 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001194 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1195 notify),
1196 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001197 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001198 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001199 return calls
1200
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001201 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001202 self,
1203 upload_args,
1204 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001205 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001206 squash=True,
1207 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001208 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001209 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001210 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001211 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001212 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001213 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001214 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001215 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001216 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001217 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001218 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001219 labels=None,
1220 change_id=None,
1221 original_title=None,
1222 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001223 gitcookies_exists=True,
1224 force=False,
Josipe827b0f2020-01-30 00:07:20 +00001225 edit_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001226 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001227 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001228 if squash_mode is None:
1229 if '--no-squash' in upload_args:
1230 squash_mode = 'nosquash'
1231 elif '--squash' in upload_args:
1232 squash_mode = 'squash'
1233 else:
1234 squash_mode = 'default'
1235
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001236 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001237 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001238 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001239 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001240 same_auth=('git-owner.example.com', '', 'pass'))).start()
1241 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1242 lambda _, offer_removal: None).start()
1243 mock.patch('git_cl.gclient_utils.RunEditor',
1244 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1245 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
1246 'DownloadGerritHook', force)).start()
1247 mock.patch('git_cl.gclient_utils.FileRead',
1248 lambda path: self._mocked_call(['FileRead', path])).start()
1249 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001250 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001251 ['FileWrite', path, contents])).start()
1252 mock.patch('git_cl.datetime_now',
1253 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1254 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1255 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1256 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001257 '%(now)s\n'
1258 '%(gerrit_host)s\n'
1259 '%(change_id)s\n'
1260 '%(title)s\n'
1261 '%(description)s\n'
1262 '%(execution_time)s\n'
1263 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001264 '%(trace_name)s').start()
1265 mock.patch('git_cl.shutil.make_archive',
1266 lambda *args: self._mocked_call(['make_archive'] +
1267 list(args))).start()
1268 mock.patch('os.path.isfile',
1269 lambda path: self._mocked_call(['os.path.isfile', path])).start()
tandriia60502f2016-06-20 02:01:53 -07001270
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001271 self.calls = self._gerrit_base_calls(
1272 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001273 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001274 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001275 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001276 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001277 short_hostname=short_hostname,
1278 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001279 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001280 mock.patch(
1281 'tempfile.NamedTemporaryFile',
1282 MakeNamedTemporaryFileMock(
1283 self, expected_content=description)).start()
1284 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001285 self.calls += self._gerrit_upload_calls(
1286 description, reviewers, squash,
1287 squash_mode=squash_mode,
1288 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001289 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001290 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001291 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001292 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001293 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001294 labels=labels,
1295 change_id=change_id,
1296 original_title=original_title,
1297 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001298 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001299 force=force,
1300 edit_description=edit_description)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001301 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001302 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001303 git_cl.main(['upload'] + upload_args)
1304
Edward Lemur1b52d872019-05-09 21:12:12 +00001305 def test_gerrit_upload_traces_no_gitcookies(self):
1306 self._run_gerrit_upload_test(
1307 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001308 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001309 [],
1310 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001311 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001312 change_id='Ixxx',
1313 gitcookies_exists=False)
1314
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001315 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001316 self._run_gerrit_upload_test(
1317 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001318 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001319 [],
1320 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001321 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001322 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001323
1324 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001325 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001326 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001327 'desc ✔\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001328 [],
tandriia60502f2016-06-20 02:01:53 -07001329 squash=False,
1330 squash_mode='override_nosquash',
Edward Lemur0db01f02019-11-12 22:01:51 +00001331 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001332 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001333
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001334 def test_gerrit_no_reviewer(self):
1335 self._run_gerrit_upload_test(
1336 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001337 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001338 [],
1339 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001340 squash_mode='override_nosquash',
1341 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001342
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001343 def test_gerrit_no_reviewer_non_chromium_host(self):
1344 # TODO(crbug/877717): remove this test case.
1345 self._run_gerrit_upload_test(
1346 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001347 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001348 [],
1349 squash=False,
1350 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001351 short_hostname='other',
1352 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001353
Nick Carter8692b182017-11-06 16:30:38 -08001354 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001355 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001356 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001357 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001358 squash=False,
1359 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001360 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1361 change_id='I123456789',
1362 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001363
ukai@chromium.orge8077812012-02-03 03:41:46 +00001364 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001365 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001366 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001367 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001368 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001369 squash=False,
1370 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001371 notify=True,
1372 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001373 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001374 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001375
Anthony Polito8b955342019-09-24 19:01:36 +00001376 def test_gerrit_upload_force_sets_bug(self):
1377 self._run_gerrit_upload_test(
1378 ['-b', '10000', '-f'],
1379 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1380 [],
1381 force=True,
1382 expected_upstream_ref='origin/master',
1383 fetched_description='desc=\n\nChange-Id: Ixxx',
1384 original_title='Initial upload',
1385 change_id='Ixxx')
1386
1387 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1388 self._run_gerrit_upload_test(
1389 ['-b', '10000', '-f', '-m', 'Title'],
1390 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1391 [],
1392 force=True,
1393 issue='123456',
1394 expected_upstream_ref='origin/master',
1395 fetched_description='desc=\n\nChange-Id: Ixxxx',
1396 original_title='Title',
1397 title='Title',
1398 change_id='Izzzz')
1399
Dan Beamd8b04ca2019-10-10 21:23:26 +00001400 def test_gerrit_upload_force_sets_fixed(self):
1401 self._run_gerrit_upload_test(
1402 ['-x', '10000', '-f'],
1403 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1404 [],
1405 force=True,
1406 expected_upstream_ref='origin/master',
1407 fetched_description='desc=\n\nChange-Id: Ixxx',
1408 original_title='Initial upload',
1409 change_id='Ixxx')
1410
ukai@chromium.orge8077812012-02-03 03:41:46 +00001411 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001412 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1413 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001414 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001415 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001416 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001417 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001418 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001419 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001420 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001421 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001422 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001423 labels={'Code-Review': 2},
1424 change_id='123456789',
1425 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001426
1427 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001428 self._run_gerrit_upload_test(
1429 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001430 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001431 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001432 expected_upstream_ref='origin/master',
1433 change_id='123456789',
1434 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001435
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001436 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001437 self._run_gerrit_upload_test(
1438 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001439 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001440 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001441 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001442 expected_upstream_ref='origin/master',
1443 change_id='123456789',
1444 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001445
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001446 def test_gerrit_upload_squash_first_with_labels(self):
1447 self._run_gerrit_upload_test(
1448 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001449 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001450 [],
1451 squash=True,
1452 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001453 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1454 change_id='123456789',
1455 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001456
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001457 def test_gerrit_upload_squash_first_against_rev(self):
1458 custom_cl_base = 'custom_cl_base_rev_or_branch'
1459 self._run_gerrit_upload_test(
1460 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001461 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001462 [],
1463 squash=True,
1464 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001465 custom_cl_base=custom_cl_base,
1466 change_id='123456789',
1467 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001468 self.assertIn(
1469 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1470 sys.stdout.getvalue())
1471
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001472 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001473 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001474 self._run_gerrit_upload_test(
1475 ['--squash'],
1476 description,
1477 [],
1478 squash=True,
1479 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001480 issue=123456,
1481 change_id='123456789',
1482 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001483
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001484 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001485 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001486 with self.assertRaises(SystemExitMock):
1487 self._run_gerrit_upload_test(
1488 ['--squash'],
1489 description,
1490 [],
1491 squash=True,
1492 expected_upstream_ref='origin/master',
1493 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001494 fetched_status='ABANDONED',
1495 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001496
Edward Lemurda4b6c62020-02-13 00:28:40 +00001497 @mock.patch(
1498 'gerrit_util.GetAccountDetails',
1499 return_value={'email': 'yet-another@example.com'})
1500 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001501 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001502 self._run_gerrit_upload_test(
1503 ['--squash'],
1504 description,
1505 [],
1506 squash=True,
1507 expected_upstream_ref='origin/master',
1508 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001509 other_cl_owner='other@example.com',
1510 change_id='123456789',
1511 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001512 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001513 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001514 'authenticate to Gerrit as yet-another@example.com.\n'
1515 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001516 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001517
Josipe827b0f2020-01-30 00:07:20 +00001518 def test_upload_change_description_editor(self):
1519 fetched_description = 'foo\n\nChange-Id: 123456789'
1520 description = 'bar\n\nChange-Id: 123456789'
1521 self._run_gerrit_upload_test(
1522 ['--squash', '--edit-description'],
1523 description,
1524 [],
1525 fetched_description=fetched_description,
1526 squash=True,
1527 expected_upstream_ref='origin/master',
1528 issue=123456,
1529 change_id='123456789',
1530 original_title='User input',
1531 edit_description=description)
1532
Edward Lemurda4b6c62020-02-13 00:28:40 +00001533 @mock.patch('git_cl.RunGit')
1534 @mock.patch('git_cl.CMDupload')
1535 @mock.patch('git_cl.ask_for_data')
1536 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001537 def mock_run_git(*args, **_kwargs):
1538 if args[0] == ['for-each-ref',
1539 '--format=%(refname:short) %(upstream:short)',
1540 'refs/heads']:
1541 # Create a local branch dependency tree that looks like this:
1542 # test1 -> test2 -> test3 -> test4 -> test5
1543 # -> test3.1
1544 # test6 -> test0
1545 branch_deps = [
1546 'test2 test1', # test1 -> test2
1547 'test3 test2', # test2 -> test3
1548 'test3.1 test2', # test2 -> test3.1
1549 'test4 test3', # test3 -> test4
1550 'test5 test4', # test4 -> test5
1551 'test6 test0', # test0 -> test6
1552 'test7', # test7
1553 ]
1554 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001555 git_cl.RunGit.side_effect = mock_run_git
1556 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001557
1558 class MockChangelist():
1559 def __init__(self):
1560 pass
1561 def GetBranch(self):
1562 return 'test1'
1563 def GetIssue(self):
1564 return '123'
1565 def GetPatchset(self):
1566 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001567 def IsGerrit(self):
1568 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001569
1570 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1571 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001572 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
1573 git_cl.ask_for_data.assert_called_once_with(
1574 'This command will checkout all dependent branches '
1575 'and run "git cl upload". Press Enter to continue, '
1576 'or Ctrl+C to abort')
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001577 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001578
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001579 def test_gerrit_change_id(self):
1580 self.calls = [
1581 ((['git', 'write-tree'], ),
1582 'hashtree'),
1583 ((['git', 'rev-parse', 'HEAD~0'], ),
1584 'branch-parent'),
1585 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1586 'A B <a@b.org> 1456848326 +0100'),
1587 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1588 'C D <c@d.org> 1456858326 +0100'),
1589 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1590 'hashchange'),
1591 ]
1592 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1593 self.assertEqual(change_id, 'Ihashchange')
1594
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001595 def test_desecription_append_footer(self):
1596 for init_desc, footer_line, expected_desc in [
1597 # Use unique desc first lines for easy test failure identification.
1598 ('foo', 'R=one', 'foo\n\nR=one'),
1599 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1600 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1601 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1602 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1603 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1604 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1605 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1606 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1607 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1608 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1609 ]:
1610 desc = git_cl.ChangeDescription(init_desc)
1611 desc.append_footer(footer_line)
1612 self.assertEqual(desc.description, expected_desc)
1613
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001614 def test_update_reviewers(self):
1615 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001616 ('foo', [], [],
1617 'foo'),
1618 ('foo\nR=xx', [], [],
1619 'foo\nR=xx'),
1620 ('foo\nTBR=xx', [], [],
1621 'foo\nTBR=xx'),
1622 ('foo', ['a@c'], [],
1623 'foo\n\nR=a@c'),
1624 ('foo\nR=xx', ['a@c'], [],
1625 'foo\n\nR=a@c, xx'),
1626 ('foo\nTBR=xx', ['a@c'], [],
1627 'foo\n\nR=a@c\nTBR=xx'),
1628 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1629 'foo\n\nR=a@c, yy\nTBR=xx'),
1630 ('foo\nBUG=', ['a@c'], [],
1631 'foo\nBUG=\nR=a@c'),
1632 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1633 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1634 ('foo', ['a@c', 'b@c'], [],
1635 'foo\n\nR=a@c, b@c'),
1636 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1637 'foo\nBar\n\nR=c@c\nBUG='),
1638 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1639 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001640 # Same as the line before, but full of whitespaces.
1641 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001642 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001643 'foo\nBar\n\nR=c@c\n BUG =',
1644 ),
1645 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001646 ('foo BUG=allo R=joe ', ['c@c'], [],
1647 'foo BUG=allo R=joe\n\nR=c@c'),
1648 # Redundant TBRs get promoted to Rs
1649 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1650 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001651 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001652 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001653 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001654 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001655 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001656 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001657 actual.append(obj.description)
1658 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001659
Nodir Turakulov23b82142017-11-16 11:04:25 -08001660 def test_get_hash_tags(self):
1661 cases = [
1662 ('', []),
1663 ('a', []),
1664 ('[a]', ['a']),
1665 ('[aa]', ['aa']),
1666 ('[a ]', ['a']),
1667 ('[a- ]', ['a']),
1668 ('[a- b]', ['a-b']),
1669 ('[a--b]', ['a-b']),
1670 ('[a', []),
1671 ('[a]x', ['a']),
1672 ('[aa]x', ['aa']),
1673 ('[a b]', ['a-b']),
1674 ('[a b]', ['a-b']),
1675 ('[a__b]', ['a-b']),
1676 ('[a] x', ['a']),
1677 ('[a][b]', ['a', 'b']),
1678 ('[a] [b]', ['a', 'b']),
1679 ('[a][b]x', ['a', 'b']),
1680 ('[a][b] x', ['a', 'b']),
1681 ('[a]\n[b]', ['a']),
1682 ('[a\nb]', []),
1683 ('[a][', ['a']),
1684 ('Revert "[a] feature"', ['a']),
1685 ('Reland "[a] feature"', ['a']),
1686 ('Revert: [a] feature', ['a']),
1687 ('Reland: [a] feature', ['a']),
1688 ('Revert "Reland: [a] feature"', ['a']),
1689 ('Foo: feature', ['foo']),
1690 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001691 ('Change Foo::Bar', []),
1692 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001693 ('Revert "Foo bar: feature"', ['foo-bar']),
1694 ('Reland "Foo bar: feature"', ['foo-bar']),
1695 ]
1696 for desc, expected in cases:
1697 change_desc = git_cl.ChangeDescription(desc)
1698 actual = change_desc.get_hash_tags()
1699 self.assertEqual(
1700 actual,
1701 expected,
1702 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1703
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001704 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001705 self.assertEqual(None, git_cl.GetTargetRef(None,
1706 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001707 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001708
wittman@chromium.org455dc922015-01-26 20:15:50 +00001709 # Check default target refs for branches.
1710 self.assertEqual('refs/heads/master',
1711 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001712 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001713 self.assertEqual('refs/heads/master',
1714 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001715 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001716 self.assertEqual('refs/heads/master',
1717 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001718 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001719 self.assertEqual('refs/branch-heads/123',
1720 git_cl.GetTargetRef('origin',
1721 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001722 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001723 self.assertEqual('refs/diff/test',
1724 git_cl.GetTargetRef('origin',
1725 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001726 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001727 self.assertEqual('refs/heads/chrome/m42',
1728 git_cl.GetTargetRef('origin',
1729 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001730 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001731
1732 # Check target refs for user-specified target branch.
1733 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1734 'refs/remotes/branch-heads/123'):
1735 self.assertEqual('refs/branch-heads/123',
1736 git_cl.GetTargetRef('origin',
1737 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001738 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001739 for branch in ('origin/master', 'remotes/origin/master',
1740 'refs/remotes/origin/master'):
1741 self.assertEqual('refs/heads/master',
1742 git_cl.GetTargetRef('origin',
1743 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001744 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001745 for branch in ('master', 'heads/master', 'refs/heads/master'):
1746 self.assertEqual('refs/heads/master',
1747 git_cl.GetTargetRef('origin',
1748 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001749 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001750
Edward Lemurda4b6c62020-02-13 00:28:40 +00001751 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1752 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001753 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001754 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1755
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001756 @staticmethod
1757 def _get_gerrit_codereview_server_calls(branch, value=None,
1758 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001759 detect_branch=True,
1760 detect_server=True):
Edward Lemur125d60a2019-09-13 18:25:41 +00001761 """Returns calls executed by Changelist.GetCodereviewServer.
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001762
1763 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1764 """
1765 calls = []
1766 if detect_branch:
1767 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001768 if detect_server:
1769 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1770 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001771 if value is None:
1772 calls += [
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001773 ((['git', 'config', 'branch.' + branch + '.merge'],),
1774 'refs/heads' + branch),
1775 ((['git', 'config', 'branch.' + branch + '.remote'],),
1776 'origin'),
1777 ((['git', 'config', 'remote.origin.url'],),
1778 'https://%s.googlesource.com/my/repo' % git_short_host),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001779 ]
1780 return calls
1781
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001782 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001783 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001784 detect_gerrit_server=False,
1785 actual_codereview=None,
1786 codereview_in_url=False):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001787 mock.patch('git_cl.IsGitVersionAtLeast', return_value=True).start()
wychen@chromium.orga872e752015-04-28 23:42:18 +00001788
tandriidf09a462016-08-18 16:23:55 -07001789 if new_branch:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001790 self.calls = [((['git', 'new-branch', 'master'],), '')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001791
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001792 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001793 self.calls += [
1794 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001795 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001796 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001797
1798 if not force_codereview and not codereview_in_url:
1799 # These calls detect codereview to use.
1800 self.calls += [
1801 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001802 ]
1803 if detect_gerrit_server:
1804 self.calls += self._get_gerrit_codereview_server_calls(
1805 'master', git_short_host=git_short_host,
1806 detect_branch=not new_branch and force_codereview)
1807 actual_codereview = 'gerrit'
1808
1809 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001810 self.calls += [
1811 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001812 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001813 {
1814 'current_revision': '7777777777',
1815 'revisions': {
1816 '1111111111': {
1817 '_number': 1,
1818 'fetch': {'http': {
1819 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1820 'ref': 'refs/changes/56/123456/1',
1821 }},
1822 },
1823 '7777777777': {
1824 '_number': 7,
1825 'fetch': {'http': {
1826 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1827 'ref': 'refs/changes/56/123456/7',
1828 }},
1829 },
1830 },
1831 }),
1832 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001833
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001834 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001835 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001836 self.calls += [
1837 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1838 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001839 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001840 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001841 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001842 ((['git', 'config', 'branch.master.gerritserver',
1843 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001844 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001845 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1846 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1847 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001848 ]
1849 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1850
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001851 def test_patch_gerrit_new_branch(self):
1852 self._patch_common(
1853 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1854 self.calls += [
1855 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1856 'refs/changes/56/123456/7'],), ''),
1857 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1858 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1859 ''),
1860 ((['git', 'config', 'branch.master.gerritserver',
1861 'https://chromium-review.googlesource.com'],), ''),
1862 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1863 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1864 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1865 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1866 ]
1867 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1868
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001869 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001870 self._patch_common(
1871 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001872 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001873 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001874 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001875 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001876 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001877 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001878 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001879 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001880 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001881 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1882 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1883 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001884 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001885 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001886
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001887 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001888 self.calls += self._get_gerrit_codereview_server_calls(
1889 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001890 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001891 actual_codereview='gerrit', git_short_host='else',
1892 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001893 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001894 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001895 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001896 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001897 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001898 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001899 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001900 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001901 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001902 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1903 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1904 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001905 ]
1906 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001907 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001908
Aaron Gable697a91b2018-01-19 15:20:15 -08001909 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001910 self.calls += self._get_gerrit_codereview_server_calls(
1911 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001912 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001913 actual_codereview='gerrit', git_short_host='else',
1914 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001915 self.calls += [
1916 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1917 'refs/changes/56/123456/1'],), ''),
1918 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1919 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1920 ''),
1921 ((['git', 'config', 'branch.master.gerritserver',
1922 'https://else-review.googlesource.com'],), ''),
1923 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1924 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1925 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1926 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1927 ]
1928 self.assertEqual(git_cl.main(
1929 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1930 0)
1931
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001932 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001933 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001934 self.calls += [
1935 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001936 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001937 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
Edward Lemurda4b6c62020-02-13 00:28:40 +00001938 (('DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'),
tandrii5d48c322016-08-18 16:19:37 -07001939 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001940 ]
1941 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001942 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001943
Edward Lemurda4b6c62020-02-13 00:28:40 +00001944 @mock.patch(
1945 'git_cl.gerrit_util.GetChangeDetail',
1946 side_effect=gerrit_util.GerritError(404, ''))
1947 def test_patch_gerrit_not_exists(self, *_mocks):
tandriic2405f52016-10-10 08:13:15 -07001948 self.calls = [
1949 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001950 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1951 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1952 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1953 ((['git', 'config', 'remote.origin.url'],),
1954 'https://chromium.googlesource.com/my/repo'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00001955 (('DieWithError',
1956 'change 123456 at https://chromium-review.googlesource.com does not '
1957 'exist or you have no access to it'), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001958 ]
1959 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001960 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001961
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001962 def _checkout_calls(self):
1963 return [
1964 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001965 'branch\\..*\\.gerritissue'], ),
1966 ('branch.ger-branch.gerritissue 123456\n'
1967 'branch.gbranch654.gerritissue 654321\n')),
1968 ]
1969
1970 def test_checkout_gerrit(self):
1971 """Tests git cl checkout <issue>."""
1972 self.calls = self._checkout_calls()
1973 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1974 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1975
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001976 def test_checkout_not_found(self):
1977 """Tests git cl checkout <issue>."""
1978 self.calls = self._checkout_calls()
1979 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1980
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001981 def test_checkout_no_branch_issues(self):
1982 """Tests git cl checkout <issue>."""
1983 self.calls = [
1984 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001985 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001986 ]
1987 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1988
tandrii@chromium.org28253532016-04-14 13:46:56 +00001989 def _test_gerrit_ensure_authenticated_common(self, auth,
1990 skip_auth_check=False):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001991 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1992 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001993 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
Edward Lemurf38bc172019-09-03 21:02:13 +00001994 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001995 cl.branch = 'master'
1996 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001997 return cl
1998
1999 def test_gerrit_ensure_authenticated_missing(self):
2000 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002001 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002002 })
2003 self.calls.append(
Edward Lemurda4b6c62020-02-13 00:28:40 +00002004 (('DieWithError',
2005 'Credentials for the following hosts are required:\n'
2006 ' chromium-review.googlesource.com\n'
2007 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
2008 'You can (re)generate your credentials by visiting '
2009 'https://chromium-review.googlesource.com/new-password'), ''),)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002010 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2011
2012 def test_gerrit_ensure_authenticated_conflict(self):
2013 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002014 'chromium.googlesource.com':
2015 ('git-one.example.com', None, 'secret1'),
2016 'chromium-review.googlesource.com':
2017 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002018 })
2019 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002020 (('ask_for_data', 'If you know what you are doing '
2021 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002022 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2023
2024 def test_gerrit_ensure_authenticated_ok(self):
2025 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002026 'chromium.googlesource.com':
2027 ('git-same.example.com', None, 'secret'),
2028 'chromium-review.googlesource.com':
2029 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002030 })
2031 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2032
tandrii@chromium.org28253532016-04-14 13:46:56 +00002033 def test_gerrit_ensure_authenticated_skipped(self):
2034 cl = self._test_gerrit_ensure_authenticated_common(
2035 auth={}, skip_auth_check=True)
2036 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2037
Eric Boren2fb63102018-10-05 13:05:03 +00002038 def test_gerrit_ensure_authenticated_bearer_token(self):
2039 cl = self._test_gerrit_ensure_authenticated_common(auth={
2040 'chromium.googlesource.com':
2041 ('', None, 'secret'),
2042 'chromium-review.googlesource.com':
2043 ('', None, 'secret'),
2044 })
2045 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2046 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2047 'chromium.googlesource.com')
2048 self.assertTrue('Bearer' in header)
2049
Daniel Chengcf6269b2019-05-18 01:02:12 +00002050 def test_gerrit_ensure_authenticated_non_https(self):
2051 self.calls = [
2052 ((['git', 'config', '--bool',
2053 'gerrit.skip-ensure-authenticated'],), CERR1),
2054 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2055 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2056 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
Josip906bfde2020-01-31 22:38:49 +00002057 (('logging.warning',
2058 'Ignoring branch %(branch)s with non-https remote '
2059 '%(remote)s', {
2060 'branch': 'master',
2061 'remote': 'custom-scheme://repo'}
2062 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00002063 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002064 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2065 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2066 mock.patch('logging.warning',
2067 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002068 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002069 cl.branch = 'master'
2070 cl.branchref = 'refs/heads/master'
2071 cl.lookedup_issue = True
2072 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2073
Florian Mayerae510e82020-01-30 21:04:48 +00002074 def test_gerrit_ensure_authenticated_non_url(self):
2075 self.calls = [
2076 ((['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated'], ),
2077 CERR1),
2078 ((['git', 'config', 'branch.master.merge'], ), 'refs/heads/master'),
2079 ((['git', 'config', 'branch.master.remote'], ), 'origin'),
2080 ((['git', 'config', 'remote.origin.url'], ),
2081 'git@somehost.example:foo/bar.git'),
Josip906bfde2020-01-31 22:38:49 +00002082 (('logging.error',
2083 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2084 'but it doesn\'t exist.', {
2085 'remote': 'origin',
2086 'branch': 'master',
2087 'url': 'git@somehost.example:foo/bar.git'}
2088 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00002089 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002090 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2091 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2092 mock.patch('logging.error',
2093 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00002094 cl = git_cl.Changelist()
2095 cl.branch = 'master'
2096 cl.branchref = 'refs/heads/master'
2097 cl.lookedup_issue = True
2098 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2099
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002100 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002101 self.calls = [
2102 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002103 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002104 ((['git', 'config', 'branch.feature.gerritserver'],),
2105 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002106 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2107 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2108 ((['git', 'config', 'remote.origin.url'],),
2109 'https://chromium.googlesource.com/infra/infra.git'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002110 (('SetReview', 'chromium-review.googlesource.com',
2111 'infra%2Finfra~123', None,
2112 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002113 ]
tandriid9e5ce52016-07-13 02:32:59 -07002114
2115 def test_cmd_set_commit_gerrit_clear(self):
2116 self._cmd_set_commit_gerrit_common(0)
2117 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2118
2119 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002120 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002121 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2122
tandriid9e5ce52016-07-13 02:32:59 -07002123 def test_cmd_set_commit_gerrit(self):
2124 self._cmd_set_commit_gerrit_common(2)
2125 self.assertEqual(0, git_cl.main(['set-commit']))
2126
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002127 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002128 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002129 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002130
2131 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002132 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002133
Edward Lemurda4b6c62020-02-13 00:28:40 +00002134 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07002135 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07002136 try:
2137 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2138 except SystemExit as ex:
2139 self.assertEqual(ex.code, 2)
Edward Lemur6c6827c2020-02-06 21:15:18 +00002140 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00002141 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07002142
2143 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07002144 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002145 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002146 return 'foobar'
2147
Edward Lemurda4b6c62020-02-13 00:28:40 +00002148 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07002149 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002150 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002151 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00002152 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07002153
iannuccie53c9352016-08-17 14:40:40 -07002154 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002155
iannuccie53c9352016-08-17 14:40:40 -07002156 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002157 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002158 return 'foobar'
2159
Edward Lemurda4b6c62020-02-13 00:28:40 +00002160 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2161 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002162 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002163 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002164
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002165 def test_description(self):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002166 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002167 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2168 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2169 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2170 ((['git', 'config', 'remote.origin.url'],),
2171 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002172 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002173 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002174 {
2175 'current_revision': 'sha1',
2176 'revisions': {'sha1': {
2177 'commit': {'message': 'foobar'},
2178 }},
2179 }),
2180 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002181 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002182 'description',
2183 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2184 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002185 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002186
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002187 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002188 mock.patch('git_cl.Changelist', ChangelistMock).start()
2189 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002190
2191 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2192 self.assertEqual('hihi', ChangelistMock.desc)
2193
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002194 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002195 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002196
2197 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002198 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002199 '# Enter a description of the change.\n'
2200 '# This will be displayed on the codereview site.\n'
2201 '# The first line will also be used as the subject of the review.\n'
2202 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002203 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002204 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002205 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002206 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002207 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002208
Edward Lemur6c6827c2020-02-06 21:15:18 +00002209 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002210 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002211
Edward Lemurda4b6c62020-02-13 00:28:40 +00002212 mock.patch('git_cl.Changelist.FetchDescription',
2213 lambda *args: current_desc).start()
2214 mock.patch('git_cl.Changelist.UpdateDescription',
2215 UpdateDescription).start()
2216 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002217
2218 self.calls = [
2219 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002220 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002221 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2222 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002223 ((['git', 'config', 'core.editor'],), 'vi'),
2224 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002225 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002226
Dan Beamd8b04ca2019-10-10 21:23:26 +00002227 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2228 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2229
2230 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002231 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002232 '# Enter a description of the change.\n'
2233 '# This will be displayed on the codereview site.\n'
2234 '# The first line will also be used as the subject of the review.\n'
2235 '#--------------------This line is 72 characters long'
2236 '--------------------\n'
2237 'Some.\n\nFixed: 123\nChange-Id: xxx',
2238 desc)
2239 return desc
2240
Edward Lemurda4b6c62020-02-13 00:28:40 +00002241 mock.patch('git_cl.Changelist.FetchDescription',
2242 lambda *args: current_desc).start()
2243 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002244
2245 self.calls = [
2246 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2247 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2248 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2249 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
2250 ((['git', 'config', 'core.editor'],), 'vi'),
2251 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002252 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002253
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002254 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002255 mock.patch('git_cl.Changelist', ChangelistMock).start()
2256 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002257
2258 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2259 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2260
kmarshall3bff56b2016-06-06 18:31:47 -07002261 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002262 self.calls = [
2263 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002264 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002265 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002266 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2267 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002268 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002269 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002270
Edward Lemurda4b6c62020-02-13 00:28:40 +00002271 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002272 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002273 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2274 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002275 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002276
2277 self.assertEqual(0, git_cl.main(['archive', '-f']))
2278
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002279 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002280 self.calls = [
2281 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2282 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2283 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2284 'refs/tags/git-cl-archived-456-foo'),
2285 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2286 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2287 ((['git', 'branch', '-D', 'foo'],), '')
2288 ]
2289
Edward Lemurda4b6c62020-02-13 00:28:40 +00002290 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002291 lambda branches, fine_grained, max_processes:
2292 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2293 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002294 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002295
2296 self.assertEqual(0, git_cl.main(['archive', '-f']))
2297
kmarshall3bff56b2016-06-06 18:31:47 -07002298 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002299 self.calls = [
2300 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2301 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002302 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002303 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2304 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002305
Edward Lemurda4b6c62020-02-13 00:28:40 +00002306 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002307 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002308 [(MockChangelistWithBranchAndIssue('master', 1),
2309 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002310
2311 self.assertEqual(1, git_cl.main(['archive', '-f']))
2312
2313 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002314 self.calls = [
2315 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2316 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002317 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002318 ((['git', 'symbolic-ref', 'HEAD'],), 'master')
2319 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002320
Edward Lemurda4b6c62020-02-13 00:28:40 +00002321 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002322 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002323 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2324 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002325 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002326
kmarshall9249e012016-08-23 12:02:16 -07002327 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2328
2329 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002330 self.calls = [
2331 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2332 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002333 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002334 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2335 ((['git', 'branch', '-D', 'foo'],), '')
2336 ]
kmarshall9249e012016-08-23 12:02:16 -07002337
Edward Lemurda4b6c62020-02-13 00:28:40 +00002338 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002339 lambda branches, fine_grained, max_processes:
2340 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2341 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002342 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002343
2344 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002345
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002346 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002347 self.calls = [
2348 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2349 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2350 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
2351 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2352 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2353 'refs/tags/git-cl-archived-456-foo'),
2354 ((['git', 'branch', '-D', 'foo'],), CERR1),
2355 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2356 'refs/tags/git-cl-archived-456-foo'),
2357 ]
2358
Edward Lemurda4b6c62020-02-13 00:28:40 +00002359 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002360 lambda branches, fine_grained, max_processes:
2361 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2362 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002363 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002364
2365 self.assertEqual(0, git_cl.main(['archive', '-f']))
2366
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002367 def test_cmd_issue_erase_existing(self):
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002368 self.calls = [
2369 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002370 # Let this command raise exception (retcode=1) - it should be ignored.
2371 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002372 CERR1),
2373 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2374 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002375 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2376 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2377 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002378 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002379 ]
2380 self.assertEqual(0, git_cl.main(['issue', '0']))
2381
Aaron Gable400e9892017-07-12 15:31:21 -07002382 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002383 mock.patch('git_cl.Changelist.FetchDescription',
2384 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002385 self.calls = [
2386 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002387 # Let this command raise exception (retcode=1) - it should be ignored.
2388 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2389 CERR1),
2390 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2391 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2392 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2393 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2394 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002395 ((['git', 'log', '-1', '--format=%B'],),
2396 'This is a description\n\nChange-Id: Ideadbeef'),
2397 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002398 ]
2399 self.assertEqual(0, git_cl.main(['issue', '0']))
2400
phajdan.jre328cf92016-08-22 04:12:17 -07002401 def test_cmd_issue_json(self):
phajdan.jre328cf92016-08-22 04:12:17 -07002402 self.calls = [
2403 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002404 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2405 ((['git', 'config', 'branch.feature.gerritserver'],),
2406 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002407 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002408 {'issue': 123,
2409 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002410 ''),
2411 ]
2412 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2413
tandrii16e0b4e2016-06-07 10:34:28 -07002414 def _common_GerritCommitMsgHookCheck(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002415 mock.patch('git_cl.os.path.abspath',
2416 lambda path: self._mocked_call(['abspath', path])).start()
2417 mock.patch('git_cl.os.path.exists',
2418 lambda path: self._mocked_call(['exists', path])).start()
2419 mock.patch('git_cl.gclient_utils.FileRead',
2420 lambda path: self._mocked_call(['FileRead', path])).start()
2421 mock.patch('git_cl.gclient_utils.rm_file_or_tree',
2422 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
tandrii16e0b4e2016-06-07 10:34:28 -07002423 self.calls = [
2424 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2425 ((['abspath', '../'],), '/abs/git_repo_root'),
2426 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002427 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002428
2429 def test_GerritCommitMsgHookCheck_custom_hook(self):
2430 cl = self._common_GerritCommitMsgHookCheck()
2431 self.calls += [
2432 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2433 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2434 '#!/bin/sh\necho "custom hook"')
2435 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002436 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002437
2438 def test_GerritCommitMsgHookCheck_not_exists(self):
2439 cl = self._common_GerritCommitMsgHookCheck()
2440 self.calls += [
2441 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2442 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002443 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002444
2445 def test_GerritCommitMsgHookCheck(self):
2446 cl = self._common_GerritCommitMsgHookCheck()
2447 self.calls += [
2448 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2449 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2450 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002451 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002452 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2453 ''),
2454 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002455 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002456
tandriic4344b52016-08-29 06:04:54 -07002457 def test_GerritCmdLand(self):
2458 self.calls += [
2459 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2460 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2461 'deadbeaf'),
2462 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2463 ((['git', 'config', 'branch.feature.gerritserver'],),
2464 'chromium-review.googlesource.com'),
2465 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002466 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002467 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002468 'labels': {},
2469 'current_revision': 'deadbeaf',
2470 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002471 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002472 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002473 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002474 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2475 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002476 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002477 self.assertEqual(0, cl.CMDLand(force=True,
2478 bypass_hooks=True,
2479 verbose=True,
2480 parallel=False))
Edward Lemur73c76702020-02-06 23:57:18 +00002481 self.assertIn(
2482 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002483 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002484 self.assertIn(
2485 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002486 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002487
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002488 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002489 mock.patch('git_cl.Changelist._GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002490
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002491 def test_gerrit_change_detail_cache_simple(self):
2492 self._mock_gerrit_changes_for_detail_cache()
2493 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002494 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2495 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2496 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002497 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002498 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002499 cl1._cached_remote_url = (
2500 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002501 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002502 cl2._cached_remote_url = (
2503 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002504 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2505 self.assertEqual(cl1._GetChangeDetail(), 'a')
2506 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2507 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2508 self.assertEqual(cl1._GetChangeDetail(), 'a')
2509 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002510
2511 def test_gerrit_change_detail_cache_options(self):
2512 self._mock_gerrit_changes_for_detail_cache()
2513 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002514 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2515 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2516 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2517 # no longer in cache.
2518 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002519 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002520 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002521 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002522 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2523 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2524 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2525 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2526 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2527 self.assertEqual(cl._GetChangeDetail(), 'cab')
2528
2529 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2530 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2531 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2532 self.assertEqual(cl._GetChangeDetail(), 'cab')
2533
2534 # Finally, no_cache should invalidate all caches for given change.
2535 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2536 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2537
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002538 def test_gerrit_description_caching(self):
2539 def gen_detail(rev, desc):
2540 return {
2541 'current_revision': rev,
2542 'revisions': {rev: {'commit': {'message': desc}}}
2543 }
2544 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002545 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002546 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2547 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002548 ]
2549
2550 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002551 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002552 cl._cached_remote_url = (
2553 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002554 self.assertEqual(cl.FetchDescription(), 'desc1')
2555 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002556
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002557 def test_print_current_creds(self):
2558 class CookiesAuthenticatorMock(object):
2559 def __init__(self):
2560 self.gitcookies = {
2561 'host.googlesource.com': ('user', 'pass'),
2562 'host-review.googlesource.com': ('user', 'pass'),
2563 }
2564 self.netrc = self
2565 self.netrc.hosts = {
2566 'github.com': ('user2', None, 'pass2'),
2567 'host2.googlesource.com': ('user3', None, 'pass'),
2568 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002569 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2570 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002571 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2572 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2573 ' Host\t User\t Which file',
2574 '============================\t=====\t===========',
2575 'host-review.googlesource.com\t user\t.gitcookies',
2576 ' host.googlesource.com\t user\t.gitcookies',
2577 ' host2.googlesource.com\tuser3\t .netrc',
2578 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002579 sys.stdout.seek(0)
2580 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002581 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2582 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2583 ' Host\tUser\t Which file',
2584 '============================\t====\t===========',
2585 'host-review.googlesource.com\tuser\t.gitcookies',
2586 ' host.googlesource.com\tuser\t.gitcookies',
2587 ])
2588
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002589 def _common_creds_check_mocks(self):
2590 def exists_mock(path):
2591 dirname = os.path.dirname(path)
2592 if dirname == os.path.expanduser('~'):
2593 dirname = '~'
2594 base = os.path.basename(path)
2595 if base in ('.netrc', '.gitcookies'):
2596 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2597 # git cl also checks for existence other files not relevant to this test.
2598 return None
Edward Lemurda4b6c62020-02-13 00:28:40 +00002599 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002600
2601 def test_creds_check_gitcookies_not_configured(self):
2602 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002603 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2604 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002605 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002606 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002607 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2608 (('os.path.exists', '~/.netrc'), True),
2609 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2610 'or Ctrl+C to abort'), ''),
2611 ((['git', 'config', '--global', 'http.cookiefile',
2612 os.path.expanduser('~/.gitcookies')], ), ''),
2613 ]
2614 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002615 self.assertTrue(
2616 sys.stdout.getvalue().startswith(
2617 'You seem to be using outdated .netrc for git credentials:'))
2618 self.assertIn(
2619 '\nConfigured git to use .gitcookies from',
2620 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002621
2622 def test_creds_check_gitcookies_configured_custom_broken(self):
2623 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002624 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2625 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002626 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002627 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002628 ((['git', 'config', '--global', 'http.cookiefile'],),
2629 '/custom/.gitcookies'),
2630 (('os.path.exists', '/custom/.gitcookies'), False),
2631 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2632 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2633 ((['git', 'config', '--global', 'http.cookiefile',
2634 os.path.expanduser('~/.gitcookies')], ), ''),
2635 ]
2636 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002637 self.assertIn(
2638 'WARNING: You have configured custom path to .gitcookies: ',
2639 sys.stdout.getvalue())
2640 self.assertIn(
2641 'However, your configured .gitcookies file is missing.',
2642 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002643
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002644 def test_git_cl_comment_add_gerrit(self):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002645 self.calls = [
2646 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2647 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2648 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2649 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2650 'origin/master'),
2651 ((['git', 'config', 'remote.origin.url'],),
2652 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002653 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002654 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002655 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002656 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002657 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002658
Edward Lemurda4b6c62020-02-13 00:28:40 +00002659 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2660 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002661 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002662 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2663 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002664 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2665 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2666 'origin/master'),
2667 ((['git', 'config', 'remote.origin.url'],),
2668 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002669 (('GetChangeDetail', 'chromium-review.googlesource.com',
2670 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002671 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2672 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002673 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002674 'current_revision': 'ba5eba11',
2675 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002676 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002677 '_number': 1,
2678 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002679 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002680 '_number': 2,
2681 },
2682 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002683 'messages': [
2684 {
2685 u'_revision_number': 1,
2686 u'author': {
2687 u'_account_id': 1111084,
2688 u'email': u'commit-bot@chromium.org',
2689 u'name': u'Commit Bot'
2690 },
2691 u'date': u'2017-03-15 20:08:45.000000000',
2692 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002693 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002694 u'tag': u'autogenerated:cq:dry-run'
2695 },
2696 {
2697 u'_revision_number': 2,
2698 u'author': {
2699 u'_account_id': 11151243,
2700 u'email': u'owner@example.com',
2701 u'name': u'owner'
2702 },
2703 u'date': u'2017-03-16 20:00:41.000000000',
2704 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2705 u'message': u'PTAL',
2706 },
2707 {
2708 u'_revision_number': 2,
2709 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002710 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002711 u'email': u'reviewer@example.com',
2712 u'name': u'reviewer'
2713 },
2714 u'date': u'2017-03-17 05:19:37.500000000',
2715 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2716 u'message': u'Patch Set 2: Code-Review+1',
2717 },
2718 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002719 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002720 (('GetChangeComments', 'chromium-review.googlesource.com',
2721 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002722 '/COMMIT_MSG': [
2723 {
2724 'author': {'email': u'reviewer@example.com'},
2725 'updated': u'2017-03-17 05:19:37.500000000',
2726 'patch_set': 2,
2727 'side': 'REVISION',
2728 'message': 'Please include a bug link',
2729 },
2730 ],
2731 'codereview.settings': [
2732 {
2733 'author': {'email': u'owner@example.com'},
2734 'updated': u'2017-03-16 20:00:41.000000000',
2735 'patch_set': 2,
2736 'side': 'PARENT',
2737 'line': 42,
2738 'message': 'I removed this because it is bad',
2739 },
2740 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002741 }),
2742 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2743 'infra%2Finfra~1'), {}),
2744 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002745 ] * 2 + [
2746 (('write_json', 'output.json', [
2747 {
2748 u'date': u'2017-03-16 20:00:41.000000',
2749 u'message': (
2750 u'PTAL\n' +
2751 u'\n' +
2752 u'codereview.settings\n' +
2753 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2754 u'c/1/2/codereview.settings#b42\n' +
2755 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002756 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002757 u'approval': False,
2758 u'disapproval': False,
2759 u'sender': u'owner@example.com'
2760 }, {
2761 u'date': u'2017-03-17 05:19:37.500000',
2762 u'message': (
2763 u'Patch Set 2: Code-Review+1\n' +
2764 u'\n' +
2765 u'/COMMIT_MSG\n' +
2766 u' PS2, File comment: https://chromium-review.googlesource' +
2767 u'.com/c/1/2//COMMIT_MSG#\n' +
2768 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002769 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002770 u'approval': False,
2771 u'disapproval': False,
2772 u'sender': u'reviewer@example.com'
2773 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002774 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002775 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002776 expected_comments_summary = [
2777 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002778 message=(
2779 u'PTAL\n' +
2780 u'\n' +
2781 u'codereview.settings\n' +
2782 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2783 u'c/1/2/codereview.settings#b42\n' +
2784 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002785 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002786 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002787 disapproval=False, approval=False, sender=u'owner@example.com'),
2788 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002789 message=(
2790 u'Patch Set 2: Code-Review+1\n' +
2791 u'\n' +
2792 u'/COMMIT_MSG\n' +
2793 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2794 u'c/1/2//COMMIT_MSG#\n' +
2795 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002796 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002797 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002798 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2799 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002800 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002801 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002802 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002803 self.assertEqual(
2804 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2805
2806 def test_git_cl_comments_robot_comments(self):
2807 # git cl comments also fetches robot comments (which are considered a type
2808 # of autogenerated comment), and unlike other types of comments, only robot
2809 # comments from the latest patchset are shown.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002810 self.calls = [
2811 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2812 ((['git', 'config', 'branch.foo.merge'],), ''),
2813 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2814 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2815 'origin/master'),
2816 ((['git', 'config', 'remote.origin.url'],),
2817 'https://chromium.googlesource.com/infra/infra'),
2818 (('GetChangeDetail', 'chromium-review.googlesource.com',
2819 'infra%2Finfra~1',
2820 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2821 'CURRENT_COMMIT']), {
2822 'owner': {'email': 'owner@example.com'},
2823 'current_revision': 'ba5eba11',
2824 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002825 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002826 '_number': 1,
2827 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002828 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002829 '_number': 2,
2830 },
2831 },
2832 'messages': [
2833 {
2834 u'_revision_number': 1,
2835 u'author': {
2836 u'_account_id': 1111084,
2837 u'email': u'commit-bot@chromium.org',
2838 u'name': u'Commit Bot'
2839 },
2840 u'date': u'2017-03-15 20:08:45.000000000',
2841 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2842 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2843 u'tag': u'autogenerated:cq:dry-run'
2844 },
2845 {
2846 u'_revision_number': 1,
2847 u'author': {
2848 u'_account_id': 123,
2849 u'email': u'tricium@serviceaccount.com',
2850 u'name': u'Tricium'
2851 },
2852 u'date': u'2017-03-16 20:00:41.000000000',
2853 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2854 u'message': u'(1 comment)',
2855 u'tag': u'autogenerated:tricium',
2856 },
2857 {
2858 u'_revision_number': 1,
2859 u'author': {
2860 u'_account_id': 123,
2861 u'email': u'tricium@serviceaccount.com',
2862 u'name': u'Tricium'
2863 },
2864 u'date': u'2017-03-16 20:00:41.000000000',
2865 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2866 u'message': u'(1 comment)',
2867 u'tag': u'autogenerated:tricium',
2868 },
2869 {
2870 u'_revision_number': 2,
2871 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002872 u'_account_id': 123,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002873 u'email': u'tricium@serviceaccount.com',
2874 u'name': u'reviewer'
2875 },
2876 u'date': u'2017-03-17 05:30:37.000000000',
2877 u'tag': u'autogenerated:tricium',
2878 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2879 u'message': u'(1 comment)',
2880 },
2881 ]
2882 }),
2883 (('GetChangeComments', 'chromium-review.googlesource.com',
2884 'infra%2Finfra~1'), {}),
2885 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2886 'infra%2Finfra~1'), {
2887 'codereview.settings': [
2888 {
2889 u'author': {u'email': u'tricium@serviceaccount.com'},
2890 u'updated': u'2017-03-17 05:30:37.000000000',
2891 u'robot_run_id': u'5565031076855808',
2892 u'robot_id': u'Linter/Category',
2893 u'tag': u'autogenerated:tricium',
2894 u'patch_set': 2,
2895 u'side': u'REVISION',
2896 u'message': u'Linter warning message text',
2897 u'line': 32,
2898 },
2899 ],
2900 }),
2901 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
2902 ]
2903 expected_comments_summary = [
2904 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2905 message=(
2906 u'(1 comment)\n\ncodereview.settings\n'
2907 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2908 u'c/1/2/codereview.settings#32\n'
2909 u' Linter warning message text\n'),
2910 sender=u'tricium@serviceaccount.com',
2911 autogenerated=True, approval=False, disapproval=False)
2912 ]
2913 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002914 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002915 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002916
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002917 def test_get_remote_url_with_mirror(self):
2918 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002919
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002920 def selective_os_path_isdir_mock(path):
2921 if path == '/cache/this-dir-exists':
2922 return self._mocked_call('os.path.isdir', path)
2923 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002924
Edward Lemurda4b6c62020-02-13 00:28:40 +00002925 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002926
2927 url = 'https://chromium.googlesource.com/my/repo'
2928 self.calls = [
2929 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2930 ((['git', 'config', 'branch.master.merge'],), 'master'),
2931 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2932 ((['git', 'config', 'remote.origin.url'],),
2933 '/cache/this-dir-exists'),
2934 (('os.path.isdir', '/cache/this-dir-exists'),
2935 True),
2936 # Runs in /cache/this-dir-exists.
2937 ((['git', 'config', 'remote.origin.url'],),
2938 url),
2939 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002940 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002941 self.assertEqual(cl.GetRemoteUrl(), url)
2942 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2943
Edward Lemur298f2cf2019-02-22 21:40:39 +00002944 def test_get_remote_url_non_existing_mirror(self):
2945 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002946
Edward Lemur298f2cf2019-02-22 21:40:39 +00002947 def selective_os_path_isdir_mock(path):
2948 if path == '/cache/this-dir-doesnt-exist':
2949 return self._mocked_call('os.path.isdir', path)
2950 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002951
Edward Lemurda4b6c62020-02-13 00:28:40 +00002952 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2953 mock.patch('logging.error',
2954 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002955
2956 self.calls = [
2957 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2958 ((['git', 'config', 'branch.master.merge'],), 'master'),
2959 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2960 ((['git', 'config', 'remote.origin.url'],),
2961 '/cache/this-dir-doesnt-exist'),
2962 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2963 False),
2964 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002965 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2966 'but it doesn\'t exist.', {
2967 'remote': 'origin',
2968 'branch': 'master',
2969 'url': '/cache/this-dir-doesnt-exist'}
2970 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002971 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002972 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002973 self.assertIsNone(cl.GetRemoteUrl())
2974
2975 def test_get_remote_url_misconfigured_mirror(self):
2976 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002977
Edward Lemur298f2cf2019-02-22 21:40:39 +00002978 def selective_os_path_isdir_mock(path):
2979 if path == '/cache/this-dir-exists':
2980 return self._mocked_call('os.path.isdir', path)
2981 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002982
Edward Lemurda4b6c62020-02-13 00:28:40 +00002983 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2984 mock.patch('logging.error',
2985 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002986
2987 self.calls = [
2988 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2989 ((['git', 'config', 'branch.master.merge'],), 'master'),
2990 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2991 ((['git', 'config', 'remote.origin.url'],),
2992 '/cache/this-dir-exists'),
2993 (('os.path.isdir', '/cache/this-dir-exists'), True),
2994 # Runs in /cache/this-dir-exists.
2995 ((['git', 'config', 'remote.origin.url'],), ''),
2996 (('logging.error',
2997 'Remote "%(remote)s" for branch "%(branch)s" points to '
2998 '"%(cache_path)s", but it is misconfigured.\n'
2999 '"%(cache_path)s" must be a git repo and must have a remote named '
3000 '"%(remote)s" pointing to the git host.', {
3001 'remote': 'origin',
3002 'cache_path': '/cache/this-dir-exists',
3003 'branch': 'master'}
3004 ), None),
3005 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003006 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003007 self.assertIsNone(cl.GetRemoteUrl())
3008
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003009 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003010 self.calls = [
3011 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3012 ((['git', 'config', 'branch.master.merge'],), 'master'),
3013 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3014 ((['git', 'config', 'remote.origin.url'],),
3015 'https://chromium.googlesource.com/a/my/repo.git/'),
3016 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003017 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003018 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3019
3020 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00003021 mock.patch('logging.error',
3022 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00003023
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003024 self.calls = [
3025 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3026 ((['git', 'config', 'branch.master.merge'],), 'master'),
3027 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3028 ((['git', 'config', 'remote.origin.url'],), CERR1),
Josip906bfde2020-01-31 22:38:49 +00003029 (('logging.error',
3030 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
3031 'but it doesn\'t exist.', {
3032 'remote': 'origin',
3033 'branch': 'master',
3034 'url': ''}
3035 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003036 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003037 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003038 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003039
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003040
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003041class CMDTestCaseBase(unittest.TestCase):
3042 _STATUSES = [
3043 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3044 'INFRA_FAILURE', 'CANCELED',
3045 ]
3046 _CHANGE_DETAIL = {
3047 'project': 'depot_tools',
3048 'status': 'OPEN',
3049 'owner': {'email': 'owner@e.mail'},
3050 'current_revision': 'beeeeeef',
3051 'revisions': {
3052 'deadbeaf': {'_number': 6},
3053 'beeeeeef': {
3054 '_number': 7,
3055 'fetch': {'http': {
3056 'url': 'https://chromium.googlesource.com/depot_tools',
3057 'ref': 'refs/changes/56/123456/7'
3058 }},
3059 },
3060 },
3061 }
3062 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003063 'builds': [{
3064 'id': str(100 + idx),
3065 'builder': {
3066 'project': 'chromium',
3067 'bucket': 'try',
3068 'builder': 'bot_' + status.lower(),
3069 },
3070 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3071 'tags': [],
3072 'status': status,
3073 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003074 }
3075
Edward Lemur4c707a22019-09-24 21:13:43 +00003076 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003077 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003078 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003079 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3080 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003081 mock.patch('git_cl.Changelist.GetCodereviewServer',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003082 return_value='https://chromium-review.googlesource.com').start()
3083 mock.patch('git_cl.Changelist.GetMostRecentPatchset',
3084 return_value=7).start()
Edward Lemur5b929a42019-10-21 17:57:39 +00003085 mock.patch('git_cl.auth.Authenticator',
Edward Lemurb4a587d2019-10-09 23:56:38 +00003086 return_value=AuthenticatorMock()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003087 mock.patch('git_cl.Changelist._GetChangeDetail',
3088 return_value=self._CHANGE_DETAIL).start()
3089 mock.patch('git_cl._call_buildbucket',
3090 return_value = self._DEFAULT_RESPONSE).start()
3091 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003092 self.addCleanup(mock.patch.stopall)
3093
Edward Lemur4c707a22019-09-24 21:13:43 +00003094
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003095class CMDTryResultsTestCase(CMDTestCaseBase):
3096 _DEFAULT_REQUEST = {
3097 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003098 "gerritChanges": [{
3099 "project": "depot_tools",
3100 "host": "chromium-review.googlesource.com",
3101 "patchset": 7,
3102 "change": 123456,
3103 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003104 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003105 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3106 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003107 }
3108
3109 def testNoJobs(self):
3110 git_cl._call_buildbucket.return_value = {}
3111
3112 self.assertEqual(0, git_cl.main(['try-results']))
3113 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3114 git_cl._call_buildbucket.assert_called_once_with(
3115 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3116 self._DEFAULT_REQUEST)
3117
3118 def testPrintToStdout(self):
3119 self.assertEqual(0, git_cl.main(['try-results']))
3120 self.assertEqual([
3121 'Successes:',
3122 ' bot_success https://ci.chromium.org/b/103',
3123 'Infra Failures:',
3124 ' bot_infra_failure https://ci.chromium.org/b/105',
3125 'Failures:',
3126 ' bot_failure https://ci.chromium.org/b/104',
3127 'Canceled:',
3128 ' bot_canceled ',
3129 'Started:',
3130 ' bot_started https://ci.chromium.org/b/102',
3131 'Scheduled:',
3132 ' bot_scheduled id=101',
3133 'Other:',
3134 ' bot_status_unspecified id=100',
3135 'Total: 7 tryjobs',
3136 ], sys.stdout.getvalue().splitlines())
3137 git_cl._call_buildbucket.assert_called_once_with(
3138 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3139 self._DEFAULT_REQUEST)
3140
3141 def testPrintToStdoutWithMasters(self):
3142 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3143 self.assertEqual([
3144 'Successes:',
3145 ' try bot_success https://ci.chromium.org/b/103',
3146 'Infra Failures:',
3147 ' try bot_infra_failure https://ci.chromium.org/b/105',
3148 'Failures:',
3149 ' try bot_failure https://ci.chromium.org/b/104',
3150 'Canceled:',
3151 ' try bot_canceled ',
3152 'Started:',
3153 ' try bot_started https://ci.chromium.org/b/102',
3154 'Scheduled:',
3155 ' try bot_scheduled id=101',
3156 'Other:',
3157 ' try bot_status_unspecified id=100',
3158 'Total: 7 tryjobs',
3159 ], sys.stdout.getvalue().splitlines())
3160 git_cl._call_buildbucket.assert_called_once_with(
3161 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3162 self._DEFAULT_REQUEST)
3163
3164 @mock.patch('git_cl.write_json')
3165 def testWriteToJson(self, mockJsonDump):
3166 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3167 git_cl._call_buildbucket.assert_called_once_with(
3168 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3169 self._DEFAULT_REQUEST)
3170 mockJsonDump.assert_called_once_with(
3171 'file.json', self._DEFAULT_RESPONSE['builds'])
3172
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003173 def test_filter_failed_for_one_simple(self):
3174 self.assertEqual({}, git_cl._filter_failed_for_retry([]))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003175 self.assertEqual({
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003176 'chromium/try': {
3177 'bot_failure': [],
3178 'bot_infra_failure': []
3179 },
3180 }, git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
3181
3182 def test_filter_failed_for_retry_many_builds(self):
3183
3184 def _build(name, created_sec, status, experimental=False):
3185 assert 0 <= created_sec < 100, created_sec
3186 b = {
3187 'id': 112112,
3188 'builder': {
3189 'project': 'chromium',
3190 'bucket': 'try',
3191 'builder': name,
3192 },
3193 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3194 'status': status,
3195 'tags': [],
3196 }
3197 if experimental:
3198 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3199 return b
3200
3201 builds = [
3202 _build('flaky-last-green', 1, 'FAILURE'),
3203 _build('flaky-last-green', 2, 'SUCCESS'),
3204 _build('flaky', 1, 'SUCCESS'),
3205 _build('flaky', 2, 'FAILURE'),
3206 _build('running', 1, 'FAILED'),
3207 _build('running', 2, 'SCHEDULED'),
3208 _build('yep-still-running', 1, 'STARTED'),
3209 _build('yep-still-running', 2, 'FAILURE'),
3210 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3211 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3212
3213 # Simulate experimental in CQ builder, which developer decided
3214 # to retry manually which resulted in 2nd build non-experimental.
3215 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3216 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3217 ]
3218 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
3219 self.assertEqual({
3220 'chromium/try': {
3221 'flaky': [],
3222 'sometimes-experimental': []
3223 },
3224 }, git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003225
3226
3227class CMDTryTestCase(CMDTestCaseBase):
3228
3229 @mock.patch('git_cl.Changelist.SetCQState')
3230 @mock.patch('git_cl._get_bucket_map', return_value={})
3231 def testSetCQDryRunByDefault(self, _mockGetBucketMap, mockSetCQState):
3232 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003233 self.assertEqual(0, git_cl.main(['try']))
3234 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3235 self.assertEqual(
3236 sys.stdout.getvalue(),
3237 'Scheduling CQ dry run on: '
3238 'https://chromium-review.googlesource.com/123456\n')
3239
Edward Lemur4c707a22019-09-24 21:13:43 +00003240 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003241 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003242 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003243
3244 self.assertEqual(0, git_cl.main([
3245 'try', '-B', 'luci.chromium.try', '-b', 'win',
3246 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3247 self.assertIn(
3248 'Scheduling jobs on:\nBucket: luci.chromium.try',
3249 git_cl.sys.stdout.getvalue())
3250
3251 expected_request = {
3252 "requests": [{
3253 "scheduleBuild": {
3254 "requestId": "uuid4",
3255 "builder": {
3256 "project": "chromium",
3257 "builder": "win",
3258 "bucket": "try",
3259 },
3260 "gerritChanges": [{
3261 "project": "depot_tools",
3262 "host": "chromium-review.googlesource.com",
3263 "patchset": 7,
3264 "change": 123456,
3265 }],
3266 "properties": {
3267 "category": "git_cl_try",
3268 "json": [{"a": 1}, None],
3269 "key": "val",
3270 },
3271 "tags": [
3272 {"value": "win", "key": "builder"},
3273 {"value": "git_cl_try", "key": "user_agent"},
3274 ],
3275 },
3276 }],
3277 }
3278 mockCallBuildbucket.assert_called_with(
3279 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3280
Anthony Polito1a5fe232020-01-24 23:17:52 +00003281 @mock.patch('git_cl._call_buildbucket')
3282 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3283 mockCallBuildbucket.return_value = {}
3284
3285 self.assertEqual(0, git_cl.main([
3286 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3287 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3288 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3289 self.assertIn(
3290 'Scheduling jobs on:\nBucket: luci.chromium.try',
3291 git_cl.sys.stdout.getvalue())
3292
3293 expected_request = {
3294 "requests": [{
3295 "scheduleBuild": {
3296 "requestId": "uuid4",
3297 "builder": {
3298 "project": "chromium",
3299 "builder": "linux",
3300 "bucket": "try",
3301 },
3302 "gerritChanges": [{
3303 "project": "depot_tools",
3304 "host": "chromium-review.googlesource.com",
3305 "patchset": 7,
3306 "change": 123456,
3307 }],
3308 "properties": {
3309 "category": "git_cl_try",
3310 "json": [{"a": 1}, None],
3311 "key": "val",
3312 },
3313 "tags": [
3314 {"value": "linux", "key": "builder"},
3315 {"value": "git_cl_try", "key": "user_agent"},
3316 ],
3317 "gitilesCommit": {
3318 "host": "chromium-review.googlesource.com",
3319 "project": "depot_tools",
3320 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3321 }
3322 },
3323 },
3324 {
3325 "scheduleBuild": {
3326 "requestId": "uuid4",
3327 "builder": {
3328 "project": "chromium",
3329 "builder": "win",
3330 "bucket": "try",
3331 },
3332 "gerritChanges": [{
3333 "project": "depot_tools",
3334 "host": "chromium-review.googlesource.com",
3335 "patchset": 7,
3336 "change": 123456,
3337 }],
3338 "properties": {
3339 "category": "git_cl_try",
3340 "json": [{"a": 1}, None],
3341 "key": "val",
3342 },
3343 "tags": [
3344 {"value": "win", "key": "builder"},
3345 {"value": "git_cl_try", "key": "user_agent"},
3346 ],
3347 "gitilesCommit": {
3348 "host": "chromium-review.googlesource.com",
3349 "project": "depot_tools",
3350 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3351 }
3352 },
3353 }],
3354 }
3355 mockCallBuildbucket.assert_called_with(
3356 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3357
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003358 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur4c707a22019-09-24 21:13:43 +00003359 self.assertEqual(0, git_cl.main([
3360 'try', '-B', 'not-a-bucket', '-b', 'win',
3361 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3362 self.assertIn(
3363 'WARNING Could not parse bucket "not-a-bucket". Skipping.',
3364 git_cl.sys.stdout.getvalue())
3365
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003366 @mock.patch('git_cl._call_buildbucket')
3367 @mock.patch('git_cl.fetch_try_jobs')
3368 def testScheduleOnBuildbucketRetryFailed(
3369 self, mockFetchTryJobs, mockCallBuildbucket):
3370
3371 git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: {
3372 7: [],
3373 6: [{
3374 'id': 112112,
3375 'builder': {
3376 'project': 'chromium',
3377 'bucket': 'try',
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003378 'builder': 'linux',},
3379 'createTime': '2019-10-09T08:00:01.854286Z',
3380 'tags': [],
3381 'status': 'FAILURE',}],}[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003382 mockCallBuildbucket.return_value = {}
3383
3384 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3385 self.assertIn(
3386 'Scheduling jobs on:\nBucket: chromium/try',
3387 git_cl.sys.stdout.getvalue())
3388
3389 expected_request = {
3390 "requests": [{
3391 "scheduleBuild": {
3392 "requestId": "uuid4",
3393 "builder": {
3394 "project": "chromium",
3395 "bucket": "try",
3396 "builder": "linux",
3397 },
3398 "gerritChanges": [{
3399 "project": "depot_tools",
3400 "host": "chromium-review.googlesource.com",
3401 "patchset": 7,
3402 "change": 123456,
3403 }],
3404 "properties": {
3405 "category": "git_cl_try",
3406 },
3407 "tags": [
3408 {"value": "linux", "key": "builder"},
3409 {"value": "git_cl_try", "key": "user_agent"},
3410 {"value": "1", "key": "retry_failed"},
3411 ],
3412 },
3413 }],
3414 }
3415 mockCallBuildbucket.assert_called_with(
3416 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3417
Edward Lemur4c707a22019-09-24 21:13:43 +00003418 def test_parse_bucket(self):
3419 test_cases = [
3420 {
3421 'bucket': 'chromium/try',
3422 'result': ('chromium', 'try'),
3423 },
3424 {
3425 'bucket': 'luci.chromium.try',
3426 'result': ('chromium', 'try'),
3427 'has_warning': True,
3428 },
3429 {
3430 'bucket': 'skia.primary',
3431 'result': ('skia', 'skia.primary'),
3432 'has_warning': True,
3433 },
3434 {
3435 'bucket': 'not-a-bucket',
3436 'result': (None, None),
3437 },
3438 ]
3439
3440 for test_case in test_cases:
3441 git_cl.sys.stdout.truncate(0)
3442 self.assertEqual(
3443 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3444 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003445 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3446 test_case['result'])
3447 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003448
3449
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003450class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003451 def setUp(self):
3452 super(CMDUploadTestCase, self).setUp()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003453 mock.patch('git_cl.fetch_try_jobs').start()
3454 mock.patch('git_cl._trigger_try_jobs', return_value={}).start()
3455 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Anthony Polito46689b02019-11-15 20:56:41 +00003456 mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003457 self.addCleanup(mock.patch.stopall)
3458
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003459 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003460 # This test mocks out the actual upload part, and just asserts that after
3461 # upload, if --retry-failed is added, then the tool will fetch try jobs
3462 # from the previous patchset and trigger the right builders on the latest
3463 # patchset.
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003464 git_cl.fetch_try_jobs.side_effect = [
3465 # Latest patchset: No builds.
3466 [],
3467 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003468 [{
3469 'id': str(100 + idx),
3470 'builder': {
3471 'project': 'chromium',
3472 'bucket': 'try',
3473 'builder': 'bot_' + status.lower(),
3474 },
3475 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3476 'tags': [],
3477 'status': status,
3478 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003479 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003480
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003481 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003482 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003483 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3484 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003485 ], git_cl.fetch_try_jobs.mock_calls)
3486 expected_buckets = {
3487 'chromium/try': {'bot_failure': [], 'bot_infra_failure': []},
3488 }
3489 git_cl._trigger_try_jobs.assert_called_once_with(
Edward Lemur5b929a42019-10-21 17:57:39 +00003490 mock.ANY, expected_buckets, mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003491
Brian Sheedy59b06a82019-10-14 17:03:29 +00003492
Edward Lemurda4b6c62020-02-13 00:28:40 +00003493class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003494
3495 def setUp(self):
3496 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003497 mock.patch('git_cl.RunCommand').start()
3498 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3499 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3500 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003501 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003502 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003503
3504 def tearDown(self):
3505 shutil.rmtree(self._top_dir)
3506 super(CMDFormatTestCase, self).tearDown()
3507
Jamie Madill5e96ad12020-01-13 16:08:35 +00003508 def _make_temp_file(self, fname, contents):
3509 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3510 tf.write('\n'.join(contents))
3511
Brian Sheedy59b06a82019-10-14 17:03:29 +00003512 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003513 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003514
Brian Sheedyb4307d52019-12-02 19:18:17 +00003515 def _check_yapf_filtering(self, files, expected):
3516 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3517 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003518
Jamie Madill5e96ad12020-01-13 16:08:35 +00003519 def testClangFormatDiffFull(self):
3520 self._make_temp_file('test.cc', ['// test'])
3521 git_cl.settings.GetFormatFullByDefault.return_value = False
3522 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3523 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3524
3525 # Diff
3526 git_cl.RunCommand.return_value = ' // test'
3527 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3528 self._top_dir, 'HEAD')
3529 self.assertEqual(2, return_value)
3530
3531 # No diff
3532 git_cl.RunCommand.return_value = '// test'
3533 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3534 self._top_dir, 'HEAD')
3535 self.assertEqual(0, return_value)
3536
3537 def testClangFormatDiff(self):
3538 git_cl.settings.GetFormatFullByDefault.return_value = False
3539 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3540
3541 # Diff
3542 git_cl.RunCommand.return_value = 'error'
3543 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3544 'HEAD')
3545 self.assertEqual(2, return_value)
3546
3547 # No diff
3548 git_cl.RunCommand.return_value = ''
3549 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3550 'HEAD')
3551 self.assertEqual(0, return_value)
3552
Brian Sheedyb4307d52019-12-02 19:18:17 +00003553 def testYapfignoreExplicit(self):
3554 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3555 files = [
3556 'bar.py',
3557 'foo/bar.py',
3558 'foo/baz.py',
3559 'foo/bar/baz.py',
3560 'foo/bar/foobar.py',
3561 ]
3562 expected = [
3563 'bar.py',
3564 'foo/baz.py',
3565 'foo/bar/foobar.py',
3566 ]
3567 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003568
Brian Sheedyb4307d52019-12-02 19:18:17 +00003569 def testYapfignoreSingleWildcards(self):
3570 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3571 files = [
3572 'bar.py', # Matched by *bar.py.
3573 'bar.txt',
3574 'foobar.py', # Matched by *bar.py, foo*.
3575 'foobar.txt', # Matched by foo*.
3576 'bazbar.py', # Matched by *bar.py, baz*.py.
3577 'bazbar.txt',
3578 'foo/baz.txt', # Matched by foo*.
3579 'bar/bar.py', # Matched by *bar.py.
3580 'baz/foo.py', # Matched by baz*.py, foo*.
3581 'baz/foo.txt',
3582 ]
3583 expected = [
3584 'bar.txt',
3585 'bazbar.txt',
3586 'baz/foo.txt',
3587 ]
3588 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003589
Brian Sheedyb4307d52019-12-02 19:18:17 +00003590 def testYapfignoreMultiplewildcards(self):
3591 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3592 files = [
3593 'bar.py', # Matched by *bar*.
3594 'bar.txt', # Matched by *bar*.
3595 'abar.py', # Matched by *bar*.
3596 'foobaz.txt', # Matched by *foo*baz.txt.
3597 'foobaz.py',
3598 'afoobaz.txt', # Matched by *foo*baz.txt.
3599 ]
3600 expected = [
3601 'foobaz.py',
3602 ]
3603 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003604
3605 def testYapfignoreComments(self):
3606 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003607 files = [
3608 'test.py',
3609 'test2.py',
3610 ]
3611 expected = [
3612 'test2.py',
3613 ]
3614 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003615
3616 def testYapfignoreBlankLines(self):
3617 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003618 files = [
3619 'test.py',
3620 'test2.py',
3621 'test3.py',
3622 ]
3623 expected = [
3624 'test3.py',
3625 ]
3626 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003627
3628 def testYapfignoreWhitespace(self):
3629 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003630 files = [
3631 'test.py',
3632 'test2.py',
3633 ]
3634 expected = [
3635 'test2.py',
3636 ]
3637 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003638
Brian Sheedyb4307d52019-12-02 19:18:17 +00003639 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003640 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003641 self._check_yapf_filtering([], [])
3642
3643 def testYapfignoreMissingYapfignore(self):
3644 files = [
3645 'test.py',
3646 ]
3647 expected = [
3648 'test.py',
3649 ]
3650 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003651
3652
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003653if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003654 logging.basicConfig(
3655 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003656 unittest.main()