blob: 6100f6eeeaeb6c24bc7f90aa2e118f502da22f64 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
34# We have to disable monitoring before importing git_cl.
35metrics.DISABLE_METRICS_COLLECTION = True
36
Jamie Madill5e96ad12020-01-13 16:08:35 +000037import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000038import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000039import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000040import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000041import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000042import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000043import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000044import git_new_branch
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +000045import owners_client
Edward Lemur85153282020-02-14 22:06:29 +000046import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000047import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000048
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000049NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
50
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000051
Edward Lemur0db01f02019-11-12 22:01:51 +000052def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070053 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
54
tandrii5d48c322016-08-18 16:19:37 -070055CERR1 = callError(1)
56
57
Edward Lemur1773f372020-02-22 00:27:14 +000058class TemporaryFileMock(object):
59 def __init__(self):
60 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070061
Edward Lemur1773f372020-02-22 00:27:14 +000062 @contextlib.contextmanager
63 def __call__(self):
64 self.suffix += 1
65 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070066
67
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000068class ChangelistMock(object):
69 # A class variable so we can access it when we don't have access to the
70 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000071 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000072
73 def __init__(self, gerrit_change=None, **kwargs):
74 self._gerrit_change = gerrit_change
75
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000076 def GetIssue(self):
77 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000078
Edward Lemur6c6827c2020-02-06 21:15:18 +000079 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000080 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000081
dsansomee2d6fd92016-09-08 00:10:47 -070082 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000083 ChangelistMock.desc = desc
84
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000085 def GetGerritChange(self, patchset=None, **kwargs):
86 del patchset
87 return self._gerrit_change
88
Josip Sokcevic9011a5b2021-02-12 18:59:44 +000089 def GetRemoteBranch(self):
90 return ('origin', 'refs/remotes/origin/main')
91
tandrii5d48c322016-08-18 16:19:37 -070092
Edward Lemur85153282020-02-14 22:06:29 +000093class GitMocks(object):
94 def __init__(self, config=None, branchref=None):
95 self.branchref = branchref or 'refs/heads/master'
96 self.config = config or {}
97
98 def GetBranchRef(self, _root):
99 return self.branchref
100
101 def NewBranch(self, branchref):
102 self.branchref = branchref
103
Edward Lemur26964072020-02-19 19:18:51 +0000104 def GetConfig(self, root, key, default=None):
105 if root != '':
106 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000107 return self.config.get(key, default)
108
Edward Lemur26964072020-02-19 19:18:51 +0000109 def SetConfig(self, root, key, value=None):
110 if root != '':
111 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000112 if value:
113 self.config[key] = value
114 return
115 if key not in self.config:
116 raise CERR1
117 del self.config[key]
118
119
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000120class WatchlistsMock(object):
121 def __init__(self, _):
122 pass
123 @staticmethod
124 def GetWatchersForPaths(_):
125 return ['joe@example.com']
126
127
Edward Lemur4c707a22019-09-24 21:13:43 +0000128class CodereviewSettingsFileMock(object):
129 def __init__(self):
130 pass
131 # pylint: disable=no-self-use
132 def read(self):
133 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
134 'GERRIT_HOST: True\n')
135
136
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000137class AuthenticatorMock(object):
138 def __init__(self, *_args):
139 pass
140 def has_cached_credentials(self):
141 return True
tandrii221ab252016-10-06 08:12:04 -0700142 def authorize(self, http):
143 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000144
145
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100146def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000147 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
148
149 Usage:
150 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100151 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000152
153 OR
154 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100155 CookiesAuthenticatorMockFactory(
156 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000157 """
158 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800159 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000160 # Intentionally not calling super() because it reads actual cookie files.
161 pass
162 @classmethod
163 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000164 return os.path.join('~', '.gitcookies')
165
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000166 @classmethod
167 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000168 return os.path.join('~', NETRC_FILENAME)
169
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100170 def _get_auth_for_host(self, host):
171 if same_auth:
172 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000173 return (hosts_with_creds or {}).get(host)
174 return CookiesAuthenticatorMock
175
Aaron Gable9a03ae02017-11-03 11:31:07 -0700176
kmarshall9249e012016-08-23 12:02:16 -0700177class MockChangelistWithBranchAndIssue():
178 def __init__(self, branch, issue):
179 self.branch = branch
180 self.issue = issue
181 def GetBranch(self):
182 return self.branch
183 def GetIssue(self):
184 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000185
tandriic2405f52016-10-10 08:13:15 -0700186
187class SystemExitMock(Exception):
188 pass
189
190
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000191class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000192 def setUp(self):
193 mock.patch('sys.exit', side_effect=SystemExitMock).start()
194 mock.patch('sys.stdout', StringIO()).start()
195 mock.patch('sys.stderr', StringIO()).start()
196 self.addCleanup(mock.patch.stopall)
197
198 def test_die_with_error(self):
199 with self.assertRaises(SystemExitMock):
200 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
201 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
202 self.assertTrue('saving CL description' in sys.stdout.getvalue())
203 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
204 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
205 sys.exit.assert_called_once_with(1)
206
207 def test_die_with_error_no_desc(self):
208 with self.assertRaises(SystemExitMock):
209 git_cl.DieWithError('foo')
210 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
211 self.assertEqual(sys.stdout.getvalue(), '')
212 sys.exit.assert_called_once_with(1)
213
Edward Lemur6c6827c2020-02-06 21:15:18 +0000214 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000215 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100216 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000217 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700218
Edward Lemur61bf4172020-02-24 23:22:37 +0000219 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
220 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
221 def test_get_cl_statuses(self, *_mocks):
222 statuses = [
223 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
224 changes = []
225 for status in statuses:
226 cl = git_cl.Changelist()
227 cl.status = status
228 changes.append(cl)
229
230 actual = set(git_cl.get_cl_statuses(changes, True))
231 self.assertEqual(set(zip(changes, statuses)), actual)
232
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000233 def test_upload_to_non_default_branch_no_retry(self):
234 m = mock.patch('git_cl.Changelist._CMDUploadChange',
235 side_effect=[git_cl.GitPushError(), None]).start()
236 mock.patch('git_cl.Changelist.GetRemoteBranch',
237 return_value=('foo', 'bar')).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000238 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000239 return_value='foo').start()
240 mock.patch('git_cl.gerrit_util.GetProjectHead',
241 return_value='refs/heads/main').start()
242
243 cl = git_cl.Changelist()
244 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000245 options.target_branch = 'refs/heads/bar'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000246 with self.assertRaises(SystemExitMock):
247 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
248
249 # ensure upload is called once
250 self.assertEqual(len(m.mock_calls), 1)
251 sys.exit.assert_called_once_with(1)
252 # option not set as retry didn't happen
253 self.assertFalse(hasattr(options, 'force'))
254 self.assertFalse(hasattr(options, 'edit_description'))
255
256 def test_upload_to_old_default_still_active(self):
257 m = mock.patch('git_cl.Changelist._CMDUploadChange',
258 side_effect=[git_cl.GitPushError(), None]).start()
259 mock.patch('git_cl.Changelist.GetRemoteBranch',
260 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000261 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000262 return_value='foo').start()
263 mock.patch('git_cl.gerrit_util.GetProjectHead',
Josip Sokcevicb631a882021-01-06 18:18:10 +0000264 return_value='refs/heads/master').start()
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000265
266 cl = git_cl.Changelist()
267 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000268 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000269 with self.assertRaises(SystemExitMock):
270 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
271
272 # ensure upload is called once
273 self.assertEqual(len(m.mock_calls), 1)
274 sys.exit.assert_called_once_with(1)
275 # option not set as retry didn't happen
276 self.assertFalse(hasattr(options, 'force'))
277 self.assertFalse(hasattr(options, 'edit_description'))
278
279 def test_upload_to_old_default_retry_on_failure(self):
280 m = mock.patch('git_cl.Changelist._CMDUploadChange',
281 side_effect=[git_cl.GitPushError(), None]).start()
282 mock.patch('git_cl.Changelist.GetRemoteBranch',
283 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000284 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000285 return_value='foo').start()
286 mock.patch('git_cl.gerrit_util.GetProjectHead',
287 return_value='refs/heads/main').start()
288 mock.patch('git_cl.RunGit').start()
289
290 cl = git_cl.Changelist()
291 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000292 options.target_branch = 'refs/heads/master'
293 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
294 # ensure upload is called twice
295 self.assertEqual(len(m.mock_calls), 2)
296 # option overrides on retry
297 self.assertEqual(options.force, True)
298 self.assertEqual(options.edit_description, False)
299
Gavin Mak68e6cf32021-01-25 18:24:08 +0000300 def test_upload_with_message_file_no_editor(self):
301 m = mock.patch('git_cl.ChangeDescription.prompt',
302 return_value=None).start()
303 mock.patch('git_cl.Changelist.GetRemoteBranch',
304 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
305 mock.patch('git_cl.GetTargetRef',
306 return_value='refs/heads/main').start()
307 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
308 lambda _, offer_removal: None).start()
309 mock.patch('git_cl.Changelist.GetIssue', return_value=None).start()
310 mock.patch('git_cl.Changelist.GetBranch',
311 side_effect=SystemExitMock).start()
312 mock.patch('git_cl.GenerateGerritChangeId', return_value=None).start()
313 mock.patch('git_cl.RunGit').start()
314
315 cl = git_cl.Changelist()
316 options = optparse.Values()
317 options.target_branch = 'refs/heads/master'
318 options.squash = True
319 options.edit_description = False
320 options.force = False
321 options.preserve_tryjobs = False
322 options.message_file = "message.txt"
323
324 with self.assertRaises(SystemExitMock):
325 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
326 self.assertEqual(len(m.mock_calls), 0)
327
328 options.message_file = None
329 with self.assertRaises(SystemExitMock):
330 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
331 self.assertEqual(len(m.mock_calls), 1)
332
Josip Sokcevicb631a882021-01-06 18:18:10 +0000333 def test_upload_to_old_default_retry_on_rollback(self):
334 """Test when default branch migration had to be rolled back to old name"""
335 m = mock.patch('git_cl.Changelist._CMDUploadChange',
336 side_effect=[git_cl.GitPushError(), None]).start()
337 mock.patch('git_cl.Changelist.GetRemoteBranch',
338 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
339 mock.patch('git_cl.Changelist.GetGerritProject',
340 return_value='foo').start()
341 mock.patch('git_cl.gerrit_util.GetProjectHead',
342 return_value='refs/heads/master').start()
343 # GetTargetRef returns new default branch since it has stale remote
344 # information.
345 mock.patch('git_cl.GetTargetRef',
346 return_value='refs/heads/main').start()
347 mock.patch('git_cl.RunGit').start()
348
349 cl = git_cl.Changelist()
350 options = optparse.Values()
351 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000352 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
353 # ensure upload is called twice
354 self.assertEqual(len(m.mock_calls), 2)
355 # option overrides on retry
356 self.assertEqual(options.force, True)
357 self.assertEqual(options.edit_description, False)
358
Edward Lemur61bf4172020-02-24 23:22:37 +0000359 def test_get_cl_statuses_no_changes(self):
360 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
361
362 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
363 @mock.patch('multiprocessing.pool.ThreadPool')
364 def test_get_cl_statuses_timeout(self, *_mocks):
365 changes = [git_cl.Changelist() for _ in range(2)]
366 pool = multiprocessing.pool.ThreadPool()
367 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
368 it.return_value.next.side_effect = [
369 (changes[0], 'lgtm'),
370 multiprocessing.TimeoutError,
371 ]
372
373 actual = list(git_cl.get_cl_statuses(changes, True))
374 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
375
376 @mock.patch('git_cl.Changelist.GetIssueURL')
377 def test_get_cl_statuses_not_finegrained(self, _mock):
378 changes = [git_cl.Changelist() for _ in range(2)]
379 urls = ['some-url', None]
380 git_cl.Changelist.GetIssueURL.side_effect = urls
381
382 actual = set(git_cl.get_cl_statuses(changes, False))
383 self.assertEqual(
384 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
385
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000386 def test_get_issue_url(self):
387 cl = git_cl.Changelist(issue=123)
388 cl._gerrit_server = 'https://example.com'
389 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
390 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
391
392 cl = git_cl.Changelist(issue=123)
393 cl._gerrit_server = 'https://chromium-review.googlesource.com'
394 self.assertEqual(cl.GetIssueURL(),
395 'https://chromium-review.googlesource.com/123')
396 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
397
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000398 def test_set_preserve_tryjobs(self):
399 d = git_cl.ChangeDescription('Simple.')
400 d.set_preserve_tryjobs()
401 self.assertEqual(d.description.splitlines(), [
402 'Simple.',
403 '',
404 'Cq-Do-Not-Cancel-Tryjobs: true',
405 ])
406 before = d.description
407 d.set_preserve_tryjobs()
408 self.assertEqual(before, d.description)
409
410 d = git_cl.ChangeDescription('\n'.join([
411 'One is enough',
412 '',
413 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
414 'Change-Id: Ideadbeef',
415 ]))
416 d.set_preserve_tryjobs()
417 self.assertEqual(d.description.splitlines(), [
418 'One is enough',
419 '',
420 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
421 'Change-Id: Ideadbeef',
422 'Cq-Do-Not-Cancel-Tryjobs: true',
423 ])
424
tandriif9aefb72016-07-01 09:06:51 -0700425 def test_get_bug_line_values(self):
426 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
427 self.assertEqual(f('', ''), [])
428 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
Lei Zhang8a0efc12020-08-05 19:58:45 +0000429 # Prefix that ends with colon.
430 self.assertEqual(f('v8:', '456'), ['v8:456'])
431 self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
432 # Prefix that ends without colon.
tandriif9aefb72016-07-01 09:06:51 -0700433 self.assertEqual(f('v8', '456'), ['v8:456'])
434 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
435 # Not nice, but not worth carying.
Lei Zhang8a0efc12020-08-05 19:58:45 +0000436 self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
437 ['v8:456', 'chromium:123', 'v8:123'])
tandriif9aefb72016-07-01 09:06:51 -0700438 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
439 ['v8:456', 'chromium:123', 'v8:123'])
440
Edward Lemurda4b6c62020-02-13 00:28:40 +0000441 @mock.patch('gerrit_util.GetAccountDetails')
442 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000443 mock_per_account = {
444 'u1': None, # 404, doesn't exist.
445 'u2': {
446 '_account_id': 123124,
447 'avatars': [],
448 'email': 'u2@example.com',
449 'name': 'User Number 2',
450 'status': 'OOO',
451 },
452 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
453 }
454 def GetAccountDetailsMock(_, account):
455 # Poor-man's mock library's side_effect.
456 v = mock_per_account.pop(account)
457 if isinstance(v, Exception):
458 raise v
459 return v
460
Edward Lemurda4b6c62020-02-13 00:28:40 +0000461 mockGetAccountDetails.side_effect = GetAccountDetailsMock
462 actual = git_cl.gerrit_util.ValidAccounts(
463 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000464 self.assertEqual(actual, {
465 'u2': {
466 '_account_id': 123124,
467 'avatars': [],
468 'email': 'u2@example.com',
469 'name': 'User Number 2',
470 'status': 'OOO',
471 },
472 })
473
474
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200475class TestParseIssueURL(unittest.TestCase):
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000476 def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
477 parsed = git_cl.ParseIssueNumberArgument(arg)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200478 self.assertIsNotNone(parsed)
479 if fail:
480 self.assertFalse(parsed.valid)
481 return
482 self.assertTrue(parsed.valid)
483 self.assertEqual(parsed.issue, issue)
484 self.assertEqual(parsed.patchset, patchset)
485 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200486
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000487 def test_basic(self):
488 self._test('123', 123)
489 self._test('', fail=True)
490 self._test('abc', fail=True)
491 self._test('123/1', fail=True)
492 self._test('123a', fail=True)
493 self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
494 self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200495
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000496 def test_gerrit_url(self):
497 self._test('https://codereview.source.com/123', 123, None,
498 'codereview.source.com')
499 self._test('http://chrome-review.source.com/c/123', 123, None,
500 'chrome-review.source.com')
501 self._test('https://chrome-review.source.com/c/123/', 123, None,
502 'chrome-review.source.com')
503 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
504 'chrome-review.source.com')
505 self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
506 'chrome-review.source.com')
507 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
508 'chrome-review.source.com')
509 self._test('https://chrome-review.source.com/123', 123, None,
510 'chrome-review.source.com')
511 self._test('https://chrome-review.source.com/123/4', 123, 4,
512 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200513
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000514 self._test('https://chrome-review.source.com/bad/123/4', fail=True)
515 self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
516 self._test('https://chrome-review.source.com/c/abc/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200517
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000518 def test_short_urls(self):
519 self._test('https://crrev.com/c/2151934', 2151934, None,
520 'chromium-review.googlesource.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200521
522
Edward Lemurda4b6c62020-02-13 00:28:40 +0000523class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100524 def setUp(self):
525 super(GitCookiesCheckerTest, self).setUp()
526 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100527 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000528 mock.patch('sys.stdout', StringIO()).start()
529 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100530
531 def mock_hosts_creds(self, subhost_identity_pairs):
532 def ensure_googlesource(h):
533 if not h.endswith(self.c._GOOGLESOURCE):
534 assert not h.endswith('.')
535 return h + '.' + self.c._GOOGLESOURCE
536 return h
537 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
538 for h, i in subhost_identity_pairs]
539
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200540 def test_identity_parsing(self):
541 self.assertEqual(self.c._parse_identity('ldap.google.com'),
542 ('ldap', 'google.com'))
543 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
544 ('ldap', 'example.com'))
545 # Specical case because we know there are no subdomains in chromium.org.
546 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
547 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800548 # Pathological: ".period." can be either username OR domain, more likely
549 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200550 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
551 ('note', 'period.example.com'))
552
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100553 def test_analysis_nothing(self):
554 self.c._all_hosts = []
555 self.assertFalse(self.c.has_generic_host())
556 self.assertEqual(set(), self.c.get_conflicting_hosts())
557 self.assertEqual(set(), self.c.get_duplicated_hosts())
558 self.assertEqual(set(), self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100559
560 def test_analysis(self):
561 self.mock_hosts_creds([
562 ('.googlesource.com', 'git-example.chromium.org'),
563
564 ('chromium', 'git-example.google.com'),
565 ('chromium-review', 'git-example.google.com'),
566 ('chrome-internal', 'git-example.chromium.org'),
567 ('chrome-internal-review', 'git-example.chromium.org'),
568 ('conflict', 'git-example.google.com'),
569 ('conflict-review', 'git-example.chromium.org'),
570 ('dup', 'git-example.google.com'),
571 ('dup', 'git-example.google.com'),
572 ('dup-review', 'git-example.google.com'),
573 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200574 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100575 ])
576 self.assertTrue(self.c.has_generic_host())
577 self.assertEqual(set(['conflict.googlesource.com']),
578 self.c.get_conflicting_hosts())
579 self.assertEqual(set(['dup.googlesource.com']),
580 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200581 self.assertEqual(set(['partial.googlesource.com',
582 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100583 self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100584
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100585 def test_report_no_problems(self):
586 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100587 self.assertFalse(self.c.find_and_report_problems())
588 self.assertEqual(sys.stdout.getvalue(), '')
589
Edward Lemurda4b6c62020-02-13 00:28:40 +0000590 @mock.patch(
591 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000592 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000593 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100594 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100595 self.assertTrue(self.c.find_and_report_problems())
596 with open(os.path.join(os.path.dirname(__file__),
597 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000598 expected = f.read() % {
599 'sep': os.sep,
600 }
601
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100602 def by_line(text):
603 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700604 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200605 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100606
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800607
Edward Lemurda4b6c62020-02-13 00:28:40 +0000608class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000609 def setUp(self):
610 super(TestGitCl, self).setUp()
611 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700612 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000613 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000614 mock.patch('sys.stdout', StringIO()).start()
615 mock.patch(
616 'git_cl.time_time',
617 lambda: self._mocked_call('time.time')).start()
618 mock.patch(
619 'git_cl.metrics.collector.add_repeated',
620 lambda *a: self._mocked_call('add_repeated', *a)).start()
621 mock.patch('subprocess2.call', self._mocked_call).start()
622 mock.patch('subprocess2.check_call', self._mocked_call).start()
623 mock.patch('subprocess2.check_output', self._mocked_call).start()
624 mock.patch(
625 'subprocess2.communicate',
626 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
627 mock.patch(
628 'git_cl.gclient_utils.CheckCallAndFilter',
629 self._mocked_call).start()
630 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000631 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
632 mock.patch(
633 'git_cl.SaveDescriptionBackup',
634 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
635 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000636 'git_cl.write_json',
637 lambda *a: self._mocked_call('write_json', *a)).start()
638 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000639 'git_cl.Changelist.RunHook',
640 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000641 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
642 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000643 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000644 mock.patch(
645 'git_cl.gerrit_util.GetChangeComments',
646 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
647 mock.patch(
648 'git_cl.gerrit_util.GetChangeRobotComments',
649 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
650 mock.patch(
651 'git_cl.gerrit_util.AddReviewers',
652 lambda *a: self._mocked_call('AddReviewers', *a)).start()
653 mock.patch(
654 'git_cl.gerrit_util.SetReview',
655 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
656 self._mocked_call(
657 'SetReview', h, i, msg, labels, notify, ready))).start()
658 mock.patch(
659 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
660 return_value=False).start()
661 mock.patch(
662 'git_cl.gerrit_util.GceAuthenticator.is_gce',
663 return_value=False).start()
664 mock.patch(
665 'git_cl.gerrit_util.ValidAccounts',
666 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000667 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000668 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000669 self.mockGit = GitMocks()
670 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
671 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
Edward Lesmes50da7702020-03-30 19:23:43 +0000672 mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
673 mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
Edward Lemur85153282020-02-14 22:06:29 +0000674 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000675 mock.patch(
676 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000677 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000678 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000679 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000680 mock.patch(
681 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000682 # It's important to reset settings to not have inter-tests interference.
683 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000684 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000685
686 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000687 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000688 if not self.failed:
689 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100690 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000691 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
692 if len(self.calls) > 5:
693 calls += ' ...\n'
694 self.fail(
695 '\n'
696 'There are un-consumed calls after this test has finished:\n' +
697 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000698 finally:
699 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000700
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000701 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000702 self.assertTrue(
703 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700704 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000705 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000706 expected_args, result = top
707
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000708 # Also logs otherwise it could get caught in a try/finally and be hard to
709 # diagnose.
710 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700711 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000712 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700713 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
714 for i, c in enumerate(self._calls_done[-N:]))
715 following_calls = '\n '.join(
716 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
717 for i, c in enumerate(self.calls[:N]))
718 extended_msg = (
719 'A few prior calls:\n %s\n\n'
720 'This (expected):\n @%d: %r\n'
721 'This (actual):\n @%d: %r\n\n'
722 'A few following expected calls:\n %s' %
723 (prior_calls, len(self._calls_done), expected_args,
724 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700725
Edward Lesmes0dd54822020-03-26 18:24:25 +0000726 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700727 self.fail('@%d\n'
728 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000729 ' Actual: %r\n'
730 '\n'
731 '%s' % (
732 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700733
734 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700735 if isinstance(result, Exception):
736 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000737 # stdout from git commands is supposed to be a bytestream. Convert it here
738 # instead of converting all test output in this file to bytes.
739 if args[0][0] == 'git' and not isinstance(result, bytes):
740 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000741 return result
742
Edward Lemur1a83da12020-03-04 21:18:36 +0000743 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
744 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100745 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100746 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000747 self.assertEqual(
748 'prompt [Yes/No]: Please, type yes or no: ',
749 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100750
tandrii48df5812016-10-17 03:55:37 -0700751 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000752 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700753 self.calls = [
754 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700755 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
756 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
757 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
758 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700759 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
760 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700761 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
762 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000763 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
764 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700765 ((['git', 'config', 'gerrit.host', 'true'],), ''),
766 ]
767 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
768
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000769 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100770 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200771 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000772 custom_cl_base=None, short_hostname='chromium',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000773 change_id=None, default_branch='master'):
Edward Lemur26964072020-02-19 19:18:51 +0000774 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200775 if custom_cl_base:
776 ancestor_revision = custom_cl_base
777 else:
778 # Determine ancestor_revision to be merge base.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000779 ancestor_revision = 'origin/' + default_branch
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200780
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100781 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000782 gerrit_util.GetChangeDetail.return_value = {
783 'owner': {'email': (other_cl_owner or 'owner@example.com')},
784 'change_id': (change_id or '123456789'),
785 'current_revision': 'sha1_of_current_revision',
786 'revisions': {'sha1_of_current_revision': {
787 'commit': {'message': fetched_description},
788 }},
789 'status': fetched_status or 'NEW',
790 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100791 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100792 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100793 if other_cl_owner:
794 calls += [
795 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
796 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100797
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100798 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200799 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
800 ([custom_cl_base] if custom_cl_base else
801 [ancestor_revision, 'HEAD']),),
802 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100803 ]
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000804 calls += [
805 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000806 '1' if default_branch == 'main' else callError(1)),
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000807 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000808
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100809 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000810
Edward Lemur26964072020-02-19 19:18:51 +0000811 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700812 squash_mode='default',
Aaron Gablefd238082017-06-07 13:42:34 -0700813 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100814 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000815 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000816 short_hostname='chromium',
Edward Lemur5a644f82020-03-18 16:44:57 +0000817 labels=None, change_id=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000818 final_description=None, gitcookies_exists=True,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000819 force=False, edit_description=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000820 default_branch='master'):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000821 if post_amend_description is None:
822 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700823 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200824
825 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000826
Edward Lesmes4de54132020-05-05 19:41:33 +0000827 if squash_mode in ('override_squash', 'override_nosquash'):
828 self.mockGit.config['gerrit.override-squash-uploads'] = (
829 'true' if squash_mode == 'override_squash' else 'false')
830
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000831 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000832 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200833 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200834 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000835 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000836 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000837 calls += [
838 ((['RunEditor'],), description),
839 ]
Josipe827b0f2020-01-30 00:07:20 +0000840 # user wants to edit description
841 if edit_description:
842 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000843 ((['RunEditor'],), edit_description),
844 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000845 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200846
847 if custom_cl_base is None:
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000848 parent = 'origin/' + default_branch
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000849 git_common.get_or_create_merge_base.return_value = parent
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200850 else:
851 calls += [
852 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000853 'refs/remotes/origin/' + default_branch],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200854 callError(1)), # Means not ancenstor.
855 (('ask_for_data',
856 'Do you take responsibility for cleaning up potential mess '
857 'resulting from proceeding with upload? Press Enter to upload, '
858 'or Ctrl+C to abort'), ''),
859 ]
860 parent = custom_cl_base
861
862 calls += [
863 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
864 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000865 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200866 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000867 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200868 ref_to_push),
869 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000870 else:
871 ref_to_push = 'HEAD'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000872 parent = 'origin/refs/heads/' + default_branch
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000873
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000874 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000875 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000876 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200877 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000878
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000879 metrics_arguments = []
880
Aaron Gableafd52772017-06-27 16:40:10 -0700881 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700882 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000883 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700884 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400885 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700886 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000887 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700888 else:
889 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000890 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800891
Edward Lemur5a644f82020-03-18 16:44:57 +0000892 # If issue is given, then description is fetched from Gerrit instead.
893 if issue is None:
894 if squash:
895 title = 'Initial upload'
896 else:
897 if not title:
898 calls += [
899 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
900 (('ask_for_data', 'Title for patchset []: '), 'User input'),
901 ]
902 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700903 if title:
Edward Lemur5a644f82020-03-18 16:44:57 +0000904 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000905 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000906
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000907 if short_hostname == 'chromium':
Quinten Yearsley925cedb2020-04-13 17:49:39 +0000908 # All reviewers and ccs get into ref_suffix.
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000909 for r in sorted(reviewers):
910 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000911 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000912 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000913 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000914 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000915 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000916 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000917 reviewers, cc = [], []
918 else:
919 # TODO(crbug/877717): remove this case.
920 calls += [
921 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
922 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000923 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000924 {
925 e: {'email': e}
926 for e in (reviewers + ['joe@example.com'] + cc)
927 })
928 ]
929 for r in sorted(reviewers):
930 if r != 'bad-account-or-email':
931 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000932 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000933 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000934 if issue is None:
935 cc += ['joe@example.com']
936 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000937 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000938 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000939 if c in cc:
940 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000941
Edward Lemur687ca902018-12-05 02:30:30 +0000942 for k, v in sorted((labels or {}).items()):
943 ref_suffix += ',l=%s+%d' % (k, v)
944 metrics_arguments.append('l=%s+%d' % (k, v))
945
946 if tbr:
947 calls += [
948 (('GetCodeReviewTbrScore',
949 '%s-review.googlesource.com' % short_hostname,
950 'my/repo'),
951 2,),
952 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000953
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000954 calls += [
955 (('time.time',), 1000,),
956 ((['git', 'push',
957 'https://%s.googlesource.com/my/repo' % short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000958 ref_to_push + ':refs/for/refs/heads/' + default_branch + ref_suffix],),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000959 (('remote:\n'
960 'remote: Processing changes: (\)\n'
961 'remote: Processing changes: (|)\n'
962 'remote: Processing changes: (/)\n'
963 'remote: Processing changes: (-)\n'
964 'remote: Processing changes: new: 1 (/)\n'
965 'remote: Processing changes: new: 1, done\n'
966 'remote:\n'
967 'remote: New Changes:\n'
968 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
969 ' XXX\n'
970 'remote:\n'
971 'To https://%s.googlesource.com/my/repo\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000972 ' * [new branch] hhhh -> refs/for/refs/heads/%s\n'
973 ) % (short_hostname, short_hostname, default_branch)),),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000974 (('time.time',), 2000,),
975 (('add_repeated',
976 'sub_commands',
977 {
978 'execution_time': 1000,
979 'command': 'git push',
980 'exit_code': 0,
981 'arguments': sorted(metrics_arguments),
982 }),
983 None,),
984 ]
985
Edward Lemur1b52d872019-05-09 21:12:12 +0000986 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000987
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000988 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
989
Edward Lemur1b52d872019-05-09 21:12:12 +0000990 # Trace-related calls
991 calls += [
992 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000993 (
994 ([
995 'FileWrite', trace_name + '-README',
996 '%(date)s\n'
997 '%(short_hostname)s-review.googlesource.com\n'
998 '%(change_id)s\n'
999 '%(title)s\n'
1000 '%(description)s\n'
1001 '1000\n'
1002 '0\n'
1003 '%(trace_name)s' % {
Josip Sokcevic5e18b602020-04-23 21:47:00 +00001004 'date': '2017-03-16T20:00:41.000000',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001005 'short_hostname': short_hostname,
1006 'change_id': change_id,
1007 'description': final_description,
1008 'title': title or '<untitled>',
1009 'trace_name': trace_name,
1010 }
1011 ], ),
1012 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001013 ),
1014 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001015 (
1016 (['os.path.isfile',
1017 os.path.join('TEMP_DIR', 'trace-packet')], ),
1018 True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001019 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001020 (
1021 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
1022 ('git-hash: 0123456789012345678901234567890123456789\n'
1023 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +00001024 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001025 (
1026 ([
1027 'FileWrite',
1028 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
1029 'git-hash: abcdea\n'
1030 ], ),
1031 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001032 ),
1033 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001034 (
1035 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
1036 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001037 ),
1038 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001039 (
1040 (['git', 'config', '-l'], ),
1041 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +00001042 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001043 (
1044 ([
1045 'FileWrite',
1046 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
1047 ], ),
1048 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001049 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001050 (
1051 (['os.path.isfile',
1052 os.path.join('~', '.gitcookies')], ),
1053 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +00001054 ),
1055 ]
1056 if gitcookies_exists:
1057 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001058 (
1059 (['FileRead', os.path.join('~', '.gitcookies')], ),
1060 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +00001061 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001062 (
1063 ([
1064 'FileWrite',
1065 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
1066 ], ),
1067 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001068 ),
1069 ]
1070 calls += [
1071 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001072 (
1073 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
1074 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001075 ),
1076 ]
1077
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001078 # TODO(crbug/877717): this should never be used.
1079 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001080 calls += [
1081 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001082 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001083 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001084 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001085 notify),
1086 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001087 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001088 return calls
1089
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001090 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001091 self,
1092 upload_args,
1093 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001094 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001095 squash=True,
1096 squash_mode=None,
Aaron Gable9b713dd2016-12-14 16:04:21 -08001097 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001098 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001099 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001100 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001101 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001102 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001103 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001104 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001105 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001106 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001107 labels=None,
1108 change_id=None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001109 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001110 gitcookies_exists=True,
1111 force=False,
Edward Lesmes0dd54822020-03-26 18:24:25 +00001112 log_description=None,
Josipe827b0f2020-01-30 00:07:20 +00001113 edit_description=None,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001114 fetched_description=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001115 default_branch='master'):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001116 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001117 if squash_mode is None:
1118 if '--no-squash' in upload_args:
1119 squash_mode = 'nosquash'
1120 elif '--squash' in upload_args:
1121 squash_mode = 'squash'
1122 else:
1123 squash_mode = 'default'
1124
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001125 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001126 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001127 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001128 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001129 same_auth=('git-owner.example.com', '', 'pass'))).start()
1130 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1131 lambda _, offer_removal: None).start()
1132 mock.patch('git_cl.gclient_utils.RunEditor',
1133 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1134 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001135 'DownloadGerritHook', force)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001136 mock.patch('git_cl.gclient_utils.FileRead',
1137 lambda path: self._mocked_call(['FileRead', path])).start()
1138 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001139 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001140 ['FileWrite', path, contents])).start()
1141 mock.patch('git_cl.datetime_now',
1142 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1143 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1144 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1145 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001146 '%(now)s\n'
1147 '%(gerrit_host)s\n'
1148 '%(change_id)s\n'
1149 '%(title)s\n'
1150 '%(description)s\n'
1151 '%(execution_time)s\n'
1152 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001153 '%(trace_name)s').start()
1154 mock.patch('git_cl.shutil.make_archive',
1155 lambda *args: self._mocked_call(['make_archive'] +
1156 list(args))).start()
1157 mock.patch('os.path.isfile',
1158 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001159 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001160 'git_cl._create_description_from_log',
1161 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001162 mock.patch(
1163 'git_cl.Changelist._AddChangeIdToCommitMessage',
1164 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001165 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001166 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1167 mock.patch(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001168 'git_common.get_or_create_merge_base',
1169 return_value='origin/' + default_branch).start()
1170 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001171 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001172 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001173
Edward Lemur26964072020-02-19 19:18:51 +00001174 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001175 self.mockGit.config['branch.master.gerritissue'] = (
1176 str(issue) if issue else None)
1177 self.mockGit.config['remote.origin.url'] = (
1178 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001179 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001180
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001181 self.calls = self._gerrit_base_calls(
1182 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001183 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001184 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001185 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001186 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001187 short_hostname=short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001188 change_id=change_id,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001189 default_branch=default_branch)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001190 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001191 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001192 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001193 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001194 self.calls += self._gerrit_upload_calls(
1195 description, reviewers, squash,
1196 squash_mode=squash_mode,
Aaron Gablefd238082017-06-07 13:42:34 -07001197 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001198 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001199 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001200 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001201 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001202 labels=labels,
1203 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001204 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001205 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001206 force=force,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001207 edit_description=edit_description,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001208 default_branch=default_branch)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001209 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001210 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001211 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001212 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001213 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001214 self.assertEqual(
1215 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001216 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001217
Edward Lemur1b52d872019-05-09 21:12:12 +00001218 def test_gerrit_upload_traces_no_gitcookies(self):
1219 self._run_gerrit_upload_test(
1220 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001221 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001222 [],
1223 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001224 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001225 change_id='Ixxx',
1226 gitcookies_exists=False)
1227
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001228 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001229 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001230 [],
1231 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1232 [],
1233 change_id='Ixxx')
1234
1235 def test_gerrit_upload_without_change_id_nosquash(self):
1236 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001237 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001238 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001239 [],
1240 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001241 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001242 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001243
Edward Lesmes4de54132020-05-05 19:41:33 +00001244 def test_gerrit_upload_without_change_id_override_nosquash(self):
1245 self._run_gerrit_upload_test(
1246 [],
1247 'desc ✔\n\nBUG=\n',
1248 [],
1249 squash=False,
1250 squash_mode='override_nosquash',
1251 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1252 change_id='Ixxx')
1253
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001254 def test_gerrit_no_reviewer(self):
1255 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001256 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001257 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001258 [],
1259 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001260 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001261 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001262
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001263 def test_gerrit_no_reviewer_non_chromium_host(self):
1264 # TODO(crbug/877717): remove this test case.
1265 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001266 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001267 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001268 [],
1269 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001270 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001271 short_hostname='other',
1272 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001273
Edward Lesmes0dd54822020-03-26 18:24:25 +00001274 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001275 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001276 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001277 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001278 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001279 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001280 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001281 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001282
ukai@chromium.orge8077812012-02-03 03:41:46 +00001283 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001284 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001285 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001286 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001287 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001288 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001289 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001290 notify=True,
1291 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001292 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001293 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001294
Anthony Polito8b955342019-09-24 19:01:36 +00001295 def test_gerrit_upload_force_sets_bug(self):
1296 self._run_gerrit_upload_test(
1297 ['-b', '10000', '-f'],
1298 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1299 [],
1300 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001301 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001302 change_id='Ixxx')
1303
Edward Lemur5fb22242020-03-12 22:05:13 +00001304 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001305 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001306 ['-b', '10000', '-m', 'Title', '--edit-description'],
1307 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001308 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001309 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001310 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001311 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001312 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001313 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001314
Dan Beamd8b04ca2019-10-10 21:23:26 +00001315 def test_gerrit_upload_force_sets_fixed(self):
1316 self._run_gerrit_upload_test(
1317 ['-x', '10000', '-f'],
1318 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1319 [],
1320 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001321 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001322 change_id='Ixxx')
1323
ukai@chromium.orge8077812012-02-03 03:41:46 +00001324 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001325 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1326 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001327 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001328 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001329 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001330 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001331 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001332 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001333 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001334 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001335 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001336 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001337
1338 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001339 self._run_gerrit_upload_test(
1340 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001341 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001342 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001343 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001344
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001345 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001346 self._run_gerrit_upload_test(
1347 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001348 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001349 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001350 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001351 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001352
Edward Lesmes0dd54822020-03-26 18:24:25 +00001353 def test_gerrit_upload_squash_first_title(self):
1354 self._run_gerrit_upload_test(
1355 ['-f', '-t', 'title'],
1356 'title\n\ndesc\n\nChange-Id: 123456789',
1357 [],
1358 force=True,
1359 squash=True,
1360 log_description='desc',
1361 change_id='123456789')
1362
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001363 def test_gerrit_upload_squash_first_with_labels(self):
1364 self._run_gerrit_upload_test(
1365 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001366 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001367 [],
1368 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001369 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001370 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001371
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001372 def test_gerrit_upload_squash_first_against_rev(self):
1373 custom_cl_base = 'custom_cl_base_rev_or_branch'
1374 self._run_gerrit_upload_test(
1375 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001376 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001377 [],
1378 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001379 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001380 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001381 self.assertIn(
1382 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1383 sys.stdout.getvalue())
1384
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001385 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001386 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001387 self._run_gerrit_upload_test(
1388 ['--squash'],
1389 description,
1390 [],
1391 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001392 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001393 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001394
Edward Lemurd55c5072020-02-20 01:09:07 +00001395 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001396 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001397 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001398 with self.assertRaises(SystemExitMock):
1399 self._run_gerrit_upload_test(
1400 ['--squash'],
1401 description,
1402 [],
1403 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001404 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001405 fetched_status='ABANDONED',
1406 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001407 self.assertEqual(
1408 'Change https://chromium-review.googlesource.com/123456 has been '
1409 'abandoned, new uploads are not allowed\n',
1410 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001411
Edward Lemurda4b6c62020-02-13 00:28:40 +00001412 @mock.patch(
1413 'gerrit_util.GetAccountDetails',
1414 return_value={'email': 'yet-another@example.com'})
1415 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001416 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001417 self._run_gerrit_upload_test(
1418 ['--squash'],
1419 description,
1420 [],
1421 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001422 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001423 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001424 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001425 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001426 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001427 'authenticate to Gerrit as yet-another@example.com.\n'
1428 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001429 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001430
Josipe827b0f2020-01-30 00:07:20 +00001431 def test_upload_change_description_editor(self):
1432 fetched_description = 'foo\n\nChange-Id: 123456789'
1433 description = 'bar\n\nChange-Id: 123456789'
1434 self._run_gerrit_upload_test(
1435 ['--squash', '--edit-description'],
1436 description,
1437 [],
1438 fetched_description=fetched_description,
1439 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001440 issue=123456,
1441 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001442 edit_description=description)
1443
Edward Lemurda4b6c62020-02-13 00:28:40 +00001444 @mock.patch('git_cl.RunGit')
1445 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001446 @mock.patch('sys.stdin', StringIO('\n'))
1447 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001448 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001449 def mock_run_git(*args, **_kwargs):
1450 if args[0] == ['for-each-ref',
1451 '--format=%(refname:short) %(upstream:short)',
1452 'refs/heads']:
1453 # Create a local branch dependency tree that looks like this:
1454 # test1 -> test2 -> test3 -> test4 -> test5
1455 # -> test3.1
1456 # test6 -> test0
1457 branch_deps = [
1458 'test2 test1', # test1 -> test2
1459 'test3 test2', # test2 -> test3
1460 'test3.1 test2', # test2 -> test3.1
1461 'test4 test3', # test3 -> test4
1462 'test5 test4', # test4 -> test5
1463 'test6 test0', # test0 -> test6
1464 'test7', # test7
1465 ]
1466 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001467 git_cl.RunGit.side_effect = mock_run_git
1468 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001469
1470 class MockChangelist():
1471 def __init__(self):
1472 pass
1473 def GetBranch(self):
1474 return 'test1'
1475 def GetIssue(self):
1476 return '123'
1477 def GetPatchset(self):
1478 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001479 def IsGerrit(self):
1480 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001481
1482 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1483 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001484 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001485 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001486 'This command will checkout all dependent branches '
1487 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001488 'or Ctrl+C to abort',
1489 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001490 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001491
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001492 def test_gerrit_change_id(self):
1493 self.calls = [
1494 ((['git', 'write-tree'], ),
1495 'hashtree'),
1496 ((['git', 'rev-parse', 'HEAD~0'], ),
1497 'branch-parent'),
1498 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1499 'A B <a@b.org> 1456848326 +0100'),
1500 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1501 'C D <c@d.org> 1456858326 +0100'),
1502 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1503 'hashchange'),
1504 ]
1505 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1506 self.assertEqual(change_id, 'Ihashchange')
1507
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001508 @mock.patch('git_cl.Settings.GetBugPrefix')
1509 @mock.patch('git_cl.Settings.GetRoot')
1510 @mock.patch('git_cl.Changelist.FetchDescription')
1511 @mock.patch('git_cl.Changelist.GetBranch')
1512 @mock.patch('git_cl.Changelist.GetCommonAncestorWithUpstream')
1513 @mock.patch('owners_client.OwnersClient.BatchListOwners')
1514 def getDescriptionForUploadTest(
1515 self, mockBatchListOwners=None, mockGetCommonAncestorWithUpstream=None,
1516 mockGetBranch=None, mockFetchDescription=None, mockGetRoot=None,
1517 mockGetBugPrefix=None,
1518 initial_description='desc', bug=None, fixed=None, branch='branch',
1519 reviewers=None, tbrs=None, add_owners_to=None,
1520 expected_description='desc'):
1521 reviewers = reviewers or []
1522 tbrs = tbrs or []
1523 owners_by_path = {
1524 'a': ['a@example.com'],
1525 'b': ['b@example.com'],
1526 'c': ['c@example.com'],
1527 }
1528 mockGetRoot.return_value = 'root'
1529 mockGetBranch.return_value = branch
1530 mockGetBugPrefix.return_value = 'prefix'
1531 mockGetCommonAncestorWithUpstream.return_value = 'upstream'
1532 mockFetchDescription.return_value = 'desc'
1533 mockBatchListOwners.side_effect = lambda ps: {
1534 p: owners_by_path.get(p)
1535 for p in ps
1536 }
1537
1538 cl = git_cl.Changelist(issue=1234)
1539 actual = cl._GetDescriptionForUpload(
1540 options=mock.Mock(
1541 bug=bug,
1542 fixed=fixed,
1543 reviewers=reviewers,
1544 tbrs=tbrs,
1545 add_owners_to=add_owners_to),
1546 git_diff_args=None,
1547 files=list(owners_by_path))
1548 self.assertEqual(expected_description, actual.description)
1549
1550 def testGetDescriptionForUpload(self):
1551 self.getDescriptionForUploadTest()
1552
1553 def testGetDescriptionForUpload_Bug(self):
1554 self.getDescriptionForUploadTest(
1555 bug='1234',
1556 expected_description='\n'.join([
1557 'desc',
1558 '',
1559 'Bug: prefix:1234',
1560 ]))
1561
1562 def testGetDescriptionForUpload_Fixed(self):
1563 self.getDescriptionForUploadTest(
1564 fixed='1234',
1565 expected_description='\n'.join([
1566 'desc',
1567 '',
1568 'Fixed: prefix:1234',
1569 ]))
1570
1571
1572 def testGetDescriptionForUpload_BugFromBranch(self):
1573 self.getDescriptionForUploadTest(
1574 branch='bug-1234',
1575 expected_description='\n'.join([
1576 'desc',
1577 '',
1578 'Bug: prefix:1234',
1579 ]))
1580
1581 def testGetDescriptionForUpload_FixedFromBranch(self):
1582 self.getDescriptionForUploadTest(
1583 branch='fix-1234',
1584 expected_description='\n'.join([
1585 'desc',
1586 '',
1587 'Fixed: prefix:1234',
1588 ]))
1589
1590 def testGetDescriptionForUpload_AddOwnersToR(self):
1591 self.getDescriptionForUploadTest(
1592 reviewers=['a@example.com'],
1593 tbrs=['b@example.com'],
1594 add_owners_to='R',
1595 expected_description='\n'.join([
1596 'desc',
1597 '',
1598 'R=a@example.com, c@example.com',
1599 'TBR=b@example.com',
1600 ]))
1601
1602 def testGetDescriptionForUpload_AddOwnersToTBR(self):
1603 self.getDescriptionForUploadTest(
1604 reviewers=['a@example.com'],
1605 tbrs=['b@example.com'],
1606 add_owners_to='TBR',
1607 expected_description='\n'.join([
1608 'desc',
1609 '',
1610 'R=a@example.com',
1611 'TBR=b@example.com, c@example.com',
1612 ]))
1613
1614 def testGetDescriptionForUpload_AddOwnersToNoOwnersNeeded(self):
1615 self.getDescriptionForUploadTest(
1616 reviewers=['a@example.com', 'c@example.com'],
1617 tbrs=['b@example.com'],
1618 add_owners_to='TBR',
1619 expected_description='\n'.join([
1620 'desc',
1621 '',
1622 'R=a@example.com, c@example.com',
1623 'TBR=b@example.com',
1624 ]))
1625
1626 def testGetDescriptionForUpload_Reviewers(self):
1627 self.getDescriptionForUploadTest(
1628 reviewers=['a@example.com', 'b@example.com'],
1629 expected_description='\n'.join([
1630 'desc',
1631 '',
1632 'R=a@example.com, b@example.com',
1633 ]))
1634
1635 def testGetDescriptionForUpload_TBRs(self):
1636 self.getDescriptionForUploadTest(
1637 tbrs=['a@example.com', 'b@example.com'],
1638 expected_description='\n'.join([
1639 'desc',
1640 '',
1641 'TBR=a@example.com, b@example.com',
1642 ]))
1643
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001644 def test_desecription_append_footer(self):
1645 for init_desc, footer_line, expected_desc in [
1646 # Use unique desc first lines for easy test failure identification.
1647 ('foo', 'R=one', 'foo\n\nR=one'),
1648 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1649 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1650 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1651 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1652 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1653 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1654 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1655 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1656 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1657 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1658 ]:
1659 desc = git_cl.ChangeDescription(init_desc)
1660 desc.append_footer(footer_line)
1661 self.assertEqual(desc.description, expected_desc)
1662
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001663 def test_update_reviewers(self):
1664 data = [
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001665 ('foo', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001666 'foo'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001667 ('foo\nR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001668 'foo\nR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001669 ('foo\nTBR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001670 'foo\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001671 ('foo', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001672 'foo\n\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001673 ('foo\nR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001674 'foo\n\nR=a@c, xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001675 ('foo\nTBR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001676 'foo\n\nR=a@c\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001677 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001678 'foo\n\nR=a@c, yy\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001679 ('foo\nBUG=', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001680 'foo\nBUG=\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001681 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001682 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001683 ('foo', ['a@c', 'b@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001684 'foo\n\nR=a@c, b@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001685 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001686 'foo\nBar\n\nR=c@c\nBUG='),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001687 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001688 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001689 # Same as the line before, but full of whitespaces.
1690 (
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001691 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001692 'foo\nBar\n\nR=c@c\n BUG =',
1693 ),
1694 # Whitespaces aren't interpreted as new lines.
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001695 ('foo BUG=allo R=joe ', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001696 'foo BUG=allo R=joe\n\nR=c@c'),
1697 # Redundant TBRs get promoted to Rs
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001698 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001699 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001700 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001701 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001702 actual = []
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001703 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001704 obj = git_cl.ChangeDescription(orig)
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001705 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001706 actual.append(obj.description)
1707 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001708
Nodir Turakulov23b82142017-11-16 11:04:25 -08001709 def test_get_hash_tags(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001710 self.calls = [
1711 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
1712 callError(1)),
1713 ] * 9
Nodir Turakulov23b82142017-11-16 11:04:25 -08001714 cases = [
1715 ('', []),
1716 ('a', []),
1717 ('[a]', ['a']),
1718 ('[aa]', ['aa']),
1719 ('[a ]', ['a']),
1720 ('[a- ]', ['a']),
1721 ('[a- b]', ['a-b']),
1722 ('[a--b]', ['a-b']),
1723 ('[a', []),
1724 ('[a]x', ['a']),
1725 ('[aa]x', ['aa']),
1726 ('[a b]', ['a-b']),
1727 ('[a b]', ['a-b']),
1728 ('[a__b]', ['a-b']),
1729 ('[a] x', ['a']),
1730 ('[a][b]', ['a', 'b']),
1731 ('[a] [b]', ['a', 'b']),
1732 ('[a][b]x', ['a', 'b']),
1733 ('[a][b] x', ['a', 'b']),
1734 ('[a]\n[b]', ['a']),
1735 ('[a\nb]', []),
1736 ('[a][', ['a']),
1737 ('Revert "[a] feature"', ['a']),
1738 ('Reland "[a] feature"', ['a']),
1739 ('Revert: [a] feature', ['a']),
1740 ('Reland: [a] feature', ['a']),
1741 ('Revert "Reland: [a] feature"', ['a']),
1742 ('Foo: feature', ['foo']),
1743 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001744 ('Change Foo::Bar', []),
1745 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001746 ('Revert "Foo bar: feature"', ['foo-bar']),
1747 ('Reland "Foo bar: feature"', ['foo-bar']),
1748 ]
1749 for desc, expected in cases:
1750 change_desc = git_cl.ChangeDescription(desc)
1751 actual = change_desc.get_hash_tags()
1752 self.assertEqual(
1753 actual,
1754 expected,
1755 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1756
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001757 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001758 self.assertEqual(None, git_cl.GetTargetRef(None,
1759 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001760 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001761
wittman@chromium.org455dc922015-01-26 20:15:50 +00001762 # Check default target refs for branches.
1763 self.assertEqual('refs/heads/master',
1764 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001765 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001766 self.assertEqual('refs/heads/master',
1767 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001768 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001769 self.assertEqual('refs/heads/master',
1770 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001771 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001772 self.assertEqual('refs/branch-heads/123',
1773 git_cl.GetTargetRef('origin',
1774 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001775 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001776 self.assertEqual('refs/diff/test',
1777 git_cl.GetTargetRef('origin',
1778 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001779 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001780 self.assertEqual('refs/heads/chrome/m42',
1781 git_cl.GetTargetRef('origin',
1782 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001783 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001784
1785 # Check target refs for user-specified target branch.
1786 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1787 'refs/remotes/branch-heads/123'):
1788 self.assertEqual('refs/branch-heads/123',
1789 git_cl.GetTargetRef('origin',
1790 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001791 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001792 for branch in ('origin/master', 'remotes/origin/master',
1793 'refs/remotes/origin/master'):
1794 self.assertEqual('refs/heads/master',
1795 git_cl.GetTargetRef('origin',
1796 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001797 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001798 for branch in ('master', 'heads/master', 'refs/heads/master'):
1799 self.assertEqual('refs/heads/master',
1800 git_cl.GetTargetRef('origin',
1801 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001802 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001803
Edward Lemurda4b6c62020-02-13 00:28:40 +00001804 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1805 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001806 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001807 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1808
Edward Lemur85153282020-02-14 22:06:29 +00001809 def assertIssueAndPatchset(
1810 self, branch='master', issue='123456', patchset='7',
1811 git_short_host='chromium'):
1812 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001813 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001814 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001815 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001816 self.assertEqual(
1817 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001818 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001819
Edward Lemur85153282020-02-14 22:06:29 +00001820 def _patch_common(self, git_short_host='chromium'):
Edward Lesmes50da7702020-03-30 19:23:43 +00001821 mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
Edward Lemur26964072020-02-19 19:18:51 +00001822 self.mockGit.config['remote.origin.url'] = (
1823 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001824 gerrit_util.GetChangeDetail.return_value = {
1825 'current_revision': '7777777777',
1826 'revisions': {
1827 '1111111111': {
1828 '_number': 1,
1829 'fetch': {'http': {
1830 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1831 'ref': 'refs/changes/56/123456/1',
1832 }},
1833 },
1834 '7777777777': {
1835 '_number': 7,
1836 'fetch': {'http': {
1837 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1838 'ref': 'refs/changes/56/123456/7',
1839 }},
1840 },
1841 },
1842 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001843
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001844 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001845 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001846 self.calls += [
1847 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1848 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001849 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001850 ]
1851 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001852 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001853
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001854 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001855 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001856 self.calls += [
1857 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1858 'refs/changes/56/123456/7'],), ''),
1859 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001860 ]
Edward Lemur85153282020-02-14 22:06:29 +00001861 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1862 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001863
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001864 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001865 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001866 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001867 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001868 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001869 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001870 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001871 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001872 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001873
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001874 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001875 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001876 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001877 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001878 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001879 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001880 ]
1881 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001882 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001883 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001884
Aaron Gable697a91b2018-01-19 15:20:15 -08001885 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001886 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001887 self.calls += [
1888 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1889 'refs/changes/56/123456/1'],), ''),
1890 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001891 ]
1892 self.assertEqual(git_cl.main(
1893 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1894 0)
Edward Lemur85153282020-02-14 22:06:29 +00001895 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001896
Edward Lemurd55c5072020-02-20 01:09:07 +00001897 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001898 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001899 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001900 self.calls += [
1901 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001902 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001903 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001904 ]
1905 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001906 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001907 self.assertEqual(
1908 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1909 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001910
Edward Lemurda4b6c62020-02-13 00:28:40 +00001911 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001912 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001913 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001914 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001915 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001916 self.mockGit.config['remote.origin.url'] = (
1917 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001918 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001919 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001920 self.assertEqual(
1921 'change 123456 at https://chromium-review.googlesource.com does not '
1922 'exist or you have no access to it\n',
1923 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001924
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001925 def _checkout_calls(self):
1926 return [
1927 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001928 'branch\\..*\\.gerritissue'], ),
1929 ('branch.ger-branch.gerritissue 123456\n'
1930 'branch.gbranch654.gerritissue 654321\n')),
1931 ]
1932
1933 def test_checkout_gerrit(self):
1934 """Tests git cl checkout <issue>."""
1935 self.calls = self._checkout_calls()
1936 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1937 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1938
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001939 def test_checkout_not_found(self):
1940 """Tests git cl checkout <issue>."""
1941 self.calls = self._checkout_calls()
1942 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1943
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001944 def test_checkout_no_branch_issues(self):
1945 """Tests git cl checkout <issue>."""
1946 self.calls = [
1947 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001948 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001949 ]
1950 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1951
Edward Lemur26964072020-02-19 19:18:51 +00001952 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00001953 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001954 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001955 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001956 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1957 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001958 self.mockGit.config['remote.origin.url'] = (
1959 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001960 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001961 cl.branch = 'master'
1962 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001963 return cl
1964
Edward Lemurd55c5072020-02-20 01:09:07 +00001965 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001966 def test_gerrit_ensure_authenticated_missing(self):
1967 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001968 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001969 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001970 with self.assertRaises(SystemExitMock):
1971 cl.EnsureAuthenticated(force=False)
1972 self.assertEqual(
1973 'Credentials for the following hosts are required:\n'
1974 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001975 'These are read from ~%(sep)s.gitcookies '
1976 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00001977 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001978 'https://chromium-review.googlesource.com/new-password\n' % {
1979 'sep': os.sep,
1980 'netrc': NETRC_FILENAME,
1981 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001982
1983 def test_gerrit_ensure_authenticated_conflict(self):
1984 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001985 'chromium.googlesource.com':
1986 ('git-one.example.com', None, 'secret1'),
1987 'chromium-review.googlesource.com':
1988 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001989 })
1990 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001991 (('ask_for_data', 'If you know what you are doing '
1992 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001993 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1994
1995 def test_gerrit_ensure_authenticated_ok(self):
1996 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001997 'chromium.googlesource.com':
1998 ('git-same.example.com', None, 'secret'),
1999 'chromium-review.googlesource.com':
2000 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002001 })
2002 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2003
tandrii@chromium.org28253532016-04-14 13:46:56 +00002004 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00002005 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
2006 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00002007 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2008
Eric Boren2fb63102018-10-05 13:05:03 +00002009 def test_gerrit_ensure_authenticated_bearer_token(self):
2010 cl = self._test_gerrit_ensure_authenticated_common(auth={
2011 'chromium.googlesource.com':
2012 ('', None, 'secret'),
2013 'chromium-review.googlesource.com':
2014 ('', None, 'secret'),
2015 })
2016 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2017 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2018 'chromium.googlesource.com')
2019 self.assertTrue('Bearer' in header)
2020
Daniel Chengcf6269b2019-05-18 01:02:12 +00002021 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00002022 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00002023 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002024 (('logging.warning',
2025 'Ignoring branch %(branch)s with non-https remote '
2026 '%(remote)s', {
2027 'branch': 'master',
2028 'remote': 'custom-scheme://repo'}
2029 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00002030 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002031 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2032 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2033 mock.patch('logging.warning',
2034 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002035 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002036 cl.branch = 'master'
2037 cl.branchref = 'refs/heads/master'
2038 cl.lookedup_issue = True
2039 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2040
Florian Mayerae510e82020-01-30 21:04:48 +00002041 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00002042 self.mockGit.config['remote.origin.url'] = (
2043 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00002044 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002045 (('logging.error',
2046 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2047 'but it doesn\'t exist.', {
2048 'remote': 'origin',
2049 'branch': 'master',
2050 'url': 'git@somehost.example:foo/bar.git'}
2051 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00002052 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002053 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2054 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2055 mock.patch('logging.error',
2056 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00002057 cl = git_cl.Changelist()
2058 cl.branch = 'master'
2059 cl.branchref = 'refs/heads/master'
2060 cl.lookedup_issue = True
2061 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2062
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002063 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00002064 self.mockGit.config['branch.master.gerritissue'] = '123'
2065 self.mockGit.config['branch.master.gerritserver'] = (
2066 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00002067 self.mockGit.config['remote.origin.url'] = (
2068 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002069 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00002070 (('SetReview', 'chromium-review.googlesource.com',
2071 'infra%2Finfra~123', None,
2072 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002073 ]
tandriid9e5ce52016-07-13 02:32:59 -07002074
2075 def test_cmd_set_commit_gerrit_clear(self):
2076 self._cmd_set_commit_gerrit_common(0)
2077 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2078
2079 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002080 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002081 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2082
tandriid9e5ce52016-07-13 02:32:59 -07002083 def test_cmd_set_commit_gerrit(self):
2084 self._cmd_set_commit_gerrit_common(2)
2085 self.assertEqual(0, git_cl.main(['set-commit']))
2086
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002087 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002088 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002089 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002090
2091 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002092 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002093
Edward Lemurda4b6c62020-02-13 00:28:40 +00002094 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07002095 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07002096 try:
2097 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00002098 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00002099 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00002100 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07002101
2102 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07002103 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002104 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002105 return 'foobar'
2106
Edward Lemurda4b6c62020-02-13 00:28:40 +00002107 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07002108 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002109 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002110 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00002111 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07002112
iannuccie53c9352016-08-17 14:40:40 -07002113 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002114
iannuccie53c9352016-08-17 14:40:40 -07002115 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002116 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002117 return 'foobar'
2118
Edward Lemurda4b6c62020-02-13 00:28:40 +00002119 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2120 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002121 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002122 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002123
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002124 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00002125 self.mockGit.config['remote.origin.url'] = (
2126 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002127 gerrit_util.GetChangeDetail.return_value = {
2128 'current_revision': 'sha1',
2129 'revisions': {'sha1': {
2130 'commit': {'message': 'foobar'},
2131 }},
2132 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002133 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002134 'description',
2135 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2136 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002137 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002138
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002139 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002140 mock.patch('git_cl.Changelist', ChangelistMock).start()
2141 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002142
2143 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2144 self.assertEqual('hihi', ChangelistMock.desc)
2145
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002146 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002147 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002148
2149 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002150 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002151 '# Enter a description of the change.\n'
2152 '# This will be displayed on the codereview site.\n'
2153 '# The first line will also be used as the subject of the review.\n'
2154 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002155 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002156 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002157 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002158 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002159 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002160
Edward Lemur6c6827c2020-02-06 21:15:18 +00002161 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002162 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002163
Edward Lemurda4b6c62020-02-13 00:28:40 +00002164 mock.patch('git_cl.Changelist.FetchDescription',
2165 lambda *args: current_desc).start()
2166 mock.patch('git_cl.Changelist.UpdateDescription',
2167 UpdateDescription).start()
2168 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002169
Edward Lemur85153282020-02-14 22:06:29 +00002170 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002171 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002172
Dan Beamd8b04ca2019-10-10 21:23:26 +00002173 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2174 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2175
2176 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002177 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002178 '# Enter a description of the change.\n'
2179 '# This will be displayed on the codereview site.\n'
2180 '# The first line will also be used as the subject of the review.\n'
2181 '#--------------------This line is 72 characters long'
2182 '--------------------\n'
2183 'Some.\n\nFixed: 123\nChange-Id: xxx',
2184 desc)
2185 return desc
2186
Edward Lemurda4b6c62020-02-13 00:28:40 +00002187 mock.patch('git_cl.Changelist.FetchDescription',
2188 lambda *args: current_desc).start()
2189 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002190
Edward Lemur85153282020-02-14 22:06:29 +00002191 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002192 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002193
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002194 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002195 mock.patch('git_cl.Changelist', ChangelistMock).start()
2196 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002197
2198 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2199 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2200
kmarshall3bff56b2016-06-06 18:31:47 -07002201 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002202 self.calls = [
2203 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002204 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002205 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002206 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002207 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002208 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002209
Edward Lemurda4b6c62020-02-13 00:28:40 +00002210 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002211 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002212 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2213 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002214 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002215
2216 self.assertEqual(0, git_cl.main(['archive', '-f']))
2217
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002218 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002219 self.calls = [
2220 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2221 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2222 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2223 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002224 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2225 ((['git', 'branch', '-D', 'foo'],), '')
2226 ]
2227
Edward Lemurda4b6c62020-02-13 00:28:40 +00002228 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002229 lambda branches, fine_grained, max_processes:
2230 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2231 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002232 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002233
2234 self.assertEqual(0, git_cl.main(['archive', '-f']))
2235
kmarshall3bff56b2016-06-06 18:31:47 -07002236 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002237 self.calls = [
2238 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2239 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002240 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002241 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002242
Edward Lemurda4b6c62020-02-13 00:28:40 +00002243 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002244 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002245 [(MockChangelistWithBranchAndIssue('master', 1),
2246 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002247
2248 self.assertEqual(1, git_cl.main(['archive', '-f']))
2249
2250 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002251 self.calls = [
2252 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2253 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002254 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002255 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002256
Edward Lemurda4b6c62020-02-13 00:28:40 +00002257 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002258 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002259 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2260 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002261 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002262
kmarshall9249e012016-08-23 12:02:16 -07002263 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2264
2265 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002266 self.calls = [
2267 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2268 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002269 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002270 ((['git', 'branch', '-D', 'foo'],), '')
2271 ]
kmarshall9249e012016-08-23 12:02:16 -07002272
Edward Lemurda4b6c62020-02-13 00:28:40 +00002273 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002274 lambda branches, fine_grained, max_processes:
2275 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2276 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002277 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002278
2279 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002280
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002281 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002282 self.calls = [
2283 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2284 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2285 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002286 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2287 'refs/tags/git-cl-archived-456-foo'),
2288 ((['git', 'branch', '-D', 'foo'],), CERR1),
2289 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2290 'refs/tags/git-cl-archived-456-foo'),
2291 ]
2292
Edward Lemurda4b6c62020-02-13 00:28:40 +00002293 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002294 lambda branches, fine_grained, max_processes:
2295 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2296 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002297 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002298
2299 self.assertEqual(0, git_cl.main(['archive', '-f']))
2300
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002301 def test_archive_with_format(self):
2302 self.calls = [
2303 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
2304 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2305 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2306 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2307 ((['git', 'branch', '-D', 'foo'], ), ''),
2308 ]
2309
2310 mock.patch('git_cl.get_cl_statuses',
2311 lambda branches, fine_grained, max_processes:
2312 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2313
2314 self.assertEqual(
2315 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2316
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002317 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002318 self.mockGit.config['branch.master.gerritissue'] = '123'
2319 self.mockGit.config['branch.master.gerritserver'] = (
2320 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002321 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002322 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002323 ]
2324 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002325 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2326 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002327
Aaron Gable400e9892017-07-12 15:31:21 -07002328 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002329 self.mockGit.config['branch.master.gerritissue'] = '123'
2330 self.mockGit.config['branch.master.gerritserver'] = (
2331 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002332 mock.patch('git_cl.Changelist.FetchDescription',
2333 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002334 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002335 ((['git', 'log', '-1', '--format=%B'],),
2336 'This is a description\n\nChange-Id: Ideadbeef'),
2337 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002338 ]
2339 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002340 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2341 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002342
phajdan.jre328cf92016-08-22 04:12:17 -07002343 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002344 self.mockGit.config['branch.master.gerritissue'] = '123'
2345 self.mockGit.config['branch.master.gerritserver'] = (
2346 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002347 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002348 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002349 {'issue': 123,
2350 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002351 ''),
2352 ]
2353 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2354
tandrii16e0b4e2016-06-07 10:34:28 -07002355 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002356 mock.patch(
2357 'git_cl.os.path.abspath',
2358 lambda path: self._mocked_call(['abspath', path])).start()
2359 mock.patch(
2360 'git_cl.os.path.exists',
2361 lambda path: self._mocked_call(['exists', path])).start()
2362 mock.patch(
2363 'git_cl.gclient_utils.FileRead',
2364 lambda path: self._mocked_call(['FileRead', path])).start()
2365 mock.patch(
2366 'git_cl.gclient_utils.rm_file_or_tree',
2367 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002368 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002369 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002370 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002371 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002372
2373 def test_GerritCommitMsgHookCheck_custom_hook(self):
2374 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002375 self.calls += [((['exists',
2376 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2377 ((['FileRead',
2378 os.path.join('.git', 'hooks', 'commit-msg')], ),
2379 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002380 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002381
2382 def test_GerritCommitMsgHookCheck_not_exists(self):
2383 cl = self._common_GerritCommitMsgHookCheck()
2384 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002385 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002386 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002387 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002388
2389 def test_GerritCommitMsgHookCheck(self):
2390 cl = self._common_GerritCommitMsgHookCheck()
2391 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002392 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2393 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002394 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002395 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002396 ((['rm_file_or_tree',
2397 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002398 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002399 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002400
tandriic4344b52016-08-29 06:04:54 -07002401 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002402 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2403 self.mockGit.config['branch.master.gerritserver'] = (
2404 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002405 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002406 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002407 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002408 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002409 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002410 'labels': {},
2411 'current_revision': 'deadbeaf',
2412 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002413 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002414 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002415 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002416 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2417 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002418 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002419 self.assertEqual(0, cl.CMDLand(force=True,
2420 bypass_hooks=True,
2421 verbose=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002422 parallel=False,
2423 resultdb=False,
2424 realm=None))
Edward Lemur73c76702020-02-06 23:57:18 +00002425 self.assertIn(
2426 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002427 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002428 self.assertIn(
2429 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002430 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002431
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002432 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002433 mock.patch('git_cl.Changelist.GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002434
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002435 def test_gerrit_change_detail_cache_simple(self):
2436 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002437 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002438 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002439 cl1._cached_remote_url = (
2440 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002441 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002442 cl2._cached_remote_url = (
2443 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002444 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2445 self.assertEqual(cl1._GetChangeDetail(), 'a')
2446 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002447
2448 def test_gerrit_change_detail_cache_options(self):
2449 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002450 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002451 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002452 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002453 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2454 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2455 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2456 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2457 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2458 self.assertEqual(cl._GetChangeDetail(), 'cab')
2459
2460 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2461 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2462 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2463 self.assertEqual(cl._GetChangeDetail(), 'cab')
2464
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002465 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002466 gerrit_util.GetChangeDetail.return_value = {
2467 'current_revision': 'rev1',
2468 'revisions': {
2469 'rev1': {'commit': {'message': 'desc1'}},
2470 },
2471 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002472
2473 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002474 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002475 cl._cached_remote_url = (
2476 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002477 self.assertEqual(cl.FetchDescription(), 'desc1')
2478 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002479
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002480 def test_print_current_creds(self):
2481 class CookiesAuthenticatorMock(object):
2482 def __init__(self):
2483 self.gitcookies = {
2484 'host.googlesource.com': ('user', 'pass'),
2485 'host-review.googlesource.com': ('user', 'pass'),
2486 }
2487 self.netrc = self
2488 self.netrc.hosts = {
2489 'github.com': ('user2', None, 'pass2'),
2490 'host2.googlesource.com': ('user3', None, 'pass'),
2491 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002492 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2493 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002494 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2495 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2496 ' Host\t User\t Which file',
2497 '============================\t=====\t===========',
2498 'host-review.googlesource.com\t user\t.gitcookies',
2499 ' host.googlesource.com\t user\t.gitcookies',
2500 ' host2.googlesource.com\tuser3\t .netrc',
2501 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002502 sys.stdout.seek(0)
2503 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002504 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2505 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2506 ' Host\tUser\t Which file',
2507 '============================\t====\t===========',
2508 'host-review.googlesource.com\tuser\t.gitcookies',
2509 ' host.googlesource.com\tuser\t.gitcookies',
2510 ])
2511
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002512 def _common_creds_check_mocks(self):
2513 def exists_mock(path):
2514 dirname = os.path.dirname(path)
2515 if dirname == os.path.expanduser('~'):
2516 dirname = '~'
2517 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002518 if base in (NETRC_FILENAME, '.gitcookies'):
2519 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002520 # git cl also checks for existence other files not relevant to this test.
2521 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002522 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002523 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002524 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002525 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002526
2527 def test_creds_check_gitcookies_not_configured(self):
2528 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002529 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2530 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002531 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002532 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2533 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2534 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2535 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2536 'or Ctrl+C to abort'), ''),
2537 (([
2538 'git', 'config', '--global', 'http.cookiefile',
2539 os.path.expanduser(os.path.join('~', '.gitcookies'))
2540 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002541 ]
2542 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002543 self.assertTrue(
2544 sys.stdout.getvalue().startswith(
2545 'You seem to be using outdated .netrc for git credentials:'))
2546 self.assertIn(
2547 '\nConfigured git to use .gitcookies from',
2548 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002549
2550 def test_creds_check_gitcookies_configured_custom_broken(self):
2551 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002552 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2553 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002554 custom_cookie_path = ('C:\\.gitcookies'
2555 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002556 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002557 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2558 ((['git', 'config', '--global', 'http.cookiefile'], ),
2559 custom_cookie_path),
2560 (('os.path.exists', custom_cookie_path), False),
2561 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2562 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2563 (([
2564 'git', 'config', '--global', 'http.cookiefile',
2565 os.path.expanduser(os.path.join('~', '.gitcookies'))
2566 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002567 ]
2568 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002569 self.assertIn(
2570 'WARNING: You have configured custom path to .gitcookies: ',
2571 sys.stdout.getvalue())
2572 self.assertIn(
2573 'However, your configured .gitcookies file is missing.',
2574 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002575
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002576 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002577 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002578 self.mockGit.config['remote.origin.url'] = (
2579 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002580 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002581 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002582 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002583 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002584 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002585 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002586
Edward Lemurda4b6c62020-02-13 00:28:40 +00002587 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2588 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002589 self.mockGit.config['remote.origin.url'] = (
2590 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002591 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002592 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002593 'current_revision': 'ba5eba11',
2594 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002595 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002596 '_number': 1,
2597 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002598 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002599 '_number': 2,
2600 },
2601 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002602 'messages': [
2603 {
2604 u'_revision_number': 1,
2605 u'author': {
2606 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002607 u'email': u'could-be-anything@example.com',
2608 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002609 },
2610 u'date': u'2017-03-15 20:08:45.000000000',
2611 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002612 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002613 u'tag': u'autogenerated:cq:dry-run'
2614 },
2615 {
2616 u'_revision_number': 2,
2617 u'author': {
2618 u'_account_id': 11151243,
2619 u'email': u'owner@example.com',
2620 u'name': u'owner'
2621 },
2622 u'date': u'2017-03-16 20:00:41.000000000',
2623 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2624 u'message': u'PTAL',
2625 },
2626 {
2627 u'_revision_number': 2,
2628 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002629 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002630 u'email': u'reviewer@example.com',
2631 u'name': u'reviewer'
2632 },
2633 u'date': u'2017-03-17 05:19:37.500000000',
2634 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2635 u'message': u'Patch Set 2: Code-Review+1',
2636 },
2637 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002638 }
2639 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002640 (('GetChangeComments', 'chromium-review.googlesource.com',
2641 'infra%2Finfra~1'), {
2642 '/COMMIT_MSG': [
2643 {
2644 'author': {
2645 'email': u'reviewer@example.com'
2646 },
2647 'updated': u'2017-03-17 05:19:37.500000000',
2648 'patch_set': 2,
2649 'side': 'REVISION',
2650 'message': 'Please include a bug link',
2651 },
2652 ],
2653 'codereview.settings': [
2654 {
2655 'author': {
2656 'email': u'owner@example.com'
2657 },
2658 'updated': u'2017-03-16 20:00:41.000000000',
2659 'patch_set': 2,
2660 'side': 'PARENT',
2661 'line': 42,
2662 'message': 'I removed this because it is bad',
2663 },
2664 ]
2665 }),
2666 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2667 'infra%2Finfra~1'), {}),
2668 ] * 2 + [(('write_json', 'output.json', [{
2669 u'date':
2670 u'2017-03-16 20:00:41.000000',
2671 u'message': (u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2672 u' Base, Line 42: https://crrev.com/c/1/2/'
2673 u'codereview.settings#b42\n' +
2674 u' I removed this because it is bad\n'),
2675 u'autogenerated':
2676 False,
2677 u'approval':
2678 False,
2679 u'disapproval':
2680 False,
2681 u'sender':
2682 u'owner@example.com'
2683 }, {
2684 u'date':
2685 u'2017-03-17 05:19:37.500000',
2686 u'message':
2687 (u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2688 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
2689 u' Please include a bug link\n'),
2690 u'autogenerated':
2691 False,
2692 u'approval':
2693 False,
2694 u'disapproval':
2695 False,
2696 u'sender':
2697 u'reviewer@example.com'
2698 }]), '')]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002699 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002700 git_cl._CommentSummary(
2701 message=(u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2702 u' Base, Line 42: https://crrev.com/c/1/2/' +
2703 u'codereview.settings#b42\n' +
2704 u' I removed this because it is bad\n'),
2705 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2706 autogenerated=False,
2707 disapproval=False,
2708 approval=False,
2709 sender=u'owner@example.com'),
2710 git_cl._CommentSummary(message=(
2711 u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2712 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002713 u' Please include a bug link\n'),
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002714 date=datetime.datetime(2017, 3, 17, 5, 19, 37,
2715 500000),
2716 autogenerated=False,
2717 disapproval=False,
2718 approval=False,
2719 sender=u'reviewer@example.com'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002720 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002721 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002722 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002723 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002724 self.assertEqual(
2725 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2726
2727 def test_git_cl_comments_robot_comments(self):
2728 # git cl comments also fetches robot comments (which are considered a type
2729 # of autogenerated comment), and unlike other types of comments, only robot
2730 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002731 self.mockGit.config['remote.origin.url'] = (
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002732 'https://x.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002733 gerrit_util.GetChangeDetail.return_value = {
2734 'owner': {'email': 'owner@example.com'},
2735 'current_revision': 'ba5eba11',
2736 'revisions': {
2737 'deadbeaf': {
2738 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002739 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002740 'ba5eba11': {
2741 '_number': 2,
2742 },
2743 },
2744 'messages': [
2745 {
2746 u'_revision_number': 1,
2747 u'author': {
2748 u'_account_id': 1111084,
2749 u'email': u'commit-bot@chromium.org',
2750 u'name': u'Commit Bot'
2751 },
2752 u'date': u'2017-03-15 20:08:45.000000000',
2753 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2754 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2755 u'tag': u'autogenerated:cq:dry-run'
2756 },
2757 {
2758 u'_revision_number': 1,
2759 u'author': {
2760 u'_account_id': 123,
2761 u'email': u'tricium@serviceaccount.com',
2762 u'name': u'Tricium'
2763 },
2764 u'date': u'2017-03-16 20:00:41.000000000',
2765 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2766 u'message': u'(1 comment)',
2767 u'tag': u'autogenerated:tricium',
2768 },
2769 {
2770 u'_revision_number': 1,
2771 u'author': {
2772 u'_account_id': 123,
2773 u'email': u'tricium@serviceaccount.com',
2774 u'name': u'Tricium'
2775 },
2776 u'date': u'2017-03-16 20:00:41.000000000',
2777 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2778 u'message': u'(1 comment)',
2779 u'tag': u'autogenerated:tricium',
2780 },
2781 {
2782 u'_revision_number': 2,
2783 u'author': {
2784 u'_account_id': 123,
2785 u'email': u'tricium@serviceaccount.com',
2786 u'name': u'reviewer'
2787 },
2788 u'date': u'2017-03-17 05:30:37.000000000',
2789 u'tag': u'autogenerated:tricium',
2790 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2791 u'message': u'(1 comment)',
2792 },
2793 ]
2794 }
2795 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002796 (('GetChangeComments', 'x-review.googlesource.com', 'infra%2Finfra~1'),
2797 {}),
2798 (('GetChangeRobotComments', 'x-review.googlesource.com',
2799 'infra%2Finfra~1'), {
2800 'codereview.settings': [
2801 {
2802 u'author': {
2803 u'email': u'tricium@serviceaccount.com'
2804 },
2805 u'updated': u'2017-03-17 05:30:37.000000000',
2806 u'robot_run_id': u'5565031076855808',
2807 u'robot_id': u'Linter/Category',
2808 u'tag': u'autogenerated:tricium',
2809 u'patch_set': 2,
2810 u'side': u'REVISION',
2811 u'message': u'Linter warning message text',
2812 u'line': 32,
2813 },
2814 ],
2815 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002816 ]
2817 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002818 git_cl._CommentSummary(
2819 date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2820 message=(u'(1 comment)\n\ncodereview.settings\n'
2821 u' PS2, Line 32: https://x-review.googlesource.com/c/1/2/'
2822 u'codereview.settings#32\n'
2823 u' Linter warning message text\n'),
2824 sender=u'tricium@serviceaccount.com',
2825 autogenerated=True,
2826 approval=False,
2827 disapproval=False)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002828 ]
2829 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002830 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002831 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002832
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002833 def test_get_remote_url_with_mirror(self):
2834 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002835
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002836 def selective_os_path_isdir_mock(path):
2837 if path == '/cache/this-dir-exists':
2838 return self._mocked_call('os.path.isdir', path)
2839 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002840
Edward Lemurda4b6c62020-02-13 00:28:40 +00002841 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002842
2843 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002844 self.mockGit.config['remote.origin.url'] = (
2845 '/cache/this-dir-exists')
2846 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2847 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002848 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002849 (('os.path.isdir', '/cache/this-dir-exists'),
2850 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002851 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002852 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002853 self.assertEqual(cl.GetRemoteUrl(), url)
2854 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2855
Edward Lemur298f2cf2019-02-22 21:40:39 +00002856 def test_get_remote_url_non_existing_mirror(self):
2857 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002858
Edward Lemur298f2cf2019-02-22 21:40:39 +00002859 def selective_os_path_isdir_mock(path):
2860 if path == '/cache/this-dir-doesnt-exist':
2861 return self._mocked_call('os.path.isdir', path)
2862 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002863
Edward Lemurda4b6c62020-02-13 00:28:40 +00002864 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2865 mock.patch('logging.error',
2866 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002867
Edward Lemur26964072020-02-19 19:18:51 +00002868 self.mockGit.config['remote.origin.url'] = (
2869 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002870 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002871 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2872 False),
2873 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002874 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2875 'but it doesn\'t exist.', {
2876 'remote': 'origin',
2877 'branch': 'master',
2878 'url': '/cache/this-dir-doesnt-exist'}
2879 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002880 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002881 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002882 self.assertIsNone(cl.GetRemoteUrl())
2883
2884 def test_get_remote_url_misconfigured_mirror(self):
2885 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002886
Edward Lemur298f2cf2019-02-22 21:40:39 +00002887 def selective_os_path_isdir_mock(path):
2888 if path == '/cache/this-dir-exists':
2889 return self._mocked_call('os.path.isdir', path)
2890 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002891
Edward Lemurda4b6c62020-02-13 00:28:40 +00002892 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2893 mock.patch('logging.error',
2894 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002895
Edward Lemur26964072020-02-19 19:18:51 +00002896 self.mockGit.config['remote.origin.url'] = (
2897 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002898 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002899 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002900 (('logging.error',
2901 'Remote "%(remote)s" for branch "%(branch)s" points to '
2902 '"%(cache_path)s", but it is misconfigured.\n'
2903 '"%(cache_path)s" must be a git repo and must have a remote named '
2904 '"%(remote)s" pointing to the git host.', {
2905 'remote': 'origin',
2906 'cache_path': '/cache/this-dir-exists',
2907 'branch': 'master'}
2908 ), None),
2909 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002910 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002911 self.assertIsNone(cl.GetRemoteUrl())
2912
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002913 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002914 self.mockGit.config['remote.origin.url'] = (
2915 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002916 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002917 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2918
2919 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002920 mock.patch('logging.error',
2921 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002922
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002923 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002924 (('logging.error',
2925 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2926 'but it doesn\'t exist.', {
2927 'remote': 'origin',
2928 'branch': 'master',
2929 'url': ''}
2930 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002931 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002932 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002933 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002934
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002935 def test_gerrit_new_default(self):
2936 self._run_gerrit_upload_test(
2937 [],
2938 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
2939 [],
2940 squash=False,
2941 squash_mode='override_nosquash',
2942 change_id='I123456789',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002943 default_branch='main')
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002944
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002945
Edward Lemur9aa1a962020-02-25 00:58:38 +00002946class ChangelistTest(unittest.TestCase):
Edward Lemur227d5102020-02-25 23:45:35 +00002947 def setUp(self):
2948 super(ChangelistTest, self).setUp()
2949 mock.patch('gclient_utils.FileRead').start()
2950 mock.patch('gclient_utils.FileWrite').start()
2951 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
2952 mock.patch(
2953 'git_cl.Changelist.GetCodereviewServer',
2954 return_value='https://chromium-review.googlesource.com').start()
2955 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
2956 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
2957 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
2958 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
2959 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
2960 mock.patch('git_cl.time_time').start()
2961 mock.patch('metrics.collector').start()
2962 mock.patch('subprocess2.Popen').start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002963 mock.patch('git_cl.Changelist.GetGerritProject',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002964 return_value='https://chromium-review.googlesource.com').start()
Edward Lemur227d5102020-02-25 23:45:35 +00002965 self.addCleanup(mock.patch.stopall)
2966 self.temp_count = 0
2967
Edward Lemur227d5102020-02-25 23:45:35 +00002968 def testRunHook(self):
2969 expected_results = {
2970 'more_cc': ['more@example.com', 'cc@example.com'],
2971 'should_continue': True,
2972 }
2973 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2974 git_cl.time_time.side_effect = [100, 200]
2975 mockProcess = mock.Mock()
2976 mockProcess.wait.return_value = 0
2977 subprocess2.Popen.return_value = mockProcess
2978
2979 cl = git_cl.Changelist()
2980 results = cl.RunHook(
2981 committing=True,
2982 may_prompt=True,
2983 verbose=2,
2984 parallel=True,
2985 upstream='upstream',
2986 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002987 all_files=True,
2988 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00002989
2990 self.assertEqual(expected_results, results)
2991 subprocess2.Popen.assert_called_once_with([
2992 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00002993 '--root', 'root',
2994 '--upstream', 'upstream',
2995 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002996 '--author', 'author',
2997 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00002998 '--issue', '123456',
2999 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003000 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00003001 '--may_prompt',
3002 '--parallel',
3003 '--all_files',
3004 '--json_output', '/tmp/fake-temp2',
3005 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00003006 '--gerrit_project', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00003007 ])
3008 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00003009 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00003010 metrics.collector.add_repeated('sub_commands', {
3011 'command': 'presubmit',
3012 'execution_time': 100,
3013 'exit_code': 0,
3014 })
3015
Edward Lemur99df04e2020-03-05 19:39:43 +00003016 def testRunHook_FewerOptions(self):
3017 expected_results = {
3018 'more_cc': ['more@example.com', 'cc@example.com'],
3019 'should_continue': True,
3020 }
3021 gclient_utils.FileRead.return_value = json.dumps(expected_results)
3022 git_cl.time_time.side_effect = [100, 200]
3023 mockProcess = mock.Mock()
3024 mockProcess.wait.return_value = 0
3025 subprocess2.Popen.return_value = mockProcess
3026
3027 git_cl.Changelist.GetAuthor.return_value = None
3028 git_cl.Changelist.GetIssue.return_value = None
3029 git_cl.Changelist.GetPatchset.return_value = None
3030 git_cl.Changelist.GetCodereviewServer.return_value = None
3031
3032 cl = git_cl.Changelist()
3033 results = cl.RunHook(
3034 committing=False,
3035 may_prompt=False,
3036 verbose=0,
3037 parallel=False,
3038 upstream='upstream',
3039 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003040 all_files=False,
3041 resultdb=False)
Edward Lemur99df04e2020-03-05 19:39:43 +00003042
3043 self.assertEqual(expected_results, results)
3044 subprocess2.Popen.assert_called_once_with([
3045 'vpython', 'PRESUBMIT_SUPPORT',
3046 '--root', 'root',
3047 '--upstream', 'upstream',
3048 '--upload',
3049 '--json_output', '/tmp/fake-temp2',
3050 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00003051 '--gerrit_project', 'https://chromium-review.googlesource.com',
Edward Lemur99df04e2020-03-05 19:39:43 +00003052 ])
3053 gclient_utils.FileWrite.assert_called_once_with(
3054 '/tmp/fake-temp1', 'description')
3055 metrics.collector.add_repeated('sub_commands', {
3056 'command': 'presubmit',
3057 'execution_time': 100,
3058 'exit_code': 0,
3059 })
3060
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003061 def testRunHook_FewerOptionsResultDB(self):
3062 expected_results = {
3063 'more_cc': ['more@example.com', 'cc@example.com'],
3064 'should_continue': True,
3065 }
3066 gclient_utils.FileRead.return_value = json.dumps(expected_results)
3067 git_cl.time_time.side_effect = [100, 200]
3068 mockProcess = mock.Mock()
3069 mockProcess.wait.return_value = 0
3070 subprocess2.Popen.return_value = mockProcess
3071
3072 git_cl.Changelist.GetAuthor.return_value = None
3073 git_cl.Changelist.GetIssue.return_value = None
3074 git_cl.Changelist.GetPatchset.return_value = None
3075 git_cl.Changelist.GetCodereviewServer.return_value = None
3076
3077 cl = git_cl.Changelist()
3078 results = cl.RunHook(
3079 committing=False,
3080 may_prompt=False,
3081 verbose=0,
3082 parallel=False,
3083 upstream='upstream',
3084 description='description',
3085 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003086 resultdb=True,
3087 realm='chromium:public')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003088
3089 self.assertEqual(expected_results, results)
3090 subprocess2.Popen.assert_called_once_with([
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003091 'rdb', 'stream', '-new', '-realm', 'chromium:public', '--',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003092 'vpython', 'PRESUBMIT_SUPPORT',
3093 '--root', 'root',
3094 '--upstream', 'upstream',
3095 '--upload',
3096 '--json_output', '/tmp/fake-temp2',
3097 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00003098 '--gerrit_project', 'https://chromium-review.googlesource.com',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003099 ])
3100
Edward Lemur227d5102020-02-25 23:45:35 +00003101 @mock.patch('sys.exit', side_effect=SystemExitMock)
3102 def testRunHook_Failure(self, _mock):
3103 git_cl.time_time.side_effect = [100, 200]
3104 mockProcess = mock.Mock()
3105 mockProcess.wait.return_value = 2
3106 subprocess2.Popen.return_value = mockProcess
3107
3108 cl = git_cl.Changelist()
3109 with self.assertRaises(SystemExitMock):
3110 cl.RunHook(
3111 committing=True,
3112 may_prompt=True,
3113 verbose=2,
3114 parallel=True,
3115 upstream='upstream',
3116 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003117 all_files=True,
3118 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003119
3120 sys.exit.assert_called_once_with(2)
3121
Edward Lemur75526302020-02-27 22:31:05 +00003122 def testRunPostUploadHook(self):
3123 cl = git_cl.Changelist()
3124 cl.RunPostUploadHook(2, 'upstream', 'description')
3125
3126 subprocess2.Popen.assert_called_once_with([
3127 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00003128 '--root', 'root',
3129 '--upstream', 'upstream',
3130 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00003131 '--author', 'author',
3132 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur75526302020-02-27 22:31:05 +00003133 '--issue', '123456',
3134 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003135 '--post_upload',
3136 '--description_file', '/tmp/fake-temp1',
3137 ])
3138 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00003139 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00003140
Edward Lemur9aa1a962020-02-25 00:58:38 +00003141
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003142class CMDTestCaseBase(unittest.TestCase):
3143 _STATUSES = [
3144 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3145 'INFRA_FAILURE', 'CANCELED',
3146 ]
3147 _CHANGE_DETAIL = {
3148 'project': 'depot_tools',
3149 'status': 'OPEN',
3150 'owner': {'email': 'owner@e.mail'},
3151 'current_revision': 'beeeeeef',
3152 'revisions': {
Gavin Make61ccc52020-11-13 00:12:57 +00003153 'deadbeaf': {
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003154 '_number': 6,
Gavin Make61ccc52020-11-13 00:12:57 +00003155 'kind': 'REWORK',
3156 },
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003157 'beeeeeef': {
3158 '_number': 7,
Gavin Make61ccc52020-11-13 00:12:57 +00003159 'kind': 'NO_CODE_CHANGE',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003160 'fetch': {'http': {
3161 'url': 'https://chromium.googlesource.com/depot_tools',
3162 'ref': 'refs/changes/56/123456/7'
3163 }},
3164 },
3165 },
3166 }
3167 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003168 'builds': [{
3169 'id': str(100 + idx),
3170 'builder': {
3171 'project': 'chromium',
3172 'bucket': 'try',
3173 'builder': 'bot_' + status.lower(),
3174 },
3175 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3176 'tags': [],
3177 'status': status,
3178 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003179 }
3180
Edward Lemur4c707a22019-09-24 21:13:43 +00003181 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003182 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003183 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003184 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3185 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003186 mock.patch(
3187 'git_cl.Changelist.GetCodereviewServer',
3188 return_value='https://chromium-review.googlesource.com').start()
3189 mock.patch(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00003190 'git_cl.Changelist.GetGerritHost',
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003191 return_value='chromium-review.googlesource.com').start()
3192 mock.patch(
3193 'git_cl.Changelist.GetMostRecentPatchset',
3194 return_value=7).start()
3195 mock.patch(
Gavin Make61ccc52020-11-13 00:12:57 +00003196 'git_cl.Changelist.GetMostRecentDryRunPatchset',
3197 return_value=6).start()
3198 mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003199 'git_cl.Changelist.GetRemoteUrl',
3200 return_value='https://chromium.googlesource.com/depot_tools').start()
3201 mock.patch(
3202 'auth.Authenticator',
3203 return_value=AuthenticatorMock()).start()
3204 mock.patch(
3205 'gerrit_util.GetChangeDetail',
3206 return_value=self._CHANGE_DETAIL).start()
3207 mock.patch(
3208 'git_cl._call_buildbucket',
3209 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003210 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003211 self.addCleanup(mock.patch.stopall)
3212
Edward Lemur4c707a22019-09-24 21:13:43 +00003213
Edward Lemur9468eba2020-02-27 19:07:22 +00003214class CMDPresubmitTestCase(CMDTestCaseBase):
3215 def setUp(self):
3216 super(CMDPresubmitTestCase, self).setUp()
3217 mock.patch(
3218 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3219 return_value='upstream').start()
3220 mock.patch(
3221 'git_cl.Changelist.FetchDescription',
3222 return_value='fetch description').start()
3223 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00003224 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00003225 return_value='get description').start()
3226 mock.patch('git_cl.Changelist.RunHook').start()
3227
3228 def testDefaultCase(self):
3229 self.assertEqual(0, git_cl.main(['presubmit']))
3230 git_cl.Changelist.RunHook.assert_called_once_with(
3231 committing=True,
3232 may_prompt=False,
3233 verbose=0,
3234 parallel=None,
3235 upstream='upstream',
3236 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003237 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003238 resultdb=None,
3239 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003240
3241 def testNoIssue(self):
3242 git_cl.Changelist.GetIssue.return_value = None
3243 self.assertEqual(0, git_cl.main(['presubmit']))
3244 git_cl.Changelist.RunHook.assert_called_once_with(
3245 committing=True,
3246 may_prompt=False,
3247 verbose=0,
3248 parallel=None,
3249 upstream='upstream',
3250 description='get description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003251 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003252 resultdb=None,
3253 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003254
3255 def testCustomBranch(self):
3256 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3257 git_cl.Changelist.RunHook.assert_called_once_with(
3258 committing=True,
3259 may_prompt=False,
3260 verbose=0,
3261 parallel=None,
3262 upstream='custom_branch',
3263 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003264 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003265 resultdb=None,
3266 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003267
3268 def testOptions(self):
3269 self.assertEqual(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003270 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003271 '--resultdb', '--realm', 'chromium:public']))
Edward Lemur9468eba2020-02-27 19:07:22 +00003272 git_cl.Changelist.RunHook.assert_called_once_with(
3273 committing=False,
3274 may_prompt=False,
3275 verbose=2,
3276 parallel=True,
3277 upstream='upstream',
3278 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003279 all_files=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003280 resultdb=True,
3281 realm='chromium:public')
Edward Lemur9468eba2020-02-27 19:07:22 +00003282
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003283class CMDTryResultsTestCase(CMDTestCaseBase):
3284 _DEFAULT_REQUEST = {
3285 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003286 "gerritChanges": [{
3287 "project": "depot_tools",
3288 "host": "chromium-review.googlesource.com",
Gavin Make61ccc52020-11-13 00:12:57 +00003289 "patchset": 6,
3290 "change": 123456,
3291 }],
3292 },
3293 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3294 ',builds.*.createTime,builds.*.tags'),
3295 }
3296
3297 _TRIVIAL_REQUEST = {
3298 'predicate': {
3299 "gerritChanges": [{
3300 "project": "depot_tools",
3301 "host": "chromium-review.googlesource.com",
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003302 "patchset": 7,
3303 "change": 123456,
3304 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003305 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003306 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3307 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003308 }
3309
3310 def testNoJobs(self):
3311 git_cl._call_buildbucket.return_value = {}
3312
3313 self.assertEqual(0, git_cl.main(['try-results']))
3314 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3315 git_cl._call_buildbucket.assert_called_once_with(
3316 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3317 self._DEFAULT_REQUEST)
3318
Gavin Make61ccc52020-11-13 00:12:57 +00003319 def testTrivialCommits(self):
3320 self.assertEqual(0, git_cl.main(['try-results']))
3321 git_cl._call_buildbucket.assert_called_with(
3322 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3323 self._DEFAULT_REQUEST)
3324
3325 git_cl._call_buildbucket.return_value = {}
3326 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '7']))
3327 git_cl._call_buildbucket.assert_called_with(
3328 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3329 self._TRIVIAL_REQUEST)
3330 self.assertEqual([
3331 'Successes:',
3332 ' bot_success https://ci.chromium.org/b/103',
3333 'Infra Failures:',
3334 ' bot_infra_failure https://ci.chromium.org/b/105',
3335 'Failures:',
3336 ' bot_failure https://ci.chromium.org/b/104',
3337 'Canceled:',
3338 ' bot_canceled ',
3339 'Started:',
3340 ' bot_started https://ci.chromium.org/b/102',
3341 'Scheduled:',
3342 ' bot_scheduled id=101',
3343 'Other:',
3344 ' bot_status_unspecified id=100',
3345 'Total: 7 tryjobs',
3346 'No tryjobs scheduled.',
3347 ], sys.stdout.getvalue().splitlines())
3348
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003349 def testPrintToStdout(self):
3350 self.assertEqual(0, git_cl.main(['try-results']))
3351 self.assertEqual([
3352 'Successes:',
3353 ' bot_success https://ci.chromium.org/b/103',
3354 'Infra Failures:',
3355 ' bot_infra_failure https://ci.chromium.org/b/105',
3356 'Failures:',
3357 ' bot_failure https://ci.chromium.org/b/104',
3358 'Canceled:',
3359 ' bot_canceled ',
3360 'Started:',
3361 ' bot_started https://ci.chromium.org/b/102',
3362 'Scheduled:',
3363 ' bot_scheduled id=101',
3364 'Other:',
3365 ' bot_status_unspecified id=100',
3366 'Total: 7 tryjobs',
3367 ], sys.stdout.getvalue().splitlines())
3368 git_cl._call_buildbucket.assert_called_once_with(
3369 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3370 self._DEFAULT_REQUEST)
3371
3372 def testPrintToStdoutWithMasters(self):
3373 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3374 self.assertEqual([
3375 'Successes:',
3376 ' try bot_success https://ci.chromium.org/b/103',
3377 'Infra Failures:',
3378 ' try bot_infra_failure https://ci.chromium.org/b/105',
3379 'Failures:',
3380 ' try bot_failure https://ci.chromium.org/b/104',
3381 'Canceled:',
3382 ' try bot_canceled ',
3383 'Started:',
3384 ' try bot_started https://ci.chromium.org/b/102',
3385 'Scheduled:',
3386 ' try bot_scheduled id=101',
3387 'Other:',
3388 ' try bot_status_unspecified id=100',
3389 'Total: 7 tryjobs',
3390 ], sys.stdout.getvalue().splitlines())
3391 git_cl._call_buildbucket.assert_called_once_with(
3392 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3393 self._DEFAULT_REQUEST)
3394
3395 @mock.patch('git_cl.write_json')
3396 def testWriteToJson(self, mockJsonDump):
3397 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3398 git_cl._call_buildbucket.assert_called_once_with(
3399 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3400 self._DEFAULT_REQUEST)
3401 mockJsonDump.assert_called_once_with(
3402 'file.json', self._DEFAULT_RESPONSE['builds'])
3403
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003404 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003405 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3406 self.assertEqual(
3407 [
3408 ('chromium', 'try', 'bot_failure'),
3409 ('chromium', 'try', 'bot_infra_failure'),
3410 ],
3411 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003412
3413 def test_filter_failed_for_retry_many_builds(self):
3414
3415 def _build(name, created_sec, status, experimental=False):
3416 assert 0 <= created_sec < 100, created_sec
3417 b = {
3418 'id': 112112,
3419 'builder': {
3420 'project': 'chromium',
3421 'bucket': 'try',
3422 'builder': name,
3423 },
3424 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3425 'status': status,
3426 'tags': [],
3427 }
3428 if experimental:
3429 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3430 return b
3431
3432 builds = [
3433 _build('flaky-last-green', 1, 'FAILURE'),
3434 _build('flaky-last-green', 2, 'SUCCESS'),
3435 _build('flaky', 1, 'SUCCESS'),
3436 _build('flaky', 2, 'FAILURE'),
3437 _build('running', 1, 'FAILED'),
3438 _build('running', 2, 'SCHEDULED'),
3439 _build('yep-still-running', 1, 'STARTED'),
3440 _build('yep-still-running', 2, 'FAILURE'),
3441 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3442 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3443
3444 # Simulate experimental in CQ builder, which developer decided
3445 # to retry manually which resulted in 2nd build non-experimental.
3446 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3447 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3448 ]
3449 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003450 self.assertEqual(
3451 [
3452 ('chromium', 'try', 'flaky'),
3453 ('chromium', 'try', 'sometimes-experimental'),
3454 ],
3455 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003456
3457
3458class CMDTryTestCase(CMDTestCaseBase):
3459
3460 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003461 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003462 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003463 self.assertEqual(0, git_cl.main(['try']))
3464 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3465 self.assertEqual(
3466 sys.stdout.getvalue(),
3467 'Scheduling CQ dry run on: '
3468 'https://chromium-review.googlesource.com/123456\n')
3469
Edward Lemur4c707a22019-09-24 21:13:43 +00003470 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003471 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003472 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003473
3474 self.assertEqual(0, git_cl.main([
3475 'try', '-B', 'luci.chromium.try', '-b', 'win',
3476 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3477 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003478 'Scheduling jobs on:\n'
3479 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003480 git_cl.sys.stdout.getvalue())
3481
3482 expected_request = {
3483 "requests": [{
3484 "scheduleBuild": {
3485 "requestId": "uuid4",
3486 "builder": {
3487 "project": "chromium",
3488 "builder": "win",
3489 "bucket": "try",
3490 },
3491 "gerritChanges": [{
3492 "project": "depot_tools",
3493 "host": "chromium-review.googlesource.com",
3494 "patchset": 7,
3495 "change": 123456,
3496 }],
3497 "properties": {
3498 "category": "git_cl_try",
3499 "json": [{"a": 1}, None],
3500 "key": "val",
3501 },
3502 "tags": [
3503 {"value": "win", "key": "builder"},
3504 {"value": "git_cl_try", "key": "user_agent"},
3505 ],
3506 },
3507 }],
3508 }
3509 mockCallBuildbucket.assert_called_with(
3510 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3511
Anthony Polito1a5fe232020-01-24 23:17:52 +00003512 @mock.patch('git_cl._call_buildbucket')
3513 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3514 mockCallBuildbucket.return_value = {}
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003515 mock.patch('git_cl.Changelist.GetRemoteBranch',
3516 return_value=('origin', 'refs/remotes/origin/main')).start()
Anthony Polito1a5fe232020-01-24 23:17:52 +00003517
3518 self.assertEqual(0, git_cl.main([
3519 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3520 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3521 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3522 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003523 'Scheduling jobs on:\n'
3524 ' chromium/try: linux\n'
3525 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003526 git_cl.sys.stdout.getvalue())
3527
3528 expected_request = {
3529 "requests": [{
3530 "scheduleBuild": {
3531 "requestId": "uuid4",
3532 "builder": {
3533 "project": "chromium",
3534 "builder": "linux",
3535 "bucket": "try",
3536 },
3537 "gerritChanges": [{
3538 "project": "depot_tools",
3539 "host": "chromium-review.googlesource.com",
3540 "patchset": 7,
3541 "change": 123456,
3542 }],
3543 "properties": {
3544 "category": "git_cl_try",
3545 "json": [{"a": 1}, None],
3546 "key": "val",
3547 },
3548 "tags": [
3549 {"value": "linux", "key": "builder"},
3550 {"value": "git_cl_try", "key": "user_agent"},
3551 ],
3552 "gitilesCommit": {
3553 "host": "chromium-review.googlesource.com",
3554 "project": "depot_tools",
3555 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003556 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003557 }
3558 },
3559 },
3560 {
3561 "scheduleBuild": {
3562 "requestId": "uuid4",
3563 "builder": {
3564 "project": "chromium",
3565 "builder": "win",
3566 "bucket": "try",
3567 },
3568 "gerritChanges": [{
3569 "project": "depot_tools",
3570 "host": "chromium-review.googlesource.com",
3571 "patchset": 7,
3572 "change": 123456,
3573 }],
3574 "properties": {
3575 "category": "git_cl_try",
3576 "json": [{"a": 1}, None],
3577 "key": "val",
3578 },
3579 "tags": [
3580 {"value": "win", "key": "builder"},
3581 {"value": "git_cl_try", "key": "user_agent"},
3582 ],
3583 "gitilesCommit": {
3584 "host": "chromium-review.googlesource.com",
3585 "project": "depot_tools",
3586 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003587 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003588 }
3589 },
3590 }],
3591 }
3592 mockCallBuildbucket.assert_called_with(
3593 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3594
Edward Lemur45768512020-03-02 19:03:14 +00003595 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003596 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003597 with self.assertRaises(SystemExit):
3598 git_cl.main([
3599 'try', '-B', 'not-a-bucket', '-b', 'win',
3600 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003601 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003602 'Invalid bucket: not-a-bucket.',
3603 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003604
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003605 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003606 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003607 def testScheduleOnBuildbucketRetryFailed(
3608 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003609 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003610 7: [],
3611 6: [{
3612 'id': 112112,
3613 'builder': {
3614 'project': 'chromium',
3615 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003616 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003617 'createTime': '2019-10-09T08:00:01.854286Z',
3618 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003619 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003620 mockCallBuildbucket.return_value = {}
3621
3622 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3623 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003624 'Scheduling jobs on:\n'
3625 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003626 git_cl.sys.stdout.getvalue())
3627
3628 expected_request = {
3629 "requests": [{
3630 "scheduleBuild": {
3631 "requestId": "uuid4",
3632 "builder": {
3633 "project": "chromium",
3634 "bucket": "try",
3635 "builder": "linux",
3636 },
3637 "gerritChanges": [{
3638 "project": "depot_tools",
3639 "host": "chromium-review.googlesource.com",
3640 "patchset": 7,
3641 "change": 123456,
3642 }],
3643 "properties": {
3644 "category": "git_cl_try",
3645 },
3646 "tags": [
3647 {"value": "linux", "key": "builder"},
3648 {"value": "git_cl_try", "key": "user_agent"},
3649 {"value": "1", "key": "retry_failed"},
3650 ],
3651 },
3652 }],
3653 }
3654 mockCallBuildbucket.assert_called_with(
3655 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3656
Edward Lemur4c707a22019-09-24 21:13:43 +00003657 def test_parse_bucket(self):
3658 test_cases = [
3659 {
3660 'bucket': 'chromium/try',
3661 'result': ('chromium', 'try'),
3662 },
3663 {
3664 'bucket': 'luci.chromium.try',
3665 'result': ('chromium', 'try'),
3666 'has_warning': True,
3667 },
3668 {
3669 'bucket': 'skia.primary',
3670 'result': ('skia', 'skia.primary'),
3671 'has_warning': True,
3672 },
3673 {
3674 'bucket': 'not-a-bucket',
3675 'result': (None, None),
3676 },
3677 ]
3678
3679 for test_case in test_cases:
3680 git_cl.sys.stdout.truncate(0)
3681 self.assertEqual(
3682 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3683 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003684 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3685 test_case['result'])
3686 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003687
3688
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003689class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003690
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003691 def setUp(self):
3692 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003693 mock.patch('git_cl._fetch_tryjobs').start()
3694 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003695 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003696 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3697 mock.patch(
3698 'git_cl.Settings.GetSquashGerritUploads',
3699 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003700 self.addCleanup(mock.patch.stopall)
3701
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003702 def testWarmUpChangeDetailCache(self):
3703 self.assertEqual(0, git_cl.main(['upload']))
3704 gerrit_util.GetChangeDetail.assert_called_once_with(
3705 'chromium-review.googlesource.com', 'depot_tools~123456',
3706 frozenset([
3707 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3708 'CURRENT_COMMIT']))
3709
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003710 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003711 # This test mocks out the actual upload part, and just asserts that after
3712 # upload, if --retry-failed is added, then the tool will fetch try jobs
3713 # from the previous patchset and trigger the right builders on the latest
3714 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003715 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003716 # Latest patchset: No builds.
3717 [],
3718 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003719 [{
3720 'id': str(100 + idx),
3721 'builder': {
3722 'project': 'chromium',
3723 'bucket': 'try',
3724 'builder': 'bot_' + status.lower(),
3725 },
3726 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3727 'tags': [],
3728 'status': status,
3729 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003730 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003731
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003732 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003733 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003734 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3735 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003736 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003737 expected_buckets = [
3738 ('chromium', 'try', 'bot_failure'),
3739 ('chromium', 'try', 'bot_infra_failure'),
3740 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003741 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3742 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003743
Brian Sheedy59b06a82019-10-14 17:03:29 +00003744
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003745class MakeRequestsHelperTestCase(unittest.TestCase):
3746
3747 def exampleGerritChange(self):
3748 return {
3749 'host': 'chromium-review.googlesource.com',
3750 'project': 'depot_tools',
3751 'change': 1,
3752 'patchset': 2,
3753 }
3754
3755 def testMakeRequestsHelperNoOptions(self):
3756 # Basic test for the helper function _make_tryjob_schedule_requests;
3757 # it shouldn't throw AttributeError even when options doesn't have any
3758 # of the expected values; it will use default option values.
3759 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3760 jobs = [('chromium', 'try', 'my-builder')]
3761 options = optparse.Values()
3762 requests = git_cl._make_tryjob_schedule_requests(
3763 changelist, jobs, options, patchset=None)
3764
3765 # requestId is non-deterministic. Just assert that it's there and has
3766 # a particular length.
3767 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3768 self.assertEqual(requests, [{
3769 'scheduleBuild': {
3770 'builder': {
3771 'bucket': 'try',
3772 'builder': 'my-builder',
3773 'project': 'chromium'
3774 },
3775 'gerritChanges': [self.exampleGerritChange()],
3776 'properties': {
3777 'category': 'git_cl_try'
3778 },
3779 'tags': [{
3780 'key': 'builder',
3781 'value': 'my-builder'
3782 }, {
3783 'key': 'user_agent',
3784 'value': 'git_cl_try'
3785 }]
3786 }
3787 }])
3788
3789 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3790 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3791 jobs = [('chromium', 'try', 'presubmit')]
3792 options = optparse.Values()
3793 requests = git_cl._make_tryjob_schedule_requests(
3794 changelist, jobs, options, patchset=None)
3795 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3796 'category': 'git_cl_try',
3797 'dry_run': 'true'
3798 })
3799
3800 def testMakeRequestsHelperRevisionSet(self):
3801 # Gitiles commit is specified when revision is in options.
3802 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3803 jobs = [('chromium', 'try', 'my-builder')]
3804 options = optparse.Values({'revision': 'ba5eba11'})
3805 requests = git_cl._make_tryjob_schedule_requests(
3806 changelist, jobs, options, patchset=None)
3807 self.assertEqual(
3808 requests[0]['scheduleBuild']['gitilesCommit'], {
3809 'host': 'chromium-review.googlesource.com',
3810 'id': 'ba5eba11',
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003811 'project': 'depot_tools',
3812 'ref': 'refs/heads/main',
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003813 })
3814
3815 def testMakeRequestsHelperRetryFailedSet(self):
3816 # An extra tag is added when retry_failed is in options.
3817 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3818 jobs = [('chromium', 'try', 'my-builder')]
3819 options = optparse.Values({'retry_failed': 'true'})
3820 requests = git_cl._make_tryjob_schedule_requests(
3821 changelist, jobs, options, patchset=None)
3822 self.assertEqual(
3823 requests[0]['scheduleBuild']['tags'], [
3824 {
3825 'key': 'builder',
3826 'value': 'my-builder'
3827 },
3828 {
3829 'key': 'user_agent',
3830 'value': 'git_cl_try'
3831 },
3832 {
3833 'key': 'retry_failed',
3834 'value': '1'
3835 }
3836 ])
3837
3838 def testMakeRequestsHelperCategorySet(self):
Quinten Yearsley925cedb2020-04-13 17:49:39 +00003839 # The category property can be overridden with options.
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003840 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3841 jobs = [('chromium', 'try', 'my-builder')]
3842 options = optparse.Values({'category': 'my-special-category'})
3843 requests = git_cl._make_tryjob_schedule_requests(
3844 changelist, jobs, options, patchset=None)
3845 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3846 {'category': 'my-special-category'})
3847
3848
Edward Lemurda4b6c62020-02-13 00:28:40 +00003849class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003850
3851 def setUp(self):
3852 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003853 mock.patch('git_cl.RunCommand').start()
3854 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3855 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3856 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003857 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003858 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003859
3860 def tearDown(self):
3861 shutil.rmtree(self._top_dir)
3862 super(CMDFormatTestCase, self).tearDown()
3863
Jamie Madill5e96ad12020-01-13 16:08:35 +00003864 def _make_temp_file(self, fname, contents):
3865 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3866 tf.write('\n'.join(contents))
3867
Brian Sheedy59b06a82019-10-14 17:03:29 +00003868 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003869 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003870
Brian Sheedyb4307d52019-12-02 19:18:17 +00003871 def _check_yapf_filtering(self, files, expected):
3872 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3873 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003874
Edward Lemur1a83da12020-03-04 21:18:36 +00003875 def _run_command_mock(self, return_value):
3876 def f(*args, **kwargs):
3877 if 'stdin' in kwargs:
3878 self.assertIsInstance(kwargs['stdin'], bytes)
3879 return return_value
3880 return f
3881
Jamie Madill5e96ad12020-01-13 16:08:35 +00003882 def testClangFormatDiffFull(self):
3883 self._make_temp_file('test.cc', ['// test'])
3884 git_cl.settings.GetFormatFullByDefault.return_value = False
3885 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3886 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3887
3888 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003889 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003890 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3891 self._top_dir, 'HEAD')
3892 self.assertEqual(2, return_value)
3893
3894 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003895 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003896 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3897 self._top_dir, 'HEAD')
3898 self.assertEqual(0, return_value)
3899
3900 def testClangFormatDiff(self):
3901 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00003902 # A valid file is required, so use this test.
3903 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00003904 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3905
3906 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003907 git_cl.RunCommand.side_effect = self._run_command_mock('error')
3908 return_value = git_cl._RunClangFormatDiff(
3909 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003910 self.assertEqual(2, return_value)
3911
3912 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003913 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003914 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3915 'HEAD')
3916 self.assertEqual(0, return_value)
3917
Brian Sheedyb4307d52019-12-02 19:18:17 +00003918 def testYapfignoreExplicit(self):
3919 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3920 files = [
3921 'bar.py',
3922 'foo/bar.py',
3923 'foo/baz.py',
3924 'foo/bar/baz.py',
3925 'foo/bar/foobar.py',
3926 ]
3927 expected = [
3928 'bar.py',
3929 'foo/baz.py',
3930 'foo/bar/foobar.py',
3931 ]
3932 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003933
Brian Sheedyb4307d52019-12-02 19:18:17 +00003934 def testYapfignoreSingleWildcards(self):
3935 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3936 files = [
3937 'bar.py', # Matched by *bar.py.
3938 'bar.txt',
3939 'foobar.py', # Matched by *bar.py, foo*.
3940 'foobar.txt', # Matched by foo*.
3941 'bazbar.py', # Matched by *bar.py, baz*.py.
3942 'bazbar.txt',
3943 'foo/baz.txt', # Matched by foo*.
3944 'bar/bar.py', # Matched by *bar.py.
3945 'baz/foo.py', # Matched by baz*.py, foo*.
3946 'baz/foo.txt',
3947 ]
3948 expected = [
3949 'bar.txt',
3950 'bazbar.txt',
3951 'baz/foo.txt',
3952 ]
3953 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003954
Brian Sheedyb4307d52019-12-02 19:18:17 +00003955 def testYapfignoreMultiplewildcards(self):
3956 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3957 files = [
3958 'bar.py', # Matched by *bar*.
3959 'bar.txt', # Matched by *bar*.
3960 'abar.py', # Matched by *bar*.
3961 'foobaz.txt', # Matched by *foo*baz.txt.
3962 'foobaz.py',
3963 'afoobaz.txt', # Matched by *foo*baz.txt.
3964 ]
3965 expected = [
3966 'foobaz.py',
3967 ]
3968 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003969
3970 def testYapfignoreComments(self):
3971 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003972 files = [
3973 'test.py',
3974 'test2.py',
3975 ]
3976 expected = [
3977 'test2.py',
3978 ]
3979 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003980
3981 def testYapfignoreBlankLines(self):
3982 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003983 files = [
3984 'test.py',
3985 'test2.py',
3986 'test3.py',
3987 ]
3988 expected = [
3989 'test3.py',
3990 ]
3991 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003992
3993 def testYapfignoreWhitespace(self):
3994 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003995 files = [
3996 'test.py',
3997 'test2.py',
3998 ]
3999 expected = [
4000 'test2.py',
4001 ]
4002 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004003
Brian Sheedyb4307d52019-12-02 19:18:17 +00004004 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00004005 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004006 self._check_yapf_filtering([], [])
4007
4008 def testYapfignoreMissingYapfignore(self):
4009 files = [
4010 'test.py',
4011 ]
4012 expected = [
4013 'test.py',
4014 ]
4015 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004016
4017
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004018class CMDStatusTestCase(CMDTestCaseBase):
4019 # Return branch names a,..,f with comitterdates in increasing order, i.e.
4020 # 'f' is the most-recently changed branch.
4021 def _mock_run_git(commands):
4022 if commands == [
4023 'for-each-ref', '--format=%(refname) %(committerdate:unix)',
4024 'refs/heads'
4025 ]:
4026 branches_and_committerdates = [
4027 'refs/heads/a 1',
4028 'refs/heads/b 2',
4029 'refs/heads/c 3',
4030 'refs/heads/d 4',
4031 'refs/heads/e 5',
4032 'refs/heads/f 6',
4033 ]
4034 return '\n'.join(branches_and_committerdates)
4035
4036 # Mock the status in such a way that the issue number gives us an
4037 # indication of the commit date (simplifies manual debugging).
4038 def _mock_get_cl_statuses(branches, fine_grained, max_processes):
4039 for c in branches:
4040 c.issue = (100 + int(c.GetCommitDate()))
4041 yield (c, 'open')
4042
4043 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4044 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4045 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4046 @mock.patch('git_cl.RunGit', _mock_run_git)
4047 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4048 @mock.patch('git_cl.Settings.GetRoot', return_value='')
4049 @mock.patch('scm.GIT.GetBranch', return_value='a')
4050 def testStatus(self, *_mocks):
4051 self.assertEqual(0, git_cl.main(['status', '--no-branch-color']))
4052 self.maxDiff = None
4053 self.assertEqual(
4054 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4055 ' * a : https://crrev.com/c/101 (open)\n'
4056 ' b : https://crrev.com/c/102 (open)\n'
4057 ' c : https://crrev.com/c/103 (open)\n'
4058 ' d : https://crrev.com/c/104 (open)\n'
4059 ' e : https://crrev.com/c/105 (open)\n'
4060 ' f : https://crrev.com/c/106 (open)\n\n'
4061 'Current branch: a\n'
4062 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4063 'Issue description:\n'
4064 'x\n')
4065
4066 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4067 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4068 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4069 @mock.patch('git_cl.RunGit', _mock_run_git)
4070 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4071 @mock.patch('git_cl.Settings.GetRoot', return_value='')
4072 @mock.patch('scm.GIT.GetBranch', return_value='a')
4073 def testStatusByDate(self, *_mocks):
4074 self.assertEqual(
4075 0, git_cl.main(['status', '--no-branch-color', '--date-order']))
4076 self.maxDiff = None
4077 self.assertEqual(
4078 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4079 ' f : https://crrev.com/c/106 (open)\n'
4080 ' e : https://crrev.com/c/105 (open)\n'
4081 ' d : https://crrev.com/c/104 (open)\n'
4082 ' c : https://crrev.com/c/103 (open)\n'
4083 ' b : https://crrev.com/c/102 (open)\n'
4084 ' * a : https://crrev.com/c/101 (open)\n\n'
4085 'Current branch: a\n'
4086 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4087 'Issue description:\n'
4088 'x\n')
4089
4090
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004091class CMDOwnersTestCase(CMDTestCaseBase):
4092 def setUp(self):
4093 super(CMDOwnersTestCase, self).setUp()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004094 self.owners_by_path = {
4095 'foo': ['a@example.com'],
4096 'bar': ['b@example.com', 'c@example.com'],
4097 }
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004098 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
4099 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
4100 mock.patch(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004101 'git_cl.Changelist.GetAffectedFiles',
4102 return_value=list(self.owners_by_path)).start()
4103 mock.patch(
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004104 'git_cl.Changelist.GetCommonAncestorWithUpstream',
4105 return_value='upstream').start()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004106 mock.patch(
4107 'owners_client.DepotToolsClient.BatchListOwners',
4108 return_value=self.owners_by_path).start()
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004109 self.addCleanup(mock.patch.stopall)
4110
4111 def testShowAllNoArgs(self):
4112 self.assertEqual(0, git_cl.main(['owners', '--show-all']))
4113 self.assertEqual(
4114 'No files specified for --show-all. Nothing to do.\n',
4115 git_cl.sys.stdout.getvalue())
4116
4117 def testShowAll(self):
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004118 self.assertEqual(
4119 0,
4120 git_cl.main(['owners', '--show-all', 'foo', 'bar', 'baz']))
Edward Lesmes82b992a2021-01-11 23:24:55 +00004121 owners_client.DepotToolsClient.BatchListOwners.assert_called_once_with(
4122 ['foo', 'bar', 'baz'])
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004123 self.assertEqual(
4124 '\n'.join([
4125 'Owners for foo:',
4126 ' - a@example.com',
4127 'Owners for bar:',
4128 ' - b@example.com',
4129 ' - c@example.com',
4130 'Owners for baz:',
4131 ' - No owners found',
4132 '',
4133 ]),
4134 sys.stdout.getvalue())
4135
Edward Lesmes82b992a2021-01-11 23:24:55 +00004136 def testBatch(self):
4137 self.assertEqual(0, git_cl.main(['owners', '--batch']))
4138 self.assertIn('a@example.com', sys.stdout.getvalue())
4139 self.assertIn('b@example.com', sys.stdout.getvalue())
4140
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004141
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004142if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01004143 logging.basicConfig(
4144 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004145 unittest.main()