blob: 05d51465b11ba39faebc8c5c894b534a8eff0d69 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
34# We have to disable monitoring before importing git_cl.
35metrics.DISABLE_METRICS_COLLECTION = True
36
Jamie Madill5e96ad12020-01-13 16:08:35 +000037import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000038import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000039import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000040import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000041import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000042import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000043import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000044import git_new_branch
45import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000046import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000047
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000048
Edward Lemur0db01f02019-11-12 22:01:51 +000049def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070050 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
51
tandrii5d48c322016-08-18 16:19:37 -070052CERR1 = callError(1)
53
54
Edward Lemur1773f372020-02-22 00:27:14 +000055class TemporaryFileMock(object):
56 def __init__(self):
57 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070058
Edward Lemur1773f372020-02-22 00:27:14 +000059 @contextlib.contextmanager
60 def __call__(self):
61 self.suffix += 1
62 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070063
64
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000065class ChangelistMock(object):
66 # A class variable so we can access it when we don't have access to the
67 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000068 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000069
70 def __init__(self, gerrit_change=None, **kwargs):
71 self._gerrit_change = gerrit_change
72
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 def GetIssue(self):
74 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000075
Edward Lemur6c6827c2020-02-06 21:15:18 +000076 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000077 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000078
dsansomee2d6fd92016-09-08 00:10:47 -070079 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000080 ChangelistMock.desc = desc
81
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000082 def GetGerritChange(self, patchset=None, **kwargs):
83 del patchset
84 return self._gerrit_change
85
tandrii5d48c322016-08-18 16:19:37 -070086
Edward Lemur85153282020-02-14 22:06:29 +000087class GitMocks(object):
88 def __init__(self, config=None, branchref=None):
89 self.branchref = branchref or 'refs/heads/master'
90 self.config = config or {}
91
92 def GetBranchRef(self, _root):
93 return self.branchref
94
95 def NewBranch(self, branchref):
96 self.branchref = branchref
97
Edward Lemur26964072020-02-19 19:18:51 +000098 def GetConfig(self, root, key, default=None):
99 if root != '':
100 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000101 return self.config.get(key, default)
102
Edward Lemur26964072020-02-19 19:18:51 +0000103 def SetConfig(self, root, key, value=None):
104 if root != '':
105 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000106 if value:
107 self.config[key] = value
108 return
109 if key not in self.config:
110 raise CERR1
111 del self.config[key]
112
113
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000114class WatchlistsMock(object):
115 def __init__(self, _):
116 pass
117 @staticmethod
118 def GetWatchersForPaths(_):
119 return ['joe@example.com']
120
121
Edward Lemur4c707a22019-09-24 21:13:43 +0000122class CodereviewSettingsFileMock(object):
123 def __init__(self):
124 pass
125 # pylint: disable=no-self-use
126 def read(self):
127 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
128 'GERRIT_HOST: True\n')
129
130
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000131class AuthenticatorMock(object):
132 def __init__(self, *_args):
133 pass
134 def has_cached_credentials(self):
135 return True
tandrii221ab252016-10-06 08:12:04 -0700136 def authorize(self, http):
137 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000138
139
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100140def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000141 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
142
143 Usage:
144 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100145 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000146
147 OR
148 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100149 CookiesAuthenticatorMockFactory(
150 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000151 """
152 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800153 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000154 # Intentionally not calling super() because it reads actual cookie files.
155 pass
156 @classmethod
157 def get_gitcookies_path(cls):
158 return '~/.gitcookies'
159 @classmethod
160 def get_netrc_path(cls):
161 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100162 def _get_auth_for_host(self, host):
163 if same_auth:
164 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000165 return (hosts_with_creds or {}).get(host)
166 return CookiesAuthenticatorMock
167
Aaron Gable9a03ae02017-11-03 11:31:07 -0700168
kmarshall9249e012016-08-23 12:02:16 -0700169class MockChangelistWithBranchAndIssue():
170 def __init__(self, branch, issue):
171 self.branch = branch
172 self.issue = issue
173 def GetBranch(self):
174 return self.branch
175 def GetIssue(self):
176 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000177
tandriic2405f52016-10-10 08:13:15 -0700178
179class SystemExitMock(Exception):
180 pass
181
182
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000183class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000184 def setUp(self):
185 mock.patch('sys.exit', side_effect=SystemExitMock).start()
186 mock.patch('sys.stdout', StringIO()).start()
187 mock.patch('sys.stderr', StringIO()).start()
188 self.addCleanup(mock.patch.stopall)
189
190 def test_die_with_error(self):
191 with self.assertRaises(SystemExitMock):
192 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
193 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
194 self.assertTrue('saving CL description' in sys.stdout.getvalue())
195 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
196 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
197 sys.exit.assert_called_once_with(1)
198
199 def test_die_with_error_no_desc(self):
200 with self.assertRaises(SystemExitMock):
201 git_cl.DieWithError('foo')
202 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
203 self.assertEqual(sys.stdout.getvalue(), '')
204 sys.exit.assert_called_once_with(1)
205
Edward Lemur6c6827c2020-02-06 21:15:18 +0000206 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000207 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100208 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000209 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700210
Edward Lemur61bf4172020-02-24 23:22:37 +0000211 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
212 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
213 def test_get_cl_statuses(self, *_mocks):
214 statuses = [
215 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
216 changes = []
217 for status in statuses:
218 cl = git_cl.Changelist()
219 cl.status = status
220 changes.append(cl)
221
222 actual = set(git_cl.get_cl_statuses(changes, True))
223 self.assertEqual(set(zip(changes, statuses)), actual)
224
225 def test_get_cl_statuses_no_changes(self):
226 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
227
228 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
229 @mock.patch('multiprocessing.pool.ThreadPool')
230 def test_get_cl_statuses_timeout(self, *_mocks):
231 changes = [git_cl.Changelist() for _ in range(2)]
232 pool = multiprocessing.pool.ThreadPool()
233 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
234 it.return_value.next.side_effect = [
235 (changes[0], 'lgtm'),
236 multiprocessing.TimeoutError,
237 ]
238
239 actual = list(git_cl.get_cl_statuses(changes, True))
240 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
241
242 @mock.patch('git_cl.Changelist.GetIssueURL')
243 def test_get_cl_statuses_not_finegrained(self, _mock):
244 changes = [git_cl.Changelist() for _ in range(2)]
245 urls = ['some-url', None]
246 git_cl.Changelist.GetIssueURL.side_effect = urls
247
248 actual = set(git_cl.get_cl_statuses(changes, False))
249 self.assertEqual(
250 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
251
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000252 def test_get_issue_url(self):
253 cl = git_cl.Changelist(issue=123)
254 cl._gerrit_server = 'https://example.com'
255 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
256 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
257
258 cl = git_cl.Changelist(issue=123)
259 cl._gerrit_server = 'https://chromium-review.googlesource.com'
260 self.assertEqual(cl.GetIssueURL(),
261 'https://chromium-review.googlesource.com/123')
262 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
263
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000264 def test_set_preserve_tryjobs(self):
265 d = git_cl.ChangeDescription('Simple.')
266 d.set_preserve_tryjobs()
267 self.assertEqual(d.description.splitlines(), [
268 'Simple.',
269 '',
270 'Cq-Do-Not-Cancel-Tryjobs: true',
271 ])
272 before = d.description
273 d.set_preserve_tryjobs()
274 self.assertEqual(before, d.description)
275
276 d = git_cl.ChangeDescription('\n'.join([
277 'One is enough',
278 '',
279 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
280 'Change-Id: Ideadbeef',
281 ]))
282 d.set_preserve_tryjobs()
283 self.assertEqual(d.description.splitlines(), [
284 'One is enough',
285 '',
286 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
287 'Change-Id: Ideadbeef',
288 'Cq-Do-Not-Cancel-Tryjobs: true',
289 ])
290
tandriif9aefb72016-07-01 09:06:51 -0700291 def test_get_bug_line_values(self):
292 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
293 self.assertEqual(f('', ''), [])
294 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
295 self.assertEqual(f('v8', '456'), ['v8:456'])
296 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
297 # Not nice, but not worth carying.
298 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
299 ['v8:456', 'chromium:123', 'v8:123'])
300
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100301 def _test_git_number(self, parent_msg, dest_ref, child_msg,
302 parent_hash='parenthash'):
303 desc = git_cl.ChangeDescription(child_msg)
304 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
305 return desc.description
306
307 def assertEqualByLine(self, actual, expected):
308 self.assertEqual(actual.splitlines(), expected.splitlines())
309
310 def test_git_number_bad_parent(self):
311 with self.assertRaises(ValueError):
312 self._test_git_number('Parent', 'refs/heads/master', 'Child')
313
314 def test_git_number_bad_parent_footer(self):
315 with self.assertRaises(AssertionError):
316 self._test_git_number(
317 'Parent\n'
318 '\n'
319 'Cr-Commit-Position: wrong',
320 'refs/heads/master', 'Child')
321
322 def test_git_number_bad_lineage_ignored(self):
323 actual = self._test_git_number(
324 'Parent\n'
325 '\n'
326 'Cr-Commit-Position: refs/heads/master@{#1}\n'
327 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
328 'refs/heads/master', 'Child')
329 self.assertEqualByLine(
330 actual,
331 'Child\n'
332 '\n'
333 'Cr-Commit-Position: refs/heads/master@{#2}\n'
334 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
335
336 def test_git_number_same_branch(self):
337 actual = self._test_git_number(
338 'Parent\n'
339 '\n'
340 'Cr-Commit-Position: refs/heads/master@{#12}',
341 dest_ref='refs/heads/master',
342 child_msg='Child')
343 self.assertEqualByLine(
344 actual,
345 'Child\n'
346 '\n'
347 'Cr-Commit-Position: refs/heads/master@{#13}')
348
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200349 def test_git_number_same_branch_mixed_footers(self):
350 actual = self._test_git_number(
351 'Parent\n'
352 '\n'
353 'Cr-Commit-Position: refs/heads/master@{#12}',
354 dest_ref='refs/heads/master',
355 child_msg='Child\n'
356 '\n'
357 'Broken-by: design\n'
358 'BUG=123')
359 self.assertEqualByLine(
360 actual,
361 'Child\n'
362 '\n'
363 'Broken-by: design\n'
364 'BUG=123\n'
365 'Cr-Commit-Position: refs/heads/master@{#13}')
366
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100367 def test_git_number_same_branch_with_originals(self):
368 actual = self._test_git_number(
369 'Parent\n'
370 '\n'
371 'Cr-Commit-Position: refs/heads/master@{#12}',
372 dest_ref='refs/heads/master',
373 child_msg='Child\n'
374 '\n'
375 'Some users are smart and insert their own footers\n'
376 '\n'
377 'Cr-Whatever: value\n'
378 'Cr-Commit-Position: refs/copy/paste@{#22}')
379 self.assertEqualByLine(
380 actual,
381 'Child\n'
382 '\n'
383 'Some users are smart and insert their own footers\n'
384 '\n'
385 'Cr-Original-Whatever: value\n'
386 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
387 'Cr-Commit-Position: refs/heads/master@{#13}')
388
389 def test_git_number_new_branch(self):
390 actual = self._test_git_number(
391 'Parent\n'
392 '\n'
393 'Cr-Commit-Position: refs/heads/master@{#12}',
394 dest_ref='refs/heads/branch',
395 child_msg='Child')
396 self.assertEqualByLine(
397 actual,
398 'Child\n'
399 '\n'
400 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
401 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
402
403 def test_git_number_lineage(self):
404 actual = self._test_git_number(
405 'Parent\n'
406 '\n'
407 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
408 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
409 dest_ref='refs/heads/branch',
410 child_msg='Child')
411 self.assertEqualByLine(
412 actual,
413 'Child\n'
414 '\n'
415 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
416 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
417
418 def test_git_number_moooooooore_lineage(self):
419 actual = self._test_git_number(
420 'Parent\n'
421 '\n'
422 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
423 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
424 dest_ref='refs/heads/mooore',
425 child_msg='Child')
426 self.assertEqualByLine(
427 actual,
428 'Child\n'
429 '\n'
430 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
431 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
432 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
433
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100434 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700435 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100436 actual = self._test_git_number(
437 'CQ commit on fresh new branch + numbering.\n'
438 '\n'
439 'NOTRY=True\n'
440 'NOPRESUBMIT=True\n'
441 'BUG=\n'
442 '\n'
443 'Review-Url: https://codereview.chromium.org/2577703003\n'
444 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
445 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
446 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
447 dest_ref='refs/heads/gnumb-test/cl',
448 child_msg='git cl on fresh new branch + numbering.\n'
449 '\n'
450 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
451 self.assertEqualByLine(
452 actual,
453 'git cl on fresh new branch + numbering.\n'
454 '\n'
455 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
456 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
457 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
458 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
459 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100460
461 def test_git_number_cherry_pick(self):
462 actual = self._test_git_number(
463 'Parent\n'
464 '\n'
465 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
466 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
467 dest_ref='refs/heads/branch',
468 child_msg='Child, which is cherry-pick from master\n'
469 '\n'
470 'Cr-Commit-Position: refs/heads/master@{#100}\n'
471 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
472 self.assertEqualByLine(
473 actual,
474 'Child, which is cherry-pick from master\n'
475 '\n'
476 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
477 '\n'
478 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
479 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
480 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
481
Edward Lemurda4b6c62020-02-13 00:28:40 +0000482 @mock.patch('gerrit_util.GetAccountDetails')
483 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000484 mock_per_account = {
485 'u1': None, # 404, doesn't exist.
486 'u2': {
487 '_account_id': 123124,
488 'avatars': [],
489 'email': 'u2@example.com',
490 'name': 'User Number 2',
491 'status': 'OOO',
492 },
493 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
494 }
495 def GetAccountDetailsMock(_, account):
496 # Poor-man's mock library's side_effect.
497 v = mock_per_account.pop(account)
498 if isinstance(v, Exception):
499 raise v
500 return v
501
Edward Lemurda4b6c62020-02-13 00:28:40 +0000502 mockGetAccountDetails.side_effect = GetAccountDetailsMock
503 actual = git_cl.gerrit_util.ValidAccounts(
504 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000505 self.assertEqual(actual, {
506 'u2': {
507 '_account_id': 123124,
508 'avatars': [],
509 'email': 'u2@example.com',
510 'name': 'User Number 2',
511 'status': 'OOO',
512 },
513 })
514
515
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200516class TestParseIssueURL(unittest.TestCase):
517 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000518 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200519 self.assertIsNotNone(parsed)
520 if fail:
521 self.assertFalse(parsed.valid)
522 return
523 self.assertTrue(parsed.valid)
524 self.assertEqual(parsed.issue, issue)
525 self.assertEqual(parsed.patchset, patchset)
526 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200527
Edward Lemur678a6842019-10-03 22:25:05 +0000528 def test_ParseIssueNumberArgument(self):
529 def test(arg, *args, **kwargs):
530 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200531
Edward Lemur678a6842019-10-03 22:25:05 +0000532 test('123', 123)
533 test('', fail=True)
534 test('abc', fail=True)
535 test('123/1', fail=True)
536 test('123a', fail=True)
537 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200538
Edward Lemur678a6842019-10-03 22:25:05 +0000539 test('https://codereview.source.com/123',
540 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200541 test('http://chrome-review.source.com/c/123',
542 123, None, 'chrome-review.source.com')
543 test('https://chrome-review.source.com/c/123/',
544 123, None, 'chrome-review.source.com')
545 test('https://chrome-review.source.com/c/123/4',
546 123, 4, 'chrome-review.source.com')
547 test('https://chrome-review.source.com/#/c/123/4',
548 123, 4, 'chrome-review.source.com')
549 test('https://chrome-review.source.com/c/123/4',
550 123, 4, 'chrome-review.source.com')
551 test('https://chrome-review.source.com/123',
552 123, None, 'chrome-review.source.com')
553 test('https://chrome-review.source.com/123/4',
554 123, 4, 'chrome-review.source.com')
555
Edward Lemur678a6842019-10-03 22:25:05 +0000556 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200557 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
558 test('https://chrome-review.source.com/c/abc/', fail=True)
559 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
560
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200561
562
Edward Lemurda4b6c62020-02-13 00:28:40 +0000563class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100564 def setUp(self):
565 super(GitCookiesCheckerTest, self).setUp()
566 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100567 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000568 mock.patch('sys.stdout', StringIO()).start()
569 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100570
571 def mock_hosts_creds(self, subhost_identity_pairs):
572 def ensure_googlesource(h):
573 if not h.endswith(self.c._GOOGLESOURCE):
574 assert not h.endswith('.')
575 return h + '.' + self.c._GOOGLESOURCE
576 return h
577 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
578 for h, i in subhost_identity_pairs]
579
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200580 def test_identity_parsing(self):
581 self.assertEqual(self.c._parse_identity('ldap.google.com'),
582 ('ldap', 'google.com'))
583 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
584 ('ldap', 'example.com'))
585 # Specical case because we know there are no subdomains in chromium.org.
586 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
587 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800588 # Pathological: ".period." can be either username OR domain, more likely
589 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200590 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
591 ('note', 'period.example.com'))
592
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100593 def test_analysis_nothing(self):
594 self.c._all_hosts = []
595 self.assertFalse(self.c.has_generic_host())
596 self.assertEqual(set(), self.c.get_conflicting_hosts())
597 self.assertEqual(set(), self.c.get_duplicated_hosts())
598 self.assertEqual(set(), self.c.get_partially_configured_hosts())
599 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
600
601 def test_analysis(self):
602 self.mock_hosts_creds([
603 ('.googlesource.com', 'git-example.chromium.org'),
604
605 ('chromium', 'git-example.google.com'),
606 ('chromium-review', 'git-example.google.com'),
607 ('chrome-internal', 'git-example.chromium.org'),
608 ('chrome-internal-review', 'git-example.chromium.org'),
609 ('conflict', 'git-example.google.com'),
610 ('conflict-review', 'git-example.chromium.org'),
611 ('dup', 'git-example.google.com'),
612 ('dup', 'git-example.google.com'),
613 ('dup-review', 'git-example.google.com'),
614 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200615 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100616 ])
617 self.assertTrue(self.c.has_generic_host())
618 self.assertEqual(set(['conflict.googlesource.com']),
619 self.c.get_conflicting_hosts())
620 self.assertEqual(set(['dup.googlesource.com']),
621 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200622 self.assertEqual(set(['partial.googlesource.com',
623 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100624 self.c.get_partially_configured_hosts())
625 self.assertEqual(set(['chromium.googlesource.com',
626 'chrome-internal.googlesource.com']),
627 self.c.get_hosts_with_wrong_identities())
628
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100629 def test_report_no_problems(self):
630 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100631 self.assertFalse(self.c.find_and_report_problems())
632 self.assertEqual(sys.stdout.getvalue(), '')
633
Edward Lemurda4b6c62020-02-13 00:28:40 +0000634 @mock.patch(
635 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
636 return_value='~/.gitcookies')
637 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100638 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100639 self.assertTrue(self.c.find_and_report_problems())
640 with open(os.path.join(os.path.dirname(__file__),
641 'git_cl_creds_check_report.txt')) as f:
642 expected = f.read()
643 def by_line(text):
644 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700645 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200646 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100647
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800648
Edward Lemurda4b6c62020-02-13 00:28:40 +0000649class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000650 def setUp(self):
651 super(TestGitCl, self).setUp()
652 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700653 self._calls_done = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000654 mock.patch('sys.stdout', StringIO()).start()
655 mock.patch(
656 'git_cl.time_time',
657 lambda: self._mocked_call('time.time')).start()
658 mock.patch(
659 'git_cl.metrics.collector.add_repeated',
660 lambda *a: self._mocked_call('add_repeated', *a)).start()
661 mock.patch('subprocess2.call', self._mocked_call).start()
662 mock.patch('subprocess2.check_call', self._mocked_call).start()
663 mock.patch('subprocess2.check_output', self._mocked_call).start()
664 mock.patch(
665 'subprocess2.communicate',
666 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
667 mock.patch(
668 'git_cl.gclient_utils.CheckCallAndFilter',
669 self._mocked_call).start()
670 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
671 mock.patch(
672 'git_common.get_or_create_merge_base',
673 lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start()
674 mock.patch('git_cl.BranchExists', return_value=True).start()
675 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
676 mock.patch(
677 'git_cl.SaveDescriptionBackup',
678 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
679 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000680 'git_cl.write_json',
681 lambda *a: self._mocked_call('write_json', *a)).start()
682 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000683 'git_cl.Changelist.RunHook',
684 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000685 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
686 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000687 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000688 mock.patch(
689 'git_cl.gerrit_util.GetChangeComments',
690 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
691 mock.patch(
692 'git_cl.gerrit_util.GetChangeRobotComments',
693 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
694 mock.patch(
695 'git_cl.gerrit_util.AddReviewers',
696 lambda *a: self._mocked_call('AddReviewers', *a)).start()
697 mock.patch(
698 'git_cl.gerrit_util.SetReview',
699 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
700 self._mocked_call(
701 'SetReview', h, i, msg, labels, notify, ready))).start()
702 mock.patch(
703 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
704 return_value=False).start()
705 mock.patch(
706 'git_cl.gerrit_util.GceAuthenticator.is_gce',
707 return_value=False).start()
708 mock.patch(
709 'git_cl.gerrit_util.ValidAccounts',
710 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000711 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000712 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000713 self.mockGit = GitMocks()
714 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
715 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
716 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000717 mock.patch(
718 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000719 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000720 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000721 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000722 mock.patch(
723 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000724 # It's important to reset settings to not have inter-tests interference.
725 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000726 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000727
728 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000729 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000730 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100731 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000732 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
733 if len(self.calls) > 5:
734 calls += ' ...\n'
735 self.fail(
736 '\n'
737 'There are un-consumed calls after this test has finished:\n' +
738 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000739 finally:
740 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000741
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000742 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000743 self.assertTrue(
744 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700745 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000746 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000747 expected_args, result = top
748
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000749 # Also logs otherwise it could get caught in a try/finally and be hard to
750 # diagnose.
751 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700752 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000753 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700754 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
755 for i, c in enumerate(self._calls_done[-N:]))
756 following_calls = '\n '.join(
757 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
758 for i, c in enumerate(self.calls[:N]))
759 extended_msg = (
760 'A few prior calls:\n %s\n\n'
761 'This (expected):\n @%d: %r\n'
762 'This (actual):\n @%d: %r\n\n'
763 'A few following expected calls:\n %s' %
764 (prior_calls, len(self._calls_done), expected_args,
765 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700766
tandrii99a72f22016-08-17 14:33:24 -0700767 self.fail('@%d\n'
768 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000769 ' Actual: %r\n'
770 '\n'
771 '%s' % (
772 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700773
774 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700775 if isinstance(result, Exception):
776 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000777 # stdout from git commands is supposed to be a bytestream. Convert it here
778 # instead of converting all test output in this file to bytes.
779 if args[0][0] == 'git' and not isinstance(result, bytes):
780 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000781 return result
782
Edward Lemur1a83da12020-03-04 21:18:36 +0000783 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
784 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100785 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100786 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000787 self.assertEqual(
788 'prompt [Yes/No]: Please, type yes or no: ',
789 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100790
tandrii48df5812016-10-17 03:55:37 -0700791 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000792 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700793 self.calls = [
794 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700795 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
796 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
797 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
798 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700799 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
800 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700801 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
802 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000803 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
804 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700805 ((['git', 'config', 'gerrit.host', 'true'],), ''),
806 ]
807 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
808
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000809 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100810 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200811 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000812 custom_cl_base=None, short_hostname='chromium',
813 change_id=None):
Edward Lemur26964072020-02-19 19:18:51 +0000814 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200815 if custom_cl_base:
816 ancestor_revision = custom_cl_base
817 else:
818 # Determine ancestor_revision to be merge base.
819 ancestor_revision = 'fake_ancestor_sha'
820 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000821 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
822 ancestor_revision),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200823 ]
824
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100825 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000826 gerrit_util.GetChangeDetail.return_value = {
827 'owner': {'email': (other_cl_owner or 'owner@example.com')},
828 'change_id': (change_id or '123456789'),
829 'current_revision': 'sha1_of_current_revision',
830 'revisions': {'sha1_of_current_revision': {
831 'commit': {'message': fetched_description},
832 }},
833 'status': fetched_status or 'NEW',
834 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100835 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100836 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100837 if other_cl_owner:
838 calls += [
839 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
840 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100841
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100842 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200843 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
844 ([custom_cl_base] if custom_cl_base else
845 [ancestor_revision, 'HEAD']),),
846 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100847 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000848
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100849 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000850
Edward Lemur26964072020-02-19 19:18:51 +0000851 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700852 squash_mode='default',
Aaron Gablefd238082017-06-07 13:42:34 -0700853 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100854 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000855 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000856 short_hostname='chromium',
Edward Lemur5a644f82020-03-18 16:44:57 +0000857 labels=None, change_id=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000858 final_description=None, gitcookies_exists=True,
Josipe827b0f2020-01-30 00:07:20 +0000859 force=False, edit_description=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000860 if post_amend_description is None:
861 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700862 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200863
864 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000865
Edward Lemur26964072020-02-19 19:18:51 +0000866 if squash_mode in ('override_squash', 'override_nosquash'):
867 self.mockGit.config['gerrit.override-squash-uploads'] = (
868 'true' if squash_mode == 'override_squash' else 'false')
tandriia60502f2016-06-20 02:01:53 -0700869
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000870 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000871 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200872 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200873 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000874 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000875 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000876 calls += [
877 ((['RunEditor'],), description),
878 ]
Josipe827b0f2020-01-30 00:07:20 +0000879 # user wants to edit description
880 if edit_description:
881 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000882 ((['RunEditor'],), edit_description),
883 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000884 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200885
886 if custom_cl_base is None:
887 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000888 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000889 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200890 ]
891 parent = 'origin/master'
892 else:
893 calls += [
894 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
895 'refs/remotes/origin/master'],),
896 callError(1)), # Means not ancenstor.
897 (('ask_for_data',
898 'Do you take responsibility for cleaning up potential mess '
899 'resulting from proceeding with upload? Press Enter to upload, '
900 'or Ctrl+C to abort'), ''),
901 ]
902 parent = custom_cl_base
903
904 calls += [
905 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
906 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000907 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200908 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000909 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200910 ref_to_push),
911 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000912 else:
913 ref_to_push = 'HEAD'
Edward Lemur5a644f82020-03-18 16:44:57 +0000914 parent = 'origin/refs/heads/master'
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000915
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000916 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000917 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000918 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200919 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000920
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000921 metrics_arguments = []
922
Aaron Gableafd52772017-06-27 16:40:10 -0700923 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700924 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000925 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700926 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400927 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700928 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000929 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700930 else:
931 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000932 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800933
Edward Lemur5a644f82020-03-18 16:44:57 +0000934 # If issue is given, then description is fetched from Gerrit instead.
935 if issue is None:
936 if squash:
937 title = 'Initial upload'
938 else:
939 if not title:
940 calls += [
941 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
942 (('ask_for_data', 'Title for patchset []: '), 'User input'),
943 ]
944 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700945 if title:
Edward Lemur5a644f82020-03-18 16:44:57 +0000946 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000947 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000948
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000949 if short_hostname == 'chromium':
950 # All reviwers and ccs get into ref_suffix.
951 for r in sorted(reviewers):
952 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000953 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000954 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000955 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000956 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000957 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000958 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000959 reviewers, cc = [], []
960 else:
961 # TODO(crbug/877717): remove this case.
962 calls += [
963 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
964 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000965 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000966 {
967 e: {'email': e}
968 for e in (reviewers + ['joe@example.com'] + cc)
969 })
970 ]
971 for r in sorted(reviewers):
972 if r != 'bad-account-or-email':
973 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000974 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000975 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000976 if issue is None:
977 cc += ['joe@example.com']
978 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000979 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000980 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000981 if c in cc:
982 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000983
Edward Lemur687ca902018-12-05 02:30:30 +0000984 for k, v in sorted((labels or {}).items()):
985 ref_suffix += ',l=%s+%d' % (k, v)
986 metrics_arguments.append('l=%s+%d' % (k, v))
987
988 if tbr:
989 calls += [
990 (('GetCodeReviewTbrScore',
991 '%s-review.googlesource.com' % short_hostname,
992 'my/repo'),
993 2,),
994 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000995
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000996 calls += [
997 (('time.time',), 1000,),
998 ((['git', 'push',
999 'https://%s.googlesource.com/my/repo' % short_hostname,
1000 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1001 (('remote:\n'
1002 'remote: Processing changes: (\)\n'
1003 'remote: Processing changes: (|)\n'
1004 'remote: Processing changes: (/)\n'
1005 'remote: Processing changes: (-)\n'
1006 'remote: Processing changes: new: 1 (/)\n'
1007 'remote: Processing changes: new: 1, done\n'
1008 'remote:\n'
1009 'remote: New Changes:\n'
1010 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1011 ' XXX\n'
1012 'remote:\n'
1013 'To https://%s.googlesource.com/my/repo\n'
1014 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1015 ) % (short_hostname, short_hostname)),),
1016 (('time.time',), 2000,),
1017 (('add_repeated',
1018 'sub_commands',
1019 {
1020 'execution_time': 1000,
1021 'command': 'git push',
1022 'exit_code': 0,
1023 'arguments': sorted(metrics_arguments),
1024 }),
1025 None,),
1026 ]
1027
Edward Lemur1b52d872019-05-09 21:12:12 +00001028 final_description = final_description or post_amend_description.strip()
Edward Lemur1b52d872019-05-09 21:12:12 +00001029 # Trace-related calls
1030 calls += [
1031 # Write a description with context for the current trace.
1032 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001033 'Thu Mar 16 20:00:41 2017\n'
1034 '%(short_hostname)s-review.googlesource.com\n'
1035 '%(change_id)s\n'
1036 '%(title)s\n'
1037 '%(description)s\n'
1038 '1000\n'
1039 '0\n'
1040 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001041 'short_hostname': short_hostname,
1042 'change_id': change_id,
1043 'description': final_description,
Edward Lemur5a644f82020-03-18 16:44:57 +00001044 'title': title or '<untitled>',
Edward Lemur75391d42019-05-14 23:35:56 +00001045 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001046 }],),
1047 None,
1048 ),
1049 # Read traces and shorten git hashes.
1050 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1051 True,
1052 ),
1053 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1054 ('git-hash: 0123456789012345678901234567890123456789\n'
1055 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1056 ),
1057 ((['FileWrite', 'TEMP_DIR/trace-packet',
1058 'git-hash: 012345\n'
1059 'git-hash: abcdea\n'],),
1060 None,
1061 ),
1062 # Make zip file for the git traces.
1063 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1064 'TEMP_DIR'],),
1065 None,
1066 ),
1067 # Collect git config and gitcookies.
1068 ((['git', 'config', '-l'],),
1069 'git-config-output',
1070 ),
1071 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1072 None,
1073 ),
1074 ((['os.path.isfile', '~/.gitcookies'],),
1075 gitcookies_exists,
1076 ),
1077 ]
1078 if gitcookies_exists:
1079 calls += [
1080 ((['FileRead', '~/.gitcookies'],),
1081 'gitcookies 1/SECRET',
1082 ),
1083 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1084 None,
1085 ),
1086 ]
1087 calls += [
1088 # Make zip file for the git config and gitcookies.
1089 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1090 'TEMP_DIR'],),
1091 None,
1092 ),
1093 ]
1094
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001095 # TODO(crbug/877717): this should never be used.
1096 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001097 calls += [
1098 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001099 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001100 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001101 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001102 notify),
1103 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001104 ]
Edward Lemur26964072020-02-19 19:18:51 +00001105 calls += [
1106 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
1107 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001108 return calls
1109
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001110 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001111 self,
1112 upload_args,
1113 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001114 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001115 squash=True,
1116 squash_mode=None,
Aaron Gable9b713dd2016-12-14 16:04:21 -08001117 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001118 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001119 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001120 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001121 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001122 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001123 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001124 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001125 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001126 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001127 labels=None,
1128 change_id=None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001129 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001130 gitcookies_exists=True,
1131 force=False,
Josipe827b0f2020-01-30 00:07:20 +00001132 edit_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001133 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001134 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001135 if squash_mode is None:
1136 if '--no-squash' in upload_args:
1137 squash_mode = 'nosquash'
1138 elif '--squash' in upload_args:
1139 squash_mode = 'squash'
1140 else:
1141 squash_mode = 'default'
1142
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001143 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001144 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001145 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001146 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001147 same_auth=('git-owner.example.com', '', 'pass'))).start()
1148 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1149 lambda _, offer_removal: None).start()
1150 mock.patch('git_cl.gclient_utils.RunEditor',
1151 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1152 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
1153 'DownloadGerritHook', force)).start()
1154 mock.patch('git_cl.gclient_utils.FileRead',
1155 lambda path: self._mocked_call(['FileRead', path])).start()
1156 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001157 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001158 ['FileWrite', path, contents])).start()
1159 mock.patch('git_cl.datetime_now',
1160 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1161 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1162 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1163 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001164 '%(now)s\n'
1165 '%(gerrit_host)s\n'
1166 '%(change_id)s\n'
1167 '%(title)s\n'
1168 '%(description)s\n'
1169 '%(execution_time)s\n'
1170 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001171 '%(trace_name)s').start()
1172 mock.patch('git_cl.shutil.make_archive',
1173 lambda *args: self._mocked_call(['make_archive'] +
1174 list(args))).start()
1175 mock.patch('os.path.isfile',
1176 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemurd55c5072020-02-20 01:09:07 +00001177 mock.patch('git_cl.Changelist.GitSanityChecks', return_value=True).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001178 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00001179 'git_cl._create_description_from_log', return_value=description).start()
1180 mock.patch(
1181 'git_cl.Changelist._AddChangeIdToCommitMessage',
1182 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001183 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001184 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1185 mock.patch(
Edward Lemur1a83da12020-03-04 21:18:36 +00001186 'git_cl.ask_for_data',
1187 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001188
Edward Lemur26964072020-02-19 19:18:51 +00001189 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001190 self.mockGit.config['branch.master.gerritissue'] = (
1191 str(issue) if issue else None)
1192 self.mockGit.config['remote.origin.url'] = (
1193 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001194 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001195
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001196 self.calls = self._gerrit_base_calls(
1197 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001198 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001199 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001200 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001201 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001202 short_hostname=short_hostname,
1203 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001204 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001205 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001206 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001207 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001208 self.calls += self._gerrit_upload_calls(
1209 description, reviewers, squash,
1210 squash_mode=squash_mode,
Aaron Gablefd238082017-06-07 13:42:34 -07001211 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001212 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001213 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001214 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001215 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001216 labels=labels,
1217 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001218 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001219 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001220 force=force,
1221 edit_description=edit_description)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001222 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001223 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001224 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001225 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001226 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001227 self.assertEqual(
1228 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001229 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001230
Edward Lemur1b52d872019-05-09 21:12:12 +00001231 def test_gerrit_upload_traces_no_gitcookies(self):
1232 self._run_gerrit_upload_test(
1233 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001234 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001235 [],
1236 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001237 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001238 change_id='Ixxx',
1239 gitcookies_exists=False)
1240
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001241 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001242 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001243 [],
1244 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1245 [],
1246 change_id='Ixxx')
1247
1248 def test_gerrit_upload_without_change_id_nosquash(self):
1249 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001250 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001251 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001252 [],
1253 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001254 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001255 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001256
1257 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001258 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001259 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001260 'desc ✔\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001261 [],
tandriia60502f2016-06-20 02:01:53 -07001262 squash=False,
1263 squash_mode='override_nosquash',
Edward Lemur0db01f02019-11-12 22:01:51 +00001264 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001265 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001266
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001267 def test_gerrit_no_reviewer(self):
1268 self._run_gerrit_upload_test(
1269 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001270 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001271 [],
1272 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001273 squash_mode='override_nosquash',
1274 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001275
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001276 def test_gerrit_no_reviewer_non_chromium_host(self):
1277 # TODO(crbug/877717): remove this test case.
1278 self._run_gerrit_upload_test(
1279 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001280 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001281 [],
1282 squash=False,
1283 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001284 short_hostname='other',
1285 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001286
Nick Carter8692b182017-11-06 16:30:38 -08001287 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001288 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001289 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001290 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001291 squash=False,
1292 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001293 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001294 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001295
ukai@chromium.orge8077812012-02-03 03:41:46 +00001296 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001297 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001298 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001299 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001300 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001301 squash=False,
1302 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001303 notify=True,
1304 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001305 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001306 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001307
Anthony Polito8b955342019-09-24 19:01:36 +00001308 def test_gerrit_upload_force_sets_bug(self):
1309 self._run_gerrit_upload_test(
1310 ['-b', '10000', '-f'],
1311 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1312 [],
1313 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001314 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001315 change_id='Ixxx')
1316
Edward Lemur5fb22242020-03-12 22:05:13 +00001317 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001318 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001319 ['-b', '10000', '-m', 'Title', '--edit-description'],
1320 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001321 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001322 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001323 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001324 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001325 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001326 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001327
Dan Beamd8b04ca2019-10-10 21:23:26 +00001328 def test_gerrit_upload_force_sets_fixed(self):
1329 self._run_gerrit_upload_test(
1330 ['-x', '10000', '-f'],
1331 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1332 [],
1333 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001334 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001335 change_id='Ixxx')
1336
ukai@chromium.orge8077812012-02-03 03:41:46 +00001337 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001338 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1339 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001340 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001341 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001342 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001343 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001344 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001345 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001346 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001347 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001348 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001349 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001350
1351 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001352 self._run_gerrit_upload_test(
1353 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001354 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001355 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001356 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001357
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001358 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001359 self._run_gerrit_upload_test(
1360 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001361 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001362 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001363 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001364 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001365
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001366 def test_gerrit_upload_squash_first_with_labels(self):
1367 self._run_gerrit_upload_test(
1368 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001369 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001370 [],
1371 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001372 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001373 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001374
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001375 def test_gerrit_upload_squash_first_against_rev(self):
1376 custom_cl_base = 'custom_cl_base_rev_or_branch'
1377 self._run_gerrit_upload_test(
1378 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001379 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001380 [],
1381 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001382 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001383 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001384 self.assertIn(
1385 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1386 sys.stdout.getvalue())
1387
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001388 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001389 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001390 self._run_gerrit_upload_test(
1391 ['--squash'],
1392 description,
1393 [],
1394 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001395 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001396 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001397
Edward Lemurd55c5072020-02-20 01:09:07 +00001398 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001399 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001400 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001401 with self.assertRaises(SystemExitMock):
1402 self._run_gerrit_upload_test(
1403 ['--squash'],
1404 description,
1405 [],
1406 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001407 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001408 fetched_status='ABANDONED',
1409 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001410 self.assertEqual(
1411 'Change https://chromium-review.googlesource.com/123456 has been '
1412 'abandoned, new uploads are not allowed\n',
1413 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001414
Edward Lemurda4b6c62020-02-13 00:28:40 +00001415 @mock.patch(
1416 'gerrit_util.GetAccountDetails',
1417 return_value={'email': 'yet-another@example.com'})
1418 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001419 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001420 self._run_gerrit_upload_test(
1421 ['--squash'],
1422 description,
1423 [],
1424 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001425 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001426 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001427 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001428 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001429 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001430 'authenticate to Gerrit as yet-another@example.com.\n'
1431 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001432 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001433
Josipe827b0f2020-01-30 00:07:20 +00001434 def test_upload_change_description_editor(self):
1435 fetched_description = 'foo\n\nChange-Id: 123456789'
1436 description = 'bar\n\nChange-Id: 123456789'
1437 self._run_gerrit_upload_test(
1438 ['--squash', '--edit-description'],
1439 description,
1440 [],
1441 fetched_description=fetched_description,
1442 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001443 issue=123456,
1444 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001445 edit_description=description)
1446
Edward Lemurda4b6c62020-02-13 00:28:40 +00001447 @mock.patch('git_cl.RunGit')
1448 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001449 @mock.patch('sys.stdin', StringIO('\n'))
1450 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001451 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001452 def mock_run_git(*args, **_kwargs):
1453 if args[0] == ['for-each-ref',
1454 '--format=%(refname:short) %(upstream:short)',
1455 'refs/heads']:
1456 # Create a local branch dependency tree that looks like this:
1457 # test1 -> test2 -> test3 -> test4 -> test5
1458 # -> test3.1
1459 # test6 -> test0
1460 branch_deps = [
1461 'test2 test1', # test1 -> test2
1462 'test3 test2', # test2 -> test3
1463 'test3.1 test2', # test2 -> test3.1
1464 'test4 test3', # test3 -> test4
1465 'test5 test4', # test4 -> test5
1466 'test6 test0', # test0 -> test6
1467 'test7', # test7
1468 ]
1469 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001470 git_cl.RunGit.side_effect = mock_run_git
1471 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001472
1473 class MockChangelist():
1474 def __init__(self):
1475 pass
1476 def GetBranch(self):
1477 return 'test1'
1478 def GetIssue(self):
1479 return '123'
1480 def GetPatchset(self):
1481 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001482 def IsGerrit(self):
1483 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001484
1485 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1486 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001487 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001488 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001489 'This command will checkout all dependent branches '
1490 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001491 'or Ctrl+C to abort',
1492 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001493 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001494
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001495 def test_gerrit_change_id(self):
1496 self.calls = [
1497 ((['git', 'write-tree'], ),
1498 'hashtree'),
1499 ((['git', 'rev-parse', 'HEAD~0'], ),
1500 'branch-parent'),
1501 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1502 'A B <a@b.org> 1456848326 +0100'),
1503 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1504 'C D <c@d.org> 1456858326 +0100'),
1505 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1506 'hashchange'),
1507 ]
1508 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1509 self.assertEqual(change_id, 'Ihashchange')
1510
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001511 def test_desecription_append_footer(self):
1512 for init_desc, footer_line, expected_desc in [
1513 # Use unique desc first lines for easy test failure identification.
1514 ('foo', 'R=one', 'foo\n\nR=one'),
1515 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1516 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1517 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1518 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1519 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1520 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1521 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1522 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1523 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1524 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1525 ]:
1526 desc = git_cl.ChangeDescription(init_desc)
1527 desc.append_footer(footer_line)
1528 self.assertEqual(desc.description, expected_desc)
1529
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001530 def test_update_reviewers(self):
1531 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001532 ('foo', [], [],
1533 'foo'),
1534 ('foo\nR=xx', [], [],
1535 'foo\nR=xx'),
1536 ('foo\nTBR=xx', [], [],
1537 'foo\nTBR=xx'),
1538 ('foo', ['a@c'], [],
1539 'foo\n\nR=a@c'),
1540 ('foo\nR=xx', ['a@c'], [],
1541 'foo\n\nR=a@c, xx'),
1542 ('foo\nTBR=xx', ['a@c'], [],
1543 'foo\n\nR=a@c\nTBR=xx'),
1544 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1545 'foo\n\nR=a@c, yy\nTBR=xx'),
1546 ('foo\nBUG=', ['a@c'], [],
1547 'foo\nBUG=\nR=a@c'),
1548 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1549 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1550 ('foo', ['a@c', 'b@c'], [],
1551 'foo\n\nR=a@c, b@c'),
1552 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1553 'foo\nBar\n\nR=c@c\nBUG='),
1554 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1555 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001556 # Same as the line before, but full of whitespaces.
1557 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001558 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001559 'foo\nBar\n\nR=c@c\n BUG =',
1560 ),
1561 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001562 ('foo BUG=allo R=joe ', ['c@c'], [],
1563 'foo BUG=allo R=joe\n\nR=c@c'),
1564 # Redundant TBRs get promoted to Rs
1565 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1566 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001567 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001568 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001569 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001570 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001571 obj = git_cl.ChangeDescription(orig)
Edward Lemur2c62b332020-03-12 22:12:33 +00001572 obj.update_reviewers(reviewers, tbrs, None, None, None)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001573 actual.append(obj.description)
1574 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001575
Nodir Turakulov23b82142017-11-16 11:04:25 -08001576 def test_get_hash_tags(self):
1577 cases = [
1578 ('', []),
1579 ('a', []),
1580 ('[a]', ['a']),
1581 ('[aa]', ['aa']),
1582 ('[a ]', ['a']),
1583 ('[a- ]', ['a']),
1584 ('[a- b]', ['a-b']),
1585 ('[a--b]', ['a-b']),
1586 ('[a', []),
1587 ('[a]x', ['a']),
1588 ('[aa]x', ['aa']),
1589 ('[a b]', ['a-b']),
1590 ('[a b]', ['a-b']),
1591 ('[a__b]', ['a-b']),
1592 ('[a] x', ['a']),
1593 ('[a][b]', ['a', 'b']),
1594 ('[a] [b]', ['a', 'b']),
1595 ('[a][b]x', ['a', 'b']),
1596 ('[a][b] x', ['a', 'b']),
1597 ('[a]\n[b]', ['a']),
1598 ('[a\nb]', []),
1599 ('[a][', ['a']),
1600 ('Revert "[a] feature"', ['a']),
1601 ('Reland "[a] feature"', ['a']),
1602 ('Revert: [a] feature', ['a']),
1603 ('Reland: [a] feature', ['a']),
1604 ('Revert "Reland: [a] feature"', ['a']),
1605 ('Foo: feature', ['foo']),
1606 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001607 ('Change Foo::Bar', []),
1608 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001609 ('Revert "Foo bar: feature"', ['foo-bar']),
1610 ('Reland "Foo bar: feature"', ['foo-bar']),
1611 ]
1612 for desc, expected in cases:
1613 change_desc = git_cl.ChangeDescription(desc)
1614 actual = change_desc.get_hash_tags()
1615 self.assertEqual(
1616 actual,
1617 expected,
1618 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1619
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001620 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001621 self.assertEqual(None, git_cl.GetTargetRef(None,
1622 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001623 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001624
wittman@chromium.org455dc922015-01-26 20:15:50 +00001625 # Check default target refs for branches.
1626 self.assertEqual('refs/heads/master',
1627 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001628 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001629 self.assertEqual('refs/heads/master',
1630 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001631 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001632 self.assertEqual('refs/heads/master',
1633 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001634 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001635 self.assertEqual('refs/branch-heads/123',
1636 git_cl.GetTargetRef('origin',
1637 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001638 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001639 self.assertEqual('refs/diff/test',
1640 git_cl.GetTargetRef('origin',
1641 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001642 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001643 self.assertEqual('refs/heads/chrome/m42',
1644 git_cl.GetTargetRef('origin',
1645 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001646 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001647
1648 # Check target refs for user-specified target branch.
1649 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1650 'refs/remotes/branch-heads/123'):
1651 self.assertEqual('refs/branch-heads/123',
1652 git_cl.GetTargetRef('origin',
1653 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001654 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001655 for branch in ('origin/master', 'remotes/origin/master',
1656 'refs/remotes/origin/master'):
1657 self.assertEqual('refs/heads/master',
1658 git_cl.GetTargetRef('origin',
1659 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001660 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001661 for branch in ('master', 'heads/master', 'refs/heads/master'):
1662 self.assertEqual('refs/heads/master',
1663 git_cl.GetTargetRef('origin',
1664 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001665 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001666
Edward Lemurda4b6c62020-02-13 00:28:40 +00001667 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1668 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001669 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001670 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1671
Edward Lemur85153282020-02-14 22:06:29 +00001672 def assertIssueAndPatchset(
1673 self, branch='master', issue='123456', patchset='7',
1674 git_short_host='chromium'):
1675 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001676 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001677 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001678 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001679 self.assertEqual(
1680 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001681 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001682
Edward Lemur85153282020-02-14 22:06:29 +00001683 def _patch_common(self, git_short_host='chromium'):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001684 mock.patch('git_cl.IsGitVersionAtLeast', return_value=True).start()
Edward Lemur26964072020-02-19 19:18:51 +00001685 self.mockGit.config['remote.origin.url'] = (
1686 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001687 gerrit_util.GetChangeDetail.return_value = {
1688 'current_revision': '7777777777',
1689 'revisions': {
1690 '1111111111': {
1691 '_number': 1,
1692 'fetch': {'http': {
1693 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1694 'ref': 'refs/changes/56/123456/1',
1695 }},
1696 },
1697 '7777777777': {
1698 '_number': 7,
1699 'fetch': {'http': {
1700 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1701 'ref': 'refs/changes/56/123456/7',
1702 }},
1703 },
1704 },
1705 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001706
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001707 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001708 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001709 self.calls += [
1710 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1711 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001712 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001713 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001714 ]
1715 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001716 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001717
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001718 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001719 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001720 self.calls += [
1721 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1722 'refs/changes/56/123456/7'],), ''),
1723 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001724 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001725 ]
Edward Lemur85153282020-02-14 22:06:29 +00001726 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1727 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001728
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001729 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001730 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001731 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001732 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001733 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001734 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001735 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001736 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001737 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001738 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001739
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001740 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001741 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001742 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001743 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001744 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001745 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001746 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001747 ]
1748 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001749 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001750 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001751
Aaron Gable697a91b2018-01-19 15:20:15 -08001752 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001753 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001754 self.calls += [
1755 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1756 'refs/changes/56/123456/1'],), ''),
1757 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001758 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Aaron Gable697a91b2018-01-19 15:20:15 -08001759 ]
1760 self.assertEqual(git_cl.main(
1761 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1762 0)
Edward Lemur85153282020-02-14 22:06:29 +00001763 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001764
Edward Lemurd55c5072020-02-20 01:09:07 +00001765 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001766 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001767 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001768 self.calls += [
1769 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001770 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001771 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001772 ]
1773 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001774 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001775 self.assertEqual(
1776 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1777 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001778
Edward Lemurda4b6c62020-02-13 00:28:40 +00001779 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001780 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001781 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001782 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001783 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001784 self.mockGit.config['remote.origin.url'] = (
1785 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001786 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001787 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001788 self.assertEqual(
1789 'change 123456 at https://chromium-review.googlesource.com does not '
1790 'exist or you have no access to it\n',
1791 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001792
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001793 def _checkout_calls(self):
1794 return [
1795 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001796 'branch\\..*\\.gerritissue'], ),
1797 ('branch.ger-branch.gerritissue 123456\n'
1798 'branch.gbranch654.gerritissue 654321\n')),
1799 ]
1800
1801 def test_checkout_gerrit(self):
1802 """Tests git cl checkout <issue>."""
1803 self.calls = self._checkout_calls()
1804 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1805 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1806
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001807 def test_checkout_not_found(self):
1808 """Tests git cl checkout <issue>."""
1809 self.calls = self._checkout_calls()
1810 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1811
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001812 def test_checkout_no_branch_issues(self):
1813 """Tests git cl checkout <issue>."""
1814 self.calls = [
1815 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001816 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001817 ]
1818 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1819
Edward Lemur26964072020-02-19 19:18:51 +00001820 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00001821 mock.patch(
1822 'git_cl.ask_for_data',
1823 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001824 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1825 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001826 self.mockGit.config['remote.origin.url'] = (
1827 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001828 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001829 cl.branch = 'master'
1830 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001831 return cl
1832
Edward Lemurd55c5072020-02-20 01:09:07 +00001833 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001834 def test_gerrit_ensure_authenticated_missing(self):
1835 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001836 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001837 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001838 with self.assertRaises(SystemExitMock):
1839 cl.EnsureAuthenticated(force=False)
1840 self.assertEqual(
1841 'Credentials for the following hosts are required:\n'
1842 ' chromium-review.googlesource.com\n'
1843 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
1844 'You can (re)generate your credentials by visiting '
1845 'https://chromium-review.googlesource.com/new-password\n',
1846 sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001847
1848 def test_gerrit_ensure_authenticated_conflict(self):
1849 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001850 'chromium.googlesource.com':
1851 ('git-one.example.com', None, 'secret1'),
1852 'chromium-review.googlesource.com':
1853 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001854 })
1855 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001856 (('ask_for_data', 'If you know what you are doing '
1857 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001858 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1859
1860 def test_gerrit_ensure_authenticated_ok(self):
1861 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001862 'chromium.googlesource.com':
1863 ('git-same.example.com', None, 'secret'),
1864 'chromium-review.googlesource.com':
1865 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001866 })
1867 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1868
tandrii@chromium.org28253532016-04-14 13:46:56 +00001869 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00001870 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
1871 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00001872 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1873
Eric Boren2fb63102018-10-05 13:05:03 +00001874 def test_gerrit_ensure_authenticated_bearer_token(self):
1875 cl = self._test_gerrit_ensure_authenticated_common(auth={
1876 'chromium.googlesource.com':
1877 ('', None, 'secret'),
1878 'chromium-review.googlesource.com':
1879 ('', None, 'secret'),
1880 })
1881 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1882 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1883 'chromium.googlesource.com')
1884 self.assertTrue('Bearer' in header)
1885
Daniel Chengcf6269b2019-05-18 01:02:12 +00001886 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00001887 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00001888 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001889 (('logging.warning',
1890 'Ignoring branch %(branch)s with non-https remote '
1891 '%(remote)s', {
1892 'branch': 'master',
1893 'remote': 'custom-scheme://repo'}
1894 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001895 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001896 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1897 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1898 mock.patch('logging.warning',
1899 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00001900 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00001901 cl.branch = 'master'
1902 cl.branchref = 'refs/heads/master'
1903 cl.lookedup_issue = True
1904 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1905
Florian Mayerae510e82020-01-30 21:04:48 +00001906 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00001907 self.mockGit.config['remote.origin.url'] = (
1908 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00001909 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001910 (('logging.error',
1911 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1912 'but it doesn\'t exist.', {
1913 'remote': 'origin',
1914 'branch': 'master',
1915 'url': 'git@somehost.example:foo/bar.git'}
1916 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00001917 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001918 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1919 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1920 mock.patch('logging.error',
1921 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00001922 cl = git_cl.Changelist()
1923 cl.branch = 'master'
1924 cl.branchref = 'refs/heads/master'
1925 cl.lookedup_issue = True
1926 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1927
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001928 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00001929 self.mockGit.config['branch.master.gerritissue'] = '123'
1930 self.mockGit.config['branch.master.gerritserver'] = (
1931 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00001932 self.mockGit.config['remote.origin.url'] = (
1933 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001934 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00001935 (('SetReview', 'chromium-review.googlesource.com',
1936 'infra%2Finfra~123', None,
1937 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001938 ]
tandriid9e5ce52016-07-13 02:32:59 -07001939
1940 def test_cmd_set_commit_gerrit_clear(self):
1941 self._cmd_set_commit_gerrit_common(0)
1942 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1943
1944 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001945 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001946 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1947
tandriid9e5ce52016-07-13 02:32:59 -07001948 def test_cmd_set_commit_gerrit(self):
1949 self._cmd_set_commit_gerrit_common(2)
1950 self.assertEqual(0, git_cl.main(['set-commit']))
1951
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001952 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001953 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001954 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001955
1956 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001957 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001958
Edward Lemurda4b6c62020-02-13 00:28:40 +00001959 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07001960 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07001961 try:
1962 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00001963 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001964 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001965 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07001966
1967 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07001968 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001969 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07001970 return 'foobar'
1971
Edward Lemurda4b6c62020-02-13 00:28:40 +00001972 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07001973 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001974 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001975 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001976 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07001977
iannuccie53c9352016-08-17 14:40:40 -07001978 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001979
iannuccie53c9352016-08-17 14:40:40 -07001980 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001981 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07001982 return 'foobar'
1983
Edward Lemurda4b6c62020-02-13 00:28:40 +00001984 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
1985 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07001986 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001987 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001988
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001989 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00001990 self.mockGit.config['remote.origin.url'] = (
1991 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001992 gerrit_util.GetChangeDetail.return_value = {
1993 'current_revision': 'sha1',
1994 'revisions': {'sha1': {
1995 'commit': {'message': 'foobar'},
1996 }},
1997 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001998 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001999 'description',
2000 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2001 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002002 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002003
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002004 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002005 mock.patch('git_cl.Changelist', ChangelistMock).start()
2006 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002007
2008 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2009 self.assertEqual('hihi', ChangelistMock.desc)
2010
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002011 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002012 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002013
2014 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002015 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002016 '# Enter a description of the change.\n'
2017 '# This will be displayed on the codereview site.\n'
2018 '# The first line will also be used as the subject of the review.\n'
2019 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002020 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002021 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002022 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002023 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002024 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002025
Edward Lemur6c6827c2020-02-06 21:15:18 +00002026 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002027 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002028
Edward Lemurda4b6c62020-02-13 00:28:40 +00002029 mock.patch('git_cl.Changelist.FetchDescription',
2030 lambda *args: current_desc).start()
2031 mock.patch('git_cl.Changelist.UpdateDescription',
2032 UpdateDescription).start()
2033 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002034
Edward Lemur85153282020-02-14 22:06:29 +00002035 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002036 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002037
Dan Beamd8b04ca2019-10-10 21:23:26 +00002038 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2039 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2040
2041 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002042 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002043 '# Enter a description of the change.\n'
2044 '# This will be displayed on the codereview site.\n'
2045 '# The first line will also be used as the subject of the review.\n'
2046 '#--------------------This line is 72 characters long'
2047 '--------------------\n'
2048 'Some.\n\nFixed: 123\nChange-Id: xxx',
2049 desc)
2050 return desc
2051
Edward Lemurda4b6c62020-02-13 00:28:40 +00002052 mock.patch('git_cl.Changelist.FetchDescription',
2053 lambda *args: current_desc).start()
2054 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002055
Edward Lemur85153282020-02-14 22:06:29 +00002056 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002057 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002058
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002059 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002060 mock.patch('git_cl.Changelist', ChangelistMock).start()
2061 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002062
2063 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2064 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2065
kmarshall3bff56b2016-06-06 18:31:47 -07002066 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002067 self.calls = [
2068 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002069 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002070 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002071 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002072 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002073 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002074
Edward Lemurda4b6c62020-02-13 00:28:40 +00002075 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002076 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002077 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2078 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002079 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002080
2081 self.assertEqual(0, git_cl.main(['archive', '-f']))
2082
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002083 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002084 self.calls = [
2085 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2086 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2087 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2088 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002089 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2090 ((['git', 'branch', '-D', 'foo'],), '')
2091 ]
2092
Edward Lemurda4b6c62020-02-13 00:28:40 +00002093 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002094 lambda branches, fine_grained, max_processes:
2095 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2096 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002097 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002098
2099 self.assertEqual(0, git_cl.main(['archive', '-f']))
2100
kmarshall3bff56b2016-06-06 18:31:47 -07002101 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002102 self.calls = [
2103 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2104 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002105 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002106 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002107
Edward Lemurda4b6c62020-02-13 00:28:40 +00002108 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002109 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002110 [(MockChangelistWithBranchAndIssue('master', 1),
2111 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002112
2113 self.assertEqual(1, git_cl.main(['archive', '-f']))
2114
2115 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002116 self.calls = [
2117 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2118 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002119 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002120 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002121
Edward Lemurda4b6c62020-02-13 00:28:40 +00002122 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002123 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002124 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2125 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002126 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002127
kmarshall9249e012016-08-23 12:02:16 -07002128 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2129
2130 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002131 self.calls = [
2132 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2133 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002134 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002135 ((['git', 'branch', '-D', 'foo'],), '')
2136 ]
kmarshall9249e012016-08-23 12:02:16 -07002137
Edward Lemurda4b6c62020-02-13 00:28:40 +00002138 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002139 lambda branches, fine_grained, max_processes:
2140 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2141 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002142 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002143
2144 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002145
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002146 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002147 self.calls = [
2148 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2149 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2150 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002151 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2152 'refs/tags/git-cl-archived-456-foo'),
2153 ((['git', 'branch', '-D', 'foo'],), CERR1),
2154 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2155 'refs/tags/git-cl-archived-456-foo'),
2156 ]
2157
Edward Lemurda4b6c62020-02-13 00:28:40 +00002158 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002159 lambda branches, fine_grained, max_processes:
2160 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2161 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002162 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002163
2164 self.assertEqual(0, git_cl.main(['archive', '-f']))
2165
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002166 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002167 self.mockGit.config['branch.master.gerritissue'] = '123'
2168 self.mockGit.config['branch.master.gerritserver'] = (
2169 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002170 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002171 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002172 ]
2173 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002174 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2175 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002176
Aaron Gable400e9892017-07-12 15:31:21 -07002177 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002178 self.mockGit.config['branch.master.gerritissue'] = '123'
2179 self.mockGit.config['branch.master.gerritserver'] = (
2180 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002181 mock.patch('git_cl.Changelist.FetchDescription',
2182 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002183 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002184 ((['git', 'log', '-1', '--format=%B'],),
2185 'This is a description\n\nChange-Id: Ideadbeef'),
2186 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002187 ]
2188 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002189 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2190 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002191
phajdan.jre328cf92016-08-22 04:12:17 -07002192 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002193 self.mockGit.config['branch.master.gerritissue'] = '123'
2194 self.mockGit.config['branch.master.gerritserver'] = (
2195 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002196 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002197 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002198 {'issue': 123,
2199 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002200 ''),
2201 ]
2202 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2203
tandrii16e0b4e2016-06-07 10:34:28 -07002204 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002205 mock.patch(
2206 'git_cl.os.path.abspath',
2207 lambda path: self._mocked_call(['abspath', path])).start()
2208 mock.patch(
2209 'git_cl.os.path.exists',
2210 lambda path: self._mocked_call(['exists', path])).start()
2211 mock.patch(
2212 'git_cl.gclient_utils.FileRead',
2213 lambda path: self._mocked_call(['FileRead', path])).start()
2214 mock.patch(
2215 'git_cl.gclient_utils.rm_file_or_tree',
2216 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002217 mock.patch(
2218 'git_cl.ask_for_data',
2219 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002220 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002221
2222 def test_GerritCommitMsgHookCheck_custom_hook(self):
2223 cl = self._common_GerritCommitMsgHookCheck()
2224 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002225 ((['exists', '.git/hooks/commit-msg'],), True),
2226 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002227 '#!/bin/sh\necho "custom hook"')
2228 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002229 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002230
2231 def test_GerritCommitMsgHookCheck_not_exists(self):
2232 cl = self._common_GerritCommitMsgHookCheck()
2233 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002234 ((['exists', '.git/hooks/commit-msg'],), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002235 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002236 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002237
2238 def test_GerritCommitMsgHookCheck(self):
2239 cl = self._common_GerritCommitMsgHookCheck()
2240 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002241 ((['exists', '.git/hooks/commit-msg'],), True),
2242 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002243 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002244 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002245 ((['rm_file_or_tree', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002246 ''),
2247 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002248 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002249
tandriic4344b52016-08-29 06:04:54 -07002250 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002251 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2252 self.mockGit.config['branch.master.gerritserver'] = (
2253 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002254 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002255 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002256 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002257 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002258 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002259 'labels': {},
2260 'current_revision': 'deadbeaf',
2261 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002262 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002263 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002264 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002265 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2266 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002267 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002268 self.assertEqual(0, cl.CMDLand(force=True,
2269 bypass_hooks=True,
2270 verbose=True,
2271 parallel=False))
Edward Lemur73c76702020-02-06 23:57:18 +00002272 self.assertIn(
2273 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002274 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002275 self.assertIn(
2276 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002277 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002278
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002279 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002280 mock.patch('git_cl.Changelist._GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002281
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002282 def test_gerrit_change_detail_cache_simple(self):
2283 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002284 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002285 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002286 cl1._cached_remote_url = (
2287 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002288 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002289 cl2._cached_remote_url = (
2290 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002291 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2292 self.assertEqual(cl1._GetChangeDetail(), 'a')
2293 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002294
2295 def test_gerrit_change_detail_cache_options(self):
2296 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002297 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002298 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002299 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002300 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2301 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2302 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2303 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2304 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2305 self.assertEqual(cl._GetChangeDetail(), 'cab')
2306
2307 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2308 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2309 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2310 self.assertEqual(cl._GetChangeDetail(), 'cab')
2311
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002312 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002313 gerrit_util.GetChangeDetail.return_value = {
2314 'current_revision': 'rev1',
2315 'revisions': {
2316 'rev1': {'commit': {'message': 'desc1'}},
2317 },
2318 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002319
2320 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002321 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002322 cl._cached_remote_url = (
2323 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002324 self.assertEqual(cl.FetchDescription(), 'desc1')
2325 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002326
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002327 def test_print_current_creds(self):
2328 class CookiesAuthenticatorMock(object):
2329 def __init__(self):
2330 self.gitcookies = {
2331 'host.googlesource.com': ('user', 'pass'),
2332 'host-review.googlesource.com': ('user', 'pass'),
2333 }
2334 self.netrc = self
2335 self.netrc.hosts = {
2336 'github.com': ('user2', None, 'pass2'),
2337 'host2.googlesource.com': ('user3', None, 'pass'),
2338 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002339 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2340 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002341 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2342 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2343 ' Host\t User\t Which file',
2344 '============================\t=====\t===========',
2345 'host-review.googlesource.com\t user\t.gitcookies',
2346 ' host.googlesource.com\t user\t.gitcookies',
2347 ' host2.googlesource.com\tuser3\t .netrc',
2348 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002349 sys.stdout.seek(0)
2350 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002351 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2352 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2353 ' Host\tUser\t Which file',
2354 '============================\t====\t===========',
2355 'host-review.googlesource.com\tuser\t.gitcookies',
2356 ' host.googlesource.com\tuser\t.gitcookies',
2357 ])
2358
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002359 def _common_creds_check_mocks(self):
2360 def exists_mock(path):
2361 dirname = os.path.dirname(path)
2362 if dirname == os.path.expanduser('~'):
2363 dirname = '~'
2364 base = os.path.basename(path)
2365 if base in ('.netrc', '.gitcookies'):
2366 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2367 # git cl also checks for existence other files not relevant to this test.
2368 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002369 mock.patch(
2370 'git_cl.ask_for_data',
2371 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002372 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002373
2374 def test_creds_check_gitcookies_not_configured(self):
2375 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002376 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2377 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002378 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002379 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002380 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2381 (('os.path.exists', '~/.netrc'), True),
2382 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2383 'or Ctrl+C to abort'), ''),
2384 ((['git', 'config', '--global', 'http.cookiefile',
2385 os.path.expanduser('~/.gitcookies')], ), ''),
2386 ]
2387 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002388 self.assertTrue(
2389 sys.stdout.getvalue().startswith(
2390 'You seem to be using outdated .netrc for git credentials:'))
2391 self.assertIn(
2392 '\nConfigured git to use .gitcookies from',
2393 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002394
2395 def test_creds_check_gitcookies_configured_custom_broken(self):
2396 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002397 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2398 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002399 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002400 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002401 ((['git', 'config', '--global', 'http.cookiefile'],),
2402 '/custom/.gitcookies'),
2403 (('os.path.exists', '/custom/.gitcookies'), False),
2404 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2405 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2406 ((['git', 'config', '--global', 'http.cookiefile',
2407 os.path.expanduser('~/.gitcookies')], ), ''),
2408 ]
2409 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002410 self.assertIn(
2411 'WARNING: You have configured custom path to .gitcookies: ',
2412 sys.stdout.getvalue())
2413 self.assertIn(
2414 'However, your configured .gitcookies file is missing.',
2415 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002416
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002417 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002418 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002419 self.mockGit.config['remote.origin.url'] = (
2420 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002421 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002422 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002423 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002424 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002425 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002426 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002427
Edward Lemurda4b6c62020-02-13 00:28:40 +00002428 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2429 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002430 self.mockGit.config['remote.origin.url'] = (
2431 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002432 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002433 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002434 'current_revision': 'ba5eba11',
2435 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002436 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002437 '_number': 1,
2438 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002439 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002440 '_number': 2,
2441 },
2442 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002443 'messages': [
2444 {
2445 u'_revision_number': 1,
2446 u'author': {
2447 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002448 u'email': u'could-be-anything@example.com',
2449 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002450 },
2451 u'date': u'2017-03-15 20:08:45.000000000',
2452 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002453 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002454 u'tag': u'autogenerated:cq:dry-run'
2455 },
2456 {
2457 u'_revision_number': 2,
2458 u'author': {
2459 u'_account_id': 11151243,
2460 u'email': u'owner@example.com',
2461 u'name': u'owner'
2462 },
2463 u'date': u'2017-03-16 20:00:41.000000000',
2464 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2465 u'message': u'PTAL',
2466 },
2467 {
2468 u'_revision_number': 2,
2469 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002470 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002471 u'email': u'reviewer@example.com',
2472 u'name': u'reviewer'
2473 },
2474 u'date': u'2017-03-17 05:19:37.500000000',
2475 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2476 u'message': u'Patch Set 2: Code-Review+1',
2477 },
2478 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002479 }
2480 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002481 (('GetChangeComments', 'chromium-review.googlesource.com',
2482 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002483 '/COMMIT_MSG': [
2484 {
2485 'author': {'email': u'reviewer@example.com'},
2486 'updated': u'2017-03-17 05:19:37.500000000',
2487 'patch_set': 2,
2488 'side': 'REVISION',
2489 'message': 'Please include a bug link',
2490 },
2491 ],
2492 'codereview.settings': [
2493 {
2494 'author': {'email': u'owner@example.com'},
2495 'updated': u'2017-03-16 20:00:41.000000000',
2496 'patch_set': 2,
2497 'side': 'PARENT',
2498 'line': 42,
2499 'message': 'I removed this because it is bad',
2500 },
2501 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002502 }),
2503 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2504 'infra%2Finfra~1'), {}),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002505 ] * 2 + [
2506 (('write_json', 'output.json', [
2507 {
2508 u'date': u'2017-03-16 20:00:41.000000',
2509 u'message': (
2510 u'PTAL\n' +
2511 u'\n' +
2512 u'codereview.settings\n' +
2513 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2514 u'c/1/2/codereview.settings#b42\n' +
2515 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002516 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002517 u'approval': False,
2518 u'disapproval': False,
2519 u'sender': u'owner@example.com'
2520 }, {
2521 u'date': u'2017-03-17 05:19:37.500000',
2522 u'message': (
2523 u'Patch Set 2: Code-Review+1\n' +
2524 u'\n' +
2525 u'/COMMIT_MSG\n' +
2526 u' PS2, File comment: https://chromium-review.googlesource' +
2527 u'.com/c/1/2//COMMIT_MSG#\n' +
2528 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002529 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002530 u'approval': False,
2531 u'disapproval': False,
2532 u'sender': u'reviewer@example.com'
2533 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002534 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002535 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002536 expected_comments_summary = [
2537 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002538 message=(
2539 u'PTAL\n' +
2540 u'\n' +
2541 u'codereview.settings\n' +
2542 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2543 u'c/1/2/codereview.settings#b42\n' +
2544 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002545 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002546 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002547 disapproval=False, approval=False, sender=u'owner@example.com'),
2548 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002549 message=(
2550 u'Patch Set 2: Code-Review+1\n' +
2551 u'\n' +
2552 u'/COMMIT_MSG\n' +
2553 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2554 u'c/1/2//COMMIT_MSG#\n' +
2555 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002556 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002557 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002558 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2559 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002560 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002561 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002562 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002563 self.assertEqual(
2564 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2565
2566 def test_git_cl_comments_robot_comments(self):
2567 # git cl comments also fetches robot comments (which are considered a type
2568 # of autogenerated comment), and unlike other types of comments, only robot
2569 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002570 self.mockGit.config['remote.origin.url'] = (
2571 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002572 gerrit_util.GetChangeDetail.return_value = {
2573 'owner': {'email': 'owner@example.com'},
2574 'current_revision': 'ba5eba11',
2575 'revisions': {
2576 'deadbeaf': {
2577 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002578 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002579 'ba5eba11': {
2580 '_number': 2,
2581 },
2582 },
2583 'messages': [
2584 {
2585 u'_revision_number': 1,
2586 u'author': {
2587 u'_account_id': 1111084,
2588 u'email': u'commit-bot@chromium.org',
2589 u'name': u'Commit Bot'
2590 },
2591 u'date': u'2017-03-15 20:08:45.000000000',
2592 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2593 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2594 u'tag': u'autogenerated:cq:dry-run'
2595 },
2596 {
2597 u'_revision_number': 1,
2598 u'author': {
2599 u'_account_id': 123,
2600 u'email': u'tricium@serviceaccount.com',
2601 u'name': u'Tricium'
2602 },
2603 u'date': u'2017-03-16 20:00:41.000000000',
2604 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2605 u'message': u'(1 comment)',
2606 u'tag': u'autogenerated:tricium',
2607 },
2608 {
2609 u'_revision_number': 1,
2610 u'author': {
2611 u'_account_id': 123,
2612 u'email': u'tricium@serviceaccount.com',
2613 u'name': u'Tricium'
2614 },
2615 u'date': u'2017-03-16 20:00:41.000000000',
2616 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2617 u'message': u'(1 comment)',
2618 u'tag': u'autogenerated:tricium',
2619 },
2620 {
2621 u'_revision_number': 2,
2622 u'author': {
2623 u'_account_id': 123,
2624 u'email': u'tricium@serviceaccount.com',
2625 u'name': u'reviewer'
2626 },
2627 u'date': u'2017-03-17 05:30:37.000000000',
2628 u'tag': u'autogenerated:tricium',
2629 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2630 u'message': u'(1 comment)',
2631 },
2632 ]
2633 }
2634 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002635 (('GetChangeComments', 'chromium-review.googlesource.com',
2636 'infra%2Finfra~1'), {}),
2637 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2638 'infra%2Finfra~1'), {
2639 'codereview.settings': [
2640 {
2641 u'author': {u'email': u'tricium@serviceaccount.com'},
2642 u'updated': u'2017-03-17 05:30:37.000000000',
2643 u'robot_run_id': u'5565031076855808',
2644 u'robot_id': u'Linter/Category',
2645 u'tag': u'autogenerated:tricium',
2646 u'patch_set': 2,
2647 u'side': u'REVISION',
2648 u'message': u'Linter warning message text',
2649 u'line': 32,
2650 },
2651 ],
2652 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002653 ]
2654 expected_comments_summary = [
2655 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2656 message=(
2657 u'(1 comment)\n\ncodereview.settings\n'
2658 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2659 u'c/1/2/codereview.settings#32\n'
2660 u' Linter warning message text\n'),
2661 sender=u'tricium@serviceaccount.com',
2662 autogenerated=True, approval=False, disapproval=False)
2663 ]
2664 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002665 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002666 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002667
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002668 def test_get_remote_url_with_mirror(self):
2669 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002670
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002671 def selective_os_path_isdir_mock(path):
2672 if path == '/cache/this-dir-exists':
2673 return self._mocked_call('os.path.isdir', path)
2674 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002675
Edward Lemurda4b6c62020-02-13 00:28:40 +00002676 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002677
2678 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002679 self.mockGit.config['remote.origin.url'] = (
2680 '/cache/this-dir-exists')
2681 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2682 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002683 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002684 (('os.path.isdir', '/cache/this-dir-exists'),
2685 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002686 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002687 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002688 self.assertEqual(cl.GetRemoteUrl(), url)
2689 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2690
Edward Lemur298f2cf2019-02-22 21:40:39 +00002691 def test_get_remote_url_non_existing_mirror(self):
2692 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002693
Edward Lemur298f2cf2019-02-22 21:40:39 +00002694 def selective_os_path_isdir_mock(path):
2695 if path == '/cache/this-dir-doesnt-exist':
2696 return self._mocked_call('os.path.isdir', path)
2697 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002698
Edward Lemurda4b6c62020-02-13 00:28:40 +00002699 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2700 mock.patch('logging.error',
2701 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002702
Edward Lemur26964072020-02-19 19:18:51 +00002703 self.mockGit.config['remote.origin.url'] = (
2704 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002705 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002706 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2707 False),
2708 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002709 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2710 'but it doesn\'t exist.', {
2711 'remote': 'origin',
2712 'branch': 'master',
2713 'url': '/cache/this-dir-doesnt-exist'}
2714 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002715 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002716 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002717 self.assertIsNone(cl.GetRemoteUrl())
2718
2719 def test_get_remote_url_misconfigured_mirror(self):
2720 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002721
Edward Lemur298f2cf2019-02-22 21:40:39 +00002722 def selective_os_path_isdir_mock(path):
2723 if path == '/cache/this-dir-exists':
2724 return self._mocked_call('os.path.isdir', path)
2725 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002726
Edward Lemurda4b6c62020-02-13 00:28:40 +00002727 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2728 mock.patch('logging.error',
2729 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002730
Edward Lemur26964072020-02-19 19:18:51 +00002731 self.mockGit.config['remote.origin.url'] = (
2732 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002733 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002734 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002735 (('logging.error',
2736 'Remote "%(remote)s" for branch "%(branch)s" points to '
2737 '"%(cache_path)s", but it is misconfigured.\n'
2738 '"%(cache_path)s" must be a git repo and must have a remote named '
2739 '"%(remote)s" pointing to the git host.', {
2740 'remote': 'origin',
2741 'cache_path': '/cache/this-dir-exists',
2742 'branch': 'master'}
2743 ), None),
2744 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002745 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002746 self.assertIsNone(cl.GetRemoteUrl())
2747
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002748 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002749 self.mockGit.config['remote.origin.url'] = (
2750 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002751 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002752 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2753
2754 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002755 mock.patch('logging.error',
2756 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002757
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002758 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002759 (('logging.error',
2760 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2761 'but it doesn\'t exist.', {
2762 'remote': 'origin',
2763 'branch': 'master',
2764 'url': ''}
2765 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002766 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002767 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002768 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002769
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002770
Edward Lemur9aa1a962020-02-25 00:58:38 +00002771class ChangelistTest(unittest.TestCase):
Edward Lemur227d5102020-02-25 23:45:35 +00002772 def setUp(self):
2773 super(ChangelistTest, self).setUp()
2774 mock.patch('gclient_utils.FileRead').start()
2775 mock.patch('gclient_utils.FileWrite').start()
2776 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
2777 mock.patch(
2778 'git_cl.Changelist.GetCodereviewServer',
2779 return_value='https://chromium-review.googlesource.com').start()
2780 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
2781 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
2782 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
2783 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
2784 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
2785 mock.patch('git_cl.time_time').start()
2786 mock.patch('metrics.collector').start()
2787 mock.patch('subprocess2.Popen').start()
2788 self.addCleanup(mock.patch.stopall)
2789 self.temp_count = 0
2790
Edward Lemur227d5102020-02-25 23:45:35 +00002791 def testRunHook(self):
2792 expected_results = {
2793 'more_cc': ['more@example.com', 'cc@example.com'],
2794 'should_continue': True,
2795 }
2796 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2797 git_cl.time_time.side_effect = [100, 200]
2798 mockProcess = mock.Mock()
2799 mockProcess.wait.return_value = 0
2800 subprocess2.Popen.return_value = mockProcess
2801
2802 cl = git_cl.Changelist()
2803 results = cl.RunHook(
2804 committing=True,
2805 may_prompt=True,
2806 verbose=2,
2807 parallel=True,
2808 upstream='upstream',
2809 description='description',
2810 all_files=True)
2811
2812 self.assertEqual(expected_results, results)
2813 subprocess2.Popen.assert_called_once_with([
2814 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00002815 '--root', 'root',
2816 '--upstream', 'upstream',
2817 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002818 '--author', 'author',
2819 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00002820 '--issue', '123456',
2821 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002822 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00002823 '--may_prompt',
2824 '--parallel',
2825 '--all_files',
2826 '--json_output', '/tmp/fake-temp2',
2827 '--description_file', '/tmp/fake-temp1',
2828 ])
2829 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002830 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00002831 metrics.collector.add_repeated('sub_commands', {
2832 'command': 'presubmit',
2833 'execution_time': 100,
2834 'exit_code': 0,
2835 })
2836
Edward Lemur99df04e2020-03-05 19:39:43 +00002837 def testRunHook_FewerOptions(self):
2838 expected_results = {
2839 'more_cc': ['more@example.com', 'cc@example.com'],
2840 'should_continue': True,
2841 }
2842 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2843 git_cl.time_time.side_effect = [100, 200]
2844 mockProcess = mock.Mock()
2845 mockProcess.wait.return_value = 0
2846 subprocess2.Popen.return_value = mockProcess
2847
2848 git_cl.Changelist.GetAuthor.return_value = None
2849 git_cl.Changelist.GetIssue.return_value = None
2850 git_cl.Changelist.GetPatchset.return_value = None
2851 git_cl.Changelist.GetCodereviewServer.return_value = None
2852
2853 cl = git_cl.Changelist()
2854 results = cl.RunHook(
2855 committing=False,
2856 may_prompt=False,
2857 verbose=0,
2858 parallel=False,
2859 upstream='upstream',
2860 description='description',
2861 all_files=False)
2862
2863 self.assertEqual(expected_results, results)
2864 subprocess2.Popen.assert_called_once_with([
2865 'vpython', 'PRESUBMIT_SUPPORT',
2866 '--root', 'root',
2867 '--upstream', 'upstream',
2868 '--upload',
2869 '--json_output', '/tmp/fake-temp2',
2870 '--description_file', '/tmp/fake-temp1',
2871 ])
2872 gclient_utils.FileWrite.assert_called_once_with(
2873 '/tmp/fake-temp1', 'description')
2874 metrics.collector.add_repeated('sub_commands', {
2875 'command': 'presubmit',
2876 'execution_time': 100,
2877 'exit_code': 0,
2878 })
2879
Edward Lemur227d5102020-02-25 23:45:35 +00002880 @mock.patch('sys.exit', side_effect=SystemExitMock)
2881 def testRunHook_Failure(self, _mock):
2882 git_cl.time_time.side_effect = [100, 200]
2883 mockProcess = mock.Mock()
2884 mockProcess.wait.return_value = 2
2885 subprocess2.Popen.return_value = mockProcess
2886
2887 cl = git_cl.Changelist()
2888 with self.assertRaises(SystemExitMock):
2889 cl.RunHook(
2890 committing=True,
2891 may_prompt=True,
2892 verbose=2,
2893 parallel=True,
2894 upstream='upstream',
2895 description='description',
2896 all_files=True)
2897
2898 sys.exit.assert_called_once_with(2)
2899
Edward Lemur75526302020-02-27 22:31:05 +00002900 def testRunPostUploadHook(self):
2901 cl = git_cl.Changelist()
2902 cl.RunPostUploadHook(2, 'upstream', 'description')
2903
2904 subprocess2.Popen.assert_called_once_with([
2905 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00002906 '--root', 'root',
2907 '--upstream', 'upstream',
2908 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002909 '--author', 'author',
2910 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur75526302020-02-27 22:31:05 +00002911 '--issue', '123456',
2912 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002913 '--post_upload',
2914 '--description_file', '/tmp/fake-temp1',
2915 ])
2916 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002917 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00002918
Edward Lemur9aa1a962020-02-25 00:58:38 +00002919
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002920class CMDTestCaseBase(unittest.TestCase):
2921 _STATUSES = [
2922 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
2923 'INFRA_FAILURE', 'CANCELED',
2924 ]
2925 _CHANGE_DETAIL = {
2926 'project': 'depot_tools',
2927 'status': 'OPEN',
2928 'owner': {'email': 'owner@e.mail'},
2929 'current_revision': 'beeeeeef',
2930 'revisions': {
2931 'deadbeaf': {'_number': 6},
2932 'beeeeeef': {
2933 '_number': 7,
2934 'fetch': {'http': {
2935 'url': 'https://chromium.googlesource.com/depot_tools',
2936 'ref': 'refs/changes/56/123456/7'
2937 }},
2938 },
2939 },
2940 }
2941 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002942 'builds': [{
2943 'id': str(100 + idx),
2944 'builder': {
2945 'project': 'chromium',
2946 'bucket': 'try',
2947 'builder': 'bot_' + status.lower(),
2948 },
2949 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
2950 'tags': [],
2951 'status': status,
2952 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002953 }
2954
Edward Lemur4c707a22019-09-24 21:13:43 +00002955 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002956 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00002957 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002958 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
2959 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002960 mock.patch(
2961 'git_cl.Changelist.GetCodereviewServer',
2962 return_value='https://chromium-review.googlesource.com').start()
2963 mock.patch(
2964 'git_cl.Changelist._GetGerritHost',
2965 return_value='chromium-review.googlesource.com').start()
2966 mock.patch(
2967 'git_cl.Changelist.GetMostRecentPatchset',
2968 return_value=7).start()
2969 mock.patch(
2970 'git_cl.Changelist.GetRemoteUrl',
2971 return_value='https://chromium.googlesource.com/depot_tools').start()
2972 mock.patch(
2973 'auth.Authenticator',
2974 return_value=AuthenticatorMock()).start()
2975 mock.patch(
2976 'gerrit_util.GetChangeDetail',
2977 return_value=self._CHANGE_DETAIL).start()
2978 mock.patch(
2979 'git_cl._call_buildbucket',
2980 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002981 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00002982 self.addCleanup(mock.patch.stopall)
2983
Edward Lemur4c707a22019-09-24 21:13:43 +00002984
Edward Lemur9468eba2020-02-27 19:07:22 +00002985class CMDPresubmitTestCase(CMDTestCaseBase):
2986 def setUp(self):
2987 super(CMDPresubmitTestCase, self).setUp()
2988 mock.patch(
2989 'git_cl.Changelist.GetCommonAncestorWithUpstream',
2990 return_value='upstream').start()
2991 mock.patch(
2992 'git_cl.Changelist.FetchDescription',
2993 return_value='fetch description').start()
2994 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00002995 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00002996 return_value='get description').start()
2997 mock.patch('git_cl.Changelist.RunHook').start()
2998
2999 def testDefaultCase(self):
3000 self.assertEqual(0, git_cl.main(['presubmit']))
3001 git_cl.Changelist.RunHook.assert_called_once_with(
3002 committing=True,
3003 may_prompt=False,
3004 verbose=0,
3005 parallel=None,
3006 upstream='upstream',
3007 description='fetch description',
3008 all_files=None)
3009
3010 def testNoIssue(self):
3011 git_cl.Changelist.GetIssue.return_value = None
3012 self.assertEqual(0, git_cl.main(['presubmit']))
3013 git_cl.Changelist.RunHook.assert_called_once_with(
3014 committing=True,
3015 may_prompt=False,
3016 verbose=0,
3017 parallel=None,
3018 upstream='upstream',
3019 description='get description',
3020 all_files=None)
3021
3022 def testCustomBranch(self):
3023 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3024 git_cl.Changelist.RunHook.assert_called_once_with(
3025 committing=True,
3026 may_prompt=False,
3027 verbose=0,
3028 parallel=None,
3029 upstream='custom_branch',
3030 description='fetch description',
3031 all_files=None)
3032
3033 def testOptions(self):
3034 self.assertEqual(
3035 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u']))
3036 git_cl.Changelist.RunHook.assert_called_once_with(
3037 committing=False,
3038 may_prompt=False,
3039 verbose=2,
3040 parallel=True,
3041 upstream='upstream',
3042 description='fetch description',
3043 all_files=True)
3044
3045
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003046class CMDTryResultsTestCase(CMDTestCaseBase):
3047 _DEFAULT_REQUEST = {
3048 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003049 "gerritChanges": [{
3050 "project": "depot_tools",
3051 "host": "chromium-review.googlesource.com",
3052 "patchset": 7,
3053 "change": 123456,
3054 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003055 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003056 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3057 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003058 }
3059
3060 def testNoJobs(self):
3061 git_cl._call_buildbucket.return_value = {}
3062
3063 self.assertEqual(0, git_cl.main(['try-results']))
3064 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3065 git_cl._call_buildbucket.assert_called_once_with(
3066 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3067 self._DEFAULT_REQUEST)
3068
3069 def testPrintToStdout(self):
3070 self.assertEqual(0, git_cl.main(['try-results']))
3071 self.assertEqual([
3072 'Successes:',
3073 ' bot_success https://ci.chromium.org/b/103',
3074 'Infra Failures:',
3075 ' bot_infra_failure https://ci.chromium.org/b/105',
3076 'Failures:',
3077 ' bot_failure https://ci.chromium.org/b/104',
3078 'Canceled:',
3079 ' bot_canceled ',
3080 'Started:',
3081 ' bot_started https://ci.chromium.org/b/102',
3082 'Scheduled:',
3083 ' bot_scheduled id=101',
3084 'Other:',
3085 ' bot_status_unspecified id=100',
3086 'Total: 7 tryjobs',
3087 ], sys.stdout.getvalue().splitlines())
3088 git_cl._call_buildbucket.assert_called_once_with(
3089 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3090 self._DEFAULT_REQUEST)
3091
3092 def testPrintToStdoutWithMasters(self):
3093 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3094 self.assertEqual([
3095 'Successes:',
3096 ' try bot_success https://ci.chromium.org/b/103',
3097 'Infra Failures:',
3098 ' try bot_infra_failure https://ci.chromium.org/b/105',
3099 'Failures:',
3100 ' try bot_failure https://ci.chromium.org/b/104',
3101 'Canceled:',
3102 ' try bot_canceled ',
3103 'Started:',
3104 ' try bot_started https://ci.chromium.org/b/102',
3105 'Scheduled:',
3106 ' try bot_scheduled id=101',
3107 'Other:',
3108 ' try bot_status_unspecified id=100',
3109 'Total: 7 tryjobs',
3110 ], sys.stdout.getvalue().splitlines())
3111 git_cl._call_buildbucket.assert_called_once_with(
3112 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3113 self._DEFAULT_REQUEST)
3114
3115 @mock.patch('git_cl.write_json')
3116 def testWriteToJson(self, mockJsonDump):
3117 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3118 git_cl._call_buildbucket.assert_called_once_with(
3119 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3120 self._DEFAULT_REQUEST)
3121 mockJsonDump.assert_called_once_with(
3122 'file.json', self._DEFAULT_RESPONSE['builds'])
3123
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003124 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003125 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3126 self.assertEqual(
3127 [
3128 ('chromium', 'try', 'bot_failure'),
3129 ('chromium', 'try', 'bot_infra_failure'),
3130 ],
3131 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003132
3133 def test_filter_failed_for_retry_many_builds(self):
3134
3135 def _build(name, created_sec, status, experimental=False):
3136 assert 0 <= created_sec < 100, created_sec
3137 b = {
3138 'id': 112112,
3139 'builder': {
3140 'project': 'chromium',
3141 'bucket': 'try',
3142 'builder': name,
3143 },
3144 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3145 'status': status,
3146 'tags': [],
3147 }
3148 if experimental:
3149 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3150 return b
3151
3152 builds = [
3153 _build('flaky-last-green', 1, 'FAILURE'),
3154 _build('flaky-last-green', 2, 'SUCCESS'),
3155 _build('flaky', 1, 'SUCCESS'),
3156 _build('flaky', 2, 'FAILURE'),
3157 _build('running', 1, 'FAILED'),
3158 _build('running', 2, 'SCHEDULED'),
3159 _build('yep-still-running', 1, 'STARTED'),
3160 _build('yep-still-running', 2, 'FAILURE'),
3161 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3162 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3163
3164 # Simulate experimental in CQ builder, which developer decided
3165 # to retry manually which resulted in 2nd build non-experimental.
3166 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3167 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3168 ]
3169 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003170 self.assertEqual(
3171 [
3172 ('chromium', 'try', 'flaky'),
3173 ('chromium', 'try', 'sometimes-experimental'),
3174 ],
3175 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003176
3177
3178class CMDTryTestCase(CMDTestCaseBase):
3179
3180 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003181 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003182 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003183 self.assertEqual(0, git_cl.main(['try']))
3184 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3185 self.assertEqual(
3186 sys.stdout.getvalue(),
3187 'Scheduling CQ dry run on: '
3188 'https://chromium-review.googlesource.com/123456\n')
3189
Edward Lemur4c707a22019-09-24 21:13:43 +00003190 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003191 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003192 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003193
3194 self.assertEqual(0, git_cl.main([
3195 'try', '-B', 'luci.chromium.try', '-b', 'win',
3196 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3197 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003198 'Scheduling jobs on:\n'
3199 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003200 git_cl.sys.stdout.getvalue())
3201
3202 expected_request = {
3203 "requests": [{
3204 "scheduleBuild": {
3205 "requestId": "uuid4",
3206 "builder": {
3207 "project": "chromium",
3208 "builder": "win",
3209 "bucket": "try",
3210 },
3211 "gerritChanges": [{
3212 "project": "depot_tools",
3213 "host": "chromium-review.googlesource.com",
3214 "patchset": 7,
3215 "change": 123456,
3216 }],
3217 "properties": {
3218 "category": "git_cl_try",
3219 "json": [{"a": 1}, None],
3220 "key": "val",
3221 },
3222 "tags": [
3223 {"value": "win", "key": "builder"},
3224 {"value": "git_cl_try", "key": "user_agent"},
3225 ],
3226 },
3227 }],
3228 }
3229 mockCallBuildbucket.assert_called_with(
3230 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3231
Anthony Polito1a5fe232020-01-24 23:17:52 +00003232 @mock.patch('git_cl._call_buildbucket')
3233 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3234 mockCallBuildbucket.return_value = {}
3235
3236 self.assertEqual(0, git_cl.main([
3237 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3238 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3239 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3240 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003241 'Scheduling jobs on:\n'
3242 ' chromium/try: linux\n'
3243 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003244 git_cl.sys.stdout.getvalue())
3245
3246 expected_request = {
3247 "requests": [{
3248 "scheduleBuild": {
3249 "requestId": "uuid4",
3250 "builder": {
3251 "project": "chromium",
3252 "builder": "linux",
3253 "bucket": "try",
3254 },
3255 "gerritChanges": [{
3256 "project": "depot_tools",
3257 "host": "chromium-review.googlesource.com",
3258 "patchset": 7,
3259 "change": 123456,
3260 }],
3261 "properties": {
3262 "category": "git_cl_try",
3263 "json": [{"a": 1}, None],
3264 "key": "val",
3265 },
3266 "tags": [
3267 {"value": "linux", "key": "builder"},
3268 {"value": "git_cl_try", "key": "user_agent"},
3269 ],
3270 "gitilesCommit": {
3271 "host": "chromium-review.googlesource.com",
3272 "project": "depot_tools",
3273 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3274 }
3275 },
3276 },
3277 {
3278 "scheduleBuild": {
3279 "requestId": "uuid4",
3280 "builder": {
3281 "project": "chromium",
3282 "builder": "win",
3283 "bucket": "try",
3284 },
3285 "gerritChanges": [{
3286 "project": "depot_tools",
3287 "host": "chromium-review.googlesource.com",
3288 "patchset": 7,
3289 "change": 123456,
3290 }],
3291 "properties": {
3292 "category": "git_cl_try",
3293 "json": [{"a": 1}, None],
3294 "key": "val",
3295 },
3296 "tags": [
3297 {"value": "win", "key": "builder"},
3298 {"value": "git_cl_try", "key": "user_agent"},
3299 ],
3300 "gitilesCommit": {
3301 "host": "chromium-review.googlesource.com",
3302 "project": "depot_tools",
3303 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3304 }
3305 },
3306 }],
3307 }
3308 mockCallBuildbucket.assert_called_with(
3309 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3310
Edward Lemur45768512020-03-02 19:03:14 +00003311 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003312 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003313 with self.assertRaises(SystemExit):
3314 git_cl.main([
3315 'try', '-B', 'not-a-bucket', '-b', 'win',
3316 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003317 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003318 'Invalid bucket: not-a-bucket.',
3319 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003320
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003321 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003322 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003323 def testScheduleOnBuildbucketRetryFailed(
3324 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003325 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003326 7: [],
3327 6: [{
3328 'id': 112112,
3329 'builder': {
3330 'project': 'chromium',
3331 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003332 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003333 'createTime': '2019-10-09T08:00:01.854286Z',
3334 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003335 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003336 mockCallBuildbucket.return_value = {}
3337
3338 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3339 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003340 'Scheduling jobs on:\n'
3341 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003342 git_cl.sys.stdout.getvalue())
3343
3344 expected_request = {
3345 "requests": [{
3346 "scheduleBuild": {
3347 "requestId": "uuid4",
3348 "builder": {
3349 "project": "chromium",
3350 "bucket": "try",
3351 "builder": "linux",
3352 },
3353 "gerritChanges": [{
3354 "project": "depot_tools",
3355 "host": "chromium-review.googlesource.com",
3356 "patchset": 7,
3357 "change": 123456,
3358 }],
3359 "properties": {
3360 "category": "git_cl_try",
3361 },
3362 "tags": [
3363 {"value": "linux", "key": "builder"},
3364 {"value": "git_cl_try", "key": "user_agent"},
3365 {"value": "1", "key": "retry_failed"},
3366 ],
3367 },
3368 }],
3369 }
3370 mockCallBuildbucket.assert_called_with(
3371 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3372
Edward Lemur4c707a22019-09-24 21:13:43 +00003373 def test_parse_bucket(self):
3374 test_cases = [
3375 {
3376 'bucket': 'chromium/try',
3377 'result': ('chromium', 'try'),
3378 },
3379 {
3380 'bucket': 'luci.chromium.try',
3381 'result': ('chromium', 'try'),
3382 'has_warning': True,
3383 },
3384 {
3385 'bucket': 'skia.primary',
3386 'result': ('skia', 'skia.primary'),
3387 'has_warning': True,
3388 },
3389 {
3390 'bucket': 'not-a-bucket',
3391 'result': (None, None),
3392 },
3393 ]
3394
3395 for test_case in test_cases:
3396 git_cl.sys.stdout.truncate(0)
3397 self.assertEqual(
3398 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3399 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003400 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3401 test_case['result'])
3402 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003403
3404
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003405class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003406
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003407 def setUp(self):
3408 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003409 mock.patch('git_cl._fetch_tryjobs').start()
3410 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003411 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Anthony Polito46689b02019-11-15 20:56:41 +00003412 mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003413 self.addCleanup(mock.patch.stopall)
3414
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003415 def testWarmUpChangeDetailCache(self):
3416 self.assertEqual(0, git_cl.main(['upload']))
3417 gerrit_util.GetChangeDetail.assert_called_once_with(
3418 'chromium-review.googlesource.com', 'depot_tools~123456',
3419 frozenset([
3420 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3421 'CURRENT_COMMIT']))
3422
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003423 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003424 # This test mocks out the actual upload part, and just asserts that after
3425 # upload, if --retry-failed is added, then the tool will fetch try jobs
3426 # from the previous patchset and trigger the right builders on the latest
3427 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003428 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003429 # Latest patchset: No builds.
3430 [],
3431 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003432 [{
3433 'id': str(100 + idx),
3434 'builder': {
3435 'project': 'chromium',
3436 'bucket': 'try',
3437 'builder': 'bot_' + status.lower(),
3438 },
3439 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3440 'tags': [],
3441 'status': status,
3442 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003443 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003444
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003445 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003446 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003447 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3448 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003449 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003450 expected_buckets = [
3451 ('chromium', 'try', 'bot_failure'),
3452 ('chromium', 'try', 'bot_infra_failure'),
3453 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003454 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3455 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003456
Brian Sheedy59b06a82019-10-14 17:03:29 +00003457
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003458class MakeRequestsHelperTestCase(unittest.TestCase):
3459
3460 def exampleGerritChange(self):
3461 return {
3462 'host': 'chromium-review.googlesource.com',
3463 'project': 'depot_tools',
3464 'change': 1,
3465 'patchset': 2,
3466 }
3467
3468 def testMakeRequestsHelperNoOptions(self):
3469 # Basic test for the helper function _make_tryjob_schedule_requests;
3470 # it shouldn't throw AttributeError even when options doesn't have any
3471 # of the expected values; it will use default option values.
3472 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3473 jobs = [('chromium', 'try', 'my-builder')]
3474 options = optparse.Values()
3475 requests = git_cl._make_tryjob_schedule_requests(
3476 changelist, jobs, options, patchset=None)
3477
3478 # requestId is non-deterministic. Just assert that it's there and has
3479 # a particular length.
3480 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3481 self.assertEqual(requests, [{
3482 'scheduleBuild': {
3483 'builder': {
3484 'bucket': 'try',
3485 'builder': 'my-builder',
3486 'project': 'chromium'
3487 },
3488 'gerritChanges': [self.exampleGerritChange()],
3489 'properties': {
3490 'category': 'git_cl_try'
3491 },
3492 'tags': [{
3493 'key': 'builder',
3494 'value': 'my-builder'
3495 }, {
3496 'key': 'user_agent',
3497 'value': 'git_cl_try'
3498 }]
3499 }
3500 }])
3501
3502 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3503 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3504 jobs = [('chromium', 'try', 'presubmit')]
3505 options = optparse.Values()
3506 requests = git_cl._make_tryjob_schedule_requests(
3507 changelist, jobs, options, patchset=None)
3508 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3509 'category': 'git_cl_try',
3510 'dry_run': 'true'
3511 })
3512
3513 def testMakeRequestsHelperRevisionSet(self):
3514 # Gitiles commit is specified when revision is in options.
3515 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3516 jobs = [('chromium', 'try', 'my-builder')]
3517 options = optparse.Values({'revision': 'ba5eba11'})
3518 requests = git_cl._make_tryjob_schedule_requests(
3519 changelist, jobs, options, patchset=None)
3520 self.assertEqual(
3521 requests[0]['scheduleBuild']['gitilesCommit'], {
3522 'host': 'chromium-review.googlesource.com',
3523 'id': 'ba5eba11',
3524 'project': 'depot_tools'
3525 })
3526
3527 def testMakeRequestsHelperRetryFailedSet(self):
3528 # An extra tag is added when retry_failed is in options.
3529 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3530 jobs = [('chromium', 'try', 'my-builder')]
3531 options = optparse.Values({'retry_failed': 'true'})
3532 requests = git_cl._make_tryjob_schedule_requests(
3533 changelist, jobs, options, patchset=None)
3534 self.assertEqual(
3535 requests[0]['scheduleBuild']['tags'], [
3536 {
3537 'key': 'builder',
3538 'value': 'my-builder'
3539 },
3540 {
3541 'key': 'user_agent',
3542 'value': 'git_cl_try'
3543 },
3544 {
3545 'key': 'retry_failed',
3546 'value': '1'
3547 }
3548 ])
3549
3550 def testMakeRequestsHelperCategorySet(self):
3551 # The category property can be overriden with options.
3552 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3553 jobs = [('chromium', 'try', 'my-builder')]
3554 options = optparse.Values({'category': 'my-special-category'})
3555 requests = git_cl._make_tryjob_schedule_requests(
3556 changelist, jobs, options, patchset=None)
3557 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3558 {'category': 'my-special-category'})
3559
3560
Edward Lemurda4b6c62020-02-13 00:28:40 +00003561class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003562
3563 def setUp(self):
3564 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003565 mock.patch('git_cl.RunCommand').start()
3566 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3567 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3568 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003569 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003570 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003571
3572 def tearDown(self):
3573 shutil.rmtree(self._top_dir)
3574 super(CMDFormatTestCase, self).tearDown()
3575
Jamie Madill5e96ad12020-01-13 16:08:35 +00003576 def _make_temp_file(self, fname, contents):
3577 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3578 tf.write('\n'.join(contents))
3579
Brian Sheedy59b06a82019-10-14 17:03:29 +00003580 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003581 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003582
Brian Sheedyb4307d52019-12-02 19:18:17 +00003583 def _check_yapf_filtering(self, files, expected):
3584 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3585 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003586
Edward Lemur1a83da12020-03-04 21:18:36 +00003587 def _run_command_mock(self, return_value):
3588 def f(*args, **kwargs):
3589 if 'stdin' in kwargs:
3590 self.assertIsInstance(kwargs['stdin'], bytes)
3591 return return_value
3592 return f
3593
Jamie Madill5e96ad12020-01-13 16:08:35 +00003594 def testClangFormatDiffFull(self):
3595 self._make_temp_file('test.cc', ['// test'])
3596 git_cl.settings.GetFormatFullByDefault.return_value = False
3597 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3598 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3599
3600 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003601 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003602 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3603 self._top_dir, 'HEAD')
3604 self.assertEqual(2, return_value)
3605
3606 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003607 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003608 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3609 self._top_dir, 'HEAD')
3610 self.assertEqual(0, return_value)
3611
3612 def testClangFormatDiff(self):
3613 git_cl.settings.GetFormatFullByDefault.return_value = False
3614 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3615
3616 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003617 git_cl.RunCommand.side_effect = self._run_command_mock('error')
3618 return_value = git_cl._RunClangFormatDiff(
3619 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003620 self.assertEqual(2, return_value)
3621
3622 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003623 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003624 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3625 'HEAD')
3626 self.assertEqual(0, return_value)
3627
Brian Sheedyb4307d52019-12-02 19:18:17 +00003628 def testYapfignoreExplicit(self):
3629 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3630 files = [
3631 'bar.py',
3632 'foo/bar.py',
3633 'foo/baz.py',
3634 'foo/bar/baz.py',
3635 'foo/bar/foobar.py',
3636 ]
3637 expected = [
3638 'bar.py',
3639 'foo/baz.py',
3640 'foo/bar/foobar.py',
3641 ]
3642 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003643
Brian Sheedyb4307d52019-12-02 19:18:17 +00003644 def testYapfignoreSingleWildcards(self):
3645 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3646 files = [
3647 'bar.py', # Matched by *bar.py.
3648 'bar.txt',
3649 'foobar.py', # Matched by *bar.py, foo*.
3650 'foobar.txt', # Matched by foo*.
3651 'bazbar.py', # Matched by *bar.py, baz*.py.
3652 'bazbar.txt',
3653 'foo/baz.txt', # Matched by foo*.
3654 'bar/bar.py', # Matched by *bar.py.
3655 'baz/foo.py', # Matched by baz*.py, foo*.
3656 'baz/foo.txt',
3657 ]
3658 expected = [
3659 'bar.txt',
3660 'bazbar.txt',
3661 'baz/foo.txt',
3662 ]
3663 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003664
Brian Sheedyb4307d52019-12-02 19:18:17 +00003665 def testYapfignoreMultiplewildcards(self):
3666 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3667 files = [
3668 'bar.py', # Matched by *bar*.
3669 'bar.txt', # Matched by *bar*.
3670 'abar.py', # Matched by *bar*.
3671 'foobaz.txt', # Matched by *foo*baz.txt.
3672 'foobaz.py',
3673 'afoobaz.txt', # Matched by *foo*baz.txt.
3674 ]
3675 expected = [
3676 'foobaz.py',
3677 ]
3678 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003679
3680 def testYapfignoreComments(self):
3681 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003682 files = [
3683 'test.py',
3684 'test2.py',
3685 ]
3686 expected = [
3687 'test2.py',
3688 ]
3689 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003690
3691 def testYapfignoreBlankLines(self):
3692 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003693 files = [
3694 'test.py',
3695 'test2.py',
3696 'test3.py',
3697 ]
3698 expected = [
3699 'test3.py',
3700 ]
3701 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003702
3703 def testYapfignoreWhitespace(self):
3704 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003705 files = [
3706 'test.py',
3707 'test2.py',
3708 ]
3709 expected = [
3710 'test2.py',
3711 ]
3712 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003713
Brian Sheedyb4307d52019-12-02 19:18:17 +00003714 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003715 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003716 self._check_yapf_filtering([], [])
3717
3718 def testYapfignoreMissingYapfignore(self):
3719 files = [
3720 'test.py',
3721 ]
3722 expected = [
3723 'test.py',
3724 ]
3725 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003726
3727
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003728if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003729 logging.basicConfig(
3730 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003731 unittest.main()