git-cl: Run PostUpload hooks via CLI.
Bug: 1042324
Change-Id: Iae90e632e9c1b2c798575ab940d82a145b47204a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2070681
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index e6d3b97..5bf17f8 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -2815,7 +2815,6 @@
self.assertEqual(expected_results, results)
subprocess2.Popen.assert_called_once_with([
'vpython', 'PRESUBMIT_SUPPORT',
- '--commit',
'--author', 'author',
'--root', 'root',
'--upstream', 'upstream',
@@ -2823,6 +2822,7 @@
'--issue', '123456',
'--patchset', '7',
'--gerrit_url', 'https://chromium-review.googlesource.com',
+ '--commit',
'--may_prompt',
'--parallel',
'--all_files',
@@ -2857,6 +2857,25 @@
sys.exit.assert_called_once_with(2)
+ def testRunPostUploadHook(self):
+ cl = git_cl.Changelist()
+ cl.RunPostUploadHook(2, 'upstream', 'description')
+
+ subprocess2.Popen.assert_called_once_with([
+ 'vpython', 'PRESUBMIT_SUPPORT',
+ '--author', 'author',
+ '--root', 'root',
+ '--upstream', 'upstream',
+ '--verbose', '--verbose',
+ '--issue', '123456',
+ '--patchset', '7',
+ '--gerrit_url', 'https://chromium-review.googlesource.com',
+ '--post_upload',
+ '--description_file', '/tmp/fake-temp1',
+ ])
+ gclient_utils.FileWrite.assert_called_once_with(
+ '/tmp/fake-temp1', b'description', mode='wb')
+
class CMDTestCaseBase(unittest.TestCase):
_STATUSES = [