blob: 539e53860f5970474677badb3b994c0be94a40ce [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
34# We have to disable monitoring before importing git_cl.
35metrics.DISABLE_METRICS_COLLECTION = True
36
Jamie Madill5e96ad12020-01-13 16:08:35 +000037import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000038import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000039import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000040import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000041import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000042import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000043import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000044import git_new_branch
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +000045import owners_client
Edward Lemur85153282020-02-14 22:06:29 +000046import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000047import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000048
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000049NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
50
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000051
Edward Lemur0db01f02019-11-12 22:01:51 +000052def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070053 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
54
tandrii5d48c322016-08-18 16:19:37 -070055CERR1 = callError(1)
56
57
Edward Lemur1773f372020-02-22 00:27:14 +000058class TemporaryFileMock(object):
59 def __init__(self):
60 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070061
Edward Lemur1773f372020-02-22 00:27:14 +000062 @contextlib.contextmanager
63 def __call__(self):
64 self.suffix += 1
65 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070066
67
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000068class ChangelistMock(object):
69 # A class variable so we can access it when we don't have access to the
70 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000071 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000072
73 def __init__(self, gerrit_change=None, **kwargs):
74 self._gerrit_change = gerrit_change
75
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000076 def GetIssue(self):
77 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000078
Edward Lemur6c6827c2020-02-06 21:15:18 +000079 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000080 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000081
dsansomee2d6fd92016-09-08 00:10:47 -070082 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000083 ChangelistMock.desc = desc
84
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000085 def GetGerritChange(self, patchset=None, **kwargs):
86 del patchset
87 return self._gerrit_change
88
Josip Sokcevic9011a5b2021-02-12 18:59:44 +000089 def GetRemoteBranch(self):
90 return ('origin', 'refs/remotes/origin/main')
91
tandrii5d48c322016-08-18 16:19:37 -070092
Edward Lemur85153282020-02-14 22:06:29 +000093class GitMocks(object):
94 def __init__(self, config=None, branchref=None):
95 self.branchref = branchref or 'refs/heads/master'
96 self.config = config or {}
97
98 def GetBranchRef(self, _root):
99 return self.branchref
100
101 def NewBranch(self, branchref):
102 self.branchref = branchref
103
Edward Lemur26964072020-02-19 19:18:51 +0000104 def GetConfig(self, root, key, default=None):
105 if root != '':
106 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000107 return self.config.get(key, default)
108
Edward Lemur26964072020-02-19 19:18:51 +0000109 def SetConfig(self, root, key, value=None):
110 if root != '':
111 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000112 if value:
113 self.config[key] = value
114 return
115 if key not in self.config:
116 raise CERR1
117 del self.config[key]
118
119
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000120class WatchlistsMock(object):
121 def __init__(self, _):
122 pass
123 @staticmethod
124 def GetWatchersForPaths(_):
125 return ['joe@example.com']
126
127
Edward Lemur4c707a22019-09-24 21:13:43 +0000128class CodereviewSettingsFileMock(object):
129 def __init__(self):
130 pass
131 # pylint: disable=no-self-use
132 def read(self):
133 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
134 'GERRIT_HOST: True\n')
135
136
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000137class AuthenticatorMock(object):
138 def __init__(self, *_args):
139 pass
140 def has_cached_credentials(self):
141 return True
tandrii221ab252016-10-06 08:12:04 -0700142 def authorize(self, http):
143 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000144
145
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100146def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000147 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
148
149 Usage:
150 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100151 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000152
153 OR
154 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100155 CookiesAuthenticatorMockFactory(
156 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000157 """
158 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800159 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000160 # Intentionally not calling super() because it reads actual cookie files.
161 pass
162 @classmethod
163 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000164 return os.path.join('~', '.gitcookies')
165
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000166 @classmethod
167 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000168 return os.path.join('~', NETRC_FILENAME)
169
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100170 def _get_auth_for_host(self, host):
171 if same_auth:
172 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000173 return (hosts_with_creds or {}).get(host)
174 return CookiesAuthenticatorMock
175
Aaron Gable9a03ae02017-11-03 11:31:07 -0700176
kmarshall9249e012016-08-23 12:02:16 -0700177class MockChangelistWithBranchAndIssue():
178 def __init__(self, branch, issue):
179 self.branch = branch
180 self.issue = issue
181 def GetBranch(self):
182 return self.branch
183 def GetIssue(self):
184 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000185
tandriic2405f52016-10-10 08:13:15 -0700186
187class SystemExitMock(Exception):
188 pass
189
190
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000191class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000192 def setUp(self):
193 mock.patch('sys.exit', side_effect=SystemExitMock).start()
194 mock.patch('sys.stdout', StringIO()).start()
195 mock.patch('sys.stderr', StringIO()).start()
196 self.addCleanup(mock.patch.stopall)
197
198 def test_die_with_error(self):
199 with self.assertRaises(SystemExitMock):
200 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
201 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
202 self.assertTrue('saving CL description' in sys.stdout.getvalue())
203 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
204 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
205 sys.exit.assert_called_once_with(1)
206
207 def test_die_with_error_no_desc(self):
208 with self.assertRaises(SystemExitMock):
209 git_cl.DieWithError('foo')
210 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
211 self.assertEqual(sys.stdout.getvalue(), '')
212 sys.exit.assert_called_once_with(1)
213
Edward Lemur6c6827c2020-02-06 21:15:18 +0000214 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000215 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100216 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000217 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700218
Edward Lemur61bf4172020-02-24 23:22:37 +0000219 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
220 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
221 def test_get_cl_statuses(self, *_mocks):
222 statuses = [
223 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
224 changes = []
225 for status in statuses:
226 cl = git_cl.Changelist()
227 cl.status = status
228 changes.append(cl)
229
230 actual = set(git_cl.get_cl_statuses(changes, True))
231 self.assertEqual(set(zip(changes, statuses)), actual)
232
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000233 def test_upload_to_non_default_branch_no_retry(self):
234 m = mock.patch('git_cl.Changelist._CMDUploadChange',
235 side_effect=[git_cl.GitPushError(), None]).start()
236 mock.patch('git_cl.Changelist.GetRemoteBranch',
237 return_value=('foo', 'bar')).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000238 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000239 return_value='foo').start()
240 mock.patch('git_cl.gerrit_util.GetProjectHead',
241 return_value='refs/heads/main').start()
242
243 cl = git_cl.Changelist()
244 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000245 options.target_branch = 'refs/heads/bar'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000246 with self.assertRaises(SystemExitMock):
247 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
248
249 # ensure upload is called once
250 self.assertEqual(len(m.mock_calls), 1)
251 sys.exit.assert_called_once_with(1)
252 # option not set as retry didn't happen
253 self.assertFalse(hasattr(options, 'force'))
254 self.assertFalse(hasattr(options, 'edit_description'))
255
256 def test_upload_to_old_default_still_active(self):
257 m = mock.patch('git_cl.Changelist._CMDUploadChange',
258 side_effect=[git_cl.GitPushError(), None]).start()
259 mock.patch('git_cl.Changelist.GetRemoteBranch',
260 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000261 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000262 return_value='foo').start()
263 mock.patch('git_cl.gerrit_util.GetProjectHead',
Josip Sokcevicb631a882021-01-06 18:18:10 +0000264 return_value='refs/heads/master').start()
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000265
266 cl = git_cl.Changelist()
267 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000268 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000269 with self.assertRaises(SystemExitMock):
270 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
271
272 # ensure upload is called once
273 self.assertEqual(len(m.mock_calls), 1)
274 sys.exit.assert_called_once_with(1)
275 # option not set as retry didn't happen
276 self.assertFalse(hasattr(options, 'force'))
277 self.assertFalse(hasattr(options, 'edit_description'))
278
279 def test_upload_to_old_default_retry_on_failure(self):
280 m = mock.patch('git_cl.Changelist._CMDUploadChange',
281 side_effect=[git_cl.GitPushError(), None]).start()
282 mock.patch('git_cl.Changelist.GetRemoteBranch',
283 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000284 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000285 return_value='foo').start()
286 mock.patch('git_cl.gerrit_util.GetProjectHead',
287 return_value='refs/heads/main').start()
288 mock.patch('git_cl.RunGit').start()
289
290 cl = git_cl.Changelist()
291 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000292 options.target_branch = 'refs/heads/master'
293 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
294 # ensure upload is called twice
295 self.assertEqual(len(m.mock_calls), 2)
296 # option overrides on retry
297 self.assertEqual(options.force, True)
298 self.assertEqual(options.edit_description, False)
299
Gavin Mak68e6cf32021-01-25 18:24:08 +0000300 def test_upload_with_message_file_no_editor(self):
301 m = mock.patch('git_cl.ChangeDescription.prompt',
302 return_value=None).start()
303 mock.patch('git_cl.Changelist.GetRemoteBranch',
304 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
305 mock.patch('git_cl.GetTargetRef',
306 return_value='refs/heads/main').start()
307 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
308 lambda _, offer_removal: None).start()
309 mock.patch('git_cl.Changelist.GetIssue', return_value=None).start()
310 mock.patch('git_cl.Changelist.GetBranch',
311 side_effect=SystemExitMock).start()
312 mock.patch('git_cl.GenerateGerritChangeId', return_value=None).start()
313 mock.patch('git_cl.RunGit').start()
314
315 cl = git_cl.Changelist()
316 options = optparse.Values()
317 options.target_branch = 'refs/heads/master'
318 options.squash = True
319 options.edit_description = False
320 options.force = False
321 options.preserve_tryjobs = False
322 options.message_file = "message.txt"
323
324 with self.assertRaises(SystemExitMock):
325 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
326 self.assertEqual(len(m.mock_calls), 0)
327
328 options.message_file = None
329 with self.assertRaises(SystemExitMock):
330 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
331 self.assertEqual(len(m.mock_calls), 1)
332
Josip Sokcevicb631a882021-01-06 18:18:10 +0000333 def test_upload_to_old_default_retry_on_rollback(self):
334 """Test when default branch migration had to be rolled back to old name"""
335 m = mock.patch('git_cl.Changelist._CMDUploadChange',
336 side_effect=[git_cl.GitPushError(), None]).start()
337 mock.patch('git_cl.Changelist.GetRemoteBranch',
338 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
339 mock.patch('git_cl.Changelist.GetGerritProject',
340 return_value='foo').start()
341 mock.patch('git_cl.gerrit_util.GetProjectHead',
342 return_value='refs/heads/master').start()
343 # GetTargetRef returns new default branch since it has stale remote
344 # information.
345 mock.patch('git_cl.GetTargetRef',
346 return_value='refs/heads/main').start()
347 mock.patch('git_cl.RunGit').start()
348
349 cl = git_cl.Changelist()
350 options = optparse.Values()
351 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000352 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
353 # ensure upload is called twice
354 self.assertEqual(len(m.mock_calls), 2)
355 # option overrides on retry
356 self.assertEqual(options.force, True)
357 self.assertEqual(options.edit_description, False)
358
Edward Lemur61bf4172020-02-24 23:22:37 +0000359 def test_get_cl_statuses_no_changes(self):
360 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
361
362 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
363 @mock.patch('multiprocessing.pool.ThreadPool')
364 def test_get_cl_statuses_timeout(self, *_mocks):
365 changes = [git_cl.Changelist() for _ in range(2)]
366 pool = multiprocessing.pool.ThreadPool()
367 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
368 it.return_value.next.side_effect = [
369 (changes[0], 'lgtm'),
370 multiprocessing.TimeoutError,
371 ]
372
373 actual = list(git_cl.get_cl_statuses(changes, True))
374 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
375
376 @mock.patch('git_cl.Changelist.GetIssueURL')
377 def test_get_cl_statuses_not_finegrained(self, _mock):
378 changes = [git_cl.Changelist() for _ in range(2)]
379 urls = ['some-url', None]
380 git_cl.Changelist.GetIssueURL.side_effect = urls
381
382 actual = set(git_cl.get_cl_statuses(changes, False))
383 self.assertEqual(
384 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
385
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000386 def test_get_issue_url(self):
387 cl = git_cl.Changelist(issue=123)
388 cl._gerrit_server = 'https://example.com'
389 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
390 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
391
392 cl = git_cl.Changelist(issue=123)
393 cl._gerrit_server = 'https://chromium-review.googlesource.com'
394 self.assertEqual(cl.GetIssueURL(),
395 'https://chromium-review.googlesource.com/123')
396 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
397
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000398 def test_set_preserve_tryjobs(self):
399 d = git_cl.ChangeDescription('Simple.')
400 d.set_preserve_tryjobs()
401 self.assertEqual(d.description.splitlines(), [
402 'Simple.',
403 '',
404 'Cq-Do-Not-Cancel-Tryjobs: true',
405 ])
406 before = d.description
407 d.set_preserve_tryjobs()
408 self.assertEqual(before, d.description)
409
410 d = git_cl.ChangeDescription('\n'.join([
411 'One is enough',
412 '',
413 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
414 'Change-Id: Ideadbeef',
415 ]))
416 d.set_preserve_tryjobs()
417 self.assertEqual(d.description.splitlines(), [
418 'One is enough',
419 '',
420 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
421 'Change-Id: Ideadbeef',
422 'Cq-Do-Not-Cancel-Tryjobs: true',
423 ])
424
tandriif9aefb72016-07-01 09:06:51 -0700425 def test_get_bug_line_values(self):
426 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
427 self.assertEqual(f('', ''), [])
428 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
Lei Zhang8a0efc12020-08-05 19:58:45 +0000429 # Prefix that ends with colon.
430 self.assertEqual(f('v8:', '456'), ['v8:456'])
431 self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
432 # Prefix that ends without colon.
tandriif9aefb72016-07-01 09:06:51 -0700433 self.assertEqual(f('v8', '456'), ['v8:456'])
434 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
435 # Not nice, but not worth carying.
Lei Zhang8a0efc12020-08-05 19:58:45 +0000436 self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
437 ['v8:456', 'chromium:123', 'v8:123'])
tandriif9aefb72016-07-01 09:06:51 -0700438 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
439 ['v8:456', 'chromium:123', 'v8:123'])
440
Edward Lemurda4b6c62020-02-13 00:28:40 +0000441 @mock.patch('gerrit_util.GetAccountDetails')
442 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000443 mock_per_account = {
444 'u1': None, # 404, doesn't exist.
445 'u2': {
446 '_account_id': 123124,
447 'avatars': [],
448 'email': 'u2@example.com',
449 'name': 'User Number 2',
450 'status': 'OOO',
451 },
452 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
453 }
454 def GetAccountDetailsMock(_, account):
455 # Poor-man's mock library's side_effect.
456 v = mock_per_account.pop(account)
457 if isinstance(v, Exception):
458 raise v
459 return v
460
Edward Lemurda4b6c62020-02-13 00:28:40 +0000461 mockGetAccountDetails.side_effect = GetAccountDetailsMock
462 actual = git_cl.gerrit_util.ValidAccounts(
463 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000464 self.assertEqual(actual, {
465 'u2': {
466 '_account_id': 123124,
467 'avatars': [],
468 'email': 'u2@example.com',
469 'name': 'User Number 2',
470 'status': 'OOO',
471 },
472 })
473
474
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200475class TestParseIssueURL(unittest.TestCase):
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000476 def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
477 parsed = git_cl.ParseIssueNumberArgument(arg)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200478 self.assertIsNotNone(parsed)
479 if fail:
480 self.assertFalse(parsed.valid)
481 return
482 self.assertTrue(parsed.valid)
483 self.assertEqual(parsed.issue, issue)
484 self.assertEqual(parsed.patchset, patchset)
485 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200486
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000487 def test_basic(self):
488 self._test('123', 123)
489 self._test('', fail=True)
490 self._test('abc', fail=True)
491 self._test('123/1', fail=True)
492 self._test('123a', fail=True)
493 self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
494 self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200495
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000496 def test_gerrit_url(self):
497 self._test('https://codereview.source.com/123', 123, None,
498 'codereview.source.com')
499 self._test('http://chrome-review.source.com/c/123', 123, None,
500 'chrome-review.source.com')
501 self._test('https://chrome-review.source.com/c/123/', 123, None,
502 'chrome-review.source.com')
503 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
504 'chrome-review.source.com')
505 self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
506 'chrome-review.source.com')
507 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
508 'chrome-review.source.com')
509 self._test('https://chrome-review.source.com/123', 123, None,
510 'chrome-review.source.com')
511 self._test('https://chrome-review.source.com/123/4', 123, 4,
512 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200513
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000514 self._test('https://chrome-review.source.com/bad/123/4', fail=True)
515 self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
516 self._test('https://chrome-review.source.com/c/abc/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200517
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000518 def test_short_urls(self):
519 self._test('https://crrev.com/c/2151934', 2151934, None,
520 'chromium-review.googlesource.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200521
522
Edward Lemurda4b6c62020-02-13 00:28:40 +0000523class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100524 def setUp(self):
525 super(GitCookiesCheckerTest, self).setUp()
526 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100527 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000528 mock.patch('sys.stdout', StringIO()).start()
529 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100530
531 def mock_hosts_creds(self, subhost_identity_pairs):
532 def ensure_googlesource(h):
533 if not h.endswith(self.c._GOOGLESOURCE):
534 assert not h.endswith('.')
535 return h + '.' + self.c._GOOGLESOURCE
536 return h
537 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
538 for h, i in subhost_identity_pairs]
539
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200540 def test_identity_parsing(self):
541 self.assertEqual(self.c._parse_identity('ldap.google.com'),
542 ('ldap', 'google.com'))
543 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
544 ('ldap', 'example.com'))
545 # Specical case because we know there are no subdomains in chromium.org.
546 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
547 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800548 # Pathological: ".period." can be either username OR domain, more likely
549 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200550 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
551 ('note', 'period.example.com'))
552
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100553 def test_analysis_nothing(self):
554 self.c._all_hosts = []
555 self.assertFalse(self.c.has_generic_host())
556 self.assertEqual(set(), self.c.get_conflicting_hosts())
557 self.assertEqual(set(), self.c.get_duplicated_hosts())
558 self.assertEqual(set(), self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100559
560 def test_analysis(self):
561 self.mock_hosts_creds([
562 ('.googlesource.com', 'git-example.chromium.org'),
563
564 ('chromium', 'git-example.google.com'),
565 ('chromium-review', 'git-example.google.com'),
566 ('chrome-internal', 'git-example.chromium.org'),
567 ('chrome-internal-review', 'git-example.chromium.org'),
568 ('conflict', 'git-example.google.com'),
569 ('conflict-review', 'git-example.chromium.org'),
570 ('dup', 'git-example.google.com'),
571 ('dup', 'git-example.google.com'),
572 ('dup-review', 'git-example.google.com'),
573 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200574 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100575 ])
576 self.assertTrue(self.c.has_generic_host())
577 self.assertEqual(set(['conflict.googlesource.com']),
578 self.c.get_conflicting_hosts())
579 self.assertEqual(set(['dup.googlesource.com']),
580 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200581 self.assertEqual(set(['partial.googlesource.com',
582 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100583 self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100584
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100585 def test_report_no_problems(self):
586 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100587 self.assertFalse(self.c.find_and_report_problems())
588 self.assertEqual(sys.stdout.getvalue(), '')
589
Edward Lemurda4b6c62020-02-13 00:28:40 +0000590 @mock.patch(
591 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000592 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000593 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100594 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100595 self.assertTrue(self.c.find_and_report_problems())
596 with open(os.path.join(os.path.dirname(__file__),
597 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000598 expected = f.read() % {
599 'sep': os.sep,
600 }
601
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100602 def by_line(text):
603 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700604 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200605 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100606
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800607
Edward Lemurda4b6c62020-02-13 00:28:40 +0000608class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000609 def setUp(self):
610 super(TestGitCl, self).setUp()
611 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700612 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000613 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000614 mock.patch('sys.stdout', StringIO()).start()
615 mock.patch(
616 'git_cl.time_time',
617 lambda: self._mocked_call('time.time')).start()
618 mock.patch(
619 'git_cl.metrics.collector.add_repeated',
620 lambda *a: self._mocked_call('add_repeated', *a)).start()
621 mock.patch('subprocess2.call', self._mocked_call).start()
622 mock.patch('subprocess2.check_call', self._mocked_call).start()
623 mock.patch('subprocess2.check_output', self._mocked_call).start()
624 mock.patch(
625 'subprocess2.communicate',
626 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
627 mock.patch(
628 'git_cl.gclient_utils.CheckCallAndFilter',
629 self._mocked_call).start()
630 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000631 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
632 mock.patch(
633 'git_cl.SaveDescriptionBackup',
634 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
635 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000636 'git_cl.write_json',
637 lambda *a: self._mocked_call('write_json', *a)).start()
638 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000639 'git_cl.Changelist.RunHook',
640 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000641 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
642 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000643 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000644 mock.patch(
645 'git_cl.gerrit_util.GetChangeComments',
646 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
647 mock.patch(
648 'git_cl.gerrit_util.GetChangeRobotComments',
649 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
650 mock.patch(
651 'git_cl.gerrit_util.AddReviewers',
652 lambda *a: self._mocked_call('AddReviewers', *a)).start()
653 mock.patch(
654 'git_cl.gerrit_util.SetReview',
655 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
656 self._mocked_call(
657 'SetReview', h, i, msg, labels, notify, ready))).start()
658 mock.patch(
659 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
660 return_value=False).start()
661 mock.patch(
662 'git_cl.gerrit_util.GceAuthenticator.is_gce',
663 return_value=False).start()
664 mock.patch(
665 'git_cl.gerrit_util.ValidAccounts',
666 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000667 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000668 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000669 self.mockGit = GitMocks()
670 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
671 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
Edward Lesmes50da7702020-03-30 19:23:43 +0000672 mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
673 mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
Edward Lemur85153282020-02-14 22:06:29 +0000674 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000675 mock.patch(
676 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000677 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000678 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000679 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000680 mock.patch(
681 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000682 # It's important to reset settings to not have inter-tests interference.
683 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000684 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000685
686 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000687 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000688 if not self.failed:
689 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100690 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000691 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
692 if len(self.calls) > 5:
693 calls += ' ...\n'
694 self.fail(
695 '\n'
696 'There are un-consumed calls after this test has finished:\n' +
697 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000698 finally:
699 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000700
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000701 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000702 self.assertTrue(
703 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700704 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000705 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000706 expected_args, result = top
707
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000708 # Also logs otherwise it could get caught in a try/finally and be hard to
709 # diagnose.
710 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700711 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000712 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700713 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
714 for i, c in enumerate(self._calls_done[-N:]))
715 following_calls = '\n '.join(
716 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
717 for i, c in enumerate(self.calls[:N]))
718 extended_msg = (
719 'A few prior calls:\n %s\n\n'
720 'This (expected):\n @%d: %r\n'
721 'This (actual):\n @%d: %r\n\n'
722 'A few following expected calls:\n %s' %
723 (prior_calls, len(self._calls_done), expected_args,
724 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700725
Edward Lesmes0dd54822020-03-26 18:24:25 +0000726 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700727 self.fail('@%d\n'
728 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000729 ' Actual: %r\n'
730 '\n'
731 '%s' % (
732 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700733
734 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700735 if isinstance(result, Exception):
736 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000737 # stdout from git commands is supposed to be a bytestream. Convert it here
738 # instead of converting all test output in this file to bytes.
739 if args[0][0] == 'git' and not isinstance(result, bytes):
740 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000741 return result
742
Edward Lemur1a83da12020-03-04 21:18:36 +0000743 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
744 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100745 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100746 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000747 self.assertEqual(
748 'prompt [Yes/No]: Please, type yes or no: ',
749 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100750
tandrii48df5812016-10-17 03:55:37 -0700751 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000752 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700753 self.calls = [
754 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700755 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
756 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
757 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
758 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700759 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
760 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700761 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
762 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000763 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
764 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700765 ((['git', 'config', 'gerrit.host', 'true'],), ''),
766 ]
767 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
768
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000769 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100770 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200771 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000772 custom_cl_base=None, short_hostname='chromium',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000773 change_id=None, default_branch='master'):
Edward Lemur26964072020-02-19 19:18:51 +0000774 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200775 if custom_cl_base:
776 ancestor_revision = custom_cl_base
777 else:
778 # Determine ancestor_revision to be merge base.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000779 ancestor_revision = 'origin/' + default_branch
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200780
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100781 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000782 gerrit_util.GetChangeDetail.return_value = {
783 'owner': {'email': (other_cl_owner or 'owner@example.com')},
784 'change_id': (change_id or '123456789'),
785 'current_revision': 'sha1_of_current_revision',
786 'revisions': {'sha1_of_current_revision': {
787 'commit': {'message': fetched_description},
788 }},
789 'status': fetched_status or 'NEW',
790 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100791 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100792 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100793 if other_cl_owner:
794 calls += [
795 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
796 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100797
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100798 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200799 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
800 ([custom_cl_base] if custom_cl_base else
801 [ancestor_revision, 'HEAD']),),
802 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100803 ]
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000804 calls += [
805 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000806 '1' if default_branch == 'main' else callError(1)),
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000807 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000808
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100809 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000810
Edward Lemur26964072020-02-19 19:18:51 +0000811 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700812 squash_mode='default',
Aaron Gablefd238082017-06-07 13:42:34 -0700813 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100814 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000815 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000816 short_hostname='chromium',
Edward Lemur5a644f82020-03-18 16:44:57 +0000817 labels=None, change_id=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000818 final_description=None, gitcookies_exists=True,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000819 force=False, edit_description=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000820 default_branch='master'):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000821 if post_amend_description is None:
822 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700823 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200824
825 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000826
Edward Lesmes4de54132020-05-05 19:41:33 +0000827 if squash_mode in ('override_squash', 'override_nosquash'):
828 self.mockGit.config['gerrit.override-squash-uploads'] = (
829 'true' if squash_mode == 'override_squash' else 'false')
830
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000831 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000832 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200833 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200834 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000835 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000836 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000837 calls += [
838 ((['RunEditor'],), description),
839 ]
Josipe827b0f2020-01-30 00:07:20 +0000840 # user wants to edit description
841 if edit_description:
842 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000843 ((['RunEditor'],), edit_description),
844 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000845 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200846
847 if custom_cl_base is None:
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000848 parent = 'origin/' + default_branch
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000849 git_common.get_or_create_merge_base.return_value = parent
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200850 else:
851 calls += [
852 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000853 'refs/remotes/origin/' + default_branch],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200854 callError(1)), # Means not ancenstor.
855 (('ask_for_data',
856 'Do you take responsibility for cleaning up potential mess '
857 'resulting from proceeding with upload? Press Enter to upload, '
858 'or Ctrl+C to abort'), ''),
859 ]
860 parent = custom_cl_base
861
862 calls += [
863 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
864 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000865 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200866 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000867 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200868 ref_to_push),
869 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000870 else:
871 ref_to_push = 'HEAD'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000872 parent = 'origin/refs/heads/' + default_branch
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000873
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000874 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000875 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000876 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200877 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000878
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000879 metrics_arguments = []
880
Aaron Gableafd52772017-06-27 16:40:10 -0700881 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700882 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000883 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700884 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400885 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700886 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000887 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700888 else:
889 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000890 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800891
Edward Lemur5a644f82020-03-18 16:44:57 +0000892 # If issue is given, then description is fetched from Gerrit instead.
893 if issue is None:
894 if squash:
895 title = 'Initial upload'
896 else:
897 if not title:
898 calls += [
899 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
900 (('ask_for_data', 'Title for patchset []: '), 'User input'),
901 ]
902 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700903 if title:
Edward Lemur5a644f82020-03-18 16:44:57 +0000904 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000905 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000906
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000907 if short_hostname == 'chromium':
Quinten Yearsley925cedb2020-04-13 17:49:39 +0000908 # All reviewers and ccs get into ref_suffix.
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000909 for r in sorted(reviewers):
910 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000911 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000912 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000913 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000914 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000915 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000916 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000917 reviewers, cc = [], []
918 else:
919 # TODO(crbug/877717): remove this case.
920 calls += [
921 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
922 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000923 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000924 {
925 e: {'email': e}
926 for e in (reviewers + ['joe@example.com'] + cc)
927 })
928 ]
929 for r in sorted(reviewers):
930 if r != 'bad-account-or-email':
931 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000932 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000933 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000934 if issue is None:
935 cc += ['joe@example.com']
936 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000937 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000938 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000939 if c in cc:
940 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000941
Edward Lemur687ca902018-12-05 02:30:30 +0000942 for k, v in sorted((labels or {}).items()):
943 ref_suffix += ',l=%s+%d' % (k, v)
944 metrics_arguments.append('l=%s+%d' % (k, v))
945
946 if tbr:
947 calls += [
948 (('GetCodeReviewTbrScore',
949 '%s-review.googlesource.com' % short_hostname,
950 'my/repo'),
951 2,),
952 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000953
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000954 calls += [
955 (('time.time',), 1000,),
956 ((['git', 'push',
957 'https://%s.googlesource.com/my/repo' % short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000958 ref_to_push + ':refs/for/refs/heads/' + default_branch + ref_suffix],),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000959 (('remote:\n'
960 'remote: Processing changes: (\)\n'
961 'remote: Processing changes: (|)\n'
962 'remote: Processing changes: (/)\n'
963 'remote: Processing changes: (-)\n'
964 'remote: Processing changes: new: 1 (/)\n'
965 'remote: Processing changes: new: 1, done\n'
966 'remote:\n'
967 'remote: New Changes:\n'
968 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
969 ' XXX\n'
970 'remote:\n'
971 'To https://%s.googlesource.com/my/repo\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000972 ' * [new branch] hhhh -> refs/for/refs/heads/%s\n'
973 ) % (short_hostname, short_hostname, default_branch)),),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000974 (('time.time',), 2000,),
975 (('add_repeated',
976 'sub_commands',
977 {
978 'execution_time': 1000,
979 'command': 'git push',
980 'exit_code': 0,
981 'arguments': sorted(metrics_arguments),
982 }),
983 None,),
984 ]
985
Edward Lemur1b52d872019-05-09 21:12:12 +0000986 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000987
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000988 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
989
Edward Lemur1b52d872019-05-09 21:12:12 +0000990 # Trace-related calls
991 calls += [
992 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000993 (
994 ([
995 'FileWrite', trace_name + '-README',
996 '%(date)s\n'
997 '%(short_hostname)s-review.googlesource.com\n'
998 '%(change_id)s\n'
999 '%(title)s\n'
1000 '%(description)s\n'
1001 '1000\n'
1002 '0\n'
1003 '%(trace_name)s' % {
Josip Sokcevic5e18b602020-04-23 21:47:00 +00001004 'date': '2017-03-16T20:00:41.000000',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001005 'short_hostname': short_hostname,
1006 'change_id': change_id,
1007 'description': final_description,
1008 'title': title or '<untitled>',
1009 'trace_name': trace_name,
1010 }
1011 ], ),
1012 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001013 ),
1014 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001015 (
1016 (['os.path.isfile',
1017 os.path.join('TEMP_DIR', 'trace-packet')], ),
1018 True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001019 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001020 (
1021 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
1022 ('git-hash: 0123456789012345678901234567890123456789\n'
1023 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +00001024 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001025 (
1026 ([
1027 'FileWrite',
1028 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
1029 'git-hash: abcdea\n'
1030 ], ),
1031 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001032 ),
1033 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001034 (
1035 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
1036 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001037 ),
1038 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001039 (
1040 (['git', 'config', '-l'], ),
1041 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +00001042 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001043 (
1044 ([
1045 'FileWrite',
1046 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
1047 ], ),
1048 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001049 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001050 (
1051 (['os.path.isfile',
1052 os.path.join('~', '.gitcookies')], ),
1053 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +00001054 ),
1055 ]
1056 if gitcookies_exists:
1057 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001058 (
1059 (['FileRead', os.path.join('~', '.gitcookies')], ),
1060 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +00001061 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001062 (
1063 ([
1064 'FileWrite',
1065 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
1066 ], ),
1067 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001068 ),
1069 ]
1070 calls += [
1071 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001072 (
1073 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
1074 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001075 ),
1076 ]
1077
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001078 # TODO(crbug/877717): this should never be used.
1079 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001080 calls += [
1081 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001082 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001083 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001084 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001085 notify),
1086 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001087 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001088 return calls
1089
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001090 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001091 self,
1092 upload_args,
1093 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001094 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001095 squash=True,
1096 squash_mode=None,
Aaron Gable9b713dd2016-12-14 16:04:21 -08001097 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001098 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001099 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001100 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001101 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001102 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001103 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001104 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001105 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001106 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001107 labels=None,
1108 change_id=None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001109 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001110 gitcookies_exists=True,
1111 force=False,
Edward Lesmes0dd54822020-03-26 18:24:25 +00001112 log_description=None,
Josipe827b0f2020-01-30 00:07:20 +00001113 edit_description=None,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001114 fetched_description=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001115 default_branch='master'):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001116 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001117 if squash_mode is None:
1118 if '--no-squash' in upload_args:
1119 squash_mode = 'nosquash'
1120 elif '--squash' in upload_args:
1121 squash_mode = 'squash'
1122 else:
1123 squash_mode = 'default'
1124
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001125 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001126 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001127 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001128 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001129 same_auth=('git-owner.example.com', '', 'pass'))).start()
1130 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1131 lambda _, offer_removal: None).start()
1132 mock.patch('git_cl.gclient_utils.RunEditor',
1133 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1134 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001135 'DownloadGerritHook', force)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001136 mock.patch('git_cl.gclient_utils.FileRead',
1137 lambda path: self._mocked_call(['FileRead', path])).start()
1138 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001139 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001140 ['FileWrite', path, contents])).start()
1141 mock.patch('git_cl.datetime_now',
1142 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1143 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1144 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1145 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001146 '%(now)s\n'
1147 '%(gerrit_host)s\n'
1148 '%(change_id)s\n'
1149 '%(title)s\n'
1150 '%(description)s\n'
1151 '%(execution_time)s\n'
1152 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001153 '%(trace_name)s').start()
1154 mock.patch('git_cl.shutil.make_archive',
1155 lambda *args: self._mocked_call(['make_archive'] +
1156 list(args))).start()
1157 mock.patch('os.path.isfile',
1158 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001159 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001160 'git_cl._create_description_from_log',
1161 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001162 mock.patch(
1163 'git_cl.Changelist._AddChangeIdToCommitMessage',
1164 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001165 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001166 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1167 mock.patch(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001168 'git_common.get_or_create_merge_base',
1169 return_value='origin/' + default_branch).start()
1170 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001171 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001172 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001173
Edward Lemur26964072020-02-19 19:18:51 +00001174 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001175 self.mockGit.config['branch.master.gerritissue'] = (
1176 str(issue) if issue else None)
1177 self.mockGit.config['remote.origin.url'] = (
1178 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001179 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001180
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001181 self.calls = self._gerrit_base_calls(
1182 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001183 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001184 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001185 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001186 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001187 short_hostname=short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001188 change_id=change_id,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001189 default_branch=default_branch)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001190 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001191 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001192 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001193 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001194 self.calls += self._gerrit_upload_calls(
1195 description, reviewers, squash,
1196 squash_mode=squash_mode,
Aaron Gablefd238082017-06-07 13:42:34 -07001197 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001198 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001199 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001200 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001201 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001202 labels=labels,
1203 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001204 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001205 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001206 force=force,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001207 edit_description=edit_description,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001208 default_branch=default_branch)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001209 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001210 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001211 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001212 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001213 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001214 self.assertEqual(
1215 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001216 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001217
Edward Lemur1b52d872019-05-09 21:12:12 +00001218 def test_gerrit_upload_traces_no_gitcookies(self):
1219 self._run_gerrit_upload_test(
1220 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001221 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001222 [],
1223 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001224 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001225 change_id='Ixxx',
1226 gitcookies_exists=False)
1227
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001228 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001229 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001230 [],
1231 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1232 [],
1233 change_id='Ixxx')
1234
1235 def test_gerrit_upload_without_change_id_nosquash(self):
1236 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001237 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001238 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001239 [],
1240 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001241 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001242 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001243
Edward Lesmes4de54132020-05-05 19:41:33 +00001244 def test_gerrit_upload_without_change_id_override_nosquash(self):
1245 self._run_gerrit_upload_test(
1246 [],
1247 'desc ✔\n\nBUG=\n',
1248 [],
1249 squash=False,
1250 squash_mode='override_nosquash',
1251 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1252 change_id='Ixxx')
1253
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001254 def test_gerrit_no_reviewer(self):
1255 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001256 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001257 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001258 [],
1259 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001260 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001261 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001262
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001263 def test_gerrit_no_reviewer_non_chromium_host(self):
1264 # TODO(crbug/877717): remove this test case.
1265 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001266 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001267 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001268 [],
1269 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001270 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001271 short_hostname='other',
1272 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001273
Edward Lesmes0dd54822020-03-26 18:24:25 +00001274 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001275 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001276 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001277 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001278 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001279 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001280 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001281 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001282
ukai@chromium.orge8077812012-02-03 03:41:46 +00001283 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001284 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001285 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001286 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001287 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001288 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001289 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001290 notify=True,
1291 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001292 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001293 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001294
Anthony Polito8b955342019-09-24 19:01:36 +00001295 def test_gerrit_upload_force_sets_bug(self):
1296 self._run_gerrit_upload_test(
1297 ['-b', '10000', '-f'],
1298 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1299 [],
1300 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001301 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001302 change_id='Ixxx')
1303
Edward Lemur5fb22242020-03-12 22:05:13 +00001304 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001305 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001306 ['-b', '10000', '-m', 'Title', '--edit-description'],
1307 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001308 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001309 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001310 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001311 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001312 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001313 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001314
Dan Beamd8b04ca2019-10-10 21:23:26 +00001315 def test_gerrit_upload_force_sets_fixed(self):
1316 self._run_gerrit_upload_test(
1317 ['-x', '10000', '-f'],
1318 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1319 [],
1320 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001321 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001322 change_id='Ixxx')
1323
ukai@chromium.orge8077812012-02-03 03:41:46 +00001324 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001325 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1326 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001327 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001328 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001329 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001330 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001331 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001332 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001333 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001334 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001335 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001336 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001337
1338 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001339 self._run_gerrit_upload_test(
1340 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001341 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001342 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001343 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001344
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001345 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001346 self._run_gerrit_upload_test(
1347 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001348 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001349 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001350 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001351 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001352
Edward Lesmes0dd54822020-03-26 18:24:25 +00001353 def test_gerrit_upload_squash_first_title(self):
1354 self._run_gerrit_upload_test(
1355 ['-f', '-t', 'title'],
1356 'title\n\ndesc\n\nChange-Id: 123456789',
1357 [],
1358 force=True,
1359 squash=True,
1360 log_description='desc',
1361 change_id='123456789')
1362
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001363 def test_gerrit_upload_squash_first_with_labels(self):
1364 self._run_gerrit_upload_test(
1365 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001366 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001367 [],
1368 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001369 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001370 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001371
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001372 def test_gerrit_upload_squash_first_against_rev(self):
1373 custom_cl_base = 'custom_cl_base_rev_or_branch'
1374 self._run_gerrit_upload_test(
1375 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001376 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001377 [],
1378 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001379 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001380 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001381 self.assertIn(
1382 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1383 sys.stdout.getvalue())
1384
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001385 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001386 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001387 self._run_gerrit_upload_test(
1388 ['--squash'],
1389 description,
1390 [],
1391 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001392 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001393 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001394
Edward Lemurd55c5072020-02-20 01:09:07 +00001395 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001396 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001397 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001398 with self.assertRaises(SystemExitMock):
1399 self._run_gerrit_upload_test(
1400 ['--squash'],
1401 description,
1402 [],
1403 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001404 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001405 fetched_status='ABANDONED',
1406 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001407 self.assertEqual(
1408 'Change https://chromium-review.googlesource.com/123456 has been '
1409 'abandoned, new uploads are not allowed\n',
1410 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001411
Edward Lemurda4b6c62020-02-13 00:28:40 +00001412 @mock.patch(
1413 'gerrit_util.GetAccountDetails',
1414 return_value={'email': 'yet-another@example.com'})
1415 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001416 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001417 self._run_gerrit_upload_test(
1418 ['--squash'],
1419 description,
1420 [],
1421 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001422 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001423 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001424 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001425 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001426 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001427 'authenticate to Gerrit as yet-another@example.com.\n'
1428 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001429 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001430
Josipe827b0f2020-01-30 00:07:20 +00001431 def test_upload_change_description_editor(self):
1432 fetched_description = 'foo\n\nChange-Id: 123456789'
1433 description = 'bar\n\nChange-Id: 123456789'
1434 self._run_gerrit_upload_test(
1435 ['--squash', '--edit-description'],
1436 description,
1437 [],
1438 fetched_description=fetched_description,
1439 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001440 issue=123456,
1441 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001442 edit_description=description)
1443
Edward Lemurda4b6c62020-02-13 00:28:40 +00001444 @mock.patch('git_cl.RunGit')
1445 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001446 @mock.patch('sys.stdin', StringIO('\n'))
1447 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001448 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001449 def mock_run_git(*args, **_kwargs):
1450 if args[0] == ['for-each-ref',
1451 '--format=%(refname:short) %(upstream:short)',
1452 'refs/heads']:
1453 # Create a local branch dependency tree that looks like this:
1454 # test1 -> test2 -> test3 -> test4 -> test5
1455 # -> test3.1
1456 # test6 -> test0
1457 branch_deps = [
1458 'test2 test1', # test1 -> test2
1459 'test3 test2', # test2 -> test3
1460 'test3.1 test2', # test2 -> test3.1
1461 'test4 test3', # test3 -> test4
1462 'test5 test4', # test4 -> test5
1463 'test6 test0', # test0 -> test6
1464 'test7', # test7
1465 ]
1466 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001467 git_cl.RunGit.side_effect = mock_run_git
1468 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001469
1470 class MockChangelist():
1471 def __init__(self):
1472 pass
1473 def GetBranch(self):
1474 return 'test1'
1475 def GetIssue(self):
1476 return '123'
1477 def GetPatchset(self):
1478 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001479 def IsGerrit(self):
1480 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001481
1482 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1483 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001484 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001485 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001486 'This command will checkout all dependent branches '
1487 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001488 'or Ctrl+C to abort',
1489 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001490 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001491
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001492 def test_gerrit_change_id(self):
1493 self.calls = [
1494 ((['git', 'write-tree'], ),
1495 'hashtree'),
1496 ((['git', 'rev-parse', 'HEAD~0'], ),
1497 'branch-parent'),
1498 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1499 'A B <a@b.org> 1456848326 +0100'),
1500 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1501 'C D <c@d.org> 1456858326 +0100'),
1502 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1503 'hashchange'),
1504 ]
1505 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1506 self.assertEqual(change_id, 'Ihashchange')
1507
Edward Lesmes8170c292021-03-19 20:04:43 +00001508 @mock.patch('gerrit_util.IsCodeOwnersEnabledOnHost')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001509 @mock.patch('git_cl.Settings.GetBugPrefix')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001510 @mock.patch('git_cl.Changelist.FetchDescription')
1511 @mock.patch('git_cl.Changelist.GetBranch')
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001512 @mock.patch('git_cl.Changelist.GetCommonAncestorWithUpstream')
Edward Lesmese1576912021-02-16 21:53:34 +00001513 @mock.patch('git_cl.Changelist.GetGerritHost')
1514 @mock.patch('git_cl.Changelist.GetGerritProject')
1515 @mock.patch('git_cl.Changelist.GetRemoteBranch')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001516 @mock.patch('owners_client.OwnersClient.BatchListOwners')
1517 def getDescriptionForUploadTest(
Edward Lesmese1576912021-02-16 21:53:34 +00001518 self, mockBatchListOwners=None, mockGetRemoteBranch=None,
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001519 mockGetGerritProject=None, mockGetGerritHost=None,
1520 mockGetCommonAncestorWithUpstream=None, mockGetBranch=None,
Edward Lesmese1576912021-02-16 21:53:34 +00001521 mockFetchDescription=None, mockGetBugPrefix=None,
Edward Lesmes8170c292021-03-19 20:04:43 +00001522 mockIsCodeOwnersEnabledOnHost=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001523 initial_description='desc', bug=None, fixed=None, branch='branch',
1524 reviewers=None, tbrs=None, add_owners_to=None,
1525 expected_description='desc'):
1526 reviewers = reviewers or []
1527 tbrs = tbrs or []
1528 owners_by_path = {
1529 'a': ['a@example.com'],
1530 'b': ['b@example.com'],
1531 'c': ['c@example.com'],
1532 }
Edward Lesmes8170c292021-03-19 20:04:43 +00001533 mockIsCodeOwnersEnabledOnHost.return_value = True
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001534 mockGetBranch.return_value = branch
1535 mockGetBugPrefix.return_value = 'prefix'
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001536 mockGetCommonAncestorWithUpstream.return_value = 'upstream'
Edward Lesmese1576912021-02-16 21:53:34 +00001537 mockGetRemoteBranch.return_value = ('origin', 'refs/remotes/origin/main')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001538 mockFetchDescription.return_value = 'desc'
1539 mockBatchListOwners.side_effect = lambda ps: {
1540 p: owners_by_path.get(p)
1541 for p in ps
1542 }
1543
1544 cl = git_cl.Changelist(issue=1234)
1545 actual = cl._GetDescriptionForUpload(
1546 options=mock.Mock(
1547 bug=bug,
1548 fixed=fixed,
1549 reviewers=reviewers,
1550 tbrs=tbrs,
1551 add_owners_to=add_owners_to),
1552 git_diff_args=None,
1553 files=list(owners_by_path))
1554 self.assertEqual(expected_description, actual.description)
1555
1556 def testGetDescriptionForUpload(self):
1557 self.getDescriptionForUploadTest()
1558
1559 def testGetDescriptionForUpload_Bug(self):
1560 self.getDescriptionForUploadTest(
1561 bug='1234',
1562 expected_description='\n'.join([
1563 'desc',
1564 '',
1565 'Bug: prefix:1234',
1566 ]))
1567
1568 def testGetDescriptionForUpload_Fixed(self):
1569 self.getDescriptionForUploadTest(
1570 fixed='1234',
1571 expected_description='\n'.join([
1572 'desc',
1573 '',
1574 'Fixed: prefix:1234',
1575 ]))
1576
1577
1578 def testGetDescriptionForUpload_BugFromBranch(self):
1579 self.getDescriptionForUploadTest(
1580 branch='bug-1234',
1581 expected_description='\n'.join([
1582 'desc',
1583 '',
1584 'Bug: prefix:1234',
1585 ]))
1586
1587 def testGetDescriptionForUpload_FixedFromBranch(self):
1588 self.getDescriptionForUploadTest(
1589 branch='fix-1234',
1590 expected_description='\n'.join([
1591 'desc',
1592 '',
1593 'Fixed: prefix:1234',
1594 ]))
1595
1596 def testGetDescriptionForUpload_AddOwnersToR(self):
1597 self.getDescriptionForUploadTest(
1598 reviewers=['a@example.com'],
1599 tbrs=['b@example.com'],
1600 add_owners_to='R',
1601 expected_description='\n'.join([
1602 'desc',
1603 '',
1604 'R=a@example.com, c@example.com',
1605 'TBR=b@example.com',
1606 ]))
1607
1608 def testGetDescriptionForUpload_AddOwnersToTBR(self):
1609 self.getDescriptionForUploadTest(
1610 reviewers=['a@example.com'],
1611 tbrs=['b@example.com'],
1612 add_owners_to='TBR',
1613 expected_description='\n'.join([
1614 'desc',
1615 '',
1616 'R=a@example.com',
1617 'TBR=b@example.com, c@example.com',
1618 ]))
1619
1620 def testGetDescriptionForUpload_AddOwnersToNoOwnersNeeded(self):
1621 self.getDescriptionForUploadTest(
1622 reviewers=['a@example.com', 'c@example.com'],
1623 tbrs=['b@example.com'],
1624 add_owners_to='TBR',
1625 expected_description='\n'.join([
1626 'desc',
1627 '',
1628 'R=a@example.com, c@example.com',
1629 'TBR=b@example.com',
1630 ]))
1631
1632 def testGetDescriptionForUpload_Reviewers(self):
1633 self.getDescriptionForUploadTest(
1634 reviewers=['a@example.com', 'b@example.com'],
1635 expected_description='\n'.join([
1636 'desc',
1637 '',
1638 'R=a@example.com, b@example.com',
1639 ]))
1640
1641 def testGetDescriptionForUpload_TBRs(self):
1642 self.getDescriptionForUploadTest(
1643 tbrs=['a@example.com', 'b@example.com'],
1644 expected_description='\n'.join([
1645 'desc',
1646 '',
1647 'TBR=a@example.com, b@example.com',
1648 ]))
1649
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001650 def test_desecription_append_footer(self):
1651 for init_desc, footer_line, expected_desc in [
1652 # Use unique desc first lines for easy test failure identification.
1653 ('foo', 'R=one', 'foo\n\nR=one'),
1654 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1655 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1656 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1657 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1658 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1659 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1660 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1661 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1662 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1663 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1664 ]:
1665 desc = git_cl.ChangeDescription(init_desc)
1666 desc.append_footer(footer_line)
1667 self.assertEqual(desc.description, expected_desc)
1668
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001669 def test_update_reviewers(self):
1670 data = [
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001671 ('foo', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001672 'foo'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001673 ('foo\nR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001674 'foo\nR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001675 ('foo\nTBR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001676 'foo\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001677 ('foo', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001678 'foo\n\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001679 ('foo\nR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001680 'foo\n\nR=a@c, xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001681 ('foo\nTBR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001682 'foo\n\nR=a@c\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001683 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001684 'foo\n\nR=a@c, yy\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001685 ('foo\nBUG=', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001686 'foo\nBUG=\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001687 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001688 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001689 ('foo', ['a@c', 'b@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001690 'foo\n\nR=a@c, b@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001691 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001692 'foo\nBar\n\nR=c@c\nBUG='),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001693 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001694 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001695 # Same as the line before, but full of whitespaces.
1696 (
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001697 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001698 'foo\nBar\n\nR=c@c\n BUG =',
1699 ),
1700 # Whitespaces aren't interpreted as new lines.
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001701 ('foo BUG=allo R=joe ', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001702 'foo BUG=allo R=joe\n\nR=c@c'),
1703 # Redundant TBRs get promoted to Rs
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001704 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001705 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001706 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001707 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001708 actual = []
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001709 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001710 obj = git_cl.ChangeDescription(orig)
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001711 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001712 actual.append(obj.description)
1713 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001714
Nodir Turakulov23b82142017-11-16 11:04:25 -08001715 def test_get_hash_tags(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001716 self.calls = [
1717 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
1718 callError(1)),
1719 ] * 9
Nodir Turakulov23b82142017-11-16 11:04:25 -08001720 cases = [
1721 ('', []),
1722 ('a', []),
1723 ('[a]', ['a']),
1724 ('[aa]', ['aa']),
1725 ('[a ]', ['a']),
1726 ('[a- ]', ['a']),
1727 ('[a- b]', ['a-b']),
1728 ('[a--b]', ['a-b']),
1729 ('[a', []),
1730 ('[a]x', ['a']),
1731 ('[aa]x', ['aa']),
1732 ('[a b]', ['a-b']),
1733 ('[a b]', ['a-b']),
1734 ('[a__b]', ['a-b']),
1735 ('[a] x', ['a']),
1736 ('[a][b]', ['a', 'b']),
1737 ('[a] [b]', ['a', 'b']),
1738 ('[a][b]x', ['a', 'b']),
1739 ('[a][b] x', ['a', 'b']),
1740 ('[a]\n[b]', ['a']),
1741 ('[a\nb]', []),
1742 ('[a][', ['a']),
1743 ('Revert "[a] feature"', ['a']),
1744 ('Reland "[a] feature"', ['a']),
1745 ('Revert: [a] feature', ['a']),
1746 ('Reland: [a] feature', ['a']),
1747 ('Revert "Reland: [a] feature"', ['a']),
1748 ('Foo: feature', ['foo']),
1749 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001750 ('Change Foo::Bar', []),
1751 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001752 ('Revert "Foo bar: feature"', ['foo-bar']),
1753 ('Reland "Foo bar: feature"', ['foo-bar']),
1754 ]
1755 for desc, expected in cases:
1756 change_desc = git_cl.ChangeDescription(desc)
1757 actual = change_desc.get_hash_tags()
1758 self.assertEqual(
1759 actual,
1760 expected,
1761 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1762
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001763 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001764 self.assertEqual(None, git_cl.GetTargetRef(None,
1765 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001766 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001767
wittman@chromium.org455dc922015-01-26 20:15:50 +00001768 # Check default target refs for branches.
1769 self.assertEqual('refs/heads/master',
1770 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001771 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001772 self.assertEqual('refs/heads/master',
1773 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001774 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001775 self.assertEqual('refs/heads/master',
1776 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001777 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001778 self.assertEqual('refs/branch-heads/123',
1779 git_cl.GetTargetRef('origin',
1780 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001781 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001782 self.assertEqual('refs/diff/test',
1783 git_cl.GetTargetRef('origin',
1784 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001785 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001786 self.assertEqual('refs/heads/chrome/m42',
1787 git_cl.GetTargetRef('origin',
1788 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001789 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001790
1791 # Check target refs for user-specified target branch.
1792 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1793 'refs/remotes/branch-heads/123'):
1794 self.assertEqual('refs/branch-heads/123',
1795 git_cl.GetTargetRef('origin',
1796 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001797 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001798 for branch in ('origin/master', 'remotes/origin/master',
1799 'refs/remotes/origin/master'):
1800 self.assertEqual('refs/heads/master',
1801 git_cl.GetTargetRef('origin',
1802 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001803 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001804 for branch in ('master', 'heads/master', 'refs/heads/master'):
1805 self.assertEqual('refs/heads/master',
1806 git_cl.GetTargetRef('origin',
1807 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001808 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001809
Edward Lemurda4b6c62020-02-13 00:28:40 +00001810 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1811 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001812 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001813 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1814
Edward Lemur85153282020-02-14 22:06:29 +00001815 def assertIssueAndPatchset(
1816 self, branch='master', issue='123456', patchset='7',
1817 git_short_host='chromium'):
1818 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001819 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001820 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001821 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001822 self.assertEqual(
1823 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001824 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001825
Edward Lemur85153282020-02-14 22:06:29 +00001826 def _patch_common(self, git_short_host='chromium'):
Edward Lesmes50da7702020-03-30 19:23:43 +00001827 mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
Edward Lemur26964072020-02-19 19:18:51 +00001828 self.mockGit.config['remote.origin.url'] = (
1829 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001830 gerrit_util.GetChangeDetail.return_value = {
1831 'current_revision': '7777777777',
1832 'revisions': {
1833 '1111111111': {
1834 '_number': 1,
1835 'fetch': {'http': {
1836 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1837 'ref': 'refs/changes/56/123456/1',
1838 }},
1839 },
1840 '7777777777': {
1841 '_number': 7,
1842 'fetch': {'http': {
1843 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1844 'ref': 'refs/changes/56/123456/7',
1845 }},
1846 },
1847 },
1848 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001849
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001850 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001851 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001852 self.calls += [
1853 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1854 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001855 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001856 ]
1857 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001858 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001859
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001860 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001861 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001862 self.calls += [
1863 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1864 'refs/changes/56/123456/7'],), ''),
1865 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001866 ]
Edward Lemur85153282020-02-14 22:06:29 +00001867 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1868 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001869
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001870 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001871 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001872 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001873 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001874 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001875 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001876 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001877 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001878 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001879
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001880 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001881 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001882 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001883 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001884 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001885 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001886 ]
1887 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001888 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001889 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001890
Aaron Gable697a91b2018-01-19 15:20:15 -08001891 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001892 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001893 self.calls += [
1894 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1895 'refs/changes/56/123456/1'],), ''),
1896 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001897 ]
1898 self.assertEqual(git_cl.main(
1899 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1900 0)
Edward Lemur85153282020-02-14 22:06:29 +00001901 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001902
Edward Lemurd55c5072020-02-20 01:09:07 +00001903 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001904 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001905 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001906 self.calls += [
1907 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001908 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001909 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001910 ]
1911 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001912 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001913 self.assertEqual(
1914 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1915 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001916
Edward Lemurda4b6c62020-02-13 00:28:40 +00001917 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001918 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001919 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001920 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001921 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001922 self.mockGit.config['remote.origin.url'] = (
1923 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001924 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001925 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001926 self.assertEqual(
1927 'change 123456 at https://chromium-review.googlesource.com does not '
1928 'exist or you have no access to it\n',
1929 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001930
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001931 def _checkout_calls(self):
1932 return [
1933 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001934 'branch\\..*\\.gerritissue'], ),
1935 ('branch.ger-branch.gerritissue 123456\n'
1936 'branch.gbranch654.gerritissue 654321\n')),
1937 ]
1938
1939 def test_checkout_gerrit(self):
1940 """Tests git cl checkout <issue>."""
1941 self.calls = self._checkout_calls()
1942 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1943 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1944
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001945 def test_checkout_not_found(self):
1946 """Tests git cl checkout <issue>."""
1947 self.calls = self._checkout_calls()
1948 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1949
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001950 def test_checkout_no_branch_issues(self):
1951 """Tests git cl checkout <issue>."""
1952 self.calls = [
1953 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001954 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001955 ]
1956 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1957
Edward Lemur26964072020-02-19 19:18:51 +00001958 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00001959 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001960 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001961 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001962 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1963 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001964 self.mockGit.config['remote.origin.url'] = (
1965 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001966 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001967 cl.branch = 'master'
1968 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001969 return cl
1970
Edward Lemurd55c5072020-02-20 01:09:07 +00001971 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001972 def test_gerrit_ensure_authenticated_missing(self):
1973 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001974 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001975 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001976 with self.assertRaises(SystemExitMock):
1977 cl.EnsureAuthenticated(force=False)
1978 self.assertEqual(
1979 'Credentials for the following hosts are required:\n'
1980 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001981 'These are read from ~%(sep)s.gitcookies '
1982 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00001983 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001984 'https://chromium-review.googlesource.com/new-password\n' % {
1985 'sep': os.sep,
1986 'netrc': NETRC_FILENAME,
1987 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001988
1989 def test_gerrit_ensure_authenticated_conflict(self):
1990 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001991 'chromium.googlesource.com':
1992 ('git-one.example.com', None, 'secret1'),
1993 'chromium-review.googlesource.com':
1994 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001995 })
1996 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001997 (('ask_for_data', 'If you know what you are doing '
1998 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001999 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2000
2001 def test_gerrit_ensure_authenticated_ok(self):
2002 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002003 'chromium.googlesource.com':
2004 ('git-same.example.com', None, 'secret'),
2005 'chromium-review.googlesource.com':
2006 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002007 })
2008 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2009
tandrii@chromium.org28253532016-04-14 13:46:56 +00002010 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00002011 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
2012 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00002013 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2014
Eric Boren2fb63102018-10-05 13:05:03 +00002015 def test_gerrit_ensure_authenticated_bearer_token(self):
2016 cl = self._test_gerrit_ensure_authenticated_common(auth={
2017 'chromium.googlesource.com':
2018 ('', None, 'secret'),
2019 'chromium-review.googlesource.com':
2020 ('', None, 'secret'),
2021 })
2022 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2023 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2024 'chromium.googlesource.com')
2025 self.assertTrue('Bearer' in header)
2026
Daniel Chengcf6269b2019-05-18 01:02:12 +00002027 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00002028 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00002029 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002030 (('logging.warning',
2031 'Ignoring branch %(branch)s with non-https remote '
2032 '%(remote)s', {
2033 'branch': 'master',
2034 'remote': 'custom-scheme://repo'}
2035 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00002036 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002037 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2038 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2039 mock.patch('logging.warning',
2040 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002041 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002042 cl.branch = 'master'
2043 cl.branchref = 'refs/heads/master'
2044 cl.lookedup_issue = True
2045 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2046
Florian Mayerae510e82020-01-30 21:04:48 +00002047 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00002048 self.mockGit.config['remote.origin.url'] = (
2049 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00002050 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002051 (('logging.error',
2052 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2053 'but it doesn\'t exist.', {
2054 'remote': 'origin',
2055 'branch': 'master',
2056 'url': 'git@somehost.example:foo/bar.git'}
2057 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00002058 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002059 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2060 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2061 mock.patch('logging.error',
2062 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00002063 cl = git_cl.Changelist()
2064 cl.branch = 'master'
2065 cl.branchref = 'refs/heads/master'
2066 cl.lookedup_issue = True
2067 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2068
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002069 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00002070 self.mockGit.config['branch.master.gerritissue'] = '123'
2071 self.mockGit.config['branch.master.gerritserver'] = (
2072 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00002073 self.mockGit.config['remote.origin.url'] = (
2074 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002075 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00002076 (('SetReview', 'chromium-review.googlesource.com',
2077 'infra%2Finfra~123', None,
2078 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002079 ]
tandriid9e5ce52016-07-13 02:32:59 -07002080
2081 def test_cmd_set_commit_gerrit_clear(self):
2082 self._cmd_set_commit_gerrit_common(0)
2083 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2084
2085 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002086 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002087 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2088
tandriid9e5ce52016-07-13 02:32:59 -07002089 def test_cmd_set_commit_gerrit(self):
2090 self._cmd_set_commit_gerrit_common(2)
2091 self.assertEqual(0, git_cl.main(['set-commit']))
2092
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002093 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002094 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002095 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002096
2097 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002098 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002099
Edward Lemurda4b6c62020-02-13 00:28:40 +00002100 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07002101 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07002102 try:
2103 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00002104 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00002105 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00002106 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07002107
2108 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07002109 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002110 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002111 return 'foobar'
2112
Edward Lemurda4b6c62020-02-13 00:28:40 +00002113 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07002114 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002115 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002116 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00002117 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07002118
iannuccie53c9352016-08-17 14:40:40 -07002119 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002120
iannuccie53c9352016-08-17 14:40:40 -07002121 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002122 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002123 return 'foobar'
2124
Edward Lemurda4b6c62020-02-13 00:28:40 +00002125 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2126 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002127 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002128 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002129
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002130 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00002131 self.mockGit.config['remote.origin.url'] = (
2132 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002133 gerrit_util.GetChangeDetail.return_value = {
2134 'current_revision': 'sha1',
2135 'revisions': {'sha1': {
2136 'commit': {'message': 'foobar'},
2137 }},
2138 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002139 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002140 'description',
2141 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2142 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002143 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002144
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002145 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002146 mock.patch('git_cl.Changelist', ChangelistMock).start()
2147 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002148
2149 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2150 self.assertEqual('hihi', ChangelistMock.desc)
2151
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002152 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002153 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002154
2155 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002156 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002157 '# Enter a description of the change.\n'
2158 '# This will be displayed on the codereview site.\n'
2159 '# The first line will also be used as the subject of the review.\n'
2160 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002161 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002162 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002163 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002164 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002165 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002166
Edward Lemur6c6827c2020-02-06 21:15:18 +00002167 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002168 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002169
Edward Lemurda4b6c62020-02-13 00:28:40 +00002170 mock.patch('git_cl.Changelist.FetchDescription',
2171 lambda *args: current_desc).start()
2172 mock.patch('git_cl.Changelist.UpdateDescription',
2173 UpdateDescription).start()
2174 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002175
Edward Lemur85153282020-02-14 22:06:29 +00002176 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002177 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002178
Dan Beamd8b04ca2019-10-10 21:23:26 +00002179 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2180 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2181
2182 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002183 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002184 '# Enter a description of the change.\n'
2185 '# This will be displayed on the codereview site.\n'
2186 '# The first line will also be used as the subject of the review.\n'
2187 '#--------------------This line is 72 characters long'
2188 '--------------------\n'
2189 'Some.\n\nFixed: 123\nChange-Id: xxx',
2190 desc)
2191 return desc
2192
Edward Lemurda4b6c62020-02-13 00:28:40 +00002193 mock.patch('git_cl.Changelist.FetchDescription',
2194 lambda *args: current_desc).start()
2195 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002196
Edward Lemur85153282020-02-14 22:06:29 +00002197 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002198 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002199
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002200 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002201 mock.patch('git_cl.Changelist', ChangelistMock).start()
2202 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002203
2204 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2205 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2206
kmarshall3bff56b2016-06-06 18:31:47 -07002207 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002208 self.calls = [
2209 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002210 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002211 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002212 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002213 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002214 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002215
Edward Lemurda4b6c62020-02-13 00:28:40 +00002216 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002217 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002218 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2219 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002220 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002221
2222 self.assertEqual(0, git_cl.main(['archive', '-f']))
2223
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002224 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002225 self.calls = [
2226 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2227 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2228 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2229 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002230 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2231 ((['git', 'branch', '-D', 'foo'],), '')
2232 ]
2233
Edward Lemurda4b6c62020-02-13 00:28:40 +00002234 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002235 lambda branches, fine_grained, max_processes:
2236 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2237 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002238 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002239
2240 self.assertEqual(0, git_cl.main(['archive', '-f']))
2241
kmarshall3bff56b2016-06-06 18:31:47 -07002242 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002243 self.calls = [
2244 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2245 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002246 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002247 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002248
Edward Lemurda4b6c62020-02-13 00:28:40 +00002249 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002250 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002251 [(MockChangelistWithBranchAndIssue('master', 1),
2252 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002253
2254 self.assertEqual(1, git_cl.main(['archive', '-f']))
2255
2256 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002257 self.calls = [
2258 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2259 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002260 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002261 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002262
Edward Lemurda4b6c62020-02-13 00:28:40 +00002263 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002264 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002265 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2266 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002267 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002268
kmarshall9249e012016-08-23 12:02:16 -07002269 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2270
2271 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002272 self.calls = [
2273 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2274 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002275 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002276 ((['git', 'branch', '-D', 'foo'],), '')
2277 ]
kmarshall9249e012016-08-23 12:02:16 -07002278
Edward Lemurda4b6c62020-02-13 00:28:40 +00002279 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002280 lambda branches, fine_grained, max_processes:
2281 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2282 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002283 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002284
2285 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002286
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002287 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002288 self.calls = [
2289 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2290 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2291 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002292 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2293 'refs/tags/git-cl-archived-456-foo'),
2294 ((['git', 'branch', '-D', 'foo'],), CERR1),
2295 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2296 'refs/tags/git-cl-archived-456-foo'),
2297 ]
2298
Edward Lemurda4b6c62020-02-13 00:28:40 +00002299 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002300 lambda branches, fine_grained, max_processes:
2301 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2302 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002303 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002304
2305 self.assertEqual(0, git_cl.main(['archive', '-f']))
2306
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002307 def test_archive_with_format(self):
2308 self.calls = [
2309 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
2310 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2311 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2312 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2313 ((['git', 'branch', '-D', 'foo'], ), ''),
2314 ]
2315
2316 mock.patch('git_cl.get_cl_statuses',
2317 lambda branches, fine_grained, max_processes:
2318 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2319
2320 self.assertEqual(
2321 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2322
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002323 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002324 self.mockGit.config['branch.master.gerritissue'] = '123'
2325 self.mockGit.config['branch.master.gerritserver'] = (
2326 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002327 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002328 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002329 ]
2330 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002331 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2332 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002333
Aaron Gable400e9892017-07-12 15:31:21 -07002334 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002335 self.mockGit.config['branch.master.gerritissue'] = '123'
2336 self.mockGit.config['branch.master.gerritserver'] = (
2337 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002338 mock.patch('git_cl.Changelist.FetchDescription',
2339 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002340 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002341 ((['git', 'log', '-1', '--format=%B'],),
2342 'This is a description\n\nChange-Id: Ideadbeef'),
2343 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002344 ]
2345 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002346 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2347 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002348
phajdan.jre328cf92016-08-22 04:12:17 -07002349 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002350 self.mockGit.config['branch.master.gerritissue'] = '123'
2351 self.mockGit.config['branch.master.gerritserver'] = (
2352 'https://chromium-review.googlesource.com')
Nodir Turakulov27379632021-03-17 18:53:29 +00002353 self.mockGit.config['remote.origin.url'] = (
2354 'https://chromium.googlesource.com/chromium/src'
2355 )
2356 self.calls = [(
2357 (
2358 'write_json',
2359 'output.json',
2360 {
2361 'issue': 123,
2362 'issue_url': 'https://chromium-review.googlesource.com/123',
2363 'gerrit_host': 'chromium-review.googlesource.com',
2364 'gerrit_project': 'chromium/src',
2365 },
2366 ),
2367 '',
2368 )]
phajdan.jre328cf92016-08-22 04:12:17 -07002369 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2370
tandrii16e0b4e2016-06-07 10:34:28 -07002371 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002372 mock.patch(
2373 'git_cl.os.path.abspath',
2374 lambda path: self._mocked_call(['abspath', path])).start()
2375 mock.patch(
2376 'git_cl.os.path.exists',
2377 lambda path: self._mocked_call(['exists', path])).start()
2378 mock.patch(
2379 'git_cl.gclient_utils.FileRead',
2380 lambda path: self._mocked_call(['FileRead', path])).start()
2381 mock.patch(
2382 'git_cl.gclient_utils.rm_file_or_tree',
2383 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002384 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002385 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002386 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002387 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002388
2389 def test_GerritCommitMsgHookCheck_custom_hook(self):
2390 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002391 self.calls += [((['exists',
2392 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2393 ((['FileRead',
2394 os.path.join('.git', 'hooks', 'commit-msg')], ),
2395 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002396 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002397
2398 def test_GerritCommitMsgHookCheck_not_exists(self):
2399 cl = self._common_GerritCommitMsgHookCheck()
2400 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002401 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002402 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002403 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002404
2405 def test_GerritCommitMsgHookCheck(self):
2406 cl = self._common_GerritCommitMsgHookCheck()
2407 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002408 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2409 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002410 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002411 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002412 ((['rm_file_or_tree',
2413 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002414 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002415 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002416
tandriic4344b52016-08-29 06:04:54 -07002417 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002418 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2419 self.mockGit.config['branch.master.gerritserver'] = (
2420 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002421 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002422 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002423 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002424 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002425 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002426 'labels': {},
2427 'current_revision': 'deadbeaf',
2428 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002429 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002430 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002431 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002432 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2433 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002434 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002435 self.assertEqual(0, cl.CMDLand(force=True,
2436 bypass_hooks=True,
2437 verbose=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002438 parallel=False,
2439 resultdb=False,
2440 realm=None))
Edward Lemur73c76702020-02-06 23:57:18 +00002441 self.assertIn(
2442 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002443 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002444 self.assertIn(
2445 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002446 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002447
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002448 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002449 mock.patch('git_cl.Changelist.GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002450
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002451 def test_gerrit_change_detail_cache_simple(self):
2452 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002453 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002454 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002455 cl1._cached_remote_url = (
2456 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002457 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002458 cl2._cached_remote_url = (
2459 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002460 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2461 self.assertEqual(cl1._GetChangeDetail(), 'a')
2462 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002463
2464 def test_gerrit_change_detail_cache_options(self):
2465 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002466 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002467 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002468 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002469 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2470 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2471 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2472 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2473 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2474 self.assertEqual(cl._GetChangeDetail(), 'cab')
2475
2476 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2477 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2478 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2479 self.assertEqual(cl._GetChangeDetail(), 'cab')
2480
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002481 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002482 gerrit_util.GetChangeDetail.return_value = {
2483 'current_revision': 'rev1',
2484 'revisions': {
2485 'rev1': {'commit': {'message': 'desc1'}},
2486 },
2487 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002488
2489 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002490 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002491 cl._cached_remote_url = (
2492 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002493 self.assertEqual(cl.FetchDescription(), 'desc1')
2494 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002495
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002496 def test_print_current_creds(self):
2497 class CookiesAuthenticatorMock(object):
2498 def __init__(self):
2499 self.gitcookies = {
2500 'host.googlesource.com': ('user', 'pass'),
2501 'host-review.googlesource.com': ('user', 'pass'),
2502 }
2503 self.netrc = self
2504 self.netrc.hosts = {
2505 'github.com': ('user2', None, 'pass2'),
2506 'host2.googlesource.com': ('user3', None, 'pass'),
2507 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002508 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2509 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002510 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2511 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2512 ' Host\t User\t Which file',
2513 '============================\t=====\t===========',
2514 'host-review.googlesource.com\t user\t.gitcookies',
2515 ' host.googlesource.com\t user\t.gitcookies',
2516 ' host2.googlesource.com\tuser3\t .netrc',
2517 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002518 sys.stdout.seek(0)
2519 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002520 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2521 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2522 ' Host\tUser\t Which file',
2523 '============================\t====\t===========',
2524 'host-review.googlesource.com\tuser\t.gitcookies',
2525 ' host.googlesource.com\tuser\t.gitcookies',
2526 ])
2527
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002528 def _common_creds_check_mocks(self):
2529 def exists_mock(path):
2530 dirname = os.path.dirname(path)
2531 if dirname == os.path.expanduser('~'):
2532 dirname = '~'
2533 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002534 if base in (NETRC_FILENAME, '.gitcookies'):
2535 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002536 # git cl also checks for existence other files not relevant to this test.
2537 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002538 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002539 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002540 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002541 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002542
2543 def test_creds_check_gitcookies_not_configured(self):
2544 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002545 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2546 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002547 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002548 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2549 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2550 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2551 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2552 'or Ctrl+C to abort'), ''),
2553 (([
2554 'git', 'config', '--global', 'http.cookiefile',
2555 os.path.expanduser(os.path.join('~', '.gitcookies'))
2556 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002557 ]
2558 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002559 self.assertTrue(
2560 sys.stdout.getvalue().startswith(
2561 'You seem to be using outdated .netrc for git credentials:'))
2562 self.assertIn(
2563 '\nConfigured git to use .gitcookies from',
2564 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002565
2566 def test_creds_check_gitcookies_configured_custom_broken(self):
2567 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002568 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2569 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002570 custom_cookie_path = ('C:\\.gitcookies'
2571 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002572 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002573 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2574 ((['git', 'config', '--global', 'http.cookiefile'], ),
2575 custom_cookie_path),
2576 (('os.path.exists', custom_cookie_path), False),
2577 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2578 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2579 (([
2580 'git', 'config', '--global', 'http.cookiefile',
2581 os.path.expanduser(os.path.join('~', '.gitcookies'))
2582 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002583 ]
2584 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002585 self.assertIn(
2586 'WARNING: You have configured custom path to .gitcookies: ',
2587 sys.stdout.getvalue())
2588 self.assertIn(
2589 'However, your configured .gitcookies file is missing.',
2590 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002591
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002592 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002593 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002594 self.mockGit.config['remote.origin.url'] = (
2595 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002596 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002597 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002598 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002599 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002600 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002601 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002602
Edward Lemurda4b6c62020-02-13 00:28:40 +00002603 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2604 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002605 self.mockGit.config['remote.origin.url'] = (
2606 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002607 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002608 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002609 'current_revision': 'ba5eba11',
2610 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002611 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002612 '_number': 1,
2613 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002614 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002615 '_number': 2,
2616 },
2617 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002618 'messages': [
2619 {
2620 u'_revision_number': 1,
2621 u'author': {
2622 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002623 u'email': u'could-be-anything@example.com',
2624 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002625 },
2626 u'date': u'2017-03-15 20:08:45.000000000',
2627 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002628 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002629 u'tag': u'autogenerated:cq:dry-run'
2630 },
2631 {
2632 u'_revision_number': 2,
2633 u'author': {
2634 u'_account_id': 11151243,
2635 u'email': u'owner@example.com',
2636 u'name': u'owner'
2637 },
2638 u'date': u'2017-03-16 20:00:41.000000000',
2639 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2640 u'message': u'PTAL',
2641 },
2642 {
2643 u'_revision_number': 2,
2644 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002645 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002646 u'email': u'reviewer@example.com',
2647 u'name': u'reviewer'
2648 },
2649 u'date': u'2017-03-17 05:19:37.500000000',
2650 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2651 u'message': u'Patch Set 2: Code-Review+1',
2652 },
2653 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002654 }
2655 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002656 (('GetChangeComments', 'chromium-review.googlesource.com',
2657 'infra%2Finfra~1'), {
2658 '/COMMIT_MSG': [
2659 {
2660 'author': {
2661 'email': u'reviewer@example.com'
2662 },
2663 'updated': u'2017-03-17 05:19:37.500000000',
2664 'patch_set': 2,
2665 'side': 'REVISION',
2666 'message': 'Please include a bug link',
2667 },
2668 ],
2669 'codereview.settings': [
2670 {
2671 'author': {
2672 'email': u'owner@example.com'
2673 },
2674 'updated': u'2017-03-16 20:00:41.000000000',
2675 'patch_set': 2,
2676 'side': 'PARENT',
2677 'line': 42,
2678 'message': 'I removed this because it is bad',
2679 },
2680 ]
2681 }),
2682 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2683 'infra%2Finfra~1'), {}),
2684 ] * 2 + [(('write_json', 'output.json', [{
2685 u'date':
2686 u'2017-03-16 20:00:41.000000',
2687 u'message': (u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2688 u' Base, Line 42: https://crrev.com/c/1/2/'
2689 u'codereview.settings#b42\n' +
2690 u' I removed this because it is bad\n'),
2691 u'autogenerated':
2692 False,
2693 u'approval':
2694 False,
2695 u'disapproval':
2696 False,
2697 u'sender':
2698 u'owner@example.com'
2699 }, {
2700 u'date':
2701 u'2017-03-17 05:19:37.500000',
2702 u'message':
2703 (u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2704 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
2705 u' Please include a bug link\n'),
2706 u'autogenerated':
2707 False,
2708 u'approval':
2709 False,
2710 u'disapproval':
2711 False,
2712 u'sender':
2713 u'reviewer@example.com'
2714 }]), '')]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002715 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002716 git_cl._CommentSummary(
2717 message=(u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2718 u' Base, Line 42: https://crrev.com/c/1/2/' +
2719 u'codereview.settings#b42\n' +
2720 u' I removed this because it is bad\n'),
2721 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2722 autogenerated=False,
2723 disapproval=False,
2724 approval=False,
2725 sender=u'owner@example.com'),
2726 git_cl._CommentSummary(message=(
2727 u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2728 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002729 u' Please include a bug link\n'),
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002730 date=datetime.datetime(2017, 3, 17, 5, 19, 37,
2731 500000),
2732 autogenerated=False,
2733 disapproval=False,
2734 approval=False,
2735 sender=u'reviewer@example.com'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002736 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002737 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002738 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002739 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002740 self.assertEqual(
2741 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2742
2743 def test_git_cl_comments_robot_comments(self):
2744 # git cl comments also fetches robot comments (which are considered a type
2745 # of autogenerated comment), and unlike other types of comments, only robot
2746 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002747 self.mockGit.config['remote.origin.url'] = (
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002748 'https://x.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002749 gerrit_util.GetChangeDetail.return_value = {
2750 'owner': {'email': 'owner@example.com'},
2751 'current_revision': 'ba5eba11',
2752 'revisions': {
2753 'deadbeaf': {
2754 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002755 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002756 'ba5eba11': {
2757 '_number': 2,
2758 },
2759 },
2760 'messages': [
2761 {
2762 u'_revision_number': 1,
2763 u'author': {
2764 u'_account_id': 1111084,
2765 u'email': u'commit-bot@chromium.org',
2766 u'name': u'Commit Bot'
2767 },
2768 u'date': u'2017-03-15 20:08:45.000000000',
2769 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2770 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2771 u'tag': u'autogenerated:cq:dry-run'
2772 },
2773 {
2774 u'_revision_number': 1,
2775 u'author': {
2776 u'_account_id': 123,
2777 u'email': u'tricium@serviceaccount.com',
2778 u'name': u'Tricium'
2779 },
2780 u'date': u'2017-03-16 20:00:41.000000000',
2781 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2782 u'message': u'(1 comment)',
2783 u'tag': u'autogenerated:tricium',
2784 },
2785 {
2786 u'_revision_number': 1,
2787 u'author': {
2788 u'_account_id': 123,
2789 u'email': u'tricium@serviceaccount.com',
2790 u'name': u'Tricium'
2791 },
2792 u'date': u'2017-03-16 20:00:41.000000000',
2793 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2794 u'message': u'(1 comment)',
2795 u'tag': u'autogenerated:tricium',
2796 },
2797 {
2798 u'_revision_number': 2,
2799 u'author': {
2800 u'_account_id': 123,
2801 u'email': u'tricium@serviceaccount.com',
2802 u'name': u'reviewer'
2803 },
2804 u'date': u'2017-03-17 05:30:37.000000000',
2805 u'tag': u'autogenerated:tricium',
2806 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2807 u'message': u'(1 comment)',
2808 },
2809 ]
2810 }
2811 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002812 (('GetChangeComments', 'x-review.googlesource.com', 'infra%2Finfra~1'),
2813 {}),
2814 (('GetChangeRobotComments', 'x-review.googlesource.com',
2815 'infra%2Finfra~1'), {
2816 'codereview.settings': [
2817 {
2818 u'author': {
2819 u'email': u'tricium@serviceaccount.com'
2820 },
2821 u'updated': u'2017-03-17 05:30:37.000000000',
2822 u'robot_run_id': u'5565031076855808',
2823 u'robot_id': u'Linter/Category',
2824 u'tag': u'autogenerated:tricium',
2825 u'patch_set': 2,
2826 u'side': u'REVISION',
2827 u'message': u'Linter warning message text',
2828 u'line': 32,
2829 },
2830 ],
2831 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002832 ]
2833 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002834 git_cl._CommentSummary(
2835 date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2836 message=(u'(1 comment)\n\ncodereview.settings\n'
2837 u' PS2, Line 32: https://x-review.googlesource.com/c/1/2/'
2838 u'codereview.settings#32\n'
2839 u' Linter warning message text\n'),
2840 sender=u'tricium@serviceaccount.com',
2841 autogenerated=True,
2842 approval=False,
2843 disapproval=False)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002844 ]
2845 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002846 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002847 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002848
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002849 def test_get_remote_url_with_mirror(self):
2850 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002851
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002852 def selective_os_path_isdir_mock(path):
2853 if path == '/cache/this-dir-exists':
2854 return self._mocked_call('os.path.isdir', path)
2855 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002856
Edward Lemurda4b6c62020-02-13 00:28:40 +00002857 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002858
2859 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002860 self.mockGit.config['remote.origin.url'] = (
2861 '/cache/this-dir-exists')
2862 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2863 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002864 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002865 (('os.path.isdir', '/cache/this-dir-exists'),
2866 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002867 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002868 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002869 self.assertEqual(cl.GetRemoteUrl(), url)
2870 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2871
Edward Lemur298f2cf2019-02-22 21:40:39 +00002872 def test_get_remote_url_non_existing_mirror(self):
2873 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002874
Edward Lemur298f2cf2019-02-22 21:40:39 +00002875 def selective_os_path_isdir_mock(path):
2876 if path == '/cache/this-dir-doesnt-exist':
2877 return self._mocked_call('os.path.isdir', path)
2878 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002879
Edward Lemurda4b6c62020-02-13 00:28:40 +00002880 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2881 mock.patch('logging.error',
2882 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002883
Edward Lemur26964072020-02-19 19:18:51 +00002884 self.mockGit.config['remote.origin.url'] = (
2885 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002886 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002887 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2888 False),
2889 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002890 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2891 'but it doesn\'t exist.', {
2892 'remote': 'origin',
2893 'branch': 'master',
2894 'url': '/cache/this-dir-doesnt-exist'}
2895 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002896 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002897 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002898 self.assertIsNone(cl.GetRemoteUrl())
2899
2900 def test_get_remote_url_misconfigured_mirror(self):
2901 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002902
Edward Lemur298f2cf2019-02-22 21:40:39 +00002903 def selective_os_path_isdir_mock(path):
2904 if path == '/cache/this-dir-exists':
2905 return self._mocked_call('os.path.isdir', path)
2906 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002907
Edward Lemurda4b6c62020-02-13 00:28:40 +00002908 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2909 mock.patch('logging.error',
2910 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002911
Edward Lemur26964072020-02-19 19:18:51 +00002912 self.mockGit.config['remote.origin.url'] = (
2913 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002914 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002915 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002916 (('logging.error',
2917 'Remote "%(remote)s" for branch "%(branch)s" points to '
2918 '"%(cache_path)s", but it is misconfigured.\n'
2919 '"%(cache_path)s" must be a git repo and must have a remote named '
2920 '"%(remote)s" pointing to the git host.', {
2921 'remote': 'origin',
2922 'cache_path': '/cache/this-dir-exists',
2923 'branch': 'master'}
2924 ), None),
2925 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002926 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002927 self.assertIsNone(cl.GetRemoteUrl())
2928
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002929 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002930 self.mockGit.config['remote.origin.url'] = (
2931 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002932 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002933 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2934
2935 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002936 mock.patch('logging.error',
2937 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002938
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002939 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002940 (('logging.error',
2941 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2942 'but it doesn\'t exist.', {
2943 'remote': 'origin',
2944 'branch': 'master',
2945 'url': ''}
2946 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002947 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002948 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002949 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002950
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002951 def test_gerrit_new_default(self):
2952 self._run_gerrit_upload_test(
2953 [],
2954 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
2955 [],
2956 squash=False,
2957 squash_mode='override_nosquash',
2958 change_id='I123456789',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002959 default_branch='main')
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002960
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002961
Edward Lemur9aa1a962020-02-25 00:58:38 +00002962class ChangelistTest(unittest.TestCase):
Edward Lemur227d5102020-02-25 23:45:35 +00002963 def setUp(self):
2964 super(ChangelistTest, self).setUp()
2965 mock.patch('gclient_utils.FileRead').start()
2966 mock.patch('gclient_utils.FileWrite').start()
2967 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
2968 mock.patch(
2969 'git_cl.Changelist.GetCodereviewServer',
2970 return_value='https://chromium-review.googlesource.com').start()
2971 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
2972 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
2973 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002974 mock.patch(
2975 'git_cl.Changelist.GetRemoteBranch',
2976 return_value=('origin', 'refs/remotes/origin/main')).start()
Edward Lemur227d5102020-02-25 23:45:35 +00002977 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
2978 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
2979 mock.patch('git_cl.time_time').start()
2980 mock.patch('metrics.collector').start()
2981 mock.patch('subprocess2.Popen').start()
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002982 mock.patch(
2983 'git_cl.Changelist.GetGerritProject', return_value='project').start()
Edward Lemur227d5102020-02-25 23:45:35 +00002984 self.addCleanup(mock.patch.stopall)
2985 self.temp_count = 0
2986
Edward Lemur227d5102020-02-25 23:45:35 +00002987 def testRunHook(self):
2988 expected_results = {
2989 'more_cc': ['more@example.com', 'cc@example.com'],
2990 'should_continue': True,
2991 }
2992 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2993 git_cl.time_time.side_effect = [100, 200]
2994 mockProcess = mock.Mock()
2995 mockProcess.wait.return_value = 0
2996 subprocess2.Popen.return_value = mockProcess
2997
2998 cl = git_cl.Changelist()
2999 results = cl.RunHook(
3000 committing=True,
3001 may_prompt=True,
3002 verbose=2,
3003 parallel=True,
3004 upstream='upstream',
3005 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003006 all_files=True,
3007 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003008
3009 self.assertEqual(expected_results, results)
3010 subprocess2.Popen.assert_called_once_with([
3011 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00003012 '--root', 'root',
3013 '--upstream', 'upstream',
3014 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00003015 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003016 '--gerrit_project', 'project',
3017 '--gerrit_branch', 'refs/heads/main',
3018 '--author', 'author',
Edward Lemur227d5102020-02-25 23:45:35 +00003019 '--issue', '123456',
3020 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003021 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00003022 '--may_prompt',
3023 '--parallel',
3024 '--all_files',
3025 '--json_output', '/tmp/fake-temp2',
3026 '--description_file', '/tmp/fake-temp1',
3027 ])
3028 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00003029 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00003030 metrics.collector.add_repeated('sub_commands', {
3031 'command': 'presubmit',
3032 'execution_time': 100,
3033 'exit_code': 0,
3034 })
3035
Edward Lemur99df04e2020-03-05 19:39:43 +00003036 def testRunHook_FewerOptions(self):
3037 expected_results = {
3038 'more_cc': ['more@example.com', 'cc@example.com'],
3039 'should_continue': True,
3040 }
3041 gclient_utils.FileRead.return_value = json.dumps(expected_results)
3042 git_cl.time_time.side_effect = [100, 200]
3043 mockProcess = mock.Mock()
3044 mockProcess.wait.return_value = 0
3045 subprocess2.Popen.return_value = mockProcess
3046
3047 git_cl.Changelist.GetAuthor.return_value = None
3048 git_cl.Changelist.GetIssue.return_value = None
3049 git_cl.Changelist.GetPatchset.return_value = None
Edward Lemur99df04e2020-03-05 19:39:43 +00003050
3051 cl = git_cl.Changelist()
3052 results = cl.RunHook(
3053 committing=False,
3054 may_prompt=False,
3055 verbose=0,
3056 parallel=False,
3057 upstream='upstream',
3058 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003059 all_files=False,
3060 resultdb=False)
Edward Lemur99df04e2020-03-05 19:39:43 +00003061
3062 self.assertEqual(expected_results, results)
3063 subprocess2.Popen.assert_called_once_with([
3064 'vpython', 'PRESUBMIT_SUPPORT',
3065 '--root', 'root',
3066 '--upstream', 'upstream',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003067 '--gerrit_url', 'https://chromium-review.googlesource.com',
3068 '--gerrit_project', 'project',
3069 '--gerrit_branch', 'refs/heads/main',
Edward Lemur99df04e2020-03-05 19:39:43 +00003070 '--upload',
3071 '--json_output', '/tmp/fake-temp2',
3072 '--description_file', '/tmp/fake-temp1',
3073 ])
3074 gclient_utils.FileWrite.assert_called_once_with(
3075 '/tmp/fake-temp1', 'description')
3076 metrics.collector.add_repeated('sub_commands', {
3077 'command': 'presubmit',
3078 'execution_time': 100,
3079 'exit_code': 0,
3080 })
3081
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003082 def testRunHook_FewerOptionsResultDB(self):
3083 expected_results = {
3084 'more_cc': ['more@example.com', 'cc@example.com'],
3085 'should_continue': True,
3086 }
3087 gclient_utils.FileRead.return_value = json.dumps(expected_results)
3088 git_cl.time_time.side_effect = [100, 200]
3089 mockProcess = mock.Mock()
3090 mockProcess.wait.return_value = 0
3091 subprocess2.Popen.return_value = mockProcess
3092
3093 git_cl.Changelist.GetAuthor.return_value = None
3094 git_cl.Changelist.GetIssue.return_value = None
3095 git_cl.Changelist.GetPatchset.return_value = None
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003096
3097 cl = git_cl.Changelist()
3098 results = cl.RunHook(
3099 committing=False,
3100 may_prompt=False,
3101 verbose=0,
3102 parallel=False,
3103 upstream='upstream',
3104 description='description',
3105 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003106 resultdb=True,
3107 realm='chromium:public')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003108
3109 self.assertEqual(expected_results, results)
3110 subprocess2.Popen.assert_called_once_with([
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003111 'rdb', 'stream', '-new', '-realm', 'chromium:public', '--',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003112 'vpython', 'PRESUBMIT_SUPPORT',
3113 '--root', 'root',
3114 '--upstream', 'upstream',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003115 '--gerrit_url', 'https://chromium-review.googlesource.com',
3116 '--gerrit_project', 'project',
3117 '--gerrit_branch', 'refs/heads/main',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003118 '--upload',
3119 '--json_output', '/tmp/fake-temp2',
3120 '--description_file', '/tmp/fake-temp1',
3121 ])
3122
Edward Lemur227d5102020-02-25 23:45:35 +00003123 @mock.patch('sys.exit', side_effect=SystemExitMock)
3124 def testRunHook_Failure(self, _mock):
3125 git_cl.time_time.side_effect = [100, 200]
3126 mockProcess = mock.Mock()
3127 mockProcess.wait.return_value = 2
3128 subprocess2.Popen.return_value = mockProcess
3129
3130 cl = git_cl.Changelist()
3131 with self.assertRaises(SystemExitMock):
3132 cl.RunHook(
3133 committing=True,
3134 may_prompt=True,
3135 verbose=2,
3136 parallel=True,
3137 upstream='upstream',
3138 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003139 all_files=True,
3140 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003141
3142 sys.exit.assert_called_once_with(2)
3143
Edward Lemur75526302020-02-27 22:31:05 +00003144 def testRunPostUploadHook(self):
3145 cl = git_cl.Changelist()
3146 cl.RunPostUploadHook(2, 'upstream', 'description')
3147
3148 subprocess2.Popen.assert_called_once_with([
3149 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00003150 '--root', 'root',
3151 '--upstream', 'upstream',
3152 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00003153 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003154 '--gerrit_project', 'project',
3155 '--gerrit_branch', 'refs/heads/main',
3156 '--author', 'author',
Edward Lemur75526302020-02-27 22:31:05 +00003157 '--issue', '123456',
3158 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003159 '--post_upload',
3160 '--description_file', '/tmp/fake-temp1',
3161 ])
3162 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00003163 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00003164
Edward Lemur9aa1a962020-02-25 00:58:38 +00003165
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003166class CMDTestCaseBase(unittest.TestCase):
3167 _STATUSES = [
3168 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3169 'INFRA_FAILURE', 'CANCELED',
3170 ]
3171 _CHANGE_DETAIL = {
3172 'project': 'depot_tools',
3173 'status': 'OPEN',
3174 'owner': {'email': 'owner@e.mail'},
3175 'current_revision': 'beeeeeef',
3176 'revisions': {
Gavin Make61ccc52020-11-13 00:12:57 +00003177 'deadbeaf': {
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003178 '_number': 6,
Gavin Make61ccc52020-11-13 00:12:57 +00003179 'kind': 'REWORK',
3180 },
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003181 'beeeeeef': {
3182 '_number': 7,
Gavin Make61ccc52020-11-13 00:12:57 +00003183 'kind': 'NO_CODE_CHANGE',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003184 'fetch': {'http': {
3185 'url': 'https://chromium.googlesource.com/depot_tools',
3186 'ref': 'refs/changes/56/123456/7'
3187 }},
3188 },
3189 },
3190 }
3191 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003192 'builds': [{
3193 'id': str(100 + idx),
3194 'builder': {
3195 'project': 'chromium',
3196 'bucket': 'try',
3197 'builder': 'bot_' + status.lower(),
3198 },
3199 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3200 'tags': [],
3201 'status': status,
3202 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003203 }
3204
Edward Lemur4c707a22019-09-24 21:13:43 +00003205 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003206 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003207 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003208 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3209 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003210 mock.patch(
3211 'git_cl.Changelist.GetCodereviewServer',
3212 return_value='https://chromium-review.googlesource.com').start()
3213 mock.patch(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00003214 'git_cl.Changelist.GetGerritHost',
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003215 return_value='chromium-review.googlesource.com').start()
3216 mock.patch(
3217 'git_cl.Changelist.GetMostRecentPatchset',
3218 return_value=7).start()
3219 mock.patch(
Gavin Make61ccc52020-11-13 00:12:57 +00003220 'git_cl.Changelist.GetMostRecentDryRunPatchset',
3221 return_value=6).start()
3222 mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003223 'git_cl.Changelist.GetRemoteUrl',
3224 return_value='https://chromium.googlesource.com/depot_tools').start()
3225 mock.patch(
3226 'auth.Authenticator',
3227 return_value=AuthenticatorMock()).start()
3228 mock.patch(
3229 'gerrit_util.GetChangeDetail',
3230 return_value=self._CHANGE_DETAIL).start()
3231 mock.patch(
3232 'git_cl._call_buildbucket',
3233 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003234 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003235 self.addCleanup(mock.patch.stopall)
3236
Edward Lemur4c707a22019-09-24 21:13:43 +00003237
Edward Lemur9468eba2020-02-27 19:07:22 +00003238class CMDPresubmitTestCase(CMDTestCaseBase):
3239 def setUp(self):
3240 super(CMDPresubmitTestCase, self).setUp()
3241 mock.patch(
3242 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3243 return_value='upstream').start()
3244 mock.patch(
3245 'git_cl.Changelist.FetchDescription',
3246 return_value='fetch description').start()
3247 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00003248 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00003249 return_value='get description').start()
3250 mock.patch('git_cl.Changelist.RunHook').start()
3251
3252 def testDefaultCase(self):
3253 self.assertEqual(0, git_cl.main(['presubmit']))
3254 git_cl.Changelist.RunHook.assert_called_once_with(
3255 committing=True,
3256 may_prompt=False,
3257 verbose=0,
3258 parallel=None,
3259 upstream='upstream',
3260 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003261 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003262 resultdb=None,
3263 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003264
3265 def testNoIssue(self):
3266 git_cl.Changelist.GetIssue.return_value = None
3267 self.assertEqual(0, git_cl.main(['presubmit']))
3268 git_cl.Changelist.RunHook.assert_called_once_with(
3269 committing=True,
3270 may_prompt=False,
3271 verbose=0,
3272 parallel=None,
3273 upstream='upstream',
3274 description='get description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003275 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003276 resultdb=None,
3277 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003278
3279 def testCustomBranch(self):
3280 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3281 git_cl.Changelist.RunHook.assert_called_once_with(
3282 committing=True,
3283 may_prompt=False,
3284 verbose=0,
3285 parallel=None,
3286 upstream='custom_branch',
3287 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003288 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003289 resultdb=None,
3290 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003291
3292 def testOptions(self):
3293 self.assertEqual(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003294 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003295 '--resultdb', '--realm', 'chromium:public']))
Edward Lemur9468eba2020-02-27 19:07:22 +00003296 git_cl.Changelist.RunHook.assert_called_once_with(
3297 committing=False,
3298 may_prompt=False,
3299 verbose=2,
3300 parallel=True,
3301 upstream='upstream',
3302 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003303 all_files=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003304 resultdb=True,
3305 realm='chromium:public')
Edward Lemur9468eba2020-02-27 19:07:22 +00003306
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003307class CMDTryResultsTestCase(CMDTestCaseBase):
3308 _DEFAULT_REQUEST = {
3309 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003310 "gerritChanges": [{
3311 "project": "depot_tools",
3312 "host": "chromium-review.googlesource.com",
Gavin Make61ccc52020-11-13 00:12:57 +00003313 "patchset": 6,
3314 "change": 123456,
3315 }],
3316 },
3317 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3318 ',builds.*.createTime,builds.*.tags'),
3319 }
3320
3321 _TRIVIAL_REQUEST = {
3322 'predicate': {
3323 "gerritChanges": [{
3324 "project": "depot_tools",
3325 "host": "chromium-review.googlesource.com",
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003326 "patchset": 7,
3327 "change": 123456,
3328 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003329 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003330 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3331 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003332 }
3333
3334 def testNoJobs(self):
3335 git_cl._call_buildbucket.return_value = {}
3336
3337 self.assertEqual(0, git_cl.main(['try-results']))
3338 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3339 git_cl._call_buildbucket.assert_called_once_with(
3340 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3341 self._DEFAULT_REQUEST)
3342
Gavin Make61ccc52020-11-13 00:12:57 +00003343 def testTrivialCommits(self):
3344 self.assertEqual(0, git_cl.main(['try-results']))
3345 git_cl._call_buildbucket.assert_called_with(
3346 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3347 self._DEFAULT_REQUEST)
3348
3349 git_cl._call_buildbucket.return_value = {}
3350 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '7']))
3351 git_cl._call_buildbucket.assert_called_with(
3352 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3353 self._TRIVIAL_REQUEST)
3354 self.assertEqual([
3355 'Successes:',
3356 ' bot_success https://ci.chromium.org/b/103',
3357 'Infra Failures:',
3358 ' bot_infra_failure https://ci.chromium.org/b/105',
3359 'Failures:',
3360 ' bot_failure https://ci.chromium.org/b/104',
3361 'Canceled:',
3362 ' bot_canceled ',
3363 'Started:',
3364 ' bot_started https://ci.chromium.org/b/102',
3365 'Scheduled:',
3366 ' bot_scheduled id=101',
3367 'Other:',
3368 ' bot_status_unspecified id=100',
3369 'Total: 7 tryjobs',
3370 'No tryjobs scheduled.',
3371 ], sys.stdout.getvalue().splitlines())
3372
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003373 def testPrintToStdout(self):
3374 self.assertEqual(0, git_cl.main(['try-results']))
3375 self.assertEqual([
3376 'Successes:',
3377 ' bot_success https://ci.chromium.org/b/103',
3378 'Infra Failures:',
3379 ' bot_infra_failure https://ci.chromium.org/b/105',
3380 'Failures:',
3381 ' bot_failure https://ci.chromium.org/b/104',
3382 'Canceled:',
3383 ' bot_canceled ',
3384 'Started:',
3385 ' bot_started https://ci.chromium.org/b/102',
3386 'Scheduled:',
3387 ' bot_scheduled id=101',
3388 'Other:',
3389 ' bot_status_unspecified id=100',
3390 'Total: 7 tryjobs',
3391 ], sys.stdout.getvalue().splitlines())
3392 git_cl._call_buildbucket.assert_called_once_with(
3393 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3394 self._DEFAULT_REQUEST)
3395
3396 def testPrintToStdoutWithMasters(self):
3397 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3398 self.assertEqual([
3399 'Successes:',
3400 ' try bot_success https://ci.chromium.org/b/103',
3401 'Infra Failures:',
3402 ' try bot_infra_failure https://ci.chromium.org/b/105',
3403 'Failures:',
3404 ' try bot_failure https://ci.chromium.org/b/104',
3405 'Canceled:',
3406 ' try bot_canceled ',
3407 'Started:',
3408 ' try bot_started https://ci.chromium.org/b/102',
3409 'Scheduled:',
3410 ' try bot_scheduled id=101',
3411 'Other:',
3412 ' try bot_status_unspecified id=100',
3413 'Total: 7 tryjobs',
3414 ], sys.stdout.getvalue().splitlines())
3415 git_cl._call_buildbucket.assert_called_once_with(
3416 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3417 self._DEFAULT_REQUEST)
3418
3419 @mock.patch('git_cl.write_json')
3420 def testWriteToJson(self, mockJsonDump):
3421 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3422 git_cl._call_buildbucket.assert_called_once_with(
3423 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3424 self._DEFAULT_REQUEST)
3425 mockJsonDump.assert_called_once_with(
3426 'file.json', self._DEFAULT_RESPONSE['builds'])
3427
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003428 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003429 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3430 self.assertEqual(
3431 [
3432 ('chromium', 'try', 'bot_failure'),
3433 ('chromium', 'try', 'bot_infra_failure'),
3434 ],
3435 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003436
3437 def test_filter_failed_for_retry_many_builds(self):
3438
3439 def _build(name, created_sec, status, experimental=False):
3440 assert 0 <= created_sec < 100, created_sec
3441 b = {
3442 'id': 112112,
3443 'builder': {
3444 'project': 'chromium',
3445 'bucket': 'try',
3446 'builder': name,
3447 },
3448 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3449 'status': status,
3450 'tags': [],
3451 }
3452 if experimental:
3453 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3454 return b
3455
3456 builds = [
3457 _build('flaky-last-green', 1, 'FAILURE'),
3458 _build('flaky-last-green', 2, 'SUCCESS'),
3459 _build('flaky', 1, 'SUCCESS'),
3460 _build('flaky', 2, 'FAILURE'),
3461 _build('running', 1, 'FAILED'),
3462 _build('running', 2, 'SCHEDULED'),
3463 _build('yep-still-running', 1, 'STARTED'),
3464 _build('yep-still-running', 2, 'FAILURE'),
3465 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3466 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3467
3468 # Simulate experimental in CQ builder, which developer decided
3469 # to retry manually which resulted in 2nd build non-experimental.
3470 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3471 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3472 ]
3473 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003474 self.assertEqual(
3475 [
3476 ('chromium', 'try', 'flaky'),
3477 ('chromium', 'try', 'sometimes-experimental'),
3478 ],
3479 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003480
3481
3482class CMDTryTestCase(CMDTestCaseBase):
3483
3484 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003485 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003486 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003487 self.assertEqual(0, git_cl.main(['try']))
3488 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3489 self.assertEqual(
3490 sys.stdout.getvalue(),
3491 'Scheduling CQ dry run on: '
3492 'https://chromium-review.googlesource.com/123456\n')
3493
Edward Lemur4c707a22019-09-24 21:13:43 +00003494 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003495 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003496 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003497
3498 self.assertEqual(0, git_cl.main([
3499 'try', '-B', 'luci.chromium.try', '-b', 'win',
3500 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3501 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003502 'Scheduling jobs on:\n'
3503 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003504 git_cl.sys.stdout.getvalue())
3505
3506 expected_request = {
3507 "requests": [{
3508 "scheduleBuild": {
3509 "requestId": "uuid4",
3510 "builder": {
3511 "project": "chromium",
3512 "builder": "win",
3513 "bucket": "try",
3514 },
3515 "gerritChanges": [{
3516 "project": "depot_tools",
3517 "host": "chromium-review.googlesource.com",
3518 "patchset": 7,
3519 "change": 123456,
3520 }],
3521 "properties": {
3522 "category": "git_cl_try",
3523 "json": [{"a": 1}, None],
3524 "key": "val",
3525 },
3526 "tags": [
3527 {"value": "win", "key": "builder"},
3528 {"value": "git_cl_try", "key": "user_agent"},
3529 ],
3530 },
3531 }],
3532 }
3533 mockCallBuildbucket.assert_called_with(
3534 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3535
Anthony Polito1a5fe232020-01-24 23:17:52 +00003536 @mock.patch('git_cl._call_buildbucket')
3537 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3538 mockCallBuildbucket.return_value = {}
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003539 mock.patch('git_cl.Changelist.GetRemoteBranch',
3540 return_value=('origin', 'refs/remotes/origin/main')).start()
Anthony Polito1a5fe232020-01-24 23:17:52 +00003541
3542 self.assertEqual(0, git_cl.main([
3543 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3544 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3545 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3546 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003547 'Scheduling jobs on:\n'
3548 ' chromium/try: linux\n'
3549 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003550 git_cl.sys.stdout.getvalue())
3551
3552 expected_request = {
3553 "requests": [{
3554 "scheduleBuild": {
3555 "requestId": "uuid4",
3556 "builder": {
3557 "project": "chromium",
3558 "builder": "linux",
3559 "bucket": "try",
3560 },
3561 "gerritChanges": [{
3562 "project": "depot_tools",
3563 "host": "chromium-review.googlesource.com",
3564 "patchset": 7,
3565 "change": 123456,
3566 }],
3567 "properties": {
3568 "category": "git_cl_try",
3569 "json": [{"a": 1}, None],
3570 "key": "val",
3571 },
3572 "tags": [
3573 {"value": "linux", "key": "builder"},
3574 {"value": "git_cl_try", "key": "user_agent"},
3575 ],
3576 "gitilesCommit": {
3577 "host": "chromium-review.googlesource.com",
3578 "project": "depot_tools",
3579 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003580 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003581 }
3582 },
3583 },
3584 {
3585 "scheduleBuild": {
3586 "requestId": "uuid4",
3587 "builder": {
3588 "project": "chromium",
3589 "builder": "win",
3590 "bucket": "try",
3591 },
3592 "gerritChanges": [{
3593 "project": "depot_tools",
3594 "host": "chromium-review.googlesource.com",
3595 "patchset": 7,
3596 "change": 123456,
3597 }],
3598 "properties": {
3599 "category": "git_cl_try",
3600 "json": [{"a": 1}, None],
3601 "key": "val",
3602 },
3603 "tags": [
3604 {"value": "win", "key": "builder"},
3605 {"value": "git_cl_try", "key": "user_agent"},
3606 ],
3607 "gitilesCommit": {
3608 "host": "chromium-review.googlesource.com",
3609 "project": "depot_tools",
3610 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003611 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003612 }
3613 },
3614 }],
3615 }
3616 mockCallBuildbucket.assert_called_with(
3617 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3618
Edward Lemur45768512020-03-02 19:03:14 +00003619 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003620 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003621 with self.assertRaises(SystemExit):
3622 git_cl.main([
3623 'try', '-B', 'not-a-bucket', '-b', 'win',
3624 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003625 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003626 'Invalid bucket: not-a-bucket.',
3627 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003628
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003629 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003630 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003631 def testScheduleOnBuildbucketRetryFailed(
3632 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003633 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003634 7: [],
3635 6: [{
3636 'id': 112112,
3637 'builder': {
3638 'project': 'chromium',
3639 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003640 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003641 'createTime': '2019-10-09T08:00:01.854286Z',
3642 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003643 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003644 mockCallBuildbucket.return_value = {}
3645
3646 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3647 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003648 'Scheduling jobs on:\n'
3649 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003650 git_cl.sys.stdout.getvalue())
3651
3652 expected_request = {
3653 "requests": [{
3654 "scheduleBuild": {
3655 "requestId": "uuid4",
3656 "builder": {
3657 "project": "chromium",
3658 "bucket": "try",
3659 "builder": "linux",
3660 },
3661 "gerritChanges": [{
3662 "project": "depot_tools",
3663 "host": "chromium-review.googlesource.com",
3664 "patchset": 7,
3665 "change": 123456,
3666 }],
3667 "properties": {
3668 "category": "git_cl_try",
3669 },
3670 "tags": [
3671 {"value": "linux", "key": "builder"},
3672 {"value": "git_cl_try", "key": "user_agent"},
3673 {"value": "1", "key": "retry_failed"},
3674 ],
3675 },
3676 }],
3677 }
3678 mockCallBuildbucket.assert_called_with(
3679 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3680
Edward Lemur4c707a22019-09-24 21:13:43 +00003681 def test_parse_bucket(self):
3682 test_cases = [
3683 {
3684 'bucket': 'chromium/try',
3685 'result': ('chromium', 'try'),
3686 },
3687 {
3688 'bucket': 'luci.chromium.try',
3689 'result': ('chromium', 'try'),
3690 'has_warning': True,
3691 },
3692 {
3693 'bucket': 'skia.primary',
3694 'result': ('skia', 'skia.primary'),
3695 'has_warning': True,
3696 },
3697 {
3698 'bucket': 'not-a-bucket',
3699 'result': (None, None),
3700 },
3701 ]
3702
3703 for test_case in test_cases:
3704 git_cl.sys.stdout.truncate(0)
3705 self.assertEqual(
3706 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3707 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003708 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3709 test_case['result'])
3710 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003711
3712
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003713class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003714
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003715 def setUp(self):
3716 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003717 mock.patch('git_cl._fetch_tryjobs').start()
3718 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003719 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003720 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3721 mock.patch(
3722 'git_cl.Settings.GetSquashGerritUploads',
3723 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003724 self.addCleanup(mock.patch.stopall)
3725
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003726 def testWarmUpChangeDetailCache(self):
3727 self.assertEqual(0, git_cl.main(['upload']))
3728 gerrit_util.GetChangeDetail.assert_called_once_with(
3729 'chromium-review.googlesource.com', 'depot_tools~123456',
3730 frozenset([
3731 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3732 'CURRENT_COMMIT']))
3733
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003734 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003735 # This test mocks out the actual upload part, and just asserts that after
3736 # upload, if --retry-failed is added, then the tool will fetch try jobs
3737 # from the previous patchset and trigger the right builders on the latest
3738 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003739 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003740 # Latest patchset: No builds.
3741 [],
3742 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003743 [{
3744 'id': str(100 + idx),
3745 'builder': {
3746 'project': 'chromium',
3747 'bucket': 'try',
3748 'builder': 'bot_' + status.lower(),
3749 },
3750 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3751 'tags': [],
3752 'status': status,
3753 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003754 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003755
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003756 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003757 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003758 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3759 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003760 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003761 expected_buckets = [
3762 ('chromium', 'try', 'bot_failure'),
3763 ('chromium', 'try', 'bot_infra_failure'),
3764 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003765 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3766 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003767
Brian Sheedy59b06a82019-10-14 17:03:29 +00003768
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003769class MakeRequestsHelperTestCase(unittest.TestCase):
3770
3771 def exampleGerritChange(self):
3772 return {
3773 'host': 'chromium-review.googlesource.com',
3774 'project': 'depot_tools',
3775 'change': 1,
3776 'patchset': 2,
3777 }
3778
3779 def testMakeRequestsHelperNoOptions(self):
3780 # Basic test for the helper function _make_tryjob_schedule_requests;
3781 # it shouldn't throw AttributeError even when options doesn't have any
3782 # of the expected values; it will use default option values.
3783 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3784 jobs = [('chromium', 'try', 'my-builder')]
3785 options = optparse.Values()
3786 requests = git_cl._make_tryjob_schedule_requests(
3787 changelist, jobs, options, patchset=None)
3788
3789 # requestId is non-deterministic. Just assert that it's there and has
3790 # a particular length.
3791 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3792 self.assertEqual(requests, [{
3793 'scheduleBuild': {
3794 'builder': {
3795 'bucket': 'try',
3796 'builder': 'my-builder',
3797 'project': 'chromium'
3798 },
3799 'gerritChanges': [self.exampleGerritChange()],
3800 'properties': {
3801 'category': 'git_cl_try'
3802 },
3803 'tags': [{
3804 'key': 'builder',
3805 'value': 'my-builder'
3806 }, {
3807 'key': 'user_agent',
3808 'value': 'git_cl_try'
3809 }]
3810 }
3811 }])
3812
3813 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3814 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3815 jobs = [('chromium', 'try', 'presubmit')]
3816 options = optparse.Values()
3817 requests = git_cl._make_tryjob_schedule_requests(
3818 changelist, jobs, options, patchset=None)
3819 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3820 'category': 'git_cl_try',
3821 'dry_run': 'true'
3822 })
3823
3824 def testMakeRequestsHelperRevisionSet(self):
3825 # Gitiles commit is specified when revision is in options.
3826 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3827 jobs = [('chromium', 'try', 'my-builder')]
3828 options = optparse.Values({'revision': 'ba5eba11'})
3829 requests = git_cl._make_tryjob_schedule_requests(
3830 changelist, jobs, options, patchset=None)
3831 self.assertEqual(
3832 requests[0]['scheduleBuild']['gitilesCommit'], {
3833 'host': 'chromium-review.googlesource.com',
3834 'id': 'ba5eba11',
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003835 'project': 'depot_tools',
3836 'ref': 'refs/heads/main',
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003837 })
3838
3839 def testMakeRequestsHelperRetryFailedSet(self):
3840 # An extra tag is added when retry_failed is in options.
3841 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3842 jobs = [('chromium', 'try', 'my-builder')]
3843 options = optparse.Values({'retry_failed': 'true'})
3844 requests = git_cl._make_tryjob_schedule_requests(
3845 changelist, jobs, options, patchset=None)
3846 self.assertEqual(
3847 requests[0]['scheduleBuild']['tags'], [
3848 {
3849 'key': 'builder',
3850 'value': 'my-builder'
3851 },
3852 {
3853 'key': 'user_agent',
3854 'value': 'git_cl_try'
3855 },
3856 {
3857 'key': 'retry_failed',
3858 'value': '1'
3859 }
3860 ])
3861
3862 def testMakeRequestsHelperCategorySet(self):
Quinten Yearsley925cedb2020-04-13 17:49:39 +00003863 # The category property can be overridden with options.
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003864 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3865 jobs = [('chromium', 'try', 'my-builder')]
3866 options = optparse.Values({'category': 'my-special-category'})
3867 requests = git_cl._make_tryjob_schedule_requests(
3868 changelist, jobs, options, patchset=None)
3869 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3870 {'category': 'my-special-category'})
3871
3872
Edward Lemurda4b6c62020-02-13 00:28:40 +00003873class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003874
3875 def setUp(self):
3876 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003877 mock.patch('git_cl.RunCommand').start()
3878 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3879 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3880 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003881 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003882 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003883
3884 def tearDown(self):
3885 shutil.rmtree(self._top_dir)
3886 super(CMDFormatTestCase, self).tearDown()
3887
Jamie Madill5e96ad12020-01-13 16:08:35 +00003888 def _make_temp_file(self, fname, contents):
3889 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3890 tf.write('\n'.join(contents))
3891
Brian Sheedy59b06a82019-10-14 17:03:29 +00003892 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003893 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003894
Brian Sheedyb4307d52019-12-02 19:18:17 +00003895 def _check_yapf_filtering(self, files, expected):
3896 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3897 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003898
Edward Lemur1a83da12020-03-04 21:18:36 +00003899 def _run_command_mock(self, return_value):
3900 def f(*args, **kwargs):
3901 if 'stdin' in kwargs:
3902 self.assertIsInstance(kwargs['stdin'], bytes)
3903 return return_value
3904 return f
3905
Jamie Madill5e96ad12020-01-13 16:08:35 +00003906 def testClangFormatDiffFull(self):
3907 self._make_temp_file('test.cc', ['// test'])
3908 git_cl.settings.GetFormatFullByDefault.return_value = False
3909 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3910 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3911
3912 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003913 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003914 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3915 self._top_dir, 'HEAD')
3916 self.assertEqual(2, return_value)
3917
3918 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003919 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003920 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3921 self._top_dir, 'HEAD')
3922 self.assertEqual(0, return_value)
3923
3924 def testClangFormatDiff(self):
3925 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00003926 # A valid file is required, so use this test.
3927 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00003928 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3929
3930 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003931 git_cl.RunCommand.side_effect = self._run_command_mock('error')
3932 return_value = git_cl._RunClangFormatDiff(
3933 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003934 self.assertEqual(2, return_value)
3935
3936 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003937 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003938 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3939 'HEAD')
3940 self.assertEqual(0, return_value)
3941
Brian Sheedyb4307d52019-12-02 19:18:17 +00003942 def testYapfignoreExplicit(self):
3943 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3944 files = [
3945 'bar.py',
3946 'foo/bar.py',
3947 'foo/baz.py',
3948 'foo/bar/baz.py',
3949 'foo/bar/foobar.py',
3950 ]
3951 expected = [
3952 'bar.py',
3953 'foo/baz.py',
3954 'foo/bar/foobar.py',
3955 ]
3956 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003957
Brian Sheedyb4307d52019-12-02 19:18:17 +00003958 def testYapfignoreSingleWildcards(self):
3959 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3960 files = [
3961 'bar.py', # Matched by *bar.py.
3962 'bar.txt',
3963 'foobar.py', # Matched by *bar.py, foo*.
3964 'foobar.txt', # Matched by foo*.
3965 'bazbar.py', # Matched by *bar.py, baz*.py.
3966 'bazbar.txt',
3967 'foo/baz.txt', # Matched by foo*.
3968 'bar/bar.py', # Matched by *bar.py.
3969 'baz/foo.py', # Matched by baz*.py, foo*.
3970 'baz/foo.txt',
3971 ]
3972 expected = [
3973 'bar.txt',
3974 'bazbar.txt',
3975 'baz/foo.txt',
3976 ]
3977 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003978
Brian Sheedyb4307d52019-12-02 19:18:17 +00003979 def testYapfignoreMultiplewildcards(self):
3980 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3981 files = [
3982 'bar.py', # Matched by *bar*.
3983 'bar.txt', # Matched by *bar*.
3984 'abar.py', # Matched by *bar*.
3985 'foobaz.txt', # Matched by *foo*baz.txt.
3986 'foobaz.py',
3987 'afoobaz.txt', # Matched by *foo*baz.txt.
3988 ]
3989 expected = [
3990 'foobaz.py',
3991 ]
3992 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003993
3994 def testYapfignoreComments(self):
3995 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003996 files = [
3997 'test.py',
3998 'test2.py',
3999 ]
4000 expected = [
4001 'test2.py',
4002 ]
4003 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004004
4005 def testYapfignoreBlankLines(self):
4006 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004007 files = [
4008 'test.py',
4009 'test2.py',
4010 'test3.py',
4011 ]
4012 expected = [
4013 'test3.py',
4014 ]
4015 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004016
4017 def testYapfignoreWhitespace(self):
4018 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004019 files = [
4020 'test.py',
4021 'test2.py',
4022 ]
4023 expected = [
4024 'test2.py',
4025 ]
4026 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004027
Brian Sheedyb4307d52019-12-02 19:18:17 +00004028 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00004029 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004030 self._check_yapf_filtering([], [])
4031
4032 def testYapfignoreMissingYapfignore(self):
4033 files = [
4034 'test.py',
4035 ]
4036 expected = [
4037 'test.py',
4038 ]
4039 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004040
4041
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004042class CMDStatusTestCase(CMDTestCaseBase):
4043 # Return branch names a,..,f with comitterdates in increasing order, i.e.
4044 # 'f' is the most-recently changed branch.
4045 def _mock_run_git(commands):
4046 if commands == [
4047 'for-each-ref', '--format=%(refname) %(committerdate:unix)',
4048 'refs/heads'
4049 ]:
4050 branches_and_committerdates = [
4051 'refs/heads/a 1',
4052 'refs/heads/b 2',
4053 'refs/heads/c 3',
4054 'refs/heads/d 4',
4055 'refs/heads/e 5',
4056 'refs/heads/f 6',
4057 ]
4058 return '\n'.join(branches_and_committerdates)
4059
4060 # Mock the status in such a way that the issue number gives us an
4061 # indication of the commit date (simplifies manual debugging).
4062 def _mock_get_cl_statuses(branches, fine_grained, max_processes):
4063 for c in branches:
4064 c.issue = (100 + int(c.GetCommitDate()))
4065 yield (c, 'open')
4066
4067 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4068 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4069 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4070 @mock.patch('git_cl.RunGit', _mock_run_git)
4071 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4072 @mock.patch('git_cl.Settings.GetRoot', return_value='')
4073 @mock.patch('scm.GIT.GetBranch', return_value='a')
4074 def testStatus(self, *_mocks):
4075 self.assertEqual(0, git_cl.main(['status', '--no-branch-color']))
4076 self.maxDiff = None
4077 self.assertEqual(
4078 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4079 ' * a : https://crrev.com/c/101 (open)\n'
4080 ' b : https://crrev.com/c/102 (open)\n'
4081 ' c : https://crrev.com/c/103 (open)\n'
4082 ' d : https://crrev.com/c/104 (open)\n'
4083 ' e : https://crrev.com/c/105 (open)\n'
4084 ' f : https://crrev.com/c/106 (open)\n\n'
4085 'Current branch: a\n'
4086 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4087 'Issue description:\n'
4088 'x\n')
4089
4090 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4091 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4092 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4093 @mock.patch('git_cl.RunGit', _mock_run_git)
4094 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4095 @mock.patch('git_cl.Settings.GetRoot', return_value='')
4096 @mock.patch('scm.GIT.GetBranch', return_value='a')
4097 def testStatusByDate(self, *_mocks):
4098 self.assertEqual(
4099 0, git_cl.main(['status', '--no-branch-color', '--date-order']))
4100 self.maxDiff = None
4101 self.assertEqual(
4102 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4103 ' f : https://crrev.com/c/106 (open)\n'
4104 ' e : https://crrev.com/c/105 (open)\n'
4105 ' d : https://crrev.com/c/104 (open)\n'
4106 ' c : https://crrev.com/c/103 (open)\n'
4107 ' b : https://crrev.com/c/102 (open)\n'
4108 ' * a : https://crrev.com/c/101 (open)\n\n'
4109 'Current branch: a\n'
4110 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4111 'Issue description:\n'
4112 'x\n')
4113
4114
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004115class CMDOwnersTestCase(CMDTestCaseBase):
4116 def setUp(self):
4117 super(CMDOwnersTestCase, self).setUp()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004118 self.owners_by_path = {
4119 'foo': ['a@example.com'],
4120 'bar': ['b@example.com', 'c@example.com'],
4121 }
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004122 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
4123 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
4124 mock.patch(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004125 'git_cl.Changelist.GetAffectedFiles',
4126 return_value=list(self.owners_by_path)).start()
4127 mock.patch(
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004128 'git_cl.Changelist.GetCommonAncestorWithUpstream',
4129 return_value='upstream').start()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004130 mock.patch(
Edward Lesmese1576912021-02-16 21:53:34 +00004131 'git_cl.Changelist.GetGerritHost',
4132 return_value='host').start()
4133 mock.patch(
4134 'git_cl.Changelist.GetGerritProject',
4135 return_value='project').start()
4136 mock.patch(
4137 'git_cl.Changelist.GetRemoteBranch',
4138 return_value=('origin', 'refs/remotes/origin/main')).start()
4139 mock.patch(
4140 'owners_client.OwnersClient.BatchListOwners',
Edward Lesmes82b992a2021-01-11 23:24:55 +00004141 return_value=self.owners_by_path).start()
Edward Lesmes8170c292021-03-19 20:04:43 +00004142 mock.patch(
4143 'gerrit_util.IsCodeOwnersEnabledOnHost', return_value=True).start()
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004144 self.addCleanup(mock.patch.stopall)
4145
4146 def testShowAllNoArgs(self):
4147 self.assertEqual(0, git_cl.main(['owners', '--show-all']))
4148 self.assertEqual(
4149 'No files specified for --show-all. Nothing to do.\n',
4150 git_cl.sys.stdout.getvalue())
4151
4152 def testShowAll(self):
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004153 self.assertEqual(
4154 0,
4155 git_cl.main(['owners', '--show-all', 'foo', 'bar', 'baz']))
Edward Lesmese1576912021-02-16 21:53:34 +00004156 owners_client.OwnersClient.BatchListOwners.assert_called_once_with(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004157 ['foo', 'bar', 'baz'])
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004158 self.assertEqual(
4159 '\n'.join([
4160 'Owners for foo:',
4161 ' - a@example.com',
4162 'Owners for bar:',
4163 ' - b@example.com',
4164 ' - c@example.com',
4165 'Owners for baz:',
4166 ' - No owners found',
4167 '',
4168 ]),
4169 sys.stdout.getvalue())
4170
Edward Lesmes82b992a2021-01-11 23:24:55 +00004171 def testBatch(self):
4172 self.assertEqual(0, git_cl.main(['owners', '--batch']))
4173 self.assertIn('a@example.com', sys.stdout.getvalue())
4174 self.assertIn('b@example.com', sys.stdout.getvalue())
4175
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004176
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004177if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01004178 logging.basicConfig(
4179 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004180 unittest.main()