blob: 00564cf7e1fc714015a56411f1986c292264213d [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
34# We have to disable monitoring before importing git_cl.
35metrics.DISABLE_METRICS_COLLECTION = True
36
Jamie Madill5e96ad12020-01-13 16:08:35 +000037import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000038import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000039import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000040import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000041import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000042import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000043import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000044import git_new_branch
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +000045import owners_client
Edward Lemur85153282020-02-14 22:06:29 +000046import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000047import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000048
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000049NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
50
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000051
Edward Lemur0db01f02019-11-12 22:01:51 +000052def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070053 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
54
tandrii5d48c322016-08-18 16:19:37 -070055CERR1 = callError(1)
56
57
Edward Lemur1773f372020-02-22 00:27:14 +000058class TemporaryFileMock(object):
59 def __init__(self):
60 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070061
Edward Lemur1773f372020-02-22 00:27:14 +000062 @contextlib.contextmanager
63 def __call__(self):
64 self.suffix += 1
65 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070066
67
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000068class ChangelistMock(object):
69 # A class variable so we can access it when we don't have access to the
70 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000071 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000072
73 def __init__(self, gerrit_change=None, **kwargs):
74 self._gerrit_change = gerrit_change
75
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000076 def GetIssue(self):
77 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000078
Edward Lemur6c6827c2020-02-06 21:15:18 +000079 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000080 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000081
dsansomee2d6fd92016-09-08 00:10:47 -070082 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000083 ChangelistMock.desc = desc
84
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000085 def GetGerritChange(self, patchset=None, **kwargs):
86 del patchset
87 return self._gerrit_change
88
tandrii5d48c322016-08-18 16:19:37 -070089
Edward Lemur85153282020-02-14 22:06:29 +000090class GitMocks(object):
91 def __init__(self, config=None, branchref=None):
92 self.branchref = branchref or 'refs/heads/master'
93 self.config = config or {}
94
95 def GetBranchRef(self, _root):
96 return self.branchref
97
98 def NewBranch(self, branchref):
99 self.branchref = branchref
100
Edward Lemur26964072020-02-19 19:18:51 +0000101 def GetConfig(self, root, key, default=None):
102 if root != '':
103 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000104 return self.config.get(key, default)
105
Edward Lemur26964072020-02-19 19:18:51 +0000106 def SetConfig(self, root, key, value=None):
107 if root != '':
108 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000109 if value:
110 self.config[key] = value
111 return
112 if key not in self.config:
113 raise CERR1
114 del self.config[key]
115
116
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000117class WatchlistsMock(object):
118 def __init__(self, _):
119 pass
120 @staticmethod
121 def GetWatchersForPaths(_):
122 return ['joe@example.com']
123
124
Edward Lemur4c707a22019-09-24 21:13:43 +0000125class CodereviewSettingsFileMock(object):
126 def __init__(self):
127 pass
128 # pylint: disable=no-self-use
129 def read(self):
130 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
131 'GERRIT_HOST: True\n')
132
133
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000134class AuthenticatorMock(object):
135 def __init__(self, *_args):
136 pass
137 def has_cached_credentials(self):
138 return True
tandrii221ab252016-10-06 08:12:04 -0700139 def authorize(self, http):
140 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000141
142
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100143def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000144 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
145
146 Usage:
147 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100148 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000149
150 OR
151 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100152 CookiesAuthenticatorMockFactory(
153 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000154 """
155 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800156 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000157 # Intentionally not calling super() because it reads actual cookie files.
158 pass
159 @classmethod
160 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000161 return os.path.join('~', '.gitcookies')
162
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000163 @classmethod
164 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000165 return os.path.join('~', NETRC_FILENAME)
166
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100167 def _get_auth_for_host(self, host):
168 if same_auth:
169 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000170 return (hosts_with_creds or {}).get(host)
171 return CookiesAuthenticatorMock
172
Aaron Gable9a03ae02017-11-03 11:31:07 -0700173
kmarshall9249e012016-08-23 12:02:16 -0700174class MockChangelistWithBranchAndIssue():
175 def __init__(self, branch, issue):
176 self.branch = branch
177 self.issue = issue
178 def GetBranch(self):
179 return self.branch
180 def GetIssue(self):
181 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000182
tandriic2405f52016-10-10 08:13:15 -0700183
184class SystemExitMock(Exception):
185 pass
186
187
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000188class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000189 def setUp(self):
190 mock.patch('sys.exit', side_effect=SystemExitMock).start()
191 mock.patch('sys.stdout', StringIO()).start()
192 mock.patch('sys.stderr', StringIO()).start()
193 self.addCleanup(mock.patch.stopall)
194
195 def test_die_with_error(self):
196 with self.assertRaises(SystemExitMock):
197 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
198 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
199 self.assertTrue('saving CL description' in sys.stdout.getvalue())
200 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
201 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
202 sys.exit.assert_called_once_with(1)
203
204 def test_die_with_error_no_desc(self):
205 with self.assertRaises(SystemExitMock):
206 git_cl.DieWithError('foo')
207 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
208 self.assertEqual(sys.stdout.getvalue(), '')
209 sys.exit.assert_called_once_with(1)
210
Edward Lemur6c6827c2020-02-06 21:15:18 +0000211 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000212 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100213 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000214 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700215
Edward Lemur61bf4172020-02-24 23:22:37 +0000216 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
217 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
218 def test_get_cl_statuses(self, *_mocks):
219 statuses = [
220 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
221 changes = []
222 for status in statuses:
223 cl = git_cl.Changelist()
224 cl.status = status
225 changes.append(cl)
226
227 actual = set(git_cl.get_cl_statuses(changes, True))
228 self.assertEqual(set(zip(changes, statuses)), actual)
229
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000230 def test_upload_to_non_default_branch_no_retry(self):
231 m = mock.patch('git_cl.Changelist._CMDUploadChange',
232 side_effect=[git_cl.GitPushError(), None]).start()
233 mock.patch('git_cl.Changelist.GetRemoteBranch',
234 return_value=('foo', 'bar')).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000235 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000236 return_value='foo').start()
237 mock.patch('git_cl.gerrit_util.GetProjectHead',
238 return_value='refs/heads/main').start()
239
240 cl = git_cl.Changelist()
241 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000242 options.target_branch = 'refs/heads/bar'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000243 with self.assertRaises(SystemExitMock):
244 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
245
246 # ensure upload is called once
247 self.assertEqual(len(m.mock_calls), 1)
248 sys.exit.assert_called_once_with(1)
249 # option not set as retry didn't happen
250 self.assertFalse(hasattr(options, 'force'))
251 self.assertFalse(hasattr(options, 'edit_description'))
252
253 def test_upload_to_old_default_still_active(self):
254 m = mock.patch('git_cl.Changelist._CMDUploadChange',
255 side_effect=[git_cl.GitPushError(), None]).start()
256 mock.patch('git_cl.Changelist.GetRemoteBranch',
257 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000258 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000259 return_value='foo').start()
260 mock.patch('git_cl.gerrit_util.GetProjectHead',
Josip Sokcevicb631a882021-01-06 18:18:10 +0000261 return_value='refs/heads/master').start()
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000262
263 cl = git_cl.Changelist()
264 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000265 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000266 with self.assertRaises(SystemExitMock):
267 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
268
269 # ensure upload is called once
270 self.assertEqual(len(m.mock_calls), 1)
271 sys.exit.assert_called_once_with(1)
272 # option not set as retry didn't happen
273 self.assertFalse(hasattr(options, 'force'))
274 self.assertFalse(hasattr(options, 'edit_description'))
275
276 def test_upload_to_old_default_retry_on_failure(self):
277 m = mock.patch('git_cl.Changelist._CMDUploadChange',
278 side_effect=[git_cl.GitPushError(), None]).start()
279 mock.patch('git_cl.Changelist.GetRemoteBranch',
280 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000281 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000282 return_value='foo').start()
283 mock.patch('git_cl.gerrit_util.GetProjectHead',
284 return_value='refs/heads/main').start()
285 mock.patch('git_cl.RunGit').start()
286
287 cl = git_cl.Changelist()
288 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000289 options.target_branch = 'refs/heads/master'
290 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
291 # ensure upload is called twice
292 self.assertEqual(len(m.mock_calls), 2)
293 # option overrides on retry
294 self.assertEqual(options.force, True)
295 self.assertEqual(options.edit_description, False)
296
297 def test_upload_to_old_default_retry_on_rollback(self):
298 """Test when default branch migration had to be rolled back to old name"""
299 m = mock.patch('git_cl.Changelist._CMDUploadChange',
300 side_effect=[git_cl.GitPushError(), None]).start()
301 mock.patch('git_cl.Changelist.GetRemoteBranch',
302 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
303 mock.patch('git_cl.Changelist.GetGerritProject',
304 return_value='foo').start()
305 mock.patch('git_cl.gerrit_util.GetProjectHead',
306 return_value='refs/heads/master').start()
307 # GetTargetRef returns new default branch since it has stale remote
308 # information.
309 mock.patch('git_cl.GetTargetRef',
310 return_value='refs/heads/main').start()
311 mock.patch('git_cl.RunGit').start()
312
313 cl = git_cl.Changelist()
314 options = optparse.Values()
315 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000316 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
317 # ensure upload is called twice
318 self.assertEqual(len(m.mock_calls), 2)
319 # option overrides on retry
320 self.assertEqual(options.force, True)
321 self.assertEqual(options.edit_description, False)
322
Edward Lemur61bf4172020-02-24 23:22:37 +0000323 def test_get_cl_statuses_no_changes(self):
324 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
325
326 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
327 @mock.patch('multiprocessing.pool.ThreadPool')
328 def test_get_cl_statuses_timeout(self, *_mocks):
329 changes = [git_cl.Changelist() for _ in range(2)]
330 pool = multiprocessing.pool.ThreadPool()
331 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
332 it.return_value.next.side_effect = [
333 (changes[0], 'lgtm'),
334 multiprocessing.TimeoutError,
335 ]
336
337 actual = list(git_cl.get_cl_statuses(changes, True))
338 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
339
340 @mock.patch('git_cl.Changelist.GetIssueURL')
341 def test_get_cl_statuses_not_finegrained(self, _mock):
342 changes = [git_cl.Changelist() for _ in range(2)]
343 urls = ['some-url', None]
344 git_cl.Changelist.GetIssueURL.side_effect = urls
345
346 actual = set(git_cl.get_cl_statuses(changes, False))
347 self.assertEqual(
348 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
349
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000350 def test_get_issue_url(self):
351 cl = git_cl.Changelist(issue=123)
352 cl._gerrit_server = 'https://example.com'
353 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
354 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
355
356 cl = git_cl.Changelist(issue=123)
357 cl._gerrit_server = 'https://chromium-review.googlesource.com'
358 self.assertEqual(cl.GetIssueURL(),
359 'https://chromium-review.googlesource.com/123')
360 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
361
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000362 def test_set_preserve_tryjobs(self):
363 d = git_cl.ChangeDescription('Simple.')
364 d.set_preserve_tryjobs()
365 self.assertEqual(d.description.splitlines(), [
366 'Simple.',
367 '',
368 'Cq-Do-Not-Cancel-Tryjobs: true',
369 ])
370 before = d.description
371 d.set_preserve_tryjobs()
372 self.assertEqual(before, d.description)
373
374 d = git_cl.ChangeDescription('\n'.join([
375 'One is enough',
376 '',
377 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
378 'Change-Id: Ideadbeef',
379 ]))
380 d.set_preserve_tryjobs()
381 self.assertEqual(d.description.splitlines(), [
382 'One is enough',
383 '',
384 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
385 'Change-Id: Ideadbeef',
386 'Cq-Do-Not-Cancel-Tryjobs: true',
387 ])
388
tandriif9aefb72016-07-01 09:06:51 -0700389 def test_get_bug_line_values(self):
390 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
391 self.assertEqual(f('', ''), [])
392 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
Lei Zhang8a0efc12020-08-05 19:58:45 +0000393 # Prefix that ends with colon.
394 self.assertEqual(f('v8:', '456'), ['v8:456'])
395 self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
396 # Prefix that ends without colon.
tandriif9aefb72016-07-01 09:06:51 -0700397 self.assertEqual(f('v8', '456'), ['v8:456'])
398 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
399 # Not nice, but not worth carying.
Lei Zhang8a0efc12020-08-05 19:58:45 +0000400 self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
401 ['v8:456', 'chromium:123', 'v8:123'])
tandriif9aefb72016-07-01 09:06:51 -0700402 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
403 ['v8:456', 'chromium:123', 'v8:123'])
404
Edward Lemurda4b6c62020-02-13 00:28:40 +0000405 @mock.patch('gerrit_util.GetAccountDetails')
406 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000407 mock_per_account = {
408 'u1': None, # 404, doesn't exist.
409 'u2': {
410 '_account_id': 123124,
411 'avatars': [],
412 'email': 'u2@example.com',
413 'name': 'User Number 2',
414 'status': 'OOO',
415 },
416 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
417 }
418 def GetAccountDetailsMock(_, account):
419 # Poor-man's mock library's side_effect.
420 v = mock_per_account.pop(account)
421 if isinstance(v, Exception):
422 raise v
423 return v
424
Edward Lemurda4b6c62020-02-13 00:28:40 +0000425 mockGetAccountDetails.side_effect = GetAccountDetailsMock
426 actual = git_cl.gerrit_util.ValidAccounts(
427 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000428 self.assertEqual(actual, {
429 'u2': {
430 '_account_id': 123124,
431 'avatars': [],
432 'email': 'u2@example.com',
433 'name': 'User Number 2',
434 'status': 'OOO',
435 },
436 })
437
438
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200439class TestParseIssueURL(unittest.TestCase):
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000440 def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
441 parsed = git_cl.ParseIssueNumberArgument(arg)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200442 self.assertIsNotNone(parsed)
443 if fail:
444 self.assertFalse(parsed.valid)
445 return
446 self.assertTrue(parsed.valid)
447 self.assertEqual(parsed.issue, issue)
448 self.assertEqual(parsed.patchset, patchset)
449 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200450
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000451 def test_basic(self):
452 self._test('123', 123)
453 self._test('', fail=True)
454 self._test('abc', fail=True)
455 self._test('123/1', fail=True)
456 self._test('123a', fail=True)
457 self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
458 self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200459
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000460 def test_gerrit_url(self):
461 self._test('https://codereview.source.com/123', 123, None,
462 'codereview.source.com')
463 self._test('http://chrome-review.source.com/c/123', 123, None,
464 'chrome-review.source.com')
465 self._test('https://chrome-review.source.com/c/123/', 123, None,
466 'chrome-review.source.com')
467 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
468 'chrome-review.source.com')
469 self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
470 'chrome-review.source.com')
471 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
472 'chrome-review.source.com')
473 self._test('https://chrome-review.source.com/123', 123, None,
474 'chrome-review.source.com')
475 self._test('https://chrome-review.source.com/123/4', 123, 4,
476 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200477
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000478 self._test('https://chrome-review.source.com/bad/123/4', fail=True)
479 self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
480 self._test('https://chrome-review.source.com/c/abc/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200481
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000482 def test_short_urls(self):
483 self._test('https://crrev.com/c/2151934', 2151934, None,
484 'chromium-review.googlesource.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200485
486
Edward Lemurda4b6c62020-02-13 00:28:40 +0000487class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100488 def setUp(self):
489 super(GitCookiesCheckerTest, self).setUp()
490 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100491 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000492 mock.patch('sys.stdout', StringIO()).start()
493 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100494
495 def mock_hosts_creds(self, subhost_identity_pairs):
496 def ensure_googlesource(h):
497 if not h.endswith(self.c._GOOGLESOURCE):
498 assert not h.endswith('.')
499 return h + '.' + self.c._GOOGLESOURCE
500 return h
501 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
502 for h, i in subhost_identity_pairs]
503
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200504 def test_identity_parsing(self):
505 self.assertEqual(self.c._parse_identity('ldap.google.com'),
506 ('ldap', 'google.com'))
507 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
508 ('ldap', 'example.com'))
509 # Specical case because we know there are no subdomains in chromium.org.
510 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
511 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800512 # Pathological: ".period." can be either username OR domain, more likely
513 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200514 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
515 ('note', 'period.example.com'))
516
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100517 def test_analysis_nothing(self):
518 self.c._all_hosts = []
519 self.assertFalse(self.c.has_generic_host())
520 self.assertEqual(set(), self.c.get_conflicting_hosts())
521 self.assertEqual(set(), self.c.get_duplicated_hosts())
522 self.assertEqual(set(), self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100523
524 def test_analysis(self):
525 self.mock_hosts_creds([
526 ('.googlesource.com', 'git-example.chromium.org'),
527
528 ('chromium', 'git-example.google.com'),
529 ('chromium-review', 'git-example.google.com'),
530 ('chrome-internal', 'git-example.chromium.org'),
531 ('chrome-internal-review', 'git-example.chromium.org'),
532 ('conflict', 'git-example.google.com'),
533 ('conflict-review', 'git-example.chromium.org'),
534 ('dup', 'git-example.google.com'),
535 ('dup', 'git-example.google.com'),
536 ('dup-review', 'git-example.google.com'),
537 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200538 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100539 ])
540 self.assertTrue(self.c.has_generic_host())
541 self.assertEqual(set(['conflict.googlesource.com']),
542 self.c.get_conflicting_hosts())
543 self.assertEqual(set(['dup.googlesource.com']),
544 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200545 self.assertEqual(set(['partial.googlesource.com',
546 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100547 self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100548
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100549 def test_report_no_problems(self):
550 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100551 self.assertFalse(self.c.find_and_report_problems())
552 self.assertEqual(sys.stdout.getvalue(), '')
553
Edward Lemurda4b6c62020-02-13 00:28:40 +0000554 @mock.patch(
555 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000556 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000557 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100558 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100559 self.assertTrue(self.c.find_and_report_problems())
560 with open(os.path.join(os.path.dirname(__file__),
561 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000562 expected = f.read() % {
563 'sep': os.sep,
564 }
565
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100566 def by_line(text):
567 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700568 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200569 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100570
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800571
Edward Lemurda4b6c62020-02-13 00:28:40 +0000572class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000573 def setUp(self):
574 super(TestGitCl, self).setUp()
575 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700576 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000577 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000578 mock.patch('sys.stdout', StringIO()).start()
579 mock.patch(
580 'git_cl.time_time',
581 lambda: self._mocked_call('time.time')).start()
582 mock.patch(
583 'git_cl.metrics.collector.add_repeated',
584 lambda *a: self._mocked_call('add_repeated', *a)).start()
585 mock.patch('subprocess2.call', self._mocked_call).start()
586 mock.patch('subprocess2.check_call', self._mocked_call).start()
587 mock.patch('subprocess2.check_output', self._mocked_call).start()
588 mock.patch(
589 'subprocess2.communicate',
590 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
591 mock.patch(
592 'git_cl.gclient_utils.CheckCallAndFilter',
593 self._mocked_call).start()
594 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
Stephen Martinis1c3c9392021-01-07 02:42:33 +0000595 mock.patch(
596 'git_common.get_or_create_merge_base',
597 lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000598 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
599 mock.patch(
600 'git_cl.SaveDescriptionBackup',
601 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
602 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000603 'git_cl.write_json',
604 lambda *a: self._mocked_call('write_json', *a)).start()
605 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000606 'git_cl.Changelist.RunHook',
607 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000608 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
609 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000610 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000611 mock.patch(
612 'git_cl.gerrit_util.GetChangeComments',
613 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
614 mock.patch(
615 'git_cl.gerrit_util.GetChangeRobotComments',
616 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
617 mock.patch(
618 'git_cl.gerrit_util.AddReviewers',
619 lambda *a: self._mocked_call('AddReviewers', *a)).start()
620 mock.patch(
621 'git_cl.gerrit_util.SetReview',
622 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
623 self._mocked_call(
624 'SetReview', h, i, msg, labels, notify, ready))).start()
625 mock.patch(
626 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
627 return_value=False).start()
628 mock.patch(
629 'git_cl.gerrit_util.GceAuthenticator.is_gce',
630 return_value=False).start()
631 mock.patch(
632 'git_cl.gerrit_util.ValidAccounts',
633 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000634 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000635 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000636 self.mockGit = GitMocks()
637 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
638 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
Edward Lesmes50da7702020-03-30 19:23:43 +0000639 mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
640 mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
Edward Lemur85153282020-02-14 22:06:29 +0000641 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000642 mock.patch(
643 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000644 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000645 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000646 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000647 mock.patch(
648 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000649 # It's important to reset settings to not have inter-tests interference.
650 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000651 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000652
653 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000654 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000655 if not self.failed:
656 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100657 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000658 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
659 if len(self.calls) > 5:
660 calls += ' ...\n'
661 self.fail(
662 '\n'
663 'There are un-consumed calls after this test has finished:\n' +
664 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000665 finally:
666 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000667
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000668 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000669 self.assertTrue(
670 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700671 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000672 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000673 expected_args, result = top
674
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000675 # Also logs otherwise it could get caught in a try/finally and be hard to
676 # diagnose.
677 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700678 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000679 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700680 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
681 for i, c in enumerate(self._calls_done[-N:]))
682 following_calls = '\n '.join(
683 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
684 for i, c in enumerate(self.calls[:N]))
685 extended_msg = (
686 'A few prior calls:\n %s\n\n'
687 'This (expected):\n @%d: %r\n'
688 'This (actual):\n @%d: %r\n\n'
689 'A few following expected calls:\n %s' %
690 (prior_calls, len(self._calls_done), expected_args,
691 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700692
Edward Lesmes0dd54822020-03-26 18:24:25 +0000693 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700694 self.fail('@%d\n'
695 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000696 ' Actual: %r\n'
697 '\n'
698 '%s' % (
699 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700700
701 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700702 if isinstance(result, Exception):
703 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000704 # stdout from git commands is supposed to be a bytestream. Convert it here
705 # instead of converting all test output in this file to bytes.
706 if args[0][0] == 'git' and not isinstance(result, bytes):
707 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000708 return result
709
Edward Lemur1a83da12020-03-04 21:18:36 +0000710 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
711 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100712 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100713 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000714 self.assertEqual(
715 'prompt [Yes/No]: Please, type yes or no: ',
716 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100717
tandrii48df5812016-10-17 03:55:37 -0700718 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000719 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700720 self.calls = [
721 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700722 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
723 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
724 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
725 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700726 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
727 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700728 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
729 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000730 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
731 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700732 ((['git', 'config', 'gerrit.host', 'true'],), ''),
733 ]
734 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
735
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000736 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100737 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200738 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000739 custom_cl_base=None, short_hostname='chromium',
Stephen Martinis1c3c9392021-01-07 02:42:33 +0000740 change_id=None, new_default=False):
Edward Lemur26964072020-02-19 19:18:51 +0000741 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200742 if custom_cl_base:
743 ancestor_revision = custom_cl_base
744 else:
745 # Determine ancestor_revision to be merge base.
Stephen Martinis1c3c9392021-01-07 02:42:33 +0000746 ancestor_revision = 'fake_ancestor_sha'
747 calls += [
748 (('get_or_create_merge_base', 'master',
749 'refs/remotes/origin/master'), ancestor_revision),
750 ]
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200751
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100752 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000753 gerrit_util.GetChangeDetail.return_value = {
754 'owner': {'email': (other_cl_owner or 'owner@example.com')},
755 'change_id': (change_id or '123456789'),
756 'current_revision': 'sha1_of_current_revision',
757 'revisions': {'sha1_of_current_revision': {
758 'commit': {'message': fetched_description},
759 }},
760 'status': fetched_status or 'NEW',
761 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100762 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100763 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100764 if other_cl_owner:
765 calls += [
766 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
767 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100768
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100769 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200770 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
771 ([custom_cl_base] if custom_cl_base else
772 [ancestor_revision, 'HEAD']),),
773 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100774 ]
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000775 calls += [
776 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
Stephen Martinis1c3c9392021-01-07 02:42:33 +0000777 '1' if new_default else callError(1)),
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000778 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000779
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100780 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000781
Edward Lemur26964072020-02-19 19:18:51 +0000782 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700783 squash_mode='default',
Aaron Gablefd238082017-06-07 13:42:34 -0700784 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100785 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000786 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000787 short_hostname='chromium',
Edward Lemur5a644f82020-03-18 16:44:57 +0000788 labels=None, change_id=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000789 final_description=None, gitcookies_exists=True,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000790 force=False, edit_description=None,
Stephen Martinis1c3c9392021-01-07 02:42:33 +0000791 new_default=False):
792 default_branch = 'main' if new_default else 'master';
tandrii@chromium.org10625002016-03-04 20:03:47 +0000793 if post_amend_description is None:
794 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700795 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200796
797 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000798
Edward Lesmes4de54132020-05-05 19:41:33 +0000799 if squash_mode in ('override_squash', 'override_nosquash'):
800 self.mockGit.config['gerrit.override-squash-uploads'] = (
801 'true' if squash_mode == 'override_squash' else 'false')
802
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000803 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000804 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200805 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200806 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000807 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000808 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000809 calls += [
810 ((['RunEditor'],), description),
811 ]
Josipe827b0f2020-01-30 00:07:20 +0000812 # user wants to edit description
813 if edit_description:
814 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000815 ((['RunEditor'],), edit_description),
816 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000817 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200818
819 if custom_cl_base is None:
Stephen Martinis1c3c9392021-01-07 02:42:33 +0000820 calls += [
821 (('get_or_create_merge_base', 'master',
822 'refs/remotes/origin/master'), 'origin/' + default_branch),
823 ]
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000824 parent = 'origin/' + default_branch
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200825 else:
826 calls += [
827 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000828 'refs/remotes/origin/' + default_branch],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200829 callError(1)), # Means not ancenstor.
830 (('ask_for_data',
831 'Do you take responsibility for cleaning up potential mess '
832 'resulting from proceeding with upload? Press Enter to upload, '
833 'or Ctrl+C to abort'), ''),
834 ]
835 parent = custom_cl_base
836
837 calls += [
838 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
839 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000840 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200841 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000842 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200843 ref_to_push),
844 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000845 else:
846 ref_to_push = 'HEAD'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000847 parent = 'origin/refs/heads/' + default_branch
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000848
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000849 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000850 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000851 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200852 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000853
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000854 metrics_arguments = []
855
Aaron Gableafd52772017-06-27 16:40:10 -0700856 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700857 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000858 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700859 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400860 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700861 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000862 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700863 else:
864 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000865 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800866
Edward Lemur5a644f82020-03-18 16:44:57 +0000867 # If issue is given, then description is fetched from Gerrit instead.
868 if issue is None:
869 if squash:
870 title = 'Initial upload'
871 else:
872 if not title:
873 calls += [
874 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
875 (('ask_for_data', 'Title for patchset []: '), 'User input'),
876 ]
877 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700878 if title:
Edward Lemur5a644f82020-03-18 16:44:57 +0000879 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000880 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000881
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000882 if short_hostname == 'chromium':
Quinten Yearsley925cedb2020-04-13 17:49:39 +0000883 # All reviewers and ccs get into ref_suffix.
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000884 for r in sorted(reviewers):
885 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000886 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000887 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000888 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000889 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000890 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000891 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000892 reviewers, cc = [], []
893 else:
894 # TODO(crbug/877717): remove this case.
895 calls += [
896 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
897 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000898 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000899 {
900 e: {'email': e}
901 for e in (reviewers + ['joe@example.com'] + cc)
902 })
903 ]
904 for r in sorted(reviewers):
905 if r != 'bad-account-or-email':
906 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000907 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000908 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000909 if issue is None:
910 cc += ['joe@example.com']
911 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000912 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000913 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000914 if c in cc:
915 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000916
Edward Lemur687ca902018-12-05 02:30:30 +0000917 for k, v in sorted((labels or {}).items()):
918 ref_suffix += ',l=%s+%d' % (k, v)
919 metrics_arguments.append('l=%s+%d' % (k, v))
920
921 if tbr:
922 calls += [
923 (('GetCodeReviewTbrScore',
924 '%s-review.googlesource.com' % short_hostname,
925 'my/repo'),
926 2,),
927 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000928
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000929 calls += [
930 (('time.time',), 1000,),
931 ((['git', 'push',
932 'https://%s.googlesource.com/my/repo' % short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000933 ref_to_push + ':refs/for/refs/heads/' + default_branch + ref_suffix],),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000934 (('remote:\n'
935 'remote: Processing changes: (\)\n'
936 'remote: Processing changes: (|)\n'
937 'remote: Processing changes: (/)\n'
938 'remote: Processing changes: (-)\n'
939 'remote: Processing changes: new: 1 (/)\n'
940 'remote: Processing changes: new: 1, done\n'
941 'remote:\n'
942 'remote: New Changes:\n'
943 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
944 ' XXX\n'
945 'remote:\n'
946 'To https://%s.googlesource.com/my/repo\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000947 ' * [new branch] hhhh -> refs/for/refs/heads/%s\n'
948 ) % (short_hostname, short_hostname, default_branch)),),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000949 (('time.time',), 2000,),
950 (('add_repeated',
951 'sub_commands',
952 {
953 'execution_time': 1000,
954 'command': 'git push',
955 'exit_code': 0,
956 'arguments': sorted(metrics_arguments),
957 }),
958 None,),
959 ]
960
Edward Lemur1b52d872019-05-09 21:12:12 +0000961 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000962
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000963 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
964
Edward Lemur1b52d872019-05-09 21:12:12 +0000965 # Trace-related calls
966 calls += [
967 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000968 (
969 ([
970 'FileWrite', trace_name + '-README',
971 '%(date)s\n'
972 '%(short_hostname)s-review.googlesource.com\n'
973 '%(change_id)s\n'
974 '%(title)s\n'
975 '%(description)s\n'
976 '1000\n'
977 '0\n'
978 '%(trace_name)s' % {
Josip Sokcevic5e18b602020-04-23 21:47:00 +0000979 'date': '2017-03-16T20:00:41.000000',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000980 'short_hostname': short_hostname,
981 'change_id': change_id,
982 'description': final_description,
983 'title': title or '<untitled>',
984 'trace_name': trace_name,
985 }
986 ], ),
987 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000988 ),
989 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000990 (
991 (['os.path.isfile',
992 os.path.join('TEMP_DIR', 'trace-packet')], ),
993 True,
Edward Lemur1b52d872019-05-09 21:12:12 +0000994 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000995 (
996 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
997 ('git-hash: 0123456789012345678901234567890123456789\n'
998 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +0000999 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001000 (
1001 ([
1002 'FileWrite',
1003 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
1004 'git-hash: abcdea\n'
1005 ], ),
1006 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001007 ),
1008 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001009 (
1010 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
1011 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001012 ),
1013 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001014 (
1015 (['git', 'config', '-l'], ),
1016 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +00001017 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001018 (
1019 ([
1020 'FileWrite',
1021 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
1022 ], ),
1023 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001024 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001025 (
1026 (['os.path.isfile',
1027 os.path.join('~', '.gitcookies')], ),
1028 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +00001029 ),
1030 ]
1031 if gitcookies_exists:
1032 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001033 (
1034 (['FileRead', os.path.join('~', '.gitcookies')], ),
1035 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +00001036 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001037 (
1038 ([
1039 'FileWrite',
1040 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
1041 ], ),
1042 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001043 ),
1044 ]
1045 calls += [
1046 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001047 (
1048 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
1049 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001050 ),
1051 ]
1052
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001053 # TODO(crbug/877717): this should never be used.
1054 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001055 calls += [
1056 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001057 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001058 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001059 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001060 notify),
1061 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001062 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001063 return calls
1064
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001065 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001066 self,
1067 upload_args,
1068 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001069 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001070 squash=True,
1071 squash_mode=None,
Aaron Gable9b713dd2016-12-14 16:04:21 -08001072 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001073 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001074 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001075 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001076 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001077 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001078 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001079 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001080 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001081 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001082 labels=None,
1083 change_id=None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001084 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001085 gitcookies_exists=True,
1086 force=False,
Edward Lesmes0dd54822020-03-26 18:24:25 +00001087 log_description=None,
Josipe827b0f2020-01-30 00:07:20 +00001088 edit_description=None,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001089 fetched_description=None,
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001090 new_default=False):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001091 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001092 if squash_mode is None:
1093 if '--no-squash' in upload_args:
1094 squash_mode = 'nosquash'
1095 elif '--squash' in upload_args:
1096 squash_mode = 'squash'
1097 else:
1098 squash_mode = 'default'
1099
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001100 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001101 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001102 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001103 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001104 same_auth=('git-owner.example.com', '', 'pass'))).start()
1105 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1106 lambda _, offer_removal: None).start()
1107 mock.patch('git_cl.gclient_utils.RunEditor',
1108 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1109 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001110 'DownloadGerritHook', force)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001111 mock.patch('git_cl.gclient_utils.FileRead',
1112 lambda path: self._mocked_call(['FileRead', path])).start()
1113 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001114 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001115 ['FileWrite', path, contents])).start()
1116 mock.patch('git_cl.datetime_now',
1117 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1118 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1119 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1120 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001121 '%(now)s\n'
1122 '%(gerrit_host)s\n'
1123 '%(change_id)s\n'
1124 '%(title)s\n'
1125 '%(description)s\n'
1126 '%(execution_time)s\n'
1127 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001128 '%(trace_name)s').start()
1129 mock.patch('git_cl.shutil.make_archive',
1130 lambda *args: self._mocked_call(['make_archive'] +
1131 list(args))).start()
1132 mock.patch('os.path.isfile',
1133 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001134 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001135 'git_cl._create_description_from_log',
1136 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001137 mock.patch(
1138 'git_cl.Changelist._AddChangeIdToCommitMessage',
1139 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001140 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001141 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1142 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001143 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001144 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001145
Edward Lemur26964072020-02-19 19:18:51 +00001146 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001147 self.mockGit.config['branch.master.gerritissue'] = (
1148 str(issue) if issue else None)
1149 self.mockGit.config['remote.origin.url'] = (
1150 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001151 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001152
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001153 self.calls = self._gerrit_base_calls(
1154 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001155 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001156 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001157 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001158 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001159 short_hostname=short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001160 change_id=change_id,
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001161 new_default=new_default)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001162 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001163 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001164 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001165 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001166 self.calls += self._gerrit_upload_calls(
1167 description, reviewers, squash,
1168 squash_mode=squash_mode,
Aaron Gablefd238082017-06-07 13:42:34 -07001169 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001170 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001171 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001172 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001173 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001174 labels=labels,
1175 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001176 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001177 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001178 force=force,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001179 edit_description=edit_description,
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001180 new_default=new_default)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001181 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001182 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001183 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001184 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001185 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001186 self.assertEqual(
1187 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001188 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001189
Edward Lemur1b52d872019-05-09 21:12:12 +00001190 def test_gerrit_upload_traces_no_gitcookies(self):
1191 self._run_gerrit_upload_test(
1192 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001193 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001194 [],
1195 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001196 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001197 change_id='Ixxx',
1198 gitcookies_exists=False)
1199
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001200 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001201 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001202 [],
1203 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1204 [],
1205 change_id='Ixxx')
1206
1207 def test_gerrit_upload_without_change_id_nosquash(self):
1208 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001209 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001210 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001211 [],
1212 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001213 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001214 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001215
Edward Lesmes4de54132020-05-05 19:41:33 +00001216 def test_gerrit_upload_without_change_id_override_nosquash(self):
1217 self._run_gerrit_upload_test(
1218 [],
1219 'desc ✔\n\nBUG=\n',
1220 [],
1221 squash=False,
1222 squash_mode='override_nosquash',
1223 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1224 change_id='Ixxx')
1225
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001226 def test_gerrit_no_reviewer(self):
1227 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001228 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001229 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001230 [],
1231 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001232 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001233 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001234
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001235 def test_gerrit_no_reviewer_non_chromium_host(self):
1236 # TODO(crbug/877717): remove this test case.
1237 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001238 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001239 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001240 [],
1241 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001242 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001243 short_hostname='other',
1244 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001245
Edward Lesmes0dd54822020-03-26 18:24:25 +00001246 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001247 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001248 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001249 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001250 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001251 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001252 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001253 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001254
ukai@chromium.orge8077812012-02-03 03:41:46 +00001255 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001256 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001257 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001258 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001259 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001260 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001261 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001262 notify=True,
1263 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001264 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001265 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001266
Anthony Polito8b955342019-09-24 19:01:36 +00001267 def test_gerrit_upload_force_sets_bug(self):
1268 self._run_gerrit_upload_test(
1269 ['-b', '10000', '-f'],
1270 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1271 [],
1272 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001273 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001274 change_id='Ixxx')
1275
Edward Lemur5fb22242020-03-12 22:05:13 +00001276 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001277 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001278 ['-b', '10000', '-m', 'Title', '--edit-description'],
1279 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001280 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001281 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001282 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001283 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001284 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001285 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001286
Dan Beamd8b04ca2019-10-10 21:23:26 +00001287 def test_gerrit_upload_force_sets_fixed(self):
1288 self._run_gerrit_upload_test(
1289 ['-x', '10000', '-f'],
1290 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1291 [],
1292 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001293 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001294 change_id='Ixxx')
1295
ukai@chromium.orge8077812012-02-03 03:41:46 +00001296 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001297 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1298 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001299 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001300 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001301 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001302 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001303 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001304 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001305 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001306 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001307 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001308 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001309
1310 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001311 self._run_gerrit_upload_test(
1312 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001313 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001314 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001315 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001316
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001317 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001318 self._run_gerrit_upload_test(
1319 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001320 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001321 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001322 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001323 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001324
Edward Lesmes0dd54822020-03-26 18:24:25 +00001325 def test_gerrit_upload_squash_first_title(self):
1326 self._run_gerrit_upload_test(
1327 ['-f', '-t', 'title'],
1328 'title\n\ndesc\n\nChange-Id: 123456789',
1329 [],
1330 force=True,
1331 squash=True,
1332 log_description='desc',
1333 change_id='123456789')
1334
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001335 def test_gerrit_upload_squash_first_with_labels(self):
1336 self._run_gerrit_upload_test(
1337 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001338 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001339 [],
1340 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001341 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001342 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001343
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001344 def test_gerrit_upload_squash_first_against_rev(self):
1345 custom_cl_base = 'custom_cl_base_rev_or_branch'
1346 self._run_gerrit_upload_test(
1347 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001348 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001349 [],
1350 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001351 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001352 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001353 self.assertIn(
1354 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1355 sys.stdout.getvalue())
1356
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001357 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001358 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001359 self._run_gerrit_upload_test(
1360 ['--squash'],
1361 description,
1362 [],
1363 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001364 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001365 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001366
Edward Lemurd55c5072020-02-20 01:09:07 +00001367 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001368 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001369 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001370 with self.assertRaises(SystemExitMock):
1371 self._run_gerrit_upload_test(
1372 ['--squash'],
1373 description,
1374 [],
1375 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001376 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001377 fetched_status='ABANDONED',
1378 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001379 self.assertEqual(
1380 'Change https://chromium-review.googlesource.com/123456 has been '
1381 'abandoned, new uploads are not allowed\n',
1382 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001383
Edward Lemurda4b6c62020-02-13 00:28:40 +00001384 @mock.patch(
1385 'gerrit_util.GetAccountDetails',
1386 return_value={'email': 'yet-another@example.com'})
1387 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001388 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001389 self._run_gerrit_upload_test(
1390 ['--squash'],
1391 description,
1392 [],
1393 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001394 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001395 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001396 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001397 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001398 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001399 'authenticate to Gerrit as yet-another@example.com.\n'
1400 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001401 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001402
Josipe827b0f2020-01-30 00:07:20 +00001403 def test_upload_change_description_editor(self):
1404 fetched_description = 'foo\n\nChange-Id: 123456789'
1405 description = 'bar\n\nChange-Id: 123456789'
1406 self._run_gerrit_upload_test(
1407 ['--squash', '--edit-description'],
1408 description,
1409 [],
1410 fetched_description=fetched_description,
1411 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001412 issue=123456,
1413 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001414 edit_description=description)
1415
Edward Lemurda4b6c62020-02-13 00:28:40 +00001416 @mock.patch('git_cl.RunGit')
1417 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001418 @mock.patch('sys.stdin', StringIO('\n'))
1419 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001420 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001421 def mock_run_git(*args, **_kwargs):
1422 if args[0] == ['for-each-ref',
1423 '--format=%(refname:short) %(upstream:short)',
1424 'refs/heads']:
1425 # Create a local branch dependency tree that looks like this:
1426 # test1 -> test2 -> test3 -> test4 -> test5
1427 # -> test3.1
1428 # test6 -> test0
1429 branch_deps = [
1430 'test2 test1', # test1 -> test2
1431 'test3 test2', # test2 -> test3
1432 'test3.1 test2', # test2 -> test3.1
1433 'test4 test3', # test3 -> test4
1434 'test5 test4', # test4 -> test5
1435 'test6 test0', # test0 -> test6
1436 'test7', # test7
1437 ]
1438 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001439 git_cl.RunGit.side_effect = mock_run_git
1440 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001441
1442 class MockChangelist():
1443 def __init__(self):
1444 pass
1445 def GetBranch(self):
1446 return 'test1'
1447 def GetIssue(self):
1448 return '123'
1449 def GetPatchset(self):
1450 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001451 def IsGerrit(self):
1452 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001453
1454 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1455 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001456 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001457 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001458 'This command will checkout all dependent branches '
1459 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001460 'or Ctrl+C to abort',
1461 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001462 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001463
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001464 def test_gerrit_change_id(self):
1465 self.calls = [
1466 ((['git', 'write-tree'], ),
1467 'hashtree'),
1468 ((['git', 'rev-parse', 'HEAD~0'], ),
1469 'branch-parent'),
1470 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1471 'A B <a@b.org> 1456848326 +0100'),
1472 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1473 'C D <c@d.org> 1456858326 +0100'),
1474 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1475 'hashchange'),
1476 ]
1477 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1478 self.assertEqual(change_id, 'Ihashchange')
1479
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001480 def test_desecription_append_footer(self):
1481 for init_desc, footer_line, expected_desc in [
1482 # Use unique desc first lines for easy test failure identification.
1483 ('foo', 'R=one', 'foo\n\nR=one'),
1484 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1485 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1486 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1487 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1488 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1489 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1490 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1491 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1492 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1493 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1494 ]:
1495 desc = git_cl.ChangeDescription(init_desc)
1496 desc.append_footer(footer_line)
1497 self.assertEqual(desc.description, expected_desc)
1498
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001499 def test_update_reviewers(self):
1500 data = [
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001501 ('foo', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001502 'foo'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001503 ('foo\nR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001504 'foo\nR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001505 ('foo\nTBR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001506 'foo\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001507 ('foo', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001508 'foo\n\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001509 ('foo\nR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001510 'foo\n\nR=a@c, xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001511 ('foo\nTBR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001512 'foo\n\nR=a@c\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001513 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001514 'foo\n\nR=a@c, yy\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001515 ('foo\nBUG=', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001516 'foo\nBUG=\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001517 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001518 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001519 ('foo', ['a@c', 'b@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001520 'foo\n\nR=a@c, b@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001521 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001522 'foo\nBar\n\nR=c@c\nBUG='),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001523 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001524 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001525 # Same as the line before, but full of whitespaces.
1526 (
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001527 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001528 'foo\nBar\n\nR=c@c\n BUG =',
1529 ),
1530 # Whitespaces aren't interpreted as new lines.
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001531 ('foo BUG=allo R=joe ', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001532 'foo BUG=allo R=joe\n\nR=c@c'),
1533 # Redundant TBRs get promoted to Rs
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001534 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001535 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001536 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001537 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001538 actual = []
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001539 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001540 obj = git_cl.ChangeDescription(orig)
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001541 obj.update_reviewers(reviewers, tbrs, None, None, None)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001542 actual.append(obj.description)
1543 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001544
Nodir Turakulov23b82142017-11-16 11:04:25 -08001545 def test_get_hash_tags(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001546 self.calls = [
1547 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
1548 callError(1)),
1549 ] * 9
Nodir Turakulov23b82142017-11-16 11:04:25 -08001550 cases = [
1551 ('', []),
1552 ('a', []),
1553 ('[a]', ['a']),
1554 ('[aa]', ['aa']),
1555 ('[a ]', ['a']),
1556 ('[a- ]', ['a']),
1557 ('[a- b]', ['a-b']),
1558 ('[a--b]', ['a-b']),
1559 ('[a', []),
1560 ('[a]x', ['a']),
1561 ('[aa]x', ['aa']),
1562 ('[a b]', ['a-b']),
1563 ('[a b]', ['a-b']),
1564 ('[a__b]', ['a-b']),
1565 ('[a] x', ['a']),
1566 ('[a][b]', ['a', 'b']),
1567 ('[a] [b]', ['a', 'b']),
1568 ('[a][b]x', ['a', 'b']),
1569 ('[a][b] x', ['a', 'b']),
1570 ('[a]\n[b]', ['a']),
1571 ('[a\nb]', []),
1572 ('[a][', ['a']),
1573 ('Revert "[a] feature"', ['a']),
1574 ('Reland "[a] feature"', ['a']),
1575 ('Revert: [a] feature', ['a']),
1576 ('Reland: [a] feature', ['a']),
1577 ('Revert "Reland: [a] feature"', ['a']),
1578 ('Foo: feature', ['foo']),
1579 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001580 ('Change Foo::Bar', []),
1581 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001582 ('Revert "Foo bar: feature"', ['foo-bar']),
1583 ('Reland "Foo bar: feature"', ['foo-bar']),
1584 ]
1585 for desc, expected in cases:
1586 change_desc = git_cl.ChangeDescription(desc)
1587 actual = change_desc.get_hash_tags()
1588 self.assertEqual(
1589 actual,
1590 expected,
1591 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1592
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001593 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001594 self.assertEqual(None, git_cl.GetTargetRef(None,
1595 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001596 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001597
wittman@chromium.org455dc922015-01-26 20:15:50 +00001598 # Check default target refs for branches.
1599 self.assertEqual('refs/heads/master',
1600 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001601 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001602 self.assertEqual('refs/heads/master',
1603 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001604 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001605 self.assertEqual('refs/heads/master',
1606 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001607 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001608 self.assertEqual('refs/branch-heads/123',
1609 git_cl.GetTargetRef('origin',
1610 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001611 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001612 self.assertEqual('refs/diff/test',
1613 git_cl.GetTargetRef('origin',
1614 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001615 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001616 self.assertEqual('refs/heads/chrome/m42',
1617 git_cl.GetTargetRef('origin',
1618 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001619 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001620
1621 # Check target refs for user-specified target branch.
1622 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1623 'refs/remotes/branch-heads/123'):
1624 self.assertEqual('refs/branch-heads/123',
1625 git_cl.GetTargetRef('origin',
1626 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001627 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001628 for branch in ('origin/master', 'remotes/origin/master',
1629 'refs/remotes/origin/master'):
1630 self.assertEqual('refs/heads/master',
1631 git_cl.GetTargetRef('origin',
1632 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001633 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001634 for branch in ('master', 'heads/master', 'refs/heads/master'):
1635 self.assertEqual('refs/heads/master',
1636 git_cl.GetTargetRef('origin',
1637 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001638 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001639
Edward Lemurda4b6c62020-02-13 00:28:40 +00001640 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1641 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001642 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001643 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1644
Edward Lemur85153282020-02-14 22:06:29 +00001645 def assertIssueAndPatchset(
1646 self, branch='master', issue='123456', patchset='7',
1647 git_short_host='chromium'):
1648 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001649 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001650 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001651 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001652 self.assertEqual(
1653 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001654 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001655
Edward Lemur85153282020-02-14 22:06:29 +00001656 def _patch_common(self, git_short_host='chromium'):
Edward Lesmes50da7702020-03-30 19:23:43 +00001657 mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
Edward Lemur26964072020-02-19 19:18:51 +00001658 self.mockGit.config['remote.origin.url'] = (
1659 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001660 gerrit_util.GetChangeDetail.return_value = {
1661 'current_revision': '7777777777',
1662 'revisions': {
1663 '1111111111': {
1664 '_number': 1,
1665 'fetch': {'http': {
1666 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1667 'ref': 'refs/changes/56/123456/1',
1668 }},
1669 },
1670 '7777777777': {
1671 '_number': 7,
1672 'fetch': {'http': {
1673 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1674 'ref': 'refs/changes/56/123456/7',
1675 }},
1676 },
1677 },
1678 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001679
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001680 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001681 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001682 self.calls += [
1683 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1684 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001685 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001686 ]
1687 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001688 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001689
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001690 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001691 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001692 self.calls += [
1693 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1694 'refs/changes/56/123456/7'],), ''),
1695 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001696 ]
Edward Lemur85153282020-02-14 22:06:29 +00001697 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1698 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001699
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001700 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001701 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001702 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001703 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001704 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001705 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001706 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001707 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001708 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001709
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001710 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001711 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001712 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001713 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001714 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001715 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001716 ]
1717 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001718 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001719 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001720
Aaron Gable697a91b2018-01-19 15:20:15 -08001721 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001722 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001723 self.calls += [
1724 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1725 'refs/changes/56/123456/1'],), ''),
1726 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001727 ]
1728 self.assertEqual(git_cl.main(
1729 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1730 0)
Edward Lemur85153282020-02-14 22:06:29 +00001731 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001732
Edward Lemurd55c5072020-02-20 01:09:07 +00001733 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001734 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001735 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001736 self.calls += [
1737 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001738 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001739 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001740 ]
1741 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001742 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001743 self.assertEqual(
1744 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1745 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001746
Edward Lemurda4b6c62020-02-13 00:28:40 +00001747 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001748 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001749 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001750 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001751 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001752 self.mockGit.config['remote.origin.url'] = (
1753 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001754 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001755 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001756 self.assertEqual(
1757 'change 123456 at https://chromium-review.googlesource.com does not '
1758 'exist or you have no access to it\n',
1759 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001760
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001761 def _checkout_calls(self):
1762 return [
1763 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001764 'branch\\..*\\.gerritissue'], ),
1765 ('branch.ger-branch.gerritissue 123456\n'
1766 'branch.gbranch654.gerritissue 654321\n')),
1767 ]
1768
1769 def test_checkout_gerrit(self):
1770 """Tests git cl checkout <issue>."""
1771 self.calls = self._checkout_calls()
1772 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1773 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1774
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001775 def test_checkout_not_found(self):
1776 """Tests git cl checkout <issue>."""
1777 self.calls = self._checkout_calls()
1778 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1779
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001780 def test_checkout_no_branch_issues(self):
1781 """Tests git cl checkout <issue>."""
1782 self.calls = [
1783 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001784 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001785 ]
1786 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1787
Edward Lemur26964072020-02-19 19:18:51 +00001788 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00001789 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001790 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001791 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001792 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1793 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001794 self.mockGit.config['remote.origin.url'] = (
1795 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001796 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001797 cl.branch = 'master'
1798 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001799 return cl
1800
Edward Lemurd55c5072020-02-20 01:09:07 +00001801 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001802 def test_gerrit_ensure_authenticated_missing(self):
1803 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001804 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001805 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001806 with self.assertRaises(SystemExitMock):
1807 cl.EnsureAuthenticated(force=False)
1808 self.assertEqual(
1809 'Credentials for the following hosts are required:\n'
1810 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001811 'These are read from ~%(sep)s.gitcookies '
1812 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00001813 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001814 'https://chromium-review.googlesource.com/new-password\n' % {
1815 'sep': os.sep,
1816 'netrc': NETRC_FILENAME,
1817 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001818
1819 def test_gerrit_ensure_authenticated_conflict(self):
1820 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001821 'chromium.googlesource.com':
1822 ('git-one.example.com', None, 'secret1'),
1823 'chromium-review.googlesource.com':
1824 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001825 })
1826 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001827 (('ask_for_data', 'If you know what you are doing '
1828 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001829 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1830
1831 def test_gerrit_ensure_authenticated_ok(self):
1832 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001833 'chromium.googlesource.com':
1834 ('git-same.example.com', None, 'secret'),
1835 'chromium-review.googlesource.com':
1836 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001837 })
1838 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1839
tandrii@chromium.org28253532016-04-14 13:46:56 +00001840 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00001841 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
1842 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00001843 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1844
Eric Boren2fb63102018-10-05 13:05:03 +00001845 def test_gerrit_ensure_authenticated_bearer_token(self):
1846 cl = self._test_gerrit_ensure_authenticated_common(auth={
1847 'chromium.googlesource.com':
1848 ('', None, 'secret'),
1849 'chromium-review.googlesource.com':
1850 ('', None, 'secret'),
1851 })
1852 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1853 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1854 'chromium.googlesource.com')
1855 self.assertTrue('Bearer' in header)
1856
Daniel Chengcf6269b2019-05-18 01:02:12 +00001857 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00001858 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00001859 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001860 (('logging.warning',
1861 'Ignoring branch %(branch)s with non-https remote '
1862 '%(remote)s', {
1863 'branch': 'master',
1864 'remote': 'custom-scheme://repo'}
1865 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001866 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001867 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1868 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1869 mock.patch('logging.warning',
1870 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00001871 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00001872 cl.branch = 'master'
1873 cl.branchref = 'refs/heads/master'
1874 cl.lookedup_issue = True
1875 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1876
Florian Mayerae510e82020-01-30 21:04:48 +00001877 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00001878 self.mockGit.config['remote.origin.url'] = (
1879 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00001880 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001881 (('logging.error',
1882 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1883 'but it doesn\'t exist.', {
1884 'remote': 'origin',
1885 'branch': 'master',
1886 'url': 'git@somehost.example:foo/bar.git'}
1887 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00001888 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001889 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1890 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1891 mock.patch('logging.error',
1892 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00001893 cl = git_cl.Changelist()
1894 cl.branch = 'master'
1895 cl.branchref = 'refs/heads/master'
1896 cl.lookedup_issue = True
1897 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1898
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001899 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00001900 self.mockGit.config['branch.master.gerritissue'] = '123'
1901 self.mockGit.config['branch.master.gerritserver'] = (
1902 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00001903 self.mockGit.config['remote.origin.url'] = (
1904 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001905 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00001906 (('SetReview', 'chromium-review.googlesource.com',
1907 'infra%2Finfra~123', None,
1908 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001909 ]
tandriid9e5ce52016-07-13 02:32:59 -07001910
1911 def test_cmd_set_commit_gerrit_clear(self):
1912 self._cmd_set_commit_gerrit_common(0)
1913 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1914
1915 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001916 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001917 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1918
tandriid9e5ce52016-07-13 02:32:59 -07001919 def test_cmd_set_commit_gerrit(self):
1920 self._cmd_set_commit_gerrit_common(2)
1921 self.assertEqual(0, git_cl.main(['set-commit']))
1922
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001923 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001924 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001925 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001926
1927 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001928 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001929
Edward Lemurda4b6c62020-02-13 00:28:40 +00001930 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07001931 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07001932 try:
1933 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00001934 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001935 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001936 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07001937
1938 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07001939 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001940 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07001941 return 'foobar'
1942
Edward Lemurda4b6c62020-02-13 00:28:40 +00001943 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07001944 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001945 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001946 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001947 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07001948
iannuccie53c9352016-08-17 14:40:40 -07001949 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001950
iannuccie53c9352016-08-17 14:40:40 -07001951 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001952 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07001953 return 'foobar'
1954
Edward Lemurda4b6c62020-02-13 00:28:40 +00001955 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
1956 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07001957 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001958 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001959
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001960 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00001961 self.mockGit.config['remote.origin.url'] = (
1962 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001963 gerrit_util.GetChangeDetail.return_value = {
1964 'current_revision': 'sha1',
1965 'revisions': {'sha1': {
1966 'commit': {'message': 'foobar'},
1967 }},
1968 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001969 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001970 'description',
1971 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
1972 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001973 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001974
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001975 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001976 mock.patch('git_cl.Changelist', ChangelistMock).start()
1977 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001978
1979 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
1980 self.assertEqual('hihi', ChangelistMock.desc)
1981
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001982 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001983 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001984
1985 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001986 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001987 '# Enter a description of the change.\n'
1988 '# This will be displayed on the codereview site.\n'
1989 '# The first line will also be used as the subject of the review.\n'
1990 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001991 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07001992 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001993 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001994 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07001995 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001996
Edward Lemur6c6827c2020-02-06 21:15:18 +00001997 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001998 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001999
Edward Lemurda4b6c62020-02-13 00:28:40 +00002000 mock.patch('git_cl.Changelist.FetchDescription',
2001 lambda *args: current_desc).start()
2002 mock.patch('git_cl.Changelist.UpdateDescription',
2003 UpdateDescription).start()
2004 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002005
Edward Lemur85153282020-02-14 22:06:29 +00002006 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002007 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002008
Dan Beamd8b04ca2019-10-10 21:23:26 +00002009 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2010 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2011
2012 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002013 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002014 '# Enter a description of the change.\n'
2015 '# This will be displayed on the codereview site.\n'
2016 '# The first line will also be used as the subject of the review.\n'
2017 '#--------------------This line is 72 characters long'
2018 '--------------------\n'
2019 'Some.\n\nFixed: 123\nChange-Id: xxx',
2020 desc)
2021 return desc
2022
Edward Lemurda4b6c62020-02-13 00:28:40 +00002023 mock.patch('git_cl.Changelist.FetchDescription',
2024 lambda *args: current_desc).start()
2025 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002026
Edward Lemur85153282020-02-14 22:06:29 +00002027 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002028 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002029
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002030 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002031 mock.patch('git_cl.Changelist', ChangelistMock).start()
2032 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002033
2034 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2035 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2036
kmarshall3bff56b2016-06-06 18:31:47 -07002037 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002038 self.calls = [
2039 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002040 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002041 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002042 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002043 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002044 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002045
Edward Lemurda4b6c62020-02-13 00:28:40 +00002046 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002047 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002048 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2049 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002050 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002051
2052 self.assertEqual(0, git_cl.main(['archive', '-f']))
2053
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002054 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002055 self.calls = [
2056 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2057 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2058 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2059 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002060 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2061 ((['git', 'branch', '-D', 'foo'],), '')
2062 ]
2063
Edward Lemurda4b6c62020-02-13 00:28:40 +00002064 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002065 lambda branches, fine_grained, max_processes:
2066 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2067 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002068 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002069
2070 self.assertEqual(0, git_cl.main(['archive', '-f']))
2071
kmarshall3bff56b2016-06-06 18:31:47 -07002072 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002073 self.calls = [
2074 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2075 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002076 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002077 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002078
Edward Lemurda4b6c62020-02-13 00:28:40 +00002079 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002080 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002081 [(MockChangelistWithBranchAndIssue('master', 1),
2082 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002083
2084 self.assertEqual(1, git_cl.main(['archive', '-f']))
2085
2086 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002087 self.calls = [
2088 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2089 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002090 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002091 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002092
Edward Lemurda4b6c62020-02-13 00:28:40 +00002093 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002094 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002095 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2096 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002097 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002098
kmarshall9249e012016-08-23 12:02:16 -07002099 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2100
2101 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002102 self.calls = [
2103 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2104 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002105 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002106 ((['git', 'branch', '-D', 'foo'],), '')
2107 ]
kmarshall9249e012016-08-23 12:02:16 -07002108
Edward Lemurda4b6c62020-02-13 00:28:40 +00002109 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002110 lambda branches, fine_grained, max_processes:
2111 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2112 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002113 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002114
2115 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002116
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002117 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002118 self.calls = [
2119 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2120 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2121 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002122 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2123 'refs/tags/git-cl-archived-456-foo'),
2124 ((['git', 'branch', '-D', 'foo'],), CERR1),
2125 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2126 'refs/tags/git-cl-archived-456-foo'),
2127 ]
2128
Edward Lemurda4b6c62020-02-13 00:28:40 +00002129 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002130 lambda branches, fine_grained, max_processes:
2131 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2132 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002133 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002134
2135 self.assertEqual(0, git_cl.main(['archive', '-f']))
2136
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002137 def test_archive_with_format(self):
2138 self.calls = [
2139 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
2140 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2141 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2142 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2143 ((['git', 'branch', '-D', 'foo'], ), ''),
2144 ]
2145
2146 mock.patch('git_cl.get_cl_statuses',
2147 lambda branches, fine_grained, max_processes:
2148 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2149
2150 self.assertEqual(
2151 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2152
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002153 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002154 self.mockGit.config['branch.master.gerritissue'] = '123'
2155 self.mockGit.config['branch.master.gerritserver'] = (
2156 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002157 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002158 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002159 ]
2160 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002161 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2162 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002163
Aaron Gable400e9892017-07-12 15:31:21 -07002164 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002165 self.mockGit.config['branch.master.gerritissue'] = '123'
2166 self.mockGit.config['branch.master.gerritserver'] = (
2167 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002168 mock.patch('git_cl.Changelist.FetchDescription',
2169 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002170 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002171 ((['git', 'log', '-1', '--format=%B'],),
2172 'This is a description\n\nChange-Id: Ideadbeef'),
2173 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002174 ]
2175 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002176 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2177 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002178
phajdan.jre328cf92016-08-22 04:12:17 -07002179 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002180 self.mockGit.config['branch.master.gerritissue'] = '123'
2181 self.mockGit.config['branch.master.gerritserver'] = (
2182 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002183 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002184 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002185 {'issue': 123,
2186 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002187 ''),
2188 ]
2189 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2190
tandrii16e0b4e2016-06-07 10:34:28 -07002191 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002192 mock.patch(
2193 'git_cl.os.path.abspath',
2194 lambda path: self._mocked_call(['abspath', path])).start()
2195 mock.patch(
2196 'git_cl.os.path.exists',
2197 lambda path: self._mocked_call(['exists', path])).start()
2198 mock.patch(
2199 'git_cl.gclient_utils.FileRead',
2200 lambda path: self._mocked_call(['FileRead', path])).start()
2201 mock.patch(
2202 'git_cl.gclient_utils.rm_file_or_tree',
2203 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002204 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002205 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002206 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002207 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002208
2209 def test_GerritCommitMsgHookCheck_custom_hook(self):
2210 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002211 self.calls += [((['exists',
2212 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2213 ((['FileRead',
2214 os.path.join('.git', 'hooks', 'commit-msg')], ),
2215 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002216 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002217
2218 def test_GerritCommitMsgHookCheck_not_exists(self):
2219 cl = self._common_GerritCommitMsgHookCheck()
2220 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002221 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002222 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002223 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002224
2225 def test_GerritCommitMsgHookCheck(self):
2226 cl = self._common_GerritCommitMsgHookCheck()
2227 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002228 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2229 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002230 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002231 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002232 ((['rm_file_or_tree',
2233 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002234 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002235 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002236
tandriic4344b52016-08-29 06:04:54 -07002237 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002238 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2239 self.mockGit.config['branch.master.gerritserver'] = (
2240 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002241 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002242 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002243 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002244 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002245 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002246 'labels': {},
2247 'current_revision': 'deadbeaf',
2248 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002249 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002250 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002251 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002252 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2253 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002254 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002255 self.assertEqual(0, cl.CMDLand(force=True,
2256 bypass_hooks=True,
2257 verbose=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002258 parallel=False,
2259 resultdb=False,
2260 realm=None))
Edward Lemur73c76702020-02-06 23:57:18 +00002261 self.assertIn(
2262 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002263 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002264 self.assertIn(
2265 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002266 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002267
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002268 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002269 mock.patch('git_cl.Changelist.GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002270
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002271 def test_gerrit_change_detail_cache_simple(self):
2272 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002273 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002274 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002275 cl1._cached_remote_url = (
2276 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002277 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002278 cl2._cached_remote_url = (
2279 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002280 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2281 self.assertEqual(cl1._GetChangeDetail(), 'a')
2282 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002283
2284 def test_gerrit_change_detail_cache_options(self):
2285 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002286 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002287 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002288 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002289 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2290 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2291 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2292 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2293 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2294 self.assertEqual(cl._GetChangeDetail(), 'cab')
2295
2296 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2297 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2298 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2299 self.assertEqual(cl._GetChangeDetail(), 'cab')
2300
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002301 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002302 gerrit_util.GetChangeDetail.return_value = {
2303 'current_revision': 'rev1',
2304 'revisions': {
2305 'rev1': {'commit': {'message': 'desc1'}},
2306 },
2307 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002308
2309 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002310 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002311 cl._cached_remote_url = (
2312 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002313 self.assertEqual(cl.FetchDescription(), 'desc1')
2314 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002315
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002316 def test_print_current_creds(self):
2317 class CookiesAuthenticatorMock(object):
2318 def __init__(self):
2319 self.gitcookies = {
2320 'host.googlesource.com': ('user', 'pass'),
2321 'host-review.googlesource.com': ('user', 'pass'),
2322 }
2323 self.netrc = self
2324 self.netrc.hosts = {
2325 'github.com': ('user2', None, 'pass2'),
2326 'host2.googlesource.com': ('user3', None, 'pass'),
2327 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002328 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2329 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002330 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2331 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2332 ' Host\t User\t Which file',
2333 '============================\t=====\t===========',
2334 'host-review.googlesource.com\t user\t.gitcookies',
2335 ' host.googlesource.com\t user\t.gitcookies',
2336 ' host2.googlesource.com\tuser3\t .netrc',
2337 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002338 sys.stdout.seek(0)
2339 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002340 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2341 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2342 ' Host\tUser\t Which file',
2343 '============================\t====\t===========',
2344 'host-review.googlesource.com\tuser\t.gitcookies',
2345 ' host.googlesource.com\tuser\t.gitcookies',
2346 ])
2347
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002348 def _common_creds_check_mocks(self):
2349 def exists_mock(path):
2350 dirname = os.path.dirname(path)
2351 if dirname == os.path.expanduser('~'):
2352 dirname = '~'
2353 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002354 if base in (NETRC_FILENAME, '.gitcookies'):
2355 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002356 # git cl also checks for existence other files not relevant to this test.
2357 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002358 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002359 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002360 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002361 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002362
2363 def test_creds_check_gitcookies_not_configured(self):
2364 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002365 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2366 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002367 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002368 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2369 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2370 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2371 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2372 'or Ctrl+C to abort'), ''),
2373 (([
2374 'git', 'config', '--global', 'http.cookiefile',
2375 os.path.expanduser(os.path.join('~', '.gitcookies'))
2376 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002377 ]
2378 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002379 self.assertTrue(
2380 sys.stdout.getvalue().startswith(
2381 'You seem to be using outdated .netrc for git credentials:'))
2382 self.assertIn(
2383 '\nConfigured git to use .gitcookies from',
2384 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002385
2386 def test_creds_check_gitcookies_configured_custom_broken(self):
2387 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002388 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2389 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002390 custom_cookie_path = ('C:\\.gitcookies'
2391 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002392 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002393 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2394 ((['git', 'config', '--global', 'http.cookiefile'], ),
2395 custom_cookie_path),
2396 (('os.path.exists', custom_cookie_path), False),
2397 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2398 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2399 (([
2400 'git', 'config', '--global', 'http.cookiefile',
2401 os.path.expanduser(os.path.join('~', '.gitcookies'))
2402 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002403 ]
2404 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002405 self.assertIn(
2406 'WARNING: You have configured custom path to .gitcookies: ',
2407 sys.stdout.getvalue())
2408 self.assertIn(
2409 'However, your configured .gitcookies file is missing.',
2410 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002411
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002412 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002413 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002414 self.mockGit.config['remote.origin.url'] = (
2415 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002416 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002417 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002418 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002419 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002420 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002421 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002422
Edward Lemurda4b6c62020-02-13 00:28:40 +00002423 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2424 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002425 self.mockGit.config['remote.origin.url'] = (
2426 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002427 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002428 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002429 'current_revision': 'ba5eba11',
2430 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002431 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002432 '_number': 1,
2433 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002434 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002435 '_number': 2,
2436 },
2437 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002438 'messages': [
2439 {
2440 u'_revision_number': 1,
2441 u'author': {
2442 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002443 u'email': u'could-be-anything@example.com',
2444 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002445 },
2446 u'date': u'2017-03-15 20:08:45.000000000',
2447 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002448 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002449 u'tag': u'autogenerated:cq:dry-run'
2450 },
2451 {
2452 u'_revision_number': 2,
2453 u'author': {
2454 u'_account_id': 11151243,
2455 u'email': u'owner@example.com',
2456 u'name': u'owner'
2457 },
2458 u'date': u'2017-03-16 20:00:41.000000000',
2459 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2460 u'message': u'PTAL',
2461 },
2462 {
2463 u'_revision_number': 2,
2464 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002465 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002466 u'email': u'reviewer@example.com',
2467 u'name': u'reviewer'
2468 },
2469 u'date': u'2017-03-17 05:19:37.500000000',
2470 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2471 u'message': u'Patch Set 2: Code-Review+1',
2472 },
2473 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002474 }
2475 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002476 (('GetChangeComments', 'chromium-review.googlesource.com',
2477 'infra%2Finfra~1'), {
2478 '/COMMIT_MSG': [
2479 {
2480 'author': {
2481 'email': u'reviewer@example.com'
2482 },
2483 'updated': u'2017-03-17 05:19:37.500000000',
2484 'patch_set': 2,
2485 'side': 'REVISION',
2486 'message': 'Please include a bug link',
2487 },
2488 ],
2489 'codereview.settings': [
2490 {
2491 'author': {
2492 'email': u'owner@example.com'
2493 },
2494 'updated': u'2017-03-16 20:00:41.000000000',
2495 'patch_set': 2,
2496 'side': 'PARENT',
2497 'line': 42,
2498 'message': 'I removed this because it is bad',
2499 },
2500 ]
2501 }),
2502 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2503 'infra%2Finfra~1'), {}),
2504 ] * 2 + [(('write_json', 'output.json', [{
2505 u'date':
2506 u'2017-03-16 20:00:41.000000',
2507 u'message': (u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2508 u' Base, Line 42: https://crrev.com/c/1/2/'
2509 u'codereview.settings#b42\n' +
2510 u' I removed this because it is bad\n'),
2511 u'autogenerated':
2512 False,
2513 u'approval':
2514 False,
2515 u'disapproval':
2516 False,
2517 u'sender':
2518 u'owner@example.com'
2519 }, {
2520 u'date':
2521 u'2017-03-17 05:19:37.500000',
2522 u'message':
2523 (u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2524 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
2525 u' Please include a bug link\n'),
2526 u'autogenerated':
2527 False,
2528 u'approval':
2529 False,
2530 u'disapproval':
2531 False,
2532 u'sender':
2533 u'reviewer@example.com'
2534 }]), '')]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002535 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002536 git_cl._CommentSummary(
2537 message=(u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2538 u' Base, Line 42: https://crrev.com/c/1/2/' +
2539 u'codereview.settings#b42\n' +
2540 u' I removed this because it is bad\n'),
2541 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2542 autogenerated=False,
2543 disapproval=False,
2544 approval=False,
2545 sender=u'owner@example.com'),
2546 git_cl._CommentSummary(message=(
2547 u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2548 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002549 u' Please include a bug link\n'),
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002550 date=datetime.datetime(2017, 3, 17, 5, 19, 37,
2551 500000),
2552 autogenerated=False,
2553 disapproval=False,
2554 approval=False,
2555 sender=u'reviewer@example.com'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002556 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002557 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002558 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002559 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002560 self.assertEqual(
2561 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2562
2563 def test_git_cl_comments_robot_comments(self):
2564 # git cl comments also fetches robot comments (which are considered a type
2565 # of autogenerated comment), and unlike other types of comments, only robot
2566 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002567 self.mockGit.config['remote.origin.url'] = (
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002568 'https://x.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002569 gerrit_util.GetChangeDetail.return_value = {
2570 'owner': {'email': 'owner@example.com'},
2571 'current_revision': 'ba5eba11',
2572 'revisions': {
2573 'deadbeaf': {
2574 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002575 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002576 'ba5eba11': {
2577 '_number': 2,
2578 },
2579 },
2580 'messages': [
2581 {
2582 u'_revision_number': 1,
2583 u'author': {
2584 u'_account_id': 1111084,
2585 u'email': u'commit-bot@chromium.org',
2586 u'name': u'Commit Bot'
2587 },
2588 u'date': u'2017-03-15 20:08:45.000000000',
2589 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2590 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2591 u'tag': u'autogenerated:cq:dry-run'
2592 },
2593 {
2594 u'_revision_number': 1,
2595 u'author': {
2596 u'_account_id': 123,
2597 u'email': u'tricium@serviceaccount.com',
2598 u'name': u'Tricium'
2599 },
2600 u'date': u'2017-03-16 20:00:41.000000000',
2601 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2602 u'message': u'(1 comment)',
2603 u'tag': u'autogenerated:tricium',
2604 },
2605 {
2606 u'_revision_number': 1,
2607 u'author': {
2608 u'_account_id': 123,
2609 u'email': u'tricium@serviceaccount.com',
2610 u'name': u'Tricium'
2611 },
2612 u'date': u'2017-03-16 20:00:41.000000000',
2613 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2614 u'message': u'(1 comment)',
2615 u'tag': u'autogenerated:tricium',
2616 },
2617 {
2618 u'_revision_number': 2,
2619 u'author': {
2620 u'_account_id': 123,
2621 u'email': u'tricium@serviceaccount.com',
2622 u'name': u'reviewer'
2623 },
2624 u'date': u'2017-03-17 05:30:37.000000000',
2625 u'tag': u'autogenerated:tricium',
2626 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2627 u'message': u'(1 comment)',
2628 },
2629 ]
2630 }
2631 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002632 (('GetChangeComments', 'x-review.googlesource.com', 'infra%2Finfra~1'),
2633 {}),
2634 (('GetChangeRobotComments', 'x-review.googlesource.com',
2635 'infra%2Finfra~1'), {
2636 'codereview.settings': [
2637 {
2638 u'author': {
2639 u'email': u'tricium@serviceaccount.com'
2640 },
2641 u'updated': u'2017-03-17 05:30:37.000000000',
2642 u'robot_run_id': u'5565031076855808',
2643 u'robot_id': u'Linter/Category',
2644 u'tag': u'autogenerated:tricium',
2645 u'patch_set': 2,
2646 u'side': u'REVISION',
2647 u'message': u'Linter warning message text',
2648 u'line': 32,
2649 },
2650 ],
2651 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002652 ]
2653 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002654 git_cl._CommentSummary(
2655 date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2656 message=(u'(1 comment)\n\ncodereview.settings\n'
2657 u' PS2, Line 32: https://x-review.googlesource.com/c/1/2/'
2658 u'codereview.settings#32\n'
2659 u' Linter warning message text\n'),
2660 sender=u'tricium@serviceaccount.com',
2661 autogenerated=True,
2662 approval=False,
2663 disapproval=False)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002664 ]
2665 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002666 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002667 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002668
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002669 def test_get_remote_url_with_mirror(self):
2670 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002671
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002672 def selective_os_path_isdir_mock(path):
2673 if path == '/cache/this-dir-exists':
2674 return self._mocked_call('os.path.isdir', path)
2675 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002676
Edward Lemurda4b6c62020-02-13 00:28:40 +00002677 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002678
2679 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002680 self.mockGit.config['remote.origin.url'] = (
2681 '/cache/this-dir-exists')
2682 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2683 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002684 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002685 (('os.path.isdir', '/cache/this-dir-exists'),
2686 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002687 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002688 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002689 self.assertEqual(cl.GetRemoteUrl(), url)
2690 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2691
Edward Lemur298f2cf2019-02-22 21:40:39 +00002692 def test_get_remote_url_non_existing_mirror(self):
2693 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002694
Edward Lemur298f2cf2019-02-22 21:40:39 +00002695 def selective_os_path_isdir_mock(path):
2696 if path == '/cache/this-dir-doesnt-exist':
2697 return self._mocked_call('os.path.isdir', path)
2698 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002699
Edward Lemurda4b6c62020-02-13 00:28:40 +00002700 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2701 mock.patch('logging.error',
2702 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002703
Edward Lemur26964072020-02-19 19:18:51 +00002704 self.mockGit.config['remote.origin.url'] = (
2705 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002706 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002707 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2708 False),
2709 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002710 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2711 'but it doesn\'t exist.', {
2712 'remote': 'origin',
2713 'branch': 'master',
2714 'url': '/cache/this-dir-doesnt-exist'}
2715 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002716 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002717 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002718 self.assertIsNone(cl.GetRemoteUrl())
2719
2720 def test_get_remote_url_misconfigured_mirror(self):
2721 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002722
Edward Lemur298f2cf2019-02-22 21:40:39 +00002723 def selective_os_path_isdir_mock(path):
2724 if path == '/cache/this-dir-exists':
2725 return self._mocked_call('os.path.isdir', path)
2726 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002727
Edward Lemurda4b6c62020-02-13 00:28:40 +00002728 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2729 mock.patch('logging.error',
2730 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002731
Edward Lemur26964072020-02-19 19:18:51 +00002732 self.mockGit.config['remote.origin.url'] = (
2733 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002734 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002735 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002736 (('logging.error',
2737 'Remote "%(remote)s" for branch "%(branch)s" points to '
2738 '"%(cache_path)s", but it is misconfigured.\n'
2739 '"%(cache_path)s" must be a git repo and must have a remote named '
2740 '"%(remote)s" pointing to the git host.', {
2741 'remote': 'origin',
2742 'cache_path': '/cache/this-dir-exists',
2743 'branch': 'master'}
2744 ), None),
2745 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002746 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002747 self.assertIsNone(cl.GetRemoteUrl())
2748
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002749 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002750 self.mockGit.config['remote.origin.url'] = (
2751 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002752 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002753 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2754
2755 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002756 mock.patch('logging.error',
2757 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002758
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002759 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002760 (('logging.error',
2761 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2762 'but it doesn\'t exist.', {
2763 'remote': 'origin',
2764 'branch': 'master',
2765 'url': ''}
2766 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002767 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002768 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002769 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002770
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002771 def test_gerrit_new_default(self):
2772 self._run_gerrit_upload_test(
2773 [],
2774 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
2775 [],
2776 squash=False,
2777 squash_mode='override_nosquash',
2778 change_id='I123456789',
Stephen Martinis1c3c9392021-01-07 02:42:33 +00002779 new_default=True)
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002780
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002781
Edward Lemur9aa1a962020-02-25 00:58:38 +00002782class ChangelistTest(unittest.TestCase):
Edward Lemur227d5102020-02-25 23:45:35 +00002783 def setUp(self):
2784 super(ChangelistTest, self).setUp()
2785 mock.patch('gclient_utils.FileRead').start()
2786 mock.patch('gclient_utils.FileWrite').start()
2787 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
2788 mock.patch(
2789 'git_cl.Changelist.GetCodereviewServer',
2790 return_value='https://chromium-review.googlesource.com').start()
2791 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
2792 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
2793 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
2794 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
2795 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
2796 mock.patch('git_cl.time_time').start()
2797 mock.patch('metrics.collector').start()
2798 mock.patch('subprocess2.Popen').start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002799 mock.patch('git_cl.Changelist.GetGerritProject',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002800 return_value='https://chromium-review.googlesource.com').start()
Edward Lemur227d5102020-02-25 23:45:35 +00002801 self.addCleanup(mock.patch.stopall)
2802 self.temp_count = 0
2803
Edward Lemur227d5102020-02-25 23:45:35 +00002804 def testRunHook(self):
2805 expected_results = {
2806 'more_cc': ['more@example.com', 'cc@example.com'],
2807 'should_continue': True,
2808 }
2809 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2810 git_cl.time_time.side_effect = [100, 200]
2811 mockProcess = mock.Mock()
2812 mockProcess.wait.return_value = 0
2813 subprocess2.Popen.return_value = mockProcess
2814
2815 cl = git_cl.Changelist()
2816 results = cl.RunHook(
2817 committing=True,
2818 may_prompt=True,
2819 verbose=2,
2820 parallel=True,
2821 upstream='upstream',
2822 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002823 all_files=True,
2824 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00002825
2826 self.assertEqual(expected_results, results)
2827 subprocess2.Popen.assert_called_once_with([
2828 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00002829 '--root', 'root',
2830 '--upstream', 'upstream',
2831 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002832 '--author', 'author',
2833 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00002834 '--issue', '123456',
2835 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002836 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00002837 '--may_prompt',
2838 '--parallel',
2839 '--all_files',
2840 '--json_output', '/tmp/fake-temp2',
2841 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002842 '--gerrit_project', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00002843 ])
2844 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002845 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00002846 metrics.collector.add_repeated('sub_commands', {
2847 'command': 'presubmit',
2848 'execution_time': 100,
2849 'exit_code': 0,
2850 })
2851
Edward Lemur99df04e2020-03-05 19:39:43 +00002852 def testRunHook_FewerOptions(self):
2853 expected_results = {
2854 'more_cc': ['more@example.com', 'cc@example.com'],
2855 'should_continue': True,
2856 }
2857 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2858 git_cl.time_time.side_effect = [100, 200]
2859 mockProcess = mock.Mock()
2860 mockProcess.wait.return_value = 0
2861 subprocess2.Popen.return_value = mockProcess
2862
2863 git_cl.Changelist.GetAuthor.return_value = None
2864 git_cl.Changelist.GetIssue.return_value = None
2865 git_cl.Changelist.GetPatchset.return_value = None
2866 git_cl.Changelist.GetCodereviewServer.return_value = None
2867
2868 cl = git_cl.Changelist()
2869 results = cl.RunHook(
2870 committing=False,
2871 may_prompt=False,
2872 verbose=0,
2873 parallel=False,
2874 upstream='upstream',
2875 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002876 all_files=False,
2877 resultdb=False)
Edward Lemur99df04e2020-03-05 19:39:43 +00002878
2879 self.assertEqual(expected_results, results)
2880 subprocess2.Popen.assert_called_once_with([
2881 'vpython', 'PRESUBMIT_SUPPORT',
2882 '--root', 'root',
2883 '--upstream', 'upstream',
2884 '--upload',
2885 '--json_output', '/tmp/fake-temp2',
2886 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002887 '--gerrit_project', 'https://chromium-review.googlesource.com',
Edward Lemur99df04e2020-03-05 19:39:43 +00002888 ])
2889 gclient_utils.FileWrite.assert_called_once_with(
2890 '/tmp/fake-temp1', 'description')
2891 metrics.collector.add_repeated('sub_commands', {
2892 'command': 'presubmit',
2893 'execution_time': 100,
2894 'exit_code': 0,
2895 })
2896
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002897 def testRunHook_FewerOptionsResultDB(self):
2898 expected_results = {
2899 'more_cc': ['more@example.com', 'cc@example.com'],
2900 'should_continue': True,
2901 }
2902 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2903 git_cl.time_time.side_effect = [100, 200]
2904 mockProcess = mock.Mock()
2905 mockProcess.wait.return_value = 0
2906 subprocess2.Popen.return_value = mockProcess
2907
2908 git_cl.Changelist.GetAuthor.return_value = None
2909 git_cl.Changelist.GetIssue.return_value = None
2910 git_cl.Changelist.GetPatchset.return_value = None
2911 git_cl.Changelist.GetCodereviewServer.return_value = None
2912
2913 cl = git_cl.Changelist()
2914 results = cl.RunHook(
2915 committing=False,
2916 may_prompt=False,
2917 verbose=0,
2918 parallel=False,
2919 upstream='upstream',
2920 description='description',
2921 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002922 resultdb=True,
2923 realm='chromium:public')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002924
2925 self.assertEqual(expected_results, results)
2926 subprocess2.Popen.assert_called_once_with([
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002927 'rdb', 'stream', '-new', '-realm', 'chromium:public', '--',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002928 'vpython', 'PRESUBMIT_SUPPORT',
2929 '--root', 'root',
2930 '--upstream', 'upstream',
2931 '--upload',
2932 '--json_output', '/tmp/fake-temp2',
2933 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002934 '--gerrit_project', 'https://chromium-review.googlesource.com',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002935 ])
2936
Edward Lemur227d5102020-02-25 23:45:35 +00002937 @mock.patch('sys.exit', side_effect=SystemExitMock)
2938 def testRunHook_Failure(self, _mock):
2939 git_cl.time_time.side_effect = [100, 200]
2940 mockProcess = mock.Mock()
2941 mockProcess.wait.return_value = 2
2942 subprocess2.Popen.return_value = mockProcess
2943
2944 cl = git_cl.Changelist()
2945 with self.assertRaises(SystemExitMock):
2946 cl.RunHook(
2947 committing=True,
2948 may_prompt=True,
2949 verbose=2,
2950 parallel=True,
2951 upstream='upstream',
2952 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002953 all_files=True,
2954 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00002955
2956 sys.exit.assert_called_once_with(2)
2957
Edward Lemur75526302020-02-27 22:31:05 +00002958 def testRunPostUploadHook(self):
2959 cl = git_cl.Changelist()
2960 cl.RunPostUploadHook(2, 'upstream', 'description')
2961
2962 subprocess2.Popen.assert_called_once_with([
2963 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00002964 '--root', 'root',
2965 '--upstream', 'upstream',
2966 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002967 '--author', 'author',
2968 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur75526302020-02-27 22:31:05 +00002969 '--issue', '123456',
2970 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002971 '--post_upload',
2972 '--description_file', '/tmp/fake-temp1',
2973 ])
2974 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002975 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00002976
Edward Lemur9aa1a962020-02-25 00:58:38 +00002977
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002978class CMDTestCaseBase(unittest.TestCase):
2979 _STATUSES = [
2980 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
2981 'INFRA_FAILURE', 'CANCELED',
2982 ]
2983 _CHANGE_DETAIL = {
2984 'project': 'depot_tools',
2985 'status': 'OPEN',
2986 'owner': {'email': 'owner@e.mail'},
2987 'current_revision': 'beeeeeef',
2988 'revisions': {
Gavin Make61ccc52020-11-13 00:12:57 +00002989 'deadbeaf': {
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00002990 '_number': 6,
Gavin Make61ccc52020-11-13 00:12:57 +00002991 'kind': 'REWORK',
2992 },
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002993 'beeeeeef': {
2994 '_number': 7,
Gavin Make61ccc52020-11-13 00:12:57 +00002995 'kind': 'NO_CODE_CHANGE',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002996 'fetch': {'http': {
2997 'url': 'https://chromium.googlesource.com/depot_tools',
2998 'ref': 'refs/changes/56/123456/7'
2999 }},
3000 },
3001 },
3002 }
3003 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003004 'builds': [{
3005 'id': str(100 + idx),
3006 'builder': {
3007 'project': 'chromium',
3008 'bucket': 'try',
3009 'builder': 'bot_' + status.lower(),
3010 },
3011 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3012 'tags': [],
3013 'status': status,
3014 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003015 }
3016
Edward Lemur4c707a22019-09-24 21:13:43 +00003017 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003018 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003019 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003020 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3021 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003022 mock.patch(
3023 'git_cl.Changelist.GetCodereviewServer',
3024 return_value='https://chromium-review.googlesource.com').start()
3025 mock.patch(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00003026 'git_cl.Changelist.GetGerritHost',
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003027 return_value='chromium-review.googlesource.com').start()
3028 mock.patch(
3029 'git_cl.Changelist.GetMostRecentPatchset',
3030 return_value=7).start()
3031 mock.patch(
Gavin Make61ccc52020-11-13 00:12:57 +00003032 'git_cl.Changelist.GetMostRecentDryRunPatchset',
3033 return_value=6).start()
3034 mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003035 'git_cl.Changelist.GetRemoteUrl',
3036 return_value='https://chromium.googlesource.com/depot_tools').start()
3037 mock.patch(
3038 'auth.Authenticator',
3039 return_value=AuthenticatorMock()).start()
3040 mock.patch(
3041 'gerrit_util.GetChangeDetail',
3042 return_value=self._CHANGE_DETAIL).start()
3043 mock.patch(
3044 'git_cl._call_buildbucket',
3045 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003046 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003047 self.addCleanup(mock.patch.stopall)
3048
Edward Lemur4c707a22019-09-24 21:13:43 +00003049
Edward Lemur9468eba2020-02-27 19:07:22 +00003050class CMDPresubmitTestCase(CMDTestCaseBase):
3051 def setUp(self):
3052 super(CMDPresubmitTestCase, self).setUp()
3053 mock.patch(
3054 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3055 return_value='upstream').start()
3056 mock.patch(
3057 'git_cl.Changelist.FetchDescription',
3058 return_value='fetch description').start()
3059 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00003060 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00003061 return_value='get description').start()
3062 mock.patch('git_cl.Changelist.RunHook').start()
3063
3064 def testDefaultCase(self):
3065 self.assertEqual(0, git_cl.main(['presubmit']))
3066 git_cl.Changelist.RunHook.assert_called_once_with(
3067 committing=True,
3068 may_prompt=False,
3069 verbose=0,
3070 parallel=None,
3071 upstream='upstream',
3072 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003073 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003074 resultdb=None,
3075 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003076
3077 def testNoIssue(self):
3078 git_cl.Changelist.GetIssue.return_value = None
3079 self.assertEqual(0, git_cl.main(['presubmit']))
3080 git_cl.Changelist.RunHook.assert_called_once_with(
3081 committing=True,
3082 may_prompt=False,
3083 verbose=0,
3084 parallel=None,
3085 upstream='upstream',
3086 description='get description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003087 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003088 resultdb=None,
3089 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003090
3091 def testCustomBranch(self):
3092 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3093 git_cl.Changelist.RunHook.assert_called_once_with(
3094 committing=True,
3095 may_prompt=False,
3096 verbose=0,
3097 parallel=None,
3098 upstream='custom_branch',
3099 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003100 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003101 resultdb=None,
3102 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003103
3104 def testOptions(self):
3105 self.assertEqual(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003106 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003107 '--resultdb', '--realm', 'chromium:public']))
Edward Lemur9468eba2020-02-27 19:07:22 +00003108 git_cl.Changelist.RunHook.assert_called_once_with(
3109 committing=False,
3110 may_prompt=False,
3111 verbose=2,
3112 parallel=True,
3113 upstream='upstream',
3114 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003115 all_files=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003116 resultdb=True,
3117 realm='chromium:public')
Edward Lemur9468eba2020-02-27 19:07:22 +00003118
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003119class CMDTryResultsTestCase(CMDTestCaseBase):
3120 _DEFAULT_REQUEST = {
3121 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003122 "gerritChanges": [{
3123 "project": "depot_tools",
3124 "host": "chromium-review.googlesource.com",
Gavin Make61ccc52020-11-13 00:12:57 +00003125 "patchset": 6,
3126 "change": 123456,
3127 }],
3128 },
3129 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3130 ',builds.*.createTime,builds.*.tags'),
3131 }
3132
3133 _TRIVIAL_REQUEST = {
3134 'predicate': {
3135 "gerritChanges": [{
3136 "project": "depot_tools",
3137 "host": "chromium-review.googlesource.com",
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003138 "patchset": 7,
3139 "change": 123456,
3140 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003141 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003142 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3143 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003144 }
3145
3146 def testNoJobs(self):
3147 git_cl._call_buildbucket.return_value = {}
3148
3149 self.assertEqual(0, git_cl.main(['try-results']))
3150 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3151 git_cl._call_buildbucket.assert_called_once_with(
3152 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3153 self._DEFAULT_REQUEST)
3154
Gavin Make61ccc52020-11-13 00:12:57 +00003155 def testTrivialCommits(self):
3156 self.assertEqual(0, git_cl.main(['try-results']))
3157 git_cl._call_buildbucket.assert_called_with(
3158 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3159 self._DEFAULT_REQUEST)
3160
3161 git_cl._call_buildbucket.return_value = {}
3162 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '7']))
3163 git_cl._call_buildbucket.assert_called_with(
3164 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3165 self._TRIVIAL_REQUEST)
3166 self.assertEqual([
3167 'Successes:',
3168 ' bot_success https://ci.chromium.org/b/103',
3169 'Infra Failures:',
3170 ' bot_infra_failure https://ci.chromium.org/b/105',
3171 'Failures:',
3172 ' bot_failure https://ci.chromium.org/b/104',
3173 'Canceled:',
3174 ' bot_canceled ',
3175 'Started:',
3176 ' bot_started https://ci.chromium.org/b/102',
3177 'Scheduled:',
3178 ' bot_scheduled id=101',
3179 'Other:',
3180 ' bot_status_unspecified id=100',
3181 'Total: 7 tryjobs',
3182 'No tryjobs scheduled.',
3183 ], sys.stdout.getvalue().splitlines())
3184
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003185 def testPrintToStdout(self):
3186 self.assertEqual(0, git_cl.main(['try-results']))
3187 self.assertEqual([
3188 'Successes:',
3189 ' bot_success https://ci.chromium.org/b/103',
3190 'Infra Failures:',
3191 ' bot_infra_failure https://ci.chromium.org/b/105',
3192 'Failures:',
3193 ' bot_failure https://ci.chromium.org/b/104',
3194 'Canceled:',
3195 ' bot_canceled ',
3196 'Started:',
3197 ' bot_started https://ci.chromium.org/b/102',
3198 'Scheduled:',
3199 ' bot_scheduled id=101',
3200 'Other:',
3201 ' bot_status_unspecified id=100',
3202 'Total: 7 tryjobs',
3203 ], sys.stdout.getvalue().splitlines())
3204 git_cl._call_buildbucket.assert_called_once_with(
3205 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3206 self._DEFAULT_REQUEST)
3207
3208 def testPrintToStdoutWithMasters(self):
3209 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3210 self.assertEqual([
3211 'Successes:',
3212 ' try bot_success https://ci.chromium.org/b/103',
3213 'Infra Failures:',
3214 ' try bot_infra_failure https://ci.chromium.org/b/105',
3215 'Failures:',
3216 ' try bot_failure https://ci.chromium.org/b/104',
3217 'Canceled:',
3218 ' try bot_canceled ',
3219 'Started:',
3220 ' try bot_started https://ci.chromium.org/b/102',
3221 'Scheduled:',
3222 ' try bot_scheduled id=101',
3223 'Other:',
3224 ' try bot_status_unspecified id=100',
3225 'Total: 7 tryjobs',
3226 ], sys.stdout.getvalue().splitlines())
3227 git_cl._call_buildbucket.assert_called_once_with(
3228 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3229 self._DEFAULT_REQUEST)
3230
3231 @mock.patch('git_cl.write_json')
3232 def testWriteToJson(self, mockJsonDump):
3233 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3234 git_cl._call_buildbucket.assert_called_once_with(
3235 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3236 self._DEFAULT_REQUEST)
3237 mockJsonDump.assert_called_once_with(
3238 'file.json', self._DEFAULT_RESPONSE['builds'])
3239
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003240 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003241 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3242 self.assertEqual(
3243 [
3244 ('chromium', 'try', 'bot_failure'),
3245 ('chromium', 'try', 'bot_infra_failure'),
3246 ],
3247 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003248
3249 def test_filter_failed_for_retry_many_builds(self):
3250
3251 def _build(name, created_sec, status, experimental=False):
3252 assert 0 <= created_sec < 100, created_sec
3253 b = {
3254 'id': 112112,
3255 'builder': {
3256 'project': 'chromium',
3257 'bucket': 'try',
3258 'builder': name,
3259 },
3260 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3261 'status': status,
3262 'tags': [],
3263 }
3264 if experimental:
3265 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3266 return b
3267
3268 builds = [
3269 _build('flaky-last-green', 1, 'FAILURE'),
3270 _build('flaky-last-green', 2, 'SUCCESS'),
3271 _build('flaky', 1, 'SUCCESS'),
3272 _build('flaky', 2, 'FAILURE'),
3273 _build('running', 1, 'FAILED'),
3274 _build('running', 2, 'SCHEDULED'),
3275 _build('yep-still-running', 1, 'STARTED'),
3276 _build('yep-still-running', 2, 'FAILURE'),
3277 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3278 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3279
3280 # Simulate experimental in CQ builder, which developer decided
3281 # to retry manually which resulted in 2nd build non-experimental.
3282 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3283 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3284 ]
3285 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003286 self.assertEqual(
3287 [
3288 ('chromium', 'try', 'flaky'),
3289 ('chromium', 'try', 'sometimes-experimental'),
3290 ],
3291 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003292
3293
3294class CMDTryTestCase(CMDTestCaseBase):
3295
3296 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003297 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003298 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003299 self.assertEqual(0, git_cl.main(['try']))
3300 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3301 self.assertEqual(
3302 sys.stdout.getvalue(),
3303 'Scheduling CQ dry run on: '
3304 'https://chromium-review.googlesource.com/123456\n')
3305
Edward Lemur4c707a22019-09-24 21:13:43 +00003306 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003307 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003308 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003309
3310 self.assertEqual(0, git_cl.main([
3311 'try', '-B', 'luci.chromium.try', '-b', 'win',
3312 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3313 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003314 'Scheduling jobs on:\n'
3315 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003316 git_cl.sys.stdout.getvalue())
3317
3318 expected_request = {
3319 "requests": [{
3320 "scheduleBuild": {
3321 "requestId": "uuid4",
3322 "builder": {
3323 "project": "chromium",
3324 "builder": "win",
3325 "bucket": "try",
3326 },
3327 "gerritChanges": [{
3328 "project": "depot_tools",
3329 "host": "chromium-review.googlesource.com",
3330 "patchset": 7,
3331 "change": 123456,
3332 }],
3333 "properties": {
3334 "category": "git_cl_try",
3335 "json": [{"a": 1}, None],
3336 "key": "val",
3337 },
3338 "tags": [
3339 {"value": "win", "key": "builder"},
3340 {"value": "git_cl_try", "key": "user_agent"},
3341 ],
3342 },
3343 }],
3344 }
3345 mockCallBuildbucket.assert_called_with(
3346 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3347
Anthony Polito1a5fe232020-01-24 23:17:52 +00003348 @mock.patch('git_cl._call_buildbucket')
3349 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3350 mockCallBuildbucket.return_value = {}
3351
3352 self.assertEqual(0, git_cl.main([
3353 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3354 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3355 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3356 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003357 'Scheduling jobs on:\n'
3358 ' chromium/try: linux\n'
3359 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003360 git_cl.sys.stdout.getvalue())
3361
3362 expected_request = {
3363 "requests": [{
3364 "scheduleBuild": {
3365 "requestId": "uuid4",
3366 "builder": {
3367 "project": "chromium",
3368 "builder": "linux",
3369 "bucket": "try",
3370 },
3371 "gerritChanges": [{
3372 "project": "depot_tools",
3373 "host": "chromium-review.googlesource.com",
3374 "patchset": 7,
3375 "change": 123456,
3376 }],
3377 "properties": {
3378 "category": "git_cl_try",
3379 "json": [{"a": 1}, None],
3380 "key": "val",
3381 },
3382 "tags": [
3383 {"value": "linux", "key": "builder"},
3384 {"value": "git_cl_try", "key": "user_agent"},
3385 ],
3386 "gitilesCommit": {
3387 "host": "chromium-review.googlesource.com",
3388 "project": "depot_tools",
3389 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3390 }
3391 },
3392 },
3393 {
3394 "scheduleBuild": {
3395 "requestId": "uuid4",
3396 "builder": {
3397 "project": "chromium",
3398 "builder": "win",
3399 "bucket": "try",
3400 },
3401 "gerritChanges": [{
3402 "project": "depot_tools",
3403 "host": "chromium-review.googlesource.com",
3404 "patchset": 7,
3405 "change": 123456,
3406 }],
3407 "properties": {
3408 "category": "git_cl_try",
3409 "json": [{"a": 1}, None],
3410 "key": "val",
3411 },
3412 "tags": [
3413 {"value": "win", "key": "builder"},
3414 {"value": "git_cl_try", "key": "user_agent"},
3415 ],
3416 "gitilesCommit": {
3417 "host": "chromium-review.googlesource.com",
3418 "project": "depot_tools",
3419 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3420 }
3421 },
3422 }],
3423 }
3424 mockCallBuildbucket.assert_called_with(
3425 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3426
Edward Lemur45768512020-03-02 19:03:14 +00003427 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003428 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003429 with self.assertRaises(SystemExit):
3430 git_cl.main([
3431 'try', '-B', 'not-a-bucket', '-b', 'win',
3432 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003433 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003434 'Invalid bucket: not-a-bucket.',
3435 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003436
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003437 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003438 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003439 def testScheduleOnBuildbucketRetryFailed(
3440 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003441 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003442 7: [],
3443 6: [{
3444 'id': 112112,
3445 'builder': {
3446 'project': 'chromium',
3447 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003448 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003449 'createTime': '2019-10-09T08:00:01.854286Z',
3450 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003451 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003452 mockCallBuildbucket.return_value = {}
3453
3454 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3455 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003456 'Scheduling jobs on:\n'
3457 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003458 git_cl.sys.stdout.getvalue())
3459
3460 expected_request = {
3461 "requests": [{
3462 "scheduleBuild": {
3463 "requestId": "uuid4",
3464 "builder": {
3465 "project": "chromium",
3466 "bucket": "try",
3467 "builder": "linux",
3468 },
3469 "gerritChanges": [{
3470 "project": "depot_tools",
3471 "host": "chromium-review.googlesource.com",
3472 "patchset": 7,
3473 "change": 123456,
3474 }],
3475 "properties": {
3476 "category": "git_cl_try",
3477 },
3478 "tags": [
3479 {"value": "linux", "key": "builder"},
3480 {"value": "git_cl_try", "key": "user_agent"},
3481 {"value": "1", "key": "retry_failed"},
3482 ],
3483 },
3484 }],
3485 }
3486 mockCallBuildbucket.assert_called_with(
3487 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3488
Edward Lemur4c707a22019-09-24 21:13:43 +00003489 def test_parse_bucket(self):
3490 test_cases = [
3491 {
3492 'bucket': 'chromium/try',
3493 'result': ('chromium', 'try'),
3494 },
3495 {
3496 'bucket': 'luci.chromium.try',
3497 'result': ('chromium', 'try'),
3498 'has_warning': True,
3499 },
3500 {
3501 'bucket': 'skia.primary',
3502 'result': ('skia', 'skia.primary'),
3503 'has_warning': True,
3504 },
3505 {
3506 'bucket': 'not-a-bucket',
3507 'result': (None, None),
3508 },
3509 ]
3510
3511 for test_case in test_cases:
3512 git_cl.sys.stdout.truncate(0)
3513 self.assertEqual(
3514 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3515 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003516 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3517 test_case['result'])
3518 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003519
3520
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003521class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003522
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003523 def setUp(self):
3524 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003525 mock.patch('git_cl._fetch_tryjobs').start()
3526 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003527 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003528 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3529 mock.patch(
3530 'git_cl.Settings.GetSquashGerritUploads',
3531 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003532 self.addCleanup(mock.patch.stopall)
3533
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003534 def testWarmUpChangeDetailCache(self):
3535 self.assertEqual(0, git_cl.main(['upload']))
3536 gerrit_util.GetChangeDetail.assert_called_once_with(
3537 'chromium-review.googlesource.com', 'depot_tools~123456',
3538 frozenset([
3539 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3540 'CURRENT_COMMIT']))
3541
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003542 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003543 # This test mocks out the actual upload part, and just asserts that after
3544 # upload, if --retry-failed is added, then the tool will fetch try jobs
3545 # from the previous patchset and trigger the right builders on the latest
3546 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003547 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003548 # Latest patchset: No builds.
3549 [],
3550 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003551 [{
3552 'id': str(100 + idx),
3553 'builder': {
3554 'project': 'chromium',
3555 'bucket': 'try',
3556 'builder': 'bot_' + status.lower(),
3557 },
3558 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3559 'tags': [],
3560 'status': status,
3561 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003562 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003563
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003564 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003565 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003566 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3567 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003568 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003569 expected_buckets = [
3570 ('chromium', 'try', 'bot_failure'),
3571 ('chromium', 'try', 'bot_infra_failure'),
3572 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003573 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3574 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003575
Brian Sheedy59b06a82019-10-14 17:03:29 +00003576
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003577class MakeRequestsHelperTestCase(unittest.TestCase):
3578
3579 def exampleGerritChange(self):
3580 return {
3581 'host': 'chromium-review.googlesource.com',
3582 'project': 'depot_tools',
3583 'change': 1,
3584 'patchset': 2,
3585 }
3586
3587 def testMakeRequestsHelperNoOptions(self):
3588 # Basic test for the helper function _make_tryjob_schedule_requests;
3589 # it shouldn't throw AttributeError even when options doesn't have any
3590 # of the expected values; it will use default option values.
3591 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3592 jobs = [('chromium', 'try', 'my-builder')]
3593 options = optparse.Values()
3594 requests = git_cl._make_tryjob_schedule_requests(
3595 changelist, jobs, options, patchset=None)
3596
3597 # requestId is non-deterministic. Just assert that it's there and has
3598 # a particular length.
3599 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3600 self.assertEqual(requests, [{
3601 'scheduleBuild': {
3602 'builder': {
3603 'bucket': 'try',
3604 'builder': 'my-builder',
3605 'project': 'chromium'
3606 },
3607 'gerritChanges': [self.exampleGerritChange()],
3608 'properties': {
3609 'category': 'git_cl_try'
3610 },
3611 'tags': [{
3612 'key': 'builder',
3613 'value': 'my-builder'
3614 }, {
3615 'key': 'user_agent',
3616 'value': 'git_cl_try'
3617 }]
3618 }
3619 }])
3620
3621 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3622 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3623 jobs = [('chromium', 'try', 'presubmit')]
3624 options = optparse.Values()
3625 requests = git_cl._make_tryjob_schedule_requests(
3626 changelist, jobs, options, patchset=None)
3627 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3628 'category': 'git_cl_try',
3629 'dry_run': 'true'
3630 })
3631
3632 def testMakeRequestsHelperRevisionSet(self):
3633 # Gitiles commit is specified when revision is in options.
3634 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3635 jobs = [('chromium', 'try', 'my-builder')]
3636 options = optparse.Values({'revision': 'ba5eba11'})
3637 requests = git_cl._make_tryjob_schedule_requests(
3638 changelist, jobs, options, patchset=None)
3639 self.assertEqual(
3640 requests[0]['scheduleBuild']['gitilesCommit'], {
3641 'host': 'chromium-review.googlesource.com',
3642 'id': 'ba5eba11',
3643 'project': 'depot_tools'
3644 })
3645
3646 def testMakeRequestsHelperRetryFailedSet(self):
3647 # An extra tag is added when retry_failed is in options.
3648 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3649 jobs = [('chromium', 'try', 'my-builder')]
3650 options = optparse.Values({'retry_failed': 'true'})
3651 requests = git_cl._make_tryjob_schedule_requests(
3652 changelist, jobs, options, patchset=None)
3653 self.assertEqual(
3654 requests[0]['scheduleBuild']['tags'], [
3655 {
3656 'key': 'builder',
3657 'value': 'my-builder'
3658 },
3659 {
3660 'key': 'user_agent',
3661 'value': 'git_cl_try'
3662 },
3663 {
3664 'key': 'retry_failed',
3665 'value': '1'
3666 }
3667 ])
3668
3669 def testMakeRequestsHelperCategorySet(self):
Quinten Yearsley925cedb2020-04-13 17:49:39 +00003670 # The category property can be overridden with options.
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003671 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3672 jobs = [('chromium', 'try', 'my-builder')]
3673 options = optparse.Values({'category': 'my-special-category'})
3674 requests = git_cl._make_tryjob_schedule_requests(
3675 changelist, jobs, options, patchset=None)
3676 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3677 {'category': 'my-special-category'})
3678
3679
Edward Lemurda4b6c62020-02-13 00:28:40 +00003680class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003681
3682 def setUp(self):
3683 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003684 mock.patch('git_cl.RunCommand').start()
3685 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3686 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3687 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003688 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003689 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003690
3691 def tearDown(self):
3692 shutil.rmtree(self._top_dir)
3693 super(CMDFormatTestCase, self).tearDown()
3694
Jamie Madill5e96ad12020-01-13 16:08:35 +00003695 def _make_temp_file(self, fname, contents):
3696 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3697 tf.write('\n'.join(contents))
3698
Brian Sheedy59b06a82019-10-14 17:03:29 +00003699 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003700 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003701
Brian Sheedyb4307d52019-12-02 19:18:17 +00003702 def _check_yapf_filtering(self, files, expected):
3703 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3704 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003705
Edward Lemur1a83da12020-03-04 21:18:36 +00003706 def _run_command_mock(self, return_value):
3707 def f(*args, **kwargs):
3708 if 'stdin' in kwargs:
3709 self.assertIsInstance(kwargs['stdin'], bytes)
3710 return return_value
3711 return f
3712
Jamie Madill5e96ad12020-01-13 16:08:35 +00003713 def testClangFormatDiffFull(self):
3714 self._make_temp_file('test.cc', ['// test'])
3715 git_cl.settings.GetFormatFullByDefault.return_value = False
3716 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3717 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3718
3719 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003720 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003721 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3722 self._top_dir, 'HEAD')
3723 self.assertEqual(2, return_value)
3724
3725 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003726 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003727 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3728 self._top_dir, 'HEAD')
3729 self.assertEqual(0, return_value)
3730
3731 def testClangFormatDiff(self):
3732 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00003733 # A valid file is required, so use this test.
3734 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00003735 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3736
3737 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003738 git_cl.RunCommand.side_effect = self._run_command_mock('error')
3739 return_value = git_cl._RunClangFormatDiff(
3740 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003741 self.assertEqual(2, return_value)
3742
3743 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003744 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003745 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3746 'HEAD')
3747 self.assertEqual(0, return_value)
3748
Brian Sheedyb4307d52019-12-02 19:18:17 +00003749 def testYapfignoreExplicit(self):
3750 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3751 files = [
3752 'bar.py',
3753 'foo/bar.py',
3754 'foo/baz.py',
3755 'foo/bar/baz.py',
3756 'foo/bar/foobar.py',
3757 ]
3758 expected = [
3759 'bar.py',
3760 'foo/baz.py',
3761 'foo/bar/foobar.py',
3762 ]
3763 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003764
Brian Sheedyb4307d52019-12-02 19:18:17 +00003765 def testYapfignoreSingleWildcards(self):
3766 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3767 files = [
3768 'bar.py', # Matched by *bar.py.
3769 'bar.txt',
3770 'foobar.py', # Matched by *bar.py, foo*.
3771 'foobar.txt', # Matched by foo*.
3772 'bazbar.py', # Matched by *bar.py, baz*.py.
3773 'bazbar.txt',
3774 'foo/baz.txt', # Matched by foo*.
3775 'bar/bar.py', # Matched by *bar.py.
3776 'baz/foo.py', # Matched by baz*.py, foo*.
3777 'baz/foo.txt',
3778 ]
3779 expected = [
3780 'bar.txt',
3781 'bazbar.txt',
3782 'baz/foo.txt',
3783 ]
3784 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003785
Brian Sheedyb4307d52019-12-02 19:18:17 +00003786 def testYapfignoreMultiplewildcards(self):
3787 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3788 files = [
3789 'bar.py', # Matched by *bar*.
3790 'bar.txt', # Matched by *bar*.
3791 'abar.py', # Matched by *bar*.
3792 'foobaz.txt', # Matched by *foo*baz.txt.
3793 'foobaz.py',
3794 'afoobaz.txt', # Matched by *foo*baz.txt.
3795 ]
3796 expected = [
3797 'foobaz.py',
3798 ]
3799 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003800
3801 def testYapfignoreComments(self):
3802 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003803 files = [
3804 'test.py',
3805 'test2.py',
3806 ]
3807 expected = [
3808 'test2.py',
3809 ]
3810 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003811
3812 def testYapfignoreBlankLines(self):
3813 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003814 files = [
3815 'test.py',
3816 'test2.py',
3817 'test3.py',
3818 ]
3819 expected = [
3820 'test3.py',
3821 ]
3822 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003823
3824 def testYapfignoreWhitespace(self):
3825 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003826 files = [
3827 'test.py',
3828 'test2.py',
3829 ]
3830 expected = [
3831 'test2.py',
3832 ]
3833 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003834
Brian Sheedyb4307d52019-12-02 19:18:17 +00003835 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003836 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003837 self._check_yapf_filtering([], [])
3838
3839 def testYapfignoreMissingYapfignore(self):
3840 files = [
3841 'test.py',
3842 ]
3843 expected = [
3844 'test.py',
3845 ]
3846 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003847
3848
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003849class CMDStatusTestCase(CMDTestCaseBase):
3850 # Return branch names a,..,f with comitterdates in increasing order, i.e.
3851 # 'f' is the most-recently changed branch.
3852 def _mock_run_git(commands):
3853 if commands == [
3854 'for-each-ref', '--format=%(refname) %(committerdate:unix)',
3855 'refs/heads'
3856 ]:
3857 branches_and_committerdates = [
3858 'refs/heads/a 1',
3859 'refs/heads/b 2',
3860 'refs/heads/c 3',
3861 'refs/heads/d 4',
3862 'refs/heads/e 5',
3863 'refs/heads/f 6',
3864 ]
3865 return '\n'.join(branches_and_committerdates)
3866
3867 # Mock the status in such a way that the issue number gives us an
3868 # indication of the commit date (simplifies manual debugging).
3869 def _mock_get_cl_statuses(branches, fine_grained, max_processes):
3870 for c in branches:
3871 c.issue = (100 + int(c.GetCommitDate()))
3872 yield (c, 'open')
3873
3874 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
3875 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
3876 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
3877 @mock.patch('git_cl.RunGit', _mock_run_git)
3878 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
3879 @mock.patch('git_cl.Settings.GetRoot', return_value='')
3880 @mock.patch('scm.GIT.GetBranch', return_value='a')
3881 def testStatus(self, *_mocks):
3882 self.assertEqual(0, git_cl.main(['status', '--no-branch-color']))
3883 self.maxDiff = None
3884 self.assertEqual(
3885 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
3886 ' * a : https://crrev.com/c/101 (open)\n'
3887 ' b : https://crrev.com/c/102 (open)\n'
3888 ' c : https://crrev.com/c/103 (open)\n'
3889 ' d : https://crrev.com/c/104 (open)\n'
3890 ' e : https://crrev.com/c/105 (open)\n'
3891 ' f : https://crrev.com/c/106 (open)\n\n'
3892 'Current branch: a\n'
3893 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
3894 'Issue description:\n'
3895 'x\n')
3896
3897 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
3898 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
3899 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
3900 @mock.patch('git_cl.RunGit', _mock_run_git)
3901 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
3902 @mock.patch('git_cl.Settings.GetRoot', return_value='')
3903 @mock.patch('scm.GIT.GetBranch', return_value='a')
3904 def testStatusByDate(self, *_mocks):
3905 self.assertEqual(
3906 0, git_cl.main(['status', '--no-branch-color', '--date-order']))
3907 self.maxDiff = None
3908 self.assertEqual(
3909 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
3910 ' f : https://crrev.com/c/106 (open)\n'
3911 ' e : https://crrev.com/c/105 (open)\n'
3912 ' d : https://crrev.com/c/104 (open)\n'
3913 ' c : https://crrev.com/c/103 (open)\n'
3914 ' b : https://crrev.com/c/102 (open)\n'
3915 ' * a : https://crrev.com/c/101 (open)\n\n'
3916 'Current branch: a\n'
3917 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
3918 'Issue description:\n'
3919 'x\n')
3920
3921
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00003922class CMDOwnersTestCase(CMDTestCaseBase):
3923 def setUp(self):
3924 super(CMDOwnersTestCase, self).setUp()
3925 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
3926 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
3927 mock.patch(
3928 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3929 return_value='upstream').start()
3930 mock.patch('owners_client.DepotToolsClient').start()
3931 self.addCleanup(mock.patch.stopall)
3932
3933 def testShowAllNoArgs(self):
3934 self.assertEqual(0, git_cl.main(['owners', '--show-all']))
3935 self.assertEqual(
3936 'No files specified for --show-all. Nothing to do.\n',
3937 git_cl.sys.stdout.getvalue())
3938
3939 def testShowAll(self):
3940 batch_mock = owners_client.DepotToolsClient.return_value.BatchListOwners
3941 batch_mock.return_value = {
3942 'foo': ['a@example.com'],
3943 'bar': ['b@example.com', 'c@example.com'],
3944 }
3945 self.assertEqual(
3946 0,
3947 git_cl.main(['owners', '--show-all', 'foo', 'bar', 'baz']))
3948 batch_mock.assert_called_once_with(['foo', 'bar', 'baz'])
3949 self.assertEqual(
3950 '\n'.join([
3951 'Owners for foo:',
3952 ' - a@example.com',
3953 'Owners for bar:',
3954 ' - b@example.com',
3955 ' - c@example.com',
3956 'Owners for baz:',
3957 ' - No owners found',
3958 '',
3959 ]),
3960 sys.stdout.getvalue())
3961
3962
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003963if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003964 logging.basicConfig(
3965 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003966 unittest.main()