blob: 62069e6b293f0405655da9722340d8a0f59c7d5a [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
34# We have to disable monitoring before importing git_cl.
35metrics.DISABLE_METRICS_COLLECTION = True
36
Jamie Madill5e96ad12020-01-13 16:08:35 +000037import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000038import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000039import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000040import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000041import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000042import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000043import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000044import git_new_branch
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +000045import owners_client
Edward Lemur85153282020-02-14 22:06:29 +000046import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000047import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000048
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000049NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
50
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000051
Edward Lemur0db01f02019-11-12 22:01:51 +000052def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070053 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
54
tandrii5d48c322016-08-18 16:19:37 -070055CERR1 = callError(1)
56
57
Edward Lemur1773f372020-02-22 00:27:14 +000058class TemporaryFileMock(object):
59 def __init__(self):
60 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070061
Edward Lemur1773f372020-02-22 00:27:14 +000062 @contextlib.contextmanager
63 def __call__(self):
64 self.suffix += 1
65 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070066
67
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000068class ChangelistMock(object):
69 # A class variable so we can access it when we don't have access to the
70 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000071 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000072
73 def __init__(self, gerrit_change=None, **kwargs):
74 self._gerrit_change = gerrit_change
75
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000076 def GetIssue(self):
77 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000078
Edward Lemur6c6827c2020-02-06 21:15:18 +000079 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000080 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000081
dsansomee2d6fd92016-09-08 00:10:47 -070082 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000083 ChangelistMock.desc = desc
84
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000085 def GetGerritChange(self, patchset=None, **kwargs):
86 del patchset
87 return self._gerrit_change
88
tandrii5d48c322016-08-18 16:19:37 -070089
Edward Lemur85153282020-02-14 22:06:29 +000090class GitMocks(object):
91 def __init__(self, config=None, branchref=None):
92 self.branchref = branchref or 'refs/heads/master'
93 self.config = config or {}
94
95 def GetBranchRef(self, _root):
96 return self.branchref
97
98 def NewBranch(self, branchref):
99 self.branchref = branchref
100
Edward Lemur26964072020-02-19 19:18:51 +0000101 def GetConfig(self, root, key, default=None):
102 if root != '':
103 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000104 return self.config.get(key, default)
105
Edward Lemur26964072020-02-19 19:18:51 +0000106 def SetConfig(self, root, key, value=None):
107 if root != '':
108 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000109 if value:
110 self.config[key] = value
111 return
112 if key not in self.config:
113 raise CERR1
114 del self.config[key]
115
116
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000117class WatchlistsMock(object):
118 def __init__(self, _):
119 pass
120 @staticmethod
121 def GetWatchersForPaths(_):
122 return ['joe@example.com']
123
124
Edward Lemur4c707a22019-09-24 21:13:43 +0000125class CodereviewSettingsFileMock(object):
126 def __init__(self):
127 pass
128 # pylint: disable=no-self-use
129 def read(self):
130 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
131 'GERRIT_HOST: True\n')
132
133
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000134class AuthenticatorMock(object):
135 def __init__(self, *_args):
136 pass
137 def has_cached_credentials(self):
138 return True
tandrii221ab252016-10-06 08:12:04 -0700139 def authorize(self, http):
140 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000141
142
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100143def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000144 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
145
146 Usage:
147 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100148 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000149
150 OR
151 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100152 CookiesAuthenticatorMockFactory(
153 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000154 """
155 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800156 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000157 # Intentionally not calling super() because it reads actual cookie files.
158 pass
159 @classmethod
160 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000161 return os.path.join('~', '.gitcookies')
162
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000163 @classmethod
164 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000165 return os.path.join('~', NETRC_FILENAME)
166
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100167 def _get_auth_for_host(self, host):
168 if same_auth:
169 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000170 return (hosts_with_creds or {}).get(host)
171 return CookiesAuthenticatorMock
172
Aaron Gable9a03ae02017-11-03 11:31:07 -0700173
kmarshall9249e012016-08-23 12:02:16 -0700174class MockChangelistWithBranchAndIssue():
175 def __init__(self, branch, issue):
176 self.branch = branch
177 self.issue = issue
178 def GetBranch(self):
179 return self.branch
180 def GetIssue(self):
181 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000182
tandriic2405f52016-10-10 08:13:15 -0700183
184class SystemExitMock(Exception):
185 pass
186
187
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000188class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000189 def setUp(self):
190 mock.patch('sys.exit', side_effect=SystemExitMock).start()
191 mock.patch('sys.stdout', StringIO()).start()
192 mock.patch('sys.stderr', StringIO()).start()
193 self.addCleanup(mock.patch.stopall)
194
195 def test_die_with_error(self):
196 with self.assertRaises(SystemExitMock):
197 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
198 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
199 self.assertTrue('saving CL description' in sys.stdout.getvalue())
200 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
201 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
202 sys.exit.assert_called_once_with(1)
203
204 def test_die_with_error_no_desc(self):
205 with self.assertRaises(SystemExitMock):
206 git_cl.DieWithError('foo')
207 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
208 self.assertEqual(sys.stdout.getvalue(), '')
209 sys.exit.assert_called_once_with(1)
210
Edward Lemur6c6827c2020-02-06 21:15:18 +0000211 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000212 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100213 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000214 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700215
Edward Lemur61bf4172020-02-24 23:22:37 +0000216 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
217 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
218 def test_get_cl_statuses(self, *_mocks):
219 statuses = [
220 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
221 changes = []
222 for status in statuses:
223 cl = git_cl.Changelist()
224 cl.status = status
225 changes.append(cl)
226
227 actual = set(git_cl.get_cl_statuses(changes, True))
228 self.assertEqual(set(zip(changes, statuses)), actual)
229
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000230 def test_upload_to_non_default_branch_no_retry(self):
231 m = mock.patch('git_cl.Changelist._CMDUploadChange',
232 side_effect=[git_cl.GitPushError(), None]).start()
233 mock.patch('git_cl.Changelist.GetRemoteBranch',
234 return_value=('foo', 'bar')).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000235 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000236 return_value='foo').start()
237 mock.patch('git_cl.gerrit_util.GetProjectHead',
238 return_value='refs/heads/main').start()
239
240 cl = git_cl.Changelist()
241 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000242 options.target_branch = 'refs/heads/bar'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000243 with self.assertRaises(SystemExitMock):
244 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
245
246 # ensure upload is called once
247 self.assertEqual(len(m.mock_calls), 1)
248 sys.exit.assert_called_once_with(1)
249 # option not set as retry didn't happen
250 self.assertFalse(hasattr(options, 'force'))
251 self.assertFalse(hasattr(options, 'edit_description'))
252
253 def test_upload_to_old_default_still_active(self):
254 m = mock.patch('git_cl.Changelist._CMDUploadChange',
255 side_effect=[git_cl.GitPushError(), None]).start()
256 mock.patch('git_cl.Changelist.GetRemoteBranch',
257 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000258 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000259 return_value='foo').start()
260 mock.patch('git_cl.gerrit_util.GetProjectHead',
Josip Sokcevicb631a882021-01-06 18:18:10 +0000261 return_value='refs/heads/master').start()
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000262
263 cl = git_cl.Changelist()
264 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000265 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000266 with self.assertRaises(SystemExitMock):
267 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
268
269 # ensure upload is called once
270 self.assertEqual(len(m.mock_calls), 1)
271 sys.exit.assert_called_once_with(1)
272 # option not set as retry didn't happen
273 self.assertFalse(hasattr(options, 'force'))
274 self.assertFalse(hasattr(options, 'edit_description'))
275
276 def test_upload_to_old_default_retry_on_failure(self):
277 m = mock.patch('git_cl.Changelist._CMDUploadChange',
278 side_effect=[git_cl.GitPushError(), None]).start()
279 mock.patch('git_cl.Changelist.GetRemoteBranch',
280 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000281 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000282 return_value='foo').start()
283 mock.patch('git_cl.gerrit_util.GetProjectHead',
284 return_value='refs/heads/main').start()
285 mock.patch('git_cl.RunGit').start()
286
287 cl = git_cl.Changelist()
288 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000289 options.target_branch = 'refs/heads/master'
290 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
291 # ensure upload is called twice
292 self.assertEqual(len(m.mock_calls), 2)
293 # option overrides on retry
294 self.assertEqual(options.force, True)
295 self.assertEqual(options.edit_description, False)
296
297 def test_upload_to_old_default_retry_on_rollback(self):
298 """Test when default branch migration had to be rolled back to old name"""
299 m = mock.patch('git_cl.Changelist._CMDUploadChange',
300 side_effect=[git_cl.GitPushError(), None]).start()
301 mock.patch('git_cl.Changelist.GetRemoteBranch',
302 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
303 mock.patch('git_cl.Changelist.GetGerritProject',
304 return_value='foo').start()
305 mock.patch('git_cl.gerrit_util.GetProjectHead',
306 return_value='refs/heads/master').start()
307 # GetTargetRef returns new default branch since it has stale remote
308 # information.
309 mock.patch('git_cl.GetTargetRef',
310 return_value='refs/heads/main').start()
311 mock.patch('git_cl.RunGit').start()
312
313 cl = git_cl.Changelist()
314 options = optparse.Values()
315 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000316 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
317 # ensure upload is called twice
318 self.assertEqual(len(m.mock_calls), 2)
319 # option overrides on retry
320 self.assertEqual(options.force, True)
321 self.assertEqual(options.edit_description, False)
322
Edward Lemur61bf4172020-02-24 23:22:37 +0000323 def test_get_cl_statuses_no_changes(self):
324 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
325
326 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
327 @mock.patch('multiprocessing.pool.ThreadPool')
328 def test_get_cl_statuses_timeout(self, *_mocks):
329 changes = [git_cl.Changelist() for _ in range(2)]
330 pool = multiprocessing.pool.ThreadPool()
331 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
332 it.return_value.next.side_effect = [
333 (changes[0], 'lgtm'),
334 multiprocessing.TimeoutError,
335 ]
336
337 actual = list(git_cl.get_cl_statuses(changes, True))
338 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
339
340 @mock.patch('git_cl.Changelist.GetIssueURL')
341 def test_get_cl_statuses_not_finegrained(self, _mock):
342 changes = [git_cl.Changelist() for _ in range(2)]
343 urls = ['some-url', None]
344 git_cl.Changelist.GetIssueURL.side_effect = urls
345
346 actual = set(git_cl.get_cl_statuses(changes, False))
347 self.assertEqual(
348 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
349
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000350 def test_get_issue_url(self):
351 cl = git_cl.Changelist(issue=123)
352 cl._gerrit_server = 'https://example.com'
353 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
354 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
355
356 cl = git_cl.Changelist(issue=123)
357 cl._gerrit_server = 'https://chromium-review.googlesource.com'
358 self.assertEqual(cl.GetIssueURL(),
359 'https://chromium-review.googlesource.com/123')
360 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
361
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000362 def test_set_preserve_tryjobs(self):
363 d = git_cl.ChangeDescription('Simple.')
364 d.set_preserve_tryjobs()
365 self.assertEqual(d.description.splitlines(), [
366 'Simple.',
367 '',
368 'Cq-Do-Not-Cancel-Tryjobs: true',
369 ])
370 before = d.description
371 d.set_preserve_tryjobs()
372 self.assertEqual(before, d.description)
373
374 d = git_cl.ChangeDescription('\n'.join([
375 'One is enough',
376 '',
377 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
378 'Change-Id: Ideadbeef',
379 ]))
380 d.set_preserve_tryjobs()
381 self.assertEqual(d.description.splitlines(), [
382 'One is enough',
383 '',
384 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
385 'Change-Id: Ideadbeef',
386 'Cq-Do-Not-Cancel-Tryjobs: true',
387 ])
388
tandriif9aefb72016-07-01 09:06:51 -0700389 def test_get_bug_line_values(self):
390 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
391 self.assertEqual(f('', ''), [])
392 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
Lei Zhang8a0efc12020-08-05 19:58:45 +0000393 # Prefix that ends with colon.
394 self.assertEqual(f('v8:', '456'), ['v8:456'])
395 self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
396 # Prefix that ends without colon.
tandriif9aefb72016-07-01 09:06:51 -0700397 self.assertEqual(f('v8', '456'), ['v8:456'])
398 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
399 # Not nice, but not worth carying.
Lei Zhang8a0efc12020-08-05 19:58:45 +0000400 self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
401 ['v8:456', 'chromium:123', 'v8:123'])
tandriif9aefb72016-07-01 09:06:51 -0700402 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
403 ['v8:456', 'chromium:123', 'v8:123'])
404
Edward Lemurda4b6c62020-02-13 00:28:40 +0000405 @mock.patch('gerrit_util.GetAccountDetails')
406 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000407 mock_per_account = {
408 'u1': None, # 404, doesn't exist.
409 'u2': {
410 '_account_id': 123124,
411 'avatars': [],
412 'email': 'u2@example.com',
413 'name': 'User Number 2',
414 'status': 'OOO',
415 },
416 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
417 }
418 def GetAccountDetailsMock(_, account):
419 # Poor-man's mock library's side_effect.
420 v = mock_per_account.pop(account)
421 if isinstance(v, Exception):
422 raise v
423 return v
424
Edward Lemurda4b6c62020-02-13 00:28:40 +0000425 mockGetAccountDetails.side_effect = GetAccountDetailsMock
426 actual = git_cl.gerrit_util.ValidAccounts(
427 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000428 self.assertEqual(actual, {
429 'u2': {
430 '_account_id': 123124,
431 'avatars': [],
432 'email': 'u2@example.com',
433 'name': 'User Number 2',
434 'status': 'OOO',
435 },
436 })
437
438
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200439class TestParseIssueURL(unittest.TestCase):
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000440 def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
441 parsed = git_cl.ParseIssueNumberArgument(arg)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200442 self.assertIsNotNone(parsed)
443 if fail:
444 self.assertFalse(parsed.valid)
445 return
446 self.assertTrue(parsed.valid)
447 self.assertEqual(parsed.issue, issue)
448 self.assertEqual(parsed.patchset, patchset)
449 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200450
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000451 def test_basic(self):
452 self._test('123', 123)
453 self._test('', fail=True)
454 self._test('abc', fail=True)
455 self._test('123/1', fail=True)
456 self._test('123a', fail=True)
457 self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
458 self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200459
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000460 def test_gerrit_url(self):
461 self._test('https://codereview.source.com/123', 123, None,
462 'codereview.source.com')
463 self._test('http://chrome-review.source.com/c/123', 123, None,
464 'chrome-review.source.com')
465 self._test('https://chrome-review.source.com/c/123/', 123, None,
466 'chrome-review.source.com')
467 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
468 'chrome-review.source.com')
469 self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
470 'chrome-review.source.com')
471 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
472 'chrome-review.source.com')
473 self._test('https://chrome-review.source.com/123', 123, None,
474 'chrome-review.source.com')
475 self._test('https://chrome-review.source.com/123/4', 123, 4,
476 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200477
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000478 self._test('https://chrome-review.source.com/bad/123/4', fail=True)
479 self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
480 self._test('https://chrome-review.source.com/c/abc/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200481
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000482 def test_short_urls(self):
483 self._test('https://crrev.com/c/2151934', 2151934, None,
484 'chromium-review.googlesource.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200485
486
Edward Lemurda4b6c62020-02-13 00:28:40 +0000487class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100488 def setUp(self):
489 super(GitCookiesCheckerTest, self).setUp()
490 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100491 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000492 mock.patch('sys.stdout', StringIO()).start()
493 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100494
495 def mock_hosts_creds(self, subhost_identity_pairs):
496 def ensure_googlesource(h):
497 if not h.endswith(self.c._GOOGLESOURCE):
498 assert not h.endswith('.')
499 return h + '.' + self.c._GOOGLESOURCE
500 return h
501 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
502 for h, i in subhost_identity_pairs]
503
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200504 def test_identity_parsing(self):
505 self.assertEqual(self.c._parse_identity('ldap.google.com'),
506 ('ldap', 'google.com'))
507 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
508 ('ldap', 'example.com'))
509 # Specical case because we know there are no subdomains in chromium.org.
510 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
511 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800512 # Pathological: ".period." can be either username OR domain, more likely
513 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200514 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
515 ('note', 'period.example.com'))
516
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100517 def test_analysis_nothing(self):
518 self.c._all_hosts = []
519 self.assertFalse(self.c.has_generic_host())
520 self.assertEqual(set(), self.c.get_conflicting_hosts())
521 self.assertEqual(set(), self.c.get_duplicated_hosts())
522 self.assertEqual(set(), self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100523
524 def test_analysis(self):
525 self.mock_hosts_creds([
526 ('.googlesource.com', 'git-example.chromium.org'),
527
528 ('chromium', 'git-example.google.com'),
529 ('chromium-review', 'git-example.google.com'),
530 ('chrome-internal', 'git-example.chromium.org'),
531 ('chrome-internal-review', 'git-example.chromium.org'),
532 ('conflict', 'git-example.google.com'),
533 ('conflict-review', 'git-example.chromium.org'),
534 ('dup', 'git-example.google.com'),
535 ('dup', 'git-example.google.com'),
536 ('dup-review', 'git-example.google.com'),
537 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200538 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100539 ])
540 self.assertTrue(self.c.has_generic_host())
541 self.assertEqual(set(['conflict.googlesource.com']),
542 self.c.get_conflicting_hosts())
543 self.assertEqual(set(['dup.googlesource.com']),
544 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200545 self.assertEqual(set(['partial.googlesource.com',
546 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100547 self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100548
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100549 def test_report_no_problems(self):
550 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100551 self.assertFalse(self.c.find_and_report_problems())
552 self.assertEqual(sys.stdout.getvalue(), '')
553
Edward Lemurda4b6c62020-02-13 00:28:40 +0000554 @mock.patch(
555 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000556 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000557 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100558 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100559 self.assertTrue(self.c.find_and_report_problems())
560 with open(os.path.join(os.path.dirname(__file__),
561 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000562 expected = f.read() % {
563 'sep': os.sep,
564 }
565
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100566 def by_line(text):
567 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700568 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200569 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100570
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800571
Edward Lemurda4b6c62020-02-13 00:28:40 +0000572class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000573 def setUp(self):
574 super(TestGitCl, self).setUp()
575 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700576 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000577 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000578 mock.patch('sys.stdout', StringIO()).start()
579 mock.patch(
580 'git_cl.time_time',
581 lambda: self._mocked_call('time.time')).start()
582 mock.patch(
583 'git_cl.metrics.collector.add_repeated',
584 lambda *a: self._mocked_call('add_repeated', *a)).start()
585 mock.patch('subprocess2.call', self._mocked_call).start()
586 mock.patch('subprocess2.check_call', self._mocked_call).start()
587 mock.patch('subprocess2.check_output', self._mocked_call).start()
588 mock.patch(
589 'subprocess2.communicate',
590 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
591 mock.patch(
592 'git_cl.gclient_utils.CheckCallAndFilter',
593 self._mocked_call).start()
594 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000595 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
596 mock.patch(
597 'git_cl.SaveDescriptionBackup',
598 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
599 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000600 'git_cl.write_json',
601 lambda *a: self._mocked_call('write_json', *a)).start()
602 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000603 'git_cl.Changelist.RunHook',
604 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000605 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
606 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000607 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000608 mock.patch(
609 'git_cl.gerrit_util.GetChangeComments',
610 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
611 mock.patch(
612 'git_cl.gerrit_util.GetChangeRobotComments',
613 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
614 mock.patch(
615 'git_cl.gerrit_util.AddReviewers',
616 lambda *a: self._mocked_call('AddReviewers', *a)).start()
617 mock.patch(
618 'git_cl.gerrit_util.SetReview',
619 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
620 self._mocked_call(
621 'SetReview', h, i, msg, labels, notify, ready))).start()
622 mock.patch(
623 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
624 return_value=False).start()
625 mock.patch(
626 'git_cl.gerrit_util.GceAuthenticator.is_gce',
627 return_value=False).start()
628 mock.patch(
629 'git_cl.gerrit_util.ValidAccounts',
630 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000631 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000632 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000633 self.mockGit = GitMocks()
634 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
635 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
Edward Lesmes50da7702020-03-30 19:23:43 +0000636 mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
637 mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
Edward Lemur85153282020-02-14 22:06:29 +0000638 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000639 mock.patch(
640 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000641 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000642 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000643 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000644 mock.patch(
645 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000646 # It's important to reset settings to not have inter-tests interference.
647 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000648 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000649
650 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000651 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000652 if not self.failed:
653 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100654 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000655 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
656 if len(self.calls) > 5:
657 calls += ' ...\n'
658 self.fail(
659 '\n'
660 'There are un-consumed calls after this test has finished:\n' +
661 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000662 finally:
663 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000664
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000665 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000666 self.assertTrue(
667 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700668 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000669 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000670 expected_args, result = top
671
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000672 # Also logs otherwise it could get caught in a try/finally and be hard to
673 # diagnose.
674 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700675 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000676 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700677 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
678 for i, c in enumerate(self._calls_done[-N:]))
679 following_calls = '\n '.join(
680 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
681 for i, c in enumerate(self.calls[:N]))
682 extended_msg = (
683 'A few prior calls:\n %s\n\n'
684 'This (expected):\n @%d: %r\n'
685 'This (actual):\n @%d: %r\n\n'
686 'A few following expected calls:\n %s' %
687 (prior_calls, len(self._calls_done), expected_args,
688 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700689
Edward Lesmes0dd54822020-03-26 18:24:25 +0000690 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700691 self.fail('@%d\n'
692 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000693 ' Actual: %r\n'
694 '\n'
695 '%s' % (
696 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700697
698 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700699 if isinstance(result, Exception):
700 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000701 # stdout from git commands is supposed to be a bytestream. Convert it here
702 # instead of converting all test output in this file to bytes.
703 if args[0][0] == 'git' and not isinstance(result, bytes):
704 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000705 return result
706
Edward Lemur1a83da12020-03-04 21:18:36 +0000707 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
708 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100709 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100710 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000711 self.assertEqual(
712 'prompt [Yes/No]: Please, type yes or no: ',
713 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100714
tandrii48df5812016-10-17 03:55:37 -0700715 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000716 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700717 self.calls = [
718 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700719 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
720 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
721 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
722 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700723 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
724 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700725 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
726 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000727 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
728 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700729 ((['git', 'config', 'gerrit.host', 'true'],), ''),
730 ]
731 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
732
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000733 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100734 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200735 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000736 custom_cl_base=None, short_hostname='chromium',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000737 change_id=None, default_branch='master'):
Edward Lemur26964072020-02-19 19:18:51 +0000738 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200739 if custom_cl_base:
740 ancestor_revision = custom_cl_base
741 else:
742 # Determine ancestor_revision to be merge base.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000743 ancestor_revision = 'origin/' + default_branch
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200744
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100745 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000746 gerrit_util.GetChangeDetail.return_value = {
747 'owner': {'email': (other_cl_owner or 'owner@example.com')},
748 'change_id': (change_id or '123456789'),
749 'current_revision': 'sha1_of_current_revision',
750 'revisions': {'sha1_of_current_revision': {
751 'commit': {'message': fetched_description},
752 }},
753 'status': fetched_status or 'NEW',
754 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100755 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100756 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100757 if other_cl_owner:
758 calls += [
759 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
760 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100761
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100762 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200763 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
764 ([custom_cl_base] if custom_cl_base else
765 [ancestor_revision, 'HEAD']),),
766 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100767 ]
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000768 calls += [
769 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000770 '1' if default_branch == 'main' else callError(1)),
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000771 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000772
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100773 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000774
Edward Lemur26964072020-02-19 19:18:51 +0000775 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700776 squash_mode='default',
Aaron Gablefd238082017-06-07 13:42:34 -0700777 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100778 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000779 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000780 short_hostname='chromium',
Edward Lemur5a644f82020-03-18 16:44:57 +0000781 labels=None, change_id=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000782 final_description=None, gitcookies_exists=True,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000783 force=False, edit_description=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000784 default_branch='master'):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000785 if post_amend_description is None:
786 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700787 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200788
789 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000790
Edward Lesmes4de54132020-05-05 19:41:33 +0000791 if squash_mode in ('override_squash', 'override_nosquash'):
792 self.mockGit.config['gerrit.override-squash-uploads'] = (
793 'true' if squash_mode == 'override_squash' else 'false')
794
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000795 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000796 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200797 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200798 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000799 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000800 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000801 calls += [
802 ((['RunEditor'],), description),
803 ]
Josipe827b0f2020-01-30 00:07:20 +0000804 # user wants to edit description
805 if edit_description:
806 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000807 ((['RunEditor'],), edit_description),
808 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000809 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200810
811 if custom_cl_base is None:
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000812 parent = 'origin/' + default_branch
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000813 git_common.get_or_create_merge_base.return_value = parent
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200814 else:
815 calls += [
816 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000817 'refs/remotes/origin/' + default_branch],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200818 callError(1)), # Means not ancenstor.
819 (('ask_for_data',
820 'Do you take responsibility for cleaning up potential mess '
821 'resulting from proceeding with upload? Press Enter to upload, '
822 'or Ctrl+C to abort'), ''),
823 ]
824 parent = custom_cl_base
825
826 calls += [
827 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
828 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000829 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200830 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000831 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200832 ref_to_push),
833 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000834 else:
835 ref_to_push = 'HEAD'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000836 parent = 'origin/refs/heads/' + default_branch
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000837
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000838 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000839 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000840 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200841 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000842
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000843 metrics_arguments = []
844
Aaron Gableafd52772017-06-27 16:40:10 -0700845 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700846 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000847 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700848 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400849 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700850 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000851 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700852 else:
853 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000854 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800855
Edward Lemur5a644f82020-03-18 16:44:57 +0000856 # If issue is given, then description is fetched from Gerrit instead.
857 if issue is None:
858 if squash:
859 title = 'Initial upload'
860 else:
861 if not title:
862 calls += [
863 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
864 (('ask_for_data', 'Title for patchset []: '), 'User input'),
865 ]
866 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700867 if title:
Edward Lemur5a644f82020-03-18 16:44:57 +0000868 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000869 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000870
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000871 if short_hostname == 'chromium':
Quinten Yearsley925cedb2020-04-13 17:49:39 +0000872 # All reviewers and ccs get into ref_suffix.
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000873 for r in sorted(reviewers):
874 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000875 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000876 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000877 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000878 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000879 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000880 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000881 reviewers, cc = [], []
882 else:
883 # TODO(crbug/877717): remove this case.
884 calls += [
885 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
886 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000887 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000888 {
889 e: {'email': e}
890 for e in (reviewers + ['joe@example.com'] + cc)
891 })
892 ]
893 for r in sorted(reviewers):
894 if r != 'bad-account-or-email':
895 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000896 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000897 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000898 if issue is None:
899 cc += ['joe@example.com']
900 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000901 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000902 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000903 if c in cc:
904 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000905
Edward Lemur687ca902018-12-05 02:30:30 +0000906 for k, v in sorted((labels or {}).items()):
907 ref_suffix += ',l=%s+%d' % (k, v)
908 metrics_arguments.append('l=%s+%d' % (k, v))
909
910 if tbr:
911 calls += [
912 (('GetCodeReviewTbrScore',
913 '%s-review.googlesource.com' % short_hostname,
914 'my/repo'),
915 2,),
916 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000917
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000918 calls += [
919 (('time.time',), 1000,),
920 ((['git', 'push',
921 'https://%s.googlesource.com/my/repo' % short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000922 ref_to_push + ':refs/for/refs/heads/' + default_branch + ref_suffix],),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000923 (('remote:\n'
924 'remote: Processing changes: (\)\n'
925 'remote: Processing changes: (|)\n'
926 'remote: Processing changes: (/)\n'
927 'remote: Processing changes: (-)\n'
928 'remote: Processing changes: new: 1 (/)\n'
929 'remote: Processing changes: new: 1, done\n'
930 'remote:\n'
931 'remote: New Changes:\n'
932 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
933 ' XXX\n'
934 'remote:\n'
935 'To https://%s.googlesource.com/my/repo\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000936 ' * [new branch] hhhh -> refs/for/refs/heads/%s\n'
937 ) % (short_hostname, short_hostname, default_branch)),),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000938 (('time.time',), 2000,),
939 (('add_repeated',
940 'sub_commands',
941 {
942 'execution_time': 1000,
943 'command': 'git push',
944 'exit_code': 0,
945 'arguments': sorted(metrics_arguments),
946 }),
947 None,),
948 ]
949
Edward Lemur1b52d872019-05-09 21:12:12 +0000950 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000951
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000952 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
953
Edward Lemur1b52d872019-05-09 21:12:12 +0000954 # Trace-related calls
955 calls += [
956 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000957 (
958 ([
959 'FileWrite', trace_name + '-README',
960 '%(date)s\n'
961 '%(short_hostname)s-review.googlesource.com\n'
962 '%(change_id)s\n'
963 '%(title)s\n'
964 '%(description)s\n'
965 '1000\n'
966 '0\n'
967 '%(trace_name)s' % {
Josip Sokcevic5e18b602020-04-23 21:47:00 +0000968 'date': '2017-03-16T20:00:41.000000',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000969 'short_hostname': short_hostname,
970 'change_id': change_id,
971 'description': final_description,
972 'title': title or '<untitled>',
973 'trace_name': trace_name,
974 }
975 ], ),
976 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000977 ),
978 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000979 (
980 (['os.path.isfile',
981 os.path.join('TEMP_DIR', 'trace-packet')], ),
982 True,
Edward Lemur1b52d872019-05-09 21:12:12 +0000983 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000984 (
985 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
986 ('git-hash: 0123456789012345678901234567890123456789\n'
987 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +0000988 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000989 (
990 ([
991 'FileWrite',
992 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
993 'git-hash: abcdea\n'
994 ], ),
995 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000996 ),
997 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000998 (
999 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
1000 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001001 ),
1002 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001003 (
1004 (['git', 'config', '-l'], ),
1005 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +00001006 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001007 (
1008 ([
1009 'FileWrite',
1010 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
1011 ], ),
1012 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001013 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001014 (
1015 (['os.path.isfile',
1016 os.path.join('~', '.gitcookies')], ),
1017 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +00001018 ),
1019 ]
1020 if gitcookies_exists:
1021 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001022 (
1023 (['FileRead', os.path.join('~', '.gitcookies')], ),
1024 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +00001025 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001026 (
1027 ([
1028 'FileWrite',
1029 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
1030 ], ),
1031 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001032 ),
1033 ]
1034 calls += [
1035 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001036 (
1037 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
1038 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001039 ),
1040 ]
1041
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001042 # TODO(crbug/877717): this should never be used.
1043 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001044 calls += [
1045 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001046 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001047 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001048 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001049 notify),
1050 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001051 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001052 return calls
1053
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001054 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001055 self,
1056 upload_args,
1057 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001058 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001059 squash=True,
1060 squash_mode=None,
Aaron Gable9b713dd2016-12-14 16:04:21 -08001061 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001062 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001063 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001064 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001065 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001066 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001067 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001068 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001069 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001070 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001071 labels=None,
1072 change_id=None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001073 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001074 gitcookies_exists=True,
1075 force=False,
Edward Lesmes0dd54822020-03-26 18:24:25 +00001076 log_description=None,
Josipe827b0f2020-01-30 00:07:20 +00001077 edit_description=None,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001078 fetched_description=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001079 default_branch='master'):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001080 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001081 if squash_mode is None:
1082 if '--no-squash' in upload_args:
1083 squash_mode = 'nosquash'
1084 elif '--squash' in upload_args:
1085 squash_mode = 'squash'
1086 else:
1087 squash_mode = 'default'
1088
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001089 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001090 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001091 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001092 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001093 same_auth=('git-owner.example.com', '', 'pass'))).start()
1094 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1095 lambda _, offer_removal: None).start()
1096 mock.patch('git_cl.gclient_utils.RunEditor',
1097 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1098 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001099 'DownloadGerritHook', force)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001100 mock.patch('git_cl.gclient_utils.FileRead',
1101 lambda path: self._mocked_call(['FileRead', path])).start()
1102 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001103 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001104 ['FileWrite', path, contents])).start()
1105 mock.patch('git_cl.datetime_now',
1106 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1107 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1108 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1109 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001110 '%(now)s\n'
1111 '%(gerrit_host)s\n'
1112 '%(change_id)s\n'
1113 '%(title)s\n'
1114 '%(description)s\n'
1115 '%(execution_time)s\n'
1116 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001117 '%(trace_name)s').start()
1118 mock.patch('git_cl.shutil.make_archive',
1119 lambda *args: self._mocked_call(['make_archive'] +
1120 list(args))).start()
1121 mock.patch('os.path.isfile',
1122 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001123 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001124 'git_cl._create_description_from_log',
1125 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001126 mock.patch(
1127 'git_cl.Changelist._AddChangeIdToCommitMessage',
1128 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001129 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001130 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1131 mock.patch(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001132 'git_common.get_or_create_merge_base',
1133 return_value='origin/' + default_branch).start()
1134 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001135 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001136 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001137
Edward Lemur26964072020-02-19 19:18:51 +00001138 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001139 self.mockGit.config['branch.master.gerritissue'] = (
1140 str(issue) if issue else None)
1141 self.mockGit.config['remote.origin.url'] = (
1142 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001143 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001144
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001145 self.calls = self._gerrit_base_calls(
1146 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001147 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001148 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001149 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001150 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001151 short_hostname=short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001152 change_id=change_id,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001153 default_branch=default_branch)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001154 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001155 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001156 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001157 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001158 self.calls += self._gerrit_upload_calls(
1159 description, reviewers, squash,
1160 squash_mode=squash_mode,
Aaron Gablefd238082017-06-07 13:42:34 -07001161 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001162 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001163 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001164 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001165 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001166 labels=labels,
1167 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001168 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001169 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001170 force=force,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001171 edit_description=edit_description,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001172 default_branch=default_branch)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001173 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001174 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001175 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001176 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001177 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001178 self.assertEqual(
1179 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001180 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001181
Edward Lemur1b52d872019-05-09 21:12:12 +00001182 def test_gerrit_upload_traces_no_gitcookies(self):
1183 self._run_gerrit_upload_test(
1184 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001185 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001186 [],
1187 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001188 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001189 change_id='Ixxx',
1190 gitcookies_exists=False)
1191
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001192 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001193 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001194 [],
1195 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1196 [],
1197 change_id='Ixxx')
1198
1199 def test_gerrit_upload_without_change_id_nosquash(self):
1200 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001201 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001202 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001203 [],
1204 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001205 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001206 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001207
Edward Lesmes4de54132020-05-05 19:41:33 +00001208 def test_gerrit_upload_without_change_id_override_nosquash(self):
1209 self._run_gerrit_upload_test(
1210 [],
1211 'desc ✔\n\nBUG=\n',
1212 [],
1213 squash=False,
1214 squash_mode='override_nosquash',
1215 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1216 change_id='Ixxx')
1217
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001218 def test_gerrit_no_reviewer(self):
1219 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001220 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001221 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001222 [],
1223 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001224 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001225 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001226
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001227 def test_gerrit_no_reviewer_non_chromium_host(self):
1228 # TODO(crbug/877717): remove this test case.
1229 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001230 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001231 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001232 [],
1233 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001234 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001235 short_hostname='other',
1236 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001237
Edward Lesmes0dd54822020-03-26 18:24:25 +00001238 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001239 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001240 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001241 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001242 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001243 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001244 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001245 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001246
ukai@chromium.orge8077812012-02-03 03:41:46 +00001247 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001248 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001249 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001250 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001251 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001252 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001253 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001254 notify=True,
1255 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001256 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001257 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001258
Anthony Polito8b955342019-09-24 19:01:36 +00001259 def test_gerrit_upload_force_sets_bug(self):
1260 self._run_gerrit_upload_test(
1261 ['-b', '10000', '-f'],
1262 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1263 [],
1264 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001265 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001266 change_id='Ixxx')
1267
Edward Lemur5fb22242020-03-12 22:05:13 +00001268 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001269 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001270 ['-b', '10000', '-m', 'Title', '--edit-description'],
1271 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001272 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001273 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001274 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001275 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001276 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001277 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001278
Dan Beamd8b04ca2019-10-10 21:23:26 +00001279 def test_gerrit_upload_force_sets_fixed(self):
1280 self._run_gerrit_upload_test(
1281 ['-x', '10000', '-f'],
1282 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1283 [],
1284 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001285 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001286 change_id='Ixxx')
1287
ukai@chromium.orge8077812012-02-03 03:41:46 +00001288 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001289 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1290 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001291 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001292 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001293 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001294 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001295 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001296 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001297 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001298 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001299 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001300 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001301
1302 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001303 self._run_gerrit_upload_test(
1304 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001305 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001306 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001307 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001308
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001309 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001310 self._run_gerrit_upload_test(
1311 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001312 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001313 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001314 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001315 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001316
Edward Lesmes0dd54822020-03-26 18:24:25 +00001317 def test_gerrit_upload_squash_first_title(self):
1318 self._run_gerrit_upload_test(
1319 ['-f', '-t', 'title'],
1320 'title\n\ndesc\n\nChange-Id: 123456789',
1321 [],
1322 force=True,
1323 squash=True,
1324 log_description='desc',
1325 change_id='123456789')
1326
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001327 def test_gerrit_upload_squash_first_with_labels(self):
1328 self._run_gerrit_upload_test(
1329 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001330 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001331 [],
1332 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001333 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001334 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001335
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001336 def test_gerrit_upload_squash_first_against_rev(self):
1337 custom_cl_base = 'custom_cl_base_rev_or_branch'
1338 self._run_gerrit_upload_test(
1339 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001340 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001341 [],
1342 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001343 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001344 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001345 self.assertIn(
1346 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1347 sys.stdout.getvalue())
1348
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001349 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001350 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001351 self._run_gerrit_upload_test(
1352 ['--squash'],
1353 description,
1354 [],
1355 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001356 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001357 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001358
Edward Lemurd55c5072020-02-20 01:09:07 +00001359 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001360 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001361 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001362 with self.assertRaises(SystemExitMock):
1363 self._run_gerrit_upload_test(
1364 ['--squash'],
1365 description,
1366 [],
1367 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001368 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001369 fetched_status='ABANDONED',
1370 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001371 self.assertEqual(
1372 'Change https://chromium-review.googlesource.com/123456 has been '
1373 'abandoned, new uploads are not allowed\n',
1374 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001375
Edward Lemurda4b6c62020-02-13 00:28:40 +00001376 @mock.patch(
1377 'gerrit_util.GetAccountDetails',
1378 return_value={'email': 'yet-another@example.com'})
1379 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001380 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001381 self._run_gerrit_upload_test(
1382 ['--squash'],
1383 description,
1384 [],
1385 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001386 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001387 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001388 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001389 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001390 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001391 'authenticate to Gerrit as yet-another@example.com.\n'
1392 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001393 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001394
Josipe827b0f2020-01-30 00:07:20 +00001395 def test_upload_change_description_editor(self):
1396 fetched_description = 'foo\n\nChange-Id: 123456789'
1397 description = 'bar\n\nChange-Id: 123456789'
1398 self._run_gerrit_upload_test(
1399 ['--squash', '--edit-description'],
1400 description,
1401 [],
1402 fetched_description=fetched_description,
1403 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001404 issue=123456,
1405 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001406 edit_description=description)
1407
Edward Lemurda4b6c62020-02-13 00:28:40 +00001408 @mock.patch('git_cl.RunGit')
1409 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001410 @mock.patch('sys.stdin', StringIO('\n'))
1411 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001412 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001413 def mock_run_git(*args, **_kwargs):
1414 if args[0] == ['for-each-ref',
1415 '--format=%(refname:short) %(upstream:short)',
1416 'refs/heads']:
1417 # Create a local branch dependency tree that looks like this:
1418 # test1 -> test2 -> test3 -> test4 -> test5
1419 # -> test3.1
1420 # test6 -> test0
1421 branch_deps = [
1422 'test2 test1', # test1 -> test2
1423 'test3 test2', # test2 -> test3
1424 'test3.1 test2', # test2 -> test3.1
1425 'test4 test3', # test3 -> test4
1426 'test5 test4', # test4 -> test5
1427 'test6 test0', # test0 -> test6
1428 'test7', # test7
1429 ]
1430 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001431 git_cl.RunGit.side_effect = mock_run_git
1432 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001433
1434 class MockChangelist():
1435 def __init__(self):
1436 pass
1437 def GetBranch(self):
1438 return 'test1'
1439 def GetIssue(self):
1440 return '123'
1441 def GetPatchset(self):
1442 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001443 def IsGerrit(self):
1444 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001445
1446 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1447 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001448 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001449 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001450 'This command will checkout all dependent branches '
1451 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001452 'or Ctrl+C to abort',
1453 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001454 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001455
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001456 def test_gerrit_change_id(self):
1457 self.calls = [
1458 ((['git', 'write-tree'], ),
1459 'hashtree'),
1460 ((['git', 'rev-parse', 'HEAD~0'], ),
1461 'branch-parent'),
1462 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1463 'A B <a@b.org> 1456848326 +0100'),
1464 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1465 'C D <c@d.org> 1456858326 +0100'),
1466 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1467 'hashchange'),
1468 ]
1469 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1470 self.assertEqual(change_id, 'Ihashchange')
1471
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001472 @mock.patch('git_cl.Settings.GetBugPrefix')
1473 @mock.patch('git_cl.Settings.GetRoot')
1474 @mock.patch('git_cl.Changelist.FetchDescription')
1475 @mock.patch('git_cl.Changelist.GetBranch')
1476 @mock.patch('git_cl.Changelist.GetCommonAncestorWithUpstream')
1477 @mock.patch('owners_client.OwnersClient.BatchListOwners')
1478 def getDescriptionForUploadTest(
1479 self, mockBatchListOwners=None, mockGetCommonAncestorWithUpstream=None,
1480 mockGetBranch=None, mockFetchDescription=None, mockGetRoot=None,
1481 mockGetBugPrefix=None,
1482 initial_description='desc', bug=None, fixed=None, branch='branch',
1483 reviewers=None, tbrs=None, add_owners_to=None,
1484 expected_description='desc'):
1485 reviewers = reviewers or []
1486 tbrs = tbrs or []
1487 owners_by_path = {
1488 'a': ['a@example.com'],
1489 'b': ['b@example.com'],
1490 'c': ['c@example.com'],
1491 }
1492 mockGetRoot.return_value = 'root'
1493 mockGetBranch.return_value = branch
1494 mockGetBugPrefix.return_value = 'prefix'
1495 mockGetCommonAncestorWithUpstream.return_value = 'upstream'
1496 mockFetchDescription.return_value = 'desc'
1497 mockBatchListOwners.side_effect = lambda ps: {
1498 p: owners_by_path.get(p)
1499 for p in ps
1500 }
1501
1502 cl = git_cl.Changelist(issue=1234)
1503 actual = cl._GetDescriptionForUpload(
1504 options=mock.Mock(
1505 bug=bug,
1506 fixed=fixed,
1507 reviewers=reviewers,
1508 tbrs=tbrs,
1509 add_owners_to=add_owners_to),
1510 git_diff_args=None,
1511 files=list(owners_by_path))
1512 self.assertEqual(expected_description, actual.description)
1513
1514 def testGetDescriptionForUpload(self):
1515 self.getDescriptionForUploadTest()
1516
1517 def testGetDescriptionForUpload_Bug(self):
1518 self.getDescriptionForUploadTest(
1519 bug='1234',
1520 expected_description='\n'.join([
1521 'desc',
1522 '',
1523 'Bug: prefix:1234',
1524 ]))
1525
1526 def testGetDescriptionForUpload_Fixed(self):
1527 self.getDescriptionForUploadTest(
1528 fixed='1234',
1529 expected_description='\n'.join([
1530 'desc',
1531 '',
1532 'Fixed: prefix:1234',
1533 ]))
1534
1535
1536 def testGetDescriptionForUpload_BugFromBranch(self):
1537 self.getDescriptionForUploadTest(
1538 branch='bug-1234',
1539 expected_description='\n'.join([
1540 'desc',
1541 '',
1542 'Bug: prefix:1234',
1543 ]))
1544
1545 def testGetDescriptionForUpload_FixedFromBranch(self):
1546 self.getDescriptionForUploadTest(
1547 branch='fix-1234',
1548 expected_description='\n'.join([
1549 'desc',
1550 '',
1551 'Fixed: prefix:1234',
1552 ]))
1553
1554 def testGetDescriptionForUpload_AddOwnersToR(self):
1555 self.getDescriptionForUploadTest(
1556 reviewers=['a@example.com'],
1557 tbrs=['b@example.com'],
1558 add_owners_to='R',
1559 expected_description='\n'.join([
1560 'desc',
1561 '',
1562 'R=a@example.com, c@example.com',
1563 'TBR=b@example.com',
1564 ]))
1565
1566 def testGetDescriptionForUpload_AddOwnersToTBR(self):
1567 self.getDescriptionForUploadTest(
1568 reviewers=['a@example.com'],
1569 tbrs=['b@example.com'],
1570 add_owners_to='TBR',
1571 expected_description='\n'.join([
1572 'desc',
1573 '',
1574 'R=a@example.com',
1575 'TBR=b@example.com, c@example.com',
1576 ]))
1577
1578 def testGetDescriptionForUpload_AddOwnersToNoOwnersNeeded(self):
1579 self.getDescriptionForUploadTest(
1580 reviewers=['a@example.com', 'c@example.com'],
1581 tbrs=['b@example.com'],
1582 add_owners_to='TBR',
1583 expected_description='\n'.join([
1584 'desc',
1585 '',
1586 'R=a@example.com, c@example.com',
1587 'TBR=b@example.com',
1588 ]))
1589
1590 def testGetDescriptionForUpload_Reviewers(self):
1591 self.getDescriptionForUploadTest(
1592 reviewers=['a@example.com', 'b@example.com'],
1593 expected_description='\n'.join([
1594 'desc',
1595 '',
1596 'R=a@example.com, b@example.com',
1597 ]))
1598
1599 def testGetDescriptionForUpload_TBRs(self):
1600 self.getDescriptionForUploadTest(
1601 tbrs=['a@example.com', 'b@example.com'],
1602 expected_description='\n'.join([
1603 'desc',
1604 '',
1605 'TBR=a@example.com, b@example.com',
1606 ]))
1607
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001608 def test_desecription_append_footer(self):
1609 for init_desc, footer_line, expected_desc in [
1610 # Use unique desc first lines for easy test failure identification.
1611 ('foo', 'R=one', 'foo\n\nR=one'),
1612 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1613 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1614 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1615 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1616 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1617 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1618 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1619 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1620 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1621 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1622 ]:
1623 desc = git_cl.ChangeDescription(init_desc)
1624 desc.append_footer(footer_line)
1625 self.assertEqual(desc.description, expected_desc)
1626
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001627 def test_update_reviewers(self):
1628 data = [
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001629 ('foo', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001630 'foo'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001631 ('foo\nR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001632 'foo\nR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001633 ('foo\nTBR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001634 'foo\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001635 ('foo', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001636 'foo\n\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001637 ('foo\nR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001638 'foo\n\nR=a@c, xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001639 ('foo\nTBR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001640 'foo\n\nR=a@c\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001641 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001642 'foo\n\nR=a@c, yy\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001643 ('foo\nBUG=', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001644 'foo\nBUG=\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001645 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001646 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001647 ('foo', ['a@c', 'b@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001648 'foo\n\nR=a@c, b@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001649 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001650 'foo\nBar\n\nR=c@c\nBUG='),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001651 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001652 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001653 # Same as the line before, but full of whitespaces.
1654 (
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001655 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001656 'foo\nBar\n\nR=c@c\n BUG =',
1657 ),
1658 # Whitespaces aren't interpreted as new lines.
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001659 ('foo BUG=allo R=joe ', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001660 'foo BUG=allo R=joe\n\nR=c@c'),
1661 # Redundant TBRs get promoted to Rs
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001662 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001663 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001664 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001665 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001666 actual = []
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001667 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001668 obj = git_cl.ChangeDescription(orig)
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001669 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001670 actual.append(obj.description)
1671 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001672
Nodir Turakulov23b82142017-11-16 11:04:25 -08001673 def test_get_hash_tags(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001674 self.calls = [
1675 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
1676 callError(1)),
1677 ] * 9
Nodir Turakulov23b82142017-11-16 11:04:25 -08001678 cases = [
1679 ('', []),
1680 ('a', []),
1681 ('[a]', ['a']),
1682 ('[aa]', ['aa']),
1683 ('[a ]', ['a']),
1684 ('[a- ]', ['a']),
1685 ('[a- b]', ['a-b']),
1686 ('[a--b]', ['a-b']),
1687 ('[a', []),
1688 ('[a]x', ['a']),
1689 ('[aa]x', ['aa']),
1690 ('[a b]', ['a-b']),
1691 ('[a b]', ['a-b']),
1692 ('[a__b]', ['a-b']),
1693 ('[a] x', ['a']),
1694 ('[a][b]', ['a', 'b']),
1695 ('[a] [b]', ['a', 'b']),
1696 ('[a][b]x', ['a', 'b']),
1697 ('[a][b] x', ['a', 'b']),
1698 ('[a]\n[b]', ['a']),
1699 ('[a\nb]', []),
1700 ('[a][', ['a']),
1701 ('Revert "[a] feature"', ['a']),
1702 ('Reland "[a] feature"', ['a']),
1703 ('Revert: [a] feature', ['a']),
1704 ('Reland: [a] feature', ['a']),
1705 ('Revert "Reland: [a] feature"', ['a']),
1706 ('Foo: feature', ['foo']),
1707 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001708 ('Change Foo::Bar', []),
1709 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001710 ('Revert "Foo bar: feature"', ['foo-bar']),
1711 ('Reland "Foo bar: feature"', ['foo-bar']),
1712 ]
1713 for desc, expected in cases:
1714 change_desc = git_cl.ChangeDescription(desc)
1715 actual = change_desc.get_hash_tags()
1716 self.assertEqual(
1717 actual,
1718 expected,
1719 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1720
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001721 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001722 self.assertEqual(None, git_cl.GetTargetRef(None,
1723 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001724 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001725
wittman@chromium.org455dc922015-01-26 20:15:50 +00001726 # Check default target refs for branches.
1727 self.assertEqual('refs/heads/master',
1728 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001729 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001730 self.assertEqual('refs/heads/master',
1731 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001732 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001733 self.assertEqual('refs/heads/master',
1734 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001735 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001736 self.assertEqual('refs/branch-heads/123',
1737 git_cl.GetTargetRef('origin',
1738 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001739 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001740 self.assertEqual('refs/diff/test',
1741 git_cl.GetTargetRef('origin',
1742 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001743 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001744 self.assertEqual('refs/heads/chrome/m42',
1745 git_cl.GetTargetRef('origin',
1746 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001747 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001748
1749 # Check target refs for user-specified target branch.
1750 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1751 'refs/remotes/branch-heads/123'):
1752 self.assertEqual('refs/branch-heads/123',
1753 git_cl.GetTargetRef('origin',
1754 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001755 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001756 for branch in ('origin/master', 'remotes/origin/master',
1757 'refs/remotes/origin/master'):
1758 self.assertEqual('refs/heads/master',
1759 git_cl.GetTargetRef('origin',
1760 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001761 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001762 for branch in ('master', 'heads/master', 'refs/heads/master'):
1763 self.assertEqual('refs/heads/master',
1764 git_cl.GetTargetRef('origin',
1765 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001766 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001767
Edward Lemurda4b6c62020-02-13 00:28:40 +00001768 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1769 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001770 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001771 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1772
Edward Lemur85153282020-02-14 22:06:29 +00001773 def assertIssueAndPatchset(
1774 self, branch='master', issue='123456', patchset='7',
1775 git_short_host='chromium'):
1776 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001777 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001778 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001779 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001780 self.assertEqual(
1781 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001782 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001783
Edward Lemur85153282020-02-14 22:06:29 +00001784 def _patch_common(self, git_short_host='chromium'):
Edward Lesmes50da7702020-03-30 19:23:43 +00001785 mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
Edward Lemur26964072020-02-19 19:18:51 +00001786 self.mockGit.config['remote.origin.url'] = (
1787 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001788 gerrit_util.GetChangeDetail.return_value = {
1789 'current_revision': '7777777777',
1790 'revisions': {
1791 '1111111111': {
1792 '_number': 1,
1793 'fetch': {'http': {
1794 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1795 'ref': 'refs/changes/56/123456/1',
1796 }},
1797 },
1798 '7777777777': {
1799 '_number': 7,
1800 'fetch': {'http': {
1801 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1802 'ref': 'refs/changes/56/123456/7',
1803 }},
1804 },
1805 },
1806 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001807
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001808 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001809 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001810 self.calls += [
1811 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1812 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001813 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001814 ]
1815 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001816 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001817
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001818 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001819 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001820 self.calls += [
1821 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1822 'refs/changes/56/123456/7'],), ''),
1823 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001824 ]
Edward Lemur85153282020-02-14 22:06:29 +00001825 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1826 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001827
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001828 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001829 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001830 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001831 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001832 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001833 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001834 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001835 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001836 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001837
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001838 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001839 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001840 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001841 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001842 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001843 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001844 ]
1845 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001846 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001847 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001848
Aaron Gable697a91b2018-01-19 15:20:15 -08001849 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001850 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001851 self.calls += [
1852 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1853 'refs/changes/56/123456/1'],), ''),
1854 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001855 ]
1856 self.assertEqual(git_cl.main(
1857 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1858 0)
Edward Lemur85153282020-02-14 22:06:29 +00001859 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001860
Edward Lemurd55c5072020-02-20 01:09:07 +00001861 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001862 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001863 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001864 self.calls += [
1865 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001866 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001867 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001868 ]
1869 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001870 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001871 self.assertEqual(
1872 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1873 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001874
Edward Lemurda4b6c62020-02-13 00:28:40 +00001875 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001876 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001877 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001878 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001879 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001880 self.mockGit.config['remote.origin.url'] = (
1881 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001882 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001883 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001884 self.assertEqual(
1885 'change 123456 at https://chromium-review.googlesource.com does not '
1886 'exist or you have no access to it\n',
1887 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001888
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001889 def _checkout_calls(self):
1890 return [
1891 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001892 'branch\\..*\\.gerritissue'], ),
1893 ('branch.ger-branch.gerritissue 123456\n'
1894 'branch.gbranch654.gerritissue 654321\n')),
1895 ]
1896
1897 def test_checkout_gerrit(self):
1898 """Tests git cl checkout <issue>."""
1899 self.calls = self._checkout_calls()
1900 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1901 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1902
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001903 def test_checkout_not_found(self):
1904 """Tests git cl checkout <issue>."""
1905 self.calls = self._checkout_calls()
1906 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1907
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001908 def test_checkout_no_branch_issues(self):
1909 """Tests git cl checkout <issue>."""
1910 self.calls = [
1911 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001912 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001913 ]
1914 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1915
Edward Lemur26964072020-02-19 19:18:51 +00001916 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00001917 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001918 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001919 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001920 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1921 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001922 self.mockGit.config['remote.origin.url'] = (
1923 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001924 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001925 cl.branch = 'master'
1926 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001927 return cl
1928
Edward Lemurd55c5072020-02-20 01:09:07 +00001929 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001930 def test_gerrit_ensure_authenticated_missing(self):
1931 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001932 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001933 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001934 with self.assertRaises(SystemExitMock):
1935 cl.EnsureAuthenticated(force=False)
1936 self.assertEqual(
1937 'Credentials for the following hosts are required:\n'
1938 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001939 'These are read from ~%(sep)s.gitcookies '
1940 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00001941 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001942 'https://chromium-review.googlesource.com/new-password\n' % {
1943 'sep': os.sep,
1944 'netrc': NETRC_FILENAME,
1945 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001946
1947 def test_gerrit_ensure_authenticated_conflict(self):
1948 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001949 'chromium.googlesource.com':
1950 ('git-one.example.com', None, 'secret1'),
1951 'chromium-review.googlesource.com':
1952 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001953 })
1954 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001955 (('ask_for_data', 'If you know what you are doing '
1956 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001957 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1958
1959 def test_gerrit_ensure_authenticated_ok(self):
1960 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001961 'chromium.googlesource.com':
1962 ('git-same.example.com', None, 'secret'),
1963 'chromium-review.googlesource.com':
1964 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001965 })
1966 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1967
tandrii@chromium.org28253532016-04-14 13:46:56 +00001968 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00001969 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
1970 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00001971 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1972
Eric Boren2fb63102018-10-05 13:05:03 +00001973 def test_gerrit_ensure_authenticated_bearer_token(self):
1974 cl = self._test_gerrit_ensure_authenticated_common(auth={
1975 'chromium.googlesource.com':
1976 ('', None, 'secret'),
1977 'chromium-review.googlesource.com':
1978 ('', None, 'secret'),
1979 })
1980 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1981 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1982 'chromium.googlesource.com')
1983 self.assertTrue('Bearer' in header)
1984
Daniel Chengcf6269b2019-05-18 01:02:12 +00001985 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00001986 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00001987 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001988 (('logging.warning',
1989 'Ignoring branch %(branch)s with non-https remote '
1990 '%(remote)s', {
1991 'branch': 'master',
1992 'remote': 'custom-scheme://repo'}
1993 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001994 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001995 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1996 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1997 mock.patch('logging.warning',
1998 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00001999 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002000 cl.branch = 'master'
2001 cl.branchref = 'refs/heads/master'
2002 cl.lookedup_issue = True
2003 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2004
Florian Mayerae510e82020-01-30 21:04:48 +00002005 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00002006 self.mockGit.config['remote.origin.url'] = (
2007 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00002008 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002009 (('logging.error',
2010 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2011 'but it doesn\'t exist.', {
2012 'remote': 'origin',
2013 'branch': 'master',
2014 'url': 'git@somehost.example:foo/bar.git'}
2015 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00002016 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002017 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2018 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2019 mock.patch('logging.error',
2020 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00002021 cl = git_cl.Changelist()
2022 cl.branch = 'master'
2023 cl.branchref = 'refs/heads/master'
2024 cl.lookedup_issue = True
2025 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2026
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002027 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00002028 self.mockGit.config['branch.master.gerritissue'] = '123'
2029 self.mockGit.config['branch.master.gerritserver'] = (
2030 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00002031 self.mockGit.config['remote.origin.url'] = (
2032 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002033 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00002034 (('SetReview', 'chromium-review.googlesource.com',
2035 'infra%2Finfra~123', None,
2036 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002037 ]
tandriid9e5ce52016-07-13 02:32:59 -07002038
2039 def test_cmd_set_commit_gerrit_clear(self):
2040 self._cmd_set_commit_gerrit_common(0)
2041 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2042
2043 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002044 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002045 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2046
tandriid9e5ce52016-07-13 02:32:59 -07002047 def test_cmd_set_commit_gerrit(self):
2048 self._cmd_set_commit_gerrit_common(2)
2049 self.assertEqual(0, git_cl.main(['set-commit']))
2050
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002051 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002052 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002053 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002054
2055 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002056 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002057
Edward Lemurda4b6c62020-02-13 00:28:40 +00002058 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07002059 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07002060 try:
2061 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00002062 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00002063 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00002064 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07002065
2066 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07002067 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002068 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002069 return 'foobar'
2070
Edward Lemurda4b6c62020-02-13 00:28:40 +00002071 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07002072 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002073 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002074 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00002075 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07002076
iannuccie53c9352016-08-17 14:40:40 -07002077 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002078
iannuccie53c9352016-08-17 14:40:40 -07002079 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002080 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002081 return 'foobar'
2082
Edward Lemurda4b6c62020-02-13 00:28:40 +00002083 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2084 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002085 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002086 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002087
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002088 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00002089 self.mockGit.config['remote.origin.url'] = (
2090 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002091 gerrit_util.GetChangeDetail.return_value = {
2092 'current_revision': 'sha1',
2093 'revisions': {'sha1': {
2094 'commit': {'message': 'foobar'},
2095 }},
2096 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002097 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002098 'description',
2099 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2100 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002101 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002102
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002103 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002104 mock.patch('git_cl.Changelist', ChangelistMock).start()
2105 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002106
2107 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2108 self.assertEqual('hihi', ChangelistMock.desc)
2109
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002110 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002111 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002112
2113 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002114 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002115 '# Enter a description of the change.\n'
2116 '# This will be displayed on the codereview site.\n'
2117 '# The first line will also be used as the subject of the review.\n'
2118 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002119 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002120 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002121 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002122 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002123 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002124
Edward Lemur6c6827c2020-02-06 21:15:18 +00002125 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002126 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002127
Edward Lemurda4b6c62020-02-13 00:28:40 +00002128 mock.patch('git_cl.Changelist.FetchDescription',
2129 lambda *args: current_desc).start()
2130 mock.patch('git_cl.Changelist.UpdateDescription',
2131 UpdateDescription).start()
2132 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002133
Edward Lemur85153282020-02-14 22:06:29 +00002134 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002135 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002136
Dan Beamd8b04ca2019-10-10 21:23:26 +00002137 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2138 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2139
2140 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002141 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002142 '# Enter a description of the change.\n'
2143 '# This will be displayed on the codereview site.\n'
2144 '# The first line will also be used as the subject of the review.\n'
2145 '#--------------------This line is 72 characters long'
2146 '--------------------\n'
2147 'Some.\n\nFixed: 123\nChange-Id: xxx',
2148 desc)
2149 return desc
2150
Edward Lemurda4b6c62020-02-13 00:28:40 +00002151 mock.patch('git_cl.Changelist.FetchDescription',
2152 lambda *args: current_desc).start()
2153 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002154
Edward Lemur85153282020-02-14 22:06:29 +00002155 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002156 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002157
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002158 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002159 mock.patch('git_cl.Changelist', ChangelistMock).start()
2160 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002161
2162 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2163 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2164
kmarshall3bff56b2016-06-06 18:31:47 -07002165 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002166 self.calls = [
2167 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002168 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002169 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002170 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002171 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002172 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002173
Edward Lemurda4b6c62020-02-13 00:28:40 +00002174 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002175 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002176 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2177 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002178 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002179
2180 self.assertEqual(0, git_cl.main(['archive', '-f']))
2181
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002182 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002183 self.calls = [
2184 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2185 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2186 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2187 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002188 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2189 ((['git', 'branch', '-D', 'foo'],), '')
2190 ]
2191
Edward Lemurda4b6c62020-02-13 00:28:40 +00002192 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002193 lambda branches, fine_grained, max_processes:
2194 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2195 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002196 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002197
2198 self.assertEqual(0, git_cl.main(['archive', '-f']))
2199
kmarshall3bff56b2016-06-06 18:31:47 -07002200 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002201 self.calls = [
2202 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2203 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002204 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002205 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002206
Edward Lemurda4b6c62020-02-13 00:28:40 +00002207 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002208 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002209 [(MockChangelistWithBranchAndIssue('master', 1),
2210 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002211
2212 self.assertEqual(1, git_cl.main(['archive', '-f']))
2213
2214 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002215 self.calls = [
2216 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2217 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002218 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002219 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002220
Edward Lemurda4b6c62020-02-13 00:28:40 +00002221 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002222 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002223 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2224 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002225 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002226
kmarshall9249e012016-08-23 12:02:16 -07002227 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2228
2229 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002230 self.calls = [
2231 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2232 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002233 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002234 ((['git', 'branch', '-D', 'foo'],), '')
2235 ]
kmarshall9249e012016-08-23 12:02:16 -07002236
Edward Lemurda4b6c62020-02-13 00:28:40 +00002237 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002238 lambda branches, fine_grained, max_processes:
2239 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2240 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002241 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002242
2243 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002244
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002245 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002246 self.calls = [
2247 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2248 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2249 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002250 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2251 'refs/tags/git-cl-archived-456-foo'),
2252 ((['git', 'branch', '-D', 'foo'],), CERR1),
2253 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2254 'refs/tags/git-cl-archived-456-foo'),
2255 ]
2256
Edward Lemurda4b6c62020-02-13 00:28:40 +00002257 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002258 lambda branches, fine_grained, max_processes:
2259 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2260 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002261 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002262
2263 self.assertEqual(0, git_cl.main(['archive', '-f']))
2264
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002265 def test_archive_with_format(self):
2266 self.calls = [
2267 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
2268 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2269 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2270 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2271 ((['git', 'branch', '-D', 'foo'], ), ''),
2272 ]
2273
2274 mock.patch('git_cl.get_cl_statuses',
2275 lambda branches, fine_grained, max_processes:
2276 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2277
2278 self.assertEqual(
2279 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2280
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002281 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002282 self.mockGit.config['branch.master.gerritissue'] = '123'
2283 self.mockGit.config['branch.master.gerritserver'] = (
2284 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002285 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002286 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002287 ]
2288 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002289 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2290 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002291
Aaron Gable400e9892017-07-12 15:31:21 -07002292 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002293 self.mockGit.config['branch.master.gerritissue'] = '123'
2294 self.mockGit.config['branch.master.gerritserver'] = (
2295 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002296 mock.patch('git_cl.Changelist.FetchDescription',
2297 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002298 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002299 ((['git', 'log', '-1', '--format=%B'],),
2300 'This is a description\n\nChange-Id: Ideadbeef'),
2301 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002302 ]
2303 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002304 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2305 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002306
phajdan.jre328cf92016-08-22 04:12:17 -07002307 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002308 self.mockGit.config['branch.master.gerritissue'] = '123'
2309 self.mockGit.config['branch.master.gerritserver'] = (
2310 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002311 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002312 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002313 {'issue': 123,
2314 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002315 ''),
2316 ]
2317 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2318
tandrii16e0b4e2016-06-07 10:34:28 -07002319 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002320 mock.patch(
2321 'git_cl.os.path.abspath',
2322 lambda path: self._mocked_call(['abspath', path])).start()
2323 mock.patch(
2324 'git_cl.os.path.exists',
2325 lambda path: self._mocked_call(['exists', path])).start()
2326 mock.patch(
2327 'git_cl.gclient_utils.FileRead',
2328 lambda path: self._mocked_call(['FileRead', path])).start()
2329 mock.patch(
2330 'git_cl.gclient_utils.rm_file_or_tree',
2331 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002332 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002333 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002334 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002335 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002336
2337 def test_GerritCommitMsgHookCheck_custom_hook(self):
2338 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002339 self.calls += [((['exists',
2340 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2341 ((['FileRead',
2342 os.path.join('.git', 'hooks', 'commit-msg')], ),
2343 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002344 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002345
2346 def test_GerritCommitMsgHookCheck_not_exists(self):
2347 cl = self._common_GerritCommitMsgHookCheck()
2348 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002349 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002350 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002351 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002352
2353 def test_GerritCommitMsgHookCheck(self):
2354 cl = self._common_GerritCommitMsgHookCheck()
2355 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002356 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2357 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002358 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002359 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002360 ((['rm_file_or_tree',
2361 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002362 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002363 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002364
tandriic4344b52016-08-29 06:04:54 -07002365 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002366 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2367 self.mockGit.config['branch.master.gerritserver'] = (
2368 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002369 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002370 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002371 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002372 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002373 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002374 'labels': {},
2375 'current_revision': 'deadbeaf',
2376 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002377 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002378 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002379 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002380 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2381 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002382 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002383 self.assertEqual(0, cl.CMDLand(force=True,
2384 bypass_hooks=True,
2385 verbose=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002386 parallel=False,
2387 resultdb=False,
2388 realm=None))
Edward Lemur73c76702020-02-06 23:57:18 +00002389 self.assertIn(
2390 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002391 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002392 self.assertIn(
2393 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002394 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002395
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002396 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002397 mock.patch('git_cl.Changelist.GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002398
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002399 def test_gerrit_change_detail_cache_simple(self):
2400 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002401 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002402 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002403 cl1._cached_remote_url = (
2404 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002405 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002406 cl2._cached_remote_url = (
2407 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002408 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2409 self.assertEqual(cl1._GetChangeDetail(), 'a')
2410 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002411
2412 def test_gerrit_change_detail_cache_options(self):
2413 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002414 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002415 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002416 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002417 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2418 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2419 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2420 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2421 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2422 self.assertEqual(cl._GetChangeDetail(), 'cab')
2423
2424 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2425 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2426 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2427 self.assertEqual(cl._GetChangeDetail(), 'cab')
2428
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002429 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002430 gerrit_util.GetChangeDetail.return_value = {
2431 'current_revision': 'rev1',
2432 'revisions': {
2433 'rev1': {'commit': {'message': 'desc1'}},
2434 },
2435 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002436
2437 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002438 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002439 cl._cached_remote_url = (
2440 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002441 self.assertEqual(cl.FetchDescription(), 'desc1')
2442 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002443
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002444 def test_print_current_creds(self):
2445 class CookiesAuthenticatorMock(object):
2446 def __init__(self):
2447 self.gitcookies = {
2448 'host.googlesource.com': ('user', 'pass'),
2449 'host-review.googlesource.com': ('user', 'pass'),
2450 }
2451 self.netrc = self
2452 self.netrc.hosts = {
2453 'github.com': ('user2', None, 'pass2'),
2454 'host2.googlesource.com': ('user3', None, 'pass'),
2455 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002456 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2457 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002458 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2459 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2460 ' Host\t User\t Which file',
2461 '============================\t=====\t===========',
2462 'host-review.googlesource.com\t user\t.gitcookies',
2463 ' host.googlesource.com\t user\t.gitcookies',
2464 ' host2.googlesource.com\tuser3\t .netrc',
2465 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002466 sys.stdout.seek(0)
2467 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002468 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2469 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2470 ' Host\tUser\t Which file',
2471 '============================\t====\t===========',
2472 'host-review.googlesource.com\tuser\t.gitcookies',
2473 ' host.googlesource.com\tuser\t.gitcookies',
2474 ])
2475
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002476 def _common_creds_check_mocks(self):
2477 def exists_mock(path):
2478 dirname = os.path.dirname(path)
2479 if dirname == os.path.expanduser('~'):
2480 dirname = '~'
2481 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002482 if base in (NETRC_FILENAME, '.gitcookies'):
2483 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002484 # git cl also checks for existence other files not relevant to this test.
2485 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002486 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002487 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002488 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002489 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002490
2491 def test_creds_check_gitcookies_not_configured(self):
2492 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002493 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2494 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002495 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002496 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2497 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2498 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2499 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2500 'or Ctrl+C to abort'), ''),
2501 (([
2502 'git', 'config', '--global', 'http.cookiefile',
2503 os.path.expanduser(os.path.join('~', '.gitcookies'))
2504 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002505 ]
2506 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002507 self.assertTrue(
2508 sys.stdout.getvalue().startswith(
2509 'You seem to be using outdated .netrc for git credentials:'))
2510 self.assertIn(
2511 '\nConfigured git to use .gitcookies from',
2512 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002513
2514 def test_creds_check_gitcookies_configured_custom_broken(self):
2515 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002516 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2517 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002518 custom_cookie_path = ('C:\\.gitcookies'
2519 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002520 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002521 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2522 ((['git', 'config', '--global', 'http.cookiefile'], ),
2523 custom_cookie_path),
2524 (('os.path.exists', custom_cookie_path), False),
2525 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2526 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2527 (([
2528 'git', 'config', '--global', 'http.cookiefile',
2529 os.path.expanduser(os.path.join('~', '.gitcookies'))
2530 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002531 ]
2532 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002533 self.assertIn(
2534 'WARNING: You have configured custom path to .gitcookies: ',
2535 sys.stdout.getvalue())
2536 self.assertIn(
2537 'However, your configured .gitcookies file is missing.',
2538 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002539
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002540 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002541 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002542 self.mockGit.config['remote.origin.url'] = (
2543 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002544 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002545 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002546 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002547 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002548 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002549 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002550
Edward Lemurda4b6c62020-02-13 00:28:40 +00002551 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2552 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002553 self.mockGit.config['remote.origin.url'] = (
2554 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002555 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002556 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002557 'current_revision': 'ba5eba11',
2558 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002559 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002560 '_number': 1,
2561 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002562 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002563 '_number': 2,
2564 },
2565 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002566 'messages': [
2567 {
2568 u'_revision_number': 1,
2569 u'author': {
2570 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002571 u'email': u'could-be-anything@example.com',
2572 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002573 },
2574 u'date': u'2017-03-15 20:08:45.000000000',
2575 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002576 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002577 u'tag': u'autogenerated:cq:dry-run'
2578 },
2579 {
2580 u'_revision_number': 2,
2581 u'author': {
2582 u'_account_id': 11151243,
2583 u'email': u'owner@example.com',
2584 u'name': u'owner'
2585 },
2586 u'date': u'2017-03-16 20:00:41.000000000',
2587 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2588 u'message': u'PTAL',
2589 },
2590 {
2591 u'_revision_number': 2,
2592 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002593 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002594 u'email': u'reviewer@example.com',
2595 u'name': u'reviewer'
2596 },
2597 u'date': u'2017-03-17 05:19:37.500000000',
2598 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2599 u'message': u'Patch Set 2: Code-Review+1',
2600 },
2601 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002602 }
2603 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002604 (('GetChangeComments', 'chromium-review.googlesource.com',
2605 'infra%2Finfra~1'), {
2606 '/COMMIT_MSG': [
2607 {
2608 'author': {
2609 'email': u'reviewer@example.com'
2610 },
2611 'updated': u'2017-03-17 05:19:37.500000000',
2612 'patch_set': 2,
2613 'side': 'REVISION',
2614 'message': 'Please include a bug link',
2615 },
2616 ],
2617 'codereview.settings': [
2618 {
2619 'author': {
2620 'email': u'owner@example.com'
2621 },
2622 'updated': u'2017-03-16 20:00:41.000000000',
2623 'patch_set': 2,
2624 'side': 'PARENT',
2625 'line': 42,
2626 'message': 'I removed this because it is bad',
2627 },
2628 ]
2629 }),
2630 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2631 'infra%2Finfra~1'), {}),
2632 ] * 2 + [(('write_json', 'output.json', [{
2633 u'date':
2634 u'2017-03-16 20:00:41.000000',
2635 u'message': (u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2636 u' Base, Line 42: https://crrev.com/c/1/2/'
2637 u'codereview.settings#b42\n' +
2638 u' I removed this because it is bad\n'),
2639 u'autogenerated':
2640 False,
2641 u'approval':
2642 False,
2643 u'disapproval':
2644 False,
2645 u'sender':
2646 u'owner@example.com'
2647 }, {
2648 u'date':
2649 u'2017-03-17 05:19:37.500000',
2650 u'message':
2651 (u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2652 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
2653 u' Please include a bug link\n'),
2654 u'autogenerated':
2655 False,
2656 u'approval':
2657 False,
2658 u'disapproval':
2659 False,
2660 u'sender':
2661 u'reviewer@example.com'
2662 }]), '')]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002663 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002664 git_cl._CommentSummary(
2665 message=(u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2666 u' Base, Line 42: https://crrev.com/c/1/2/' +
2667 u'codereview.settings#b42\n' +
2668 u' I removed this because it is bad\n'),
2669 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2670 autogenerated=False,
2671 disapproval=False,
2672 approval=False,
2673 sender=u'owner@example.com'),
2674 git_cl._CommentSummary(message=(
2675 u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2676 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002677 u' Please include a bug link\n'),
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002678 date=datetime.datetime(2017, 3, 17, 5, 19, 37,
2679 500000),
2680 autogenerated=False,
2681 disapproval=False,
2682 approval=False,
2683 sender=u'reviewer@example.com'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002684 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002685 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002686 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002687 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002688 self.assertEqual(
2689 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2690
2691 def test_git_cl_comments_robot_comments(self):
2692 # git cl comments also fetches robot comments (which are considered a type
2693 # of autogenerated comment), and unlike other types of comments, only robot
2694 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002695 self.mockGit.config['remote.origin.url'] = (
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002696 'https://x.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002697 gerrit_util.GetChangeDetail.return_value = {
2698 'owner': {'email': 'owner@example.com'},
2699 'current_revision': 'ba5eba11',
2700 'revisions': {
2701 'deadbeaf': {
2702 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002703 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002704 'ba5eba11': {
2705 '_number': 2,
2706 },
2707 },
2708 'messages': [
2709 {
2710 u'_revision_number': 1,
2711 u'author': {
2712 u'_account_id': 1111084,
2713 u'email': u'commit-bot@chromium.org',
2714 u'name': u'Commit Bot'
2715 },
2716 u'date': u'2017-03-15 20:08:45.000000000',
2717 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2718 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2719 u'tag': u'autogenerated:cq:dry-run'
2720 },
2721 {
2722 u'_revision_number': 1,
2723 u'author': {
2724 u'_account_id': 123,
2725 u'email': u'tricium@serviceaccount.com',
2726 u'name': u'Tricium'
2727 },
2728 u'date': u'2017-03-16 20:00:41.000000000',
2729 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2730 u'message': u'(1 comment)',
2731 u'tag': u'autogenerated:tricium',
2732 },
2733 {
2734 u'_revision_number': 1,
2735 u'author': {
2736 u'_account_id': 123,
2737 u'email': u'tricium@serviceaccount.com',
2738 u'name': u'Tricium'
2739 },
2740 u'date': u'2017-03-16 20:00:41.000000000',
2741 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2742 u'message': u'(1 comment)',
2743 u'tag': u'autogenerated:tricium',
2744 },
2745 {
2746 u'_revision_number': 2,
2747 u'author': {
2748 u'_account_id': 123,
2749 u'email': u'tricium@serviceaccount.com',
2750 u'name': u'reviewer'
2751 },
2752 u'date': u'2017-03-17 05:30:37.000000000',
2753 u'tag': u'autogenerated:tricium',
2754 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2755 u'message': u'(1 comment)',
2756 },
2757 ]
2758 }
2759 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002760 (('GetChangeComments', 'x-review.googlesource.com', 'infra%2Finfra~1'),
2761 {}),
2762 (('GetChangeRobotComments', 'x-review.googlesource.com',
2763 'infra%2Finfra~1'), {
2764 'codereview.settings': [
2765 {
2766 u'author': {
2767 u'email': u'tricium@serviceaccount.com'
2768 },
2769 u'updated': u'2017-03-17 05:30:37.000000000',
2770 u'robot_run_id': u'5565031076855808',
2771 u'robot_id': u'Linter/Category',
2772 u'tag': u'autogenerated:tricium',
2773 u'patch_set': 2,
2774 u'side': u'REVISION',
2775 u'message': u'Linter warning message text',
2776 u'line': 32,
2777 },
2778 ],
2779 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002780 ]
2781 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002782 git_cl._CommentSummary(
2783 date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2784 message=(u'(1 comment)\n\ncodereview.settings\n'
2785 u' PS2, Line 32: https://x-review.googlesource.com/c/1/2/'
2786 u'codereview.settings#32\n'
2787 u' Linter warning message text\n'),
2788 sender=u'tricium@serviceaccount.com',
2789 autogenerated=True,
2790 approval=False,
2791 disapproval=False)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002792 ]
2793 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002794 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002795 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002796
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002797 def test_get_remote_url_with_mirror(self):
2798 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002799
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002800 def selective_os_path_isdir_mock(path):
2801 if path == '/cache/this-dir-exists':
2802 return self._mocked_call('os.path.isdir', path)
2803 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002804
Edward Lemurda4b6c62020-02-13 00:28:40 +00002805 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002806
2807 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002808 self.mockGit.config['remote.origin.url'] = (
2809 '/cache/this-dir-exists')
2810 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2811 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002812 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002813 (('os.path.isdir', '/cache/this-dir-exists'),
2814 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002815 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002816 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002817 self.assertEqual(cl.GetRemoteUrl(), url)
2818 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2819
Edward Lemur298f2cf2019-02-22 21:40:39 +00002820 def test_get_remote_url_non_existing_mirror(self):
2821 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002822
Edward Lemur298f2cf2019-02-22 21:40:39 +00002823 def selective_os_path_isdir_mock(path):
2824 if path == '/cache/this-dir-doesnt-exist':
2825 return self._mocked_call('os.path.isdir', path)
2826 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002827
Edward Lemurda4b6c62020-02-13 00:28:40 +00002828 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2829 mock.patch('logging.error',
2830 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002831
Edward Lemur26964072020-02-19 19:18:51 +00002832 self.mockGit.config['remote.origin.url'] = (
2833 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002834 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002835 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2836 False),
2837 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002838 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2839 'but it doesn\'t exist.', {
2840 'remote': 'origin',
2841 'branch': 'master',
2842 'url': '/cache/this-dir-doesnt-exist'}
2843 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002844 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002845 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002846 self.assertIsNone(cl.GetRemoteUrl())
2847
2848 def test_get_remote_url_misconfigured_mirror(self):
2849 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002850
Edward Lemur298f2cf2019-02-22 21:40:39 +00002851 def selective_os_path_isdir_mock(path):
2852 if path == '/cache/this-dir-exists':
2853 return self._mocked_call('os.path.isdir', path)
2854 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002855
Edward Lemurda4b6c62020-02-13 00:28:40 +00002856 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2857 mock.patch('logging.error',
2858 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002859
Edward Lemur26964072020-02-19 19:18:51 +00002860 self.mockGit.config['remote.origin.url'] = (
2861 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002862 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002863 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002864 (('logging.error',
2865 'Remote "%(remote)s" for branch "%(branch)s" points to '
2866 '"%(cache_path)s", but it is misconfigured.\n'
2867 '"%(cache_path)s" must be a git repo and must have a remote named '
2868 '"%(remote)s" pointing to the git host.', {
2869 'remote': 'origin',
2870 'cache_path': '/cache/this-dir-exists',
2871 'branch': 'master'}
2872 ), None),
2873 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002874 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002875 self.assertIsNone(cl.GetRemoteUrl())
2876
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002877 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002878 self.mockGit.config['remote.origin.url'] = (
2879 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002880 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002881 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2882
2883 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002884 mock.patch('logging.error',
2885 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002886
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002887 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002888 (('logging.error',
2889 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2890 'but it doesn\'t exist.', {
2891 'remote': 'origin',
2892 'branch': 'master',
2893 'url': ''}
2894 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002895 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002896 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002897 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002898
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002899 def test_gerrit_new_default(self):
2900 self._run_gerrit_upload_test(
2901 [],
2902 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
2903 [],
2904 squash=False,
2905 squash_mode='override_nosquash',
2906 change_id='I123456789',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002907 default_branch='main')
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002908
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002909
Edward Lemur9aa1a962020-02-25 00:58:38 +00002910class ChangelistTest(unittest.TestCase):
Edward Lemur227d5102020-02-25 23:45:35 +00002911 def setUp(self):
2912 super(ChangelistTest, self).setUp()
2913 mock.patch('gclient_utils.FileRead').start()
2914 mock.patch('gclient_utils.FileWrite').start()
2915 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
2916 mock.patch(
2917 'git_cl.Changelist.GetCodereviewServer',
2918 return_value='https://chromium-review.googlesource.com').start()
2919 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
2920 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
2921 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
2922 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
2923 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
2924 mock.patch('git_cl.time_time').start()
2925 mock.patch('metrics.collector').start()
2926 mock.patch('subprocess2.Popen').start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002927 mock.patch('git_cl.Changelist.GetGerritProject',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002928 return_value='https://chromium-review.googlesource.com').start()
Edward Lemur227d5102020-02-25 23:45:35 +00002929 self.addCleanup(mock.patch.stopall)
2930 self.temp_count = 0
2931
Edward Lemur227d5102020-02-25 23:45:35 +00002932 def testRunHook(self):
2933 expected_results = {
2934 'more_cc': ['more@example.com', 'cc@example.com'],
2935 'should_continue': True,
2936 }
2937 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2938 git_cl.time_time.side_effect = [100, 200]
2939 mockProcess = mock.Mock()
2940 mockProcess.wait.return_value = 0
2941 subprocess2.Popen.return_value = mockProcess
2942
2943 cl = git_cl.Changelist()
2944 results = cl.RunHook(
2945 committing=True,
2946 may_prompt=True,
2947 verbose=2,
2948 parallel=True,
2949 upstream='upstream',
2950 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002951 all_files=True,
2952 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00002953
2954 self.assertEqual(expected_results, results)
2955 subprocess2.Popen.assert_called_once_with([
2956 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00002957 '--root', 'root',
2958 '--upstream', 'upstream',
2959 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002960 '--author', 'author',
2961 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00002962 '--issue', '123456',
2963 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002964 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00002965 '--may_prompt',
2966 '--parallel',
2967 '--all_files',
2968 '--json_output', '/tmp/fake-temp2',
2969 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002970 '--gerrit_project', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00002971 ])
2972 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002973 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00002974 metrics.collector.add_repeated('sub_commands', {
2975 'command': 'presubmit',
2976 'execution_time': 100,
2977 'exit_code': 0,
2978 })
2979
Edward Lemur99df04e2020-03-05 19:39:43 +00002980 def testRunHook_FewerOptions(self):
2981 expected_results = {
2982 'more_cc': ['more@example.com', 'cc@example.com'],
2983 'should_continue': True,
2984 }
2985 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2986 git_cl.time_time.side_effect = [100, 200]
2987 mockProcess = mock.Mock()
2988 mockProcess.wait.return_value = 0
2989 subprocess2.Popen.return_value = mockProcess
2990
2991 git_cl.Changelist.GetAuthor.return_value = None
2992 git_cl.Changelist.GetIssue.return_value = None
2993 git_cl.Changelist.GetPatchset.return_value = None
2994 git_cl.Changelist.GetCodereviewServer.return_value = None
2995
2996 cl = git_cl.Changelist()
2997 results = cl.RunHook(
2998 committing=False,
2999 may_prompt=False,
3000 verbose=0,
3001 parallel=False,
3002 upstream='upstream',
3003 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003004 all_files=False,
3005 resultdb=False)
Edward Lemur99df04e2020-03-05 19:39:43 +00003006
3007 self.assertEqual(expected_results, results)
3008 subprocess2.Popen.assert_called_once_with([
3009 'vpython', 'PRESUBMIT_SUPPORT',
3010 '--root', 'root',
3011 '--upstream', 'upstream',
3012 '--upload',
3013 '--json_output', '/tmp/fake-temp2',
3014 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00003015 '--gerrit_project', 'https://chromium-review.googlesource.com',
Edward Lemur99df04e2020-03-05 19:39:43 +00003016 ])
3017 gclient_utils.FileWrite.assert_called_once_with(
3018 '/tmp/fake-temp1', 'description')
3019 metrics.collector.add_repeated('sub_commands', {
3020 'command': 'presubmit',
3021 'execution_time': 100,
3022 'exit_code': 0,
3023 })
3024
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003025 def testRunHook_FewerOptionsResultDB(self):
3026 expected_results = {
3027 'more_cc': ['more@example.com', 'cc@example.com'],
3028 'should_continue': True,
3029 }
3030 gclient_utils.FileRead.return_value = json.dumps(expected_results)
3031 git_cl.time_time.side_effect = [100, 200]
3032 mockProcess = mock.Mock()
3033 mockProcess.wait.return_value = 0
3034 subprocess2.Popen.return_value = mockProcess
3035
3036 git_cl.Changelist.GetAuthor.return_value = None
3037 git_cl.Changelist.GetIssue.return_value = None
3038 git_cl.Changelist.GetPatchset.return_value = None
3039 git_cl.Changelist.GetCodereviewServer.return_value = None
3040
3041 cl = git_cl.Changelist()
3042 results = cl.RunHook(
3043 committing=False,
3044 may_prompt=False,
3045 verbose=0,
3046 parallel=False,
3047 upstream='upstream',
3048 description='description',
3049 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003050 resultdb=True,
3051 realm='chromium:public')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003052
3053 self.assertEqual(expected_results, results)
3054 subprocess2.Popen.assert_called_once_with([
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003055 'rdb', 'stream', '-new', '-realm', 'chromium:public', '--',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003056 'vpython', 'PRESUBMIT_SUPPORT',
3057 '--root', 'root',
3058 '--upstream', 'upstream',
3059 '--upload',
3060 '--json_output', '/tmp/fake-temp2',
3061 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00003062 '--gerrit_project', 'https://chromium-review.googlesource.com',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003063 ])
3064
Edward Lemur227d5102020-02-25 23:45:35 +00003065 @mock.patch('sys.exit', side_effect=SystemExitMock)
3066 def testRunHook_Failure(self, _mock):
3067 git_cl.time_time.side_effect = [100, 200]
3068 mockProcess = mock.Mock()
3069 mockProcess.wait.return_value = 2
3070 subprocess2.Popen.return_value = mockProcess
3071
3072 cl = git_cl.Changelist()
3073 with self.assertRaises(SystemExitMock):
3074 cl.RunHook(
3075 committing=True,
3076 may_prompt=True,
3077 verbose=2,
3078 parallel=True,
3079 upstream='upstream',
3080 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003081 all_files=True,
3082 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003083
3084 sys.exit.assert_called_once_with(2)
3085
Edward Lemur75526302020-02-27 22:31:05 +00003086 def testRunPostUploadHook(self):
3087 cl = git_cl.Changelist()
3088 cl.RunPostUploadHook(2, 'upstream', 'description')
3089
3090 subprocess2.Popen.assert_called_once_with([
3091 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00003092 '--root', 'root',
3093 '--upstream', 'upstream',
3094 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00003095 '--author', 'author',
3096 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur75526302020-02-27 22:31:05 +00003097 '--issue', '123456',
3098 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003099 '--post_upload',
3100 '--description_file', '/tmp/fake-temp1',
3101 ])
3102 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00003103 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00003104
Edward Lemur9aa1a962020-02-25 00:58:38 +00003105
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003106class CMDTestCaseBase(unittest.TestCase):
3107 _STATUSES = [
3108 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3109 'INFRA_FAILURE', 'CANCELED',
3110 ]
3111 _CHANGE_DETAIL = {
3112 'project': 'depot_tools',
3113 'status': 'OPEN',
3114 'owner': {'email': 'owner@e.mail'},
3115 'current_revision': 'beeeeeef',
3116 'revisions': {
Gavin Make61ccc52020-11-13 00:12:57 +00003117 'deadbeaf': {
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003118 '_number': 6,
Gavin Make61ccc52020-11-13 00:12:57 +00003119 'kind': 'REWORK',
3120 },
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003121 'beeeeeef': {
3122 '_number': 7,
Gavin Make61ccc52020-11-13 00:12:57 +00003123 'kind': 'NO_CODE_CHANGE',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003124 'fetch': {'http': {
3125 'url': 'https://chromium.googlesource.com/depot_tools',
3126 'ref': 'refs/changes/56/123456/7'
3127 }},
3128 },
3129 },
3130 }
3131 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003132 'builds': [{
3133 'id': str(100 + idx),
3134 'builder': {
3135 'project': 'chromium',
3136 'bucket': 'try',
3137 'builder': 'bot_' + status.lower(),
3138 },
3139 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3140 'tags': [],
3141 'status': status,
3142 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003143 }
3144
Edward Lemur4c707a22019-09-24 21:13:43 +00003145 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003146 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003147 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003148 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3149 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003150 mock.patch(
3151 'git_cl.Changelist.GetCodereviewServer',
3152 return_value='https://chromium-review.googlesource.com').start()
3153 mock.patch(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00003154 'git_cl.Changelist.GetGerritHost',
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003155 return_value='chromium-review.googlesource.com').start()
3156 mock.patch(
3157 'git_cl.Changelist.GetMostRecentPatchset',
3158 return_value=7).start()
3159 mock.patch(
Gavin Make61ccc52020-11-13 00:12:57 +00003160 'git_cl.Changelist.GetMostRecentDryRunPatchset',
3161 return_value=6).start()
3162 mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003163 'git_cl.Changelist.GetRemoteUrl',
3164 return_value='https://chromium.googlesource.com/depot_tools').start()
3165 mock.patch(
3166 'auth.Authenticator',
3167 return_value=AuthenticatorMock()).start()
3168 mock.patch(
3169 'gerrit_util.GetChangeDetail',
3170 return_value=self._CHANGE_DETAIL).start()
3171 mock.patch(
3172 'git_cl._call_buildbucket',
3173 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003174 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003175 self.addCleanup(mock.patch.stopall)
3176
Edward Lemur4c707a22019-09-24 21:13:43 +00003177
Edward Lemur9468eba2020-02-27 19:07:22 +00003178class CMDPresubmitTestCase(CMDTestCaseBase):
3179 def setUp(self):
3180 super(CMDPresubmitTestCase, self).setUp()
3181 mock.patch(
3182 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3183 return_value='upstream').start()
3184 mock.patch(
3185 'git_cl.Changelist.FetchDescription',
3186 return_value='fetch description').start()
3187 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00003188 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00003189 return_value='get description').start()
3190 mock.patch('git_cl.Changelist.RunHook').start()
3191
3192 def testDefaultCase(self):
3193 self.assertEqual(0, git_cl.main(['presubmit']))
3194 git_cl.Changelist.RunHook.assert_called_once_with(
3195 committing=True,
3196 may_prompt=False,
3197 verbose=0,
3198 parallel=None,
3199 upstream='upstream',
3200 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003201 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003202 resultdb=None,
3203 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003204
3205 def testNoIssue(self):
3206 git_cl.Changelist.GetIssue.return_value = None
3207 self.assertEqual(0, git_cl.main(['presubmit']))
3208 git_cl.Changelist.RunHook.assert_called_once_with(
3209 committing=True,
3210 may_prompt=False,
3211 verbose=0,
3212 parallel=None,
3213 upstream='upstream',
3214 description='get description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003215 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003216 resultdb=None,
3217 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003218
3219 def testCustomBranch(self):
3220 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3221 git_cl.Changelist.RunHook.assert_called_once_with(
3222 committing=True,
3223 may_prompt=False,
3224 verbose=0,
3225 parallel=None,
3226 upstream='custom_branch',
3227 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003228 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003229 resultdb=None,
3230 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003231
3232 def testOptions(self):
3233 self.assertEqual(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003234 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003235 '--resultdb', '--realm', 'chromium:public']))
Edward Lemur9468eba2020-02-27 19:07:22 +00003236 git_cl.Changelist.RunHook.assert_called_once_with(
3237 committing=False,
3238 may_prompt=False,
3239 verbose=2,
3240 parallel=True,
3241 upstream='upstream',
3242 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003243 all_files=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003244 resultdb=True,
3245 realm='chromium:public')
Edward Lemur9468eba2020-02-27 19:07:22 +00003246
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003247class CMDTryResultsTestCase(CMDTestCaseBase):
3248 _DEFAULT_REQUEST = {
3249 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003250 "gerritChanges": [{
3251 "project": "depot_tools",
3252 "host": "chromium-review.googlesource.com",
Gavin Make61ccc52020-11-13 00:12:57 +00003253 "patchset": 6,
3254 "change": 123456,
3255 }],
3256 },
3257 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3258 ',builds.*.createTime,builds.*.tags'),
3259 }
3260
3261 _TRIVIAL_REQUEST = {
3262 'predicate': {
3263 "gerritChanges": [{
3264 "project": "depot_tools",
3265 "host": "chromium-review.googlesource.com",
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003266 "patchset": 7,
3267 "change": 123456,
3268 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003269 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003270 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3271 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003272 }
3273
3274 def testNoJobs(self):
3275 git_cl._call_buildbucket.return_value = {}
3276
3277 self.assertEqual(0, git_cl.main(['try-results']))
3278 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3279 git_cl._call_buildbucket.assert_called_once_with(
3280 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3281 self._DEFAULT_REQUEST)
3282
Gavin Make61ccc52020-11-13 00:12:57 +00003283 def testTrivialCommits(self):
3284 self.assertEqual(0, git_cl.main(['try-results']))
3285 git_cl._call_buildbucket.assert_called_with(
3286 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3287 self._DEFAULT_REQUEST)
3288
3289 git_cl._call_buildbucket.return_value = {}
3290 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '7']))
3291 git_cl._call_buildbucket.assert_called_with(
3292 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3293 self._TRIVIAL_REQUEST)
3294 self.assertEqual([
3295 'Successes:',
3296 ' bot_success https://ci.chromium.org/b/103',
3297 'Infra Failures:',
3298 ' bot_infra_failure https://ci.chromium.org/b/105',
3299 'Failures:',
3300 ' bot_failure https://ci.chromium.org/b/104',
3301 'Canceled:',
3302 ' bot_canceled ',
3303 'Started:',
3304 ' bot_started https://ci.chromium.org/b/102',
3305 'Scheduled:',
3306 ' bot_scheduled id=101',
3307 'Other:',
3308 ' bot_status_unspecified id=100',
3309 'Total: 7 tryjobs',
3310 'No tryjobs scheduled.',
3311 ], sys.stdout.getvalue().splitlines())
3312
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003313 def testPrintToStdout(self):
3314 self.assertEqual(0, git_cl.main(['try-results']))
3315 self.assertEqual([
3316 'Successes:',
3317 ' bot_success https://ci.chromium.org/b/103',
3318 'Infra Failures:',
3319 ' bot_infra_failure https://ci.chromium.org/b/105',
3320 'Failures:',
3321 ' bot_failure https://ci.chromium.org/b/104',
3322 'Canceled:',
3323 ' bot_canceled ',
3324 'Started:',
3325 ' bot_started https://ci.chromium.org/b/102',
3326 'Scheduled:',
3327 ' bot_scheduled id=101',
3328 'Other:',
3329 ' bot_status_unspecified id=100',
3330 'Total: 7 tryjobs',
3331 ], sys.stdout.getvalue().splitlines())
3332 git_cl._call_buildbucket.assert_called_once_with(
3333 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3334 self._DEFAULT_REQUEST)
3335
3336 def testPrintToStdoutWithMasters(self):
3337 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3338 self.assertEqual([
3339 'Successes:',
3340 ' try bot_success https://ci.chromium.org/b/103',
3341 'Infra Failures:',
3342 ' try bot_infra_failure https://ci.chromium.org/b/105',
3343 'Failures:',
3344 ' try bot_failure https://ci.chromium.org/b/104',
3345 'Canceled:',
3346 ' try bot_canceled ',
3347 'Started:',
3348 ' try bot_started https://ci.chromium.org/b/102',
3349 'Scheduled:',
3350 ' try bot_scheduled id=101',
3351 'Other:',
3352 ' try bot_status_unspecified id=100',
3353 'Total: 7 tryjobs',
3354 ], sys.stdout.getvalue().splitlines())
3355 git_cl._call_buildbucket.assert_called_once_with(
3356 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3357 self._DEFAULT_REQUEST)
3358
3359 @mock.patch('git_cl.write_json')
3360 def testWriteToJson(self, mockJsonDump):
3361 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3362 git_cl._call_buildbucket.assert_called_once_with(
3363 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3364 self._DEFAULT_REQUEST)
3365 mockJsonDump.assert_called_once_with(
3366 'file.json', self._DEFAULT_RESPONSE['builds'])
3367
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003368 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003369 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3370 self.assertEqual(
3371 [
3372 ('chromium', 'try', 'bot_failure'),
3373 ('chromium', 'try', 'bot_infra_failure'),
3374 ],
3375 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003376
3377 def test_filter_failed_for_retry_many_builds(self):
3378
3379 def _build(name, created_sec, status, experimental=False):
3380 assert 0 <= created_sec < 100, created_sec
3381 b = {
3382 'id': 112112,
3383 'builder': {
3384 'project': 'chromium',
3385 'bucket': 'try',
3386 'builder': name,
3387 },
3388 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3389 'status': status,
3390 'tags': [],
3391 }
3392 if experimental:
3393 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3394 return b
3395
3396 builds = [
3397 _build('flaky-last-green', 1, 'FAILURE'),
3398 _build('flaky-last-green', 2, 'SUCCESS'),
3399 _build('flaky', 1, 'SUCCESS'),
3400 _build('flaky', 2, 'FAILURE'),
3401 _build('running', 1, 'FAILED'),
3402 _build('running', 2, 'SCHEDULED'),
3403 _build('yep-still-running', 1, 'STARTED'),
3404 _build('yep-still-running', 2, 'FAILURE'),
3405 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3406 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3407
3408 # Simulate experimental in CQ builder, which developer decided
3409 # to retry manually which resulted in 2nd build non-experimental.
3410 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3411 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3412 ]
3413 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003414 self.assertEqual(
3415 [
3416 ('chromium', 'try', 'flaky'),
3417 ('chromium', 'try', 'sometimes-experimental'),
3418 ],
3419 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003420
3421
3422class CMDTryTestCase(CMDTestCaseBase):
3423
3424 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003425 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003426 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003427 self.assertEqual(0, git_cl.main(['try']))
3428 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3429 self.assertEqual(
3430 sys.stdout.getvalue(),
3431 'Scheduling CQ dry run on: '
3432 'https://chromium-review.googlesource.com/123456\n')
3433
Edward Lemur4c707a22019-09-24 21:13:43 +00003434 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003435 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003436 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003437
3438 self.assertEqual(0, git_cl.main([
3439 'try', '-B', 'luci.chromium.try', '-b', 'win',
3440 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3441 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003442 'Scheduling jobs on:\n'
3443 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003444 git_cl.sys.stdout.getvalue())
3445
3446 expected_request = {
3447 "requests": [{
3448 "scheduleBuild": {
3449 "requestId": "uuid4",
3450 "builder": {
3451 "project": "chromium",
3452 "builder": "win",
3453 "bucket": "try",
3454 },
3455 "gerritChanges": [{
3456 "project": "depot_tools",
3457 "host": "chromium-review.googlesource.com",
3458 "patchset": 7,
3459 "change": 123456,
3460 }],
3461 "properties": {
3462 "category": "git_cl_try",
3463 "json": [{"a": 1}, None],
3464 "key": "val",
3465 },
3466 "tags": [
3467 {"value": "win", "key": "builder"},
3468 {"value": "git_cl_try", "key": "user_agent"},
3469 ],
3470 },
3471 }],
3472 }
3473 mockCallBuildbucket.assert_called_with(
3474 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3475
Anthony Polito1a5fe232020-01-24 23:17:52 +00003476 @mock.patch('git_cl._call_buildbucket')
3477 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3478 mockCallBuildbucket.return_value = {}
3479
3480 self.assertEqual(0, git_cl.main([
3481 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3482 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3483 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3484 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003485 'Scheduling jobs on:\n'
3486 ' chromium/try: linux\n'
3487 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003488 git_cl.sys.stdout.getvalue())
3489
3490 expected_request = {
3491 "requests": [{
3492 "scheduleBuild": {
3493 "requestId": "uuid4",
3494 "builder": {
3495 "project": "chromium",
3496 "builder": "linux",
3497 "bucket": "try",
3498 },
3499 "gerritChanges": [{
3500 "project": "depot_tools",
3501 "host": "chromium-review.googlesource.com",
3502 "patchset": 7,
3503 "change": 123456,
3504 }],
3505 "properties": {
3506 "category": "git_cl_try",
3507 "json": [{"a": 1}, None],
3508 "key": "val",
3509 },
3510 "tags": [
3511 {"value": "linux", "key": "builder"},
3512 {"value": "git_cl_try", "key": "user_agent"},
3513 ],
3514 "gitilesCommit": {
3515 "host": "chromium-review.googlesource.com",
3516 "project": "depot_tools",
3517 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3518 }
3519 },
3520 },
3521 {
3522 "scheduleBuild": {
3523 "requestId": "uuid4",
3524 "builder": {
3525 "project": "chromium",
3526 "builder": "win",
3527 "bucket": "try",
3528 },
3529 "gerritChanges": [{
3530 "project": "depot_tools",
3531 "host": "chromium-review.googlesource.com",
3532 "patchset": 7,
3533 "change": 123456,
3534 }],
3535 "properties": {
3536 "category": "git_cl_try",
3537 "json": [{"a": 1}, None],
3538 "key": "val",
3539 },
3540 "tags": [
3541 {"value": "win", "key": "builder"},
3542 {"value": "git_cl_try", "key": "user_agent"},
3543 ],
3544 "gitilesCommit": {
3545 "host": "chromium-review.googlesource.com",
3546 "project": "depot_tools",
3547 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3548 }
3549 },
3550 }],
3551 }
3552 mockCallBuildbucket.assert_called_with(
3553 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3554
Edward Lemur45768512020-03-02 19:03:14 +00003555 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003556 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003557 with self.assertRaises(SystemExit):
3558 git_cl.main([
3559 'try', '-B', 'not-a-bucket', '-b', 'win',
3560 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003561 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003562 'Invalid bucket: not-a-bucket.',
3563 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003564
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003565 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003566 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003567 def testScheduleOnBuildbucketRetryFailed(
3568 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003569 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003570 7: [],
3571 6: [{
3572 'id': 112112,
3573 'builder': {
3574 'project': 'chromium',
3575 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003576 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003577 'createTime': '2019-10-09T08:00:01.854286Z',
3578 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003579 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003580 mockCallBuildbucket.return_value = {}
3581
3582 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3583 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003584 'Scheduling jobs on:\n'
3585 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003586 git_cl.sys.stdout.getvalue())
3587
3588 expected_request = {
3589 "requests": [{
3590 "scheduleBuild": {
3591 "requestId": "uuid4",
3592 "builder": {
3593 "project": "chromium",
3594 "bucket": "try",
3595 "builder": "linux",
3596 },
3597 "gerritChanges": [{
3598 "project": "depot_tools",
3599 "host": "chromium-review.googlesource.com",
3600 "patchset": 7,
3601 "change": 123456,
3602 }],
3603 "properties": {
3604 "category": "git_cl_try",
3605 },
3606 "tags": [
3607 {"value": "linux", "key": "builder"},
3608 {"value": "git_cl_try", "key": "user_agent"},
3609 {"value": "1", "key": "retry_failed"},
3610 ],
3611 },
3612 }],
3613 }
3614 mockCallBuildbucket.assert_called_with(
3615 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3616
Edward Lemur4c707a22019-09-24 21:13:43 +00003617 def test_parse_bucket(self):
3618 test_cases = [
3619 {
3620 'bucket': 'chromium/try',
3621 'result': ('chromium', 'try'),
3622 },
3623 {
3624 'bucket': 'luci.chromium.try',
3625 'result': ('chromium', 'try'),
3626 'has_warning': True,
3627 },
3628 {
3629 'bucket': 'skia.primary',
3630 'result': ('skia', 'skia.primary'),
3631 'has_warning': True,
3632 },
3633 {
3634 'bucket': 'not-a-bucket',
3635 'result': (None, None),
3636 },
3637 ]
3638
3639 for test_case in test_cases:
3640 git_cl.sys.stdout.truncate(0)
3641 self.assertEqual(
3642 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3643 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003644 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3645 test_case['result'])
3646 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003647
3648
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003649class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003650
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003651 def setUp(self):
3652 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003653 mock.patch('git_cl._fetch_tryjobs').start()
3654 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003655 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003656 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3657 mock.patch(
3658 'git_cl.Settings.GetSquashGerritUploads',
3659 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003660 self.addCleanup(mock.patch.stopall)
3661
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003662 def testWarmUpChangeDetailCache(self):
3663 self.assertEqual(0, git_cl.main(['upload']))
3664 gerrit_util.GetChangeDetail.assert_called_once_with(
3665 'chromium-review.googlesource.com', 'depot_tools~123456',
3666 frozenset([
3667 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3668 'CURRENT_COMMIT']))
3669
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003670 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003671 # This test mocks out the actual upload part, and just asserts that after
3672 # upload, if --retry-failed is added, then the tool will fetch try jobs
3673 # from the previous patchset and trigger the right builders on the latest
3674 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003675 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003676 # Latest patchset: No builds.
3677 [],
3678 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003679 [{
3680 'id': str(100 + idx),
3681 'builder': {
3682 'project': 'chromium',
3683 'bucket': 'try',
3684 'builder': 'bot_' + status.lower(),
3685 },
3686 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3687 'tags': [],
3688 'status': status,
3689 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003690 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003691
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003692 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003693 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003694 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3695 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003696 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003697 expected_buckets = [
3698 ('chromium', 'try', 'bot_failure'),
3699 ('chromium', 'try', 'bot_infra_failure'),
3700 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003701 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3702 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003703
Brian Sheedy59b06a82019-10-14 17:03:29 +00003704
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003705class MakeRequestsHelperTestCase(unittest.TestCase):
3706
3707 def exampleGerritChange(self):
3708 return {
3709 'host': 'chromium-review.googlesource.com',
3710 'project': 'depot_tools',
3711 'change': 1,
3712 'patchset': 2,
3713 }
3714
3715 def testMakeRequestsHelperNoOptions(self):
3716 # Basic test for the helper function _make_tryjob_schedule_requests;
3717 # it shouldn't throw AttributeError even when options doesn't have any
3718 # of the expected values; it will use default option values.
3719 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3720 jobs = [('chromium', 'try', 'my-builder')]
3721 options = optparse.Values()
3722 requests = git_cl._make_tryjob_schedule_requests(
3723 changelist, jobs, options, patchset=None)
3724
3725 # requestId is non-deterministic. Just assert that it's there and has
3726 # a particular length.
3727 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3728 self.assertEqual(requests, [{
3729 'scheduleBuild': {
3730 'builder': {
3731 'bucket': 'try',
3732 'builder': 'my-builder',
3733 'project': 'chromium'
3734 },
3735 'gerritChanges': [self.exampleGerritChange()],
3736 'properties': {
3737 'category': 'git_cl_try'
3738 },
3739 'tags': [{
3740 'key': 'builder',
3741 'value': 'my-builder'
3742 }, {
3743 'key': 'user_agent',
3744 'value': 'git_cl_try'
3745 }]
3746 }
3747 }])
3748
3749 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3750 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3751 jobs = [('chromium', 'try', 'presubmit')]
3752 options = optparse.Values()
3753 requests = git_cl._make_tryjob_schedule_requests(
3754 changelist, jobs, options, patchset=None)
3755 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3756 'category': 'git_cl_try',
3757 'dry_run': 'true'
3758 })
3759
3760 def testMakeRequestsHelperRevisionSet(self):
3761 # Gitiles commit is specified when revision is in options.
3762 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3763 jobs = [('chromium', 'try', 'my-builder')]
3764 options = optparse.Values({'revision': 'ba5eba11'})
3765 requests = git_cl._make_tryjob_schedule_requests(
3766 changelist, jobs, options, patchset=None)
3767 self.assertEqual(
3768 requests[0]['scheduleBuild']['gitilesCommit'], {
3769 'host': 'chromium-review.googlesource.com',
3770 'id': 'ba5eba11',
3771 'project': 'depot_tools'
3772 })
3773
3774 def testMakeRequestsHelperRetryFailedSet(self):
3775 # An extra tag is added when retry_failed is in options.
3776 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3777 jobs = [('chromium', 'try', 'my-builder')]
3778 options = optparse.Values({'retry_failed': 'true'})
3779 requests = git_cl._make_tryjob_schedule_requests(
3780 changelist, jobs, options, patchset=None)
3781 self.assertEqual(
3782 requests[0]['scheduleBuild']['tags'], [
3783 {
3784 'key': 'builder',
3785 'value': 'my-builder'
3786 },
3787 {
3788 'key': 'user_agent',
3789 'value': 'git_cl_try'
3790 },
3791 {
3792 'key': 'retry_failed',
3793 'value': '1'
3794 }
3795 ])
3796
3797 def testMakeRequestsHelperCategorySet(self):
Quinten Yearsley925cedb2020-04-13 17:49:39 +00003798 # The category property can be overridden with options.
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003799 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3800 jobs = [('chromium', 'try', 'my-builder')]
3801 options = optparse.Values({'category': 'my-special-category'})
3802 requests = git_cl._make_tryjob_schedule_requests(
3803 changelist, jobs, options, patchset=None)
3804 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3805 {'category': 'my-special-category'})
3806
3807
Edward Lemurda4b6c62020-02-13 00:28:40 +00003808class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003809
3810 def setUp(self):
3811 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003812 mock.patch('git_cl.RunCommand').start()
3813 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3814 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3815 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003816 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003817 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003818
3819 def tearDown(self):
3820 shutil.rmtree(self._top_dir)
3821 super(CMDFormatTestCase, self).tearDown()
3822
Jamie Madill5e96ad12020-01-13 16:08:35 +00003823 def _make_temp_file(self, fname, contents):
3824 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3825 tf.write('\n'.join(contents))
3826
Brian Sheedy59b06a82019-10-14 17:03:29 +00003827 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003828 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003829
Brian Sheedyb4307d52019-12-02 19:18:17 +00003830 def _check_yapf_filtering(self, files, expected):
3831 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3832 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003833
Edward Lemur1a83da12020-03-04 21:18:36 +00003834 def _run_command_mock(self, return_value):
3835 def f(*args, **kwargs):
3836 if 'stdin' in kwargs:
3837 self.assertIsInstance(kwargs['stdin'], bytes)
3838 return return_value
3839 return f
3840
Jamie Madill5e96ad12020-01-13 16:08:35 +00003841 def testClangFormatDiffFull(self):
3842 self._make_temp_file('test.cc', ['// test'])
3843 git_cl.settings.GetFormatFullByDefault.return_value = False
3844 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3845 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3846
3847 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003848 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003849 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3850 self._top_dir, 'HEAD')
3851 self.assertEqual(2, return_value)
3852
3853 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003854 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003855 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3856 self._top_dir, 'HEAD')
3857 self.assertEqual(0, return_value)
3858
3859 def testClangFormatDiff(self):
3860 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00003861 # A valid file is required, so use this test.
3862 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00003863 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3864
3865 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003866 git_cl.RunCommand.side_effect = self._run_command_mock('error')
3867 return_value = git_cl._RunClangFormatDiff(
3868 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003869 self.assertEqual(2, return_value)
3870
3871 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003872 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003873 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3874 'HEAD')
3875 self.assertEqual(0, return_value)
3876
Brian Sheedyb4307d52019-12-02 19:18:17 +00003877 def testYapfignoreExplicit(self):
3878 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3879 files = [
3880 'bar.py',
3881 'foo/bar.py',
3882 'foo/baz.py',
3883 'foo/bar/baz.py',
3884 'foo/bar/foobar.py',
3885 ]
3886 expected = [
3887 'bar.py',
3888 'foo/baz.py',
3889 'foo/bar/foobar.py',
3890 ]
3891 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003892
Brian Sheedyb4307d52019-12-02 19:18:17 +00003893 def testYapfignoreSingleWildcards(self):
3894 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3895 files = [
3896 'bar.py', # Matched by *bar.py.
3897 'bar.txt',
3898 'foobar.py', # Matched by *bar.py, foo*.
3899 'foobar.txt', # Matched by foo*.
3900 'bazbar.py', # Matched by *bar.py, baz*.py.
3901 'bazbar.txt',
3902 'foo/baz.txt', # Matched by foo*.
3903 'bar/bar.py', # Matched by *bar.py.
3904 'baz/foo.py', # Matched by baz*.py, foo*.
3905 'baz/foo.txt',
3906 ]
3907 expected = [
3908 'bar.txt',
3909 'bazbar.txt',
3910 'baz/foo.txt',
3911 ]
3912 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003913
Brian Sheedyb4307d52019-12-02 19:18:17 +00003914 def testYapfignoreMultiplewildcards(self):
3915 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3916 files = [
3917 'bar.py', # Matched by *bar*.
3918 'bar.txt', # Matched by *bar*.
3919 'abar.py', # Matched by *bar*.
3920 'foobaz.txt', # Matched by *foo*baz.txt.
3921 'foobaz.py',
3922 'afoobaz.txt', # Matched by *foo*baz.txt.
3923 ]
3924 expected = [
3925 'foobaz.py',
3926 ]
3927 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003928
3929 def testYapfignoreComments(self):
3930 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003931 files = [
3932 'test.py',
3933 'test2.py',
3934 ]
3935 expected = [
3936 'test2.py',
3937 ]
3938 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003939
3940 def testYapfignoreBlankLines(self):
3941 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003942 files = [
3943 'test.py',
3944 'test2.py',
3945 'test3.py',
3946 ]
3947 expected = [
3948 'test3.py',
3949 ]
3950 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003951
3952 def testYapfignoreWhitespace(self):
3953 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003954 files = [
3955 'test.py',
3956 'test2.py',
3957 ]
3958 expected = [
3959 'test2.py',
3960 ]
3961 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003962
Brian Sheedyb4307d52019-12-02 19:18:17 +00003963 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003964 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003965 self._check_yapf_filtering([], [])
3966
3967 def testYapfignoreMissingYapfignore(self):
3968 files = [
3969 'test.py',
3970 ]
3971 expected = [
3972 'test.py',
3973 ]
3974 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003975
3976
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003977class CMDStatusTestCase(CMDTestCaseBase):
3978 # Return branch names a,..,f with comitterdates in increasing order, i.e.
3979 # 'f' is the most-recently changed branch.
3980 def _mock_run_git(commands):
3981 if commands == [
3982 'for-each-ref', '--format=%(refname) %(committerdate:unix)',
3983 'refs/heads'
3984 ]:
3985 branches_and_committerdates = [
3986 'refs/heads/a 1',
3987 'refs/heads/b 2',
3988 'refs/heads/c 3',
3989 'refs/heads/d 4',
3990 'refs/heads/e 5',
3991 'refs/heads/f 6',
3992 ]
3993 return '\n'.join(branches_and_committerdates)
3994
3995 # Mock the status in such a way that the issue number gives us an
3996 # indication of the commit date (simplifies manual debugging).
3997 def _mock_get_cl_statuses(branches, fine_grained, max_processes):
3998 for c in branches:
3999 c.issue = (100 + int(c.GetCommitDate()))
4000 yield (c, 'open')
4001
4002 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4003 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4004 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4005 @mock.patch('git_cl.RunGit', _mock_run_git)
4006 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4007 @mock.patch('git_cl.Settings.GetRoot', return_value='')
4008 @mock.patch('scm.GIT.GetBranch', return_value='a')
4009 def testStatus(self, *_mocks):
4010 self.assertEqual(0, git_cl.main(['status', '--no-branch-color']))
4011 self.maxDiff = None
4012 self.assertEqual(
4013 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4014 ' * a : https://crrev.com/c/101 (open)\n'
4015 ' b : https://crrev.com/c/102 (open)\n'
4016 ' c : https://crrev.com/c/103 (open)\n'
4017 ' d : https://crrev.com/c/104 (open)\n'
4018 ' e : https://crrev.com/c/105 (open)\n'
4019 ' f : https://crrev.com/c/106 (open)\n\n'
4020 'Current branch: a\n'
4021 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4022 'Issue description:\n'
4023 'x\n')
4024
4025 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4026 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4027 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4028 @mock.patch('git_cl.RunGit', _mock_run_git)
4029 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4030 @mock.patch('git_cl.Settings.GetRoot', return_value='')
4031 @mock.patch('scm.GIT.GetBranch', return_value='a')
4032 def testStatusByDate(self, *_mocks):
4033 self.assertEqual(
4034 0, git_cl.main(['status', '--no-branch-color', '--date-order']))
4035 self.maxDiff = None
4036 self.assertEqual(
4037 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4038 ' f : https://crrev.com/c/106 (open)\n'
4039 ' e : https://crrev.com/c/105 (open)\n'
4040 ' d : https://crrev.com/c/104 (open)\n'
4041 ' c : https://crrev.com/c/103 (open)\n'
4042 ' b : https://crrev.com/c/102 (open)\n'
4043 ' * a : https://crrev.com/c/101 (open)\n\n'
4044 'Current branch: a\n'
4045 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4046 'Issue description:\n'
4047 'x\n')
4048
4049
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004050class CMDOwnersTestCase(CMDTestCaseBase):
4051 def setUp(self):
4052 super(CMDOwnersTestCase, self).setUp()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004053 self.owners_by_path = {
4054 'foo': ['a@example.com'],
4055 'bar': ['b@example.com', 'c@example.com'],
4056 }
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004057 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
4058 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
4059 mock.patch(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004060 'git_cl.Changelist.GetAffectedFiles',
4061 return_value=list(self.owners_by_path)).start()
4062 mock.patch(
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004063 'git_cl.Changelist.GetCommonAncestorWithUpstream',
4064 return_value='upstream').start()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004065 mock.patch(
4066 'owners_client.DepotToolsClient.BatchListOwners',
4067 return_value=self.owners_by_path).start()
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004068 self.addCleanup(mock.patch.stopall)
4069
4070 def testShowAllNoArgs(self):
4071 self.assertEqual(0, git_cl.main(['owners', '--show-all']))
4072 self.assertEqual(
4073 'No files specified for --show-all. Nothing to do.\n',
4074 git_cl.sys.stdout.getvalue())
4075
4076 def testShowAll(self):
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004077 self.assertEqual(
4078 0,
4079 git_cl.main(['owners', '--show-all', 'foo', 'bar', 'baz']))
Edward Lesmes82b992a2021-01-11 23:24:55 +00004080 owners_client.DepotToolsClient.BatchListOwners.assert_called_once_with(
4081 ['foo', 'bar', 'baz'])
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004082 self.assertEqual(
4083 '\n'.join([
4084 'Owners for foo:',
4085 ' - a@example.com',
4086 'Owners for bar:',
4087 ' - b@example.com',
4088 ' - c@example.com',
4089 'Owners for baz:',
4090 ' - No owners found',
4091 '',
4092 ]),
4093 sys.stdout.getvalue())
4094
Edward Lesmes82b992a2021-01-11 23:24:55 +00004095 def testBatch(self):
4096 self.assertEqual(0, git_cl.main(['owners', '--batch']))
4097 self.assertIn('a@example.com', sys.stdout.getvalue())
4098 self.assertIn('b@example.com', sys.stdout.getvalue())
4099
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004100
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004101if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01004102 logging.basicConfig(
4103 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004104 unittest.main()