blob: fdc884cad4b300ec13f7e94d7a403af97c980820 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
34# We have to disable monitoring before importing git_cl.
35metrics.DISABLE_METRICS_COLLECTION = True
36
Jamie Madill5e96ad12020-01-13 16:08:35 +000037import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000038import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000039import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000040import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000041import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000042import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000043import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000044import git_new_branch
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +000045import owners_client
Edward Lemur85153282020-02-14 22:06:29 +000046import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000047import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000048
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000049NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
50
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000051
Edward Lemur0db01f02019-11-12 22:01:51 +000052def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070053 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
54
tandrii5d48c322016-08-18 16:19:37 -070055CERR1 = callError(1)
56
57
Edward Lemur1773f372020-02-22 00:27:14 +000058class TemporaryFileMock(object):
59 def __init__(self):
60 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070061
Edward Lemur1773f372020-02-22 00:27:14 +000062 @contextlib.contextmanager
63 def __call__(self):
64 self.suffix += 1
65 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070066
67
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000068class ChangelistMock(object):
69 # A class variable so we can access it when we don't have access to the
70 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000071 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000072
73 def __init__(self, gerrit_change=None, **kwargs):
74 self._gerrit_change = gerrit_change
75
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000076 def GetIssue(self):
77 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000078
Edward Lemur6c6827c2020-02-06 21:15:18 +000079 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000080 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000081
dsansomee2d6fd92016-09-08 00:10:47 -070082 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000083 ChangelistMock.desc = desc
84
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000085 def GetGerritChange(self, patchset=None, **kwargs):
86 del patchset
87 return self._gerrit_change
88
Josip Sokcevic9011a5b2021-02-12 18:59:44 +000089 def GetRemoteBranch(self):
90 return ('origin', 'refs/remotes/origin/main')
91
tandrii5d48c322016-08-18 16:19:37 -070092
Edward Lemur85153282020-02-14 22:06:29 +000093class GitMocks(object):
94 def __init__(self, config=None, branchref=None):
95 self.branchref = branchref or 'refs/heads/master'
96 self.config = config or {}
97
98 def GetBranchRef(self, _root):
99 return self.branchref
100
101 def NewBranch(self, branchref):
102 self.branchref = branchref
103
Edward Lemur26964072020-02-19 19:18:51 +0000104 def GetConfig(self, root, key, default=None):
105 if root != '':
106 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000107 return self.config.get(key, default)
108
Edward Lemur26964072020-02-19 19:18:51 +0000109 def SetConfig(self, root, key, value=None):
110 if root != '':
111 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000112 if value:
113 self.config[key] = value
114 return
115 if key not in self.config:
116 raise CERR1
117 del self.config[key]
118
119
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000120class WatchlistsMock(object):
121 def __init__(self, _):
122 pass
123 @staticmethod
124 def GetWatchersForPaths(_):
125 return ['joe@example.com']
126
127
Edward Lemur4c707a22019-09-24 21:13:43 +0000128class CodereviewSettingsFileMock(object):
129 def __init__(self):
130 pass
131 # pylint: disable=no-self-use
132 def read(self):
133 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
134 'GERRIT_HOST: True\n')
135
136
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000137class AuthenticatorMock(object):
138 def __init__(self, *_args):
139 pass
140 def has_cached_credentials(self):
141 return True
tandrii221ab252016-10-06 08:12:04 -0700142 def authorize(self, http):
143 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000144
145
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100146def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000147 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
148
149 Usage:
150 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100151 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000152
153 OR
154 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100155 CookiesAuthenticatorMockFactory(
156 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000157 """
158 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800159 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000160 # Intentionally not calling super() because it reads actual cookie files.
161 pass
162 @classmethod
163 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000164 return os.path.join('~', '.gitcookies')
165
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000166 @classmethod
167 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000168 return os.path.join('~', NETRC_FILENAME)
169
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100170 def _get_auth_for_host(self, host):
171 if same_auth:
172 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000173 return (hosts_with_creds or {}).get(host)
174 return CookiesAuthenticatorMock
175
Aaron Gable9a03ae02017-11-03 11:31:07 -0700176
kmarshall9249e012016-08-23 12:02:16 -0700177class MockChangelistWithBranchAndIssue():
178 def __init__(self, branch, issue):
179 self.branch = branch
180 self.issue = issue
181 def GetBranch(self):
182 return self.branch
183 def GetIssue(self):
184 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000185
tandriic2405f52016-10-10 08:13:15 -0700186
187class SystemExitMock(Exception):
188 pass
189
190
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000191class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000192 def setUp(self):
193 mock.patch('sys.exit', side_effect=SystemExitMock).start()
194 mock.patch('sys.stdout', StringIO()).start()
195 mock.patch('sys.stderr', StringIO()).start()
196 self.addCleanup(mock.patch.stopall)
197
198 def test_die_with_error(self):
199 with self.assertRaises(SystemExitMock):
200 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
201 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
202 self.assertTrue('saving CL description' in sys.stdout.getvalue())
203 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
204 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
205 sys.exit.assert_called_once_with(1)
206
207 def test_die_with_error_no_desc(self):
208 with self.assertRaises(SystemExitMock):
209 git_cl.DieWithError('foo')
210 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
211 self.assertEqual(sys.stdout.getvalue(), '')
212 sys.exit.assert_called_once_with(1)
213
Edward Lemur6c6827c2020-02-06 21:15:18 +0000214 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000215 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100216 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000217 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700218
Edward Lemur61bf4172020-02-24 23:22:37 +0000219 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
220 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
221 def test_get_cl_statuses(self, *_mocks):
222 statuses = [
223 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
224 changes = []
225 for status in statuses:
226 cl = git_cl.Changelist()
227 cl.status = status
228 changes.append(cl)
229
230 actual = set(git_cl.get_cl_statuses(changes, True))
231 self.assertEqual(set(zip(changes, statuses)), actual)
232
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000233 def test_upload_to_non_default_branch_no_retry(self):
234 m = mock.patch('git_cl.Changelist._CMDUploadChange',
235 side_effect=[git_cl.GitPushError(), None]).start()
236 mock.patch('git_cl.Changelist.GetRemoteBranch',
237 return_value=('foo', 'bar')).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000238 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000239 return_value='foo').start()
240 mock.patch('git_cl.gerrit_util.GetProjectHead',
241 return_value='refs/heads/main').start()
242
243 cl = git_cl.Changelist()
244 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000245 options.target_branch = 'refs/heads/bar'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000246 with self.assertRaises(SystemExitMock):
247 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
248
249 # ensure upload is called once
250 self.assertEqual(len(m.mock_calls), 1)
251 sys.exit.assert_called_once_with(1)
252 # option not set as retry didn't happen
253 self.assertFalse(hasattr(options, 'force'))
254 self.assertFalse(hasattr(options, 'edit_description'))
255
256 def test_upload_to_old_default_still_active(self):
257 m = mock.patch('git_cl.Changelist._CMDUploadChange',
258 side_effect=[git_cl.GitPushError(), None]).start()
259 mock.patch('git_cl.Changelist.GetRemoteBranch',
260 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000261 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000262 return_value='foo').start()
263 mock.patch('git_cl.gerrit_util.GetProjectHead',
Josip Sokcevicb631a882021-01-06 18:18:10 +0000264 return_value='refs/heads/master').start()
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000265
266 cl = git_cl.Changelist()
267 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000268 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000269 with self.assertRaises(SystemExitMock):
270 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
271
272 # ensure upload is called once
273 self.assertEqual(len(m.mock_calls), 1)
274 sys.exit.assert_called_once_with(1)
275 # option not set as retry didn't happen
276 self.assertFalse(hasattr(options, 'force'))
277 self.assertFalse(hasattr(options, 'edit_description'))
278
279 def test_upload_to_old_default_retry_on_failure(self):
280 m = mock.patch('git_cl.Changelist._CMDUploadChange',
281 side_effect=[git_cl.GitPushError(), None]).start()
282 mock.patch('git_cl.Changelist.GetRemoteBranch',
283 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000284 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000285 return_value='foo').start()
286 mock.patch('git_cl.gerrit_util.GetProjectHead',
287 return_value='refs/heads/main').start()
288 mock.patch('git_cl.RunGit').start()
289
290 cl = git_cl.Changelist()
291 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000292 options.target_branch = 'refs/heads/master'
293 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
294 # ensure upload is called twice
295 self.assertEqual(len(m.mock_calls), 2)
296 # option overrides on retry
297 self.assertEqual(options.force, True)
298 self.assertEqual(options.edit_description, False)
299
Gavin Mak68e6cf32021-01-25 18:24:08 +0000300 def test_upload_with_message_file_no_editor(self):
301 m = mock.patch('git_cl.ChangeDescription.prompt',
302 return_value=None).start()
303 mock.patch('git_cl.Changelist.GetRemoteBranch',
304 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
305 mock.patch('git_cl.GetTargetRef',
306 return_value='refs/heads/main').start()
307 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
308 lambda _, offer_removal: None).start()
309 mock.patch('git_cl.Changelist.GetIssue', return_value=None).start()
310 mock.patch('git_cl.Changelist.GetBranch',
311 side_effect=SystemExitMock).start()
312 mock.patch('git_cl.GenerateGerritChangeId', return_value=None).start()
313 mock.patch('git_cl.RunGit').start()
314
315 cl = git_cl.Changelist()
316 options = optparse.Values()
317 options.target_branch = 'refs/heads/master'
318 options.squash = True
319 options.edit_description = False
320 options.force = False
321 options.preserve_tryjobs = False
322 options.message_file = "message.txt"
323
324 with self.assertRaises(SystemExitMock):
325 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
326 self.assertEqual(len(m.mock_calls), 0)
327
328 options.message_file = None
329 with self.assertRaises(SystemExitMock):
330 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
331 self.assertEqual(len(m.mock_calls), 1)
332
Josip Sokcevicb631a882021-01-06 18:18:10 +0000333 def test_upload_to_old_default_retry_on_rollback(self):
334 """Test when default branch migration had to be rolled back to old name"""
335 m = mock.patch('git_cl.Changelist._CMDUploadChange',
336 side_effect=[git_cl.GitPushError(), None]).start()
337 mock.patch('git_cl.Changelist.GetRemoteBranch',
338 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
339 mock.patch('git_cl.Changelist.GetGerritProject',
340 return_value='foo').start()
341 mock.patch('git_cl.gerrit_util.GetProjectHead',
342 return_value='refs/heads/master').start()
343 # GetTargetRef returns new default branch since it has stale remote
344 # information.
345 mock.patch('git_cl.GetTargetRef',
346 return_value='refs/heads/main').start()
347 mock.patch('git_cl.RunGit').start()
348
349 cl = git_cl.Changelist()
350 options = optparse.Values()
351 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000352 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
353 # ensure upload is called twice
354 self.assertEqual(len(m.mock_calls), 2)
355 # option overrides on retry
356 self.assertEqual(options.force, True)
357 self.assertEqual(options.edit_description, False)
358
Edward Lemur61bf4172020-02-24 23:22:37 +0000359 def test_get_cl_statuses_no_changes(self):
360 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
361
362 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
363 @mock.patch('multiprocessing.pool.ThreadPool')
364 def test_get_cl_statuses_timeout(self, *_mocks):
365 changes = [git_cl.Changelist() for _ in range(2)]
366 pool = multiprocessing.pool.ThreadPool()
367 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
368 it.return_value.next.side_effect = [
369 (changes[0], 'lgtm'),
370 multiprocessing.TimeoutError,
371 ]
372
373 actual = list(git_cl.get_cl_statuses(changes, True))
374 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
375
376 @mock.patch('git_cl.Changelist.GetIssueURL')
377 def test_get_cl_statuses_not_finegrained(self, _mock):
378 changes = [git_cl.Changelist() for _ in range(2)]
379 urls = ['some-url', None]
380 git_cl.Changelist.GetIssueURL.side_effect = urls
381
382 actual = set(git_cl.get_cl_statuses(changes, False))
383 self.assertEqual(
384 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
385
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000386 def test_get_issue_url(self):
387 cl = git_cl.Changelist(issue=123)
388 cl._gerrit_server = 'https://example.com'
389 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
390 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
391
392 cl = git_cl.Changelist(issue=123)
393 cl._gerrit_server = 'https://chromium-review.googlesource.com'
394 self.assertEqual(cl.GetIssueURL(),
395 'https://chromium-review.googlesource.com/123')
396 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
397
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000398 def test_set_preserve_tryjobs(self):
399 d = git_cl.ChangeDescription('Simple.')
400 d.set_preserve_tryjobs()
401 self.assertEqual(d.description.splitlines(), [
402 'Simple.',
403 '',
404 'Cq-Do-Not-Cancel-Tryjobs: true',
405 ])
406 before = d.description
407 d.set_preserve_tryjobs()
408 self.assertEqual(before, d.description)
409
410 d = git_cl.ChangeDescription('\n'.join([
411 'One is enough',
412 '',
413 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
414 'Change-Id: Ideadbeef',
415 ]))
416 d.set_preserve_tryjobs()
417 self.assertEqual(d.description.splitlines(), [
418 'One is enough',
419 '',
420 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
421 'Change-Id: Ideadbeef',
422 'Cq-Do-Not-Cancel-Tryjobs: true',
423 ])
424
tandriif9aefb72016-07-01 09:06:51 -0700425 def test_get_bug_line_values(self):
426 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
427 self.assertEqual(f('', ''), [])
428 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
Lei Zhang8a0efc12020-08-05 19:58:45 +0000429 # Prefix that ends with colon.
430 self.assertEqual(f('v8:', '456'), ['v8:456'])
431 self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
432 # Prefix that ends without colon.
tandriif9aefb72016-07-01 09:06:51 -0700433 self.assertEqual(f('v8', '456'), ['v8:456'])
434 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
435 # Not nice, but not worth carying.
Lei Zhang8a0efc12020-08-05 19:58:45 +0000436 self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
437 ['v8:456', 'chromium:123', 'v8:123'])
tandriif9aefb72016-07-01 09:06:51 -0700438 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
439 ['v8:456', 'chromium:123', 'v8:123'])
440
Edward Lemurda4b6c62020-02-13 00:28:40 +0000441 @mock.patch('gerrit_util.GetAccountDetails')
442 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000443 mock_per_account = {
444 'u1': None, # 404, doesn't exist.
445 'u2': {
446 '_account_id': 123124,
447 'avatars': [],
448 'email': 'u2@example.com',
449 'name': 'User Number 2',
450 'status': 'OOO',
451 },
452 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
453 }
454 def GetAccountDetailsMock(_, account):
455 # Poor-man's mock library's side_effect.
456 v = mock_per_account.pop(account)
457 if isinstance(v, Exception):
458 raise v
459 return v
460
Edward Lemurda4b6c62020-02-13 00:28:40 +0000461 mockGetAccountDetails.side_effect = GetAccountDetailsMock
462 actual = git_cl.gerrit_util.ValidAccounts(
463 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000464 self.assertEqual(actual, {
465 'u2': {
466 '_account_id': 123124,
467 'avatars': [],
468 'email': 'u2@example.com',
469 'name': 'User Number 2',
470 'status': 'OOO',
471 },
472 })
473
474
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200475class TestParseIssueURL(unittest.TestCase):
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000476 def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
477 parsed = git_cl.ParseIssueNumberArgument(arg)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200478 self.assertIsNotNone(parsed)
479 if fail:
480 self.assertFalse(parsed.valid)
481 return
482 self.assertTrue(parsed.valid)
483 self.assertEqual(parsed.issue, issue)
484 self.assertEqual(parsed.patchset, patchset)
485 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200486
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000487 def test_basic(self):
488 self._test('123', 123)
489 self._test('', fail=True)
490 self._test('abc', fail=True)
491 self._test('123/1', fail=True)
492 self._test('123a', fail=True)
493 self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
494 self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200495
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000496 def test_gerrit_url(self):
497 self._test('https://codereview.source.com/123', 123, None,
498 'codereview.source.com')
499 self._test('http://chrome-review.source.com/c/123', 123, None,
500 'chrome-review.source.com')
501 self._test('https://chrome-review.source.com/c/123/', 123, None,
502 'chrome-review.source.com')
503 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
504 'chrome-review.source.com')
505 self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
506 'chrome-review.source.com')
507 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
508 'chrome-review.source.com')
509 self._test('https://chrome-review.source.com/123', 123, None,
510 'chrome-review.source.com')
511 self._test('https://chrome-review.source.com/123/4', 123, 4,
512 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200513
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000514 self._test('https://chrome-review.source.com/bad/123/4', fail=True)
515 self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
516 self._test('https://chrome-review.source.com/c/abc/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200517
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000518 def test_short_urls(self):
519 self._test('https://crrev.com/c/2151934', 2151934, None,
520 'chromium-review.googlesource.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200521
522
Edward Lemurda4b6c62020-02-13 00:28:40 +0000523class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100524 def setUp(self):
525 super(GitCookiesCheckerTest, self).setUp()
526 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100527 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000528 mock.patch('sys.stdout', StringIO()).start()
529 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100530
531 def mock_hosts_creds(self, subhost_identity_pairs):
532 def ensure_googlesource(h):
533 if not h.endswith(self.c._GOOGLESOURCE):
534 assert not h.endswith('.')
535 return h + '.' + self.c._GOOGLESOURCE
536 return h
537 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
538 for h, i in subhost_identity_pairs]
539
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200540 def test_identity_parsing(self):
541 self.assertEqual(self.c._parse_identity('ldap.google.com'),
542 ('ldap', 'google.com'))
543 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
544 ('ldap', 'example.com'))
545 # Specical case because we know there are no subdomains in chromium.org.
546 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
547 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800548 # Pathological: ".period." can be either username OR domain, more likely
549 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200550 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
551 ('note', 'period.example.com'))
552
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100553 def test_analysis_nothing(self):
554 self.c._all_hosts = []
555 self.assertFalse(self.c.has_generic_host())
556 self.assertEqual(set(), self.c.get_conflicting_hosts())
557 self.assertEqual(set(), self.c.get_duplicated_hosts())
558 self.assertEqual(set(), self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100559
560 def test_analysis(self):
561 self.mock_hosts_creds([
562 ('.googlesource.com', 'git-example.chromium.org'),
563
564 ('chromium', 'git-example.google.com'),
565 ('chromium-review', 'git-example.google.com'),
566 ('chrome-internal', 'git-example.chromium.org'),
567 ('chrome-internal-review', 'git-example.chromium.org'),
568 ('conflict', 'git-example.google.com'),
569 ('conflict-review', 'git-example.chromium.org'),
570 ('dup', 'git-example.google.com'),
571 ('dup', 'git-example.google.com'),
572 ('dup-review', 'git-example.google.com'),
573 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200574 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100575 ])
576 self.assertTrue(self.c.has_generic_host())
577 self.assertEqual(set(['conflict.googlesource.com']),
578 self.c.get_conflicting_hosts())
579 self.assertEqual(set(['dup.googlesource.com']),
580 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200581 self.assertEqual(set(['partial.googlesource.com',
582 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100583 self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100584
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100585 def test_report_no_problems(self):
586 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100587 self.assertFalse(self.c.find_and_report_problems())
588 self.assertEqual(sys.stdout.getvalue(), '')
589
Edward Lemurda4b6c62020-02-13 00:28:40 +0000590 @mock.patch(
591 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000592 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000593 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100594 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100595 self.assertTrue(self.c.find_and_report_problems())
596 with open(os.path.join(os.path.dirname(__file__),
597 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000598 expected = f.read() % {
599 'sep': os.sep,
600 }
601
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100602 def by_line(text):
603 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700604 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200605 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100606
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800607
Edward Lemurda4b6c62020-02-13 00:28:40 +0000608class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000609 def setUp(self):
610 super(TestGitCl, self).setUp()
611 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700612 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000613 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000614 mock.patch('sys.stdout', StringIO()).start()
615 mock.patch(
616 'git_cl.time_time',
617 lambda: self._mocked_call('time.time')).start()
618 mock.patch(
619 'git_cl.metrics.collector.add_repeated',
620 lambda *a: self._mocked_call('add_repeated', *a)).start()
621 mock.patch('subprocess2.call', self._mocked_call).start()
622 mock.patch('subprocess2.check_call', self._mocked_call).start()
623 mock.patch('subprocess2.check_output', self._mocked_call).start()
624 mock.patch(
625 'subprocess2.communicate',
626 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
627 mock.patch(
628 'git_cl.gclient_utils.CheckCallAndFilter',
629 self._mocked_call).start()
630 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000631 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
632 mock.patch(
633 'git_cl.SaveDescriptionBackup',
634 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
635 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000636 'git_cl.write_json',
637 lambda *a: self._mocked_call('write_json', *a)).start()
638 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000639 'git_cl.Changelist.RunHook',
640 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000641 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
642 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000643 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000644 mock.patch(
645 'git_cl.gerrit_util.GetChangeComments',
646 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
647 mock.patch(
648 'git_cl.gerrit_util.GetChangeRobotComments',
649 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
650 mock.patch(
651 'git_cl.gerrit_util.AddReviewers',
652 lambda *a: self._mocked_call('AddReviewers', *a)).start()
653 mock.patch(
654 'git_cl.gerrit_util.SetReview',
655 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
656 self._mocked_call(
657 'SetReview', h, i, msg, labels, notify, ready))).start()
658 mock.patch(
659 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
660 return_value=False).start()
661 mock.patch(
662 'git_cl.gerrit_util.GceAuthenticator.is_gce',
663 return_value=False).start()
664 mock.patch(
665 'git_cl.gerrit_util.ValidAccounts',
666 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000667 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000668 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000669 self.mockGit = GitMocks()
670 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
671 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
Edward Lesmes50da7702020-03-30 19:23:43 +0000672 mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
673 mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
Edward Lemur85153282020-02-14 22:06:29 +0000674 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000675 mock.patch(
676 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000677 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000678 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000679 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000680 mock.patch(
681 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000682 # It's important to reset settings to not have inter-tests interference.
683 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000684 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000685
686 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000687 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000688 if not self.failed:
689 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100690 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000691 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
692 if len(self.calls) > 5:
693 calls += ' ...\n'
694 self.fail(
695 '\n'
696 'There are un-consumed calls after this test has finished:\n' +
697 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000698 finally:
699 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000700
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000701 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000702 self.assertTrue(
703 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700704 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000705 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000706 expected_args, result = top
707
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000708 # Also logs otherwise it could get caught in a try/finally and be hard to
709 # diagnose.
710 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700711 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000712 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700713 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
714 for i, c in enumerate(self._calls_done[-N:]))
715 following_calls = '\n '.join(
716 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
717 for i, c in enumerate(self.calls[:N]))
718 extended_msg = (
719 'A few prior calls:\n %s\n\n'
720 'This (expected):\n @%d: %r\n'
721 'This (actual):\n @%d: %r\n\n'
722 'A few following expected calls:\n %s' %
723 (prior_calls, len(self._calls_done), expected_args,
724 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700725
Edward Lesmes0dd54822020-03-26 18:24:25 +0000726 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700727 self.fail('@%d\n'
728 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000729 ' Actual: %r\n'
730 '\n'
731 '%s' % (
732 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700733
734 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700735 if isinstance(result, Exception):
736 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000737 # stdout from git commands is supposed to be a bytestream. Convert it here
738 # instead of converting all test output in this file to bytes.
739 if args[0][0] == 'git' and not isinstance(result, bytes):
740 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000741 return result
742
Edward Lemur1a83da12020-03-04 21:18:36 +0000743 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
744 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100745 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100746 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000747 self.assertEqual(
748 'prompt [Yes/No]: Please, type yes or no: ',
749 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100750
tandrii48df5812016-10-17 03:55:37 -0700751 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000752 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700753 self.calls = [
754 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700755 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
756 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
757 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
758 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700759 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
760 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700761 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
762 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000763 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
764 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700765 ((['git', 'config', 'gerrit.host', 'true'],), ''),
766 ]
767 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
768
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000769 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100770 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200771 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000772 custom_cl_base=None, short_hostname='chromium',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000773 change_id=None, default_branch='master'):
Edward Lemur26964072020-02-19 19:18:51 +0000774 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200775 if custom_cl_base:
776 ancestor_revision = custom_cl_base
777 else:
778 # Determine ancestor_revision to be merge base.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000779 ancestor_revision = 'origin/' + default_branch
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200780
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100781 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000782 gerrit_util.GetChangeDetail.return_value = {
783 'owner': {'email': (other_cl_owner or 'owner@example.com')},
784 'change_id': (change_id or '123456789'),
785 'current_revision': 'sha1_of_current_revision',
786 'revisions': {'sha1_of_current_revision': {
787 'commit': {'message': fetched_description},
788 }},
789 'status': fetched_status or 'NEW',
790 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100791 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100792 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100793 if other_cl_owner:
794 calls += [
795 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
796 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100797
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100798 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200799 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
800 ([custom_cl_base] if custom_cl_base else
801 [ancestor_revision, 'HEAD']),),
802 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100803 ]
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000804 calls += [
805 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000806 '1' if default_branch == 'main' else callError(1)),
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000807 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000808
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100809 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000810
Edward Lemur26964072020-02-19 19:18:51 +0000811 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700812 squash_mode='default',
Aaron Gablefd238082017-06-07 13:42:34 -0700813 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100814 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000815 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000816 short_hostname='chromium',
Edward Lemur5a644f82020-03-18 16:44:57 +0000817 labels=None, change_id=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000818 final_description=None, gitcookies_exists=True,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000819 force=False, edit_description=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000820 default_branch='master'):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000821 if post_amend_description is None:
822 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700823 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200824
825 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000826
Edward Lesmes4de54132020-05-05 19:41:33 +0000827 if squash_mode in ('override_squash', 'override_nosquash'):
828 self.mockGit.config['gerrit.override-squash-uploads'] = (
829 'true' if squash_mode == 'override_squash' else 'false')
830
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000831 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000832 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200833 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200834 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000835 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000836 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000837 calls += [
838 ((['RunEditor'],), description),
839 ]
Josipe827b0f2020-01-30 00:07:20 +0000840 # user wants to edit description
841 if edit_description:
842 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000843 ((['RunEditor'],), edit_description),
844 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000845 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200846
847 if custom_cl_base is None:
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000848 parent = 'origin/' + default_branch
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000849 git_common.get_or_create_merge_base.return_value = parent
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200850 else:
851 calls += [
852 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000853 'refs/remotes/origin/' + default_branch],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200854 callError(1)), # Means not ancenstor.
855 (('ask_for_data',
856 'Do you take responsibility for cleaning up potential mess '
857 'resulting from proceeding with upload? Press Enter to upload, '
858 'or Ctrl+C to abort'), ''),
859 ]
860 parent = custom_cl_base
861
862 calls += [
863 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
864 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000865 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200866 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000867 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200868 ref_to_push),
869 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000870 else:
871 ref_to_push = 'HEAD'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000872 parent = 'origin/refs/heads/' + default_branch
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000873
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000874 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000875 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000876 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200877 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000878
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000879 metrics_arguments = []
880
Aaron Gableafd52772017-06-27 16:40:10 -0700881 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700882 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000883 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700884 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400885 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700886 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000887 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700888 else:
889 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000890 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800891
Edward Lemur5a644f82020-03-18 16:44:57 +0000892 # If issue is given, then description is fetched from Gerrit instead.
893 if issue is None:
894 if squash:
895 title = 'Initial upload'
896 else:
897 if not title:
898 calls += [
899 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
900 (('ask_for_data', 'Title for patchset []: '), 'User input'),
901 ]
902 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700903 if title:
Edward Lemur5a644f82020-03-18 16:44:57 +0000904 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000905 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000906
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000907 if short_hostname == 'chromium':
Quinten Yearsley925cedb2020-04-13 17:49:39 +0000908 # All reviewers and ccs get into ref_suffix.
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000909 for r in sorted(reviewers):
910 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000911 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000912 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000913 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000914 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000915 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000916 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000917 reviewers, cc = [], []
918 else:
919 # TODO(crbug/877717): remove this case.
920 calls += [
921 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
922 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000923 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000924 {
925 e: {'email': e}
926 for e in (reviewers + ['joe@example.com'] + cc)
927 })
928 ]
929 for r in sorted(reviewers):
930 if r != 'bad-account-or-email':
931 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000932 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000933 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000934 if issue is None:
935 cc += ['joe@example.com']
936 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000937 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000938 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000939 if c in cc:
940 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000941
Edward Lemur687ca902018-12-05 02:30:30 +0000942 for k, v in sorted((labels or {}).items()):
943 ref_suffix += ',l=%s+%d' % (k, v)
944 metrics_arguments.append('l=%s+%d' % (k, v))
945
946 if tbr:
947 calls += [
948 (('GetCodeReviewTbrScore',
949 '%s-review.googlesource.com' % short_hostname,
950 'my/repo'),
951 2,),
952 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000953
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000954 calls += [
955 (('time.time',), 1000,),
956 ((['git', 'push',
957 'https://%s.googlesource.com/my/repo' % short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000958 ref_to_push + ':refs/for/refs/heads/' + default_branch + ref_suffix],),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000959 (('remote:\n'
960 'remote: Processing changes: (\)\n'
961 'remote: Processing changes: (|)\n'
962 'remote: Processing changes: (/)\n'
963 'remote: Processing changes: (-)\n'
964 'remote: Processing changes: new: 1 (/)\n'
965 'remote: Processing changes: new: 1, done\n'
966 'remote:\n'
967 'remote: New Changes:\n'
968 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
969 ' XXX\n'
970 'remote:\n'
971 'To https://%s.googlesource.com/my/repo\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000972 ' * [new branch] hhhh -> refs/for/refs/heads/%s\n'
973 ) % (short_hostname, short_hostname, default_branch)),),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000974 (('time.time',), 2000,),
975 (('add_repeated',
976 'sub_commands',
977 {
978 'execution_time': 1000,
979 'command': 'git push',
980 'exit_code': 0,
981 'arguments': sorted(metrics_arguments),
982 }),
983 None,),
984 ]
985
Edward Lemur1b52d872019-05-09 21:12:12 +0000986 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000987
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000988 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
989
Edward Lemur1b52d872019-05-09 21:12:12 +0000990 # Trace-related calls
991 calls += [
992 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000993 (
994 ([
995 'FileWrite', trace_name + '-README',
996 '%(date)s\n'
997 '%(short_hostname)s-review.googlesource.com\n'
998 '%(change_id)s\n'
999 '%(title)s\n'
1000 '%(description)s\n'
1001 '1000\n'
1002 '0\n'
1003 '%(trace_name)s' % {
Josip Sokcevic5e18b602020-04-23 21:47:00 +00001004 'date': '2017-03-16T20:00:41.000000',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001005 'short_hostname': short_hostname,
1006 'change_id': change_id,
1007 'description': final_description,
1008 'title': title or '<untitled>',
1009 'trace_name': trace_name,
1010 }
1011 ], ),
1012 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001013 ),
1014 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001015 (
1016 (['os.path.isfile',
1017 os.path.join('TEMP_DIR', 'trace-packet')], ),
1018 True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001019 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001020 (
1021 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
1022 ('git-hash: 0123456789012345678901234567890123456789\n'
1023 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +00001024 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001025 (
1026 ([
1027 'FileWrite',
1028 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
1029 'git-hash: abcdea\n'
1030 ], ),
1031 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001032 ),
1033 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001034 (
1035 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
1036 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001037 ),
1038 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001039 (
1040 (['git', 'config', '-l'], ),
1041 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +00001042 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001043 (
1044 ([
1045 'FileWrite',
1046 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
1047 ], ),
1048 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001049 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001050 (
1051 (['os.path.isfile',
1052 os.path.join('~', '.gitcookies')], ),
1053 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +00001054 ),
1055 ]
1056 if gitcookies_exists:
1057 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001058 (
1059 (['FileRead', os.path.join('~', '.gitcookies')], ),
1060 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +00001061 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001062 (
1063 ([
1064 'FileWrite',
1065 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
1066 ], ),
1067 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001068 ),
1069 ]
1070 calls += [
1071 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001072 (
1073 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
1074 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001075 ),
1076 ]
1077
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001078 # TODO(crbug/877717): this should never be used.
1079 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001080 calls += [
1081 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001082 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001083 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001084 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001085 notify),
1086 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001087 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001088 return calls
1089
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001090 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001091 self,
1092 upload_args,
1093 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001094 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001095 squash=True,
1096 squash_mode=None,
Aaron Gable9b713dd2016-12-14 16:04:21 -08001097 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001098 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001099 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001100 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001101 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001102 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001103 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001104 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001105 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001106 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001107 labels=None,
1108 change_id=None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001109 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001110 gitcookies_exists=True,
1111 force=False,
Edward Lesmes0dd54822020-03-26 18:24:25 +00001112 log_description=None,
Josipe827b0f2020-01-30 00:07:20 +00001113 edit_description=None,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001114 fetched_description=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001115 default_branch='master'):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001116 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001117 if squash_mode is None:
1118 if '--no-squash' in upload_args:
1119 squash_mode = 'nosquash'
1120 elif '--squash' in upload_args:
1121 squash_mode = 'squash'
1122 else:
1123 squash_mode = 'default'
1124
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001125 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001126 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001127 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001128 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001129 same_auth=('git-owner.example.com', '', 'pass'))).start()
1130 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1131 lambda _, offer_removal: None).start()
1132 mock.patch('git_cl.gclient_utils.RunEditor',
1133 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1134 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001135 'DownloadGerritHook', force)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001136 mock.patch('git_cl.gclient_utils.FileRead',
1137 lambda path: self._mocked_call(['FileRead', path])).start()
1138 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001139 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001140 ['FileWrite', path, contents])).start()
1141 mock.patch('git_cl.datetime_now',
1142 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1143 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1144 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1145 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001146 '%(now)s\n'
1147 '%(gerrit_host)s\n'
1148 '%(change_id)s\n'
1149 '%(title)s\n'
1150 '%(description)s\n'
1151 '%(execution_time)s\n'
1152 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001153 '%(trace_name)s').start()
1154 mock.patch('git_cl.shutil.make_archive',
1155 lambda *args: self._mocked_call(['make_archive'] +
1156 list(args))).start()
1157 mock.patch('os.path.isfile',
1158 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001159 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001160 'git_cl._create_description_from_log',
1161 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001162 mock.patch(
1163 'git_cl.Changelist._AddChangeIdToCommitMessage',
1164 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001165 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001166 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1167 mock.patch(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001168 'git_common.get_or_create_merge_base',
1169 return_value='origin/' + default_branch).start()
1170 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001171 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001172 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001173
Edward Lemur26964072020-02-19 19:18:51 +00001174 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001175 self.mockGit.config['branch.master.gerritissue'] = (
1176 str(issue) if issue else None)
1177 self.mockGit.config['remote.origin.url'] = (
1178 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001179 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001180
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001181 self.calls = self._gerrit_base_calls(
1182 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001183 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001184 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001185 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001186 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001187 short_hostname=short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001188 change_id=change_id,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001189 default_branch=default_branch)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001190 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001191 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001192 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001193 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001194 self.calls += self._gerrit_upload_calls(
1195 description, reviewers, squash,
1196 squash_mode=squash_mode,
Aaron Gablefd238082017-06-07 13:42:34 -07001197 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001198 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001199 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001200 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001201 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001202 labels=labels,
1203 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001204 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001205 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001206 force=force,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001207 edit_description=edit_description,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001208 default_branch=default_branch)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001209 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001210 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001211 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001212 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001213 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001214 self.assertEqual(
1215 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001216 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001217
Edward Lemur1b52d872019-05-09 21:12:12 +00001218 def test_gerrit_upload_traces_no_gitcookies(self):
1219 self._run_gerrit_upload_test(
1220 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001221 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001222 [],
1223 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001224 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001225 change_id='Ixxx',
1226 gitcookies_exists=False)
1227
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001228 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001229 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001230 [],
1231 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1232 [],
1233 change_id='Ixxx')
1234
1235 def test_gerrit_upload_without_change_id_nosquash(self):
1236 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001237 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001238 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001239 [],
1240 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001241 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001242 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001243
Edward Lesmes4de54132020-05-05 19:41:33 +00001244 def test_gerrit_upload_without_change_id_override_nosquash(self):
1245 self._run_gerrit_upload_test(
1246 [],
1247 'desc ✔\n\nBUG=\n',
1248 [],
1249 squash=False,
1250 squash_mode='override_nosquash',
1251 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1252 change_id='Ixxx')
1253
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001254 def test_gerrit_no_reviewer(self):
1255 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001256 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001257 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001258 [],
1259 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001260 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001261 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001262
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001263 def test_gerrit_no_reviewer_non_chromium_host(self):
1264 # TODO(crbug/877717): remove this test case.
1265 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001266 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001267 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001268 [],
1269 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001270 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001271 short_hostname='other',
1272 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001273
Edward Lesmes0dd54822020-03-26 18:24:25 +00001274 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001275 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001276 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001277 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001278 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001279 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001280 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001281 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001282
ukai@chromium.orge8077812012-02-03 03:41:46 +00001283 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001284 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001285 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001286 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001287 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001288 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001289 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001290 notify=True,
1291 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001292 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001293 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001294
Anthony Polito8b955342019-09-24 19:01:36 +00001295 def test_gerrit_upload_force_sets_bug(self):
1296 self._run_gerrit_upload_test(
1297 ['-b', '10000', '-f'],
1298 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1299 [],
1300 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001301 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001302 change_id='Ixxx')
1303
Edward Lemur5fb22242020-03-12 22:05:13 +00001304 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001305 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001306 ['-b', '10000', '-m', 'Title', '--edit-description'],
1307 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001308 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001309 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001310 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001311 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001312 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001313 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001314
Dan Beamd8b04ca2019-10-10 21:23:26 +00001315 def test_gerrit_upload_force_sets_fixed(self):
1316 self._run_gerrit_upload_test(
1317 ['-x', '10000', '-f'],
1318 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1319 [],
1320 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001321 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001322 change_id='Ixxx')
1323
ukai@chromium.orge8077812012-02-03 03:41:46 +00001324 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001325 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1326 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001327 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001328 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001329 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001330 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001331 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001332 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001333 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001334 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001335 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001336 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001337
1338 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001339 self._run_gerrit_upload_test(
1340 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001341 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001342 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001343 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001344
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001345 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001346 self._run_gerrit_upload_test(
1347 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001348 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001349 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001350 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001351 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001352
Edward Lesmes0dd54822020-03-26 18:24:25 +00001353 def test_gerrit_upload_squash_first_title(self):
1354 self._run_gerrit_upload_test(
1355 ['-f', '-t', 'title'],
1356 'title\n\ndesc\n\nChange-Id: 123456789',
1357 [],
1358 force=True,
1359 squash=True,
1360 log_description='desc',
1361 change_id='123456789')
1362
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001363 def test_gerrit_upload_squash_first_with_labels(self):
1364 self._run_gerrit_upload_test(
1365 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001366 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001367 [],
1368 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001369 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001370 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001371
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001372 def test_gerrit_upload_squash_first_against_rev(self):
1373 custom_cl_base = 'custom_cl_base_rev_or_branch'
1374 self._run_gerrit_upload_test(
1375 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001376 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001377 [],
1378 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001379 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001380 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001381 self.assertIn(
1382 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1383 sys.stdout.getvalue())
1384
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001385 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001386 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001387 self._run_gerrit_upload_test(
1388 ['--squash'],
1389 description,
1390 [],
1391 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001392 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001393 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001394
Edward Lemurd55c5072020-02-20 01:09:07 +00001395 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001396 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001397 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001398 with self.assertRaises(SystemExitMock):
1399 self._run_gerrit_upload_test(
1400 ['--squash'],
1401 description,
1402 [],
1403 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001404 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001405 fetched_status='ABANDONED',
1406 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001407 self.assertEqual(
1408 'Change https://chromium-review.googlesource.com/123456 has been '
1409 'abandoned, new uploads are not allowed\n',
1410 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001411
Edward Lemurda4b6c62020-02-13 00:28:40 +00001412 @mock.patch(
1413 'gerrit_util.GetAccountDetails',
1414 return_value={'email': 'yet-another@example.com'})
1415 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001416 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001417 self._run_gerrit_upload_test(
1418 ['--squash'],
1419 description,
1420 [],
1421 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001422 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001423 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001424 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001425 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001426 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001427 'authenticate to Gerrit as yet-another@example.com.\n'
1428 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001429 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001430
Josipe827b0f2020-01-30 00:07:20 +00001431 def test_upload_change_description_editor(self):
1432 fetched_description = 'foo\n\nChange-Id: 123456789'
1433 description = 'bar\n\nChange-Id: 123456789'
1434 self._run_gerrit_upload_test(
1435 ['--squash', '--edit-description'],
1436 description,
1437 [],
1438 fetched_description=fetched_description,
1439 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001440 issue=123456,
1441 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001442 edit_description=description)
1443
Edward Lemurda4b6c62020-02-13 00:28:40 +00001444 @mock.patch('git_cl.RunGit')
1445 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001446 @mock.patch('sys.stdin', StringIO('\n'))
1447 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001448 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001449 def mock_run_git(*args, **_kwargs):
1450 if args[0] == ['for-each-ref',
1451 '--format=%(refname:short) %(upstream:short)',
1452 'refs/heads']:
1453 # Create a local branch dependency tree that looks like this:
1454 # test1 -> test2 -> test3 -> test4 -> test5
1455 # -> test3.1
1456 # test6 -> test0
1457 branch_deps = [
1458 'test2 test1', # test1 -> test2
1459 'test3 test2', # test2 -> test3
1460 'test3.1 test2', # test2 -> test3.1
1461 'test4 test3', # test3 -> test4
1462 'test5 test4', # test4 -> test5
1463 'test6 test0', # test0 -> test6
1464 'test7', # test7
1465 ]
1466 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001467 git_cl.RunGit.side_effect = mock_run_git
1468 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001469
1470 class MockChangelist():
1471 def __init__(self):
1472 pass
1473 def GetBranch(self):
1474 return 'test1'
1475 def GetIssue(self):
1476 return '123'
1477 def GetPatchset(self):
1478 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001479 def IsGerrit(self):
1480 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001481
1482 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1483 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001484 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001485 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001486 'This command will checkout all dependent branches '
1487 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001488 'or Ctrl+C to abort',
1489 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001490 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001491
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001492 def test_gerrit_change_id(self):
1493 self.calls = [
1494 ((['git', 'write-tree'], ),
1495 'hashtree'),
1496 ((['git', 'rev-parse', 'HEAD~0'], ),
1497 'branch-parent'),
1498 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1499 'A B <a@b.org> 1456848326 +0100'),
1500 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1501 'C D <c@d.org> 1456858326 +0100'),
1502 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1503 'hashchange'),
1504 ]
1505 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1506 self.assertEqual(change_id, 'Ihashchange')
1507
Edward Lesmese1576912021-02-16 21:53:34 +00001508 @mock.patch('gerrit_util.IsCodeOwnersEnabled')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001509 @mock.patch('git_cl.Settings.GetBugPrefix')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001510 @mock.patch('git_cl.Changelist.FetchDescription')
1511 @mock.patch('git_cl.Changelist.GetBranch')
Edward Lesmese1576912021-02-16 21:53:34 +00001512 @mock.patch('git_cl.Changelist.GetGerritHost')
1513 @mock.patch('git_cl.Changelist.GetGerritProject')
1514 @mock.patch('git_cl.Changelist.GetRemoteBranch')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001515 @mock.patch('owners_client.OwnersClient.BatchListOwners')
1516 def getDescriptionForUploadTest(
Edward Lesmese1576912021-02-16 21:53:34 +00001517 self, mockBatchListOwners=None, mockGetRemoteBranch=None,
1518 mockGetGerritProject=None, mockGetGerritHost=None, mockGetBranch=None,
1519 mockFetchDescription=None, mockGetBugPrefix=None,
1520 mockIsCodeOwnersEnabled=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001521 initial_description='desc', bug=None, fixed=None, branch='branch',
1522 reviewers=None, tbrs=None, add_owners_to=None,
1523 expected_description='desc'):
1524 reviewers = reviewers or []
1525 tbrs = tbrs or []
1526 owners_by_path = {
1527 'a': ['a@example.com'],
1528 'b': ['b@example.com'],
1529 'c': ['c@example.com'],
1530 }
Edward Lesmese1576912021-02-16 21:53:34 +00001531 mockIsCodeOwnersEnabled.return_value = True
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001532 mockGetBranch.return_value = branch
1533 mockGetBugPrefix.return_value = 'prefix'
Edward Lesmese1576912021-02-16 21:53:34 +00001534 mockGetRemoteBranch.return_value = ('origin', 'refs/remotes/origin/main')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001535 mockFetchDescription.return_value = 'desc'
1536 mockBatchListOwners.side_effect = lambda ps: {
1537 p: owners_by_path.get(p)
1538 for p in ps
1539 }
1540
1541 cl = git_cl.Changelist(issue=1234)
1542 actual = cl._GetDescriptionForUpload(
1543 options=mock.Mock(
1544 bug=bug,
1545 fixed=fixed,
1546 reviewers=reviewers,
1547 tbrs=tbrs,
1548 add_owners_to=add_owners_to),
1549 git_diff_args=None,
1550 files=list(owners_by_path))
1551 self.assertEqual(expected_description, actual.description)
1552
1553 def testGetDescriptionForUpload(self):
1554 self.getDescriptionForUploadTest()
1555
1556 def testGetDescriptionForUpload_Bug(self):
1557 self.getDescriptionForUploadTest(
1558 bug='1234',
1559 expected_description='\n'.join([
1560 'desc',
1561 '',
1562 'Bug: prefix:1234',
1563 ]))
1564
1565 def testGetDescriptionForUpload_Fixed(self):
1566 self.getDescriptionForUploadTest(
1567 fixed='1234',
1568 expected_description='\n'.join([
1569 'desc',
1570 '',
1571 'Fixed: prefix:1234',
1572 ]))
1573
1574
1575 def testGetDescriptionForUpload_BugFromBranch(self):
1576 self.getDescriptionForUploadTest(
1577 branch='bug-1234',
1578 expected_description='\n'.join([
1579 'desc',
1580 '',
1581 'Bug: prefix:1234',
1582 ]))
1583
1584 def testGetDescriptionForUpload_FixedFromBranch(self):
1585 self.getDescriptionForUploadTest(
1586 branch='fix-1234',
1587 expected_description='\n'.join([
1588 'desc',
1589 '',
1590 'Fixed: prefix:1234',
1591 ]))
1592
1593 def testGetDescriptionForUpload_AddOwnersToR(self):
1594 self.getDescriptionForUploadTest(
1595 reviewers=['a@example.com'],
1596 tbrs=['b@example.com'],
1597 add_owners_to='R',
1598 expected_description='\n'.join([
1599 'desc',
1600 '',
1601 'R=a@example.com, c@example.com',
1602 'TBR=b@example.com',
1603 ]))
1604
1605 def testGetDescriptionForUpload_AddOwnersToTBR(self):
1606 self.getDescriptionForUploadTest(
1607 reviewers=['a@example.com'],
1608 tbrs=['b@example.com'],
1609 add_owners_to='TBR',
1610 expected_description='\n'.join([
1611 'desc',
1612 '',
1613 'R=a@example.com',
1614 'TBR=b@example.com, c@example.com',
1615 ]))
1616
1617 def testGetDescriptionForUpload_AddOwnersToNoOwnersNeeded(self):
1618 self.getDescriptionForUploadTest(
1619 reviewers=['a@example.com', 'c@example.com'],
1620 tbrs=['b@example.com'],
1621 add_owners_to='TBR',
1622 expected_description='\n'.join([
1623 'desc',
1624 '',
1625 'R=a@example.com, c@example.com',
1626 'TBR=b@example.com',
1627 ]))
1628
1629 def testGetDescriptionForUpload_Reviewers(self):
1630 self.getDescriptionForUploadTest(
1631 reviewers=['a@example.com', 'b@example.com'],
1632 expected_description='\n'.join([
1633 'desc',
1634 '',
1635 'R=a@example.com, b@example.com',
1636 ]))
1637
1638 def testGetDescriptionForUpload_TBRs(self):
1639 self.getDescriptionForUploadTest(
1640 tbrs=['a@example.com', 'b@example.com'],
1641 expected_description='\n'.join([
1642 'desc',
1643 '',
1644 'TBR=a@example.com, b@example.com',
1645 ]))
1646
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001647 def test_desecription_append_footer(self):
1648 for init_desc, footer_line, expected_desc in [
1649 # Use unique desc first lines for easy test failure identification.
1650 ('foo', 'R=one', 'foo\n\nR=one'),
1651 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1652 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1653 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1654 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1655 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1656 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1657 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1658 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1659 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1660 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1661 ]:
1662 desc = git_cl.ChangeDescription(init_desc)
1663 desc.append_footer(footer_line)
1664 self.assertEqual(desc.description, expected_desc)
1665
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001666 def test_update_reviewers(self):
1667 data = [
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001668 ('foo', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001669 'foo'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001670 ('foo\nR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001671 'foo\nR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001672 ('foo\nTBR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001673 'foo\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001674 ('foo', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001675 'foo\n\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001676 ('foo\nR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001677 'foo\n\nR=a@c, xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001678 ('foo\nTBR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001679 'foo\n\nR=a@c\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001680 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001681 'foo\n\nR=a@c, yy\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001682 ('foo\nBUG=', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001683 'foo\nBUG=\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001684 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001685 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001686 ('foo', ['a@c', 'b@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001687 'foo\n\nR=a@c, b@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001688 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001689 'foo\nBar\n\nR=c@c\nBUG='),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001690 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001691 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001692 # Same as the line before, but full of whitespaces.
1693 (
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001694 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001695 'foo\nBar\n\nR=c@c\n BUG =',
1696 ),
1697 # Whitespaces aren't interpreted as new lines.
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001698 ('foo BUG=allo R=joe ', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001699 'foo BUG=allo R=joe\n\nR=c@c'),
1700 # Redundant TBRs get promoted to Rs
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001701 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001702 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001703 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001704 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001705 actual = []
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001706 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001707 obj = git_cl.ChangeDescription(orig)
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001708 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001709 actual.append(obj.description)
1710 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001711
Nodir Turakulov23b82142017-11-16 11:04:25 -08001712 def test_get_hash_tags(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001713 self.calls = [
1714 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
1715 callError(1)),
1716 ] * 9
Nodir Turakulov23b82142017-11-16 11:04:25 -08001717 cases = [
1718 ('', []),
1719 ('a', []),
1720 ('[a]', ['a']),
1721 ('[aa]', ['aa']),
1722 ('[a ]', ['a']),
1723 ('[a- ]', ['a']),
1724 ('[a- b]', ['a-b']),
1725 ('[a--b]', ['a-b']),
1726 ('[a', []),
1727 ('[a]x', ['a']),
1728 ('[aa]x', ['aa']),
1729 ('[a b]', ['a-b']),
1730 ('[a b]', ['a-b']),
1731 ('[a__b]', ['a-b']),
1732 ('[a] x', ['a']),
1733 ('[a][b]', ['a', 'b']),
1734 ('[a] [b]', ['a', 'b']),
1735 ('[a][b]x', ['a', 'b']),
1736 ('[a][b] x', ['a', 'b']),
1737 ('[a]\n[b]', ['a']),
1738 ('[a\nb]', []),
1739 ('[a][', ['a']),
1740 ('Revert "[a] feature"', ['a']),
1741 ('Reland "[a] feature"', ['a']),
1742 ('Revert: [a] feature', ['a']),
1743 ('Reland: [a] feature', ['a']),
1744 ('Revert "Reland: [a] feature"', ['a']),
1745 ('Foo: feature', ['foo']),
1746 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001747 ('Change Foo::Bar', []),
1748 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001749 ('Revert "Foo bar: feature"', ['foo-bar']),
1750 ('Reland "Foo bar: feature"', ['foo-bar']),
1751 ]
1752 for desc, expected in cases:
1753 change_desc = git_cl.ChangeDescription(desc)
1754 actual = change_desc.get_hash_tags()
1755 self.assertEqual(
1756 actual,
1757 expected,
1758 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1759
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001760 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001761 self.assertEqual(None, git_cl.GetTargetRef(None,
1762 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001763 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001764
wittman@chromium.org455dc922015-01-26 20:15:50 +00001765 # Check default target refs for branches.
1766 self.assertEqual('refs/heads/master',
1767 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001768 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001769 self.assertEqual('refs/heads/master',
1770 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001771 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001772 self.assertEqual('refs/heads/master',
1773 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001774 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001775 self.assertEqual('refs/branch-heads/123',
1776 git_cl.GetTargetRef('origin',
1777 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001778 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001779 self.assertEqual('refs/diff/test',
1780 git_cl.GetTargetRef('origin',
1781 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001782 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001783 self.assertEqual('refs/heads/chrome/m42',
1784 git_cl.GetTargetRef('origin',
1785 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001786 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001787
1788 # Check target refs for user-specified target branch.
1789 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1790 'refs/remotes/branch-heads/123'):
1791 self.assertEqual('refs/branch-heads/123',
1792 git_cl.GetTargetRef('origin',
1793 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001794 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001795 for branch in ('origin/master', 'remotes/origin/master',
1796 'refs/remotes/origin/master'):
1797 self.assertEqual('refs/heads/master',
1798 git_cl.GetTargetRef('origin',
1799 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001800 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001801 for branch in ('master', 'heads/master', 'refs/heads/master'):
1802 self.assertEqual('refs/heads/master',
1803 git_cl.GetTargetRef('origin',
1804 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001805 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001806
Edward Lemurda4b6c62020-02-13 00:28:40 +00001807 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1808 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001809 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001810 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1811
Edward Lemur85153282020-02-14 22:06:29 +00001812 def assertIssueAndPatchset(
1813 self, branch='master', issue='123456', patchset='7',
1814 git_short_host='chromium'):
1815 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001816 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001817 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001818 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001819 self.assertEqual(
1820 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001821 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001822
Edward Lemur85153282020-02-14 22:06:29 +00001823 def _patch_common(self, git_short_host='chromium'):
Edward Lesmes50da7702020-03-30 19:23:43 +00001824 mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
Edward Lemur26964072020-02-19 19:18:51 +00001825 self.mockGit.config['remote.origin.url'] = (
1826 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001827 gerrit_util.GetChangeDetail.return_value = {
1828 'current_revision': '7777777777',
1829 'revisions': {
1830 '1111111111': {
1831 '_number': 1,
1832 'fetch': {'http': {
1833 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1834 'ref': 'refs/changes/56/123456/1',
1835 }},
1836 },
1837 '7777777777': {
1838 '_number': 7,
1839 'fetch': {'http': {
1840 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1841 'ref': 'refs/changes/56/123456/7',
1842 }},
1843 },
1844 },
1845 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001846
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001847 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001848 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001849 self.calls += [
1850 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1851 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001852 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001853 ]
1854 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001855 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001856
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001857 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001858 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001859 self.calls += [
1860 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1861 'refs/changes/56/123456/7'],), ''),
1862 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001863 ]
Edward Lemur85153282020-02-14 22:06:29 +00001864 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1865 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001866
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001867 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001868 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001869 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001870 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001871 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001872 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001873 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001874 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001875 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001876
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001877 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001878 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001879 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001880 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001881 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001882 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001883 ]
1884 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001885 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001886 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001887
Aaron Gable697a91b2018-01-19 15:20:15 -08001888 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001889 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001890 self.calls += [
1891 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1892 'refs/changes/56/123456/1'],), ''),
1893 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001894 ]
1895 self.assertEqual(git_cl.main(
1896 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1897 0)
Edward Lemur85153282020-02-14 22:06:29 +00001898 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001899
Edward Lemurd55c5072020-02-20 01:09:07 +00001900 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001901 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001902 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001903 self.calls += [
1904 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001905 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001906 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001907 ]
1908 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001909 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001910 self.assertEqual(
1911 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1912 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001913
Edward Lemurda4b6c62020-02-13 00:28:40 +00001914 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001915 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001916 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001917 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001918 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001919 self.mockGit.config['remote.origin.url'] = (
1920 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001921 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001922 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001923 self.assertEqual(
1924 'change 123456 at https://chromium-review.googlesource.com does not '
1925 'exist or you have no access to it\n',
1926 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001927
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001928 def _checkout_calls(self):
1929 return [
1930 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001931 'branch\\..*\\.gerritissue'], ),
1932 ('branch.ger-branch.gerritissue 123456\n'
1933 'branch.gbranch654.gerritissue 654321\n')),
1934 ]
1935
1936 def test_checkout_gerrit(self):
1937 """Tests git cl checkout <issue>."""
1938 self.calls = self._checkout_calls()
1939 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1940 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1941
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001942 def test_checkout_not_found(self):
1943 """Tests git cl checkout <issue>."""
1944 self.calls = self._checkout_calls()
1945 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1946
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001947 def test_checkout_no_branch_issues(self):
1948 """Tests git cl checkout <issue>."""
1949 self.calls = [
1950 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001951 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001952 ]
1953 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1954
Edward Lemur26964072020-02-19 19:18:51 +00001955 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00001956 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001957 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001958 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001959 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1960 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001961 self.mockGit.config['remote.origin.url'] = (
1962 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001963 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001964 cl.branch = 'master'
1965 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001966 return cl
1967
Edward Lemurd55c5072020-02-20 01:09:07 +00001968 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001969 def test_gerrit_ensure_authenticated_missing(self):
1970 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001971 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001972 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001973 with self.assertRaises(SystemExitMock):
1974 cl.EnsureAuthenticated(force=False)
1975 self.assertEqual(
1976 'Credentials for the following hosts are required:\n'
1977 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001978 'These are read from ~%(sep)s.gitcookies '
1979 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00001980 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001981 'https://chromium-review.googlesource.com/new-password\n' % {
1982 'sep': os.sep,
1983 'netrc': NETRC_FILENAME,
1984 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001985
1986 def test_gerrit_ensure_authenticated_conflict(self):
1987 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001988 'chromium.googlesource.com':
1989 ('git-one.example.com', None, 'secret1'),
1990 'chromium-review.googlesource.com':
1991 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001992 })
1993 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001994 (('ask_for_data', 'If you know what you are doing '
1995 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001996 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1997
1998 def test_gerrit_ensure_authenticated_ok(self):
1999 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002000 'chromium.googlesource.com':
2001 ('git-same.example.com', None, 'secret'),
2002 'chromium-review.googlesource.com':
2003 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002004 })
2005 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2006
tandrii@chromium.org28253532016-04-14 13:46:56 +00002007 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00002008 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
2009 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00002010 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2011
Eric Boren2fb63102018-10-05 13:05:03 +00002012 def test_gerrit_ensure_authenticated_bearer_token(self):
2013 cl = self._test_gerrit_ensure_authenticated_common(auth={
2014 'chromium.googlesource.com':
2015 ('', None, 'secret'),
2016 'chromium-review.googlesource.com':
2017 ('', None, 'secret'),
2018 })
2019 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2020 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2021 'chromium.googlesource.com')
2022 self.assertTrue('Bearer' in header)
2023
Daniel Chengcf6269b2019-05-18 01:02:12 +00002024 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00002025 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00002026 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002027 (('logging.warning',
2028 'Ignoring branch %(branch)s with non-https remote '
2029 '%(remote)s', {
2030 'branch': 'master',
2031 'remote': 'custom-scheme://repo'}
2032 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00002033 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002034 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2035 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2036 mock.patch('logging.warning',
2037 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002038 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002039 cl.branch = 'master'
2040 cl.branchref = 'refs/heads/master'
2041 cl.lookedup_issue = True
2042 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2043
Florian Mayerae510e82020-01-30 21:04:48 +00002044 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00002045 self.mockGit.config['remote.origin.url'] = (
2046 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00002047 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002048 (('logging.error',
2049 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2050 'but it doesn\'t exist.', {
2051 'remote': 'origin',
2052 'branch': 'master',
2053 'url': 'git@somehost.example:foo/bar.git'}
2054 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00002055 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002056 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2057 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2058 mock.patch('logging.error',
2059 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00002060 cl = git_cl.Changelist()
2061 cl.branch = 'master'
2062 cl.branchref = 'refs/heads/master'
2063 cl.lookedup_issue = True
2064 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2065
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002066 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00002067 self.mockGit.config['branch.master.gerritissue'] = '123'
2068 self.mockGit.config['branch.master.gerritserver'] = (
2069 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00002070 self.mockGit.config['remote.origin.url'] = (
2071 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002072 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00002073 (('SetReview', 'chromium-review.googlesource.com',
2074 'infra%2Finfra~123', None,
2075 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002076 ]
tandriid9e5ce52016-07-13 02:32:59 -07002077
2078 def test_cmd_set_commit_gerrit_clear(self):
2079 self._cmd_set_commit_gerrit_common(0)
2080 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2081
2082 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002083 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002084 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2085
tandriid9e5ce52016-07-13 02:32:59 -07002086 def test_cmd_set_commit_gerrit(self):
2087 self._cmd_set_commit_gerrit_common(2)
2088 self.assertEqual(0, git_cl.main(['set-commit']))
2089
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002090 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002091 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002092 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002093
2094 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002095 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002096
Edward Lemurda4b6c62020-02-13 00:28:40 +00002097 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07002098 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07002099 try:
2100 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00002101 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00002102 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00002103 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07002104
2105 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07002106 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002107 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002108 return 'foobar'
2109
Edward Lemurda4b6c62020-02-13 00:28:40 +00002110 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07002111 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002112 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002113 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00002114 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07002115
iannuccie53c9352016-08-17 14:40:40 -07002116 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002117
iannuccie53c9352016-08-17 14:40:40 -07002118 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002119 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002120 return 'foobar'
2121
Edward Lemurda4b6c62020-02-13 00:28:40 +00002122 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2123 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002124 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002125 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002126
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002127 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00002128 self.mockGit.config['remote.origin.url'] = (
2129 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002130 gerrit_util.GetChangeDetail.return_value = {
2131 'current_revision': 'sha1',
2132 'revisions': {'sha1': {
2133 'commit': {'message': 'foobar'},
2134 }},
2135 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002136 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002137 'description',
2138 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2139 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002140 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002141
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002142 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002143 mock.patch('git_cl.Changelist', ChangelistMock).start()
2144 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002145
2146 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2147 self.assertEqual('hihi', ChangelistMock.desc)
2148
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002149 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002150 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002151
2152 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002153 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002154 '# Enter a description of the change.\n'
2155 '# This will be displayed on the codereview site.\n'
2156 '# The first line will also be used as the subject of the review.\n'
2157 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002158 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002159 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002160 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002161 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002162 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002163
Edward Lemur6c6827c2020-02-06 21:15:18 +00002164 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002165 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002166
Edward Lemurda4b6c62020-02-13 00:28:40 +00002167 mock.patch('git_cl.Changelist.FetchDescription',
2168 lambda *args: current_desc).start()
2169 mock.patch('git_cl.Changelist.UpdateDescription',
2170 UpdateDescription).start()
2171 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002172
Edward Lemur85153282020-02-14 22:06:29 +00002173 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002174 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002175
Dan Beamd8b04ca2019-10-10 21:23:26 +00002176 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2177 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2178
2179 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002180 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002181 '# Enter a description of the change.\n'
2182 '# This will be displayed on the codereview site.\n'
2183 '# The first line will also be used as the subject of the review.\n'
2184 '#--------------------This line is 72 characters long'
2185 '--------------------\n'
2186 'Some.\n\nFixed: 123\nChange-Id: xxx',
2187 desc)
2188 return desc
2189
Edward Lemurda4b6c62020-02-13 00:28:40 +00002190 mock.patch('git_cl.Changelist.FetchDescription',
2191 lambda *args: current_desc).start()
2192 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002193
Edward Lemur85153282020-02-14 22:06:29 +00002194 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002195 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002196
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002197 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002198 mock.patch('git_cl.Changelist', ChangelistMock).start()
2199 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002200
2201 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2202 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2203
kmarshall3bff56b2016-06-06 18:31:47 -07002204 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002205 self.calls = [
2206 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002207 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002208 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002209 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002210 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002211 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002212
Edward Lemurda4b6c62020-02-13 00:28:40 +00002213 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002214 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002215 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2216 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002217 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002218
2219 self.assertEqual(0, git_cl.main(['archive', '-f']))
2220
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002221 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002222 self.calls = [
2223 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2224 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2225 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2226 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002227 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2228 ((['git', 'branch', '-D', 'foo'],), '')
2229 ]
2230
Edward Lemurda4b6c62020-02-13 00:28:40 +00002231 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002232 lambda branches, fine_grained, max_processes:
2233 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2234 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002235 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002236
2237 self.assertEqual(0, git_cl.main(['archive', '-f']))
2238
kmarshall3bff56b2016-06-06 18:31:47 -07002239 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002240 self.calls = [
2241 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2242 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002243 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002244 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002245
Edward Lemurda4b6c62020-02-13 00:28:40 +00002246 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002247 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002248 [(MockChangelistWithBranchAndIssue('master', 1),
2249 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002250
2251 self.assertEqual(1, git_cl.main(['archive', '-f']))
2252
2253 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002254 self.calls = [
2255 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2256 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002257 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002258 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002259
Edward Lemurda4b6c62020-02-13 00:28:40 +00002260 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002261 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002262 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2263 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002264 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002265
kmarshall9249e012016-08-23 12:02:16 -07002266 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2267
2268 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002269 self.calls = [
2270 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2271 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002272 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002273 ((['git', 'branch', '-D', 'foo'],), '')
2274 ]
kmarshall9249e012016-08-23 12:02:16 -07002275
Edward Lemurda4b6c62020-02-13 00:28:40 +00002276 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002277 lambda branches, fine_grained, max_processes:
2278 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2279 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002280 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002281
2282 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002283
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002284 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002285 self.calls = [
2286 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2287 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2288 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002289 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2290 'refs/tags/git-cl-archived-456-foo'),
2291 ((['git', 'branch', '-D', 'foo'],), CERR1),
2292 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2293 'refs/tags/git-cl-archived-456-foo'),
2294 ]
2295
Edward Lemurda4b6c62020-02-13 00:28:40 +00002296 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002297 lambda branches, fine_grained, max_processes:
2298 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2299 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002300 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002301
2302 self.assertEqual(0, git_cl.main(['archive', '-f']))
2303
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002304 def test_archive_with_format(self):
2305 self.calls = [
2306 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
2307 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2308 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2309 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2310 ((['git', 'branch', '-D', 'foo'], ), ''),
2311 ]
2312
2313 mock.patch('git_cl.get_cl_statuses',
2314 lambda branches, fine_grained, max_processes:
2315 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2316
2317 self.assertEqual(
2318 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2319
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002320 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002321 self.mockGit.config['branch.master.gerritissue'] = '123'
2322 self.mockGit.config['branch.master.gerritserver'] = (
2323 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002324 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002325 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002326 ]
2327 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002328 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2329 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002330
Aaron Gable400e9892017-07-12 15:31:21 -07002331 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002332 self.mockGit.config['branch.master.gerritissue'] = '123'
2333 self.mockGit.config['branch.master.gerritserver'] = (
2334 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002335 mock.patch('git_cl.Changelist.FetchDescription',
2336 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002337 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002338 ((['git', 'log', '-1', '--format=%B'],),
2339 'This is a description\n\nChange-Id: Ideadbeef'),
2340 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002341 ]
2342 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002343 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2344 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002345
phajdan.jre328cf92016-08-22 04:12:17 -07002346 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002347 self.mockGit.config['branch.master.gerritissue'] = '123'
2348 self.mockGit.config['branch.master.gerritserver'] = (
2349 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002350 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002351 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002352 {'issue': 123,
2353 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002354 ''),
2355 ]
2356 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2357
tandrii16e0b4e2016-06-07 10:34:28 -07002358 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002359 mock.patch(
2360 'git_cl.os.path.abspath',
2361 lambda path: self._mocked_call(['abspath', path])).start()
2362 mock.patch(
2363 'git_cl.os.path.exists',
2364 lambda path: self._mocked_call(['exists', path])).start()
2365 mock.patch(
2366 'git_cl.gclient_utils.FileRead',
2367 lambda path: self._mocked_call(['FileRead', path])).start()
2368 mock.patch(
2369 'git_cl.gclient_utils.rm_file_or_tree',
2370 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002371 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002372 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002373 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002374 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002375
2376 def test_GerritCommitMsgHookCheck_custom_hook(self):
2377 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002378 self.calls += [((['exists',
2379 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2380 ((['FileRead',
2381 os.path.join('.git', 'hooks', 'commit-msg')], ),
2382 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002383 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002384
2385 def test_GerritCommitMsgHookCheck_not_exists(self):
2386 cl = self._common_GerritCommitMsgHookCheck()
2387 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002388 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002389 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002390 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002391
2392 def test_GerritCommitMsgHookCheck(self):
2393 cl = self._common_GerritCommitMsgHookCheck()
2394 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002395 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2396 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002397 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002398 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002399 ((['rm_file_or_tree',
2400 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002401 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002402 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002403
tandriic4344b52016-08-29 06:04:54 -07002404 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002405 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2406 self.mockGit.config['branch.master.gerritserver'] = (
2407 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002408 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002409 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002410 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002411 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002412 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002413 'labels': {},
2414 'current_revision': 'deadbeaf',
2415 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002416 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002417 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002418 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002419 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2420 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002421 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002422 self.assertEqual(0, cl.CMDLand(force=True,
2423 bypass_hooks=True,
2424 verbose=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002425 parallel=False,
2426 resultdb=False,
2427 realm=None))
Edward Lemur73c76702020-02-06 23:57:18 +00002428 self.assertIn(
2429 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002430 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002431 self.assertIn(
2432 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002433 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002434
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002435 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002436 mock.patch('git_cl.Changelist.GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002437
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002438 def test_gerrit_change_detail_cache_simple(self):
2439 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002440 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002441 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002442 cl1._cached_remote_url = (
2443 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002444 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002445 cl2._cached_remote_url = (
2446 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002447 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2448 self.assertEqual(cl1._GetChangeDetail(), 'a')
2449 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002450
2451 def test_gerrit_change_detail_cache_options(self):
2452 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002453 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002454 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002455 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002456 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2457 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2458 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2459 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2460 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2461 self.assertEqual(cl._GetChangeDetail(), 'cab')
2462
2463 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2464 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2465 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2466 self.assertEqual(cl._GetChangeDetail(), 'cab')
2467
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002468 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002469 gerrit_util.GetChangeDetail.return_value = {
2470 'current_revision': 'rev1',
2471 'revisions': {
2472 'rev1': {'commit': {'message': 'desc1'}},
2473 },
2474 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002475
2476 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002477 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002478 cl._cached_remote_url = (
2479 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002480 self.assertEqual(cl.FetchDescription(), 'desc1')
2481 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002482
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002483 def test_print_current_creds(self):
2484 class CookiesAuthenticatorMock(object):
2485 def __init__(self):
2486 self.gitcookies = {
2487 'host.googlesource.com': ('user', 'pass'),
2488 'host-review.googlesource.com': ('user', 'pass'),
2489 }
2490 self.netrc = self
2491 self.netrc.hosts = {
2492 'github.com': ('user2', None, 'pass2'),
2493 'host2.googlesource.com': ('user3', None, 'pass'),
2494 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002495 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2496 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002497 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2498 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2499 ' Host\t User\t Which file',
2500 '============================\t=====\t===========',
2501 'host-review.googlesource.com\t user\t.gitcookies',
2502 ' host.googlesource.com\t user\t.gitcookies',
2503 ' host2.googlesource.com\tuser3\t .netrc',
2504 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002505 sys.stdout.seek(0)
2506 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002507 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2508 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2509 ' Host\tUser\t Which file',
2510 '============================\t====\t===========',
2511 'host-review.googlesource.com\tuser\t.gitcookies',
2512 ' host.googlesource.com\tuser\t.gitcookies',
2513 ])
2514
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002515 def _common_creds_check_mocks(self):
2516 def exists_mock(path):
2517 dirname = os.path.dirname(path)
2518 if dirname == os.path.expanduser('~'):
2519 dirname = '~'
2520 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002521 if base in (NETRC_FILENAME, '.gitcookies'):
2522 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002523 # git cl also checks for existence other files not relevant to this test.
2524 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002525 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002526 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002527 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002528 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002529
2530 def test_creds_check_gitcookies_not_configured(self):
2531 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002532 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2533 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002534 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002535 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2536 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2537 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2538 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2539 'or Ctrl+C to abort'), ''),
2540 (([
2541 'git', 'config', '--global', 'http.cookiefile',
2542 os.path.expanduser(os.path.join('~', '.gitcookies'))
2543 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002544 ]
2545 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002546 self.assertTrue(
2547 sys.stdout.getvalue().startswith(
2548 'You seem to be using outdated .netrc for git credentials:'))
2549 self.assertIn(
2550 '\nConfigured git to use .gitcookies from',
2551 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002552
2553 def test_creds_check_gitcookies_configured_custom_broken(self):
2554 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002555 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2556 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002557 custom_cookie_path = ('C:\\.gitcookies'
2558 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002559 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002560 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2561 ((['git', 'config', '--global', 'http.cookiefile'], ),
2562 custom_cookie_path),
2563 (('os.path.exists', custom_cookie_path), False),
2564 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2565 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2566 (([
2567 'git', 'config', '--global', 'http.cookiefile',
2568 os.path.expanduser(os.path.join('~', '.gitcookies'))
2569 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002570 ]
2571 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002572 self.assertIn(
2573 'WARNING: You have configured custom path to .gitcookies: ',
2574 sys.stdout.getvalue())
2575 self.assertIn(
2576 'However, your configured .gitcookies file is missing.',
2577 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002578
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002579 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002580 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002581 self.mockGit.config['remote.origin.url'] = (
2582 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002583 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002584 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002585 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002586 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002587 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002588 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002589
Edward Lemurda4b6c62020-02-13 00:28:40 +00002590 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2591 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002592 self.mockGit.config['remote.origin.url'] = (
2593 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002594 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002595 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002596 'current_revision': 'ba5eba11',
2597 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002598 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002599 '_number': 1,
2600 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002601 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002602 '_number': 2,
2603 },
2604 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002605 'messages': [
2606 {
2607 u'_revision_number': 1,
2608 u'author': {
2609 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002610 u'email': u'could-be-anything@example.com',
2611 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002612 },
2613 u'date': u'2017-03-15 20:08:45.000000000',
2614 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002615 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002616 u'tag': u'autogenerated:cq:dry-run'
2617 },
2618 {
2619 u'_revision_number': 2,
2620 u'author': {
2621 u'_account_id': 11151243,
2622 u'email': u'owner@example.com',
2623 u'name': u'owner'
2624 },
2625 u'date': u'2017-03-16 20:00:41.000000000',
2626 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2627 u'message': u'PTAL',
2628 },
2629 {
2630 u'_revision_number': 2,
2631 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002632 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002633 u'email': u'reviewer@example.com',
2634 u'name': u'reviewer'
2635 },
2636 u'date': u'2017-03-17 05:19:37.500000000',
2637 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2638 u'message': u'Patch Set 2: Code-Review+1',
2639 },
2640 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002641 }
2642 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002643 (('GetChangeComments', 'chromium-review.googlesource.com',
2644 'infra%2Finfra~1'), {
2645 '/COMMIT_MSG': [
2646 {
2647 'author': {
2648 'email': u'reviewer@example.com'
2649 },
2650 'updated': u'2017-03-17 05:19:37.500000000',
2651 'patch_set': 2,
2652 'side': 'REVISION',
2653 'message': 'Please include a bug link',
2654 },
2655 ],
2656 'codereview.settings': [
2657 {
2658 'author': {
2659 'email': u'owner@example.com'
2660 },
2661 'updated': u'2017-03-16 20:00:41.000000000',
2662 'patch_set': 2,
2663 'side': 'PARENT',
2664 'line': 42,
2665 'message': 'I removed this because it is bad',
2666 },
2667 ]
2668 }),
2669 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2670 'infra%2Finfra~1'), {}),
2671 ] * 2 + [(('write_json', 'output.json', [{
2672 u'date':
2673 u'2017-03-16 20:00:41.000000',
2674 u'message': (u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2675 u' Base, Line 42: https://crrev.com/c/1/2/'
2676 u'codereview.settings#b42\n' +
2677 u' I removed this because it is bad\n'),
2678 u'autogenerated':
2679 False,
2680 u'approval':
2681 False,
2682 u'disapproval':
2683 False,
2684 u'sender':
2685 u'owner@example.com'
2686 }, {
2687 u'date':
2688 u'2017-03-17 05:19:37.500000',
2689 u'message':
2690 (u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2691 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
2692 u' Please include a bug link\n'),
2693 u'autogenerated':
2694 False,
2695 u'approval':
2696 False,
2697 u'disapproval':
2698 False,
2699 u'sender':
2700 u'reviewer@example.com'
2701 }]), '')]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002702 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002703 git_cl._CommentSummary(
2704 message=(u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2705 u' Base, Line 42: https://crrev.com/c/1/2/' +
2706 u'codereview.settings#b42\n' +
2707 u' I removed this because it is bad\n'),
2708 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2709 autogenerated=False,
2710 disapproval=False,
2711 approval=False,
2712 sender=u'owner@example.com'),
2713 git_cl._CommentSummary(message=(
2714 u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2715 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002716 u' Please include a bug link\n'),
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002717 date=datetime.datetime(2017, 3, 17, 5, 19, 37,
2718 500000),
2719 autogenerated=False,
2720 disapproval=False,
2721 approval=False,
2722 sender=u'reviewer@example.com'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002723 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002724 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002725 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002726 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002727 self.assertEqual(
2728 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2729
2730 def test_git_cl_comments_robot_comments(self):
2731 # git cl comments also fetches robot comments (which are considered a type
2732 # of autogenerated comment), and unlike other types of comments, only robot
2733 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002734 self.mockGit.config['remote.origin.url'] = (
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002735 'https://x.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002736 gerrit_util.GetChangeDetail.return_value = {
2737 'owner': {'email': 'owner@example.com'},
2738 'current_revision': 'ba5eba11',
2739 'revisions': {
2740 'deadbeaf': {
2741 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002742 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002743 'ba5eba11': {
2744 '_number': 2,
2745 },
2746 },
2747 'messages': [
2748 {
2749 u'_revision_number': 1,
2750 u'author': {
2751 u'_account_id': 1111084,
2752 u'email': u'commit-bot@chromium.org',
2753 u'name': u'Commit Bot'
2754 },
2755 u'date': u'2017-03-15 20:08:45.000000000',
2756 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2757 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2758 u'tag': u'autogenerated:cq:dry-run'
2759 },
2760 {
2761 u'_revision_number': 1,
2762 u'author': {
2763 u'_account_id': 123,
2764 u'email': u'tricium@serviceaccount.com',
2765 u'name': u'Tricium'
2766 },
2767 u'date': u'2017-03-16 20:00:41.000000000',
2768 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2769 u'message': u'(1 comment)',
2770 u'tag': u'autogenerated:tricium',
2771 },
2772 {
2773 u'_revision_number': 1,
2774 u'author': {
2775 u'_account_id': 123,
2776 u'email': u'tricium@serviceaccount.com',
2777 u'name': u'Tricium'
2778 },
2779 u'date': u'2017-03-16 20:00:41.000000000',
2780 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2781 u'message': u'(1 comment)',
2782 u'tag': u'autogenerated:tricium',
2783 },
2784 {
2785 u'_revision_number': 2,
2786 u'author': {
2787 u'_account_id': 123,
2788 u'email': u'tricium@serviceaccount.com',
2789 u'name': u'reviewer'
2790 },
2791 u'date': u'2017-03-17 05:30:37.000000000',
2792 u'tag': u'autogenerated:tricium',
2793 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2794 u'message': u'(1 comment)',
2795 },
2796 ]
2797 }
2798 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002799 (('GetChangeComments', 'x-review.googlesource.com', 'infra%2Finfra~1'),
2800 {}),
2801 (('GetChangeRobotComments', 'x-review.googlesource.com',
2802 'infra%2Finfra~1'), {
2803 'codereview.settings': [
2804 {
2805 u'author': {
2806 u'email': u'tricium@serviceaccount.com'
2807 },
2808 u'updated': u'2017-03-17 05:30:37.000000000',
2809 u'robot_run_id': u'5565031076855808',
2810 u'robot_id': u'Linter/Category',
2811 u'tag': u'autogenerated:tricium',
2812 u'patch_set': 2,
2813 u'side': u'REVISION',
2814 u'message': u'Linter warning message text',
2815 u'line': 32,
2816 },
2817 ],
2818 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002819 ]
2820 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002821 git_cl._CommentSummary(
2822 date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2823 message=(u'(1 comment)\n\ncodereview.settings\n'
2824 u' PS2, Line 32: https://x-review.googlesource.com/c/1/2/'
2825 u'codereview.settings#32\n'
2826 u' Linter warning message text\n'),
2827 sender=u'tricium@serviceaccount.com',
2828 autogenerated=True,
2829 approval=False,
2830 disapproval=False)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002831 ]
2832 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002833 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002834 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002835
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002836 def test_get_remote_url_with_mirror(self):
2837 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002838
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002839 def selective_os_path_isdir_mock(path):
2840 if path == '/cache/this-dir-exists':
2841 return self._mocked_call('os.path.isdir', path)
2842 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002843
Edward Lemurda4b6c62020-02-13 00:28:40 +00002844 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002845
2846 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002847 self.mockGit.config['remote.origin.url'] = (
2848 '/cache/this-dir-exists')
2849 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2850 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002851 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002852 (('os.path.isdir', '/cache/this-dir-exists'),
2853 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002854 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002855 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002856 self.assertEqual(cl.GetRemoteUrl(), url)
2857 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2858
Edward Lemur298f2cf2019-02-22 21:40:39 +00002859 def test_get_remote_url_non_existing_mirror(self):
2860 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002861
Edward Lemur298f2cf2019-02-22 21:40:39 +00002862 def selective_os_path_isdir_mock(path):
2863 if path == '/cache/this-dir-doesnt-exist':
2864 return self._mocked_call('os.path.isdir', path)
2865 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002866
Edward Lemurda4b6c62020-02-13 00:28:40 +00002867 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2868 mock.patch('logging.error',
2869 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002870
Edward Lemur26964072020-02-19 19:18:51 +00002871 self.mockGit.config['remote.origin.url'] = (
2872 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002873 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002874 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2875 False),
2876 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002877 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2878 'but it doesn\'t exist.', {
2879 'remote': 'origin',
2880 'branch': 'master',
2881 'url': '/cache/this-dir-doesnt-exist'}
2882 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002883 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002884 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002885 self.assertIsNone(cl.GetRemoteUrl())
2886
2887 def test_get_remote_url_misconfigured_mirror(self):
2888 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002889
Edward Lemur298f2cf2019-02-22 21:40:39 +00002890 def selective_os_path_isdir_mock(path):
2891 if path == '/cache/this-dir-exists':
2892 return self._mocked_call('os.path.isdir', path)
2893 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002894
Edward Lemurda4b6c62020-02-13 00:28:40 +00002895 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2896 mock.patch('logging.error',
2897 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002898
Edward Lemur26964072020-02-19 19:18:51 +00002899 self.mockGit.config['remote.origin.url'] = (
2900 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002901 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002902 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002903 (('logging.error',
2904 'Remote "%(remote)s" for branch "%(branch)s" points to '
2905 '"%(cache_path)s", but it is misconfigured.\n'
2906 '"%(cache_path)s" must be a git repo and must have a remote named '
2907 '"%(remote)s" pointing to the git host.', {
2908 'remote': 'origin',
2909 'cache_path': '/cache/this-dir-exists',
2910 'branch': 'master'}
2911 ), None),
2912 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002913 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002914 self.assertIsNone(cl.GetRemoteUrl())
2915
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002916 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002917 self.mockGit.config['remote.origin.url'] = (
2918 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002919 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002920 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2921
2922 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002923 mock.patch('logging.error',
2924 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002925
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002926 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002927 (('logging.error',
2928 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2929 'but it doesn\'t exist.', {
2930 'remote': 'origin',
2931 'branch': 'master',
2932 'url': ''}
2933 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002934 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002935 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002936 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002937
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002938 def test_gerrit_new_default(self):
2939 self._run_gerrit_upload_test(
2940 [],
2941 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
2942 [],
2943 squash=False,
2944 squash_mode='override_nosquash',
2945 change_id='I123456789',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002946 default_branch='main')
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002947
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002948
Edward Lemur9aa1a962020-02-25 00:58:38 +00002949class ChangelistTest(unittest.TestCase):
Edward Lemur227d5102020-02-25 23:45:35 +00002950 def setUp(self):
2951 super(ChangelistTest, self).setUp()
2952 mock.patch('gclient_utils.FileRead').start()
2953 mock.patch('gclient_utils.FileWrite').start()
2954 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
2955 mock.patch(
2956 'git_cl.Changelist.GetCodereviewServer',
2957 return_value='https://chromium-review.googlesource.com').start()
2958 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
2959 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
2960 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
2961 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
2962 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
2963 mock.patch('git_cl.time_time').start()
2964 mock.patch('metrics.collector').start()
2965 mock.patch('subprocess2.Popen').start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002966 mock.patch('git_cl.Changelist.GetGerritProject',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002967 return_value='https://chromium-review.googlesource.com').start()
Edward Lemur227d5102020-02-25 23:45:35 +00002968 self.addCleanup(mock.patch.stopall)
2969 self.temp_count = 0
2970
Edward Lemur227d5102020-02-25 23:45:35 +00002971 def testRunHook(self):
2972 expected_results = {
2973 'more_cc': ['more@example.com', 'cc@example.com'],
2974 'should_continue': True,
2975 }
2976 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2977 git_cl.time_time.side_effect = [100, 200]
2978 mockProcess = mock.Mock()
2979 mockProcess.wait.return_value = 0
2980 subprocess2.Popen.return_value = mockProcess
2981
2982 cl = git_cl.Changelist()
2983 results = cl.RunHook(
2984 committing=True,
2985 may_prompt=True,
2986 verbose=2,
2987 parallel=True,
2988 upstream='upstream',
2989 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002990 all_files=True,
2991 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00002992
2993 self.assertEqual(expected_results, results)
2994 subprocess2.Popen.assert_called_once_with([
2995 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00002996 '--root', 'root',
2997 '--upstream', 'upstream',
2998 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002999 '--author', 'author',
3000 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00003001 '--issue', '123456',
3002 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003003 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00003004 '--may_prompt',
3005 '--parallel',
3006 '--all_files',
3007 '--json_output', '/tmp/fake-temp2',
3008 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00003009 '--gerrit_project', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00003010 ])
3011 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00003012 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00003013 metrics.collector.add_repeated('sub_commands', {
3014 'command': 'presubmit',
3015 'execution_time': 100,
3016 'exit_code': 0,
3017 })
3018
Edward Lemur99df04e2020-03-05 19:39:43 +00003019 def testRunHook_FewerOptions(self):
3020 expected_results = {
3021 'more_cc': ['more@example.com', 'cc@example.com'],
3022 'should_continue': True,
3023 }
3024 gclient_utils.FileRead.return_value = json.dumps(expected_results)
3025 git_cl.time_time.side_effect = [100, 200]
3026 mockProcess = mock.Mock()
3027 mockProcess.wait.return_value = 0
3028 subprocess2.Popen.return_value = mockProcess
3029
3030 git_cl.Changelist.GetAuthor.return_value = None
3031 git_cl.Changelist.GetIssue.return_value = None
3032 git_cl.Changelist.GetPatchset.return_value = None
3033 git_cl.Changelist.GetCodereviewServer.return_value = None
3034
3035 cl = git_cl.Changelist()
3036 results = cl.RunHook(
3037 committing=False,
3038 may_prompt=False,
3039 verbose=0,
3040 parallel=False,
3041 upstream='upstream',
3042 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003043 all_files=False,
3044 resultdb=False)
Edward Lemur99df04e2020-03-05 19:39:43 +00003045
3046 self.assertEqual(expected_results, results)
3047 subprocess2.Popen.assert_called_once_with([
3048 'vpython', 'PRESUBMIT_SUPPORT',
3049 '--root', 'root',
3050 '--upstream', 'upstream',
3051 '--upload',
3052 '--json_output', '/tmp/fake-temp2',
3053 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00003054 '--gerrit_project', 'https://chromium-review.googlesource.com',
Edward Lemur99df04e2020-03-05 19:39:43 +00003055 ])
3056 gclient_utils.FileWrite.assert_called_once_with(
3057 '/tmp/fake-temp1', 'description')
3058 metrics.collector.add_repeated('sub_commands', {
3059 'command': 'presubmit',
3060 'execution_time': 100,
3061 'exit_code': 0,
3062 })
3063
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003064 def testRunHook_FewerOptionsResultDB(self):
3065 expected_results = {
3066 'more_cc': ['more@example.com', 'cc@example.com'],
3067 'should_continue': True,
3068 }
3069 gclient_utils.FileRead.return_value = json.dumps(expected_results)
3070 git_cl.time_time.side_effect = [100, 200]
3071 mockProcess = mock.Mock()
3072 mockProcess.wait.return_value = 0
3073 subprocess2.Popen.return_value = mockProcess
3074
3075 git_cl.Changelist.GetAuthor.return_value = None
3076 git_cl.Changelist.GetIssue.return_value = None
3077 git_cl.Changelist.GetPatchset.return_value = None
3078 git_cl.Changelist.GetCodereviewServer.return_value = None
3079
3080 cl = git_cl.Changelist()
3081 results = cl.RunHook(
3082 committing=False,
3083 may_prompt=False,
3084 verbose=0,
3085 parallel=False,
3086 upstream='upstream',
3087 description='description',
3088 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003089 resultdb=True,
3090 realm='chromium:public')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003091
3092 self.assertEqual(expected_results, results)
3093 subprocess2.Popen.assert_called_once_with([
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003094 'rdb', 'stream', '-new', '-realm', 'chromium:public', '--',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003095 'vpython', 'PRESUBMIT_SUPPORT',
3096 '--root', 'root',
3097 '--upstream', 'upstream',
3098 '--upload',
3099 '--json_output', '/tmp/fake-temp2',
3100 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00003101 '--gerrit_project', 'https://chromium-review.googlesource.com',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003102 ])
3103
Edward Lemur227d5102020-02-25 23:45:35 +00003104 @mock.patch('sys.exit', side_effect=SystemExitMock)
3105 def testRunHook_Failure(self, _mock):
3106 git_cl.time_time.side_effect = [100, 200]
3107 mockProcess = mock.Mock()
3108 mockProcess.wait.return_value = 2
3109 subprocess2.Popen.return_value = mockProcess
3110
3111 cl = git_cl.Changelist()
3112 with self.assertRaises(SystemExitMock):
3113 cl.RunHook(
3114 committing=True,
3115 may_prompt=True,
3116 verbose=2,
3117 parallel=True,
3118 upstream='upstream',
3119 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003120 all_files=True,
3121 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003122
3123 sys.exit.assert_called_once_with(2)
3124
Edward Lemur75526302020-02-27 22:31:05 +00003125 def testRunPostUploadHook(self):
3126 cl = git_cl.Changelist()
3127 cl.RunPostUploadHook(2, 'upstream', 'description')
3128
3129 subprocess2.Popen.assert_called_once_with([
3130 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00003131 '--root', 'root',
3132 '--upstream', 'upstream',
3133 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00003134 '--author', 'author',
3135 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur75526302020-02-27 22:31:05 +00003136 '--issue', '123456',
3137 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003138 '--post_upload',
3139 '--description_file', '/tmp/fake-temp1',
3140 ])
3141 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00003142 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00003143
Edward Lemur9aa1a962020-02-25 00:58:38 +00003144
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003145class CMDTestCaseBase(unittest.TestCase):
3146 _STATUSES = [
3147 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3148 'INFRA_FAILURE', 'CANCELED',
3149 ]
3150 _CHANGE_DETAIL = {
3151 'project': 'depot_tools',
3152 'status': 'OPEN',
3153 'owner': {'email': 'owner@e.mail'},
3154 'current_revision': 'beeeeeef',
3155 'revisions': {
Gavin Make61ccc52020-11-13 00:12:57 +00003156 'deadbeaf': {
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003157 '_number': 6,
Gavin Make61ccc52020-11-13 00:12:57 +00003158 'kind': 'REWORK',
3159 },
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003160 'beeeeeef': {
3161 '_number': 7,
Gavin Make61ccc52020-11-13 00:12:57 +00003162 'kind': 'NO_CODE_CHANGE',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003163 'fetch': {'http': {
3164 'url': 'https://chromium.googlesource.com/depot_tools',
3165 'ref': 'refs/changes/56/123456/7'
3166 }},
3167 },
3168 },
3169 }
3170 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003171 'builds': [{
3172 'id': str(100 + idx),
3173 'builder': {
3174 'project': 'chromium',
3175 'bucket': 'try',
3176 'builder': 'bot_' + status.lower(),
3177 },
3178 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3179 'tags': [],
3180 'status': status,
3181 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003182 }
3183
Edward Lemur4c707a22019-09-24 21:13:43 +00003184 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003185 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003186 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003187 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3188 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003189 mock.patch(
3190 'git_cl.Changelist.GetCodereviewServer',
3191 return_value='https://chromium-review.googlesource.com').start()
3192 mock.patch(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00003193 'git_cl.Changelist.GetGerritHost',
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003194 return_value='chromium-review.googlesource.com').start()
3195 mock.patch(
3196 'git_cl.Changelist.GetMostRecentPatchset',
3197 return_value=7).start()
3198 mock.patch(
Gavin Make61ccc52020-11-13 00:12:57 +00003199 'git_cl.Changelist.GetMostRecentDryRunPatchset',
3200 return_value=6).start()
3201 mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003202 'git_cl.Changelist.GetRemoteUrl',
3203 return_value='https://chromium.googlesource.com/depot_tools').start()
3204 mock.patch(
3205 'auth.Authenticator',
3206 return_value=AuthenticatorMock()).start()
3207 mock.patch(
3208 'gerrit_util.GetChangeDetail',
3209 return_value=self._CHANGE_DETAIL).start()
3210 mock.patch(
3211 'git_cl._call_buildbucket',
3212 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003213 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003214 self.addCleanup(mock.patch.stopall)
3215
Edward Lemur4c707a22019-09-24 21:13:43 +00003216
Edward Lemur9468eba2020-02-27 19:07:22 +00003217class CMDPresubmitTestCase(CMDTestCaseBase):
3218 def setUp(self):
3219 super(CMDPresubmitTestCase, self).setUp()
3220 mock.patch(
3221 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3222 return_value='upstream').start()
3223 mock.patch(
3224 'git_cl.Changelist.FetchDescription',
3225 return_value='fetch description').start()
3226 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00003227 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00003228 return_value='get description').start()
3229 mock.patch('git_cl.Changelist.RunHook').start()
3230
3231 def testDefaultCase(self):
3232 self.assertEqual(0, git_cl.main(['presubmit']))
3233 git_cl.Changelist.RunHook.assert_called_once_with(
3234 committing=True,
3235 may_prompt=False,
3236 verbose=0,
3237 parallel=None,
3238 upstream='upstream',
3239 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003240 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003241 resultdb=None,
3242 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003243
3244 def testNoIssue(self):
3245 git_cl.Changelist.GetIssue.return_value = None
3246 self.assertEqual(0, git_cl.main(['presubmit']))
3247 git_cl.Changelist.RunHook.assert_called_once_with(
3248 committing=True,
3249 may_prompt=False,
3250 verbose=0,
3251 parallel=None,
3252 upstream='upstream',
3253 description='get description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003254 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003255 resultdb=None,
3256 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003257
3258 def testCustomBranch(self):
3259 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3260 git_cl.Changelist.RunHook.assert_called_once_with(
3261 committing=True,
3262 may_prompt=False,
3263 verbose=0,
3264 parallel=None,
3265 upstream='custom_branch',
3266 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003267 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003268 resultdb=None,
3269 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003270
3271 def testOptions(self):
3272 self.assertEqual(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003273 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003274 '--resultdb', '--realm', 'chromium:public']))
Edward Lemur9468eba2020-02-27 19:07:22 +00003275 git_cl.Changelist.RunHook.assert_called_once_with(
3276 committing=False,
3277 may_prompt=False,
3278 verbose=2,
3279 parallel=True,
3280 upstream='upstream',
3281 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003282 all_files=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003283 resultdb=True,
3284 realm='chromium:public')
Edward Lemur9468eba2020-02-27 19:07:22 +00003285
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003286class CMDTryResultsTestCase(CMDTestCaseBase):
3287 _DEFAULT_REQUEST = {
3288 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003289 "gerritChanges": [{
3290 "project": "depot_tools",
3291 "host": "chromium-review.googlesource.com",
Gavin Make61ccc52020-11-13 00:12:57 +00003292 "patchset": 6,
3293 "change": 123456,
3294 }],
3295 },
3296 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3297 ',builds.*.createTime,builds.*.tags'),
3298 }
3299
3300 _TRIVIAL_REQUEST = {
3301 'predicate': {
3302 "gerritChanges": [{
3303 "project": "depot_tools",
3304 "host": "chromium-review.googlesource.com",
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003305 "patchset": 7,
3306 "change": 123456,
3307 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003308 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003309 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3310 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003311 }
3312
3313 def testNoJobs(self):
3314 git_cl._call_buildbucket.return_value = {}
3315
3316 self.assertEqual(0, git_cl.main(['try-results']))
3317 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3318 git_cl._call_buildbucket.assert_called_once_with(
3319 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3320 self._DEFAULT_REQUEST)
3321
Gavin Make61ccc52020-11-13 00:12:57 +00003322 def testTrivialCommits(self):
3323 self.assertEqual(0, git_cl.main(['try-results']))
3324 git_cl._call_buildbucket.assert_called_with(
3325 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3326 self._DEFAULT_REQUEST)
3327
3328 git_cl._call_buildbucket.return_value = {}
3329 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '7']))
3330 git_cl._call_buildbucket.assert_called_with(
3331 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3332 self._TRIVIAL_REQUEST)
3333 self.assertEqual([
3334 'Successes:',
3335 ' bot_success https://ci.chromium.org/b/103',
3336 'Infra Failures:',
3337 ' bot_infra_failure https://ci.chromium.org/b/105',
3338 'Failures:',
3339 ' bot_failure https://ci.chromium.org/b/104',
3340 'Canceled:',
3341 ' bot_canceled ',
3342 'Started:',
3343 ' bot_started https://ci.chromium.org/b/102',
3344 'Scheduled:',
3345 ' bot_scheduled id=101',
3346 'Other:',
3347 ' bot_status_unspecified id=100',
3348 'Total: 7 tryjobs',
3349 'No tryjobs scheduled.',
3350 ], sys.stdout.getvalue().splitlines())
3351
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003352 def testPrintToStdout(self):
3353 self.assertEqual(0, git_cl.main(['try-results']))
3354 self.assertEqual([
3355 'Successes:',
3356 ' bot_success https://ci.chromium.org/b/103',
3357 'Infra Failures:',
3358 ' bot_infra_failure https://ci.chromium.org/b/105',
3359 'Failures:',
3360 ' bot_failure https://ci.chromium.org/b/104',
3361 'Canceled:',
3362 ' bot_canceled ',
3363 'Started:',
3364 ' bot_started https://ci.chromium.org/b/102',
3365 'Scheduled:',
3366 ' bot_scheduled id=101',
3367 'Other:',
3368 ' bot_status_unspecified id=100',
3369 'Total: 7 tryjobs',
3370 ], sys.stdout.getvalue().splitlines())
3371 git_cl._call_buildbucket.assert_called_once_with(
3372 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3373 self._DEFAULT_REQUEST)
3374
3375 def testPrintToStdoutWithMasters(self):
3376 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3377 self.assertEqual([
3378 'Successes:',
3379 ' try bot_success https://ci.chromium.org/b/103',
3380 'Infra Failures:',
3381 ' try bot_infra_failure https://ci.chromium.org/b/105',
3382 'Failures:',
3383 ' try bot_failure https://ci.chromium.org/b/104',
3384 'Canceled:',
3385 ' try bot_canceled ',
3386 'Started:',
3387 ' try bot_started https://ci.chromium.org/b/102',
3388 'Scheduled:',
3389 ' try bot_scheduled id=101',
3390 'Other:',
3391 ' try bot_status_unspecified id=100',
3392 'Total: 7 tryjobs',
3393 ], sys.stdout.getvalue().splitlines())
3394 git_cl._call_buildbucket.assert_called_once_with(
3395 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3396 self._DEFAULT_REQUEST)
3397
3398 @mock.patch('git_cl.write_json')
3399 def testWriteToJson(self, mockJsonDump):
3400 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3401 git_cl._call_buildbucket.assert_called_once_with(
3402 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3403 self._DEFAULT_REQUEST)
3404 mockJsonDump.assert_called_once_with(
3405 'file.json', self._DEFAULT_RESPONSE['builds'])
3406
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003407 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003408 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3409 self.assertEqual(
3410 [
3411 ('chromium', 'try', 'bot_failure'),
3412 ('chromium', 'try', 'bot_infra_failure'),
3413 ],
3414 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003415
3416 def test_filter_failed_for_retry_many_builds(self):
3417
3418 def _build(name, created_sec, status, experimental=False):
3419 assert 0 <= created_sec < 100, created_sec
3420 b = {
3421 'id': 112112,
3422 'builder': {
3423 'project': 'chromium',
3424 'bucket': 'try',
3425 'builder': name,
3426 },
3427 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3428 'status': status,
3429 'tags': [],
3430 }
3431 if experimental:
3432 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3433 return b
3434
3435 builds = [
3436 _build('flaky-last-green', 1, 'FAILURE'),
3437 _build('flaky-last-green', 2, 'SUCCESS'),
3438 _build('flaky', 1, 'SUCCESS'),
3439 _build('flaky', 2, 'FAILURE'),
3440 _build('running', 1, 'FAILED'),
3441 _build('running', 2, 'SCHEDULED'),
3442 _build('yep-still-running', 1, 'STARTED'),
3443 _build('yep-still-running', 2, 'FAILURE'),
3444 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3445 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3446
3447 # Simulate experimental in CQ builder, which developer decided
3448 # to retry manually which resulted in 2nd build non-experimental.
3449 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3450 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3451 ]
3452 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003453 self.assertEqual(
3454 [
3455 ('chromium', 'try', 'flaky'),
3456 ('chromium', 'try', 'sometimes-experimental'),
3457 ],
3458 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003459
3460
3461class CMDTryTestCase(CMDTestCaseBase):
3462
3463 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003464 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003465 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003466 self.assertEqual(0, git_cl.main(['try']))
3467 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3468 self.assertEqual(
3469 sys.stdout.getvalue(),
3470 'Scheduling CQ dry run on: '
3471 'https://chromium-review.googlesource.com/123456\n')
3472
Edward Lemur4c707a22019-09-24 21:13:43 +00003473 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003474 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003475 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003476
3477 self.assertEqual(0, git_cl.main([
3478 'try', '-B', 'luci.chromium.try', '-b', 'win',
3479 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3480 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003481 'Scheduling jobs on:\n'
3482 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003483 git_cl.sys.stdout.getvalue())
3484
3485 expected_request = {
3486 "requests": [{
3487 "scheduleBuild": {
3488 "requestId": "uuid4",
3489 "builder": {
3490 "project": "chromium",
3491 "builder": "win",
3492 "bucket": "try",
3493 },
3494 "gerritChanges": [{
3495 "project": "depot_tools",
3496 "host": "chromium-review.googlesource.com",
3497 "patchset": 7,
3498 "change": 123456,
3499 }],
3500 "properties": {
3501 "category": "git_cl_try",
3502 "json": [{"a": 1}, None],
3503 "key": "val",
3504 },
3505 "tags": [
3506 {"value": "win", "key": "builder"},
3507 {"value": "git_cl_try", "key": "user_agent"},
3508 ],
3509 },
3510 }],
3511 }
3512 mockCallBuildbucket.assert_called_with(
3513 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3514
Anthony Polito1a5fe232020-01-24 23:17:52 +00003515 @mock.patch('git_cl._call_buildbucket')
3516 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3517 mockCallBuildbucket.return_value = {}
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003518 mock.patch('git_cl.Changelist.GetRemoteBranch',
3519 return_value=('origin', 'refs/remotes/origin/main')).start()
Anthony Polito1a5fe232020-01-24 23:17:52 +00003520
3521 self.assertEqual(0, git_cl.main([
3522 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3523 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3524 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3525 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003526 'Scheduling jobs on:\n'
3527 ' chromium/try: linux\n'
3528 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003529 git_cl.sys.stdout.getvalue())
3530
3531 expected_request = {
3532 "requests": [{
3533 "scheduleBuild": {
3534 "requestId": "uuid4",
3535 "builder": {
3536 "project": "chromium",
3537 "builder": "linux",
3538 "bucket": "try",
3539 },
3540 "gerritChanges": [{
3541 "project": "depot_tools",
3542 "host": "chromium-review.googlesource.com",
3543 "patchset": 7,
3544 "change": 123456,
3545 }],
3546 "properties": {
3547 "category": "git_cl_try",
3548 "json": [{"a": 1}, None],
3549 "key": "val",
3550 },
3551 "tags": [
3552 {"value": "linux", "key": "builder"},
3553 {"value": "git_cl_try", "key": "user_agent"},
3554 ],
3555 "gitilesCommit": {
3556 "host": "chromium-review.googlesource.com",
3557 "project": "depot_tools",
3558 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003559 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003560 }
3561 },
3562 },
3563 {
3564 "scheduleBuild": {
3565 "requestId": "uuid4",
3566 "builder": {
3567 "project": "chromium",
3568 "builder": "win",
3569 "bucket": "try",
3570 },
3571 "gerritChanges": [{
3572 "project": "depot_tools",
3573 "host": "chromium-review.googlesource.com",
3574 "patchset": 7,
3575 "change": 123456,
3576 }],
3577 "properties": {
3578 "category": "git_cl_try",
3579 "json": [{"a": 1}, None],
3580 "key": "val",
3581 },
3582 "tags": [
3583 {"value": "win", "key": "builder"},
3584 {"value": "git_cl_try", "key": "user_agent"},
3585 ],
3586 "gitilesCommit": {
3587 "host": "chromium-review.googlesource.com",
3588 "project": "depot_tools",
3589 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003590 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003591 }
3592 },
3593 }],
3594 }
3595 mockCallBuildbucket.assert_called_with(
3596 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3597
Edward Lemur45768512020-03-02 19:03:14 +00003598 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003599 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003600 with self.assertRaises(SystemExit):
3601 git_cl.main([
3602 'try', '-B', 'not-a-bucket', '-b', 'win',
3603 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003604 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003605 'Invalid bucket: not-a-bucket.',
3606 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003607
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003608 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003609 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003610 def testScheduleOnBuildbucketRetryFailed(
3611 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003612 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003613 7: [],
3614 6: [{
3615 'id': 112112,
3616 'builder': {
3617 'project': 'chromium',
3618 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003619 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003620 'createTime': '2019-10-09T08:00:01.854286Z',
3621 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003622 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003623 mockCallBuildbucket.return_value = {}
3624
3625 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3626 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003627 'Scheduling jobs on:\n'
3628 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003629 git_cl.sys.stdout.getvalue())
3630
3631 expected_request = {
3632 "requests": [{
3633 "scheduleBuild": {
3634 "requestId": "uuid4",
3635 "builder": {
3636 "project": "chromium",
3637 "bucket": "try",
3638 "builder": "linux",
3639 },
3640 "gerritChanges": [{
3641 "project": "depot_tools",
3642 "host": "chromium-review.googlesource.com",
3643 "patchset": 7,
3644 "change": 123456,
3645 }],
3646 "properties": {
3647 "category": "git_cl_try",
3648 },
3649 "tags": [
3650 {"value": "linux", "key": "builder"},
3651 {"value": "git_cl_try", "key": "user_agent"},
3652 {"value": "1", "key": "retry_failed"},
3653 ],
3654 },
3655 }],
3656 }
3657 mockCallBuildbucket.assert_called_with(
3658 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3659
Edward Lemur4c707a22019-09-24 21:13:43 +00003660 def test_parse_bucket(self):
3661 test_cases = [
3662 {
3663 'bucket': 'chromium/try',
3664 'result': ('chromium', 'try'),
3665 },
3666 {
3667 'bucket': 'luci.chromium.try',
3668 'result': ('chromium', 'try'),
3669 'has_warning': True,
3670 },
3671 {
3672 'bucket': 'skia.primary',
3673 'result': ('skia', 'skia.primary'),
3674 'has_warning': True,
3675 },
3676 {
3677 'bucket': 'not-a-bucket',
3678 'result': (None, None),
3679 },
3680 ]
3681
3682 for test_case in test_cases:
3683 git_cl.sys.stdout.truncate(0)
3684 self.assertEqual(
3685 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3686 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003687 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3688 test_case['result'])
3689 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003690
3691
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003692class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003693
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003694 def setUp(self):
3695 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003696 mock.patch('git_cl._fetch_tryjobs').start()
3697 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003698 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003699 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3700 mock.patch(
3701 'git_cl.Settings.GetSquashGerritUploads',
3702 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003703 self.addCleanup(mock.patch.stopall)
3704
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003705 def testWarmUpChangeDetailCache(self):
3706 self.assertEqual(0, git_cl.main(['upload']))
3707 gerrit_util.GetChangeDetail.assert_called_once_with(
3708 'chromium-review.googlesource.com', 'depot_tools~123456',
3709 frozenset([
3710 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3711 'CURRENT_COMMIT']))
3712
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003713 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003714 # This test mocks out the actual upload part, and just asserts that after
3715 # upload, if --retry-failed is added, then the tool will fetch try jobs
3716 # from the previous patchset and trigger the right builders on the latest
3717 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003718 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003719 # Latest patchset: No builds.
3720 [],
3721 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003722 [{
3723 'id': str(100 + idx),
3724 'builder': {
3725 'project': 'chromium',
3726 'bucket': 'try',
3727 'builder': 'bot_' + status.lower(),
3728 },
3729 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3730 'tags': [],
3731 'status': status,
3732 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003733 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003734
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003735 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003736 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003737 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3738 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003739 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003740 expected_buckets = [
3741 ('chromium', 'try', 'bot_failure'),
3742 ('chromium', 'try', 'bot_infra_failure'),
3743 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003744 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3745 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003746
Brian Sheedy59b06a82019-10-14 17:03:29 +00003747
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003748class MakeRequestsHelperTestCase(unittest.TestCase):
3749
3750 def exampleGerritChange(self):
3751 return {
3752 'host': 'chromium-review.googlesource.com',
3753 'project': 'depot_tools',
3754 'change': 1,
3755 'patchset': 2,
3756 }
3757
3758 def testMakeRequestsHelperNoOptions(self):
3759 # Basic test for the helper function _make_tryjob_schedule_requests;
3760 # it shouldn't throw AttributeError even when options doesn't have any
3761 # of the expected values; it will use default option values.
3762 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3763 jobs = [('chromium', 'try', 'my-builder')]
3764 options = optparse.Values()
3765 requests = git_cl._make_tryjob_schedule_requests(
3766 changelist, jobs, options, patchset=None)
3767
3768 # requestId is non-deterministic. Just assert that it's there and has
3769 # a particular length.
3770 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3771 self.assertEqual(requests, [{
3772 'scheduleBuild': {
3773 'builder': {
3774 'bucket': 'try',
3775 'builder': 'my-builder',
3776 'project': 'chromium'
3777 },
3778 'gerritChanges': [self.exampleGerritChange()],
3779 'properties': {
3780 'category': 'git_cl_try'
3781 },
3782 'tags': [{
3783 'key': 'builder',
3784 'value': 'my-builder'
3785 }, {
3786 'key': 'user_agent',
3787 'value': 'git_cl_try'
3788 }]
3789 }
3790 }])
3791
3792 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3793 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3794 jobs = [('chromium', 'try', 'presubmit')]
3795 options = optparse.Values()
3796 requests = git_cl._make_tryjob_schedule_requests(
3797 changelist, jobs, options, patchset=None)
3798 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3799 'category': 'git_cl_try',
3800 'dry_run': 'true'
3801 })
3802
3803 def testMakeRequestsHelperRevisionSet(self):
3804 # Gitiles commit is specified when revision is in options.
3805 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3806 jobs = [('chromium', 'try', 'my-builder')]
3807 options = optparse.Values({'revision': 'ba5eba11'})
3808 requests = git_cl._make_tryjob_schedule_requests(
3809 changelist, jobs, options, patchset=None)
3810 self.assertEqual(
3811 requests[0]['scheduleBuild']['gitilesCommit'], {
3812 'host': 'chromium-review.googlesource.com',
3813 'id': 'ba5eba11',
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003814 'project': 'depot_tools',
3815 'ref': 'refs/heads/main',
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003816 })
3817
3818 def testMakeRequestsHelperRetryFailedSet(self):
3819 # An extra tag is added when retry_failed is in options.
3820 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3821 jobs = [('chromium', 'try', 'my-builder')]
3822 options = optparse.Values({'retry_failed': 'true'})
3823 requests = git_cl._make_tryjob_schedule_requests(
3824 changelist, jobs, options, patchset=None)
3825 self.assertEqual(
3826 requests[0]['scheduleBuild']['tags'], [
3827 {
3828 'key': 'builder',
3829 'value': 'my-builder'
3830 },
3831 {
3832 'key': 'user_agent',
3833 'value': 'git_cl_try'
3834 },
3835 {
3836 'key': 'retry_failed',
3837 'value': '1'
3838 }
3839 ])
3840
3841 def testMakeRequestsHelperCategorySet(self):
Quinten Yearsley925cedb2020-04-13 17:49:39 +00003842 # The category property can be overridden with options.
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003843 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3844 jobs = [('chromium', 'try', 'my-builder')]
3845 options = optparse.Values({'category': 'my-special-category'})
3846 requests = git_cl._make_tryjob_schedule_requests(
3847 changelist, jobs, options, patchset=None)
3848 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3849 {'category': 'my-special-category'})
3850
3851
Edward Lemurda4b6c62020-02-13 00:28:40 +00003852class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003853
3854 def setUp(self):
3855 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003856 mock.patch('git_cl.RunCommand').start()
3857 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3858 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3859 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003860 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003861 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003862
3863 def tearDown(self):
3864 shutil.rmtree(self._top_dir)
3865 super(CMDFormatTestCase, self).tearDown()
3866
Jamie Madill5e96ad12020-01-13 16:08:35 +00003867 def _make_temp_file(self, fname, contents):
3868 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3869 tf.write('\n'.join(contents))
3870
Brian Sheedy59b06a82019-10-14 17:03:29 +00003871 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003872 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003873
Brian Sheedyb4307d52019-12-02 19:18:17 +00003874 def _check_yapf_filtering(self, files, expected):
3875 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3876 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003877
Edward Lemur1a83da12020-03-04 21:18:36 +00003878 def _run_command_mock(self, return_value):
3879 def f(*args, **kwargs):
3880 if 'stdin' in kwargs:
3881 self.assertIsInstance(kwargs['stdin'], bytes)
3882 return return_value
3883 return f
3884
Jamie Madill5e96ad12020-01-13 16:08:35 +00003885 def testClangFormatDiffFull(self):
3886 self._make_temp_file('test.cc', ['// test'])
3887 git_cl.settings.GetFormatFullByDefault.return_value = False
3888 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3889 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3890
3891 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003892 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003893 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3894 self._top_dir, 'HEAD')
3895 self.assertEqual(2, return_value)
3896
3897 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003898 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003899 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3900 self._top_dir, 'HEAD')
3901 self.assertEqual(0, return_value)
3902
3903 def testClangFormatDiff(self):
3904 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00003905 # A valid file is required, so use this test.
3906 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00003907 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3908
3909 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003910 git_cl.RunCommand.side_effect = self._run_command_mock('error')
3911 return_value = git_cl._RunClangFormatDiff(
3912 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003913 self.assertEqual(2, return_value)
3914
3915 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003916 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003917 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3918 'HEAD')
3919 self.assertEqual(0, return_value)
3920
Brian Sheedyb4307d52019-12-02 19:18:17 +00003921 def testYapfignoreExplicit(self):
3922 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3923 files = [
3924 'bar.py',
3925 'foo/bar.py',
3926 'foo/baz.py',
3927 'foo/bar/baz.py',
3928 'foo/bar/foobar.py',
3929 ]
3930 expected = [
3931 'bar.py',
3932 'foo/baz.py',
3933 'foo/bar/foobar.py',
3934 ]
3935 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003936
Brian Sheedyb4307d52019-12-02 19:18:17 +00003937 def testYapfignoreSingleWildcards(self):
3938 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3939 files = [
3940 'bar.py', # Matched by *bar.py.
3941 'bar.txt',
3942 'foobar.py', # Matched by *bar.py, foo*.
3943 'foobar.txt', # Matched by foo*.
3944 'bazbar.py', # Matched by *bar.py, baz*.py.
3945 'bazbar.txt',
3946 'foo/baz.txt', # Matched by foo*.
3947 'bar/bar.py', # Matched by *bar.py.
3948 'baz/foo.py', # Matched by baz*.py, foo*.
3949 'baz/foo.txt',
3950 ]
3951 expected = [
3952 'bar.txt',
3953 'bazbar.txt',
3954 'baz/foo.txt',
3955 ]
3956 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003957
Brian Sheedyb4307d52019-12-02 19:18:17 +00003958 def testYapfignoreMultiplewildcards(self):
3959 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3960 files = [
3961 'bar.py', # Matched by *bar*.
3962 'bar.txt', # Matched by *bar*.
3963 'abar.py', # Matched by *bar*.
3964 'foobaz.txt', # Matched by *foo*baz.txt.
3965 'foobaz.py',
3966 'afoobaz.txt', # Matched by *foo*baz.txt.
3967 ]
3968 expected = [
3969 'foobaz.py',
3970 ]
3971 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003972
3973 def testYapfignoreComments(self):
3974 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003975 files = [
3976 'test.py',
3977 'test2.py',
3978 ]
3979 expected = [
3980 'test2.py',
3981 ]
3982 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003983
3984 def testYapfignoreBlankLines(self):
3985 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003986 files = [
3987 'test.py',
3988 'test2.py',
3989 'test3.py',
3990 ]
3991 expected = [
3992 'test3.py',
3993 ]
3994 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003995
3996 def testYapfignoreWhitespace(self):
3997 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003998 files = [
3999 'test.py',
4000 'test2.py',
4001 ]
4002 expected = [
4003 'test2.py',
4004 ]
4005 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004006
Brian Sheedyb4307d52019-12-02 19:18:17 +00004007 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00004008 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004009 self._check_yapf_filtering([], [])
4010
4011 def testYapfignoreMissingYapfignore(self):
4012 files = [
4013 'test.py',
4014 ]
4015 expected = [
4016 'test.py',
4017 ]
4018 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004019
4020
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004021class CMDStatusTestCase(CMDTestCaseBase):
4022 # Return branch names a,..,f with comitterdates in increasing order, i.e.
4023 # 'f' is the most-recently changed branch.
4024 def _mock_run_git(commands):
4025 if commands == [
4026 'for-each-ref', '--format=%(refname) %(committerdate:unix)',
4027 'refs/heads'
4028 ]:
4029 branches_and_committerdates = [
4030 'refs/heads/a 1',
4031 'refs/heads/b 2',
4032 'refs/heads/c 3',
4033 'refs/heads/d 4',
4034 'refs/heads/e 5',
4035 'refs/heads/f 6',
4036 ]
4037 return '\n'.join(branches_and_committerdates)
4038
4039 # Mock the status in such a way that the issue number gives us an
4040 # indication of the commit date (simplifies manual debugging).
4041 def _mock_get_cl_statuses(branches, fine_grained, max_processes):
4042 for c in branches:
4043 c.issue = (100 + int(c.GetCommitDate()))
4044 yield (c, 'open')
4045
4046 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4047 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4048 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4049 @mock.patch('git_cl.RunGit', _mock_run_git)
4050 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4051 @mock.patch('git_cl.Settings.GetRoot', return_value='')
4052 @mock.patch('scm.GIT.GetBranch', return_value='a')
4053 def testStatus(self, *_mocks):
4054 self.assertEqual(0, git_cl.main(['status', '--no-branch-color']))
4055 self.maxDiff = None
4056 self.assertEqual(
4057 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4058 ' * a : https://crrev.com/c/101 (open)\n'
4059 ' b : https://crrev.com/c/102 (open)\n'
4060 ' c : https://crrev.com/c/103 (open)\n'
4061 ' d : https://crrev.com/c/104 (open)\n'
4062 ' e : https://crrev.com/c/105 (open)\n'
4063 ' f : https://crrev.com/c/106 (open)\n\n'
4064 'Current branch: a\n'
4065 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4066 'Issue description:\n'
4067 'x\n')
4068
4069 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4070 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4071 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4072 @mock.patch('git_cl.RunGit', _mock_run_git)
4073 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4074 @mock.patch('git_cl.Settings.GetRoot', return_value='')
4075 @mock.patch('scm.GIT.GetBranch', return_value='a')
4076 def testStatusByDate(self, *_mocks):
4077 self.assertEqual(
4078 0, git_cl.main(['status', '--no-branch-color', '--date-order']))
4079 self.maxDiff = None
4080 self.assertEqual(
4081 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4082 ' f : https://crrev.com/c/106 (open)\n'
4083 ' e : https://crrev.com/c/105 (open)\n'
4084 ' d : https://crrev.com/c/104 (open)\n'
4085 ' c : https://crrev.com/c/103 (open)\n'
4086 ' b : https://crrev.com/c/102 (open)\n'
4087 ' * a : https://crrev.com/c/101 (open)\n\n'
4088 'Current branch: a\n'
4089 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4090 'Issue description:\n'
4091 'x\n')
4092
4093
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004094class CMDOwnersTestCase(CMDTestCaseBase):
4095 def setUp(self):
4096 super(CMDOwnersTestCase, self).setUp()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004097 self.owners_by_path = {
4098 'foo': ['a@example.com'],
4099 'bar': ['b@example.com', 'c@example.com'],
4100 }
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004101 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
4102 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
4103 mock.patch(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004104 'git_cl.Changelist.GetAffectedFiles',
4105 return_value=list(self.owners_by_path)).start()
4106 mock.patch(
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004107 'git_cl.Changelist.GetCommonAncestorWithUpstream',
4108 return_value='upstream').start()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004109 mock.patch(
Edward Lesmese1576912021-02-16 21:53:34 +00004110 'git_cl.Changelist.GetGerritHost',
4111 return_value='host').start()
4112 mock.patch(
4113 'git_cl.Changelist.GetGerritProject',
4114 return_value='project').start()
4115 mock.patch(
4116 'git_cl.Changelist.GetRemoteBranch',
4117 return_value=('origin', 'refs/remotes/origin/main')).start()
4118 mock.patch(
4119 'owners_client.OwnersClient.BatchListOwners',
Edward Lesmes82b992a2021-01-11 23:24:55 +00004120 return_value=self.owners_by_path).start()
Edward Lesmese1576912021-02-16 21:53:34 +00004121 mock.patch('gerrit_util.IsCodeOwnersEnabled', return_value=True).start()
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004122 self.addCleanup(mock.patch.stopall)
4123
4124 def testShowAllNoArgs(self):
4125 self.assertEqual(0, git_cl.main(['owners', '--show-all']))
4126 self.assertEqual(
4127 'No files specified for --show-all. Nothing to do.\n',
4128 git_cl.sys.stdout.getvalue())
4129
4130 def testShowAll(self):
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004131 self.assertEqual(
4132 0,
4133 git_cl.main(['owners', '--show-all', 'foo', 'bar', 'baz']))
Edward Lesmese1576912021-02-16 21:53:34 +00004134 owners_client.OwnersClient.BatchListOwners.assert_called_once_with(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004135 ['foo', 'bar', 'baz'])
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004136 self.assertEqual(
4137 '\n'.join([
4138 'Owners for foo:',
4139 ' - a@example.com',
4140 'Owners for bar:',
4141 ' - b@example.com',
4142 ' - c@example.com',
4143 'Owners for baz:',
4144 ' - No owners found',
4145 '',
4146 ]),
4147 sys.stdout.getvalue())
4148
Edward Lesmes82b992a2021-01-11 23:24:55 +00004149 def testBatch(self):
4150 self.assertEqual(0, git_cl.main(['owners', '--batch']))
4151 self.assertIn('a@example.com', sys.stdout.getvalue())
4152 self.assertIn('b@example.com', sys.stdout.getvalue())
4153
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004154
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004155if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01004156 logging.basicConfig(
4157 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004158 unittest.main()