blob: 9d91cc981224467ff7ba67e38c2394cd4301e897 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
34# We have to disable monitoring before importing git_cl.
35metrics.DISABLE_METRICS_COLLECTION = True
36
Jamie Madill5e96ad12020-01-13 16:08:35 +000037import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000038import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000039import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000040import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000041import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000042import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000043import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000044import git_new_branch
45import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000046import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000047
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000048NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
49
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000050
Edward Lemur0db01f02019-11-12 22:01:51 +000051def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070052 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
53
tandrii5d48c322016-08-18 16:19:37 -070054CERR1 = callError(1)
55
56
Edward Lemur1773f372020-02-22 00:27:14 +000057class TemporaryFileMock(object):
58 def __init__(self):
59 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070060
Edward Lemur1773f372020-02-22 00:27:14 +000061 @contextlib.contextmanager
62 def __call__(self):
63 self.suffix += 1
64 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070065
66
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000067class ChangelistMock(object):
68 # A class variable so we can access it when we don't have access to the
69 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000070 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000071
72 def __init__(self, gerrit_change=None, **kwargs):
73 self._gerrit_change = gerrit_change
74
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000075 def GetIssue(self):
76 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000077
Edward Lemur6c6827c2020-02-06 21:15:18 +000078 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000079 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000080
dsansomee2d6fd92016-09-08 00:10:47 -070081 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000082 ChangelistMock.desc = desc
83
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000084 def GetGerritChange(self, patchset=None, **kwargs):
85 del patchset
86 return self._gerrit_change
87
tandrii5d48c322016-08-18 16:19:37 -070088
Edward Lemur85153282020-02-14 22:06:29 +000089class GitMocks(object):
90 def __init__(self, config=None, branchref=None):
91 self.branchref = branchref or 'refs/heads/master'
92 self.config = config or {}
93
94 def GetBranchRef(self, _root):
95 return self.branchref
96
97 def NewBranch(self, branchref):
98 self.branchref = branchref
99
Edward Lemur26964072020-02-19 19:18:51 +0000100 def GetConfig(self, root, key, default=None):
101 if root != '':
102 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000103 return self.config.get(key, default)
104
Edward Lemur26964072020-02-19 19:18:51 +0000105 def SetConfig(self, root, key, value=None):
106 if root != '':
107 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000108 if value:
109 self.config[key] = value
110 return
111 if key not in self.config:
112 raise CERR1
113 del self.config[key]
114
115
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000116class WatchlistsMock(object):
117 def __init__(self, _):
118 pass
119 @staticmethod
120 def GetWatchersForPaths(_):
121 return ['joe@example.com']
122
123
Edward Lemur4c707a22019-09-24 21:13:43 +0000124class CodereviewSettingsFileMock(object):
125 def __init__(self):
126 pass
127 # pylint: disable=no-self-use
128 def read(self):
129 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
130 'GERRIT_HOST: True\n')
131
132
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000133class AuthenticatorMock(object):
134 def __init__(self, *_args):
135 pass
136 def has_cached_credentials(self):
137 return True
tandrii221ab252016-10-06 08:12:04 -0700138 def authorize(self, http):
139 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000140
141
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100142def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000143 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
144
145 Usage:
146 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000148
149 OR
150 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100151 CookiesAuthenticatorMockFactory(
152 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000153 """
154 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800155 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000156 # Intentionally not calling super() because it reads actual cookie files.
157 pass
158 @classmethod
159 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000160 return os.path.join('~', '.gitcookies')
161
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162 @classmethod
163 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000164 return os.path.join('~', NETRC_FILENAME)
165
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100166 def _get_auth_for_host(self, host):
167 if same_auth:
168 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000169 return (hosts_with_creds or {}).get(host)
170 return CookiesAuthenticatorMock
171
Aaron Gable9a03ae02017-11-03 11:31:07 -0700172
kmarshall9249e012016-08-23 12:02:16 -0700173class MockChangelistWithBranchAndIssue():
174 def __init__(self, branch, issue):
175 self.branch = branch
176 self.issue = issue
177 def GetBranch(self):
178 return self.branch
179 def GetIssue(self):
180 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000181
tandriic2405f52016-10-10 08:13:15 -0700182
183class SystemExitMock(Exception):
184 pass
185
186
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000187class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000188 def setUp(self):
189 mock.patch('sys.exit', side_effect=SystemExitMock).start()
190 mock.patch('sys.stdout', StringIO()).start()
191 mock.patch('sys.stderr', StringIO()).start()
192 self.addCleanup(mock.patch.stopall)
193
194 def test_die_with_error(self):
195 with self.assertRaises(SystemExitMock):
196 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
197 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
198 self.assertTrue('saving CL description' in sys.stdout.getvalue())
199 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
200 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
201 sys.exit.assert_called_once_with(1)
202
203 def test_die_with_error_no_desc(self):
204 with self.assertRaises(SystemExitMock):
205 git_cl.DieWithError('foo')
206 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
207 self.assertEqual(sys.stdout.getvalue(), '')
208 sys.exit.assert_called_once_with(1)
209
Edward Lemur6c6827c2020-02-06 21:15:18 +0000210 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000211 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100212 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000213 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700214
Edward Lemur61bf4172020-02-24 23:22:37 +0000215 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
216 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
217 def test_get_cl_statuses(self, *_mocks):
218 statuses = [
219 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
220 changes = []
221 for status in statuses:
222 cl = git_cl.Changelist()
223 cl.status = status
224 changes.append(cl)
225
226 actual = set(git_cl.get_cl_statuses(changes, True))
227 self.assertEqual(set(zip(changes, statuses)), actual)
228
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000229 def test_upload_to_non_default_branch_no_retry(self):
230 m = mock.patch('git_cl.Changelist._CMDUploadChange',
231 side_effect=[git_cl.GitPushError(), None]).start()
232 mock.patch('git_cl.Changelist.GetRemoteBranch',
233 return_value=('foo', 'bar')).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000234 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000235 return_value='foo').start()
236 mock.patch('git_cl.gerrit_util.GetProjectHead',
237 return_value='refs/heads/main').start()
238
239 cl = git_cl.Changelist()
240 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000241 options.target_branch = 'refs/heads/bar'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000242 with self.assertRaises(SystemExitMock):
243 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
244
245 # ensure upload is called once
246 self.assertEqual(len(m.mock_calls), 1)
247 sys.exit.assert_called_once_with(1)
248 # option not set as retry didn't happen
249 self.assertFalse(hasattr(options, 'force'))
250 self.assertFalse(hasattr(options, 'edit_description'))
251
252 def test_upload_to_old_default_still_active(self):
253 m = mock.patch('git_cl.Changelist._CMDUploadChange',
254 side_effect=[git_cl.GitPushError(), None]).start()
255 mock.patch('git_cl.Changelist.GetRemoteBranch',
256 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000257 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000258 return_value='foo').start()
259 mock.patch('git_cl.gerrit_util.GetProjectHead',
Josip Sokcevicb631a882021-01-06 18:18:10 +0000260 return_value='refs/heads/master').start()
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000261
262 cl = git_cl.Changelist()
263 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000264 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000265 with self.assertRaises(SystemExitMock):
266 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
267
268 # ensure upload is called once
269 self.assertEqual(len(m.mock_calls), 1)
270 sys.exit.assert_called_once_with(1)
271 # option not set as retry didn't happen
272 self.assertFalse(hasattr(options, 'force'))
273 self.assertFalse(hasattr(options, 'edit_description'))
274
275 def test_upload_to_old_default_retry_on_failure(self):
276 m = mock.patch('git_cl.Changelist._CMDUploadChange',
277 side_effect=[git_cl.GitPushError(), None]).start()
278 mock.patch('git_cl.Changelist.GetRemoteBranch',
279 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000280 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000281 return_value='foo').start()
282 mock.patch('git_cl.gerrit_util.GetProjectHead',
283 return_value='refs/heads/main').start()
284 mock.patch('git_cl.RunGit').start()
285
286 cl = git_cl.Changelist()
287 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000288 options.target_branch = 'refs/heads/master'
289 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
290 # ensure upload is called twice
291 self.assertEqual(len(m.mock_calls), 2)
292 # option overrides on retry
293 self.assertEqual(options.force, True)
294 self.assertEqual(options.edit_description, False)
295
296 def test_upload_to_old_default_retry_on_rollback(self):
297 """Test when default branch migration had to be rolled back to old name"""
298 m = mock.patch('git_cl.Changelist._CMDUploadChange',
299 side_effect=[git_cl.GitPushError(), None]).start()
300 mock.patch('git_cl.Changelist.GetRemoteBranch',
301 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
302 mock.patch('git_cl.Changelist.GetGerritProject',
303 return_value='foo').start()
304 mock.patch('git_cl.gerrit_util.GetProjectHead',
305 return_value='refs/heads/master').start()
306 # GetTargetRef returns new default branch since it has stale remote
307 # information.
308 mock.patch('git_cl.GetTargetRef',
309 return_value='refs/heads/main').start()
310 mock.patch('git_cl.RunGit').start()
311
312 cl = git_cl.Changelist()
313 options = optparse.Values()
314 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000315 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
316 # ensure upload is called twice
317 self.assertEqual(len(m.mock_calls), 2)
318 # option overrides on retry
319 self.assertEqual(options.force, True)
320 self.assertEqual(options.edit_description, False)
321
Edward Lemur61bf4172020-02-24 23:22:37 +0000322 def test_get_cl_statuses_no_changes(self):
323 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
324
325 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
326 @mock.patch('multiprocessing.pool.ThreadPool')
327 def test_get_cl_statuses_timeout(self, *_mocks):
328 changes = [git_cl.Changelist() for _ in range(2)]
329 pool = multiprocessing.pool.ThreadPool()
330 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
331 it.return_value.next.side_effect = [
332 (changes[0], 'lgtm'),
333 multiprocessing.TimeoutError,
334 ]
335
336 actual = list(git_cl.get_cl_statuses(changes, True))
337 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
338
339 @mock.patch('git_cl.Changelist.GetIssueURL')
340 def test_get_cl_statuses_not_finegrained(self, _mock):
341 changes = [git_cl.Changelist() for _ in range(2)]
342 urls = ['some-url', None]
343 git_cl.Changelist.GetIssueURL.side_effect = urls
344
345 actual = set(git_cl.get_cl_statuses(changes, False))
346 self.assertEqual(
347 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
348
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000349 def test_get_issue_url(self):
350 cl = git_cl.Changelist(issue=123)
351 cl._gerrit_server = 'https://example.com'
352 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
353 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
354
355 cl = git_cl.Changelist(issue=123)
356 cl._gerrit_server = 'https://chromium-review.googlesource.com'
357 self.assertEqual(cl.GetIssueURL(),
358 'https://chromium-review.googlesource.com/123')
359 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
360
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000361 def test_set_preserve_tryjobs(self):
362 d = git_cl.ChangeDescription('Simple.')
363 d.set_preserve_tryjobs()
364 self.assertEqual(d.description.splitlines(), [
365 'Simple.',
366 '',
367 'Cq-Do-Not-Cancel-Tryjobs: true',
368 ])
369 before = d.description
370 d.set_preserve_tryjobs()
371 self.assertEqual(before, d.description)
372
373 d = git_cl.ChangeDescription('\n'.join([
374 'One is enough',
375 '',
376 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
377 'Change-Id: Ideadbeef',
378 ]))
379 d.set_preserve_tryjobs()
380 self.assertEqual(d.description.splitlines(), [
381 'One is enough',
382 '',
383 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
384 'Change-Id: Ideadbeef',
385 'Cq-Do-Not-Cancel-Tryjobs: true',
386 ])
387
tandriif9aefb72016-07-01 09:06:51 -0700388 def test_get_bug_line_values(self):
389 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
390 self.assertEqual(f('', ''), [])
391 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
Lei Zhang8a0efc12020-08-05 19:58:45 +0000392 # Prefix that ends with colon.
393 self.assertEqual(f('v8:', '456'), ['v8:456'])
394 self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
395 # Prefix that ends without colon.
tandriif9aefb72016-07-01 09:06:51 -0700396 self.assertEqual(f('v8', '456'), ['v8:456'])
397 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
398 # Not nice, but not worth carying.
Lei Zhang8a0efc12020-08-05 19:58:45 +0000399 self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
400 ['v8:456', 'chromium:123', 'v8:123'])
tandriif9aefb72016-07-01 09:06:51 -0700401 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
402 ['v8:456', 'chromium:123', 'v8:123'])
403
Edward Lemurda4b6c62020-02-13 00:28:40 +0000404 @mock.patch('gerrit_util.GetAccountDetails')
405 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000406 mock_per_account = {
407 'u1': None, # 404, doesn't exist.
408 'u2': {
409 '_account_id': 123124,
410 'avatars': [],
411 'email': 'u2@example.com',
412 'name': 'User Number 2',
413 'status': 'OOO',
414 },
415 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
416 }
417 def GetAccountDetailsMock(_, account):
418 # Poor-man's mock library's side_effect.
419 v = mock_per_account.pop(account)
420 if isinstance(v, Exception):
421 raise v
422 return v
423
Edward Lemurda4b6c62020-02-13 00:28:40 +0000424 mockGetAccountDetails.side_effect = GetAccountDetailsMock
425 actual = git_cl.gerrit_util.ValidAccounts(
426 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000427 self.assertEqual(actual, {
428 'u2': {
429 '_account_id': 123124,
430 'avatars': [],
431 'email': 'u2@example.com',
432 'name': 'User Number 2',
433 'status': 'OOO',
434 },
435 })
436
437
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200438class TestParseIssueURL(unittest.TestCase):
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000439 def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
440 parsed = git_cl.ParseIssueNumberArgument(arg)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200441 self.assertIsNotNone(parsed)
442 if fail:
443 self.assertFalse(parsed.valid)
444 return
445 self.assertTrue(parsed.valid)
446 self.assertEqual(parsed.issue, issue)
447 self.assertEqual(parsed.patchset, patchset)
448 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200449
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000450 def test_basic(self):
451 self._test('123', 123)
452 self._test('', fail=True)
453 self._test('abc', fail=True)
454 self._test('123/1', fail=True)
455 self._test('123a', fail=True)
456 self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
457 self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200458
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000459 def test_gerrit_url(self):
460 self._test('https://codereview.source.com/123', 123, None,
461 'codereview.source.com')
462 self._test('http://chrome-review.source.com/c/123', 123, None,
463 'chrome-review.source.com')
464 self._test('https://chrome-review.source.com/c/123/', 123, None,
465 'chrome-review.source.com')
466 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
467 'chrome-review.source.com')
468 self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
469 'chrome-review.source.com')
470 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
471 'chrome-review.source.com')
472 self._test('https://chrome-review.source.com/123', 123, None,
473 'chrome-review.source.com')
474 self._test('https://chrome-review.source.com/123/4', 123, 4,
475 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200476
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000477 self._test('https://chrome-review.source.com/bad/123/4', fail=True)
478 self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
479 self._test('https://chrome-review.source.com/c/abc/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000481 def test_short_urls(self):
482 self._test('https://crrev.com/c/2151934', 2151934, None,
483 'chromium-review.googlesource.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200484
485
Edward Lemurda4b6c62020-02-13 00:28:40 +0000486class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100487 def setUp(self):
488 super(GitCookiesCheckerTest, self).setUp()
489 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100490 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000491 mock.patch('sys.stdout', StringIO()).start()
492 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100493
494 def mock_hosts_creds(self, subhost_identity_pairs):
495 def ensure_googlesource(h):
496 if not h.endswith(self.c._GOOGLESOURCE):
497 assert not h.endswith('.')
498 return h + '.' + self.c._GOOGLESOURCE
499 return h
500 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
501 for h, i in subhost_identity_pairs]
502
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200503 def test_identity_parsing(self):
504 self.assertEqual(self.c._parse_identity('ldap.google.com'),
505 ('ldap', 'google.com'))
506 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
507 ('ldap', 'example.com'))
508 # Specical case because we know there are no subdomains in chromium.org.
509 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
510 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800511 # Pathological: ".period." can be either username OR domain, more likely
512 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200513 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
514 ('note', 'period.example.com'))
515
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100516 def test_analysis_nothing(self):
517 self.c._all_hosts = []
518 self.assertFalse(self.c.has_generic_host())
519 self.assertEqual(set(), self.c.get_conflicting_hosts())
520 self.assertEqual(set(), self.c.get_duplicated_hosts())
521 self.assertEqual(set(), self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100522
523 def test_analysis(self):
524 self.mock_hosts_creds([
525 ('.googlesource.com', 'git-example.chromium.org'),
526
527 ('chromium', 'git-example.google.com'),
528 ('chromium-review', 'git-example.google.com'),
529 ('chrome-internal', 'git-example.chromium.org'),
530 ('chrome-internal-review', 'git-example.chromium.org'),
531 ('conflict', 'git-example.google.com'),
532 ('conflict-review', 'git-example.chromium.org'),
533 ('dup', 'git-example.google.com'),
534 ('dup', 'git-example.google.com'),
535 ('dup-review', 'git-example.google.com'),
536 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200537 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100538 ])
539 self.assertTrue(self.c.has_generic_host())
540 self.assertEqual(set(['conflict.googlesource.com']),
541 self.c.get_conflicting_hosts())
542 self.assertEqual(set(['dup.googlesource.com']),
543 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200544 self.assertEqual(set(['partial.googlesource.com',
545 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100546 self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100547
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100548 def test_report_no_problems(self):
549 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100550 self.assertFalse(self.c.find_and_report_problems())
551 self.assertEqual(sys.stdout.getvalue(), '')
552
Edward Lemurda4b6c62020-02-13 00:28:40 +0000553 @mock.patch(
554 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000555 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000556 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100557 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100558 self.assertTrue(self.c.find_and_report_problems())
559 with open(os.path.join(os.path.dirname(__file__),
560 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000561 expected = f.read() % {
562 'sep': os.sep,
563 }
564
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100565 def by_line(text):
566 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700567 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200568 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100569
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800570
Edward Lemurda4b6c62020-02-13 00:28:40 +0000571class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000572 def setUp(self):
573 super(TestGitCl, self).setUp()
574 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700575 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000576 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000577 mock.patch('sys.stdout', StringIO()).start()
578 mock.patch(
579 'git_cl.time_time',
580 lambda: self._mocked_call('time.time')).start()
581 mock.patch(
582 'git_cl.metrics.collector.add_repeated',
583 lambda *a: self._mocked_call('add_repeated', *a)).start()
584 mock.patch('subprocess2.call', self._mocked_call).start()
585 mock.patch('subprocess2.check_call', self._mocked_call).start()
586 mock.patch('subprocess2.check_output', self._mocked_call).start()
587 mock.patch(
588 'subprocess2.communicate',
589 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
590 mock.patch(
591 'git_cl.gclient_utils.CheckCallAndFilter',
592 self._mocked_call).start()
593 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000594 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
595 mock.patch(
596 'git_cl.SaveDescriptionBackup',
597 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
598 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000599 'git_cl.write_json',
600 lambda *a: self._mocked_call('write_json', *a)).start()
601 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000602 'git_cl.Changelist.RunHook',
603 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000604 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
605 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000606 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000607 mock.patch(
608 'git_cl.gerrit_util.GetChangeComments',
609 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
610 mock.patch(
611 'git_cl.gerrit_util.GetChangeRobotComments',
612 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
613 mock.patch(
614 'git_cl.gerrit_util.AddReviewers',
615 lambda *a: self._mocked_call('AddReviewers', *a)).start()
616 mock.patch(
617 'git_cl.gerrit_util.SetReview',
618 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
619 self._mocked_call(
620 'SetReview', h, i, msg, labels, notify, ready))).start()
621 mock.patch(
622 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
623 return_value=False).start()
624 mock.patch(
625 'git_cl.gerrit_util.GceAuthenticator.is_gce',
626 return_value=False).start()
627 mock.patch(
628 'git_cl.gerrit_util.ValidAccounts',
629 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000630 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000631 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000632 self.mockGit = GitMocks()
633 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
634 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
Edward Lesmes50da7702020-03-30 19:23:43 +0000635 mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
636 mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
Edward Lemur85153282020-02-14 22:06:29 +0000637 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000638 mock.patch(
639 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000640 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000641 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000642 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000643 mock.patch(
644 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000645 # It's important to reset settings to not have inter-tests interference.
646 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000647 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000648
649 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000650 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000651 if not self.failed:
652 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100653 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000654 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
655 if len(self.calls) > 5:
656 calls += ' ...\n'
657 self.fail(
658 '\n'
659 'There are un-consumed calls after this test has finished:\n' +
660 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000661 finally:
662 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000663
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000664 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000665 self.assertTrue(
666 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700667 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000668 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000669 expected_args, result = top
670
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000671 # Also logs otherwise it could get caught in a try/finally and be hard to
672 # diagnose.
673 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700674 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000675 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700676 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
677 for i, c in enumerate(self._calls_done[-N:]))
678 following_calls = '\n '.join(
679 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
680 for i, c in enumerate(self.calls[:N]))
681 extended_msg = (
682 'A few prior calls:\n %s\n\n'
683 'This (expected):\n @%d: %r\n'
684 'This (actual):\n @%d: %r\n\n'
685 'A few following expected calls:\n %s' %
686 (prior_calls, len(self._calls_done), expected_args,
687 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700688
Edward Lesmes0dd54822020-03-26 18:24:25 +0000689 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700690 self.fail('@%d\n'
691 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000692 ' Actual: %r\n'
693 '\n'
694 '%s' % (
695 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700696
697 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700698 if isinstance(result, Exception):
699 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000700 # stdout from git commands is supposed to be a bytestream. Convert it here
701 # instead of converting all test output in this file to bytes.
702 if args[0][0] == 'git' and not isinstance(result, bytes):
703 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000704 return result
705
Edward Lemur1a83da12020-03-04 21:18:36 +0000706 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
707 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100708 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100709 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000710 self.assertEqual(
711 'prompt [Yes/No]: Please, type yes or no: ',
712 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100713
tandrii48df5812016-10-17 03:55:37 -0700714 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000715 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700716 self.calls = [
717 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700718 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
719 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
720 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
721 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700722 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
723 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700724 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
725 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000726 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
727 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700728 ((['git', 'config', 'gerrit.host', 'true'],), ''),
729 ]
730 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
731
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000732 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100733 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200734 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000735 custom_cl_base=None, short_hostname='chromium',
Edward Lesmes968b1fe2020-12-04 00:45:01 +0000736 change_id=None, default_branch='master'):
Edward Lemur26964072020-02-19 19:18:51 +0000737 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200738 if custom_cl_base:
739 ancestor_revision = custom_cl_base
740 else:
741 # Determine ancestor_revision to be merge base.
Edward Lesmes968b1fe2020-12-04 00:45:01 +0000742 ancestor_revision = 'origin/' + default_branch
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200743
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100744 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000745 gerrit_util.GetChangeDetail.return_value = {
746 'owner': {'email': (other_cl_owner or 'owner@example.com')},
747 'change_id': (change_id or '123456789'),
748 'current_revision': 'sha1_of_current_revision',
749 'revisions': {'sha1_of_current_revision': {
750 'commit': {'message': fetched_description},
751 }},
752 'status': fetched_status or 'NEW',
753 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100754 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100755 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100756 if other_cl_owner:
757 calls += [
758 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
759 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100760
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100761 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200762 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
763 ([custom_cl_base] if custom_cl_base else
764 [ancestor_revision, 'HEAD']),),
765 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100766 ]
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000767 calls += [
768 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
Edward Lesmes968b1fe2020-12-04 00:45:01 +0000769 '1' if default_branch == 'main' else callError(1)),
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000770 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000771
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100772 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000773
Edward Lemur26964072020-02-19 19:18:51 +0000774 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700775 squash_mode='default',
Aaron Gablefd238082017-06-07 13:42:34 -0700776 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100777 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000778 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000779 short_hostname='chromium',
Edward Lemur5a644f82020-03-18 16:44:57 +0000780 labels=None, change_id=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000781 final_description=None, gitcookies_exists=True,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000782 force=False, edit_description=None,
Edward Lesmes968b1fe2020-12-04 00:45:01 +0000783 default_branch='master'):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000784 if post_amend_description is None:
785 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700786 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200787
788 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000789
Edward Lesmes4de54132020-05-05 19:41:33 +0000790 if squash_mode in ('override_squash', 'override_nosquash'):
791 self.mockGit.config['gerrit.override-squash-uploads'] = (
792 'true' if squash_mode == 'override_squash' else 'false')
793
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000794 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000795 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200796 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200797 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000798 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000799 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000800 calls += [
801 ((['RunEditor'],), description),
802 ]
Josipe827b0f2020-01-30 00:07:20 +0000803 # user wants to edit description
804 if edit_description:
805 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000806 ((['RunEditor'],), edit_description),
807 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000808 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200809
810 if custom_cl_base is None:
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000811 parent = 'origin/' + default_branch
Edward Lesmes968b1fe2020-12-04 00:45:01 +0000812 git_common.get_or_create_merge_base.return_value = parent
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200813 else:
814 calls += [
815 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000816 'refs/remotes/origin/' + default_branch],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200817 callError(1)), # Means not ancenstor.
818 (('ask_for_data',
819 'Do you take responsibility for cleaning up potential mess '
820 'resulting from proceeding with upload? Press Enter to upload, '
821 'or Ctrl+C to abort'), ''),
822 ]
823 parent = custom_cl_base
824
825 calls += [
826 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
827 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000828 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200829 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000830 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200831 ref_to_push),
832 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000833 else:
834 ref_to_push = 'HEAD'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000835 parent = 'origin/refs/heads/' + default_branch
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000836
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000837 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000838 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000839 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200840 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000841
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000842 metrics_arguments = []
843
Aaron Gableafd52772017-06-27 16:40:10 -0700844 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700845 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000846 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700847 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400848 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700849 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000850 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700851 else:
852 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000853 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800854
Edward Lemur5a644f82020-03-18 16:44:57 +0000855 # If issue is given, then description is fetched from Gerrit instead.
856 if issue is None:
857 if squash:
858 title = 'Initial upload'
859 else:
860 if not title:
861 calls += [
862 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
863 (('ask_for_data', 'Title for patchset []: '), 'User input'),
864 ]
865 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700866 if title:
Edward Lemur5a644f82020-03-18 16:44:57 +0000867 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000868 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000869
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000870 if short_hostname == 'chromium':
Quinten Yearsley925cedb2020-04-13 17:49:39 +0000871 # All reviewers and ccs get into ref_suffix.
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000872 for r in sorted(reviewers):
873 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000874 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000875 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000876 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000877 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000878 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000879 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000880 reviewers, cc = [], []
881 else:
882 # TODO(crbug/877717): remove this case.
883 calls += [
884 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
885 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000886 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000887 {
888 e: {'email': e}
889 for e in (reviewers + ['joe@example.com'] + cc)
890 })
891 ]
892 for r in sorted(reviewers):
893 if r != 'bad-account-or-email':
894 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000895 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000896 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000897 if issue is None:
898 cc += ['joe@example.com']
899 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000900 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000901 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000902 if c in cc:
903 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000904
Edward Lemur687ca902018-12-05 02:30:30 +0000905 for k, v in sorted((labels or {}).items()):
906 ref_suffix += ',l=%s+%d' % (k, v)
907 metrics_arguments.append('l=%s+%d' % (k, v))
908
909 if tbr:
910 calls += [
911 (('GetCodeReviewTbrScore',
912 '%s-review.googlesource.com' % short_hostname,
913 'my/repo'),
914 2,),
915 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000916
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000917 calls += [
918 (('time.time',), 1000,),
919 ((['git', 'push',
920 'https://%s.googlesource.com/my/repo' % short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000921 ref_to_push + ':refs/for/refs/heads/' + default_branch + ref_suffix],),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000922 (('remote:\n'
923 'remote: Processing changes: (\)\n'
924 'remote: Processing changes: (|)\n'
925 'remote: Processing changes: (/)\n'
926 'remote: Processing changes: (-)\n'
927 'remote: Processing changes: new: 1 (/)\n'
928 'remote: Processing changes: new: 1, done\n'
929 'remote:\n'
930 'remote: New Changes:\n'
931 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
932 ' XXX\n'
933 'remote:\n'
934 'To https://%s.googlesource.com/my/repo\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000935 ' * [new branch] hhhh -> refs/for/refs/heads/%s\n'
936 ) % (short_hostname, short_hostname, default_branch)),),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000937 (('time.time',), 2000,),
938 (('add_repeated',
939 'sub_commands',
940 {
941 'execution_time': 1000,
942 'command': 'git push',
943 'exit_code': 0,
944 'arguments': sorted(metrics_arguments),
945 }),
946 None,),
947 ]
948
Edward Lemur1b52d872019-05-09 21:12:12 +0000949 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000950
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000951 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
952
Edward Lemur1b52d872019-05-09 21:12:12 +0000953 # Trace-related calls
954 calls += [
955 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000956 (
957 ([
958 'FileWrite', trace_name + '-README',
959 '%(date)s\n'
960 '%(short_hostname)s-review.googlesource.com\n'
961 '%(change_id)s\n'
962 '%(title)s\n'
963 '%(description)s\n'
964 '1000\n'
965 '0\n'
966 '%(trace_name)s' % {
Josip Sokcevic5e18b602020-04-23 21:47:00 +0000967 'date': '2017-03-16T20:00:41.000000',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000968 'short_hostname': short_hostname,
969 'change_id': change_id,
970 'description': final_description,
971 'title': title or '<untitled>',
972 'trace_name': trace_name,
973 }
974 ], ),
975 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000976 ),
977 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000978 (
979 (['os.path.isfile',
980 os.path.join('TEMP_DIR', 'trace-packet')], ),
981 True,
Edward Lemur1b52d872019-05-09 21:12:12 +0000982 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000983 (
984 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
985 ('git-hash: 0123456789012345678901234567890123456789\n'
986 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +0000987 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000988 (
989 ([
990 'FileWrite',
991 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
992 'git-hash: abcdea\n'
993 ], ),
994 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000995 ),
996 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000997 (
998 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
999 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001000 ),
1001 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001002 (
1003 (['git', 'config', '-l'], ),
1004 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +00001005 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001006 (
1007 ([
1008 'FileWrite',
1009 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
1010 ], ),
1011 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001012 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001013 (
1014 (['os.path.isfile',
1015 os.path.join('~', '.gitcookies')], ),
1016 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +00001017 ),
1018 ]
1019 if gitcookies_exists:
1020 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001021 (
1022 (['FileRead', os.path.join('~', '.gitcookies')], ),
1023 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +00001024 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001025 (
1026 ([
1027 'FileWrite',
1028 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
1029 ], ),
1030 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001031 ),
1032 ]
1033 calls += [
1034 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001035 (
1036 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
1037 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001038 ),
1039 ]
1040
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001041 # TODO(crbug/877717): this should never be used.
1042 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001043 calls += [
1044 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001045 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001046 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001047 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001048 notify),
1049 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001050 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001051 return calls
1052
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001053 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001054 self,
1055 upload_args,
1056 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001057 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001058 squash=True,
1059 squash_mode=None,
Aaron Gable9b713dd2016-12-14 16:04:21 -08001060 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001061 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001062 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001063 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001064 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001065 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001066 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001067 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001068 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001069 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001070 labels=None,
1071 change_id=None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001072 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001073 gitcookies_exists=True,
1074 force=False,
Edward Lesmes0dd54822020-03-26 18:24:25 +00001075 log_description=None,
Josipe827b0f2020-01-30 00:07:20 +00001076 edit_description=None,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001077 fetched_description=None,
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001078 default_branch='master'):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001079 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001080 if squash_mode is None:
1081 if '--no-squash' in upload_args:
1082 squash_mode = 'nosquash'
1083 elif '--squash' in upload_args:
1084 squash_mode = 'squash'
1085 else:
1086 squash_mode = 'default'
1087
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001088 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001089 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001090 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001091 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001092 same_auth=('git-owner.example.com', '', 'pass'))).start()
1093 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1094 lambda _, offer_removal: None).start()
1095 mock.patch('git_cl.gclient_utils.RunEditor',
1096 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1097 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001098 'DownloadGerritHook', force)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001099 mock.patch('git_cl.gclient_utils.FileRead',
1100 lambda path: self._mocked_call(['FileRead', path])).start()
1101 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001102 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001103 ['FileWrite', path, contents])).start()
1104 mock.patch('git_cl.datetime_now',
1105 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1106 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1107 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1108 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001109 '%(now)s\n'
1110 '%(gerrit_host)s\n'
1111 '%(change_id)s\n'
1112 '%(title)s\n'
1113 '%(description)s\n'
1114 '%(execution_time)s\n'
1115 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001116 '%(trace_name)s').start()
1117 mock.patch('git_cl.shutil.make_archive',
1118 lambda *args: self._mocked_call(['make_archive'] +
1119 list(args))).start()
1120 mock.patch('os.path.isfile',
1121 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001122 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001123 'git_cl._create_description_from_log',
1124 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001125 mock.patch(
1126 'git_cl.Changelist._AddChangeIdToCommitMessage',
1127 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001128 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001129 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1130 mock.patch(
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001131 'git_common.get_or_create_merge_base',
1132 return_value='origin/' + default_branch).start()
1133 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001134 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001135 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001136
Edward Lemur26964072020-02-19 19:18:51 +00001137 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001138 self.mockGit.config['branch.master.gerritissue'] = (
1139 str(issue) if issue else None)
1140 self.mockGit.config['remote.origin.url'] = (
1141 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001142 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001143
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001144 self.calls = self._gerrit_base_calls(
1145 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001146 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001147 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001148 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001149 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001150 short_hostname=short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001151 change_id=change_id,
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001152 default_branch=default_branch)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001153 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001154 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001155 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001156 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001157 self.calls += self._gerrit_upload_calls(
1158 description, reviewers, squash,
1159 squash_mode=squash_mode,
Aaron Gablefd238082017-06-07 13:42:34 -07001160 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001161 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001162 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001163 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001164 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001165 labels=labels,
1166 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001167 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001168 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001169 force=force,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001170 edit_description=edit_description,
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001171 default_branch=default_branch)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001172 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001173 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001174 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001175 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001176 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001177 self.assertEqual(
1178 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001179 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001180
Edward Lemur1b52d872019-05-09 21:12:12 +00001181 def test_gerrit_upload_traces_no_gitcookies(self):
1182 self._run_gerrit_upload_test(
1183 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001184 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001185 [],
1186 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001187 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001188 change_id='Ixxx',
1189 gitcookies_exists=False)
1190
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001191 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001192 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001193 [],
1194 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1195 [],
1196 change_id='Ixxx')
1197
1198 def test_gerrit_upload_without_change_id_nosquash(self):
1199 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001200 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001201 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001202 [],
1203 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001204 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001205 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001206
Edward Lesmes4de54132020-05-05 19:41:33 +00001207 def test_gerrit_upload_without_change_id_override_nosquash(self):
1208 self._run_gerrit_upload_test(
1209 [],
1210 'desc ✔\n\nBUG=\n',
1211 [],
1212 squash=False,
1213 squash_mode='override_nosquash',
1214 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1215 change_id='Ixxx')
1216
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001217 def test_gerrit_no_reviewer(self):
1218 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001219 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001220 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001221 [],
1222 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001223 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001224 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001225
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001226 def test_gerrit_no_reviewer_non_chromium_host(self):
1227 # TODO(crbug/877717): remove this test case.
1228 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001229 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001230 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001231 [],
1232 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001233 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001234 short_hostname='other',
1235 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001236
Edward Lesmes0dd54822020-03-26 18:24:25 +00001237 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001238 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001239 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001240 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001241 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001242 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001243 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001244 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001245
ukai@chromium.orge8077812012-02-03 03:41:46 +00001246 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001247 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001248 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001249 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001250 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001251 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001252 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001253 notify=True,
1254 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001255 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001256 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001257
Anthony Polito8b955342019-09-24 19:01:36 +00001258 def test_gerrit_upload_force_sets_bug(self):
1259 self._run_gerrit_upload_test(
1260 ['-b', '10000', '-f'],
1261 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1262 [],
1263 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001264 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001265 change_id='Ixxx')
1266
Edward Lemur5fb22242020-03-12 22:05:13 +00001267 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001268 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001269 ['-b', '10000', '-m', 'Title', '--edit-description'],
1270 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001271 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001272 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001273 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001274 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001275 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001276 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001277
Dan Beamd8b04ca2019-10-10 21:23:26 +00001278 def test_gerrit_upload_force_sets_fixed(self):
1279 self._run_gerrit_upload_test(
1280 ['-x', '10000', '-f'],
1281 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1282 [],
1283 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001284 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001285 change_id='Ixxx')
1286
ukai@chromium.orge8077812012-02-03 03:41:46 +00001287 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001288 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1289 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001290 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001291 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001292 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001293 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001294 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001295 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001296 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001297 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001298 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001299 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001300
1301 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001302 self._run_gerrit_upload_test(
1303 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001304 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001305 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001306 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001307
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001308 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001309 self._run_gerrit_upload_test(
1310 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001311 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001312 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001313 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001314 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001315
Edward Lesmes0dd54822020-03-26 18:24:25 +00001316 def test_gerrit_upload_squash_first_title(self):
1317 self._run_gerrit_upload_test(
1318 ['-f', '-t', 'title'],
1319 'title\n\ndesc\n\nChange-Id: 123456789',
1320 [],
1321 force=True,
1322 squash=True,
1323 log_description='desc',
1324 change_id='123456789')
1325
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001326 def test_gerrit_upload_squash_first_with_labels(self):
1327 self._run_gerrit_upload_test(
1328 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001329 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001330 [],
1331 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001332 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001333 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001334
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001335 def test_gerrit_upload_squash_first_against_rev(self):
1336 custom_cl_base = 'custom_cl_base_rev_or_branch'
1337 self._run_gerrit_upload_test(
1338 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001339 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001340 [],
1341 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001342 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001343 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001344 self.assertIn(
1345 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1346 sys.stdout.getvalue())
1347
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001348 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001349 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001350 self._run_gerrit_upload_test(
1351 ['--squash'],
1352 description,
1353 [],
1354 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001355 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001356 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001357
Edward Lemurd55c5072020-02-20 01:09:07 +00001358 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001359 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001360 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001361 with self.assertRaises(SystemExitMock):
1362 self._run_gerrit_upload_test(
1363 ['--squash'],
1364 description,
1365 [],
1366 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001367 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001368 fetched_status='ABANDONED',
1369 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001370 self.assertEqual(
1371 'Change https://chromium-review.googlesource.com/123456 has been '
1372 'abandoned, new uploads are not allowed\n',
1373 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001374
Edward Lemurda4b6c62020-02-13 00:28:40 +00001375 @mock.patch(
1376 'gerrit_util.GetAccountDetails',
1377 return_value={'email': 'yet-another@example.com'})
1378 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001379 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001380 self._run_gerrit_upload_test(
1381 ['--squash'],
1382 description,
1383 [],
1384 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001385 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001386 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001387 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001388 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001389 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001390 'authenticate to Gerrit as yet-another@example.com.\n'
1391 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001392 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001393
Josipe827b0f2020-01-30 00:07:20 +00001394 def test_upload_change_description_editor(self):
1395 fetched_description = 'foo\n\nChange-Id: 123456789'
1396 description = 'bar\n\nChange-Id: 123456789'
1397 self._run_gerrit_upload_test(
1398 ['--squash', '--edit-description'],
1399 description,
1400 [],
1401 fetched_description=fetched_description,
1402 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001403 issue=123456,
1404 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001405 edit_description=description)
1406
Edward Lemurda4b6c62020-02-13 00:28:40 +00001407 @mock.patch('git_cl.RunGit')
1408 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001409 @mock.patch('sys.stdin', StringIO('\n'))
1410 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001411 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001412 def mock_run_git(*args, **_kwargs):
1413 if args[0] == ['for-each-ref',
1414 '--format=%(refname:short) %(upstream:short)',
1415 'refs/heads']:
1416 # Create a local branch dependency tree that looks like this:
1417 # test1 -> test2 -> test3 -> test4 -> test5
1418 # -> test3.1
1419 # test6 -> test0
1420 branch_deps = [
1421 'test2 test1', # test1 -> test2
1422 'test3 test2', # test2 -> test3
1423 'test3.1 test2', # test2 -> test3.1
1424 'test4 test3', # test3 -> test4
1425 'test5 test4', # test4 -> test5
1426 'test6 test0', # test0 -> test6
1427 'test7', # test7
1428 ]
1429 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001430 git_cl.RunGit.side_effect = mock_run_git
1431 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001432
1433 class MockChangelist():
1434 def __init__(self):
1435 pass
1436 def GetBranch(self):
1437 return 'test1'
1438 def GetIssue(self):
1439 return '123'
1440 def GetPatchset(self):
1441 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001442 def IsGerrit(self):
1443 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001444
1445 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1446 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001447 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001448 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001449 'This command will checkout all dependent branches '
1450 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001451 'or Ctrl+C to abort',
1452 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001453 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001454
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001455 def test_gerrit_change_id(self):
1456 self.calls = [
1457 ((['git', 'write-tree'], ),
1458 'hashtree'),
1459 ((['git', 'rev-parse', 'HEAD~0'], ),
1460 'branch-parent'),
1461 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1462 'A B <a@b.org> 1456848326 +0100'),
1463 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1464 'C D <c@d.org> 1456858326 +0100'),
1465 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1466 'hashchange'),
1467 ]
1468 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1469 self.assertEqual(change_id, 'Ihashchange')
1470
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001471 def test_desecription_append_footer(self):
1472 for init_desc, footer_line, expected_desc in [
1473 # Use unique desc first lines for easy test failure identification.
1474 ('foo', 'R=one', 'foo\n\nR=one'),
1475 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1476 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1477 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1478 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1479 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1480 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1481 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1482 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1483 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1484 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1485 ]:
1486 desc = git_cl.ChangeDescription(init_desc)
1487 desc.append_footer(footer_line)
1488 self.assertEqual(desc.description, expected_desc)
1489
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001490 def test_update_reviewers(self):
1491 data = [
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001492 ('foo', [], [], None, None,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001493 'foo'),
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001494 ('foo\nR=xx', [], [], None, None,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001495 'foo\nR=xx'),
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001496 ('foo\nTBR=xx', [], [], None, None,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001497 'foo\nTBR=xx'),
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001498 ('foo', ['a@c'], [], None, None,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001499 'foo\n\nR=a@c'),
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001500 ('foo\nR=xx', ['a@c'], [], None, None,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001501 'foo\n\nR=a@c, xx'),
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001502 ('foo\nTBR=xx', ['a@c'], [], None, None,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001503 'foo\n\nR=a@c\nTBR=xx'),
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001504 ('foo\nTBR=xx\nR=yy', ['a@c'], [], None, None,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001505 'foo\n\nR=a@c, yy\nTBR=xx'),
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001506 ('foo\nBUG=', ['a@c'], [], None, None,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001507 'foo\nBUG=\nR=a@c'),
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001508 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [], None, None,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001509 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001510 ('foo', ['a@c', 'b@c'], [], None, None,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001511 'foo\n\nR=a@c, b@c'),
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001512 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [], None, None,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001513 'foo\nBar\n\nR=c@c\nBUG='),
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001514 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [], None, None,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001515 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001516 # Same as the line before, but full of whitespaces.
1517 (
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001518 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [], None, None,
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001519 'foo\nBar\n\nR=c@c\n BUG =',
1520 ),
1521 # Whitespaces aren't interpreted as new lines.
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001522 ('foo BUG=allo R=joe ', ['c@c'], [], None, None,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001523 'foo BUG=allo R=joe\n\nR=c@c'),
1524 # Redundant TBRs get promoted to Rs
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001525 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'], None, None,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001526 'foo\n\nR=a@c, b@c\nTBR=t@c'),
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001527 # Add to R
1528 ('foo', [], [], 'R', ['a@c'],
1529 'foo\n\nR=a@c'),
1530 # Add to TBR
1531 ('foo', [], [], 'TBR', ['a@c'],
1532 'foo\n\nTBR=a@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001533 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001534 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001535 actual = []
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001536 for orig, reviewers, tbrs, add_to, add, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001537 obj = git_cl.ChangeDescription(orig)
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001538 obj.update_reviewers(reviewers, tbrs, add_to, add)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001539 actual.append(obj.description)
1540 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001541
Nodir Turakulov23b82142017-11-16 11:04:25 -08001542 def test_get_hash_tags(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001543 self.calls = [
1544 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
1545 callError(1)),
1546 ] * 9
Nodir Turakulov23b82142017-11-16 11:04:25 -08001547 cases = [
1548 ('', []),
1549 ('a', []),
1550 ('[a]', ['a']),
1551 ('[aa]', ['aa']),
1552 ('[a ]', ['a']),
1553 ('[a- ]', ['a']),
1554 ('[a- b]', ['a-b']),
1555 ('[a--b]', ['a-b']),
1556 ('[a', []),
1557 ('[a]x', ['a']),
1558 ('[aa]x', ['aa']),
1559 ('[a b]', ['a-b']),
1560 ('[a b]', ['a-b']),
1561 ('[a__b]', ['a-b']),
1562 ('[a] x', ['a']),
1563 ('[a][b]', ['a', 'b']),
1564 ('[a] [b]', ['a', 'b']),
1565 ('[a][b]x', ['a', 'b']),
1566 ('[a][b] x', ['a', 'b']),
1567 ('[a]\n[b]', ['a']),
1568 ('[a\nb]', []),
1569 ('[a][', ['a']),
1570 ('Revert "[a] feature"', ['a']),
1571 ('Reland "[a] feature"', ['a']),
1572 ('Revert: [a] feature', ['a']),
1573 ('Reland: [a] feature', ['a']),
1574 ('Revert "Reland: [a] feature"', ['a']),
1575 ('Foo: feature', ['foo']),
1576 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001577 ('Change Foo::Bar', []),
1578 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001579 ('Revert "Foo bar: feature"', ['foo-bar']),
1580 ('Reland "Foo bar: feature"', ['foo-bar']),
1581 ]
1582 for desc, expected in cases:
1583 change_desc = git_cl.ChangeDescription(desc)
1584 actual = change_desc.get_hash_tags()
1585 self.assertEqual(
1586 actual,
1587 expected,
1588 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1589
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001590 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001591 self.assertEqual(None, git_cl.GetTargetRef(None,
1592 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001593 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001594
wittman@chromium.org455dc922015-01-26 20:15:50 +00001595 # Check default target refs for branches.
1596 self.assertEqual('refs/heads/master',
1597 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001598 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001599 self.assertEqual('refs/heads/master',
1600 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001601 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001602 self.assertEqual('refs/heads/master',
1603 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001604 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001605 self.assertEqual('refs/branch-heads/123',
1606 git_cl.GetTargetRef('origin',
1607 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001608 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001609 self.assertEqual('refs/diff/test',
1610 git_cl.GetTargetRef('origin',
1611 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001612 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001613 self.assertEqual('refs/heads/chrome/m42',
1614 git_cl.GetTargetRef('origin',
1615 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001616 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001617
1618 # Check target refs for user-specified target branch.
1619 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1620 'refs/remotes/branch-heads/123'):
1621 self.assertEqual('refs/branch-heads/123',
1622 git_cl.GetTargetRef('origin',
1623 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001624 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001625 for branch in ('origin/master', 'remotes/origin/master',
1626 'refs/remotes/origin/master'):
1627 self.assertEqual('refs/heads/master',
1628 git_cl.GetTargetRef('origin',
1629 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001630 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001631 for branch in ('master', 'heads/master', 'refs/heads/master'):
1632 self.assertEqual('refs/heads/master',
1633 git_cl.GetTargetRef('origin',
1634 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001635 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001636
Edward Lemurda4b6c62020-02-13 00:28:40 +00001637 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1638 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001639 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001640 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1641
Edward Lemur85153282020-02-14 22:06:29 +00001642 def assertIssueAndPatchset(
1643 self, branch='master', issue='123456', patchset='7',
1644 git_short_host='chromium'):
1645 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001646 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001647 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001648 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001649 self.assertEqual(
1650 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001651 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001652
Edward Lemur85153282020-02-14 22:06:29 +00001653 def _patch_common(self, git_short_host='chromium'):
Edward Lesmes50da7702020-03-30 19:23:43 +00001654 mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
Edward Lemur26964072020-02-19 19:18:51 +00001655 self.mockGit.config['remote.origin.url'] = (
1656 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001657 gerrit_util.GetChangeDetail.return_value = {
1658 'current_revision': '7777777777',
1659 'revisions': {
1660 '1111111111': {
1661 '_number': 1,
1662 'fetch': {'http': {
1663 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1664 'ref': 'refs/changes/56/123456/1',
1665 }},
1666 },
1667 '7777777777': {
1668 '_number': 7,
1669 'fetch': {'http': {
1670 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1671 'ref': 'refs/changes/56/123456/7',
1672 }},
1673 },
1674 },
1675 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001676
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001677 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001678 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001679 self.calls += [
1680 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1681 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001682 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001683 ]
1684 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001685 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001686
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001687 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001688 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001689 self.calls += [
1690 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1691 'refs/changes/56/123456/7'],), ''),
1692 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001693 ]
Edward Lemur85153282020-02-14 22:06:29 +00001694 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1695 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001696
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001697 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001698 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001699 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001700 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001701 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001702 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001703 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001704 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001705 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001706
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001707 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001708 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001709 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001710 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001711 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001712 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001713 ]
1714 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001715 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001716 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001717
Aaron Gable697a91b2018-01-19 15:20:15 -08001718 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001719 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001720 self.calls += [
1721 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1722 'refs/changes/56/123456/1'],), ''),
1723 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001724 ]
1725 self.assertEqual(git_cl.main(
1726 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1727 0)
Edward Lemur85153282020-02-14 22:06:29 +00001728 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001729
Edward Lemurd55c5072020-02-20 01:09:07 +00001730 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001731 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001732 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001733 self.calls += [
1734 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001735 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001736 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001737 ]
1738 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001739 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001740 self.assertEqual(
1741 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1742 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001743
Edward Lemurda4b6c62020-02-13 00:28:40 +00001744 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001745 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001746 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001747 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001748 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001749 self.mockGit.config['remote.origin.url'] = (
1750 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001751 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001752 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001753 self.assertEqual(
1754 'change 123456 at https://chromium-review.googlesource.com does not '
1755 'exist or you have no access to it\n',
1756 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001757
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001758 def _checkout_calls(self):
1759 return [
1760 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001761 'branch\\..*\\.gerritissue'], ),
1762 ('branch.ger-branch.gerritissue 123456\n'
1763 'branch.gbranch654.gerritissue 654321\n')),
1764 ]
1765
1766 def test_checkout_gerrit(self):
1767 """Tests git cl checkout <issue>."""
1768 self.calls = self._checkout_calls()
1769 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1770 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1771
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001772 def test_checkout_not_found(self):
1773 """Tests git cl checkout <issue>."""
1774 self.calls = self._checkout_calls()
1775 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1776
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001777 def test_checkout_no_branch_issues(self):
1778 """Tests git cl checkout <issue>."""
1779 self.calls = [
1780 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001781 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001782 ]
1783 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1784
Edward Lemur26964072020-02-19 19:18:51 +00001785 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00001786 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001787 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001788 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001789 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1790 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001791 self.mockGit.config['remote.origin.url'] = (
1792 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001793 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001794 cl.branch = 'master'
1795 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001796 return cl
1797
Edward Lemurd55c5072020-02-20 01:09:07 +00001798 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001799 def test_gerrit_ensure_authenticated_missing(self):
1800 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001801 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001802 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001803 with self.assertRaises(SystemExitMock):
1804 cl.EnsureAuthenticated(force=False)
1805 self.assertEqual(
1806 'Credentials for the following hosts are required:\n'
1807 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001808 'These are read from ~%(sep)s.gitcookies '
1809 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00001810 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001811 'https://chromium-review.googlesource.com/new-password\n' % {
1812 'sep': os.sep,
1813 'netrc': NETRC_FILENAME,
1814 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001815
1816 def test_gerrit_ensure_authenticated_conflict(self):
1817 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001818 'chromium.googlesource.com':
1819 ('git-one.example.com', None, 'secret1'),
1820 'chromium-review.googlesource.com':
1821 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001822 })
1823 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001824 (('ask_for_data', 'If you know what you are doing '
1825 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001826 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1827
1828 def test_gerrit_ensure_authenticated_ok(self):
1829 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001830 'chromium.googlesource.com':
1831 ('git-same.example.com', None, 'secret'),
1832 'chromium-review.googlesource.com':
1833 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001834 })
1835 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1836
tandrii@chromium.org28253532016-04-14 13:46:56 +00001837 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00001838 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
1839 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00001840 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1841
Eric Boren2fb63102018-10-05 13:05:03 +00001842 def test_gerrit_ensure_authenticated_bearer_token(self):
1843 cl = self._test_gerrit_ensure_authenticated_common(auth={
1844 'chromium.googlesource.com':
1845 ('', None, 'secret'),
1846 'chromium-review.googlesource.com':
1847 ('', None, 'secret'),
1848 })
1849 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1850 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1851 'chromium.googlesource.com')
1852 self.assertTrue('Bearer' in header)
1853
Daniel Chengcf6269b2019-05-18 01:02:12 +00001854 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00001855 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00001856 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001857 (('logging.warning',
1858 'Ignoring branch %(branch)s with non-https remote '
1859 '%(remote)s', {
1860 'branch': 'master',
1861 'remote': 'custom-scheme://repo'}
1862 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001863 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001864 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1865 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1866 mock.patch('logging.warning',
1867 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00001868 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00001869 cl.branch = 'master'
1870 cl.branchref = 'refs/heads/master'
1871 cl.lookedup_issue = True
1872 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1873
Florian Mayerae510e82020-01-30 21:04:48 +00001874 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00001875 self.mockGit.config['remote.origin.url'] = (
1876 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00001877 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001878 (('logging.error',
1879 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1880 'but it doesn\'t exist.', {
1881 'remote': 'origin',
1882 'branch': 'master',
1883 'url': 'git@somehost.example:foo/bar.git'}
1884 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00001885 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001886 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1887 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1888 mock.patch('logging.error',
1889 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00001890 cl = git_cl.Changelist()
1891 cl.branch = 'master'
1892 cl.branchref = 'refs/heads/master'
1893 cl.lookedup_issue = True
1894 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1895
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001896 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00001897 self.mockGit.config['branch.master.gerritissue'] = '123'
1898 self.mockGit.config['branch.master.gerritserver'] = (
1899 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00001900 self.mockGit.config['remote.origin.url'] = (
1901 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001902 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00001903 (('SetReview', 'chromium-review.googlesource.com',
1904 'infra%2Finfra~123', None,
1905 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001906 ]
tandriid9e5ce52016-07-13 02:32:59 -07001907
1908 def test_cmd_set_commit_gerrit_clear(self):
1909 self._cmd_set_commit_gerrit_common(0)
1910 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1911
1912 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001913 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001914 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1915
tandriid9e5ce52016-07-13 02:32:59 -07001916 def test_cmd_set_commit_gerrit(self):
1917 self._cmd_set_commit_gerrit_common(2)
1918 self.assertEqual(0, git_cl.main(['set-commit']))
1919
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001920 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001921 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001922 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001923
1924 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001925 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001926
Edward Lemurda4b6c62020-02-13 00:28:40 +00001927 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07001928 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07001929 try:
1930 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00001931 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001932 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001933 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07001934
1935 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07001936 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001937 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07001938 return 'foobar'
1939
Edward Lemurda4b6c62020-02-13 00:28:40 +00001940 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07001941 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001942 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001943 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001944 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07001945
iannuccie53c9352016-08-17 14:40:40 -07001946 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001947
iannuccie53c9352016-08-17 14:40:40 -07001948 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001949 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07001950 return 'foobar'
1951
Edward Lemurda4b6c62020-02-13 00:28:40 +00001952 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
1953 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07001954 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001955 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001956
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001957 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00001958 self.mockGit.config['remote.origin.url'] = (
1959 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001960 gerrit_util.GetChangeDetail.return_value = {
1961 'current_revision': 'sha1',
1962 'revisions': {'sha1': {
1963 'commit': {'message': 'foobar'},
1964 }},
1965 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001966 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001967 'description',
1968 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
1969 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001970 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001971
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001972 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001973 mock.patch('git_cl.Changelist', ChangelistMock).start()
1974 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001975
1976 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
1977 self.assertEqual('hihi', ChangelistMock.desc)
1978
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001979 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001980 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001981
1982 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001983 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001984 '# Enter a description of the change.\n'
1985 '# This will be displayed on the codereview site.\n'
1986 '# The first line will also be used as the subject of the review.\n'
1987 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001988 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07001989 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001990 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001991 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07001992 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001993
Edward Lemur6c6827c2020-02-06 21:15:18 +00001994 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001995 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001996
Edward Lemurda4b6c62020-02-13 00:28:40 +00001997 mock.patch('git_cl.Changelist.FetchDescription',
1998 lambda *args: current_desc).start()
1999 mock.patch('git_cl.Changelist.UpdateDescription',
2000 UpdateDescription).start()
2001 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002002
Edward Lemur85153282020-02-14 22:06:29 +00002003 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002004 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002005
Dan Beamd8b04ca2019-10-10 21:23:26 +00002006 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2007 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2008
2009 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002010 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002011 '# Enter a description of the change.\n'
2012 '# This will be displayed on the codereview site.\n'
2013 '# The first line will also be used as the subject of the review.\n'
2014 '#--------------------This line is 72 characters long'
2015 '--------------------\n'
2016 'Some.\n\nFixed: 123\nChange-Id: xxx',
2017 desc)
2018 return desc
2019
Edward Lemurda4b6c62020-02-13 00:28:40 +00002020 mock.patch('git_cl.Changelist.FetchDescription',
2021 lambda *args: current_desc).start()
2022 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002023
Edward Lemur85153282020-02-14 22:06:29 +00002024 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002025 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002026
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002027 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002028 mock.patch('git_cl.Changelist', ChangelistMock).start()
2029 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002030
2031 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2032 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2033
kmarshall3bff56b2016-06-06 18:31:47 -07002034 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002035 self.calls = [
2036 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002037 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002038 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002039 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002040 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002041 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002042
Edward Lemurda4b6c62020-02-13 00:28:40 +00002043 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002044 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002045 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2046 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002047 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002048
2049 self.assertEqual(0, git_cl.main(['archive', '-f']))
2050
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002051 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002052 self.calls = [
2053 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2054 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2055 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2056 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002057 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2058 ((['git', 'branch', '-D', 'foo'],), '')
2059 ]
2060
Edward Lemurda4b6c62020-02-13 00:28:40 +00002061 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002062 lambda branches, fine_grained, max_processes:
2063 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2064 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002065 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002066
2067 self.assertEqual(0, git_cl.main(['archive', '-f']))
2068
kmarshall3bff56b2016-06-06 18:31:47 -07002069 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002070 self.calls = [
2071 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2072 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002073 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002074 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002075
Edward Lemurda4b6c62020-02-13 00:28:40 +00002076 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002077 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002078 [(MockChangelistWithBranchAndIssue('master', 1),
2079 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002080
2081 self.assertEqual(1, git_cl.main(['archive', '-f']))
2082
2083 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002084 self.calls = [
2085 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2086 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002087 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002088 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002089
Edward Lemurda4b6c62020-02-13 00:28:40 +00002090 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002091 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002092 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2093 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002094 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002095
kmarshall9249e012016-08-23 12:02:16 -07002096 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2097
2098 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002099 self.calls = [
2100 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2101 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002102 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002103 ((['git', 'branch', '-D', 'foo'],), '')
2104 ]
kmarshall9249e012016-08-23 12:02:16 -07002105
Edward Lemurda4b6c62020-02-13 00:28:40 +00002106 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002107 lambda branches, fine_grained, max_processes:
2108 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2109 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002110 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002111
2112 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002113
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002114 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002115 self.calls = [
2116 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2117 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2118 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002119 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2120 'refs/tags/git-cl-archived-456-foo'),
2121 ((['git', 'branch', '-D', 'foo'],), CERR1),
2122 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2123 'refs/tags/git-cl-archived-456-foo'),
2124 ]
2125
Edward Lemurda4b6c62020-02-13 00:28:40 +00002126 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002127 lambda branches, fine_grained, max_processes:
2128 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2129 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002130 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002131
2132 self.assertEqual(0, git_cl.main(['archive', '-f']))
2133
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002134 def test_archive_with_format(self):
2135 self.calls = [
2136 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
2137 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2138 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2139 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2140 ((['git', 'branch', '-D', 'foo'], ), ''),
2141 ]
2142
2143 mock.patch('git_cl.get_cl_statuses',
2144 lambda branches, fine_grained, max_processes:
2145 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2146
2147 self.assertEqual(
2148 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2149
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002150 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002151 self.mockGit.config['branch.master.gerritissue'] = '123'
2152 self.mockGit.config['branch.master.gerritserver'] = (
2153 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002154 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002155 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002156 ]
2157 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002158 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2159 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002160
Aaron Gable400e9892017-07-12 15:31:21 -07002161 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002162 self.mockGit.config['branch.master.gerritissue'] = '123'
2163 self.mockGit.config['branch.master.gerritserver'] = (
2164 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002165 mock.patch('git_cl.Changelist.FetchDescription',
2166 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002167 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002168 ((['git', 'log', '-1', '--format=%B'],),
2169 'This is a description\n\nChange-Id: Ideadbeef'),
2170 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002171 ]
2172 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002173 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2174 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002175
phajdan.jre328cf92016-08-22 04:12:17 -07002176 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002177 self.mockGit.config['branch.master.gerritissue'] = '123'
2178 self.mockGit.config['branch.master.gerritserver'] = (
2179 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002180 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002181 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002182 {'issue': 123,
2183 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002184 ''),
2185 ]
2186 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2187
tandrii16e0b4e2016-06-07 10:34:28 -07002188 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002189 mock.patch(
2190 'git_cl.os.path.abspath',
2191 lambda path: self._mocked_call(['abspath', path])).start()
2192 mock.patch(
2193 'git_cl.os.path.exists',
2194 lambda path: self._mocked_call(['exists', path])).start()
2195 mock.patch(
2196 'git_cl.gclient_utils.FileRead',
2197 lambda path: self._mocked_call(['FileRead', path])).start()
2198 mock.patch(
2199 'git_cl.gclient_utils.rm_file_or_tree',
2200 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002201 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002202 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002203 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002204 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002205
2206 def test_GerritCommitMsgHookCheck_custom_hook(self):
2207 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002208 self.calls += [((['exists',
2209 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2210 ((['FileRead',
2211 os.path.join('.git', 'hooks', 'commit-msg')], ),
2212 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002213 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002214
2215 def test_GerritCommitMsgHookCheck_not_exists(self):
2216 cl = self._common_GerritCommitMsgHookCheck()
2217 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002218 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002219 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002220 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002221
2222 def test_GerritCommitMsgHookCheck(self):
2223 cl = self._common_GerritCommitMsgHookCheck()
2224 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002225 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2226 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002227 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002228 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002229 ((['rm_file_or_tree',
2230 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002231 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002232 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002233
tandriic4344b52016-08-29 06:04:54 -07002234 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002235 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2236 self.mockGit.config['branch.master.gerritserver'] = (
2237 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002238 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002239 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002240 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002241 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002242 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002243 'labels': {},
2244 'current_revision': 'deadbeaf',
2245 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002246 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002247 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002248 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002249 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2250 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002251 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002252 self.assertEqual(0, cl.CMDLand(force=True,
2253 bypass_hooks=True,
2254 verbose=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002255 parallel=False,
2256 resultdb=False,
2257 realm=None))
Edward Lemur73c76702020-02-06 23:57:18 +00002258 self.assertIn(
2259 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002260 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002261 self.assertIn(
2262 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002263 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002264
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002265 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002266 mock.patch('git_cl.Changelist.GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002267
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002268 def test_gerrit_change_detail_cache_simple(self):
2269 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002270 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002271 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002272 cl1._cached_remote_url = (
2273 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002274 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002275 cl2._cached_remote_url = (
2276 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002277 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2278 self.assertEqual(cl1._GetChangeDetail(), 'a')
2279 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002280
2281 def test_gerrit_change_detail_cache_options(self):
2282 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002283 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002284 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002285 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002286 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2287 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2288 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2289 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2290 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2291 self.assertEqual(cl._GetChangeDetail(), 'cab')
2292
2293 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2294 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2295 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2296 self.assertEqual(cl._GetChangeDetail(), 'cab')
2297
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002298 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002299 gerrit_util.GetChangeDetail.return_value = {
2300 'current_revision': 'rev1',
2301 'revisions': {
2302 'rev1': {'commit': {'message': 'desc1'}},
2303 },
2304 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002305
2306 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002307 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002308 cl._cached_remote_url = (
2309 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002310 self.assertEqual(cl.FetchDescription(), 'desc1')
2311 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002312
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002313 def test_print_current_creds(self):
2314 class CookiesAuthenticatorMock(object):
2315 def __init__(self):
2316 self.gitcookies = {
2317 'host.googlesource.com': ('user', 'pass'),
2318 'host-review.googlesource.com': ('user', 'pass'),
2319 }
2320 self.netrc = self
2321 self.netrc.hosts = {
2322 'github.com': ('user2', None, 'pass2'),
2323 'host2.googlesource.com': ('user3', None, 'pass'),
2324 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002325 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2326 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002327 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2328 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2329 ' Host\t User\t Which file',
2330 '============================\t=====\t===========',
2331 'host-review.googlesource.com\t user\t.gitcookies',
2332 ' host.googlesource.com\t user\t.gitcookies',
2333 ' host2.googlesource.com\tuser3\t .netrc',
2334 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002335 sys.stdout.seek(0)
2336 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002337 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2338 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2339 ' Host\tUser\t Which file',
2340 '============================\t====\t===========',
2341 'host-review.googlesource.com\tuser\t.gitcookies',
2342 ' host.googlesource.com\tuser\t.gitcookies',
2343 ])
2344
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002345 def _common_creds_check_mocks(self):
2346 def exists_mock(path):
2347 dirname = os.path.dirname(path)
2348 if dirname == os.path.expanduser('~'):
2349 dirname = '~'
2350 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002351 if base in (NETRC_FILENAME, '.gitcookies'):
2352 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002353 # git cl also checks for existence other files not relevant to this test.
2354 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002355 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002356 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002357 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002358 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002359
2360 def test_creds_check_gitcookies_not_configured(self):
2361 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002362 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2363 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002364 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002365 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2366 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2367 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2368 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2369 'or Ctrl+C to abort'), ''),
2370 (([
2371 'git', 'config', '--global', 'http.cookiefile',
2372 os.path.expanduser(os.path.join('~', '.gitcookies'))
2373 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002374 ]
2375 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002376 self.assertTrue(
2377 sys.stdout.getvalue().startswith(
2378 'You seem to be using outdated .netrc for git credentials:'))
2379 self.assertIn(
2380 '\nConfigured git to use .gitcookies from',
2381 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002382
2383 def test_creds_check_gitcookies_configured_custom_broken(self):
2384 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002385 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2386 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002387 custom_cookie_path = ('C:\\.gitcookies'
2388 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002389 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002390 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2391 ((['git', 'config', '--global', 'http.cookiefile'], ),
2392 custom_cookie_path),
2393 (('os.path.exists', custom_cookie_path), False),
2394 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2395 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2396 (([
2397 'git', 'config', '--global', 'http.cookiefile',
2398 os.path.expanduser(os.path.join('~', '.gitcookies'))
2399 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002400 ]
2401 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002402 self.assertIn(
2403 'WARNING: You have configured custom path to .gitcookies: ',
2404 sys.stdout.getvalue())
2405 self.assertIn(
2406 'However, your configured .gitcookies file is missing.',
2407 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002408
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002409 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002410 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002411 self.mockGit.config['remote.origin.url'] = (
2412 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002413 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002414 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002415 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002416 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002417 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002418 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002419
Edward Lemurda4b6c62020-02-13 00:28:40 +00002420 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2421 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002422 self.mockGit.config['remote.origin.url'] = (
2423 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002424 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002425 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002426 'current_revision': 'ba5eba11',
2427 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002428 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002429 '_number': 1,
2430 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002431 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002432 '_number': 2,
2433 },
2434 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002435 'messages': [
2436 {
2437 u'_revision_number': 1,
2438 u'author': {
2439 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002440 u'email': u'could-be-anything@example.com',
2441 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002442 },
2443 u'date': u'2017-03-15 20:08:45.000000000',
2444 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002445 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002446 u'tag': u'autogenerated:cq:dry-run'
2447 },
2448 {
2449 u'_revision_number': 2,
2450 u'author': {
2451 u'_account_id': 11151243,
2452 u'email': u'owner@example.com',
2453 u'name': u'owner'
2454 },
2455 u'date': u'2017-03-16 20:00:41.000000000',
2456 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2457 u'message': u'PTAL',
2458 },
2459 {
2460 u'_revision_number': 2,
2461 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002462 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002463 u'email': u'reviewer@example.com',
2464 u'name': u'reviewer'
2465 },
2466 u'date': u'2017-03-17 05:19:37.500000000',
2467 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2468 u'message': u'Patch Set 2: Code-Review+1',
2469 },
2470 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002471 }
2472 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002473 (('GetChangeComments', 'chromium-review.googlesource.com',
2474 'infra%2Finfra~1'), {
2475 '/COMMIT_MSG': [
2476 {
2477 'author': {
2478 'email': u'reviewer@example.com'
2479 },
2480 'updated': u'2017-03-17 05:19:37.500000000',
2481 'patch_set': 2,
2482 'side': 'REVISION',
2483 'message': 'Please include a bug link',
2484 },
2485 ],
2486 'codereview.settings': [
2487 {
2488 'author': {
2489 'email': u'owner@example.com'
2490 },
2491 'updated': u'2017-03-16 20:00:41.000000000',
2492 'patch_set': 2,
2493 'side': 'PARENT',
2494 'line': 42,
2495 'message': 'I removed this because it is bad',
2496 },
2497 ]
2498 }),
2499 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2500 'infra%2Finfra~1'), {}),
2501 ] * 2 + [(('write_json', 'output.json', [{
2502 u'date':
2503 u'2017-03-16 20:00:41.000000',
2504 u'message': (u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2505 u' Base, Line 42: https://crrev.com/c/1/2/'
2506 u'codereview.settings#b42\n' +
2507 u' I removed this because it is bad\n'),
2508 u'autogenerated':
2509 False,
2510 u'approval':
2511 False,
2512 u'disapproval':
2513 False,
2514 u'sender':
2515 u'owner@example.com'
2516 }, {
2517 u'date':
2518 u'2017-03-17 05:19:37.500000',
2519 u'message':
2520 (u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2521 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
2522 u' Please include a bug link\n'),
2523 u'autogenerated':
2524 False,
2525 u'approval':
2526 False,
2527 u'disapproval':
2528 False,
2529 u'sender':
2530 u'reviewer@example.com'
2531 }]), '')]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002532 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002533 git_cl._CommentSummary(
2534 message=(u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2535 u' Base, Line 42: https://crrev.com/c/1/2/' +
2536 u'codereview.settings#b42\n' +
2537 u' I removed this because it is bad\n'),
2538 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2539 autogenerated=False,
2540 disapproval=False,
2541 approval=False,
2542 sender=u'owner@example.com'),
2543 git_cl._CommentSummary(message=(
2544 u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2545 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002546 u' Please include a bug link\n'),
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002547 date=datetime.datetime(2017, 3, 17, 5, 19, 37,
2548 500000),
2549 autogenerated=False,
2550 disapproval=False,
2551 approval=False,
2552 sender=u'reviewer@example.com'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002553 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002554 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002555 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002556 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002557 self.assertEqual(
2558 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2559
2560 def test_git_cl_comments_robot_comments(self):
2561 # git cl comments also fetches robot comments (which are considered a type
2562 # of autogenerated comment), and unlike other types of comments, only robot
2563 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002564 self.mockGit.config['remote.origin.url'] = (
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002565 'https://x.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002566 gerrit_util.GetChangeDetail.return_value = {
2567 'owner': {'email': 'owner@example.com'},
2568 'current_revision': 'ba5eba11',
2569 'revisions': {
2570 'deadbeaf': {
2571 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002572 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002573 'ba5eba11': {
2574 '_number': 2,
2575 },
2576 },
2577 'messages': [
2578 {
2579 u'_revision_number': 1,
2580 u'author': {
2581 u'_account_id': 1111084,
2582 u'email': u'commit-bot@chromium.org',
2583 u'name': u'Commit Bot'
2584 },
2585 u'date': u'2017-03-15 20:08:45.000000000',
2586 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2587 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2588 u'tag': u'autogenerated:cq:dry-run'
2589 },
2590 {
2591 u'_revision_number': 1,
2592 u'author': {
2593 u'_account_id': 123,
2594 u'email': u'tricium@serviceaccount.com',
2595 u'name': u'Tricium'
2596 },
2597 u'date': u'2017-03-16 20:00:41.000000000',
2598 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2599 u'message': u'(1 comment)',
2600 u'tag': u'autogenerated:tricium',
2601 },
2602 {
2603 u'_revision_number': 1,
2604 u'author': {
2605 u'_account_id': 123,
2606 u'email': u'tricium@serviceaccount.com',
2607 u'name': u'Tricium'
2608 },
2609 u'date': u'2017-03-16 20:00:41.000000000',
2610 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2611 u'message': u'(1 comment)',
2612 u'tag': u'autogenerated:tricium',
2613 },
2614 {
2615 u'_revision_number': 2,
2616 u'author': {
2617 u'_account_id': 123,
2618 u'email': u'tricium@serviceaccount.com',
2619 u'name': u'reviewer'
2620 },
2621 u'date': u'2017-03-17 05:30:37.000000000',
2622 u'tag': u'autogenerated:tricium',
2623 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2624 u'message': u'(1 comment)',
2625 },
2626 ]
2627 }
2628 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002629 (('GetChangeComments', 'x-review.googlesource.com', 'infra%2Finfra~1'),
2630 {}),
2631 (('GetChangeRobotComments', 'x-review.googlesource.com',
2632 'infra%2Finfra~1'), {
2633 'codereview.settings': [
2634 {
2635 u'author': {
2636 u'email': u'tricium@serviceaccount.com'
2637 },
2638 u'updated': u'2017-03-17 05:30:37.000000000',
2639 u'robot_run_id': u'5565031076855808',
2640 u'robot_id': u'Linter/Category',
2641 u'tag': u'autogenerated:tricium',
2642 u'patch_set': 2,
2643 u'side': u'REVISION',
2644 u'message': u'Linter warning message text',
2645 u'line': 32,
2646 },
2647 ],
2648 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002649 ]
2650 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002651 git_cl._CommentSummary(
2652 date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2653 message=(u'(1 comment)\n\ncodereview.settings\n'
2654 u' PS2, Line 32: https://x-review.googlesource.com/c/1/2/'
2655 u'codereview.settings#32\n'
2656 u' Linter warning message text\n'),
2657 sender=u'tricium@serviceaccount.com',
2658 autogenerated=True,
2659 approval=False,
2660 disapproval=False)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002661 ]
2662 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002663 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002664 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002665
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002666 def test_get_remote_url_with_mirror(self):
2667 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002668
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002669 def selective_os_path_isdir_mock(path):
2670 if path == '/cache/this-dir-exists':
2671 return self._mocked_call('os.path.isdir', path)
2672 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002673
Edward Lemurda4b6c62020-02-13 00:28:40 +00002674 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002675
2676 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002677 self.mockGit.config['remote.origin.url'] = (
2678 '/cache/this-dir-exists')
2679 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2680 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002681 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002682 (('os.path.isdir', '/cache/this-dir-exists'),
2683 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002684 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002685 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002686 self.assertEqual(cl.GetRemoteUrl(), url)
2687 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2688
Edward Lemur298f2cf2019-02-22 21:40:39 +00002689 def test_get_remote_url_non_existing_mirror(self):
2690 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002691
Edward Lemur298f2cf2019-02-22 21:40:39 +00002692 def selective_os_path_isdir_mock(path):
2693 if path == '/cache/this-dir-doesnt-exist':
2694 return self._mocked_call('os.path.isdir', path)
2695 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002696
Edward Lemurda4b6c62020-02-13 00:28:40 +00002697 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2698 mock.patch('logging.error',
2699 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002700
Edward Lemur26964072020-02-19 19:18:51 +00002701 self.mockGit.config['remote.origin.url'] = (
2702 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002703 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002704 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2705 False),
2706 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002707 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2708 'but it doesn\'t exist.', {
2709 'remote': 'origin',
2710 'branch': 'master',
2711 'url': '/cache/this-dir-doesnt-exist'}
2712 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002713 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002714 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002715 self.assertIsNone(cl.GetRemoteUrl())
2716
2717 def test_get_remote_url_misconfigured_mirror(self):
2718 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002719
Edward Lemur298f2cf2019-02-22 21:40:39 +00002720 def selective_os_path_isdir_mock(path):
2721 if path == '/cache/this-dir-exists':
2722 return self._mocked_call('os.path.isdir', path)
2723 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002724
Edward Lemurda4b6c62020-02-13 00:28:40 +00002725 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2726 mock.patch('logging.error',
2727 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002728
Edward Lemur26964072020-02-19 19:18:51 +00002729 self.mockGit.config['remote.origin.url'] = (
2730 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002731 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002732 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002733 (('logging.error',
2734 'Remote "%(remote)s" for branch "%(branch)s" points to '
2735 '"%(cache_path)s", but it is misconfigured.\n'
2736 '"%(cache_path)s" must be a git repo and must have a remote named '
2737 '"%(remote)s" pointing to the git host.', {
2738 'remote': 'origin',
2739 'cache_path': '/cache/this-dir-exists',
2740 'branch': 'master'}
2741 ), None),
2742 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002743 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002744 self.assertIsNone(cl.GetRemoteUrl())
2745
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002746 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002747 self.mockGit.config['remote.origin.url'] = (
2748 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002749 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002750 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2751
2752 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002753 mock.patch('logging.error',
2754 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002755
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002756 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002757 (('logging.error',
2758 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2759 'but it doesn\'t exist.', {
2760 'remote': 'origin',
2761 'branch': 'master',
2762 'url': ''}
2763 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002764 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002765 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002766 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002767
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002768 def test_gerrit_new_default(self):
2769 self._run_gerrit_upload_test(
2770 [],
2771 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
2772 [],
2773 squash=False,
2774 squash_mode='override_nosquash',
2775 change_id='I123456789',
Edward Lesmes968b1fe2020-12-04 00:45:01 +00002776 default_branch='main')
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002777
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002778
Edward Lemur9aa1a962020-02-25 00:58:38 +00002779class ChangelistTest(unittest.TestCase):
Edward Lemur227d5102020-02-25 23:45:35 +00002780 def setUp(self):
2781 super(ChangelistTest, self).setUp()
2782 mock.patch('gclient_utils.FileRead').start()
2783 mock.patch('gclient_utils.FileWrite').start()
2784 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
2785 mock.patch(
2786 'git_cl.Changelist.GetCodereviewServer',
2787 return_value='https://chromium-review.googlesource.com').start()
2788 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
2789 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
2790 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
2791 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
2792 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
2793 mock.patch('git_cl.time_time').start()
2794 mock.patch('metrics.collector').start()
2795 mock.patch('subprocess2.Popen').start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002796 mock.patch('git_cl.Changelist.GetGerritProject',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002797 return_value='https://chromium-review.googlesource.com').start()
Edward Lemur227d5102020-02-25 23:45:35 +00002798 self.addCleanup(mock.patch.stopall)
2799 self.temp_count = 0
2800
Edward Lemur227d5102020-02-25 23:45:35 +00002801 def testRunHook(self):
2802 expected_results = {
2803 'more_cc': ['more@example.com', 'cc@example.com'],
2804 'should_continue': True,
2805 }
2806 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2807 git_cl.time_time.side_effect = [100, 200]
2808 mockProcess = mock.Mock()
2809 mockProcess.wait.return_value = 0
2810 subprocess2.Popen.return_value = mockProcess
2811
2812 cl = git_cl.Changelist()
2813 results = cl.RunHook(
2814 committing=True,
2815 may_prompt=True,
2816 verbose=2,
2817 parallel=True,
2818 upstream='upstream',
2819 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002820 all_files=True,
2821 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00002822
2823 self.assertEqual(expected_results, results)
2824 subprocess2.Popen.assert_called_once_with([
2825 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00002826 '--root', 'root',
2827 '--upstream', 'upstream',
2828 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002829 '--author', 'author',
2830 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00002831 '--issue', '123456',
2832 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002833 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00002834 '--may_prompt',
2835 '--parallel',
2836 '--all_files',
2837 '--json_output', '/tmp/fake-temp2',
2838 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002839 '--gerrit_project', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00002840 ])
2841 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002842 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00002843 metrics.collector.add_repeated('sub_commands', {
2844 'command': 'presubmit',
2845 'execution_time': 100,
2846 'exit_code': 0,
2847 })
2848
Edward Lemur99df04e2020-03-05 19:39:43 +00002849 def testRunHook_FewerOptions(self):
2850 expected_results = {
2851 'more_cc': ['more@example.com', 'cc@example.com'],
2852 'should_continue': True,
2853 }
2854 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2855 git_cl.time_time.side_effect = [100, 200]
2856 mockProcess = mock.Mock()
2857 mockProcess.wait.return_value = 0
2858 subprocess2.Popen.return_value = mockProcess
2859
2860 git_cl.Changelist.GetAuthor.return_value = None
2861 git_cl.Changelist.GetIssue.return_value = None
2862 git_cl.Changelist.GetPatchset.return_value = None
2863 git_cl.Changelist.GetCodereviewServer.return_value = None
2864
2865 cl = git_cl.Changelist()
2866 results = cl.RunHook(
2867 committing=False,
2868 may_prompt=False,
2869 verbose=0,
2870 parallel=False,
2871 upstream='upstream',
2872 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002873 all_files=False,
2874 resultdb=False)
Edward Lemur99df04e2020-03-05 19:39:43 +00002875
2876 self.assertEqual(expected_results, results)
2877 subprocess2.Popen.assert_called_once_with([
2878 'vpython', 'PRESUBMIT_SUPPORT',
2879 '--root', 'root',
2880 '--upstream', 'upstream',
2881 '--upload',
2882 '--json_output', '/tmp/fake-temp2',
2883 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002884 '--gerrit_project', 'https://chromium-review.googlesource.com',
Edward Lemur99df04e2020-03-05 19:39:43 +00002885 ])
2886 gclient_utils.FileWrite.assert_called_once_with(
2887 '/tmp/fake-temp1', 'description')
2888 metrics.collector.add_repeated('sub_commands', {
2889 'command': 'presubmit',
2890 'execution_time': 100,
2891 'exit_code': 0,
2892 })
2893
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002894 def testRunHook_FewerOptionsResultDB(self):
2895 expected_results = {
2896 'more_cc': ['more@example.com', 'cc@example.com'],
2897 'should_continue': True,
2898 }
2899 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2900 git_cl.time_time.side_effect = [100, 200]
2901 mockProcess = mock.Mock()
2902 mockProcess.wait.return_value = 0
2903 subprocess2.Popen.return_value = mockProcess
2904
2905 git_cl.Changelist.GetAuthor.return_value = None
2906 git_cl.Changelist.GetIssue.return_value = None
2907 git_cl.Changelist.GetPatchset.return_value = None
2908 git_cl.Changelist.GetCodereviewServer.return_value = None
2909
2910 cl = git_cl.Changelist()
2911 results = cl.RunHook(
2912 committing=False,
2913 may_prompt=False,
2914 verbose=0,
2915 parallel=False,
2916 upstream='upstream',
2917 description='description',
2918 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002919 resultdb=True,
2920 realm='chromium:public')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002921
2922 self.assertEqual(expected_results, results)
2923 subprocess2.Popen.assert_called_once_with([
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002924 'rdb', 'stream', '-new', '-realm', 'chromium:public', '--',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002925 'vpython', 'PRESUBMIT_SUPPORT',
2926 '--root', 'root',
2927 '--upstream', 'upstream',
2928 '--upload',
2929 '--json_output', '/tmp/fake-temp2',
2930 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002931 '--gerrit_project', 'https://chromium-review.googlesource.com',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002932 ])
2933
Edward Lemur227d5102020-02-25 23:45:35 +00002934 @mock.patch('sys.exit', side_effect=SystemExitMock)
2935 def testRunHook_Failure(self, _mock):
2936 git_cl.time_time.side_effect = [100, 200]
2937 mockProcess = mock.Mock()
2938 mockProcess.wait.return_value = 2
2939 subprocess2.Popen.return_value = mockProcess
2940
2941 cl = git_cl.Changelist()
2942 with self.assertRaises(SystemExitMock):
2943 cl.RunHook(
2944 committing=True,
2945 may_prompt=True,
2946 verbose=2,
2947 parallel=True,
2948 upstream='upstream',
2949 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002950 all_files=True,
2951 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00002952
2953 sys.exit.assert_called_once_with(2)
2954
Edward Lemur75526302020-02-27 22:31:05 +00002955 def testRunPostUploadHook(self):
2956 cl = git_cl.Changelist()
2957 cl.RunPostUploadHook(2, 'upstream', 'description')
2958
2959 subprocess2.Popen.assert_called_once_with([
2960 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00002961 '--root', 'root',
2962 '--upstream', 'upstream',
2963 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002964 '--author', 'author',
2965 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur75526302020-02-27 22:31:05 +00002966 '--issue', '123456',
2967 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002968 '--post_upload',
2969 '--description_file', '/tmp/fake-temp1',
2970 ])
2971 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002972 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00002973
Edward Lemur9aa1a962020-02-25 00:58:38 +00002974
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002975class CMDTestCaseBase(unittest.TestCase):
2976 _STATUSES = [
2977 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
2978 'INFRA_FAILURE', 'CANCELED',
2979 ]
2980 _CHANGE_DETAIL = {
2981 'project': 'depot_tools',
2982 'status': 'OPEN',
2983 'owner': {'email': 'owner@e.mail'},
2984 'current_revision': 'beeeeeef',
2985 'revisions': {
Gavin Make61ccc52020-11-13 00:12:57 +00002986 'deadbeaf': {
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00002987 '_number': 6,
Gavin Make61ccc52020-11-13 00:12:57 +00002988 'kind': 'REWORK',
2989 },
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002990 'beeeeeef': {
2991 '_number': 7,
Gavin Make61ccc52020-11-13 00:12:57 +00002992 'kind': 'NO_CODE_CHANGE',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002993 'fetch': {'http': {
2994 'url': 'https://chromium.googlesource.com/depot_tools',
2995 'ref': 'refs/changes/56/123456/7'
2996 }},
2997 },
2998 },
2999 }
3000 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003001 'builds': [{
3002 'id': str(100 + idx),
3003 'builder': {
3004 'project': 'chromium',
3005 'bucket': 'try',
3006 'builder': 'bot_' + status.lower(),
3007 },
3008 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3009 'tags': [],
3010 'status': status,
3011 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003012 }
3013
Edward Lemur4c707a22019-09-24 21:13:43 +00003014 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003015 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003016 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003017 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3018 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003019 mock.patch(
3020 'git_cl.Changelist.GetCodereviewServer',
3021 return_value='https://chromium-review.googlesource.com').start()
3022 mock.patch(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00003023 'git_cl.Changelist.GetGerritHost',
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003024 return_value='chromium-review.googlesource.com').start()
3025 mock.patch(
3026 'git_cl.Changelist.GetMostRecentPatchset',
3027 return_value=7).start()
3028 mock.patch(
Gavin Make61ccc52020-11-13 00:12:57 +00003029 'git_cl.Changelist.GetMostRecentDryRunPatchset',
3030 return_value=6).start()
3031 mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003032 'git_cl.Changelist.GetRemoteUrl',
3033 return_value='https://chromium.googlesource.com/depot_tools').start()
3034 mock.patch(
3035 'auth.Authenticator',
3036 return_value=AuthenticatorMock()).start()
3037 mock.patch(
3038 'gerrit_util.GetChangeDetail',
3039 return_value=self._CHANGE_DETAIL).start()
3040 mock.patch(
3041 'git_cl._call_buildbucket',
3042 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003043 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003044 self.addCleanup(mock.patch.stopall)
3045
Edward Lemur4c707a22019-09-24 21:13:43 +00003046
Edward Lemur9468eba2020-02-27 19:07:22 +00003047class CMDPresubmitTestCase(CMDTestCaseBase):
3048 def setUp(self):
3049 super(CMDPresubmitTestCase, self).setUp()
3050 mock.patch(
3051 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3052 return_value='upstream').start()
3053 mock.patch(
3054 'git_cl.Changelist.FetchDescription',
3055 return_value='fetch description').start()
3056 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00003057 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00003058 return_value='get description').start()
3059 mock.patch('git_cl.Changelist.RunHook').start()
3060
3061 def testDefaultCase(self):
3062 self.assertEqual(0, git_cl.main(['presubmit']))
3063 git_cl.Changelist.RunHook.assert_called_once_with(
3064 committing=True,
3065 may_prompt=False,
3066 verbose=0,
3067 parallel=None,
3068 upstream='upstream',
3069 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003070 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003071 resultdb=None,
3072 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003073
3074 def testNoIssue(self):
3075 git_cl.Changelist.GetIssue.return_value = None
3076 self.assertEqual(0, git_cl.main(['presubmit']))
3077 git_cl.Changelist.RunHook.assert_called_once_with(
3078 committing=True,
3079 may_prompt=False,
3080 verbose=0,
3081 parallel=None,
3082 upstream='upstream',
3083 description='get description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003084 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003085 resultdb=None,
3086 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003087
3088 def testCustomBranch(self):
3089 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3090 git_cl.Changelist.RunHook.assert_called_once_with(
3091 committing=True,
3092 may_prompt=False,
3093 verbose=0,
3094 parallel=None,
3095 upstream='custom_branch',
3096 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003097 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003098 resultdb=None,
3099 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003100
3101 def testOptions(self):
3102 self.assertEqual(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003103 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003104 '--resultdb', '--realm', 'chromium:public']))
Edward Lemur9468eba2020-02-27 19:07:22 +00003105 git_cl.Changelist.RunHook.assert_called_once_with(
3106 committing=False,
3107 may_prompt=False,
3108 verbose=2,
3109 parallel=True,
3110 upstream='upstream',
3111 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003112 all_files=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003113 resultdb=True,
3114 realm='chromium:public')
Edward Lemur9468eba2020-02-27 19:07:22 +00003115
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003116class CMDTryResultsTestCase(CMDTestCaseBase):
3117 _DEFAULT_REQUEST = {
3118 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003119 "gerritChanges": [{
3120 "project": "depot_tools",
3121 "host": "chromium-review.googlesource.com",
Gavin Make61ccc52020-11-13 00:12:57 +00003122 "patchset": 6,
3123 "change": 123456,
3124 }],
3125 },
3126 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3127 ',builds.*.createTime,builds.*.tags'),
3128 }
3129
3130 _TRIVIAL_REQUEST = {
3131 'predicate': {
3132 "gerritChanges": [{
3133 "project": "depot_tools",
3134 "host": "chromium-review.googlesource.com",
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003135 "patchset": 7,
3136 "change": 123456,
3137 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003138 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003139 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3140 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003141 }
3142
3143 def testNoJobs(self):
3144 git_cl._call_buildbucket.return_value = {}
3145
3146 self.assertEqual(0, git_cl.main(['try-results']))
3147 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3148 git_cl._call_buildbucket.assert_called_once_with(
3149 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3150 self._DEFAULT_REQUEST)
3151
Gavin Make61ccc52020-11-13 00:12:57 +00003152 def testTrivialCommits(self):
3153 self.assertEqual(0, git_cl.main(['try-results']))
3154 git_cl._call_buildbucket.assert_called_with(
3155 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3156 self._DEFAULT_REQUEST)
3157
3158 git_cl._call_buildbucket.return_value = {}
3159 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '7']))
3160 git_cl._call_buildbucket.assert_called_with(
3161 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3162 self._TRIVIAL_REQUEST)
3163 self.assertEqual([
3164 'Successes:',
3165 ' bot_success https://ci.chromium.org/b/103',
3166 'Infra Failures:',
3167 ' bot_infra_failure https://ci.chromium.org/b/105',
3168 'Failures:',
3169 ' bot_failure https://ci.chromium.org/b/104',
3170 'Canceled:',
3171 ' bot_canceled ',
3172 'Started:',
3173 ' bot_started https://ci.chromium.org/b/102',
3174 'Scheduled:',
3175 ' bot_scheduled id=101',
3176 'Other:',
3177 ' bot_status_unspecified id=100',
3178 'Total: 7 tryjobs',
3179 'No tryjobs scheduled.',
3180 ], sys.stdout.getvalue().splitlines())
3181
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003182 def testPrintToStdout(self):
3183 self.assertEqual(0, git_cl.main(['try-results']))
3184 self.assertEqual([
3185 'Successes:',
3186 ' bot_success https://ci.chromium.org/b/103',
3187 'Infra Failures:',
3188 ' bot_infra_failure https://ci.chromium.org/b/105',
3189 'Failures:',
3190 ' bot_failure https://ci.chromium.org/b/104',
3191 'Canceled:',
3192 ' bot_canceled ',
3193 'Started:',
3194 ' bot_started https://ci.chromium.org/b/102',
3195 'Scheduled:',
3196 ' bot_scheduled id=101',
3197 'Other:',
3198 ' bot_status_unspecified id=100',
3199 'Total: 7 tryjobs',
3200 ], sys.stdout.getvalue().splitlines())
3201 git_cl._call_buildbucket.assert_called_once_with(
3202 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3203 self._DEFAULT_REQUEST)
3204
3205 def testPrintToStdoutWithMasters(self):
3206 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3207 self.assertEqual([
3208 'Successes:',
3209 ' try bot_success https://ci.chromium.org/b/103',
3210 'Infra Failures:',
3211 ' try bot_infra_failure https://ci.chromium.org/b/105',
3212 'Failures:',
3213 ' try bot_failure https://ci.chromium.org/b/104',
3214 'Canceled:',
3215 ' try bot_canceled ',
3216 'Started:',
3217 ' try bot_started https://ci.chromium.org/b/102',
3218 'Scheduled:',
3219 ' try bot_scheduled id=101',
3220 'Other:',
3221 ' try bot_status_unspecified id=100',
3222 'Total: 7 tryjobs',
3223 ], sys.stdout.getvalue().splitlines())
3224 git_cl._call_buildbucket.assert_called_once_with(
3225 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3226 self._DEFAULT_REQUEST)
3227
3228 @mock.patch('git_cl.write_json')
3229 def testWriteToJson(self, mockJsonDump):
3230 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3231 git_cl._call_buildbucket.assert_called_once_with(
3232 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3233 self._DEFAULT_REQUEST)
3234 mockJsonDump.assert_called_once_with(
3235 'file.json', self._DEFAULT_RESPONSE['builds'])
3236
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003237 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003238 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3239 self.assertEqual(
3240 [
3241 ('chromium', 'try', 'bot_failure'),
3242 ('chromium', 'try', 'bot_infra_failure'),
3243 ],
3244 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003245
3246 def test_filter_failed_for_retry_many_builds(self):
3247
3248 def _build(name, created_sec, status, experimental=False):
3249 assert 0 <= created_sec < 100, created_sec
3250 b = {
3251 'id': 112112,
3252 'builder': {
3253 'project': 'chromium',
3254 'bucket': 'try',
3255 'builder': name,
3256 },
3257 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3258 'status': status,
3259 'tags': [],
3260 }
3261 if experimental:
3262 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3263 return b
3264
3265 builds = [
3266 _build('flaky-last-green', 1, 'FAILURE'),
3267 _build('flaky-last-green', 2, 'SUCCESS'),
3268 _build('flaky', 1, 'SUCCESS'),
3269 _build('flaky', 2, 'FAILURE'),
3270 _build('running', 1, 'FAILED'),
3271 _build('running', 2, 'SCHEDULED'),
3272 _build('yep-still-running', 1, 'STARTED'),
3273 _build('yep-still-running', 2, 'FAILURE'),
3274 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3275 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3276
3277 # Simulate experimental in CQ builder, which developer decided
3278 # to retry manually which resulted in 2nd build non-experimental.
3279 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3280 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3281 ]
3282 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003283 self.assertEqual(
3284 [
3285 ('chromium', 'try', 'flaky'),
3286 ('chromium', 'try', 'sometimes-experimental'),
3287 ],
3288 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003289
3290
3291class CMDTryTestCase(CMDTestCaseBase):
3292
3293 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003294 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003295 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003296 self.assertEqual(0, git_cl.main(['try']))
3297 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3298 self.assertEqual(
3299 sys.stdout.getvalue(),
3300 'Scheduling CQ dry run on: '
3301 'https://chromium-review.googlesource.com/123456\n')
3302
Edward Lemur4c707a22019-09-24 21:13:43 +00003303 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003304 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003305 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003306
3307 self.assertEqual(0, git_cl.main([
3308 'try', '-B', 'luci.chromium.try', '-b', 'win',
3309 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3310 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003311 'Scheduling jobs on:\n'
3312 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003313 git_cl.sys.stdout.getvalue())
3314
3315 expected_request = {
3316 "requests": [{
3317 "scheduleBuild": {
3318 "requestId": "uuid4",
3319 "builder": {
3320 "project": "chromium",
3321 "builder": "win",
3322 "bucket": "try",
3323 },
3324 "gerritChanges": [{
3325 "project": "depot_tools",
3326 "host": "chromium-review.googlesource.com",
3327 "patchset": 7,
3328 "change": 123456,
3329 }],
3330 "properties": {
3331 "category": "git_cl_try",
3332 "json": [{"a": 1}, None],
3333 "key": "val",
3334 },
3335 "tags": [
3336 {"value": "win", "key": "builder"},
3337 {"value": "git_cl_try", "key": "user_agent"},
3338 ],
3339 },
3340 }],
3341 }
3342 mockCallBuildbucket.assert_called_with(
3343 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3344
Anthony Polito1a5fe232020-01-24 23:17:52 +00003345 @mock.patch('git_cl._call_buildbucket')
3346 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3347 mockCallBuildbucket.return_value = {}
3348
3349 self.assertEqual(0, git_cl.main([
3350 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3351 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3352 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3353 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003354 'Scheduling jobs on:\n'
3355 ' chromium/try: linux\n'
3356 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003357 git_cl.sys.stdout.getvalue())
3358
3359 expected_request = {
3360 "requests": [{
3361 "scheduleBuild": {
3362 "requestId": "uuid4",
3363 "builder": {
3364 "project": "chromium",
3365 "builder": "linux",
3366 "bucket": "try",
3367 },
3368 "gerritChanges": [{
3369 "project": "depot_tools",
3370 "host": "chromium-review.googlesource.com",
3371 "patchset": 7,
3372 "change": 123456,
3373 }],
3374 "properties": {
3375 "category": "git_cl_try",
3376 "json": [{"a": 1}, None],
3377 "key": "val",
3378 },
3379 "tags": [
3380 {"value": "linux", "key": "builder"},
3381 {"value": "git_cl_try", "key": "user_agent"},
3382 ],
3383 "gitilesCommit": {
3384 "host": "chromium-review.googlesource.com",
3385 "project": "depot_tools",
3386 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3387 }
3388 },
3389 },
3390 {
3391 "scheduleBuild": {
3392 "requestId": "uuid4",
3393 "builder": {
3394 "project": "chromium",
3395 "builder": "win",
3396 "bucket": "try",
3397 },
3398 "gerritChanges": [{
3399 "project": "depot_tools",
3400 "host": "chromium-review.googlesource.com",
3401 "patchset": 7,
3402 "change": 123456,
3403 }],
3404 "properties": {
3405 "category": "git_cl_try",
3406 "json": [{"a": 1}, None],
3407 "key": "val",
3408 },
3409 "tags": [
3410 {"value": "win", "key": "builder"},
3411 {"value": "git_cl_try", "key": "user_agent"},
3412 ],
3413 "gitilesCommit": {
3414 "host": "chromium-review.googlesource.com",
3415 "project": "depot_tools",
3416 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3417 }
3418 },
3419 }],
3420 }
3421 mockCallBuildbucket.assert_called_with(
3422 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3423
Edward Lemur45768512020-03-02 19:03:14 +00003424 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003425 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003426 with self.assertRaises(SystemExit):
3427 git_cl.main([
3428 'try', '-B', 'not-a-bucket', '-b', 'win',
3429 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003430 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003431 'Invalid bucket: not-a-bucket.',
3432 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003433
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003434 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003435 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003436 def testScheduleOnBuildbucketRetryFailed(
3437 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003438 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003439 7: [],
3440 6: [{
3441 'id': 112112,
3442 'builder': {
3443 'project': 'chromium',
3444 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003445 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003446 'createTime': '2019-10-09T08:00:01.854286Z',
3447 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003448 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003449 mockCallBuildbucket.return_value = {}
3450
3451 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3452 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003453 'Scheduling jobs on:\n'
3454 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003455 git_cl.sys.stdout.getvalue())
3456
3457 expected_request = {
3458 "requests": [{
3459 "scheduleBuild": {
3460 "requestId": "uuid4",
3461 "builder": {
3462 "project": "chromium",
3463 "bucket": "try",
3464 "builder": "linux",
3465 },
3466 "gerritChanges": [{
3467 "project": "depot_tools",
3468 "host": "chromium-review.googlesource.com",
3469 "patchset": 7,
3470 "change": 123456,
3471 }],
3472 "properties": {
3473 "category": "git_cl_try",
3474 },
3475 "tags": [
3476 {"value": "linux", "key": "builder"},
3477 {"value": "git_cl_try", "key": "user_agent"},
3478 {"value": "1", "key": "retry_failed"},
3479 ],
3480 },
3481 }],
3482 }
3483 mockCallBuildbucket.assert_called_with(
3484 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3485
Edward Lemur4c707a22019-09-24 21:13:43 +00003486 def test_parse_bucket(self):
3487 test_cases = [
3488 {
3489 'bucket': 'chromium/try',
3490 'result': ('chromium', 'try'),
3491 },
3492 {
3493 'bucket': 'luci.chromium.try',
3494 'result': ('chromium', 'try'),
3495 'has_warning': True,
3496 },
3497 {
3498 'bucket': 'skia.primary',
3499 'result': ('skia', 'skia.primary'),
3500 'has_warning': True,
3501 },
3502 {
3503 'bucket': 'not-a-bucket',
3504 'result': (None, None),
3505 },
3506 ]
3507
3508 for test_case in test_cases:
3509 git_cl.sys.stdout.truncate(0)
3510 self.assertEqual(
3511 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3512 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003513 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3514 test_case['result'])
3515 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003516
3517
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003518class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003519
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003520 def setUp(self):
3521 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003522 mock.patch('git_cl._fetch_tryjobs').start()
3523 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003524 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003525 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3526 mock.patch(
3527 'git_cl.Settings.GetSquashGerritUploads',
3528 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003529 self.addCleanup(mock.patch.stopall)
3530
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003531 def testWarmUpChangeDetailCache(self):
3532 self.assertEqual(0, git_cl.main(['upload']))
3533 gerrit_util.GetChangeDetail.assert_called_once_with(
3534 'chromium-review.googlesource.com', 'depot_tools~123456',
3535 frozenset([
3536 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3537 'CURRENT_COMMIT']))
3538
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003539 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003540 # This test mocks out the actual upload part, and just asserts that after
3541 # upload, if --retry-failed is added, then the tool will fetch try jobs
3542 # from the previous patchset and trigger the right builders on the latest
3543 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003544 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003545 # Latest patchset: No builds.
3546 [],
3547 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003548 [{
3549 'id': str(100 + idx),
3550 'builder': {
3551 'project': 'chromium',
3552 'bucket': 'try',
3553 'builder': 'bot_' + status.lower(),
3554 },
3555 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3556 'tags': [],
3557 'status': status,
3558 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003559 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003560
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003561 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003562 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003563 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3564 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003565 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003566 expected_buckets = [
3567 ('chromium', 'try', 'bot_failure'),
3568 ('chromium', 'try', 'bot_infra_failure'),
3569 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003570 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3571 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003572
Brian Sheedy59b06a82019-10-14 17:03:29 +00003573
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003574class MakeRequestsHelperTestCase(unittest.TestCase):
3575
3576 def exampleGerritChange(self):
3577 return {
3578 'host': 'chromium-review.googlesource.com',
3579 'project': 'depot_tools',
3580 'change': 1,
3581 'patchset': 2,
3582 }
3583
3584 def testMakeRequestsHelperNoOptions(self):
3585 # Basic test for the helper function _make_tryjob_schedule_requests;
3586 # it shouldn't throw AttributeError even when options doesn't have any
3587 # of the expected values; it will use default option values.
3588 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3589 jobs = [('chromium', 'try', 'my-builder')]
3590 options = optparse.Values()
3591 requests = git_cl._make_tryjob_schedule_requests(
3592 changelist, jobs, options, patchset=None)
3593
3594 # requestId is non-deterministic. Just assert that it's there and has
3595 # a particular length.
3596 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3597 self.assertEqual(requests, [{
3598 'scheduleBuild': {
3599 'builder': {
3600 'bucket': 'try',
3601 'builder': 'my-builder',
3602 'project': 'chromium'
3603 },
3604 'gerritChanges': [self.exampleGerritChange()],
3605 'properties': {
3606 'category': 'git_cl_try'
3607 },
3608 'tags': [{
3609 'key': 'builder',
3610 'value': 'my-builder'
3611 }, {
3612 'key': 'user_agent',
3613 'value': 'git_cl_try'
3614 }]
3615 }
3616 }])
3617
3618 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3619 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3620 jobs = [('chromium', 'try', 'presubmit')]
3621 options = optparse.Values()
3622 requests = git_cl._make_tryjob_schedule_requests(
3623 changelist, jobs, options, patchset=None)
3624 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3625 'category': 'git_cl_try',
3626 'dry_run': 'true'
3627 })
3628
3629 def testMakeRequestsHelperRevisionSet(self):
3630 # Gitiles commit is specified when revision is in options.
3631 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3632 jobs = [('chromium', 'try', 'my-builder')]
3633 options = optparse.Values({'revision': 'ba5eba11'})
3634 requests = git_cl._make_tryjob_schedule_requests(
3635 changelist, jobs, options, patchset=None)
3636 self.assertEqual(
3637 requests[0]['scheduleBuild']['gitilesCommit'], {
3638 'host': 'chromium-review.googlesource.com',
3639 'id': 'ba5eba11',
3640 'project': 'depot_tools'
3641 })
3642
3643 def testMakeRequestsHelperRetryFailedSet(self):
3644 # An extra tag is added when retry_failed is in options.
3645 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3646 jobs = [('chromium', 'try', 'my-builder')]
3647 options = optparse.Values({'retry_failed': 'true'})
3648 requests = git_cl._make_tryjob_schedule_requests(
3649 changelist, jobs, options, patchset=None)
3650 self.assertEqual(
3651 requests[0]['scheduleBuild']['tags'], [
3652 {
3653 'key': 'builder',
3654 'value': 'my-builder'
3655 },
3656 {
3657 'key': 'user_agent',
3658 'value': 'git_cl_try'
3659 },
3660 {
3661 'key': 'retry_failed',
3662 'value': '1'
3663 }
3664 ])
3665
3666 def testMakeRequestsHelperCategorySet(self):
Quinten Yearsley925cedb2020-04-13 17:49:39 +00003667 # The category property can be overridden with options.
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003668 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3669 jobs = [('chromium', 'try', 'my-builder')]
3670 options = optparse.Values({'category': 'my-special-category'})
3671 requests = git_cl._make_tryjob_schedule_requests(
3672 changelist, jobs, options, patchset=None)
3673 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3674 {'category': 'my-special-category'})
3675
3676
Edward Lemurda4b6c62020-02-13 00:28:40 +00003677class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003678
3679 def setUp(self):
3680 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003681 mock.patch('git_cl.RunCommand').start()
3682 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3683 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3684 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003685 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003686 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003687
3688 def tearDown(self):
3689 shutil.rmtree(self._top_dir)
3690 super(CMDFormatTestCase, self).tearDown()
3691
Jamie Madill5e96ad12020-01-13 16:08:35 +00003692 def _make_temp_file(self, fname, contents):
3693 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3694 tf.write('\n'.join(contents))
3695
Brian Sheedy59b06a82019-10-14 17:03:29 +00003696 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003697 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003698
Brian Sheedyb4307d52019-12-02 19:18:17 +00003699 def _check_yapf_filtering(self, files, expected):
3700 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3701 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003702
Edward Lemur1a83da12020-03-04 21:18:36 +00003703 def _run_command_mock(self, return_value):
3704 def f(*args, **kwargs):
3705 if 'stdin' in kwargs:
3706 self.assertIsInstance(kwargs['stdin'], bytes)
3707 return return_value
3708 return f
3709
Jamie Madill5e96ad12020-01-13 16:08:35 +00003710 def testClangFormatDiffFull(self):
3711 self._make_temp_file('test.cc', ['// test'])
3712 git_cl.settings.GetFormatFullByDefault.return_value = False
3713 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3714 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3715
3716 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003717 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003718 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3719 self._top_dir, 'HEAD')
3720 self.assertEqual(2, return_value)
3721
3722 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003723 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003724 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3725 self._top_dir, 'HEAD')
3726 self.assertEqual(0, return_value)
3727
3728 def testClangFormatDiff(self):
3729 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00003730 # A valid file is required, so use this test.
3731 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00003732 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3733
3734 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003735 git_cl.RunCommand.side_effect = self._run_command_mock('error')
3736 return_value = git_cl._RunClangFormatDiff(
3737 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003738 self.assertEqual(2, return_value)
3739
3740 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003741 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003742 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3743 'HEAD')
3744 self.assertEqual(0, return_value)
3745
Brian Sheedyb4307d52019-12-02 19:18:17 +00003746 def testYapfignoreExplicit(self):
3747 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3748 files = [
3749 'bar.py',
3750 'foo/bar.py',
3751 'foo/baz.py',
3752 'foo/bar/baz.py',
3753 'foo/bar/foobar.py',
3754 ]
3755 expected = [
3756 'bar.py',
3757 'foo/baz.py',
3758 'foo/bar/foobar.py',
3759 ]
3760 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003761
Brian Sheedyb4307d52019-12-02 19:18:17 +00003762 def testYapfignoreSingleWildcards(self):
3763 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3764 files = [
3765 'bar.py', # Matched by *bar.py.
3766 'bar.txt',
3767 'foobar.py', # Matched by *bar.py, foo*.
3768 'foobar.txt', # Matched by foo*.
3769 'bazbar.py', # Matched by *bar.py, baz*.py.
3770 'bazbar.txt',
3771 'foo/baz.txt', # Matched by foo*.
3772 'bar/bar.py', # Matched by *bar.py.
3773 'baz/foo.py', # Matched by baz*.py, foo*.
3774 'baz/foo.txt',
3775 ]
3776 expected = [
3777 'bar.txt',
3778 'bazbar.txt',
3779 'baz/foo.txt',
3780 ]
3781 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003782
Brian Sheedyb4307d52019-12-02 19:18:17 +00003783 def testYapfignoreMultiplewildcards(self):
3784 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3785 files = [
3786 'bar.py', # Matched by *bar*.
3787 'bar.txt', # Matched by *bar*.
3788 'abar.py', # Matched by *bar*.
3789 'foobaz.txt', # Matched by *foo*baz.txt.
3790 'foobaz.py',
3791 'afoobaz.txt', # Matched by *foo*baz.txt.
3792 ]
3793 expected = [
3794 'foobaz.py',
3795 ]
3796 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003797
3798 def testYapfignoreComments(self):
3799 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003800 files = [
3801 'test.py',
3802 'test2.py',
3803 ]
3804 expected = [
3805 'test2.py',
3806 ]
3807 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003808
3809 def testYapfignoreBlankLines(self):
3810 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003811 files = [
3812 'test.py',
3813 'test2.py',
3814 'test3.py',
3815 ]
3816 expected = [
3817 'test3.py',
3818 ]
3819 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003820
3821 def testYapfignoreWhitespace(self):
3822 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003823 files = [
3824 'test.py',
3825 'test2.py',
3826 ]
3827 expected = [
3828 'test2.py',
3829 ]
3830 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003831
Brian Sheedyb4307d52019-12-02 19:18:17 +00003832 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003833 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003834 self._check_yapf_filtering([], [])
3835
3836 def testYapfignoreMissingYapfignore(self):
3837 files = [
3838 'test.py',
3839 ]
3840 expected = [
3841 'test.py',
3842 ]
3843 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003844
3845
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003846class CMDStatusTestCase(CMDTestCaseBase):
3847 # Return branch names a,..,f with comitterdates in increasing order, i.e.
3848 # 'f' is the most-recently changed branch.
3849 def _mock_run_git(commands):
3850 if commands == [
3851 'for-each-ref', '--format=%(refname) %(committerdate:unix)',
3852 'refs/heads'
3853 ]:
3854 branches_and_committerdates = [
3855 'refs/heads/a 1',
3856 'refs/heads/b 2',
3857 'refs/heads/c 3',
3858 'refs/heads/d 4',
3859 'refs/heads/e 5',
3860 'refs/heads/f 6',
3861 ]
3862 return '\n'.join(branches_and_committerdates)
3863
3864 # Mock the status in such a way that the issue number gives us an
3865 # indication of the commit date (simplifies manual debugging).
3866 def _mock_get_cl_statuses(branches, fine_grained, max_processes):
3867 for c in branches:
3868 c.issue = (100 + int(c.GetCommitDate()))
3869 yield (c, 'open')
3870
3871 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
3872 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
3873 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
3874 @mock.patch('git_cl.RunGit', _mock_run_git)
3875 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
3876 @mock.patch('git_cl.Settings.GetRoot', return_value='')
3877 @mock.patch('scm.GIT.GetBranch', return_value='a')
3878 def testStatus(self, *_mocks):
3879 self.assertEqual(0, git_cl.main(['status', '--no-branch-color']))
3880 self.maxDiff = None
3881 self.assertEqual(
3882 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
3883 ' * a : https://crrev.com/c/101 (open)\n'
3884 ' b : https://crrev.com/c/102 (open)\n'
3885 ' c : https://crrev.com/c/103 (open)\n'
3886 ' d : https://crrev.com/c/104 (open)\n'
3887 ' e : https://crrev.com/c/105 (open)\n'
3888 ' f : https://crrev.com/c/106 (open)\n\n'
3889 'Current branch: a\n'
3890 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
3891 'Issue description:\n'
3892 'x\n')
3893
3894 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
3895 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
3896 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
3897 @mock.patch('git_cl.RunGit', _mock_run_git)
3898 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
3899 @mock.patch('git_cl.Settings.GetRoot', return_value='')
3900 @mock.patch('scm.GIT.GetBranch', return_value='a')
3901 def testStatusByDate(self, *_mocks):
3902 self.assertEqual(
3903 0, git_cl.main(['status', '--no-branch-color', '--date-order']))
3904 self.maxDiff = None
3905 self.assertEqual(
3906 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
3907 ' f : https://crrev.com/c/106 (open)\n'
3908 ' e : https://crrev.com/c/105 (open)\n'
3909 ' d : https://crrev.com/c/104 (open)\n'
3910 ' c : https://crrev.com/c/103 (open)\n'
3911 ' b : https://crrev.com/c/102 (open)\n'
3912 ' * a : https://crrev.com/c/101 (open)\n\n'
3913 'Current branch: a\n'
3914 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
3915 'Issue description:\n'
3916 'x\n')
3917
3918
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003919if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003920 logging.basicConfig(
3921 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003922 unittest.main()