blob: 8b144e83027880b44509e8508ed8a01f37dd41fc [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
34# We have to disable monitoring before importing git_cl.
35metrics.DISABLE_METRICS_COLLECTION = True
36
Jamie Madill5e96ad12020-01-13 16:08:35 +000037import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000038import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000039import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000040import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000041import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000042import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000043import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000044import git_new_branch
45import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000046import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000047
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000048NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
49
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000050
Edward Lemur0db01f02019-11-12 22:01:51 +000051def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070052 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
53
tandrii5d48c322016-08-18 16:19:37 -070054CERR1 = callError(1)
55
56
Edward Lemur1773f372020-02-22 00:27:14 +000057class TemporaryFileMock(object):
58 def __init__(self):
59 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070060
Edward Lemur1773f372020-02-22 00:27:14 +000061 @contextlib.contextmanager
62 def __call__(self):
63 self.suffix += 1
64 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070065
66
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000067class ChangelistMock(object):
68 # A class variable so we can access it when we don't have access to the
69 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000070 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000071
72 def __init__(self, gerrit_change=None, **kwargs):
73 self._gerrit_change = gerrit_change
74
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000075 def GetIssue(self):
76 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000077
Edward Lemur6c6827c2020-02-06 21:15:18 +000078 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000079 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000080
dsansomee2d6fd92016-09-08 00:10:47 -070081 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000082 ChangelistMock.desc = desc
83
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000084 def GetGerritChange(self, patchset=None, **kwargs):
85 del patchset
86 return self._gerrit_change
87
tandrii5d48c322016-08-18 16:19:37 -070088
Edward Lemur85153282020-02-14 22:06:29 +000089class GitMocks(object):
90 def __init__(self, config=None, branchref=None):
91 self.branchref = branchref or 'refs/heads/master'
92 self.config = config or {}
93
94 def GetBranchRef(self, _root):
95 return self.branchref
96
97 def NewBranch(self, branchref):
98 self.branchref = branchref
99
Edward Lemur26964072020-02-19 19:18:51 +0000100 def GetConfig(self, root, key, default=None):
101 if root != '':
102 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000103 return self.config.get(key, default)
104
Edward Lemur26964072020-02-19 19:18:51 +0000105 def SetConfig(self, root, key, value=None):
106 if root != '':
107 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000108 if value:
109 self.config[key] = value
110 return
111 if key not in self.config:
112 raise CERR1
113 del self.config[key]
114
115
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000116class WatchlistsMock(object):
117 def __init__(self, _):
118 pass
119 @staticmethod
120 def GetWatchersForPaths(_):
121 return ['joe@example.com']
122
123
Edward Lemur4c707a22019-09-24 21:13:43 +0000124class CodereviewSettingsFileMock(object):
125 def __init__(self):
126 pass
127 # pylint: disable=no-self-use
128 def read(self):
129 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
130 'GERRIT_HOST: True\n')
131
132
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000133class AuthenticatorMock(object):
134 def __init__(self, *_args):
135 pass
136 def has_cached_credentials(self):
137 return True
tandrii221ab252016-10-06 08:12:04 -0700138 def authorize(self, http):
139 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000140
141
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100142def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000143 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
144
145 Usage:
146 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000148
149 OR
150 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100151 CookiesAuthenticatorMockFactory(
152 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000153 """
154 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800155 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000156 # Intentionally not calling super() because it reads actual cookie files.
157 pass
158 @classmethod
159 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000160 return os.path.join('~', '.gitcookies')
161
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162 @classmethod
163 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000164 return os.path.join('~', NETRC_FILENAME)
165
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100166 def _get_auth_for_host(self, host):
167 if same_auth:
168 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000169 return (hosts_with_creds or {}).get(host)
170 return CookiesAuthenticatorMock
171
Aaron Gable9a03ae02017-11-03 11:31:07 -0700172
kmarshall9249e012016-08-23 12:02:16 -0700173class MockChangelistWithBranchAndIssue():
174 def __init__(self, branch, issue):
175 self.branch = branch
176 self.issue = issue
177 def GetBranch(self):
178 return self.branch
179 def GetIssue(self):
180 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000181
tandriic2405f52016-10-10 08:13:15 -0700182
183class SystemExitMock(Exception):
184 pass
185
186
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000187class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000188 def setUp(self):
189 mock.patch('sys.exit', side_effect=SystemExitMock).start()
190 mock.patch('sys.stdout', StringIO()).start()
191 mock.patch('sys.stderr', StringIO()).start()
192 self.addCleanup(mock.patch.stopall)
193
194 def test_die_with_error(self):
195 with self.assertRaises(SystemExitMock):
196 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
197 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
198 self.assertTrue('saving CL description' in sys.stdout.getvalue())
199 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
200 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
201 sys.exit.assert_called_once_with(1)
202
203 def test_die_with_error_no_desc(self):
204 with self.assertRaises(SystemExitMock):
205 git_cl.DieWithError('foo')
206 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
207 self.assertEqual(sys.stdout.getvalue(), '')
208 sys.exit.assert_called_once_with(1)
209
Edward Lemur6c6827c2020-02-06 21:15:18 +0000210 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000211 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100212 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000213 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700214
Edward Lemur61bf4172020-02-24 23:22:37 +0000215 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
216 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
217 def test_get_cl_statuses(self, *_mocks):
218 statuses = [
219 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
220 changes = []
221 for status in statuses:
222 cl = git_cl.Changelist()
223 cl.status = status
224 changes.append(cl)
225
226 actual = set(git_cl.get_cl_statuses(changes, True))
227 self.assertEqual(set(zip(changes, statuses)), actual)
228
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000229 def test_upload_to_non_default_branch_no_retry(self):
230 m = mock.patch('git_cl.Changelist._CMDUploadChange',
231 side_effect=[git_cl.GitPushError(), None]).start()
232 mock.patch('git_cl.Changelist.GetRemoteBranch',
233 return_value=('foo', 'bar')).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000234 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000235 return_value='foo').start()
236 mock.patch('git_cl.gerrit_util.GetProjectHead',
237 return_value='refs/heads/main').start()
238
239 cl = git_cl.Changelist()
240 options = optparse.Values()
241 with self.assertRaises(SystemExitMock):
242 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
243
244 # ensure upload is called once
245 self.assertEqual(len(m.mock_calls), 1)
246 sys.exit.assert_called_once_with(1)
247 # option not set as retry didn't happen
248 self.assertFalse(hasattr(options, 'force'))
249 self.assertFalse(hasattr(options, 'edit_description'))
250
251 def test_upload_to_old_default_still_active(self):
252 m = mock.patch('git_cl.Changelist._CMDUploadChange',
253 side_effect=[git_cl.GitPushError(), None]).start()
254 mock.patch('git_cl.Changelist.GetRemoteBranch',
255 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000256 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000257 return_value='foo').start()
258 mock.patch('git_cl.gerrit_util.GetProjectHead',
259 return_value='refs/heads/old_default').start()
260
261 cl = git_cl.Changelist()
262 options = optparse.Values()
263 with self.assertRaises(SystemExitMock):
264 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
265
266 # ensure upload is called once
267 self.assertEqual(len(m.mock_calls), 1)
268 sys.exit.assert_called_once_with(1)
269 # option not set as retry didn't happen
270 self.assertFalse(hasattr(options, 'force'))
271 self.assertFalse(hasattr(options, 'edit_description'))
272
273 def test_upload_to_old_default_retry_on_failure(self):
274 m = mock.patch('git_cl.Changelist._CMDUploadChange',
275 side_effect=[git_cl.GitPushError(), None]).start()
276 mock.patch('git_cl.Changelist.GetRemoteBranch',
277 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000278 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000279 return_value='foo').start()
280 mock.patch('git_cl.gerrit_util.GetProjectHead',
281 return_value='refs/heads/main').start()
282 mock.patch('git_cl.RunGit').start()
283
284 cl = git_cl.Changelist()
285 options = optparse.Values()
286 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
287 # ensure upload is called twice
288 self.assertEqual(len(m.mock_calls), 2)
289 # option overrides on retry
290 self.assertEqual(options.force, True)
291 self.assertEqual(options.edit_description, False)
292
Edward Lemur61bf4172020-02-24 23:22:37 +0000293 def test_get_cl_statuses_no_changes(self):
294 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
295
296 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
297 @mock.patch('multiprocessing.pool.ThreadPool')
298 def test_get_cl_statuses_timeout(self, *_mocks):
299 changes = [git_cl.Changelist() for _ in range(2)]
300 pool = multiprocessing.pool.ThreadPool()
301 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
302 it.return_value.next.side_effect = [
303 (changes[0], 'lgtm'),
304 multiprocessing.TimeoutError,
305 ]
306
307 actual = list(git_cl.get_cl_statuses(changes, True))
308 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
309
310 @mock.patch('git_cl.Changelist.GetIssueURL')
311 def test_get_cl_statuses_not_finegrained(self, _mock):
312 changes = [git_cl.Changelist() for _ in range(2)]
313 urls = ['some-url', None]
314 git_cl.Changelist.GetIssueURL.side_effect = urls
315
316 actual = set(git_cl.get_cl_statuses(changes, False))
317 self.assertEqual(
318 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
319
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000320 def test_get_issue_url(self):
321 cl = git_cl.Changelist(issue=123)
322 cl._gerrit_server = 'https://example.com'
323 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
324 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
325
326 cl = git_cl.Changelist(issue=123)
327 cl._gerrit_server = 'https://chromium-review.googlesource.com'
328 self.assertEqual(cl.GetIssueURL(),
329 'https://chromium-review.googlesource.com/123')
330 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
331
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000332 def test_set_preserve_tryjobs(self):
333 d = git_cl.ChangeDescription('Simple.')
334 d.set_preserve_tryjobs()
335 self.assertEqual(d.description.splitlines(), [
336 'Simple.',
337 '',
338 'Cq-Do-Not-Cancel-Tryjobs: true',
339 ])
340 before = d.description
341 d.set_preserve_tryjobs()
342 self.assertEqual(before, d.description)
343
344 d = git_cl.ChangeDescription('\n'.join([
345 'One is enough',
346 '',
347 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
348 'Change-Id: Ideadbeef',
349 ]))
350 d.set_preserve_tryjobs()
351 self.assertEqual(d.description.splitlines(), [
352 'One is enough',
353 '',
354 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
355 'Change-Id: Ideadbeef',
356 'Cq-Do-Not-Cancel-Tryjobs: true',
357 ])
358
tandriif9aefb72016-07-01 09:06:51 -0700359 def test_get_bug_line_values(self):
360 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
361 self.assertEqual(f('', ''), [])
362 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
Lei Zhang8a0efc12020-08-05 19:58:45 +0000363 # Prefix that ends with colon.
364 self.assertEqual(f('v8:', '456'), ['v8:456'])
365 self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
366 # Prefix that ends without colon.
tandriif9aefb72016-07-01 09:06:51 -0700367 self.assertEqual(f('v8', '456'), ['v8:456'])
368 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
369 # Not nice, but not worth carying.
Lei Zhang8a0efc12020-08-05 19:58:45 +0000370 self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
371 ['v8:456', 'chromium:123', 'v8:123'])
tandriif9aefb72016-07-01 09:06:51 -0700372 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
373 ['v8:456', 'chromium:123', 'v8:123'])
374
Edward Lemurda4b6c62020-02-13 00:28:40 +0000375 @mock.patch('gerrit_util.GetAccountDetails')
376 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000377 mock_per_account = {
378 'u1': None, # 404, doesn't exist.
379 'u2': {
380 '_account_id': 123124,
381 'avatars': [],
382 'email': 'u2@example.com',
383 'name': 'User Number 2',
384 'status': 'OOO',
385 },
386 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
387 }
388 def GetAccountDetailsMock(_, account):
389 # Poor-man's mock library's side_effect.
390 v = mock_per_account.pop(account)
391 if isinstance(v, Exception):
392 raise v
393 return v
394
Edward Lemurda4b6c62020-02-13 00:28:40 +0000395 mockGetAccountDetails.side_effect = GetAccountDetailsMock
396 actual = git_cl.gerrit_util.ValidAccounts(
397 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000398 self.assertEqual(actual, {
399 'u2': {
400 '_account_id': 123124,
401 'avatars': [],
402 'email': 'u2@example.com',
403 'name': 'User Number 2',
404 'status': 'OOO',
405 },
406 })
407
408
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200409class TestParseIssueURL(unittest.TestCase):
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000410 def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
411 parsed = git_cl.ParseIssueNumberArgument(arg)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200412 self.assertIsNotNone(parsed)
413 if fail:
414 self.assertFalse(parsed.valid)
415 return
416 self.assertTrue(parsed.valid)
417 self.assertEqual(parsed.issue, issue)
418 self.assertEqual(parsed.patchset, patchset)
419 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200420
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000421 def test_basic(self):
422 self._test('123', 123)
423 self._test('', fail=True)
424 self._test('abc', fail=True)
425 self._test('123/1', fail=True)
426 self._test('123a', fail=True)
427 self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
428 self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200429
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000430 def test_gerrit_url(self):
431 self._test('https://codereview.source.com/123', 123, None,
432 'codereview.source.com')
433 self._test('http://chrome-review.source.com/c/123', 123, None,
434 'chrome-review.source.com')
435 self._test('https://chrome-review.source.com/c/123/', 123, None,
436 'chrome-review.source.com')
437 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
438 'chrome-review.source.com')
439 self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
440 'chrome-review.source.com')
441 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
442 'chrome-review.source.com')
443 self._test('https://chrome-review.source.com/123', 123, None,
444 'chrome-review.source.com')
445 self._test('https://chrome-review.source.com/123/4', 123, 4,
446 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200447
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000448 self._test('https://chrome-review.source.com/bad/123/4', fail=True)
449 self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
450 self._test('https://chrome-review.source.com/c/abc/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200451
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000452 def test_short_urls(self):
453 self._test('https://crrev.com/c/2151934', 2151934, None,
454 'chromium-review.googlesource.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200455
456
Edward Lemurda4b6c62020-02-13 00:28:40 +0000457class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100458 def setUp(self):
459 super(GitCookiesCheckerTest, self).setUp()
460 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100461 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000462 mock.patch('sys.stdout', StringIO()).start()
463 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100464
465 def mock_hosts_creds(self, subhost_identity_pairs):
466 def ensure_googlesource(h):
467 if not h.endswith(self.c._GOOGLESOURCE):
468 assert not h.endswith('.')
469 return h + '.' + self.c._GOOGLESOURCE
470 return h
471 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
472 for h, i in subhost_identity_pairs]
473
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200474 def test_identity_parsing(self):
475 self.assertEqual(self.c._parse_identity('ldap.google.com'),
476 ('ldap', 'google.com'))
477 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
478 ('ldap', 'example.com'))
479 # Specical case because we know there are no subdomains in chromium.org.
480 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
481 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800482 # Pathological: ".period." can be either username OR domain, more likely
483 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200484 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
485 ('note', 'period.example.com'))
486
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100487 def test_analysis_nothing(self):
488 self.c._all_hosts = []
489 self.assertFalse(self.c.has_generic_host())
490 self.assertEqual(set(), self.c.get_conflicting_hosts())
491 self.assertEqual(set(), self.c.get_duplicated_hosts())
492 self.assertEqual(set(), self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100493
494 def test_analysis(self):
495 self.mock_hosts_creds([
496 ('.googlesource.com', 'git-example.chromium.org'),
497
498 ('chromium', 'git-example.google.com'),
499 ('chromium-review', 'git-example.google.com'),
500 ('chrome-internal', 'git-example.chromium.org'),
501 ('chrome-internal-review', 'git-example.chromium.org'),
502 ('conflict', 'git-example.google.com'),
503 ('conflict-review', 'git-example.chromium.org'),
504 ('dup', 'git-example.google.com'),
505 ('dup', 'git-example.google.com'),
506 ('dup-review', 'git-example.google.com'),
507 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200508 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100509 ])
510 self.assertTrue(self.c.has_generic_host())
511 self.assertEqual(set(['conflict.googlesource.com']),
512 self.c.get_conflicting_hosts())
513 self.assertEqual(set(['dup.googlesource.com']),
514 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200515 self.assertEqual(set(['partial.googlesource.com',
516 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100517 self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100518
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100519 def test_report_no_problems(self):
520 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100521 self.assertFalse(self.c.find_and_report_problems())
522 self.assertEqual(sys.stdout.getvalue(), '')
523
Edward Lemurda4b6c62020-02-13 00:28:40 +0000524 @mock.patch(
525 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000526 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000527 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100528 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100529 self.assertTrue(self.c.find_and_report_problems())
530 with open(os.path.join(os.path.dirname(__file__),
531 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000532 expected = f.read() % {
533 'sep': os.sep,
534 }
535
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100536 def by_line(text):
537 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700538 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200539 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100540
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800541
Edward Lemurda4b6c62020-02-13 00:28:40 +0000542class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000543 def setUp(self):
544 super(TestGitCl, self).setUp()
545 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700546 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000547 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000548 mock.patch('sys.stdout', StringIO()).start()
549 mock.patch(
550 'git_cl.time_time',
551 lambda: self._mocked_call('time.time')).start()
552 mock.patch(
553 'git_cl.metrics.collector.add_repeated',
554 lambda *a: self._mocked_call('add_repeated', *a)).start()
555 mock.patch('subprocess2.call', self._mocked_call).start()
556 mock.patch('subprocess2.check_call', self._mocked_call).start()
557 mock.patch('subprocess2.check_output', self._mocked_call).start()
558 mock.patch(
559 'subprocess2.communicate',
560 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
561 mock.patch(
562 'git_cl.gclient_utils.CheckCallAndFilter',
563 self._mocked_call).start()
564 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
565 mock.patch(
566 'git_common.get_or_create_merge_base',
567 lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000568 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
569 mock.patch(
570 'git_cl.SaveDescriptionBackup',
571 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
572 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000573 'git_cl.write_json',
574 lambda *a: self._mocked_call('write_json', *a)).start()
575 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000576 'git_cl.Changelist.RunHook',
577 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000578 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
579 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000580 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000581 mock.patch(
582 'git_cl.gerrit_util.GetChangeComments',
583 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
584 mock.patch(
585 'git_cl.gerrit_util.GetChangeRobotComments',
586 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
587 mock.patch(
588 'git_cl.gerrit_util.AddReviewers',
589 lambda *a: self._mocked_call('AddReviewers', *a)).start()
590 mock.patch(
591 'git_cl.gerrit_util.SetReview',
592 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
593 self._mocked_call(
594 'SetReview', h, i, msg, labels, notify, ready))).start()
595 mock.patch(
596 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
597 return_value=False).start()
598 mock.patch(
599 'git_cl.gerrit_util.GceAuthenticator.is_gce',
600 return_value=False).start()
601 mock.patch(
602 'git_cl.gerrit_util.ValidAccounts',
603 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000604 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000605 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000606 self.mockGit = GitMocks()
607 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
608 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
Edward Lesmes50da7702020-03-30 19:23:43 +0000609 mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
610 mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
Edward Lemur85153282020-02-14 22:06:29 +0000611 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000612 mock.patch(
613 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000614 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000615 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000616 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000617 mock.patch(
618 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000619 # It's important to reset settings to not have inter-tests interference.
620 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000621 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000622
623 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000624 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000625 if not self.failed:
626 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100627 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000628 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
629 if len(self.calls) > 5:
630 calls += ' ...\n'
631 self.fail(
632 '\n'
633 'There are un-consumed calls after this test has finished:\n' +
634 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000635 finally:
636 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000637
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000638 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000639 self.assertTrue(
640 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700641 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000642 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000643 expected_args, result = top
644
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000645 # Also logs otherwise it could get caught in a try/finally and be hard to
646 # diagnose.
647 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700648 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000649 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700650 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
651 for i, c in enumerate(self._calls_done[-N:]))
652 following_calls = '\n '.join(
653 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
654 for i, c in enumerate(self.calls[:N]))
655 extended_msg = (
656 'A few prior calls:\n %s\n\n'
657 'This (expected):\n @%d: %r\n'
658 'This (actual):\n @%d: %r\n\n'
659 'A few following expected calls:\n %s' %
660 (prior_calls, len(self._calls_done), expected_args,
661 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700662
Edward Lesmes0dd54822020-03-26 18:24:25 +0000663 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700664 self.fail('@%d\n'
665 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000666 ' Actual: %r\n'
667 '\n'
668 '%s' % (
669 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700670
671 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700672 if isinstance(result, Exception):
673 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000674 # stdout from git commands is supposed to be a bytestream. Convert it here
675 # instead of converting all test output in this file to bytes.
676 if args[0][0] == 'git' and not isinstance(result, bytes):
677 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000678 return result
679
Edward Lemur1a83da12020-03-04 21:18:36 +0000680 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
681 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100682 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100683 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000684 self.assertEqual(
685 'prompt [Yes/No]: Please, type yes or no: ',
686 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100687
tandrii48df5812016-10-17 03:55:37 -0700688 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000689 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700690 self.calls = [
691 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700692 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
693 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
694 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
695 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700696 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
697 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700698 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
699 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000700 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
701 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700702 ((['git', 'config', 'gerrit.host', 'true'],), ''),
703 ]
704 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
705
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000706 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100707 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200708 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000709 custom_cl_base=None, short_hostname='chromium',
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000710 change_id=None, new_default=False):
Edward Lemur26964072020-02-19 19:18:51 +0000711 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200712 if custom_cl_base:
713 ancestor_revision = custom_cl_base
714 else:
715 # Determine ancestor_revision to be merge base.
716 ancestor_revision = 'fake_ancestor_sha'
717 calls += [
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000718 (('get_or_create_merge_base', 'master',
719 'refs/remotes/origin/master'), ancestor_revision),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200720 ]
721
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100722 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000723 gerrit_util.GetChangeDetail.return_value = {
724 'owner': {'email': (other_cl_owner or 'owner@example.com')},
725 'change_id': (change_id or '123456789'),
726 'current_revision': 'sha1_of_current_revision',
727 'revisions': {'sha1_of_current_revision': {
728 'commit': {'message': fetched_description},
729 }},
730 'status': fetched_status or 'NEW',
731 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100732 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100733 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100734 if other_cl_owner:
735 calls += [
736 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
737 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100738
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100739 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200740 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
741 ([custom_cl_base] if custom_cl_base else
742 [ancestor_revision, 'HEAD']),),
743 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100744 ]
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000745 calls += [
746 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
747 '1' if new_default else callError(1)),
748 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000749
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100750 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000751
Edward Lemur26964072020-02-19 19:18:51 +0000752 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700753 squash_mode='default',
Aaron Gablefd238082017-06-07 13:42:34 -0700754 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100755 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000756 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000757 short_hostname='chromium',
Edward Lemur5a644f82020-03-18 16:44:57 +0000758 labels=None, change_id=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000759 final_description=None, gitcookies_exists=True,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000760 force=False, edit_description=None,
761 new_default=False):
762 default_branch = 'main' if new_default else 'master';
tandrii@chromium.org10625002016-03-04 20:03:47 +0000763 if post_amend_description is None:
764 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700765 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200766
767 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000768
Edward Lesmes4de54132020-05-05 19:41:33 +0000769 if squash_mode in ('override_squash', 'override_nosquash'):
770 self.mockGit.config['gerrit.override-squash-uploads'] = (
771 'true' if squash_mode == 'override_squash' else 'false')
772
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000773 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000774 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200775 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200776 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000777 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000778 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000779 calls += [
780 ((['RunEditor'],), description),
781 ]
Josipe827b0f2020-01-30 00:07:20 +0000782 # user wants to edit description
783 if edit_description:
784 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000785 ((['RunEditor'],), edit_description),
786 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000787 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200788
789 if custom_cl_base is None:
790 calls += [
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000791 (('get_or_create_merge_base', 'master',
792 'refs/remotes/origin/master'), 'origin/' + default_branch),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200793 ]
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000794 parent = 'origin/' + default_branch
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200795 else:
796 calls += [
797 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000798 'refs/remotes/origin/' + default_branch],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200799 callError(1)), # Means not ancenstor.
800 (('ask_for_data',
801 'Do you take responsibility for cleaning up potential mess '
802 'resulting from proceeding with upload? Press Enter to upload, '
803 'or Ctrl+C to abort'), ''),
804 ]
805 parent = custom_cl_base
806
807 calls += [
808 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
809 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000810 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200811 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000812 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200813 ref_to_push),
814 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000815 else:
816 ref_to_push = 'HEAD'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000817 parent = 'origin/refs/heads/' + default_branch
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000818
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000819 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000820 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000821 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200822 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000823
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000824 metrics_arguments = []
825
Aaron Gableafd52772017-06-27 16:40:10 -0700826 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700827 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000828 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700829 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400830 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700831 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000832 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700833 else:
834 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000835 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800836
Edward Lemur5a644f82020-03-18 16:44:57 +0000837 # If issue is given, then description is fetched from Gerrit instead.
838 if issue is None:
839 if squash:
840 title = 'Initial upload'
841 else:
842 if not title:
843 calls += [
844 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
845 (('ask_for_data', 'Title for patchset []: '), 'User input'),
846 ]
847 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700848 if title:
Edward Lemur5a644f82020-03-18 16:44:57 +0000849 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000850 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000851
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000852 if short_hostname == 'chromium':
Quinten Yearsley925cedb2020-04-13 17:49:39 +0000853 # All reviewers and ccs get into ref_suffix.
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000854 for r in sorted(reviewers):
855 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000856 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000857 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000858 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000859 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000860 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000861 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000862 reviewers, cc = [], []
863 else:
864 # TODO(crbug/877717): remove this case.
865 calls += [
866 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
867 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000868 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000869 {
870 e: {'email': e}
871 for e in (reviewers + ['joe@example.com'] + cc)
872 })
873 ]
874 for r in sorted(reviewers):
875 if r != 'bad-account-or-email':
876 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000877 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000878 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000879 if issue is None:
880 cc += ['joe@example.com']
881 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000882 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000883 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000884 if c in cc:
885 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000886
Edward Lemur687ca902018-12-05 02:30:30 +0000887 for k, v in sorted((labels or {}).items()):
888 ref_suffix += ',l=%s+%d' % (k, v)
889 metrics_arguments.append('l=%s+%d' % (k, v))
890
891 if tbr:
892 calls += [
893 (('GetCodeReviewTbrScore',
894 '%s-review.googlesource.com' % short_hostname,
895 'my/repo'),
896 2,),
897 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000898
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000899 calls += [
900 (('time.time',), 1000,),
901 ((['git', 'push',
902 'https://%s.googlesource.com/my/repo' % short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000903 ref_to_push + ':refs/for/refs/heads/' + default_branch + ref_suffix],),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000904 (('remote:\n'
905 'remote: Processing changes: (\)\n'
906 'remote: Processing changes: (|)\n'
907 'remote: Processing changes: (/)\n'
908 'remote: Processing changes: (-)\n'
909 'remote: Processing changes: new: 1 (/)\n'
910 'remote: Processing changes: new: 1, done\n'
911 'remote:\n'
912 'remote: New Changes:\n'
913 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
914 ' XXX\n'
915 'remote:\n'
916 'To https://%s.googlesource.com/my/repo\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000917 ' * [new branch] hhhh -> refs/for/refs/heads/%s\n'
918 ) % (short_hostname, short_hostname, default_branch)),),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000919 (('time.time',), 2000,),
920 (('add_repeated',
921 'sub_commands',
922 {
923 'execution_time': 1000,
924 'command': 'git push',
925 'exit_code': 0,
926 'arguments': sorted(metrics_arguments),
927 }),
928 None,),
929 ]
930
Edward Lemur1b52d872019-05-09 21:12:12 +0000931 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000932
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000933 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
934
Edward Lemur1b52d872019-05-09 21:12:12 +0000935 # Trace-related calls
936 calls += [
937 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000938 (
939 ([
940 'FileWrite', trace_name + '-README',
941 '%(date)s\n'
942 '%(short_hostname)s-review.googlesource.com\n'
943 '%(change_id)s\n'
944 '%(title)s\n'
945 '%(description)s\n'
946 '1000\n'
947 '0\n'
948 '%(trace_name)s' % {
Josip Sokcevic5e18b602020-04-23 21:47:00 +0000949 'date': '2017-03-16T20:00:41.000000',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000950 'short_hostname': short_hostname,
951 'change_id': change_id,
952 'description': final_description,
953 'title': title or '<untitled>',
954 'trace_name': trace_name,
955 }
956 ], ),
957 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000958 ),
959 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000960 (
961 (['os.path.isfile',
962 os.path.join('TEMP_DIR', 'trace-packet')], ),
963 True,
Edward Lemur1b52d872019-05-09 21:12:12 +0000964 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000965 (
966 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
967 ('git-hash: 0123456789012345678901234567890123456789\n'
968 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +0000969 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000970 (
971 ([
972 'FileWrite',
973 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
974 'git-hash: abcdea\n'
975 ], ),
976 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000977 ),
978 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000979 (
980 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
981 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000982 ),
983 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000984 (
985 (['git', 'config', '-l'], ),
986 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +0000987 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000988 (
989 ([
990 'FileWrite',
991 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
992 ], ),
993 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000994 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000995 (
996 (['os.path.isfile',
997 os.path.join('~', '.gitcookies')], ),
998 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +0000999 ),
1000 ]
1001 if gitcookies_exists:
1002 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001003 (
1004 (['FileRead', os.path.join('~', '.gitcookies')], ),
1005 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +00001006 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001007 (
1008 ([
1009 'FileWrite',
1010 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
1011 ], ),
1012 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001013 ),
1014 ]
1015 calls += [
1016 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001017 (
1018 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
1019 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001020 ),
1021 ]
1022
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001023 # TODO(crbug/877717): this should never be used.
1024 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001025 calls += [
1026 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001027 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001028 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001029 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001030 notify),
1031 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001032 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001033 return calls
1034
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001035 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001036 self,
1037 upload_args,
1038 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001039 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001040 squash=True,
1041 squash_mode=None,
Aaron Gable9b713dd2016-12-14 16:04:21 -08001042 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001043 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001044 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001045 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001046 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001047 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001048 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001049 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001050 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001051 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001052 labels=None,
1053 change_id=None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001054 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001055 gitcookies_exists=True,
1056 force=False,
Edward Lesmes0dd54822020-03-26 18:24:25 +00001057 log_description=None,
Josipe827b0f2020-01-30 00:07:20 +00001058 edit_description=None,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001059 fetched_description=None,
1060 new_default=False):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001061 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001062 if squash_mode is None:
1063 if '--no-squash' in upload_args:
1064 squash_mode = 'nosquash'
1065 elif '--squash' in upload_args:
1066 squash_mode = 'squash'
1067 else:
1068 squash_mode = 'default'
1069
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001070 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001071 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001072 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001073 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001074 same_auth=('git-owner.example.com', '', 'pass'))).start()
1075 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1076 lambda _, offer_removal: None).start()
1077 mock.patch('git_cl.gclient_utils.RunEditor',
1078 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1079 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001080 'DownloadGerritHook', force)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001081 mock.patch('git_cl.gclient_utils.FileRead',
1082 lambda path: self._mocked_call(['FileRead', path])).start()
1083 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001084 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001085 ['FileWrite', path, contents])).start()
1086 mock.patch('git_cl.datetime_now',
1087 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1088 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1089 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1090 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001091 '%(now)s\n'
1092 '%(gerrit_host)s\n'
1093 '%(change_id)s\n'
1094 '%(title)s\n'
1095 '%(description)s\n'
1096 '%(execution_time)s\n'
1097 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001098 '%(trace_name)s').start()
1099 mock.patch('git_cl.shutil.make_archive',
1100 lambda *args: self._mocked_call(['make_archive'] +
1101 list(args))).start()
1102 mock.patch('os.path.isfile',
1103 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001104 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001105 'git_cl._create_description_from_log',
1106 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001107 mock.patch(
1108 'git_cl.Changelist._AddChangeIdToCommitMessage',
1109 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001110 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001111 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1112 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001113 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001114 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001115
Edward Lemur26964072020-02-19 19:18:51 +00001116 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001117 self.mockGit.config['branch.master.gerritissue'] = (
1118 str(issue) if issue else None)
1119 self.mockGit.config['remote.origin.url'] = (
1120 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001121 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001122
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001123 self.calls = self._gerrit_base_calls(
1124 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001125 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001126 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001127 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001128 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001129 short_hostname=short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001130 change_id=change_id,
1131 new_default=new_default)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001132 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001133 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001134 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001135 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001136 self.calls += self._gerrit_upload_calls(
1137 description, reviewers, squash,
1138 squash_mode=squash_mode,
Aaron Gablefd238082017-06-07 13:42:34 -07001139 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001140 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001141 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001142 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001143 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001144 labels=labels,
1145 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001146 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001147 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001148 force=force,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001149 edit_description=edit_description,
1150 new_default=new_default)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001151 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001152 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001153 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001154 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001155 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001156 self.assertEqual(
1157 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001158 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001159
Edward Lemur1b52d872019-05-09 21:12:12 +00001160 def test_gerrit_upload_traces_no_gitcookies(self):
1161 self._run_gerrit_upload_test(
1162 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001163 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001164 [],
1165 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001166 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001167 change_id='Ixxx',
1168 gitcookies_exists=False)
1169
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001170 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001171 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001172 [],
1173 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1174 [],
1175 change_id='Ixxx')
1176
1177 def test_gerrit_upload_without_change_id_nosquash(self):
1178 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001179 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001180 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001181 [],
1182 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001183 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001184 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001185
Edward Lesmes4de54132020-05-05 19:41:33 +00001186 def test_gerrit_upload_without_change_id_override_nosquash(self):
1187 self._run_gerrit_upload_test(
1188 [],
1189 'desc ✔\n\nBUG=\n',
1190 [],
1191 squash=False,
1192 squash_mode='override_nosquash',
1193 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1194 change_id='Ixxx')
1195
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001196 def test_gerrit_no_reviewer(self):
1197 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001198 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001199 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001200 [],
1201 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001202 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001203 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001204
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001205 def test_gerrit_no_reviewer_non_chromium_host(self):
1206 # TODO(crbug/877717): remove this test case.
1207 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001208 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001209 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001210 [],
1211 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001212 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001213 short_hostname='other',
1214 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001215
Edward Lesmes0dd54822020-03-26 18:24:25 +00001216 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001217 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001218 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001219 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001220 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001221 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001222 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001223 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001224
ukai@chromium.orge8077812012-02-03 03:41:46 +00001225 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001226 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001227 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001228 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001229 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001230 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001231 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001232 notify=True,
1233 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001234 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001235 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001236
Anthony Polito8b955342019-09-24 19:01:36 +00001237 def test_gerrit_upload_force_sets_bug(self):
1238 self._run_gerrit_upload_test(
1239 ['-b', '10000', '-f'],
1240 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1241 [],
1242 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001243 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001244 change_id='Ixxx')
1245
Edward Lemur5fb22242020-03-12 22:05:13 +00001246 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001247 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001248 ['-b', '10000', '-m', 'Title', '--edit-description'],
1249 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001250 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001251 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001252 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001253 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001254 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001255 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001256
Dan Beamd8b04ca2019-10-10 21:23:26 +00001257 def test_gerrit_upload_force_sets_fixed(self):
1258 self._run_gerrit_upload_test(
1259 ['-x', '10000', '-f'],
1260 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1261 [],
1262 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001263 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001264 change_id='Ixxx')
1265
ukai@chromium.orge8077812012-02-03 03:41:46 +00001266 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001267 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1268 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001269 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001270 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001271 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001272 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001273 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001274 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001275 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001276 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001277 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001278 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001279
1280 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001281 self._run_gerrit_upload_test(
1282 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001283 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001284 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001285 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001286
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001287 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001288 self._run_gerrit_upload_test(
1289 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001290 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001291 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001292 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001293 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001294
Edward Lesmes0dd54822020-03-26 18:24:25 +00001295 def test_gerrit_upload_squash_first_title(self):
1296 self._run_gerrit_upload_test(
1297 ['-f', '-t', 'title'],
1298 'title\n\ndesc\n\nChange-Id: 123456789',
1299 [],
1300 force=True,
1301 squash=True,
1302 log_description='desc',
1303 change_id='123456789')
1304
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001305 def test_gerrit_upload_squash_first_with_labels(self):
1306 self._run_gerrit_upload_test(
1307 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001308 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001309 [],
1310 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001311 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001312 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001313
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001314 def test_gerrit_upload_squash_first_against_rev(self):
1315 custom_cl_base = 'custom_cl_base_rev_or_branch'
1316 self._run_gerrit_upload_test(
1317 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001318 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001319 [],
1320 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001321 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001322 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001323 self.assertIn(
1324 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1325 sys.stdout.getvalue())
1326
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001327 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001328 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001329 self._run_gerrit_upload_test(
1330 ['--squash'],
1331 description,
1332 [],
1333 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001334 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001335 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001336
Edward Lemurd55c5072020-02-20 01:09:07 +00001337 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001338 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001339 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001340 with self.assertRaises(SystemExitMock):
1341 self._run_gerrit_upload_test(
1342 ['--squash'],
1343 description,
1344 [],
1345 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001346 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001347 fetched_status='ABANDONED',
1348 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001349 self.assertEqual(
1350 'Change https://chromium-review.googlesource.com/123456 has been '
1351 'abandoned, new uploads are not allowed\n',
1352 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001353
Edward Lemurda4b6c62020-02-13 00:28:40 +00001354 @mock.patch(
1355 'gerrit_util.GetAccountDetails',
1356 return_value={'email': 'yet-another@example.com'})
1357 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001358 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001359 self._run_gerrit_upload_test(
1360 ['--squash'],
1361 description,
1362 [],
1363 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001364 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001365 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001366 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001367 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001368 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001369 'authenticate to Gerrit as yet-another@example.com.\n'
1370 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001371 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001372
Josipe827b0f2020-01-30 00:07:20 +00001373 def test_upload_change_description_editor(self):
1374 fetched_description = 'foo\n\nChange-Id: 123456789'
1375 description = 'bar\n\nChange-Id: 123456789'
1376 self._run_gerrit_upload_test(
1377 ['--squash', '--edit-description'],
1378 description,
1379 [],
1380 fetched_description=fetched_description,
1381 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001382 issue=123456,
1383 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001384 edit_description=description)
1385
Edward Lemurda4b6c62020-02-13 00:28:40 +00001386 @mock.patch('git_cl.RunGit')
1387 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001388 @mock.patch('sys.stdin', StringIO('\n'))
1389 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001390 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001391 def mock_run_git(*args, **_kwargs):
1392 if args[0] == ['for-each-ref',
1393 '--format=%(refname:short) %(upstream:short)',
1394 'refs/heads']:
1395 # Create a local branch dependency tree that looks like this:
1396 # test1 -> test2 -> test3 -> test4 -> test5
1397 # -> test3.1
1398 # test6 -> test0
1399 branch_deps = [
1400 'test2 test1', # test1 -> test2
1401 'test3 test2', # test2 -> test3
1402 'test3.1 test2', # test2 -> test3.1
1403 'test4 test3', # test3 -> test4
1404 'test5 test4', # test4 -> test5
1405 'test6 test0', # test0 -> test6
1406 'test7', # test7
1407 ]
1408 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001409 git_cl.RunGit.side_effect = mock_run_git
1410 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001411
1412 class MockChangelist():
1413 def __init__(self):
1414 pass
1415 def GetBranch(self):
1416 return 'test1'
1417 def GetIssue(self):
1418 return '123'
1419 def GetPatchset(self):
1420 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001421 def IsGerrit(self):
1422 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001423
1424 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1425 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001426 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001427 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001428 'This command will checkout all dependent branches '
1429 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001430 'or Ctrl+C to abort',
1431 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001432 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001433
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001434 def test_gerrit_change_id(self):
1435 self.calls = [
1436 ((['git', 'write-tree'], ),
1437 'hashtree'),
1438 ((['git', 'rev-parse', 'HEAD~0'], ),
1439 'branch-parent'),
1440 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1441 'A B <a@b.org> 1456848326 +0100'),
1442 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1443 'C D <c@d.org> 1456858326 +0100'),
1444 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1445 'hashchange'),
1446 ]
1447 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1448 self.assertEqual(change_id, 'Ihashchange')
1449
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001450 def test_desecription_append_footer(self):
1451 for init_desc, footer_line, expected_desc in [
1452 # Use unique desc first lines for easy test failure identification.
1453 ('foo', 'R=one', 'foo\n\nR=one'),
1454 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1455 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1456 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1457 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1458 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1459 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1460 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1461 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1462 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1463 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1464 ]:
1465 desc = git_cl.ChangeDescription(init_desc)
1466 desc.append_footer(footer_line)
1467 self.assertEqual(desc.description, expected_desc)
1468
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001469 def test_update_reviewers(self):
1470 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001471 ('foo', [], [],
1472 'foo'),
1473 ('foo\nR=xx', [], [],
1474 'foo\nR=xx'),
1475 ('foo\nTBR=xx', [], [],
1476 'foo\nTBR=xx'),
1477 ('foo', ['a@c'], [],
1478 'foo\n\nR=a@c'),
1479 ('foo\nR=xx', ['a@c'], [],
1480 'foo\n\nR=a@c, xx'),
1481 ('foo\nTBR=xx', ['a@c'], [],
1482 'foo\n\nR=a@c\nTBR=xx'),
1483 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1484 'foo\n\nR=a@c, yy\nTBR=xx'),
1485 ('foo\nBUG=', ['a@c'], [],
1486 'foo\nBUG=\nR=a@c'),
1487 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1488 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1489 ('foo', ['a@c', 'b@c'], [],
1490 'foo\n\nR=a@c, b@c'),
1491 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1492 'foo\nBar\n\nR=c@c\nBUG='),
1493 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1494 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001495 # Same as the line before, but full of whitespaces.
1496 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001497 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001498 'foo\nBar\n\nR=c@c\n BUG =',
1499 ),
1500 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001501 ('foo BUG=allo R=joe ', ['c@c'], [],
1502 'foo BUG=allo R=joe\n\nR=c@c'),
1503 # Redundant TBRs get promoted to Rs
1504 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1505 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001506 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001507 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001508 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001509 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001510 obj = git_cl.ChangeDescription(orig)
Edward Lemur2c62b332020-03-12 22:12:33 +00001511 obj.update_reviewers(reviewers, tbrs, None, None, None)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001512 actual.append(obj.description)
1513 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001514
Nodir Turakulov23b82142017-11-16 11:04:25 -08001515 def test_get_hash_tags(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001516 self.calls = [
1517 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
1518 callError(1)),
1519 ] * 9
Nodir Turakulov23b82142017-11-16 11:04:25 -08001520 cases = [
1521 ('', []),
1522 ('a', []),
1523 ('[a]', ['a']),
1524 ('[aa]', ['aa']),
1525 ('[a ]', ['a']),
1526 ('[a- ]', ['a']),
1527 ('[a- b]', ['a-b']),
1528 ('[a--b]', ['a-b']),
1529 ('[a', []),
1530 ('[a]x', ['a']),
1531 ('[aa]x', ['aa']),
1532 ('[a b]', ['a-b']),
1533 ('[a b]', ['a-b']),
1534 ('[a__b]', ['a-b']),
1535 ('[a] x', ['a']),
1536 ('[a][b]', ['a', 'b']),
1537 ('[a] [b]', ['a', 'b']),
1538 ('[a][b]x', ['a', 'b']),
1539 ('[a][b] x', ['a', 'b']),
1540 ('[a]\n[b]', ['a']),
1541 ('[a\nb]', []),
1542 ('[a][', ['a']),
1543 ('Revert "[a] feature"', ['a']),
1544 ('Reland "[a] feature"', ['a']),
1545 ('Revert: [a] feature', ['a']),
1546 ('Reland: [a] feature', ['a']),
1547 ('Revert "Reland: [a] feature"', ['a']),
1548 ('Foo: feature', ['foo']),
1549 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001550 ('Change Foo::Bar', []),
1551 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001552 ('Revert "Foo bar: feature"', ['foo-bar']),
1553 ('Reland "Foo bar: feature"', ['foo-bar']),
1554 ]
1555 for desc, expected in cases:
1556 change_desc = git_cl.ChangeDescription(desc)
1557 actual = change_desc.get_hash_tags()
1558 self.assertEqual(
1559 actual,
1560 expected,
1561 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1562
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001563 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001564 self.assertEqual(None, git_cl.GetTargetRef(None,
1565 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001566 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001567
wittman@chromium.org455dc922015-01-26 20:15:50 +00001568 # Check default target refs for branches.
1569 self.assertEqual('refs/heads/master',
1570 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001571 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001572 self.assertEqual('refs/heads/master',
1573 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001574 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001575 self.assertEqual('refs/heads/master',
1576 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001577 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001578 self.assertEqual('refs/branch-heads/123',
1579 git_cl.GetTargetRef('origin',
1580 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001581 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001582 self.assertEqual('refs/diff/test',
1583 git_cl.GetTargetRef('origin',
1584 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001585 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001586 self.assertEqual('refs/heads/chrome/m42',
1587 git_cl.GetTargetRef('origin',
1588 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001589 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001590
1591 # Check target refs for user-specified target branch.
1592 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1593 'refs/remotes/branch-heads/123'):
1594 self.assertEqual('refs/branch-heads/123',
1595 git_cl.GetTargetRef('origin',
1596 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001597 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001598 for branch in ('origin/master', 'remotes/origin/master',
1599 'refs/remotes/origin/master'):
1600 self.assertEqual('refs/heads/master',
1601 git_cl.GetTargetRef('origin',
1602 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001603 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001604 for branch in ('master', 'heads/master', 'refs/heads/master'):
1605 self.assertEqual('refs/heads/master',
1606 git_cl.GetTargetRef('origin',
1607 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001608 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001609
Edward Lemurda4b6c62020-02-13 00:28:40 +00001610 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1611 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001612 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001613 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1614
Edward Lemur85153282020-02-14 22:06:29 +00001615 def assertIssueAndPatchset(
1616 self, branch='master', issue='123456', patchset='7',
1617 git_short_host='chromium'):
1618 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001619 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001620 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001621 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001622 self.assertEqual(
1623 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001624 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001625
Edward Lemur85153282020-02-14 22:06:29 +00001626 def _patch_common(self, git_short_host='chromium'):
Edward Lesmes50da7702020-03-30 19:23:43 +00001627 mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
Edward Lemur26964072020-02-19 19:18:51 +00001628 self.mockGit.config['remote.origin.url'] = (
1629 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001630 gerrit_util.GetChangeDetail.return_value = {
1631 'current_revision': '7777777777',
1632 'revisions': {
1633 '1111111111': {
1634 '_number': 1,
1635 'fetch': {'http': {
1636 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1637 'ref': 'refs/changes/56/123456/1',
1638 }},
1639 },
1640 '7777777777': {
1641 '_number': 7,
1642 'fetch': {'http': {
1643 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1644 'ref': 'refs/changes/56/123456/7',
1645 }},
1646 },
1647 },
1648 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001649
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001650 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001651 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001652 self.calls += [
1653 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1654 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001655 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001656 ]
1657 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001658 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001659
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001660 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001661 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001662 self.calls += [
1663 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1664 'refs/changes/56/123456/7'],), ''),
1665 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001666 ]
Edward Lemur85153282020-02-14 22:06:29 +00001667 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1668 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001669
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001670 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001671 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001672 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001673 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001674 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001675 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001676 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001677 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001678 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001679
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001680 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001681 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001682 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001683 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001684 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001685 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001686 ]
1687 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001688 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001689 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001690
Aaron Gable697a91b2018-01-19 15:20:15 -08001691 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001692 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001693 self.calls += [
1694 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1695 'refs/changes/56/123456/1'],), ''),
1696 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001697 ]
1698 self.assertEqual(git_cl.main(
1699 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1700 0)
Edward Lemur85153282020-02-14 22:06:29 +00001701 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001702
Edward Lemurd55c5072020-02-20 01:09:07 +00001703 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001704 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001705 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001706 self.calls += [
1707 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001708 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001709 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001710 ]
1711 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001712 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001713 self.assertEqual(
1714 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1715 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001716
Edward Lemurda4b6c62020-02-13 00:28:40 +00001717 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001718 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001719 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001720 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001721 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001722 self.mockGit.config['remote.origin.url'] = (
1723 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001724 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001725 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001726 self.assertEqual(
1727 'change 123456 at https://chromium-review.googlesource.com does not '
1728 'exist or you have no access to it\n',
1729 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001730
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001731 def _checkout_calls(self):
1732 return [
1733 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001734 'branch\\..*\\.gerritissue'], ),
1735 ('branch.ger-branch.gerritissue 123456\n'
1736 'branch.gbranch654.gerritissue 654321\n')),
1737 ]
1738
1739 def test_checkout_gerrit(self):
1740 """Tests git cl checkout <issue>."""
1741 self.calls = self._checkout_calls()
1742 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1743 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1744
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001745 def test_checkout_not_found(self):
1746 """Tests git cl checkout <issue>."""
1747 self.calls = self._checkout_calls()
1748 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1749
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001750 def test_checkout_no_branch_issues(self):
1751 """Tests git cl checkout <issue>."""
1752 self.calls = [
1753 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001754 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001755 ]
1756 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1757
Edward Lemur26964072020-02-19 19:18:51 +00001758 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00001759 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001760 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001761 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001762 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1763 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001764 self.mockGit.config['remote.origin.url'] = (
1765 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001766 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001767 cl.branch = 'master'
1768 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001769 return cl
1770
Edward Lemurd55c5072020-02-20 01:09:07 +00001771 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001772 def test_gerrit_ensure_authenticated_missing(self):
1773 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001774 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001775 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001776 with self.assertRaises(SystemExitMock):
1777 cl.EnsureAuthenticated(force=False)
1778 self.assertEqual(
1779 'Credentials for the following hosts are required:\n'
1780 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001781 'These are read from ~%(sep)s.gitcookies '
1782 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00001783 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001784 'https://chromium-review.googlesource.com/new-password\n' % {
1785 'sep': os.sep,
1786 'netrc': NETRC_FILENAME,
1787 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001788
1789 def test_gerrit_ensure_authenticated_conflict(self):
1790 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001791 'chromium.googlesource.com':
1792 ('git-one.example.com', None, 'secret1'),
1793 'chromium-review.googlesource.com':
1794 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001795 })
1796 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001797 (('ask_for_data', 'If you know what you are doing '
1798 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001799 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1800
1801 def test_gerrit_ensure_authenticated_ok(self):
1802 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001803 'chromium.googlesource.com':
1804 ('git-same.example.com', None, 'secret'),
1805 'chromium-review.googlesource.com':
1806 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001807 })
1808 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1809
tandrii@chromium.org28253532016-04-14 13:46:56 +00001810 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00001811 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
1812 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00001813 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1814
Eric Boren2fb63102018-10-05 13:05:03 +00001815 def test_gerrit_ensure_authenticated_bearer_token(self):
1816 cl = self._test_gerrit_ensure_authenticated_common(auth={
1817 'chromium.googlesource.com':
1818 ('', None, 'secret'),
1819 'chromium-review.googlesource.com':
1820 ('', None, 'secret'),
1821 })
1822 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1823 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1824 'chromium.googlesource.com')
1825 self.assertTrue('Bearer' in header)
1826
Daniel Chengcf6269b2019-05-18 01:02:12 +00001827 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00001828 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00001829 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001830 (('logging.warning',
1831 'Ignoring branch %(branch)s with non-https remote '
1832 '%(remote)s', {
1833 'branch': 'master',
1834 'remote': 'custom-scheme://repo'}
1835 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001836 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001837 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1838 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1839 mock.patch('logging.warning',
1840 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00001841 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00001842 cl.branch = 'master'
1843 cl.branchref = 'refs/heads/master'
1844 cl.lookedup_issue = True
1845 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1846
Florian Mayerae510e82020-01-30 21:04:48 +00001847 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00001848 self.mockGit.config['remote.origin.url'] = (
1849 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00001850 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001851 (('logging.error',
1852 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1853 'but it doesn\'t exist.', {
1854 'remote': 'origin',
1855 'branch': 'master',
1856 'url': 'git@somehost.example:foo/bar.git'}
1857 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00001858 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001859 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1860 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1861 mock.patch('logging.error',
1862 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00001863 cl = git_cl.Changelist()
1864 cl.branch = 'master'
1865 cl.branchref = 'refs/heads/master'
1866 cl.lookedup_issue = True
1867 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1868
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001869 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00001870 self.mockGit.config['branch.master.gerritissue'] = '123'
1871 self.mockGit.config['branch.master.gerritserver'] = (
1872 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00001873 self.mockGit.config['remote.origin.url'] = (
1874 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001875 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00001876 (('SetReview', 'chromium-review.googlesource.com',
1877 'infra%2Finfra~123', None,
1878 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001879 ]
tandriid9e5ce52016-07-13 02:32:59 -07001880
1881 def test_cmd_set_commit_gerrit_clear(self):
1882 self._cmd_set_commit_gerrit_common(0)
1883 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1884
1885 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001886 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001887 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1888
tandriid9e5ce52016-07-13 02:32:59 -07001889 def test_cmd_set_commit_gerrit(self):
1890 self._cmd_set_commit_gerrit_common(2)
1891 self.assertEqual(0, git_cl.main(['set-commit']))
1892
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001893 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001894 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001895 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001896
1897 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001898 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001899
Edward Lemurda4b6c62020-02-13 00:28:40 +00001900 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07001901 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07001902 try:
1903 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00001904 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001905 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001906 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07001907
1908 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07001909 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001910 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07001911 return 'foobar'
1912
Edward Lemurda4b6c62020-02-13 00:28:40 +00001913 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07001914 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001915 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001916 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001917 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07001918
iannuccie53c9352016-08-17 14:40:40 -07001919 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001920
iannuccie53c9352016-08-17 14:40:40 -07001921 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001922 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07001923 return 'foobar'
1924
Edward Lemurda4b6c62020-02-13 00:28:40 +00001925 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
1926 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07001927 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001928 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001929
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001930 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00001931 self.mockGit.config['remote.origin.url'] = (
1932 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001933 gerrit_util.GetChangeDetail.return_value = {
1934 'current_revision': 'sha1',
1935 'revisions': {'sha1': {
1936 'commit': {'message': 'foobar'},
1937 }},
1938 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001939 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001940 'description',
1941 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
1942 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001943 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001944
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001945 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001946 mock.patch('git_cl.Changelist', ChangelistMock).start()
1947 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001948
1949 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
1950 self.assertEqual('hihi', ChangelistMock.desc)
1951
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001952 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001953 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001954
1955 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001956 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001957 '# Enter a description of the change.\n'
1958 '# This will be displayed on the codereview site.\n'
1959 '# The first line will also be used as the subject of the review.\n'
1960 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001961 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07001962 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001963 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001964 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07001965 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001966
Edward Lemur6c6827c2020-02-06 21:15:18 +00001967 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001968 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001969
Edward Lemurda4b6c62020-02-13 00:28:40 +00001970 mock.patch('git_cl.Changelist.FetchDescription',
1971 lambda *args: current_desc).start()
1972 mock.patch('git_cl.Changelist.UpdateDescription',
1973 UpdateDescription).start()
1974 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001975
Edward Lemur85153282020-02-14 22:06:29 +00001976 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00001977 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001978
Dan Beamd8b04ca2019-10-10 21:23:26 +00001979 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
1980 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
1981
1982 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001983 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00001984 '# Enter a description of the change.\n'
1985 '# This will be displayed on the codereview site.\n'
1986 '# The first line will also be used as the subject of the review.\n'
1987 '#--------------------This line is 72 characters long'
1988 '--------------------\n'
1989 'Some.\n\nFixed: 123\nChange-Id: xxx',
1990 desc)
1991 return desc
1992
Edward Lemurda4b6c62020-02-13 00:28:40 +00001993 mock.patch('git_cl.Changelist.FetchDescription',
1994 lambda *args: current_desc).start()
1995 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00001996
Edward Lemur85153282020-02-14 22:06:29 +00001997 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00001998 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00001999
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002000 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002001 mock.patch('git_cl.Changelist', ChangelistMock).start()
2002 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002003
2004 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2005 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2006
kmarshall3bff56b2016-06-06 18:31:47 -07002007 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002008 self.calls = [
2009 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002010 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002011 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002012 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002013 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002014 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002015
Edward Lemurda4b6c62020-02-13 00:28:40 +00002016 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002017 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002018 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2019 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002020 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002021
2022 self.assertEqual(0, git_cl.main(['archive', '-f']))
2023
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002024 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002025 self.calls = [
2026 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2027 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2028 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2029 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002030 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2031 ((['git', 'branch', '-D', 'foo'],), '')
2032 ]
2033
Edward Lemurda4b6c62020-02-13 00:28:40 +00002034 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002035 lambda branches, fine_grained, max_processes:
2036 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2037 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002038 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002039
2040 self.assertEqual(0, git_cl.main(['archive', '-f']))
2041
kmarshall3bff56b2016-06-06 18:31:47 -07002042 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002043 self.calls = [
2044 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2045 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002046 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002047 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002048
Edward Lemurda4b6c62020-02-13 00:28:40 +00002049 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002050 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002051 [(MockChangelistWithBranchAndIssue('master', 1),
2052 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002053
2054 self.assertEqual(1, git_cl.main(['archive', '-f']))
2055
2056 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002057 self.calls = [
2058 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2059 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002060 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002061 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002062
Edward Lemurda4b6c62020-02-13 00:28:40 +00002063 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002064 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002065 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2066 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002067 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002068
kmarshall9249e012016-08-23 12:02:16 -07002069 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2070
2071 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002072 self.calls = [
2073 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2074 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002075 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002076 ((['git', 'branch', '-D', 'foo'],), '')
2077 ]
kmarshall9249e012016-08-23 12:02:16 -07002078
Edward Lemurda4b6c62020-02-13 00:28:40 +00002079 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002080 lambda branches, fine_grained, max_processes:
2081 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2082 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002083 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002084
2085 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002086
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002087 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002088 self.calls = [
2089 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2090 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2091 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002092 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2093 'refs/tags/git-cl-archived-456-foo'),
2094 ((['git', 'branch', '-D', 'foo'],), CERR1),
2095 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2096 'refs/tags/git-cl-archived-456-foo'),
2097 ]
2098
Edward Lemurda4b6c62020-02-13 00:28:40 +00002099 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002100 lambda branches, fine_grained, max_processes:
2101 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2102 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002103 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002104
2105 self.assertEqual(0, git_cl.main(['archive', '-f']))
2106
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002107 def test_archive_with_format(self):
2108 self.calls = [
2109 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
2110 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2111 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2112 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2113 ((['git', 'branch', '-D', 'foo'], ), ''),
2114 ]
2115
2116 mock.patch('git_cl.get_cl_statuses',
2117 lambda branches, fine_grained, max_processes:
2118 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2119
2120 self.assertEqual(
2121 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2122
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002123 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002124 self.mockGit.config['branch.master.gerritissue'] = '123'
2125 self.mockGit.config['branch.master.gerritserver'] = (
2126 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002127 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002128 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002129 ]
2130 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002131 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2132 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002133
Aaron Gable400e9892017-07-12 15:31:21 -07002134 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002135 self.mockGit.config['branch.master.gerritissue'] = '123'
2136 self.mockGit.config['branch.master.gerritserver'] = (
2137 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002138 mock.patch('git_cl.Changelist.FetchDescription',
2139 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002140 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002141 ((['git', 'log', '-1', '--format=%B'],),
2142 'This is a description\n\nChange-Id: Ideadbeef'),
2143 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002144 ]
2145 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002146 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2147 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002148
phajdan.jre328cf92016-08-22 04:12:17 -07002149 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002150 self.mockGit.config['branch.master.gerritissue'] = '123'
2151 self.mockGit.config['branch.master.gerritserver'] = (
2152 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002153 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002154 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002155 {'issue': 123,
2156 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002157 ''),
2158 ]
2159 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2160
tandrii16e0b4e2016-06-07 10:34:28 -07002161 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002162 mock.patch(
2163 'git_cl.os.path.abspath',
2164 lambda path: self._mocked_call(['abspath', path])).start()
2165 mock.patch(
2166 'git_cl.os.path.exists',
2167 lambda path: self._mocked_call(['exists', path])).start()
2168 mock.patch(
2169 'git_cl.gclient_utils.FileRead',
2170 lambda path: self._mocked_call(['FileRead', path])).start()
2171 mock.patch(
2172 'git_cl.gclient_utils.rm_file_or_tree',
2173 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002174 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002175 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002176 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002177 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002178
2179 def test_GerritCommitMsgHookCheck_custom_hook(self):
2180 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002181 self.calls += [((['exists',
2182 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2183 ((['FileRead',
2184 os.path.join('.git', 'hooks', 'commit-msg')], ),
2185 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002186 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002187
2188 def test_GerritCommitMsgHookCheck_not_exists(self):
2189 cl = self._common_GerritCommitMsgHookCheck()
2190 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002191 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002192 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002193 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002194
2195 def test_GerritCommitMsgHookCheck(self):
2196 cl = self._common_GerritCommitMsgHookCheck()
2197 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002198 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2199 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002200 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002201 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002202 ((['rm_file_or_tree',
2203 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002204 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002205 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002206
tandriic4344b52016-08-29 06:04:54 -07002207 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002208 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2209 self.mockGit.config['branch.master.gerritserver'] = (
2210 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002211 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002212 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002213 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002214 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002215 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002216 'labels': {},
2217 'current_revision': 'deadbeaf',
2218 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002219 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002220 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002221 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002222 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2223 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002224 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002225 self.assertEqual(0, cl.CMDLand(force=True,
2226 bypass_hooks=True,
2227 verbose=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002228 parallel=False,
2229 resultdb=False,
2230 realm=None))
Edward Lemur73c76702020-02-06 23:57:18 +00002231 self.assertIn(
2232 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002233 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002234 self.assertIn(
2235 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002236 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002237
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002238 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002239 mock.patch('git_cl.Changelist.GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002240
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002241 def test_gerrit_change_detail_cache_simple(self):
2242 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002243 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002244 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002245 cl1._cached_remote_url = (
2246 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002247 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002248 cl2._cached_remote_url = (
2249 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002250 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2251 self.assertEqual(cl1._GetChangeDetail(), 'a')
2252 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002253
2254 def test_gerrit_change_detail_cache_options(self):
2255 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002256 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002257 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002258 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002259 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2260 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2261 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2262 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2263 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2264 self.assertEqual(cl._GetChangeDetail(), 'cab')
2265
2266 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2267 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2268 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2269 self.assertEqual(cl._GetChangeDetail(), 'cab')
2270
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002271 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002272 gerrit_util.GetChangeDetail.return_value = {
2273 'current_revision': 'rev1',
2274 'revisions': {
2275 'rev1': {'commit': {'message': 'desc1'}},
2276 },
2277 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002278
2279 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002280 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002281 cl._cached_remote_url = (
2282 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002283 self.assertEqual(cl.FetchDescription(), 'desc1')
2284 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002285
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002286 def test_print_current_creds(self):
2287 class CookiesAuthenticatorMock(object):
2288 def __init__(self):
2289 self.gitcookies = {
2290 'host.googlesource.com': ('user', 'pass'),
2291 'host-review.googlesource.com': ('user', 'pass'),
2292 }
2293 self.netrc = self
2294 self.netrc.hosts = {
2295 'github.com': ('user2', None, 'pass2'),
2296 'host2.googlesource.com': ('user3', None, 'pass'),
2297 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002298 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2299 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002300 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2301 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2302 ' Host\t User\t Which file',
2303 '============================\t=====\t===========',
2304 'host-review.googlesource.com\t user\t.gitcookies',
2305 ' host.googlesource.com\t user\t.gitcookies',
2306 ' host2.googlesource.com\tuser3\t .netrc',
2307 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002308 sys.stdout.seek(0)
2309 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002310 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2311 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2312 ' Host\tUser\t Which file',
2313 '============================\t====\t===========',
2314 'host-review.googlesource.com\tuser\t.gitcookies',
2315 ' host.googlesource.com\tuser\t.gitcookies',
2316 ])
2317
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002318 def _common_creds_check_mocks(self):
2319 def exists_mock(path):
2320 dirname = os.path.dirname(path)
2321 if dirname == os.path.expanduser('~'):
2322 dirname = '~'
2323 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002324 if base in (NETRC_FILENAME, '.gitcookies'):
2325 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002326 # git cl also checks for existence other files not relevant to this test.
2327 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002328 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002329 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002330 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002331 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002332
2333 def test_creds_check_gitcookies_not_configured(self):
2334 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002335 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2336 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002337 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002338 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2339 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2340 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2341 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2342 'or Ctrl+C to abort'), ''),
2343 (([
2344 'git', 'config', '--global', 'http.cookiefile',
2345 os.path.expanduser(os.path.join('~', '.gitcookies'))
2346 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002347 ]
2348 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002349 self.assertTrue(
2350 sys.stdout.getvalue().startswith(
2351 'You seem to be using outdated .netrc for git credentials:'))
2352 self.assertIn(
2353 '\nConfigured git to use .gitcookies from',
2354 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002355
2356 def test_creds_check_gitcookies_configured_custom_broken(self):
2357 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002358 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2359 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002360 custom_cookie_path = ('C:\\.gitcookies'
2361 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002362 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002363 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2364 ((['git', 'config', '--global', 'http.cookiefile'], ),
2365 custom_cookie_path),
2366 (('os.path.exists', custom_cookie_path), False),
2367 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2368 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2369 (([
2370 'git', 'config', '--global', 'http.cookiefile',
2371 os.path.expanduser(os.path.join('~', '.gitcookies'))
2372 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002373 ]
2374 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002375 self.assertIn(
2376 'WARNING: You have configured custom path to .gitcookies: ',
2377 sys.stdout.getvalue())
2378 self.assertIn(
2379 'However, your configured .gitcookies file is missing.',
2380 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002381
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002382 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002383 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002384 self.mockGit.config['remote.origin.url'] = (
2385 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002386 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002387 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002388 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002389 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002390 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002391 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002392
Edward Lemurda4b6c62020-02-13 00:28:40 +00002393 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2394 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002395 self.mockGit.config['remote.origin.url'] = (
2396 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002397 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002398 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002399 'current_revision': 'ba5eba11',
2400 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002401 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002402 '_number': 1,
2403 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002404 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002405 '_number': 2,
2406 },
2407 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002408 'messages': [
2409 {
2410 u'_revision_number': 1,
2411 u'author': {
2412 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002413 u'email': u'could-be-anything@example.com',
2414 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002415 },
2416 u'date': u'2017-03-15 20:08:45.000000000',
2417 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002418 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002419 u'tag': u'autogenerated:cq:dry-run'
2420 },
2421 {
2422 u'_revision_number': 2,
2423 u'author': {
2424 u'_account_id': 11151243,
2425 u'email': u'owner@example.com',
2426 u'name': u'owner'
2427 },
2428 u'date': u'2017-03-16 20:00:41.000000000',
2429 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2430 u'message': u'PTAL',
2431 },
2432 {
2433 u'_revision_number': 2,
2434 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002435 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002436 u'email': u'reviewer@example.com',
2437 u'name': u'reviewer'
2438 },
2439 u'date': u'2017-03-17 05:19:37.500000000',
2440 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2441 u'message': u'Patch Set 2: Code-Review+1',
2442 },
2443 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002444 }
2445 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002446 (('GetChangeComments', 'chromium-review.googlesource.com',
2447 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002448 '/COMMIT_MSG': [
2449 {
2450 'author': {'email': u'reviewer@example.com'},
2451 'updated': u'2017-03-17 05:19:37.500000000',
2452 'patch_set': 2,
2453 'side': 'REVISION',
2454 'message': 'Please include a bug link',
2455 },
2456 ],
2457 'codereview.settings': [
2458 {
2459 'author': {'email': u'owner@example.com'},
2460 'updated': u'2017-03-16 20:00:41.000000000',
2461 'patch_set': 2,
2462 'side': 'PARENT',
2463 'line': 42,
2464 'message': 'I removed this because it is bad',
2465 },
2466 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002467 }),
2468 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2469 'infra%2Finfra~1'), {}),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002470 ] * 2 + [
2471 (('write_json', 'output.json', [
2472 {
2473 u'date': u'2017-03-16 20:00:41.000000',
2474 u'message': (
2475 u'PTAL\n' +
2476 u'\n' +
2477 u'codereview.settings\n' +
2478 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2479 u'c/1/2/codereview.settings#b42\n' +
2480 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002481 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002482 u'approval': False,
2483 u'disapproval': False,
2484 u'sender': u'owner@example.com'
2485 }, {
2486 u'date': u'2017-03-17 05:19:37.500000',
2487 u'message': (
2488 u'Patch Set 2: Code-Review+1\n' +
2489 u'\n' +
2490 u'/COMMIT_MSG\n' +
2491 u' PS2, File comment: https://chromium-review.googlesource' +
2492 u'.com/c/1/2//COMMIT_MSG#\n' +
2493 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002494 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002495 u'approval': False,
2496 u'disapproval': False,
2497 u'sender': u'reviewer@example.com'
2498 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002499 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002500 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002501 expected_comments_summary = [
2502 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002503 message=(
2504 u'PTAL\n' +
2505 u'\n' +
2506 u'codereview.settings\n' +
2507 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2508 u'c/1/2/codereview.settings#b42\n' +
2509 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002510 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002511 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002512 disapproval=False, approval=False, sender=u'owner@example.com'),
2513 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002514 message=(
2515 u'Patch Set 2: Code-Review+1\n' +
2516 u'\n' +
2517 u'/COMMIT_MSG\n' +
2518 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2519 u'c/1/2//COMMIT_MSG#\n' +
2520 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002521 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002522 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002523 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2524 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002525 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002526 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002527 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002528 self.assertEqual(
2529 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2530
2531 def test_git_cl_comments_robot_comments(self):
2532 # git cl comments also fetches robot comments (which are considered a type
2533 # of autogenerated comment), and unlike other types of comments, only robot
2534 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002535 self.mockGit.config['remote.origin.url'] = (
2536 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002537 gerrit_util.GetChangeDetail.return_value = {
2538 'owner': {'email': 'owner@example.com'},
2539 'current_revision': 'ba5eba11',
2540 'revisions': {
2541 'deadbeaf': {
2542 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002543 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002544 'ba5eba11': {
2545 '_number': 2,
2546 },
2547 },
2548 'messages': [
2549 {
2550 u'_revision_number': 1,
2551 u'author': {
2552 u'_account_id': 1111084,
2553 u'email': u'commit-bot@chromium.org',
2554 u'name': u'Commit Bot'
2555 },
2556 u'date': u'2017-03-15 20:08:45.000000000',
2557 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2558 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2559 u'tag': u'autogenerated:cq:dry-run'
2560 },
2561 {
2562 u'_revision_number': 1,
2563 u'author': {
2564 u'_account_id': 123,
2565 u'email': u'tricium@serviceaccount.com',
2566 u'name': u'Tricium'
2567 },
2568 u'date': u'2017-03-16 20:00:41.000000000',
2569 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2570 u'message': u'(1 comment)',
2571 u'tag': u'autogenerated:tricium',
2572 },
2573 {
2574 u'_revision_number': 1,
2575 u'author': {
2576 u'_account_id': 123,
2577 u'email': u'tricium@serviceaccount.com',
2578 u'name': u'Tricium'
2579 },
2580 u'date': u'2017-03-16 20:00:41.000000000',
2581 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2582 u'message': u'(1 comment)',
2583 u'tag': u'autogenerated:tricium',
2584 },
2585 {
2586 u'_revision_number': 2,
2587 u'author': {
2588 u'_account_id': 123,
2589 u'email': u'tricium@serviceaccount.com',
2590 u'name': u'reviewer'
2591 },
2592 u'date': u'2017-03-17 05:30:37.000000000',
2593 u'tag': u'autogenerated:tricium',
2594 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2595 u'message': u'(1 comment)',
2596 },
2597 ]
2598 }
2599 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002600 (('GetChangeComments', 'chromium-review.googlesource.com',
2601 'infra%2Finfra~1'), {}),
2602 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2603 'infra%2Finfra~1'), {
2604 'codereview.settings': [
2605 {
2606 u'author': {u'email': u'tricium@serviceaccount.com'},
2607 u'updated': u'2017-03-17 05:30:37.000000000',
2608 u'robot_run_id': u'5565031076855808',
2609 u'robot_id': u'Linter/Category',
2610 u'tag': u'autogenerated:tricium',
2611 u'patch_set': 2,
2612 u'side': u'REVISION',
2613 u'message': u'Linter warning message text',
2614 u'line': 32,
2615 },
2616 ],
2617 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002618 ]
2619 expected_comments_summary = [
2620 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2621 message=(
2622 u'(1 comment)\n\ncodereview.settings\n'
2623 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2624 u'c/1/2/codereview.settings#32\n'
2625 u' Linter warning message text\n'),
2626 sender=u'tricium@serviceaccount.com',
2627 autogenerated=True, approval=False, disapproval=False)
2628 ]
2629 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002630 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002631 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002632
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002633 def test_get_remote_url_with_mirror(self):
2634 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002635
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002636 def selective_os_path_isdir_mock(path):
2637 if path == '/cache/this-dir-exists':
2638 return self._mocked_call('os.path.isdir', path)
2639 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002640
Edward Lemurda4b6c62020-02-13 00:28:40 +00002641 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002642
2643 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002644 self.mockGit.config['remote.origin.url'] = (
2645 '/cache/this-dir-exists')
2646 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2647 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002648 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002649 (('os.path.isdir', '/cache/this-dir-exists'),
2650 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002651 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002652 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002653 self.assertEqual(cl.GetRemoteUrl(), url)
2654 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2655
Edward Lemur298f2cf2019-02-22 21:40:39 +00002656 def test_get_remote_url_non_existing_mirror(self):
2657 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002658
Edward Lemur298f2cf2019-02-22 21:40:39 +00002659 def selective_os_path_isdir_mock(path):
2660 if path == '/cache/this-dir-doesnt-exist':
2661 return self._mocked_call('os.path.isdir', path)
2662 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002663
Edward Lemurda4b6c62020-02-13 00:28:40 +00002664 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2665 mock.patch('logging.error',
2666 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002667
Edward Lemur26964072020-02-19 19:18:51 +00002668 self.mockGit.config['remote.origin.url'] = (
2669 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002670 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002671 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2672 False),
2673 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002674 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2675 'but it doesn\'t exist.', {
2676 'remote': 'origin',
2677 'branch': 'master',
2678 'url': '/cache/this-dir-doesnt-exist'}
2679 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002680 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002681 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002682 self.assertIsNone(cl.GetRemoteUrl())
2683
2684 def test_get_remote_url_misconfigured_mirror(self):
2685 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002686
Edward Lemur298f2cf2019-02-22 21:40:39 +00002687 def selective_os_path_isdir_mock(path):
2688 if path == '/cache/this-dir-exists':
2689 return self._mocked_call('os.path.isdir', path)
2690 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002691
Edward Lemurda4b6c62020-02-13 00:28:40 +00002692 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2693 mock.patch('logging.error',
2694 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002695
Edward Lemur26964072020-02-19 19:18:51 +00002696 self.mockGit.config['remote.origin.url'] = (
2697 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002698 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002699 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002700 (('logging.error',
2701 'Remote "%(remote)s" for branch "%(branch)s" points to '
2702 '"%(cache_path)s", but it is misconfigured.\n'
2703 '"%(cache_path)s" must be a git repo and must have a remote named '
2704 '"%(remote)s" pointing to the git host.', {
2705 'remote': 'origin',
2706 'cache_path': '/cache/this-dir-exists',
2707 'branch': 'master'}
2708 ), None),
2709 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002710 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002711 self.assertIsNone(cl.GetRemoteUrl())
2712
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002713 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002714 self.mockGit.config['remote.origin.url'] = (
2715 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002716 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002717 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2718
2719 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002720 mock.patch('logging.error',
2721 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002722
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002723 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002724 (('logging.error',
2725 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2726 'but it doesn\'t exist.', {
2727 'remote': 'origin',
2728 'branch': 'master',
2729 'url': ''}
2730 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002731 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002732 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002733 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002734
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002735 def test_gerrit_new_default(self):
2736 self._run_gerrit_upload_test(
2737 [],
2738 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
2739 [],
2740 squash=False,
2741 squash_mode='override_nosquash',
2742 change_id='I123456789',
2743 new_default=True)
2744
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002745
Edward Lemur9aa1a962020-02-25 00:58:38 +00002746class ChangelistTest(unittest.TestCase):
Edward Lemur227d5102020-02-25 23:45:35 +00002747 def setUp(self):
2748 super(ChangelistTest, self).setUp()
2749 mock.patch('gclient_utils.FileRead').start()
2750 mock.patch('gclient_utils.FileWrite').start()
2751 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
2752 mock.patch(
2753 'git_cl.Changelist.GetCodereviewServer',
2754 return_value='https://chromium-review.googlesource.com').start()
2755 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
2756 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
2757 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
2758 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
2759 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
2760 mock.patch('git_cl.time_time').start()
2761 mock.patch('metrics.collector').start()
2762 mock.patch('subprocess2.Popen').start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002763 mock.patch('git_cl.Changelist.GetGerritProject',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002764 return_value='https://chromium-review.googlesource.com').start()
Edward Lemur227d5102020-02-25 23:45:35 +00002765 self.addCleanup(mock.patch.stopall)
2766 self.temp_count = 0
2767
Edward Lemur227d5102020-02-25 23:45:35 +00002768 def testRunHook(self):
2769 expected_results = {
2770 'more_cc': ['more@example.com', 'cc@example.com'],
2771 'should_continue': True,
2772 }
2773 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2774 git_cl.time_time.side_effect = [100, 200]
2775 mockProcess = mock.Mock()
2776 mockProcess.wait.return_value = 0
2777 subprocess2.Popen.return_value = mockProcess
2778
2779 cl = git_cl.Changelist()
2780 results = cl.RunHook(
2781 committing=True,
2782 may_prompt=True,
2783 verbose=2,
2784 parallel=True,
2785 upstream='upstream',
2786 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002787 all_files=True,
2788 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00002789
2790 self.assertEqual(expected_results, results)
2791 subprocess2.Popen.assert_called_once_with([
2792 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00002793 '--root', 'root',
2794 '--upstream', 'upstream',
2795 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002796 '--author', 'author',
2797 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00002798 '--issue', '123456',
2799 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002800 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00002801 '--may_prompt',
2802 '--parallel',
2803 '--all_files',
2804 '--json_output', '/tmp/fake-temp2',
2805 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002806 '--gerrit_project', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00002807 ])
2808 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002809 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00002810 metrics.collector.add_repeated('sub_commands', {
2811 'command': 'presubmit',
2812 'execution_time': 100,
2813 'exit_code': 0,
2814 })
2815
Edward Lemur99df04e2020-03-05 19:39:43 +00002816 def testRunHook_FewerOptions(self):
2817 expected_results = {
2818 'more_cc': ['more@example.com', 'cc@example.com'],
2819 'should_continue': True,
2820 }
2821 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2822 git_cl.time_time.side_effect = [100, 200]
2823 mockProcess = mock.Mock()
2824 mockProcess.wait.return_value = 0
2825 subprocess2.Popen.return_value = mockProcess
2826
2827 git_cl.Changelist.GetAuthor.return_value = None
2828 git_cl.Changelist.GetIssue.return_value = None
2829 git_cl.Changelist.GetPatchset.return_value = None
2830 git_cl.Changelist.GetCodereviewServer.return_value = None
2831
2832 cl = git_cl.Changelist()
2833 results = cl.RunHook(
2834 committing=False,
2835 may_prompt=False,
2836 verbose=0,
2837 parallel=False,
2838 upstream='upstream',
2839 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002840 all_files=False,
2841 resultdb=False)
Edward Lemur99df04e2020-03-05 19:39:43 +00002842
2843 self.assertEqual(expected_results, results)
2844 subprocess2.Popen.assert_called_once_with([
2845 'vpython', 'PRESUBMIT_SUPPORT',
2846 '--root', 'root',
2847 '--upstream', 'upstream',
2848 '--upload',
2849 '--json_output', '/tmp/fake-temp2',
2850 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002851 '--gerrit_project', 'https://chromium-review.googlesource.com',
Edward Lemur99df04e2020-03-05 19:39:43 +00002852 ])
2853 gclient_utils.FileWrite.assert_called_once_with(
2854 '/tmp/fake-temp1', 'description')
2855 metrics.collector.add_repeated('sub_commands', {
2856 'command': 'presubmit',
2857 'execution_time': 100,
2858 'exit_code': 0,
2859 })
2860
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002861 def testRunHook_FewerOptionsResultDB(self):
2862 expected_results = {
2863 'more_cc': ['more@example.com', 'cc@example.com'],
2864 'should_continue': True,
2865 }
2866 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2867 git_cl.time_time.side_effect = [100, 200]
2868 mockProcess = mock.Mock()
2869 mockProcess.wait.return_value = 0
2870 subprocess2.Popen.return_value = mockProcess
2871
2872 git_cl.Changelist.GetAuthor.return_value = None
2873 git_cl.Changelist.GetIssue.return_value = None
2874 git_cl.Changelist.GetPatchset.return_value = None
2875 git_cl.Changelist.GetCodereviewServer.return_value = None
2876
2877 cl = git_cl.Changelist()
2878 results = cl.RunHook(
2879 committing=False,
2880 may_prompt=False,
2881 verbose=0,
2882 parallel=False,
2883 upstream='upstream',
2884 description='description',
2885 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002886 resultdb=True,
2887 realm='chromium:public')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002888
2889 self.assertEqual(expected_results, results)
2890 subprocess2.Popen.assert_called_once_with([
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002891 'rdb', 'stream', '-new', '-realm', 'chromium:public', '--',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002892 'vpython', 'PRESUBMIT_SUPPORT',
2893 '--root', 'root',
2894 '--upstream', 'upstream',
2895 '--upload',
2896 '--json_output', '/tmp/fake-temp2',
2897 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002898 '--gerrit_project', 'https://chromium-review.googlesource.com',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002899 ])
2900
Edward Lemur227d5102020-02-25 23:45:35 +00002901 @mock.patch('sys.exit', side_effect=SystemExitMock)
2902 def testRunHook_Failure(self, _mock):
2903 git_cl.time_time.side_effect = [100, 200]
2904 mockProcess = mock.Mock()
2905 mockProcess.wait.return_value = 2
2906 subprocess2.Popen.return_value = mockProcess
2907
2908 cl = git_cl.Changelist()
2909 with self.assertRaises(SystemExitMock):
2910 cl.RunHook(
2911 committing=True,
2912 may_prompt=True,
2913 verbose=2,
2914 parallel=True,
2915 upstream='upstream',
2916 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002917 all_files=True,
2918 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00002919
2920 sys.exit.assert_called_once_with(2)
2921
Edward Lemur75526302020-02-27 22:31:05 +00002922 def testRunPostUploadHook(self):
2923 cl = git_cl.Changelist()
2924 cl.RunPostUploadHook(2, 'upstream', 'description')
2925
2926 subprocess2.Popen.assert_called_once_with([
2927 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00002928 '--root', 'root',
2929 '--upstream', 'upstream',
2930 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002931 '--author', 'author',
2932 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur75526302020-02-27 22:31:05 +00002933 '--issue', '123456',
2934 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002935 '--post_upload',
2936 '--description_file', '/tmp/fake-temp1',
2937 ])
2938 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002939 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00002940
Edward Lemur9aa1a962020-02-25 00:58:38 +00002941
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002942class CMDTestCaseBase(unittest.TestCase):
2943 _STATUSES = [
2944 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
2945 'INFRA_FAILURE', 'CANCELED',
2946 ]
2947 _CHANGE_DETAIL = {
2948 'project': 'depot_tools',
2949 'status': 'OPEN',
2950 'owner': {'email': 'owner@e.mail'},
2951 'current_revision': 'beeeeeef',
2952 'revisions': {
Gavin Make61ccc52020-11-13 00:12:57 +00002953 'deadbeaf': {
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00002954 '_number': 6,
Gavin Make61ccc52020-11-13 00:12:57 +00002955 'kind': 'REWORK',
2956 },
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002957 'beeeeeef': {
2958 '_number': 7,
Gavin Make61ccc52020-11-13 00:12:57 +00002959 'kind': 'NO_CODE_CHANGE',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002960 'fetch': {'http': {
2961 'url': 'https://chromium.googlesource.com/depot_tools',
2962 'ref': 'refs/changes/56/123456/7'
2963 }},
2964 },
2965 },
2966 }
2967 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002968 'builds': [{
2969 'id': str(100 + idx),
2970 'builder': {
2971 'project': 'chromium',
2972 'bucket': 'try',
2973 'builder': 'bot_' + status.lower(),
2974 },
2975 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
2976 'tags': [],
2977 'status': status,
2978 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002979 }
2980
Edward Lemur4c707a22019-09-24 21:13:43 +00002981 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002982 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00002983 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002984 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
2985 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002986 mock.patch(
2987 'git_cl.Changelist.GetCodereviewServer',
2988 return_value='https://chromium-review.googlesource.com').start()
2989 mock.patch(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002990 'git_cl.Changelist.GetGerritHost',
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002991 return_value='chromium-review.googlesource.com').start()
2992 mock.patch(
2993 'git_cl.Changelist.GetMostRecentPatchset',
2994 return_value=7).start()
2995 mock.patch(
Gavin Make61ccc52020-11-13 00:12:57 +00002996 'git_cl.Changelist.GetMostRecentDryRunPatchset',
2997 return_value=6).start()
2998 mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002999 'git_cl.Changelist.GetRemoteUrl',
3000 return_value='https://chromium.googlesource.com/depot_tools').start()
3001 mock.patch(
3002 'auth.Authenticator',
3003 return_value=AuthenticatorMock()).start()
3004 mock.patch(
3005 'gerrit_util.GetChangeDetail',
3006 return_value=self._CHANGE_DETAIL).start()
3007 mock.patch(
3008 'git_cl._call_buildbucket',
3009 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003010 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003011 self.addCleanup(mock.patch.stopall)
3012
Edward Lemur4c707a22019-09-24 21:13:43 +00003013
Edward Lemur9468eba2020-02-27 19:07:22 +00003014class CMDPresubmitTestCase(CMDTestCaseBase):
3015 def setUp(self):
3016 super(CMDPresubmitTestCase, self).setUp()
3017 mock.patch(
3018 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3019 return_value='upstream').start()
3020 mock.patch(
3021 'git_cl.Changelist.FetchDescription',
3022 return_value='fetch description').start()
3023 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00003024 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00003025 return_value='get description').start()
3026 mock.patch('git_cl.Changelist.RunHook').start()
3027
3028 def testDefaultCase(self):
3029 self.assertEqual(0, git_cl.main(['presubmit']))
3030 git_cl.Changelist.RunHook.assert_called_once_with(
3031 committing=True,
3032 may_prompt=False,
3033 verbose=0,
3034 parallel=None,
3035 upstream='upstream',
3036 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003037 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003038 resultdb=None,
3039 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003040
3041 def testNoIssue(self):
3042 git_cl.Changelist.GetIssue.return_value = None
3043 self.assertEqual(0, git_cl.main(['presubmit']))
3044 git_cl.Changelist.RunHook.assert_called_once_with(
3045 committing=True,
3046 may_prompt=False,
3047 verbose=0,
3048 parallel=None,
3049 upstream='upstream',
3050 description='get description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003051 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003052 resultdb=None,
3053 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003054
3055 def testCustomBranch(self):
3056 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3057 git_cl.Changelist.RunHook.assert_called_once_with(
3058 committing=True,
3059 may_prompt=False,
3060 verbose=0,
3061 parallel=None,
3062 upstream='custom_branch',
3063 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003064 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003065 resultdb=None,
3066 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003067
3068 def testOptions(self):
3069 self.assertEqual(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003070 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003071 '--resultdb', '--realm', 'chromium:public']))
Edward Lemur9468eba2020-02-27 19:07:22 +00003072 git_cl.Changelist.RunHook.assert_called_once_with(
3073 committing=False,
3074 may_prompt=False,
3075 verbose=2,
3076 parallel=True,
3077 upstream='upstream',
3078 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003079 all_files=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003080 resultdb=True,
3081 realm='chromium:public')
Edward Lemur9468eba2020-02-27 19:07:22 +00003082
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003083class CMDTryResultsTestCase(CMDTestCaseBase):
3084 _DEFAULT_REQUEST = {
3085 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003086 "gerritChanges": [{
3087 "project": "depot_tools",
3088 "host": "chromium-review.googlesource.com",
Gavin Make61ccc52020-11-13 00:12:57 +00003089 "patchset": 6,
3090 "change": 123456,
3091 }],
3092 },
3093 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3094 ',builds.*.createTime,builds.*.tags'),
3095 }
3096
3097 _TRIVIAL_REQUEST = {
3098 'predicate': {
3099 "gerritChanges": [{
3100 "project": "depot_tools",
3101 "host": "chromium-review.googlesource.com",
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003102 "patchset": 7,
3103 "change": 123456,
3104 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003105 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003106 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3107 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003108 }
3109
3110 def testNoJobs(self):
3111 git_cl._call_buildbucket.return_value = {}
3112
3113 self.assertEqual(0, git_cl.main(['try-results']))
3114 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3115 git_cl._call_buildbucket.assert_called_once_with(
3116 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3117 self._DEFAULT_REQUEST)
3118
Gavin Make61ccc52020-11-13 00:12:57 +00003119 def testTrivialCommits(self):
3120 self.assertEqual(0, git_cl.main(['try-results']))
3121 git_cl._call_buildbucket.assert_called_with(
3122 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3123 self._DEFAULT_REQUEST)
3124
3125 git_cl._call_buildbucket.return_value = {}
3126 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '7']))
3127 git_cl._call_buildbucket.assert_called_with(
3128 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3129 self._TRIVIAL_REQUEST)
3130 self.assertEqual([
3131 'Successes:',
3132 ' bot_success https://ci.chromium.org/b/103',
3133 'Infra Failures:',
3134 ' bot_infra_failure https://ci.chromium.org/b/105',
3135 'Failures:',
3136 ' bot_failure https://ci.chromium.org/b/104',
3137 'Canceled:',
3138 ' bot_canceled ',
3139 'Started:',
3140 ' bot_started https://ci.chromium.org/b/102',
3141 'Scheduled:',
3142 ' bot_scheduled id=101',
3143 'Other:',
3144 ' bot_status_unspecified id=100',
3145 'Total: 7 tryjobs',
3146 'No tryjobs scheduled.',
3147 ], sys.stdout.getvalue().splitlines())
3148
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003149 def testPrintToStdout(self):
3150 self.assertEqual(0, git_cl.main(['try-results']))
3151 self.assertEqual([
3152 'Successes:',
3153 ' bot_success https://ci.chromium.org/b/103',
3154 'Infra Failures:',
3155 ' bot_infra_failure https://ci.chromium.org/b/105',
3156 'Failures:',
3157 ' bot_failure https://ci.chromium.org/b/104',
3158 'Canceled:',
3159 ' bot_canceled ',
3160 'Started:',
3161 ' bot_started https://ci.chromium.org/b/102',
3162 'Scheduled:',
3163 ' bot_scheduled id=101',
3164 'Other:',
3165 ' bot_status_unspecified id=100',
3166 'Total: 7 tryjobs',
3167 ], sys.stdout.getvalue().splitlines())
3168 git_cl._call_buildbucket.assert_called_once_with(
3169 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3170 self._DEFAULT_REQUEST)
3171
3172 def testPrintToStdoutWithMasters(self):
3173 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3174 self.assertEqual([
3175 'Successes:',
3176 ' try bot_success https://ci.chromium.org/b/103',
3177 'Infra Failures:',
3178 ' try bot_infra_failure https://ci.chromium.org/b/105',
3179 'Failures:',
3180 ' try bot_failure https://ci.chromium.org/b/104',
3181 'Canceled:',
3182 ' try bot_canceled ',
3183 'Started:',
3184 ' try bot_started https://ci.chromium.org/b/102',
3185 'Scheduled:',
3186 ' try bot_scheduled id=101',
3187 'Other:',
3188 ' try bot_status_unspecified id=100',
3189 'Total: 7 tryjobs',
3190 ], sys.stdout.getvalue().splitlines())
3191 git_cl._call_buildbucket.assert_called_once_with(
3192 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3193 self._DEFAULT_REQUEST)
3194
3195 @mock.patch('git_cl.write_json')
3196 def testWriteToJson(self, mockJsonDump):
3197 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3198 git_cl._call_buildbucket.assert_called_once_with(
3199 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3200 self._DEFAULT_REQUEST)
3201 mockJsonDump.assert_called_once_with(
3202 'file.json', self._DEFAULT_RESPONSE['builds'])
3203
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003204 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003205 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3206 self.assertEqual(
3207 [
3208 ('chromium', 'try', 'bot_failure'),
3209 ('chromium', 'try', 'bot_infra_failure'),
3210 ],
3211 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003212
3213 def test_filter_failed_for_retry_many_builds(self):
3214
3215 def _build(name, created_sec, status, experimental=False):
3216 assert 0 <= created_sec < 100, created_sec
3217 b = {
3218 'id': 112112,
3219 'builder': {
3220 'project': 'chromium',
3221 'bucket': 'try',
3222 'builder': name,
3223 },
3224 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3225 'status': status,
3226 'tags': [],
3227 }
3228 if experimental:
3229 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3230 return b
3231
3232 builds = [
3233 _build('flaky-last-green', 1, 'FAILURE'),
3234 _build('flaky-last-green', 2, 'SUCCESS'),
3235 _build('flaky', 1, 'SUCCESS'),
3236 _build('flaky', 2, 'FAILURE'),
3237 _build('running', 1, 'FAILED'),
3238 _build('running', 2, 'SCHEDULED'),
3239 _build('yep-still-running', 1, 'STARTED'),
3240 _build('yep-still-running', 2, 'FAILURE'),
3241 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3242 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3243
3244 # Simulate experimental in CQ builder, which developer decided
3245 # to retry manually which resulted in 2nd build non-experimental.
3246 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3247 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3248 ]
3249 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003250 self.assertEqual(
3251 [
3252 ('chromium', 'try', 'flaky'),
3253 ('chromium', 'try', 'sometimes-experimental'),
3254 ],
3255 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003256
3257
3258class CMDTryTestCase(CMDTestCaseBase):
3259
3260 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003261 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003262 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003263 self.assertEqual(0, git_cl.main(['try']))
3264 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3265 self.assertEqual(
3266 sys.stdout.getvalue(),
3267 'Scheduling CQ dry run on: '
3268 'https://chromium-review.googlesource.com/123456\n')
3269
Edward Lemur4c707a22019-09-24 21:13:43 +00003270 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003271 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003272 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003273
3274 self.assertEqual(0, git_cl.main([
3275 'try', '-B', 'luci.chromium.try', '-b', 'win',
3276 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3277 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003278 'Scheduling jobs on:\n'
3279 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003280 git_cl.sys.stdout.getvalue())
3281
3282 expected_request = {
3283 "requests": [{
3284 "scheduleBuild": {
3285 "requestId": "uuid4",
3286 "builder": {
3287 "project": "chromium",
3288 "builder": "win",
3289 "bucket": "try",
3290 },
3291 "gerritChanges": [{
3292 "project": "depot_tools",
3293 "host": "chromium-review.googlesource.com",
3294 "patchset": 7,
3295 "change": 123456,
3296 }],
3297 "properties": {
3298 "category": "git_cl_try",
3299 "json": [{"a": 1}, None],
3300 "key": "val",
3301 },
3302 "tags": [
3303 {"value": "win", "key": "builder"},
3304 {"value": "git_cl_try", "key": "user_agent"},
3305 ],
3306 },
3307 }],
3308 }
3309 mockCallBuildbucket.assert_called_with(
3310 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3311
Anthony Polito1a5fe232020-01-24 23:17:52 +00003312 @mock.patch('git_cl._call_buildbucket')
3313 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3314 mockCallBuildbucket.return_value = {}
3315
3316 self.assertEqual(0, git_cl.main([
3317 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3318 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3319 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3320 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003321 'Scheduling jobs on:\n'
3322 ' chromium/try: linux\n'
3323 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003324 git_cl.sys.stdout.getvalue())
3325
3326 expected_request = {
3327 "requests": [{
3328 "scheduleBuild": {
3329 "requestId": "uuid4",
3330 "builder": {
3331 "project": "chromium",
3332 "builder": "linux",
3333 "bucket": "try",
3334 },
3335 "gerritChanges": [{
3336 "project": "depot_tools",
3337 "host": "chromium-review.googlesource.com",
3338 "patchset": 7,
3339 "change": 123456,
3340 }],
3341 "properties": {
3342 "category": "git_cl_try",
3343 "json": [{"a": 1}, None],
3344 "key": "val",
3345 },
3346 "tags": [
3347 {"value": "linux", "key": "builder"},
3348 {"value": "git_cl_try", "key": "user_agent"},
3349 ],
3350 "gitilesCommit": {
3351 "host": "chromium-review.googlesource.com",
3352 "project": "depot_tools",
3353 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3354 }
3355 },
3356 },
3357 {
3358 "scheduleBuild": {
3359 "requestId": "uuid4",
3360 "builder": {
3361 "project": "chromium",
3362 "builder": "win",
3363 "bucket": "try",
3364 },
3365 "gerritChanges": [{
3366 "project": "depot_tools",
3367 "host": "chromium-review.googlesource.com",
3368 "patchset": 7,
3369 "change": 123456,
3370 }],
3371 "properties": {
3372 "category": "git_cl_try",
3373 "json": [{"a": 1}, None],
3374 "key": "val",
3375 },
3376 "tags": [
3377 {"value": "win", "key": "builder"},
3378 {"value": "git_cl_try", "key": "user_agent"},
3379 ],
3380 "gitilesCommit": {
3381 "host": "chromium-review.googlesource.com",
3382 "project": "depot_tools",
3383 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3384 }
3385 },
3386 }],
3387 }
3388 mockCallBuildbucket.assert_called_with(
3389 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3390
Edward Lemur45768512020-03-02 19:03:14 +00003391 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003392 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003393 with self.assertRaises(SystemExit):
3394 git_cl.main([
3395 'try', '-B', 'not-a-bucket', '-b', 'win',
3396 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003397 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003398 'Invalid bucket: not-a-bucket.',
3399 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003400
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003401 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003402 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003403 def testScheduleOnBuildbucketRetryFailed(
3404 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003405 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003406 7: [],
3407 6: [{
3408 'id': 112112,
3409 'builder': {
3410 'project': 'chromium',
3411 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003412 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003413 'createTime': '2019-10-09T08:00:01.854286Z',
3414 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003415 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003416 mockCallBuildbucket.return_value = {}
3417
3418 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3419 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003420 'Scheduling jobs on:\n'
3421 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003422 git_cl.sys.stdout.getvalue())
3423
3424 expected_request = {
3425 "requests": [{
3426 "scheduleBuild": {
3427 "requestId": "uuid4",
3428 "builder": {
3429 "project": "chromium",
3430 "bucket": "try",
3431 "builder": "linux",
3432 },
3433 "gerritChanges": [{
3434 "project": "depot_tools",
3435 "host": "chromium-review.googlesource.com",
3436 "patchset": 7,
3437 "change": 123456,
3438 }],
3439 "properties": {
3440 "category": "git_cl_try",
3441 },
3442 "tags": [
3443 {"value": "linux", "key": "builder"},
3444 {"value": "git_cl_try", "key": "user_agent"},
3445 {"value": "1", "key": "retry_failed"},
3446 ],
3447 },
3448 }],
3449 }
3450 mockCallBuildbucket.assert_called_with(
3451 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3452
Edward Lemur4c707a22019-09-24 21:13:43 +00003453 def test_parse_bucket(self):
3454 test_cases = [
3455 {
3456 'bucket': 'chromium/try',
3457 'result': ('chromium', 'try'),
3458 },
3459 {
3460 'bucket': 'luci.chromium.try',
3461 'result': ('chromium', 'try'),
3462 'has_warning': True,
3463 },
3464 {
3465 'bucket': 'skia.primary',
3466 'result': ('skia', 'skia.primary'),
3467 'has_warning': True,
3468 },
3469 {
3470 'bucket': 'not-a-bucket',
3471 'result': (None, None),
3472 },
3473 ]
3474
3475 for test_case in test_cases:
3476 git_cl.sys.stdout.truncate(0)
3477 self.assertEqual(
3478 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3479 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003480 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3481 test_case['result'])
3482 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003483
3484
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003485class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003486
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003487 def setUp(self):
3488 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003489 mock.patch('git_cl._fetch_tryjobs').start()
3490 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003491 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003492 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3493 mock.patch(
3494 'git_cl.Settings.GetSquashGerritUploads',
3495 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003496 self.addCleanup(mock.patch.stopall)
3497
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003498 def testWarmUpChangeDetailCache(self):
3499 self.assertEqual(0, git_cl.main(['upload']))
3500 gerrit_util.GetChangeDetail.assert_called_once_with(
3501 'chromium-review.googlesource.com', 'depot_tools~123456',
3502 frozenset([
3503 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3504 'CURRENT_COMMIT']))
3505
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003506 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003507 # This test mocks out the actual upload part, and just asserts that after
3508 # upload, if --retry-failed is added, then the tool will fetch try jobs
3509 # from the previous patchset and trigger the right builders on the latest
3510 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003511 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003512 # Latest patchset: No builds.
3513 [],
3514 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003515 [{
3516 'id': str(100 + idx),
3517 'builder': {
3518 'project': 'chromium',
3519 'bucket': 'try',
3520 'builder': 'bot_' + status.lower(),
3521 },
3522 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3523 'tags': [],
3524 'status': status,
3525 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003526 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003527
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003528 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003529 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003530 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3531 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003532 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003533 expected_buckets = [
3534 ('chromium', 'try', 'bot_failure'),
3535 ('chromium', 'try', 'bot_infra_failure'),
3536 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003537 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3538 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003539
Brian Sheedy59b06a82019-10-14 17:03:29 +00003540
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003541class MakeRequestsHelperTestCase(unittest.TestCase):
3542
3543 def exampleGerritChange(self):
3544 return {
3545 'host': 'chromium-review.googlesource.com',
3546 'project': 'depot_tools',
3547 'change': 1,
3548 'patchset': 2,
3549 }
3550
3551 def testMakeRequestsHelperNoOptions(self):
3552 # Basic test for the helper function _make_tryjob_schedule_requests;
3553 # it shouldn't throw AttributeError even when options doesn't have any
3554 # of the expected values; it will use default option values.
3555 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3556 jobs = [('chromium', 'try', 'my-builder')]
3557 options = optparse.Values()
3558 requests = git_cl._make_tryjob_schedule_requests(
3559 changelist, jobs, options, patchset=None)
3560
3561 # requestId is non-deterministic. Just assert that it's there and has
3562 # a particular length.
3563 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3564 self.assertEqual(requests, [{
3565 'scheduleBuild': {
3566 'builder': {
3567 'bucket': 'try',
3568 'builder': 'my-builder',
3569 'project': 'chromium'
3570 },
3571 'gerritChanges': [self.exampleGerritChange()],
3572 'properties': {
3573 'category': 'git_cl_try'
3574 },
3575 'tags': [{
3576 'key': 'builder',
3577 'value': 'my-builder'
3578 }, {
3579 'key': 'user_agent',
3580 'value': 'git_cl_try'
3581 }]
3582 }
3583 }])
3584
3585 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3586 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3587 jobs = [('chromium', 'try', 'presubmit')]
3588 options = optparse.Values()
3589 requests = git_cl._make_tryjob_schedule_requests(
3590 changelist, jobs, options, patchset=None)
3591 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3592 'category': 'git_cl_try',
3593 'dry_run': 'true'
3594 })
3595
3596 def testMakeRequestsHelperRevisionSet(self):
3597 # Gitiles commit is specified when revision is in options.
3598 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3599 jobs = [('chromium', 'try', 'my-builder')]
3600 options = optparse.Values({'revision': 'ba5eba11'})
3601 requests = git_cl._make_tryjob_schedule_requests(
3602 changelist, jobs, options, patchset=None)
3603 self.assertEqual(
3604 requests[0]['scheduleBuild']['gitilesCommit'], {
3605 'host': 'chromium-review.googlesource.com',
3606 'id': 'ba5eba11',
3607 'project': 'depot_tools'
3608 })
3609
3610 def testMakeRequestsHelperRetryFailedSet(self):
3611 # An extra tag is added when retry_failed is in options.
3612 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3613 jobs = [('chromium', 'try', 'my-builder')]
3614 options = optparse.Values({'retry_failed': 'true'})
3615 requests = git_cl._make_tryjob_schedule_requests(
3616 changelist, jobs, options, patchset=None)
3617 self.assertEqual(
3618 requests[0]['scheduleBuild']['tags'], [
3619 {
3620 'key': 'builder',
3621 'value': 'my-builder'
3622 },
3623 {
3624 'key': 'user_agent',
3625 'value': 'git_cl_try'
3626 },
3627 {
3628 'key': 'retry_failed',
3629 'value': '1'
3630 }
3631 ])
3632
3633 def testMakeRequestsHelperCategorySet(self):
Quinten Yearsley925cedb2020-04-13 17:49:39 +00003634 # The category property can be overridden with options.
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003635 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3636 jobs = [('chromium', 'try', 'my-builder')]
3637 options = optparse.Values({'category': 'my-special-category'})
3638 requests = git_cl._make_tryjob_schedule_requests(
3639 changelist, jobs, options, patchset=None)
3640 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3641 {'category': 'my-special-category'})
3642
3643
Edward Lemurda4b6c62020-02-13 00:28:40 +00003644class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003645
3646 def setUp(self):
3647 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003648 mock.patch('git_cl.RunCommand').start()
3649 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3650 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3651 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003652 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003653 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003654
3655 def tearDown(self):
3656 shutil.rmtree(self._top_dir)
3657 super(CMDFormatTestCase, self).tearDown()
3658
Jamie Madill5e96ad12020-01-13 16:08:35 +00003659 def _make_temp_file(self, fname, contents):
3660 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3661 tf.write('\n'.join(contents))
3662
Brian Sheedy59b06a82019-10-14 17:03:29 +00003663 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003664 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003665
Brian Sheedyb4307d52019-12-02 19:18:17 +00003666 def _check_yapf_filtering(self, files, expected):
3667 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3668 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003669
Edward Lemur1a83da12020-03-04 21:18:36 +00003670 def _run_command_mock(self, return_value):
3671 def f(*args, **kwargs):
3672 if 'stdin' in kwargs:
3673 self.assertIsInstance(kwargs['stdin'], bytes)
3674 return return_value
3675 return f
3676
Jamie Madill5e96ad12020-01-13 16:08:35 +00003677 def testClangFormatDiffFull(self):
3678 self._make_temp_file('test.cc', ['// test'])
3679 git_cl.settings.GetFormatFullByDefault.return_value = False
3680 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3681 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3682
3683 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003684 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003685 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3686 self._top_dir, 'HEAD')
3687 self.assertEqual(2, return_value)
3688
3689 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003690 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003691 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3692 self._top_dir, 'HEAD')
3693 self.assertEqual(0, return_value)
3694
3695 def testClangFormatDiff(self):
3696 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00003697 # A valid file is required, so use this test.
3698 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00003699 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3700
3701 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003702 git_cl.RunCommand.side_effect = self._run_command_mock('error')
3703 return_value = git_cl._RunClangFormatDiff(
3704 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003705 self.assertEqual(2, return_value)
3706
3707 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003708 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003709 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3710 'HEAD')
3711 self.assertEqual(0, return_value)
3712
Brian Sheedyb4307d52019-12-02 19:18:17 +00003713 def testYapfignoreExplicit(self):
3714 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3715 files = [
3716 'bar.py',
3717 'foo/bar.py',
3718 'foo/baz.py',
3719 'foo/bar/baz.py',
3720 'foo/bar/foobar.py',
3721 ]
3722 expected = [
3723 'bar.py',
3724 'foo/baz.py',
3725 'foo/bar/foobar.py',
3726 ]
3727 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003728
Brian Sheedyb4307d52019-12-02 19:18:17 +00003729 def testYapfignoreSingleWildcards(self):
3730 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3731 files = [
3732 'bar.py', # Matched by *bar.py.
3733 'bar.txt',
3734 'foobar.py', # Matched by *bar.py, foo*.
3735 'foobar.txt', # Matched by foo*.
3736 'bazbar.py', # Matched by *bar.py, baz*.py.
3737 'bazbar.txt',
3738 'foo/baz.txt', # Matched by foo*.
3739 'bar/bar.py', # Matched by *bar.py.
3740 'baz/foo.py', # Matched by baz*.py, foo*.
3741 'baz/foo.txt',
3742 ]
3743 expected = [
3744 'bar.txt',
3745 'bazbar.txt',
3746 'baz/foo.txt',
3747 ]
3748 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003749
Brian Sheedyb4307d52019-12-02 19:18:17 +00003750 def testYapfignoreMultiplewildcards(self):
3751 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3752 files = [
3753 'bar.py', # Matched by *bar*.
3754 'bar.txt', # Matched by *bar*.
3755 'abar.py', # Matched by *bar*.
3756 'foobaz.txt', # Matched by *foo*baz.txt.
3757 'foobaz.py',
3758 'afoobaz.txt', # Matched by *foo*baz.txt.
3759 ]
3760 expected = [
3761 'foobaz.py',
3762 ]
3763 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003764
3765 def testYapfignoreComments(self):
3766 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003767 files = [
3768 'test.py',
3769 'test2.py',
3770 ]
3771 expected = [
3772 'test2.py',
3773 ]
3774 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003775
3776 def testYapfignoreBlankLines(self):
3777 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003778 files = [
3779 'test.py',
3780 'test2.py',
3781 'test3.py',
3782 ]
3783 expected = [
3784 'test3.py',
3785 ]
3786 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003787
3788 def testYapfignoreWhitespace(self):
3789 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003790 files = [
3791 'test.py',
3792 'test2.py',
3793 ]
3794 expected = [
3795 'test2.py',
3796 ]
3797 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003798
Brian Sheedyb4307d52019-12-02 19:18:17 +00003799 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003800 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003801 self._check_yapf_filtering([], [])
3802
3803 def testYapfignoreMissingYapfignore(self):
3804 files = [
3805 'test.py',
3806 ]
3807 expected = [
3808 'test.py',
3809 ]
3810 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003811
3812
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003813class CMDStatusTestCase(CMDTestCaseBase):
3814 # Return branch names a,..,f with comitterdates in increasing order, i.e.
3815 # 'f' is the most-recently changed branch.
3816 def _mock_run_git(commands):
3817 if commands == [
3818 'for-each-ref', '--format=%(refname) %(committerdate:unix)',
3819 'refs/heads'
3820 ]:
3821 branches_and_committerdates = [
3822 'refs/heads/a 1',
3823 'refs/heads/b 2',
3824 'refs/heads/c 3',
3825 'refs/heads/d 4',
3826 'refs/heads/e 5',
3827 'refs/heads/f 6',
3828 ]
3829 return '\n'.join(branches_and_committerdates)
3830
3831 # Mock the status in such a way that the issue number gives us an
3832 # indication of the commit date (simplifies manual debugging).
3833 def _mock_get_cl_statuses(branches, fine_grained, max_processes):
3834 for c in branches:
3835 c.issue = (100 + int(c.GetCommitDate()))
3836 yield (c, 'open')
3837
3838 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
3839 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
3840 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
3841 @mock.patch('git_cl.RunGit', _mock_run_git)
3842 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
3843 @mock.patch('git_cl.Settings.GetRoot', return_value='')
3844 @mock.patch('scm.GIT.GetBranch', return_value='a')
3845 def testStatus(self, *_mocks):
3846 self.assertEqual(0, git_cl.main(['status', '--no-branch-color']))
3847 self.maxDiff = None
3848 self.assertEqual(
3849 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
3850 ' * a : https://crrev.com/c/101 (open)\n'
3851 ' b : https://crrev.com/c/102 (open)\n'
3852 ' c : https://crrev.com/c/103 (open)\n'
3853 ' d : https://crrev.com/c/104 (open)\n'
3854 ' e : https://crrev.com/c/105 (open)\n'
3855 ' f : https://crrev.com/c/106 (open)\n\n'
3856 'Current branch: a\n'
3857 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
3858 'Issue description:\n'
3859 'x\n')
3860
3861 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
3862 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
3863 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
3864 @mock.patch('git_cl.RunGit', _mock_run_git)
3865 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
3866 @mock.patch('git_cl.Settings.GetRoot', return_value='')
3867 @mock.patch('scm.GIT.GetBranch', return_value='a')
3868 def testStatusByDate(self, *_mocks):
3869 self.assertEqual(
3870 0, git_cl.main(['status', '--no-branch-color', '--date-order']))
3871 self.maxDiff = None
3872 self.assertEqual(
3873 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
3874 ' f : https://crrev.com/c/106 (open)\n'
3875 ' e : https://crrev.com/c/105 (open)\n'
3876 ' d : https://crrev.com/c/104 (open)\n'
3877 ' c : https://crrev.com/c/103 (open)\n'
3878 ' b : https://crrev.com/c/102 (open)\n'
3879 ' * a : https://crrev.com/c/101 (open)\n\n'
3880 'Current branch: a\n'
3881 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
3882 'Issue description:\n'
3883 'x\n')
3884
3885
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003886if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003887 logging.basicConfig(
3888 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003889 unittest.main()