blob: ef98d001a0e4b22a3a6d496a16916ede4d201e55 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
34# We have to disable monitoring before importing git_cl.
35metrics.DISABLE_METRICS_COLLECTION = True
36
Jamie Madill5e96ad12020-01-13 16:08:35 +000037import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000038import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000039import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000040import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000041import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000042import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000043import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000044import git_new_branch
45import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000046import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000047
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000048NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
49
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000050
Edward Lemur0db01f02019-11-12 22:01:51 +000051def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070052 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
53
tandrii5d48c322016-08-18 16:19:37 -070054CERR1 = callError(1)
55
56
Edward Lemur1773f372020-02-22 00:27:14 +000057class TemporaryFileMock(object):
58 def __init__(self):
59 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070060
Edward Lemur1773f372020-02-22 00:27:14 +000061 @contextlib.contextmanager
62 def __call__(self):
63 self.suffix += 1
64 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070065
66
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000067class ChangelistMock(object):
68 # A class variable so we can access it when we don't have access to the
69 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000070 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000071
72 def __init__(self, gerrit_change=None, **kwargs):
73 self._gerrit_change = gerrit_change
74
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000075 def GetIssue(self):
76 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000077
Edward Lemur6c6827c2020-02-06 21:15:18 +000078 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000079 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000080
dsansomee2d6fd92016-09-08 00:10:47 -070081 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000082 ChangelistMock.desc = desc
83
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000084 def GetGerritChange(self, patchset=None, **kwargs):
85 del patchset
86 return self._gerrit_change
87
tandrii5d48c322016-08-18 16:19:37 -070088
Edward Lemur85153282020-02-14 22:06:29 +000089class GitMocks(object):
90 def __init__(self, config=None, branchref=None):
91 self.branchref = branchref or 'refs/heads/master'
92 self.config = config or {}
93
94 def GetBranchRef(self, _root):
95 return self.branchref
96
97 def NewBranch(self, branchref):
98 self.branchref = branchref
99
Edward Lemur26964072020-02-19 19:18:51 +0000100 def GetConfig(self, root, key, default=None):
101 if root != '':
102 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000103 return self.config.get(key, default)
104
Edward Lemur26964072020-02-19 19:18:51 +0000105 def SetConfig(self, root, key, value=None):
106 if root != '':
107 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000108 if value:
109 self.config[key] = value
110 return
111 if key not in self.config:
112 raise CERR1
113 del self.config[key]
114
115
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000116class WatchlistsMock(object):
117 def __init__(self, _):
118 pass
119 @staticmethod
120 def GetWatchersForPaths(_):
121 return ['joe@example.com']
122
123
Edward Lemur4c707a22019-09-24 21:13:43 +0000124class CodereviewSettingsFileMock(object):
125 def __init__(self):
126 pass
127 # pylint: disable=no-self-use
128 def read(self):
129 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
130 'GERRIT_HOST: True\n')
131
132
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000133class AuthenticatorMock(object):
134 def __init__(self, *_args):
135 pass
136 def has_cached_credentials(self):
137 return True
tandrii221ab252016-10-06 08:12:04 -0700138 def authorize(self, http):
139 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000140
141
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100142def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000143 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
144
145 Usage:
146 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000148
149 OR
150 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100151 CookiesAuthenticatorMockFactory(
152 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000153 """
154 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800155 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000156 # Intentionally not calling super() because it reads actual cookie files.
157 pass
158 @classmethod
159 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000160 return os.path.join('~', '.gitcookies')
161
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162 @classmethod
163 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000164 return os.path.join('~', NETRC_FILENAME)
165
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100166 def _get_auth_for_host(self, host):
167 if same_auth:
168 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000169 return (hosts_with_creds or {}).get(host)
170 return CookiesAuthenticatorMock
171
Aaron Gable9a03ae02017-11-03 11:31:07 -0700172
kmarshall9249e012016-08-23 12:02:16 -0700173class MockChangelistWithBranchAndIssue():
174 def __init__(self, branch, issue):
175 self.branch = branch
176 self.issue = issue
177 def GetBranch(self):
178 return self.branch
179 def GetIssue(self):
180 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000181
tandriic2405f52016-10-10 08:13:15 -0700182
183class SystemExitMock(Exception):
184 pass
185
186
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000187class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000188 def setUp(self):
189 mock.patch('sys.exit', side_effect=SystemExitMock).start()
190 mock.patch('sys.stdout', StringIO()).start()
191 mock.patch('sys.stderr', StringIO()).start()
192 self.addCleanup(mock.patch.stopall)
193
194 def test_die_with_error(self):
195 with self.assertRaises(SystemExitMock):
196 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
197 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
198 self.assertTrue('saving CL description' in sys.stdout.getvalue())
199 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
200 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
201 sys.exit.assert_called_once_with(1)
202
203 def test_die_with_error_no_desc(self):
204 with self.assertRaises(SystemExitMock):
205 git_cl.DieWithError('foo')
206 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
207 self.assertEqual(sys.stdout.getvalue(), '')
208 sys.exit.assert_called_once_with(1)
209
Edward Lemur6c6827c2020-02-06 21:15:18 +0000210 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000211 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100212 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000213 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700214
Edward Lemur61bf4172020-02-24 23:22:37 +0000215 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
216 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
217 def test_get_cl_statuses(self, *_mocks):
218 statuses = [
219 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
220 changes = []
221 for status in statuses:
222 cl = git_cl.Changelist()
223 cl.status = status
224 changes.append(cl)
225
226 actual = set(git_cl.get_cl_statuses(changes, True))
227 self.assertEqual(set(zip(changes, statuses)), actual)
228
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000229 def test_upload_to_non_default_branch_no_retry(self):
230 m = mock.patch('git_cl.Changelist._CMDUploadChange',
231 side_effect=[git_cl.GitPushError(), None]).start()
232 mock.patch('git_cl.Changelist.GetRemoteBranch',
233 return_value=('foo', 'bar')).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000234 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000235 return_value='foo').start()
236 mock.patch('git_cl.gerrit_util.GetProjectHead',
237 return_value='refs/heads/main').start()
238
239 cl = git_cl.Changelist()
240 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000241 options.target_branch = 'refs/heads/bar'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000242 with self.assertRaises(SystemExitMock):
243 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
244
245 # ensure upload is called once
246 self.assertEqual(len(m.mock_calls), 1)
247 sys.exit.assert_called_once_with(1)
248 # option not set as retry didn't happen
249 self.assertFalse(hasattr(options, 'force'))
250 self.assertFalse(hasattr(options, 'edit_description'))
251
252 def test_upload_to_old_default_still_active(self):
253 m = mock.patch('git_cl.Changelist._CMDUploadChange',
254 side_effect=[git_cl.GitPushError(), None]).start()
255 mock.patch('git_cl.Changelist.GetRemoteBranch',
256 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000257 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000258 return_value='foo').start()
259 mock.patch('git_cl.gerrit_util.GetProjectHead',
Josip Sokcevicb631a882021-01-06 18:18:10 +0000260 return_value='refs/heads/master').start()
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000261
262 cl = git_cl.Changelist()
263 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000264 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000265 with self.assertRaises(SystemExitMock):
266 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
267
268 # ensure upload is called once
269 self.assertEqual(len(m.mock_calls), 1)
270 sys.exit.assert_called_once_with(1)
271 # option not set as retry didn't happen
272 self.assertFalse(hasattr(options, 'force'))
273 self.assertFalse(hasattr(options, 'edit_description'))
274
275 def test_upload_to_old_default_retry_on_failure(self):
276 m = mock.patch('git_cl.Changelist._CMDUploadChange',
277 side_effect=[git_cl.GitPushError(), None]).start()
278 mock.patch('git_cl.Changelist.GetRemoteBranch',
279 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000280 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000281 return_value='foo').start()
282 mock.patch('git_cl.gerrit_util.GetProjectHead',
283 return_value='refs/heads/main').start()
284 mock.patch('git_cl.RunGit').start()
285
286 cl = git_cl.Changelist()
287 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000288 options.target_branch = 'refs/heads/master'
289 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
290 # ensure upload is called twice
291 self.assertEqual(len(m.mock_calls), 2)
292 # option overrides on retry
293 self.assertEqual(options.force, True)
294 self.assertEqual(options.edit_description, False)
295
296 def test_upload_to_old_default_retry_on_rollback(self):
297 """Test when default branch migration had to be rolled back to old name"""
298 m = mock.patch('git_cl.Changelist._CMDUploadChange',
299 side_effect=[git_cl.GitPushError(), None]).start()
300 mock.patch('git_cl.Changelist.GetRemoteBranch',
301 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
302 mock.patch('git_cl.Changelist.GetGerritProject',
303 return_value='foo').start()
304 mock.patch('git_cl.gerrit_util.GetProjectHead',
305 return_value='refs/heads/master').start()
306 # GetTargetRef returns new default branch since it has stale remote
307 # information.
308 mock.patch('git_cl.GetTargetRef',
309 return_value='refs/heads/main').start()
310 mock.patch('git_cl.RunGit').start()
311
312 cl = git_cl.Changelist()
313 options = optparse.Values()
314 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000315 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
316 # ensure upload is called twice
317 self.assertEqual(len(m.mock_calls), 2)
318 # option overrides on retry
319 self.assertEqual(options.force, True)
320 self.assertEqual(options.edit_description, False)
321
Edward Lemur61bf4172020-02-24 23:22:37 +0000322 def test_get_cl_statuses_no_changes(self):
323 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
324
325 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
326 @mock.patch('multiprocessing.pool.ThreadPool')
327 def test_get_cl_statuses_timeout(self, *_mocks):
328 changes = [git_cl.Changelist() for _ in range(2)]
329 pool = multiprocessing.pool.ThreadPool()
330 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
331 it.return_value.next.side_effect = [
332 (changes[0], 'lgtm'),
333 multiprocessing.TimeoutError,
334 ]
335
336 actual = list(git_cl.get_cl_statuses(changes, True))
337 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
338
339 @mock.patch('git_cl.Changelist.GetIssueURL')
340 def test_get_cl_statuses_not_finegrained(self, _mock):
341 changes = [git_cl.Changelist() for _ in range(2)]
342 urls = ['some-url', None]
343 git_cl.Changelist.GetIssueURL.side_effect = urls
344
345 actual = set(git_cl.get_cl_statuses(changes, False))
346 self.assertEqual(
347 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
348
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000349 def test_get_issue_url(self):
350 cl = git_cl.Changelist(issue=123)
351 cl._gerrit_server = 'https://example.com'
352 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
353 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
354
355 cl = git_cl.Changelist(issue=123)
356 cl._gerrit_server = 'https://chromium-review.googlesource.com'
357 self.assertEqual(cl.GetIssueURL(),
358 'https://chromium-review.googlesource.com/123')
359 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
360
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000361 def test_set_preserve_tryjobs(self):
362 d = git_cl.ChangeDescription('Simple.')
363 d.set_preserve_tryjobs()
364 self.assertEqual(d.description.splitlines(), [
365 'Simple.',
366 '',
367 'Cq-Do-Not-Cancel-Tryjobs: true',
368 ])
369 before = d.description
370 d.set_preserve_tryjobs()
371 self.assertEqual(before, d.description)
372
373 d = git_cl.ChangeDescription('\n'.join([
374 'One is enough',
375 '',
376 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
377 'Change-Id: Ideadbeef',
378 ]))
379 d.set_preserve_tryjobs()
380 self.assertEqual(d.description.splitlines(), [
381 'One is enough',
382 '',
383 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
384 'Change-Id: Ideadbeef',
385 'Cq-Do-Not-Cancel-Tryjobs: true',
386 ])
387
tandriif9aefb72016-07-01 09:06:51 -0700388 def test_get_bug_line_values(self):
389 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
390 self.assertEqual(f('', ''), [])
391 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
Lei Zhang8a0efc12020-08-05 19:58:45 +0000392 # Prefix that ends with colon.
393 self.assertEqual(f('v8:', '456'), ['v8:456'])
394 self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
395 # Prefix that ends without colon.
tandriif9aefb72016-07-01 09:06:51 -0700396 self.assertEqual(f('v8', '456'), ['v8:456'])
397 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
398 # Not nice, but not worth carying.
Lei Zhang8a0efc12020-08-05 19:58:45 +0000399 self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
400 ['v8:456', 'chromium:123', 'v8:123'])
tandriif9aefb72016-07-01 09:06:51 -0700401 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
402 ['v8:456', 'chromium:123', 'v8:123'])
403
Edward Lemurda4b6c62020-02-13 00:28:40 +0000404 @mock.patch('gerrit_util.GetAccountDetails')
405 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000406 mock_per_account = {
407 'u1': None, # 404, doesn't exist.
408 'u2': {
409 '_account_id': 123124,
410 'avatars': [],
411 'email': 'u2@example.com',
412 'name': 'User Number 2',
413 'status': 'OOO',
414 },
415 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
416 }
417 def GetAccountDetailsMock(_, account):
418 # Poor-man's mock library's side_effect.
419 v = mock_per_account.pop(account)
420 if isinstance(v, Exception):
421 raise v
422 return v
423
Edward Lemurda4b6c62020-02-13 00:28:40 +0000424 mockGetAccountDetails.side_effect = GetAccountDetailsMock
425 actual = git_cl.gerrit_util.ValidAccounts(
426 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000427 self.assertEqual(actual, {
428 'u2': {
429 '_account_id': 123124,
430 'avatars': [],
431 'email': 'u2@example.com',
432 'name': 'User Number 2',
433 'status': 'OOO',
434 },
435 })
436
437
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200438class TestParseIssueURL(unittest.TestCase):
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000439 def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
440 parsed = git_cl.ParseIssueNumberArgument(arg)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200441 self.assertIsNotNone(parsed)
442 if fail:
443 self.assertFalse(parsed.valid)
444 return
445 self.assertTrue(parsed.valid)
446 self.assertEqual(parsed.issue, issue)
447 self.assertEqual(parsed.patchset, patchset)
448 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200449
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000450 def test_basic(self):
451 self._test('123', 123)
452 self._test('', fail=True)
453 self._test('abc', fail=True)
454 self._test('123/1', fail=True)
455 self._test('123a', fail=True)
456 self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
457 self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200458
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000459 def test_gerrit_url(self):
460 self._test('https://codereview.source.com/123', 123, None,
461 'codereview.source.com')
462 self._test('http://chrome-review.source.com/c/123', 123, None,
463 'chrome-review.source.com')
464 self._test('https://chrome-review.source.com/c/123/', 123, None,
465 'chrome-review.source.com')
466 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
467 'chrome-review.source.com')
468 self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
469 'chrome-review.source.com')
470 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
471 'chrome-review.source.com')
472 self._test('https://chrome-review.source.com/123', 123, None,
473 'chrome-review.source.com')
474 self._test('https://chrome-review.source.com/123/4', 123, 4,
475 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200476
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000477 self._test('https://chrome-review.source.com/bad/123/4', fail=True)
478 self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
479 self._test('https://chrome-review.source.com/c/abc/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000481 def test_short_urls(self):
482 self._test('https://crrev.com/c/2151934', 2151934, None,
483 'chromium-review.googlesource.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200484
485
Edward Lemurda4b6c62020-02-13 00:28:40 +0000486class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100487 def setUp(self):
488 super(GitCookiesCheckerTest, self).setUp()
489 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100490 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000491 mock.patch('sys.stdout', StringIO()).start()
492 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100493
494 def mock_hosts_creds(self, subhost_identity_pairs):
495 def ensure_googlesource(h):
496 if not h.endswith(self.c._GOOGLESOURCE):
497 assert not h.endswith('.')
498 return h + '.' + self.c._GOOGLESOURCE
499 return h
500 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
501 for h, i in subhost_identity_pairs]
502
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200503 def test_identity_parsing(self):
504 self.assertEqual(self.c._parse_identity('ldap.google.com'),
505 ('ldap', 'google.com'))
506 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
507 ('ldap', 'example.com'))
508 # Specical case because we know there are no subdomains in chromium.org.
509 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
510 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800511 # Pathological: ".period." can be either username OR domain, more likely
512 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200513 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
514 ('note', 'period.example.com'))
515
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100516 def test_analysis_nothing(self):
517 self.c._all_hosts = []
518 self.assertFalse(self.c.has_generic_host())
519 self.assertEqual(set(), self.c.get_conflicting_hosts())
520 self.assertEqual(set(), self.c.get_duplicated_hosts())
521 self.assertEqual(set(), self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100522
523 def test_analysis(self):
524 self.mock_hosts_creds([
525 ('.googlesource.com', 'git-example.chromium.org'),
526
527 ('chromium', 'git-example.google.com'),
528 ('chromium-review', 'git-example.google.com'),
529 ('chrome-internal', 'git-example.chromium.org'),
530 ('chrome-internal-review', 'git-example.chromium.org'),
531 ('conflict', 'git-example.google.com'),
532 ('conflict-review', 'git-example.chromium.org'),
533 ('dup', 'git-example.google.com'),
534 ('dup', 'git-example.google.com'),
535 ('dup-review', 'git-example.google.com'),
536 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200537 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100538 ])
539 self.assertTrue(self.c.has_generic_host())
540 self.assertEqual(set(['conflict.googlesource.com']),
541 self.c.get_conflicting_hosts())
542 self.assertEqual(set(['dup.googlesource.com']),
543 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200544 self.assertEqual(set(['partial.googlesource.com',
545 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100546 self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100547
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100548 def test_report_no_problems(self):
549 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100550 self.assertFalse(self.c.find_and_report_problems())
551 self.assertEqual(sys.stdout.getvalue(), '')
552
Edward Lemurda4b6c62020-02-13 00:28:40 +0000553 @mock.patch(
554 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000555 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000556 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100557 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100558 self.assertTrue(self.c.find_and_report_problems())
559 with open(os.path.join(os.path.dirname(__file__),
560 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000561 expected = f.read() % {
562 'sep': os.sep,
563 }
564
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100565 def by_line(text):
566 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700567 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200568 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100569
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800570
Edward Lemurda4b6c62020-02-13 00:28:40 +0000571class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000572 def setUp(self):
573 super(TestGitCl, self).setUp()
574 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700575 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000576 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000577 mock.patch('sys.stdout', StringIO()).start()
578 mock.patch(
579 'git_cl.time_time',
580 lambda: self._mocked_call('time.time')).start()
581 mock.patch(
582 'git_cl.metrics.collector.add_repeated',
583 lambda *a: self._mocked_call('add_repeated', *a)).start()
584 mock.patch('subprocess2.call', self._mocked_call).start()
585 mock.patch('subprocess2.check_call', self._mocked_call).start()
586 mock.patch('subprocess2.check_output', self._mocked_call).start()
587 mock.patch(
588 'subprocess2.communicate',
589 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
590 mock.patch(
591 'git_cl.gclient_utils.CheckCallAndFilter',
592 self._mocked_call).start()
593 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
Stephen Martinis1c3c9392021-01-07 02:42:33 +0000594 mock.patch(
595 'git_common.get_or_create_merge_base',
596 lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000597 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
598 mock.patch(
599 'git_cl.SaveDescriptionBackup',
600 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
601 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000602 'git_cl.write_json',
603 lambda *a: self._mocked_call('write_json', *a)).start()
604 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000605 'git_cl.Changelist.RunHook',
606 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000607 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
608 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000609 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000610 mock.patch(
611 'git_cl.gerrit_util.GetChangeComments',
612 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
613 mock.patch(
614 'git_cl.gerrit_util.GetChangeRobotComments',
615 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
616 mock.patch(
617 'git_cl.gerrit_util.AddReviewers',
618 lambda *a: self._mocked_call('AddReviewers', *a)).start()
619 mock.patch(
620 'git_cl.gerrit_util.SetReview',
621 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
622 self._mocked_call(
623 'SetReview', h, i, msg, labels, notify, ready))).start()
624 mock.patch(
625 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
626 return_value=False).start()
627 mock.patch(
628 'git_cl.gerrit_util.GceAuthenticator.is_gce',
629 return_value=False).start()
630 mock.patch(
631 'git_cl.gerrit_util.ValidAccounts',
632 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000633 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000634 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000635 self.mockGit = GitMocks()
636 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
637 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
Edward Lesmes50da7702020-03-30 19:23:43 +0000638 mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
639 mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
Edward Lemur85153282020-02-14 22:06:29 +0000640 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000641 mock.patch(
642 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000643 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000644 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000645 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000646 mock.patch(
647 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000648 # It's important to reset settings to not have inter-tests interference.
649 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000650 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000651
652 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000653 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000654 if not self.failed:
655 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100656 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000657 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
658 if len(self.calls) > 5:
659 calls += ' ...\n'
660 self.fail(
661 '\n'
662 'There are un-consumed calls after this test has finished:\n' +
663 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000664 finally:
665 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000666
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000667 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000668 self.assertTrue(
669 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700670 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000671 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000672 expected_args, result = top
673
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000674 # Also logs otherwise it could get caught in a try/finally and be hard to
675 # diagnose.
676 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700677 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000678 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700679 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
680 for i, c in enumerate(self._calls_done[-N:]))
681 following_calls = '\n '.join(
682 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
683 for i, c in enumerate(self.calls[:N]))
684 extended_msg = (
685 'A few prior calls:\n %s\n\n'
686 'This (expected):\n @%d: %r\n'
687 'This (actual):\n @%d: %r\n\n'
688 'A few following expected calls:\n %s' %
689 (prior_calls, len(self._calls_done), expected_args,
690 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700691
Edward Lesmes0dd54822020-03-26 18:24:25 +0000692 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700693 self.fail('@%d\n'
694 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000695 ' Actual: %r\n'
696 '\n'
697 '%s' % (
698 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700699
700 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700701 if isinstance(result, Exception):
702 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000703 # stdout from git commands is supposed to be a bytestream. Convert it here
704 # instead of converting all test output in this file to bytes.
705 if args[0][0] == 'git' and not isinstance(result, bytes):
706 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000707 return result
708
Edward Lemur1a83da12020-03-04 21:18:36 +0000709 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
710 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100711 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100712 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000713 self.assertEqual(
714 'prompt [Yes/No]: Please, type yes or no: ',
715 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100716
tandrii48df5812016-10-17 03:55:37 -0700717 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000718 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700719 self.calls = [
720 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700721 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
722 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
723 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
724 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700725 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
726 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700727 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
728 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000729 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
730 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700731 ((['git', 'config', 'gerrit.host', 'true'],), ''),
732 ]
733 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
734
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000735 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100736 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200737 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000738 custom_cl_base=None, short_hostname='chromium',
Stephen Martinis1c3c9392021-01-07 02:42:33 +0000739 change_id=None, new_default=False):
Edward Lemur26964072020-02-19 19:18:51 +0000740 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200741 if custom_cl_base:
742 ancestor_revision = custom_cl_base
743 else:
744 # Determine ancestor_revision to be merge base.
Stephen Martinis1c3c9392021-01-07 02:42:33 +0000745 ancestor_revision = 'fake_ancestor_sha'
746 calls += [
747 (('get_or_create_merge_base', 'master',
748 'refs/remotes/origin/master'), ancestor_revision),
749 ]
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200750
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100751 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000752 gerrit_util.GetChangeDetail.return_value = {
753 'owner': {'email': (other_cl_owner or 'owner@example.com')},
754 'change_id': (change_id or '123456789'),
755 'current_revision': 'sha1_of_current_revision',
756 'revisions': {'sha1_of_current_revision': {
757 'commit': {'message': fetched_description},
758 }},
759 'status': fetched_status or 'NEW',
760 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100761 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100762 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100763 if other_cl_owner:
764 calls += [
765 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
766 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100767
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100768 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200769 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
770 ([custom_cl_base] if custom_cl_base else
771 [ancestor_revision, 'HEAD']),),
772 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100773 ]
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000774 calls += [
775 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
Stephen Martinis1c3c9392021-01-07 02:42:33 +0000776 '1' if new_default else callError(1)),
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000777 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000778
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100779 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000780
Edward Lemur26964072020-02-19 19:18:51 +0000781 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700782 squash_mode='default',
Aaron Gablefd238082017-06-07 13:42:34 -0700783 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100784 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000785 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000786 short_hostname='chromium',
Edward Lemur5a644f82020-03-18 16:44:57 +0000787 labels=None, change_id=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000788 final_description=None, gitcookies_exists=True,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000789 force=False, edit_description=None,
Stephen Martinis1c3c9392021-01-07 02:42:33 +0000790 new_default=False):
791 default_branch = 'main' if new_default else 'master';
tandrii@chromium.org10625002016-03-04 20:03:47 +0000792 if post_amend_description is None:
793 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700794 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200795
796 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000797
Edward Lesmes4de54132020-05-05 19:41:33 +0000798 if squash_mode in ('override_squash', 'override_nosquash'):
799 self.mockGit.config['gerrit.override-squash-uploads'] = (
800 'true' if squash_mode == 'override_squash' else 'false')
801
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000802 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000803 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200804 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200805 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000806 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000807 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000808 calls += [
809 ((['RunEditor'],), description),
810 ]
Josipe827b0f2020-01-30 00:07:20 +0000811 # user wants to edit description
812 if edit_description:
813 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000814 ((['RunEditor'],), edit_description),
815 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000816 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200817
818 if custom_cl_base is None:
Stephen Martinis1c3c9392021-01-07 02:42:33 +0000819 calls += [
820 (('get_or_create_merge_base', 'master',
821 'refs/remotes/origin/master'), 'origin/' + default_branch),
822 ]
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000823 parent = 'origin/' + default_branch
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200824 else:
825 calls += [
826 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000827 'refs/remotes/origin/' + default_branch],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200828 callError(1)), # Means not ancenstor.
829 (('ask_for_data',
830 'Do you take responsibility for cleaning up potential mess '
831 'resulting from proceeding with upload? Press Enter to upload, '
832 'or Ctrl+C to abort'), ''),
833 ]
834 parent = custom_cl_base
835
836 calls += [
837 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
838 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000839 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200840 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000841 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200842 ref_to_push),
843 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000844 else:
845 ref_to_push = 'HEAD'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000846 parent = 'origin/refs/heads/' + default_branch
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000847
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000848 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000849 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000850 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200851 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000852
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000853 metrics_arguments = []
854
Aaron Gableafd52772017-06-27 16:40:10 -0700855 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700856 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000857 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700858 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400859 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700860 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000861 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700862 else:
863 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000864 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800865
Edward Lemur5a644f82020-03-18 16:44:57 +0000866 # If issue is given, then description is fetched from Gerrit instead.
867 if issue is None:
868 if squash:
869 title = 'Initial upload'
870 else:
871 if not title:
872 calls += [
873 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
874 (('ask_for_data', 'Title for patchset []: '), 'User input'),
875 ]
876 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700877 if title:
Edward Lemur5a644f82020-03-18 16:44:57 +0000878 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000879 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000880
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000881 if short_hostname == 'chromium':
Quinten Yearsley925cedb2020-04-13 17:49:39 +0000882 # All reviewers and ccs get into ref_suffix.
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000883 for r in sorted(reviewers):
884 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000885 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000886 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000887 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000888 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000889 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000890 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000891 reviewers, cc = [], []
892 else:
893 # TODO(crbug/877717): remove this case.
894 calls += [
895 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
896 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000897 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000898 {
899 e: {'email': e}
900 for e in (reviewers + ['joe@example.com'] + cc)
901 })
902 ]
903 for r in sorted(reviewers):
904 if r != 'bad-account-or-email':
905 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000906 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000907 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000908 if issue is None:
909 cc += ['joe@example.com']
910 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000911 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000912 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000913 if c in cc:
914 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000915
Edward Lemur687ca902018-12-05 02:30:30 +0000916 for k, v in sorted((labels or {}).items()):
917 ref_suffix += ',l=%s+%d' % (k, v)
918 metrics_arguments.append('l=%s+%d' % (k, v))
919
920 if tbr:
921 calls += [
922 (('GetCodeReviewTbrScore',
923 '%s-review.googlesource.com' % short_hostname,
924 'my/repo'),
925 2,),
926 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000927
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000928 calls += [
929 (('time.time',), 1000,),
930 ((['git', 'push',
931 'https://%s.googlesource.com/my/repo' % short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000932 ref_to_push + ':refs/for/refs/heads/' + default_branch + ref_suffix],),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000933 (('remote:\n'
934 'remote: Processing changes: (\)\n'
935 'remote: Processing changes: (|)\n'
936 'remote: Processing changes: (/)\n'
937 'remote: Processing changes: (-)\n'
938 'remote: Processing changes: new: 1 (/)\n'
939 'remote: Processing changes: new: 1, done\n'
940 'remote:\n'
941 'remote: New Changes:\n'
942 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
943 ' XXX\n'
944 'remote:\n'
945 'To https://%s.googlesource.com/my/repo\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000946 ' * [new branch] hhhh -> refs/for/refs/heads/%s\n'
947 ) % (short_hostname, short_hostname, default_branch)),),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000948 (('time.time',), 2000,),
949 (('add_repeated',
950 'sub_commands',
951 {
952 'execution_time': 1000,
953 'command': 'git push',
954 'exit_code': 0,
955 'arguments': sorted(metrics_arguments),
956 }),
957 None,),
958 ]
959
Edward Lemur1b52d872019-05-09 21:12:12 +0000960 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000961
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000962 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
963
Edward Lemur1b52d872019-05-09 21:12:12 +0000964 # Trace-related calls
965 calls += [
966 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000967 (
968 ([
969 'FileWrite', trace_name + '-README',
970 '%(date)s\n'
971 '%(short_hostname)s-review.googlesource.com\n'
972 '%(change_id)s\n'
973 '%(title)s\n'
974 '%(description)s\n'
975 '1000\n'
976 '0\n'
977 '%(trace_name)s' % {
Josip Sokcevic5e18b602020-04-23 21:47:00 +0000978 'date': '2017-03-16T20:00:41.000000',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000979 'short_hostname': short_hostname,
980 'change_id': change_id,
981 'description': final_description,
982 'title': title or '<untitled>',
983 'trace_name': trace_name,
984 }
985 ], ),
986 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000987 ),
988 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000989 (
990 (['os.path.isfile',
991 os.path.join('TEMP_DIR', 'trace-packet')], ),
992 True,
Edward Lemur1b52d872019-05-09 21:12:12 +0000993 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000994 (
995 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
996 ('git-hash: 0123456789012345678901234567890123456789\n'
997 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +0000998 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000999 (
1000 ([
1001 'FileWrite',
1002 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
1003 'git-hash: abcdea\n'
1004 ], ),
1005 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001006 ),
1007 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001008 (
1009 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
1010 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001011 ),
1012 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001013 (
1014 (['git', 'config', '-l'], ),
1015 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +00001016 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001017 (
1018 ([
1019 'FileWrite',
1020 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
1021 ], ),
1022 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001023 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001024 (
1025 (['os.path.isfile',
1026 os.path.join('~', '.gitcookies')], ),
1027 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +00001028 ),
1029 ]
1030 if gitcookies_exists:
1031 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001032 (
1033 (['FileRead', os.path.join('~', '.gitcookies')], ),
1034 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +00001035 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001036 (
1037 ([
1038 'FileWrite',
1039 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
1040 ], ),
1041 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001042 ),
1043 ]
1044 calls += [
1045 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001046 (
1047 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
1048 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001049 ),
1050 ]
1051
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001052 # TODO(crbug/877717): this should never be used.
1053 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001054 calls += [
1055 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001056 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001057 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001058 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001059 notify),
1060 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001061 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001062 return calls
1063
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001064 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001065 self,
1066 upload_args,
1067 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001068 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001069 squash=True,
1070 squash_mode=None,
Aaron Gable9b713dd2016-12-14 16:04:21 -08001071 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001072 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001073 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001074 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001075 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001076 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001077 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001078 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001079 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001080 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001081 labels=None,
1082 change_id=None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001083 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001084 gitcookies_exists=True,
1085 force=False,
Edward Lesmes0dd54822020-03-26 18:24:25 +00001086 log_description=None,
Josipe827b0f2020-01-30 00:07:20 +00001087 edit_description=None,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001088 fetched_description=None,
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001089 new_default=False):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001090 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001091 if squash_mode is None:
1092 if '--no-squash' in upload_args:
1093 squash_mode = 'nosquash'
1094 elif '--squash' in upload_args:
1095 squash_mode = 'squash'
1096 else:
1097 squash_mode = 'default'
1098
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001099 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001100 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001101 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001102 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001103 same_auth=('git-owner.example.com', '', 'pass'))).start()
1104 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1105 lambda _, offer_removal: None).start()
1106 mock.patch('git_cl.gclient_utils.RunEditor',
1107 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1108 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001109 'DownloadGerritHook', force)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001110 mock.patch('git_cl.gclient_utils.FileRead',
1111 lambda path: self._mocked_call(['FileRead', path])).start()
1112 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001113 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001114 ['FileWrite', path, contents])).start()
1115 mock.patch('git_cl.datetime_now',
1116 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1117 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1118 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1119 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001120 '%(now)s\n'
1121 '%(gerrit_host)s\n'
1122 '%(change_id)s\n'
1123 '%(title)s\n'
1124 '%(description)s\n'
1125 '%(execution_time)s\n'
1126 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001127 '%(trace_name)s').start()
1128 mock.patch('git_cl.shutil.make_archive',
1129 lambda *args: self._mocked_call(['make_archive'] +
1130 list(args))).start()
1131 mock.patch('os.path.isfile',
1132 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001133 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001134 'git_cl._create_description_from_log',
1135 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001136 mock.patch(
1137 'git_cl.Changelist._AddChangeIdToCommitMessage',
1138 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001139 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001140 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1141 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001142 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001143 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001144
Edward Lemur26964072020-02-19 19:18:51 +00001145 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001146 self.mockGit.config['branch.master.gerritissue'] = (
1147 str(issue) if issue else None)
1148 self.mockGit.config['remote.origin.url'] = (
1149 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001150 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001151
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001152 self.calls = self._gerrit_base_calls(
1153 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001154 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001155 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001156 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001157 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001158 short_hostname=short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001159 change_id=change_id,
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001160 new_default=new_default)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001161 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001162 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001163 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001164 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001165 self.calls += self._gerrit_upload_calls(
1166 description, reviewers, squash,
1167 squash_mode=squash_mode,
Aaron Gablefd238082017-06-07 13:42:34 -07001168 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001169 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001170 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001171 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001172 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001173 labels=labels,
1174 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001175 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001176 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001177 force=force,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001178 edit_description=edit_description,
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001179 new_default=new_default)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001180 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001181 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001182 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001183 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001184 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001185 self.assertEqual(
1186 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001187 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001188
Edward Lemur1b52d872019-05-09 21:12:12 +00001189 def test_gerrit_upload_traces_no_gitcookies(self):
1190 self._run_gerrit_upload_test(
1191 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001192 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001193 [],
1194 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001195 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001196 change_id='Ixxx',
1197 gitcookies_exists=False)
1198
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001199 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001200 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001201 [],
1202 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1203 [],
1204 change_id='Ixxx')
1205
1206 def test_gerrit_upload_without_change_id_nosquash(self):
1207 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001208 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001209 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001210 [],
1211 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001212 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001213 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001214
Edward Lesmes4de54132020-05-05 19:41:33 +00001215 def test_gerrit_upload_without_change_id_override_nosquash(self):
1216 self._run_gerrit_upload_test(
1217 [],
1218 'desc ✔\n\nBUG=\n',
1219 [],
1220 squash=False,
1221 squash_mode='override_nosquash',
1222 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1223 change_id='Ixxx')
1224
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001225 def test_gerrit_no_reviewer(self):
1226 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001227 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001228 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001229 [],
1230 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001231 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001232 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001233
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001234 def test_gerrit_no_reviewer_non_chromium_host(self):
1235 # TODO(crbug/877717): remove this test case.
1236 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001237 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001238 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001239 [],
1240 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001241 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001242 short_hostname='other',
1243 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001244
Edward Lesmes0dd54822020-03-26 18:24:25 +00001245 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001246 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001247 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001248 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001249 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001250 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001251 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001252 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001253
ukai@chromium.orge8077812012-02-03 03:41:46 +00001254 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001255 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001256 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001257 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001258 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001259 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001260 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001261 notify=True,
1262 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001263 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001264 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001265
Anthony Polito8b955342019-09-24 19:01:36 +00001266 def test_gerrit_upload_force_sets_bug(self):
1267 self._run_gerrit_upload_test(
1268 ['-b', '10000', '-f'],
1269 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1270 [],
1271 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001272 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001273 change_id='Ixxx')
1274
Edward Lemur5fb22242020-03-12 22:05:13 +00001275 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001276 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001277 ['-b', '10000', '-m', 'Title', '--edit-description'],
1278 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001279 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001280 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001281 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001282 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001283 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001284 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001285
Dan Beamd8b04ca2019-10-10 21:23:26 +00001286 def test_gerrit_upload_force_sets_fixed(self):
1287 self._run_gerrit_upload_test(
1288 ['-x', '10000', '-f'],
1289 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1290 [],
1291 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001292 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001293 change_id='Ixxx')
1294
ukai@chromium.orge8077812012-02-03 03:41:46 +00001295 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001296 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1297 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001298 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001299 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001300 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001301 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001302 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001303 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001304 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001305 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001306 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001307 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001308
1309 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001310 self._run_gerrit_upload_test(
1311 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001312 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001313 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001314 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001315
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001316 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001317 self._run_gerrit_upload_test(
1318 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001319 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001320 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001321 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001322 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001323
Edward Lesmes0dd54822020-03-26 18:24:25 +00001324 def test_gerrit_upload_squash_first_title(self):
1325 self._run_gerrit_upload_test(
1326 ['-f', '-t', 'title'],
1327 'title\n\ndesc\n\nChange-Id: 123456789',
1328 [],
1329 force=True,
1330 squash=True,
1331 log_description='desc',
1332 change_id='123456789')
1333
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001334 def test_gerrit_upload_squash_first_with_labels(self):
1335 self._run_gerrit_upload_test(
1336 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001337 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001338 [],
1339 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001340 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001341 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001342
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001343 def test_gerrit_upload_squash_first_against_rev(self):
1344 custom_cl_base = 'custom_cl_base_rev_or_branch'
1345 self._run_gerrit_upload_test(
1346 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001347 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001348 [],
1349 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001350 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001351 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001352 self.assertIn(
1353 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1354 sys.stdout.getvalue())
1355
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001356 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001357 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001358 self._run_gerrit_upload_test(
1359 ['--squash'],
1360 description,
1361 [],
1362 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001363 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001364 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001365
Edward Lemurd55c5072020-02-20 01:09:07 +00001366 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001367 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001368 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001369 with self.assertRaises(SystemExitMock):
1370 self._run_gerrit_upload_test(
1371 ['--squash'],
1372 description,
1373 [],
1374 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001375 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001376 fetched_status='ABANDONED',
1377 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001378 self.assertEqual(
1379 'Change https://chromium-review.googlesource.com/123456 has been '
1380 'abandoned, new uploads are not allowed\n',
1381 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001382
Edward Lemurda4b6c62020-02-13 00:28:40 +00001383 @mock.patch(
1384 'gerrit_util.GetAccountDetails',
1385 return_value={'email': 'yet-another@example.com'})
1386 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001387 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001388 self._run_gerrit_upload_test(
1389 ['--squash'],
1390 description,
1391 [],
1392 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001393 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001394 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001395 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001396 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001397 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001398 'authenticate to Gerrit as yet-another@example.com.\n'
1399 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001400 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001401
Josipe827b0f2020-01-30 00:07:20 +00001402 def test_upload_change_description_editor(self):
1403 fetched_description = 'foo\n\nChange-Id: 123456789'
1404 description = 'bar\n\nChange-Id: 123456789'
1405 self._run_gerrit_upload_test(
1406 ['--squash', '--edit-description'],
1407 description,
1408 [],
1409 fetched_description=fetched_description,
1410 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001411 issue=123456,
1412 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001413 edit_description=description)
1414
Edward Lemurda4b6c62020-02-13 00:28:40 +00001415 @mock.patch('git_cl.RunGit')
1416 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001417 @mock.patch('sys.stdin', StringIO('\n'))
1418 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001419 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001420 def mock_run_git(*args, **_kwargs):
1421 if args[0] == ['for-each-ref',
1422 '--format=%(refname:short) %(upstream:short)',
1423 'refs/heads']:
1424 # Create a local branch dependency tree that looks like this:
1425 # test1 -> test2 -> test3 -> test4 -> test5
1426 # -> test3.1
1427 # test6 -> test0
1428 branch_deps = [
1429 'test2 test1', # test1 -> test2
1430 'test3 test2', # test2 -> test3
1431 'test3.1 test2', # test2 -> test3.1
1432 'test4 test3', # test3 -> test4
1433 'test5 test4', # test4 -> test5
1434 'test6 test0', # test0 -> test6
1435 'test7', # test7
1436 ]
1437 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001438 git_cl.RunGit.side_effect = mock_run_git
1439 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001440
1441 class MockChangelist():
1442 def __init__(self):
1443 pass
1444 def GetBranch(self):
1445 return 'test1'
1446 def GetIssue(self):
1447 return '123'
1448 def GetPatchset(self):
1449 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001450 def IsGerrit(self):
1451 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001452
1453 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1454 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001455 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001456 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001457 'This command will checkout all dependent branches '
1458 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001459 'or Ctrl+C to abort',
1460 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001461 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001462
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001463 def test_gerrit_change_id(self):
1464 self.calls = [
1465 ((['git', 'write-tree'], ),
1466 'hashtree'),
1467 ((['git', 'rev-parse', 'HEAD~0'], ),
1468 'branch-parent'),
1469 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1470 'A B <a@b.org> 1456848326 +0100'),
1471 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1472 'C D <c@d.org> 1456858326 +0100'),
1473 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1474 'hashchange'),
1475 ]
1476 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1477 self.assertEqual(change_id, 'Ihashchange')
1478
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001479 def test_desecription_append_footer(self):
1480 for init_desc, footer_line, expected_desc in [
1481 # Use unique desc first lines for easy test failure identification.
1482 ('foo', 'R=one', 'foo\n\nR=one'),
1483 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1484 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1485 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1486 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1487 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1488 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1489 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1490 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1491 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1492 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1493 ]:
1494 desc = git_cl.ChangeDescription(init_desc)
1495 desc.append_footer(footer_line)
1496 self.assertEqual(desc.description, expected_desc)
1497
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001498 def test_update_reviewers(self):
1499 data = [
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001500 ('foo', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001501 'foo'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001502 ('foo\nR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001503 'foo\nR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001504 ('foo\nTBR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001505 'foo\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001506 ('foo', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001507 'foo\n\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001508 ('foo\nR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001509 'foo\n\nR=a@c, xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001510 ('foo\nTBR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001511 'foo\n\nR=a@c\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001512 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001513 'foo\n\nR=a@c, yy\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001514 ('foo\nBUG=', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001515 'foo\nBUG=\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001516 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001517 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001518 ('foo', ['a@c', 'b@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001519 'foo\n\nR=a@c, b@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001520 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001521 'foo\nBar\n\nR=c@c\nBUG='),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001522 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001523 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001524 # Same as the line before, but full of whitespaces.
1525 (
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001526 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001527 'foo\nBar\n\nR=c@c\n BUG =',
1528 ),
1529 # Whitespaces aren't interpreted as new lines.
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001530 ('foo BUG=allo R=joe ', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001531 'foo BUG=allo R=joe\n\nR=c@c'),
1532 # Redundant TBRs get promoted to Rs
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001533 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001534 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001535 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001536 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001537 actual = []
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001538 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001539 obj = git_cl.ChangeDescription(orig)
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001540 obj.update_reviewers(reviewers, tbrs, None, None, None)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001541 actual.append(obj.description)
1542 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001543
Nodir Turakulov23b82142017-11-16 11:04:25 -08001544 def test_get_hash_tags(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001545 self.calls = [
1546 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
1547 callError(1)),
1548 ] * 9
Nodir Turakulov23b82142017-11-16 11:04:25 -08001549 cases = [
1550 ('', []),
1551 ('a', []),
1552 ('[a]', ['a']),
1553 ('[aa]', ['aa']),
1554 ('[a ]', ['a']),
1555 ('[a- ]', ['a']),
1556 ('[a- b]', ['a-b']),
1557 ('[a--b]', ['a-b']),
1558 ('[a', []),
1559 ('[a]x', ['a']),
1560 ('[aa]x', ['aa']),
1561 ('[a b]', ['a-b']),
1562 ('[a b]', ['a-b']),
1563 ('[a__b]', ['a-b']),
1564 ('[a] x', ['a']),
1565 ('[a][b]', ['a', 'b']),
1566 ('[a] [b]', ['a', 'b']),
1567 ('[a][b]x', ['a', 'b']),
1568 ('[a][b] x', ['a', 'b']),
1569 ('[a]\n[b]', ['a']),
1570 ('[a\nb]', []),
1571 ('[a][', ['a']),
1572 ('Revert "[a] feature"', ['a']),
1573 ('Reland "[a] feature"', ['a']),
1574 ('Revert: [a] feature', ['a']),
1575 ('Reland: [a] feature', ['a']),
1576 ('Revert "Reland: [a] feature"', ['a']),
1577 ('Foo: feature', ['foo']),
1578 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001579 ('Change Foo::Bar', []),
1580 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001581 ('Revert "Foo bar: feature"', ['foo-bar']),
1582 ('Reland "Foo bar: feature"', ['foo-bar']),
1583 ]
1584 for desc, expected in cases:
1585 change_desc = git_cl.ChangeDescription(desc)
1586 actual = change_desc.get_hash_tags()
1587 self.assertEqual(
1588 actual,
1589 expected,
1590 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1591
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001592 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001593 self.assertEqual(None, git_cl.GetTargetRef(None,
1594 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001595 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001596
wittman@chromium.org455dc922015-01-26 20:15:50 +00001597 # Check default target refs for branches.
1598 self.assertEqual('refs/heads/master',
1599 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001600 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001601 self.assertEqual('refs/heads/master',
1602 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001603 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001604 self.assertEqual('refs/heads/master',
1605 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001606 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001607 self.assertEqual('refs/branch-heads/123',
1608 git_cl.GetTargetRef('origin',
1609 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001610 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001611 self.assertEqual('refs/diff/test',
1612 git_cl.GetTargetRef('origin',
1613 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001614 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001615 self.assertEqual('refs/heads/chrome/m42',
1616 git_cl.GetTargetRef('origin',
1617 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001618 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001619
1620 # Check target refs for user-specified target branch.
1621 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1622 'refs/remotes/branch-heads/123'):
1623 self.assertEqual('refs/branch-heads/123',
1624 git_cl.GetTargetRef('origin',
1625 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001626 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001627 for branch in ('origin/master', 'remotes/origin/master',
1628 'refs/remotes/origin/master'):
1629 self.assertEqual('refs/heads/master',
1630 git_cl.GetTargetRef('origin',
1631 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001632 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001633 for branch in ('master', 'heads/master', 'refs/heads/master'):
1634 self.assertEqual('refs/heads/master',
1635 git_cl.GetTargetRef('origin',
1636 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001637 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001638
Edward Lemurda4b6c62020-02-13 00:28:40 +00001639 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1640 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001641 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001642 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1643
Edward Lemur85153282020-02-14 22:06:29 +00001644 def assertIssueAndPatchset(
1645 self, branch='master', issue='123456', patchset='7',
1646 git_short_host='chromium'):
1647 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001648 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001649 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001650 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001651 self.assertEqual(
1652 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001653 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001654
Edward Lemur85153282020-02-14 22:06:29 +00001655 def _patch_common(self, git_short_host='chromium'):
Edward Lesmes50da7702020-03-30 19:23:43 +00001656 mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
Edward Lemur26964072020-02-19 19:18:51 +00001657 self.mockGit.config['remote.origin.url'] = (
1658 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001659 gerrit_util.GetChangeDetail.return_value = {
1660 'current_revision': '7777777777',
1661 'revisions': {
1662 '1111111111': {
1663 '_number': 1,
1664 'fetch': {'http': {
1665 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1666 'ref': 'refs/changes/56/123456/1',
1667 }},
1668 },
1669 '7777777777': {
1670 '_number': 7,
1671 'fetch': {'http': {
1672 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1673 'ref': 'refs/changes/56/123456/7',
1674 }},
1675 },
1676 },
1677 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001678
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001679 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001680 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001681 self.calls += [
1682 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1683 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001684 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001685 ]
1686 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001687 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001688
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001689 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001690 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001691 self.calls += [
1692 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1693 'refs/changes/56/123456/7'],), ''),
1694 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001695 ]
Edward Lemur85153282020-02-14 22:06:29 +00001696 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1697 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001698
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001699 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001700 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001701 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001702 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001703 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001704 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001705 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001706 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001707 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001708
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001709 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001710 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001711 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001712 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001713 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001714 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001715 ]
1716 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001717 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001718 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001719
Aaron Gable697a91b2018-01-19 15:20:15 -08001720 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001721 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001722 self.calls += [
1723 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1724 'refs/changes/56/123456/1'],), ''),
1725 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001726 ]
1727 self.assertEqual(git_cl.main(
1728 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1729 0)
Edward Lemur85153282020-02-14 22:06:29 +00001730 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001731
Edward Lemurd55c5072020-02-20 01:09:07 +00001732 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001733 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001734 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001735 self.calls += [
1736 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001737 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001738 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001739 ]
1740 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001741 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001742 self.assertEqual(
1743 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1744 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001745
Edward Lemurda4b6c62020-02-13 00:28:40 +00001746 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001747 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001748 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001749 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001750 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001751 self.mockGit.config['remote.origin.url'] = (
1752 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001753 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001754 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001755 self.assertEqual(
1756 'change 123456 at https://chromium-review.googlesource.com does not '
1757 'exist or you have no access to it\n',
1758 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001759
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001760 def _checkout_calls(self):
1761 return [
1762 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001763 'branch\\..*\\.gerritissue'], ),
1764 ('branch.ger-branch.gerritissue 123456\n'
1765 'branch.gbranch654.gerritissue 654321\n')),
1766 ]
1767
1768 def test_checkout_gerrit(self):
1769 """Tests git cl checkout <issue>."""
1770 self.calls = self._checkout_calls()
1771 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1772 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1773
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001774 def test_checkout_not_found(self):
1775 """Tests git cl checkout <issue>."""
1776 self.calls = self._checkout_calls()
1777 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1778
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001779 def test_checkout_no_branch_issues(self):
1780 """Tests git cl checkout <issue>."""
1781 self.calls = [
1782 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001783 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001784 ]
1785 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1786
Edward Lemur26964072020-02-19 19:18:51 +00001787 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00001788 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001789 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001790 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001791 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1792 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001793 self.mockGit.config['remote.origin.url'] = (
1794 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001795 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001796 cl.branch = 'master'
1797 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001798 return cl
1799
Edward Lemurd55c5072020-02-20 01:09:07 +00001800 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001801 def test_gerrit_ensure_authenticated_missing(self):
1802 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001803 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001804 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001805 with self.assertRaises(SystemExitMock):
1806 cl.EnsureAuthenticated(force=False)
1807 self.assertEqual(
1808 'Credentials for the following hosts are required:\n'
1809 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001810 'These are read from ~%(sep)s.gitcookies '
1811 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00001812 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001813 'https://chromium-review.googlesource.com/new-password\n' % {
1814 'sep': os.sep,
1815 'netrc': NETRC_FILENAME,
1816 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001817
1818 def test_gerrit_ensure_authenticated_conflict(self):
1819 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001820 'chromium.googlesource.com':
1821 ('git-one.example.com', None, 'secret1'),
1822 'chromium-review.googlesource.com':
1823 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001824 })
1825 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001826 (('ask_for_data', 'If you know what you are doing '
1827 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001828 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1829
1830 def test_gerrit_ensure_authenticated_ok(self):
1831 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001832 'chromium.googlesource.com':
1833 ('git-same.example.com', None, 'secret'),
1834 'chromium-review.googlesource.com':
1835 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001836 })
1837 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1838
tandrii@chromium.org28253532016-04-14 13:46:56 +00001839 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00001840 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
1841 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00001842 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1843
Eric Boren2fb63102018-10-05 13:05:03 +00001844 def test_gerrit_ensure_authenticated_bearer_token(self):
1845 cl = self._test_gerrit_ensure_authenticated_common(auth={
1846 'chromium.googlesource.com':
1847 ('', None, 'secret'),
1848 'chromium-review.googlesource.com':
1849 ('', None, 'secret'),
1850 })
1851 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1852 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1853 'chromium.googlesource.com')
1854 self.assertTrue('Bearer' in header)
1855
Daniel Chengcf6269b2019-05-18 01:02:12 +00001856 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00001857 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00001858 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001859 (('logging.warning',
1860 'Ignoring branch %(branch)s with non-https remote '
1861 '%(remote)s', {
1862 'branch': 'master',
1863 'remote': 'custom-scheme://repo'}
1864 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001865 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001866 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1867 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1868 mock.patch('logging.warning',
1869 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00001870 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00001871 cl.branch = 'master'
1872 cl.branchref = 'refs/heads/master'
1873 cl.lookedup_issue = True
1874 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1875
Florian Mayerae510e82020-01-30 21:04:48 +00001876 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00001877 self.mockGit.config['remote.origin.url'] = (
1878 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00001879 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001880 (('logging.error',
1881 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1882 'but it doesn\'t exist.', {
1883 'remote': 'origin',
1884 'branch': 'master',
1885 'url': 'git@somehost.example:foo/bar.git'}
1886 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00001887 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001888 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1889 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1890 mock.patch('logging.error',
1891 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00001892 cl = git_cl.Changelist()
1893 cl.branch = 'master'
1894 cl.branchref = 'refs/heads/master'
1895 cl.lookedup_issue = True
1896 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1897
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001898 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00001899 self.mockGit.config['branch.master.gerritissue'] = '123'
1900 self.mockGit.config['branch.master.gerritserver'] = (
1901 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00001902 self.mockGit.config['remote.origin.url'] = (
1903 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001904 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00001905 (('SetReview', 'chromium-review.googlesource.com',
1906 'infra%2Finfra~123', None,
1907 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001908 ]
tandriid9e5ce52016-07-13 02:32:59 -07001909
1910 def test_cmd_set_commit_gerrit_clear(self):
1911 self._cmd_set_commit_gerrit_common(0)
1912 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1913
1914 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001915 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001916 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1917
tandriid9e5ce52016-07-13 02:32:59 -07001918 def test_cmd_set_commit_gerrit(self):
1919 self._cmd_set_commit_gerrit_common(2)
1920 self.assertEqual(0, git_cl.main(['set-commit']))
1921
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001922 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001923 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001924 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001925
1926 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001927 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001928
Edward Lemurda4b6c62020-02-13 00:28:40 +00001929 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07001930 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07001931 try:
1932 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00001933 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001934 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001935 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07001936
1937 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07001938 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001939 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07001940 return 'foobar'
1941
Edward Lemurda4b6c62020-02-13 00:28:40 +00001942 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07001943 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001944 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001945 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001946 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07001947
iannuccie53c9352016-08-17 14:40:40 -07001948 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001949
iannuccie53c9352016-08-17 14:40:40 -07001950 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001951 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07001952 return 'foobar'
1953
Edward Lemurda4b6c62020-02-13 00:28:40 +00001954 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
1955 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07001956 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001957 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001958
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001959 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00001960 self.mockGit.config['remote.origin.url'] = (
1961 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001962 gerrit_util.GetChangeDetail.return_value = {
1963 'current_revision': 'sha1',
1964 'revisions': {'sha1': {
1965 'commit': {'message': 'foobar'},
1966 }},
1967 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001968 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001969 'description',
1970 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
1971 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001972 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001973
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001974 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001975 mock.patch('git_cl.Changelist', ChangelistMock).start()
1976 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001977
1978 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
1979 self.assertEqual('hihi', ChangelistMock.desc)
1980
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001981 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001982 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001983
1984 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001985 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001986 '# Enter a description of the change.\n'
1987 '# This will be displayed on the codereview site.\n'
1988 '# The first line will also be used as the subject of the review.\n'
1989 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001990 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07001991 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001992 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001993 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07001994 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001995
Edward Lemur6c6827c2020-02-06 21:15:18 +00001996 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001997 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001998
Edward Lemurda4b6c62020-02-13 00:28:40 +00001999 mock.patch('git_cl.Changelist.FetchDescription',
2000 lambda *args: current_desc).start()
2001 mock.patch('git_cl.Changelist.UpdateDescription',
2002 UpdateDescription).start()
2003 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002004
Edward Lemur85153282020-02-14 22:06:29 +00002005 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002006 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002007
Dan Beamd8b04ca2019-10-10 21:23:26 +00002008 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2009 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2010
2011 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002012 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002013 '# Enter a description of the change.\n'
2014 '# This will be displayed on the codereview site.\n'
2015 '# The first line will also be used as the subject of the review.\n'
2016 '#--------------------This line is 72 characters long'
2017 '--------------------\n'
2018 'Some.\n\nFixed: 123\nChange-Id: xxx',
2019 desc)
2020 return desc
2021
Edward Lemurda4b6c62020-02-13 00:28:40 +00002022 mock.patch('git_cl.Changelist.FetchDescription',
2023 lambda *args: current_desc).start()
2024 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002025
Edward Lemur85153282020-02-14 22:06:29 +00002026 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002027 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002028
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002029 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002030 mock.patch('git_cl.Changelist', ChangelistMock).start()
2031 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002032
2033 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2034 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2035
kmarshall3bff56b2016-06-06 18:31:47 -07002036 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002037 self.calls = [
2038 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002039 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002040 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002041 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002042 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002043 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002044
Edward Lemurda4b6c62020-02-13 00:28:40 +00002045 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002046 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002047 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2048 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002049 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002050
2051 self.assertEqual(0, git_cl.main(['archive', '-f']))
2052
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002053 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002054 self.calls = [
2055 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2056 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2057 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2058 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002059 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2060 ((['git', 'branch', '-D', 'foo'],), '')
2061 ]
2062
Edward Lemurda4b6c62020-02-13 00:28:40 +00002063 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002064 lambda branches, fine_grained, max_processes:
2065 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2066 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002067 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002068
2069 self.assertEqual(0, git_cl.main(['archive', '-f']))
2070
kmarshall3bff56b2016-06-06 18:31:47 -07002071 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002072 self.calls = [
2073 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2074 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002075 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002076 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002077
Edward Lemurda4b6c62020-02-13 00:28:40 +00002078 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002079 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002080 [(MockChangelistWithBranchAndIssue('master', 1),
2081 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002082
2083 self.assertEqual(1, git_cl.main(['archive', '-f']))
2084
2085 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002086 self.calls = [
2087 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2088 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002089 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002090 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002091
Edward Lemurda4b6c62020-02-13 00:28:40 +00002092 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002093 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002094 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2095 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002096 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002097
kmarshall9249e012016-08-23 12:02:16 -07002098 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2099
2100 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002101 self.calls = [
2102 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2103 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002104 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002105 ((['git', 'branch', '-D', 'foo'],), '')
2106 ]
kmarshall9249e012016-08-23 12:02:16 -07002107
Edward Lemurda4b6c62020-02-13 00:28:40 +00002108 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002109 lambda branches, fine_grained, max_processes:
2110 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2111 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002112 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002113
2114 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002115
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002116 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002117 self.calls = [
2118 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2119 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2120 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002121 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2122 'refs/tags/git-cl-archived-456-foo'),
2123 ((['git', 'branch', '-D', 'foo'],), CERR1),
2124 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2125 'refs/tags/git-cl-archived-456-foo'),
2126 ]
2127
Edward Lemurda4b6c62020-02-13 00:28:40 +00002128 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002129 lambda branches, fine_grained, max_processes:
2130 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2131 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002132 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002133
2134 self.assertEqual(0, git_cl.main(['archive', '-f']))
2135
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002136 def test_archive_with_format(self):
2137 self.calls = [
2138 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
2139 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2140 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2141 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2142 ((['git', 'branch', '-D', 'foo'], ), ''),
2143 ]
2144
2145 mock.patch('git_cl.get_cl_statuses',
2146 lambda branches, fine_grained, max_processes:
2147 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2148
2149 self.assertEqual(
2150 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2151
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002152 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002153 self.mockGit.config['branch.master.gerritissue'] = '123'
2154 self.mockGit.config['branch.master.gerritserver'] = (
2155 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002156 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002157 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002158 ]
2159 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002160 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2161 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002162
Aaron Gable400e9892017-07-12 15:31:21 -07002163 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002164 self.mockGit.config['branch.master.gerritissue'] = '123'
2165 self.mockGit.config['branch.master.gerritserver'] = (
2166 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002167 mock.patch('git_cl.Changelist.FetchDescription',
2168 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002169 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002170 ((['git', 'log', '-1', '--format=%B'],),
2171 'This is a description\n\nChange-Id: Ideadbeef'),
2172 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002173 ]
2174 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002175 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2176 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002177
phajdan.jre328cf92016-08-22 04:12:17 -07002178 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002179 self.mockGit.config['branch.master.gerritissue'] = '123'
2180 self.mockGit.config['branch.master.gerritserver'] = (
2181 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002182 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002183 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002184 {'issue': 123,
2185 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002186 ''),
2187 ]
2188 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2189
tandrii16e0b4e2016-06-07 10:34:28 -07002190 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002191 mock.patch(
2192 'git_cl.os.path.abspath',
2193 lambda path: self._mocked_call(['abspath', path])).start()
2194 mock.patch(
2195 'git_cl.os.path.exists',
2196 lambda path: self._mocked_call(['exists', path])).start()
2197 mock.patch(
2198 'git_cl.gclient_utils.FileRead',
2199 lambda path: self._mocked_call(['FileRead', path])).start()
2200 mock.patch(
2201 'git_cl.gclient_utils.rm_file_or_tree',
2202 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002203 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002204 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002205 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002206 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002207
2208 def test_GerritCommitMsgHookCheck_custom_hook(self):
2209 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002210 self.calls += [((['exists',
2211 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2212 ((['FileRead',
2213 os.path.join('.git', 'hooks', 'commit-msg')], ),
2214 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002215 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002216
2217 def test_GerritCommitMsgHookCheck_not_exists(self):
2218 cl = self._common_GerritCommitMsgHookCheck()
2219 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002220 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002221 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002222 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002223
2224 def test_GerritCommitMsgHookCheck(self):
2225 cl = self._common_GerritCommitMsgHookCheck()
2226 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002227 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2228 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002229 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002230 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002231 ((['rm_file_or_tree',
2232 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002233 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002234 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002235
tandriic4344b52016-08-29 06:04:54 -07002236 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002237 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2238 self.mockGit.config['branch.master.gerritserver'] = (
2239 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002240 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002241 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002242 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002243 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002244 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002245 'labels': {},
2246 'current_revision': 'deadbeaf',
2247 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002248 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002249 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002250 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002251 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2252 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002253 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002254 self.assertEqual(0, cl.CMDLand(force=True,
2255 bypass_hooks=True,
2256 verbose=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002257 parallel=False,
2258 resultdb=False,
2259 realm=None))
Edward Lemur73c76702020-02-06 23:57:18 +00002260 self.assertIn(
2261 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002262 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002263 self.assertIn(
2264 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002265 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002266
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002267 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002268 mock.patch('git_cl.Changelist.GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002269
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002270 def test_gerrit_change_detail_cache_simple(self):
2271 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002272 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002273 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002274 cl1._cached_remote_url = (
2275 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002276 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002277 cl2._cached_remote_url = (
2278 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002279 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2280 self.assertEqual(cl1._GetChangeDetail(), 'a')
2281 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002282
2283 def test_gerrit_change_detail_cache_options(self):
2284 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002285 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002286 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002287 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002288 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2289 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2290 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2291 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2292 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2293 self.assertEqual(cl._GetChangeDetail(), 'cab')
2294
2295 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2296 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2297 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2298 self.assertEqual(cl._GetChangeDetail(), 'cab')
2299
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002300 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002301 gerrit_util.GetChangeDetail.return_value = {
2302 'current_revision': 'rev1',
2303 'revisions': {
2304 'rev1': {'commit': {'message': 'desc1'}},
2305 },
2306 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002307
2308 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002309 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002310 cl._cached_remote_url = (
2311 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002312 self.assertEqual(cl.FetchDescription(), 'desc1')
2313 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002314
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002315 def test_print_current_creds(self):
2316 class CookiesAuthenticatorMock(object):
2317 def __init__(self):
2318 self.gitcookies = {
2319 'host.googlesource.com': ('user', 'pass'),
2320 'host-review.googlesource.com': ('user', 'pass'),
2321 }
2322 self.netrc = self
2323 self.netrc.hosts = {
2324 'github.com': ('user2', None, 'pass2'),
2325 'host2.googlesource.com': ('user3', None, 'pass'),
2326 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002327 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2328 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002329 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2330 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2331 ' Host\t User\t Which file',
2332 '============================\t=====\t===========',
2333 'host-review.googlesource.com\t user\t.gitcookies',
2334 ' host.googlesource.com\t user\t.gitcookies',
2335 ' host2.googlesource.com\tuser3\t .netrc',
2336 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002337 sys.stdout.seek(0)
2338 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002339 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2340 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2341 ' Host\tUser\t Which file',
2342 '============================\t====\t===========',
2343 'host-review.googlesource.com\tuser\t.gitcookies',
2344 ' host.googlesource.com\tuser\t.gitcookies',
2345 ])
2346
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002347 def _common_creds_check_mocks(self):
2348 def exists_mock(path):
2349 dirname = os.path.dirname(path)
2350 if dirname == os.path.expanduser('~'):
2351 dirname = '~'
2352 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002353 if base in (NETRC_FILENAME, '.gitcookies'):
2354 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002355 # git cl also checks for existence other files not relevant to this test.
2356 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002357 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002358 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002359 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002360 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002361
2362 def test_creds_check_gitcookies_not_configured(self):
2363 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002364 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2365 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002366 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002367 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2368 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2369 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2370 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2371 'or Ctrl+C to abort'), ''),
2372 (([
2373 'git', 'config', '--global', 'http.cookiefile',
2374 os.path.expanduser(os.path.join('~', '.gitcookies'))
2375 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002376 ]
2377 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002378 self.assertTrue(
2379 sys.stdout.getvalue().startswith(
2380 'You seem to be using outdated .netrc for git credentials:'))
2381 self.assertIn(
2382 '\nConfigured git to use .gitcookies from',
2383 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002384
2385 def test_creds_check_gitcookies_configured_custom_broken(self):
2386 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002387 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2388 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002389 custom_cookie_path = ('C:\\.gitcookies'
2390 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002391 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002392 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2393 ((['git', 'config', '--global', 'http.cookiefile'], ),
2394 custom_cookie_path),
2395 (('os.path.exists', custom_cookie_path), False),
2396 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2397 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2398 (([
2399 'git', 'config', '--global', 'http.cookiefile',
2400 os.path.expanduser(os.path.join('~', '.gitcookies'))
2401 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002402 ]
2403 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002404 self.assertIn(
2405 'WARNING: You have configured custom path to .gitcookies: ',
2406 sys.stdout.getvalue())
2407 self.assertIn(
2408 'However, your configured .gitcookies file is missing.',
2409 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002410
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002411 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002412 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002413 self.mockGit.config['remote.origin.url'] = (
2414 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002415 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002416 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002417 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002418 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002419 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002420 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002421
Edward Lemurda4b6c62020-02-13 00:28:40 +00002422 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2423 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002424 self.mockGit.config['remote.origin.url'] = (
2425 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002426 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002427 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002428 'current_revision': 'ba5eba11',
2429 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002430 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002431 '_number': 1,
2432 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002433 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002434 '_number': 2,
2435 },
2436 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002437 'messages': [
2438 {
2439 u'_revision_number': 1,
2440 u'author': {
2441 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002442 u'email': u'could-be-anything@example.com',
2443 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002444 },
2445 u'date': u'2017-03-15 20:08:45.000000000',
2446 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002447 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002448 u'tag': u'autogenerated:cq:dry-run'
2449 },
2450 {
2451 u'_revision_number': 2,
2452 u'author': {
2453 u'_account_id': 11151243,
2454 u'email': u'owner@example.com',
2455 u'name': u'owner'
2456 },
2457 u'date': u'2017-03-16 20:00:41.000000000',
2458 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2459 u'message': u'PTAL',
2460 },
2461 {
2462 u'_revision_number': 2,
2463 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002464 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002465 u'email': u'reviewer@example.com',
2466 u'name': u'reviewer'
2467 },
2468 u'date': u'2017-03-17 05:19:37.500000000',
2469 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2470 u'message': u'Patch Set 2: Code-Review+1',
2471 },
2472 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002473 }
2474 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002475 (('GetChangeComments', 'chromium-review.googlesource.com',
2476 'infra%2Finfra~1'), {
2477 '/COMMIT_MSG': [
2478 {
2479 'author': {
2480 'email': u'reviewer@example.com'
2481 },
2482 'updated': u'2017-03-17 05:19:37.500000000',
2483 'patch_set': 2,
2484 'side': 'REVISION',
2485 'message': 'Please include a bug link',
2486 },
2487 ],
2488 'codereview.settings': [
2489 {
2490 'author': {
2491 'email': u'owner@example.com'
2492 },
2493 'updated': u'2017-03-16 20:00:41.000000000',
2494 'patch_set': 2,
2495 'side': 'PARENT',
2496 'line': 42,
2497 'message': 'I removed this because it is bad',
2498 },
2499 ]
2500 }),
2501 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2502 'infra%2Finfra~1'), {}),
2503 ] * 2 + [(('write_json', 'output.json', [{
2504 u'date':
2505 u'2017-03-16 20:00:41.000000',
2506 u'message': (u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2507 u' Base, Line 42: https://crrev.com/c/1/2/'
2508 u'codereview.settings#b42\n' +
2509 u' I removed this because it is bad\n'),
2510 u'autogenerated':
2511 False,
2512 u'approval':
2513 False,
2514 u'disapproval':
2515 False,
2516 u'sender':
2517 u'owner@example.com'
2518 }, {
2519 u'date':
2520 u'2017-03-17 05:19:37.500000',
2521 u'message':
2522 (u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2523 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
2524 u' Please include a bug link\n'),
2525 u'autogenerated':
2526 False,
2527 u'approval':
2528 False,
2529 u'disapproval':
2530 False,
2531 u'sender':
2532 u'reviewer@example.com'
2533 }]), '')]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002534 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002535 git_cl._CommentSummary(
2536 message=(u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2537 u' Base, Line 42: https://crrev.com/c/1/2/' +
2538 u'codereview.settings#b42\n' +
2539 u' I removed this because it is bad\n'),
2540 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2541 autogenerated=False,
2542 disapproval=False,
2543 approval=False,
2544 sender=u'owner@example.com'),
2545 git_cl._CommentSummary(message=(
2546 u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2547 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002548 u' Please include a bug link\n'),
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002549 date=datetime.datetime(2017, 3, 17, 5, 19, 37,
2550 500000),
2551 autogenerated=False,
2552 disapproval=False,
2553 approval=False,
2554 sender=u'reviewer@example.com'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002555 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002556 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002557 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002558 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002559 self.assertEqual(
2560 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2561
2562 def test_git_cl_comments_robot_comments(self):
2563 # git cl comments also fetches robot comments (which are considered a type
2564 # of autogenerated comment), and unlike other types of comments, only robot
2565 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002566 self.mockGit.config['remote.origin.url'] = (
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002567 'https://x.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002568 gerrit_util.GetChangeDetail.return_value = {
2569 'owner': {'email': 'owner@example.com'},
2570 'current_revision': 'ba5eba11',
2571 'revisions': {
2572 'deadbeaf': {
2573 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002574 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002575 'ba5eba11': {
2576 '_number': 2,
2577 },
2578 },
2579 'messages': [
2580 {
2581 u'_revision_number': 1,
2582 u'author': {
2583 u'_account_id': 1111084,
2584 u'email': u'commit-bot@chromium.org',
2585 u'name': u'Commit Bot'
2586 },
2587 u'date': u'2017-03-15 20:08:45.000000000',
2588 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2589 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2590 u'tag': u'autogenerated:cq:dry-run'
2591 },
2592 {
2593 u'_revision_number': 1,
2594 u'author': {
2595 u'_account_id': 123,
2596 u'email': u'tricium@serviceaccount.com',
2597 u'name': u'Tricium'
2598 },
2599 u'date': u'2017-03-16 20:00:41.000000000',
2600 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2601 u'message': u'(1 comment)',
2602 u'tag': u'autogenerated:tricium',
2603 },
2604 {
2605 u'_revision_number': 1,
2606 u'author': {
2607 u'_account_id': 123,
2608 u'email': u'tricium@serviceaccount.com',
2609 u'name': u'Tricium'
2610 },
2611 u'date': u'2017-03-16 20:00:41.000000000',
2612 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2613 u'message': u'(1 comment)',
2614 u'tag': u'autogenerated:tricium',
2615 },
2616 {
2617 u'_revision_number': 2,
2618 u'author': {
2619 u'_account_id': 123,
2620 u'email': u'tricium@serviceaccount.com',
2621 u'name': u'reviewer'
2622 },
2623 u'date': u'2017-03-17 05:30:37.000000000',
2624 u'tag': u'autogenerated:tricium',
2625 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2626 u'message': u'(1 comment)',
2627 },
2628 ]
2629 }
2630 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002631 (('GetChangeComments', 'x-review.googlesource.com', 'infra%2Finfra~1'),
2632 {}),
2633 (('GetChangeRobotComments', 'x-review.googlesource.com',
2634 'infra%2Finfra~1'), {
2635 'codereview.settings': [
2636 {
2637 u'author': {
2638 u'email': u'tricium@serviceaccount.com'
2639 },
2640 u'updated': u'2017-03-17 05:30:37.000000000',
2641 u'robot_run_id': u'5565031076855808',
2642 u'robot_id': u'Linter/Category',
2643 u'tag': u'autogenerated:tricium',
2644 u'patch_set': 2,
2645 u'side': u'REVISION',
2646 u'message': u'Linter warning message text',
2647 u'line': 32,
2648 },
2649 ],
2650 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002651 ]
2652 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002653 git_cl._CommentSummary(
2654 date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2655 message=(u'(1 comment)\n\ncodereview.settings\n'
2656 u' PS2, Line 32: https://x-review.googlesource.com/c/1/2/'
2657 u'codereview.settings#32\n'
2658 u' Linter warning message text\n'),
2659 sender=u'tricium@serviceaccount.com',
2660 autogenerated=True,
2661 approval=False,
2662 disapproval=False)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002663 ]
2664 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002665 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002666 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002667
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002668 def test_get_remote_url_with_mirror(self):
2669 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002670
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002671 def selective_os_path_isdir_mock(path):
2672 if path == '/cache/this-dir-exists':
2673 return self._mocked_call('os.path.isdir', path)
2674 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002675
Edward Lemurda4b6c62020-02-13 00:28:40 +00002676 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002677
2678 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002679 self.mockGit.config['remote.origin.url'] = (
2680 '/cache/this-dir-exists')
2681 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2682 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002683 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002684 (('os.path.isdir', '/cache/this-dir-exists'),
2685 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002686 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002687 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002688 self.assertEqual(cl.GetRemoteUrl(), url)
2689 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2690
Edward Lemur298f2cf2019-02-22 21:40:39 +00002691 def test_get_remote_url_non_existing_mirror(self):
2692 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002693
Edward Lemur298f2cf2019-02-22 21:40:39 +00002694 def selective_os_path_isdir_mock(path):
2695 if path == '/cache/this-dir-doesnt-exist':
2696 return self._mocked_call('os.path.isdir', path)
2697 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002698
Edward Lemurda4b6c62020-02-13 00:28:40 +00002699 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2700 mock.patch('logging.error',
2701 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002702
Edward Lemur26964072020-02-19 19:18:51 +00002703 self.mockGit.config['remote.origin.url'] = (
2704 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002705 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002706 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2707 False),
2708 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002709 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2710 'but it doesn\'t exist.', {
2711 'remote': 'origin',
2712 'branch': 'master',
2713 'url': '/cache/this-dir-doesnt-exist'}
2714 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002715 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002716 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002717 self.assertIsNone(cl.GetRemoteUrl())
2718
2719 def test_get_remote_url_misconfigured_mirror(self):
2720 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002721
Edward Lemur298f2cf2019-02-22 21:40:39 +00002722 def selective_os_path_isdir_mock(path):
2723 if path == '/cache/this-dir-exists':
2724 return self._mocked_call('os.path.isdir', path)
2725 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002726
Edward Lemurda4b6c62020-02-13 00:28:40 +00002727 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2728 mock.patch('logging.error',
2729 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002730
Edward Lemur26964072020-02-19 19:18:51 +00002731 self.mockGit.config['remote.origin.url'] = (
2732 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002733 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002734 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002735 (('logging.error',
2736 'Remote "%(remote)s" for branch "%(branch)s" points to '
2737 '"%(cache_path)s", but it is misconfigured.\n'
2738 '"%(cache_path)s" must be a git repo and must have a remote named '
2739 '"%(remote)s" pointing to the git host.', {
2740 'remote': 'origin',
2741 'cache_path': '/cache/this-dir-exists',
2742 'branch': 'master'}
2743 ), None),
2744 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002745 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002746 self.assertIsNone(cl.GetRemoteUrl())
2747
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002748 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002749 self.mockGit.config['remote.origin.url'] = (
2750 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002751 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002752 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2753
2754 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002755 mock.patch('logging.error',
2756 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002757
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002758 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002759 (('logging.error',
2760 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2761 'but it doesn\'t exist.', {
2762 'remote': 'origin',
2763 'branch': 'master',
2764 'url': ''}
2765 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002766 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002767 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002768 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002769
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002770 def test_gerrit_new_default(self):
2771 self._run_gerrit_upload_test(
2772 [],
2773 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
2774 [],
2775 squash=False,
2776 squash_mode='override_nosquash',
2777 change_id='I123456789',
Stephen Martinis1c3c9392021-01-07 02:42:33 +00002778 new_default=True)
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002779
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002780
Edward Lemur9aa1a962020-02-25 00:58:38 +00002781class ChangelistTest(unittest.TestCase):
Edward Lemur227d5102020-02-25 23:45:35 +00002782 def setUp(self):
2783 super(ChangelistTest, self).setUp()
2784 mock.patch('gclient_utils.FileRead').start()
2785 mock.patch('gclient_utils.FileWrite').start()
2786 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
2787 mock.patch(
2788 'git_cl.Changelist.GetCodereviewServer',
2789 return_value='https://chromium-review.googlesource.com').start()
2790 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
2791 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
2792 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
2793 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
2794 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
2795 mock.patch('git_cl.time_time').start()
2796 mock.patch('metrics.collector').start()
2797 mock.patch('subprocess2.Popen').start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002798 mock.patch('git_cl.Changelist.GetGerritProject',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002799 return_value='https://chromium-review.googlesource.com').start()
Edward Lemur227d5102020-02-25 23:45:35 +00002800 self.addCleanup(mock.patch.stopall)
2801 self.temp_count = 0
2802
Edward Lemur227d5102020-02-25 23:45:35 +00002803 def testRunHook(self):
2804 expected_results = {
2805 'more_cc': ['more@example.com', 'cc@example.com'],
2806 'should_continue': True,
2807 }
2808 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2809 git_cl.time_time.side_effect = [100, 200]
2810 mockProcess = mock.Mock()
2811 mockProcess.wait.return_value = 0
2812 subprocess2.Popen.return_value = mockProcess
2813
2814 cl = git_cl.Changelist()
2815 results = cl.RunHook(
2816 committing=True,
2817 may_prompt=True,
2818 verbose=2,
2819 parallel=True,
2820 upstream='upstream',
2821 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002822 all_files=True,
2823 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00002824
2825 self.assertEqual(expected_results, results)
2826 subprocess2.Popen.assert_called_once_with([
2827 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00002828 '--root', 'root',
2829 '--upstream', 'upstream',
2830 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002831 '--author', 'author',
2832 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00002833 '--issue', '123456',
2834 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002835 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00002836 '--may_prompt',
2837 '--parallel',
2838 '--all_files',
2839 '--json_output', '/tmp/fake-temp2',
2840 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002841 '--gerrit_project', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00002842 ])
2843 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002844 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00002845 metrics.collector.add_repeated('sub_commands', {
2846 'command': 'presubmit',
2847 'execution_time': 100,
2848 'exit_code': 0,
2849 })
2850
Edward Lemur99df04e2020-03-05 19:39:43 +00002851 def testRunHook_FewerOptions(self):
2852 expected_results = {
2853 'more_cc': ['more@example.com', 'cc@example.com'],
2854 'should_continue': True,
2855 }
2856 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2857 git_cl.time_time.side_effect = [100, 200]
2858 mockProcess = mock.Mock()
2859 mockProcess.wait.return_value = 0
2860 subprocess2.Popen.return_value = mockProcess
2861
2862 git_cl.Changelist.GetAuthor.return_value = None
2863 git_cl.Changelist.GetIssue.return_value = None
2864 git_cl.Changelist.GetPatchset.return_value = None
2865 git_cl.Changelist.GetCodereviewServer.return_value = None
2866
2867 cl = git_cl.Changelist()
2868 results = cl.RunHook(
2869 committing=False,
2870 may_prompt=False,
2871 verbose=0,
2872 parallel=False,
2873 upstream='upstream',
2874 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002875 all_files=False,
2876 resultdb=False)
Edward Lemur99df04e2020-03-05 19:39:43 +00002877
2878 self.assertEqual(expected_results, results)
2879 subprocess2.Popen.assert_called_once_with([
2880 'vpython', 'PRESUBMIT_SUPPORT',
2881 '--root', 'root',
2882 '--upstream', 'upstream',
2883 '--upload',
2884 '--json_output', '/tmp/fake-temp2',
2885 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002886 '--gerrit_project', 'https://chromium-review.googlesource.com',
Edward Lemur99df04e2020-03-05 19:39:43 +00002887 ])
2888 gclient_utils.FileWrite.assert_called_once_with(
2889 '/tmp/fake-temp1', 'description')
2890 metrics.collector.add_repeated('sub_commands', {
2891 'command': 'presubmit',
2892 'execution_time': 100,
2893 'exit_code': 0,
2894 })
2895
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002896 def testRunHook_FewerOptionsResultDB(self):
2897 expected_results = {
2898 'more_cc': ['more@example.com', 'cc@example.com'],
2899 'should_continue': True,
2900 }
2901 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2902 git_cl.time_time.side_effect = [100, 200]
2903 mockProcess = mock.Mock()
2904 mockProcess.wait.return_value = 0
2905 subprocess2.Popen.return_value = mockProcess
2906
2907 git_cl.Changelist.GetAuthor.return_value = None
2908 git_cl.Changelist.GetIssue.return_value = None
2909 git_cl.Changelist.GetPatchset.return_value = None
2910 git_cl.Changelist.GetCodereviewServer.return_value = None
2911
2912 cl = git_cl.Changelist()
2913 results = cl.RunHook(
2914 committing=False,
2915 may_prompt=False,
2916 verbose=0,
2917 parallel=False,
2918 upstream='upstream',
2919 description='description',
2920 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002921 resultdb=True,
2922 realm='chromium:public')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002923
2924 self.assertEqual(expected_results, results)
2925 subprocess2.Popen.assert_called_once_with([
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002926 'rdb', 'stream', '-new', '-realm', 'chromium:public', '--',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002927 'vpython', 'PRESUBMIT_SUPPORT',
2928 '--root', 'root',
2929 '--upstream', 'upstream',
2930 '--upload',
2931 '--json_output', '/tmp/fake-temp2',
2932 '--description_file', '/tmp/fake-temp1',
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002933 '--gerrit_project', 'https://chromium-review.googlesource.com',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002934 ])
2935
Edward Lemur227d5102020-02-25 23:45:35 +00002936 @mock.patch('sys.exit', side_effect=SystemExitMock)
2937 def testRunHook_Failure(self, _mock):
2938 git_cl.time_time.side_effect = [100, 200]
2939 mockProcess = mock.Mock()
2940 mockProcess.wait.return_value = 2
2941 subprocess2.Popen.return_value = mockProcess
2942
2943 cl = git_cl.Changelist()
2944 with self.assertRaises(SystemExitMock):
2945 cl.RunHook(
2946 committing=True,
2947 may_prompt=True,
2948 verbose=2,
2949 parallel=True,
2950 upstream='upstream',
2951 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002952 all_files=True,
2953 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00002954
2955 sys.exit.assert_called_once_with(2)
2956
Edward Lemur75526302020-02-27 22:31:05 +00002957 def testRunPostUploadHook(self):
2958 cl = git_cl.Changelist()
2959 cl.RunPostUploadHook(2, 'upstream', 'description')
2960
2961 subprocess2.Popen.assert_called_once_with([
2962 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00002963 '--root', 'root',
2964 '--upstream', 'upstream',
2965 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002966 '--author', 'author',
2967 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur75526302020-02-27 22:31:05 +00002968 '--issue', '123456',
2969 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002970 '--post_upload',
2971 '--description_file', '/tmp/fake-temp1',
2972 ])
2973 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002974 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00002975
Edward Lemur9aa1a962020-02-25 00:58:38 +00002976
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002977class CMDTestCaseBase(unittest.TestCase):
2978 _STATUSES = [
2979 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
2980 'INFRA_FAILURE', 'CANCELED',
2981 ]
2982 _CHANGE_DETAIL = {
2983 'project': 'depot_tools',
2984 'status': 'OPEN',
2985 'owner': {'email': 'owner@e.mail'},
2986 'current_revision': 'beeeeeef',
2987 'revisions': {
Gavin Make61ccc52020-11-13 00:12:57 +00002988 'deadbeaf': {
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00002989 '_number': 6,
Gavin Make61ccc52020-11-13 00:12:57 +00002990 'kind': 'REWORK',
2991 },
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002992 'beeeeeef': {
2993 '_number': 7,
Gavin Make61ccc52020-11-13 00:12:57 +00002994 'kind': 'NO_CODE_CHANGE',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002995 'fetch': {'http': {
2996 'url': 'https://chromium.googlesource.com/depot_tools',
2997 'ref': 'refs/changes/56/123456/7'
2998 }},
2999 },
3000 },
3001 }
3002 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003003 'builds': [{
3004 'id': str(100 + idx),
3005 'builder': {
3006 'project': 'chromium',
3007 'bucket': 'try',
3008 'builder': 'bot_' + status.lower(),
3009 },
3010 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3011 'tags': [],
3012 'status': status,
3013 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003014 }
3015
Edward Lemur4c707a22019-09-24 21:13:43 +00003016 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003017 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003018 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003019 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3020 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003021 mock.patch(
3022 'git_cl.Changelist.GetCodereviewServer',
3023 return_value='https://chromium-review.googlesource.com').start()
3024 mock.patch(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00003025 'git_cl.Changelist.GetGerritHost',
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003026 return_value='chromium-review.googlesource.com').start()
3027 mock.patch(
3028 'git_cl.Changelist.GetMostRecentPatchset',
3029 return_value=7).start()
3030 mock.patch(
Gavin Make61ccc52020-11-13 00:12:57 +00003031 'git_cl.Changelist.GetMostRecentDryRunPatchset',
3032 return_value=6).start()
3033 mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003034 'git_cl.Changelist.GetRemoteUrl',
3035 return_value='https://chromium.googlesource.com/depot_tools').start()
3036 mock.patch(
3037 'auth.Authenticator',
3038 return_value=AuthenticatorMock()).start()
3039 mock.patch(
3040 'gerrit_util.GetChangeDetail',
3041 return_value=self._CHANGE_DETAIL).start()
3042 mock.patch(
3043 'git_cl._call_buildbucket',
3044 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003045 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003046 self.addCleanup(mock.patch.stopall)
3047
Edward Lemur4c707a22019-09-24 21:13:43 +00003048
Edward Lemur9468eba2020-02-27 19:07:22 +00003049class CMDPresubmitTestCase(CMDTestCaseBase):
3050 def setUp(self):
3051 super(CMDPresubmitTestCase, self).setUp()
3052 mock.patch(
3053 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3054 return_value='upstream').start()
3055 mock.patch(
3056 'git_cl.Changelist.FetchDescription',
3057 return_value='fetch description').start()
3058 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00003059 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00003060 return_value='get description').start()
3061 mock.patch('git_cl.Changelist.RunHook').start()
3062
3063 def testDefaultCase(self):
3064 self.assertEqual(0, git_cl.main(['presubmit']))
3065 git_cl.Changelist.RunHook.assert_called_once_with(
3066 committing=True,
3067 may_prompt=False,
3068 verbose=0,
3069 parallel=None,
3070 upstream='upstream',
3071 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003072 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003073 resultdb=None,
3074 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003075
3076 def testNoIssue(self):
3077 git_cl.Changelist.GetIssue.return_value = None
3078 self.assertEqual(0, git_cl.main(['presubmit']))
3079 git_cl.Changelist.RunHook.assert_called_once_with(
3080 committing=True,
3081 may_prompt=False,
3082 verbose=0,
3083 parallel=None,
3084 upstream='upstream',
3085 description='get description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003086 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003087 resultdb=None,
3088 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003089
3090 def testCustomBranch(self):
3091 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3092 git_cl.Changelist.RunHook.assert_called_once_with(
3093 committing=True,
3094 may_prompt=False,
3095 verbose=0,
3096 parallel=None,
3097 upstream='custom_branch',
3098 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003099 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003100 resultdb=None,
3101 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003102
3103 def testOptions(self):
3104 self.assertEqual(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003105 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003106 '--resultdb', '--realm', 'chromium:public']))
Edward Lemur9468eba2020-02-27 19:07:22 +00003107 git_cl.Changelist.RunHook.assert_called_once_with(
3108 committing=False,
3109 may_prompt=False,
3110 verbose=2,
3111 parallel=True,
3112 upstream='upstream',
3113 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003114 all_files=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003115 resultdb=True,
3116 realm='chromium:public')
Edward Lemur9468eba2020-02-27 19:07:22 +00003117
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003118class CMDTryResultsTestCase(CMDTestCaseBase):
3119 _DEFAULT_REQUEST = {
3120 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003121 "gerritChanges": [{
3122 "project": "depot_tools",
3123 "host": "chromium-review.googlesource.com",
Gavin Make61ccc52020-11-13 00:12:57 +00003124 "patchset": 6,
3125 "change": 123456,
3126 }],
3127 },
3128 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3129 ',builds.*.createTime,builds.*.tags'),
3130 }
3131
3132 _TRIVIAL_REQUEST = {
3133 'predicate': {
3134 "gerritChanges": [{
3135 "project": "depot_tools",
3136 "host": "chromium-review.googlesource.com",
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003137 "patchset": 7,
3138 "change": 123456,
3139 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003140 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003141 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3142 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003143 }
3144
3145 def testNoJobs(self):
3146 git_cl._call_buildbucket.return_value = {}
3147
3148 self.assertEqual(0, git_cl.main(['try-results']))
3149 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3150 git_cl._call_buildbucket.assert_called_once_with(
3151 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3152 self._DEFAULT_REQUEST)
3153
Gavin Make61ccc52020-11-13 00:12:57 +00003154 def testTrivialCommits(self):
3155 self.assertEqual(0, git_cl.main(['try-results']))
3156 git_cl._call_buildbucket.assert_called_with(
3157 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3158 self._DEFAULT_REQUEST)
3159
3160 git_cl._call_buildbucket.return_value = {}
3161 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '7']))
3162 git_cl._call_buildbucket.assert_called_with(
3163 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3164 self._TRIVIAL_REQUEST)
3165 self.assertEqual([
3166 'Successes:',
3167 ' bot_success https://ci.chromium.org/b/103',
3168 'Infra Failures:',
3169 ' bot_infra_failure https://ci.chromium.org/b/105',
3170 'Failures:',
3171 ' bot_failure https://ci.chromium.org/b/104',
3172 'Canceled:',
3173 ' bot_canceled ',
3174 'Started:',
3175 ' bot_started https://ci.chromium.org/b/102',
3176 'Scheduled:',
3177 ' bot_scheduled id=101',
3178 'Other:',
3179 ' bot_status_unspecified id=100',
3180 'Total: 7 tryjobs',
3181 'No tryjobs scheduled.',
3182 ], sys.stdout.getvalue().splitlines())
3183
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003184 def testPrintToStdout(self):
3185 self.assertEqual(0, git_cl.main(['try-results']))
3186 self.assertEqual([
3187 'Successes:',
3188 ' bot_success https://ci.chromium.org/b/103',
3189 'Infra Failures:',
3190 ' bot_infra_failure https://ci.chromium.org/b/105',
3191 'Failures:',
3192 ' bot_failure https://ci.chromium.org/b/104',
3193 'Canceled:',
3194 ' bot_canceled ',
3195 'Started:',
3196 ' bot_started https://ci.chromium.org/b/102',
3197 'Scheduled:',
3198 ' bot_scheduled id=101',
3199 'Other:',
3200 ' bot_status_unspecified id=100',
3201 'Total: 7 tryjobs',
3202 ], sys.stdout.getvalue().splitlines())
3203 git_cl._call_buildbucket.assert_called_once_with(
3204 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3205 self._DEFAULT_REQUEST)
3206
3207 def testPrintToStdoutWithMasters(self):
3208 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3209 self.assertEqual([
3210 'Successes:',
3211 ' try bot_success https://ci.chromium.org/b/103',
3212 'Infra Failures:',
3213 ' try bot_infra_failure https://ci.chromium.org/b/105',
3214 'Failures:',
3215 ' try bot_failure https://ci.chromium.org/b/104',
3216 'Canceled:',
3217 ' try bot_canceled ',
3218 'Started:',
3219 ' try bot_started https://ci.chromium.org/b/102',
3220 'Scheduled:',
3221 ' try bot_scheduled id=101',
3222 'Other:',
3223 ' try bot_status_unspecified id=100',
3224 'Total: 7 tryjobs',
3225 ], sys.stdout.getvalue().splitlines())
3226 git_cl._call_buildbucket.assert_called_once_with(
3227 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3228 self._DEFAULT_REQUEST)
3229
3230 @mock.patch('git_cl.write_json')
3231 def testWriteToJson(self, mockJsonDump):
3232 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3233 git_cl._call_buildbucket.assert_called_once_with(
3234 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3235 self._DEFAULT_REQUEST)
3236 mockJsonDump.assert_called_once_with(
3237 'file.json', self._DEFAULT_RESPONSE['builds'])
3238
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003239 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003240 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3241 self.assertEqual(
3242 [
3243 ('chromium', 'try', 'bot_failure'),
3244 ('chromium', 'try', 'bot_infra_failure'),
3245 ],
3246 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003247
3248 def test_filter_failed_for_retry_many_builds(self):
3249
3250 def _build(name, created_sec, status, experimental=False):
3251 assert 0 <= created_sec < 100, created_sec
3252 b = {
3253 'id': 112112,
3254 'builder': {
3255 'project': 'chromium',
3256 'bucket': 'try',
3257 'builder': name,
3258 },
3259 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3260 'status': status,
3261 'tags': [],
3262 }
3263 if experimental:
3264 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3265 return b
3266
3267 builds = [
3268 _build('flaky-last-green', 1, 'FAILURE'),
3269 _build('flaky-last-green', 2, 'SUCCESS'),
3270 _build('flaky', 1, 'SUCCESS'),
3271 _build('flaky', 2, 'FAILURE'),
3272 _build('running', 1, 'FAILED'),
3273 _build('running', 2, 'SCHEDULED'),
3274 _build('yep-still-running', 1, 'STARTED'),
3275 _build('yep-still-running', 2, 'FAILURE'),
3276 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3277 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3278
3279 # Simulate experimental in CQ builder, which developer decided
3280 # to retry manually which resulted in 2nd build non-experimental.
3281 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3282 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3283 ]
3284 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003285 self.assertEqual(
3286 [
3287 ('chromium', 'try', 'flaky'),
3288 ('chromium', 'try', 'sometimes-experimental'),
3289 ],
3290 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003291
3292
3293class CMDTryTestCase(CMDTestCaseBase):
3294
3295 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003296 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003297 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003298 self.assertEqual(0, git_cl.main(['try']))
3299 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3300 self.assertEqual(
3301 sys.stdout.getvalue(),
3302 'Scheduling CQ dry run on: '
3303 'https://chromium-review.googlesource.com/123456\n')
3304
Edward Lemur4c707a22019-09-24 21:13:43 +00003305 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003306 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003307 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003308
3309 self.assertEqual(0, git_cl.main([
3310 'try', '-B', 'luci.chromium.try', '-b', 'win',
3311 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3312 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003313 'Scheduling jobs on:\n'
3314 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003315 git_cl.sys.stdout.getvalue())
3316
3317 expected_request = {
3318 "requests": [{
3319 "scheduleBuild": {
3320 "requestId": "uuid4",
3321 "builder": {
3322 "project": "chromium",
3323 "builder": "win",
3324 "bucket": "try",
3325 },
3326 "gerritChanges": [{
3327 "project": "depot_tools",
3328 "host": "chromium-review.googlesource.com",
3329 "patchset": 7,
3330 "change": 123456,
3331 }],
3332 "properties": {
3333 "category": "git_cl_try",
3334 "json": [{"a": 1}, None],
3335 "key": "val",
3336 },
3337 "tags": [
3338 {"value": "win", "key": "builder"},
3339 {"value": "git_cl_try", "key": "user_agent"},
3340 ],
3341 },
3342 }],
3343 }
3344 mockCallBuildbucket.assert_called_with(
3345 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3346
Anthony Polito1a5fe232020-01-24 23:17:52 +00003347 @mock.patch('git_cl._call_buildbucket')
3348 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3349 mockCallBuildbucket.return_value = {}
3350
3351 self.assertEqual(0, git_cl.main([
3352 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3353 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3354 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3355 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003356 'Scheduling jobs on:\n'
3357 ' chromium/try: linux\n'
3358 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003359 git_cl.sys.stdout.getvalue())
3360
3361 expected_request = {
3362 "requests": [{
3363 "scheduleBuild": {
3364 "requestId": "uuid4",
3365 "builder": {
3366 "project": "chromium",
3367 "builder": "linux",
3368 "bucket": "try",
3369 },
3370 "gerritChanges": [{
3371 "project": "depot_tools",
3372 "host": "chromium-review.googlesource.com",
3373 "patchset": 7,
3374 "change": 123456,
3375 }],
3376 "properties": {
3377 "category": "git_cl_try",
3378 "json": [{"a": 1}, None],
3379 "key": "val",
3380 },
3381 "tags": [
3382 {"value": "linux", "key": "builder"},
3383 {"value": "git_cl_try", "key": "user_agent"},
3384 ],
3385 "gitilesCommit": {
3386 "host": "chromium-review.googlesource.com",
3387 "project": "depot_tools",
3388 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3389 }
3390 },
3391 },
3392 {
3393 "scheduleBuild": {
3394 "requestId": "uuid4",
3395 "builder": {
3396 "project": "chromium",
3397 "builder": "win",
3398 "bucket": "try",
3399 },
3400 "gerritChanges": [{
3401 "project": "depot_tools",
3402 "host": "chromium-review.googlesource.com",
3403 "patchset": 7,
3404 "change": 123456,
3405 }],
3406 "properties": {
3407 "category": "git_cl_try",
3408 "json": [{"a": 1}, None],
3409 "key": "val",
3410 },
3411 "tags": [
3412 {"value": "win", "key": "builder"},
3413 {"value": "git_cl_try", "key": "user_agent"},
3414 ],
3415 "gitilesCommit": {
3416 "host": "chromium-review.googlesource.com",
3417 "project": "depot_tools",
3418 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3419 }
3420 },
3421 }],
3422 }
3423 mockCallBuildbucket.assert_called_with(
3424 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3425
Edward Lemur45768512020-03-02 19:03:14 +00003426 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003427 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003428 with self.assertRaises(SystemExit):
3429 git_cl.main([
3430 'try', '-B', 'not-a-bucket', '-b', 'win',
3431 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003432 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003433 'Invalid bucket: not-a-bucket.',
3434 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003435
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003436 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003437 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003438 def testScheduleOnBuildbucketRetryFailed(
3439 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003440 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003441 7: [],
3442 6: [{
3443 'id': 112112,
3444 'builder': {
3445 'project': 'chromium',
3446 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003447 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003448 'createTime': '2019-10-09T08:00:01.854286Z',
3449 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003450 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003451 mockCallBuildbucket.return_value = {}
3452
3453 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3454 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003455 'Scheduling jobs on:\n'
3456 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003457 git_cl.sys.stdout.getvalue())
3458
3459 expected_request = {
3460 "requests": [{
3461 "scheduleBuild": {
3462 "requestId": "uuid4",
3463 "builder": {
3464 "project": "chromium",
3465 "bucket": "try",
3466 "builder": "linux",
3467 },
3468 "gerritChanges": [{
3469 "project": "depot_tools",
3470 "host": "chromium-review.googlesource.com",
3471 "patchset": 7,
3472 "change": 123456,
3473 }],
3474 "properties": {
3475 "category": "git_cl_try",
3476 },
3477 "tags": [
3478 {"value": "linux", "key": "builder"},
3479 {"value": "git_cl_try", "key": "user_agent"},
3480 {"value": "1", "key": "retry_failed"},
3481 ],
3482 },
3483 }],
3484 }
3485 mockCallBuildbucket.assert_called_with(
3486 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3487
Edward Lemur4c707a22019-09-24 21:13:43 +00003488 def test_parse_bucket(self):
3489 test_cases = [
3490 {
3491 'bucket': 'chromium/try',
3492 'result': ('chromium', 'try'),
3493 },
3494 {
3495 'bucket': 'luci.chromium.try',
3496 'result': ('chromium', 'try'),
3497 'has_warning': True,
3498 },
3499 {
3500 'bucket': 'skia.primary',
3501 'result': ('skia', 'skia.primary'),
3502 'has_warning': True,
3503 },
3504 {
3505 'bucket': 'not-a-bucket',
3506 'result': (None, None),
3507 },
3508 ]
3509
3510 for test_case in test_cases:
3511 git_cl.sys.stdout.truncate(0)
3512 self.assertEqual(
3513 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3514 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003515 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3516 test_case['result'])
3517 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003518
3519
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003520class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003521
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003522 def setUp(self):
3523 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003524 mock.patch('git_cl._fetch_tryjobs').start()
3525 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003526 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003527 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3528 mock.patch(
3529 'git_cl.Settings.GetSquashGerritUploads',
3530 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003531 self.addCleanup(mock.patch.stopall)
3532
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003533 def testWarmUpChangeDetailCache(self):
3534 self.assertEqual(0, git_cl.main(['upload']))
3535 gerrit_util.GetChangeDetail.assert_called_once_with(
3536 'chromium-review.googlesource.com', 'depot_tools~123456',
3537 frozenset([
3538 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3539 'CURRENT_COMMIT']))
3540
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003541 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003542 # This test mocks out the actual upload part, and just asserts that after
3543 # upload, if --retry-failed is added, then the tool will fetch try jobs
3544 # from the previous patchset and trigger the right builders on the latest
3545 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003546 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003547 # Latest patchset: No builds.
3548 [],
3549 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003550 [{
3551 'id': str(100 + idx),
3552 'builder': {
3553 'project': 'chromium',
3554 'bucket': 'try',
3555 'builder': 'bot_' + status.lower(),
3556 },
3557 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3558 'tags': [],
3559 'status': status,
3560 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003561 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003562
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003563 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003564 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003565 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3566 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003567 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003568 expected_buckets = [
3569 ('chromium', 'try', 'bot_failure'),
3570 ('chromium', 'try', 'bot_infra_failure'),
3571 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003572 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3573 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003574
Brian Sheedy59b06a82019-10-14 17:03:29 +00003575
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003576class MakeRequestsHelperTestCase(unittest.TestCase):
3577
3578 def exampleGerritChange(self):
3579 return {
3580 'host': 'chromium-review.googlesource.com',
3581 'project': 'depot_tools',
3582 'change': 1,
3583 'patchset': 2,
3584 }
3585
3586 def testMakeRequestsHelperNoOptions(self):
3587 # Basic test for the helper function _make_tryjob_schedule_requests;
3588 # it shouldn't throw AttributeError even when options doesn't have any
3589 # of the expected values; it will use default option values.
3590 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3591 jobs = [('chromium', 'try', 'my-builder')]
3592 options = optparse.Values()
3593 requests = git_cl._make_tryjob_schedule_requests(
3594 changelist, jobs, options, patchset=None)
3595
3596 # requestId is non-deterministic. Just assert that it's there and has
3597 # a particular length.
3598 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3599 self.assertEqual(requests, [{
3600 'scheduleBuild': {
3601 'builder': {
3602 'bucket': 'try',
3603 'builder': 'my-builder',
3604 'project': 'chromium'
3605 },
3606 'gerritChanges': [self.exampleGerritChange()],
3607 'properties': {
3608 'category': 'git_cl_try'
3609 },
3610 'tags': [{
3611 'key': 'builder',
3612 'value': 'my-builder'
3613 }, {
3614 'key': 'user_agent',
3615 'value': 'git_cl_try'
3616 }]
3617 }
3618 }])
3619
3620 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3621 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3622 jobs = [('chromium', 'try', 'presubmit')]
3623 options = optparse.Values()
3624 requests = git_cl._make_tryjob_schedule_requests(
3625 changelist, jobs, options, patchset=None)
3626 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3627 'category': 'git_cl_try',
3628 'dry_run': 'true'
3629 })
3630
3631 def testMakeRequestsHelperRevisionSet(self):
3632 # Gitiles commit is specified when revision is in options.
3633 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3634 jobs = [('chromium', 'try', 'my-builder')]
3635 options = optparse.Values({'revision': 'ba5eba11'})
3636 requests = git_cl._make_tryjob_schedule_requests(
3637 changelist, jobs, options, patchset=None)
3638 self.assertEqual(
3639 requests[0]['scheduleBuild']['gitilesCommit'], {
3640 'host': 'chromium-review.googlesource.com',
3641 'id': 'ba5eba11',
3642 'project': 'depot_tools'
3643 })
3644
3645 def testMakeRequestsHelperRetryFailedSet(self):
3646 # An extra tag is added when retry_failed is in options.
3647 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3648 jobs = [('chromium', 'try', 'my-builder')]
3649 options = optparse.Values({'retry_failed': 'true'})
3650 requests = git_cl._make_tryjob_schedule_requests(
3651 changelist, jobs, options, patchset=None)
3652 self.assertEqual(
3653 requests[0]['scheduleBuild']['tags'], [
3654 {
3655 'key': 'builder',
3656 'value': 'my-builder'
3657 },
3658 {
3659 'key': 'user_agent',
3660 'value': 'git_cl_try'
3661 },
3662 {
3663 'key': 'retry_failed',
3664 'value': '1'
3665 }
3666 ])
3667
3668 def testMakeRequestsHelperCategorySet(self):
Quinten Yearsley925cedb2020-04-13 17:49:39 +00003669 # The category property can be overridden with options.
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003670 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3671 jobs = [('chromium', 'try', 'my-builder')]
3672 options = optparse.Values({'category': 'my-special-category'})
3673 requests = git_cl._make_tryjob_schedule_requests(
3674 changelist, jobs, options, patchset=None)
3675 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3676 {'category': 'my-special-category'})
3677
3678
Edward Lemurda4b6c62020-02-13 00:28:40 +00003679class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003680
3681 def setUp(self):
3682 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003683 mock.patch('git_cl.RunCommand').start()
3684 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3685 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3686 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003687 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003688 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003689
3690 def tearDown(self):
3691 shutil.rmtree(self._top_dir)
3692 super(CMDFormatTestCase, self).tearDown()
3693
Jamie Madill5e96ad12020-01-13 16:08:35 +00003694 def _make_temp_file(self, fname, contents):
3695 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3696 tf.write('\n'.join(contents))
3697
Brian Sheedy59b06a82019-10-14 17:03:29 +00003698 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003699 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003700
Brian Sheedyb4307d52019-12-02 19:18:17 +00003701 def _check_yapf_filtering(self, files, expected):
3702 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3703 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003704
Edward Lemur1a83da12020-03-04 21:18:36 +00003705 def _run_command_mock(self, return_value):
3706 def f(*args, **kwargs):
3707 if 'stdin' in kwargs:
3708 self.assertIsInstance(kwargs['stdin'], bytes)
3709 return return_value
3710 return f
3711
Jamie Madill5e96ad12020-01-13 16:08:35 +00003712 def testClangFormatDiffFull(self):
3713 self._make_temp_file('test.cc', ['// test'])
3714 git_cl.settings.GetFormatFullByDefault.return_value = False
3715 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3716 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3717
3718 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003719 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003720 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3721 self._top_dir, 'HEAD')
3722 self.assertEqual(2, return_value)
3723
3724 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003725 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003726 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3727 self._top_dir, 'HEAD')
3728 self.assertEqual(0, return_value)
3729
3730 def testClangFormatDiff(self):
3731 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00003732 # A valid file is required, so use this test.
3733 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00003734 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3735
3736 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003737 git_cl.RunCommand.side_effect = self._run_command_mock('error')
3738 return_value = git_cl._RunClangFormatDiff(
3739 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003740 self.assertEqual(2, return_value)
3741
3742 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003743 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003744 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3745 'HEAD')
3746 self.assertEqual(0, return_value)
3747
Brian Sheedyb4307d52019-12-02 19:18:17 +00003748 def testYapfignoreExplicit(self):
3749 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3750 files = [
3751 'bar.py',
3752 'foo/bar.py',
3753 'foo/baz.py',
3754 'foo/bar/baz.py',
3755 'foo/bar/foobar.py',
3756 ]
3757 expected = [
3758 'bar.py',
3759 'foo/baz.py',
3760 'foo/bar/foobar.py',
3761 ]
3762 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003763
Brian Sheedyb4307d52019-12-02 19:18:17 +00003764 def testYapfignoreSingleWildcards(self):
3765 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3766 files = [
3767 'bar.py', # Matched by *bar.py.
3768 'bar.txt',
3769 'foobar.py', # Matched by *bar.py, foo*.
3770 'foobar.txt', # Matched by foo*.
3771 'bazbar.py', # Matched by *bar.py, baz*.py.
3772 'bazbar.txt',
3773 'foo/baz.txt', # Matched by foo*.
3774 'bar/bar.py', # Matched by *bar.py.
3775 'baz/foo.py', # Matched by baz*.py, foo*.
3776 'baz/foo.txt',
3777 ]
3778 expected = [
3779 'bar.txt',
3780 'bazbar.txt',
3781 'baz/foo.txt',
3782 ]
3783 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003784
Brian Sheedyb4307d52019-12-02 19:18:17 +00003785 def testYapfignoreMultiplewildcards(self):
3786 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3787 files = [
3788 'bar.py', # Matched by *bar*.
3789 'bar.txt', # Matched by *bar*.
3790 'abar.py', # Matched by *bar*.
3791 'foobaz.txt', # Matched by *foo*baz.txt.
3792 'foobaz.py',
3793 'afoobaz.txt', # Matched by *foo*baz.txt.
3794 ]
3795 expected = [
3796 'foobaz.py',
3797 ]
3798 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003799
3800 def testYapfignoreComments(self):
3801 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003802 files = [
3803 'test.py',
3804 'test2.py',
3805 ]
3806 expected = [
3807 'test2.py',
3808 ]
3809 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003810
3811 def testYapfignoreBlankLines(self):
3812 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003813 files = [
3814 'test.py',
3815 'test2.py',
3816 'test3.py',
3817 ]
3818 expected = [
3819 'test3.py',
3820 ]
3821 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003822
3823 def testYapfignoreWhitespace(self):
3824 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003825 files = [
3826 'test.py',
3827 'test2.py',
3828 ]
3829 expected = [
3830 'test2.py',
3831 ]
3832 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003833
Brian Sheedyb4307d52019-12-02 19:18:17 +00003834 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003835 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003836 self._check_yapf_filtering([], [])
3837
3838 def testYapfignoreMissingYapfignore(self):
3839 files = [
3840 'test.py',
3841 ]
3842 expected = [
3843 'test.py',
3844 ]
3845 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003846
3847
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003848class CMDStatusTestCase(CMDTestCaseBase):
3849 # Return branch names a,..,f with comitterdates in increasing order, i.e.
3850 # 'f' is the most-recently changed branch.
3851 def _mock_run_git(commands):
3852 if commands == [
3853 'for-each-ref', '--format=%(refname) %(committerdate:unix)',
3854 'refs/heads'
3855 ]:
3856 branches_and_committerdates = [
3857 'refs/heads/a 1',
3858 'refs/heads/b 2',
3859 'refs/heads/c 3',
3860 'refs/heads/d 4',
3861 'refs/heads/e 5',
3862 'refs/heads/f 6',
3863 ]
3864 return '\n'.join(branches_and_committerdates)
3865
3866 # Mock the status in such a way that the issue number gives us an
3867 # indication of the commit date (simplifies manual debugging).
3868 def _mock_get_cl_statuses(branches, fine_grained, max_processes):
3869 for c in branches:
3870 c.issue = (100 + int(c.GetCommitDate()))
3871 yield (c, 'open')
3872
3873 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
3874 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
3875 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
3876 @mock.patch('git_cl.RunGit', _mock_run_git)
3877 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
3878 @mock.patch('git_cl.Settings.GetRoot', return_value='')
3879 @mock.patch('scm.GIT.GetBranch', return_value='a')
3880 def testStatus(self, *_mocks):
3881 self.assertEqual(0, git_cl.main(['status', '--no-branch-color']))
3882 self.maxDiff = None
3883 self.assertEqual(
3884 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
3885 ' * a : https://crrev.com/c/101 (open)\n'
3886 ' b : https://crrev.com/c/102 (open)\n'
3887 ' c : https://crrev.com/c/103 (open)\n'
3888 ' d : https://crrev.com/c/104 (open)\n'
3889 ' e : https://crrev.com/c/105 (open)\n'
3890 ' f : https://crrev.com/c/106 (open)\n\n'
3891 'Current branch: a\n'
3892 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
3893 'Issue description:\n'
3894 'x\n')
3895
3896 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
3897 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
3898 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
3899 @mock.patch('git_cl.RunGit', _mock_run_git)
3900 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
3901 @mock.patch('git_cl.Settings.GetRoot', return_value='')
3902 @mock.patch('scm.GIT.GetBranch', return_value='a')
3903 def testStatusByDate(self, *_mocks):
3904 self.assertEqual(
3905 0, git_cl.main(['status', '--no-branch-color', '--date-order']))
3906 self.maxDiff = None
3907 self.assertEqual(
3908 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
3909 ' f : https://crrev.com/c/106 (open)\n'
3910 ' e : https://crrev.com/c/105 (open)\n'
3911 ' d : https://crrev.com/c/104 (open)\n'
3912 ' c : https://crrev.com/c/103 (open)\n'
3913 ' b : https://crrev.com/c/102 (open)\n'
3914 ' * a : https://crrev.com/c/101 (open)\n\n'
3915 'Current branch: a\n'
3916 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
3917 'Issue description:\n'
3918 'x\n')
3919
3920
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003921if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003922 logging.basicConfig(
3923 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003924 unittest.main()