blob: 64196c97a151d1ce32d0cb137b11f227a264add3 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
34# We have to disable monitoring before importing git_cl.
35metrics.DISABLE_METRICS_COLLECTION = True
36
Jamie Madill5e96ad12020-01-13 16:08:35 +000037import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000038import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000039import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000040import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000041import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000042import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000043import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000044import git_new_branch
45import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000046import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000047
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000048NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
49
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000050
Edward Lemur0db01f02019-11-12 22:01:51 +000051def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070052 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
53
tandrii5d48c322016-08-18 16:19:37 -070054CERR1 = callError(1)
55
56
Edward Lemur1773f372020-02-22 00:27:14 +000057class TemporaryFileMock(object):
58 def __init__(self):
59 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070060
Edward Lemur1773f372020-02-22 00:27:14 +000061 @contextlib.contextmanager
62 def __call__(self):
63 self.suffix += 1
64 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070065
66
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000067class ChangelistMock(object):
68 # A class variable so we can access it when we don't have access to the
69 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000070 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000071
72 def __init__(self, gerrit_change=None, **kwargs):
73 self._gerrit_change = gerrit_change
74
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000075 def GetIssue(self):
76 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000077
Edward Lemur6c6827c2020-02-06 21:15:18 +000078 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000079 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000080
dsansomee2d6fd92016-09-08 00:10:47 -070081 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000082 ChangelistMock.desc = desc
83
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000084 def GetGerritChange(self, patchset=None, **kwargs):
85 del patchset
86 return self._gerrit_change
87
tandrii5d48c322016-08-18 16:19:37 -070088
Edward Lemur85153282020-02-14 22:06:29 +000089class GitMocks(object):
90 def __init__(self, config=None, branchref=None):
91 self.branchref = branchref or 'refs/heads/master'
92 self.config = config or {}
93
94 def GetBranchRef(self, _root):
95 return self.branchref
96
97 def NewBranch(self, branchref):
98 self.branchref = branchref
99
Edward Lemur26964072020-02-19 19:18:51 +0000100 def GetConfig(self, root, key, default=None):
101 if root != '':
102 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000103 return self.config.get(key, default)
104
Edward Lemur26964072020-02-19 19:18:51 +0000105 def SetConfig(self, root, key, value=None):
106 if root != '':
107 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000108 if value:
109 self.config[key] = value
110 return
111 if key not in self.config:
112 raise CERR1
113 del self.config[key]
114
115
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000116class WatchlistsMock(object):
117 def __init__(self, _):
118 pass
119 @staticmethod
120 def GetWatchersForPaths(_):
121 return ['joe@example.com']
122
123
Edward Lemur4c707a22019-09-24 21:13:43 +0000124class CodereviewSettingsFileMock(object):
125 def __init__(self):
126 pass
127 # pylint: disable=no-self-use
128 def read(self):
129 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
130 'GERRIT_HOST: True\n')
131
132
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000133class AuthenticatorMock(object):
134 def __init__(self, *_args):
135 pass
136 def has_cached_credentials(self):
137 return True
tandrii221ab252016-10-06 08:12:04 -0700138 def authorize(self, http):
139 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000140
141
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100142def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000143 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
144
145 Usage:
146 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000148
149 OR
150 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100151 CookiesAuthenticatorMockFactory(
152 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000153 """
154 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800155 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000156 # Intentionally not calling super() because it reads actual cookie files.
157 pass
158 @classmethod
159 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000160 return os.path.join('~', '.gitcookies')
161
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162 @classmethod
163 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000164 return os.path.join('~', NETRC_FILENAME)
165
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100166 def _get_auth_for_host(self, host):
167 if same_auth:
168 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000169 return (hosts_with_creds or {}).get(host)
170 return CookiesAuthenticatorMock
171
Aaron Gable9a03ae02017-11-03 11:31:07 -0700172
kmarshall9249e012016-08-23 12:02:16 -0700173class MockChangelistWithBranchAndIssue():
174 def __init__(self, branch, issue):
175 self.branch = branch
176 self.issue = issue
177 def GetBranch(self):
178 return self.branch
179 def GetIssue(self):
180 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000181
tandriic2405f52016-10-10 08:13:15 -0700182
183class SystemExitMock(Exception):
184 pass
185
186
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000187class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000188 def setUp(self):
189 mock.patch('sys.exit', side_effect=SystemExitMock).start()
190 mock.patch('sys.stdout', StringIO()).start()
191 mock.patch('sys.stderr', StringIO()).start()
192 self.addCleanup(mock.patch.stopall)
193
194 def test_die_with_error(self):
195 with self.assertRaises(SystemExitMock):
196 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
197 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
198 self.assertTrue('saving CL description' in sys.stdout.getvalue())
199 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
200 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
201 sys.exit.assert_called_once_with(1)
202
203 def test_die_with_error_no_desc(self):
204 with self.assertRaises(SystemExitMock):
205 git_cl.DieWithError('foo')
206 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
207 self.assertEqual(sys.stdout.getvalue(), '')
208 sys.exit.assert_called_once_with(1)
209
Edward Lemur6c6827c2020-02-06 21:15:18 +0000210 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000211 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100212 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000213 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700214
Edward Lemur61bf4172020-02-24 23:22:37 +0000215 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
216 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
217 def test_get_cl_statuses(self, *_mocks):
218 statuses = [
219 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
220 changes = []
221 for status in statuses:
222 cl = git_cl.Changelist()
223 cl.status = status
224 changes.append(cl)
225
226 actual = set(git_cl.get_cl_statuses(changes, True))
227 self.assertEqual(set(zip(changes, statuses)), actual)
228
229 def test_get_cl_statuses_no_changes(self):
230 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
231
232 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
233 @mock.patch('multiprocessing.pool.ThreadPool')
234 def test_get_cl_statuses_timeout(self, *_mocks):
235 changes = [git_cl.Changelist() for _ in range(2)]
236 pool = multiprocessing.pool.ThreadPool()
237 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
238 it.return_value.next.side_effect = [
239 (changes[0], 'lgtm'),
240 multiprocessing.TimeoutError,
241 ]
242
243 actual = list(git_cl.get_cl_statuses(changes, True))
244 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
245
246 @mock.patch('git_cl.Changelist.GetIssueURL')
247 def test_get_cl_statuses_not_finegrained(self, _mock):
248 changes = [git_cl.Changelist() for _ in range(2)]
249 urls = ['some-url', None]
250 git_cl.Changelist.GetIssueURL.side_effect = urls
251
252 actual = set(git_cl.get_cl_statuses(changes, False))
253 self.assertEqual(
254 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
255
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000256 def test_get_issue_url(self):
257 cl = git_cl.Changelist(issue=123)
258 cl._gerrit_server = 'https://example.com'
259 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
260 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
261
262 cl = git_cl.Changelist(issue=123)
263 cl._gerrit_server = 'https://chromium-review.googlesource.com'
264 self.assertEqual(cl.GetIssueURL(),
265 'https://chromium-review.googlesource.com/123')
266 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
267
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000268 def test_set_preserve_tryjobs(self):
269 d = git_cl.ChangeDescription('Simple.')
270 d.set_preserve_tryjobs()
271 self.assertEqual(d.description.splitlines(), [
272 'Simple.',
273 '',
274 'Cq-Do-Not-Cancel-Tryjobs: true',
275 ])
276 before = d.description
277 d.set_preserve_tryjobs()
278 self.assertEqual(before, d.description)
279
280 d = git_cl.ChangeDescription('\n'.join([
281 'One is enough',
282 '',
283 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
284 'Change-Id: Ideadbeef',
285 ]))
286 d.set_preserve_tryjobs()
287 self.assertEqual(d.description.splitlines(), [
288 'One is enough',
289 '',
290 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
291 'Change-Id: Ideadbeef',
292 'Cq-Do-Not-Cancel-Tryjobs: true',
293 ])
294
tandriif9aefb72016-07-01 09:06:51 -0700295 def test_get_bug_line_values(self):
296 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
297 self.assertEqual(f('', ''), [])
298 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
Lei Zhang8a0efc12020-08-05 19:58:45 +0000299 # Prefix that ends with colon.
300 self.assertEqual(f('v8:', '456'), ['v8:456'])
301 self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
302 # Prefix that ends without colon.
tandriif9aefb72016-07-01 09:06:51 -0700303 self.assertEqual(f('v8', '456'), ['v8:456'])
304 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
305 # Not nice, but not worth carying.
Lei Zhang8a0efc12020-08-05 19:58:45 +0000306 self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
307 ['v8:456', 'chromium:123', 'v8:123'])
tandriif9aefb72016-07-01 09:06:51 -0700308 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
309 ['v8:456', 'chromium:123', 'v8:123'])
310
Edward Lemurda4b6c62020-02-13 00:28:40 +0000311 @mock.patch('gerrit_util.GetAccountDetails')
312 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000313 mock_per_account = {
314 'u1': None, # 404, doesn't exist.
315 'u2': {
316 '_account_id': 123124,
317 'avatars': [],
318 'email': 'u2@example.com',
319 'name': 'User Number 2',
320 'status': 'OOO',
321 },
322 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
323 }
324 def GetAccountDetailsMock(_, account):
325 # Poor-man's mock library's side_effect.
326 v = mock_per_account.pop(account)
327 if isinstance(v, Exception):
328 raise v
329 return v
330
Edward Lemurda4b6c62020-02-13 00:28:40 +0000331 mockGetAccountDetails.side_effect = GetAccountDetailsMock
332 actual = git_cl.gerrit_util.ValidAccounts(
333 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000334 self.assertEqual(actual, {
335 'u2': {
336 '_account_id': 123124,
337 'avatars': [],
338 'email': 'u2@example.com',
339 'name': 'User Number 2',
340 'status': 'OOO',
341 },
342 })
343
344
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200345class TestParseIssueURL(unittest.TestCase):
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000346 def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
347 parsed = git_cl.ParseIssueNumberArgument(arg)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200348 self.assertIsNotNone(parsed)
349 if fail:
350 self.assertFalse(parsed.valid)
351 return
352 self.assertTrue(parsed.valid)
353 self.assertEqual(parsed.issue, issue)
354 self.assertEqual(parsed.patchset, patchset)
355 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200356
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000357 def test_basic(self):
358 self._test('123', 123)
359 self._test('', fail=True)
360 self._test('abc', fail=True)
361 self._test('123/1', fail=True)
362 self._test('123a', fail=True)
363 self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
364 self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200365
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000366 def test_gerrit_url(self):
367 self._test('https://codereview.source.com/123', 123, None,
368 'codereview.source.com')
369 self._test('http://chrome-review.source.com/c/123', 123, None,
370 'chrome-review.source.com')
371 self._test('https://chrome-review.source.com/c/123/', 123, None,
372 'chrome-review.source.com')
373 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
374 'chrome-review.source.com')
375 self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
376 'chrome-review.source.com')
377 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
378 'chrome-review.source.com')
379 self._test('https://chrome-review.source.com/123', 123, None,
380 'chrome-review.source.com')
381 self._test('https://chrome-review.source.com/123/4', 123, 4,
382 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200383
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000384 self._test('https://chrome-review.source.com/bad/123/4', fail=True)
385 self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
386 self._test('https://chrome-review.source.com/c/abc/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200387
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000388 def test_short_urls(self):
389 self._test('https://crrev.com/c/2151934', 2151934, None,
390 'chromium-review.googlesource.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200391
392
Edward Lemurda4b6c62020-02-13 00:28:40 +0000393class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100394 def setUp(self):
395 super(GitCookiesCheckerTest, self).setUp()
396 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100397 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000398 mock.patch('sys.stdout', StringIO()).start()
399 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100400
401 def mock_hosts_creds(self, subhost_identity_pairs):
402 def ensure_googlesource(h):
403 if not h.endswith(self.c._GOOGLESOURCE):
404 assert not h.endswith('.')
405 return h + '.' + self.c._GOOGLESOURCE
406 return h
407 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
408 for h, i in subhost_identity_pairs]
409
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200410 def test_identity_parsing(self):
411 self.assertEqual(self.c._parse_identity('ldap.google.com'),
412 ('ldap', 'google.com'))
413 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
414 ('ldap', 'example.com'))
415 # Specical case because we know there are no subdomains in chromium.org.
416 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
417 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800418 # Pathological: ".period." can be either username OR domain, more likely
419 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200420 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
421 ('note', 'period.example.com'))
422
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100423 def test_analysis_nothing(self):
424 self.c._all_hosts = []
425 self.assertFalse(self.c.has_generic_host())
426 self.assertEqual(set(), self.c.get_conflicting_hosts())
427 self.assertEqual(set(), self.c.get_duplicated_hosts())
428 self.assertEqual(set(), self.c.get_partially_configured_hosts())
429 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
430
431 def test_analysis(self):
432 self.mock_hosts_creds([
433 ('.googlesource.com', 'git-example.chromium.org'),
434
435 ('chromium', 'git-example.google.com'),
436 ('chromium-review', 'git-example.google.com'),
437 ('chrome-internal', 'git-example.chromium.org'),
438 ('chrome-internal-review', 'git-example.chromium.org'),
439 ('conflict', 'git-example.google.com'),
440 ('conflict-review', 'git-example.chromium.org'),
441 ('dup', 'git-example.google.com'),
442 ('dup', 'git-example.google.com'),
443 ('dup-review', 'git-example.google.com'),
444 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200445 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100446 ])
447 self.assertTrue(self.c.has_generic_host())
448 self.assertEqual(set(['conflict.googlesource.com']),
449 self.c.get_conflicting_hosts())
450 self.assertEqual(set(['dup.googlesource.com']),
451 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200452 self.assertEqual(set(['partial.googlesource.com',
453 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100454 self.c.get_partially_configured_hosts())
455 self.assertEqual(set(['chromium.googlesource.com',
456 'chrome-internal.googlesource.com']),
457 self.c.get_hosts_with_wrong_identities())
458
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100459 def test_report_no_problems(self):
460 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100461 self.assertFalse(self.c.find_and_report_problems())
462 self.assertEqual(sys.stdout.getvalue(), '')
463
Edward Lemurda4b6c62020-02-13 00:28:40 +0000464 @mock.patch(
465 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000466 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000467 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100468 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100469 self.assertTrue(self.c.find_and_report_problems())
470 with open(os.path.join(os.path.dirname(__file__),
471 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000472 expected = f.read() % {
473 'sep': os.sep,
474 }
475
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100476 def by_line(text):
477 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700478 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200479 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100480
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800481
Edward Lemurda4b6c62020-02-13 00:28:40 +0000482class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000483 def setUp(self):
484 super(TestGitCl, self).setUp()
485 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700486 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000487 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000488 mock.patch('sys.stdout', StringIO()).start()
489 mock.patch(
490 'git_cl.time_time',
491 lambda: self._mocked_call('time.time')).start()
492 mock.patch(
493 'git_cl.metrics.collector.add_repeated',
494 lambda *a: self._mocked_call('add_repeated', *a)).start()
495 mock.patch('subprocess2.call', self._mocked_call).start()
496 mock.patch('subprocess2.check_call', self._mocked_call).start()
497 mock.patch('subprocess2.check_output', self._mocked_call).start()
498 mock.patch(
499 'subprocess2.communicate',
500 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
501 mock.patch(
502 'git_cl.gclient_utils.CheckCallAndFilter',
503 self._mocked_call).start()
504 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
505 mock.patch(
506 'git_common.get_or_create_merge_base',
507 lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000508 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
509 mock.patch(
510 'git_cl.SaveDescriptionBackup',
511 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
512 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000513 'git_cl.write_json',
514 lambda *a: self._mocked_call('write_json', *a)).start()
515 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000516 'git_cl.Changelist.RunHook',
517 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000518 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
519 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000520 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000521 mock.patch(
522 'git_cl.gerrit_util.GetChangeComments',
523 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
524 mock.patch(
525 'git_cl.gerrit_util.GetChangeRobotComments',
526 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
527 mock.patch(
528 'git_cl.gerrit_util.AddReviewers',
529 lambda *a: self._mocked_call('AddReviewers', *a)).start()
530 mock.patch(
531 'git_cl.gerrit_util.SetReview',
532 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
533 self._mocked_call(
534 'SetReview', h, i, msg, labels, notify, ready))).start()
535 mock.patch(
536 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
537 return_value=False).start()
538 mock.patch(
539 'git_cl.gerrit_util.GceAuthenticator.is_gce',
540 return_value=False).start()
541 mock.patch(
542 'git_cl.gerrit_util.ValidAccounts',
543 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000544 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000545 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000546 self.mockGit = GitMocks()
547 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
548 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
Edward Lesmes50da7702020-03-30 19:23:43 +0000549 mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
550 mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
Edward Lemur85153282020-02-14 22:06:29 +0000551 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000552 mock.patch(
553 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000554 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000555 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000556 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000557 mock.patch(
558 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000559 # It's important to reset settings to not have inter-tests interference.
560 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000561 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000562
563 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000564 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000565 if not self.failed:
566 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100567 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000568 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
569 if len(self.calls) > 5:
570 calls += ' ...\n'
571 self.fail(
572 '\n'
573 'There are un-consumed calls after this test has finished:\n' +
574 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000575 finally:
576 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000577
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000578 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000579 self.assertTrue(
580 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700581 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000582 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000583 expected_args, result = top
584
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000585 # Also logs otherwise it could get caught in a try/finally and be hard to
586 # diagnose.
587 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700588 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000589 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700590 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
591 for i, c in enumerate(self._calls_done[-N:]))
592 following_calls = '\n '.join(
593 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
594 for i, c in enumerate(self.calls[:N]))
595 extended_msg = (
596 'A few prior calls:\n %s\n\n'
597 'This (expected):\n @%d: %r\n'
598 'This (actual):\n @%d: %r\n\n'
599 'A few following expected calls:\n %s' %
600 (prior_calls, len(self._calls_done), expected_args,
601 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700602
Edward Lesmes0dd54822020-03-26 18:24:25 +0000603 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700604 self.fail('@%d\n'
605 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000606 ' Actual: %r\n'
607 '\n'
608 '%s' % (
609 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700610
611 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700612 if isinstance(result, Exception):
613 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000614 # stdout from git commands is supposed to be a bytestream. Convert it here
615 # instead of converting all test output in this file to bytes.
616 if args[0][0] == 'git' and not isinstance(result, bytes):
617 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000618 return result
619
Edward Lemur1a83da12020-03-04 21:18:36 +0000620 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
621 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100622 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100623 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000624 self.assertEqual(
625 'prompt [Yes/No]: Please, type yes or no: ',
626 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100627
tandrii48df5812016-10-17 03:55:37 -0700628 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000629 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700630 self.calls = [
631 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700632 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
633 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
634 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
635 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700636 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
637 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700638 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
639 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000640 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
641 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700642 ((['git', 'config', 'gerrit.host', 'true'],), ''),
643 ]
644 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
645
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000646 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100647 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200648 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000649 custom_cl_base=None, short_hostname='chromium',
650 change_id=None):
Edward Lemur26964072020-02-19 19:18:51 +0000651 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200652 if custom_cl_base:
653 ancestor_revision = custom_cl_base
654 else:
655 # Determine ancestor_revision to be merge base.
656 ancestor_revision = 'fake_ancestor_sha'
657 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000658 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
659 ancestor_revision),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200660 ]
661
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100662 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000663 gerrit_util.GetChangeDetail.return_value = {
664 'owner': {'email': (other_cl_owner or 'owner@example.com')},
665 'change_id': (change_id or '123456789'),
666 'current_revision': 'sha1_of_current_revision',
667 'revisions': {'sha1_of_current_revision': {
668 'commit': {'message': fetched_description},
669 }},
670 'status': fetched_status or 'NEW',
671 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100672 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100673 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100674 if other_cl_owner:
675 calls += [
676 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
677 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100678
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100679 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200680 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
681 ([custom_cl_base] if custom_cl_base else
682 [ancestor_revision, 'HEAD']),),
683 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100684 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000685
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100686 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000687
Edward Lemur26964072020-02-19 19:18:51 +0000688 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700689 squash_mode='default',
Aaron Gablefd238082017-06-07 13:42:34 -0700690 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100691 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000692 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000693 short_hostname='chromium',
Edward Lemur5a644f82020-03-18 16:44:57 +0000694 labels=None, change_id=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000695 final_description=None, gitcookies_exists=True,
Josipe827b0f2020-01-30 00:07:20 +0000696 force=False, edit_description=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000697 if post_amend_description is None:
698 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700699 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200700
701 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000702
Edward Lesmes4de54132020-05-05 19:41:33 +0000703 if squash_mode in ('override_squash', 'override_nosquash'):
704 self.mockGit.config['gerrit.override-squash-uploads'] = (
705 'true' if squash_mode == 'override_squash' else 'false')
706
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000707 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000708 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200709 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200710 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000711 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000712 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000713 calls += [
714 ((['RunEditor'],), description),
715 ]
Josipe827b0f2020-01-30 00:07:20 +0000716 # user wants to edit description
717 if edit_description:
718 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000719 ((['RunEditor'],), edit_description),
720 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000721 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200722
723 if custom_cl_base is None:
724 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000725 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000726 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200727 ]
728 parent = 'origin/master'
729 else:
730 calls += [
731 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
732 'refs/remotes/origin/master'],),
733 callError(1)), # Means not ancenstor.
734 (('ask_for_data',
735 'Do you take responsibility for cleaning up potential mess '
736 'resulting from proceeding with upload? Press Enter to upload, '
737 'or Ctrl+C to abort'), ''),
738 ]
739 parent = custom_cl_base
740
741 calls += [
742 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
743 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000744 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200745 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000746 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200747 ref_to_push),
748 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000749 else:
750 ref_to_push = 'HEAD'
Edward Lemur5a644f82020-03-18 16:44:57 +0000751 parent = 'origin/refs/heads/master'
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000752
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000753 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000754 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000755 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200756 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000757
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000758 metrics_arguments = []
759
Aaron Gableafd52772017-06-27 16:40:10 -0700760 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700761 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000762 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700763 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400764 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700765 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000766 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700767 else:
768 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000769 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800770
Edward Lemur5a644f82020-03-18 16:44:57 +0000771 # If issue is given, then description is fetched from Gerrit instead.
772 if issue is None:
773 if squash:
774 title = 'Initial upload'
775 else:
776 if not title:
777 calls += [
778 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
779 (('ask_for_data', 'Title for patchset []: '), 'User input'),
780 ]
781 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700782 if title:
Edward Lemur5a644f82020-03-18 16:44:57 +0000783 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000784 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000785
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000786 if short_hostname == 'chromium':
Quinten Yearsley925cedb2020-04-13 17:49:39 +0000787 # All reviewers and ccs get into ref_suffix.
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000788 for r in sorted(reviewers):
789 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000790 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000791 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000792 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000793 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000794 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000795 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000796 reviewers, cc = [], []
797 else:
798 # TODO(crbug/877717): remove this case.
799 calls += [
800 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
801 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000802 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000803 {
804 e: {'email': e}
805 for e in (reviewers + ['joe@example.com'] + cc)
806 })
807 ]
808 for r in sorted(reviewers):
809 if r != 'bad-account-or-email':
810 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000811 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000812 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000813 if issue is None:
814 cc += ['joe@example.com']
815 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000816 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000817 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000818 if c in cc:
819 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000820
Edward Lemur687ca902018-12-05 02:30:30 +0000821 for k, v in sorted((labels or {}).items()):
822 ref_suffix += ',l=%s+%d' % (k, v)
823 metrics_arguments.append('l=%s+%d' % (k, v))
824
825 if tbr:
826 calls += [
827 (('GetCodeReviewTbrScore',
828 '%s-review.googlesource.com' % short_hostname,
829 'my/repo'),
830 2,),
831 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000832
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000833 calls += [
834 (('time.time',), 1000,),
835 ((['git', 'push',
836 'https://%s.googlesource.com/my/repo' % short_hostname,
837 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
838 (('remote:\n'
839 'remote: Processing changes: (\)\n'
840 'remote: Processing changes: (|)\n'
841 'remote: Processing changes: (/)\n'
842 'remote: Processing changes: (-)\n'
843 'remote: Processing changes: new: 1 (/)\n'
844 'remote: Processing changes: new: 1, done\n'
845 'remote:\n'
846 'remote: New Changes:\n'
847 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
848 ' XXX\n'
849 'remote:\n'
850 'To https://%s.googlesource.com/my/repo\n'
851 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
852 ) % (short_hostname, short_hostname)),),
853 (('time.time',), 2000,),
854 (('add_repeated',
855 'sub_commands',
856 {
857 'execution_time': 1000,
858 'command': 'git push',
859 'exit_code': 0,
860 'arguments': sorted(metrics_arguments),
861 }),
862 None,),
863 ]
864
Edward Lemur1b52d872019-05-09 21:12:12 +0000865 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000866
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000867 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
868
Edward Lemur1b52d872019-05-09 21:12:12 +0000869 # Trace-related calls
870 calls += [
871 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000872 (
873 ([
874 'FileWrite', trace_name + '-README',
875 '%(date)s\n'
876 '%(short_hostname)s-review.googlesource.com\n'
877 '%(change_id)s\n'
878 '%(title)s\n'
879 '%(description)s\n'
880 '1000\n'
881 '0\n'
882 '%(trace_name)s' % {
Josip Sokcevic5e18b602020-04-23 21:47:00 +0000883 'date': '2017-03-16T20:00:41.000000',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000884 'short_hostname': short_hostname,
885 'change_id': change_id,
886 'description': final_description,
887 'title': title or '<untitled>',
888 'trace_name': trace_name,
889 }
890 ], ),
891 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000892 ),
893 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000894 (
895 (['os.path.isfile',
896 os.path.join('TEMP_DIR', 'trace-packet')], ),
897 True,
Edward Lemur1b52d872019-05-09 21:12:12 +0000898 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000899 (
900 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
901 ('git-hash: 0123456789012345678901234567890123456789\n'
902 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +0000903 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000904 (
905 ([
906 'FileWrite',
907 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
908 'git-hash: abcdea\n'
909 ], ),
910 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000911 ),
912 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000913 (
914 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
915 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000916 ),
917 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000918 (
919 (['git', 'config', '-l'], ),
920 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +0000921 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000922 (
923 ([
924 'FileWrite',
925 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
926 ], ),
927 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000928 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000929 (
930 (['os.path.isfile',
931 os.path.join('~', '.gitcookies')], ),
932 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +0000933 ),
934 ]
935 if gitcookies_exists:
936 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000937 (
938 (['FileRead', os.path.join('~', '.gitcookies')], ),
939 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +0000940 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000941 (
942 ([
943 'FileWrite',
944 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
945 ], ),
946 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000947 ),
948 ]
949 calls += [
950 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000951 (
952 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
953 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000954 ),
955 ]
956
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000957 # TODO(crbug/877717): this should never be used.
958 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +0000959 calls += [
960 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +0000961 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +0000962 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +0000963 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +0000964 notify),
965 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +0000966 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +0000967 return calls
968
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000969 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +0000970 self,
971 upload_args,
972 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +0000973 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -0700974 squash=True,
975 squash_mode=None,
Aaron Gable9b713dd2016-12-14 16:04:21 -0800976 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000977 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000978 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -0700979 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100980 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100981 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200982 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -0700983 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000984 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000985 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000986 labels=None,
987 change_id=None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000988 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000989 gitcookies_exists=True,
990 force=False,
Edward Lesmes0dd54822020-03-26 18:24:25 +0000991 log_description=None,
Josipe827b0f2020-01-30 00:07:20 +0000992 edit_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000993 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000994 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -0700995 if squash_mode is None:
996 if '--no-squash' in upload_args:
997 squash_mode = 'nosquash'
998 elif '--squash' in upload_args:
999 squash_mode = 'squash'
1000 else:
1001 squash_mode = 'default'
1002
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001003 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001004 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001005 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001006 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001007 same_auth=('git-owner.example.com', '', 'pass'))).start()
1008 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1009 lambda _, offer_removal: None).start()
1010 mock.patch('git_cl.gclient_utils.RunEditor',
1011 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1012 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001013 'DownloadGerritHook', force)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001014 mock.patch('git_cl.gclient_utils.FileRead',
1015 lambda path: self._mocked_call(['FileRead', path])).start()
1016 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001017 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001018 ['FileWrite', path, contents])).start()
1019 mock.patch('git_cl.datetime_now',
1020 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1021 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1022 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1023 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001024 '%(now)s\n'
1025 '%(gerrit_host)s\n'
1026 '%(change_id)s\n'
1027 '%(title)s\n'
1028 '%(description)s\n'
1029 '%(execution_time)s\n'
1030 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001031 '%(trace_name)s').start()
1032 mock.patch('git_cl.shutil.make_archive',
1033 lambda *args: self._mocked_call(['make_archive'] +
1034 list(args))).start()
1035 mock.patch('os.path.isfile',
1036 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001037 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001038 'git_cl._create_description_from_log',
1039 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001040 mock.patch(
1041 'git_cl.Changelist._AddChangeIdToCommitMessage',
1042 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001043 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001044 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1045 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001046 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001047 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001048
Edward Lemur26964072020-02-19 19:18:51 +00001049 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001050 self.mockGit.config['branch.master.gerritissue'] = (
1051 str(issue) if issue else None)
1052 self.mockGit.config['remote.origin.url'] = (
1053 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001054 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001055
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001056 self.calls = self._gerrit_base_calls(
1057 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001058 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001059 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001060 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001061 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001062 short_hostname=short_hostname,
1063 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001064 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001065 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001066 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001067 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001068 self.calls += self._gerrit_upload_calls(
1069 description, reviewers, squash,
1070 squash_mode=squash_mode,
Aaron Gablefd238082017-06-07 13:42:34 -07001071 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001072 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001073 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001074 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001075 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001076 labels=labels,
1077 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001078 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001079 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001080 force=force,
1081 edit_description=edit_description)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001082 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001083 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001084 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001085 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001086 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001087 self.assertEqual(
1088 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001089 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001090
Edward Lemur1b52d872019-05-09 21:12:12 +00001091 def test_gerrit_upload_traces_no_gitcookies(self):
1092 self._run_gerrit_upload_test(
1093 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001094 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001095 [],
1096 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001097 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001098 change_id='Ixxx',
1099 gitcookies_exists=False)
1100
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001101 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001102 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001103 [],
1104 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1105 [],
1106 change_id='Ixxx')
1107
1108 def test_gerrit_upload_without_change_id_nosquash(self):
1109 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001110 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001111 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001112 [],
1113 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001114 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001115 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001116
Edward Lesmes4de54132020-05-05 19:41:33 +00001117 def test_gerrit_upload_without_change_id_override_nosquash(self):
1118 self._run_gerrit_upload_test(
1119 [],
1120 'desc ✔\n\nBUG=\n',
1121 [],
1122 squash=False,
1123 squash_mode='override_nosquash',
1124 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1125 change_id='Ixxx')
1126
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001127 def test_gerrit_no_reviewer(self):
1128 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001129 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001130 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001131 [],
1132 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001133 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001134 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001135
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001136 def test_gerrit_no_reviewer_non_chromium_host(self):
1137 # TODO(crbug/877717): remove this test case.
1138 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001139 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001140 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001141 [],
1142 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001143 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001144 short_hostname='other',
1145 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001146
Edward Lesmes0dd54822020-03-26 18:24:25 +00001147 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001148 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001149 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001150 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001151 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001152 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001153 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001154 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001155
ukai@chromium.orge8077812012-02-03 03:41:46 +00001156 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001157 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001158 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001159 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001160 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001161 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001162 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001163 notify=True,
1164 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001165 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001166 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001167
Anthony Polito8b955342019-09-24 19:01:36 +00001168 def test_gerrit_upload_force_sets_bug(self):
1169 self._run_gerrit_upload_test(
1170 ['-b', '10000', '-f'],
1171 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1172 [],
1173 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001174 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001175 change_id='Ixxx')
1176
Edward Lemur5fb22242020-03-12 22:05:13 +00001177 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001178 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001179 ['-b', '10000', '-m', 'Title', '--edit-description'],
1180 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001181 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001182 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001183 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001184 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001185 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001186 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001187
Dan Beamd8b04ca2019-10-10 21:23:26 +00001188 def test_gerrit_upload_force_sets_fixed(self):
1189 self._run_gerrit_upload_test(
1190 ['-x', '10000', '-f'],
1191 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1192 [],
1193 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001194 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001195 change_id='Ixxx')
1196
ukai@chromium.orge8077812012-02-03 03:41:46 +00001197 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001198 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1199 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001200 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001201 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001202 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001203 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001204 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001205 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001206 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001207 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001208 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001209 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001210
1211 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001212 self._run_gerrit_upload_test(
1213 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001214 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001215 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001216 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001217
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001218 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001219 self._run_gerrit_upload_test(
1220 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001221 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001222 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001223 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001224 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001225
Edward Lesmes0dd54822020-03-26 18:24:25 +00001226 def test_gerrit_upload_squash_first_title(self):
1227 self._run_gerrit_upload_test(
1228 ['-f', '-t', 'title'],
1229 'title\n\ndesc\n\nChange-Id: 123456789',
1230 [],
1231 force=True,
1232 squash=True,
1233 log_description='desc',
1234 change_id='123456789')
1235
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001236 def test_gerrit_upload_squash_first_with_labels(self):
1237 self._run_gerrit_upload_test(
1238 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001239 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001240 [],
1241 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001242 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001243 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001244
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001245 def test_gerrit_upload_squash_first_against_rev(self):
1246 custom_cl_base = 'custom_cl_base_rev_or_branch'
1247 self._run_gerrit_upload_test(
1248 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001249 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001250 [],
1251 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001252 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001253 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001254 self.assertIn(
1255 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1256 sys.stdout.getvalue())
1257
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001258 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001259 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001260 self._run_gerrit_upload_test(
1261 ['--squash'],
1262 description,
1263 [],
1264 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001265 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001266 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001267
Edward Lemurd55c5072020-02-20 01:09:07 +00001268 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001269 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001270 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001271 with self.assertRaises(SystemExitMock):
1272 self._run_gerrit_upload_test(
1273 ['--squash'],
1274 description,
1275 [],
1276 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001277 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001278 fetched_status='ABANDONED',
1279 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001280 self.assertEqual(
1281 'Change https://chromium-review.googlesource.com/123456 has been '
1282 'abandoned, new uploads are not allowed\n',
1283 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001284
Edward Lemurda4b6c62020-02-13 00:28:40 +00001285 @mock.patch(
1286 'gerrit_util.GetAccountDetails',
1287 return_value={'email': 'yet-another@example.com'})
1288 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001289 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001290 self._run_gerrit_upload_test(
1291 ['--squash'],
1292 description,
1293 [],
1294 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001295 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001296 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001297 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001298 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001299 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001300 'authenticate to Gerrit as yet-another@example.com.\n'
1301 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001302 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001303
Josipe827b0f2020-01-30 00:07:20 +00001304 def test_upload_change_description_editor(self):
1305 fetched_description = 'foo\n\nChange-Id: 123456789'
1306 description = 'bar\n\nChange-Id: 123456789'
1307 self._run_gerrit_upload_test(
1308 ['--squash', '--edit-description'],
1309 description,
1310 [],
1311 fetched_description=fetched_description,
1312 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001313 issue=123456,
1314 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001315 edit_description=description)
1316
Edward Lemurda4b6c62020-02-13 00:28:40 +00001317 @mock.patch('git_cl.RunGit')
1318 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001319 @mock.patch('sys.stdin', StringIO('\n'))
1320 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001321 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001322 def mock_run_git(*args, **_kwargs):
1323 if args[0] == ['for-each-ref',
1324 '--format=%(refname:short) %(upstream:short)',
1325 'refs/heads']:
1326 # Create a local branch dependency tree that looks like this:
1327 # test1 -> test2 -> test3 -> test4 -> test5
1328 # -> test3.1
1329 # test6 -> test0
1330 branch_deps = [
1331 'test2 test1', # test1 -> test2
1332 'test3 test2', # test2 -> test3
1333 'test3.1 test2', # test2 -> test3.1
1334 'test4 test3', # test3 -> test4
1335 'test5 test4', # test4 -> test5
1336 'test6 test0', # test0 -> test6
1337 'test7', # test7
1338 ]
1339 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001340 git_cl.RunGit.side_effect = mock_run_git
1341 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001342
1343 class MockChangelist():
1344 def __init__(self):
1345 pass
1346 def GetBranch(self):
1347 return 'test1'
1348 def GetIssue(self):
1349 return '123'
1350 def GetPatchset(self):
1351 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001352 def IsGerrit(self):
1353 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001354
1355 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1356 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001357 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001358 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001359 'This command will checkout all dependent branches '
1360 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001361 'or Ctrl+C to abort',
1362 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001363 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001364
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001365 def test_gerrit_change_id(self):
1366 self.calls = [
1367 ((['git', 'write-tree'], ),
1368 'hashtree'),
1369 ((['git', 'rev-parse', 'HEAD~0'], ),
1370 'branch-parent'),
1371 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1372 'A B <a@b.org> 1456848326 +0100'),
1373 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1374 'C D <c@d.org> 1456858326 +0100'),
1375 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1376 'hashchange'),
1377 ]
1378 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1379 self.assertEqual(change_id, 'Ihashchange')
1380
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001381 def test_desecription_append_footer(self):
1382 for init_desc, footer_line, expected_desc in [
1383 # Use unique desc first lines for easy test failure identification.
1384 ('foo', 'R=one', 'foo\n\nR=one'),
1385 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1386 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1387 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1388 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1389 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1390 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1391 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1392 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1393 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1394 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1395 ]:
1396 desc = git_cl.ChangeDescription(init_desc)
1397 desc.append_footer(footer_line)
1398 self.assertEqual(desc.description, expected_desc)
1399
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001400 def test_update_reviewers(self):
1401 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001402 ('foo', [], [],
1403 'foo'),
1404 ('foo\nR=xx', [], [],
1405 'foo\nR=xx'),
1406 ('foo\nTBR=xx', [], [],
1407 'foo\nTBR=xx'),
1408 ('foo', ['a@c'], [],
1409 'foo\n\nR=a@c'),
1410 ('foo\nR=xx', ['a@c'], [],
1411 'foo\n\nR=a@c, xx'),
1412 ('foo\nTBR=xx', ['a@c'], [],
1413 'foo\n\nR=a@c\nTBR=xx'),
1414 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1415 'foo\n\nR=a@c, yy\nTBR=xx'),
1416 ('foo\nBUG=', ['a@c'], [],
1417 'foo\nBUG=\nR=a@c'),
1418 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1419 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1420 ('foo', ['a@c', 'b@c'], [],
1421 'foo\n\nR=a@c, b@c'),
1422 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1423 'foo\nBar\n\nR=c@c\nBUG='),
1424 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1425 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001426 # Same as the line before, but full of whitespaces.
1427 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001428 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001429 'foo\nBar\n\nR=c@c\n BUG =',
1430 ),
1431 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001432 ('foo BUG=allo R=joe ', ['c@c'], [],
1433 'foo BUG=allo R=joe\n\nR=c@c'),
1434 # Redundant TBRs get promoted to Rs
1435 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1436 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001437 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001438 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001439 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001440 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001441 obj = git_cl.ChangeDescription(orig)
Edward Lemur2c62b332020-03-12 22:12:33 +00001442 obj.update_reviewers(reviewers, tbrs, None, None, None)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001443 actual.append(obj.description)
1444 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001445
Nodir Turakulov23b82142017-11-16 11:04:25 -08001446 def test_get_hash_tags(self):
1447 cases = [
1448 ('', []),
1449 ('a', []),
1450 ('[a]', ['a']),
1451 ('[aa]', ['aa']),
1452 ('[a ]', ['a']),
1453 ('[a- ]', ['a']),
1454 ('[a- b]', ['a-b']),
1455 ('[a--b]', ['a-b']),
1456 ('[a', []),
1457 ('[a]x', ['a']),
1458 ('[aa]x', ['aa']),
1459 ('[a b]', ['a-b']),
1460 ('[a b]', ['a-b']),
1461 ('[a__b]', ['a-b']),
1462 ('[a] x', ['a']),
1463 ('[a][b]', ['a', 'b']),
1464 ('[a] [b]', ['a', 'b']),
1465 ('[a][b]x', ['a', 'b']),
1466 ('[a][b] x', ['a', 'b']),
1467 ('[a]\n[b]', ['a']),
1468 ('[a\nb]', []),
1469 ('[a][', ['a']),
1470 ('Revert "[a] feature"', ['a']),
1471 ('Reland "[a] feature"', ['a']),
1472 ('Revert: [a] feature', ['a']),
1473 ('Reland: [a] feature', ['a']),
1474 ('Revert "Reland: [a] feature"', ['a']),
1475 ('Foo: feature', ['foo']),
1476 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001477 ('Change Foo::Bar', []),
1478 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001479 ('Revert "Foo bar: feature"', ['foo-bar']),
1480 ('Reland "Foo bar: feature"', ['foo-bar']),
1481 ]
1482 for desc, expected in cases:
1483 change_desc = git_cl.ChangeDescription(desc)
1484 actual = change_desc.get_hash_tags()
1485 self.assertEqual(
1486 actual,
1487 expected,
1488 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1489
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001490 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001491 self.assertEqual(None, git_cl.GetTargetRef(None,
1492 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001493 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001494
wittman@chromium.org455dc922015-01-26 20:15:50 +00001495 # Check default target refs for branches.
1496 self.assertEqual('refs/heads/master',
1497 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001498 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001499 self.assertEqual('refs/heads/master',
1500 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001501 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001502 self.assertEqual('refs/heads/master',
1503 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001504 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001505 self.assertEqual('refs/branch-heads/123',
1506 git_cl.GetTargetRef('origin',
1507 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001508 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001509 self.assertEqual('refs/diff/test',
1510 git_cl.GetTargetRef('origin',
1511 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001512 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001513 self.assertEqual('refs/heads/chrome/m42',
1514 git_cl.GetTargetRef('origin',
1515 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001516 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001517
1518 # Check target refs for user-specified target branch.
1519 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1520 'refs/remotes/branch-heads/123'):
1521 self.assertEqual('refs/branch-heads/123',
1522 git_cl.GetTargetRef('origin',
1523 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001524 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001525 for branch in ('origin/master', 'remotes/origin/master',
1526 'refs/remotes/origin/master'):
1527 self.assertEqual('refs/heads/master',
1528 git_cl.GetTargetRef('origin',
1529 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001530 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001531 for branch in ('master', 'heads/master', 'refs/heads/master'):
1532 self.assertEqual('refs/heads/master',
1533 git_cl.GetTargetRef('origin',
1534 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001535 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001536
Edward Lemurda4b6c62020-02-13 00:28:40 +00001537 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1538 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001539 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001540 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1541
Edward Lemur85153282020-02-14 22:06:29 +00001542 def assertIssueAndPatchset(
1543 self, branch='master', issue='123456', patchset='7',
1544 git_short_host='chromium'):
1545 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001546 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001547 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001548 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001549 self.assertEqual(
1550 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001551 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001552
Edward Lemur85153282020-02-14 22:06:29 +00001553 def _patch_common(self, git_short_host='chromium'):
Edward Lesmes50da7702020-03-30 19:23:43 +00001554 mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
Edward Lemur26964072020-02-19 19:18:51 +00001555 self.mockGit.config['remote.origin.url'] = (
1556 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001557 gerrit_util.GetChangeDetail.return_value = {
1558 'current_revision': '7777777777',
1559 'revisions': {
1560 '1111111111': {
1561 '_number': 1,
1562 'fetch': {'http': {
1563 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1564 'ref': 'refs/changes/56/123456/1',
1565 }},
1566 },
1567 '7777777777': {
1568 '_number': 7,
1569 'fetch': {'http': {
1570 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1571 'ref': 'refs/changes/56/123456/7',
1572 }},
1573 },
1574 },
1575 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001576
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001577 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001578 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001579 self.calls += [
1580 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1581 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001582 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001583 ]
1584 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001585 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001586
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001587 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001588 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001589 self.calls += [
1590 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1591 'refs/changes/56/123456/7'],), ''),
1592 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001593 ]
Edward Lemur85153282020-02-14 22:06:29 +00001594 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1595 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001596
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001597 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001598 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001599 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001600 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001601 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001602 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001603 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001604 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001605 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001606
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001607 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001608 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001609 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001610 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001611 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001612 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001613 ]
1614 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001615 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001616 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001617
Aaron Gable697a91b2018-01-19 15:20:15 -08001618 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001619 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001620 self.calls += [
1621 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1622 'refs/changes/56/123456/1'],), ''),
1623 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001624 ]
1625 self.assertEqual(git_cl.main(
1626 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1627 0)
Edward Lemur85153282020-02-14 22:06:29 +00001628 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001629
Edward Lemurd55c5072020-02-20 01:09:07 +00001630 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001631 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001632 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001633 self.calls += [
1634 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001635 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001636 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001637 ]
1638 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001639 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001640 self.assertEqual(
1641 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1642 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001643
Edward Lemurda4b6c62020-02-13 00:28:40 +00001644 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001645 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001646 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001647 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001648 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001649 self.mockGit.config['remote.origin.url'] = (
1650 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001651 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001652 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001653 self.assertEqual(
1654 'change 123456 at https://chromium-review.googlesource.com does not '
1655 'exist or you have no access to it\n',
1656 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001657
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001658 def _checkout_calls(self):
1659 return [
1660 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001661 'branch\\..*\\.gerritissue'], ),
1662 ('branch.ger-branch.gerritissue 123456\n'
1663 'branch.gbranch654.gerritissue 654321\n')),
1664 ]
1665
1666 def test_checkout_gerrit(self):
1667 """Tests git cl checkout <issue>."""
1668 self.calls = self._checkout_calls()
1669 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1670 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1671
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001672 def test_checkout_not_found(self):
1673 """Tests git cl checkout <issue>."""
1674 self.calls = self._checkout_calls()
1675 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1676
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001677 def test_checkout_no_branch_issues(self):
1678 """Tests git cl checkout <issue>."""
1679 self.calls = [
1680 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001681 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001682 ]
1683 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1684
Edward Lemur26964072020-02-19 19:18:51 +00001685 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00001686 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001687 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001688 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001689 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1690 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001691 self.mockGit.config['remote.origin.url'] = (
1692 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001693 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001694 cl.branch = 'master'
1695 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001696 return cl
1697
Edward Lemurd55c5072020-02-20 01:09:07 +00001698 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001699 def test_gerrit_ensure_authenticated_missing(self):
1700 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001701 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001702 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001703 with self.assertRaises(SystemExitMock):
1704 cl.EnsureAuthenticated(force=False)
1705 self.assertEqual(
1706 'Credentials for the following hosts are required:\n'
1707 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001708 'These are read from ~%(sep)s.gitcookies '
1709 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00001710 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001711 'https://chromium-review.googlesource.com/new-password\n' % {
1712 'sep': os.sep,
1713 'netrc': NETRC_FILENAME,
1714 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001715
1716 def test_gerrit_ensure_authenticated_conflict(self):
1717 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001718 'chromium.googlesource.com':
1719 ('git-one.example.com', None, 'secret1'),
1720 'chromium-review.googlesource.com':
1721 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001722 })
1723 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001724 (('ask_for_data', 'If you know what you are doing '
1725 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001726 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1727
1728 def test_gerrit_ensure_authenticated_ok(self):
1729 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001730 'chromium.googlesource.com':
1731 ('git-same.example.com', None, 'secret'),
1732 'chromium-review.googlesource.com':
1733 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001734 })
1735 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1736
tandrii@chromium.org28253532016-04-14 13:46:56 +00001737 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00001738 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
1739 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00001740 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1741
Eric Boren2fb63102018-10-05 13:05:03 +00001742 def test_gerrit_ensure_authenticated_bearer_token(self):
1743 cl = self._test_gerrit_ensure_authenticated_common(auth={
1744 'chromium.googlesource.com':
1745 ('', None, 'secret'),
1746 'chromium-review.googlesource.com':
1747 ('', None, 'secret'),
1748 })
1749 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1750 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1751 'chromium.googlesource.com')
1752 self.assertTrue('Bearer' in header)
1753
Daniel Chengcf6269b2019-05-18 01:02:12 +00001754 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00001755 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00001756 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001757 (('logging.warning',
1758 'Ignoring branch %(branch)s with non-https remote '
1759 '%(remote)s', {
1760 'branch': 'master',
1761 'remote': 'custom-scheme://repo'}
1762 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001763 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001764 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1765 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1766 mock.patch('logging.warning',
1767 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00001768 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00001769 cl.branch = 'master'
1770 cl.branchref = 'refs/heads/master'
1771 cl.lookedup_issue = True
1772 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1773
Florian Mayerae510e82020-01-30 21:04:48 +00001774 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00001775 self.mockGit.config['remote.origin.url'] = (
1776 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00001777 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001778 (('logging.error',
1779 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1780 'but it doesn\'t exist.', {
1781 'remote': 'origin',
1782 'branch': 'master',
1783 'url': 'git@somehost.example:foo/bar.git'}
1784 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00001785 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001786 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1787 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1788 mock.patch('logging.error',
1789 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00001790 cl = git_cl.Changelist()
1791 cl.branch = 'master'
1792 cl.branchref = 'refs/heads/master'
1793 cl.lookedup_issue = True
1794 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1795
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001796 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00001797 self.mockGit.config['branch.master.gerritissue'] = '123'
1798 self.mockGit.config['branch.master.gerritserver'] = (
1799 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00001800 self.mockGit.config['remote.origin.url'] = (
1801 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001802 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00001803 (('SetReview', 'chromium-review.googlesource.com',
1804 'infra%2Finfra~123', None,
1805 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001806 ]
tandriid9e5ce52016-07-13 02:32:59 -07001807
1808 def test_cmd_set_commit_gerrit_clear(self):
1809 self._cmd_set_commit_gerrit_common(0)
1810 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1811
1812 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001813 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001814 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1815
tandriid9e5ce52016-07-13 02:32:59 -07001816 def test_cmd_set_commit_gerrit(self):
1817 self._cmd_set_commit_gerrit_common(2)
1818 self.assertEqual(0, git_cl.main(['set-commit']))
1819
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001820 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001821 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001822 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001823
1824 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001825 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001826
Edward Lemurda4b6c62020-02-13 00:28:40 +00001827 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07001828 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07001829 try:
1830 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00001831 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001832 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001833 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07001834
1835 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07001836 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001837 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07001838 return 'foobar'
1839
Edward Lemurda4b6c62020-02-13 00:28:40 +00001840 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07001841 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001842 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001843 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001844 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07001845
iannuccie53c9352016-08-17 14:40:40 -07001846 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001847
iannuccie53c9352016-08-17 14:40:40 -07001848 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001849 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07001850 return 'foobar'
1851
Edward Lemurda4b6c62020-02-13 00:28:40 +00001852 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
1853 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07001854 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001855 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001856
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001857 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00001858 self.mockGit.config['remote.origin.url'] = (
1859 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001860 gerrit_util.GetChangeDetail.return_value = {
1861 'current_revision': 'sha1',
1862 'revisions': {'sha1': {
1863 'commit': {'message': 'foobar'},
1864 }},
1865 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001866 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001867 'description',
1868 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
1869 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001870 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001871
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001872 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001873 mock.patch('git_cl.Changelist', ChangelistMock).start()
1874 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001875
1876 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
1877 self.assertEqual('hihi', ChangelistMock.desc)
1878
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001879 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001880 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001881
1882 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001883 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001884 '# Enter a description of the change.\n'
1885 '# This will be displayed on the codereview site.\n'
1886 '# The first line will also be used as the subject of the review.\n'
1887 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001888 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07001889 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001890 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001891 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07001892 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001893
Edward Lemur6c6827c2020-02-06 21:15:18 +00001894 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001895 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001896
Edward Lemurda4b6c62020-02-13 00:28:40 +00001897 mock.patch('git_cl.Changelist.FetchDescription',
1898 lambda *args: current_desc).start()
1899 mock.patch('git_cl.Changelist.UpdateDescription',
1900 UpdateDescription).start()
1901 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001902
Edward Lemur85153282020-02-14 22:06:29 +00001903 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00001904 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001905
Dan Beamd8b04ca2019-10-10 21:23:26 +00001906 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
1907 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
1908
1909 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001910 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00001911 '# Enter a description of the change.\n'
1912 '# This will be displayed on the codereview site.\n'
1913 '# The first line will also be used as the subject of the review.\n'
1914 '#--------------------This line is 72 characters long'
1915 '--------------------\n'
1916 'Some.\n\nFixed: 123\nChange-Id: xxx',
1917 desc)
1918 return desc
1919
Edward Lemurda4b6c62020-02-13 00:28:40 +00001920 mock.patch('git_cl.Changelist.FetchDescription',
1921 lambda *args: current_desc).start()
1922 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00001923
Edward Lemur85153282020-02-14 22:06:29 +00001924 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00001925 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00001926
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001927 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001928 mock.patch('git_cl.Changelist', ChangelistMock).start()
1929 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001930
1931 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
1932 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
1933
kmarshall3bff56b2016-06-06 18:31:47 -07001934 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001935 self.calls = [
1936 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00001937 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00001938 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001939 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00001940 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001941 ]
kmarshall3bff56b2016-06-06 18:31:47 -07001942
Edward Lemurda4b6c62020-02-13 00:28:40 +00001943 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07001944 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07001945 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
1946 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00001947 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07001948
1949 self.assertEqual(0, git_cl.main(['archive', '-f']))
1950
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00001951 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00001952 self.calls = [
1953 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
1954 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
1955 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
1956 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00001957 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
1958 ((['git', 'branch', '-D', 'foo'],), '')
1959 ]
1960
Edward Lemurda4b6c62020-02-13 00:28:40 +00001961 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00001962 lambda branches, fine_grained, max_processes:
1963 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
1964 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00001965 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00001966
1967 self.assertEqual(0, git_cl.main(['archive', '-f']))
1968
kmarshall3bff56b2016-06-06 18:31:47 -07001969 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001970 self.calls = [
1971 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
1972 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00001973 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001974 ]
kmarshall3bff56b2016-06-06 18:31:47 -07001975
Edward Lemurda4b6c62020-02-13 00:28:40 +00001976 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07001977 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00001978 [(MockChangelistWithBranchAndIssue('master', 1),
1979 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07001980
1981 self.assertEqual(1, git_cl.main(['archive', '-f']))
1982
1983 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001984 self.calls = [
1985 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
1986 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00001987 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001988 ]
kmarshall3bff56b2016-06-06 18:31:47 -07001989
Edward Lemurda4b6c62020-02-13 00:28:40 +00001990 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07001991 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07001992 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
1993 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00001994 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07001995
kmarshall9249e012016-08-23 12:02:16 -07001996 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
1997
1998 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001999 self.calls = [
2000 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2001 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002002 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002003 ((['git', 'branch', '-D', 'foo'],), '')
2004 ]
kmarshall9249e012016-08-23 12:02:16 -07002005
Edward Lemurda4b6c62020-02-13 00:28:40 +00002006 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002007 lambda branches, fine_grained, max_processes:
2008 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2009 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002010 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002011
2012 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002013
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002014 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002015 self.calls = [
2016 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2017 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2018 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002019 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2020 'refs/tags/git-cl-archived-456-foo'),
2021 ((['git', 'branch', '-D', 'foo'],), CERR1),
2022 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2023 'refs/tags/git-cl-archived-456-foo'),
2024 ]
2025
Edward Lemurda4b6c62020-02-13 00:28:40 +00002026 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002027 lambda branches, fine_grained, max_processes:
2028 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2029 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002030 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002031
2032 self.assertEqual(0, git_cl.main(['archive', '-f']))
2033
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002034 def test_archive_with_format(self):
2035 self.calls = [
2036 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
2037 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2038 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2039 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2040 ((['git', 'branch', '-D', 'foo'], ), ''),
2041 ]
2042
2043 mock.patch('git_cl.get_cl_statuses',
2044 lambda branches, fine_grained, max_processes:
2045 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2046
2047 self.assertEqual(
2048 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2049
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002050 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002051 self.mockGit.config['branch.master.gerritissue'] = '123'
2052 self.mockGit.config['branch.master.gerritserver'] = (
2053 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002054 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002055 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002056 ]
2057 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002058 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2059 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002060
Aaron Gable400e9892017-07-12 15:31:21 -07002061 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002062 self.mockGit.config['branch.master.gerritissue'] = '123'
2063 self.mockGit.config['branch.master.gerritserver'] = (
2064 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002065 mock.patch('git_cl.Changelist.FetchDescription',
2066 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002067 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002068 ((['git', 'log', '-1', '--format=%B'],),
2069 'This is a description\n\nChange-Id: Ideadbeef'),
2070 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002071 ]
2072 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002073 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2074 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002075
phajdan.jre328cf92016-08-22 04:12:17 -07002076 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002077 self.mockGit.config['branch.master.gerritissue'] = '123'
2078 self.mockGit.config['branch.master.gerritserver'] = (
2079 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002080 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002081 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002082 {'issue': 123,
2083 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002084 ''),
2085 ]
2086 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2087
tandrii16e0b4e2016-06-07 10:34:28 -07002088 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002089 mock.patch(
2090 'git_cl.os.path.abspath',
2091 lambda path: self._mocked_call(['abspath', path])).start()
2092 mock.patch(
2093 'git_cl.os.path.exists',
2094 lambda path: self._mocked_call(['exists', path])).start()
2095 mock.patch(
2096 'git_cl.gclient_utils.FileRead',
2097 lambda path: self._mocked_call(['FileRead', path])).start()
2098 mock.patch(
2099 'git_cl.gclient_utils.rm_file_or_tree',
2100 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002101 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002102 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002103 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002104 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002105
2106 def test_GerritCommitMsgHookCheck_custom_hook(self):
2107 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002108 self.calls += [((['exists',
2109 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2110 ((['FileRead',
2111 os.path.join('.git', 'hooks', 'commit-msg')], ),
2112 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002113 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002114
2115 def test_GerritCommitMsgHookCheck_not_exists(self):
2116 cl = self._common_GerritCommitMsgHookCheck()
2117 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002118 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002119 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002120 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002121
2122 def test_GerritCommitMsgHookCheck(self):
2123 cl = self._common_GerritCommitMsgHookCheck()
2124 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002125 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2126 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002127 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002128 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002129 ((['rm_file_or_tree',
2130 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002131 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002132 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002133
tandriic4344b52016-08-29 06:04:54 -07002134 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002135 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2136 self.mockGit.config['branch.master.gerritserver'] = (
2137 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002138 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002139 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002140 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002141 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002142 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002143 'labels': {},
2144 'current_revision': 'deadbeaf',
2145 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002146 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002147 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002148 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002149 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2150 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002151 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002152 self.assertEqual(0, cl.CMDLand(force=True,
2153 bypass_hooks=True,
2154 verbose=True,
Saagar Sanghavidba1d652020-08-05 23:55:14 +00002155 parallel=False,
2156 resultdb=False,
2157 realm=None))
Edward Lemur73c76702020-02-06 23:57:18 +00002158 self.assertIn(
2159 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002160 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002161 self.assertIn(
2162 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002163 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002164
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002165 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002166 mock.patch('git_cl.Changelist._GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002167
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002168 def test_gerrit_change_detail_cache_simple(self):
2169 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002170 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002171 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002172 cl1._cached_remote_url = (
2173 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002174 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002175 cl2._cached_remote_url = (
2176 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002177 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2178 self.assertEqual(cl1._GetChangeDetail(), 'a')
2179 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002180
2181 def test_gerrit_change_detail_cache_options(self):
2182 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002183 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002184 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002185 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002186 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2187 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2188 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2189 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2190 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2191 self.assertEqual(cl._GetChangeDetail(), 'cab')
2192
2193 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2194 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2195 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2196 self.assertEqual(cl._GetChangeDetail(), 'cab')
2197
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002198 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002199 gerrit_util.GetChangeDetail.return_value = {
2200 'current_revision': 'rev1',
2201 'revisions': {
2202 'rev1': {'commit': {'message': 'desc1'}},
2203 },
2204 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002205
2206 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002207 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002208 cl._cached_remote_url = (
2209 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002210 self.assertEqual(cl.FetchDescription(), 'desc1')
2211 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002212
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002213 def test_print_current_creds(self):
2214 class CookiesAuthenticatorMock(object):
2215 def __init__(self):
2216 self.gitcookies = {
2217 'host.googlesource.com': ('user', 'pass'),
2218 'host-review.googlesource.com': ('user', 'pass'),
2219 }
2220 self.netrc = self
2221 self.netrc.hosts = {
2222 'github.com': ('user2', None, 'pass2'),
2223 'host2.googlesource.com': ('user3', None, 'pass'),
2224 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002225 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2226 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002227 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2228 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2229 ' Host\t User\t Which file',
2230 '============================\t=====\t===========',
2231 'host-review.googlesource.com\t user\t.gitcookies',
2232 ' host.googlesource.com\t user\t.gitcookies',
2233 ' host2.googlesource.com\tuser3\t .netrc',
2234 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002235 sys.stdout.seek(0)
2236 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002237 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2238 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2239 ' Host\tUser\t Which file',
2240 '============================\t====\t===========',
2241 'host-review.googlesource.com\tuser\t.gitcookies',
2242 ' host.googlesource.com\tuser\t.gitcookies',
2243 ])
2244
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002245 def _common_creds_check_mocks(self):
2246 def exists_mock(path):
2247 dirname = os.path.dirname(path)
2248 if dirname == os.path.expanduser('~'):
2249 dirname = '~'
2250 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002251 if base in (NETRC_FILENAME, '.gitcookies'):
2252 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002253 # git cl also checks for existence other files not relevant to this test.
2254 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002255 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002256 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002257 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002258 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002259
2260 def test_creds_check_gitcookies_not_configured(self):
2261 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002262 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2263 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002264 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002265 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2266 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2267 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2268 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2269 'or Ctrl+C to abort'), ''),
2270 (([
2271 'git', 'config', '--global', 'http.cookiefile',
2272 os.path.expanduser(os.path.join('~', '.gitcookies'))
2273 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002274 ]
2275 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002276 self.assertTrue(
2277 sys.stdout.getvalue().startswith(
2278 'You seem to be using outdated .netrc for git credentials:'))
2279 self.assertIn(
2280 '\nConfigured git to use .gitcookies from',
2281 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002282
2283 def test_creds_check_gitcookies_configured_custom_broken(self):
2284 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002285 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2286 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002287 custom_cookie_path = ('C:\\.gitcookies'
2288 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002289 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002290 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2291 ((['git', 'config', '--global', 'http.cookiefile'], ),
2292 custom_cookie_path),
2293 (('os.path.exists', custom_cookie_path), False),
2294 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2295 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2296 (([
2297 'git', 'config', '--global', 'http.cookiefile',
2298 os.path.expanduser(os.path.join('~', '.gitcookies'))
2299 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002300 ]
2301 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002302 self.assertIn(
2303 'WARNING: You have configured custom path to .gitcookies: ',
2304 sys.stdout.getvalue())
2305 self.assertIn(
2306 'However, your configured .gitcookies file is missing.',
2307 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002308
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002309 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002310 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002311 self.mockGit.config['remote.origin.url'] = (
2312 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002313 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002314 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002315 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002316 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002317 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002318 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002319
Edward Lemurda4b6c62020-02-13 00:28:40 +00002320 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2321 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002322 self.mockGit.config['remote.origin.url'] = (
2323 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002324 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002325 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002326 'current_revision': 'ba5eba11',
2327 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002328 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002329 '_number': 1,
2330 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002331 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002332 '_number': 2,
2333 },
2334 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002335 'messages': [
2336 {
2337 u'_revision_number': 1,
2338 u'author': {
2339 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002340 u'email': u'could-be-anything@example.com',
2341 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002342 },
2343 u'date': u'2017-03-15 20:08:45.000000000',
2344 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002345 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002346 u'tag': u'autogenerated:cq:dry-run'
2347 },
2348 {
2349 u'_revision_number': 2,
2350 u'author': {
2351 u'_account_id': 11151243,
2352 u'email': u'owner@example.com',
2353 u'name': u'owner'
2354 },
2355 u'date': u'2017-03-16 20:00:41.000000000',
2356 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2357 u'message': u'PTAL',
2358 },
2359 {
2360 u'_revision_number': 2,
2361 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002362 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002363 u'email': u'reviewer@example.com',
2364 u'name': u'reviewer'
2365 },
2366 u'date': u'2017-03-17 05:19:37.500000000',
2367 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2368 u'message': u'Patch Set 2: Code-Review+1',
2369 },
2370 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002371 }
2372 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002373 (('GetChangeComments', 'chromium-review.googlesource.com',
2374 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002375 '/COMMIT_MSG': [
2376 {
2377 'author': {'email': u'reviewer@example.com'},
2378 'updated': u'2017-03-17 05:19:37.500000000',
2379 'patch_set': 2,
2380 'side': 'REVISION',
2381 'message': 'Please include a bug link',
2382 },
2383 ],
2384 'codereview.settings': [
2385 {
2386 'author': {'email': u'owner@example.com'},
2387 'updated': u'2017-03-16 20:00:41.000000000',
2388 'patch_set': 2,
2389 'side': 'PARENT',
2390 'line': 42,
2391 'message': 'I removed this because it is bad',
2392 },
2393 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002394 }),
2395 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2396 'infra%2Finfra~1'), {}),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002397 ] * 2 + [
2398 (('write_json', 'output.json', [
2399 {
2400 u'date': u'2017-03-16 20:00:41.000000',
2401 u'message': (
2402 u'PTAL\n' +
2403 u'\n' +
2404 u'codereview.settings\n' +
2405 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2406 u'c/1/2/codereview.settings#b42\n' +
2407 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002408 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002409 u'approval': False,
2410 u'disapproval': False,
2411 u'sender': u'owner@example.com'
2412 }, {
2413 u'date': u'2017-03-17 05:19:37.500000',
2414 u'message': (
2415 u'Patch Set 2: Code-Review+1\n' +
2416 u'\n' +
2417 u'/COMMIT_MSG\n' +
2418 u' PS2, File comment: https://chromium-review.googlesource' +
2419 u'.com/c/1/2//COMMIT_MSG#\n' +
2420 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002421 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002422 u'approval': False,
2423 u'disapproval': False,
2424 u'sender': u'reviewer@example.com'
2425 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002426 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002427 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002428 expected_comments_summary = [
2429 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002430 message=(
2431 u'PTAL\n' +
2432 u'\n' +
2433 u'codereview.settings\n' +
2434 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2435 u'c/1/2/codereview.settings#b42\n' +
2436 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002437 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002438 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002439 disapproval=False, approval=False, sender=u'owner@example.com'),
2440 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002441 message=(
2442 u'Patch Set 2: Code-Review+1\n' +
2443 u'\n' +
2444 u'/COMMIT_MSG\n' +
2445 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2446 u'c/1/2//COMMIT_MSG#\n' +
2447 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002448 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002449 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002450 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2451 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002452 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002453 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002454 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002455 self.assertEqual(
2456 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2457
2458 def test_git_cl_comments_robot_comments(self):
2459 # git cl comments also fetches robot comments (which are considered a type
2460 # of autogenerated comment), and unlike other types of comments, only robot
2461 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002462 self.mockGit.config['remote.origin.url'] = (
2463 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002464 gerrit_util.GetChangeDetail.return_value = {
2465 'owner': {'email': 'owner@example.com'},
2466 'current_revision': 'ba5eba11',
2467 'revisions': {
2468 'deadbeaf': {
2469 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002470 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002471 'ba5eba11': {
2472 '_number': 2,
2473 },
2474 },
2475 'messages': [
2476 {
2477 u'_revision_number': 1,
2478 u'author': {
2479 u'_account_id': 1111084,
2480 u'email': u'commit-bot@chromium.org',
2481 u'name': u'Commit Bot'
2482 },
2483 u'date': u'2017-03-15 20:08:45.000000000',
2484 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2485 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2486 u'tag': u'autogenerated:cq:dry-run'
2487 },
2488 {
2489 u'_revision_number': 1,
2490 u'author': {
2491 u'_account_id': 123,
2492 u'email': u'tricium@serviceaccount.com',
2493 u'name': u'Tricium'
2494 },
2495 u'date': u'2017-03-16 20:00:41.000000000',
2496 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2497 u'message': u'(1 comment)',
2498 u'tag': u'autogenerated:tricium',
2499 },
2500 {
2501 u'_revision_number': 1,
2502 u'author': {
2503 u'_account_id': 123,
2504 u'email': u'tricium@serviceaccount.com',
2505 u'name': u'Tricium'
2506 },
2507 u'date': u'2017-03-16 20:00:41.000000000',
2508 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2509 u'message': u'(1 comment)',
2510 u'tag': u'autogenerated:tricium',
2511 },
2512 {
2513 u'_revision_number': 2,
2514 u'author': {
2515 u'_account_id': 123,
2516 u'email': u'tricium@serviceaccount.com',
2517 u'name': u'reviewer'
2518 },
2519 u'date': u'2017-03-17 05:30:37.000000000',
2520 u'tag': u'autogenerated:tricium',
2521 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2522 u'message': u'(1 comment)',
2523 },
2524 ]
2525 }
2526 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002527 (('GetChangeComments', 'chromium-review.googlesource.com',
2528 'infra%2Finfra~1'), {}),
2529 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2530 'infra%2Finfra~1'), {
2531 'codereview.settings': [
2532 {
2533 u'author': {u'email': u'tricium@serviceaccount.com'},
2534 u'updated': u'2017-03-17 05:30:37.000000000',
2535 u'robot_run_id': u'5565031076855808',
2536 u'robot_id': u'Linter/Category',
2537 u'tag': u'autogenerated:tricium',
2538 u'patch_set': 2,
2539 u'side': u'REVISION',
2540 u'message': u'Linter warning message text',
2541 u'line': 32,
2542 },
2543 ],
2544 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002545 ]
2546 expected_comments_summary = [
2547 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2548 message=(
2549 u'(1 comment)\n\ncodereview.settings\n'
2550 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2551 u'c/1/2/codereview.settings#32\n'
2552 u' Linter warning message text\n'),
2553 sender=u'tricium@serviceaccount.com',
2554 autogenerated=True, approval=False, disapproval=False)
2555 ]
2556 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002557 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002558 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002559
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002560 def test_get_remote_url_with_mirror(self):
2561 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002562
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002563 def selective_os_path_isdir_mock(path):
2564 if path == '/cache/this-dir-exists':
2565 return self._mocked_call('os.path.isdir', path)
2566 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002567
Edward Lemurda4b6c62020-02-13 00:28:40 +00002568 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002569
2570 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002571 self.mockGit.config['remote.origin.url'] = (
2572 '/cache/this-dir-exists')
2573 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2574 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002575 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002576 (('os.path.isdir', '/cache/this-dir-exists'),
2577 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002578 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002579 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002580 self.assertEqual(cl.GetRemoteUrl(), url)
2581 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2582
Edward Lemur298f2cf2019-02-22 21:40:39 +00002583 def test_get_remote_url_non_existing_mirror(self):
2584 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002585
Edward Lemur298f2cf2019-02-22 21:40:39 +00002586 def selective_os_path_isdir_mock(path):
2587 if path == '/cache/this-dir-doesnt-exist':
2588 return self._mocked_call('os.path.isdir', path)
2589 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002590
Edward Lemurda4b6c62020-02-13 00:28:40 +00002591 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2592 mock.patch('logging.error',
2593 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002594
Edward Lemur26964072020-02-19 19:18:51 +00002595 self.mockGit.config['remote.origin.url'] = (
2596 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002597 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002598 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2599 False),
2600 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002601 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2602 'but it doesn\'t exist.', {
2603 'remote': 'origin',
2604 'branch': 'master',
2605 'url': '/cache/this-dir-doesnt-exist'}
2606 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002607 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002608 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002609 self.assertIsNone(cl.GetRemoteUrl())
2610
2611 def test_get_remote_url_misconfigured_mirror(self):
2612 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002613
Edward Lemur298f2cf2019-02-22 21:40:39 +00002614 def selective_os_path_isdir_mock(path):
2615 if path == '/cache/this-dir-exists':
2616 return self._mocked_call('os.path.isdir', path)
2617 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002618
Edward Lemurda4b6c62020-02-13 00:28:40 +00002619 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2620 mock.patch('logging.error',
2621 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002622
Edward Lemur26964072020-02-19 19:18:51 +00002623 self.mockGit.config['remote.origin.url'] = (
2624 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002625 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002626 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002627 (('logging.error',
2628 'Remote "%(remote)s" for branch "%(branch)s" points to '
2629 '"%(cache_path)s", but it is misconfigured.\n'
2630 '"%(cache_path)s" must be a git repo and must have a remote named '
2631 '"%(remote)s" pointing to the git host.', {
2632 'remote': 'origin',
2633 'cache_path': '/cache/this-dir-exists',
2634 'branch': 'master'}
2635 ), None),
2636 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002637 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002638 self.assertIsNone(cl.GetRemoteUrl())
2639
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002640 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002641 self.mockGit.config['remote.origin.url'] = (
2642 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002643 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002644 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2645
2646 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002647 mock.patch('logging.error',
2648 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002649
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002650 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002651 (('logging.error',
2652 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2653 'but it doesn\'t exist.', {
2654 'remote': 'origin',
2655 'branch': 'master',
2656 'url': ''}
2657 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002658 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002659 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002660 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002661
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002662
Edward Lemur9aa1a962020-02-25 00:58:38 +00002663class ChangelistTest(unittest.TestCase):
Edward Lemur227d5102020-02-25 23:45:35 +00002664 def setUp(self):
2665 super(ChangelistTest, self).setUp()
2666 mock.patch('gclient_utils.FileRead').start()
2667 mock.patch('gclient_utils.FileWrite').start()
2668 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
2669 mock.patch(
2670 'git_cl.Changelist.GetCodereviewServer',
2671 return_value='https://chromium-review.googlesource.com').start()
2672 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
2673 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
2674 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
2675 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
2676 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
2677 mock.patch('git_cl.time_time').start()
2678 mock.patch('metrics.collector').start()
2679 mock.patch('subprocess2.Popen').start()
2680 self.addCleanup(mock.patch.stopall)
2681 self.temp_count = 0
2682
Edward Lemur227d5102020-02-25 23:45:35 +00002683 def testRunHook(self):
2684 expected_results = {
2685 'more_cc': ['more@example.com', 'cc@example.com'],
2686 'should_continue': True,
2687 }
2688 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2689 git_cl.time_time.side_effect = [100, 200]
2690 mockProcess = mock.Mock()
2691 mockProcess.wait.return_value = 0
2692 subprocess2.Popen.return_value = mockProcess
2693
2694 cl = git_cl.Changelist()
2695 results = cl.RunHook(
2696 committing=True,
2697 may_prompt=True,
2698 verbose=2,
2699 parallel=True,
2700 upstream='upstream',
2701 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002702 all_files=True,
2703 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00002704
2705 self.assertEqual(expected_results, results)
2706 subprocess2.Popen.assert_called_once_with([
2707 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00002708 '--root', 'root',
2709 '--upstream', 'upstream',
2710 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002711 '--author', 'author',
2712 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00002713 '--issue', '123456',
2714 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002715 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00002716 '--may_prompt',
2717 '--parallel',
2718 '--all_files',
2719 '--json_output', '/tmp/fake-temp2',
2720 '--description_file', '/tmp/fake-temp1',
2721 ])
2722 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002723 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00002724 metrics.collector.add_repeated('sub_commands', {
2725 'command': 'presubmit',
2726 'execution_time': 100,
2727 'exit_code': 0,
2728 })
2729
Edward Lemur99df04e2020-03-05 19:39:43 +00002730 def testRunHook_FewerOptions(self):
2731 expected_results = {
2732 'more_cc': ['more@example.com', 'cc@example.com'],
2733 'should_continue': True,
2734 }
2735 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2736 git_cl.time_time.side_effect = [100, 200]
2737 mockProcess = mock.Mock()
2738 mockProcess.wait.return_value = 0
2739 subprocess2.Popen.return_value = mockProcess
2740
2741 git_cl.Changelist.GetAuthor.return_value = None
2742 git_cl.Changelist.GetIssue.return_value = None
2743 git_cl.Changelist.GetPatchset.return_value = None
2744 git_cl.Changelist.GetCodereviewServer.return_value = None
2745
2746 cl = git_cl.Changelist()
2747 results = cl.RunHook(
2748 committing=False,
2749 may_prompt=False,
2750 verbose=0,
2751 parallel=False,
2752 upstream='upstream',
2753 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002754 all_files=False,
2755 resultdb=False)
Edward Lemur99df04e2020-03-05 19:39:43 +00002756
2757 self.assertEqual(expected_results, results)
2758 subprocess2.Popen.assert_called_once_with([
2759 'vpython', 'PRESUBMIT_SUPPORT',
2760 '--root', 'root',
2761 '--upstream', 'upstream',
2762 '--upload',
2763 '--json_output', '/tmp/fake-temp2',
2764 '--description_file', '/tmp/fake-temp1',
2765 ])
2766 gclient_utils.FileWrite.assert_called_once_with(
2767 '/tmp/fake-temp1', 'description')
2768 metrics.collector.add_repeated('sub_commands', {
2769 'command': 'presubmit',
2770 'execution_time': 100,
2771 'exit_code': 0,
2772 })
2773
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002774 def testRunHook_FewerOptionsResultDB(self):
2775 expected_results = {
2776 'more_cc': ['more@example.com', 'cc@example.com'],
2777 'should_continue': True,
2778 }
2779 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2780 git_cl.time_time.side_effect = [100, 200]
2781 mockProcess = mock.Mock()
2782 mockProcess.wait.return_value = 0
2783 subprocess2.Popen.return_value = mockProcess
2784
2785 git_cl.Changelist.GetAuthor.return_value = None
2786 git_cl.Changelist.GetIssue.return_value = None
2787 git_cl.Changelist.GetPatchset.return_value = None
2788 git_cl.Changelist.GetCodereviewServer.return_value = None
2789
2790 cl = git_cl.Changelist()
2791 results = cl.RunHook(
2792 committing=False,
2793 may_prompt=False,
2794 verbose=0,
2795 parallel=False,
2796 upstream='upstream',
2797 description='description',
2798 all_files=False,
Saagar Sanghavidba1d652020-08-05 23:55:14 +00002799 resultdb=True,
2800 realm='chromium:public')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002801
2802 self.assertEqual(expected_results, results)
2803 subprocess2.Popen.assert_called_once_with([
Saagar Sanghavidba1d652020-08-05 23:55:14 +00002804 'rdb', 'stream', '-new', '-realm', 'chromium:public',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002805 'vpython', 'PRESUBMIT_SUPPORT',
2806 '--root', 'root',
2807 '--upstream', 'upstream',
2808 '--upload',
2809 '--json_output', '/tmp/fake-temp2',
2810 '--description_file', '/tmp/fake-temp1',
2811 ])
2812
Edward Lemur227d5102020-02-25 23:45:35 +00002813 @mock.patch('sys.exit', side_effect=SystemExitMock)
2814 def testRunHook_Failure(self, _mock):
2815 git_cl.time_time.side_effect = [100, 200]
2816 mockProcess = mock.Mock()
2817 mockProcess.wait.return_value = 2
2818 subprocess2.Popen.return_value = mockProcess
2819
2820 cl = git_cl.Changelist()
2821 with self.assertRaises(SystemExitMock):
2822 cl.RunHook(
2823 committing=True,
2824 may_prompt=True,
2825 verbose=2,
2826 parallel=True,
2827 upstream='upstream',
2828 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002829 all_files=True,
2830 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00002831
2832 sys.exit.assert_called_once_with(2)
2833
Edward Lemur75526302020-02-27 22:31:05 +00002834 def testRunPostUploadHook(self):
2835 cl = git_cl.Changelist()
2836 cl.RunPostUploadHook(2, 'upstream', 'description')
2837
2838 subprocess2.Popen.assert_called_once_with([
2839 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00002840 '--root', 'root',
2841 '--upstream', 'upstream',
2842 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002843 '--author', 'author',
2844 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur75526302020-02-27 22:31:05 +00002845 '--issue', '123456',
2846 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002847 '--post_upload',
2848 '--description_file', '/tmp/fake-temp1',
2849 ])
2850 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002851 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00002852
Edward Lemur9aa1a962020-02-25 00:58:38 +00002853
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002854class CMDTestCaseBase(unittest.TestCase):
2855 _STATUSES = [
2856 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
2857 'INFRA_FAILURE', 'CANCELED',
2858 ]
2859 _CHANGE_DETAIL = {
2860 'project': 'depot_tools',
2861 'status': 'OPEN',
2862 'owner': {'email': 'owner@e.mail'},
2863 'current_revision': 'beeeeeef',
2864 'revisions': {
2865 'deadbeaf': {'_number': 6},
2866 'beeeeeef': {
2867 '_number': 7,
2868 'fetch': {'http': {
2869 'url': 'https://chromium.googlesource.com/depot_tools',
2870 'ref': 'refs/changes/56/123456/7'
2871 }},
2872 },
2873 },
2874 }
2875 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002876 'builds': [{
2877 'id': str(100 + idx),
2878 'builder': {
2879 'project': 'chromium',
2880 'bucket': 'try',
2881 'builder': 'bot_' + status.lower(),
2882 },
2883 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
2884 'tags': [],
2885 'status': status,
2886 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002887 }
2888
Edward Lemur4c707a22019-09-24 21:13:43 +00002889 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002890 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00002891 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002892 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
2893 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002894 mock.patch(
2895 'git_cl.Changelist.GetCodereviewServer',
2896 return_value='https://chromium-review.googlesource.com').start()
2897 mock.patch(
2898 'git_cl.Changelist._GetGerritHost',
2899 return_value='chromium-review.googlesource.com').start()
2900 mock.patch(
2901 'git_cl.Changelist.GetMostRecentPatchset',
2902 return_value=7).start()
2903 mock.patch(
2904 'git_cl.Changelist.GetRemoteUrl',
2905 return_value='https://chromium.googlesource.com/depot_tools').start()
2906 mock.patch(
2907 'auth.Authenticator',
2908 return_value=AuthenticatorMock()).start()
2909 mock.patch(
2910 'gerrit_util.GetChangeDetail',
2911 return_value=self._CHANGE_DETAIL).start()
2912 mock.patch(
2913 'git_cl._call_buildbucket',
2914 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002915 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00002916 self.addCleanup(mock.patch.stopall)
2917
Edward Lemur4c707a22019-09-24 21:13:43 +00002918
Edward Lemur9468eba2020-02-27 19:07:22 +00002919class CMDPresubmitTestCase(CMDTestCaseBase):
2920 def setUp(self):
2921 super(CMDPresubmitTestCase, self).setUp()
2922 mock.patch(
2923 'git_cl.Changelist.GetCommonAncestorWithUpstream',
2924 return_value='upstream').start()
2925 mock.patch(
2926 'git_cl.Changelist.FetchDescription',
2927 return_value='fetch description').start()
2928 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00002929 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00002930 return_value='get description').start()
2931 mock.patch('git_cl.Changelist.RunHook').start()
2932
2933 def testDefaultCase(self):
2934 self.assertEqual(0, git_cl.main(['presubmit']))
2935 git_cl.Changelist.RunHook.assert_called_once_with(
2936 committing=True,
2937 may_prompt=False,
2938 verbose=0,
2939 parallel=None,
2940 upstream='upstream',
2941 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002942 all_files=None,
Saagar Sanghavidba1d652020-08-05 23:55:14 +00002943 resultdb=None,
2944 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00002945
2946 def testNoIssue(self):
2947 git_cl.Changelist.GetIssue.return_value = None
2948 self.assertEqual(0, git_cl.main(['presubmit']))
2949 git_cl.Changelist.RunHook.assert_called_once_with(
2950 committing=True,
2951 may_prompt=False,
2952 verbose=0,
2953 parallel=None,
2954 upstream='upstream',
2955 description='get description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002956 all_files=None,
Saagar Sanghavidba1d652020-08-05 23:55:14 +00002957 resultdb=None,
2958 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00002959
2960 def testCustomBranch(self):
2961 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
2962 git_cl.Changelist.RunHook.assert_called_once_with(
2963 committing=True,
2964 may_prompt=False,
2965 verbose=0,
2966 parallel=None,
2967 upstream='custom_branch',
2968 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002969 all_files=None,
Saagar Sanghavidba1d652020-08-05 23:55:14 +00002970 resultdb=None,
2971 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00002972
2973 def testOptions(self):
2974 self.assertEqual(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002975 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
Saagar Sanghavidba1d652020-08-05 23:55:14 +00002976 '--resultdb', '--realm', 'chromium:public']))
Edward Lemur9468eba2020-02-27 19:07:22 +00002977 git_cl.Changelist.RunHook.assert_called_once_with(
2978 committing=False,
2979 may_prompt=False,
2980 verbose=2,
2981 parallel=True,
2982 upstream='upstream',
2983 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002984 all_files=True,
Saagar Sanghavidba1d652020-08-05 23:55:14 +00002985 resultdb=True,
2986 realm='chromium:public')
Edward Lemur9468eba2020-02-27 19:07:22 +00002987
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002988class CMDTryResultsTestCase(CMDTestCaseBase):
2989 _DEFAULT_REQUEST = {
2990 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002991 "gerritChanges": [{
2992 "project": "depot_tools",
2993 "host": "chromium-review.googlesource.com",
2994 "patchset": 7,
2995 "change": 123456,
2996 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002997 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002998 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
2999 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003000 }
3001
3002 def testNoJobs(self):
3003 git_cl._call_buildbucket.return_value = {}
3004
3005 self.assertEqual(0, git_cl.main(['try-results']))
3006 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3007 git_cl._call_buildbucket.assert_called_once_with(
3008 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3009 self._DEFAULT_REQUEST)
3010
3011 def testPrintToStdout(self):
3012 self.assertEqual(0, git_cl.main(['try-results']))
3013 self.assertEqual([
3014 'Successes:',
3015 ' bot_success https://ci.chromium.org/b/103',
3016 'Infra Failures:',
3017 ' bot_infra_failure https://ci.chromium.org/b/105',
3018 'Failures:',
3019 ' bot_failure https://ci.chromium.org/b/104',
3020 'Canceled:',
3021 ' bot_canceled ',
3022 'Started:',
3023 ' bot_started https://ci.chromium.org/b/102',
3024 'Scheduled:',
3025 ' bot_scheduled id=101',
3026 'Other:',
3027 ' bot_status_unspecified id=100',
3028 'Total: 7 tryjobs',
3029 ], sys.stdout.getvalue().splitlines())
3030 git_cl._call_buildbucket.assert_called_once_with(
3031 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3032 self._DEFAULT_REQUEST)
3033
3034 def testPrintToStdoutWithMasters(self):
3035 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3036 self.assertEqual([
3037 'Successes:',
3038 ' try bot_success https://ci.chromium.org/b/103',
3039 'Infra Failures:',
3040 ' try bot_infra_failure https://ci.chromium.org/b/105',
3041 'Failures:',
3042 ' try bot_failure https://ci.chromium.org/b/104',
3043 'Canceled:',
3044 ' try bot_canceled ',
3045 'Started:',
3046 ' try bot_started https://ci.chromium.org/b/102',
3047 'Scheduled:',
3048 ' try bot_scheduled id=101',
3049 'Other:',
3050 ' try bot_status_unspecified id=100',
3051 'Total: 7 tryjobs',
3052 ], sys.stdout.getvalue().splitlines())
3053 git_cl._call_buildbucket.assert_called_once_with(
3054 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3055 self._DEFAULT_REQUEST)
3056
3057 @mock.patch('git_cl.write_json')
3058 def testWriteToJson(self, mockJsonDump):
3059 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3060 git_cl._call_buildbucket.assert_called_once_with(
3061 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3062 self._DEFAULT_REQUEST)
3063 mockJsonDump.assert_called_once_with(
3064 'file.json', self._DEFAULT_RESPONSE['builds'])
3065
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003066 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003067 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3068 self.assertEqual(
3069 [
3070 ('chromium', 'try', 'bot_failure'),
3071 ('chromium', 'try', 'bot_infra_failure'),
3072 ],
3073 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003074
3075 def test_filter_failed_for_retry_many_builds(self):
3076
3077 def _build(name, created_sec, status, experimental=False):
3078 assert 0 <= created_sec < 100, created_sec
3079 b = {
3080 'id': 112112,
3081 'builder': {
3082 'project': 'chromium',
3083 'bucket': 'try',
3084 'builder': name,
3085 },
3086 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3087 'status': status,
3088 'tags': [],
3089 }
3090 if experimental:
3091 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3092 return b
3093
3094 builds = [
3095 _build('flaky-last-green', 1, 'FAILURE'),
3096 _build('flaky-last-green', 2, 'SUCCESS'),
3097 _build('flaky', 1, 'SUCCESS'),
3098 _build('flaky', 2, 'FAILURE'),
3099 _build('running', 1, 'FAILED'),
3100 _build('running', 2, 'SCHEDULED'),
3101 _build('yep-still-running', 1, 'STARTED'),
3102 _build('yep-still-running', 2, 'FAILURE'),
3103 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3104 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3105
3106 # Simulate experimental in CQ builder, which developer decided
3107 # to retry manually which resulted in 2nd build non-experimental.
3108 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3109 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3110 ]
3111 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003112 self.assertEqual(
3113 [
3114 ('chromium', 'try', 'flaky'),
3115 ('chromium', 'try', 'sometimes-experimental'),
3116 ],
3117 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003118
3119
3120class CMDTryTestCase(CMDTestCaseBase):
3121
3122 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003123 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003124 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003125 self.assertEqual(0, git_cl.main(['try']))
3126 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3127 self.assertEqual(
3128 sys.stdout.getvalue(),
3129 'Scheduling CQ dry run on: '
3130 'https://chromium-review.googlesource.com/123456\n')
3131
Edward Lemur4c707a22019-09-24 21:13:43 +00003132 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003133 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003134 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003135
3136 self.assertEqual(0, git_cl.main([
3137 'try', '-B', 'luci.chromium.try', '-b', 'win',
3138 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3139 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003140 'Scheduling jobs on:\n'
3141 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003142 git_cl.sys.stdout.getvalue())
3143
3144 expected_request = {
3145 "requests": [{
3146 "scheduleBuild": {
3147 "requestId": "uuid4",
3148 "builder": {
3149 "project": "chromium",
3150 "builder": "win",
3151 "bucket": "try",
3152 },
3153 "gerritChanges": [{
3154 "project": "depot_tools",
3155 "host": "chromium-review.googlesource.com",
3156 "patchset": 7,
3157 "change": 123456,
3158 }],
3159 "properties": {
3160 "category": "git_cl_try",
3161 "json": [{"a": 1}, None],
3162 "key": "val",
3163 },
3164 "tags": [
3165 {"value": "win", "key": "builder"},
3166 {"value": "git_cl_try", "key": "user_agent"},
3167 ],
3168 },
3169 }],
3170 }
3171 mockCallBuildbucket.assert_called_with(
3172 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3173
Anthony Polito1a5fe232020-01-24 23:17:52 +00003174 @mock.patch('git_cl._call_buildbucket')
3175 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3176 mockCallBuildbucket.return_value = {}
3177
3178 self.assertEqual(0, git_cl.main([
3179 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3180 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3181 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3182 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003183 'Scheduling jobs on:\n'
3184 ' chromium/try: linux\n'
3185 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003186 git_cl.sys.stdout.getvalue())
3187
3188 expected_request = {
3189 "requests": [{
3190 "scheduleBuild": {
3191 "requestId": "uuid4",
3192 "builder": {
3193 "project": "chromium",
3194 "builder": "linux",
3195 "bucket": "try",
3196 },
3197 "gerritChanges": [{
3198 "project": "depot_tools",
3199 "host": "chromium-review.googlesource.com",
3200 "patchset": 7,
3201 "change": 123456,
3202 }],
3203 "properties": {
3204 "category": "git_cl_try",
3205 "json": [{"a": 1}, None],
3206 "key": "val",
3207 },
3208 "tags": [
3209 {"value": "linux", "key": "builder"},
3210 {"value": "git_cl_try", "key": "user_agent"},
3211 ],
3212 "gitilesCommit": {
3213 "host": "chromium-review.googlesource.com",
3214 "project": "depot_tools",
3215 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3216 }
3217 },
3218 },
3219 {
3220 "scheduleBuild": {
3221 "requestId": "uuid4",
3222 "builder": {
3223 "project": "chromium",
3224 "builder": "win",
3225 "bucket": "try",
3226 },
3227 "gerritChanges": [{
3228 "project": "depot_tools",
3229 "host": "chromium-review.googlesource.com",
3230 "patchset": 7,
3231 "change": 123456,
3232 }],
3233 "properties": {
3234 "category": "git_cl_try",
3235 "json": [{"a": 1}, None],
3236 "key": "val",
3237 },
3238 "tags": [
3239 {"value": "win", "key": "builder"},
3240 {"value": "git_cl_try", "key": "user_agent"},
3241 ],
3242 "gitilesCommit": {
3243 "host": "chromium-review.googlesource.com",
3244 "project": "depot_tools",
3245 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3246 }
3247 },
3248 }],
3249 }
3250 mockCallBuildbucket.assert_called_with(
3251 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3252
Edward Lemur45768512020-03-02 19:03:14 +00003253 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003254 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003255 with self.assertRaises(SystemExit):
3256 git_cl.main([
3257 'try', '-B', 'not-a-bucket', '-b', 'win',
3258 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003259 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003260 'Invalid bucket: not-a-bucket.',
3261 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003262
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003263 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003264 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003265 def testScheduleOnBuildbucketRetryFailed(
3266 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003267 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003268 7: [],
3269 6: [{
3270 'id': 112112,
3271 'builder': {
3272 'project': 'chromium',
3273 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003274 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003275 'createTime': '2019-10-09T08:00:01.854286Z',
3276 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003277 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003278 mockCallBuildbucket.return_value = {}
3279
3280 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3281 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003282 'Scheduling jobs on:\n'
3283 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003284 git_cl.sys.stdout.getvalue())
3285
3286 expected_request = {
3287 "requests": [{
3288 "scheduleBuild": {
3289 "requestId": "uuid4",
3290 "builder": {
3291 "project": "chromium",
3292 "bucket": "try",
3293 "builder": "linux",
3294 },
3295 "gerritChanges": [{
3296 "project": "depot_tools",
3297 "host": "chromium-review.googlesource.com",
3298 "patchset": 7,
3299 "change": 123456,
3300 }],
3301 "properties": {
3302 "category": "git_cl_try",
3303 },
3304 "tags": [
3305 {"value": "linux", "key": "builder"},
3306 {"value": "git_cl_try", "key": "user_agent"},
3307 {"value": "1", "key": "retry_failed"},
3308 ],
3309 },
3310 }],
3311 }
3312 mockCallBuildbucket.assert_called_with(
3313 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3314
Edward Lemur4c707a22019-09-24 21:13:43 +00003315 def test_parse_bucket(self):
3316 test_cases = [
3317 {
3318 'bucket': 'chromium/try',
3319 'result': ('chromium', 'try'),
3320 },
3321 {
3322 'bucket': 'luci.chromium.try',
3323 'result': ('chromium', 'try'),
3324 'has_warning': True,
3325 },
3326 {
3327 'bucket': 'skia.primary',
3328 'result': ('skia', 'skia.primary'),
3329 'has_warning': True,
3330 },
3331 {
3332 'bucket': 'not-a-bucket',
3333 'result': (None, None),
3334 },
3335 ]
3336
3337 for test_case in test_cases:
3338 git_cl.sys.stdout.truncate(0)
3339 self.assertEqual(
3340 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3341 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003342 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3343 test_case['result'])
3344 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003345
3346
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003347class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003348
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003349 def setUp(self):
3350 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003351 mock.patch('git_cl._fetch_tryjobs').start()
3352 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003353 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003354 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3355 mock.patch(
3356 'git_cl.Settings.GetSquashGerritUploads',
3357 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003358 self.addCleanup(mock.patch.stopall)
3359
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003360 def testWarmUpChangeDetailCache(self):
3361 self.assertEqual(0, git_cl.main(['upload']))
3362 gerrit_util.GetChangeDetail.assert_called_once_with(
3363 'chromium-review.googlesource.com', 'depot_tools~123456',
3364 frozenset([
3365 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3366 'CURRENT_COMMIT']))
3367
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003368 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003369 # This test mocks out the actual upload part, and just asserts that after
3370 # upload, if --retry-failed is added, then the tool will fetch try jobs
3371 # from the previous patchset and trigger the right builders on the latest
3372 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003373 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003374 # Latest patchset: No builds.
3375 [],
3376 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003377 [{
3378 'id': str(100 + idx),
3379 'builder': {
3380 'project': 'chromium',
3381 'bucket': 'try',
3382 'builder': 'bot_' + status.lower(),
3383 },
3384 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3385 'tags': [],
3386 'status': status,
3387 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003388 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003389
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003390 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003391 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003392 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3393 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003394 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003395 expected_buckets = [
3396 ('chromium', 'try', 'bot_failure'),
3397 ('chromium', 'try', 'bot_infra_failure'),
3398 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003399 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3400 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003401
Brian Sheedy59b06a82019-10-14 17:03:29 +00003402
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003403class MakeRequestsHelperTestCase(unittest.TestCase):
3404
3405 def exampleGerritChange(self):
3406 return {
3407 'host': 'chromium-review.googlesource.com',
3408 'project': 'depot_tools',
3409 'change': 1,
3410 'patchset': 2,
3411 }
3412
3413 def testMakeRequestsHelperNoOptions(self):
3414 # Basic test for the helper function _make_tryjob_schedule_requests;
3415 # it shouldn't throw AttributeError even when options doesn't have any
3416 # of the expected values; it will use default option values.
3417 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3418 jobs = [('chromium', 'try', 'my-builder')]
3419 options = optparse.Values()
3420 requests = git_cl._make_tryjob_schedule_requests(
3421 changelist, jobs, options, patchset=None)
3422
3423 # requestId is non-deterministic. Just assert that it's there and has
3424 # a particular length.
3425 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3426 self.assertEqual(requests, [{
3427 'scheduleBuild': {
3428 'builder': {
3429 'bucket': 'try',
3430 'builder': 'my-builder',
3431 'project': 'chromium'
3432 },
3433 'gerritChanges': [self.exampleGerritChange()],
3434 'properties': {
3435 'category': 'git_cl_try'
3436 },
3437 'tags': [{
3438 'key': 'builder',
3439 'value': 'my-builder'
3440 }, {
3441 'key': 'user_agent',
3442 'value': 'git_cl_try'
3443 }]
3444 }
3445 }])
3446
3447 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3448 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3449 jobs = [('chromium', 'try', 'presubmit')]
3450 options = optparse.Values()
3451 requests = git_cl._make_tryjob_schedule_requests(
3452 changelist, jobs, options, patchset=None)
3453 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3454 'category': 'git_cl_try',
3455 'dry_run': 'true'
3456 })
3457
3458 def testMakeRequestsHelperRevisionSet(self):
3459 # Gitiles commit is specified when revision is in options.
3460 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3461 jobs = [('chromium', 'try', 'my-builder')]
3462 options = optparse.Values({'revision': 'ba5eba11'})
3463 requests = git_cl._make_tryjob_schedule_requests(
3464 changelist, jobs, options, patchset=None)
3465 self.assertEqual(
3466 requests[0]['scheduleBuild']['gitilesCommit'], {
3467 'host': 'chromium-review.googlesource.com',
3468 'id': 'ba5eba11',
3469 'project': 'depot_tools'
3470 })
3471
3472 def testMakeRequestsHelperRetryFailedSet(self):
3473 # An extra tag is added when retry_failed is in options.
3474 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3475 jobs = [('chromium', 'try', 'my-builder')]
3476 options = optparse.Values({'retry_failed': 'true'})
3477 requests = git_cl._make_tryjob_schedule_requests(
3478 changelist, jobs, options, patchset=None)
3479 self.assertEqual(
3480 requests[0]['scheduleBuild']['tags'], [
3481 {
3482 'key': 'builder',
3483 'value': 'my-builder'
3484 },
3485 {
3486 'key': 'user_agent',
3487 'value': 'git_cl_try'
3488 },
3489 {
3490 'key': 'retry_failed',
3491 'value': '1'
3492 }
3493 ])
3494
3495 def testMakeRequestsHelperCategorySet(self):
Quinten Yearsley925cedb2020-04-13 17:49:39 +00003496 # The category property can be overridden with options.
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003497 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3498 jobs = [('chromium', 'try', 'my-builder')]
3499 options = optparse.Values({'category': 'my-special-category'})
3500 requests = git_cl._make_tryjob_schedule_requests(
3501 changelist, jobs, options, patchset=None)
3502 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3503 {'category': 'my-special-category'})
3504
3505
Edward Lemurda4b6c62020-02-13 00:28:40 +00003506class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003507
3508 def setUp(self):
3509 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003510 mock.patch('git_cl.RunCommand').start()
3511 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3512 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3513 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003514 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003515 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003516
3517 def tearDown(self):
3518 shutil.rmtree(self._top_dir)
3519 super(CMDFormatTestCase, self).tearDown()
3520
Jamie Madill5e96ad12020-01-13 16:08:35 +00003521 def _make_temp_file(self, fname, contents):
3522 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3523 tf.write('\n'.join(contents))
3524
Brian Sheedy59b06a82019-10-14 17:03:29 +00003525 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003526 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003527
Brian Sheedyb4307d52019-12-02 19:18:17 +00003528 def _check_yapf_filtering(self, files, expected):
3529 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3530 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003531
Edward Lemur1a83da12020-03-04 21:18:36 +00003532 def _run_command_mock(self, return_value):
3533 def f(*args, **kwargs):
3534 if 'stdin' in kwargs:
3535 self.assertIsInstance(kwargs['stdin'], bytes)
3536 return return_value
3537 return f
3538
Jamie Madill5e96ad12020-01-13 16:08:35 +00003539 def testClangFormatDiffFull(self):
3540 self._make_temp_file('test.cc', ['// test'])
3541 git_cl.settings.GetFormatFullByDefault.return_value = False
3542 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3543 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3544
3545 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003546 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003547 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3548 self._top_dir, 'HEAD')
3549 self.assertEqual(2, return_value)
3550
3551 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003552 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003553 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3554 self._top_dir, 'HEAD')
3555 self.assertEqual(0, return_value)
3556
3557 def testClangFormatDiff(self):
3558 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00003559 # A valid file is required, so use this test.
3560 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00003561 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3562
3563 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003564 git_cl.RunCommand.side_effect = self._run_command_mock('error')
3565 return_value = git_cl._RunClangFormatDiff(
3566 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003567 self.assertEqual(2, return_value)
3568
3569 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003570 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003571 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3572 'HEAD')
3573 self.assertEqual(0, return_value)
3574
Brian Sheedyb4307d52019-12-02 19:18:17 +00003575 def testYapfignoreExplicit(self):
3576 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3577 files = [
3578 'bar.py',
3579 'foo/bar.py',
3580 'foo/baz.py',
3581 'foo/bar/baz.py',
3582 'foo/bar/foobar.py',
3583 ]
3584 expected = [
3585 'bar.py',
3586 'foo/baz.py',
3587 'foo/bar/foobar.py',
3588 ]
3589 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003590
Brian Sheedyb4307d52019-12-02 19:18:17 +00003591 def testYapfignoreSingleWildcards(self):
3592 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3593 files = [
3594 'bar.py', # Matched by *bar.py.
3595 'bar.txt',
3596 'foobar.py', # Matched by *bar.py, foo*.
3597 'foobar.txt', # Matched by foo*.
3598 'bazbar.py', # Matched by *bar.py, baz*.py.
3599 'bazbar.txt',
3600 'foo/baz.txt', # Matched by foo*.
3601 'bar/bar.py', # Matched by *bar.py.
3602 'baz/foo.py', # Matched by baz*.py, foo*.
3603 'baz/foo.txt',
3604 ]
3605 expected = [
3606 'bar.txt',
3607 'bazbar.txt',
3608 'baz/foo.txt',
3609 ]
3610 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003611
Brian Sheedyb4307d52019-12-02 19:18:17 +00003612 def testYapfignoreMultiplewildcards(self):
3613 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3614 files = [
3615 'bar.py', # Matched by *bar*.
3616 'bar.txt', # Matched by *bar*.
3617 'abar.py', # Matched by *bar*.
3618 'foobaz.txt', # Matched by *foo*baz.txt.
3619 'foobaz.py',
3620 'afoobaz.txt', # Matched by *foo*baz.txt.
3621 ]
3622 expected = [
3623 'foobaz.py',
3624 ]
3625 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003626
3627 def testYapfignoreComments(self):
3628 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003629 files = [
3630 'test.py',
3631 'test2.py',
3632 ]
3633 expected = [
3634 'test2.py',
3635 ]
3636 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003637
3638 def testYapfignoreBlankLines(self):
3639 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003640 files = [
3641 'test.py',
3642 'test2.py',
3643 'test3.py',
3644 ]
3645 expected = [
3646 'test3.py',
3647 ]
3648 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003649
3650 def testYapfignoreWhitespace(self):
3651 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003652 files = [
3653 'test.py',
3654 'test2.py',
3655 ]
3656 expected = [
3657 'test2.py',
3658 ]
3659 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003660
Brian Sheedyb4307d52019-12-02 19:18:17 +00003661 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003662 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003663 self._check_yapf_filtering([], [])
3664
3665 def testYapfignoreMissingYapfignore(self):
3666 files = [
3667 'test.py',
3668 ]
3669 expected = [
3670 'test.py',
3671 ]
3672 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003673
3674
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003675if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003676 logging.basicConfig(
3677 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003678 unittest.main()