blob: 521a097947c3be375b74742f1537a5a1f5dcdc9d [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
34# We have to disable monitoring before importing git_cl.
35metrics.DISABLE_METRICS_COLLECTION = True
36
Jamie Madill5e96ad12020-01-13 16:08:35 +000037import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000038import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000039import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000040import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000041import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000042import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000043import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000044import git_new_branch
45import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000046import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000047
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000048NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
49
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000050
Edward Lemur0db01f02019-11-12 22:01:51 +000051def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070052 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
53
tandrii5d48c322016-08-18 16:19:37 -070054CERR1 = callError(1)
55
56
Edward Lemur1773f372020-02-22 00:27:14 +000057class TemporaryFileMock(object):
58 def __init__(self):
59 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070060
Edward Lemur1773f372020-02-22 00:27:14 +000061 @contextlib.contextmanager
62 def __call__(self):
63 self.suffix += 1
64 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070065
66
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000067class ChangelistMock(object):
68 # A class variable so we can access it when we don't have access to the
69 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000070 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000071
72 def __init__(self, gerrit_change=None, **kwargs):
73 self._gerrit_change = gerrit_change
74
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000075 def GetIssue(self):
76 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000077
Edward Lemur6c6827c2020-02-06 21:15:18 +000078 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000079 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000080
dsansomee2d6fd92016-09-08 00:10:47 -070081 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000082 ChangelistMock.desc = desc
83
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000084 def GetGerritChange(self, patchset=None, **kwargs):
85 del patchset
86 return self._gerrit_change
87
tandrii5d48c322016-08-18 16:19:37 -070088
Edward Lemur85153282020-02-14 22:06:29 +000089class GitMocks(object):
90 def __init__(self, config=None, branchref=None):
91 self.branchref = branchref or 'refs/heads/master'
92 self.config = config or {}
93
94 def GetBranchRef(self, _root):
95 return self.branchref
96
97 def NewBranch(self, branchref):
98 self.branchref = branchref
99
Edward Lemur26964072020-02-19 19:18:51 +0000100 def GetConfig(self, root, key, default=None):
101 if root != '':
102 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000103 return self.config.get(key, default)
104
Edward Lemur26964072020-02-19 19:18:51 +0000105 def SetConfig(self, root, key, value=None):
106 if root != '':
107 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000108 if value:
109 self.config[key] = value
110 return
111 if key not in self.config:
112 raise CERR1
113 del self.config[key]
114
115
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000116class WatchlistsMock(object):
117 def __init__(self, _):
118 pass
119 @staticmethod
120 def GetWatchersForPaths(_):
121 return ['joe@example.com']
122
123
Edward Lemur4c707a22019-09-24 21:13:43 +0000124class CodereviewSettingsFileMock(object):
125 def __init__(self):
126 pass
127 # pylint: disable=no-self-use
128 def read(self):
129 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
130 'GERRIT_HOST: True\n')
131
132
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000133class AuthenticatorMock(object):
134 def __init__(self, *_args):
135 pass
136 def has_cached_credentials(self):
137 return True
tandrii221ab252016-10-06 08:12:04 -0700138 def authorize(self, http):
139 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000140
141
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100142def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000143 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
144
145 Usage:
146 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000148
149 OR
150 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100151 CookiesAuthenticatorMockFactory(
152 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000153 """
154 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800155 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000156 # Intentionally not calling super() because it reads actual cookie files.
157 pass
158 @classmethod
159 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000160 return os.path.join('~', '.gitcookies')
161
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000162 @classmethod
163 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000164 return os.path.join('~', NETRC_FILENAME)
165
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100166 def _get_auth_for_host(self, host):
167 if same_auth:
168 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000169 return (hosts_with_creds or {}).get(host)
170 return CookiesAuthenticatorMock
171
Aaron Gable9a03ae02017-11-03 11:31:07 -0700172
kmarshall9249e012016-08-23 12:02:16 -0700173class MockChangelistWithBranchAndIssue():
174 def __init__(self, branch, issue):
175 self.branch = branch
176 self.issue = issue
177 def GetBranch(self):
178 return self.branch
179 def GetIssue(self):
180 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000181
tandriic2405f52016-10-10 08:13:15 -0700182
183class SystemExitMock(Exception):
184 pass
185
186
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000187class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000188 def setUp(self):
189 mock.patch('sys.exit', side_effect=SystemExitMock).start()
190 mock.patch('sys.stdout', StringIO()).start()
191 mock.patch('sys.stderr', StringIO()).start()
192 self.addCleanup(mock.patch.stopall)
193
194 def test_die_with_error(self):
195 with self.assertRaises(SystemExitMock):
196 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
197 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
198 self.assertTrue('saving CL description' in sys.stdout.getvalue())
199 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
200 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
201 sys.exit.assert_called_once_with(1)
202
203 def test_die_with_error_no_desc(self):
204 with self.assertRaises(SystemExitMock):
205 git_cl.DieWithError('foo')
206 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
207 self.assertEqual(sys.stdout.getvalue(), '')
208 sys.exit.assert_called_once_with(1)
209
Edward Lemur6c6827c2020-02-06 21:15:18 +0000210 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000211 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100212 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000213 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700214
Edward Lemur61bf4172020-02-24 23:22:37 +0000215 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
216 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
217 def test_get_cl_statuses(self, *_mocks):
218 statuses = [
219 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
220 changes = []
221 for status in statuses:
222 cl = git_cl.Changelist()
223 cl.status = status
224 changes.append(cl)
225
226 actual = set(git_cl.get_cl_statuses(changes, True))
227 self.assertEqual(set(zip(changes, statuses)), actual)
228
229 def test_get_cl_statuses_no_changes(self):
230 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
231
232 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
233 @mock.patch('multiprocessing.pool.ThreadPool')
234 def test_get_cl_statuses_timeout(self, *_mocks):
235 changes = [git_cl.Changelist() for _ in range(2)]
236 pool = multiprocessing.pool.ThreadPool()
237 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
238 it.return_value.next.side_effect = [
239 (changes[0], 'lgtm'),
240 multiprocessing.TimeoutError,
241 ]
242
243 actual = list(git_cl.get_cl_statuses(changes, True))
244 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
245
246 @mock.patch('git_cl.Changelist.GetIssueURL')
247 def test_get_cl_statuses_not_finegrained(self, _mock):
248 changes = [git_cl.Changelist() for _ in range(2)]
249 urls = ['some-url', None]
250 git_cl.Changelist.GetIssueURL.side_effect = urls
251
252 actual = set(git_cl.get_cl_statuses(changes, False))
253 self.assertEqual(
254 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
255
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000256 def test_get_issue_url(self):
257 cl = git_cl.Changelist(issue=123)
258 cl._gerrit_server = 'https://example.com'
259 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
260 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
261
262 cl = git_cl.Changelist(issue=123)
263 cl._gerrit_server = 'https://chromium-review.googlesource.com'
264 self.assertEqual(cl.GetIssueURL(),
265 'https://chromium-review.googlesource.com/123')
266 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
267
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000268 def test_set_preserve_tryjobs(self):
269 d = git_cl.ChangeDescription('Simple.')
270 d.set_preserve_tryjobs()
271 self.assertEqual(d.description.splitlines(), [
272 'Simple.',
273 '',
274 'Cq-Do-Not-Cancel-Tryjobs: true',
275 ])
276 before = d.description
277 d.set_preserve_tryjobs()
278 self.assertEqual(before, d.description)
279
280 d = git_cl.ChangeDescription('\n'.join([
281 'One is enough',
282 '',
283 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
284 'Change-Id: Ideadbeef',
285 ]))
286 d.set_preserve_tryjobs()
287 self.assertEqual(d.description.splitlines(), [
288 'One is enough',
289 '',
290 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
291 'Change-Id: Ideadbeef',
292 'Cq-Do-Not-Cancel-Tryjobs: true',
293 ])
294
tandriif9aefb72016-07-01 09:06:51 -0700295 def test_get_bug_line_values(self):
296 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
297 self.assertEqual(f('', ''), [])
298 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
299 self.assertEqual(f('v8', '456'), ['v8:456'])
300 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
301 # Not nice, but not worth carying.
302 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
303 ['v8:456', 'chromium:123', 'v8:123'])
304
Edward Lesmescba46082020-03-25 00:29:06 +0000305 def _test_git_number(self, parent_msg, dest_ref, child_msg,
306 parent_hash='parenthash'):
307 desc = git_cl.ChangeDescription(child_msg)
308 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
309 return desc.description
310
311 def assertEqualByLine(self, actual, expected):
312 self.assertEqual(actual.splitlines(), expected.splitlines())
313
314 def test_git_number_bad_parent(self):
315 with self.assertRaises(ValueError):
316 self._test_git_number('Parent', 'refs/heads/master', 'Child')
317
318 def test_git_number_bad_parent_footer(self):
319 with self.assertRaises(AssertionError):
320 self._test_git_number(
321 'Parent\n'
322 '\n'
323 'Cr-Commit-Position: wrong',
324 'refs/heads/master', 'Child')
325
326 def test_git_number_bad_lineage_ignored(self):
327 actual = self._test_git_number(
328 'Parent\n'
329 '\n'
330 'Cr-Commit-Position: refs/heads/master@{#1}\n'
331 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
332 'refs/heads/master', 'Child')
333 self.assertEqualByLine(
334 actual,
335 'Child\n'
336 '\n'
337 'Cr-Commit-Position: refs/heads/master@{#2}\n'
338 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
339
340 def test_git_number_same_branch(self):
341 actual = self._test_git_number(
342 'Parent\n'
343 '\n'
344 'Cr-Commit-Position: refs/heads/master@{#12}',
345 dest_ref='refs/heads/master',
346 child_msg='Child')
347 self.assertEqualByLine(
348 actual,
349 'Child\n'
350 '\n'
351 'Cr-Commit-Position: refs/heads/master@{#13}')
352
353 def test_git_number_same_branch_mixed_footers(self):
354 actual = self._test_git_number(
355 'Parent\n'
356 '\n'
357 'Cr-Commit-Position: refs/heads/master@{#12}',
358 dest_ref='refs/heads/master',
359 child_msg='Child\n'
360 '\n'
361 'Broken-by: design\n'
362 'BUG=123')
363 self.assertEqualByLine(
364 actual,
365 'Child\n'
366 '\n'
367 'Broken-by: design\n'
368 'BUG=123\n'
369 'Cr-Commit-Position: refs/heads/master@{#13}')
370
371 def test_git_number_same_branch_with_originals(self):
372 actual = self._test_git_number(
373 'Parent\n'
374 '\n'
375 'Cr-Commit-Position: refs/heads/master@{#12}',
376 dest_ref='refs/heads/master',
377 child_msg='Child\n'
378 '\n'
379 'Some users are smart and insert their own footers\n'
380 '\n'
381 'Cr-Whatever: value\n'
382 'Cr-Commit-Position: refs/copy/paste@{#22}')
383 self.assertEqualByLine(
384 actual,
385 'Child\n'
386 '\n'
387 'Some users are smart and insert their own footers\n'
388 '\n'
389 'Cr-Original-Whatever: value\n'
390 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
391 'Cr-Commit-Position: refs/heads/master@{#13}')
392
393 def test_git_number_new_branch(self):
394 actual = self._test_git_number(
395 'Parent\n'
396 '\n'
397 'Cr-Commit-Position: refs/heads/master@{#12}',
398 dest_ref='refs/heads/branch',
399 child_msg='Child')
400 self.assertEqualByLine(
401 actual,
402 'Child\n'
403 '\n'
404 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
405 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
406
407 def test_git_number_lineage(self):
408 actual = self._test_git_number(
409 'Parent\n'
410 '\n'
411 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
412 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
413 dest_ref='refs/heads/branch',
414 child_msg='Child')
415 self.assertEqualByLine(
416 actual,
417 'Child\n'
418 '\n'
419 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
420 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
421
422 def test_git_number_moooooooore_lineage(self):
423 actual = self._test_git_number(
424 'Parent\n'
425 '\n'
426 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
427 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
428 dest_ref='refs/heads/mooore',
429 child_msg='Child')
430 self.assertEqualByLine(
431 actual,
432 'Child\n'
433 '\n'
434 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
435 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
436 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
437
438 def test_git_number_ever_moooooooore_lineage(self):
439 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
440 actual = self._test_git_number(
441 'CQ commit on fresh new branch + numbering.\n'
442 '\n'
443 'NOTRY=True\n'
444 'NOPRESUBMIT=True\n'
445 'BUG=\n'
446 '\n'
447 'Review-Url: https://codereview.chromium.org/2577703003\n'
448 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
449 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
450 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
451 dest_ref='refs/heads/gnumb-test/cl',
452 child_msg='git cl on fresh new branch + numbering.\n'
453 '\n'
454 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
455 self.assertEqualByLine(
456 actual,
457 'git cl on fresh new branch + numbering.\n'
458 '\n'
459 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
460 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
461 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
462 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
463 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
464
465 def test_git_number_cherry_pick(self):
466 actual = self._test_git_number(
467 'Parent\n'
468 '\n'
469 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
470 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
471 dest_ref='refs/heads/branch',
472 child_msg='Child, which is cherry-pick from master\n'
473 '\n'
474 'Cr-Commit-Position: refs/heads/master@{#100}\n'
475 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
476 self.assertEqualByLine(
477 actual,
478 'Child, which is cherry-pick from master\n'
479 '\n'
480 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
481 '\n'
482 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
483 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
484 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
485
Edward Lemurda4b6c62020-02-13 00:28:40 +0000486 @mock.patch('gerrit_util.GetAccountDetails')
487 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000488 mock_per_account = {
489 'u1': None, # 404, doesn't exist.
490 'u2': {
491 '_account_id': 123124,
492 'avatars': [],
493 'email': 'u2@example.com',
494 'name': 'User Number 2',
495 'status': 'OOO',
496 },
497 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
498 }
499 def GetAccountDetailsMock(_, account):
500 # Poor-man's mock library's side_effect.
501 v = mock_per_account.pop(account)
502 if isinstance(v, Exception):
503 raise v
504 return v
505
Edward Lemurda4b6c62020-02-13 00:28:40 +0000506 mockGetAccountDetails.side_effect = GetAccountDetailsMock
507 actual = git_cl.gerrit_util.ValidAccounts(
508 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000509 self.assertEqual(actual, {
510 'u2': {
511 '_account_id': 123124,
512 'avatars': [],
513 'email': 'u2@example.com',
514 'name': 'User Number 2',
515 'status': 'OOO',
516 },
517 })
518
519
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200520class TestParseIssueURL(unittest.TestCase):
521 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000522 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200523 self.assertIsNotNone(parsed)
524 if fail:
525 self.assertFalse(parsed.valid)
526 return
527 self.assertTrue(parsed.valid)
528 self.assertEqual(parsed.issue, issue)
529 self.assertEqual(parsed.patchset, patchset)
530 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200531
Edward Lemur678a6842019-10-03 22:25:05 +0000532 def test_ParseIssueNumberArgument(self):
533 def test(arg, *args, **kwargs):
534 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200535
Edward Lemur678a6842019-10-03 22:25:05 +0000536 test('123', 123)
537 test('', fail=True)
538 test('abc', fail=True)
539 test('123/1', fail=True)
540 test('123a', fail=True)
541 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200542
Edward Lemur678a6842019-10-03 22:25:05 +0000543 test('https://codereview.source.com/123',
544 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200545 test('http://chrome-review.source.com/c/123',
546 123, None, 'chrome-review.source.com')
547 test('https://chrome-review.source.com/c/123/',
548 123, None, 'chrome-review.source.com')
549 test('https://chrome-review.source.com/c/123/4',
550 123, 4, 'chrome-review.source.com')
551 test('https://chrome-review.source.com/#/c/123/4',
552 123, 4, 'chrome-review.source.com')
553 test('https://chrome-review.source.com/c/123/4',
554 123, 4, 'chrome-review.source.com')
555 test('https://chrome-review.source.com/123',
556 123, None, 'chrome-review.source.com')
557 test('https://chrome-review.source.com/123/4',
558 123, 4, 'chrome-review.source.com')
559
Edward Lemur678a6842019-10-03 22:25:05 +0000560 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200561 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
562 test('https://chrome-review.source.com/c/abc/', fail=True)
563 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
564
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200565
566
Edward Lemurda4b6c62020-02-13 00:28:40 +0000567class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100568 def setUp(self):
569 super(GitCookiesCheckerTest, self).setUp()
570 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100571 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000572 mock.patch('sys.stdout', StringIO()).start()
573 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100574
575 def mock_hosts_creds(self, subhost_identity_pairs):
576 def ensure_googlesource(h):
577 if not h.endswith(self.c._GOOGLESOURCE):
578 assert not h.endswith('.')
579 return h + '.' + self.c._GOOGLESOURCE
580 return h
581 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
582 for h, i in subhost_identity_pairs]
583
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200584 def test_identity_parsing(self):
585 self.assertEqual(self.c._parse_identity('ldap.google.com'),
586 ('ldap', 'google.com'))
587 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
588 ('ldap', 'example.com'))
589 # Specical case because we know there are no subdomains in chromium.org.
590 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
591 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800592 # Pathological: ".period." can be either username OR domain, more likely
593 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200594 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
595 ('note', 'period.example.com'))
596
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100597 def test_analysis_nothing(self):
598 self.c._all_hosts = []
599 self.assertFalse(self.c.has_generic_host())
600 self.assertEqual(set(), self.c.get_conflicting_hosts())
601 self.assertEqual(set(), self.c.get_duplicated_hosts())
602 self.assertEqual(set(), self.c.get_partially_configured_hosts())
603 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
604
605 def test_analysis(self):
606 self.mock_hosts_creds([
607 ('.googlesource.com', 'git-example.chromium.org'),
608
609 ('chromium', 'git-example.google.com'),
610 ('chromium-review', 'git-example.google.com'),
611 ('chrome-internal', 'git-example.chromium.org'),
612 ('chrome-internal-review', 'git-example.chromium.org'),
613 ('conflict', 'git-example.google.com'),
614 ('conflict-review', 'git-example.chromium.org'),
615 ('dup', 'git-example.google.com'),
616 ('dup', 'git-example.google.com'),
617 ('dup-review', 'git-example.google.com'),
618 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200619 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100620 ])
621 self.assertTrue(self.c.has_generic_host())
622 self.assertEqual(set(['conflict.googlesource.com']),
623 self.c.get_conflicting_hosts())
624 self.assertEqual(set(['dup.googlesource.com']),
625 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200626 self.assertEqual(set(['partial.googlesource.com',
627 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100628 self.c.get_partially_configured_hosts())
629 self.assertEqual(set(['chromium.googlesource.com',
630 'chrome-internal.googlesource.com']),
631 self.c.get_hosts_with_wrong_identities())
632
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100633 def test_report_no_problems(self):
634 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100635 self.assertFalse(self.c.find_and_report_problems())
636 self.assertEqual(sys.stdout.getvalue(), '')
637
Edward Lemurda4b6c62020-02-13 00:28:40 +0000638 @mock.patch(
639 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000640 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000641 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100642 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100643 self.assertTrue(self.c.find_and_report_problems())
644 with open(os.path.join(os.path.dirname(__file__),
645 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000646 expected = f.read() % {
647 'sep': os.sep,
648 }
649
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100650 def by_line(text):
651 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700652 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200653 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100654
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800655
Edward Lemurda4b6c62020-02-13 00:28:40 +0000656class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000657 def setUp(self):
658 super(TestGitCl, self).setUp()
659 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700660 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000661 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000662 mock.patch('sys.stdout', StringIO()).start()
663 mock.patch(
664 'git_cl.time_time',
665 lambda: self._mocked_call('time.time')).start()
666 mock.patch(
667 'git_cl.metrics.collector.add_repeated',
668 lambda *a: self._mocked_call('add_repeated', *a)).start()
669 mock.patch('subprocess2.call', self._mocked_call).start()
670 mock.patch('subprocess2.check_call', self._mocked_call).start()
671 mock.patch('subprocess2.check_output', self._mocked_call).start()
672 mock.patch(
673 'subprocess2.communicate',
674 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
675 mock.patch(
676 'git_cl.gclient_utils.CheckCallAndFilter',
677 self._mocked_call).start()
678 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
679 mock.patch(
680 'git_common.get_or_create_merge_base',
681 lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start()
Edward Lesmescba46082020-03-25 00:29:06 +0000682 mock.patch('git_cl.BranchExists', return_value=True).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000683 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
684 mock.patch(
685 'git_cl.SaveDescriptionBackup',
686 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
687 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000688 'git_cl.write_json',
689 lambda *a: self._mocked_call('write_json', *a)).start()
690 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000691 'git_cl.Changelist.RunHook',
692 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000693 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
694 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000695 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000696 mock.patch(
697 'git_cl.gerrit_util.GetChangeComments',
698 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
699 mock.patch(
700 'git_cl.gerrit_util.GetChangeRobotComments',
701 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
702 mock.patch(
703 'git_cl.gerrit_util.AddReviewers',
704 lambda *a: self._mocked_call('AddReviewers', *a)).start()
705 mock.patch(
706 'git_cl.gerrit_util.SetReview',
707 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
708 self._mocked_call(
709 'SetReview', h, i, msg, labels, notify, ready))).start()
710 mock.patch(
711 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
712 return_value=False).start()
713 mock.patch(
714 'git_cl.gerrit_util.GceAuthenticator.is_gce',
715 return_value=False).start()
716 mock.patch(
717 'git_cl.gerrit_util.ValidAccounts',
718 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000719 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000720 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000721 self.mockGit = GitMocks()
722 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
723 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
724 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000725 mock.patch(
726 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000727 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000728 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000729 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000730 mock.patch(
731 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000732 # It's important to reset settings to not have inter-tests interference.
733 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000734 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000735
736 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000737 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000738 if not self.failed:
739 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100740 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000741 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
742 if len(self.calls) > 5:
743 calls += ' ...\n'
744 self.fail(
745 '\n'
746 'There are un-consumed calls after this test has finished:\n' +
747 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000748 finally:
749 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000750
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000751 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000752 self.assertTrue(
753 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700754 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000755 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000756 expected_args, result = top
757
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000758 # Also logs otherwise it could get caught in a try/finally and be hard to
759 # diagnose.
760 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700761 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000762 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700763 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
764 for i, c in enumerate(self._calls_done[-N:]))
765 following_calls = '\n '.join(
766 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
767 for i, c in enumerate(self.calls[:N]))
768 extended_msg = (
769 'A few prior calls:\n %s\n\n'
770 'This (expected):\n @%d: %r\n'
771 'This (actual):\n @%d: %r\n\n'
772 'A few following expected calls:\n %s' %
773 (prior_calls, len(self._calls_done), expected_args,
774 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700775
Edward Lesmes0dd54822020-03-26 18:24:25 +0000776 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700777 self.fail('@%d\n'
778 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000779 ' Actual: %r\n'
780 '\n'
781 '%s' % (
782 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700783
784 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700785 if isinstance(result, Exception):
786 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000787 # stdout from git commands is supposed to be a bytestream. Convert it here
788 # instead of converting all test output in this file to bytes.
789 if args[0][0] == 'git' and not isinstance(result, bytes):
790 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000791 return result
792
Edward Lemur1a83da12020-03-04 21:18:36 +0000793 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
794 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100795 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100796 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000797 self.assertEqual(
798 'prompt [Yes/No]: Please, type yes or no: ',
799 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100800
tandrii48df5812016-10-17 03:55:37 -0700801 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000802 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700803 self.calls = [
804 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700805 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
806 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
807 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
808 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700809 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
810 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700811 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
812 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000813 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
814 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700815 ((['git', 'config', 'gerrit.host', 'true'],), ''),
816 ]
817 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
818
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000819 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100820 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200821 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000822 custom_cl_base=None, short_hostname='chromium',
823 change_id=None):
Edward Lemur26964072020-02-19 19:18:51 +0000824 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200825 if custom_cl_base:
826 ancestor_revision = custom_cl_base
827 else:
828 # Determine ancestor_revision to be merge base.
829 ancestor_revision = 'fake_ancestor_sha'
830 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000831 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
832 ancestor_revision),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200833 ]
834
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100835 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000836 gerrit_util.GetChangeDetail.return_value = {
837 'owner': {'email': (other_cl_owner or 'owner@example.com')},
838 'change_id': (change_id or '123456789'),
839 'current_revision': 'sha1_of_current_revision',
840 'revisions': {'sha1_of_current_revision': {
841 'commit': {'message': fetched_description},
842 }},
843 'status': fetched_status or 'NEW',
844 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100845 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100846 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100847 if other_cl_owner:
848 calls += [
849 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
850 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100851
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100852 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200853 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
854 ([custom_cl_base] if custom_cl_base else
855 [ancestor_revision, 'HEAD']),),
856 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100857 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000858
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100859 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000860
Edward Lemur26964072020-02-19 19:18:51 +0000861 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700862 squash_mode='default',
Aaron Gablefd238082017-06-07 13:42:34 -0700863 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100864 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000865 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000866 short_hostname='chromium',
Edward Lemur5a644f82020-03-18 16:44:57 +0000867 labels=None, change_id=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000868 final_description=None, gitcookies_exists=True,
Josipe827b0f2020-01-30 00:07:20 +0000869 force=False, edit_description=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000870 if post_amend_description is None:
871 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700872 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200873
874 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000875
Edward Lemur26964072020-02-19 19:18:51 +0000876 if squash_mode in ('override_squash', 'override_nosquash'):
877 self.mockGit.config['gerrit.override-squash-uploads'] = (
878 'true' if squash_mode == 'override_squash' else 'false')
tandriia60502f2016-06-20 02:01:53 -0700879
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000880 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000881 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200882 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200883 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000884 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000885 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000886 calls += [
887 ((['RunEditor'],), description),
888 ]
Josipe827b0f2020-01-30 00:07:20 +0000889 # user wants to edit description
890 if edit_description:
891 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000892 ((['RunEditor'],), edit_description),
893 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000894 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200895
896 if custom_cl_base is None:
897 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000898 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000899 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200900 ]
901 parent = 'origin/master'
902 else:
903 calls += [
904 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
905 'refs/remotes/origin/master'],),
906 callError(1)), # Means not ancenstor.
907 (('ask_for_data',
908 'Do you take responsibility for cleaning up potential mess '
909 'resulting from proceeding with upload? Press Enter to upload, '
910 'or Ctrl+C to abort'), ''),
911 ]
912 parent = custom_cl_base
913
914 calls += [
915 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
916 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000917 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200918 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000919 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200920 ref_to_push),
921 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000922 else:
923 ref_to_push = 'HEAD'
Edward Lemur5a644f82020-03-18 16:44:57 +0000924 parent = 'origin/refs/heads/master'
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000925
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000926 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000927 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000928 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200929 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000930
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000931 metrics_arguments = []
932
Aaron Gableafd52772017-06-27 16:40:10 -0700933 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700934 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000935 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700936 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400937 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700938 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000939 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700940 else:
941 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000942 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800943
Edward Lemur5a644f82020-03-18 16:44:57 +0000944 # If issue is given, then description is fetched from Gerrit instead.
945 if issue is None:
946 if squash:
947 title = 'Initial upload'
948 else:
949 if not title:
950 calls += [
951 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
952 (('ask_for_data', 'Title for patchset []: '), 'User input'),
953 ]
954 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700955 if title:
Edward Lemur5a644f82020-03-18 16:44:57 +0000956 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000957 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000958
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000959 if short_hostname == 'chromium':
960 # All reviwers and ccs get into ref_suffix.
961 for r in sorted(reviewers):
962 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000963 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000964 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000965 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000966 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000967 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000968 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000969 reviewers, cc = [], []
970 else:
971 # TODO(crbug/877717): remove this case.
972 calls += [
973 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
974 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000975 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000976 {
977 e: {'email': e}
978 for e in (reviewers + ['joe@example.com'] + cc)
979 })
980 ]
981 for r in sorted(reviewers):
982 if r != 'bad-account-or-email':
983 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000984 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000985 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000986 if issue is None:
987 cc += ['joe@example.com']
988 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000989 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000990 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000991 if c in cc:
992 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000993
Edward Lemur687ca902018-12-05 02:30:30 +0000994 for k, v in sorted((labels or {}).items()):
995 ref_suffix += ',l=%s+%d' % (k, v)
996 metrics_arguments.append('l=%s+%d' % (k, v))
997
998 if tbr:
999 calls += [
1000 (('GetCodeReviewTbrScore',
1001 '%s-review.googlesource.com' % short_hostname,
1002 'my/repo'),
1003 2,),
1004 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001005
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001006 calls += [
1007 (('time.time',), 1000,),
1008 ((['git', 'push',
1009 'https://%s.googlesource.com/my/repo' % short_hostname,
1010 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1011 (('remote:\n'
1012 'remote: Processing changes: (\)\n'
1013 'remote: Processing changes: (|)\n'
1014 'remote: Processing changes: (/)\n'
1015 'remote: Processing changes: (-)\n'
1016 'remote: Processing changes: new: 1 (/)\n'
1017 'remote: Processing changes: new: 1, done\n'
1018 'remote:\n'
1019 'remote: New Changes:\n'
1020 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1021 ' XXX\n'
1022 'remote:\n'
1023 'To https://%s.googlesource.com/my/repo\n'
1024 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1025 ) % (short_hostname, short_hostname)),),
1026 (('time.time',), 2000,),
1027 (('add_repeated',
1028 'sub_commands',
1029 {
1030 'execution_time': 1000,
1031 'command': 'git push',
1032 'exit_code': 0,
1033 'arguments': sorted(metrics_arguments),
1034 }),
1035 None,),
1036 ]
1037
Edward Lemur1b52d872019-05-09 21:12:12 +00001038 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001039
1040 date_format = ('03/16/17 20:00:41'
1041 if sys.platform == 'win32' and sys.version_info.major == 2
1042 else 'Thu Mar 16 20:00:41 2017')
1043 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
1044
Edward Lemur1b52d872019-05-09 21:12:12 +00001045 # Trace-related calls
1046 calls += [
1047 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001048 (
1049 ([
1050 'FileWrite', trace_name + '-README',
1051 '%(date)s\n'
1052 '%(short_hostname)s-review.googlesource.com\n'
1053 '%(change_id)s\n'
1054 '%(title)s\n'
1055 '%(description)s\n'
1056 '1000\n'
1057 '0\n'
1058 '%(trace_name)s' % {
1059 'date': date_format,
1060 'short_hostname': short_hostname,
1061 'change_id': change_id,
1062 'description': final_description,
1063 'title': title or '<untitled>',
1064 'trace_name': trace_name,
1065 }
1066 ], ),
1067 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001068 ),
1069 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001070 (
1071 (['os.path.isfile',
1072 os.path.join('TEMP_DIR', 'trace-packet')], ),
1073 True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001074 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001075 (
1076 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
1077 ('git-hash: 0123456789012345678901234567890123456789\n'
1078 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +00001079 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001080 (
1081 ([
1082 'FileWrite',
1083 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
1084 'git-hash: abcdea\n'
1085 ], ),
1086 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001087 ),
1088 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001089 (
1090 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
1091 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001092 ),
1093 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001094 (
1095 (['git', 'config', '-l'], ),
1096 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +00001097 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001098 (
1099 ([
1100 'FileWrite',
1101 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
1102 ], ),
1103 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001104 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001105 (
1106 (['os.path.isfile',
1107 os.path.join('~', '.gitcookies')], ),
1108 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +00001109 ),
1110 ]
1111 if gitcookies_exists:
1112 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001113 (
1114 (['FileRead', os.path.join('~', '.gitcookies')], ),
1115 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +00001116 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001117 (
1118 ([
1119 'FileWrite',
1120 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
1121 ], ),
1122 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001123 ),
1124 ]
1125 calls += [
1126 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001127 (
1128 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
1129 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001130 ),
1131 ]
1132
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001133 # TODO(crbug/877717): this should never be used.
1134 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001135 calls += [
1136 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001137 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001138 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001139 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001140 notify),
1141 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001142 ]
Edward Lesmescba46082020-03-25 00:29:06 +00001143 calls += [
1144 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
1145 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001146 return calls
1147
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001148 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001149 self,
1150 upload_args,
1151 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001152 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001153 squash=True,
1154 squash_mode=None,
Aaron Gable9b713dd2016-12-14 16:04:21 -08001155 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001156 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001157 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001158 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001159 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001160 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001161 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001162 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001163 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001164 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001165 labels=None,
1166 change_id=None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001167 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001168 gitcookies_exists=True,
1169 force=False,
Edward Lesmes0dd54822020-03-26 18:24:25 +00001170 log_description=None,
Josipe827b0f2020-01-30 00:07:20 +00001171 edit_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001172 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001173 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001174 if squash_mode is None:
1175 if '--no-squash' in upload_args:
1176 squash_mode = 'nosquash'
1177 elif '--squash' in upload_args:
1178 squash_mode = 'squash'
1179 else:
1180 squash_mode = 'default'
1181
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001182 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001183 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001184 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001185 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001186 same_auth=('git-owner.example.com', '', 'pass'))).start()
1187 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1188 lambda _, offer_removal: None).start()
1189 mock.patch('git_cl.gclient_utils.RunEditor',
1190 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1191 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
1192 'DownloadGerritHook', force)).start()
1193 mock.patch('git_cl.gclient_utils.FileRead',
1194 lambda path: self._mocked_call(['FileRead', path])).start()
1195 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001196 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001197 ['FileWrite', path, contents])).start()
1198 mock.patch('git_cl.datetime_now',
1199 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1200 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1201 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1202 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001203 '%(now)s\n'
1204 '%(gerrit_host)s\n'
1205 '%(change_id)s\n'
1206 '%(title)s\n'
1207 '%(description)s\n'
1208 '%(execution_time)s\n'
1209 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001210 '%(trace_name)s').start()
1211 mock.patch('git_cl.shutil.make_archive',
1212 lambda *args: self._mocked_call(['make_archive'] +
1213 list(args))).start()
1214 mock.patch('os.path.isfile',
1215 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lesmescba46082020-03-25 00:29:06 +00001216 mock.patch('git_cl.Changelist.GitSanityChecks', return_value=True).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001217 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001218 'git_cl._create_description_from_log',
1219 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001220 mock.patch(
1221 'git_cl.Changelist._AddChangeIdToCommitMessage',
1222 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001223 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001224 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1225 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001226 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001227 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001228
Edward Lemur26964072020-02-19 19:18:51 +00001229 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001230 self.mockGit.config['branch.master.gerritissue'] = (
1231 str(issue) if issue else None)
1232 self.mockGit.config['remote.origin.url'] = (
1233 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001234 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001235
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001236 self.calls = self._gerrit_base_calls(
1237 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001238 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001239 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001240 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001241 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001242 short_hostname=short_hostname,
1243 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001244 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001245 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001246 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001247 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001248 self.calls += self._gerrit_upload_calls(
1249 description, reviewers, squash,
1250 squash_mode=squash_mode,
Aaron Gablefd238082017-06-07 13:42:34 -07001251 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001252 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001253 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001254 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001255 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001256 labels=labels,
1257 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001258 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001259 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001260 force=force,
1261 edit_description=edit_description)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001262 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001263 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001264 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001265 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001266 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001267 self.assertEqual(
1268 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001269 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001270
Edward Lemur1b52d872019-05-09 21:12:12 +00001271 def test_gerrit_upload_traces_no_gitcookies(self):
1272 self._run_gerrit_upload_test(
1273 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001274 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001275 [],
1276 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001277 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001278 change_id='Ixxx',
1279 gitcookies_exists=False)
1280
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001281 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001282 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001283 [],
1284 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1285 [],
1286 change_id='Ixxx')
1287
1288 def test_gerrit_upload_without_change_id_nosquash(self):
1289 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001290 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001291 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001292 [],
1293 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001294 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001295 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001296
1297 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001298 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001299 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001300 'desc ✔\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001301 [],
tandriia60502f2016-06-20 02:01:53 -07001302 squash=False,
1303 squash_mode='override_nosquash',
Edward Lemur0db01f02019-11-12 22:01:51 +00001304 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001305 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001306
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001307 def test_gerrit_no_reviewer(self):
1308 self._run_gerrit_upload_test(
1309 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001310 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001311 [],
1312 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001313 squash_mode='override_nosquash',
1314 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001315
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001316 def test_gerrit_no_reviewer_non_chromium_host(self):
1317 # TODO(crbug/877717): remove this test case.
1318 self._run_gerrit_upload_test(
1319 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001320 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001321 [],
1322 squash=False,
1323 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001324 short_hostname='other',
1325 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001326
Edward Lesmes0dd54822020-03-26 18:24:25 +00001327 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001328 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001329 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001330 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001331 squash=False,
1332 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001333 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001334 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001335
ukai@chromium.orge8077812012-02-03 03:41:46 +00001336 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001337 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001338 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001339 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001340 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001341 squash=False,
1342 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001343 notify=True,
1344 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001345 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001346 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001347
Anthony Polito8b955342019-09-24 19:01:36 +00001348 def test_gerrit_upload_force_sets_bug(self):
1349 self._run_gerrit_upload_test(
1350 ['-b', '10000', '-f'],
1351 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1352 [],
1353 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001354 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001355 change_id='Ixxx')
1356
Edward Lemur5fb22242020-03-12 22:05:13 +00001357 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001358 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001359 ['-b', '10000', '-m', 'Title', '--edit-description'],
1360 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001361 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001362 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001363 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001364 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001365 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001366 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001367
Dan Beamd8b04ca2019-10-10 21:23:26 +00001368 def test_gerrit_upload_force_sets_fixed(self):
1369 self._run_gerrit_upload_test(
1370 ['-x', '10000', '-f'],
1371 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1372 [],
1373 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001374 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001375 change_id='Ixxx')
1376
ukai@chromium.orge8077812012-02-03 03:41:46 +00001377 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001378 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1379 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001380 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001381 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001382 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001383 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001384 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001385 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001386 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001387 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001388 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001389 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001390
1391 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001392 self._run_gerrit_upload_test(
1393 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001394 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001395 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001396 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001397
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001398 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001399 self._run_gerrit_upload_test(
1400 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001401 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001402 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001403 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001404 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001405
Edward Lesmes0dd54822020-03-26 18:24:25 +00001406 def test_gerrit_upload_squash_first_title(self):
1407 self._run_gerrit_upload_test(
1408 ['-f', '-t', 'title'],
1409 'title\n\ndesc\n\nChange-Id: 123456789',
1410 [],
1411 force=True,
1412 squash=True,
1413 log_description='desc',
1414 change_id='123456789')
1415
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001416 def test_gerrit_upload_squash_first_with_labels(self):
1417 self._run_gerrit_upload_test(
1418 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001419 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001420 [],
1421 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001422 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001423 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001424
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001425 def test_gerrit_upload_squash_first_against_rev(self):
1426 custom_cl_base = 'custom_cl_base_rev_or_branch'
1427 self._run_gerrit_upload_test(
1428 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001429 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001430 [],
1431 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001432 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001433 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001434 self.assertIn(
1435 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1436 sys.stdout.getvalue())
1437
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001438 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001439 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001440 self._run_gerrit_upload_test(
1441 ['--squash'],
1442 description,
1443 [],
1444 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001445 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001446 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001447
Edward Lemurd55c5072020-02-20 01:09:07 +00001448 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001449 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001450 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001451 with self.assertRaises(SystemExitMock):
1452 self._run_gerrit_upload_test(
1453 ['--squash'],
1454 description,
1455 [],
1456 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001457 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001458 fetched_status='ABANDONED',
1459 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001460 self.assertEqual(
1461 'Change https://chromium-review.googlesource.com/123456 has been '
1462 'abandoned, new uploads are not allowed\n',
1463 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001464
Edward Lemurda4b6c62020-02-13 00:28:40 +00001465 @mock.patch(
1466 'gerrit_util.GetAccountDetails',
1467 return_value={'email': 'yet-another@example.com'})
1468 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001469 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001470 self._run_gerrit_upload_test(
1471 ['--squash'],
1472 description,
1473 [],
1474 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001475 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001476 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001477 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001478 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001479 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001480 'authenticate to Gerrit as yet-another@example.com.\n'
1481 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001482 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001483
Josipe827b0f2020-01-30 00:07:20 +00001484 def test_upload_change_description_editor(self):
1485 fetched_description = 'foo\n\nChange-Id: 123456789'
1486 description = 'bar\n\nChange-Id: 123456789'
1487 self._run_gerrit_upload_test(
1488 ['--squash', '--edit-description'],
1489 description,
1490 [],
1491 fetched_description=fetched_description,
1492 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001493 issue=123456,
1494 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001495 edit_description=description)
1496
Edward Lemurda4b6c62020-02-13 00:28:40 +00001497 @mock.patch('git_cl.RunGit')
1498 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001499 @mock.patch('sys.stdin', StringIO('\n'))
1500 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001501 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001502 def mock_run_git(*args, **_kwargs):
1503 if args[0] == ['for-each-ref',
1504 '--format=%(refname:short) %(upstream:short)',
1505 'refs/heads']:
1506 # Create a local branch dependency tree that looks like this:
1507 # test1 -> test2 -> test3 -> test4 -> test5
1508 # -> test3.1
1509 # test6 -> test0
1510 branch_deps = [
1511 'test2 test1', # test1 -> test2
1512 'test3 test2', # test2 -> test3
1513 'test3.1 test2', # test2 -> test3.1
1514 'test4 test3', # test3 -> test4
1515 'test5 test4', # test4 -> test5
1516 'test6 test0', # test0 -> test6
1517 'test7', # test7
1518 ]
1519 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001520 git_cl.RunGit.side_effect = mock_run_git
1521 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001522
1523 class MockChangelist():
1524 def __init__(self):
1525 pass
1526 def GetBranch(self):
1527 return 'test1'
1528 def GetIssue(self):
1529 return '123'
1530 def GetPatchset(self):
1531 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001532 def IsGerrit(self):
1533 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001534
1535 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1536 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001537 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001538 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001539 'This command will checkout all dependent branches '
1540 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001541 'or Ctrl+C to abort',
1542 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001543 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001544
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001545 def test_gerrit_change_id(self):
1546 self.calls = [
1547 ((['git', 'write-tree'], ),
1548 'hashtree'),
1549 ((['git', 'rev-parse', 'HEAD~0'], ),
1550 'branch-parent'),
1551 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1552 'A B <a@b.org> 1456848326 +0100'),
1553 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1554 'C D <c@d.org> 1456858326 +0100'),
1555 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1556 'hashchange'),
1557 ]
1558 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1559 self.assertEqual(change_id, 'Ihashchange')
1560
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001561 def test_desecription_append_footer(self):
1562 for init_desc, footer_line, expected_desc in [
1563 # Use unique desc first lines for easy test failure identification.
1564 ('foo', 'R=one', 'foo\n\nR=one'),
1565 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1566 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1567 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1568 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1569 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1570 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1571 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1572 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1573 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1574 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1575 ]:
1576 desc = git_cl.ChangeDescription(init_desc)
1577 desc.append_footer(footer_line)
1578 self.assertEqual(desc.description, expected_desc)
1579
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001580 def test_update_reviewers(self):
1581 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001582 ('foo', [], [],
1583 'foo'),
1584 ('foo\nR=xx', [], [],
1585 'foo\nR=xx'),
1586 ('foo\nTBR=xx', [], [],
1587 'foo\nTBR=xx'),
1588 ('foo', ['a@c'], [],
1589 'foo\n\nR=a@c'),
1590 ('foo\nR=xx', ['a@c'], [],
1591 'foo\n\nR=a@c, xx'),
1592 ('foo\nTBR=xx', ['a@c'], [],
1593 'foo\n\nR=a@c\nTBR=xx'),
1594 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1595 'foo\n\nR=a@c, yy\nTBR=xx'),
1596 ('foo\nBUG=', ['a@c'], [],
1597 'foo\nBUG=\nR=a@c'),
1598 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1599 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1600 ('foo', ['a@c', 'b@c'], [],
1601 'foo\n\nR=a@c, b@c'),
1602 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1603 'foo\nBar\n\nR=c@c\nBUG='),
1604 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1605 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001606 # Same as the line before, but full of whitespaces.
1607 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001608 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001609 'foo\nBar\n\nR=c@c\n BUG =',
1610 ),
1611 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001612 ('foo BUG=allo R=joe ', ['c@c'], [],
1613 'foo BUG=allo R=joe\n\nR=c@c'),
1614 # Redundant TBRs get promoted to Rs
1615 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1616 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001617 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001618 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001619 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001620 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001621 obj = git_cl.ChangeDescription(orig)
Edward Lemur2c62b332020-03-12 22:12:33 +00001622 obj.update_reviewers(reviewers, tbrs, None, None, None)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001623 actual.append(obj.description)
1624 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001625
Nodir Turakulov23b82142017-11-16 11:04:25 -08001626 def test_get_hash_tags(self):
1627 cases = [
1628 ('', []),
1629 ('a', []),
1630 ('[a]', ['a']),
1631 ('[aa]', ['aa']),
1632 ('[a ]', ['a']),
1633 ('[a- ]', ['a']),
1634 ('[a- b]', ['a-b']),
1635 ('[a--b]', ['a-b']),
1636 ('[a', []),
1637 ('[a]x', ['a']),
1638 ('[aa]x', ['aa']),
1639 ('[a b]', ['a-b']),
1640 ('[a b]', ['a-b']),
1641 ('[a__b]', ['a-b']),
1642 ('[a] x', ['a']),
1643 ('[a][b]', ['a', 'b']),
1644 ('[a] [b]', ['a', 'b']),
1645 ('[a][b]x', ['a', 'b']),
1646 ('[a][b] x', ['a', 'b']),
1647 ('[a]\n[b]', ['a']),
1648 ('[a\nb]', []),
1649 ('[a][', ['a']),
1650 ('Revert "[a] feature"', ['a']),
1651 ('Reland "[a] feature"', ['a']),
1652 ('Revert: [a] feature', ['a']),
1653 ('Reland: [a] feature', ['a']),
1654 ('Revert "Reland: [a] feature"', ['a']),
1655 ('Foo: feature', ['foo']),
1656 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001657 ('Change Foo::Bar', []),
1658 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001659 ('Revert "Foo bar: feature"', ['foo-bar']),
1660 ('Reland "Foo bar: feature"', ['foo-bar']),
1661 ]
1662 for desc, expected in cases:
1663 change_desc = git_cl.ChangeDescription(desc)
1664 actual = change_desc.get_hash_tags()
1665 self.assertEqual(
1666 actual,
1667 expected,
1668 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1669
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001670 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001671 self.assertEqual(None, git_cl.GetTargetRef(None,
1672 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001673 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001674
wittman@chromium.org455dc922015-01-26 20:15:50 +00001675 # Check default target refs for branches.
1676 self.assertEqual('refs/heads/master',
1677 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001678 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001679 self.assertEqual('refs/heads/master',
1680 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001681 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001682 self.assertEqual('refs/heads/master',
1683 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001684 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001685 self.assertEqual('refs/branch-heads/123',
1686 git_cl.GetTargetRef('origin',
1687 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001688 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001689 self.assertEqual('refs/diff/test',
1690 git_cl.GetTargetRef('origin',
1691 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001692 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001693 self.assertEqual('refs/heads/chrome/m42',
1694 git_cl.GetTargetRef('origin',
1695 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001696 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001697
1698 # Check target refs for user-specified target branch.
1699 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1700 'refs/remotes/branch-heads/123'):
1701 self.assertEqual('refs/branch-heads/123',
1702 git_cl.GetTargetRef('origin',
1703 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001704 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001705 for branch in ('origin/master', 'remotes/origin/master',
1706 'refs/remotes/origin/master'):
1707 self.assertEqual('refs/heads/master',
1708 git_cl.GetTargetRef('origin',
1709 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001710 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001711 for branch in ('master', 'heads/master', 'refs/heads/master'):
1712 self.assertEqual('refs/heads/master',
1713 git_cl.GetTargetRef('origin',
1714 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001715 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001716
Edward Lemurda4b6c62020-02-13 00:28:40 +00001717 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1718 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001719 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001720 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1721
Edward Lemur85153282020-02-14 22:06:29 +00001722 def assertIssueAndPatchset(
1723 self, branch='master', issue='123456', patchset='7',
1724 git_short_host='chromium'):
1725 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001726 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001727 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001728 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001729 self.assertEqual(
1730 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001731 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001732
Edward Lemur85153282020-02-14 22:06:29 +00001733 def _patch_common(self, git_short_host='chromium'):
Edward Lesmescba46082020-03-25 00:29:06 +00001734 mock.patch('git_cl.IsGitVersionAtLeast', return_value=True).start()
Edward Lemur26964072020-02-19 19:18:51 +00001735 self.mockGit.config['remote.origin.url'] = (
1736 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001737 gerrit_util.GetChangeDetail.return_value = {
1738 'current_revision': '7777777777',
1739 'revisions': {
1740 '1111111111': {
1741 '_number': 1,
1742 'fetch': {'http': {
1743 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1744 'ref': 'refs/changes/56/123456/1',
1745 }},
1746 },
1747 '7777777777': {
1748 '_number': 7,
1749 'fetch': {'http': {
1750 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1751 'ref': 'refs/changes/56/123456/7',
1752 }},
1753 },
1754 },
1755 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001756
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001757 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001758 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001759 self.calls += [
1760 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1761 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001762 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Edward Lesmescba46082020-03-25 00:29:06 +00001763 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001764 ]
1765 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001766 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001767
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001768 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001769 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001770 self.calls += [
1771 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1772 'refs/changes/56/123456/7'],), ''),
1773 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Edward Lesmescba46082020-03-25 00:29:06 +00001774 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001775 ]
Edward Lemur85153282020-02-14 22:06:29 +00001776 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1777 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001778
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001779 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001780 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001781 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001782 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001783 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001784 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
Edward Lesmescba46082020-03-25 00:29:06 +00001785 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001786 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001787 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001788 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001789
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001790 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001791 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001792 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001793 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001794 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001795 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Edward Lesmescba46082020-03-25 00:29:06 +00001796 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001797 ]
1798 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001799 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001800 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001801
Aaron Gable697a91b2018-01-19 15:20:15 -08001802 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001803 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001804 self.calls += [
1805 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1806 'refs/changes/56/123456/1'],), ''),
1807 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Edward Lesmescba46082020-03-25 00:29:06 +00001808 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Aaron Gable697a91b2018-01-19 15:20:15 -08001809 ]
1810 self.assertEqual(git_cl.main(
1811 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1812 0)
Edward Lemur85153282020-02-14 22:06:29 +00001813 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001814
Edward Lemurd55c5072020-02-20 01:09:07 +00001815 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001816 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001817 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001818 self.calls += [
1819 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001820 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001821 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001822 ]
1823 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001824 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001825 self.assertEqual(
1826 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1827 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001828
Edward Lemurda4b6c62020-02-13 00:28:40 +00001829 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001830 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001831 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001832 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001833 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001834 self.mockGit.config['remote.origin.url'] = (
1835 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001836 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001837 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001838 self.assertEqual(
1839 'change 123456 at https://chromium-review.googlesource.com does not '
1840 'exist or you have no access to it\n',
1841 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001842
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001843 def _checkout_calls(self):
1844 return [
1845 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001846 'branch\\..*\\.gerritissue'], ),
1847 ('branch.ger-branch.gerritissue 123456\n'
1848 'branch.gbranch654.gerritissue 654321\n')),
1849 ]
1850
1851 def test_checkout_gerrit(self):
1852 """Tests git cl checkout <issue>."""
1853 self.calls = self._checkout_calls()
1854 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1855 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1856
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001857 def test_checkout_not_found(self):
1858 """Tests git cl checkout <issue>."""
1859 self.calls = self._checkout_calls()
1860 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1861
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001862 def test_checkout_no_branch_issues(self):
1863 """Tests git cl checkout <issue>."""
1864 self.calls = [
1865 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001866 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001867 ]
1868 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1869
Edward Lemur26964072020-02-19 19:18:51 +00001870 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00001871 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001872 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001873 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001874 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1875 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001876 self.mockGit.config['remote.origin.url'] = (
1877 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001878 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001879 cl.branch = 'master'
1880 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001881 return cl
1882
Edward Lemurd55c5072020-02-20 01:09:07 +00001883 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001884 def test_gerrit_ensure_authenticated_missing(self):
1885 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001886 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001887 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001888 with self.assertRaises(SystemExitMock):
1889 cl.EnsureAuthenticated(force=False)
1890 self.assertEqual(
1891 'Credentials for the following hosts are required:\n'
1892 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001893 'These are read from ~%(sep)s.gitcookies '
1894 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00001895 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001896 'https://chromium-review.googlesource.com/new-password\n' % {
1897 'sep': os.sep,
1898 'netrc': NETRC_FILENAME,
1899 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001900
1901 def test_gerrit_ensure_authenticated_conflict(self):
1902 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001903 'chromium.googlesource.com':
1904 ('git-one.example.com', None, 'secret1'),
1905 'chromium-review.googlesource.com':
1906 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001907 })
1908 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001909 (('ask_for_data', 'If you know what you are doing '
1910 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001911 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1912
1913 def test_gerrit_ensure_authenticated_ok(self):
1914 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001915 'chromium.googlesource.com':
1916 ('git-same.example.com', None, 'secret'),
1917 'chromium-review.googlesource.com':
1918 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001919 })
1920 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1921
tandrii@chromium.org28253532016-04-14 13:46:56 +00001922 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00001923 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
1924 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00001925 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1926
Eric Boren2fb63102018-10-05 13:05:03 +00001927 def test_gerrit_ensure_authenticated_bearer_token(self):
1928 cl = self._test_gerrit_ensure_authenticated_common(auth={
1929 'chromium.googlesource.com':
1930 ('', None, 'secret'),
1931 'chromium-review.googlesource.com':
1932 ('', None, 'secret'),
1933 })
1934 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1935 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1936 'chromium.googlesource.com')
1937 self.assertTrue('Bearer' in header)
1938
Daniel Chengcf6269b2019-05-18 01:02:12 +00001939 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00001940 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00001941 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001942 (('logging.warning',
1943 'Ignoring branch %(branch)s with non-https remote '
1944 '%(remote)s', {
1945 'branch': 'master',
1946 'remote': 'custom-scheme://repo'}
1947 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001948 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001949 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1950 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1951 mock.patch('logging.warning',
1952 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00001953 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00001954 cl.branch = 'master'
1955 cl.branchref = 'refs/heads/master'
1956 cl.lookedup_issue = True
1957 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1958
Florian Mayerae510e82020-01-30 21:04:48 +00001959 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00001960 self.mockGit.config['remote.origin.url'] = (
1961 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00001962 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001963 (('logging.error',
1964 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1965 'but it doesn\'t exist.', {
1966 'remote': 'origin',
1967 'branch': 'master',
1968 'url': 'git@somehost.example:foo/bar.git'}
1969 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00001970 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001971 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1972 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1973 mock.patch('logging.error',
1974 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00001975 cl = git_cl.Changelist()
1976 cl.branch = 'master'
1977 cl.branchref = 'refs/heads/master'
1978 cl.lookedup_issue = True
1979 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1980
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001981 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00001982 self.mockGit.config['branch.master.gerritissue'] = '123'
1983 self.mockGit.config['branch.master.gerritserver'] = (
1984 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00001985 self.mockGit.config['remote.origin.url'] = (
1986 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001987 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00001988 (('SetReview', 'chromium-review.googlesource.com',
1989 'infra%2Finfra~123', None,
1990 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001991 ]
tandriid9e5ce52016-07-13 02:32:59 -07001992
1993 def test_cmd_set_commit_gerrit_clear(self):
1994 self._cmd_set_commit_gerrit_common(0)
1995 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1996
1997 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001998 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001999 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2000
tandriid9e5ce52016-07-13 02:32:59 -07002001 def test_cmd_set_commit_gerrit(self):
2002 self._cmd_set_commit_gerrit_common(2)
2003 self.assertEqual(0, git_cl.main(['set-commit']))
2004
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002005 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002006 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002007 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002008
2009 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002010 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002011
Edward Lemurda4b6c62020-02-13 00:28:40 +00002012 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07002013 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07002014 try:
2015 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00002016 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00002017 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00002018 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07002019
2020 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07002021 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002022 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002023 return 'foobar'
2024
Edward Lemurda4b6c62020-02-13 00:28:40 +00002025 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07002026 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002027 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002028 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00002029 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07002030
iannuccie53c9352016-08-17 14:40:40 -07002031 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002032
iannuccie53c9352016-08-17 14:40:40 -07002033 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002034 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002035 return 'foobar'
2036
Edward Lemurda4b6c62020-02-13 00:28:40 +00002037 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2038 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002039 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002040 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002041
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002042 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00002043 self.mockGit.config['remote.origin.url'] = (
2044 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002045 gerrit_util.GetChangeDetail.return_value = {
2046 'current_revision': 'sha1',
2047 'revisions': {'sha1': {
2048 'commit': {'message': 'foobar'},
2049 }},
2050 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002051 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002052 'description',
2053 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2054 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002055 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002056
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002057 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002058 mock.patch('git_cl.Changelist', ChangelistMock).start()
2059 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002060
2061 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2062 self.assertEqual('hihi', ChangelistMock.desc)
2063
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002064 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002065 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002066
2067 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002068 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002069 '# Enter a description of the change.\n'
2070 '# This will be displayed on the codereview site.\n'
2071 '# The first line will also be used as the subject of the review.\n'
2072 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002073 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002074 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002075 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002076 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002077 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002078
Edward Lemur6c6827c2020-02-06 21:15:18 +00002079 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002080 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002081
Edward Lemurda4b6c62020-02-13 00:28:40 +00002082 mock.patch('git_cl.Changelist.FetchDescription',
2083 lambda *args: current_desc).start()
2084 mock.patch('git_cl.Changelist.UpdateDescription',
2085 UpdateDescription).start()
2086 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002087
Edward Lemur85153282020-02-14 22:06:29 +00002088 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002089 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002090
Dan Beamd8b04ca2019-10-10 21:23:26 +00002091 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2092 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2093
2094 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002095 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002096 '# Enter a description of the change.\n'
2097 '# This will be displayed on the codereview site.\n'
2098 '# The first line will also be used as the subject of the review.\n'
2099 '#--------------------This line is 72 characters long'
2100 '--------------------\n'
2101 'Some.\n\nFixed: 123\nChange-Id: xxx',
2102 desc)
2103 return desc
2104
Edward Lemurda4b6c62020-02-13 00:28:40 +00002105 mock.patch('git_cl.Changelist.FetchDescription',
2106 lambda *args: current_desc).start()
2107 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002108
Edward Lemur85153282020-02-14 22:06:29 +00002109 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002110 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002111
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002112 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002113 mock.patch('git_cl.Changelist', ChangelistMock).start()
2114 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002115
2116 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2117 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2118
kmarshall3bff56b2016-06-06 18:31:47 -07002119 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002120 self.calls = [
2121 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002122 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002123 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002124 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002125 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002126 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002127
Edward Lemurda4b6c62020-02-13 00:28:40 +00002128 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002129 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002130 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2131 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002132 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002133
2134 self.assertEqual(0, git_cl.main(['archive', '-f']))
2135
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002136 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002137 self.calls = [
2138 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2139 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2140 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2141 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002142 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2143 ((['git', 'branch', '-D', 'foo'],), '')
2144 ]
2145
Edward Lemurda4b6c62020-02-13 00:28:40 +00002146 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002147 lambda branches, fine_grained, max_processes:
2148 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2149 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002150 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002151
2152 self.assertEqual(0, git_cl.main(['archive', '-f']))
2153
kmarshall3bff56b2016-06-06 18:31:47 -07002154 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002155 self.calls = [
2156 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2157 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002158 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002159 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002160
Edward Lemurda4b6c62020-02-13 00:28:40 +00002161 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002162 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002163 [(MockChangelistWithBranchAndIssue('master', 1),
2164 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002165
2166 self.assertEqual(1, git_cl.main(['archive', '-f']))
2167
2168 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002169 self.calls = [
2170 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2171 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002172 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002173 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002174
Edward Lemurda4b6c62020-02-13 00:28:40 +00002175 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002176 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002177 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2178 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002179 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002180
kmarshall9249e012016-08-23 12:02:16 -07002181 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2182
2183 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002184 self.calls = [
2185 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2186 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002187 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002188 ((['git', 'branch', '-D', 'foo'],), '')
2189 ]
kmarshall9249e012016-08-23 12:02:16 -07002190
Edward Lemurda4b6c62020-02-13 00:28:40 +00002191 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002192 lambda branches, fine_grained, max_processes:
2193 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2194 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002195 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002196
2197 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002198
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002199 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002200 self.calls = [
2201 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2202 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2203 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002204 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2205 'refs/tags/git-cl-archived-456-foo'),
2206 ((['git', 'branch', '-D', 'foo'],), CERR1),
2207 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2208 'refs/tags/git-cl-archived-456-foo'),
2209 ]
2210
Edward Lemurda4b6c62020-02-13 00:28:40 +00002211 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002212 lambda branches, fine_grained, max_processes:
2213 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2214 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002215 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002216
2217 self.assertEqual(0, git_cl.main(['archive', '-f']))
2218
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002219 def test_archive_with_format(self):
2220 self.calls = [
2221 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
2222 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2223 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2224 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2225 ((['git', 'branch', '-D', 'foo'], ), ''),
2226 ]
2227
2228 mock.patch('git_cl.get_cl_statuses',
2229 lambda branches, fine_grained, max_processes:
2230 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2231
2232 self.assertEqual(
2233 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2234
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002235 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002236 self.mockGit.config['branch.master.gerritissue'] = '123'
2237 self.mockGit.config['branch.master.gerritserver'] = (
2238 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002239 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002240 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002241 ]
2242 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002243 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2244 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002245
Aaron Gable400e9892017-07-12 15:31:21 -07002246 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002247 self.mockGit.config['branch.master.gerritissue'] = '123'
2248 self.mockGit.config['branch.master.gerritserver'] = (
2249 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002250 mock.patch('git_cl.Changelist.FetchDescription',
2251 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002252 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002253 ((['git', 'log', '-1', '--format=%B'],),
2254 'This is a description\n\nChange-Id: Ideadbeef'),
2255 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002256 ]
2257 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002258 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2259 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002260
phajdan.jre328cf92016-08-22 04:12:17 -07002261 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002262 self.mockGit.config['branch.master.gerritissue'] = '123'
2263 self.mockGit.config['branch.master.gerritserver'] = (
2264 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002265 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002266 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002267 {'issue': 123,
2268 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002269 ''),
2270 ]
2271 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2272
tandrii16e0b4e2016-06-07 10:34:28 -07002273 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002274 mock.patch(
2275 'git_cl.os.path.abspath',
2276 lambda path: self._mocked_call(['abspath', path])).start()
2277 mock.patch(
2278 'git_cl.os.path.exists',
2279 lambda path: self._mocked_call(['exists', path])).start()
2280 mock.patch(
2281 'git_cl.gclient_utils.FileRead',
2282 lambda path: self._mocked_call(['FileRead', path])).start()
2283 mock.patch(
2284 'git_cl.gclient_utils.rm_file_or_tree',
2285 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002286 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002287 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002288 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002289 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002290
2291 def test_GerritCommitMsgHookCheck_custom_hook(self):
2292 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002293 self.calls += [((['exists',
2294 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2295 ((['FileRead',
2296 os.path.join('.git', 'hooks', 'commit-msg')], ),
2297 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002298 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002299
2300 def test_GerritCommitMsgHookCheck_not_exists(self):
2301 cl = self._common_GerritCommitMsgHookCheck()
2302 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002303 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002304 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002305 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002306
2307 def test_GerritCommitMsgHookCheck(self):
2308 cl = self._common_GerritCommitMsgHookCheck()
2309 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002310 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2311 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002312 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002313 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002314 ((['rm_file_or_tree',
2315 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002316 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002317 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002318
tandriic4344b52016-08-29 06:04:54 -07002319 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002320 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2321 self.mockGit.config['branch.master.gerritserver'] = (
2322 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002323 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002324 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002325 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002326 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002327 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002328 'labels': {},
2329 'current_revision': 'deadbeaf',
2330 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002331 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002332 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002333 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002334 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2335 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002336 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002337 self.assertEqual(0, cl.CMDLand(force=True,
2338 bypass_hooks=True,
2339 verbose=True,
2340 parallel=False))
Edward Lemur73c76702020-02-06 23:57:18 +00002341 self.assertIn(
2342 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002343 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002344 self.assertIn(
2345 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002346 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002347
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002348 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002349 mock.patch('git_cl.Changelist._GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002350
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002351 def test_gerrit_change_detail_cache_simple(self):
2352 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002353 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002354 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002355 cl1._cached_remote_url = (
2356 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002357 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002358 cl2._cached_remote_url = (
2359 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002360 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2361 self.assertEqual(cl1._GetChangeDetail(), 'a')
2362 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002363
2364 def test_gerrit_change_detail_cache_options(self):
2365 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002366 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002367 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002368 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002369 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2370 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2371 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2372 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2373 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2374 self.assertEqual(cl._GetChangeDetail(), 'cab')
2375
2376 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2377 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2378 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2379 self.assertEqual(cl._GetChangeDetail(), 'cab')
2380
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002381 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002382 gerrit_util.GetChangeDetail.return_value = {
2383 'current_revision': 'rev1',
2384 'revisions': {
2385 'rev1': {'commit': {'message': 'desc1'}},
2386 },
2387 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002388
2389 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002390 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002391 cl._cached_remote_url = (
2392 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002393 self.assertEqual(cl.FetchDescription(), 'desc1')
2394 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002395
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002396 def test_print_current_creds(self):
2397 class CookiesAuthenticatorMock(object):
2398 def __init__(self):
2399 self.gitcookies = {
2400 'host.googlesource.com': ('user', 'pass'),
2401 'host-review.googlesource.com': ('user', 'pass'),
2402 }
2403 self.netrc = self
2404 self.netrc.hosts = {
2405 'github.com': ('user2', None, 'pass2'),
2406 'host2.googlesource.com': ('user3', None, 'pass'),
2407 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002408 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2409 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002410 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2411 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2412 ' Host\t User\t Which file',
2413 '============================\t=====\t===========',
2414 'host-review.googlesource.com\t user\t.gitcookies',
2415 ' host.googlesource.com\t user\t.gitcookies',
2416 ' host2.googlesource.com\tuser3\t .netrc',
2417 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002418 sys.stdout.seek(0)
2419 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002420 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2421 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2422 ' Host\tUser\t Which file',
2423 '============================\t====\t===========',
2424 'host-review.googlesource.com\tuser\t.gitcookies',
2425 ' host.googlesource.com\tuser\t.gitcookies',
2426 ])
2427
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002428 def _common_creds_check_mocks(self):
2429 def exists_mock(path):
2430 dirname = os.path.dirname(path)
2431 if dirname == os.path.expanduser('~'):
2432 dirname = '~'
2433 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002434 if base in (NETRC_FILENAME, '.gitcookies'):
2435 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002436 # git cl also checks for existence other files not relevant to this test.
2437 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002438 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002439 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002440 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002441 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002442
2443 def test_creds_check_gitcookies_not_configured(self):
2444 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002445 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2446 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002447 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002448 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2449 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2450 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2451 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2452 'or Ctrl+C to abort'), ''),
2453 (([
2454 'git', 'config', '--global', 'http.cookiefile',
2455 os.path.expanduser(os.path.join('~', '.gitcookies'))
2456 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002457 ]
2458 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002459 self.assertTrue(
2460 sys.stdout.getvalue().startswith(
2461 'You seem to be using outdated .netrc for git credentials:'))
2462 self.assertIn(
2463 '\nConfigured git to use .gitcookies from',
2464 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002465
2466 def test_creds_check_gitcookies_configured_custom_broken(self):
2467 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002468 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2469 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002470 custom_cookie_path = ('C:\\.gitcookies'
2471 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002472 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002473 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2474 ((['git', 'config', '--global', 'http.cookiefile'], ),
2475 custom_cookie_path),
2476 (('os.path.exists', custom_cookie_path), False),
2477 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2478 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2479 (([
2480 'git', 'config', '--global', 'http.cookiefile',
2481 os.path.expanduser(os.path.join('~', '.gitcookies'))
2482 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002483 ]
2484 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002485 self.assertIn(
2486 'WARNING: You have configured custom path to .gitcookies: ',
2487 sys.stdout.getvalue())
2488 self.assertIn(
2489 'However, your configured .gitcookies file is missing.',
2490 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002491
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002492 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002493 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002494 self.mockGit.config['remote.origin.url'] = (
2495 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002496 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002497 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002498 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002499 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002500 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002501 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002502
Edward Lemurda4b6c62020-02-13 00:28:40 +00002503 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2504 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002505 self.mockGit.config['remote.origin.url'] = (
2506 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002507 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002508 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002509 'current_revision': 'ba5eba11',
2510 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002511 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002512 '_number': 1,
2513 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002514 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002515 '_number': 2,
2516 },
2517 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002518 'messages': [
2519 {
2520 u'_revision_number': 1,
2521 u'author': {
2522 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002523 u'email': u'could-be-anything@example.com',
2524 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002525 },
2526 u'date': u'2017-03-15 20:08:45.000000000',
2527 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002528 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002529 u'tag': u'autogenerated:cq:dry-run'
2530 },
2531 {
2532 u'_revision_number': 2,
2533 u'author': {
2534 u'_account_id': 11151243,
2535 u'email': u'owner@example.com',
2536 u'name': u'owner'
2537 },
2538 u'date': u'2017-03-16 20:00:41.000000000',
2539 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2540 u'message': u'PTAL',
2541 },
2542 {
2543 u'_revision_number': 2,
2544 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002545 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002546 u'email': u'reviewer@example.com',
2547 u'name': u'reviewer'
2548 },
2549 u'date': u'2017-03-17 05:19:37.500000000',
2550 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2551 u'message': u'Patch Set 2: Code-Review+1',
2552 },
2553 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002554 }
2555 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002556 (('GetChangeComments', 'chromium-review.googlesource.com',
2557 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002558 '/COMMIT_MSG': [
2559 {
2560 'author': {'email': u'reviewer@example.com'},
2561 'updated': u'2017-03-17 05:19:37.500000000',
2562 'patch_set': 2,
2563 'side': 'REVISION',
2564 'message': 'Please include a bug link',
2565 },
2566 ],
2567 'codereview.settings': [
2568 {
2569 'author': {'email': u'owner@example.com'},
2570 'updated': u'2017-03-16 20:00:41.000000000',
2571 'patch_set': 2,
2572 'side': 'PARENT',
2573 'line': 42,
2574 'message': 'I removed this because it is bad',
2575 },
2576 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002577 }),
2578 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2579 'infra%2Finfra~1'), {}),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002580 ] * 2 + [
2581 (('write_json', 'output.json', [
2582 {
2583 u'date': u'2017-03-16 20:00:41.000000',
2584 u'message': (
2585 u'PTAL\n' +
2586 u'\n' +
2587 u'codereview.settings\n' +
2588 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2589 u'c/1/2/codereview.settings#b42\n' +
2590 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002591 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002592 u'approval': False,
2593 u'disapproval': False,
2594 u'sender': u'owner@example.com'
2595 }, {
2596 u'date': u'2017-03-17 05:19:37.500000',
2597 u'message': (
2598 u'Patch Set 2: Code-Review+1\n' +
2599 u'\n' +
2600 u'/COMMIT_MSG\n' +
2601 u' PS2, File comment: https://chromium-review.googlesource' +
2602 u'.com/c/1/2//COMMIT_MSG#\n' +
2603 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002604 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002605 u'approval': False,
2606 u'disapproval': False,
2607 u'sender': u'reviewer@example.com'
2608 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002609 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002610 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002611 expected_comments_summary = [
2612 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002613 message=(
2614 u'PTAL\n' +
2615 u'\n' +
2616 u'codereview.settings\n' +
2617 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2618 u'c/1/2/codereview.settings#b42\n' +
2619 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002620 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002621 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002622 disapproval=False, approval=False, sender=u'owner@example.com'),
2623 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002624 message=(
2625 u'Patch Set 2: Code-Review+1\n' +
2626 u'\n' +
2627 u'/COMMIT_MSG\n' +
2628 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2629 u'c/1/2//COMMIT_MSG#\n' +
2630 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002631 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002632 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002633 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2634 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002635 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002636 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002637 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002638 self.assertEqual(
2639 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2640
2641 def test_git_cl_comments_robot_comments(self):
2642 # git cl comments also fetches robot comments (which are considered a type
2643 # of autogenerated comment), and unlike other types of comments, only robot
2644 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002645 self.mockGit.config['remote.origin.url'] = (
2646 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002647 gerrit_util.GetChangeDetail.return_value = {
2648 'owner': {'email': 'owner@example.com'},
2649 'current_revision': 'ba5eba11',
2650 'revisions': {
2651 'deadbeaf': {
2652 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002653 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002654 'ba5eba11': {
2655 '_number': 2,
2656 },
2657 },
2658 'messages': [
2659 {
2660 u'_revision_number': 1,
2661 u'author': {
2662 u'_account_id': 1111084,
2663 u'email': u'commit-bot@chromium.org',
2664 u'name': u'Commit Bot'
2665 },
2666 u'date': u'2017-03-15 20:08:45.000000000',
2667 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2668 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2669 u'tag': u'autogenerated:cq:dry-run'
2670 },
2671 {
2672 u'_revision_number': 1,
2673 u'author': {
2674 u'_account_id': 123,
2675 u'email': u'tricium@serviceaccount.com',
2676 u'name': u'Tricium'
2677 },
2678 u'date': u'2017-03-16 20:00:41.000000000',
2679 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2680 u'message': u'(1 comment)',
2681 u'tag': u'autogenerated:tricium',
2682 },
2683 {
2684 u'_revision_number': 1,
2685 u'author': {
2686 u'_account_id': 123,
2687 u'email': u'tricium@serviceaccount.com',
2688 u'name': u'Tricium'
2689 },
2690 u'date': u'2017-03-16 20:00:41.000000000',
2691 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2692 u'message': u'(1 comment)',
2693 u'tag': u'autogenerated:tricium',
2694 },
2695 {
2696 u'_revision_number': 2,
2697 u'author': {
2698 u'_account_id': 123,
2699 u'email': u'tricium@serviceaccount.com',
2700 u'name': u'reviewer'
2701 },
2702 u'date': u'2017-03-17 05:30:37.000000000',
2703 u'tag': u'autogenerated:tricium',
2704 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2705 u'message': u'(1 comment)',
2706 },
2707 ]
2708 }
2709 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002710 (('GetChangeComments', 'chromium-review.googlesource.com',
2711 'infra%2Finfra~1'), {}),
2712 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2713 'infra%2Finfra~1'), {
2714 'codereview.settings': [
2715 {
2716 u'author': {u'email': u'tricium@serviceaccount.com'},
2717 u'updated': u'2017-03-17 05:30:37.000000000',
2718 u'robot_run_id': u'5565031076855808',
2719 u'robot_id': u'Linter/Category',
2720 u'tag': u'autogenerated:tricium',
2721 u'patch_set': 2,
2722 u'side': u'REVISION',
2723 u'message': u'Linter warning message text',
2724 u'line': 32,
2725 },
2726 ],
2727 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002728 ]
2729 expected_comments_summary = [
2730 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2731 message=(
2732 u'(1 comment)\n\ncodereview.settings\n'
2733 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2734 u'c/1/2/codereview.settings#32\n'
2735 u' Linter warning message text\n'),
2736 sender=u'tricium@serviceaccount.com',
2737 autogenerated=True, approval=False, disapproval=False)
2738 ]
2739 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002740 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002741 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002742
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002743 def test_get_remote_url_with_mirror(self):
2744 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002745
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002746 def selective_os_path_isdir_mock(path):
2747 if path == '/cache/this-dir-exists':
2748 return self._mocked_call('os.path.isdir', path)
2749 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002750
Edward Lemurda4b6c62020-02-13 00:28:40 +00002751 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002752
2753 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002754 self.mockGit.config['remote.origin.url'] = (
2755 '/cache/this-dir-exists')
2756 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2757 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002758 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002759 (('os.path.isdir', '/cache/this-dir-exists'),
2760 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002761 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002762 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002763 self.assertEqual(cl.GetRemoteUrl(), url)
2764 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2765
Edward Lemur298f2cf2019-02-22 21:40:39 +00002766 def test_get_remote_url_non_existing_mirror(self):
2767 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002768
Edward Lemur298f2cf2019-02-22 21:40:39 +00002769 def selective_os_path_isdir_mock(path):
2770 if path == '/cache/this-dir-doesnt-exist':
2771 return self._mocked_call('os.path.isdir', path)
2772 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002773
Edward Lemurda4b6c62020-02-13 00:28:40 +00002774 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2775 mock.patch('logging.error',
2776 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002777
Edward Lemur26964072020-02-19 19:18:51 +00002778 self.mockGit.config['remote.origin.url'] = (
2779 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002780 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002781 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2782 False),
2783 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002784 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2785 'but it doesn\'t exist.', {
2786 'remote': 'origin',
2787 'branch': 'master',
2788 'url': '/cache/this-dir-doesnt-exist'}
2789 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002790 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002791 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002792 self.assertIsNone(cl.GetRemoteUrl())
2793
2794 def test_get_remote_url_misconfigured_mirror(self):
2795 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002796
Edward Lemur298f2cf2019-02-22 21:40:39 +00002797 def selective_os_path_isdir_mock(path):
2798 if path == '/cache/this-dir-exists':
2799 return self._mocked_call('os.path.isdir', path)
2800 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002801
Edward Lemurda4b6c62020-02-13 00:28:40 +00002802 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2803 mock.patch('logging.error',
2804 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002805
Edward Lemur26964072020-02-19 19:18:51 +00002806 self.mockGit.config['remote.origin.url'] = (
2807 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002808 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002809 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002810 (('logging.error',
2811 'Remote "%(remote)s" for branch "%(branch)s" points to '
2812 '"%(cache_path)s", but it is misconfigured.\n'
2813 '"%(cache_path)s" must be a git repo and must have a remote named '
2814 '"%(remote)s" pointing to the git host.', {
2815 'remote': 'origin',
2816 'cache_path': '/cache/this-dir-exists',
2817 'branch': 'master'}
2818 ), None),
2819 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002820 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002821 self.assertIsNone(cl.GetRemoteUrl())
2822
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002823 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002824 self.mockGit.config['remote.origin.url'] = (
2825 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002826 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002827 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2828
2829 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002830 mock.patch('logging.error',
2831 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002832
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002833 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002834 (('logging.error',
2835 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2836 'but it doesn\'t exist.', {
2837 'remote': 'origin',
2838 'branch': 'master',
2839 'url': ''}
2840 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002841 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002842 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002843 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002844
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002845
Edward Lemur9aa1a962020-02-25 00:58:38 +00002846class ChangelistTest(unittest.TestCase):
Edward Lemur227d5102020-02-25 23:45:35 +00002847 def setUp(self):
2848 super(ChangelistTest, self).setUp()
2849 mock.patch('gclient_utils.FileRead').start()
2850 mock.patch('gclient_utils.FileWrite').start()
2851 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
2852 mock.patch(
2853 'git_cl.Changelist.GetCodereviewServer',
2854 return_value='https://chromium-review.googlesource.com').start()
2855 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
2856 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
2857 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
2858 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
2859 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
2860 mock.patch('git_cl.time_time').start()
2861 mock.patch('metrics.collector').start()
2862 mock.patch('subprocess2.Popen').start()
2863 self.addCleanup(mock.patch.stopall)
2864 self.temp_count = 0
2865
Edward Lemur227d5102020-02-25 23:45:35 +00002866 def testRunHook(self):
2867 expected_results = {
2868 'more_cc': ['more@example.com', 'cc@example.com'],
2869 'should_continue': True,
2870 }
2871 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2872 git_cl.time_time.side_effect = [100, 200]
2873 mockProcess = mock.Mock()
2874 mockProcess.wait.return_value = 0
2875 subprocess2.Popen.return_value = mockProcess
2876
2877 cl = git_cl.Changelist()
2878 results = cl.RunHook(
2879 committing=True,
2880 may_prompt=True,
2881 verbose=2,
2882 parallel=True,
2883 upstream='upstream',
2884 description='description',
2885 all_files=True)
2886
2887 self.assertEqual(expected_results, results)
2888 subprocess2.Popen.assert_called_once_with([
2889 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00002890 '--root', 'root',
2891 '--upstream', 'upstream',
2892 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002893 '--author', 'author',
2894 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur227d5102020-02-25 23:45:35 +00002895 '--issue', '123456',
2896 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002897 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00002898 '--may_prompt',
2899 '--parallel',
2900 '--all_files',
2901 '--json_output', '/tmp/fake-temp2',
2902 '--description_file', '/tmp/fake-temp1',
2903 ])
2904 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002905 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00002906 metrics.collector.add_repeated('sub_commands', {
2907 'command': 'presubmit',
2908 'execution_time': 100,
2909 'exit_code': 0,
2910 })
2911
Edward Lemur99df04e2020-03-05 19:39:43 +00002912 def testRunHook_FewerOptions(self):
2913 expected_results = {
2914 'more_cc': ['more@example.com', 'cc@example.com'],
2915 'should_continue': True,
2916 }
2917 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2918 git_cl.time_time.side_effect = [100, 200]
2919 mockProcess = mock.Mock()
2920 mockProcess.wait.return_value = 0
2921 subprocess2.Popen.return_value = mockProcess
2922
2923 git_cl.Changelist.GetAuthor.return_value = None
2924 git_cl.Changelist.GetIssue.return_value = None
2925 git_cl.Changelist.GetPatchset.return_value = None
2926 git_cl.Changelist.GetCodereviewServer.return_value = None
2927
2928 cl = git_cl.Changelist()
2929 results = cl.RunHook(
2930 committing=False,
2931 may_prompt=False,
2932 verbose=0,
2933 parallel=False,
2934 upstream='upstream',
2935 description='description',
2936 all_files=False)
2937
2938 self.assertEqual(expected_results, results)
2939 subprocess2.Popen.assert_called_once_with([
2940 'vpython', 'PRESUBMIT_SUPPORT',
2941 '--root', 'root',
2942 '--upstream', 'upstream',
2943 '--upload',
2944 '--json_output', '/tmp/fake-temp2',
2945 '--description_file', '/tmp/fake-temp1',
2946 ])
2947 gclient_utils.FileWrite.assert_called_once_with(
2948 '/tmp/fake-temp1', 'description')
2949 metrics.collector.add_repeated('sub_commands', {
2950 'command': 'presubmit',
2951 'execution_time': 100,
2952 'exit_code': 0,
2953 })
2954
Edward Lemur227d5102020-02-25 23:45:35 +00002955 @mock.patch('sys.exit', side_effect=SystemExitMock)
2956 def testRunHook_Failure(self, _mock):
2957 git_cl.time_time.side_effect = [100, 200]
2958 mockProcess = mock.Mock()
2959 mockProcess.wait.return_value = 2
2960 subprocess2.Popen.return_value = mockProcess
2961
2962 cl = git_cl.Changelist()
2963 with self.assertRaises(SystemExitMock):
2964 cl.RunHook(
2965 committing=True,
2966 may_prompt=True,
2967 verbose=2,
2968 parallel=True,
2969 upstream='upstream',
2970 description='description',
2971 all_files=True)
2972
2973 sys.exit.assert_called_once_with(2)
2974
Edward Lemur75526302020-02-27 22:31:05 +00002975 def testRunPostUploadHook(self):
2976 cl = git_cl.Changelist()
2977 cl.RunPostUploadHook(2, 'upstream', 'description')
2978
2979 subprocess2.Popen.assert_called_once_with([
2980 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00002981 '--root', 'root',
2982 '--upstream', 'upstream',
2983 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00002984 '--author', 'author',
2985 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur75526302020-02-27 22:31:05 +00002986 '--issue', '123456',
2987 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00002988 '--post_upload',
2989 '--description_file', '/tmp/fake-temp1',
2990 ])
2991 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002992 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00002993
Edward Lemur9aa1a962020-02-25 00:58:38 +00002994
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002995class CMDTestCaseBase(unittest.TestCase):
2996 _STATUSES = [
2997 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
2998 'INFRA_FAILURE', 'CANCELED',
2999 ]
3000 _CHANGE_DETAIL = {
3001 'project': 'depot_tools',
3002 'status': 'OPEN',
3003 'owner': {'email': 'owner@e.mail'},
3004 'current_revision': 'beeeeeef',
3005 'revisions': {
3006 'deadbeaf': {'_number': 6},
3007 'beeeeeef': {
3008 '_number': 7,
3009 'fetch': {'http': {
3010 'url': 'https://chromium.googlesource.com/depot_tools',
3011 'ref': 'refs/changes/56/123456/7'
3012 }},
3013 },
3014 },
3015 }
3016 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003017 'builds': [{
3018 'id': str(100 + idx),
3019 'builder': {
3020 'project': 'chromium',
3021 'bucket': 'try',
3022 'builder': 'bot_' + status.lower(),
3023 },
3024 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3025 'tags': [],
3026 'status': status,
3027 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003028 }
3029
Edward Lemur4c707a22019-09-24 21:13:43 +00003030 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003031 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003032 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003033 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3034 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003035 mock.patch(
3036 'git_cl.Changelist.GetCodereviewServer',
3037 return_value='https://chromium-review.googlesource.com').start()
3038 mock.patch(
3039 'git_cl.Changelist._GetGerritHost',
3040 return_value='chromium-review.googlesource.com').start()
3041 mock.patch(
3042 'git_cl.Changelist.GetMostRecentPatchset',
3043 return_value=7).start()
3044 mock.patch(
3045 'git_cl.Changelist.GetRemoteUrl',
3046 return_value='https://chromium.googlesource.com/depot_tools').start()
3047 mock.patch(
3048 'auth.Authenticator',
3049 return_value=AuthenticatorMock()).start()
3050 mock.patch(
3051 'gerrit_util.GetChangeDetail',
3052 return_value=self._CHANGE_DETAIL).start()
3053 mock.patch(
3054 'git_cl._call_buildbucket',
3055 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003056 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003057 self.addCleanup(mock.patch.stopall)
3058
Edward Lemur4c707a22019-09-24 21:13:43 +00003059
Edward Lemur9468eba2020-02-27 19:07:22 +00003060class CMDPresubmitTestCase(CMDTestCaseBase):
3061 def setUp(self):
3062 super(CMDPresubmitTestCase, self).setUp()
3063 mock.patch(
3064 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3065 return_value='upstream').start()
3066 mock.patch(
3067 'git_cl.Changelist.FetchDescription',
3068 return_value='fetch description').start()
3069 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00003070 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00003071 return_value='get description').start()
3072 mock.patch('git_cl.Changelist.RunHook').start()
3073
3074 def testDefaultCase(self):
3075 self.assertEqual(0, git_cl.main(['presubmit']))
3076 git_cl.Changelist.RunHook.assert_called_once_with(
3077 committing=True,
3078 may_prompt=False,
3079 verbose=0,
3080 parallel=None,
3081 upstream='upstream',
3082 description='fetch description',
3083 all_files=None)
3084
3085 def testNoIssue(self):
3086 git_cl.Changelist.GetIssue.return_value = None
3087 self.assertEqual(0, git_cl.main(['presubmit']))
3088 git_cl.Changelist.RunHook.assert_called_once_with(
3089 committing=True,
3090 may_prompt=False,
3091 verbose=0,
3092 parallel=None,
3093 upstream='upstream',
3094 description='get description',
3095 all_files=None)
3096
3097 def testCustomBranch(self):
3098 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3099 git_cl.Changelist.RunHook.assert_called_once_with(
3100 committing=True,
3101 may_prompt=False,
3102 verbose=0,
3103 parallel=None,
3104 upstream='custom_branch',
3105 description='fetch description',
3106 all_files=None)
3107
3108 def testOptions(self):
3109 self.assertEqual(
3110 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u']))
3111 git_cl.Changelist.RunHook.assert_called_once_with(
3112 committing=False,
3113 may_prompt=False,
3114 verbose=2,
3115 parallel=True,
3116 upstream='upstream',
3117 description='fetch description',
3118 all_files=True)
3119
3120
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003121class CMDTryResultsTestCase(CMDTestCaseBase):
3122 _DEFAULT_REQUEST = {
3123 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003124 "gerritChanges": [{
3125 "project": "depot_tools",
3126 "host": "chromium-review.googlesource.com",
3127 "patchset": 7,
3128 "change": 123456,
3129 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003130 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003131 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3132 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003133 }
3134
3135 def testNoJobs(self):
3136 git_cl._call_buildbucket.return_value = {}
3137
3138 self.assertEqual(0, git_cl.main(['try-results']))
3139 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3140 git_cl._call_buildbucket.assert_called_once_with(
3141 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3142 self._DEFAULT_REQUEST)
3143
3144 def testPrintToStdout(self):
3145 self.assertEqual(0, git_cl.main(['try-results']))
3146 self.assertEqual([
3147 'Successes:',
3148 ' bot_success https://ci.chromium.org/b/103',
3149 'Infra Failures:',
3150 ' bot_infra_failure https://ci.chromium.org/b/105',
3151 'Failures:',
3152 ' bot_failure https://ci.chromium.org/b/104',
3153 'Canceled:',
3154 ' bot_canceled ',
3155 'Started:',
3156 ' bot_started https://ci.chromium.org/b/102',
3157 'Scheduled:',
3158 ' bot_scheduled id=101',
3159 'Other:',
3160 ' bot_status_unspecified id=100',
3161 'Total: 7 tryjobs',
3162 ], sys.stdout.getvalue().splitlines())
3163 git_cl._call_buildbucket.assert_called_once_with(
3164 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3165 self._DEFAULT_REQUEST)
3166
3167 def testPrintToStdoutWithMasters(self):
3168 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3169 self.assertEqual([
3170 'Successes:',
3171 ' try bot_success https://ci.chromium.org/b/103',
3172 'Infra Failures:',
3173 ' try bot_infra_failure https://ci.chromium.org/b/105',
3174 'Failures:',
3175 ' try bot_failure https://ci.chromium.org/b/104',
3176 'Canceled:',
3177 ' try bot_canceled ',
3178 'Started:',
3179 ' try bot_started https://ci.chromium.org/b/102',
3180 'Scheduled:',
3181 ' try bot_scheduled id=101',
3182 'Other:',
3183 ' try bot_status_unspecified id=100',
3184 'Total: 7 tryjobs',
3185 ], sys.stdout.getvalue().splitlines())
3186 git_cl._call_buildbucket.assert_called_once_with(
3187 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3188 self._DEFAULT_REQUEST)
3189
3190 @mock.patch('git_cl.write_json')
3191 def testWriteToJson(self, mockJsonDump):
3192 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3193 git_cl._call_buildbucket.assert_called_once_with(
3194 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3195 self._DEFAULT_REQUEST)
3196 mockJsonDump.assert_called_once_with(
3197 'file.json', self._DEFAULT_RESPONSE['builds'])
3198
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003199 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003200 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3201 self.assertEqual(
3202 [
3203 ('chromium', 'try', 'bot_failure'),
3204 ('chromium', 'try', 'bot_infra_failure'),
3205 ],
3206 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003207
3208 def test_filter_failed_for_retry_many_builds(self):
3209
3210 def _build(name, created_sec, status, experimental=False):
3211 assert 0 <= created_sec < 100, created_sec
3212 b = {
3213 'id': 112112,
3214 'builder': {
3215 'project': 'chromium',
3216 'bucket': 'try',
3217 'builder': name,
3218 },
3219 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3220 'status': status,
3221 'tags': [],
3222 }
3223 if experimental:
3224 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3225 return b
3226
3227 builds = [
3228 _build('flaky-last-green', 1, 'FAILURE'),
3229 _build('flaky-last-green', 2, 'SUCCESS'),
3230 _build('flaky', 1, 'SUCCESS'),
3231 _build('flaky', 2, 'FAILURE'),
3232 _build('running', 1, 'FAILED'),
3233 _build('running', 2, 'SCHEDULED'),
3234 _build('yep-still-running', 1, 'STARTED'),
3235 _build('yep-still-running', 2, 'FAILURE'),
3236 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3237 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3238
3239 # Simulate experimental in CQ builder, which developer decided
3240 # to retry manually which resulted in 2nd build non-experimental.
3241 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3242 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3243 ]
3244 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003245 self.assertEqual(
3246 [
3247 ('chromium', 'try', 'flaky'),
3248 ('chromium', 'try', 'sometimes-experimental'),
3249 ],
3250 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003251
3252
3253class CMDTryTestCase(CMDTestCaseBase):
3254
3255 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003256 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003257 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003258 self.assertEqual(0, git_cl.main(['try']))
3259 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3260 self.assertEqual(
3261 sys.stdout.getvalue(),
3262 'Scheduling CQ dry run on: '
3263 'https://chromium-review.googlesource.com/123456\n')
3264
Edward Lemur4c707a22019-09-24 21:13:43 +00003265 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003266 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003267 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003268
3269 self.assertEqual(0, git_cl.main([
3270 'try', '-B', 'luci.chromium.try', '-b', 'win',
3271 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3272 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003273 'Scheduling jobs on:\n'
3274 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003275 git_cl.sys.stdout.getvalue())
3276
3277 expected_request = {
3278 "requests": [{
3279 "scheduleBuild": {
3280 "requestId": "uuid4",
3281 "builder": {
3282 "project": "chromium",
3283 "builder": "win",
3284 "bucket": "try",
3285 },
3286 "gerritChanges": [{
3287 "project": "depot_tools",
3288 "host": "chromium-review.googlesource.com",
3289 "patchset": 7,
3290 "change": 123456,
3291 }],
3292 "properties": {
3293 "category": "git_cl_try",
3294 "json": [{"a": 1}, None],
3295 "key": "val",
3296 },
3297 "tags": [
3298 {"value": "win", "key": "builder"},
3299 {"value": "git_cl_try", "key": "user_agent"},
3300 ],
3301 },
3302 }],
3303 }
3304 mockCallBuildbucket.assert_called_with(
3305 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3306
Anthony Polito1a5fe232020-01-24 23:17:52 +00003307 @mock.patch('git_cl._call_buildbucket')
3308 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3309 mockCallBuildbucket.return_value = {}
3310
3311 self.assertEqual(0, git_cl.main([
3312 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3313 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3314 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3315 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003316 'Scheduling jobs on:\n'
3317 ' chromium/try: linux\n'
3318 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003319 git_cl.sys.stdout.getvalue())
3320
3321 expected_request = {
3322 "requests": [{
3323 "scheduleBuild": {
3324 "requestId": "uuid4",
3325 "builder": {
3326 "project": "chromium",
3327 "builder": "linux",
3328 "bucket": "try",
3329 },
3330 "gerritChanges": [{
3331 "project": "depot_tools",
3332 "host": "chromium-review.googlesource.com",
3333 "patchset": 7,
3334 "change": 123456,
3335 }],
3336 "properties": {
3337 "category": "git_cl_try",
3338 "json": [{"a": 1}, None],
3339 "key": "val",
3340 },
3341 "tags": [
3342 {"value": "linux", "key": "builder"},
3343 {"value": "git_cl_try", "key": "user_agent"},
3344 ],
3345 "gitilesCommit": {
3346 "host": "chromium-review.googlesource.com",
3347 "project": "depot_tools",
3348 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3349 }
3350 },
3351 },
3352 {
3353 "scheduleBuild": {
3354 "requestId": "uuid4",
3355 "builder": {
3356 "project": "chromium",
3357 "builder": "win",
3358 "bucket": "try",
3359 },
3360 "gerritChanges": [{
3361 "project": "depot_tools",
3362 "host": "chromium-review.googlesource.com",
3363 "patchset": 7,
3364 "change": 123456,
3365 }],
3366 "properties": {
3367 "category": "git_cl_try",
3368 "json": [{"a": 1}, None],
3369 "key": "val",
3370 },
3371 "tags": [
3372 {"value": "win", "key": "builder"},
3373 {"value": "git_cl_try", "key": "user_agent"},
3374 ],
3375 "gitilesCommit": {
3376 "host": "chromium-review.googlesource.com",
3377 "project": "depot_tools",
3378 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3379 }
3380 },
3381 }],
3382 }
3383 mockCallBuildbucket.assert_called_with(
3384 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3385
Edward Lemur45768512020-03-02 19:03:14 +00003386 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003387 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003388 with self.assertRaises(SystemExit):
3389 git_cl.main([
3390 'try', '-B', 'not-a-bucket', '-b', 'win',
3391 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003392 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003393 'Invalid bucket: not-a-bucket.',
3394 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003395
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003396 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003397 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003398 def testScheduleOnBuildbucketRetryFailed(
3399 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003400 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003401 7: [],
3402 6: [{
3403 'id': 112112,
3404 'builder': {
3405 'project': 'chromium',
3406 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003407 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003408 'createTime': '2019-10-09T08:00:01.854286Z',
3409 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003410 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003411 mockCallBuildbucket.return_value = {}
3412
3413 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3414 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003415 'Scheduling jobs on:\n'
3416 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003417 git_cl.sys.stdout.getvalue())
3418
3419 expected_request = {
3420 "requests": [{
3421 "scheduleBuild": {
3422 "requestId": "uuid4",
3423 "builder": {
3424 "project": "chromium",
3425 "bucket": "try",
3426 "builder": "linux",
3427 },
3428 "gerritChanges": [{
3429 "project": "depot_tools",
3430 "host": "chromium-review.googlesource.com",
3431 "patchset": 7,
3432 "change": 123456,
3433 }],
3434 "properties": {
3435 "category": "git_cl_try",
3436 },
3437 "tags": [
3438 {"value": "linux", "key": "builder"},
3439 {"value": "git_cl_try", "key": "user_agent"},
3440 {"value": "1", "key": "retry_failed"},
3441 ],
3442 },
3443 }],
3444 }
3445 mockCallBuildbucket.assert_called_with(
3446 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3447
Edward Lemur4c707a22019-09-24 21:13:43 +00003448 def test_parse_bucket(self):
3449 test_cases = [
3450 {
3451 'bucket': 'chromium/try',
3452 'result': ('chromium', 'try'),
3453 },
3454 {
3455 'bucket': 'luci.chromium.try',
3456 'result': ('chromium', 'try'),
3457 'has_warning': True,
3458 },
3459 {
3460 'bucket': 'skia.primary',
3461 'result': ('skia', 'skia.primary'),
3462 'has_warning': True,
3463 },
3464 {
3465 'bucket': 'not-a-bucket',
3466 'result': (None, None),
3467 },
3468 ]
3469
3470 for test_case in test_cases:
3471 git_cl.sys.stdout.truncate(0)
3472 self.assertEqual(
3473 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3474 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003475 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3476 test_case['result'])
3477 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003478
3479
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003480class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003481
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003482 def setUp(self):
3483 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003484 mock.patch('git_cl._fetch_tryjobs').start()
3485 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003486 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003487 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3488 mock.patch(
3489 'git_cl.Settings.GetSquashGerritUploads',
3490 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003491 self.addCleanup(mock.patch.stopall)
3492
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003493 def testWarmUpChangeDetailCache(self):
3494 self.assertEqual(0, git_cl.main(['upload']))
3495 gerrit_util.GetChangeDetail.assert_called_once_with(
3496 'chromium-review.googlesource.com', 'depot_tools~123456',
3497 frozenset([
3498 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3499 'CURRENT_COMMIT']))
3500
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003501 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003502 # This test mocks out the actual upload part, and just asserts that after
3503 # upload, if --retry-failed is added, then the tool will fetch try jobs
3504 # from the previous patchset and trigger the right builders on the latest
3505 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003506 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003507 # Latest patchset: No builds.
3508 [],
3509 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003510 [{
3511 'id': str(100 + idx),
3512 'builder': {
3513 'project': 'chromium',
3514 'bucket': 'try',
3515 'builder': 'bot_' + status.lower(),
3516 },
3517 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3518 'tags': [],
3519 'status': status,
3520 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003521 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003522
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003523 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003524 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003525 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3526 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003527 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003528 expected_buckets = [
3529 ('chromium', 'try', 'bot_failure'),
3530 ('chromium', 'try', 'bot_infra_failure'),
3531 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003532 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3533 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003534
Brian Sheedy59b06a82019-10-14 17:03:29 +00003535
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003536class MakeRequestsHelperTestCase(unittest.TestCase):
3537
3538 def exampleGerritChange(self):
3539 return {
3540 'host': 'chromium-review.googlesource.com',
3541 'project': 'depot_tools',
3542 'change': 1,
3543 'patchset': 2,
3544 }
3545
3546 def testMakeRequestsHelperNoOptions(self):
3547 # Basic test for the helper function _make_tryjob_schedule_requests;
3548 # it shouldn't throw AttributeError even when options doesn't have any
3549 # of the expected values; it will use default option values.
3550 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3551 jobs = [('chromium', 'try', 'my-builder')]
3552 options = optparse.Values()
3553 requests = git_cl._make_tryjob_schedule_requests(
3554 changelist, jobs, options, patchset=None)
3555
3556 # requestId is non-deterministic. Just assert that it's there and has
3557 # a particular length.
3558 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3559 self.assertEqual(requests, [{
3560 'scheduleBuild': {
3561 'builder': {
3562 'bucket': 'try',
3563 'builder': 'my-builder',
3564 'project': 'chromium'
3565 },
3566 'gerritChanges': [self.exampleGerritChange()],
3567 'properties': {
3568 'category': 'git_cl_try'
3569 },
3570 'tags': [{
3571 'key': 'builder',
3572 'value': 'my-builder'
3573 }, {
3574 'key': 'user_agent',
3575 'value': 'git_cl_try'
3576 }]
3577 }
3578 }])
3579
3580 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3581 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3582 jobs = [('chromium', 'try', 'presubmit')]
3583 options = optparse.Values()
3584 requests = git_cl._make_tryjob_schedule_requests(
3585 changelist, jobs, options, patchset=None)
3586 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3587 'category': 'git_cl_try',
3588 'dry_run': 'true'
3589 })
3590
3591 def testMakeRequestsHelperRevisionSet(self):
3592 # Gitiles commit is specified when revision is in options.
3593 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3594 jobs = [('chromium', 'try', 'my-builder')]
3595 options = optparse.Values({'revision': 'ba5eba11'})
3596 requests = git_cl._make_tryjob_schedule_requests(
3597 changelist, jobs, options, patchset=None)
3598 self.assertEqual(
3599 requests[0]['scheduleBuild']['gitilesCommit'], {
3600 'host': 'chromium-review.googlesource.com',
3601 'id': 'ba5eba11',
3602 'project': 'depot_tools'
3603 })
3604
3605 def testMakeRequestsHelperRetryFailedSet(self):
3606 # An extra tag is added when retry_failed is in options.
3607 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3608 jobs = [('chromium', 'try', 'my-builder')]
3609 options = optparse.Values({'retry_failed': 'true'})
3610 requests = git_cl._make_tryjob_schedule_requests(
3611 changelist, jobs, options, patchset=None)
3612 self.assertEqual(
3613 requests[0]['scheduleBuild']['tags'], [
3614 {
3615 'key': 'builder',
3616 'value': 'my-builder'
3617 },
3618 {
3619 'key': 'user_agent',
3620 'value': 'git_cl_try'
3621 },
3622 {
3623 'key': 'retry_failed',
3624 'value': '1'
3625 }
3626 ])
3627
3628 def testMakeRequestsHelperCategorySet(self):
3629 # The category property can be overriden with options.
3630 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3631 jobs = [('chromium', 'try', 'my-builder')]
3632 options = optparse.Values({'category': 'my-special-category'})
3633 requests = git_cl._make_tryjob_schedule_requests(
3634 changelist, jobs, options, patchset=None)
3635 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3636 {'category': 'my-special-category'})
3637
3638
Edward Lemurda4b6c62020-02-13 00:28:40 +00003639class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003640
3641 def setUp(self):
3642 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003643 mock.patch('git_cl.RunCommand').start()
3644 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3645 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3646 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003647 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003648 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003649
3650 def tearDown(self):
3651 shutil.rmtree(self._top_dir)
3652 super(CMDFormatTestCase, self).tearDown()
3653
Jamie Madill5e96ad12020-01-13 16:08:35 +00003654 def _make_temp_file(self, fname, contents):
3655 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3656 tf.write('\n'.join(contents))
3657
Brian Sheedy59b06a82019-10-14 17:03:29 +00003658 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003659 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003660
Brian Sheedyb4307d52019-12-02 19:18:17 +00003661 def _check_yapf_filtering(self, files, expected):
3662 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3663 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003664
Edward Lemur1a83da12020-03-04 21:18:36 +00003665 def _run_command_mock(self, return_value):
3666 def f(*args, **kwargs):
3667 if 'stdin' in kwargs:
3668 self.assertIsInstance(kwargs['stdin'], bytes)
3669 return return_value
3670 return f
3671
Jamie Madill5e96ad12020-01-13 16:08:35 +00003672 def testClangFormatDiffFull(self):
3673 self._make_temp_file('test.cc', ['// test'])
3674 git_cl.settings.GetFormatFullByDefault.return_value = False
3675 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3676 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3677
3678 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003679 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003680 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3681 self._top_dir, 'HEAD')
3682 self.assertEqual(2, return_value)
3683
3684 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003685 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003686 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3687 self._top_dir, 'HEAD')
3688 self.assertEqual(0, return_value)
3689
3690 def testClangFormatDiff(self):
3691 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00003692 # A valid file is required, so use this test.
3693 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00003694 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3695
3696 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003697 git_cl.RunCommand.side_effect = self._run_command_mock('error')
3698 return_value = git_cl._RunClangFormatDiff(
3699 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003700 self.assertEqual(2, return_value)
3701
3702 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003703 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003704 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3705 'HEAD')
3706 self.assertEqual(0, return_value)
3707
Brian Sheedyb4307d52019-12-02 19:18:17 +00003708 def testYapfignoreExplicit(self):
3709 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3710 files = [
3711 'bar.py',
3712 'foo/bar.py',
3713 'foo/baz.py',
3714 'foo/bar/baz.py',
3715 'foo/bar/foobar.py',
3716 ]
3717 expected = [
3718 'bar.py',
3719 'foo/baz.py',
3720 'foo/bar/foobar.py',
3721 ]
3722 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003723
Brian Sheedyb4307d52019-12-02 19:18:17 +00003724 def testYapfignoreSingleWildcards(self):
3725 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3726 files = [
3727 'bar.py', # Matched by *bar.py.
3728 'bar.txt',
3729 'foobar.py', # Matched by *bar.py, foo*.
3730 'foobar.txt', # Matched by foo*.
3731 'bazbar.py', # Matched by *bar.py, baz*.py.
3732 'bazbar.txt',
3733 'foo/baz.txt', # Matched by foo*.
3734 'bar/bar.py', # Matched by *bar.py.
3735 'baz/foo.py', # Matched by baz*.py, foo*.
3736 'baz/foo.txt',
3737 ]
3738 expected = [
3739 'bar.txt',
3740 'bazbar.txt',
3741 'baz/foo.txt',
3742 ]
3743 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003744
Brian Sheedyb4307d52019-12-02 19:18:17 +00003745 def testYapfignoreMultiplewildcards(self):
3746 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3747 files = [
3748 'bar.py', # Matched by *bar*.
3749 'bar.txt', # Matched by *bar*.
3750 'abar.py', # Matched by *bar*.
3751 'foobaz.txt', # Matched by *foo*baz.txt.
3752 'foobaz.py',
3753 'afoobaz.txt', # Matched by *foo*baz.txt.
3754 ]
3755 expected = [
3756 'foobaz.py',
3757 ]
3758 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003759
3760 def testYapfignoreComments(self):
3761 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003762 files = [
3763 'test.py',
3764 'test2.py',
3765 ]
3766 expected = [
3767 'test2.py',
3768 ]
3769 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003770
3771 def testYapfignoreBlankLines(self):
3772 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003773 files = [
3774 'test.py',
3775 'test2.py',
3776 'test3.py',
3777 ]
3778 expected = [
3779 'test3.py',
3780 ]
3781 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003782
3783 def testYapfignoreWhitespace(self):
3784 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003785 files = [
3786 'test.py',
3787 'test2.py',
3788 ]
3789 expected = [
3790 'test2.py',
3791 ]
3792 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003793
Brian Sheedyb4307d52019-12-02 19:18:17 +00003794 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003795 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003796 self._check_yapf_filtering([], [])
3797
3798 def testYapfignoreMissingYapfignore(self):
3799 files = [
3800 'test.py',
3801 ]
3802 expected = [
3803 'test.py',
3804 ]
3805 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003806
3807
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003808if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003809 logging.basicConfig(
3810 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003811 unittest.main()