blob: 04d012f82f2b4d5b2a6d00b130cf1901816fd695 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur0db01f02019-11-12 22:01:51 +00009from __future__ import unicode_literals
10
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010011import datetime
tandriide281ae2016-10-12 06:02:30 -070012import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010013import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import os
Brian Sheedy59b06a82019-10-14 17:03:29 +000015import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070017import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018import unittest
19
Edward Lemura8145022020-01-06 18:47:54 +000020if sys.version_info.major == 2:
21 from StringIO import StringIO
22 import mock
23else:
24 from io import StringIO
25 from unittest import mock
26
maruel@chromium.orgddd59412011-11-30 14:20:38 +000027sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
28
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000029import metrics
30# We have to disable monitoring before importing git_cl.
31metrics.DISABLE_METRICS_COLLECTION = True
32
Jamie Madill5e96ad12020-01-13 16:08:35 +000033import clang_format
Eric Boren2fb63102018-10-05 13:05:03 +000034import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000035import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000036import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000037import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000038import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000039
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000040
Edward Lemur0db01f02019-11-12 22:01:51 +000041def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070042 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
43
44
Edward Lemur4c707a22019-09-24 21:13:43 +000045def _constantFn(return_value):
46 def f(*args, **kwargs):
47 return return_value
48 return f
49
50
tandrii5d48c322016-08-18 16:19:37 -070051CERR1 = callError(1)
52
53
Edward Lemur0db01f02019-11-12 22:01:51 +000054def MakeNamedTemporaryFileMock(test, expected_content):
Aaron Gable9a03ae02017-11-03 11:31:07 -070055 class NamedTemporaryFileMock(object):
56 def __init__(self, *args, **kwargs):
57 self.name = '/tmp/named'
Edward Lemur0db01f02019-11-12 22:01:51 +000058 self.expected_content = expected_content.encode('utf-8', 'replace')
Aaron Gable9a03ae02017-11-03 11:31:07 -070059
60 def __enter__(self):
61 return self
62
63 def __exit__(self, _type, _value, _tb):
64 pass
65
66 def write(self, content):
67 if self.expected_content:
Edward Lemur0db01f02019-11-12 22:01:51 +000068 test.assertEqual(self.expected_content, content)
Aaron Gable9a03ae02017-11-03 11:31:07 -070069
70 def close(self):
71 pass
72
73 return NamedTemporaryFileMock
74
75
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000076class ChangelistMock(object):
77 # A class variable so we can access it when we don't have access to the
78 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000079 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000080 def __init__(self, **kwargs):
81 pass
82 def GetIssue(self):
83 return 1
Edward Lemur6c6827c2020-02-06 21:15:18 +000084 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000085 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070086 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000087 ChangelistMock.desc = desc
88
tandrii5d48c322016-08-18 16:19:37 -070089
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000090class PresubmitMock(object):
91 def __init__(self, *args, **kwargs):
92 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080093 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
94
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000095 @staticmethod
96 def should_continue():
97 return True
98
99
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000100class WatchlistsMock(object):
101 def __init__(self, _):
102 pass
103 @staticmethod
104 def GetWatchersForPaths(_):
105 return ['joe@example.com']
106
107
Edward Lemur4c707a22019-09-24 21:13:43 +0000108class CodereviewSettingsFileMock(object):
109 def __init__(self):
110 pass
111 # pylint: disable=no-self-use
112 def read(self):
113 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
114 'GERRIT_HOST: True\n')
115
116
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000117class AuthenticatorMock(object):
118 def __init__(self, *_args):
119 pass
120 def has_cached_credentials(self):
121 return True
tandrii221ab252016-10-06 08:12:04 -0700122 def authorize(self, http):
123 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000124
125
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100126def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000127 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
128
129 Usage:
130 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100131 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000132
133 OR
134 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100135 CookiesAuthenticatorMockFactory(
136 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000137 """
138 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800139 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000140 # Intentionally not calling super() because it reads actual cookie files.
141 pass
142 @classmethod
143 def get_gitcookies_path(cls):
144 return '~/.gitcookies'
145 @classmethod
146 def get_netrc_path(cls):
147 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100148 def _get_auth_for_host(self, host):
149 if same_auth:
150 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000151 return (hosts_with_creds or {}).get(host)
152 return CookiesAuthenticatorMock
153
Aaron Gable9a03ae02017-11-03 11:31:07 -0700154
kmarshall9249e012016-08-23 12:02:16 -0700155class MockChangelistWithBranchAndIssue():
156 def __init__(self, branch, issue):
157 self.branch = branch
158 self.issue = issue
159 def GetBranch(self):
160 return self.branch
161 def GetIssue(self):
162 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000163
tandriic2405f52016-10-10 08:13:15 -0700164
165class SystemExitMock(Exception):
166 pass
167
168
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000169class TestGitClBasic(unittest.TestCase):
Edward Lemur6c6827c2020-02-06 21:15:18 +0000170 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000171 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100172 cl.description = 'x'
173 cl.has_description = True
Edward Lemur6c6827c2020-02-06 21:15:18 +0000174 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700175
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000176 def test_set_preserve_tryjobs(self):
177 d = git_cl.ChangeDescription('Simple.')
178 d.set_preserve_tryjobs()
179 self.assertEqual(d.description.splitlines(), [
180 'Simple.',
181 '',
182 'Cq-Do-Not-Cancel-Tryjobs: true',
183 ])
184 before = d.description
185 d.set_preserve_tryjobs()
186 self.assertEqual(before, d.description)
187
188 d = git_cl.ChangeDescription('\n'.join([
189 'One is enough',
190 '',
191 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
192 'Change-Id: Ideadbeef',
193 ]))
194 d.set_preserve_tryjobs()
195 self.assertEqual(d.description.splitlines(), [
196 'One is enough',
197 '',
198 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
199 'Change-Id: Ideadbeef',
200 'Cq-Do-Not-Cancel-Tryjobs: true',
201 ])
202
tandriif9aefb72016-07-01 09:06:51 -0700203 def test_get_bug_line_values(self):
204 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
205 self.assertEqual(f('', ''), [])
206 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
207 self.assertEqual(f('v8', '456'), ['v8:456'])
208 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
209 # Not nice, but not worth carying.
210 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
211 ['v8:456', 'chromium:123', 'v8:123'])
212
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100213 def _test_git_number(self, parent_msg, dest_ref, child_msg,
214 parent_hash='parenthash'):
215 desc = git_cl.ChangeDescription(child_msg)
216 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
217 return desc.description
218
219 def assertEqualByLine(self, actual, expected):
220 self.assertEqual(actual.splitlines(), expected.splitlines())
221
222 def test_git_number_bad_parent(self):
223 with self.assertRaises(ValueError):
224 self._test_git_number('Parent', 'refs/heads/master', 'Child')
225
226 def test_git_number_bad_parent_footer(self):
227 with self.assertRaises(AssertionError):
228 self._test_git_number(
229 'Parent\n'
230 '\n'
231 'Cr-Commit-Position: wrong',
232 'refs/heads/master', 'Child')
233
234 def test_git_number_bad_lineage_ignored(self):
235 actual = self._test_git_number(
236 'Parent\n'
237 '\n'
238 'Cr-Commit-Position: refs/heads/master@{#1}\n'
239 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
240 'refs/heads/master', 'Child')
241 self.assertEqualByLine(
242 actual,
243 'Child\n'
244 '\n'
245 'Cr-Commit-Position: refs/heads/master@{#2}\n'
246 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
247
248 def test_git_number_same_branch(self):
249 actual = self._test_git_number(
250 'Parent\n'
251 '\n'
252 'Cr-Commit-Position: refs/heads/master@{#12}',
253 dest_ref='refs/heads/master',
254 child_msg='Child')
255 self.assertEqualByLine(
256 actual,
257 'Child\n'
258 '\n'
259 'Cr-Commit-Position: refs/heads/master@{#13}')
260
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200261 def test_git_number_same_branch_mixed_footers(self):
262 actual = self._test_git_number(
263 'Parent\n'
264 '\n'
265 'Cr-Commit-Position: refs/heads/master@{#12}',
266 dest_ref='refs/heads/master',
267 child_msg='Child\n'
268 '\n'
269 'Broken-by: design\n'
270 'BUG=123')
271 self.assertEqualByLine(
272 actual,
273 'Child\n'
274 '\n'
275 'Broken-by: design\n'
276 'BUG=123\n'
277 'Cr-Commit-Position: refs/heads/master@{#13}')
278
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100279 def test_git_number_same_branch_with_originals(self):
280 actual = self._test_git_number(
281 'Parent\n'
282 '\n'
283 'Cr-Commit-Position: refs/heads/master@{#12}',
284 dest_ref='refs/heads/master',
285 child_msg='Child\n'
286 '\n'
287 'Some users are smart and insert their own footers\n'
288 '\n'
289 'Cr-Whatever: value\n'
290 'Cr-Commit-Position: refs/copy/paste@{#22}')
291 self.assertEqualByLine(
292 actual,
293 'Child\n'
294 '\n'
295 'Some users are smart and insert their own footers\n'
296 '\n'
297 'Cr-Original-Whatever: value\n'
298 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
299 'Cr-Commit-Position: refs/heads/master@{#13}')
300
301 def test_git_number_new_branch(self):
302 actual = self._test_git_number(
303 'Parent\n'
304 '\n'
305 'Cr-Commit-Position: refs/heads/master@{#12}',
306 dest_ref='refs/heads/branch',
307 child_msg='Child')
308 self.assertEqualByLine(
309 actual,
310 'Child\n'
311 '\n'
312 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
313 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
314
315 def test_git_number_lineage(self):
316 actual = self._test_git_number(
317 'Parent\n'
318 '\n'
319 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
320 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
321 dest_ref='refs/heads/branch',
322 child_msg='Child')
323 self.assertEqualByLine(
324 actual,
325 'Child\n'
326 '\n'
327 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
328 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
329
330 def test_git_number_moooooooore_lineage(self):
331 actual = self._test_git_number(
332 'Parent\n'
333 '\n'
334 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
335 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
336 dest_ref='refs/heads/mooore',
337 child_msg='Child')
338 self.assertEqualByLine(
339 actual,
340 'Child\n'
341 '\n'
342 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
343 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
344 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
345
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100346 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700347 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100348 actual = self._test_git_number(
349 'CQ commit on fresh new branch + numbering.\n'
350 '\n'
351 'NOTRY=True\n'
352 'NOPRESUBMIT=True\n'
353 'BUG=\n'
354 '\n'
355 'Review-Url: https://codereview.chromium.org/2577703003\n'
356 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
357 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
358 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
359 dest_ref='refs/heads/gnumb-test/cl',
360 child_msg='git cl on fresh new branch + numbering.\n'
361 '\n'
362 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
363 self.assertEqualByLine(
364 actual,
365 'git cl on fresh new branch + numbering.\n'
366 '\n'
367 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
368 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
369 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
370 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
371 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100372
373 def test_git_number_cherry_pick(self):
374 actual = self._test_git_number(
375 'Parent\n'
376 '\n'
377 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
378 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
379 dest_ref='refs/heads/branch',
380 child_msg='Child, which is cherry-pick from master\n'
381 '\n'
382 'Cr-Commit-Position: refs/heads/master@{#100}\n'
383 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
384 self.assertEqualByLine(
385 actual,
386 'Child, which is cherry-pick from master\n'
387 '\n'
388 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
389 '\n'
390 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
391 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
392 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
393
Edward Lemurda4b6c62020-02-13 00:28:40 +0000394 @mock.patch('gerrit_util.GetAccountDetails')
395 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000396 mock_per_account = {
397 'u1': None, # 404, doesn't exist.
398 'u2': {
399 '_account_id': 123124,
400 'avatars': [],
401 'email': 'u2@example.com',
402 'name': 'User Number 2',
403 'status': 'OOO',
404 },
405 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
406 }
407 def GetAccountDetailsMock(_, account):
408 # Poor-man's mock library's side_effect.
409 v = mock_per_account.pop(account)
410 if isinstance(v, Exception):
411 raise v
412 return v
413
Edward Lemurda4b6c62020-02-13 00:28:40 +0000414 mockGetAccountDetails.side_effect = GetAccountDetailsMock
415 actual = git_cl.gerrit_util.ValidAccounts(
416 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000417 self.assertEqual(actual, {
418 'u2': {
419 '_account_id': 123124,
420 'avatars': [],
421 'email': 'u2@example.com',
422 'name': 'User Number 2',
423 'status': 'OOO',
424 },
425 })
426
427
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200428class TestParseIssueURL(unittest.TestCase):
429 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000430 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200431 self.assertIsNotNone(parsed)
432 if fail:
433 self.assertFalse(parsed.valid)
434 return
435 self.assertTrue(parsed.valid)
436 self.assertEqual(parsed.issue, issue)
437 self.assertEqual(parsed.patchset, patchset)
438 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200439
Edward Lemur678a6842019-10-03 22:25:05 +0000440 def test_ParseIssueNumberArgument(self):
441 def test(arg, *args, **kwargs):
442 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200443
Edward Lemur678a6842019-10-03 22:25:05 +0000444 test('123', 123)
445 test('', fail=True)
446 test('abc', fail=True)
447 test('123/1', fail=True)
448 test('123a', fail=True)
449 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200450
Edward Lemur678a6842019-10-03 22:25:05 +0000451 test('https://codereview.source.com/123',
452 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200453 test('http://chrome-review.source.com/c/123',
454 123, None, 'chrome-review.source.com')
455 test('https://chrome-review.source.com/c/123/',
456 123, None, 'chrome-review.source.com')
457 test('https://chrome-review.source.com/c/123/4',
458 123, 4, 'chrome-review.source.com')
459 test('https://chrome-review.source.com/#/c/123/4',
460 123, 4, 'chrome-review.source.com')
461 test('https://chrome-review.source.com/c/123/4',
462 123, 4, 'chrome-review.source.com')
463 test('https://chrome-review.source.com/123',
464 123, None, 'chrome-review.source.com')
465 test('https://chrome-review.source.com/123/4',
466 123, 4, 'chrome-review.source.com')
467
Edward Lemur678a6842019-10-03 22:25:05 +0000468 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200469 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
470 test('https://chrome-review.source.com/c/abc/', fail=True)
471 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
472
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200473
474
Edward Lemurda4b6c62020-02-13 00:28:40 +0000475class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100476 def setUp(self):
477 super(GitCookiesCheckerTest, self).setUp()
478 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100479 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000480 mock.patch('sys.stdout', StringIO()).start()
481 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100482
483 def mock_hosts_creds(self, subhost_identity_pairs):
484 def ensure_googlesource(h):
485 if not h.endswith(self.c._GOOGLESOURCE):
486 assert not h.endswith('.')
487 return h + '.' + self.c._GOOGLESOURCE
488 return h
489 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
490 for h, i in subhost_identity_pairs]
491
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200492 def test_identity_parsing(self):
493 self.assertEqual(self.c._parse_identity('ldap.google.com'),
494 ('ldap', 'google.com'))
495 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
496 ('ldap', 'example.com'))
497 # Specical case because we know there are no subdomains in chromium.org.
498 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
499 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800500 # Pathological: ".period." can be either username OR domain, more likely
501 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200502 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
503 ('note', 'period.example.com'))
504
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100505 def test_analysis_nothing(self):
506 self.c._all_hosts = []
507 self.assertFalse(self.c.has_generic_host())
508 self.assertEqual(set(), self.c.get_conflicting_hosts())
509 self.assertEqual(set(), self.c.get_duplicated_hosts())
510 self.assertEqual(set(), self.c.get_partially_configured_hosts())
511 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
512
513 def test_analysis(self):
514 self.mock_hosts_creds([
515 ('.googlesource.com', 'git-example.chromium.org'),
516
517 ('chromium', 'git-example.google.com'),
518 ('chromium-review', 'git-example.google.com'),
519 ('chrome-internal', 'git-example.chromium.org'),
520 ('chrome-internal-review', 'git-example.chromium.org'),
521 ('conflict', 'git-example.google.com'),
522 ('conflict-review', 'git-example.chromium.org'),
523 ('dup', 'git-example.google.com'),
524 ('dup', 'git-example.google.com'),
525 ('dup-review', 'git-example.google.com'),
526 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200527 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100528 ])
529 self.assertTrue(self.c.has_generic_host())
530 self.assertEqual(set(['conflict.googlesource.com']),
531 self.c.get_conflicting_hosts())
532 self.assertEqual(set(['dup.googlesource.com']),
533 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200534 self.assertEqual(set(['partial.googlesource.com',
535 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100536 self.c.get_partially_configured_hosts())
537 self.assertEqual(set(['chromium.googlesource.com',
538 'chrome-internal.googlesource.com']),
539 self.c.get_hosts_with_wrong_identities())
540
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100541 def test_report_no_problems(self):
542 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100543 self.assertFalse(self.c.find_and_report_problems())
544 self.assertEqual(sys.stdout.getvalue(), '')
545
Edward Lemurda4b6c62020-02-13 00:28:40 +0000546 @mock.patch(
547 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
548 return_value='~/.gitcookies')
549 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100550 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100551 self.assertTrue(self.c.find_and_report_problems())
552 with open(os.path.join(os.path.dirname(__file__),
553 'git_cl_creds_check_report.txt')) as f:
554 expected = f.read()
555 def by_line(text):
556 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700557 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200558 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100559
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800560
Edward Lemurda4b6c62020-02-13 00:28:40 +0000561class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000562 def setUp(self):
563 super(TestGitCl, self).setUp()
564 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700565 self._calls_done = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000566 mock.patch('sys.stdout', StringIO()).start()
567 mock.patch(
568 'git_cl.time_time',
569 lambda: self._mocked_call('time.time')).start()
570 mock.patch(
571 'git_cl.metrics.collector.add_repeated',
572 lambda *a: self._mocked_call('add_repeated', *a)).start()
573 mock.patch('subprocess2.call', self._mocked_call).start()
574 mock.patch('subprocess2.check_call', self._mocked_call).start()
575 mock.patch('subprocess2.check_output', self._mocked_call).start()
576 mock.patch(
577 'subprocess2.communicate',
578 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
579 mock.patch(
580 'git_cl.gclient_utils.CheckCallAndFilter',
581 self._mocked_call).start()
582 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
583 mock.patch(
584 'git_common.get_or_create_merge_base',
585 lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start()
586 mock.patch('git_cl.BranchExists', return_value=True).start()
587 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
588 mock.patch(
589 'git_cl.SaveDescriptionBackup',
590 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
591 mock.patch(
592 'git_cl.ask_for_data',
593 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
594 mock.patch(
595 'git_cl.write_json',
596 lambda *a: self._mocked_call('write_json', *a)).start()
597 mock.patch(
598 'git_cl.presubmit_support.DoPresubmitChecks', PresubmitMock).start()
599 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
600 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
601 mock.patch(
602 'git_cl.gerrit_util.GetChangeDetail',
603 lambda *a: self._mocked_call('GetChangeDetail', *a)).start()
604 mock.patch(
605 'git_cl.gerrit_util.GetChangeComments',
606 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
607 mock.patch(
608 'git_cl.gerrit_util.GetChangeRobotComments',
609 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
610 mock.patch(
611 'git_cl.gerrit_util.AddReviewers',
612 lambda *a: self._mocked_call('AddReviewers', *a)).start()
613 mock.patch(
614 'git_cl.gerrit_util.SetReview',
615 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
616 self._mocked_call(
617 'SetReview', h, i, msg, labels, notify, ready))).start()
618 mock.patch(
619 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
620 return_value=False).start()
621 mock.patch(
622 'git_cl.gerrit_util.GceAuthenticator.is_gce',
623 return_value=False).start()
624 mock.patch(
625 'git_cl.gerrit_util.ValidAccounts',
626 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
627 mock.patch(
628 'git_cl.DieWithError',
629 lambda msg, change=None: self._mocked_call('DieWithError', msg)).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000630 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
631 mock.patch(
632 'git_cl.Changelist.FetchUpstreamTuple',
633 return_value=('origin', 'refs/heads/master')).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000634 # It's important to reset settings to not have inter-tests interference.
635 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000636 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000637
638 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000639 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000640 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100641 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000642 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100643 raise
644 # Sadly, has_failed() returns True if this OR any other tests before this
645 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200646 git_cl.logging.error(
647 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100648 'There are un-consumed self.calls after this test has finished.\n'
649 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700650 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200651 'If you are already running only this test, then **first** fix the '
652 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100653 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700654 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100655 'and follow instructions above.\n' +
656 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000657 finally:
658 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000659
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000660 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000661 self.assertTrue(
662 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700663 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000664 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000665 expected_args, result = top
666
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000667 # Also logs otherwise it could get caught in a try/finally and be hard to
668 # diagnose.
669 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700670 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000671 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700672 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
673 for i, c in enumerate(self._calls_done[-N:]))
674 following_calls = '\n '.join(
675 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
676 for i, c in enumerate(self.calls[:N]))
677 extended_msg = (
678 'A few prior calls:\n %s\n\n'
679 'This (expected):\n @%d: %r\n'
680 'This (actual):\n @%d: %r\n\n'
681 'A few following expected calls:\n %s' %
682 (prior_calls, len(self._calls_done), expected_args,
683 len(self._calls_done), args, following_calls))
684 git_cl.logging.error(extended_msg)
685
tandrii99a72f22016-08-17 14:33:24 -0700686 self.fail('@%d\n'
687 ' Expected: %r\n'
688 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700689 len(self._calls_done), expected_args, args))
690
691 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700692 if isinstance(result, Exception):
693 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000694 # stdout from git commands is supposed to be a bytestream. Convert it here
695 # instead of converting all test output in this file to bytes.
696 if args[0][0] == 'git' and not isinstance(result, bytes):
697 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000698 return result
699
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100700 def test_ask_for_explicit_yes_true(self):
701 self.calls = [
702 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
703 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
704 ]
705 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
706
tandrii48df5812016-10-17 03:55:37 -0700707 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000708 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700709 self.calls = [
710 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700711 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
712 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
713 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
714 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700715 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
716 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700717 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
718 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000719 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
720 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700721 ((['git', 'config', 'gerrit.host', 'true'],), ''),
722 ]
723 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
724
maruel@chromium.orga3353652011-11-30 14:26:57 +0000725 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000726 def _is_gerrit_calls(cls, gerrit=False):
727 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
728 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
729
730 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000731 def _git_post_upload_calls(cls):
732 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000733 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
734 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
735 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000736 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000737 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000738 ]
739
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000740 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000741 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000742 fake_ancestor = 'fake_ancestor'
743 fake_cl = 'fake_cl_for_patch'
744 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000745 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000746 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000747 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000748 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000749 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000750 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000751 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000752 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700753 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000754 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000755 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000756 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000757 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000758 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000759 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000760 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000761 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000762 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000763 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000764 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000765
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000766 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000767 def _gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000768 cls, issue=None, skip_auth_check=False, short_hostname='chromium',
769 custom_cl_base=None):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000770 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000771 if skip_auth_check:
772 return [((cmd, ), 'true')]
773
tandrii5d48c322016-08-18 16:19:37 -0700774 calls = [((cmd, ), CERR1)]
Edward Lemurf38bc172019-09-03 21:02:13 +0000775
776 if custom_cl_base:
777 calls += [
778 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
779 ]
780
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000781 calls.extend([
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000782 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000783 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000784 ])
Edward Lemurf38bc172019-09-03 21:02:13 +0000785
786 calls += [
787 ((['git', 'config', 'branch.master.gerritissue'],),
788 CERR1 if issue is None else str(issue)),
789 ]
790
Daniel Chengcf6269b2019-05-18 01:02:12 +0000791 if issue:
792 calls.extend([
793 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
794 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000795 return calls
796
797 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100798 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200799 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000800 custom_cl_base=None, short_hostname='chromium',
801 change_id=None):
Aaron Gable13101a62018-02-09 13:20:41 -0800802 calls = cls._is_gerrit_calls(True)
Edward Lemurf38bc172019-09-03 21:02:13 +0000803 if not custom_cl_base:
804 calls += [
805 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
806 ]
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200807
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000808
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200809 if custom_cl_base:
810 ancestor_revision = custom_cl_base
811 else:
812 # Determine ancestor_revision to be merge base.
813 ancestor_revision = 'fake_ancestor_sha'
814 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000815 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
816 ancestor_revision),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200817 ]
818
819 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000820 calls += cls._gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000821 issue=issue, short_hostname=short_hostname,
822 custom_cl_base=custom_cl_base)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100823
824 if issue:
825 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000826 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000827 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000828 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
829 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100830 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100831 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Anthony Polito8b955342019-09-24 19:01:36 +0000832 'change_id': (change_id or '123456789'),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100833 'current_revision': 'sha1_of_current_revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000834 'revisions': {'sha1_of_current_revision': {
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100835 'commit': {'message': fetched_description},
836 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100837 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100838 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100839 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100840 if fetched_status == 'ABANDONED':
841 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000842 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100843 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000844 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100845 ]
846 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100847 if other_cl_owner:
848 calls += [
849 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
850 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100851
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200852 calls += cls._git_sanity_checks(ancestor_revision, 'master',
853 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100854 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200855 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000856
Aaron Gable7817f022017-12-12 09:43:17 -0800857 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
Edward Lemur7f6dec02020-02-06 20:23:58 +0000858 '--no-renames', '-r', ancestor_revision + '...'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200859 'M\t.gitignore\n'),
860 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100861 ]
862
863 if not issue:
864 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200865 ((['git', 'log', '--pretty=format:%s%n%n%b',
866 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000867 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100868 ]
869
870 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200871 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000872 (('time.time',), 1000,),
873 (('time.time',), 3000,),
874 (('add_repeated', 'sub_commands', {
875 'execution_time': 2000,
876 'command': 'presubmit',
877 'exit_code': 0
878 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200879 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
880 ([custom_cl_base] if custom_cl_base else
881 [ancestor_revision, 'HEAD']),),
882 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100883 ]
884 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000885
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000886 @classmethod
887 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700888 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000889 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700890 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100891 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000892 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000893 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000894 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000895 final_description=None, gitcookies_exists=True,
Josipe827b0f2020-01-30 00:07:20 +0000896 force=False, edit_description=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000897 if post_amend_description is None:
898 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700899 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200900 # Determined in `_gerrit_base_calls`.
901 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
902
903 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000904
tandriia60502f2016-06-20 02:01:53 -0700905 if squash_mode == 'default':
906 calls.extend([
907 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
908 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
909 ])
910 elif squash_mode in ('override_squash', 'override_nosquash'):
911 calls.extend([
912 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
913 'true' if squash_mode == 'override_squash' else 'false'),
914 ])
915 else:
916 assert squash_mode in ('squash', 'nosquash')
917
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000918 # If issue is given, then description is fetched from Gerrit instead.
919 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000920 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200921 ((['git', 'log', '--pretty=format:%s\n\n%b',
922 ((custom_cl_base + '..') if custom_cl_base else
923 'fake_ancestor_sha..HEAD')],),
924 description),
925 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800926 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000927 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800928 else:
929 if not title:
930 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200931 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
932 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800933 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000934 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000935 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000936 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200937 (('DownloadGerritHook', False), ''),
938 # Amending of commit message to get the Change-Id.
939 ((['git', 'log', '--pretty=format:%s\n\n%b',
940 determined_ancestor_revision + '..HEAD'],),
941 description),
942 ((['git', 'commit', '--amend', '-m', description],), ''),
943 ((['git', 'log', '--pretty=format:%s\n\n%b',
944 determined_ancestor_revision + '..HEAD'],),
945 post_amend_description)
946 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000947 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000948 if force or not issue:
949 if issue:
950 calls += [
951 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
952 ]
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000953 # Prompting to edit description on first upload.
954 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000955 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000956 ]
Anthony Polito8b955342019-09-24 19:01:36 +0000957 if not force:
958 calls += [
959 ((['git', 'config', 'core.editor'],), ''),
960 ((['RunEditor'],), description),
961 ]
Josipe827b0f2020-01-30 00:07:20 +0000962 # user wants to edit description
963 if edit_description:
964 calls += [
965 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
966 ((['git', 'config', 'core.editor'],), ''),
967 ((['RunEditor'],), edit_description),
968 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000969 ref_to_push = 'abcdef0123456789'
970 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200971 ]
972
973 if custom_cl_base is None:
974 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000975 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000976 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200977 ]
978 parent = 'origin/master'
979 else:
980 calls += [
981 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
982 'refs/remotes/origin/master'],),
983 callError(1)), # Means not ancenstor.
984 (('ask_for_data',
985 'Do you take responsibility for cleaning up potential mess '
986 'resulting from proceeding with upload? Press Enter to upload, '
987 'or Ctrl+C to abort'), ''),
988 ]
989 parent = custom_cl_base
990
991 calls += [
992 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
993 '0123456789abcdef'),
994 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -0700995 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200996 ref_to_push),
997 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000998 else:
999 ref_to_push = 'HEAD'
1000
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001001 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001002 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001003 ((['git', 'rev-list',
1004 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1005 ref_to_push],),
1006 '1hashPerLine\n'),
1007 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001008
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001009 metrics_arguments = []
1010
Aaron Gableafd52772017-06-27 16:40:10 -07001011 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001012 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001013 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001014 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001015 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001016 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001017 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001018 else:
1019 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001020 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001021
Aaron Gable70f4e242017-06-26 10:45:59 -07001022 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001023 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001024 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001025
Edward Lemur4508b422019-10-03 21:56:35 +00001026 if issue is None:
1027 calls += [
1028 ((['git', 'config', 'rietveld.cc'],), ''),
1029 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001030 if short_hostname == 'chromium':
1031 # All reviwers and ccs get into ref_suffix.
1032 for r in sorted(reviewers):
1033 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001034 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +00001035 if issue is None:
1036 cc += ['chromium-reviews+test-more-cc@chromium.org', 'joe@example.com']
1037 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001038 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001039 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001040 reviewers, cc = [], []
1041 else:
1042 # TODO(crbug/877717): remove this case.
1043 calls += [
1044 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1045 sorted(reviewers) + ['joe@example.com',
1046 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1047 {
1048 e: {'email': e}
1049 for e in (reviewers + ['joe@example.com'] + cc)
1050 })
1051 ]
1052 for r in sorted(reviewers):
1053 if r != 'bad-account-or-email':
1054 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001055 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001056 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +00001057 if issue is None:
1058 cc += ['joe@example.com']
1059 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001060 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001061 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001062 if c in cc:
1063 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001064
Edward Lemur687ca902018-12-05 02:30:30 +00001065 for k, v in sorted((labels or {}).items()):
1066 ref_suffix += ',l=%s+%d' % (k, v)
1067 metrics_arguments.append('l=%s+%d' % (k, v))
1068
1069 if tbr:
1070 calls += [
1071 (('GetCodeReviewTbrScore',
1072 '%s-review.googlesource.com' % short_hostname,
1073 'my/repo'),
1074 2,),
1075 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001076
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001077 calls += [
1078 (('time.time',), 1000,),
1079 ((['git', 'push',
1080 'https://%s.googlesource.com/my/repo' % short_hostname,
1081 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1082 (('remote:\n'
1083 'remote: Processing changes: (\)\n'
1084 'remote: Processing changes: (|)\n'
1085 'remote: Processing changes: (/)\n'
1086 'remote: Processing changes: (-)\n'
1087 'remote: Processing changes: new: 1 (/)\n'
1088 'remote: Processing changes: new: 1, done\n'
1089 'remote:\n'
1090 'remote: New Changes:\n'
1091 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1092 ' XXX\n'
1093 'remote:\n'
1094 'To https://%s.googlesource.com/my/repo\n'
1095 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1096 ) % (short_hostname, short_hostname)),),
1097 (('time.time',), 2000,),
1098 (('add_repeated',
1099 'sub_commands',
1100 {
1101 'execution_time': 1000,
1102 'command': 'git push',
1103 'exit_code': 0,
1104 'arguments': sorted(metrics_arguments),
1105 }),
1106 None,),
1107 ]
1108
Edward Lemur1b52d872019-05-09 21:12:12 +00001109 final_description = final_description or post_amend_description.strip()
1110 original_title = original_title or title or '<untitled>'
1111 # Trace-related calls
1112 calls += [
1113 # Write a description with context for the current trace.
1114 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001115 'Thu Mar 16 20:00:41 2017\n'
1116 '%(short_hostname)s-review.googlesource.com\n'
1117 '%(change_id)s\n'
1118 '%(title)s\n'
1119 '%(description)s\n'
1120 '1000\n'
1121 '0\n'
1122 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001123 'short_hostname': short_hostname,
1124 'change_id': change_id,
1125 'description': final_description,
1126 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001127 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001128 }],),
1129 None,
1130 ),
1131 # Read traces and shorten git hashes.
1132 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1133 True,
1134 ),
1135 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1136 ('git-hash: 0123456789012345678901234567890123456789\n'
1137 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1138 ),
1139 ((['FileWrite', 'TEMP_DIR/trace-packet',
1140 'git-hash: 012345\n'
1141 'git-hash: abcdea\n'],),
1142 None,
1143 ),
1144 # Make zip file for the git traces.
1145 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1146 'TEMP_DIR'],),
1147 None,
1148 ),
1149 # Collect git config and gitcookies.
1150 ((['git', 'config', '-l'],),
1151 'git-config-output',
1152 ),
1153 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1154 None,
1155 ),
1156 ((['os.path.isfile', '~/.gitcookies'],),
1157 gitcookies_exists,
1158 ),
1159 ]
1160 if gitcookies_exists:
1161 calls += [
1162 ((['FileRead', '~/.gitcookies'],),
1163 'gitcookies 1/SECRET',
1164 ),
1165 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1166 None,
1167 ),
1168 ]
1169 calls += [
1170 # Make zip file for the git config and gitcookies.
1171 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1172 'TEMP_DIR'],),
1173 None,
1174 ),
1175 ]
1176
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001177 if squash:
1178 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001179 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001180 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001181 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001182 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001183 ((['git', 'config', 'branch.master.gerritsquashhash',
1184 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001185 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001186 # TODO(crbug/877717): this should never be used.
1187 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001188 calls += [
1189 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001190 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001191 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001192 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1193 notify),
1194 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001195 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001196 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001197 return calls
1198
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001199 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001200 self,
1201 upload_args,
1202 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001203 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001204 squash=True,
1205 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001206 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001207 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001208 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001209 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001210 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001211 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001212 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001213 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001214 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001215 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001216 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001217 labels=None,
1218 change_id=None,
1219 original_title=None,
1220 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001221 gitcookies_exists=True,
1222 force=False,
Josipe827b0f2020-01-30 00:07:20 +00001223 edit_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001224 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001225 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001226 if squash_mode is None:
1227 if '--no-squash' in upload_args:
1228 squash_mode = 'nosquash'
1229 elif '--squash' in upload_args:
1230 squash_mode = 'squash'
1231 else:
1232 squash_mode = 'default'
1233
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001234 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001235 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001236 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001237 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001238 same_auth=('git-owner.example.com', '', 'pass'))).start()
1239 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1240 lambda _, offer_removal: None).start()
1241 mock.patch('git_cl.gclient_utils.RunEditor',
1242 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1243 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
1244 'DownloadGerritHook', force)).start()
1245 mock.patch('git_cl.gclient_utils.FileRead',
1246 lambda path: self._mocked_call(['FileRead', path])).start()
1247 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001248 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001249 ['FileWrite', path, contents])).start()
1250 mock.patch('git_cl.datetime_now',
1251 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1252 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1253 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1254 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001255 '%(now)s\n'
1256 '%(gerrit_host)s\n'
1257 '%(change_id)s\n'
1258 '%(title)s\n'
1259 '%(description)s\n'
1260 '%(execution_time)s\n'
1261 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001262 '%(trace_name)s').start()
1263 mock.patch('git_cl.shutil.make_archive',
1264 lambda *args: self._mocked_call(['make_archive'] +
1265 list(args))).start()
1266 mock.patch('os.path.isfile',
1267 lambda path: self._mocked_call(['os.path.isfile', path])).start()
tandriia60502f2016-06-20 02:01:53 -07001268
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001269 self.calls = self._gerrit_base_calls(
1270 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001271 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001272 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001273 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001274 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001275 short_hostname=short_hostname,
1276 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001277 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001278 mock.patch(
1279 'tempfile.NamedTemporaryFile',
1280 MakeNamedTemporaryFileMock(
1281 self, expected_content=description)).start()
1282 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001283 self.calls += self._gerrit_upload_calls(
1284 description, reviewers, squash,
1285 squash_mode=squash_mode,
1286 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001287 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001288 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001289 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001290 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001291 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001292 labels=labels,
1293 change_id=change_id,
1294 original_title=original_title,
1295 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001296 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001297 force=force,
1298 edit_description=edit_description)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001299 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001300 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001301 git_cl.main(['upload'] + upload_args)
1302
Edward Lemur1b52d872019-05-09 21:12:12 +00001303 def test_gerrit_upload_traces_no_gitcookies(self):
1304 self._run_gerrit_upload_test(
1305 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001306 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001307 [],
1308 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001309 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001310 change_id='Ixxx',
1311 gitcookies_exists=False)
1312
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001313 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001314 self._run_gerrit_upload_test(
1315 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001316 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001317 [],
1318 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001319 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001320 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001321
1322 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001323 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001324 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001325 'desc ✔\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001326 [],
tandriia60502f2016-06-20 02:01:53 -07001327 squash=False,
1328 squash_mode='override_nosquash',
Edward Lemur0db01f02019-11-12 22:01:51 +00001329 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001330 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001331
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001332 def test_gerrit_no_reviewer(self):
1333 self._run_gerrit_upload_test(
1334 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001335 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001336 [],
1337 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001338 squash_mode='override_nosquash',
1339 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001340
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001341 def test_gerrit_no_reviewer_non_chromium_host(self):
1342 # TODO(crbug/877717): remove this test case.
1343 self._run_gerrit_upload_test(
1344 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001345 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001346 [],
1347 squash=False,
1348 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001349 short_hostname='other',
1350 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001351
Nick Carter8692b182017-11-06 16:30:38 -08001352 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001353 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001354 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001355 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001356 squash=False,
1357 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001358 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1359 change_id='I123456789',
1360 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001361
ukai@chromium.orge8077812012-02-03 03:41:46 +00001362 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001363 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001364 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001365 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001366 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001367 squash=False,
1368 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001369 notify=True,
1370 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001371 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001372 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001373
Anthony Polito8b955342019-09-24 19:01:36 +00001374 def test_gerrit_upload_force_sets_bug(self):
1375 self._run_gerrit_upload_test(
1376 ['-b', '10000', '-f'],
1377 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1378 [],
1379 force=True,
1380 expected_upstream_ref='origin/master',
1381 fetched_description='desc=\n\nChange-Id: Ixxx',
1382 original_title='Initial upload',
1383 change_id='Ixxx')
1384
1385 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1386 self._run_gerrit_upload_test(
1387 ['-b', '10000', '-f', '-m', 'Title'],
1388 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1389 [],
1390 force=True,
1391 issue='123456',
1392 expected_upstream_ref='origin/master',
1393 fetched_description='desc=\n\nChange-Id: Ixxxx',
1394 original_title='Title',
1395 title='Title',
1396 change_id='Izzzz')
1397
Dan Beamd8b04ca2019-10-10 21:23:26 +00001398 def test_gerrit_upload_force_sets_fixed(self):
1399 self._run_gerrit_upload_test(
1400 ['-x', '10000', '-f'],
1401 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1402 [],
1403 force=True,
1404 expected_upstream_ref='origin/master',
1405 fetched_description='desc=\n\nChange-Id: Ixxx',
1406 original_title='Initial upload',
1407 change_id='Ixxx')
1408
ukai@chromium.orge8077812012-02-03 03:41:46 +00001409 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001410 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1411 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001412 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001413 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001414 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001415 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001416 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001417 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001418 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001419 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001420 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001421 labels={'Code-Review': 2},
1422 change_id='123456789',
1423 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001424
1425 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001426 self._run_gerrit_upload_test(
1427 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001428 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001429 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001430 expected_upstream_ref='origin/master',
1431 change_id='123456789',
1432 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001433
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001434 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001435 self._run_gerrit_upload_test(
1436 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001437 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001438 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001439 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001440 expected_upstream_ref='origin/master',
1441 change_id='123456789',
1442 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001443
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001444 def test_gerrit_upload_squash_first_with_labels(self):
1445 self._run_gerrit_upload_test(
1446 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001447 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001448 [],
1449 squash=True,
1450 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001451 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1452 change_id='123456789',
1453 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001454
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001455 def test_gerrit_upload_squash_first_against_rev(self):
1456 custom_cl_base = 'custom_cl_base_rev_or_branch'
1457 self._run_gerrit_upload_test(
1458 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001459 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001460 [],
1461 squash=True,
1462 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001463 custom_cl_base=custom_cl_base,
1464 change_id='123456789',
1465 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001466 self.assertIn(
1467 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1468 sys.stdout.getvalue())
1469
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001470 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001471 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001472 self._run_gerrit_upload_test(
1473 ['--squash'],
1474 description,
1475 [],
1476 squash=True,
1477 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001478 issue=123456,
1479 change_id='123456789',
1480 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001481
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001482 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001483 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001484 with self.assertRaises(SystemExitMock):
1485 self._run_gerrit_upload_test(
1486 ['--squash'],
1487 description,
1488 [],
1489 squash=True,
1490 expected_upstream_ref='origin/master',
1491 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001492 fetched_status='ABANDONED',
1493 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001494
Edward Lemurda4b6c62020-02-13 00:28:40 +00001495 @mock.patch(
1496 'gerrit_util.GetAccountDetails',
1497 return_value={'email': 'yet-another@example.com'})
1498 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001499 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001500 self._run_gerrit_upload_test(
1501 ['--squash'],
1502 description,
1503 [],
1504 squash=True,
1505 expected_upstream_ref='origin/master',
1506 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001507 other_cl_owner='other@example.com',
1508 change_id='123456789',
1509 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001510 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001511 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001512 'authenticate to Gerrit as yet-another@example.com.\n'
1513 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001514 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001515
Josipe827b0f2020-01-30 00:07:20 +00001516 def test_upload_change_description_editor(self):
1517 fetched_description = 'foo\n\nChange-Id: 123456789'
1518 description = 'bar\n\nChange-Id: 123456789'
1519 self._run_gerrit_upload_test(
1520 ['--squash', '--edit-description'],
1521 description,
1522 [],
1523 fetched_description=fetched_description,
1524 squash=True,
1525 expected_upstream_ref='origin/master',
1526 issue=123456,
1527 change_id='123456789',
1528 original_title='User input',
1529 edit_description=description)
1530
Edward Lemurda4b6c62020-02-13 00:28:40 +00001531 @mock.patch('git_cl.RunGit')
1532 @mock.patch('git_cl.CMDupload')
1533 @mock.patch('git_cl.ask_for_data')
1534 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001535 def mock_run_git(*args, **_kwargs):
1536 if args[0] == ['for-each-ref',
1537 '--format=%(refname:short) %(upstream:short)',
1538 'refs/heads']:
1539 # Create a local branch dependency tree that looks like this:
1540 # test1 -> test2 -> test3 -> test4 -> test5
1541 # -> test3.1
1542 # test6 -> test0
1543 branch_deps = [
1544 'test2 test1', # test1 -> test2
1545 'test3 test2', # test2 -> test3
1546 'test3.1 test2', # test2 -> test3.1
1547 'test4 test3', # test3 -> test4
1548 'test5 test4', # test4 -> test5
1549 'test6 test0', # test0 -> test6
1550 'test7', # test7
1551 ]
1552 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001553 git_cl.RunGit.side_effect = mock_run_git
1554 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001555
1556 class MockChangelist():
1557 def __init__(self):
1558 pass
1559 def GetBranch(self):
1560 return 'test1'
1561 def GetIssue(self):
1562 return '123'
1563 def GetPatchset(self):
1564 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001565 def IsGerrit(self):
1566 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001567
1568 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1569 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001570 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
1571 git_cl.ask_for_data.assert_called_once_with(
1572 'This command will checkout all dependent branches '
1573 'and run "git cl upload". Press Enter to continue, '
1574 'or Ctrl+C to abort')
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001575 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001576
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001577 def test_gerrit_change_id(self):
1578 self.calls = [
1579 ((['git', 'write-tree'], ),
1580 'hashtree'),
1581 ((['git', 'rev-parse', 'HEAD~0'], ),
1582 'branch-parent'),
1583 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1584 'A B <a@b.org> 1456848326 +0100'),
1585 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1586 'C D <c@d.org> 1456858326 +0100'),
1587 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1588 'hashchange'),
1589 ]
1590 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1591 self.assertEqual(change_id, 'Ihashchange')
1592
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001593 def test_desecription_append_footer(self):
1594 for init_desc, footer_line, expected_desc in [
1595 # Use unique desc first lines for easy test failure identification.
1596 ('foo', 'R=one', 'foo\n\nR=one'),
1597 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1598 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1599 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1600 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1601 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1602 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1603 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1604 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1605 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1606 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1607 ]:
1608 desc = git_cl.ChangeDescription(init_desc)
1609 desc.append_footer(footer_line)
1610 self.assertEqual(desc.description, expected_desc)
1611
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001612 def test_update_reviewers(self):
1613 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001614 ('foo', [], [],
1615 'foo'),
1616 ('foo\nR=xx', [], [],
1617 'foo\nR=xx'),
1618 ('foo\nTBR=xx', [], [],
1619 'foo\nTBR=xx'),
1620 ('foo', ['a@c'], [],
1621 'foo\n\nR=a@c'),
1622 ('foo\nR=xx', ['a@c'], [],
1623 'foo\n\nR=a@c, xx'),
1624 ('foo\nTBR=xx', ['a@c'], [],
1625 'foo\n\nR=a@c\nTBR=xx'),
1626 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1627 'foo\n\nR=a@c, yy\nTBR=xx'),
1628 ('foo\nBUG=', ['a@c'], [],
1629 'foo\nBUG=\nR=a@c'),
1630 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1631 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1632 ('foo', ['a@c', 'b@c'], [],
1633 'foo\n\nR=a@c, b@c'),
1634 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1635 'foo\nBar\n\nR=c@c\nBUG='),
1636 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1637 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001638 # Same as the line before, but full of whitespaces.
1639 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001640 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001641 'foo\nBar\n\nR=c@c\n BUG =',
1642 ),
1643 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001644 ('foo BUG=allo R=joe ', ['c@c'], [],
1645 'foo BUG=allo R=joe\n\nR=c@c'),
1646 # Redundant TBRs get promoted to Rs
1647 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1648 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001649 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001650 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001651 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001652 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001653 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001654 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001655 actual.append(obj.description)
1656 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001657
Nodir Turakulov23b82142017-11-16 11:04:25 -08001658 def test_get_hash_tags(self):
1659 cases = [
1660 ('', []),
1661 ('a', []),
1662 ('[a]', ['a']),
1663 ('[aa]', ['aa']),
1664 ('[a ]', ['a']),
1665 ('[a- ]', ['a']),
1666 ('[a- b]', ['a-b']),
1667 ('[a--b]', ['a-b']),
1668 ('[a', []),
1669 ('[a]x', ['a']),
1670 ('[aa]x', ['aa']),
1671 ('[a b]', ['a-b']),
1672 ('[a b]', ['a-b']),
1673 ('[a__b]', ['a-b']),
1674 ('[a] x', ['a']),
1675 ('[a][b]', ['a', 'b']),
1676 ('[a] [b]', ['a', 'b']),
1677 ('[a][b]x', ['a', 'b']),
1678 ('[a][b] x', ['a', 'b']),
1679 ('[a]\n[b]', ['a']),
1680 ('[a\nb]', []),
1681 ('[a][', ['a']),
1682 ('Revert "[a] feature"', ['a']),
1683 ('Reland "[a] feature"', ['a']),
1684 ('Revert: [a] feature', ['a']),
1685 ('Reland: [a] feature', ['a']),
1686 ('Revert "Reland: [a] feature"', ['a']),
1687 ('Foo: feature', ['foo']),
1688 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001689 ('Change Foo::Bar', []),
1690 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001691 ('Revert "Foo bar: feature"', ['foo-bar']),
1692 ('Reland "Foo bar: feature"', ['foo-bar']),
1693 ]
1694 for desc, expected in cases:
1695 change_desc = git_cl.ChangeDescription(desc)
1696 actual = change_desc.get_hash_tags()
1697 self.assertEqual(
1698 actual,
1699 expected,
1700 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1701
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001702 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001703 self.assertEqual(None, git_cl.GetTargetRef(None,
1704 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001705 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001706
wittman@chromium.org455dc922015-01-26 20:15:50 +00001707 # Check default target refs for branches.
1708 self.assertEqual('refs/heads/master',
1709 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001710 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001711 self.assertEqual('refs/heads/master',
1712 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001713 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001714 self.assertEqual('refs/heads/master',
1715 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001716 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001717 self.assertEqual('refs/branch-heads/123',
1718 git_cl.GetTargetRef('origin',
1719 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001720 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001721 self.assertEqual('refs/diff/test',
1722 git_cl.GetTargetRef('origin',
1723 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001724 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001725 self.assertEqual('refs/heads/chrome/m42',
1726 git_cl.GetTargetRef('origin',
1727 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001728 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001729
1730 # Check target refs for user-specified target branch.
1731 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1732 'refs/remotes/branch-heads/123'):
1733 self.assertEqual('refs/branch-heads/123',
1734 git_cl.GetTargetRef('origin',
1735 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001736 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001737 for branch in ('origin/master', 'remotes/origin/master',
1738 'refs/remotes/origin/master'):
1739 self.assertEqual('refs/heads/master',
1740 git_cl.GetTargetRef('origin',
1741 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001742 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001743 for branch in ('master', 'heads/master', 'refs/heads/master'):
1744 self.assertEqual('refs/heads/master',
1745 git_cl.GetTargetRef('origin',
1746 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001747 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001748
Edward Lemurda4b6c62020-02-13 00:28:40 +00001749 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1750 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001751 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001752 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1753
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001754 @staticmethod
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001755 def _get_gerrit_codereview_server_calls(value=None,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001756 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001757 detect_branch=True,
1758 detect_server=True):
Edward Lemur125d60a2019-09-13 18:25:41 +00001759 """Returns calls executed by Changelist.GetCodereviewServer.
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001760
1761 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1762 """
1763 calls = []
1764 if detect_branch:
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001765 calls.append(((['git', 'symbolic-ref', 'HEAD'],), 'master'))
Aaron Gable697a91b2018-01-19 15:20:15 -08001766 if detect_server:
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001767 calls.append(((['git', 'config', 'branch.master.gerritserver'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001768 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001769 if value is None:
1770 calls += [
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001771 ((['git', 'config', 'remote.origin.url'],),
1772 'https://%s.googlesource.com/my/repo' % git_short_host),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001773 ]
1774 return calls
1775
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001776 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001777 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001778 detect_gerrit_server=False,
1779 actual_codereview=None,
1780 codereview_in_url=False):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001781 mock.patch('git_cl.IsGitVersionAtLeast', return_value=True).start()
wychen@chromium.orga872e752015-04-28 23:42:18 +00001782
tandriidf09a462016-08-18 16:23:55 -07001783 if new_branch:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001784 self.calls = [((['git', 'new-branch', 'master'],), '')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001785
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001786 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001787 self.calls += [
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001788 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001789 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001790
1791 if not force_codereview and not codereview_in_url:
1792 # These calls detect codereview to use.
1793 self.calls += [
1794 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001795 ]
1796 if detect_gerrit_server:
1797 self.calls += self._get_gerrit_codereview_server_calls(
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001798 git_short_host=git_short_host,
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001799 detect_branch=not new_branch and force_codereview)
1800 actual_codereview = 'gerrit'
1801
1802 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001803 self.calls += [
1804 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001805 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001806 {
1807 'current_revision': '7777777777',
1808 'revisions': {
1809 '1111111111': {
1810 '_number': 1,
1811 'fetch': {'http': {
1812 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1813 'ref': 'refs/changes/56/123456/1',
1814 }},
1815 },
1816 '7777777777': {
1817 '_number': 7,
1818 'fetch': {'http': {
1819 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1820 'ref': 'refs/changes/56/123456/7',
1821 }},
1822 },
1823 },
1824 }),
1825 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001826
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001827 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001828 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001829 self.calls += [
1830 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1831 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001832 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001833 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001834 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001835 ((['git', 'config', 'branch.master.gerritserver',
1836 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001837 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001838 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1839 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1840 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001841 ]
1842 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1843
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001844 def test_patch_gerrit_new_branch(self):
1845 self._patch_common(
1846 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1847 self.calls += [
1848 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1849 'refs/changes/56/123456/7'],), ''),
1850 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1851 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1852 ''),
1853 ((['git', 'config', 'branch.master.gerritserver',
1854 'https://chromium-review.googlesource.com'],), ''),
1855 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1856 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1857 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1858 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1859 ]
1860 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1861
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001862 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001863 self._patch_common(
1864 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001865 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001866 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001867 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001868 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001869 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001870 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001871 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001872 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001873 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001874 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1875 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1876 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001877 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001878 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001879
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001880 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001881 self.calls += self._get_gerrit_codereview_server_calls(
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001882 git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001883 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001884 actual_codereview='gerrit', git_short_host='else',
1885 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001886 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001887 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001888 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001889 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001890 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001891 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001892 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001893 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001894 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001895 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1896 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1897 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001898 ]
1899 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001900 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001901
Aaron Gable697a91b2018-01-19 15:20:15 -08001902 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001903 self.calls += self._get_gerrit_codereview_server_calls(
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001904 git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001905 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001906 actual_codereview='gerrit', git_short_host='else',
1907 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001908 self.calls += [
1909 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1910 'refs/changes/56/123456/1'],), ''),
1911 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1912 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1913 ''),
1914 ((['git', 'config', 'branch.master.gerritserver',
1915 'https://else-review.googlesource.com'],), ''),
1916 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1917 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1918 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1919 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1920 ]
1921 self.assertEqual(git_cl.main(
1922 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1923 0)
1924
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001925 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001926 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001927 self.calls += [
1928 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001929 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001930 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
Edward Lemurda4b6c62020-02-13 00:28:40 +00001931 (('DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'),
tandrii5d48c322016-08-18 16:19:37 -07001932 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001933 ]
1934 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001935 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001936
Edward Lemurda4b6c62020-02-13 00:28:40 +00001937 @mock.patch(
1938 'git_cl.gerrit_util.GetChangeDetail',
1939 side_effect=gerrit_util.GerritError(404, ''))
1940 def test_patch_gerrit_not_exists(self, *_mocks):
tandriic2405f52016-10-10 08:13:15 -07001941 self.calls = [
1942 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001943 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001944 ((['git', 'config', 'remote.origin.url'],),
1945 'https://chromium.googlesource.com/my/repo'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00001946 (('DieWithError',
1947 'change 123456 at https://chromium-review.googlesource.com does not '
1948 'exist or you have no access to it'), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001949 ]
1950 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001951 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001952
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001953 def _checkout_calls(self):
1954 return [
1955 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001956 'branch\\..*\\.gerritissue'], ),
1957 ('branch.ger-branch.gerritissue 123456\n'
1958 'branch.gbranch654.gerritissue 654321\n')),
1959 ]
1960
1961 def test_checkout_gerrit(self):
1962 """Tests git cl checkout <issue>."""
1963 self.calls = self._checkout_calls()
1964 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1965 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1966
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001967 def test_checkout_not_found(self):
1968 """Tests git cl checkout <issue>."""
1969 self.calls = self._checkout_calls()
1970 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1971
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001972 def test_checkout_no_branch_issues(self):
1973 """Tests git cl checkout <issue>."""
1974 self.calls = [
1975 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001976 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001977 ]
1978 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1979
tandrii@chromium.org28253532016-04-14 13:46:56 +00001980 def _test_gerrit_ensure_authenticated_common(self, auth,
1981 skip_auth_check=False):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001982 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1983 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001984 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
Edward Lemurf38bc172019-09-03 21:02:13 +00001985 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001986 cl.branch = 'master'
1987 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001988 return cl
1989
1990 def test_gerrit_ensure_authenticated_missing(self):
1991 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001992 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001993 })
1994 self.calls.append(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001995 (('DieWithError',
1996 'Credentials for the following hosts are required:\n'
1997 ' chromium-review.googlesource.com\n'
1998 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
1999 'You can (re)generate your credentials by visiting '
2000 'https://chromium-review.googlesource.com/new-password'), ''),)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002001 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2002
2003 def test_gerrit_ensure_authenticated_conflict(self):
2004 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002005 'chromium.googlesource.com':
2006 ('git-one.example.com', None, 'secret1'),
2007 'chromium-review.googlesource.com':
2008 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002009 })
2010 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002011 (('ask_for_data', 'If you know what you are doing '
2012 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002013 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2014
2015 def test_gerrit_ensure_authenticated_ok(self):
2016 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002017 'chromium.googlesource.com':
2018 ('git-same.example.com', None, 'secret'),
2019 'chromium-review.googlesource.com':
2020 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002021 })
2022 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2023
tandrii@chromium.org28253532016-04-14 13:46:56 +00002024 def test_gerrit_ensure_authenticated_skipped(self):
2025 cl = self._test_gerrit_ensure_authenticated_common(
2026 auth={}, skip_auth_check=True)
2027 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2028
Eric Boren2fb63102018-10-05 13:05:03 +00002029 def test_gerrit_ensure_authenticated_bearer_token(self):
2030 cl = self._test_gerrit_ensure_authenticated_common(auth={
2031 'chromium.googlesource.com':
2032 ('', None, 'secret'),
2033 'chromium-review.googlesource.com':
2034 ('', None, 'secret'),
2035 })
2036 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2037 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2038 'chromium.googlesource.com')
2039 self.assertTrue('Bearer' in header)
2040
Daniel Chengcf6269b2019-05-18 01:02:12 +00002041 def test_gerrit_ensure_authenticated_non_https(self):
2042 self.calls = [
2043 ((['git', 'config', '--bool',
2044 'gerrit.skip-ensure-authenticated'],), CERR1),
Daniel Chengcf6269b2019-05-18 01:02:12 +00002045 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
Josip906bfde2020-01-31 22:38:49 +00002046 (('logging.warning',
2047 'Ignoring branch %(branch)s with non-https remote '
2048 '%(remote)s', {
2049 'branch': 'master',
2050 'remote': 'custom-scheme://repo'}
2051 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00002052 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002053 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2054 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2055 mock.patch('logging.warning',
2056 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002057 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002058 cl.branch = 'master'
2059 cl.branchref = 'refs/heads/master'
2060 cl.lookedup_issue = True
2061 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2062
Florian Mayerae510e82020-01-30 21:04:48 +00002063 def test_gerrit_ensure_authenticated_non_url(self):
2064 self.calls = [
2065 ((['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated'], ),
2066 CERR1),
Florian Mayerae510e82020-01-30 21:04:48 +00002067 ((['git', 'config', 'remote.origin.url'], ),
2068 'git@somehost.example:foo/bar.git'),
Josip906bfde2020-01-31 22:38:49 +00002069 (('logging.error',
2070 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2071 'but it doesn\'t exist.', {
2072 'remote': 'origin',
2073 'branch': 'master',
2074 'url': 'git@somehost.example:foo/bar.git'}
2075 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00002076 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002077 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2078 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2079 mock.patch('logging.error',
2080 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00002081 cl = git_cl.Changelist()
2082 cl.branch = 'master'
2083 cl.branchref = 'refs/heads/master'
2084 cl.lookedup_issue = True
2085 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2086
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002087 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002088 self.calls = [
2089 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002090 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002091 ((['git', 'config', 'branch.feature.gerritserver'],),
2092 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002093 ((['git', 'config', 'remote.origin.url'],),
2094 'https://chromium.googlesource.com/infra/infra.git'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002095 (('SetReview', 'chromium-review.googlesource.com',
2096 'infra%2Finfra~123', None,
2097 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002098 ]
tandriid9e5ce52016-07-13 02:32:59 -07002099
2100 def test_cmd_set_commit_gerrit_clear(self):
2101 self._cmd_set_commit_gerrit_common(0)
2102 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2103
2104 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002105 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002106 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2107
tandriid9e5ce52016-07-13 02:32:59 -07002108 def test_cmd_set_commit_gerrit(self):
2109 self._cmd_set_commit_gerrit_common(2)
2110 self.assertEqual(0, git_cl.main(['set-commit']))
2111
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002112 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002113 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002114 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002115
2116 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002117 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002118
Edward Lemurda4b6c62020-02-13 00:28:40 +00002119 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07002120 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07002121 try:
2122 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2123 except SystemExit as ex:
2124 self.assertEqual(ex.code, 2)
Edward Lemur6c6827c2020-02-06 21:15:18 +00002125 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00002126 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07002127
2128 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07002129 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002130 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002131 return 'foobar'
2132
Edward Lemurda4b6c62020-02-13 00:28:40 +00002133 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07002134 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002135 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002136 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00002137 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07002138
iannuccie53c9352016-08-17 14:40:40 -07002139 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002140
iannuccie53c9352016-08-17 14:40:40 -07002141 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002142 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002143 return 'foobar'
2144
Edward Lemurda4b6c62020-02-13 00:28:40 +00002145 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2146 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002147 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002148 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002149
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002150 def test_description(self):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002151 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002152 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002153 ((['git', 'config', 'remote.origin.url'],),
2154 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002155 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002156 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002157 {
2158 'current_revision': 'sha1',
2159 'revisions': {'sha1': {
2160 'commit': {'message': 'foobar'},
2161 }},
2162 }),
2163 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002164 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002165 'description',
2166 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2167 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002168 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002169
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002170 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002171 mock.patch('git_cl.Changelist', ChangelistMock).start()
2172 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002173
2174 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2175 self.assertEqual('hihi', ChangelistMock.desc)
2176
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002177 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002178 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002179
2180 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002181 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002182 '# Enter a description of the change.\n'
2183 '# This will be displayed on the codereview site.\n'
2184 '# The first line will also be used as the subject of the review.\n'
2185 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002186 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002187 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002188 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002189 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002190 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002191
Edward Lemur6c6827c2020-02-06 21:15:18 +00002192 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002193 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002194
Edward Lemurda4b6c62020-02-13 00:28:40 +00002195 mock.patch('git_cl.Changelist.FetchDescription',
2196 lambda *args: current_desc).start()
2197 mock.patch('git_cl.Changelist.UpdateDescription',
2198 UpdateDescription).start()
2199 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002200
2201 self.calls = [
2202 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002203 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002204 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2205 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002206 ((['git', 'config', 'core.editor'],), 'vi'),
2207 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002208 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002209
Dan Beamd8b04ca2019-10-10 21:23:26 +00002210 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2211 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2212
2213 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002214 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002215 '# Enter a description of the change.\n'
2216 '# This will be displayed on the codereview site.\n'
2217 '# The first line will also be used as the subject of the review.\n'
2218 '#--------------------This line is 72 characters long'
2219 '--------------------\n'
2220 'Some.\n\nFixed: 123\nChange-Id: xxx',
2221 desc)
2222 return desc
2223
Edward Lemurda4b6c62020-02-13 00:28:40 +00002224 mock.patch('git_cl.Changelist.FetchDescription',
2225 lambda *args: current_desc).start()
2226 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002227
2228 self.calls = [
2229 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2230 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2231 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2232 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
2233 ((['git', 'config', 'core.editor'],), 'vi'),
2234 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002235 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002236
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002237 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002238 mock.patch('git_cl.Changelist', ChangelistMock).start()
2239 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002240
2241 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2242 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2243
kmarshall3bff56b2016-06-06 18:31:47 -07002244 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002245 self.calls = [
2246 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002247 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002248 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002249 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2250 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002251 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002252 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002253
Edward Lemurda4b6c62020-02-13 00:28:40 +00002254 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002255 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002256 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2257 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002258 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002259
2260 self.assertEqual(0, git_cl.main(['archive', '-f']))
2261
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002262 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002263 self.calls = [
2264 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2265 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2266 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2267 'refs/tags/git-cl-archived-456-foo'),
2268 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2269 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2270 ((['git', 'branch', '-D', 'foo'],), '')
2271 ]
2272
Edward Lemurda4b6c62020-02-13 00:28:40 +00002273 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002274 lambda branches, fine_grained, max_processes:
2275 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2276 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002277 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002278
2279 self.assertEqual(0, git_cl.main(['archive', '-f']))
2280
kmarshall3bff56b2016-06-06 18:31:47 -07002281 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002282 self.calls = [
2283 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2284 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002285 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002286 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2287 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002288
Edward Lemurda4b6c62020-02-13 00:28:40 +00002289 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002290 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002291 [(MockChangelistWithBranchAndIssue('master', 1),
2292 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002293
2294 self.assertEqual(1, git_cl.main(['archive', '-f']))
2295
2296 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002297 self.calls = [
2298 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2299 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002300 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002301 ((['git', 'symbolic-ref', 'HEAD'],), 'master')
2302 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002303
Edward Lemurda4b6c62020-02-13 00:28:40 +00002304 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002305 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002306 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2307 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002308 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002309
kmarshall9249e012016-08-23 12:02:16 -07002310 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2311
2312 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002313 self.calls = [
2314 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2315 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002316 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002317 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2318 ((['git', 'branch', '-D', 'foo'],), '')
2319 ]
kmarshall9249e012016-08-23 12:02:16 -07002320
Edward Lemurda4b6c62020-02-13 00:28:40 +00002321 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002322 lambda branches, fine_grained, max_processes:
2323 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2324 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002325 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002326
2327 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002328
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002329 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002330 self.calls = [
2331 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2332 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2333 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
2334 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2335 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2336 'refs/tags/git-cl-archived-456-foo'),
2337 ((['git', 'branch', '-D', 'foo'],), CERR1),
2338 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2339 'refs/tags/git-cl-archived-456-foo'),
2340 ]
2341
Edward Lemurda4b6c62020-02-13 00:28:40 +00002342 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002343 lambda branches, fine_grained, max_processes:
2344 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2345 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002346 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002347
2348 self.assertEqual(0, git_cl.main(['archive', '-f']))
2349
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002350 def test_cmd_issue_erase_existing(self):
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002351 self.calls = [
2352 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002353 # Let this command raise exception (retcode=1) - it should be ignored.
2354 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002355 CERR1),
2356 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2357 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002358 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2359 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2360 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002361 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002362 ]
2363 self.assertEqual(0, git_cl.main(['issue', '0']))
2364
Aaron Gable400e9892017-07-12 15:31:21 -07002365 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002366 mock.patch('git_cl.Changelist.FetchDescription',
2367 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002368 self.calls = [
2369 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002370 # Let this command raise exception (retcode=1) - it should be ignored.
2371 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2372 CERR1),
2373 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2374 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2375 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2376 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2377 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002378 ((['git', 'log', '-1', '--format=%B'],),
2379 'This is a description\n\nChange-Id: Ideadbeef'),
2380 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002381 ]
2382 self.assertEqual(0, git_cl.main(['issue', '0']))
2383
phajdan.jre328cf92016-08-22 04:12:17 -07002384 def test_cmd_issue_json(self):
phajdan.jre328cf92016-08-22 04:12:17 -07002385 self.calls = [
2386 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002387 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2388 ((['git', 'config', 'branch.feature.gerritserver'],),
2389 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002390 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002391 {'issue': 123,
2392 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002393 ''),
2394 ]
2395 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2396
tandrii16e0b4e2016-06-07 10:34:28 -07002397 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002398 mock.patch(
2399 'git_cl.os.path.abspath',
2400 lambda path: self._mocked_call(['abspath', path])).start()
2401 mock.patch(
2402 'git_cl.os.path.exists',
2403 lambda path: self._mocked_call(['exists', path])).start()
2404 mock.patch(
2405 'git_cl.gclient_utils.FileRead',
2406 lambda path: self._mocked_call(['FileRead', path])).start()
2407 mock.patch(
2408 'git_cl.gclient_utils.rm_file_or_tree',
2409 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002410 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002411
2412 def test_GerritCommitMsgHookCheck_custom_hook(self):
2413 cl = self._common_GerritCommitMsgHookCheck()
2414 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002415 ((['exists', '.git/hooks/commit-msg'],), True),
2416 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002417 '#!/bin/sh\necho "custom hook"')
2418 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002419 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002420
2421 def test_GerritCommitMsgHookCheck_not_exists(self):
2422 cl = self._common_GerritCommitMsgHookCheck()
2423 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002424 ((['exists', '.git/hooks/commit-msg'],), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002425 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002426 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002427
2428 def test_GerritCommitMsgHookCheck(self):
2429 cl = self._common_GerritCommitMsgHookCheck()
2430 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002431 ((['exists', '.git/hooks/commit-msg'],), True),
2432 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002433 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002434 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002435 ((['rm_file_or_tree', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002436 ''),
2437 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002438 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002439
tandriic4344b52016-08-29 06:04:54 -07002440 def test_GerritCmdLand(self):
2441 self.calls += [
2442 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2443 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2444 'deadbeaf'),
2445 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2446 ((['git', 'config', 'branch.feature.gerritserver'],),
2447 'chromium-review.googlesource.com'),
2448 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002449 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002450 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002451 'labels': {},
2452 'current_revision': 'deadbeaf',
2453 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002454 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002455 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002456 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002457 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2458 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002459 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002460 self.assertEqual(0, cl.CMDLand(force=True,
2461 bypass_hooks=True,
2462 verbose=True,
2463 parallel=False))
Edward Lemur73c76702020-02-06 23:57:18 +00002464 self.assertIn(
2465 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002466 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002467 self.assertIn(
2468 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002469 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002470
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002471 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002472 mock.patch('git_cl.Changelist._GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002473
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002474 def test_gerrit_change_detail_cache_simple(self):
2475 self._mock_gerrit_changes_for_detail_cache()
2476 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002477 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2478 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2479 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002480 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002481 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002482 cl1._cached_remote_url = (
2483 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002484 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002485 cl2._cached_remote_url = (
2486 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002487 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2488 self.assertEqual(cl1._GetChangeDetail(), 'a')
2489 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2490 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2491 self.assertEqual(cl1._GetChangeDetail(), 'a')
2492 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002493
2494 def test_gerrit_change_detail_cache_options(self):
2495 self._mock_gerrit_changes_for_detail_cache()
2496 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002497 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2498 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2499 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2500 # no longer in cache.
2501 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002502 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002503 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002504 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002505 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2506 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2507 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2508 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2509 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2510 self.assertEqual(cl._GetChangeDetail(), 'cab')
2511
2512 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2513 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2514 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2515 self.assertEqual(cl._GetChangeDetail(), 'cab')
2516
2517 # Finally, no_cache should invalidate all caches for given change.
2518 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2519 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2520
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002521 def test_gerrit_description_caching(self):
2522 def gen_detail(rev, desc):
2523 return {
2524 'current_revision': rev,
2525 'revisions': {rev: {'commit': {'message': desc}}}
2526 }
2527 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002528 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002529 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2530 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002531 ]
2532
2533 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002534 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002535 cl._cached_remote_url = (
2536 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002537 self.assertEqual(cl.FetchDescription(), 'desc1')
2538 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002539
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002540 def test_print_current_creds(self):
2541 class CookiesAuthenticatorMock(object):
2542 def __init__(self):
2543 self.gitcookies = {
2544 'host.googlesource.com': ('user', 'pass'),
2545 'host-review.googlesource.com': ('user', 'pass'),
2546 }
2547 self.netrc = self
2548 self.netrc.hosts = {
2549 'github.com': ('user2', None, 'pass2'),
2550 'host2.googlesource.com': ('user3', None, 'pass'),
2551 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002552 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2553 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002554 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2555 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2556 ' Host\t User\t Which file',
2557 '============================\t=====\t===========',
2558 'host-review.googlesource.com\t user\t.gitcookies',
2559 ' host.googlesource.com\t user\t.gitcookies',
2560 ' host2.googlesource.com\tuser3\t .netrc',
2561 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002562 sys.stdout.seek(0)
2563 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002564 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2565 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2566 ' Host\tUser\t Which file',
2567 '============================\t====\t===========',
2568 'host-review.googlesource.com\tuser\t.gitcookies',
2569 ' host.googlesource.com\tuser\t.gitcookies',
2570 ])
2571
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002572 def _common_creds_check_mocks(self):
2573 def exists_mock(path):
2574 dirname = os.path.dirname(path)
2575 if dirname == os.path.expanduser('~'):
2576 dirname = '~'
2577 base = os.path.basename(path)
2578 if base in ('.netrc', '.gitcookies'):
2579 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2580 # git cl also checks for existence other files not relevant to this test.
2581 return None
Edward Lemurda4b6c62020-02-13 00:28:40 +00002582 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002583
2584 def test_creds_check_gitcookies_not_configured(self):
2585 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002586 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2587 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002588 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002589 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002590 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2591 (('os.path.exists', '~/.netrc'), True),
2592 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2593 'or Ctrl+C to abort'), ''),
2594 ((['git', 'config', '--global', 'http.cookiefile',
2595 os.path.expanduser('~/.gitcookies')], ), ''),
2596 ]
2597 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002598 self.assertTrue(
2599 sys.stdout.getvalue().startswith(
2600 'You seem to be using outdated .netrc for git credentials:'))
2601 self.assertIn(
2602 '\nConfigured git to use .gitcookies from',
2603 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002604
2605 def test_creds_check_gitcookies_configured_custom_broken(self):
2606 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002607 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2608 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002609 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002610 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002611 ((['git', 'config', '--global', 'http.cookiefile'],),
2612 '/custom/.gitcookies'),
2613 (('os.path.exists', '/custom/.gitcookies'), False),
2614 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2615 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2616 ((['git', 'config', '--global', 'http.cookiefile',
2617 os.path.expanduser('~/.gitcookies')], ), ''),
2618 ]
2619 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002620 self.assertIn(
2621 'WARNING: You have configured custom path to .gitcookies: ',
2622 sys.stdout.getvalue())
2623 self.assertIn(
2624 'However, your configured .gitcookies file is missing.',
2625 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002626
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002627 def test_git_cl_comment_add_gerrit(self):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002628 self.calls = [
2629 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2630 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002631 ((['git', 'config', 'remote.origin.url'],),
2632 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002633 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002634 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002635 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002636 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002637 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002638
Edward Lemurda4b6c62020-02-13 00:28:40 +00002639 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2640 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002641 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002642 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002643 ((['git', 'config', 'remote.origin.url'],),
2644 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002645 (('GetChangeDetail', 'chromium-review.googlesource.com',
2646 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002647 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2648 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002649 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002650 'current_revision': 'ba5eba11',
2651 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002652 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002653 '_number': 1,
2654 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002655 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002656 '_number': 2,
2657 },
2658 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002659 'messages': [
2660 {
2661 u'_revision_number': 1,
2662 u'author': {
2663 u'_account_id': 1111084,
2664 u'email': u'commit-bot@chromium.org',
2665 u'name': u'Commit Bot'
2666 },
2667 u'date': u'2017-03-15 20:08:45.000000000',
2668 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002669 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002670 u'tag': u'autogenerated:cq:dry-run'
2671 },
2672 {
2673 u'_revision_number': 2,
2674 u'author': {
2675 u'_account_id': 11151243,
2676 u'email': u'owner@example.com',
2677 u'name': u'owner'
2678 },
2679 u'date': u'2017-03-16 20:00:41.000000000',
2680 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2681 u'message': u'PTAL',
2682 },
2683 {
2684 u'_revision_number': 2,
2685 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002686 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002687 u'email': u'reviewer@example.com',
2688 u'name': u'reviewer'
2689 },
2690 u'date': u'2017-03-17 05:19:37.500000000',
2691 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2692 u'message': u'Patch Set 2: Code-Review+1',
2693 },
2694 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002695 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002696 (('GetChangeComments', 'chromium-review.googlesource.com',
2697 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002698 '/COMMIT_MSG': [
2699 {
2700 'author': {'email': u'reviewer@example.com'},
2701 'updated': u'2017-03-17 05:19:37.500000000',
2702 'patch_set': 2,
2703 'side': 'REVISION',
2704 'message': 'Please include a bug link',
2705 },
2706 ],
2707 'codereview.settings': [
2708 {
2709 'author': {'email': u'owner@example.com'},
2710 'updated': u'2017-03-16 20:00:41.000000000',
2711 'patch_set': 2,
2712 'side': 'PARENT',
2713 'line': 42,
2714 'message': 'I removed this because it is bad',
2715 },
2716 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002717 }),
2718 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2719 'infra%2Finfra~1'), {}),
2720 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002721 ] * 2 + [
2722 (('write_json', 'output.json', [
2723 {
2724 u'date': u'2017-03-16 20:00:41.000000',
2725 u'message': (
2726 u'PTAL\n' +
2727 u'\n' +
2728 u'codereview.settings\n' +
2729 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2730 u'c/1/2/codereview.settings#b42\n' +
2731 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002732 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002733 u'approval': False,
2734 u'disapproval': False,
2735 u'sender': u'owner@example.com'
2736 }, {
2737 u'date': u'2017-03-17 05:19:37.500000',
2738 u'message': (
2739 u'Patch Set 2: Code-Review+1\n' +
2740 u'\n' +
2741 u'/COMMIT_MSG\n' +
2742 u' PS2, File comment: https://chromium-review.googlesource' +
2743 u'.com/c/1/2//COMMIT_MSG#\n' +
2744 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002745 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002746 u'approval': False,
2747 u'disapproval': False,
2748 u'sender': u'reviewer@example.com'
2749 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002750 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002751 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002752 expected_comments_summary = [
2753 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002754 message=(
2755 u'PTAL\n' +
2756 u'\n' +
2757 u'codereview.settings\n' +
2758 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2759 u'c/1/2/codereview.settings#b42\n' +
2760 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002761 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002762 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002763 disapproval=False, approval=False, sender=u'owner@example.com'),
2764 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002765 message=(
2766 u'Patch Set 2: Code-Review+1\n' +
2767 u'\n' +
2768 u'/COMMIT_MSG\n' +
2769 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2770 u'c/1/2//COMMIT_MSG#\n' +
2771 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002772 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002773 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002774 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2775 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002776 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002777 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002778 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002779 self.assertEqual(
2780 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2781
2782 def test_git_cl_comments_robot_comments(self):
2783 # git cl comments also fetches robot comments (which are considered a type
2784 # of autogenerated comment), and unlike other types of comments, only robot
2785 # comments from the latest patchset are shown.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002786 self.calls = [
2787 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002788 ((['git', 'config', 'remote.origin.url'],),
2789 'https://chromium.googlesource.com/infra/infra'),
2790 (('GetChangeDetail', 'chromium-review.googlesource.com',
2791 'infra%2Finfra~1',
2792 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2793 'CURRENT_COMMIT']), {
2794 'owner': {'email': 'owner@example.com'},
2795 'current_revision': 'ba5eba11',
2796 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002797 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002798 '_number': 1,
2799 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002800 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002801 '_number': 2,
2802 },
2803 },
2804 'messages': [
2805 {
2806 u'_revision_number': 1,
2807 u'author': {
2808 u'_account_id': 1111084,
2809 u'email': u'commit-bot@chromium.org',
2810 u'name': u'Commit Bot'
2811 },
2812 u'date': u'2017-03-15 20:08:45.000000000',
2813 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2814 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2815 u'tag': u'autogenerated:cq:dry-run'
2816 },
2817 {
2818 u'_revision_number': 1,
2819 u'author': {
2820 u'_account_id': 123,
2821 u'email': u'tricium@serviceaccount.com',
2822 u'name': u'Tricium'
2823 },
2824 u'date': u'2017-03-16 20:00:41.000000000',
2825 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2826 u'message': u'(1 comment)',
2827 u'tag': u'autogenerated:tricium',
2828 },
2829 {
2830 u'_revision_number': 1,
2831 u'author': {
2832 u'_account_id': 123,
2833 u'email': u'tricium@serviceaccount.com',
2834 u'name': u'Tricium'
2835 },
2836 u'date': u'2017-03-16 20:00:41.000000000',
2837 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2838 u'message': u'(1 comment)',
2839 u'tag': u'autogenerated:tricium',
2840 },
2841 {
2842 u'_revision_number': 2,
2843 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002844 u'_account_id': 123,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002845 u'email': u'tricium@serviceaccount.com',
2846 u'name': u'reviewer'
2847 },
2848 u'date': u'2017-03-17 05:30:37.000000000',
2849 u'tag': u'autogenerated:tricium',
2850 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2851 u'message': u'(1 comment)',
2852 },
2853 ]
2854 }),
2855 (('GetChangeComments', 'chromium-review.googlesource.com',
2856 'infra%2Finfra~1'), {}),
2857 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2858 'infra%2Finfra~1'), {
2859 'codereview.settings': [
2860 {
2861 u'author': {u'email': u'tricium@serviceaccount.com'},
2862 u'updated': u'2017-03-17 05:30:37.000000000',
2863 u'robot_run_id': u'5565031076855808',
2864 u'robot_id': u'Linter/Category',
2865 u'tag': u'autogenerated:tricium',
2866 u'patch_set': 2,
2867 u'side': u'REVISION',
2868 u'message': u'Linter warning message text',
2869 u'line': 32,
2870 },
2871 ],
2872 }),
2873 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
2874 ]
2875 expected_comments_summary = [
2876 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2877 message=(
2878 u'(1 comment)\n\ncodereview.settings\n'
2879 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2880 u'c/1/2/codereview.settings#32\n'
2881 u' Linter warning message text\n'),
2882 sender=u'tricium@serviceaccount.com',
2883 autogenerated=True, approval=False, disapproval=False)
2884 ]
2885 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002886 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002887 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002888
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002889 def test_get_remote_url_with_mirror(self):
2890 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002891
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002892 def selective_os_path_isdir_mock(path):
2893 if path == '/cache/this-dir-exists':
2894 return self._mocked_call('os.path.isdir', path)
2895 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002896
Edward Lemurda4b6c62020-02-13 00:28:40 +00002897 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002898
2899 url = 'https://chromium.googlesource.com/my/repo'
2900 self.calls = [
2901 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002902 ((['git', 'config', 'remote.origin.url'],),
2903 '/cache/this-dir-exists'),
2904 (('os.path.isdir', '/cache/this-dir-exists'),
2905 True),
2906 # Runs in /cache/this-dir-exists.
2907 ((['git', 'config', 'remote.origin.url'],),
2908 url),
2909 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002910 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002911 self.assertEqual(cl.GetRemoteUrl(), url)
2912 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2913
Edward Lemur298f2cf2019-02-22 21:40:39 +00002914 def test_get_remote_url_non_existing_mirror(self):
2915 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002916
Edward Lemur298f2cf2019-02-22 21:40:39 +00002917 def selective_os_path_isdir_mock(path):
2918 if path == '/cache/this-dir-doesnt-exist':
2919 return self._mocked_call('os.path.isdir', path)
2920 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002921
Edward Lemurda4b6c62020-02-13 00:28:40 +00002922 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2923 mock.patch('logging.error',
2924 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002925
2926 self.calls = [
2927 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002928 ((['git', 'config', 'remote.origin.url'],),
2929 '/cache/this-dir-doesnt-exist'),
2930 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2931 False),
2932 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002933 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2934 'but it doesn\'t exist.', {
2935 'remote': 'origin',
2936 'branch': 'master',
2937 'url': '/cache/this-dir-doesnt-exist'}
2938 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002939 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002940 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002941 self.assertIsNone(cl.GetRemoteUrl())
2942
2943 def test_get_remote_url_misconfigured_mirror(self):
2944 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002945
Edward Lemur298f2cf2019-02-22 21:40:39 +00002946 def selective_os_path_isdir_mock(path):
2947 if path == '/cache/this-dir-exists':
2948 return self._mocked_call('os.path.isdir', path)
2949 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002950
Edward Lemurda4b6c62020-02-13 00:28:40 +00002951 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2952 mock.patch('logging.error',
2953 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002954
2955 self.calls = [
2956 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002957 ((['git', 'config', 'remote.origin.url'],),
2958 '/cache/this-dir-exists'),
2959 (('os.path.isdir', '/cache/this-dir-exists'), True),
2960 # Runs in /cache/this-dir-exists.
2961 ((['git', 'config', 'remote.origin.url'],), ''),
2962 (('logging.error',
2963 'Remote "%(remote)s" for branch "%(branch)s" points to '
2964 '"%(cache_path)s", but it is misconfigured.\n'
2965 '"%(cache_path)s" must be a git repo and must have a remote named '
2966 '"%(remote)s" pointing to the git host.', {
2967 'remote': 'origin',
2968 'cache_path': '/cache/this-dir-exists',
2969 'branch': 'master'}
2970 ), None),
2971 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002972 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002973 self.assertIsNone(cl.GetRemoteUrl())
2974
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002975 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002976 self.calls = [
2977 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002978 ((['git', 'config', 'remote.origin.url'],),
2979 'https://chromium.googlesource.com/a/my/repo.git/'),
2980 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002981 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002982 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2983
2984 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002985 mock.patch('logging.error',
2986 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002987
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002988 self.calls = [
2989 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002990 ((['git', 'config', 'remote.origin.url'],), CERR1),
Josip906bfde2020-01-31 22:38:49 +00002991 (('logging.error',
2992 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2993 'but it doesn\'t exist.', {
2994 'remote': 'origin',
2995 'branch': 'master',
2996 'url': ''}
2997 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002998 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002999 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003000 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003001
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003002
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003003class CMDTestCaseBase(unittest.TestCase):
3004 _STATUSES = [
3005 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3006 'INFRA_FAILURE', 'CANCELED',
3007 ]
3008 _CHANGE_DETAIL = {
3009 'project': 'depot_tools',
3010 'status': 'OPEN',
3011 'owner': {'email': 'owner@e.mail'},
3012 'current_revision': 'beeeeeef',
3013 'revisions': {
3014 'deadbeaf': {'_number': 6},
3015 'beeeeeef': {
3016 '_number': 7,
3017 'fetch': {'http': {
3018 'url': 'https://chromium.googlesource.com/depot_tools',
3019 'ref': 'refs/changes/56/123456/7'
3020 }},
3021 },
3022 },
3023 }
3024 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003025 'builds': [{
3026 'id': str(100 + idx),
3027 'builder': {
3028 'project': 'chromium',
3029 'bucket': 'try',
3030 'builder': 'bot_' + status.lower(),
3031 },
3032 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3033 'tags': [],
3034 'status': status,
3035 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003036 }
3037
Edward Lemur4c707a22019-09-24 21:13:43 +00003038 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003039 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003040 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003041 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3042 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003043 mock.patch('git_cl.Changelist.GetCodereviewServer',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003044 return_value='https://chromium-review.googlesource.com').start()
3045 mock.patch('git_cl.Changelist.GetMostRecentPatchset',
3046 return_value=7).start()
Edward Lemur5b929a42019-10-21 17:57:39 +00003047 mock.patch('git_cl.auth.Authenticator',
Edward Lemurb4a587d2019-10-09 23:56:38 +00003048 return_value=AuthenticatorMock()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003049 mock.patch('git_cl.Changelist._GetChangeDetail',
3050 return_value=self._CHANGE_DETAIL).start()
3051 mock.patch('git_cl._call_buildbucket',
3052 return_value = self._DEFAULT_RESPONSE).start()
3053 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003054 self.addCleanup(mock.patch.stopall)
3055
Edward Lemur4c707a22019-09-24 21:13:43 +00003056
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003057class CMDTryResultsTestCase(CMDTestCaseBase):
3058 _DEFAULT_REQUEST = {
3059 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003060 "gerritChanges": [{
3061 "project": "depot_tools",
3062 "host": "chromium-review.googlesource.com",
3063 "patchset": 7,
3064 "change": 123456,
3065 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003066 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003067 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3068 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003069 }
3070
3071 def testNoJobs(self):
3072 git_cl._call_buildbucket.return_value = {}
3073
3074 self.assertEqual(0, git_cl.main(['try-results']))
3075 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3076 git_cl._call_buildbucket.assert_called_once_with(
3077 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3078 self._DEFAULT_REQUEST)
3079
3080 def testPrintToStdout(self):
3081 self.assertEqual(0, git_cl.main(['try-results']))
3082 self.assertEqual([
3083 'Successes:',
3084 ' bot_success https://ci.chromium.org/b/103',
3085 'Infra Failures:',
3086 ' bot_infra_failure https://ci.chromium.org/b/105',
3087 'Failures:',
3088 ' bot_failure https://ci.chromium.org/b/104',
3089 'Canceled:',
3090 ' bot_canceled ',
3091 'Started:',
3092 ' bot_started https://ci.chromium.org/b/102',
3093 'Scheduled:',
3094 ' bot_scheduled id=101',
3095 'Other:',
3096 ' bot_status_unspecified id=100',
3097 'Total: 7 tryjobs',
3098 ], sys.stdout.getvalue().splitlines())
3099 git_cl._call_buildbucket.assert_called_once_with(
3100 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3101 self._DEFAULT_REQUEST)
3102
3103 def testPrintToStdoutWithMasters(self):
3104 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3105 self.assertEqual([
3106 'Successes:',
3107 ' try bot_success https://ci.chromium.org/b/103',
3108 'Infra Failures:',
3109 ' try bot_infra_failure https://ci.chromium.org/b/105',
3110 'Failures:',
3111 ' try bot_failure https://ci.chromium.org/b/104',
3112 'Canceled:',
3113 ' try bot_canceled ',
3114 'Started:',
3115 ' try bot_started https://ci.chromium.org/b/102',
3116 'Scheduled:',
3117 ' try bot_scheduled id=101',
3118 'Other:',
3119 ' try bot_status_unspecified id=100',
3120 'Total: 7 tryjobs',
3121 ], sys.stdout.getvalue().splitlines())
3122 git_cl._call_buildbucket.assert_called_once_with(
3123 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3124 self._DEFAULT_REQUEST)
3125
3126 @mock.patch('git_cl.write_json')
3127 def testWriteToJson(self, mockJsonDump):
3128 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3129 git_cl._call_buildbucket.assert_called_once_with(
3130 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3131 self._DEFAULT_REQUEST)
3132 mockJsonDump.assert_called_once_with(
3133 'file.json', self._DEFAULT_RESPONSE['builds'])
3134
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003135 def test_filter_failed_for_one_simple(self):
3136 self.assertEqual({}, git_cl._filter_failed_for_retry([]))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003137 self.assertEqual({
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003138 'chromium/try': {
3139 'bot_failure': [],
3140 'bot_infra_failure': []
3141 },
3142 }, git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
3143
3144 def test_filter_failed_for_retry_many_builds(self):
3145
3146 def _build(name, created_sec, status, experimental=False):
3147 assert 0 <= created_sec < 100, created_sec
3148 b = {
3149 'id': 112112,
3150 'builder': {
3151 'project': 'chromium',
3152 'bucket': 'try',
3153 'builder': name,
3154 },
3155 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3156 'status': status,
3157 'tags': [],
3158 }
3159 if experimental:
3160 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3161 return b
3162
3163 builds = [
3164 _build('flaky-last-green', 1, 'FAILURE'),
3165 _build('flaky-last-green', 2, 'SUCCESS'),
3166 _build('flaky', 1, 'SUCCESS'),
3167 _build('flaky', 2, 'FAILURE'),
3168 _build('running', 1, 'FAILED'),
3169 _build('running', 2, 'SCHEDULED'),
3170 _build('yep-still-running', 1, 'STARTED'),
3171 _build('yep-still-running', 2, 'FAILURE'),
3172 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3173 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3174
3175 # Simulate experimental in CQ builder, which developer decided
3176 # to retry manually which resulted in 2nd build non-experimental.
3177 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3178 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3179 ]
3180 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
3181 self.assertEqual({
3182 'chromium/try': {
3183 'flaky': [],
3184 'sometimes-experimental': []
3185 },
3186 }, git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003187
3188
3189class CMDTryTestCase(CMDTestCaseBase):
3190
3191 @mock.patch('git_cl.Changelist.SetCQState')
3192 @mock.patch('git_cl._get_bucket_map', return_value={})
3193 def testSetCQDryRunByDefault(self, _mockGetBucketMap, mockSetCQState):
3194 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003195 self.assertEqual(0, git_cl.main(['try']))
3196 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3197 self.assertEqual(
3198 sys.stdout.getvalue(),
3199 'Scheduling CQ dry run on: '
3200 'https://chromium-review.googlesource.com/123456\n')
3201
Edward Lemur4c707a22019-09-24 21:13:43 +00003202 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003203 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003204 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003205
3206 self.assertEqual(0, git_cl.main([
3207 'try', '-B', 'luci.chromium.try', '-b', 'win',
3208 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3209 self.assertIn(
3210 'Scheduling jobs on:\nBucket: luci.chromium.try',
3211 git_cl.sys.stdout.getvalue())
3212
3213 expected_request = {
3214 "requests": [{
3215 "scheduleBuild": {
3216 "requestId": "uuid4",
3217 "builder": {
3218 "project": "chromium",
3219 "builder": "win",
3220 "bucket": "try",
3221 },
3222 "gerritChanges": [{
3223 "project": "depot_tools",
3224 "host": "chromium-review.googlesource.com",
3225 "patchset": 7,
3226 "change": 123456,
3227 }],
3228 "properties": {
3229 "category": "git_cl_try",
3230 "json": [{"a": 1}, None],
3231 "key": "val",
3232 },
3233 "tags": [
3234 {"value": "win", "key": "builder"},
3235 {"value": "git_cl_try", "key": "user_agent"},
3236 ],
3237 },
3238 }],
3239 }
3240 mockCallBuildbucket.assert_called_with(
3241 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3242
Anthony Polito1a5fe232020-01-24 23:17:52 +00003243 @mock.patch('git_cl._call_buildbucket')
3244 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3245 mockCallBuildbucket.return_value = {}
3246
3247 self.assertEqual(0, git_cl.main([
3248 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3249 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3250 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3251 self.assertIn(
3252 'Scheduling jobs on:\nBucket: luci.chromium.try',
3253 git_cl.sys.stdout.getvalue())
3254
3255 expected_request = {
3256 "requests": [{
3257 "scheduleBuild": {
3258 "requestId": "uuid4",
3259 "builder": {
3260 "project": "chromium",
3261 "builder": "linux",
3262 "bucket": "try",
3263 },
3264 "gerritChanges": [{
3265 "project": "depot_tools",
3266 "host": "chromium-review.googlesource.com",
3267 "patchset": 7,
3268 "change": 123456,
3269 }],
3270 "properties": {
3271 "category": "git_cl_try",
3272 "json": [{"a": 1}, None],
3273 "key": "val",
3274 },
3275 "tags": [
3276 {"value": "linux", "key": "builder"},
3277 {"value": "git_cl_try", "key": "user_agent"},
3278 ],
3279 "gitilesCommit": {
3280 "host": "chromium-review.googlesource.com",
3281 "project": "depot_tools",
3282 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3283 }
3284 },
3285 },
3286 {
3287 "scheduleBuild": {
3288 "requestId": "uuid4",
3289 "builder": {
3290 "project": "chromium",
3291 "builder": "win",
3292 "bucket": "try",
3293 },
3294 "gerritChanges": [{
3295 "project": "depot_tools",
3296 "host": "chromium-review.googlesource.com",
3297 "patchset": 7,
3298 "change": 123456,
3299 }],
3300 "properties": {
3301 "category": "git_cl_try",
3302 "json": [{"a": 1}, None],
3303 "key": "val",
3304 },
3305 "tags": [
3306 {"value": "win", "key": "builder"},
3307 {"value": "git_cl_try", "key": "user_agent"},
3308 ],
3309 "gitilesCommit": {
3310 "host": "chromium-review.googlesource.com",
3311 "project": "depot_tools",
3312 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3313 }
3314 },
3315 }],
3316 }
3317 mockCallBuildbucket.assert_called_with(
3318 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3319
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003320 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur4c707a22019-09-24 21:13:43 +00003321 self.assertEqual(0, git_cl.main([
3322 'try', '-B', 'not-a-bucket', '-b', 'win',
3323 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3324 self.assertIn(
3325 'WARNING Could not parse bucket "not-a-bucket". Skipping.',
3326 git_cl.sys.stdout.getvalue())
3327
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003328 @mock.patch('git_cl._call_buildbucket')
3329 @mock.patch('git_cl.fetch_try_jobs')
3330 def testScheduleOnBuildbucketRetryFailed(
3331 self, mockFetchTryJobs, mockCallBuildbucket):
3332
3333 git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: {
3334 7: [],
3335 6: [{
3336 'id': 112112,
3337 'builder': {
3338 'project': 'chromium',
3339 'bucket': 'try',
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003340 'builder': 'linux',},
3341 'createTime': '2019-10-09T08:00:01.854286Z',
3342 'tags': [],
3343 'status': 'FAILURE',}],}[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003344 mockCallBuildbucket.return_value = {}
3345
3346 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3347 self.assertIn(
3348 'Scheduling jobs on:\nBucket: chromium/try',
3349 git_cl.sys.stdout.getvalue())
3350
3351 expected_request = {
3352 "requests": [{
3353 "scheduleBuild": {
3354 "requestId": "uuid4",
3355 "builder": {
3356 "project": "chromium",
3357 "bucket": "try",
3358 "builder": "linux",
3359 },
3360 "gerritChanges": [{
3361 "project": "depot_tools",
3362 "host": "chromium-review.googlesource.com",
3363 "patchset": 7,
3364 "change": 123456,
3365 }],
3366 "properties": {
3367 "category": "git_cl_try",
3368 },
3369 "tags": [
3370 {"value": "linux", "key": "builder"},
3371 {"value": "git_cl_try", "key": "user_agent"},
3372 {"value": "1", "key": "retry_failed"},
3373 ],
3374 },
3375 }],
3376 }
3377 mockCallBuildbucket.assert_called_with(
3378 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3379
Edward Lemur4c707a22019-09-24 21:13:43 +00003380 def test_parse_bucket(self):
3381 test_cases = [
3382 {
3383 'bucket': 'chromium/try',
3384 'result': ('chromium', 'try'),
3385 },
3386 {
3387 'bucket': 'luci.chromium.try',
3388 'result': ('chromium', 'try'),
3389 'has_warning': True,
3390 },
3391 {
3392 'bucket': 'skia.primary',
3393 'result': ('skia', 'skia.primary'),
3394 'has_warning': True,
3395 },
3396 {
3397 'bucket': 'not-a-bucket',
3398 'result': (None, None),
3399 },
3400 ]
3401
3402 for test_case in test_cases:
3403 git_cl.sys.stdout.truncate(0)
3404 self.assertEqual(
3405 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3406 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003407 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3408 test_case['result'])
3409 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003410
3411
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003412class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003413 def setUp(self):
3414 super(CMDUploadTestCase, self).setUp()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003415 mock.patch('git_cl.fetch_try_jobs').start()
3416 mock.patch('git_cl._trigger_try_jobs', return_value={}).start()
3417 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Anthony Polito46689b02019-11-15 20:56:41 +00003418 mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003419 self.addCleanup(mock.patch.stopall)
3420
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003421 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003422 # This test mocks out the actual upload part, and just asserts that after
3423 # upload, if --retry-failed is added, then the tool will fetch try jobs
3424 # from the previous patchset and trigger the right builders on the latest
3425 # patchset.
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003426 git_cl.fetch_try_jobs.side_effect = [
3427 # Latest patchset: No builds.
3428 [],
3429 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003430 [{
3431 'id': str(100 + idx),
3432 'builder': {
3433 'project': 'chromium',
3434 'bucket': 'try',
3435 'builder': 'bot_' + status.lower(),
3436 },
3437 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3438 'tags': [],
3439 'status': status,
3440 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003441 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003442
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003443 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003444 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003445 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3446 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003447 ], git_cl.fetch_try_jobs.mock_calls)
3448 expected_buckets = {
3449 'chromium/try': {'bot_failure': [], 'bot_infra_failure': []},
3450 }
3451 git_cl._trigger_try_jobs.assert_called_once_with(
Edward Lemur5b929a42019-10-21 17:57:39 +00003452 mock.ANY, expected_buckets, mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003453
Brian Sheedy59b06a82019-10-14 17:03:29 +00003454
Edward Lemurda4b6c62020-02-13 00:28:40 +00003455class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003456
3457 def setUp(self):
3458 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003459 mock.patch('git_cl.RunCommand').start()
3460 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3461 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3462 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003463 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003464 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003465
3466 def tearDown(self):
3467 shutil.rmtree(self._top_dir)
3468 super(CMDFormatTestCase, self).tearDown()
3469
Jamie Madill5e96ad12020-01-13 16:08:35 +00003470 def _make_temp_file(self, fname, contents):
3471 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3472 tf.write('\n'.join(contents))
3473
Brian Sheedy59b06a82019-10-14 17:03:29 +00003474 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003475 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003476
Brian Sheedyb4307d52019-12-02 19:18:17 +00003477 def _check_yapf_filtering(self, files, expected):
3478 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3479 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003480
Jamie Madill5e96ad12020-01-13 16:08:35 +00003481 def testClangFormatDiffFull(self):
3482 self._make_temp_file('test.cc', ['// test'])
3483 git_cl.settings.GetFormatFullByDefault.return_value = False
3484 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3485 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3486
3487 # Diff
3488 git_cl.RunCommand.return_value = ' // test'
3489 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3490 self._top_dir, 'HEAD')
3491 self.assertEqual(2, return_value)
3492
3493 # No diff
3494 git_cl.RunCommand.return_value = '// test'
3495 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3496 self._top_dir, 'HEAD')
3497 self.assertEqual(0, return_value)
3498
3499 def testClangFormatDiff(self):
3500 git_cl.settings.GetFormatFullByDefault.return_value = False
3501 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3502
3503 # Diff
3504 git_cl.RunCommand.return_value = 'error'
3505 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3506 'HEAD')
3507 self.assertEqual(2, return_value)
3508
3509 # No diff
3510 git_cl.RunCommand.return_value = ''
3511 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3512 'HEAD')
3513 self.assertEqual(0, return_value)
3514
Brian Sheedyb4307d52019-12-02 19:18:17 +00003515 def testYapfignoreExplicit(self):
3516 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3517 files = [
3518 'bar.py',
3519 'foo/bar.py',
3520 'foo/baz.py',
3521 'foo/bar/baz.py',
3522 'foo/bar/foobar.py',
3523 ]
3524 expected = [
3525 'bar.py',
3526 'foo/baz.py',
3527 'foo/bar/foobar.py',
3528 ]
3529 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003530
Brian Sheedyb4307d52019-12-02 19:18:17 +00003531 def testYapfignoreSingleWildcards(self):
3532 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3533 files = [
3534 'bar.py', # Matched by *bar.py.
3535 'bar.txt',
3536 'foobar.py', # Matched by *bar.py, foo*.
3537 'foobar.txt', # Matched by foo*.
3538 'bazbar.py', # Matched by *bar.py, baz*.py.
3539 'bazbar.txt',
3540 'foo/baz.txt', # Matched by foo*.
3541 'bar/bar.py', # Matched by *bar.py.
3542 'baz/foo.py', # Matched by baz*.py, foo*.
3543 'baz/foo.txt',
3544 ]
3545 expected = [
3546 'bar.txt',
3547 'bazbar.txt',
3548 'baz/foo.txt',
3549 ]
3550 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003551
Brian Sheedyb4307d52019-12-02 19:18:17 +00003552 def testYapfignoreMultiplewildcards(self):
3553 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3554 files = [
3555 'bar.py', # Matched by *bar*.
3556 'bar.txt', # Matched by *bar*.
3557 'abar.py', # Matched by *bar*.
3558 'foobaz.txt', # Matched by *foo*baz.txt.
3559 'foobaz.py',
3560 'afoobaz.txt', # Matched by *foo*baz.txt.
3561 ]
3562 expected = [
3563 'foobaz.py',
3564 ]
3565 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003566
3567 def testYapfignoreComments(self):
3568 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003569 files = [
3570 'test.py',
3571 'test2.py',
3572 ]
3573 expected = [
3574 'test2.py',
3575 ]
3576 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003577
3578 def testYapfignoreBlankLines(self):
3579 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003580 files = [
3581 'test.py',
3582 'test2.py',
3583 'test3.py',
3584 ]
3585 expected = [
3586 'test3.py',
3587 ]
3588 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003589
3590 def testYapfignoreWhitespace(self):
3591 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003592 files = [
3593 'test.py',
3594 'test2.py',
3595 ]
3596 expected = [
3597 'test2.py',
3598 ]
3599 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003600
Brian Sheedyb4307d52019-12-02 19:18:17 +00003601 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003602 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003603 self._check_yapf_filtering([], [])
3604
3605 def testYapfignoreMissingYapfignore(self):
3606 files = [
3607 'test.py',
3608 ]
3609 expected = [
3610 'test.py',
3611 ]
3612 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003613
3614
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003615if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003616 logging.basicConfig(
3617 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003618 unittest.main()