blob: 746fc0ec8336f82fc576cd4aabc7f10134db2ad9 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur0db01f02019-11-12 22:01:51 +00009from __future__ import unicode_literals
10
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010011import datetime
tandriide281ae2016-10-12 06:02:30 -070012import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010013import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import os
Brian Sheedy59b06a82019-10-14 17:03:29 +000015import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070017import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018import unittest
19
Edward Lemura8145022020-01-06 18:47:54 +000020if sys.version_info.major == 2:
21 from StringIO import StringIO
22 import mock
23else:
24 from io import StringIO
25 from unittest import mock
26
maruel@chromium.orgddd59412011-11-30 14:20:38 +000027sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
28
29from testing_support.auto_stub import TestCase
30
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000031import metrics
32# We have to disable monitoring before importing git_cl.
33metrics.DISABLE_METRICS_COLLECTION = True
34
Jamie Madill5e96ad12020-01-13 16:08:35 +000035import clang_format
Eric Boren2fb63102018-10-05 13:05:03 +000036import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000037import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000038import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000039import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000040import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000041
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000042
Edward Lemur0db01f02019-11-12 22:01:51 +000043def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070044 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
45
46
Edward Lemur4c707a22019-09-24 21:13:43 +000047def _constantFn(return_value):
48 def f(*args, **kwargs):
49 return return_value
50 return f
51
52
tandrii5d48c322016-08-18 16:19:37 -070053CERR1 = callError(1)
54
55
Edward Lemur0db01f02019-11-12 22:01:51 +000056def MakeNamedTemporaryFileMock(test, expected_content):
Aaron Gable9a03ae02017-11-03 11:31:07 -070057 class NamedTemporaryFileMock(object):
58 def __init__(self, *args, **kwargs):
59 self.name = '/tmp/named'
Edward Lemur0db01f02019-11-12 22:01:51 +000060 self.expected_content = expected_content.encode('utf-8', 'replace')
Aaron Gable9a03ae02017-11-03 11:31:07 -070061
62 def __enter__(self):
63 return self
64
65 def __exit__(self, _type, _value, _tb):
66 pass
67
68 def write(self, content):
69 if self.expected_content:
Edward Lemur0db01f02019-11-12 22:01:51 +000070 test.assertEqual(self.expected_content, content)
Aaron Gable9a03ae02017-11-03 11:31:07 -070071
72 def close(self):
73 pass
74
75 return NamedTemporaryFileMock
76
77
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000078class ChangelistMock(object):
79 # A class variable so we can access it when we don't have access to the
80 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000081 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000082 def __init__(self, **kwargs):
83 pass
84 def GetIssue(self):
85 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080086 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000087 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070088 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000089 ChangelistMock.desc = desc
90
tandrii5d48c322016-08-18 16:19:37 -070091
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000092class PresubmitMock(object):
93 def __init__(self, *args, **kwargs):
94 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080095 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
96
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000097 @staticmethod
98 def should_continue():
99 return True
100
101
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000102class WatchlistsMock(object):
103 def __init__(self, _):
104 pass
105 @staticmethod
106 def GetWatchersForPaths(_):
107 return ['joe@example.com']
108
109
Edward Lemur4c707a22019-09-24 21:13:43 +0000110class CodereviewSettingsFileMock(object):
111 def __init__(self):
112 pass
113 # pylint: disable=no-self-use
114 def read(self):
115 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
116 'GERRIT_HOST: True\n')
117
118
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000119class AuthenticatorMock(object):
120 def __init__(self, *_args):
121 pass
122 def has_cached_credentials(self):
123 return True
tandrii221ab252016-10-06 08:12:04 -0700124 def authorize(self, http):
125 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000126
127
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100128def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000129 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
130
131 Usage:
132 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100133 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000134
135 OR
136 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100137 CookiesAuthenticatorMockFactory(
138 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139 """
140 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800141 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000142 # Intentionally not calling super() because it reads actual cookie files.
143 pass
144 @classmethod
145 def get_gitcookies_path(cls):
146 return '~/.gitcookies'
147 @classmethod
148 def get_netrc_path(cls):
149 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100150 def _get_auth_for_host(self, host):
151 if same_auth:
152 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000153 return (hosts_with_creds or {}).get(host)
154 return CookiesAuthenticatorMock
155
Aaron Gable9a03ae02017-11-03 11:31:07 -0700156
kmarshall9249e012016-08-23 12:02:16 -0700157class MockChangelistWithBranchAndIssue():
158 def __init__(self, branch, issue):
159 self.branch = branch
160 self.issue = issue
161 def GetBranch(self):
162 return self.branch
163 def GetIssue(self):
164 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000165
tandriic2405f52016-10-10 08:13:15 -0700166
167class SystemExitMock(Exception):
168 pass
169
170
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000171class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100172 def test_get_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000173 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100174 cl.description = 'x'
175 cl.has_description = True
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000176 self.assertEqual(cl.GetDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700177
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000178 def test_set_preserve_tryjobs(self):
179 d = git_cl.ChangeDescription('Simple.')
180 d.set_preserve_tryjobs()
181 self.assertEqual(d.description.splitlines(), [
182 'Simple.',
183 '',
184 'Cq-Do-Not-Cancel-Tryjobs: true',
185 ])
186 before = d.description
187 d.set_preserve_tryjobs()
188 self.assertEqual(before, d.description)
189
190 d = git_cl.ChangeDescription('\n'.join([
191 'One is enough',
192 '',
193 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
194 'Change-Id: Ideadbeef',
195 ]))
196 d.set_preserve_tryjobs()
197 self.assertEqual(d.description.splitlines(), [
198 'One is enough',
199 '',
200 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
201 'Change-Id: Ideadbeef',
202 'Cq-Do-Not-Cancel-Tryjobs: true',
203 ])
204
tandriif9aefb72016-07-01 09:06:51 -0700205 def test_get_bug_line_values(self):
206 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
207 self.assertEqual(f('', ''), [])
208 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
209 self.assertEqual(f('v8', '456'), ['v8:456'])
210 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
211 # Not nice, but not worth carying.
212 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
213 ['v8:456', 'chromium:123', 'v8:123'])
214
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100215 def _test_git_number(self, parent_msg, dest_ref, child_msg,
216 parent_hash='parenthash'):
217 desc = git_cl.ChangeDescription(child_msg)
218 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
219 return desc.description
220
221 def assertEqualByLine(self, actual, expected):
222 self.assertEqual(actual.splitlines(), expected.splitlines())
223
224 def test_git_number_bad_parent(self):
225 with self.assertRaises(ValueError):
226 self._test_git_number('Parent', 'refs/heads/master', 'Child')
227
228 def test_git_number_bad_parent_footer(self):
229 with self.assertRaises(AssertionError):
230 self._test_git_number(
231 'Parent\n'
232 '\n'
233 'Cr-Commit-Position: wrong',
234 'refs/heads/master', 'Child')
235
236 def test_git_number_bad_lineage_ignored(self):
237 actual = self._test_git_number(
238 'Parent\n'
239 '\n'
240 'Cr-Commit-Position: refs/heads/master@{#1}\n'
241 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
242 'refs/heads/master', 'Child')
243 self.assertEqualByLine(
244 actual,
245 'Child\n'
246 '\n'
247 'Cr-Commit-Position: refs/heads/master@{#2}\n'
248 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
249
250 def test_git_number_same_branch(self):
251 actual = self._test_git_number(
252 'Parent\n'
253 '\n'
254 'Cr-Commit-Position: refs/heads/master@{#12}',
255 dest_ref='refs/heads/master',
256 child_msg='Child')
257 self.assertEqualByLine(
258 actual,
259 'Child\n'
260 '\n'
261 'Cr-Commit-Position: refs/heads/master@{#13}')
262
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200263 def test_git_number_same_branch_mixed_footers(self):
264 actual = self._test_git_number(
265 'Parent\n'
266 '\n'
267 'Cr-Commit-Position: refs/heads/master@{#12}',
268 dest_ref='refs/heads/master',
269 child_msg='Child\n'
270 '\n'
271 'Broken-by: design\n'
272 'BUG=123')
273 self.assertEqualByLine(
274 actual,
275 'Child\n'
276 '\n'
277 'Broken-by: design\n'
278 'BUG=123\n'
279 'Cr-Commit-Position: refs/heads/master@{#13}')
280
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100281 def test_git_number_same_branch_with_originals(self):
282 actual = self._test_git_number(
283 'Parent\n'
284 '\n'
285 'Cr-Commit-Position: refs/heads/master@{#12}',
286 dest_ref='refs/heads/master',
287 child_msg='Child\n'
288 '\n'
289 'Some users are smart and insert their own footers\n'
290 '\n'
291 'Cr-Whatever: value\n'
292 'Cr-Commit-Position: refs/copy/paste@{#22}')
293 self.assertEqualByLine(
294 actual,
295 'Child\n'
296 '\n'
297 'Some users are smart and insert their own footers\n'
298 '\n'
299 'Cr-Original-Whatever: value\n'
300 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
301 'Cr-Commit-Position: refs/heads/master@{#13}')
302
303 def test_git_number_new_branch(self):
304 actual = self._test_git_number(
305 'Parent\n'
306 '\n'
307 'Cr-Commit-Position: refs/heads/master@{#12}',
308 dest_ref='refs/heads/branch',
309 child_msg='Child')
310 self.assertEqualByLine(
311 actual,
312 'Child\n'
313 '\n'
314 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
315 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
316
317 def test_git_number_lineage(self):
318 actual = self._test_git_number(
319 'Parent\n'
320 '\n'
321 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
322 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
323 dest_ref='refs/heads/branch',
324 child_msg='Child')
325 self.assertEqualByLine(
326 actual,
327 'Child\n'
328 '\n'
329 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
330 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
331
332 def test_git_number_moooooooore_lineage(self):
333 actual = self._test_git_number(
334 'Parent\n'
335 '\n'
336 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
337 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
338 dest_ref='refs/heads/mooore',
339 child_msg='Child')
340 self.assertEqualByLine(
341 actual,
342 'Child\n'
343 '\n'
344 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
345 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
346 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
347
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100348 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700349 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100350 actual = self._test_git_number(
351 'CQ commit on fresh new branch + numbering.\n'
352 '\n'
353 'NOTRY=True\n'
354 'NOPRESUBMIT=True\n'
355 'BUG=\n'
356 '\n'
357 'Review-Url: https://codereview.chromium.org/2577703003\n'
358 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
359 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
360 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
361 dest_ref='refs/heads/gnumb-test/cl',
362 child_msg='git cl on fresh new branch + numbering.\n'
363 '\n'
364 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
365 self.assertEqualByLine(
366 actual,
367 'git cl on fresh new branch + numbering.\n'
368 '\n'
369 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
370 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
371 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
372 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
373 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100374
375 def test_git_number_cherry_pick(self):
376 actual = self._test_git_number(
377 'Parent\n'
378 '\n'
379 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
380 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
381 dest_ref='refs/heads/branch',
382 child_msg='Child, which is cherry-pick from master\n'
383 '\n'
384 'Cr-Commit-Position: refs/heads/master@{#100}\n'
385 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
386 self.assertEqualByLine(
387 actual,
388 'Child, which is cherry-pick from master\n'
389 '\n'
390 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
391 '\n'
392 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
393 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
394 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
395
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000396 def test_valid_accounts(self):
397 mock_per_account = {
398 'u1': None, # 404, doesn't exist.
399 'u2': {
400 '_account_id': 123124,
401 'avatars': [],
402 'email': 'u2@example.com',
403 'name': 'User Number 2',
404 'status': 'OOO',
405 },
406 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
407 }
408 def GetAccountDetailsMock(_, account):
409 # Poor-man's mock library's side_effect.
410 v = mock_per_account.pop(account)
411 if isinstance(v, Exception):
412 raise v
413 return v
414
415 original = git_cl.gerrit_util.GetAccountDetails
416 try:
417 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
418 actual = git_cl.gerrit_util.ValidAccounts(
419 'host', ['u1', 'u2', 'u3'], max_threads=1)
420 finally:
421 git_cl.gerrit_util.GetAccountDetails = original
422 self.assertEqual(actual, {
423 'u2': {
424 '_account_id': 123124,
425 'avatars': [],
426 'email': 'u2@example.com',
427 'name': 'User Number 2',
428 'status': 'OOO',
429 },
430 })
431
432
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200433class TestParseIssueURL(unittest.TestCase):
434 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000435 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200436 self.assertIsNotNone(parsed)
437 if fail:
438 self.assertFalse(parsed.valid)
439 return
440 self.assertTrue(parsed.valid)
441 self.assertEqual(parsed.issue, issue)
442 self.assertEqual(parsed.patchset, patchset)
443 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200444
Edward Lemur678a6842019-10-03 22:25:05 +0000445 def test_ParseIssueNumberArgument(self):
446 def test(arg, *args, **kwargs):
447 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200448
Edward Lemur678a6842019-10-03 22:25:05 +0000449 test('123', 123)
450 test('', fail=True)
451 test('abc', fail=True)
452 test('123/1', fail=True)
453 test('123a', fail=True)
454 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200455
Edward Lemur678a6842019-10-03 22:25:05 +0000456 test('https://codereview.source.com/123',
457 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200458 test('http://chrome-review.source.com/c/123',
459 123, None, 'chrome-review.source.com')
460 test('https://chrome-review.source.com/c/123/',
461 123, None, 'chrome-review.source.com')
462 test('https://chrome-review.source.com/c/123/4',
463 123, 4, 'chrome-review.source.com')
464 test('https://chrome-review.source.com/#/c/123/4',
465 123, 4, 'chrome-review.source.com')
466 test('https://chrome-review.source.com/c/123/4',
467 123, 4, 'chrome-review.source.com')
468 test('https://chrome-review.source.com/123',
469 123, None, 'chrome-review.source.com')
470 test('https://chrome-review.source.com/123/4',
471 123, 4, 'chrome-review.source.com')
472
Edward Lemur678a6842019-10-03 22:25:05 +0000473 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200474 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
475 test('https://chrome-review.source.com/c/abc/', fail=True)
476 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
477
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200478
479
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100480class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100481 def setUp(self):
482 super(GitCookiesCheckerTest, self).setUp()
483 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100484 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100485
486 def mock_hosts_creds(self, subhost_identity_pairs):
487 def ensure_googlesource(h):
488 if not h.endswith(self.c._GOOGLESOURCE):
489 assert not h.endswith('.')
490 return h + '.' + self.c._GOOGLESOURCE
491 return h
492 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
493 for h, i in subhost_identity_pairs]
494
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200495 def test_identity_parsing(self):
496 self.assertEqual(self.c._parse_identity('ldap.google.com'),
497 ('ldap', 'google.com'))
498 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
499 ('ldap', 'example.com'))
500 # Specical case because we know there are no subdomains in chromium.org.
501 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
502 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800503 # Pathological: ".period." can be either username OR domain, more likely
504 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200505 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
506 ('note', 'period.example.com'))
507
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100508 def test_analysis_nothing(self):
509 self.c._all_hosts = []
510 self.assertFalse(self.c.has_generic_host())
511 self.assertEqual(set(), self.c.get_conflicting_hosts())
512 self.assertEqual(set(), self.c.get_duplicated_hosts())
513 self.assertEqual(set(), self.c.get_partially_configured_hosts())
514 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
515
516 def test_analysis(self):
517 self.mock_hosts_creds([
518 ('.googlesource.com', 'git-example.chromium.org'),
519
520 ('chromium', 'git-example.google.com'),
521 ('chromium-review', 'git-example.google.com'),
522 ('chrome-internal', 'git-example.chromium.org'),
523 ('chrome-internal-review', 'git-example.chromium.org'),
524 ('conflict', 'git-example.google.com'),
525 ('conflict-review', 'git-example.chromium.org'),
526 ('dup', 'git-example.google.com'),
527 ('dup', 'git-example.google.com'),
528 ('dup-review', 'git-example.google.com'),
529 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200530 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100531 ])
532 self.assertTrue(self.c.has_generic_host())
533 self.assertEqual(set(['conflict.googlesource.com']),
534 self.c.get_conflicting_hosts())
535 self.assertEqual(set(['dup.googlesource.com']),
536 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200537 self.assertEqual(set(['partial.googlesource.com',
538 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100539 self.c.get_partially_configured_hosts())
540 self.assertEqual(set(['chromium.googlesource.com',
541 'chrome-internal.googlesource.com']),
542 self.c.get_hosts_with_wrong_identities())
543
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100544 def test_report_no_problems(self):
545 self.test_analysis_nothing()
Edward Lemur79d4f992019-11-11 23:49:02 +0000546 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100547 self.assertFalse(self.c.find_and_report_problems())
548 self.assertEqual(sys.stdout.getvalue(), '')
549
550 def test_report(self):
551 self.test_analysis()
Edward Lemur79d4f992019-11-11 23:49:02 +0000552 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200553 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
554 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100555 self.assertTrue(self.c.find_and_report_problems())
556 with open(os.path.join(os.path.dirname(__file__),
557 'git_cl_creds_check_report.txt')) as f:
558 expected = f.read()
559 def by_line(text):
560 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700561 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200562 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800564
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000565class TestGitCl(TestCase):
566 def setUp(self):
567 super(TestGitCl, self).setUp()
568 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700569 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000570 self.mock(git_cl, 'time_time',
571 lambda: self._mocked_call('time.time'))
572 self.mock(git_cl.metrics.collector, 'add_repeated',
573 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000574 self.mock(subprocess2, 'call', self._mocked_call)
575 self.mock(subprocess2, 'check_call', self._mocked_call)
576 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700577 self.mock(subprocess2, 'communicate',
578 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000579 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000580 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000581 self.mock(git_common, 'get_or_create_merge_base',
582 lambda *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000583 self._mocked_call(['get_or_create_merge_base'] + list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000584 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000585 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000586 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
587 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100588 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000589 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700590 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000591 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000592 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000593 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
Edward Lemur5b929a42019-10-21 17:57:39 +0000594 self.mock(git_cl.auth, 'Authenticator', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100595 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
596 lambda *args, **kwargs: self._mocked_call(
597 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700598 self.mock(git_cl.gerrit_util, 'GetChangeComments',
599 lambda *args, **kwargs: self._mocked_call(
600 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000601 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
602 lambda *args, **kwargs: self._mocked_call(
603 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100604 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700605 lambda h, i, reviewers, ccs, notify: self._mocked_call(
606 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700607 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700608 lambda h, i, msg=None, labels=None, notify=None:
609 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700610 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
611 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000612 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
613 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000614 self.mock(git_cl.gerrit_util, 'ValidAccounts',
615 lambda host, accounts:
616 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700617 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100618 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000619 # It's important to reset settings to not have inter-tests interference.
620 git_cl.settings = None
621
622 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000623 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000624 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100625 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000626 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100627 raise
628 # Sadly, has_failed() returns True if this OR any other tests before this
629 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200630 git_cl.logging.error(
631 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100632 'There are un-consumed self.calls after this test has finished.\n'
633 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700634 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200635 'If you are already running only this test, then **first** fix the '
636 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100637 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700638 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100639 'and follow instructions above.\n' +
640 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000641 finally:
642 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000643
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000644 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000645 self.assertTrue(
646 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700647 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000648 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000649 expected_args, result = top
650
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000651 # Also logs otherwise it could get caught in a try/finally and be hard to
652 # diagnose.
653 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700654 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000655 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700656 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
657 for i, c in enumerate(self._calls_done[-N:]))
658 following_calls = '\n '.join(
659 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
660 for i, c in enumerate(self.calls[:N]))
661 extended_msg = (
662 'A few prior calls:\n %s\n\n'
663 'This (expected):\n @%d: %r\n'
664 'This (actual):\n @%d: %r\n\n'
665 'A few following expected calls:\n %s' %
666 (prior_calls, len(self._calls_done), expected_args,
667 len(self._calls_done), args, following_calls))
668 git_cl.logging.error(extended_msg)
669
tandrii99a72f22016-08-17 14:33:24 -0700670 self.fail('@%d\n'
671 ' Expected: %r\n'
672 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700673 len(self._calls_done), expected_args, args))
674
675 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700676 if isinstance(result, Exception):
677 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000678 # stdout from git commands is supposed to be a bytestream. Convert it here
679 # instead of converting all test output in this file to bytes.
680 if args[0][0] == 'git' and not isinstance(result, bytes):
681 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000682 return result
683
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100684 def test_ask_for_explicit_yes_true(self):
685 self.calls = [
686 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
687 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
688 ]
689 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
690
tandrii48df5812016-10-17 03:55:37 -0700691 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000692 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700693 self.calls = [
694 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700695 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
696 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
697 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
698 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700699 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
700 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700701 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
702 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000703 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
704 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700705 ((['git', 'config', 'gerrit.host', 'true'],), ''),
706 ]
707 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
708
maruel@chromium.orga3353652011-11-30 14:26:57 +0000709 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000710 def _is_gerrit_calls(cls, gerrit=False):
711 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
712 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
713
714 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000715 def _git_post_upload_calls(cls):
716 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000717 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
718 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
719 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000720 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000721 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000722 ]
723
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000724 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000725 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000726 fake_ancestor = 'fake_ancestor'
727 fake_cl = 'fake_cl_for_patch'
728 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000729 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000730 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000731 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000732 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000733 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000734 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000735 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000736 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700737 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000738 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000739 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000740 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000741 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000742 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000743 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000744 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000745 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000746 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000747 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000748 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000749
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000750 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000751 def _gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000752 cls, issue=None, skip_auth_check=False, short_hostname='chromium',
753 custom_cl_base=None):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000754 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000755 if skip_auth_check:
756 return [((cmd, ), 'true')]
757
tandrii5d48c322016-08-18 16:19:37 -0700758 calls = [((cmd, ), CERR1)]
Edward Lemurf38bc172019-09-03 21:02:13 +0000759
760 if custom_cl_base:
761 calls += [
762 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
763 ]
764
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000765 calls.extend([
766 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
767 ((['git', 'config', 'branch.master.remote'],), 'origin'),
768 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000769 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000770 ])
Edward Lemurf38bc172019-09-03 21:02:13 +0000771
772 calls += [
773 ((['git', 'config', 'branch.master.gerritissue'],),
774 CERR1 if issue is None else str(issue)),
775 ]
776
Daniel Chengcf6269b2019-05-18 01:02:12 +0000777 if issue:
778 calls.extend([
779 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
780 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000781 return calls
782
783 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100784 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200785 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000786 custom_cl_base=None, short_hostname='chromium',
787 change_id=None):
Aaron Gable13101a62018-02-09 13:20:41 -0800788 calls = cls._is_gerrit_calls(True)
Edward Lemurf38bc172019-09-03 21:02:13 +0000789 if not custom_cl_base:
790 calls += [
791 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
792 ]
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200793
794 if custom_cl_base:
795 ancestor_revision = custom_cl_base
796 else:
797 # Determine ancestor_revision to be merge base.
798 ancestor_revision = 'fake_ancestor_sha'
799 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000800 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000801 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000802 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200803 'refs/remotes/origin/master'],), ancestor_revision),
804 ]
805
806 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000807 calls += cls._gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000808 issue=issue, short_hostname=short_hostname,
809 custom_cl_base=custom_cl_base)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100810
811 if issue:
812 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000813 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000814 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000815 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
816 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100817 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100818 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Anthony Polito8b955342019-09-24 19:01:36 +0000819 'change_id': (change_id or '123456789'),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100820 'current_revision': 'sha1_of_current_revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000821 'revisions': {'sha1_of_current_revision': {
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100822 'commit': {'message': fetched_description},
823 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100824 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100825 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100826 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100827 if fetched_status == 'ABANDONED':
828 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000829 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100830 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000831 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100832 ]
833 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100834 if other_cl_owner:
835 calls += [
836 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
837 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100838
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200839 calls += cls._git_sanity_checks(ancestor_revision, 'master',
840 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100841 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200842 ((['git', 'rev-parse', '--show-cdup'],), ''),
843 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000844
Aaron Gable7817f022017-12-12 09:43:17 -0800845 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
Edward Lemur7f6dec02020-02-06 20:23:58 +0000846 '--no-renames', '-r', ancestor_revision + '...'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200847 'M\t.gitignore\n'),
848 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100849 ]
850
851 if not issue:
852 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200853 ((['git', 'log', '--pretty=format:%s%n%n%b',
854 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000855 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100856 ]
857
858 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200859 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000860 (('time.time',), 1000,),
861 (('time.time',), 3000,),
862 (('add_repeated', 'sub_commands', {
863 'execution_time': 2000,
864 'command': 'presubmit',
865 'exit_code': 0
866 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200867 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
868 ([custom_cl_base] if custom_cl_base else
869 [ancestor_revision, 'HEAD']),),
870 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100871 ]
872 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000873
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000874 @classmethod
875 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700876 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000877 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700878 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100879 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000880 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000881 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000882 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000883 final_description=None, gitcookies_exists=True,
Josipe827b0f2020-01-30 00:07:20 +0000884 force=False, edit_description=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000885 if post_amend_description is None:
886 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700887 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200888 # Determined in `_gerrit_base_calls`.
889 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
890
891 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000892
tandriia60502f2016-06-20 02:01:53 -0700893 if squash_mode == 'default':
894 calls.extend([
895 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
896 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
897 ])
898 elif squash_mode in ('override_squash', 'override_nosquash'):
899 calls.extend([
900 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
901 'true' if squash_mode == 'override_squash' else 'false'),
902 ])
903 else:
904 assert squash_mode in ('squash', 'nosquash')
905
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000906 # If issue is given, then description is fetched from Gerrit instead.
907 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000908 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200909 ((['git', 'log', '--pretty=format:%s\n\n%b',
910 ((custom_cl_base + '..') if custom_cl_base else
911 'fake_ancestor_sha..HEAD')],),
912 description),
913 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800914 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000915 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800916 else:
917 if not title:
918 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200919 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
920 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800921 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000922 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000923 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000924 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200925 (('DownloadGerritHook', False), ''),
926 # Amending of commit message to get the Change-Id.
927 ((['git', 'log', '--pretty=format:%s\n\n%b',
928 determined_ancestor_revision + '..HEAD'],),
929 description),
930 ((['git', 'commit', '--amend', '-m', description],), ''),
931 ((['git', 'log', '--pretty=format:%s\n\n%b',
932 determined_ancestor_revision + '..HEAD'],),
933 post_amend_description)
934 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000935 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000936 if force or not issue:
937 if issue:
938 calls += [
939 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
940 ]
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000941 # Prompting to edit description on first upload.
942 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000943 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000944 ]
Anthony Polito8b955342019-09-24 19:01:36 +0000945 if not force:
946 calls += [
947 ((['git', 'config', 'core.editor'],), ''),
948 ((['RunEditor'],), description),
949 ]
Josipe827b0f2020-01-30 00:07:20 +0000950 # user wants to edit description
951 if edit_description:
952 calls += [
953 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
954 ((['git', 'config', 'core.editor'],), ''),
955 ((['RunEditor'],), edit_description),
956 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000957 ref_to_push = 'abcdef0123456789'
958 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200959 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
960 ((['git', 'config', 'branch.master.remote'],), 'origin'),
961 ]
962
963 if custom_cl_base is None:
964 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000965 ((['get_or_create_merge_base', 'master',
966 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000967 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200968 ]
969 parent = 'origin/master'
970 else:
971 calls += [
972 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
973 'refs/remotes/origin/master'],),
974 callError(1)), # Means not ancenstor.
975 (('ask_for_data',
976 'Do you take responsibility for cleaning up potential mess '
977 'resulting from proceeding with upload? Press Enter to upload, '
978 'or Ctrl+C to abort'), ''),
979 ]
980 parent = custom_cl_base
981
982 calls += [
983 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
984 '0123456789abcdef'),
985 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -0700986 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200987 ref_to_push),
988 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000989 else:
990 ref_to_push = 'HEAD'
991
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000992 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000993 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200994 ((['git', 'rev-list',
995 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
996 ref_to_push],),
997 '1hashPerLine\n'),
998 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000999
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001000 metrics_arguments = []
1001
Aaron Gableafd52772017-06-27 16:40:10 -07001002 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001003 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001004 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001005 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001006 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001007 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001008 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001009 else:
1010 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001011 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001012
Aaron Gable70f4e242017-06-26 10:45:59 -07001013 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001014 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001015 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001016
Edward Lemur4508b422019-10-03 21:56:35 +00001017 if issue is None:
1018 calls += [
1019 ((['git', 'config', 'rietveld.cc'],), ''),
1020 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001021 if short_hostname == 'chromium':
1022 # All reviwers and ccs get into ref_suffix.
1023 for r in sorted(reviewers):
1024 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001025 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +00001026 if issue is None:
1027 cc += ['chromium-reviews+test-more-cc@chromium.org', 'joe@example.com']
1028 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001029 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001030 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001031 reviewers, cc = [], []
1032 else:
1033 # TODO(crbug/877717): remove this case.
1034 calls += [
1035 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1036 sorted(reviewers) + ['joe@example.com',
1037 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1038 {
1039 e: {'email': e}
1040 for e in (reviewers + ['joe@example.com'] + cc)
1041 })
1042 ]
1043 for r in sorted(reviewers):
1044 if r != 'bad-account-or-email':
1045 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001046 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001047 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +00001048 if issue is None:
1049 cc += ['joe@example.com']
1050 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001051 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001052 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001053 if c in cc:
1054 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001055
Edward Lemur687ca902018-12-05 02:30:30 +00001056 for k, v in sorted((labels or {}).items()):
1057 ref_suffix += ',l=%s+%d' % (k, v)
1058 metrics_arguments.append('l=%s+%d' % (k, v))
1059
1060 if tbr:
1061 calls += [
1062 (('GetCodeReviewTbrScore',
1063 '%s-review.googlesource.com' % short_hostname,
1064 'my/repo'),
1065 2,),
1066 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001067
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001068 calls += [
1069 (('time.time',), 1000,),
1070 ((['git', 'push',
1071 'https://%s.googlesource.com/my/repo' % short_hostname,
1072 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1073 (('remote:\n'
1074 'remote: Processing changes: (\)\n'
1075 'remote: Processing changes: (|)\n'
1076 'remote: Processing changes: (/)\n'
1077 'remote: Processing changes: (-)\n'
1078 'remote: Processing changes: new: 1 (/)\n'
1079 'remote: Processing changes: new: 1, done\n'
1080 'remote:\n'
1081 'remote: New Changes:\n'
1082 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1083 ' XXX\n'
1084 'remote:\n'
1085 'To https://%s.googlesource.com/my/repo\n'
1086 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1087 ) % (short_hostname, short_hostname)),),
1088 (('time.time',), 2000,),
1089 (('add_repeated',
1090 'sub_commands',
1091 {
1092 'execution_time': 1000,
1093 'command': 'git push',
1094 'exit_code': 0,
1095 'arguments': sorted(metrics_arguments),
1096 }),
1097 None,),
1098 ]
1099
Edward Lemur1b52d872019-05-09 21:12:12 +00001100 final_description = final_description or post_amend_description.strip()
1101 original_title = original_title or title or '<untitled>'
1102 # Trace-related calls
1103 calls += [
1104 # Write a description with context for the current trace.
1105 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001106 'Thu Mar 16 20:00:41 2017\n'
1107 '%(short_hostname)s-review.googlesource.com\n'
1108 '%(change_id)s\n'
1109 '%(title)s\n'
1110 '%(description)s\n'
1111 '1000\n'
1112 '0\n'
1113 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001114 'short_hostname': short_hostname,
1115 'change_id': change_id,
1116 'description': final_description,
1117 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001118 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001119 }],),
1120 None,
1121 ),
1122 # Read traces and shorten git hashes.
1123 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1124 True,
1125 ),
1126 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1127 ('git-hash: 0123456789012345678901234567890123456789\n'
1128 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1129 ),
1130 ((['FileWrite', 'TEMP_DIR/trace-packet',
1131 'git-hash: 012345\n'
1132 'git-hash: abcdea\n'],),
1133 None,
1134 ),
1135 # Make zip file for the git traces.
1136 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1137 'TEMP_DIR'],),
1138 None,
1139 ),
1140 # Collect git config and gitcookies.
1141 ((['git', 'config', '-l'],),
1142 'git-config-output',
1143 ),
1144 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1145 None,
1146 ),
1147 ((['os.path.isfile', '~/.gitcookies'],),
1148 gitcookies_exists,
1149 ),
1150 ]
1151 if gitcookies_exists:
1152 calls += [
1153 ((['FileRead', '~/.gitcookies'],),
1154 'gitcookies 1/SECRET',
1155 ),
1156 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1157 None,
1158 ),
1159 ]
1160 calls += [
1161 # Make zip file for the git config and gitcookies.
1162 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1163 'TEMP_DIR'],),
1164 None,
1165 ),
1166 ]
1167
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001168 if squash:
1169 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001170 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001171 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001172 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001173 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001174 ((['git', 'config', 'branch.master.gerritsquashhash',
1175 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001176 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001177 # TODO(crbug/877717): this should never be used.
1178 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001179 calls += [
1180 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001181 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001182 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001183 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1184 notify),
1185 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001186 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001187 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001188 return calls
1189
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001190 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001191 self,
1192 upload_args,
1193 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001194 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001195 squash=True,
1196 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001197 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001198 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001199 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001200 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001201 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001202 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001203 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001204 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001205 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001206 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001207 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001208 labels=None,
1209 change_id=None,
1210 original_title=None,
1211 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001212 gitcookies_exists=True,
1213 force=False,
Josipe827b0f2020-01-30 00:07:20 +00001214 edit_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001215 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001216 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001217 if squash_mode is None:
1218 if '--no-squash' in upload_args:
1219 squash_mode = 'nosquash'
1220 elif '--squash' in upload_args:
1221 squash_mode = 'squash'
1222 else:
1223 squash_mode = 'default'
1224
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001225 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001226 cc = cc or []
Edward Lemur79d4f992019-11-11 23:49:02 +00001227 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001228 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001229 CookiesAuthenticatorMockFactory(
1230 same_auth=('git-owner.example.com', '', 'pass')))
Edward Lemur125d60a2019-09-13 18:25:41 +00001231 self.mock(git_cl.Changelist, '_GerritCommitMsgHookCheck',
tandrii16e0b4e2016-06-07 10:34:28 -07001232 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001233 self.mock(git_cl.gclient_utils, 'RunEditor',
1234 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001235 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1236 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001237 self.mock(git_cl.gclient_utils, 'FileRead',
1238 lambda path: self._mocked_call(['FileRead', path]))
1239 self.mock(git_cl.gclient_utils, 'FileWrite',
1240 lambda path, contents: self._mocked_call(
1241 ['FileWrite', path, contents]))
1242 self.mock(git_cl, 'datetime_now',
1243 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1244 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1245 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
Edward Lemur75391d42019-05-14 23:35:56 +00001246 self.mock(git_cl, 'TRACES_README_FORMAT',
1247 '%(now)s\n'
1248 '%(gerrit_host)s\n'
1249 '%(change_id)s\n'
1250 '%(title)s\n'
1251 '%(description)s\n'
1252 '%(execution_time)s\n'
1253 '%(exit_code)s\n'
1254 '%(trace_name)s')
Edward Lemur1b52d872019-05-09 21:12:12 +00001255 self.mock(git_cl.shutil, 'make_archive',
1256 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1257 self.mock(os.path, 'isfile',
1258 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001259
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001260 self.calls = self._gerrit_base_calls(
1261 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001262 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001263 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001264 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001265 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001266 short_hostname=short_hostname,
1267 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001268 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001269 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
Edward Lemur0db01f02019-11-12 22:01:51 +00001270 self, expected_content=description))
Aaron Gable9a03ae02017-11-03 11:31:07 -07001271 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001272 self.calls += self._gerrit_upload_calls(
1273 description, reviewers, squash,
1274 squash_mode=squash_mode,
1275 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001276 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001277 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001278 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001279 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001280 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001281 labels=labels,
1282 change_id=change_id,
1283 original_title=original_title,
1284 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001285 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001286 force=force,
1287 edit_description=edit_description)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001288 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001289 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001290 git_cl.main(['upload'] + upload_args)
1291
Edward Lemur1b52d872019-05-09 21:12:12 +00001292 def test_gerrit_upload_traces_no_gitcookies(self):
1293 self._run_gerrit_upload_test(
1294 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001295 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001296 [],
1297 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001298 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001299 change_id='Ixxx',
1300 gitcookies_exists=False)
1301
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001302 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001303 self._run_gerrit_upload_test(
1304 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001305 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001306 [],
1307 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001308 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001309 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001310
1311 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001312 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001313 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001314 'desc ✔\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001315 [],
tandriia60502f2016-06-20 02:01:53 -07001316 squash=False,
1317 squash_mode='override_nosquash',
Edward Lemur0db01f02019-11-12 22:01:51 +00001318 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001319 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001320
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001321 def test_gerrit_no_reviewer(self):
1322 self._run_gerrit_upload_test(
1323 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001324 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001325 [],
1326 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001327 squash_mode='override_nosquash',
1328 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001329
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001330 def test_gerrit_no_reviewer_non_chromium_host(self):
1331 # TODO(crbug/877717): remove this test case.
1332 self._run_gerrit_upload_test(
1333 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001334 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001335 [],
1336 squash=False,
1337 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001338 short_hostname='other',
1339 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001340
Nick Carter8692b182017-11-06 16:30:38 -08001341 def test_gerrit_patchset_title_special_chars(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00001342 self.mock(git_cl.sys, 'stdout', StringIO())
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001343 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001344 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001345 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001346 squash=False,
1347 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001348 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1349 change_id='I123456789',
1350 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001351
ukai@chromium.orge8077812012-02-03 03:41:46 +00001352 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001353 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001354 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001355 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001356 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001357 squash=False,
1358 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001359 notify=True,
1360 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001361 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001362 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001363
Anthony Polito8b955342019-09-24 19:01:36 +00001364 def test_gerrit_upload_force_sets_bug(self):
1365 self._run_gerrit_upload_test(
1366 ['-b', '10000', '-f'],
1367 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1368 [],
1369 force=True,
1370 expected_upstream_ref='origin/master',
1371 fetched_description='desc=\n\nChange-Id: Ixxx',
1372 original_title='Initial upload',
1373 change_id='Ixxx')
1374
1375 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1376 self._run_gerrit_upload_test(
1377 ['-b', '10000', '-f', '-m', 'Title'],
1378 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1379 [],
1380 force=True,
1381 issue='123456',
1382 expected_upstream_ref='origin/master',
1383 fetched_description='desc=\n\nChange-Id: Ixxxx',
1384 original_title='Title',
1385 title='Title',
1386 change_id='Izzzz')
1387
Dan Beamd8b04ca2019-10-10 21:23:26 +00001388 def test_gerrit_upload_force_sets_fixed(self):
1389 self._run_gerrit_upload_test(
1390 ['-x', '10000', '-f'],
1391 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1392 [],
1393 force=True,
1394 expected_upstream_ref='origin/master',
1395 fetched_description='desc=\n\nChange-Id: Ixxx',
1396 original_title='Initial upload',
1397 change_id='Ixxx')
1398
ukai@chromium.orge8077812012-02-03 03:41:46 +00001399 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001400 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1401 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001402 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001403 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001404 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001405 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001406 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001407 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001408 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001409 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001410 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001411 labels={'Code-Review': 2},
1412 change_id='123456789',
1413 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001414
1415 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001416 self._run_gerrit_upload_test(
1417 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001418 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001419 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001420 expected_upstream_ref='origin/master',
1421 change_id='123456789',
1422 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001423
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001424 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001425 self._run_gerrit_upload_test(
1426 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001427 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001428 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001429 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001430 expected_upstream_ref='origin/master',
1431 change_id='123456789',
1432 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001433
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001434 def test_gerrit_upload_squash_first_with_labels(self):
1435 self._run_gerrit_upload_test(
1436 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001437 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001438 [],
1439 squash=True,
1440 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001441 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1442 change_id='123456789',
1443 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001444
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001445 def test_gerrit_upload_squash_first_against_rev(self):
1446 custom_cl_base = 'custom_cl_base_rev_or_branch'
1447 self._run_gerrit_upload_test(
1448 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001449 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001450 [],
1451 squash=True,
1452 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001453 custom_cl_base=custom_cl_base,
1454 change_id='123456789',
1455 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001456 self.assertIn(
1457 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1458 sys.stdout.getvalue())
1459
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001460 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001461 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001462 self._run_gerrit_upload_test(
1463 ['--squash'],
1464 description,
1465 [],
1466 squash=True,
1467 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001468 issue=123456,
1469 change_id='123456789',
1470 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001471
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001472 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1473 self.mock(git_cl, 'DieWithError',
1474 lambda msg, change=None: self._mocked_call('DieWithError', msg))
Edward Lemur0db01f02019-11-12 22:01:51 +00001475 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001476 with self.assertRaises(SystemExitMock):
1477 self._run_gerrit_upload_test(
1478 ['--squash'],
1479 description,
1480 [],
1481 squash=True,
1482 expected_upstream_ref='origin/master',
1483 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001484 fetched_status='ABANDONED',
1485 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001486
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001487 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1488 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1489 lambda *_, **__: {'email': 'yet-another@example.com'})
Edward Lemur0db01f02019-11-12 22:01:51 +00001490 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001491 self._run_gerrit_upload_test(
1492 ['--squash'],
1493 description,
1494 [],
1495 squash=True,
1496 expected_upstream_ref='origin/master',
1497 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001498 other_cl_owner='other@example.com',
1499 change_id='123456789',
1500 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001501 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001502 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001503 'authenticate to Gerrit as yet-another@example.com.\n'
1504 'Uploading may fail due to lack of permissions',
1505 git_cl.sys.stdout.getvalue())
1506
Josipe827b0f2020-01-30 00:07:20 +00001507 def test_upload_change_description_editor(self):
1508 fetched_description = 'foo\n\nChange-Id: 123456789'
1509 description = 'bar\n\nChange-Id: 123456789'
1510 self._run_gerrit_upload_test(
1511 ['--squash', '--edit-description'],
1512 description,
1513 [],
1514 fetched_description=fetched_description,
1515 squash=True,
1516 expected_upstream_ref='origin/master',
1517 issue=123456,
1518 change_id='123456789',
1519 original_title='User input',
1520 edit_description=description)
1521
rmistry@google.com2dd99862015-06-22 12:22:18 +00001522 def test_upload_branch_deps(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00001523 self.mock(git_cl.sys, 'stdout', StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001524 def mock_run_git(*args, **_kwargs):
1525 if args[0] == ['for-each-ref',
1526 '--format=%(refname:short) %(upstream:short)',
1527 'refs/heads']:
1528 # Create a local branch dependency tree that looks like this:
1529 # test1 -> test2 -> test3 -> test4 -> test5
1530 # -> test3.1
1531 # test6 -> test0
1532 branch_deps = [
1533 'test2 test1', # test1 -> test2
1534 'test3 test2', # test2 -> test3
1535 'test3.1 test2', # test2 -> test3.1
1536 'test4 test3', # test3 -> test4
1537 'test5 test4', # test4 -> test5
1538 'test6 test0', # test0 -> test6
1539 'test7', # test7
1540 ]
1541 return '\n'.join(branch_deps)
1542 self.mock(git_cl, 'RunGit', mock_run_git)
1543
1544 class RecordCalls:
1545 times_called = 0
1546 record_calls = RecordCalls()
1547 def mock_CMDupload(*args, **_kwargs):
1548 record_calls.times_called += 1
1549 return 0
1550 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1551
1552 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001553 (('ask_for_data', 'This command will checkout all dependent branches '
1554 'and run "git cl upload". Press Enter to continue, '
1555 'or Ctrl+C to abort'), ''),
1556 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001557
1558 class MockChangelist():
1559 def __init__(self):
1560 pass
1561 def GetBranch(self):
1562 return 'test1'
1563 def GetIssue(self):
1564 return '123'
1565 def GetPatchset(self):
1566 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001567 def IsGerrit(self):
1568 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001569
1570 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1571 # CMDupload should have been called 5 times because of 5 dependent branches.
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001572 self.assertEqual(5, record_calls.times_called)
1573 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001574
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001575 def test_gerrit_change_id(self):
1576 self.calls = [
1577 ((['git', 'write-tree'], ),
1578 'hashtree'),
1579 ((['git', 'rev-parse', 'HEAD~0'], ),
1580 'branch-parent'),
1581 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1582 'A B <a@b.org> 1456848326 +0100'),
1583 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1584 'C D <c@d.org> 1456858326 +0100'),
1585 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1586 'hashchange'),
1587 ]
1588 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1589 self.assertEqual(change_id, 'Ihashchange')
1590
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001591 def test_desecription_append_footer(self):
1592 for init_desc, footer_line, expected_desc in [
1593 # Use unique desc first lines for easy test failure identification.
1594 ('foo', 'R=one', 'foo\n\nR=one'),
1595 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1596 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1597 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1598 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1599 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1600 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1601 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1602 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1603 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1604 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1605 ]:
1606 desc = git_cl.ChangeDescription(init_desc)
1607 desc.append_footer(footer_line)
1608 self.assertEqual(desc.description, expected_desc)
1609
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001610 def test_update_reviewers(self):
1611 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001612 ('foo', [], [],
1613 'foo'),
1614 ('foo\nR=xx', [], [],
1615 'foo\nR=xx'),
1616 ('foo\nTBR=xx', [], [],
1617 'foo\nTBR=xx'),
1618 ('foo', ['a@c'], [],
1619 'foo\n\nR=a@c'),
1620 ('foo\nR=xx', ['a@c'], [],
1621 'foo\n\nR=a@c, xx'),
1622 ('foo\nTBR=xx', ['a@c'], [],
1623 'foo\n\nR=a@c\nTBR=xx'),
1624 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1625 'foo\n\nR=a@c, yy\nTBR=xx'),
1626 ('foo\nBUG=', ['a@c'], [],
1627 'foo\nBUG=\nR=a@c'),
1628 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1629 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1630 ('foo', ['a@c', 'b@c'], [],
1631 'foo\n\nR=a@c, b@c'),
1632 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1633 'foo\nBar\n\nR=c@c\nBUG='),
1634 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1635 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001636 # Same as the line before, but full of whitespaces.
1637 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001638 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001639 'foo\nBar\n\nR=c@c\n BUG =',
1640 ),
1641 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001642 ('foo BUG=allo R=joe ', ['c@c'], [],
1643 'foo BUG=allo R=joe\n\nR=c@c'),
1644 # Redundant TBRs get promoted to Rs
1645 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1646 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001647 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001648 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001649 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001650 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001651 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001652 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001653 actual.append(obj.description)
1654 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001655
Nodir Turakulov23b82142017-11-16 11:04:25 -08001656 def test_get_hash_tags(self):
1657 cases = [
1658 ('', []),
1659 ('a', []),
1660 ('[a]', ['a']),
1661 ('[aa]', ['aa']),
1662 ('[a ]', ['a']),
1663 ('[a- ]', ['a']),
1664 ('[a- b]', ['a-b']),
1665 ('[a--b]', ['a-b']),
1666 ('[a', []),
1667 ('[a]x', ['a']),
1668 ('[aa]x', ['aa']),
1669 ('[a b]', ['a-b']),
1670 ('[a b]', ['a-b']),
1671 ('[a__b]', ['a-b']),
1672 ('[a] x', ['a']),
1673 ('[a][b]', ['a', 'b']),
1674 ('[a] [b]', ['a', 'b']),
1675 ('[a][b]x', ['a', 'b']),
1676 ('[a][b] x', ['a', 'b']),
1677 ('[a]\n[b]', ['a']),
1678 ('[a\nb]', []),
1679 ('[a][', ['a']),
1680 ('Revert "[a] feature"', ['a']),
1681 ('Reland "[a] feature"', ['a']),
1682 ('Revert: [a] feature', ['a']),
1683 ('Reland: [a] feature', ['a']),
1684 ('Revert "Reland: [a] feature"', ['a']),
1685 ('Foo: feature', ['foo']),
1686 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001687 ('Change Foo::Bar', []),
1688 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001689 ('Revert "Foo bar: feature"', ['foo-bar']),
1690 ('Reland "Foo bar: feature"', ['foo-bar']),
1691 ]
1692 for desc, expected in cases:
1693 change_desc = git_cl.ChangeDescription(desc)
1694 actual = change_desc.get_hash_tags()
1695 self.assertEqual(
1696 actual,
1697 expected,
1698 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1699
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001700 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001701 self.assertEqual(None, git_cl.GetTargetRef(None,
1702 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001703 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001704
wittman@chromium.org455dc922015-01-26 20:15:50 +00001705 # Check default target refs for branches.
1706 self.assertEqual('refs/heads/master',
1707 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001708 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001709 self.assertEqual('refs/heads/master',
1710 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001711 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001712 self.assertEqual('refs/heads/master',
1713 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001714 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001715 self.assertEqual('refs/branch-heads/123',
1716 git_cl.GetTargetRef('origin',
1717 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001718 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001719 self.assertEqual('refs/diff/test',
1720 git_cl.GetTargetRef('origin',
1721 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001722 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001723 self.assertEqual('refs/heads/chrome/m42',
1724 git_cl.GetTargetRef('origin',
1725 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001726 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001727
1728 # Check target refs for user-specified target branch.
1729 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1730 'refs/remotes/branch-heads/123'):
1731 self.assertEqual('refs/branch-heads/123',
1732 git_cl.GetTargetRef('origin',
1733 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001734 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001735 for branch in ('origin/master', 'remotes/origin/master',
1736 'refs/remotes/origin/master'):
1737 self.assertEqual('refs/heads/master',
1738 git_cl.GetTargetRef('origin',
1739 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001740 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001741 for branch in ('master', 'heads/master', 'refs/heads/master'):
1742 self.assertEqual('refs/heads/master',
1743 git_cl.GetTargetRef('origin',
1744 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001745 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001746
wychen@chromium.orga872e752015-04-28 23:42:18 +00001747 def test_patch_when_dirty(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001748 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001749 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1750 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1751
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001752 @staticmethod
1753 def _get_gerrit_codereview_server_calls(branch, value=None,
1754 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001755 detect_branch=True,
1756 detect_server=True):
Edward Lemur125d60a2019-09-13 18:25:41 +00001757 """Returns calls executed by Changelist.GetCodereviewServer.
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001758
1759 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1760 """
1761 calls = []
1762 if detect_branch:
1763 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001764 if detect_server:
1765 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1766 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001767 if value is None:
1768 calls += [
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001769 ((['git', 'config', 'branch.' + branch + '.merge'],),
1770 'refs/heads' + branch),
1771 ((['git', 'config', 'branch.' + branch + '.remote'],),
1772 'origin'),
1773 ((['git', 'config', 'remote.origin.url'],),
1774 'https://%s.googlesource.com/my/repo' % git_short_host),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001775 ]
1776 return calls
1777
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001778 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001779 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001780 detect_gerrit_server=False,
1781 actual_codereview=None,
1782 codereview_in_url=False):
Edward Lemur79d4f992019-11-11 23:49:02 +00001783 self.mock(git_cl.sys, 'stdout', StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001784 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1785
tandriidf09a462016-08-18 16:23:55 -07001786 if new_branch:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001787 self.calls = [((['git', 'new-branch', 'master'],), '')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001788
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001789 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001790 self.calls += [
1791 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001792 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001793 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001794
1795 if not force_codereview and not codereview_in_url:
1796 # These calls detect codereview to use.
1797 self.calls += [
1798 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001799 ]
1800 if detect_gerrit_server:
1801 self.calls += self._get_gerrit_codereview_server_calls(
1802 'master', git_short_host=git_short_host,
1803 detect_branch=not new_branch and force_codereview)
1804 actual_codereview = 'gerrit'
1805
1806 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001807 self.calls += [
1808 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001809 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001810 {
1811 'current_revision': '7777777777',
1812 'revisions': {
1813 '1111111111': {
1814 '_number': 1,
1815 'fetch': {'http': {
1816 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1817 'ref': 'refs/changes/56/123456/1',
1818 }},
1819 },
1820 '7777777777': {
1821 '_number': 7,
1822 'fetch': {'http': {
1823 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1824 'ref': 'refs/changes/56/123456/7',
1825 }},
1826 },
1827 },
1828 }),
1829 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001830
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001831 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001832 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001833 self.calls += [
1834 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1835 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001836 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001837 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001838 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001839 ((['git', 'config', 'branch.master.gerritserver',
1840 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001841 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001842 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1843 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1844 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001845 ]
1846 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1847
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001848 def test_patch_gerrit_new_branch(self):
1849 self._patch_common(
1850 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1851 self.calls += [
1852 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1853 'refs/changes/56/123456/7'],), ''),
1854 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1855 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1856 ''),
1857 ((['git', 'config', 'branch.master.gerritserver',
1858 'https://chromium-review.googlesource.com'],), ''),
1859 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1860 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1861 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1862 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1863 ]
1864 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1865
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001866 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001867 self._patch_common(
1868 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001869 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001870 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001871 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001872 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001873 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001874 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001875 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001876 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001877 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001878 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1879 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1880 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001881 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001882 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001883
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001884 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001885 self.calls += self._get_gerrit_codereview_server_calls(
1886 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001887 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001888 actual_codereview='gerrit', git_short_host='else',
1889 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001890 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001891 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001892 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001893 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001894 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001895 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001896 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001897 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001898 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001899 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1900 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1901 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001902 ]
1903 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001904 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001905
Aaron Gable697a91b2018-01-19 15:20:15 -08001906 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001907 self.calls += self._get_gerrit_codereview_server_calls(
1908 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001909 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001910 actual_codereview='gerrit', git_short_host='else',
1911 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001912 self.calls += [
1913 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1914 'refs/changes/56/123456/1'],), ''),
1915 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1916 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1917 ''),
1918 ((['git', 'config', 'branch.master.gerritserver',
1919 'https://else-review.googlesource.com'],), ''),
1920 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1921 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1922 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1923 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1924 ]
1925 self.assertEqual(git_cl.main(
1926 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1927 0)
1928
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001929 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001930 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001931 self.calls += [
1932 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001933 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001934 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1935 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1936 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001937 ]
1938 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001939 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001940
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001941 def test_patch_gerrit_not_exists(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001942
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001943 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001944 raise git_cl.gerrit_util.GerritError(404, '')
1945 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1946
tandriic2405f52016-10-10 08:13:15 -07001947 self.calls = [
1948 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001949 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1950 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1951 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1952 ((['git', 'config', 'remote.origin.url'],),
1953 'https://chromium.googlesource.com/my/repo'),
1954 ((['DieWithError',
1955 'change 123456 at https://chromium-review.googlesource.com does not '
1956 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001957 ]
1958 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001959 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001960
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001961 def _checkout_calls(self):
1962 return [
1963 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001964 'branch\\..*\\.gerritissue'], ),
1965 ('branch.ger-branch.gerritissue 123456\n'
1966 'branch.gbranch654.gerritissue 654321\n')),
1967 ]
1968
1969 def test_checkout_gerrit(self):
1970 """Tests git cl checkout <issue>."""
1971 self.calls = self._checkout_calls()
1972 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1973 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1974
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001975 def test_checkout_not_found(self):
1976 """Tests git cl checkout <issue>."""
Edward Lemur79d4f992019-11-11 23:49:02 +00001977 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001978 self.calls = self._checkout_calls()
1979 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1980
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001981 def test_checkout_no_branch_issues(self):
1982 """Tests git cl checkout <issue>."""
Edward Lemur79d4f992019-11-11 23:49:02 +00001983 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001984 self.calls = [
1985 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001986 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001987 ]
1988 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1989
tandrii@chromium.org28253532016-04-14 13:46:56 +00001990 def _test_gerrit_ensure_authenticated_common(self, auth,
1991 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001992 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1993 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1994 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001995 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001996 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
Edward Lemurf38bc172019-09-03 21:02:13 +00001997 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001998 cl.branch = 'master'
1999 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002000 return cl
2001
2002 def test_gerrit_ensure_authenticated_missing(self):
2003 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002004 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002005 })
2006 self.calls.append(
2007 ((['DieWithError',
2008 'Credentials for the following hosts are required:\n'
2009 ' chromium-review.googlesource.com\n'
2010 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002011 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002012 'https://chromium-review.googlesource.com/new-password'],), ''),)
2013 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2014
2015 def test_gerrit_ensure_authenticated_conflict(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002016 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002017 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002018 'chromium.googlesource.com':
2019 ('git-one.example.com', None, 'secret1'),
2020 'chromium-review.googlesource.com':
2021 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002022 })
2023 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002024 (('ask_for_data', 'If you know what you are doing '
2025 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002026 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2027
2028 def test_gerrit_ensure_authenticated_ok(self):
2029 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002030 'chromium.googlesource.com':
2031 ('git-same.example.com', None, 'secret'),
2032 'chromium-review.googlesource.com':
2033 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002034 })
2035 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2036
tandrii@chromium.org28253532016-04-14 13:46:56 +00002037 def test_gerrit_ensure_authenticated_skipped(self):
2038 cl = self._test_gerrit_ensure_authenticated_common(
2039 auth={}, skip_auth_check=True)
2040 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2041
Eric Boren2fb63102018-10-05 13:05:03 +00002042 def test_gerrit_ensure_authenticated_bearer_token(self):
2043 cl = self._test_gerrit_ensure_authenticated_common(auth={
2044 'chromium.googlesource.com':
2045 ('', None, 'secret'),
2046 'chromium-review.googlesource.com':
2047 ('', None, 'secret'),
2048 })
2049 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2050 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2051 'chromium.googlesource.com')
2052 self.assertTrue('Bearer' in header)
2053
Daniel Chengcf6269b2019-05-18 01:02:12 +00002054 def test_gerrit_ensure_authenticated_non_https(self):
2055 self.calls = [
2056 ((['git', 'config', '--bool',
2057 'gerrit.skip-ensure-authenticated'],), CERR1),
2058 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2059 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2060 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
Josip906bfde2020-01-31 22:38:49 +00002061 (('logging.warning',
2062 'Ignoring branch %(branch)s with non-https remote '
2063 '%(remote)s', {
2064 'branch': 'master',
2065 'remote': 'custom-scheme://repo'}
2066 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00002067 ]
2068 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2069 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
Josip906bfde2020-01-31 22:38:49 +00002070 self.mock(logging, 'warning',
2071 lambda *a: self._mocked_call('logging.warning', *a))
Edward Lemurf38bc172019-09-03 21:02:13 +00002072 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002073 cl.branch = 'master'
2074 cl.branchref = 'refs/heads/master'
2075 cl.lookedup_issue = True
2076 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2077
Florian Mayerae510e82020-01-30 21:04:48 +00002078 def test_gerrit_ensure_authenticated_non_url(self):
2079 self.calls = [
2080 ((['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated'], ),
2081 CERR1),
2082 ((['git', 'config', 'branch.master.merge'], ), 'refs/heads/master'),
2083 ((['git', 'config', 'branch.master.remote'], ), 'origin'),
2084 ((['git', 'config', 'remote.origin.url'], ),
2085 'git@somehost.example:foo/bar.git'),
Josip906bfde2020-01-31 22:38:49 +00002086 (('logging.error',
2087 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2088 'but it doesn\'t exist.', {
2089 'remote': 'origin',
2090 'branch': 'master',
2091 'url': 'git@somehost.example:foo/bar.git'}
2092 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00002093 ]
2094 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2095 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
Josip906bfde2020-01-31 22:38:49 +00002096 self.mock(logging, 'error',
2097 lambda *a: self._mocked_call('logging.error', *a))
Florian Mayerae510e82020-01-30 21:04:48 +00002098 cl = git_cl.Changelist()
2099 cl.branch = 'master'
2100 cl.branchref = 'refs/heads/master'
2101 cl.lookedup_issue = True
2102 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2103
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002104 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002105 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002106 lambda h, i, labels, notify=None:
2107 self._mocked_call(['SetReview', h, i, labels, notify]))
2108
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002109 self.calls = [
2110 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002111 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002112 ((['git', 'config', 'branch.feature.gerritserver'],),
2113 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002114 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2115 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2116 ((['git', 'config', 'remote.origin.url'],),
2117 'https://chromium.googlesource.com/infra/infra.git'),
2118 ((['SetReview', 'chromium-review.googlesource.com',
2119 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002120 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002121 ]
tandriid9e5ce52016-07-13 02:32:59 -07002122
2123 def test_cmd_set_commit_gerrit_clear(self):
2124 self._cmd_set_commit_gerrit_common(0)
2125 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2126
2127 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002128 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002129 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2130
tandriid9e5ce52016-07-13 02:32:59 -07002131 def test_cmd_set_commit_gerrit(self):
2132 self._cmd_set_commit_gerrit_common(2)
2133 self.assertEqual(0, git_cl.main(['set-commit']))
2134
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002135 def test_description_display(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002136 out = StringIO()
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002137 self.mock(git_cl.sys, 'stdout', out)
2138
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002139 self.mock(git_cl, 'Changelist', ChangelistMock)
2140 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002141
2142 self.assertEqual(0, git_cl.main(['description', '-d']))
2143 self.assertEqual('foo\n', out.getvalue())
2144
iannucci3c972b92016-08-17 13:24:10 -07002145 def test_StatusFieldOverrideIssueMissingArgs(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002146 out = StringIO()
iannucci3c972b92016-08-17 13:24:10 -07002147 self.mock(git_cl.sys, 'stderr', out)
2148
2149 try:
2150 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2151 except SystemExit as ex:
2152 self.assertEqual(ex.code, 2)
Edward Lemurf38bc172019-09-03 21:02:13 +00002153 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002154
Edward Lemur79d4f992019-11-11 23:49:02 +00002155 out = StringIO()
iannucci3c972b92016-08-17 13:24:10 -07002156 self.mock(git_cl.sys, 'stderr', out)
2157
2158 try:
Edward Lemur52969c92020-02-06 18:15:28 +00002159 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002160 except SystemExit as ex:
2161 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002162 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002163
2164 def test_StatusFieldOverrideIssue(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002165 out = StringIO()
iannucci3c972b92016-08-17 13:24:10 -07002166 self.mock(git_cl.sys, 'stdout', out)
2167
2168 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002169 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002170 return 'foobar'
2171
2172 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002173 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002174 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002175 0)
iannucci3c972b92016-08-17 13:24:10 -07002176 self.assertEqual(out.getvalue(), 'foobar\n')
2177
iannuccie53c9352016-08-17 14:40:40 -07002178 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002179
iannuccie53c9352016-08-17 14:40:40 -07002180 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002181 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002182 return 'foobar'
2183
2184 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2185 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002186 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002187 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002188
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002189 def test_description(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002190 out = StringIO()
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002191 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002192 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002193 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2194 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2195 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2196 ((['git', 'config', 'remote.origin.url'],),
2197 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002198 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002199 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002200 {
2201 'current_revision': 'sha1',
2202 'revisions': {'sha1': {
2203 'commit': {'message': 'foobar'},
2204 }},
2205 }),
2206 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002207 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002208 'description',
2209 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2210 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002211 self.assertEqual('foobar\n', out.getvalue())
2212
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002213 def test_description_set_raw(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002214 out = StringIO()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002215 self.mock(git_cl.sys, 'stdout', out)
2216
2217 self.mock(git_cl, 'Changelist', ChangelistMock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002218 self.mock(git_cl.sys, 'stdin', StringIO('hihi'))
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002219
2220 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2221 self.assertEqual('hihi', ChangelistMock.desc)
2222
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002223 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002224 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002225
2226 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002227 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002228 '# Enter a description of the change.\n'
2229 '# This will be displayed on the codereview site.\n'
2230 '# The first line will also be used as the subject of the review.\n'
2231 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002232 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002233 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002234 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002235 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002236 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002237
dsansomee2d6fd92016-09-08 00:10:47 -07002238 def UpdateDescriptionRemote(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002239 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002240
Edward Lemur79d4f992019-11-11 23:49:02 +00002241 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002242 self.mock(git_cl.Changelist, 'GetDescription',
2243 lambda *args: current_desc)
Edward Lemur125d60a2019-09-13 18:25:41 +00002244 self.mock(git_cl.Changelist, 'UpdateDescriptionRemote',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002245 UpdateDescriptionRemote)
2246 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2247
2248 self.calls = [
2249 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002250 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002251 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2252 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002253 ((['git', 'config', 'core.editor'],), 'vi'),
2254 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002255 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002256
Dan Beamd8b04ca2019-10-10 21:23:26 +00002257 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2258 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2259
2260 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002261 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002262 '# Enter a description of the change.\n'
2263 '# This will be displayed on the codereview site.\n'
2264 '# The first line will also be used as the subject of the review.\n'
2265 '#--------------------This line is 72 characters long'
2266 '--------------------\n'
2267 'Some.\n\nFixed: 123\nChange-Id: xxx',
2268 desc)
2269 return desc
2270
Edward Lemur79d4f992019-11-11 23:49:02 +00002271 self.mock(git_cl.sys, 'stdout', StringIO())
Dan Beamd8b04ca2019-10-10 21:23:26 +00002272 self.mock(git_cl.Changelist, 'GetDescription',
2273 lambda *args: current_desc)
2274 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2275
2276 self.calls = [
2277 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2278 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2279 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2280 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
2281 ((['git', 'config', 'core.editor'],), 'vi'),
2282 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002283 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002284
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002285 def test_description_set_stdin(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002286 out = StringIO()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002287 self.mock(git_cl.sys, 'stdout', out)
2288
2289 self.mock(git_cl, 'Changelist', ChangelistMock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002290 self.mock(git_cl.sys, 'stdin', StringIO('hi \r\n\t there\n\nman'))
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002291
2292 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2293 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2294
kmarshall3bff56b2016-06-06 18:31:47 -07002295 def test_archive(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002296 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii1c67da62016-06-10 07:35:53 -07002297
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002298 self.calls = [
2299 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002300 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002301 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002302 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2303 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002304 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002305 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002306
kmarshall3bff56b2016-06-06 18:31:47 -07002307 self.mock(git_cl, 'get_cl_statuses',
2308 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002309 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2310 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2311 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002312
2313 self.assertEqual(0, git_cl.main(['archive', '-f']))
2314
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002315 def test_archive_tag_collision(self):
2316 self.mock(git_cl.sys, 'stdout', StringIO())
2317
2318 self.calls = [
2319 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2320 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2321 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2322 'refs/tags/git-cl-archived-456-foo'),
2323 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2324 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2325 ((['git', 'branch', '-D', 'foo'],), '')
2326 ]
2327
2328 self.mock(git_cl, 'get_cl_statuses',
2329 lambda branches, fine_grained, max_processes:
2330 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2331 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2332 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2333
2334 self.assertEqual(0, git_cl.main(['archive', '-f']))
2335
kmarshall3bff56b2016-06-06 18:31:47 -07002336 def test_archive_current_branch_fails(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002337 self.mock(git_cl.sys, 'stdout', StringIO())
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002338 self.calls = [
2339 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2340 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002341 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002342 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2343 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002344
kmarshall9249e012016-08-23 12:02:16 -07002345 self.mock(git_cl, 'get_cl_statuses',
2346 lambda branches, fine_grained, max_processes:
2347 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2348
2349 self.assertEqual(1, git_cl.main(['archive', '-f']))
2350
2351 def test_archive_dry_run(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002352 self.mock(git_cl.sys, 'stdout', StringIO())
kmarshall9249e012016-08-23 12:02:16 -07002353
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002354 self.calls = [
2355 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2356 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002357 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002358 ((['git', 'symbolic-ref', 'HEAD'],), 'master')
2359 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002360
2361 self.mock(git_cl, 'get_cl_statuses',
2362 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002363 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2364 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2365 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002366
kmarshall9249e012016-08-23 12:02:16 -07002367 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2368
2369 def test_archive_no_tags(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002370 self.mock(git_cl.sys, 'stdout', StringIO())
kmarshall9249e012016-08-23 12:02:16 -07002371
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002372 self.calls = [
2373 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2374 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002375 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002376 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2377 ((['git', 'branch', '-D', 'foo'],), '')
2378 ]
kmarshall9249e012016-08-23 12:02:16 -07002379
2380 self.mock(git_cl, 'get_cl_statuses',
2381 lambda branches, fine_grained, max_processes:
2382 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2383 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2384 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2385
2386 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002387
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002388 def test_archive_tag_cleanup_on_branch_deletion_error(self):
2389 self.mock(git_cl.sys, 'stdout', StringIO())
2390
2391 self.calls = [
2392 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2393 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2394 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
2395 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2396 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2397 'refs/tags/git-cl-archived-456-foo'),
2398 ((['git', 'branch', '-D', 'foo'],), CERR1),
2399 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2400 'refs/tags/git-cl-archived-456-foo'),
2401 ]
2402
2403 self.mock(git_cl, 'get_cl_statuses',
2404 lambda branches, fine_grained, max_processes:
2405 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2406 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2407 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2408
2409 self.assertEqual(0, git_cl.main(['archive', '-f']))
2410
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002411 def test_cmd_issue_erase_existing(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002412 out = StringIO()
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002413 self.mock(git_cl.sys, 'stdout', out)
2414 self.calls = [
2415 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002416 # Let this command raise exception (retcode=1) - it should be ignored.
2417 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002418 CERR1),
2419 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2420 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002421 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2422 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2423 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002424 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002425 ]
2426 self.assertEqual(0, git_cl.main(['issue', '0']))
2427
Aaron Gable400e9892017-07-12 15:31:21 -07002428 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002429 out = StringIO()
Aaron Gable400e9892017-07-12 15:31:21 -07002430 self.mock(git_cl.sys, 'stdout', out)
2431 self.mock(git_cl.Changelist, 'GetDescription',
2432 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2433 self.calls = [
2434 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002435 # Let this command raise exception (retcode=1) - it should be ignored.
2436 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2437 CERR1),
2438 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2439 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2440 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2441 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2442 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002443 ((['git', 'log', '-1', '--format=%B'],),
2444 'This is a description\n\nChange-Id: Ideadbeef'),
2445 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002446 ]
2447 self.assertEqual(0, git_cl.main(['issue', '0']))
2448
phajdan.jre328cf92016-08-22 04:12:17 -07002449 def test_cmd_issue_json(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002450 out = StringIO()
phajdan.jre328cf92016-08-22 04:12:17 -07002451 self.mock(git_cl.sys, 'stdout', out)
2452 self.calls = [
2453 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002454 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2455 ((['git', 'config', 'branch.feature.gerritserver'],),
2456 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002457 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002458 {'issue': 123,
2459 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002460 ''),
2461 ]
2462 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2463
tandrii16e0b4e2016-06-07 10:34:28 -07002464 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002465 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07002466 self.mock(git_cl.os.path, 'abspath',
2467 lambda path: self._mocked_call(['abspath', path]))
2468 self.mock(git_cl.os.path, 'exists',
2469 lambda path: self._mocked_call(['exists', path]))
2470 self.mock(git_cl.gclient_utils, 'FileRead',
2471 lambda path: self._mocked_call(['FileRead', path]))
2472 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2473 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2474 self.calls = [
2475 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2476 ((['abspath', '../'],), '/abs/git_repo_root'),
2477 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002478 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002479
2480 def test_GerritCommitMsgHookCheck_custom_hook(self):
2481 cl = self._common_GerritCommitMsgHookCheck()
2482 self.calls += [
2483 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2484 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2485 '#!/bin/sh\necho "custom hook"')
2486 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002487 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002488
2489 def test_GerritCommitMsgHookCheck_not_exists(self):
2490 cl = self._common_GerritCommitMsgHookCheck()
2491 self.calls += [
2492 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2493 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002494 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002495
2496 def test_GerritCommitMsgHookCheck(self):
2497 cl = self._common_GerritCommitMsgHookCheck()
2498 self.calls += [
2499 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2500 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2501 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002502 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002503 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2504 ''),
2505 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002506 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002507
tandriic4344b52016-08-29 06:04:54 -07002508 def test_GerritCmdLand(self):
2509 self.calls += [
2510 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2511 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2512 'deadbeaf'),
2513 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2514 ((['git', 'config', 'branch.feature.gerritserver'],),
2515 'chromium-review.googlesource.com'),
2516 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002517 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002518 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002519 'labels': {},
2520 'current_revision': 'deadbeaf',
2521 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002522 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002523 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002524 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002525 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2526 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002527 cl.SubmitIssue = lambda wait_for_merge: None
Edward Lemur79d4f992019-11-11 23:49:02 +00002528 out = StringIO()
tandrii8da412c2016-09-07 16:01:07 -07002529 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002530 self.assertEqual(0, cl.CMDLand(force=True,
2531 bypass_hooks=True,
2532 verbose=True,
2533 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002534 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002535 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002536
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002537 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemur125d60a2019-09-13 18:25:41 +00002538 self.mock(git_cl.Changelist, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002539
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002540 def test_gerrit_change_detail_cache_simple(self):
2541 self._mock_gerrit_changes_for_detail_cache()
2542 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002543 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2544 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2545 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002546 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002547 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002548 cl1._cached_remote_url = (
2549 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002550 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002551 cl2._cached_remote_url = (
2552 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002553 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2554 self.assertEqual(cl1._GetChangeDetail(), 'a')
2555 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2556 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2557 self.assertEqual(cl1._GetChangeDetail(), 'a')
2558 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002559
2560 def test_gerrit_change_detail_cache_options(self):
2561 self._mock_gerrit_changes_for_detail_cache()
2562 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002563 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2564 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2565 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2566 # no longer in cache.
2567 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002568 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002569 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002570 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002571 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2572 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2573 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2574 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2575 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2576 self.assertEqual(cl._GetChangeDetail(), 'cab')
2577
2578 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2579 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2580 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2581 self.assertEqual(cl._GetChangeDetail(), 'cab')
2582
2583 # Finally, no_cache should invalidate all caches for given change.
2584 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2585 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2586
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002587 def test_gerrit_description_caching(self):
2588 def gen_detail(rev, desc):
2589 return {
2590 'current_revision': rev,
2591 'revisions': {rev: {'commit': {'message': desc}}}
2592 }
2593 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002594 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002595 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2596 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002597 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002598 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2599 gen_detail('rev2', 'desc2')),
2600 ]
2601
2602 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002603 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002604 cl._cached_remote_url = (
2605 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002606 self.assertEqual(cl.GetDescription(), 'desc1')
2607 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2608 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002609
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002610 def test_print_current_creds(self):
2611 class CookiesAuthenticatorMock(object):
2612 def __init__(self):
2613 self.gitcookies = {
2614 'host.googlesource.com': ('user', 'pass'),
2615 'host-review.googlesource.com': ('user', 'pass'),
2616 }
2617 self.netrc = self
2618 self.netrc.hosts = {
2619 'github.com': ('user2', None, 'pass2'),
2620 'host2.googlesource.com': ('user3', None, 'pass'),
2621 }
2622 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2623 CookiesAuthenticatorMock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002624 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002625 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2626 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2627 ' Host\t User\t Which file',
2628 '============================\t=====\t===========',
2629 'host-review.googlesource.com\t user\t.gitcookies',
2630 ' host.googlesource.com\t user\t.gitcookies',
2631 ' host2.googlesource.com\tuser3\t .netrc',
2632 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002633 sys.stdout.seek(0)
2634 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002635 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2636 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2637 ' Host\tUser\t Which file',
2638 '============================\t====\t===========',
2639 'host-review.googlesource.com\tuser\t.gitcookies',
2640 ' host.googlesource.com\tuser\t.gitcookies',
2641 ])
2642
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002643 def _common_creds_check_mocks(self):
2644 def exists_mock(path):
2645 dirname = os.path.dirname(path)
2646 if dirname == os.path.expanduser('~'):
2647 dirname = '~'
2648 base = os.path.basename(path)
2649 if base in ('.netrc', '.gitcookies'):
2650 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2651 # git cl also checks for existence other files not relevant to this test.
2652 return None
2653 self.mock(os.path, 'exists', exists_mock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002654 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002655
2656 def test_creds_check_gitcookies_not_configured(self):
2657 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002658 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002659 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002660 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002661 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002662 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2663 (('os.path.exists', '~/.netrc'), True),
2664 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2665 'or Ctrl+C to abort'), ''),
2666 ((['git', 'config', '--global', 'http.cookiefile',
2667 os.path.expanduser('~/.gitcookies')], ), ''),
2668 ]
2669 self.assertEqual(0, git_cl.main(['creds-check']))
2670 self.assertRegexpMatches(
2671 sys.stdout.getvalue(),
2672 '^You seem to be using outdated .netrc for git credentials:')
2673 self.assertRegexpMatches(
2674 sys.stdout.getvalue(),
2675 '\nConfigured git to use .gitcookies from')
2676
2677 def test_creds_check_gitcookies_configured_custom_broken(self):
2678 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002679 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002680 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002681 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002682 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002683 ((['git', 'config', '--global', 'http.cookiefile'],),
2684 '/custom/.gitcookies'),
2685 (('os.path.exists', '/custom/.gitcookies'), False),
2686 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2687 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2688 ((['git', 'config', '--global', 'http.cookiefile',
2689 os.path.expanduser('~/.gitcookies')], ), ''),
2690 ]
2691 self.assertEqual(0, git_cl.main(['creds-check']))
2692 self.assertRegexpMatches(
2693 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002694 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002695 self.assertRegexpMatches(
2696 sys.stdout.getvalue(),
2697 'However, your configured .gitcookies file is missing.')
2698
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002699 def test_git_cl_comment_add_gerrit(self):
2700 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002701 lambda host, change, msg, ready:
2702 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002703 self.calls = [
2704 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2705 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2706 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2707 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2708 'origin/master'),
2709 ((['git', 'config', 'remote.origin.url'],),
2710 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002711 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2712 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002713 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002714 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002715 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002716
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002717 def test_git_cl_comments_fetch_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002718 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002719 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002720 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2721 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002722 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2723 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2724 'origin/master'),
2725 ((['git', 'config', 'remote.origin.url'],),
2726 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002727 (('GetChangeDetail', 'chromium-review.googlesource.com',
2728 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002729 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2730 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002731 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002732 'current_revision': 'ba5eba11',
2733 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002734 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002735 '_number': 1,
2736 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002737 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002738 '_number': 2,
2739 },
2740 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002741 'messages': [
2742 {
2743 u'_revision_number': 1,
2744 u'author': {
2745 u'_account_id': 1111084,
2746 u'email': u'commit-bot@chromium.org',
2747 u'name': u'Commit Bot'
2748 },
2749 u'date': u'2017-03-15 20:08:45.000000000',
2750 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002751 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002752 u'tag': u'autogenerated:cq:dry-run'
2753 },
2754 {
2755 u'_revision_number': 2,
2756 u'author': {
2757 u'_account_id': 11151243,
2758 u'email': u'owner@example.com',
2759 u'name': u'owner'
2760 },
2761 u'date': u'2017-03-16 20:00:41.000000000',
2762 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2763 u'message': u'PTAL',
2764 },
2765 {
2766 u'_revision_number': 2,
2767 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002768 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002769 u'email': u'reviewer@example.com',
2770 u'name': u'reviewer'
2771 },
2772 u'date': u'2017-03-17 05:19:37.500000000',
2773 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2774 u'message': u'Patch Set 2: Code-Review+1',
2775 },
2776 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002777 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002778 (('GetChangeComments', 'chromium-review.googlesource.com',
2779 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002780 '/COMMIT_MSG': [
2781 {
2782 'author': {'email': u'reviewer@example.com'},
2783 'updated': u'2017-03-17 05:19:37.500000000',
2784 'patch_set': 2,
2785 'side': 'REVISION',
2786 'message': 'Please include a bug link',
2787 },
2788 ],
2789 'codereview.settings': [
2790 {
2791 'author': {'email': u'owner@example.com'},
2792 'updated': u'2017-03-16 20:00:41.000000000',
2793 'patch_set': 2,
2794 'side': 'PARENT',
2795 'line': 42,
2796 'message': 'I removed this because it is bad',
2797 },
2798 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002799 }),
2800 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2801 'infra%2Finfra~1'), {}),
2802 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002803 ] * 2 + [
2804 (('write_json', 'output.json', [
2805 {
2806 u'date': u'2017-03-16 20:00:41.000000',
2807 u'message': (
2808 u'PTAL\n' +
2809 u'\n' +
2810 u'codereview.settings\n' +
2811 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2812 u'c/1/2/codereview.settings#b42\n' +
2813 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002814 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002815 u'approval': False,
2816 u'disapproval': False,
2817 u'sender': u'owner@example.com'
2818 }, {
2819 u'date': u'2017-03-17 05:19:37.500000',
2820 u'message': (
2821 u'Patch Set 2: Code-Review+1\n' +
2822 u'\n' +
2823 u'/COMMIT_MSG\n' +
2824 u' PS2, File comment: https://chromium-review.googlesource' +
2825 u'.com/c/1/2//COMMIT_MSG#\n' +
2826 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002827 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002828 u'approval': False,
2829 u'disapproval': False,
2830 u'sender': u'reviewer@example.com'
2831 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002832 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002833 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002834 expected_comments_summary = [
2835 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002836 message=(
2837 u'PTAL\n' +
2838 u'\n' +
2839 u'codereview.settings\n' +
2840 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2841 u'c/1/2/codereview.settings#b42\n' +
2842 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002843 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002844 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002845 disapproval=False, approval=False, sender=u'owner@example.com'),
2846 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002847 message=(
2848 u'Patch Set 2: Code-Review+1\n' +
2849 u'\n' +
2850 u'/COMMIT_MSG\n' +
2851 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2852 u'c/1/2//COMMIT_MSG#\n' +
2853 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002854 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002855 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002856 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2857 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002858 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002859 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002860 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002861 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
2862 self.assertEqual(
2863 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2864
2865 def test_git_cl_comments_robot_comments(self):
2866 # git cl comments also fetches robot comments (which are considered a type
2867 # of autogenerated comment), and unlike other types of comments, only robot
2868 # comments from the latest patchset are shown.
Edward Lemur79d4f992019-11-11 23:49:02 +00002869 self.mock(sys, 'stdout', StringIO())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002870 self.calls = [
2871 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2872 ((['git', 'config', 'branch.foo.merge'],), ''),
2873 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2874 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2875 'origin/master'),
2876 ((['git', 'config', 'remote.origin.url'],),
2877 'https://chromium.googlesource.com/infra/infra'),
2878 (('GetChangeDetail', 'chromium-review.googlesource.com',
2879 'infra%2Finfra~1',
2880 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2881 'CURRENT_COMMIT']), {
2882 'owner': {'email': 'owner@example.com'},
2883 'current_revision': 'ba5eba11',
2884 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002885 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002886 '_number': 1,
2887 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002888 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002889 '_number': 2,
2890 },
2891 },
2892 'messages': [
2893 {
2894 u'_revision_number': 1,
2895 u'author': {
2896 u'_account_id': 1111084,
2897 u'email': u'commit-bot@chromium.org',
2898 u'name': u'Commit Bot'
2899 },
2900 u'date': u'2017-03-15 20:08:45.000000000',
2901 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2902 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2903 u'tag': u'autogenerated:cq:dry-run'
2904 },
2905 {
2906 u'_revision_number': 1,
2907 u'author': {
2908 u'_account_id': 123,
2909 u'email': u'tricium@serviceaccount.com',
2910 u'name': u'Tricium'
2911 },
2912 u'date': u'2017-03-16 20:00:41.000000000',
2913 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2914 u'message': u'(1 comment)',
2915 u'tag': u'autogenerated:tricium',
2916 },
2917 {
2918 u'_revision_number': 1,
2919 u'author': {
2920 u'_account_id': 123,
2921 u'email': u'tricium@serviceaccount.com',
2922 u'name': u'Tricium'
2923 },
2924 u'date': u'2017-03-16 20:00:41.000000000',
2925 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2926 u'message': u'(1 comment)',
2927 u'tag': u'autogenerated:tricium',
2928 },
2929 {
2930 u'_revision_number': 2,
2931 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002932 u'_account_id': 123,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002933 u'email': u'tricium@serviceaccount.com',
2934 u'name': u'reviewer'
2935 },
2936 u'date': u'2017-03-17 05:30:37.000000000',
2937 u'tag': u'autogenerated:tricium',
2938 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2939 u'message': u'(1 comment)',
2940 },
2941 ]
2942 }),
2943 (('GetChangeComments', 'chromium-review.googlesource.com',
2944 'infra%2Finfra~1'), {}),
2945 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2946 'infra%2Finfra~1'), {
2947 'codereview.settings': [
2948 {
2949 u'author': {u'email': u'tricium@serviceaccount.com'},
2950 u'updated': u'2017-03-17 05:30:37.000000000',
2951 u'robot_run_id': u'5565031076855808',
2952 u'robot_id': u'Linter/Category',
2953 u'tag': u'autogenerated:tricium',
2954 u'patch_set': 2,
2955 u'side': u'REVISION',
2956 u'message': u'Linter warning message text',
2957 u'line': 32,
2958 },
2959 ],
2960 }),
2961 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
2962 ]
2963 expected_comments_summary = [
2964 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2965 message=(
2966 u'(1 comment)\n\ncodereview.settings\n'
2967 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2968 u'c/1/2/codereview.settings#32\n'
2969 u' Linter warning message text\n'),
2970 sender=u'tricium@serviceaccount.com',
2971 autogenerated=True, approval=False, disapproval=False)
2972 ]
2973 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002974 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002975 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002976
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002977 def test_get_remote_url_with_mirror(self):
2978 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002979
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002980 def selective_os_path_isdir_mock(path):
2981 if path == '/cache/this-dir-exists':
2982 return self._mocked_call('os.path.isdir', path)
2983 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002984
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002985 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2986
2987 url = 'https://chromium.googlesource.com/my/repo'
2988 self.calls = [
2989 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2990 ((['git', 'config', 'branch.master.merge'],), 'master'),
2991 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2992 ((['git', 'config', 'remote.origin.url'],),
2993 '/cache/this-dir-exists'),
2994 (('os.path.isdir', '/cache/this-dir-exists'),
2995 True),
2996 # Runs in /cache/this-dir-exists.
2997 ((['git', 'config', 'remote.origin.url'],),
2998 url),
2999 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003000 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003001 self.assertEqual(cl.GetRemoteUrl(), url)
3002 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3003
Edward Lemur298f2cf2019-02-22 21:40:39 +00003004 def test_get_remote_url_non_existing_mirror(self):
3005 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003006
Edward Lemur298f2cf2019-02-22 21:40:39 +00003007 def selective_os_path_isdir_mock(path):
3008 if path == '/cache/this-dir-doesnt-exist':
3009 return self._mocked_call('os.path.isdir', path)
3010 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003011
Edward Lemur298f2cf2019-02-22 21:40:39 +00003012 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3013 self.mock(logging, 'error',
Josip906bfde2020-01-31 22:38:49 +00003014 lambda *a: self._mocked_call('logging.error', *a))
Edward Lemur298f2cf2019-02-22 21:40:39 +00003015
3016 self.calls = [
3017 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3018 ((['git', 'config', 'branch.master.merge'],), 'master'),
3019 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3020 ((['git', 'config', 'remote.origin.url'],),
3021 '/cache/this-dir-doesnt-exist'),
3022 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3023 False),
3024 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00003025 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
3026 'but it doesn\'t exist.', {
3027 'remote': 'origin',
3028 'branch': 'master',
3029 'url': '/cache/this-dir-doesnt-exist'}
3030 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00003031 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003032 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003033 self.assertIsNone(cl.GetRemoteUrl())
3034
3035 def test_get_remote_url_misconfigured_mirror(self):
3036 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003037
Edward Lemur298f2cf2019-02-22 21:40:39 +00003038 def selective_os_path_isdir_mock(path):
3039 if path == '/cache/this-dir-exists':
3040 return self._mocked_call('os.path.isdir', path)
3041 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003042
Edward Lemur298f2cf2019-02-22 21:40:39 +00003043 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3044 self.mock(logging, 'error',
3045 lambda *a: self._mocked_call('logging.error', *a))
3046
3047 self.calls = [
3048 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3049 ((['git', 'config', 'branch.master.merge'],), 'master'),
3050 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3051 ((['git', 'config', 'remote.origin.url'],),
3052 '/cache/this-dir-exists'),
3053 (('os.path.isdir', '/cache/this-dir-exists'), True),
3054 # Runs in /cache/this-dir-exists.
3055 ((['git', 'config', 'remote.origin.url'],), ''),
3056 (('logging.error',
3057 'Remote "%(remote)s" for branch "%(branch)s" points to '
3058 '"%(cache_path)s", but it is misconfigured.\n'
3059 '"%(cache_path)s" must be a git repo and must have a remote named '
3060 '"%(remote)s" pointing to the git host.', {
3061 'remote': 'origin',
3062 'cache_path': '/cache/this-dir-exists',
3063 'branch': 'master'}
3064 ), None),
3065 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003066 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003067 self.assertIsNone(cl.GetRemoteUrl())
3068
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003069 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003070 self.calls = [
3071 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3072 ((['git', 'config', 'branch.master.merge'],), 'master'),
3073 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3074 ((['git', 'config', 'remote.origin.url'],),
3075 'https://chromium.googlesource.com/a/my/repo.git/'),
3076 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003077 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003078 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3079
3080 def test_gerrit_change_identifier_without_project(self):
Josip906bfde2020-01-31 22:38:49 +00003081 self.mock(logging, 'error',
3082 lambda *a: self._mocked_call('logging.error', *a))
3083
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003084 self.calls = [
3085 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3086 ((['git', 'config', 'branch.master.merge'],), 'master'),
3087 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3088 ((['git', 'config', 'remote.origin.url'],), CERR1),
Josip906bfde2020-01-31 22:38:49 +00003089 (('logging.error',
3090 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
3091 'but it doesn\'t exist.', {
3092 'remote': 'origin',
3093 'branch': 'master',
3094 'url': ''}
3095 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003096 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003097 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003098 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003099
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003100
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003101class CMDTestCaseBase(unittest.TestCase):
3102 _STATUSES = [
3103 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3104 'INFRA_FAILURE', 'CANCELED',
3105 ]
3106 _CHANGE_DETAIL = {
3107 'project': 'depot_tools',
3108 'status': 'OPEN',
3109 'owner': {'email': 'owner@e.mail'},
3110 'current_revision': 'beeeeeef',
3111 'revisions': {
3112 'deadbeaf': {'_number': 6},
3113 'beeeeeef': {
3114 '_number': 7,
3115 'fetch': {'http': {
3116 'url': 'https://chromium.googlesource.com/depot_tools',
3117 'ref': 'refs/changes/56/123456/7'
3118 }},
3119 },
3120 },
3121 }
3122 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003123 'builds': [{
3124 'id': str(100 + idx),
3125 'builder': {
3126 'project': 'chromium',
3127 'bucket': 'try',
3128 'builder': 'bot_' + status.lower(),
3129 },
3130 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3131 'tags': [],
3132 'status': status,
3133 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003134 }
3135
Edward Lemur4c707a22019-09-24 21:13:43 +00003136 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003137 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003138 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003139 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3140 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003141 mock.patch('git_cl.Changelist.GetCodereviewServer',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003142 return_value='https://chromium-review.googlesource.com').start()
3143 mock.patch('git_cl.Changelist.GetMostRecentPatchset',
3144 return_value=7).start()
Edward Lemur5b929a42019-10-21 17:57:39 +00003145 mock.patch('git_cl.auth.Authenticator',
Edward Lemurb4a587d2019-10-09 23:56:38 +00003146 return_value=AuthenticatorMock()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003147 mock.patch('git_cl.Changelist._GetChangeDetail',
3148 return_value=self._CHANGE_DETAIL).start()
3149 mock.patch('git_cl._call_buildbucket',
3150 return_value = self._DEFAULT_RESPONSE).start()
3151 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003152 self.addCleanup(mock.patch.stopall)
3153
Edward Lemur4c707a22019-09-24 21:13:43 +00003154
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003155class CMDTryResultsTestCase(CMDTestCaseBase):
3156 _DEFAULT_REQUEST = {
3157 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003158 "gerritChanges": [{
3159 "project": "depot_tools",
3160 "host": "chromium-review.googlesource.com",
3161 "patchset": 7,
3162 "change": 123456,
3163 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003164 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003165 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3166 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003167 }
3168
3169 def testNoJobs(self):
3170 git_cl._call_buildbucket.return_value = {}
3171
3172 self.assertEqual(0, git_cl.main(['try-results']))
3173 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3174 git_cl._call_buildbucket.assert_called_once_with(
3175 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3176 self._DEFAULT_REQUEST)
3177
3178 def testPrintToStdout(self):
3179 self.assertEqual(0, git_cl.main(['try-results']))
3180 self.assertEqual([
3181 'Successes:',
3182 ' bot_success https://ci.chromium.org/b/103',
3183 'Infra Failures:',
3184 ' bot_infra_failure https://ci.chromium.org/b/105',
3185 'Failures:',
3186 ' bot_failure https://ci.chromium.org/b/104',
3187 'Canceled:',
3188 ' bot_canceled ',
3189 'Started:',
3190 ' bot_started https://ci.chromium.org/b/102',
3191 'Scheduled:',
3192 ' bot_scheduled id=101',
3193 'Other:',
3194 ' bot_status_unspecified id=100',
3195 'Total: 7 tryjobs',
3196 ], sys.stdout.getvalue().splitlines())
3197 git_cl._call_buildbucket.assert_called_once_with(
3198 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3199 self._DEFAULT_REQUEST)
3200
3201 def testPrintToStdoutWithMasters(self):
3202 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3203 self.assertEqual([
3204 'Successes:',
3205 ' try bot_success https://ci.chromium.org/b/103',
3206 'Infra Failures:',
3207 ' try bot_infra_failure https://ci.chromium.org/b/105',
3208 'Failures:',
3209 ' try bot_failure https://ci.chromium.org/b/104',
3210 'Canceled:',
3211 ' try bot_canceled ',
3212 'Started:',
3213 ' try bot_started https://ci.chromium.org/b/102',
3214 'Scheduled:',
3215 ' try bot_scheduled id=101',
3216 'Other:',
3217 ' try bot_status_unspecified id=100',
3218 'Total: 7 tryjobs',
3219 ], sys.stdout.getvalue().splitlines())
3220 git_cl._call_buildbucket.assert_called_once_with(
3221 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3222 self._DEFAULT_REQUEST)
3223
3224 @mock.patch('git_cl.write_json')
3225 def testWriteToJson(self, mockJsonDump):
3226 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3227 git_cl._call_buildbucket.assert_called_once_with(
3228 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3229 self._DEFAULT_REQUEST)
3230 mockJsonDump.assert_called_once_with(
3231 'file.json', self._DEFAULT_RESPONSE['builds'])
3232
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003233 def test_filter_failed_for_one_simple(self):
3234 self.assertEqual({}, git_cl._filter_failed_for_retry([]))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003235 self.assertEqual({
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003236 'chromium/try': {
3237 'bot_failure': [],
3238 'bot_infra_failure': []
3239 },
3240 }, git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
3241
3242 def test_filter_failed_for_retry_many_builds(self):
3243
3244 def _build(name, created_sec, status, experimental=False):
3245 assert 0 <= created_sec < 100, created_sec
3246 b = {
3247 'id': 112112,
3248 'builder': {
3249 'project': 'chromium',
3250 'bucket': 'try',
3251 'builder': name,
3252 },
3253 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3254 'status': status,
3255 'tags': [],
3256 }
3257 if experimental:
3258 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3259 return b
3260
3261 builds = [
3262 _build('flaky-last-green', 1, 'FAILURE'),
3263 _build('flaky-last-green', 2, 'SUCCESS'),
3264 _build('flaky', 1, 'SUCCESS'),
3265 _build('flaky', 2, 'FAILURE'),
3266 _build('running', 1, 'FAILED'),
3267 _build('running', 2, 'SCHEDULED'),
3268 _build('yep-still-running', 1, 'STARTED'),
3269 _build('yep-still-running', 2, 'FAILURE'),
3270 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3271 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3272
3273 # Simulate experimental in CQ builder, which developer decided
3274 # to retry manually which resulted in 2nd build non-experimental.
3275 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3276 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3277 ]
3278 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
3279 self.assertEqual({
3280 'chromium/try': {
3281 'flaky': [],
3282 'sometimes-experimental': []
3283 },
3284 }, git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003285
3286
3287class CMDTryTestCase(CMDTestCaseBase):
3288
3289 @mock.patch('git_cl.Changelist.SetCQState')
3290 @mock.patch('git_cl._get_bucket_map', return_value={})
3291 def testSetCQDryRunByDefault(self, _mockGetBucketMap, mockSetCQState):
3292 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003293 self.assertEqual(0, git_cl.main(['try']))
3294 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3295 self.assertEqual(
3296 sys.stdout.getvalue(),
3297 'Scheduling CQ dry run on: '
3298 'https://chromium-review.googlesource.com/123456\n')
3299
Edward Lemur4c707a22019-09-24 21:13:43 +00003300 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003301 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003302 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003303
3304 self.assertEqual(0, git_cl.main([
3305 'try', '-B', 'luci.chromium.try', '-b', 'win',
3306 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3307 self.assertIn(
3308 'Scheduling jobs on:\nBucket: luci.chromium.try',
3309 git_cl.sys.stdout.getvalue())
3310
3311 expected_request = {
3312 "requests": [{
3313 "scheduleBuild": {
3314 "requestId": "uuid4",
3315 "builder": {
3316 "project": "chromium",
3317 "builder": "win",
3318 "bucket": "try",
3319 },
3320 "gerritChanges": [{
3321 "project": "depot_tools",
3322 "host": "chromium-review.googlesource.com",
3323 "patchset": 7,
3324 "change": 123456,
3325 }],
3326 "properties": {
3327 "category": "git_cl_try",
3328 "json": [{"a": 1}, None],
3329 "key": "val",
3330 },
3331 "tags": [
3332 {"value": "win", "key": "builder"},
3333 {"value": "git_cl_try", "key": "user_agent"},
3334 ],
3335 },
3336 }],
3337 }
3338 mockCallBuildbucket.assert_called_with(
3339 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3340
Anthony Polito1a5fe232020-01-24 23:17:52 +00003341 @mock.patch('git_cl._call_buildbucket')
3342 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3343 mockCallBuildbucket.return_value = {}
3344
3345 self.assertEqual(0, git_cl.main([
3346 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3347 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3348 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3349 self.assertIn(
3350 'Scheduling jobs on:\nBucket: luci.chromium.try',
3351 git_cl.sys.stdout.getvalue())
3352
3353 expected_request = {
3354 "requests": [{
3355 "scheduleBuild": {
3356 "requestId": "uuid4",
3357 "builder": {
3358 "project": "chromium",
3359 "builder": "linux",
3360 "bucket": "try",
3361 },
3362 "gerritChanges": [{
3363 "project": "depot_tools",
3364 "host": "chromium-review.googlesource.com",
3365 "patchset": 7,
3366 "change": 123456,
3367 }],
3368 "properties": {
3369 "category": "git_cl_try",
3370 "json": [{"a": 1}, None],
3371 "key": "val",
3372 },
3373 "tags": [
3374 {"value": "linux", "key": "builder"},
3375 {"value": "git_cl_try", "key": "user_agent"},
3376 ],
3377 "gitilesCommit": {
3378 "host": "chromium-review.googlesource.com",
3379 "project": "depot_tools",
3380 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3381 }
3382 },
3383 },
3384 {
3385 "scheduleBuild": {
3386 "requestId": "uuid4",
3387 "builder": {
3388 "project": "chromium",
3389 "builder": "win",
3390 "bucket": "try",
3391 },
3392 "gerritChanges": [{
3393 "project": "depot_tools",
3394 "host": "chromium-review.googlesource.com",
3395 "patchset": 7,
3396 "change": 123456,
3397 }],
3398 "properties": {
3399 "category": "git_cl_try",
3400 "json": [{"a": 1}, None],
3401 "key": "val",
3402 },
3403 "tags": [
3404 {"value": "win", "key": "builder"},
3405 {"value": "git_cl_try", "key": "user_agent"},
3406 ],
3407 "gitilesCommit": {
3408 "host": "chromium-review.googlesource.com",
3409 "project": "depot_tools",
3410 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3411 }
3412 },
3413 }],
3414 }
3415 mockCallBuildbucket.assert_called_with(
3416 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3417
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003418 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur4c707a22019-09-24 21:13:43 +00003419 self.assertEqual(0, git_cl.main([
3420 'try', '-B', 'not-a-bucket', '-b', 'win',
3421 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3422 self.assertIn(
3423 'WARNING Could not parse bucket "not-a-bucket". Skipping.',
3424 git_cl.sys.stdout.getvalue())
3425
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003426 @mock.patch('git_cl._call_buildbucket')
3427 @mock.patch('git_cl.fetch_try_jobs')
3428 def testScheduleOnBuildbucketRetryFailed(
3429 self, mockFetchTryJobs, mockCallBuildbucket):
3430
3431 git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: {
3432 7: [],
3433 6: [{
3434 'id': 112112,
3435 'builder': {
3436 'project': 'chromium',
3437 'bucket': 'try',
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003438 'builder': 'linux',},
3439 'createTime': '2019-10-09T08:00:01.854286Z',
3440 'tags': [],
3441 'status': 'FAILURE',}],}[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003442 mockCallBuildbucket.return_value = {}
3443
3444 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3445 self.assertIn(
3446 'Scheduling jobs on:\nBucket: chromium/try',
3447 git_cl.sys.stdout.getvalue())
3448
3449 expected_request = {
3450 "requests": [{
3451 "scheduleBuild": {
3452 "requestId": "uuid4",
3453 "builder": {
3454 "project": "chromium",
3455 "bucket": "try",
3456 "builder": "linux",
3457 },
3458 "gerritChanges": [{
3459 "project": "depot_tools",
3460 "host": "chromium-review.googlesource.com",
3461 "patchset": 7,
3462 "change": 123456,
3463 }],
3464 "properties": {
3465 "category": "git_cl_try",
3466 },
3467 "tags": [
3468 {"value": "linux", "key": "builder"},
3469 {"value": "git_cl_try", "key": "user_agent"},
3470 {"value": "1", "key": "retry_failed"},
3471 ],
3472 },
3473 }],
3474 }
3475 mockCallBuildbucket.assert_called_with(
3476 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3477
Edward Lemur4c707a22019-09-24 21:13:43 +00003478 def test_parse_bucket(self):
3479 test_cases = [
3480 {
3481 'bucket': 'chromium/try',
3482 'result': ('chromium', 'try'),
3483 },
3484 {
3485 'bucket': 'luci.chromium.try',
3486 'result': ('chromium', 'try'),
3487 'has_warning': True,
3488 },
3489 {
3490 'bucket': 'skia.primary',
3491 'result': ('skia', 'skia.primary'),
3492 'has_warning': True,
3493 },
3494 {
3495 'bucket': 'not-a-bucket',
3496 'result': (None, None),
3497 },
3498 ]
3499
3500 for test_case in test_cases:
3501 git_cl.sys.stdout.truncate(0)
3502 self.assertEqual(
3503 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3504 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003505 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3506 test_case['result'])
3507 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003508
3509
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003510class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003511 def setUp(self):
3512 super(CMDUploadTestCase, self).setUp()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003513 mock.patch('git_cl.fetch_try_jobs').start()
3514 mock.patch('git_cl._trigger_try_jobs', return_value={}).start()
3515 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Anthony Polito46689b02019-11-15 20:56:41 +00003516 mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003517 self.addCleanup(mock.patch.stopall)
3518
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003519 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003520 # This test mocks out the actual upload part, and just asserts that after
3521 # upload, if --retry-failed is added, then the tool will fetch try jobs
3522 # from the previous patchset and trigger the right builders on the latest
3523 # patchset.
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003524 git_cl.fetch_try_jobs.side_effect = [
3525 # Latest patchset: No builds.
3526 [],
3527 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003528 [{
3529 'id': str(100 + idx),
3530 'builder': {
3531 'project': 'chromium',
3532 'bucket': 'try',
3533 'builder': 'bot_' + status.lower(),
3534 },
3535 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3536 'tags': [],
3537 'status': status,
3538 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003539 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003540
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003541 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003542 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003543 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3544 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003545 ], git_cl.fetch_try_jobs.mock_calls)
3546 expected_buckets = {
3547 'chromium/try': {'bot_failure': [], 'bot_infra_failure': []},
3548 }
3549 git_cl._trigger_try_jobs.assert_called_once_with(
Edward Lemur5b929a42019-10-21 17:57:39 +00003550 mock.ANY, expected_buckets, mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003551
Brian Sheedy59b06a82019-10-14 17:03:29 +00003552
3553class CMDFormatTestCase(TestCase):
3554
3555 def setUp(self):
3556 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003557 mock.patch('git_cl.RunCommand').start()
3558 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3559 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3560 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003561 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003562 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003563
3564 def tearDown(self):
3565 shutil.rmtree(self._top_dir)
3566 super(CMDFormatTestCase, self).tearDown()
3567
Jamie Madill5e96ad12020-01-13 16:08:35 +00003568 def _make_temp_file(self, fname, contents):
3569 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3570 tf.write('\n'.join(contents))
3571
Brian Sheedy59b06a82019-10-14 17:03:29 +00003572 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003573 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003574
Brian Sheedyb4307d52019-12-02 19:18:17 +00003575 def _check_yapf_filtering(self, files, expected):
3576 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3577 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003578
Jamie Madill5e96ad12020-01-13 16:08:35 +00003579 def testClangFormatDiffFull(self):
3580 self._make_temp_file('test.cc', ['// test'])
3581 git_cl.settings.GetFormatFullByDefault.return_value = False
3582 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3583 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3584
3585 # Diff
3586 git_cl.RunCommand.return_value = ' // test'
3587 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3588 self._top_dir, 'HEAD')
3589 self.assertEqual(2, return_value)
3590
3591 # No diff
3592 git_cl.RunCommand.return_value = '// test'
3593 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3594 self._top_dir, 'HEAD')
3595 self.assertEqual(0, return_value)
3596
3597 def testClangFormatDiff(self):
3598 git_cl.settings.GetFormatFullByDefault.return_value = False
3599 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3600
3601 # Diff
3602 git_cl.RunCommand.return_value = 'error'
3603 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3604 'HEAD')
3605 self.assertEqual(2, return_value)
3606
3607 # No diff
3608 git_cl.RunCommand.return_value = ''
3609 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3610 'HEAD')
3611 self.assertEqual(0, return_value)
3612
Brian Sheedyb4307d52019-12-02 19:18:17 +00003613 def testYapfignoreExplicit(self):
3614 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3615 files = [
3616 'bar.py',
3617 'foo/bar.py',
3618 'foo/baz.py',
3619 'foo/bar/baz.py',
3620 'foo/bar/foobar.py',
3621 ]
3622 expected = [
3623 'bar.py',
3624 'foo/baz.py',
3625 'foo/bar/foobar.py',
3626 ]
3627 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003628
Brian Sheedyb4307d52019-12-02 19:18:17 +00003629 def testYapfignoreSingleWildcards(self):
3630 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3631 files = [
3632 'bar.py', # Matched by *bar.py.
3633 'bar.txt',
3634 'foobar.py', # Matched by *bar.py, foo*.
3635 'foobar.txt', # Matched by foo*.
3636 'bazbar.py', # Matched by *bar.py, baz*.py.
3637 'bazbar.txt',
3638 'foo/baz.txt', # Matched by foo*.
3639 'bar/bar.py', # Matched by *bar.py.
3640 'baz/foo.py', # Matched by baz*.py, foo*.
3641 'baz/foo.txt',
3642 ]
3643 expected = [
3644 'bar.txt',
3645 'bazbar.txt',
3646 'baz/foo.txt',
3647 ]
3648 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003649
Brian Sheedyb4307d52019-12-02 19:18:17 +00003650 def testYapfignoreMultiplewildcards(self):
3651 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3652 files = [
3653 'bar.py', # Matched by *bar*.
3654 'bar.txt', # Matched by *bar*.
3655 'abar.py', # Matched by *bar*.
3656 'foobaz.txt', # Matched by *foo*baz.txt.
3657 'foobaz.py',
3658 'afoobaz.txt', # Matched by *foo*baz.txt.
3659 ]
3660 expected = [
3661 'foobaz.py',
3662 ]
3663 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003664
3665 def testYapfignoreComments(self):
3666 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003667 files = [
3668 'test.py',
3669 'test2.py',
3670 ]
3671 expected = [
3672 'test2.py',
3673 ]
3674 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003675
3676 def testYapfignoreBlankLines(self):
3677 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003678 files = [
3679 'test.py',
3680 'test2.py',
3681 'test3.py',
3682 ]
3683 expected = [
3684 'test3.py',
3685 ]
3686 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003687
3688 def testYapfignoreWhitespace(self):
3689 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003690 files = [
3691 'test.py',
3692 'test2.py',
3693 ]
3694 expected = [
3695 'test2.py',
3696 ]
3697 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003698
Brian Sheedyb4307d52019-12-02 19:18:17 +00003699 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003700 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003701 self._check_yapf_filtering([], [])
3702
3703 def testYapfignoreMissingYapfignore(self):
3704 files = [
3705 'test.py',
3706 ]
3707 expected = [
3708 'test.py',
3709 ]
3710 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003711
3712
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003713if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003714 logging.basicConfig(
3715 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003716 unittest.main()