blob: de8ce6ade580fb8bf815aa5c1a452245f60eddc0 [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env python3
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
Gavin Maka94d8fe2023-09-05 18:05:01 +000038import urllib.parse as urlparse
39import urllib.request as urllib_request
40import urllib.error as urllib_error
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000041from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000042
43# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000044import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000045import gclient_paths # Exposed through the API
46import gclient_utils
Josip Sokcevic7958e302023-03-01 23:02:21 +000047import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000048import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000049import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020050import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000051import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000052import rdb_wrapper
Josip Sokcevic7958e302023-03-01 23:02:21 +000053import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000054import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000055
56
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000057# Ask for feedback only once in program lifetime.
58_ASKED_FOR_FEEDBACK = False
59
Bruce Dawsondca14bc2022-09-15 20:59:38 +000060# Set if super-verbose mode is requested, for tracking where presubmit messages
61# are coming from.
62_SHOW_CALLSTACKS = False
63
64
Edward Lemurecc27072020-01-06 16:42:34 +000065def time_time():
66 # Use this so that it can be mocked in tests without interfering with python
67 # system machinery.
68 return time.time()
69
70
maruel@chromium.org899e1c12011-04-07 17:03:18 +000071class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000072 pass
73
74
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000075class CommandData(object):
Bruce Dawsonb6cb9e02023-05-18 20:52:43 +000076 def __init__(self, name, cmd, kwargs, message, python3=True):
77 # The python3 argument is ignored but has to be retained because of the many
78 # callers in other repos that pass it in.
79 del python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000080 self.name = name
81 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040082 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000083 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040084 self.kwargs['stdout'] = subprocess.PIPE
85 self.kwargs['stderr'] = subprocess.STDOUT
86 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000087 self.message = message
88 self.info = None
Bruce Dawsonb6cb9e02023-05-18 20:52:43 +000089
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000090
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000091
Edward Lesmes8e282792018-04-03 18:50:29 -040092# Adapted from
93# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
94#
95# An object that catches SIGINT sent to the Python process and notices
96# if processes passed to wait() die by SIGINT (we need to look for
97# both of those cases, because pressing Ctrl+C can result in either
98# the main process or one of the subprocesses getting the signal).
99#
100# Before a SIGINT is seen, wait(p) will simply call p.wait() and
101# return the result. Once a SIGINT has been seen (in the main process
102# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000103# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400104class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400105 sigint_returncodes = {-signal.SIGINT, # Unix
106 -1073741510, # Windows
107 }
108 def __init__(self):
109 self.__lock = threading.Lock()
110 self.__processes = set()
111 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000112 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400113
114 def __on_sigint(self):
115 self.__got_sigint = True
116 while self.__processes:
117 try:
118 self.__processes.pop().terminate()
119 except OSError:
120 pass
121
Edward Lemur9a5bb612019-09-26 02:01:52 +0000122 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400123 with self.__lock:
124 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000125 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400126
127 def got_sigint(self):
128 with self.__lock:
129 return self.__got_sigint
130
131 def wait(self, p, stdin):
132 with self.__lock:
133 if self.__got_sigint:
134 p.terminate()
135 self.__processes.add(p)
136 stdout, stderr = p.communicate(stdin)
137 code = p.returncode
138 with self.__lock:
139 self.__processes.discard(p)
140 if code in self.sigint_returncodes:
141 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400142 return stdout, stderr
143
144sigint_handler = SigintHandler()
145
146
Edward Lemurecc27072020-01-06 16:42:34 +0000147class Timer(object):
148 def __init__(self, timeout, fn):
149 self.completed = False
150 self._fn = fn
151 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
152
153 def __enter__(self):
154 if self._timer:
155 self._timer.start()
156 return self
157
158 def __exit__(self, _type, _value, _traceback):
159 if self._timer:
160 self._timer.cancel()
161
162 def _onTimer(self):
163 self._fn()
164 self.completed = True
165
166
Edward Lesmes8e282792018-04-03 18:50:29 -0400167class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000168 def __init__(self, pool_size=None, timeout=None):
169 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400170 self._pool_size = pool_size or multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000171 if sys.platform == 'win32':
172 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
173 # Windows or Python3 may hang.
174 self._pool_size = min(self._pool_size, 56)
Edward Lesmes8e282792018-04-03 18:50:29 -0400175 self._messages = []
176 self._messages_lock = threading.Lock()
177 self._tests = []
178 self._tests_lock = threading.Lock()
179 self._nonparallel_tests = []
180
Edward Lemurecc27072020-01-06 16:42:34 +0000181 def _GetCommand(self, test):
Bruce Dawsonb6cb9e02023-05-18 20:52:43 +0000182 vpython = 'vpython3'
Edward Lemur940c2822019-08-23 00:34:25 +0000183 if sys.platform == 'win32':
184 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400185
186 cmd = test.cmd
187 if cmd[0] == 'python':
188 cmd = list(cmd)
189 cmd[0] = vpython
190 elif cmd[0].endswith('.py'):
191 cmd = [vpython] + cmd
192
Edward Lemur336e51f2019-11-14 21:42:04 +0000193 # On Windows, scripts on the current directory take precedence over PATH, so
194 # that when testing depot_tools on Windows, calling `vpython.bat` will
195 # execute the copy of vpython of the depot_tools under test instead of the
196 # one in the bot.
197 # As a workaround, we run the tests from the parent directory instead.
198 if (cmd[0] == vpython and
199 'cwd' in test.kwargs and
200 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
201 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
202 cmd[1] = os.path.join('depot_tools', cmd[1])
203
Edward Lemurecc27072020-01-06 16:42:34 +0000204 return cmd
205
206 def _RunWithTimeout(self, cmd, stdin, kwargs):
207 p = subprocess.Popen(cmd, **kwargs)
208 with Timer(self.timeout, p.terminate) as timer:
209 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000210 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000211 if timer.completed:
212 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000213 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000214
Josip Sokcevica4b871e2023-05-18 14:27:56 +0000215 def CallCommand(self, test, show_callstack=None):
Edward Lemurecc27072020-01-06 16:42:34 +0000216 """Runs an external program.
217
Edward Lemura5799e32020-01-17 19:26:51 +0000218 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000219 to vpython invocations.
220 """
221 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400222 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000223 start = time_time()
224 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
225 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000226 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000227 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400228 return test.message(
Josip Sokcevica4b871e2023-05-18 14:27:56 +0000229 '%s\n%s exec failure (%4.2fs)\n%s' %
230 (test.name, ' '.join(cmd), duration, traceback.format_exc()),
231 show_callstack=show_callstack)
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000232
Edward Lemurecc27072020-01-06 16:42:34 +0000233 if returncode != 0:
Josip Sokcevica4b871e2023-05-18 14:27:56 +0000234 return test.message('%s\n%s (%4.2fs) failed\n%s' %
235 (test.name, ' '.join(cmd), duration, stdout),
236 show_callstack=show_callstack)
Edward Lemurecc27072020-01-06 16:42:34 +0000237
Edward Lesmes8e282792018-04-03 18:50:29 -0400238 if test.info:
Josip Sokcevica4b871e2023-05-18 14:27:56 +0000239 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration),
240 show_callstack=show_callstack)
Edward Lesmes8e282792018-04-03 18:50:29 -0400241
242 def AddTests(self, tests, parallel=True):
243 if parallel:
244 self._tests.extend(tests)
245 else:
246 self._nonparallel_tests.extend(tests)
247
248 def RunAsync(self):
249 self._messages = []
250
251 def _WorkerFn():
252 while True:
253 test = None
254 with self._tests_lock:
255 if not self._tests:
256 break
257 test = self._tests.pop()
Josip Sokcevica4b871e2023-05-18 14:27:56 +0000258 result = self.CallCommand(test, show_callstack=False)
Edward Lesmes8e282792018-04-03 18:50:29 -0400259 if result:
260 with self._messages_lock:
261 self._messages.append(result)
262
263 def _StartDaemon():
264 t = threading.Thread(target=_WorkerFn)
265 t.daemon = True
266 t.start()
267 return t
268
269 while self._nonparallel_tests:
270 test = self._nonparallel_tests.pop()
271 result = self.CallCommand(test)
272 if result:
273 self._messages.append(result)
274
275 if self._tests:
276 threads = [_StartDaemon() for _ in range(self._pool_size)]
277 for worker in threads:
278 worker.join()
279
280 return self._messages
281
282
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000283def normpath(path):
284 '''Version of os.path.normpath that also changes backward slashes to
285 forward slashes when not running on Windows.
286 '''
287 # This is safe to always do because the Windows version of os.path.normpath
288 # will replace forward slashes with backward slashes.
289 path = path.replace(os.sep, '/')
290 return os.path.normpath(path)
291
292
Josip Sokcevic7958e302023-03-01 23:02:21 +0000293def _RightHandSideLinesImpl(affected_files):
294 """Implements RightHandSideLines for InputApi and GclChange."""
295 for af in affected_files:
296 lines = af.ChangedContents()
297 for line in lines:
298 yield (af, line[0], line[1])
299
300
Edward Lemur6eb1d322020-02-27 22:20:15 +0000301def prompt_should_continue(prompt_string):
302 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000303 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000304 response = sys.stdin.readline().strip().lower()
305 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000306
Josip Sokcevic967cf672023-05-10 17:09:58 +0000307
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000308# Top level object so multiprocessing can pickle
309# Public access through OutputApi object.
310class _PresubmitResult(object):
311 """Base class for result objects."""
312 fatal = False
313 should_prompt = False
314
Josip Sokcevica4b871e2023-05-18 14:27:56 +0000315 def __init__(self, message, items=None, long_text='', show_callstack=None):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000316 """
317 message: A short one-line message to indicate errors.
318 items: A list of short strings to indicate where errors occurred.
319 long_text: multi-line text output, e.g. from another tool
320 """
Bruce Dawsondb8622b2022-04-03 15:38:12 +0000321 self._message = _PresubmitResult._ensure_str(message)
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000322 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000323 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
Josip Sokcevica4b871e2023-05-18 14:27:56 +0000324 if show_callstack is None:
325 show_callstack = _SHOW_CALLSTACKS
326 if show_callstack:
Bruce Dawsondca14bc2022-09-15 20:59:38 +0000327 self._long_text += 'Presubmit result call stack is:\n'
328 self._long_text += ''.join(traceback.format_stack(None, 8))
Tom McKee61c72652021-07-20 11:56:32 +0000329
330 @staticmethod
331 def _ensure_str(val):
332 """
Gavin Maka94d8fe2023-09-05 18:05:01 +0000333 val: A "stringish" value. Can be any of str or bytes.
Tom McKee61c72652021-07-20 11:56:32 +0000334 returns: A str after applying encoding/decoding as needed.
335 Assumes/uses UTF-8 for relevant inputs/outputs.
Tom McKee61c72652021-07-20 11:56:32 +0000336 """
337 if isinstance(val, str):
338 return val
Gavin Maka94d8fe2023-09-05 18:05:01 +0000339 if isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000340 return val.decode()
341 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000342
Edward Lemur6eb1d322020-02-27 22:20:15 +0000343 def handle(self):
344 sys.stdout.write(self._message)
345 sys.stdout.write('\n')
Takuto Ikutabaa7be02022-08-23 00:19:34 +0000346 for item in self._items:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000347 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000348 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000349 sys.stdout.write(str(item))
Edward Lemur6eb1d322020-02-27 22:20:15 +0000350 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000351 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000352 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000353 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000354 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000355 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000356
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000357 def json_format(self):
358 return {
359 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000360 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000361 'long_text': self._long_text,
362 'fatal': self.fatal
363 }
364
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000365
366# Top level object so multiprocessing can pickle
367# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000368class _PresubmitError(_PresubmitResult):
369 """A hard presubmit error."""
370 fatal = True
371
372
373# Top level object so multiprocessing can pickle
374# Public access through OutputApi object.
375class _PresubmitPromptWarning(_PresubmitResult):
376 """An warning that prompts the user if they want to continue."""
377 should_prompt = True
378
379
380# Top level object so multiprocessing can pickle
381# Public access through OutputApi object.
382class _PresubmitNotifyResult(_PresubmitResult):
383 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000384
385
386# Top level object so multiprocessing can pickle
387# Public access through OutputApi object.
388class _MailTextResult(_PresubmitResult):
389 """A warning that should be included in the review request email."""
390 def __init__(self, *args, **kwargs):
391 super(_MailTextResult, self).__init__()
392 raise NotImplementedError()
393
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000394class GerritAccessor(object):
395 """Limited Gerrit functionality for canned presubmit checks to work.
396
397 To avoid excessive Gerrit calls, caches the results.
398 """
399
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000400 def __init__(self, url=None, project=None, branch=None):
401 self.host = urlparse.urlparse(url).netloc if url else None
402 self.project = project
403 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000404 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000405 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000406
407 def _FetchChangeDetail(self, issue):
408 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100409 try:
410 return gerrit_util.GetChangeDetail(
411 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700412 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100413 except gerrit_util.GerritError as e:
414 if e.http_status == 404:
415 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
416 'no credentials to fetch issue details' % issue)
417 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000418
419 def GetChangeInfo(self, issue):
420 """Returns labels and all revisions (patchsets) for this issue.
421
422 The result is a dictionary according to Gerrit REST Api.
423 https://gerrit-review.googlesource.com/Documentation/rest-api.html
424
425 However, API isn't very clear what's inside, so see tests for example.
426 """
427 assert issue
428 cache_key = int(issue)
429 if cache_key not in self.cache:
430 self.cache[cache_key] = self._FetchChangeDetail(issue)
431 return self.cache[cache_key]
432
433 def GetChangeDescription(self, issue, patchset=None):
434 """If patchset is none, fetches current patchset."""
435 info = self.GetChangeInfo(issue)
436 # info is a reference to cache. We'll modify it here adding description to
437 # it to the right patchset, if it is not yet there.
438
439 # Find revision info for the patchset we want.
440 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000441 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000442 if str(rev_info['_number']) == str(patchset):
443 break
444 else:
445 raise Exception('patchset %s doesn\'t exist in issue %s' % (
446 patchset, issue))
447 else:
448 rev = info['current_revision']
449 rev_info = info['revisions'][rev]
450
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100451 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000452
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800453 def GetDestRef(self, issue):
454 ref = self.GetChangeInfo(issue)['branch']
455 if not ref.startswith('refs/'):
456 # NOTE: it is possible to create 'refs/x' branch,
457 # aka 'refs/heads/refs/x'. However, this is ill-advised.
458 ref = 'refs/heads/%s' % ref
459 return ref
460
Edward Lesmes02d4b822020-11-11 00:37:35 +0000461 def _GetApproversForLabel(self, issue, label):
462 change_info = self.GetChangeInfo(issue)
463 label_info = change_info.get('labels', {}).get(label, {})
464 values = label_info.get('values', {}).keys()
465 if not values:
466 return []
467 max_value = max(int(v) for v in values)
468 return [v for v in label_info.get('all', [])
469 if v.get('value', 0) == max_value]
470
Edward Lesmesc4566172021-03-19 16:55:13 +0000471 def IsBotCommitApproved(self, issue):
472 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
473
Edward Lesmescf49cb82020-11-11 01:08:36 +0000474 def IsOwnersOverrideApproved(self, issue):
475 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
476
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000477 def GetChangeOwner(self, issue):
478 return self.GetChangeInfo(issue)['owner']['email']
479
480 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700481 changeinfo = self.GetChangeInfo(issue)
482 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000483 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700484 else:
485 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
486 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000487
Edward Lemure4d329c2020-02-03 20:41:18 +0000488 def UpdateDescription(self, description, issue):
489 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
490
Edward Lesmes8170c292021-03-19 20:04:43 +0000491 def IsCodeOwnersEnabledOnRepo(self):
492 if self.code_owners_enabled is None:
493 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000494 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000495 return self.code_owners_enabled
496
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000497
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000498class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000499 """An instance of OutputApi gets passed to presubmit scripts so that they
500 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000501 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000502 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000503 PresubmitError = _PresubmitError
504 PresubmitPromptWarning = _PresubmitPromptWarning
505 PresubmitNotifyResult = _PresubmitNotifyResult
506 MailTextResult = _MailTextResult
507
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000508 def __init__(self, is_committing):
509 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800510 self.more_cc = []
511
512 def AppendCC(self, cc):
513 """Appends a user to cc for this change."""
Daniel Cheng541638f2023-05-15 22:00:47 +0000514 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000515
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000516 def PresubmitPromptOrNotify(self, *args, **kwargs):
517 """Warn the user when uploading, but only notify if committing."""
518 if self.is_committing:
519 return self.PresubmitNotifyResult(*args, **kwargs)
520 return self.PresubmitPromptWarning(*args, **kwargs)
521
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000522
523class InputApi(object):
524 """An instance of this object is passed to presubmit scripts so they can
525 know stuff about the change they're looking at.
526 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000527 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800528 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000529
maruel@chromium.org3410d912009-06-09 20:56:16 +0000530 # File extensions that are considered source files from a style guide
531 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000532 #
533 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000534 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000535 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
536 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000537 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000538 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
539 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000540 # Scripts
dpapad443d9132022-05-05 00:17:30 +0000541 r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$',
542 r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000543 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000544 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
Bruce Dawson7a81ebf2023-01-03 18:36:18 +0000545 r'.+\.fidl$', r'.+\.rs$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000546 )
547
548 # Path regexp that should be excluded from being considered containing source
549 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000550 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000551 r'testing_support[\\\/]google_appengine[\\\/].*',
552 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900553 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
554 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000555 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000556 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000557 r'.*\bDebug[\\\/].*',
558 r'.*\bRelease[\\\/].*',
559 r'.*\bxcodebuild[\\\/].*',
560 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000561 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000562 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000563 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000564 r'(|.*[\\\/])\.git[\\\/].*',
565 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000566 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000567 r'.+\.diff$',
568 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000569 )
570
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000571 def __init__(self, change, presubmit_path, is_committing,
Bruce Dawson09c0c072022-05-26 20:28:58 +0000572 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False,
573 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000574 """Builds an InputApi object.
575
576 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000577 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000578 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000579 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000580 gerrit_obj: provides basic Gerrit codereview functionality.
581 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400582 parallel: if true, all tests reported via input_api.RunTests for all
583 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +0000584 no_diffs: if true, implies that --files or --all was specified so some
585 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000586 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000587 # Version number of the presubmit_support script.
588 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000589 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000590 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000591 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000592 self.dry_run = dry_run
Bruce Dawson09c0c072022-05-26 20:28:58 +0000593 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000594
Edward Lesmes8e282792018-04-03 18:50:29 -0400595 self.parallel = parallel
596 self.thread_pool = thread_pool or ThreadPool()
597
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000598 # We expose various modules and functions as attributes of the input_api
599 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900600 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000601 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000602 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700603 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000604 self.gclient_paths = gclient_paths
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000605 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000606 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000607 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000608 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000609 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000610 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000611 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000612 self.re = re
613 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000614 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000615 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000616 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000617 self.unittest = unittest
Edward Lemur16af3562019-10-17 22:11:33 +0000618 self.urllib_request = urllib_request
619 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000620
Robert Iannucci50258932018-03-19 10:30:59 -0700621 self.is_windows = sys.platform == 'win32'
622
Bruce Dawsonb6cb9e02023-05-18 20:52:43 +0000623 # Set python_executable to 'vpython3' in order to allow scripts in other
Edward Lemurb9646622019-10-25 20:57:35 +0000624 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
625 # instead of inheriting the one in depot_tools.
Bruce Dawsonb6cb9e02023-05-18 20:52:43 +0000626 self.python_executable = 'vpython3'
Erik Staab69135d12021-05-14 22:31:57 +0000627 # Offer a python 3 executable for use during the migration off of python 2.
628 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000629 self.environ = os.environ
630
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000631 # InputApi.platform is the platform you're currently running on.
632 self.platform = sys.platform
633
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000634 self.cpu_count = multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000635 if self.is_windows:
636 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
637 # Windows or Python3 may hang.
638 self.cpu_count = min(self.cpu_count, 56)
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000639
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000640 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000641 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000642
643 # We carry the canned checks so presubmit scripts can easily use them.
644 self.canned_checks = presubmit_canned_checks
645
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100646 # Temporary files we must manually remove at the end of a run.
647 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200648
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000649 self.owners_client = None
Bruce Dawsoneb8426e2022-08-05 23:58:15 +0000650 if self.gerrit and not 'PRESUBMIT_SKIP_NETWORK' in self.environ:
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000651 try:
652 self.owners_client = owners_client.GetCodeOwnersClient(
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000653 host=self.gerrit.host,
654 project=self.gerrit.project,
655 branch=self.gerrit.branch)
656 except Exception as e:
657 print('Failed to set owners_client - %s' % str(e))
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200658 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000659 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000660 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000661
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000662 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000663 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000664 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800665 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000666 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000667 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000668 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
669 for (a, b, header) in cpplint._re_pattern_templates
670 ]
671
Edward Lemurecc27072020-01-06 16:42:34 +0000672 def SetTimeout(self, timeout):
673 self.thread_pool.timeout = timeout
674
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000675 def PresubmitLocalPath(self):
676 """Returns the local path of the presubmit script currently being run.
677
678 This is useful if you don't want to hard-code absolute paths in the
679 presubmit script. For example, It can be used to find another file
680 relative to the PRESUBMIT.py script, so the whole tree can be branched and
681 the presubmit script still works, without editing its content.
682 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000683 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000684
agable0b65e732016-11-22 09:25:46 -0800685 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000686 """Same as input_api.change.AffectedFiles() except only lists files
687 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000688 script, or subdirectories thereof. Note that files are listed using the OS
689 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000690 """
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000691 dir_with_slash = normpath(self.PresubmitLocalPath())
Bruce Dawson31bfd512022-05-10 23:19:39 +0000692 # normpath strips trailing path separators, so the trailing separator has to
693 # be added after the normpath call.
694 if len(dir_with_slash) > 0:
695 dir_with_slash += os.path.sep
sail@chromium.org5538e022011-05-12 17:53:16 +0000696
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000697 return list(filter(
698 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
699 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000700
agable0b65e732016-11-22 09:25:46 -0800701 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000702 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800703 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000704 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000705 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000706
agable0b65e732016-11-22 09:25:46 -0800707 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000708 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800709 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000710
John Budorick16162372018-04-18 10:39:53 -0700711 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800712 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000713 in the same directory as the current presubmit script, or subdirectories
714 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000715 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000716 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000717 warn('AffectedTestableFiles(include_deletes=%s)'
718 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000719 category=DeprecationWarning,
720 stacklevel=2)
Josip Sokcevic4de5dea2022-03-23 21:15:14 +0000721 # pylint: disable=consider-using-generator
722 return [
723 x for x in self.AffectedFiles(include_deletes=False, **kwargs)
724 if x.IsTestableFile()
725 ]
agable0b65e732016-11-22 09:25:46 -0800726
727 def AffectedTextFiles(self, include_deletes=None):
728 """An alias to AffectedTestableFiles for backwards compatibility."""
729 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000730
Josip Sokcevic8c955952021-02-01 21:32:57 +0000731 def FilterSourceFile(self,
732 affected_file,
733 files_to_check=None,
734 files_to_skip=None,
735 allow_list=None,
736 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000737 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000738
local_bot64021412020-07-08 21:05:39 +0000739 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
740 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000741
Bruce Dawson635383f2022-09-13 16:23:18 +0000742 affected_file.LocalPath() needs to re.match an entry in the files_to_check
743 list and not re.match any entries in the files_to_skip list.
744 '/' path separators should be used in the regular expressions and will work
745 on Windows as well as other platforms.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000746
747 Note: Copy-paste this function to suit your needs or use a lambda function.
748 """
local_bot64021412020-07-08 21:05:39 +0000749 if files_to_check is None:
750 files_to_check = self.DEFAULT_FILES_TO_CHECK
751 if files_to_skip is None:
752 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000753
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000754 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000755 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000756 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000757 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000758 return True
Bruce Dawsona3a014e2022-04-27 23:28:17 +0000759 # Handle the cases where the files regex only handles /, but the local
760 # path uses \.
761 if self.is_windows and self.re.match(item, local_path.replace(
762 '\\', '/')):
763 return True
maruel@chromium.org3410d912009-06-09 20:56:16 +0000764 return False
local_bot64021412020-07-08 21:05:39 +0000765 return (Find(affected_file, files_to_check) and
766 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000767
768 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800769 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000770
771 If source_file is None, InputApi.FilterSourceFile() is used.
772 """
773 if not source_file:
774 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000775 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000776
777 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000778 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000779
780 Only lists lines from new or modified text files in the change that are
781 contained by the directory of the currently executing presubmit script.
782
783 This is useful for doing line-by-line regex checks, like checking for
784 trailing whitespace.
785
786 Yields:
787 a 3 tuple:
Josip Sokcevic7958e302023-03-01 23:02:21 +0000788 the AffectedFile instance of the current file;
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000789 integer line number (1-based); and
790 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000791
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000792 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000793 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000794 files = self.AffectedSourceFiles(source_file_filter)
Josip Sokcevic7958e302023-03-01 23:02:21 +0000795 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000796
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000797 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000798 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000799
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000800 Deny reading anything outside the repository.
801 """
Josip Sokcevic7958e302023-03-01 23:02:21 +0000802 if isinstance(file_item, AffectedFile):
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000803 file_item = file_item.AbsoluteLocalPath()
804 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000805 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000806 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000807
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100808 def CreateTemporaryFile(self, **kwargs):
809 """Returns a named temporary file that must be removed with a call to
810 RemoveTemporaryFiles().
811
812 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
813 except for |delete|, which is always set to False.
814
815 Presubmit checks that need to create a temporary file and pass it for
816 reading should use this function instead of NamedTemporaryFile(), as
817 Windows fails to open a file that is already open for writing.
818
819 with input_api.CreateTemporaryFile() as f:
820 f.write('xyz')
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100821 input_api.subprocess.check_output(['script-that', '--reads-from',
822 f.name])
823
824
825 Note that callers of CreateTemporaryFile() should not worry about removing
826 any temporary file; this is done transparently by the presubmit handling
827 code.
828 """
829 if 'delete' in kwargs:
830 # Prevent users from passing |delete|; we take care of file deletion
831 # ourselves and this prevents unintuitive error messages when we pass
832 # delete=False and 'delete' is also in kwargs.
833 raise TypeError('CreateTemporaryFile() does not take a "delete" '
834 'argument, file deletion is handled automatically by '
835 'the same presubmit_support code that creates InputApi '
836 'objects.')
837 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
838 self._named_temporary_files.append(temp_file.name)
839 return temp_file
840
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000841 @property
842 def tbr(self):
843 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400844 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000845
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000846 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000847 tests = []
848 msgs = []
849 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400850 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000851 msgs.append(t)
852 else:
853 assert issubclass(t.message, _PresubmitResult)
854 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000855 if self.verbose:
856 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400857 if not t.kwargs.get('cwd'):
858 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400859 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000860 # When self.parallel is True (i.e. --parallel is passed as an option)
861 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
862 # will run all tests once all PRESUBMIT files are processed.
863 # Otherwise, it will run them and return the results.
864 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400865 msgs.extend(self.thread_pool.RunAsync())
866 return msgs
scottmg86099d72016-09-01 09:16:51 -0700867
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000868
Josip Sokcevic7958e302023-03-01 23:02:21 +0000869class _DiffCache(object):
870 """Caches diffs retrieved from a particular SCM."""
871 def __init__(self, upstream=None):
872 """Stores the upstream revision against which all diffs will be computed."""
873 self._upstream = upstream
874
875 def GetDiff(self, path, local_root):
876 """Get the diff for a particular path."""
877 raise NotImplementedError()
878
879 def GetOldContents(self, path, local_root):
880 """Get the old version for a particular path."""
881 raise NotImplementedError()
882
883
884class _GitDiffCache(_DiffCache):
885 """DiffCache implementation for git; gets all file diffs at once."""
886 def __init__(self, upstream):
887 super(_GitDiffCache, self).__init__(upstream=upstream)
888 self._diffs_by_file = None
889
890 def GetDiff(self, path, local_root):
891 # Compare against None to distinguish between None and an initialized but
892 # empty dictionary.
893 if self._diffs_by_file == None:
894 # Compute a single diff for all files and parse the output; should
895 # with git this is much faster than computing one diff for each file.
896 diffs = {}
897
898 # Don't specify any filenames below, because there are command line length
899 # limits on some platforms and GenerateDiff would fail.
900 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
901 branch=self._upstream)
902
903 # This regex matches the path twice, separated by a space. Note that
904 # filename itself may contain spaces.
905 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
906 current_diff = []
907 keep_line_endings = True
908 for x in unified_diff.splitlines(keep_line_endings):
909 match = file_marker.match(x)
910 if match:
911 # Marks the start of a new per-file section.
912 diffs[match.group('filename')] = current_diff = [x]
913 elif x.startswith('diff --git'):
914 raise PresubmitFailure('Unexpected diff line: %s' % x)
915 else:
916 current_diff.append(x)
917
918 self._diffs_by_file = dict(
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000919 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
Josip Sokcevic7958e302023-03-01 23:02:21 +0000920
921 if path not in self._diffs_by_file:
922 # SCM didn't have any diff on this file. It could be that the file was not
923 # modified at all (e.g. user used --all flag in git cl presubmit).
924 # Intead of failing, return empty string.
925 # See: https://crbug.com/808346.
926 return ''
927
928 return self._diffs_by_file[path]
929
930 def GetOldContents(self, path, local_root):
931 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
932
933
934class AffectedFile(object):
935 """Representation of a file in a change."""
936
937 DIFF_CACHE = _DiffCache
938
939 # Method could be a function
940 # pylint: disable=no-self-use
941 def __init__(self, path, action, repository_root, diff_cache):
942 self._path = path
943 self._action = action
944 self._local_root = repository_root
945 self._is_directory = None
946 self._cached_changed_contents = None
947 self._cached_new_contents = None
948 self._diff_cache = diff_cache
949 logging.debug('%s(%s)', self.__class__.__name__, self._path)
950
951 def LocalPath(self):
952 """Returns the path of this file on the local disk relative to client root.
953
954 This should be used for error messages but not for accessing files,
955 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
956 often != client root).
957 """
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000958 return normpath(self._path)
Josip Sokcevic7958e302023-03-01 23:02:21 +0000959
960 def AbsoluteLocalPath(self):
961 """Returns the absolute path of this file on the local disk.
962 """
963 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
964
965 def Action(self):
966 """Returns the action on this opened file, e.g. A, M, D, etc."""
967 return self._action
968
969 def IsTestableFile(self):
970 """Returns True if the file is a text file and not a binary file.
971
972 Deleted files are not text file."""
973 raise NotImplementedError() # Implement when needed
974
975 def IsTextFile(self):
976 """An alias to IsTestableFile for backwards compatibility."""
977 return self.IsTestableFile()
978
979 def OldContents(self):
980 """Returns an iterator over the lines in the old version of file.
981
982 The old version is the file before any modifications in the user's
983 workspace, i.e. the 'left hand side'.
984
985 Contents will be empty if the file is a directory or does not exist.
986 Note: The carriage returns (LF or CR) are stripped off.
987 """
988 return self._diff_cache.GetOldContents(self.LocalPath(),
989 self._local_root).splitlines()
990
991 def NewContents(self):
992 """Returns an iterator over the lines in the new version of file.
993
994 The new version is the file in the user's workspace, i.e. the 'right hand
995 side'.
996
997 Contents will be empty if the file is a directory or does not exist.
998 Note: The carriage returns (LF or CR) are stripped off.
999 """
1000 if self._cached_new_contents is None:
1001 self._cached_new_contents = []
1002 try:
1003 self._cached_new_contents = gclient_utils.FileRead(
1004 self.AbsoluteLocalPath(), 'rU').splitlines()
1005 except IOError:
1006 pass # File not found? That's fine; maybe it was deleted.
1007 except UnicodeDecodeError as e:
1008 # log the filename since we're probably trying to read a binary
1009 # file, and shouldn't be.
1010 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1011 raise
1012
1013 return self._cached_new_contents[:]
1014
1015 def ChangedContents(self, keeplinebreaks=False):
1016 """Returns a list of tuples (line number, line text) of all new lines.
1017
1018 This relies on the scm diff output describing each changed code section
1019 with a line of the form
1020
1021 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1022 """
1023 # Don't return cached results when line breaks are requested.
1024 if not keeplinebreaks and self._cached_changed_contents is not None:
1025 return self._cached_changed_contents[:]
1026 result = []
1027 line_num = 0
1028
1029 # The keeplinebreaks parameter to splitlines must be True or else the
1030 # CheckForWindowsLineEndings presubmit will be a NOP.
1031 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
1032 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1033 if m:
1034 line_num = int(m.groups(1)[0])
1035 continue
1036 if line.startswith('+') and not line.startswith('++'):
1037 result.append((line_num, line[1:]))
1038 if not line.startswith('-'):
1039 line_num += 1
1040 # Don't cache results with line breaks.
1041 if keeplinebreaks:
1042 return result;
1043 self._cached_changed_contents = result
1044 return self._cached_changed_contents[:]
1045
1046 def __str__(self):
1047 return self.LocalPath()
1048
1049 def GenerateScmDiff(self):
1050 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
1051
1052
1053class GitAffectedFile(AffectedFile):
1054 """Representation of a file in a change out of a git checkout."""
1055 # Method 'NNN' is abstract in class 'NNN' but is not overridden
1056 # pylint: disable=abstract-method
1057
1058 DIFF_CACHE = _GitDiffCache
1059
1060 def __init__(self, *args, **kwargs):
1061 AffectedFile.__init__(self, *args, **kwargs)
1062 self._server_path = None
1063 self._is_testable_file = None
1064
1065 def IsTestableFile(self):
1066 if self._is_testable_file is None:
1067 if self.Action() == 'D':
1068 # A deleted file is not testable.
1069 self._is_testable_file = False
1070 else:
1071 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1072 return self._is_testable_file
1073
1074
1075class Change(object):
1076 """Describe a change.
1077
1078 Used directly by the presubmit scripts to query the current change being
1079 tested.
1080
1081 Instance members:
1082 tags: Dictionary of KEY=VALUE pairs found in the change description.
1083 self.KEY: equivalent to tags['KEY']
1084 """
1085
1086 _AFFECTED_FILES = AffectedFile
1087
1088 # Matches key/value (or 'tag') lines in changelist descriptions.
1089 TAG_LINE_RE = re.compile(
1090 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
1091 scm = ''
1092
1093 def __init__(
1094 self, name, description, local_root, files, issue, patchset, author,
1095 upstream=None):
1096 if files is None:
1097 files = []
1098 self._name = name
1099 # Convert root into an absolute path.
1100 self._local_root = os.path.abspath(local_root)
1101 self._upstream = upstream
1102 self.issue = issue
1103 self.patchset = patchset
1104 self.author_email = author
1105
1106 self._full_description = ''
1107 self.tags = {}
1108 self._description_without_tags = ''
1109 self.SetDescriptionText(description)
1110
1111 assert all(
1112 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1113
1114 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
1115 self._affected_files = [
1116 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1117 for action, path in files
1118 ]
1119
1120 def UpstreamBranch(self):
1121 """Returns the upstream branch for the change."""
1122 return self._upstream
1123
1124 def Name(self):
1125 """Returns the change name."""
1126 return self._name
1127
1128 def DescriptionText(self):
1129 """Returns the user-entered changelist description, minus tags.
1130
1131 Any line in the user-provided description starting with e.g. 'FOO='
1132 (whitespace permitted before and around) is considered a tag line. Such
1133 lines are stripped out of the description this function returns.
1134 """
1135 return self._description_without_tags
1136
1137 def FullDescriptionText(self):
1138 """Returns the complete changelist description including tags."""
1139 return self._full_description
1140
1141 def SetDescriptionText(self, description):
1142 """Sets the full description text (including tags) to |description|.
1143
1144 Also updates the list of tags."""
1145 self._full_description = description
1146
1147 # From the description text, build up a dictionary of key/value pairs
1148 # plus the description minus all key/value or 'tag' lines.
1149 description_without_tags = []
1150 self.tags = {}
1151 for line in self._full_description.splitlines():
1152 m = self.TAG_LINE_RE.match(line)
1153 if m:
1154 self.tags[m.group('key')] = m.group('value')
1155 else:
1156 description_without_tags.append(line)
1157
1158 # Change back to text and remove whitespace at end.
1159 self._description_without_tags = (
1160 '\n'.join(description_without_tags).rstrip())
1161
1162 def AddDescriptionFooter(self, key, value):
1163 """Adds the given footer to the change description.
1164
1165 Args:
1166 key: A string with the key for the git footer. It must conform to
1167 the git footers format (i.e. 'List-Of-Tokens') and will be case
1168 normalized so that each token is title-cased.
1169 value: A string with the value for the git footer.
1170 """
1171 description = git_footers.add_footer(
1172 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1173 self.SetDescriptionText(description)
1174
1175 def RepositoryRoot(self):
1176 """Returns the repository (checkout) root directory for this change,
1177 as an absolute path.
1178 """
1179 return self._local_root
1180
1181 def __getattr__(self, attr):
1182 """Return tags directly as attributes on the object."""
1183 if not re.match(r'^[A-Z_]*$', attr):
1184 raise AttributeError(self, attr)
1185 return self.tags.get(attr)
1186
1187 def GitFootersFromDescription(self):
1188 """Return the git footers present in the description.
1189
1190 Returns:
1191 footers: A dict of {footer: [values]} containing a multimap of the footers
1192 in the change description.
1193 """
1194 return git_footers.parse_footers(self.FullDescriptionText())
1195
1196 def BugsFromDescription(self):
1197 """Returns all bugs referenced in the commit description."""
1198 bug_tags = ['BUG', 'FIXED']
1199
1200 tags = []
1201 for tag in bug_tags:
1202 values = self.tags.get(tag)
1203 if values:
1204 tags += [value.strip() for value in values.split(',')]
1205
1206 footers = []
1207 parsed = self.GitFootersFromDescription()
1208 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
1209 for unsplit_footer in unsplit_footers:
1210 footers += [b.strip() for b in unsplit_footer.split(',')]
1211 return sorted(set(tags + footers))
1212
1213 def ReviewersFromDescription(self):
1214 """Returns all reviewers listed in the commit description."""
1215 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
1216 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1217 return sorted(set(tags))
1218
1219 def TBRsFromDescription(self):
1220 """Returns all TBR reviewers listed in the commit description."""
1221 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1222 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1223 # programmatically determined by self-CR+1s.
1224 footers = self.GitFootersFromDescription().get('Tbr', [])
1225 return sorted(set(tags + footers))
1226
1227 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
1228 @property
1229 def BUG(self):
1230 return ','.join(self.BugsFromDescription())
1231 @property
1232 def R(self):
1233 return ','.join(self.ReviewersFromDescription())
1234 @property
1235 def TBR(self):
1236 return ','.join(self.TBRsFromDescription())
1237
1238 def AllFiles(self, root=None):
1239 """List all files under source control in the repo."""
1240 raise NotImplementedError()
1241
1242 def AffectedFiles(self, include_deletes=True, file_filter=None):
1243 """Returns a list of AffectedFile instances for all files in the change.
1244
1245 Args:
1246 include_deletes: If false, deleted files will be filtered out.
1247 file_filter: An additional filter to apply.
1248
1249 Returns:
1250 [AffectedFile(path, action), AffectedFile(path, action)]
1251 """
1252 affected = list(filter(file_filter, self._affected_files))
1253
1254 if include_deletes:
1255 return affected
1256 return list(filter(lambda x: x.Action() != 'D', affected))
1257
1258 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
1259 """Return a list of the existing text files in a change."""
1260 if include_deletes is not None:
1261 warn('AffectedTeestableFiles(include_deletes=%s)'
1262 ' is deprecated and ignored' % str(include_deletes),
1263 category=DeprecationWarning,
1264 stacklevel=2)
1265 return list(filter(
1266 lambda x: x.IsTestableFile(),
1267 self.AffectedFiles(include_deletes=False, **kwargs)))
1268
1269 def AffectedTextFiles(self, include_deletes=None):
1270 """An alias to AffectedTestableFiles for backwards compatibility."""
1271 return self.AffectedTestableFiles(include_deletes=include_deletes)
1272
1273 def LocalPaths(self):
1274 """Convenience function."""
1275 return [af.LocalPath() for af in self.AffectedFiles()]
1276
1277 def AbsoluteLocalPaths(self):
1278 """Convenience function."""
1279 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
1280
1281 def RightHandSideLines(self):
1282 """An iterator over all text lines in 'new' version of changed files.
1283
1284 Lists lines from new or modified text files in the change.
1285
1286 This is useful for doing line-by-line regex checks, like checking for
1287 trailing whitespace.
1288
1289 Yields:
1290 a 3 tuple:
1291 the AffectedFile instance of the current file;
1292 integer line number (1-based); and
1293 the contents of the line as a string.
1294 """
1295 return _RightHandSideLinesImpl(
1296 x for x in self.AffectedFiles(include_deletes=False)
1297 if x.IsTestableFile())
1298
1299 def OriginalOwnersFiles(self):
1300 """A map from path names of affected OWNERS files to their old content."""
1301 def owners_file_filter(f):
1302 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1303 files = self.AffectedFiles(file_filter=owners_file_filter)
1304 return {f.LocalPath(): f.OldContents() for f in files}
1305
1306
1307class GitChange(Change):
1308 _AFFECTED_FILES = GitAffectedFile
1309 scm = 'git'
1310
1311 def AllFiles(self, root=None):
1312 """List all files under source control in the repo."""
1313 root = root or self.RepositoryRoot()
1314 return subprocess.check_output(
1315 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1316 cwd=root).decode('utf-8', 'ignore').splitlines()
1317
1318
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001319def ListRelevantPresubmitFiles(files, root):
1320 """Finds all presubmit files that apply to a given set of source files.
1321
1322 If inherit-review-settings-ok is present right under root, looks for
1323 PRESUBMIT.py in directories enclosing root.
1324
1325 Args:
1326 files: An iterable container containing file paths.
1327 root: Path where to stop searching.
1328
1329 Return:
1330 List of absolute paths of the existing PRESUBMIT.py scripts.
1331 """
1332 files = [normpath(os.path.join(root, f)) for f in files]
1333
1334 # List all the individual directories containing files.
1335 directories = {os.path.dirname(f) for f in files}
1336
1337 # Ignore root if inherit-review-settings-ok is present.
1338 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1339 root = None
1340
1341 # Collect all unique directories that may contain PRESUBMIT.py.
1342 candidates = set()
1343 for directory in directories:
1344 while True:
1345 if directory in candidates:
1346 break
1347 candidates.add(directory)
1348 if directory == root:
1349 break
1350 parent_dir = os.path.dirname(directory)
1351 if parent_dir == directory:
1352 # We hit the system root directory.
1353 break
1354 directory = parent_dir
1355
1356 # Look for PRESUBMIT.py in all candidate directories.
1357 results = []
1358 for directory in sorted(list(candidates)):
1359 try:
1360 for f in os.listdir(directory):
1361 p = os.path.join(directory, f)
1362 if os.path.isfile(p) and re.match(
1363 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1364 results.append(p)
1365 except OSError:
1366 pass
1367
1368 logging.debug('Presubmit files: %s', ','.join(results))
1369 return results
1370
1371
rmistry@google.com5626a922015-02-26 14:03:30 +00001372class GetPostUploadExecuter(object):
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001373 def __init__(self, change, gerrit_obj):
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001374 """
1375 Args:
Pavol Marko624e7ee2023-01-09 09:56:29 +00001376 change: The Change object.
1377 gerrit_obj: provides basic Gerrit codereview functionality.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001378 """
Pavol Marko624e7ee2023-01-09 09:56:29 +00001379 self.change = change
1380 self.gerrit = gerrit_obj
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001381
Pavol Marko624e7ee2023-01-09 09:56:29 +00001382 def ExecPresubmitScript(self, script_text, presubmit_path):
rmistry@google.com5626a922015-02-26 14:03:30 +00001383 """Executes PostUploadHook() from a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001384 Caller is responsible for validating whether the hook should be executed
1385 and should only call this function if it should be.
rmistry@google.com5626a922015-02-26 14:03:30 +00001386
1387 Args:
1388 script_text: The text of the presubmit script.
1389 presubmit_path: Project script to run.
rmistry@google.com5626a922015-02-26 14:03:30 +00001390
1391 Return:
1392 A list of results objects.
1393 """
Pavol Marko624e7ee2023-01-09 09:56:29 +00001394 # Change to the presubmit file's directory to support local imports.
1395 presubmit_dir = os.path.dirname(presubmit_path)
1396 main_path = os.getcwd()
1397 try:
1398 os.chdir(presubmit_dir)
1399 return self._execute_with_local_working_directory(script_text,
1400 presubmit_dir,
1401 presubmit_path)
1402 finally:
1403 # Return the process to the original working directory.
1404 os.chdir(main_path)
1405
1406 def _execute_with_local_working_directory(self, script_text, presubmit_dir,
1407 presubmit_path):
rmistry@google.com5626a922015-02-26 14:03:30 +00001408 context = {}
1409 try:
Pavol Marko624e7ee2023-01-09 09:56:29 +00001410 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001411 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001412 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001413 raise PresubmitFailure('"%s" had an exception.\n%s'
1414 % (presubmit_path, e))
1415
1416 function_name = 'PostUploadHook'
1417 if function_name not in context:
1418 return {}
1419 post_upload_hook = context[function_name]
Bruce Dawson05ebc9e2023-05-24 19:00:05 +00001420 if not len(inspect.getfullargspec(post_upload_hook)[0]) == 3:
rmistry@google.com5626a922015-02-26 14:03:30 +00001421 raise PresubmitFailure(
1422 'Expected function "PostUploadHook" to take three arguments.')
Pavol Marko624e7ee2023-01-09 09:56:29 +00001423 return post_upload_hook(self.gerrit, self.change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001424
1425
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001426def _MergeMasters(masters1, masters2):
1427 """Merges two master maps. Merges also the tests of each builder."""
1428 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001429 for (master, builders) in itertools.chain(masters1.items(),
1430 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001431 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001432 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001433 new_builders.setdefault(builder, set([])).update(tests)
1434 return result
1435
1436
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001437def DoPostUploadExecuter(change, gerrit_obj, verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001438 """Execute the post upload hook.
1439
1440 Args:
1441 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001442 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001443 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001444 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001445 python_version = 'Python %s' % sys.version_info.major
1446 sys.stdout.write('Running %s post upload checks ...\n' % python_version)
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001447 presubmit_files = ListRelevantPresubmitFiles(
1448 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001449 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001450 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001451 results = []
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001452 executer = GetPostUploadExecuter(change, gerrit_obj)
rmistry@google.com5626a922015-02-26 14:03:30 +00001453 # The root presubmit file should be executed after the ones in subdirectories.
1454 # i.e. the specific post upload hooks should run before the general ones.
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001455 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
rmistry@google.com5626a922015-02-26 14:03:30 +00001456 presubmit_files.reverse()
1457
1458 for filename in presubmit_files:
1459 filename = os.path.abspath(filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001460 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001461 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001462 if verbose:
1463 sys.stdout.write('Running %s\n' % filename)
1464 results.extend(executer.ExecPresubmitScript(presubmit_script, filename))
rmistry@google.com5626a922015-02-26 14:03:30 +00001465
Edward Lemur6eb1d322020-02-27 22:20:15 +00001466 if not results:
1467 return 0
1468
1469 sys.stdout.write('\n')
1470 sys.stdout.write('** Post Upload Hook Messages **\n')
1471
1472 exit_code = 0
1473 for result in results:
1474 if result.fatal:
1475 exit_code = 1
1476 result.handle()
1477 sys.stdout.write('\n')
1478
1479 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001480
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001481class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001482 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001483 thread_pool=None, parallel=False, no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001484 """
1485 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001486 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001487 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001488 gerrit_obj: provides basic Gerrit codereview functionality.
1489 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001490 parallel: if true, all tests reported via input_api.RunTests for all
1491 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001492 no_diffs: if true, implies that --files or --all was specified so some
1493 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001494 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001495 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001496 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001497 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001498 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001499 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001500 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001501 self.thread_pool = thread_pool
1502 self.parallel = parallel
Bruce Dawson09c0c072022-05-26 20:28:58 +00001503 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001504
1505 def ExecPresubmitScript(self, script_text, presubmit_path):
1506 """Executes a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001507 Caller is responsible for validating whether the hook should be executed
1508 and should only call this function if it should be.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001509
1510 Args:
1511 script_text: The text of the presubmit script.
1512 presubmit_path: The path to the presubmit file (this will be reported via
1513 input_api.PresubmitLocalPath()).
1514
1515 Return:
1516 A list of result objects, empty if no problems.
1517 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001518 # Change to the presubmit file's directory to support local imports.
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001519 presubmit_dir = os.path.dirname(presubmit_path)
Pavol Marko624e7ee2023-01-09 09:56:29 +00001520 main_path = os.getcwd()
1521 try:
1522 os.chdir(presubmit_dir)
1523 return self._execute_with_local_working_directory(script_text,
1524 presubmit_dir,
1525 presubmit_path)
1526 finally:
1527 # Return the process to the original working directory.
1528 os.chdir(main_path)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001529
Pavol Marko624e7ee2023-01-09 09:56:29 +00001530 def _execute_with_local_working_directory(self, script_text, presubmit_dir,
1531 presubmit_path):
chase@chromium.org8e416c82009-10-06 04:30:44 +00001532 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001533 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001534 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001535 dry_run=self.dry_run, thread_pool=self.thread_pool,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001536 parallel=self.parallel, no_diffs=self.no_diffs)
Daniel Cheng7227d212017-11-17 08:12:37 -08001537 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001538 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001539
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001540 try:
Bruce Dawson0ba2fd42022-07-21 13:47:21 +00001541 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001542 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001543 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001544 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001545
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001546 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001547
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001548 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001549 # Always use forward slashes, so that path is same in *nix and Windows
1550 root = input_api.change.RepositoryRoot()
1551 rel_path = os.path.relpath(presubmit_dir, root)
1552 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001553
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001554 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001555 host = project = ''
1556 if self.gerrit:
1557 host = self.gerrit.host or ''
1558 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001559
1560 # Prefix for test names
1561 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1562
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001563 # Perform all the desired presubmit checks.
1564 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001565
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001566 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001567 version = [
1568 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1569 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001570
Scott Leecc2fe9b2020-11-19 19:38:06 +00001571 with rdb_wrapper.client(prefix) as sink:
1572 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001573 # Copy the keys to prevent "dictionary changed size during iteration"
1574 # exception if checks add globals to context. E.g. sometimes the
1575 # Python runtime will add __warningregistry__.
1576 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001577 if not function_name.startswith('Check'):
1578 continue
1579 if function_name.endswith('Commit') and not self.committing:
1580 continue
1581 if function_name.endswith('Upload') and self.committing:
1582 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001583 logging.debug('Running %s in %s', function_name, presubmit_path)
1584 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001585 self._run_check_function(function_name, context, sink,
1586 presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001587 logging.debug('Running %s done.', function_name)
1588 self.more_cc.extend(output_api.more_cc)
Daniel Cheng541638f2023-05-15 22:00:47 +00001589 # Clear the CC list between running each presubmit check to prevent
1590 # CCs from being repeatedly appended.
1591 output_api.more_cc = []
Scott Leecc2fe9b2020-11-19 19:38:06 +00001592
1593 else: # Old format
1594 if self.committing:
1595 function_name = 'CheckChangeOnCommit'
1596 else:
1597 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001598 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001599 logging.debug('Running %s in %s', function_name, presubmit_path)
1600 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001601 self._run_check_function(function_name, context, sink,
1602 presubmit_path))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001603 logging.debug('Running %s done.', function_name)
1604 self.more_cc.extend(output_api.more_cc)
Daniel Cheng541638f2023-05-15 22:00:47 +00001605 # Clear the CC list between running each presubmit check to prevent
1606 # CCs from being repeatedly appended.
1607 output_api.more_cc = []
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001608
1609 finally:
1610 for f in input_api._named_temporary_files:
1611 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001612
Daniel Cheng541638f2023-05-15 22:00:47 +00001613 self.more_cc = sorted(set(self.more_cc))
1614
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001615 return results
1616
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001617 def _run_check_function(self, function_name, context, sink, presubmit_path):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001618 """Evaluates and returns the result of a given presubmit function.
1619
1620 If sink is given, the result of the presubmit function will be reported
1621 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001622
1623 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001624 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001625 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001626 sink: an instance of ResultSink. None, by default.
1627 Returns:
1628 the result of the presubmit function call.
1629 """
1630 start_time = time_time()
1631 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001632 result = eval(function_name + '(*__args)', context)
1633 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001634 except Exception:
Bruce Dawson10a82862022-05-27 19:25:56 +00001635 _, e_value, _ = sys.exc_info()
1636 result = [
1637 OutputApi.PresubmitError(
1638 'Evaluation of %s failed: %s, %s' %
1639 (function_name, e_value, traceback.format_exc()))
1640 ]
Scott Leecc2fe9b2020-11-19 19:38:06 +00001641
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001642 elapsed_time = time_time() - start_time
1643 if elapsed_time > 10.0:
Bruce Dawson6757d462022-07-13 04:04:40 +00001644 sys.stdout.write('%6.1fs to run %s from %s.\n' %
1645 (elapsed_time, function_name, presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001646 if sink:
Erik Staab9f38b632022-10-31 14:05:24 +00001647 failure_reason = None
Scott Leecc2fe9b2020-11-19 19:38:06 +00001648 status = rdb_wrapper.STATUS_PASS
1649 if any(r.fatal for r in result):
1650 status = rdb_wrapper.STATUS_FAIL
Erik Staab9f38b632022-10-31 14:05:24 +00001651 failure_reasons = []
1652 for r in result:
1653 fields = r.json_format()
1654 message = fields['message']
1655 items = '\n'.join(' %s' % item for item in fields['items'])
1656 failure_reasons.append('\n'.join([message, items]))
1657 if failure_reasons:
1658 failure_reason = '\n'.join(failure_reasons)
1659 sink.report(function_name, status, elapsed_time, failure_reason)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001660
1661 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001662
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001663 def _check_result_type(self, result):
1664 """Helper function which ensures result is a list, and all elements are
1665 instances of OutputApi.PresubmitResult"""
1666 if not isinstance(result, (tuple, list)):
1667 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1668 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1669 raise PresubmitFailure(
1670 'All presubmit results must be of types derived from '
1671 'output_api.PresubmitResult')
1672
1673
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001674def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001675 committing,
1676 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001677 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001678 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001679 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001680 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001681 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001682 json_output=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001683 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001684 """Runs all presubmit checks that apply to the files in the change.
1685
1686 This finds all PRESUBMIT.py files in directories enclosing the files in the
1687 change (up to the repository root) and calls the relevant entrypoint function
1688 depending on whether the change is being committed or uploaded.
1689
1690 Prints errors, warnings and notifications. Prompts the user for warnings
1691 when needed.
1692
1693 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001694 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001695 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001696 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001697 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001698 may_prompt: Enable (y/n) questions on warning or error. If False,
1699 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001700 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001701 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001702 parallel: if true, all tests specified by input_api.RunTests in all
1703 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001704 no_diffs: if true, implies that --files or --all was specified so some
1705 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001706 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001707 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001708 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001709 old_environ = os.environ
1710 try:
1711 # Make sure python subprocesses won't generate .pyc files.
1712 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001713 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001714
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001715 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001716 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001717 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001718 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001719 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001720 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1721 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001722 start_time = time_time()
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001723 presubmit_files = ListRelevantPresubmitFiles(
1724 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001725 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001726 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001727 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001728 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001729 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001730 dry_run, thread_pool, parallel, no_diffs)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001731 if default_presubmit:
1732 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001733 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001734 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001735 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001736 for filename in presubmit_files:
1737 filename = os.path.abspath(filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001738 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001739 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001740 if verbose:
1741 sys.stdout.write('Running %s\n' % filename)
1742 results += executer.ExecPresubmitScript(presubmit_script, filename)
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001743
Edward Lesmes8e282792018-04-03 18:50:29 -04001744 results += thread_pool.RunAsync()
1745
Edward Lemur6eb1d322020-02-27 22:20:15 +00001746 messages = {}
1747 should_prompt = False
1748 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001749 for result in results:
1750 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001751 presubmits_failed = True
1752 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001753 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001754 should_prompt = True
1755 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001756 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001757 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001758
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001759 # Print the different message types in a consistent order. ERRORS go last
1760 # so that they will be most visible in the local-presubmit output.
1761 for name in ['Messages', 'Warnings', 'ERRORS']:
1762 if name in messages:
1763 items = messages[name]
Gavin Makd22bf602022-07-11 21:10:41 +00001764 sys.stdout.write('** Presubmit %s: %d **\n' % (name, len(items)))
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001765 for item in items:
1766 item.handle()
1767 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001768
Edward Lemurecc27072020-01-06 16:42:34 +00001769 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001770 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001771 sys.stdout.write(
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001772 'Presubmit checks took %.1fs to calculate.\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001773
Edward Lemur6eb1d322020-02-27 22:20:15 +00001774 if not should_prompt and not presubmits_failed:
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001775 sys.stdout.write('%s presubmit checks passed.\n\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001776 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001777 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001778 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001779 presubmits_failed = not prompt_should_continue(
1780 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001781 else:
1782 sys.stdout.write('\n')
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001783 else:
1784 sys.stdout.write('There were %s presubmit errors.\n' % python_version)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001785
Edward Lemur1dc66e12020-02-21 21:36:34 +00001786 if json_output:
1787 # Write the presubmit results to json output
1788 presubmit_results = {
1789 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001790 error.json_format()
1791 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001792 ],
1793 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001794 notification.json_format()
1795 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001796 ],
1797 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001798 warning.json_format()
1799 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001800 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001801 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001802 }
1803
1804 gclient_utils.FileWrite(
1805 json_output, json.dumps(presubmit_results, sort_keys=True))
1806
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001807 global _ASKED_FOR_FEEDBACK
1808 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001809 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001810 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001811 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1812 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1813 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001814 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001815
1816 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001817 finally:
1818 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001819
1820
Edward Lemur50984a62020-02-06 18:10:18 +00001821def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001822 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001823 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001824
1825 results = []
1826 for root, dirs, files in os.walk('.'):
1827 if '.svn' in dirs:
1828 dirs.remove('.svn')
1829 if '.git' in dirs:
1830 dirs.remove('.git')
1831 for name in files:
1832 if fnmatch.fnmatch(name, mask):
1833 results.append(os.path.join(root, name))
1834 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001835
1836
Edward Lemur50984a62020-02-06 18:10:18 +00001837def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001838 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001839 files = []
1840 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001841 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001842 return files
1843
1844
Edward Lemur50984a62020-02-06 18:10:18 +00001845def _parse_change(parser, options):
1846 """Process change options.
1847
1848 Args:
1849 parser: The parser used to parse the arguments from command line.
1850 options: The arguments parsed from command line.
1851 Returns:
Josip Sokcevic7958e302023-03-01 23:02:21 +00001852 A GitChange if the change root is a git repository, or a Change otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001853 """
1854 if options.files and options.all_files:
1855 parser.error('<files> cannot be specified when --all-files is set.')
1856
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001857 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001858 if change_scm != 'git' and not options.files:
1859 parser.error('<files> is not optional for unversioned directories.')
1860
1861 if options.files:
Josip Sokcevic017544d2022-03-31 23:47:53 +00001862 if options.source_controlled_only:
1863 # Get the filtered set of files from SCM.
1864 change_files = []
1865 for name in scm.GIT.GetAllFiles(options.root):
1866 for mask in options.files:
1867 if fnmatch.fnmatch(name, mask):
1868 change_files.append(('M', name))
1869 break
1870 else:
1871 # Get the filtered set of files from a directory scan.
1872 change_files = _parse_files(options.files, options.recursive)
Edward Lemur50984a62020-02-06 18:10:18 +00001873 elif options.all_files:
1874 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001875 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001876 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001877 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001878
1879 logging.info('Found %d file(s).', len(change_files))
1880
Josip Sokcevic7958e302023-03-01 23:02:21 +00001881 change_class = GitChange if change_scm == 'git' else Change
Edward Lemur50984a62020-02-06 18:10:18 +00001882 return change_class(
1883 options.name,
1884 options.description,
1885 options.root,
1886 change_files,
1887 options.issue,
1888 options.patchset,
1889 options.author,
1890 upstream=options.upstream)
1891
1892
1893def _parse_gerrit_options(parser, options):
1894 """Process gerrit options.
1895
1896 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1897 options.gerrit_fetch is set.
1898
1899 Args:
1900 parser: The parser used to parse the arguments from command line.
1901 options: The arguments parsed from command line.
1902 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001903 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001904 """
1905 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001906 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001907 gerrit_obj = GerritAccessor(
1908 url=options.gerrit_url,
1909 project=options.gerrit_project,
1910 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001911
1912 if not options.gerrit_fetch:
1913 return gerrit_obj
1914
1915 if not options.gerrit_url or not options.issue or not options.patchset:
1916 parser.error(
1917 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1918
1919 options.author = gerrit_obj.GetChangeOwner(options.issue)
1920 options.description = gerrit_obj.GetChangeDescription(
1921 options.issue, options.patchset)
1922
1923 logging.info('Got author: "%s"', options.author)
1924 logging.info('Got description: """\n%s\n"""', options.description)
1925
1926 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001927
1928
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001929@contextlib.contextmanager
1930def canned_check_filter(method_names):
1931 filtered = {}
1932 try:
1933 for method_name in method_names:
1934 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001935 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001936 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001937 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1938 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1939 yield
1940 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001941 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001942 setattr(presubmit_canned_checks, name, method)
1943
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001944
sbc@chromium.org013731e2015-02-26 18:28:43 +00001945def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001946 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1947 hooks = parser.add_mutually_exclusive_group()
1948 hooks.add_argument('-c', '--commit', action='store_true',
1949 help='Use commit instead of upload checks.')
1950 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1951 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001952 hooks.add_argument('--post_upload', action='store_true',
1953 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001954 parser.add_argument('-r', '--recursive', action='store_true',
1955 help='Act recursively.')
1956 parser.add_argument('-v', '--verbose', action='count', default=0,
1957 help='Use 2 times for more debug info.')
1958 parser.add_argument('--name', default='no name')
1959 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001960 desc = parser.add_mutually_exclusive_group()
1961 desc.add_argument('--description', default='', help='The change description.')
1962 desc.add_argument('--description_file',
1963 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001964 parser.add_argument('--issue', type=int, default=0)
1965 parser.add_argument('--patchset', type=int, default=0)
1966 parser.add_argument('--root', default=os.getcwd(),
1967 help='Search for PRESUBMIT.py up to this directory. '
1968 'If inherit-review-settings-ok is present in this '
1969 'directory, parent directories up to the root file '
1970 'system directories will also be searched.')
1971 parser.add_argument('--upstream',
1972 help='Git only: the base ref or upstream branch against '
1973 'which the diff should be computed.')
1974 parser.add_argument('--default_presubmit')
1975 parser.add_argument('--may_prompt', action='store_true', default=False)
1976 parser.add_argument('--skip_canned', action='append', default=[],
1977 help='A list of checks to skip which appear in '
1978 'presubmit_canned_checks. Can be provided multiple times '
1979 'to skip multiple canned checks.')
1980 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1981 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001982 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
1983 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001984 parser.add_argument('--gerrit_fetch', action='store_true',
1985 help=argparse.SUPPRESS)
1986 parser.add_argument('--parallel', action='store_true',
1987 help='Run all tests specified by input_api.RunTests in '
1988 'all PRESUBMIT files in parallel.')
1989 parser.add_argument('--json_output',
1990 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001991 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001992 help='Mark all files under source control as modified.')
Bruce Dawson09c0c072022-05-26 20:28:58 +00001993
Edward Lemura5799e32020-01-17 19:26:51 +00001994 parser.add_argument('files', nargs='*',
1995 help='List of files to be marked as modified when '
1996 'executing presubmit or post-upload hooks. fnmatch '
1997 'wildcards can also be used.')
Josip Sokcevic017544d2022-03-31 23:47:53 +00001998 parser.add_argument('--source_controlled_only', action='store_true',
1999 help='Constrain \'files\' to those in source control.')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002000 parser.add_argument('--no_diffs', action='store_true',
2001 help='Assume that all "modified" files have no diffs.')
Edward Lemura5799e32020-01-17 19:26:51 +00002002 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002003
Erik Staabcca5c492020-04-16 17:40:07 +00002004 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002005 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00002006 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002007 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00002008 log_level = logging.INFO
2009 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
2010 '%(filename)s] %(message)s')
2011 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002012
Bruce Dawsondca14bc2022-09-15 20:59:38 +00002013 # Print call stacks when _PresubmitResult objects are created with -v -v is
2014 # specified. This helps track down where presubmit messages are coming from.
2015 if options.verbose >= 2:
2016 global _SHOW_CALLSTACKS
2017 _SHOW_CALLSTACKS = True
2018
Edward Lemur227d5102020-02-25 23:45:35 +00002019 if options.description_file:
2020 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00002021 gerrit_obj = _parse_gerrit_options(parser, options)
2022 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002023
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002024 try:
Edward Lemur75526302020-02-27 22:31:05 +00002025 if options.post_upload:
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00002026 return DoPostUploadExecuter(change, gerrit_obj, options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002027 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002028 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002029 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002030 options.commit,
2031 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002032 options.default_presubmit,
2033 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002034 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002035 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002036 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00002037 options.json_output,
Bruce Dawson09c0c072022-05-26 20:28:58 +00002038 options.no_diffs)
Raul Tambre7c938462019-05-24 16:35:35 +00002039 except PresubmitFailure as e:
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00002040 import utils
Raul Tambre80ee78e2019-05-06 22:41:05 +00002041 print(e, file=sys.stderr)
2042 print('Maybe your depot_tools is out of date?', file=sys.stderr)
Josip Sokcevic0399e172022-03-21 23:11:51 +00002043 print('depot_tools version: %s' % utils.depot_tools_version(),
2044 file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002045 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002046
2047
2048if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002049 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002050 try:
2051 sys.exit(main())
2052 except KeyboardInterrupt:
2053 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002054 sys.exit(2)