maruel@chromium.org | 725f1c3 | 2011-04-01 20:24:54 +0000 | [diff] [blame] | 1 | #!/usr/bin/env python |
maruel@chromium.org | 3bbf294 | 2012-01-10 16:52:06 +0000 | [diff] [blame] | 2 | # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 3 | # Use of this source code is governed by a BSD-style license that can be |
| 4 | # found in the LICENSE file. |
| 5 | |
| 6 | """Enables directory-specific presubmit checks to run at upload and/or commit. |
| 7 | """ |
| 8 | |
Raul Tambre | 80ee78e | 2019-05-06 22:41:05 +0000 | [diff] [blame] | 9 | from __future__ import print_function |
| 10 | |
stip@chromium.org | f7d31f5 | 2014-01-03 20:14:46 +0000 | [diff] [blame] | 11 | __version__ = '1.8.0' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 12 | |
| 13 | # TODO(joi) Add caching where appropriate/needed. The API is designed to allow |
| 14 | # caching (between all different invocations of presubmit scripts for a given |
| 15 | # change). We should add it as our presubmit scripts start feeling slow. |
| 16 | |
Takeshi Yoshino | 07a6bea | 2017-08-02 02:44:06 +0900 | [diff] [blame] | 17 | import ast # Exposed through the API. |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 18 | import contextlib |
Yoshisato Yanagisawa | 406de13 | 2018-06-29 05:43:25 +0000 | [diff] [blame] | 19 | import cpplint |
dcheng | 091b7db | 2016-06-16 01:27:51 -0700 | [diff] [blame] | 20 | import fnmatch # Exposed through the API. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 21 | import glob |
asvitkine@chromium.org | 1516995 | 2011-09-27 14:30:53 +0000 | [diff] [blame] | 22 | import inspect |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 23 | import itertools |
maruel@chromium.org | 4f6852c | 2012-04-20 20:39:20 +0000 | [diff] [blame] | 24 | import json # Exposed through the API. |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 25 | import logging |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 26 | import multiprocessing |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 27 | import optparse |
| 28 | import os # Somewhat exposed through the API. |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 29 | import random |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 30 | import re # Exposed through the API. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 31 | import signal |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 32 | import sys # Parts exposed through API. |
| 33 | import tempfile # Exposed through the API. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 34 | import threading |
jam@chromium.org | 2a891dc | 2009-08-20 20:33:37 +0000 | [diff] [blame] | 35 | import time |
Edward Lemur | de9e3ca | 2019-10-24 21:13:31 +0000 | [diff] [blame] | 36 | import traceback |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 37 | import unittest # Exposed through the API. |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 38 | from warnings import warn |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 39 | |
| 40 | # Local imports. |
maruel@chromium.org | 35625c7 | 2011-03-23 17:34:02 +0000 | [diff] [blame] | 41 | import fix_encoding |
Yoshisato Yanagisawa | 04600b4 | 2019-03-15 03:03:41 +0000 | [diff] [blame] | 42 | import gclient_paths # Exposed through the API |
| 43 | import gclient_utils |
Aaron Gable | b584c4f | 2017-04-26 16:28:08 -0700 | [diff] [blame] | 44 | import git_footers |
tandrii@chromium.org | 015ebae | 2016-04-25 19:37:22 +0000 | [diff] [blame] | 45 | import gerrit_util |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 46 | import owners |
Jochen Eisinger | 76f5fc6 | 2017-04-07 16:27:46 +0200 | [diff] [blame] | 47 | import owners_finder |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 48 | import presubmit_canned_checks |
maruel@chromium.org | 5aeb7dd | 2009-11-17 18:09:01 +0000 | [diff] [blame] | 49 | import scm |
maruel@chromium.org | 84f4fe3 | 2011-04-06 13:26:45 +0000 | [diff] [blame] | 50 | import subprocess2 as subprocess # Exposed through the API. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 51 | |
Edward Lemur | 16af356 | 2019-10-17 22:11:33 +0000 | [diff] [blame] | 52 | if sys.version_info.major == 2: |
| 53 | # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error |
| 54 | import urllib2 # Exposed through the API. |
| 55 | import urlparse |
| 56 | import urllib2 as urllib_request |
| 57 | import urllib2 as urllib_error |
| 58 | else: |
| 59 | import urllib.parse as urlparse |
| 60 | import urllib.request as urllib_request |
| 61 | import urllib.error as urllib_error |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 62 | |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 63 | # Ask for feedback only once in program lifetime. |
| 64 | _ASKED_FOR_FEEDBACK = False |
| 65 | |
| 66 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame^] | 67 | def time_time(): |
| 68 | # Use this so that it can be mocked in tests without interfering with python |
| 69 | # system machinery. |
| 70 | return time.time() |
| 71 | |
| 72 | |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 73 | class PresubmitFailure(Exception): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 74 | pass |
| 75 | |
| 76 | |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 77 | class CommandData(object): |
Edward Lemur | 940c282 | 2019-08-23 00:34:25 +0000 | [diff] [blame] | 78 | def __init__(self, name, cmd, kwargs, message, python3=False): |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 79 | self.name = name |
| 80 | self.cmd = cmd |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 81 | self.stdin = kwargs.get('stdin', None) |
Edward Lemur | 2d6b67c | 2019-08-23 22:25:41 +0000 | [diff] [blame] | 82 | self.kwargs = kwargs.copy() |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 83 | self.kwargs['stdout'] = subprocess.PIPE |
| 84 | self.kwargs['stderr'] = subprocess.STDOUT |
| 85 | self.kwargs['stdin'] = subprocess.PIPE |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 86 | self.message = message |
| 87 | self.info = None |
Edward Lemur | 940c282 | 2019-08-23 00:34:25 +0000 | [diff] [blame] | 88 | self.python3 = python3 |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 89 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 90 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 91 | # Adapted from |
| 92 | # https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37 |
| 93 | # |
| 94 | # An object that catches SIGINT sent to the Python process and notices |
| 95 | # if processes passed to wait() die by SIGINT (we need to look for |
| 96 | # both of those cases, because pressing Ctrl+C can result in either |
| 97 | # the main process or one of the subprocesses getting the signal). |
| 98 | # |
| 99 | # Before a SIGINT is seen, wait(p) will simply call p.wait() and |
| 100 | # return the result. Once a SIGINT has been seen (in the main process |
| 101 | # or a subprocess, including the one the current call is waiting for), |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 102 | # wait(p) will call p.terminate(). |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 103 | class SigintHandler(object): |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 104 | sigint_returncodes = {-signal.SIGINT, # Unix |
| 105 | -1073741510, # Windows |
| 106 | } |
| 107 | def __init__(self): |
| 108 | self.__lock = threading.Lock() |
| 109 | self.__processes = set() |
| 110 | self.__got_sigint = False |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 111 | self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 112 | |
| 113 | def __on_sigint(self): |
| 114 | self.__got_sigint = True |
| 115 | while self.__processes: |
| 116 | try: |
| 117 | self.__processes.pop().terminate() |
| 118 | except OSError: |
| 119 | pass |
| 120 | |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 121 | def interrupt(self, signal_num, frame): |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 122 | with self.__lock: |
| 123 | self.__on_sigint() |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 124 | self.__previous_signal(signal_num, frame) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 125 | |
| 126 | def got_sigint(self): |
| 127 | with self.__lock: |
| 128 | return self.__got_sigint |
| 129 | |
| 130 | def wait(self, p, stdin): |
| 131 | with self.__lock: |
| 132 | if self.__got_sigint: |
| 133 | p.terminate() |
| 134 | self.__processes.add(p) |
| 135 | stdout, stderr = p.communicate(stdin) |
| 136 | code = p.returncode |
| 137 | with self.__lock: |
| 138 | self.__processes.discard(p) |
| 139 | if code in self.sigint_returncodes: |
| 140 | self.__on_sigint() |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 141 | return stdout, stderr |
| 142 | |
| 143 | sigint_handler = SigintHandler() |
| 144 | |
| 145 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame^] | 146 | class Timer(object): |
| 147 | def __init__(self, timeout, fn): |
| 148 | self.completed = False |
| 149 | self._fn = fn |
| 150 | self._timer = threading.Timer(timeout, self._onTimer) if timeout else None |
| 151 | |
| 152 | def __enter__(self): |
| 153 | if self._timer: |
| 154 | self._timer.start() |
| 155 | return self |
| 156 | |
| 157 | def __exit__(self, _type, _value, _traceback): |
| 158 | if self._timer: |
| 159 | self._timer.cancel() |
| 160 | |
| 161 | def _onTimer(self): |
| 162 | self._fn() |
| 163 | self.completed = True |
| 164 | |
| 165 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 166 | class ThreadPool(object): |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame^] | 167 | def __init__(self, pool_size=None, timeout=None): |
| 168 | self.timeout = timeout |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 169 | self._pool_size = pool_size or multiprocessing.cpu_count() |
| 170 | self._messages = [] |
| 171 | self._messages_lock = threading.Lock() |
| 172 | self._tests = [] |
| 173 | self._tests_lock = threading.Lock() |
| 174 | self._nonparallel_tests = [] |
| 175 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame^] | 176 | def _GetCommand(self, test): |
Edward Lemur | 940c282 | 2019-08-23 00:34:25 +0000 | [diff] [blame] | 177 | vpython = 'vpython' |
| 178 | if test.python3: |
| 179 | vpython += '3' |
| 180 | if sys.platform == 'win32': |
| 181 | vpython += '.bat' |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 182 | |
| 183 | cmd = test.cmd |
| 184 | if cmd[0] == 'python': |
| 185 | cmd = list(cmd) |
| 186 | cmd[0] = vpython |
| 187 | elif cmd[0].endswith('.py'): |
| 188 | cmd = [vpython] + cmd |
| 189 | |
Edward Lemur | 336e51f | 2019-11-14 21:42:04 +0000 | [diff] [blame] | 190 | # On Windows, scripts on the current directory take precedence over PATH, so |
| 191 | # that when testing depot_tools on Windows, calling `vpython.bat` will |
| 192 | # execute the copy of vpython of the depot_tools under test instead of the |
| 193 | # one in the bot. |
| 194 | # As a workaround, we run the tests from the parent directory instead. |
| 195 | if (cmd[0] == vpython and |
| 196 | 'cwd' in test.kwargs and |
| 197 | os.path.basename(test.kwargs['cwd']) == 'depot_tools'): |
| 198 | test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd']) |
| 199 | cmd[1] = os.path.join('depot_tools', cmd[1]) |
| 200 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame^] | 201 | return cmd |
| 202 | |
| 203 | def _RunWithTimeout(self, cmd, stdin, kwargs): |
| 204 | p = subprocess.Popen(cmd, **kwargs) |
| 205 | with Timer(self.timeout, p.terminate) as timer: |
| 206 | stdout, _ = sigint_handler.wait(p, stdin) |
| 207 | if timer.completed: |
| 208 | stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout) |
| 209 | return p.returncode, stdout |
| 210 | |
| 211 | def CallCommand(self, test): |
| 212 | """Runs an external program. |
| 213 | |
| 214 | This function converts invocation of .py files and invocations of "python" |
| 215 | to vpython invocations. |
| 216 | """ |
| 217 | cmd = self._GetCommand(test) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 218 | try: |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame^] | 219 | start = time_time() |
| 220 | returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs) |
| 221 | duration = time_time() - start |
Edward Lemur | 7cf9438 | 2019-11-15 22:36:41 +0000 | [diff] [blame] | 222 | except Exception: |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame^] | 223 | duration = time_time() - start |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 224 | return test.message( |
Edward Lemur | 7cf9438 | 2019-11-15 22:36:41 +0000 | [diff] [blame] | 225 | '%s\n%s exec failure (%4.2fs)\n%s' % ( |
| 226 | test.name, ' '.join(cmd), duration, traceback.format_exc())) |
Edward Lemur | de9e3ca | 2019-10-24 21:13:31 +0000 | [diff] [blame] | 227 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame^] | 228 | if returncode != 0: |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 229 | return test.message( |
Edward Lemur | 7cf9438 | 2019-11-15 22:36:41 +0000 | [diff] [blame] | 230 | '%s\n%s (%4.2fs) failed\n%s' % ( |
| 231 | test.name, ' '.join(cmd), duration, stdout)) |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame^] | 232 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 233 | if test.info: |
Edward Lemur | 7cf9438 | 2019-11-15 22:36:41 +0000 | [diff] [blame] | 234 | return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration)) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 235 | |
| 236 | def AddTests(self, tests, parallel=True): |
| 237 | if parallel: |
| 238 | self._tests.extend(tests) |
| 239 | else: |
| 240 | self._nonparallel_tests.extend(tests) |
| 241 | |
| 242 | def RunAsync(self): |
| 243 | self._messages = [] |
| 244 | |
| 245 | def _WorkerFn(): |
| 246 | while True: |
| 247 | test = None |
| 248 | with self._tests_lock: |
| 249 | if not self._tests: |
| 250 | break |
| 251 | test = self._tests.pop() |
| 252 | result = self.CallCommand(test) |
| 253 | if result: |
| 254 | with self._messages_lock: |
| 255 | self._messages.append(result) |
| 256 | |
| 257 | def _StartDaemon(): |
| 258 | t = threading.Thread(target=_WorkerFn) |
| 259 | t.daemon = True |
| 260 | t.start() |
| 261 | return t |
| 262 | |
| 263 | while self._nonparallel_tests: |
| 264 | test = self._nonparallel_tests.pop() |
| 265 | result = self.CallCommand(test) |
| 266 | if result: |
| 267 | self._messages.append(result) |
| 268 | |
| 269 | if self._tests: |
| 270 | threads = [_StartDaemon() for _ in range(self._pool_size)] |
| 271 | for worker in threads: |
| 272 | worker.join() |
| 273 | |
| 274 | return self._messages |
| 275 | |
| 276 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 277 | def normpath(path): |
| 278 | '''Version of os.path.normpath that also changes backward slashes to |
| 279 | forward slashes when not running on Windows. |
| 280 | ''' |
| 281 | # This is safe to always do because the Windows version of os.path.normpath |
| 282 | # will replace forward slashes with backward slashes. |
| 283 | path = path.replace(os.sep, '/') |
| 284 | return os.path.normpath(path) |
| 285 | |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 286 | |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 287 | def _RightHandSideLinesImpl(affected_files): |
| 288 | """Implements RightHandSideLines for InputApi and GclChange.""" |
| 289 | for af in affected_files: |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 290 | lines = af.ChangedContents() |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 291 | for line in lines: |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 292 | yield (af, line[0], line[1]) |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 293 | |
| 294 | |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 295 | class PresubmitOutput(object): |
| 296 | def __init__(self, input_stream=None, output_stream=None): |
| 297 | self.input_stream = input_stream |
| 298 | self.output_stream = output_stream |
| 299 | self.reviewers = [] |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 300 | self.more_cc = [] |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 301 | self.written_output = [] |
| 302 | self.error_count = 0 |
| 303 | |
| 304 | def prompt_yes_no(self, prompt_string): |
| 305 | self.write(prompt_string) |
| 306 | if self.input_stream: |
| 307 | response = self.input_stream.readline().strip().lower() |
| 308 | if response not in ('y', 'yes'): |
| 309 | self.fail() |
| 310 | else: |
| 311 | self.fail() |
| 312 | |
| 313 | def fail(self): |
| 314 | self.error_count += 1 |
| 315 | |
| 316 | def should_continue(self): |
| 317 | return not self.error_count |
| 318 | |
| 319 | def write(self, s): |
| 320 | self.written_output.append(s) |
| 321 | if self.output_stream: |
| 322 | self.output_stream.write(s) |
| 323 | |
| 324 | def getvalue(self): |
| 325 | return ''.join(self.written_output) |
| 326 | |
| 327 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 328 | # Top level object so multiprocessing can pickle |
| 329 | # Public access through OutputApi object. |
| 330 | class _PresubmitResult(object): |
| 331 | """Base class for result objects.""" |
| 332 | fatal = False |
| 333 | should_prompt = False |
| 334 | |
| 335 | def __init__(self, message, items=None, long_text=''): |
| 336 | """ |
| 337 | message: A short one-line message to indicate errors. |
| 338 | items: A list of short strings to indicate where errors occurred. |
| 339 | long_text: multi-line text output, e.g. from another tool |
| 340 | """ |
| 341 | self._message = message |
| 342 | self._items = items or [] |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 343 | self._long_text = long_text.rstrip() |
| 344 | |
| 345 | def handle(self, output): |
| 346 | output.write(self._message) |
| 347 | output.write('\n') |
| 348 | for index, item in enumerate(self._items): |
| 349 | output.write(' ') |
| 350 | # Write separately in case it's unicode. |
| 351 | output.write(str(item)) |
| 352 | if index < len(self._items) - 1: |
| 353 | output.write(' \\') |
| 354 | output.write('\n') |
| 355 | if self._long_text: |
| 356 | output.write('\n***************\n') |
| 357 | # Write separately in case it's unicode. |
| 358 | output.write(self._long_text) |
| 359 | output.write('\n***************\n') |
| 360 | if self.fatal: |
| 361 | output.fail() |
| 362 | |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 363 | def json_format(self): |
| 364 | return { |
| 365 | 'message': self._message, |
Debrian Figueroa | 6095d40 | 2019-06-28 18:47:18 +0000 | [diff] [blame] | 366 | 'items': [str(item) for item in self._items], |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 367 | 'long_text': self._long_text, |
| 368 | 'fatal': self.fatal |
| 369 | } |
| 370 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 371 | |
| 372 | # Top level object so multiprocessing can pickle |
| 373 | # Public access through OutputApi object. |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 374 | class _PresubmitError(_PresubmitResult): |
| 375 | """A hard presubmit error.""" |
| 376 | fatal = True |
| 377 | |
| 378 | |
| 379 | # Top level object so multiprocessing can pickle |
| 380 | # Public access through OutputApi object. |
| 381 | class _PresubmitPromptWarning(_PresubmitResult): |
| 382 | """An warning that prompts the user if they want to continue.""" |
| 383 | should_prompt = True |
| 384 | |
| 385 | |
| 386 | # Top level object so multiprocessing can pickle |
| 387 | # Public access through OutputApi object. |
| 388 | class _PresubmitNotifyResult(_PresubmitResult): |
| 389 | """Just print something to the screen -- but it's not even a warning.""" |
| 390 | pass |
| 391 | |
| 392 | |
| 393 | # Top level object so multiprocessing can pickle |
| 394 | # Public access through OutputApi object. |
| 395 | class _MailTextResult(_PresubmitResult): |
| 396 | """A warning that should be included in the review request email.""" |
| 397 | def __init__(self, *args, **kwargs): |
| 398 | super(_MailTextResult, self).__init__() |
| 399 | raise NotImplementedError() |
| 400 | |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 401 | class GerritAccessor(object): |
| 402 | """Limited Gerrit functionality for canned presubmit checks to work. |
| 403 | |
| 404 | To avoid excessive Gerrit calls, caches the results. |
| 405 | """ |
| 406 | |
| 407 | def __init__(self, host): |
| 408 | self.host = host |
| 409 | self.cache = {} |
| 410 | |
| 411 | def _FetchChangeDetail(self, issue): |
| 412 | # Separate function to be easily mocked in tests. |
Andrii Shyshkalov | c6c8b4c | 2016-11-09 20:51:20 +0100 | [diff] [blame] | 413 | try: |
| 414 | return gerrit_util.GetChangeDetail( |
| 415 | self.host, str(issue), |
Aaron Gable | 6f5a8d9 | 2017-04-18 14:49:05 -0700 | [diff] [blame] | 416 | ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS']) |
Andrii Shyshkalov | c6c8b4c | 2016-11-09 20:51:20 +0100 | [diff] [blame] | 417 | except gerrit_util.GerritError as e: |
| 418 | if e.http_status == 404: |
| 419 | raise Exception('Either Gerrit issue %s doesn\'t exist, or ' |
| 420 | 'no credentials to fetch issue details' % issue) |
| 421 | raise |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 422 | |
| 423 | def GetChangeInfo(self, issue): |
| 424 | """Returns labels and all revisions (patchsets) for this issue. |
| 425 | |
| 426 | The result is a dictionary according to Gerrit REST Api. |
| 427 | https://gerrit-review.googlesource.com/Documentation/rest-api.html |
| 428 | |
| 429 | However, API isn't very clear what's inside, so see tests for example. |
| 430 | """ |
| 431 | assert issue |
| 432 | cache_key = int(issue) |
| 433 | if cache_key not in self.cache: |
| 434 | self.cache[cache_key] = self._FetchChangeDetail(issue) |
| 435 | return self.cache[cache_key] |
| 436 | |
| 437 | def GetChangeDescription(self, issue, patchset=None): |
| 438 | """If patchset is none, fetches current patchset.""" |
| 439 | info = self.GetChangeInfo(issue) |
| 440 | # info is a reference to cache. We'll modify it here adding description to |
| 441 | # it to the right patchset, if it is not yet there. |
| 442 | |
| 443 | # Find revision info for the patchset we want. |
| 444 | if patchset is not None: |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 445 | for rev, rev_info in info['revisions'].items(): |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 446 | if str(rev_info['_number']) == str(patchset): |
| 447 | break |
| 448 | else: |
| 449 | raise Exception('patchset %s doesn\'t exist in issue %s' % ( |
| 450 | patchset, issue)) |
| 451 | else: |
| 452 | rev = info['current_revision'] |
| 453 | rev_info = info['revisions'][rev] |
| 454 | |
Andrii Shyshkalov | 9c3a464 | 2017-01-24 17:41:22 +0100 | [diff] [blame] | 455 | return rev_info['commit']['message'] |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 456 | |
Mun Yong Jang | 603d01e | 2017-12-19 16:38:30 -0800 | [diff] [blame] | 457 | def GetDestRef(self, issue): |
| 458 | ref = self.GetChangeInfo(issue)['branch'] |
| 459 | if not ref.startswith('refs/'): |
| 460 | # NOTE: it is possible to create 'refs/x' branch, |
| 461 | # aka 'refs/heads/refs/x'. However, this is ill-advised. |
| 462 | ref = 'refs/heads/%s' % ref |
| 463 | return ref |
| 464 | |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 465 | def GetChangeOwner(self, issue): |
| 466 | return self.GetChangeInfo(issue)['owner']['email'] |
| 467 | |
| 468 | def GetChangeReviewers(self, issue, approving_only=True): |
Aaron Gable | 8b478f0 | 2017-07-31 15:33:19 -0700 | [diff] [blame] | 469 | changeinfo = self.GetChangeInfo(issue) |
| 470 | if approving_only: |
| 471 | labelinfo = changeinfo.get('labels', {}).get('Code-Review', {}) |
| 472 | values = labelinfo.get('values', {}).keys() |
| 473 | try: |
| 474 | max_value = max(int(v) for v in values) |
| 475 | reviewers = [r for r in labelinfo.get('all', []) |
| 476 | if r.get('value', 0) == max_value] |
| 477 | except ValueError: # values is the empty list |
| 478 | reviewers = [] |
| 479 | else: |
| 480 | reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', []) |
| 481 | return [r.get('email') for r in reviewers] |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 482 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 483 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 484 | class OutputApi(object): |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 485 | """An instance of OutputApi gets passed to presubmit scripts so that they |
| 486 | can output various types of results. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 487 | """ |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 488 | PresubmitResult = _PresubmitResult |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 489 | PresubmitError = _PresubmitError |
| 490 | PresubmitPromptWarning = _PresubmitPromptWarning |
| 491 | PresubmitNotifyResult = _PresubmitNotifyResult |
| 492 | MailTextResult = _MailTextResult |
| 493 | |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 494 | def __init__(self, is_committing): |
| 495 | self.is_committing = is_committing |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 496 | self.more_cc = [] |
| 497 | |
| 498 | def AppendCC(self, cc): |
| 499 | """Appends a user to cc for this change.""" |
| 500 | self.more_cc.append(cc) |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 501 | |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 502 | def PresubmitPromptOrNotify(self, *args, **kwargs): |
| 503 | """Warn the user when uploading, but only notify if committing.""" |
| 504 | if self.is_committing: |
| 505 | return self.PresubmitNotifyResult(*args, **kwargs) |
| 506 | return self.PresubmitPromptWarning(*args, **kwargs) |
| 507 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 508 | |
| 509 | class InputApi(object): |
| 510 | """An instance of this object is passed to presubmit scripts so they can |
| 511 | know stuff about the change they're looking at. |
| 512 | """ |
maruel@chromium.org | b17b55b | 2010-11-03 14:42:37 +0000 | [diff] [blame] | 513 | # Method could be a function |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 514 | # pylint: disable=no-self-use |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 515 | |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 516 | # File extensions that are considered source files from a style guide |
| 517 | # perspective. Don't modify this list from a presubmit script! |
maruel@chromium.org | c33455a | 2011-06-24 19:14:18 +0000 | [diff] [blame] | 518 | # |
| 519 | # Files without an extension aren't included in the list. If you want to |
| 520 | # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list. |
| 521 | # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below. |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 522 | DEFAULT_WHITE_LIST = ( |
| 523 | # C++ and friends |
maruel@chromium.org | fe1211a | 2011-05-28 18:54:17 +0000 | [diff] [blame] | 524 | r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$", |
| 525 | r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$", |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 526 | # Scripts |
maruel@chromium.org | fe1211a | 2011-05-28 18:54:17 +0000 | [diff] [blame] | 527 | r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$", |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 528 | # Other |
Sergey Ulanov | 166bc4c | 2018-04-30 17:03:38 -0700 | [diff] [blame] | 529 | r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$", r".+\.mojom$", |
| 530 | r".+\.fidl$" |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 531 | ) |
| 532 | |
| 533 | # Path regexp that should be excluded from being considered containing source |
| 534 | # files. Don't modify this list from a presubmit script! |
| 535 | DEFAULT_BLACK_LIST = ( |
gavinp@chromium.org | 656326d | 2012-08-13 00:43:57 +0000 | [diff] [blame] | 536 | r"testing_support[\\\/]google_appengine[\\\/].*", |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 537 | r".*\bexperimental[\\\/].*", |
Kent Tamura | 179dd1e | 2018-04-26 15:07:41 +0900 | [diff] [blame] | 538 | # Exclude third_party/.* but NOT third_party/{WebKit,blink} |
| 539 | # (crbug.com/539768 and crbug.com/836555). |
| 540 | r".*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*", |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 541 | # Output directories (just in case) |
| 542 | r".*\bDebug[\\\/].*", |
| 543 | r".*\bRelease[\\\/].*", |
| 544 | r".*\bxcodebuild[\\\/].*", |
thakis@chromium.org | c1c9635 | 2013-10-09 19:50:27 +0000 | [diff] [blame] | 545 | r".*\bout[\\\/].*", |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 546 | # All caps files like README and LICENCE. |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 547 | r".*\b[A-Z0-9_]{2,}$", |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 548 | # SCM (can happen in dual SCM configuration). (Slightly over aggressive) |
maruel@chromium.org | 5d0dc43 | 2011-01-03 02:40:37 +0000 | [diff] [blame] | 549 | r"(|.*[\\\/])\.git[\\\/].*", |
| 550 | r"(|.*[\\\/])\.svn[\\\/].*", |
maruel@chromium.org | 7ccb4bb | 2011-11-07 20:26:20 +0000 | [diff] [blame] | 551 | # There is no point in processing a patch file. |
| 552 | r".+\.diff$", |
| 553 | r".+\.patch$", |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 554 | ) |
| 555 | |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 556 | def __init__(self, change, presubmit_path, is_committing, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 557 | verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 558 | """Builds an InputApi object. |
| 559 | |
| 560 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 561 | change: A presubmit.Change object. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 562 | presubmit_path: The path to the presubmit script being processed. |
maruel@chromium.org | d7dccf5 | 2009-06-06 18:51:58 +0000 | [diff] [blame] | 563 | is_committing: True if the change is about to be committed. |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 564 | gerrit_obj: provides basic Gerrit codereview functionality. |
| 565 | dry_run: if true, some Checks will be skipped. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 566 | parallel: if true, all tests reported via input_api.RunTests for all |
| 567 | PRESUBMIT files will be run in parallel. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 568 | """ |
maruel@chromium.org | 9711bba | 2009-05-22 23:51:39 +0000 | [diff] [blame] | 569 | # Version number of the presubmit_support script. |
| 570 | self.version = [int(x) for x in __version__.split('.')] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 571 | self.change = change |
maruel@chromium.org | d7dccf5 | 2009-06-06 18:51:58 +0000 | [diff] [blame] | 572 | self.is_committing = is_committing |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 573 | self.gerrit = gerrit_obj |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 574 | self.dry_run = dry_run |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 575 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 576 | self.parallel = parallel |
| 577 | self.thread_pool = thread_pool or ThreadPool() |
| 578 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 579 | # We expose various modules and functions as attributes of the input_api |
| 580 | # so that presubmit scripts don't have to import them. |
Takeshi Yoshino | 07a6bea | 2017-08-02 02:44:06 +0900 | [diff] [blame] | 581 | self.ast = ast |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 582 | self.basename = os.path.basename |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 583 | self.cpplint = cpplint |
dcheng | 091b7db | 2016-06-16 01:27:51 -0700 | [diff] [blame] | 584 | self.fnmatch = fnmatch |
Yoshisato Yanagisawa | 04600b4 | 2019-03-15 03:03:41 +0000 | [diff] [blame] | 585 | self.gclient_paths = gclient_paths |
Yoshisato Yanagisawa | 57dd17b | 2019-03-22 09:10:29 +0000 | [diff] [blame] | 586 | # TODO(yyanagisawa): stop exposing this when python3 become default. |
| 587 | # Since python3's tempfile has TemporaryDirectory, we do not need this. |
| 588 | self.temporary_directory = gclient_utils.temporary_directory |
dpranke@chromium.org | 17cc244 | 2012-10-17 21:12:09 +0000 | [diff] [blame] | 589 | self.glob = glob.glob |
maruel@chromium.org | fb11c7b | 2010-03-18 18:22:14 +0000 | [diff] [blame] | 590 | self.json = json |
maruel@chromium.org | 6fba34d | 2011-06-02 13:45:12 +0000 | [diff] [blame] | 591 | self.logging = logging.getLogger('PRESUBMIT') |
maruel@chromium.org | 2b5ce56 | 2011-03-31 16:15:44 +0000 | [diff] [blame] | 592 | self.os_listdir = os.listdir |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 593 | self.os_path = os.path |
pgervais@chromium.org | bd0cace | 2014-10-02 23:23:46 +0000 | [diff] [blame] | 594 | self.os_stat = os.stat |
Yoshisato Yanagisawa | 406de13 | 2018-06-29 05:43:25 +0000 | [diff] [blame] | 595 | self.os_walk = os.walk |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 596 | self.re = re |
| 597 | self.subprocess = subprocess |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 598 | self.sys = sys |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 599 | self.tempfile = tempfile |
dpranke@chromium.org | 0d1bdea | 2011-03-24 22:54:38 +0000 | [diff] [blame] | 600 | self.time = time |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 601 | self.unittest = unittest |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 602 | if sys.version_info.major == 2: |
| 603 | self.urllib2 = urllib2 |
Edward Lemur | 16af356 | 2019-10-17 22:11:33 +0000 | [diff] [blame] | 604 | self.urllib_request = urllib_request |
| 605 | self.urllib_error = urllib_error |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 606 | |
Robert Iannucci | 5025893 | 2018-03-19 10:30:59 -0700 | [diff] [blame] | 607 | self.is_windows = sys.platform == 'win32' |
| 608 | |
Edward Lemur | b964662 | 2019-10-25 20:57:35 +0000 | [diff] [blame] | 609 | # Set python_executable to 'vpython' in order to allow scripts in other |
| 610 | # repos (e.g. src.git) to automatically pick up that repo's .vpython file, |
| 611 | # instead of inheriting the one in depot_tools. |
| 612 | self.python_executable = 'vpython' |
maruel@chromium.org | c0b2297 | 2009-06-25 16:19:14 +0000 | [diff] [blame] | 613 | self.environ = os.environ |
| 614 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 615 | # InputApi.platform is the platform you're currently running on. |
| 616 | self.platform = sys.platform |
| 617 | |
iannucci@chromium.org | 0af3bb3 | 2015-06-12 20:44:35 +0000 | [diff] [blame] | 618 | self.cpu_count = multiprocessing.cpu_count() |
| 619 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 620 | # The local path of the currently-being-processed presubmit script. |
maruel@chromium.org | 3d23524 | 2009-05-15 12:40:48 +0000 | [diff] [blame] | 621 | self._current_presubmit_path = os.path.dirname(presubmit_path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 622 | |
| 623 | # We carry the canned checks so presubmit scripts can easily use them. |
| 624 | self.canned_checks = presubmit_canned_checks |
| 625 | |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 626 | # Temporary files we must manually remove at the end of a run. |
| 627 | self._named_temporary_files = [] |
Jochen Eisinger | 72606f8 | 2017-04-04 10:44:18 +0200 | [diff] [blame] | 628 | |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 629 | # TODO(dpranke): figure out a list of all approved owners for a repo |
| 630 | # in order to be able to handle wildcard OWNERS files? |
| 631 | self.owners_db = owners.Database(change.RepositoryRoot(), |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 632 | fopen=open, os_path=self.os_path) |
Jochen Eisinger | 76f5fc6 | 2017-04-07 16:27:46 +0200 | [diff] [blame] | 633 | self.owners_finder = owners_finder.OwnersFinder |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 634 | self.verbose = verbose |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 635 | self.Command = CommandData |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 636 | |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 637 | # Replace <hash_map> and <hash_set> as headers that need to be included |
danakj@chromium.org | 1827852 | 2013-06-11 22:42:32 +0000 | [diff] [blame] | 638 | # with "base/containers/hash_tables.h" instead. |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 639 | # Access to a protected member _XX of a client class |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 640 | # pylint: disable=protected-access |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 641 | self.cpplint._re_pattern_templates = [ |
danakj@chromium.org | 1827852 | 2013-06-11 22:42:32 +0000 | [diff] [blame] | 642 | (a, b, 'base/containers/hash_tables.h') |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 643 | if header in ('<hash_map>', '<hash_set>') else (a, b, header) |
| 644 | for (a, b, header) in cpplint._re_pattern_templates |
| 645 | ] |
| 646 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame^] | 647 | def SetTimeout(self, timeout): |
| 648 | self.thread_pool.timeout = timeout |
| 649 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 650 | def PresubmitLocalPath(self): |
| 651 | """Returns the local path of the presubmit script currently being run. |
| 652 | |
| 653 | This is useful if you don't want to hard-code absolute paths in the |
| 654 | presubmit script. For example, It can be used to find another file |
| 655 | relative to the PRESUBMIT.py script, so the whole tree can be branched and |
| 656 | the presubmit script still works, without editing its content. |
| 657 | """ |
maruel@chromium.org | 3d23524 | 2009-05-15 12:40:48 +0000 | [diff] [blame] | 658 | return self._current_presubmit_path |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 659 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 660 | def AffectedFiles(self, include_deletes=True, file_filter=None): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 661 | """Same as input_api.change.AffectedFiles() except only lists files |
| 662 | (and optionally directories) in the same directory as the current presubmit |
| 663 | script, or subdirectories thereof. |
| 664 | """ |
maruel@chromium.org | 3d23524 | 2009-05-15 12:40:48 +0000 | [diff] [blame] | 665 | dir_with_slash = normpath("%s/" % self.PresubmitLocalPath()) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 666 | if len(dir_with_slash) == 1: |
| 667 | dir_with_slash = '' |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 668 | |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 669 | return list(filter( |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 670 | lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash), |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 671 | self.change.AffectedFiles(include_deletes, file_filter))) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 672 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 673 | def LocalPaths(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 674 | """Returns local paths of input_api.AffectedFiles().""" |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 675 | paths = [af.LocalPath() for af in self.AffectedFiles()] |
pgervais@chromium.org | 2f64f78 | 2014-04-25 00:12:33 +0000 | [diff] [blame] | 676 | logging.debug("LocalPaths: %s", paths) |
| 677 | return paths |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 678 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 679 | def AbsoluteLocalPaths(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 680 | """Returns absolute local paths of input_api.AffectedFiles().""" |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 681 | return [af.AbsoluteLocalPath() for af in self.AffectedFiles()] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 682 | |
John Budorick | 1616237 | 2018-04-18 10:39:53 -0700 | [diff] [blame] | 683 | def AffectedTestableFiles(self, include_deletes=None, **kwargs): |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 684 | """Same as input_api.change.AffectedTestableFiles() except only lists files |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 685 | in the same directory as the current presubmit script, or subdirectories |
| 686 | thereof. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 687 | """ |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 688 | if include_deletes is not None: |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 689 | warn("AffectedTestableFiles(include_deletes=%s)" |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 690 | " is deprecated and ignored" % str(include_deletes), |
| 691 | category=DeprecationWarning, |
| 692 | stacklevel=2) |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 693 | return list(filter( |
| 694 | lambda x: x.IsTestableFile(), |
| 695 | self.AffectedFiles(include_deletes=False, **kwargs))) |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 696 | |
| 697 | def AffectedTextFiles(self, include_deletes=None): |
| 698 | """An alias to AffectedTestableFiles for backwards compatibility.""" |
| 699 | return self.AffectedTestableFiles(include_deletes=include_deletes) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 700 | |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 701 | def FilterSourceFile(self, affected_file, white_list=None, black_list=None): |
| 702 | """Filters out files that aren't considered "source file". |
| 703 | |
| 704 | If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST |
| 705 | and InputApi.DEFAULT_BLACK_LIST is used respectively. |
| 706 | |
| 707 | The lists will be compiled as regular expression and |
| 708 | AffectedFile.LocalPath() needs to pass both list. |
| 709 | |
| 710 | Note: Copy-paste this function to suit your needs or use a lambda function. |
| 711 | """ |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 712 | def Find(affected_file, items): |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 713 | local_path = affected_file.LocalPath() |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 714 | for item in items: |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 715 | if self.re.match(item, local_path): |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 716 | return True |
| 717 | return False |
| 718 | return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and |
| 719 | not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST)) |
| 720 | |
| 721 | def AffectedSourceFiles(self, source_file): |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 722 | """Filter the list of AffectedTestableFiles by the function source_file. |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 723 | |
| 724 | If source_file is None, InputApi.FilterSourceFile() is used. |
| 725 | """ |
| 726 | if not source_file: |
| 727 | source_file = self.FilterSourceFile |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 728 | return list(filter(source_file, self.AffectedTestableFiles())) |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 729 | |
| 730 | def RightHandSideLines(self, source_file_filter=None): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 731 | """An iterator over all text lines in "new" version of changed files. |
| 732 | |
| 733 | Only lists lines from new or modified text files in the change that are |
| 734 | contained by the directory of the currently executing presubmit script. |
| 735 | |
| 736 | This is useful for doing line-by-line regex checks, like checking for |
| 737 | trailing whitespace. |
| 738 | |
| 739 | Yields: |
| 740 | a 3 tuple: |
| 741 | the AffectedFile instance of the current file; |
| 742 | integer line number (1-based); and |
| 743 | the contents of the line as a string. |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 744 | |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 745 | Note: The carriage return (LF or CR) is stripped off. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 746 | """ |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 747 | files = self.AffectedSourceFiles(source_file_filter) |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 748 | return _RightHandSideLinesImpl(files) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 749 | |
maruel@chromium.org | e3608df | 2009-11-10 20:22:57 +0000 | [diff] [blame] | 750 | def ReadFile(self, file_item, mode='r'): |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 751 | """Reads an arbitrary file. |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 752 | |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 753 | Deny reading anything outside the repository. |
| 754 | """ |
maruel@chromium.org | e3608df | 2009-11-10 20:22:57 +0000 | [diff] [blame] | 755 | if isinstance(file_item, AffectedFile): |
| 756 | file_item = file_item.AbsoluteLocalPath() |
| 757 | if not file_item.startswith(self.change.RepositoryRoot()): |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 758 | raise IOError('Access outside the repository root is denied.') |
maruel@chromium.org | 5aeb7dd | 2009-11-17 18:09:01 +0000 | [diff] [blame] | 759 | return gclient_utils.FileRead(file_item, mode) |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 760 | |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 761 | def CreateTemporaryFile(self, **kwargs): |
| 762 | """Returns a named temporary file that must be removed with a call to |
| 763 | RemoveTemporaryFiles(). |
| 764 | |
| 765 | All keyword arguments are forwarded to tempfile.NamedTemporaryFile(), |
| 766 | except for |delete|, which is always set to False. |
| 767 | |
| 768 | Presubmit checks that need to create a temporary file and pass it for |
| 769 | reading should use this function instead of NamedTemporaryFile(), as |
| 770 | Windows fails to open a file that is already open for writing. |
| 771 | |
| 772 | with input_api.CreateTemporaryFile() as f: |
| 773 | f.write('xyz') |
| 774 | f.close() |
| 775 | input_api.subprocess.check_output(['script-that', '--reads-from', |
| 776 | f.name]) |
| 777 | |
| 778 | |
| 779 | Note that callers of CreateTemporaryFile() should not worry about removing |
| 780 | any temporary file; this is done transparently by the presubmit handling |
| 781 | code. |
| 782 | """ |
| 783 | if 'delete' in kwargs: |
| 784 | # Prevent users from passing |delete|; we take care of file deletion |
| 785 | # ourselves and this prevents unintuitive error messages when we pass |
| 786 | # delete=False and 'delete' is also in kwargs. |
| 787 | raise TypeError('CreateTemporaryFile() does not take a "delete" ' |
| 788 | 'argument, file deletion is handled automatically by ' |
| 789 | 'the same presubmit_support code that creates InputApi ' |
| 790 | 'objects.') |
| 791 | temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs) |
| 792 | self._named_temporary_files.append(temp_file.name) |
| 793 | return temp_file |
| 794 | |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 795 | @property |
| 796 | def tbr(self): |
| 797 | """Returns if a change is TBR'ed.""" |
Jeremy Roman | dce2250 | 2017-06-20 15:37:29 -0400 | [diff] [blame] | 798 | return 'TBR' in self.change.tags or self.change.TBRsFromDescription() |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 799 | |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 800 | def RunTests(self, tests_mix, parallel=True): |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 801 | tests = [] |
| 802 | msgs = [] |
| 803 | for t in tests_mix: |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 804 | if isinstance(t, OutputApi.PresubmitResult) and t: |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 805 | msgs.append(t) |
| 806 | else: |
| 807 | assert issubclass(t.message, _PresubmitResult) |
| 808 | tests.append(t) |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 809 | if self.verbose: |
| 810 | t.info = _PresubmitNotifyResult |
Edward Lemur | 1037c74 | 2018-05-01 18:56:04 -0400 | [diff] [blame] | 811 | if not t.kwargs.get('cwd'): |
| 812 | t.kwargs['cwd'] = self.PresubmitLocalPath() |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 813 | self.thread_pool.AddTests(tests, parallel) |
Edward Lemur | 21000eb | 2019-05-24 23:25:58 +0000 | [diff] [blame] | 814 | # When self.parallel is True (i.e. --parallel is passed as an option) |
| 815 | # RunTests doesn't actually run tests. It adds them to a ThreadPool that |
| 816 | # will run all tests once all PRESUBMIT files are processed. |
| 817 | # Otherwise, it will run them and return the results. |
| 818 | if not self.parallel: |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 819 | msgs.extend(self.thread_pool.RunAsync()) |
| 820 | return msgs |
scottmg | 86099d7 | 2016-09-01 09:16:51 -0700 | [diff] [blame] | 821 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 822 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 823 | class _DiffCache(object): |
| 824 | """Caches diffs retrieved from a particular SCM.""" |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 825 | def __init__(self, upstream=None): |
| 826 | """Stores the upstream revision against which all diffs will be computed.""" |
| 827 | self._upstream = upstream |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 828 | |
| 829 | def GetDiff(self, path, local_root): |
| 830 | """Get the diff for a particular path.""" |
| 831 | raise NotImplementedError() |
| 832 | |
Daniel Cheng | 7a1f04d | 2017-03-21 19:12:31 -0700 | [diff] [blame] | 833 | def GetOldContents(self, path, local_root): |
| 834 | """Get the old version for a particular path.""" |
| 835 | raise NotImplementedError() |
| 836 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 837 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 838 | class _GitDiffCache(_DiffCache): |
| 839 | """DiffCache implementation for git; gets all file diffs at once.""" |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 840 | def __init__(self, upstream): |
| 841 | super(_GitDiffCache, self).__init__(upstream=upstream) |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 842 | self._diffs_by_file = None |
| 843 | |
| 844 | def GetDiff(self, path, local_root): |
| 845 | if not self._diffs_by_file: |
| 846 | # Compute a single diff for all files and parse the output; should |
| 847 | # with git this is much faster than computing one diff for each file. |
| 848 | diffs = {} |
| 849 | |
| 850 | # Don't specify any filenames below, because there are command line length |
| 851 | # limits on some platforms and GenerateDiff would fail. |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 852 | unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True, |
| 853 | branch=self._upstream) |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 854 | |
| 855 | # This regex matches the path twice, separated by a space. Note that |
| 856 | # filename itself may contain spaces. |
| 857 | file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$') |
| 858 | current_diff = [] |
| 859 | keep_line_endings = True |
| 860 | for x in unified_diff.splitlines(keep_line_endings): |
| 861 | match = file_marker.match(x) |
| 862 | if match: |
| 863 | # Marks the start of a new per-file section. |
| 864 | diffs[match.group('filename')] = current_diff = [x] |
| 865 | elif x.startswith('diff --git'): |
| 866 | raise PresubmitFailure('Unexpected diff line: %s' % x) |
| 867 | else: |
| 868 | current_diff.append(x) |
| 869 | |
| 870 | self._diffs_by_file = dict( |
| 871 | (normpath(path), ''.join(diff)) for path, diff in diffs.items()) |
| 872 | |
| 873 | if path not in self._diffs_by_file: |
| 874 | raise PresubmitFailure( |
| 875 | 'Unified diff did not contain entry for file %s' % path) |
| 876 | |
| 877 | return self._diffs_by_file[path] |
| 878 | |
Daniel Cheng | 7a1f04d | 2017-03-21 19:12:31 -0700 | [diff] [blame] | 879 | def GetOldContents(self, path, local_root): |
| 880 | return scm.GIT.GetOldContents(local_root, path, branch=self._upstream) |
| 881 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 882 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 883 | class AffectedFile(object): |
| 884 | """Representation of a file in a change.""" |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 885 | |
| 886 | DIFF_CACHE = _DiffCache |
| 887 | |
maruel@chromium.org | b17b55b | 2010-11-03 14:42:37 +0000 | [diff] [blame] | 888 | # Method could be a function |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 889 | # pylint: disable=no-self-use |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 890 | def __init__(self, path, action, repository_root, diff_cache): |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 891 | self._path = path |
| 892 | self._action = action |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 893 | self._local_root = repository_root |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 894 | self._is_directory = None |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 895 | self._cached_changed_contents = None |
| 896 | self._cached_new_contents = None |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 897 | self._diff_cache = diff_cache |
tobiasjs | 2836bcf | 2016-08-16 04:08:16 -0700 | [diff] [blame] | 898 | logging.debug('%s(%s)', self.__class__.__name__, self._path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 899 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 900 | def LocalPath(self): |
| 901 | """Returns the path of this file on the local disk relative to client root. |
Andrew Grieve | 92b8b99 | 2017-11-02 09:42:24 -0400 | [diff] [blame] | 902 | |
| 903 | This should be used for error messages but not for accessing files, |
| 904 | because presubmit checks are run with CWD=PresubmitLocalPath() (which is |
| 905 | often != client root). |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 906 | """ |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 907 | return normpath(self._path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 908 | |
| 909 | def AbsoluteLocalPath(self): |
| 910 | """Returns the absolute path of this file on the local disk. |
| 911 | """ |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 912 | return os.path.abspath(os.path.join(self._local_root, self.LocalPath())) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 913 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 914 | def Action(self): |
| 915 | """Returns the action on this opened file, e.g. A, M, D, etc.""" |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 916 | return self._action |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 917 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 918 | def IsTestableFile(self): |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 919 | """Returns True if the file is a text file and not a binary file. |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 920 | |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 921 | Deleted files are not text file.""" |
maruel@chromium.org | 1e08c00 | 2009-05-28 19:09:33 +0000 | [diff] [blame] | 922 | raise NotImplementedError() # Implement when needed |
| 923 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 924 | def IsTextFile(self): |
| 925 | """An alias to IsTestableFile for backwards compatibility.""" |
| 926 | return self.IsTestableFile() |
| 927 | |
Daniel Cheng | 7a1f04d | 2017-03-21 19:12:31 -0700 | [diff] [blame] | 928 | def OldContents(self): |
| 929 | """Returns an iterator over the lines in the old version of file. |
| 930 | |
Daniel Cheng | 2da34fe | 2017-03-21 20:42:12 -0700 | [diff] [blame] | 931 | The old version is the file before any modifications in the user's |
| 932 | workspace, i.e. the "left hand side". |
Daniel Cheng | 7a1f04d | 2017-03-21 19:12:31 -0700 | [diff] [blame] | 933 | |
| 934 | Contents will be empty if the file is a directory or does not exist. |
| 935 | Note: The carriage returns (LF or CR) are stripped off. |
| 936 | """ |
| 937 | return self._diff_cache.GetOldContents(self.LocalPath(), |
| 938 | self._local_root).splitlines() |
| 939 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 940 | def NewContents(self): |
| 941 | """Returns an iterator over the lines in the new version of file. |
| 942 | |
| 943 | The new version is the file in the user's workspace, i.e. the "right hand |
| 944 | side". |
| 945 | |
| 946 | Contents will be empty if the file is a directory or does not exist. |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 947 | Note: The carriage returns (LF or CR) are stripped off. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 948 | """ |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 949 | if self._cached_new_contents is None: |
| 950 | self._cached_new_contents = [] |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 951 | try: |
| 952 | self._cached_new_contents = gclient_utils.FileRead( |
| 953 | self.AbsoluteLocalPath(), 'rU').splitlines() |
| 954 | except IOError: |
| 955 | pass # File not found? That's fine; maybe it was deleted. |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 956 | return self._cached_new_contents[:] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 957 | |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 958 | def ChangedContents(self): |
| 959 | """Returns a list of tuples (line number, line text) of all new lines. |
| 960 | |
| 961 | This relies on the scm diff output describing each changed code section |
| 962 | with a line of the form |
| 963 | |
| 964 | ^@@ <old line num>,<old size> <new line num>,<new size> @@$ |
| 965 | """ |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 966 | if self._cached_changed_contents is not None: |
| 967 | return self._cached_changed_contents[:] |
| 968 | self._cached_changed_contents = [] |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 969 | line_num = 0 |
| 970 | |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 971 | for line in self.GenerateScmDiff().splitlines(): |
| 972 | m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line) |
| 973 | if m: |
| 974 | line_num = int(m.groups(1)[0]) |
| 975 | continue |
| 976 | if line.startswith('+') and not line.startswith('++'): |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 977 | self._cached_changed_contents.append((line_num, line[1:])) |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 978 | if not line.startswith('-'): |
| 979 | line_num += 1 |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 980 | return self._cached_changed_contents[:] |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 981 | |
maruel@chromium.org | 5de1397 | 2009-06-10 18:16:06 +0000 | [diff] [blame] | 982 | def __str__(self): |
| 983 | return self.LocalPath() |
| 984 | |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 985 | def GenerateScmDiff(self): |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 986 | return self._diff_cache.GetDiff(self.LocalPath(), self._local_root) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 987 | |
maruel@chromium.org | 58407af | 2011-04-12 23:15:57 +0000 | [diff] [blame] | 988 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 989 | class GitAffectedFile(AffectedFile): |
| 990 | """Representation of a file in a change out of a git checkout.""" |
maruel@chromium.org | b17b55b | 2010-11-03 14:42:37 +0000 | [diff] [blame] | 991 | # Method 'NNN' is abstract in class 'NNN' but is not overridden |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 992 | # pylint: disable=abstract-method |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 993 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 994 | DIFF_CACHE = _GitDiffCache |
| 995 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 996 | def __init__(self, *args, **kwargs): |
| 997 | AffectedFile.__init__(self, *args, **kwargs) |
| 998 | self._server_path = None |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 999 | self._is_testable_file = None |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1000 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1001 | def IsTestableFile(self): |
| 1002 | if self._is_testable_file is None: |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1003 | if self.Action() == 'D': |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1004 | # A deleted file is not testable. |
| 1005 | self._is_testable_file = False |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1006 | else: |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1007 | self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath()) |
| 1008 | return self._is_testable_file |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1009 | |
maruel@chromium.org | c193875 | 2011-04-12 23:11:13 +0000 | [diff] [blame] | 1010 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1011 | class Change(object): |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1012 | """Describe a change. |
| 1013 | |
| 1014 | Used directly by the presubmit scripts to query the current change being |
| 1015 | tested. |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 1016 | |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1017 | Instance members: |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 1018 | tags: Dictionary of KEY=VALUE pairs found in the change description. |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1019 | self.KEY: equivalent to tags['KEY'] |
| 1020 | """ |
| 1021 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1022 | _AFFECTED_FILES = AffectedFile |
| 1023 | |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1024 | # Matches key/value (or "tag") lines in changelist descriptions. |
maruel@chromium.org | 428342a | 2011-11-10 15:46:33 +0000 | [diff] [blame] | 1025 | TAG_LINE_RE = re.compile( |
maruel@chromium.org | c6f60e8 | 2013-04-19 17:01:57 +0000 | [diff] [blame] | 1026 | '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$') |
maruel@chromium.org | c193875 | 2011-04-12 23:11:13 +0000 | [diff] [blame] | 1027 | scm = '' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1028 | |
maruel@chromium.org | 58407af | 2011-04-12 23:15:57 +0000 | [diff] [blame] | 1029 | def __init__( |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 1030 | self, name, description, local_root, files, issue, patchset, author, |
| 1031 | upstream=None): |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1032 | if files is None: |
| 1033 | files = [] |
| 1034 | self._name = name |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1035 | # Convert root into an absolute path. |
| 1036 | self._local_root = os.path.abspath(local_root) |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 1037 | self._upstream = upstream |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1038 | self.issue = issue |
| 1039 | self.patchset = patchset |
maruel@chromium.org | 58407af | 2011-04-12 23:15:57 +0000 | [diff] [blame] | 1040 | self.author_email = author |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1041 | |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 1042 | self._full_description = '' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1043 | self.tags = {} |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 1044 | self._description_without_tags = '' |
| 1045 | self.SetDescriptionText(description) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1046 | |
maruel@chromium.org | e085d81 | 2011-10-10 19:49:15 +0000 | [diff] [blame] | 1047 | assert all( |
| 1048 | (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files |
| 1049 | |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 1050 | diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream) |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1051 | self._affected_files = [ |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 1052 | self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache) |
| 1053 | for action, path in files |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 1054 | ] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1055 | |
maruel@chromium.org | 92022ec | 2009-06-11 01:59:28 +0000 | [diff] [blame] | 1056 | def Name(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1057 | """Returns the change name.""" |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1058 | return self._name |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1059 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1060 | def DescriptionText(self): |
| 1061 | """Returns the user-entered changelist description, minus tags. |
| 1062 | |
| 1063 | Any line in the user-provided description starting with e.g. "FOO=" |
| 1064 | (whitespace permitted before and around) is considered a tag line. Such |
| 1065 | lines are stripped out of the description this function returns. |
| 1066 | """ |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1067 | return self._description_without_tags |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1068 | |
| 1069 | def FullDescriptionText(self): |
| 1070 | """Returns the complete changelist description including tags.""" |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1071 | return self._full_description |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1072 | |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 1073 | def SetDescriptionText(self, description): |
| 1074 | """Sets the full description text (including tags) to |description|. |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 1075 | |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 1076 | Also updates the list of tags.""" |
| 1077 | self._full_description = description |
| 1078 | |
| 1079 | # From the description text, build up a dictionary of key/value pairs |
| 1080 | # plus the description minus all key/value or "tag" lines. |
| 1081 | description_without_tags = [] |
| 1082 | self.tags = {} |
| 1083 | for line in self._full_description.splitlines(): |
| 1084 | m = self.TAG_LINE_RE.match(line) |
| 1085 | if m: |
| 1086 | self.tags[m.group('key')] = m.group('value') |
| 1087 | else: |
| 1088 | description_without_tags.append(line) |
| 1089 | |
| 1090 | # Change back to text and remove whitespace at end. |
| 1091 | self._description_without_tags = ( |
| 1092 | '\n'.join(description_without_tags).rstrip()) |
| 1093 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1094 | def RepositoryRoot(self): |
maruel@chromium.org | 92022ec | 2009-06-11 01:59:28 +0000 | [diff] [blame] | 1095 | """Returns the repository (checkout) root directory for this change, |
| 1096 | as an absolute path. |
| 1097 | """ |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1098 | return self._local_root |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1099 | |
| 1100 | def __getattr__(self, attr): |
maruel@chromium.org | 92022ec | 2009-06-11 01:59:28 +0000 | [diff] [blame] | 1101 | """Return tags directly as attributes on the object.""" |
| 1102 | if not re.match(r"^[A-Z_]*$", attr): |
| 1103 | raise AttributeError(self, attr) |
maruel@chromium.org | e1a524f | 2009-05-27 14:43:46 +0000 | [diff] [blame] | 1104 | return self.tags.get(attr) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1105 | |
Aaron Gable | fc03e67 | 2017-05-15 14:09:42 -0700 | [diff] [blame] | 1106 | def BugsFromDescription(self): |
| 1107 | """Returns all bugs referenced in the commit description.""" |
Aaron Gable | 12ef501 | 2017-05-15 14:29:00 -0700 | [diff] [blame] | 1108 | tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()] |
Caleb Rouleau | c0546b9 | 2019-02-22 06:12:57 +0000 | [diff] [blame] | 1109 | footers = [] |
Dan Beam | 6295404 | 2019-10-03 21:20:33 +0000 | [diff] [blame] | 1110 | parsed = git_footers.parse_footers(self._full_description) |
| 1111 | unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', []) |
Caleb Rouleau | c0546b9 | 2019-02-22 06:12:57 +0000 | [diff] [blame] | 1112 | for unsplit_footer in unsplit_footers: |
| 1113 | footers += [b.strip() for b in unsplit_footer.split(',')] |
Aaron Gable | 12ef501 | 2017-05-15 14:29:00 -0700 | [diff] [blame] | 1114 | return sorted(set(tags + footers)) |
Aaron Gable | fc03e67 | 2017-05-15 14:09:42 -0700 | [diff] [blame] | 1115 | |
| 1116 | def ReviewersFromDescription(self): |
| 1117 | """Returns all reviewers listed in the commit description.""" |
Aaron Gable | 12ef501 | 2017-05-15 14:29:00 -0700 | [diff] [blame] | 1118 | # We don't support a "R:" git-footer for reviewers; that is in metadata. |
| 1119 | tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()] |
| 1120 | return sorted(set(tags)) |
Aaron Gable | fc03e67 | 2017-05-15 14:09:42 -0700 | [diff] [blame] | 1121 | |
| 1122 | def TBRsFromDescription(self): |
| 1123 | """Returns all TBR reviewers listed in the commit description.""" |
Aaron Gable | 12ef501 | 2017-05-15 14:29:00 -0700 | [diff] [blame] | 1124 | tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()] |
| 1125 | # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically |
| 1126 | # determined by self-CR+1s. |
| 1127 | footers = git_footers.parse_footers(self._full_description).get('Tbr', []) |
| 1128 | return sorted(set(tags + footers)) |
Aaron Gable | fc03e67 | 2017-05-15 14:09:42 -0700 | [diff] [blame] | 1129 | |
| 1130 | # TODO(agable): Delete these once we're sure they're unused. |
| 1131 | @property |
| 1132 | def BUG(self): |
| 1133 | return ','.join(self.BugsFromDescription()) |
| 1134 | @property |
| 1135 | def R(self): |
| 1136 | return ','.join(self.ReviewersFromDescription()) |
| 1137 | @property |
| 1138 | def TBR(self): |
| 1139 | return ','.join(self.TBRsFromDescription()) |
| 1140 | |
agable@chromium.org | 40a3d0b | 2014-05-15 01:59:16 +0000 | [diff] [blame] | 1141 | def AllFiles(self, root=None): |
| 1142 | """List all files under source control in the repo.""" |
| 1143 | raise NotImplementedError() |
| 1144 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1145 | def AffectedFiles(self, include_deletes=True, file_filter=None): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1146 | """Returns a list of AffectedFile instances for all files in the change. |
| 1147 | |
| 1148 | Args: |
| 1149 | include_deletes: If false, deleted files will be filtered out. |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 1150 | file_filter: An additional filter to apply. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1151 | |
| 1152 | Returns: |
| 1153 | [AffectedFile(path, action), AffectedFile(path, action)] |
| 1154 | """ |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1155 | affected = list(filter(file_filter, self._affected_files)) |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 1156 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1157 | if include_deletes: |
| 1158 | return affected |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1159 | return list(filter(lambda x: x.Action() != 'D', affected)) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1160 | |
John Budorick | 1616237 | 2018-04-18 10:39:53 -0700 | [diff] [blame] | 1161 | def AffectedTestableFiles(self, include_deletes=None, **kwargs): |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 1162 | """Return a list of the existing text files in a change.""" |
| 1163 | if include_deletes is not None: |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1164 | warn("AffectedTeestableFiles(include_deletes=%s)" |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 1165 | " is deprecated and ignored" % str(include_deletes), |
| 1166 | category=DeprecationWarning, |
| 1167 | stacklevel=2) |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1168 | return list(filter( |
| 1169 | lambda x: x.IsTestableFile(), |
| 1170 | self.AffectedFiles(include_deletes=False, **kwargs))) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1171 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1172 | def AffectedTextFiles(self, include_deletes=None): |
| 1173 | """An alias to AffectedTestableFiles for backwards compatibility.""" |
| 1174 | return self.AffectedTestableFiles(include_deletes=include_deletes) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1175 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1176 | def LocalPaths(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1177 | """Convenience function.""" |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1178 | return [af.LocalPath() for af in self.AffectedFiles()] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1179 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1180 | def AbsoluteLocalPaths(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1181 | """Convenience function.""" |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1182 | return [af.AbsoluteLocalPath() for af in self.AffectedFiles()] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1183 | |
| 1184 | def RightHandSideLines(self): |
| 1185 | """An iterator over all text lines in "new" version of changed files. |
| 1186 | |
| 1187 | Lists lines from new or modified text files in the change. |
| 1188 | |
| 1189 | This is useful for doing line-by-line regex checks, like checking for |
| 1190 | trailing whitespace. |
| 1191 | |
| 1192 | Yields: |
| 1193 | a 3 tuple: |
| 1194 | the AffectedFile instance of the current file; |
| 1195 | integer line number (1-based); and |
| 1196 | the contents of the line as a string. |
| 1197 | """ |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 1198 | return _RightHandSideLinesImpl( |
| 1199 | x for x in self.AffectedFiles(include_deletes=False) |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1200 | if x.IsTestableFile()) |
agable@chromium.org | 40a3d0b | 2014-05-15 01:59:16 +0000 | [diff] [blame] | 1201 | |
Jochen Eisinger | d0573ec | 2017-04-13 10:55:06 +0200 | [diff] [blame] | 1202 | def OriginalOwnersFiles(self): |
| 1203 | """A map from path names of affected OWNERS files to their old content.""" |
| 1204 | def owners_file_filter(f): |
| 1205 | return 'OWNERS' in os.path.split(f.LocalPath())[1] |
| 1206 | files = self.AffectedFiles(file_filter=owners_file_filter) |
| 1207 | return dict([(f.LocalPath(), f.OldContents()) for f in files]) |
| 1208 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1209 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1210 | class GitChange(Change): |
| 1211 | _AFFECTED_FILES = GitAffectedFile |
maruel@chromium.org | c193875 | 2011-04-12 23:11:13 +0000 | [diff] [blame] | 1212 | scm = 'git' |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 1213 | |
agable@chromium.org | 40a3d0b | 2014-05-15 01:59:16 +0000 | [diff] [blame] | 1214 | def AllFiles(self, root=None): |
| 1215 | """List all files under source control in the repo.""" |
| 1216 | root = root or self.RepositoryRoot() |
| 1217 | return subprocess.check_output( |
Aaron Gable | 7817f02 | 2017-12-12 09:43:17 -0800 | [diff] [blame] | 1218 | ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'], |
| 1219 | cwd=root).splitlines() |
agable@chromium.org | 40a3d0b | 2014-05-15 01:59:16 +0000 | [diff] [blame] | 1220 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1221 | |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 1222 | def ListRelevantPresubmitFiles(files, root): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1223 | """Finds all presubmit files that apply to a given set of source files. |
| 1224 | |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1225 | If inherit-review-settings-ok is present right under root, looks for |
| 1226 | PRESUBMIT.py in directories enclosing root. |
| 1227 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1228 | Args: |
| 1229 | files: An iterable container containing file paths. |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 1230 | root: Path where to stop searching. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1231 | |
| 1232 | Return: |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 1233 | List of absolute paths of the existing PRESUBMIT.py scripts. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1234 | """ |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1235 | files = [normpath(os.path.join(root, f)) for f in files] |
| 1236 | |
| 1237 | # List all the individual directories containing files. |
| 1238 | directories = set([os.path.dirname(f) for f in files]) |
| 1239 | |
| 1240 | # Ignore root if inherit-review-settings-ok is present. |
| 1241 | if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')): |
| 1242 | root = None |
| 1243 | |
| 1244 | # Collect all unique directories that may contain PRESUBMIT.py. |
| 1245 | candidates = set() |
| 1246 | for directory in directories: |
| 1247 | while True: |
| 1248 | if directory in candidates: |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1249 | break |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1250 | candidates.add(directory) |
| 1251 | if directory == root: |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 1252 | break |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1253 | parent_dir = os.path.dirname(directory) |
| 1254 | if parent_dir == directory: |
| 1255 | # We hit the system root directory. |
| 1256 | break |
| 1257 | directory = parent_dir |
| 1258 | |
| 1259 | # Look for PRESUBMIT.py in all candidate directories. |
| 1260 | results = [] |
| 1261 | for directory in sorted(list(candidates)): |
tobiasjs | ff061c0 | 2016-08-17 03:23:57 -0700 | [diff] [blame] | 1262 | try: |
| 1263 | for f in os.listdir(directory): |
| 1264 | p = os.path.join(directory, f) |
| 1265 | if os.path.isfile(p) and re.match( |
| 1266 | r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'): |
| 1267 | results.append(p) |
| 1268 | except OSError: |
| 1269 | pass |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1270 | |
tobiasjs | 2836bcf | 2016-08-16 04:08:16 -0700 | [diff] [blame] | 1271 | logging.debug('Presubmit files: %s', ','.join(results)) |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1272 | return results |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1273 | |
| 1274 | |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1275 | class GetTryMastersExecuter(object): |
| 1276 | @staticmethod |
| 1277 | def ExecPresubmitScript(script_text, presubmit_path, project, change): |
| 1278 | """Executes GetPreferredTryMasters() from a single presubmit script. |
| 1279 | |
| 1280 | Args: |
| 1281 | script_text: The text of the presubmit script. |
| 1282 | presubmit_path: Project script to run. |
| 1283 | project: Project name to pass to presubmit script for bot selection. |
| 1284 | |
| 1285 | Return: |
| 1286 | A map of try masters to map of builders to set of tests. |
| 1287 | """ |
| 1288 | context = {} |
| 1289 | try: |
Raul Tambre | 09e64b4 | 2019-05-14 01:57:22 +0000 | [diff] [blame] | 1290 | exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True), |
| 1291 | context) |
Raul Tambre | 7c93846 | 2019-05-24 16:35:35 +0000 | [diff] [blame] | 1292 | except Exception as e: |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1293 | raise PresubmitFailure('"%s" had an exception.\n%s' |
| 1294 | % (presubmit_path, e)) |
| 1295 | |
| 1296 | function_name = 'GetPreferredTryMasters' |
| 1297 | if function_name not in context: |
| 1298 | return {} |
| 1299 | get_preferred_try_masters = context[function_name] |
| 1300 | if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2: |
| 1301 | raise PresubmitFailure( |
| 1302 | 'Expected function "GetPreferredTryMasters" to take two arguments.') |
| 1303 | return get_preferred_try_masters(project, change) |
| 1304 | |
| 1305 | |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1306 | class GetPostUploadExecuter(object): |
| 1307 | @staticmethod |
| 1308 | def ExecPresubmitScript(script_text, presubmit_path, cl, change): |
| 1309 | """Executes PostUploadHook() from a single presubmit script. |
| 1310 | |
| 1311 | Args: |
| 1312 | script_text: The text of the presubmit script. |
| 1313 | presubmit_path: Project script to run. |
| 1314 | cl: The Changelist object. |
| 1315 | change: The Change object. |
| 1316 | |
| 1317 | Return: |
| 1318 | A list of results objects. |
| 1319 | """ |
| 1320 | context = {} |
| 1321 | try: |
Raul Tambre | 09e64b4 | 2019-05-14 01:57:22 +0000 | [diff] [blame] | 1322 | exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True), |
| 1323 | context) |
Raul Tambre | 7c93846 | 2019-05-24 16:35:35 +0000 | [diff] [blame] | 1324 | except Exception as e: |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1325 | raise PresubmitFailure('"%s" had an exception.\n%s' |
| 1326 | % (presubmit_path, e)) |
| 1327 | |
| 1328 | function_name = 'PostUploadHook' |
| 1329 | if function_name not in context: |
| 1330 | return {} |
| 1331 | post_upload_hook = context[function_name] |
| 1332 | if not len(inspect.getargspec(post_upload_hook)[0]) == 3: |
| 1333 | raise PresubmitFailure( |
| 1334 | 'Expected function "PostUploadHook" to take three arguments.') |
| 1335 | return post_upload_hook(cl, change, OutputApi(False)) |
| 1336 | |
| 1337 | |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1338 | def _MergeMasters(masters1, masters2): |
| 1339 | """Merges two master maps. Merges also the tests of each builder.""" |
| 1340 | result = {} |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 1341 | for (master, builders) in itertools.chain(masters1.items(), |
| 1342 | masters2.items()): |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1343 | new_builders = result.setdefault(master, {}) |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 1344 | for (builder, tests) in builders.items(): |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1345 | new_builders.setdefault(builder, set([])).update(tests) |
| 1346 | return result |
| 1347 | |
| 1348 | |
| 1349 | def DoGetTryMasters(change, |
| 1350 | changed_files, |
| 1351 | repository_root, |
| 1352 | default_presubmit, |
| 1353 | project, |
| 1354 | verbose, |
| 1355 | output_stream): |
| 1356 | """Get the list of try masters from the presubmit scripts. |
| 1357 | |
| 1358 | Args: |
| 1359 | changed_files: List of modified files. |
| 1360 | repository_root: The repository root. |
| 1361 | default_presubmit: A default presubmit script to execute in any case. |
| 1362 | project: Optional name of a project used in selecting trybots. |
| 1363 | verbose: Prints debug info. |
| 1364 | output_stream: A stream to write debug output to. |
| 1365 | |
| 1366 | Return: |
| 1367 | Map of try masters to map of builders to set of tests. |
| 1368 | """ |
| 1369 | presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root) |
| 1370 | if not presubmit_files and verbose: |
| 1371 | output_stream.write("Warning, no PRESUBMIT.py found.\n") |
| 1372 | results = {} |
| 1373 | executer = GetTryMastersExecuter() |
| 1374 | |
| 1375 | if default_presubmit: |
| 1376 | if verbose: |
| 1377 | output_stream.write("Running default presubmit script.\n") |
| 1378 | fake_path = os.path.join(repository_root, 'PRESUBMIT.py') |
| 1379 | results = _MergeMasters(results, executer.ExecPresubmitScript( |
| 1380 | default_presubmit, fake_path, project, change)) |
| 1381 | for filename in presubmit_files: |
| 1382 | filename = os.path.abspath(filename) |
| 1383 | if verbose: |
| 1384 | output_stream.write("Running %s\n" % filename) |
| 1385 | # Accept CRLF presubmit script. |
| 1386 | presubmit_script = gclient_utils.FileRead(filename, 'rU') |
| 1387 | results = _MergeMasters(results, executer.ExecPresubmitScript( |
| 1388 | presubmit_script, filename, project, change)) |
| 1389 | |
| 1390 | # Make sets to lists again for later JSON serialization. |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 1391 | for builders in results.values(): |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1392 | for builder in builders: |
| 1393 | builders[builder] = list(builders[builder]) |
| 1394 | |
| 1395 | if results and verbose: |
| 1396 | output_stream.write('%s\n' % str(results)) |
| 1397 | return results |
| 1398 | |
| 1399 | |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1400 | def DoPostUploadExecuter(change, |
| 1401 | cl, |
| 1402 | repository_root, |
| 1403 | verbose, |
| 1404 | output_stream): |
| 1405 | """Execute the post upload hook. |
| 1406 | |
| 1407 | Args: |
| 1408 | change: The Change object. |
| 1409 | cl: The Changelist object. |
| 1410 | repository_root: The repository root. |
| 1411 | verbose: Prints debug info. |
| 1412 | output_stream: A stream to write debug output to. |
| 1413 | """ |
| 1414 | presubmit_files = ListRelevantPresubmitFiles( |
| 1415 | change.LocalPaths(), repository_root) |
| 1416 | if not presubmit_files and verbose: |
| 1417 | output_stream.write("Warning, no PRESUBMIT.py found.\n") |
| 1418 | results = [] |
| 1419 | executer = GetPostUploadExecuter() |
| 1420 | # The root presubmit file should be executed after the ones in subdirectories. |
| 1421 | # i.e. the specific post upload hooks should run before the general ones. |
| 1422 | # Thus, reverse the order provided by ListRelevantPresubmitFiles. |
| 1423 | presubmit_files.reverse() |
| 1424 | |
| 1425 | for filename in presubmit_files: |
| 1426 | filename = os.path.abspath(filename) |
| 1427 | if verbose: |
| 1428 | output_stream.write("Running %s\n" % filename) |
| 1429 | # Accept CRLF presubmit script. |
| 1430 | presubmit_script = gclient_utils.FileRead(filename, 'rU') |
| 1431 | results.extend(executer.ExecPresubmitScript( |
| 1432 | presubmit_script, filename, cl, change)) |
| 1433 | output_stream.write('\n') |
| 1434 | if results: |
| 1435 | output_stream.write('** Post Upload Hook Messages **\n') |
| 1436 | for result in results: |
| 1437 | result.handle(output_stream) |
| 1438 | output_stream.write('\n') |
| 1439 | |
| 1440 | return results |
| 1441 | |
| 1442 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1443 | class PresubmitExecuter(object): |
Aaron Gable | 668c1d8 | 2018-04-03 10:19:16 -0700 | [diff] [blame] | 1444 | def __init__(self, change, committing, verbose, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1445 | gerrit_obj, dry_run=None, thread_pool=None, parallel=False): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1446 | """ |
| 1447 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1448 | change: The Change object. |
agable | 92bec4f | 2016-08-24 09:27:27 -0700 | [diff] [blame] | 1449 | committing: True if 'git cl land' is running, False if 'git cl upload' is. |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1450 | gerrit_obj: provides basic Gerrit codereview functionality. |
| 1451 | dry_run: if true, some Checks will be skipped. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1452 | parallel: if true, all tests reported via input_api.RunTests for all |
| 1453 | PRESUBMIT files will be run in parallel. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1454 | """ |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1455 | self.change = change |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1456 | self.committing = committing |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1457 | self.gerrit = gerrit_obj |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1458 | self.verbose = verbose |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 1459 | self.dry_run = dry_run |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1460 | self.more_cc = [] |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1461 | self.thread_pool = thread_pool |
| 1462 | self.parallel = parallel |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1463 | |
| 1464 | def ExecPresubmitScript(self, script_text, presubmit_path): |
| 1465 | """Executes a single presubmit script. |
| 1466 | |
| 1467 | Args: |
| 1468 | script_text: The text of the presubmit script. |
| 1469 | presubmit_path: The path to the presubmit file (this will be reported via |
| 1470 | input_api.PresubmitLocalPath()). |
| 1471 | |
| 1472 | Return: |
| 1473 | A list of result objects, empty if no problems. |
| 1474 | """ |
thakis@chromium.org | c6ef53a | 2014-11-04 00:13:54 +0000 | [diff] [blame] | 1475 | |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1476 | # Change to the presubmit file's directory to support local imports. |
| 1477 | main_path = os.getcwd() |
| 1478 | os.chdir(os.path.dirname(presubmit_path)) |
| 1479 | |
| 1480 | # Load the presubmit script into context. |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 1481 | input_api = InputApi(self.change, presubmit_path, self.committing, |
Aaron Gable | 668c1d8 | 2018-04-03 10:19:16 -0700 | [diff] [blame] | 1482 | self.verbose, gerrit_obj=self.gerrit, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1483 | dry_run=self.dry_run, thread_pool=self.thread_pool, |
| 1484 | parallel=self.parallel) |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1485 | output_api = OutputApi(self.committing) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1486 | context = {} |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1487 | try: |
Raul Tambre | 09e64b4 | 2019-05-14 01:57:22 +0000 | [diff] [blame] | 1488 | exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True), |
| 1489 | context) |
Raul Tambre | 7c93846 | 2019-05-24 16:35:35 +0000 | [diff] [blame] | 1490 | except Exception as e: |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1491 | raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e)) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1492 | |
| 1493 | # These function names must change if we make substantial changes to |
| 1494 | # the presubmit API that are not backwards compatible. |
| 1495 | if self.committing: |
| 1496 | function_name = 'CheckChangeOnCommit' |
| 1497 | else: |
| 1498 | function_name = 'CheckChangeOnUpload' |
| 1499 | if function_name in context: |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 1500 | try: |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1501 | context['__args'] = (input_api, output_api) |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 1502 | logging.debug('Running %s in %s', function_name, presubmit_path) |
| 1503 | result = eval(function_name + '(*__args)', context) |
| 1504 | logging.debug('Running %s done.', function_name) |
Daniel Cheng | d36fce4 | 2017-11-21 21:52:52 -0800 | [diff] [blame] | 1505 | self.more_cc.extend(output_api.more_cc) |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 1506 | finally: |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1507 | for f in input_api._named_temporary_files: |
| 1508 | os.remove(f) |
| 1509 | if not isinstance(result, (tuple, list)): |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1510 | raise PresubmitFailure( |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1511 | 'Presubmit functions must return a tuple or list') |
| 1512 | for item in result: |
| 1513 | if not isinstance(item, OutputApi.PresubmitResult): |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1514 | raise PresubmitFailure( |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1515 | 'All presubmit results must be of types derived from ' |
| 1516 | 'output_api.PresubmitResult') |
| 1517 | else: |
| 1518 | result = () # no error since the script doesn't care about current event. |
| 1519 | |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1520 | # Return the process to the original working directory. |
| 1521 | os.chdir(main_path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1522 | return result |
| 1523 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1524 | def DoPresubmitChecks(change, |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1525 | committing, |
| 1526 | verbose, |
| 1527 | output_stream, |
maruel@chromium.org | 0ff1fab | 2009-05-22 13:08:15 +0000 | [diff] [blame] | 1528 | input_stream, |
maruel@chromium.org | b0dfd35 | 2009-06-10 14:12:54 +0000 | [diff] [blame] | 1529 | default_presubmit, |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 1530 | may_prompt, |
Aaron Gable | 668c1d8 | 2018-04-03 10:19:16 -0700 | [diff] [blame] | 1531 | gerrit_obj, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1532 | dry_run=None, |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 1533 | parallel=False, |
| 1534 | json_output=None): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1535 | """Runs all presubmit checks that apply to the files in the change. |
| 1536 | |
| 1537 | This finds all PRESUBMIT.py files in directories enclosing the files in the |
| 1538 | change (up to the repository root) and calls the relevant entrypoint function |
| 1539 | depending on whether the change is being committed or uploaded. |
| 1540 | |
| 1541 | Prints errors, warnings and notifications. Prompts the user for warnings |
| 1542 | when needed. |
| 1543 | |
| 1544 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1545 | change: The Change object. |
agable | 92bec4f | 2016-08-24 09:27:27 -0700 | [diff] [blame] | 1546 | committing: True if 'git cl land' is running, False if 'git cl upload' is. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1547 | verbose: Prints debug info. |
| 1548 | output_stream: A stream to write output from presubmit tests to. |
| 1549 | input_stream: A stream to read input from the user. |
maruel@chromium.org | 0ff1fab | 2009-05-22 13:08:15 +0000 | [diff] [blame] | 1550 | default_presubmit: A default presubmit script to execute in any case. |
Quinten Yearsley | 516fe7f | 2016-12-14 11:50:18 -0800 | [diff] [blame] | 1551 | may_prompt: Enable (y/n) questions on warning or error. If False, |
| 1552 | any questions are answered with yes by default. |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1553 | gerrit_obj: provides basic Gerrit codereview functionality. |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 1554 | dry_run: if true, some Checks will be skipped. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1555 | parallel: if true, all tests specified by input_api.RunTests in all |
| 1556 | PRESUBMIT files will be run in parallel. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1557 | |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 1558 | Warning: |
| 1559 | If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream |
| 1560 | SHOULD be sys.stdin. |
| 1561 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1562 | Return: |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 1563 | A PresubmitOutput object. Use output.should_continue() to figure out |
| 1564 | if there were errors or warnings and the caller should abort. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1565 | """ |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1566 | old_environ = os.environ |
| 1567 | try: |
| 1568 | # Make sure python subprocesses won't generate .pyc files. |
| 1569 | os.environ = os.environ.copy() |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1570 | os.environ['PYTHONDONTWRITEBYTECODE'] = '1' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1571 | |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1572 | output = PresubmitOutput(input_stream, output_stream) |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 1573 | |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1574 | if committing: |
| 1575 | output.write("Running presubmit commit checks ...\n") |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1576 | else: |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1577 | output.write("Running presubmit upload checks ...\n") |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame^] | 1578 | start_time = time_time() |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1579 | presubmit_files = ListRelevantPresubmitFiles( |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1580 | change.AbsoluteLocalPaths(), change.RepositoryRoot()) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1581 | if not presubmit_files and verbose: |
maruel@chromium.org | fae707b | 2011-09-15 18:57:58 +0000 | [diff] [blame] | 1582 | output.write("Warning, no PRESUBMIT.py found.\n") |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1583 | results = [] |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1584 | thread_pool = ThreadPool() |
Edward Lemur | 7e3c67f | 2018-07-20 20:52:49 +0000 | [diff] [blame] | 1585 | executer = PresubmitExecuter(change, committing, verbose, gerrit_obj, |
| 1586 | dry_run, thread_pool, parallel) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1587 | if default_presubmit: |
| 1588 | if verbose: |
| 1589 | output.write("Running default presubmit script.\n") |
| 1590 | fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py') |
| 1591 | results += executer.ExecPresubmitScript(default_presubmit, fake_path) |
| 1592 | for filename in presubmit_files: |
| 1593 | filename = os.path.abspath(filename) |
| 1594 | if verbose: |
| 1595 | output.write("Running %s\n" % filename) |
| 1596 | # Accept CRLF presubmit script. |
| 1597 | presubmit_script = gclient_utils.FileRead(filename, 'rU') |
| 1598 | results += executer.ExecPresubmitScript(presubmit_script, filename) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1599 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1600 | results += thread_pool.RunAsync() |
| 1601 | |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1602 | output.more_cc.extend(executer.more_cc) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1603 | errors = [] |
| 1604 | notifications = [] |
| 1605 | warnings = [] |
| 1606 | for result in results: |
| 1607 | if result.fatal: |
| 1608 | errors.append(result) |
| 1609 | elif result.should_prompt: |
| 1610 | warnings.append(result) |
| 1611 | else: |
| 1612 | notifications.append(result) |
pam@chromium.org | ed9a083 | 2009-09-09 22:48:55 +0000 | [diff] [blame] | 1613 | |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 1614 | if json_output: |
| 1615 | # Write the presubmit results to json output |
| 1616 | presubmit_results = { |
| 1617 | 'errors': [ |
| 1618 | error.json_format() for error in errors |
| 1619 | ], |
| 1620 | 'notifications': [ |
| 1621 | notification.json_format() for notification in notifications |
| 1622 | ], |
| 1623 | 'warnings': [ |
| 1624 | warning.json_format() for warning in warnings |
| 1625 | ] |
| 1626 | } |
| 1627 | |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1628 | gclient_utils.FileWrite( |
| 1629 | json_output, json.dumps(presubmit_results, sort_keys=True)) |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 1630 | |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1631 | output.write('\n') |
| 1632 | for name, items in (('Messages', notifications), |
| 1633 | ('Warnings', warnings), |
| 1634 | ('ERRORS', errors)): |
| 1635 | if items: |
| 1636 | output.write('** Presubmit %s **\n' % name) |
| 1637 | for item in items: |
| 1638 | item.handle(output) |
| 1639 | output.write('\n') |
pam@chromium.org | ed9a083 | 2009-09-09 22:48:55 +0000 | [diff] [blame] | 1640 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame^] | 1641 | total_time = time_time() - start_time |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1642 | if total_time > 1.0: |
| 1643 | output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time) |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 1644 | |
Quinten Yearsley | 516fe7f | 2016-12-14 11:50:18 -0800 | [diff] [blame] | 1645 | if errors: |
| 1646 | output.fail() |
| 1647 | elif warnings: |
| 1648 | output.write('There were presubmit warnings. ') |
| 1649 | if may_prompt: |
| 1650 | output.prompt_yes_no('Are you sure you wish to continue? (y/N): ') |
| 1651 | else: |
| 1652 | output.write('Presubmit checks passed.\n') |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1653 | |
| 1654 | global _ASKED_FOR_FEEDBACK |
| 1655 | # Ask for feedback one time out of 5. |
| 1656 | if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK): |
maruel@chromium.org | 1ce8e66 | 2014-01-14 15:23:00 +0000 | [diff] [blame] | 1657 | output.write( |
| 1658 | 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n' |
| 1659 | 'to figure out which PRESUBMIT.py was run, then run git blame\n' |
| 1660 | 'on the file to figure out who to ask for help.\n') |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1661 | _ASKED_FOR_FEEDBACK = True |
| 1662 | return output |
| 1663 | finally: |
| 1664 | os.environ = old_environ |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1665 | |
| 1666 | |
| 1667 | def ScanSubDirs(mask, recursive): |
| 1668 | if not recursive: |
pgervais@chromium.org | e57b09d | 2014-05-07 00:58:13 +0000 | [diff] [blame] | 1669 | return [x for x in glob.glob(mask) if x not in ('.svn', '.git')] |
Lei Zhang | 9611c4c | 2017-04-04 01:41:56 -0700 | [diff] [blame] | 1670 | |
| 1671 | results = [] |
| 1672 | for root, dirs, files in os.walk('.'): |
| 1673 | if '.svn' in dirs: |
| 1674 | dirs.remove('.svn') |
| 1675 | if '.git' in dirs: |
| 1676 | dirs.remove('.git') |
| 1677 | for name in files: |
| 1678 | if fnmatch.fnmatch(name, mask): |
| 1679 | results.append(os.path.join(root, name)) |
| 1680 | return results |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1681 | |
| 1682 | |
| 1683 | def ParseFiles(args, recursive): |
tobiasjs | 2836bcf | 2016-08-16 04:08:16 -0700 | [diff] [blame] | 1684 | logging.debug('Searching for %s', args) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1685 | files = [] |
| 1686 | for arg in args: |
maruel@chromium.org | e3608df | 2009-11-10 20:22:57 +0000 | [diff] [blame] | 1687 | files.extend([('M', f) for f in ScanSubDirs(arg, recursive)]) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1688 | return files |
| 1689 | |
| 1690 | |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1691 | def load_files(options, args): |
| 1692 | """Tries to determine the SCM.""" |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1693 | files = [] |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1694 | if args: |
| 1695 | files = ParseFiles(args, options.recursive) |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1696 | change_scm = scm.determine_scm(options.root) |
| 1697 | if change_scm == 'git': |
maruel@chromium.org | 9b31f16 | 2012-01-26 19:02:31 +0000 | [diff] [blame] | 1698 | change_class = GitChange |
agable@chromium.org | 2da1ade | 2014-04-30 17:40:45 +0000 | [diff] [blame] | 1699 | upstream = options.upstream or None |
maruel@chromium.org | 9b31f16 | 2012-01-26 19:02:31 +0000 | [diff] [blame] | 1700 | if not files: |
agable@chromium.org | 2da1ade | 2014-04-30 17:40:45 +0000 | [diff] [blame] | 1701 | files = scm.GIT.CaptureStatus([], options.root, upstream) |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1702 | else: |
tobiasjs | 2836bcf | 2016-08-16 04:08:16 -0700 | [diff] [blame] | 1703 | logging.info('Doesn\'t seem under source control. Got %d files', len(args)) |
maruel@chromium.org | 9b31f16 | 2012-01-26 19:02:31 +0000 | [diff] [blame] | 1704 | if not files: |
| 1705 | return None, None |
| 1706 | change_class = Change |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1707 | return change_class, files |
| 1708 | |
| 1709 | |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1710 | @contextlib.contextmanager |
| 1711 | def canned_check_filter(method_names): |
| 1712 | filtered = {} |
| 1713 | try: |
| 1714 | for method_name in method_names: |
| 1715 | if not hasattr(presubmit_canned_checks, method_name): |
Aaron Gable | ecee74c | 2018-04-02 15:13:08 -0700 | [diff] [blame] | 1716 | logging.warn('Skipping unknown "canned" check %s' % method_name) |
| 1717 | continue |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1718 | filtered[method_name] = getattr(presubmit_canned_checks, method_name) |
| 1719 | setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: []) |
| 1720 | yield |
| 1721 | finally: |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 1722 | for name, method in filtered.items(): |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1723 | setattr(presubmit_canned_checks, name, method) |
| 1724 | |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 1725 | |
sbc@chromium.org | 013731e | 2015-02-26 18:28:43 +0000 | [diff] [blame] | 1726 | def main(argv=None): |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1727 | parser = optparse.OptionParser(usage="%prog [options] <files...>", |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1728 | version="%prog " + str(__version__)) |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1729 | parser.add_option("-c", "--commit", action="store_true", default=False, |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1730 | help="Use commit instead of upload checks") |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1731 | parser.add_option("-u", "--upload", action="store_false", dest='commit', |
| 1732 | help="Use upload instead of commit checks") |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1733 | parser.add_option("-r", "--recursive", action="store_true", |
| 1734 | help="Act recursively") |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1735 | parser.add_option("-v", "--verbose", action="count", default=0, |
| 1736 | help="Use 2 times for more debug info") |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1737 | parser.add_option("--name", default='no name') |
maruel@chromium.org | 58407af | 2011-04-12 23:15:57 +0000 | [diff] [blame] | 1738 | parser.add_option("--author") |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1739 | parser.add_option("--description", default='') |
| 1740 | parser.add_option("--issue", type='int', default=0) |
| 1741 | parser.add_option("--patchset", type='int', default=0) |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1742 | parser.add_option("--root", default=os.getcwd(), |
| 1743 | help="Search for PRESUBMIT.py up to this directory. " |
| 1744 | "If inherit-review-settings-ok is present in this " |
| 1745 | "directory, parent directories up to the root file " |
| 1746 | "system directories will also be searched.") |
agable@chromium.org | 2da1ade | 2014-04-30 17:40:45 +0000 | [diff] [blame] | 1747 | parser.add_option("--upstream", |
| 1748 | help="Git only: the base ref or upstream branch against " |
| 1749 | "which the diff should be computed.") |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1750 | parser.add_option("--default_presubmit") |
| 1751 | parser.add_option("--may_prompt", action='store_true', default=False) |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1752 | parser.add_option("--skip_canned", action='append', default=[], |
| 1753 | help="A list of checks to skip which appear in " |
| 1754 | "presubmit_canned_checks. Can be provided multiple times " |
| 1755 | "to skip multiple canned checks.") |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 1756 | parser.add_option("--dry_run", action='store_true', |
| 1757 | help=optparse.SUPPRESS_HELP) |
tandrii@chromium.org | 015ebae | 2016-04-25 19:37:22 +0000 | [diff] [blame] | 1758 | parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP) |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 1759 | parser.add_option("--gerrit_fetch", action='store_true', |
| 1760 | help=optparse.SUPPRESS_HELP) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1761 | parser.add_option('--parallel', action='store_true', |
| 1762 | help='Run all tests specified by input_api.RunTests in all ' |
| 1763 | 'PRESUBMIT files in parallel.') |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 1764 | parser.add_option('--json_output', |
| 1765 | help='Write presubmit errors to json output.') |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 1766 | |
maruel@chromium.org | 82e5f28 | 2011-03-17 14:08:55 +0000 | [diff] [blame] | 1767 | options, args = parser.parse_args(argv) |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 1768 | |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1769 | if options.verbose >= 2: |
maruel@chromium.org | 7444c50 | 2011-02-09 14:02:11 +0000 | [diff] [blame] | 1770 | logging.basicConfig(level=logging.DEBUG) |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1771 | elif options.verbose: |
| 1772 | logging.basicConfig(level=logging.INFO) |
| 1773 | else: |
| 1774 | logging.basicConfig(level=logging.ERROR) |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 1775 | |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1776 | change_class, files = load_files(options, args) |
| 1777 | if not change_class: |
| 1778 | parser.error('For unversioned directory, <files> is not optional.') |
tobiasjs | 2836bcf | 2016-08-16 04:08:16 -0700 | [diff] [blame] | 1779 | logging.info('Found %d file(s).', len(files)) |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 1780 | |
Aaron Gable | 668c1d8 | 2018-04-03 10:19:16 -0700 | [diff] [blame] | 1781 | gerrit_obj = None |
tandrii@chromium.org | 015ebae | 2016-04-25 19:37:22 +0000 | [diff] [blame] | 1782 | if options.gerrit_url and options.gerrit_fetch: |
tandrii@chromium.org | 83b1b23 | 2016-04-29 16:33:19 +0000 | [diff] [blame] | 1783 | assert options.issue and options.patchset |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1784 | gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc) |
| 1785 | options.author = gerrit_obj.GetChangeOwner(options.issue) |
| 1786 | options.description = gerrit_obj.GetChangeDescription(options.issue, |
| 1787 | options.patchset) |
tandrii@chromium.org | 015ebae | 2016-04-25 19:37:22 +0000 | [diff] [blame] | 1788 | logging.info('Got author: "%s"', options.author) |
| 1789 | logging.info('Got description: """\n%s\n"""', options.description) |
| 1790 | |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1791 | try: |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1792 | with canned_check_filter(options.skip_canned): |
| 1793 | results = DoPresubmitChecks( |
| 1794 | change_class(options.name, |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 1795 | options.description, |
| 1796 | options.root, |
| 1797 | files, |
| 1798 | options.issue, |
| 1799 | options.patchset, |
| 1800 | options.author, |
| 1801 | upstream=options.upstream), |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1802 | options.commit, |
| 1803 | options.verbose, |
| 1804 | sys.stdout, |
| 1805 | sys.stdin, |
| 1806 | options.default_presubmit, |
| 1807 | options.may_prompt, |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1808 | gerrit_obj, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1809 | options.dry_run, |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 1810 | options.parallel, |
| 1811 | options.json_output) |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1812 | return not results.should_continue() |
Raul Tambre | 7c93846 | 2019-05-24 16:35:35 +0000 | [diff] [blame] | 1813 | except PresubmitFailure as e: |
Raul Tambre | 80ee78e | 2019-05-06 22:41:05 +0000 | [diff] [blame] | 1814 | print(e, file=sys.stderr) |
| 1815 | print('Maybe your depot_tools is out of date?', file=sys.stderr) |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1816 | return 2 |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1817 | |
| 1818 | |
| 1819 | if __name__ == '__main__': |
maruel@chromium.org | 35625c7 | 2011-03-23 17:34:02 +0000 | [diff] [blame] | 1820 | fix_encoding.fix_encoding() |
sbc@chromium.org | 013731e | 2015-02-26 18:28:43 +0000 | [diff] [blame] | 1821 | try: |
| 1822 | sys.exit(main()) |
| 1823 | except KeyboardInterrupt: |
| 1824 | sys.stderr.write('interrupted\n') |
sergiyb | f8a3b38 | 2016-07-05 11:21:30 -0700 | [diff] [blame] | 1825 | sys.exit(2) |