blob: 342388e64ae5d34e4983b70127a4ae17270047c1 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
enne@chromium.orge72c5f52013-04-16 00:36:40 +000015import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000016import cPickle # Exposed through the API.
17import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000018import contextlib
dcheng091b7db2016-06-16 01:27:51 -070019import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000020import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000021import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000022import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000023import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000024import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000025import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000026import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000027import optparse
28import os # Somewhat exposed through the API.
29import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000030import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000031import re # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
jam@chromium.org2a891dc2009-08-20 20:33:37 +000034import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000035import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000036import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000038import urllib2 # Exposed through the API.
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000039import urlparse
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000040from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000041
42# Local imports.
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000043import auth
maruel@chromium.org35625c72011-03-23 17:34:02 +000044import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000045import gclient_utils
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000047import owners
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000048import presubmit_canned_checks
maruel@chromium.org239f4112011-06-03 20:08:23 +000049import rietveld
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000050import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000051import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000052
53
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000054# Ask for feedback only once in program lifetime.
55_ASKED_FOR_FEEDBACK = False
56
57
maruel@chromium.org899e1c12011-04-07 17:03:18 +000058class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000059 pass
60
61
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000062class CommandData(object):
63 def __init__(self, name, cmd, kwargs, message):
64 self.name = name
65 self.cmd = cmd
66 self.kwargs = kwargs
67 self.message = message
68 self.info = None
69
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000070
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000071def normpath(path):
72 '''Version of os.path.normpath that also changes backward slashes to
73 forward slashes when not running on Windows.
74 '''
75 # This is safe to always do because the Windows version of os.path.normpath
76 # will replace forward slashes with backward slashes.
77 path = path.replace(os.sep, '/')
78 return os.path.normpath(path)
79
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000080
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000081def _RightHandSideLinesImpl(affected_files):
82 """Implements RightHandSideLines for InputApi and GclChange."""
83 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000084 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000085 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000086 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000087
88
dpranke@chromium.org5ac21012011-03-16 02:58:25 +000089class PresubmitOutput(object):
90 def __init__(self, input_stream=None, output_stream=None):
91 self.input_stream = input_stream
92 self.output_stream = output_stream
93 self.reviewers = []
94 self.written_output = []
95 self.error_count = 0
96
97 def prompt_yes_no(self, prompt_string):
98 self.write(prompt_string)
99 if self.input_stream:
100 response = self.input_stream.readline().strip().lower()
101 if response not in ('y', 'yes'):
102 self.fail()
103 else:
104 self.fail()
105
106 def fail(self):
107 self.error_count += 1
108
109 def should_continue(self):
110 return not self.error_count
111
112 def write(self, s):
113 self.written_output.append(s)
114 if self.output_stream:
115 self.output_stream.write(s)
116
117 def getvalue(self):
118 return ''.join(self.written_output)
119
120
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000121# Top level object so multiprocessing can pickle
122# Public access through OutputApi object.
123class _PresubmitResult(object):
124 """Base class for result objects."""
125 fatal = False
126 should_prompt = False
127
128 def __init__(self, message, items=None, long_text=''):
129 """
130 message: A short one-line message to indicate errors.
131 items: A list of short strings to indicate where errors occurred.
132 long_text: multi-line text output, e.g. from another tool
133 """
134 self._message = message
135 self._items = items or []
136 if items:
137 self._items = items
138 self._long_text = long_text.rstrip()
139
140 def handle(self, output):
141 output.write(self._message)
142 output.write('\n')
143 for index, item in enumerate(self._items):
144 output.write(' ')
145 # Write separately in case it's unicode.
146 output.write(str(item))
147 if index < len(self._items) - 1:
148 output.write(' \\')
149 output.write('\n')
150 if self._long_text:
151 output.write('\n***************\n')
152 # Write separately in case it's unicode.
153 output.write(self._long_text)
154 output.write('\n***************\n')
155 if self.fatal:
156 output.fail()
157
158
159# Top level object so multiprocessing can pickle
160# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000161class _PresubmitError(_PresubmitResult):
162 """A hard presubmit error."""
163 fatal = True
164
165
166# Top level object so multiprocessing can pickle
167# Public access through OutputApi object.
168class _PresubmitPromptWarning(_PresubmitResult):
169 """An warning that prompts the user if they want to continue."""
170 should_prompt = True
171
172
173# Top level object so multiprocessing can pickle
174# Public access through OutputApi object.
175class _PresubmitNotifyResult(_PresubmitResult):
176 """Just print something to the screen -- but it's not even a warning."""
177 pass
178
179
180# Top level object so multiprocessing can pickle
181# Public access through OutputApi object.
182class _MailTextResult(_PresubmitResult):
183 """A warning that should be included in the review request email."""
184 def __init__(self, *args, **kwargs):
185 super(_MailTextResult, self).__init__()
186 raise NotImplementedError()
187
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000188class GerritAccessor(object):
189 """Limited Gerrit functionality for canned presubmit checks to work.
190
191 To avoid excessive Gerrit calls, caches the results.
192 """
193
194 def __init__(self, host):
195 self.host = host
196 self.cache = {}
197
198 def _FetchChangeDetail(self, issue):
199 # Separate function to be easily mocked in tests.
200 return gerrit_util.GetChangeDetail(
201 self.host, str(issue),
202 ['ALL_REVISIONS', 'DETAILED_LABELS'])
203
204 def GetChangeInfo(self, issue):
205 """Returns labels and all revisions (patchsets) for this issue.
206
207 The result is a dictionary according to Gerrit REST Api.
208 https://gerrit-review.googlesource.com/Documentation/rest-api.html
209
210 However, API isn't very clear what's inside, so see tests for example.
211 """
212 assert issue
213 cache_key = int(issue)
214 if cache_key not in self.cache:
215 self.cache[cache_key] = self._FetchChangeDetail(issue)
216 return self.cache[cache_key]
217
218 def GetChangeDescription(self, issue, patchset=None):
219 """If patchset is none, fetches current patchset."""
220 info = self.GetChangeInfo(issue)
221 # info is a reference to cache. We'll modify it here adding description to
222 # it to the right patchset, if it is not yet there.
223
224 # Find revision info for the patchset we want.
225 if patchset is not None:
226 for rev, rev_info in info['revisions'].iteritems():
227 if str(rev_info['_number']) == str(patchset):
228 break
229 else:
230 raise Exception('patchset %s doesn\'t exist in issue %s' % (
231 patchset, issue))
232 else:
233 rev = info['current_revision']
234 rev_info = info['revisions'][rev]
235
236 # Updates revision info, which is part of cached issue info.
237 if 'real_description' not in rev_info:
238 rev_info['real_description'] = (
239 gerrit_util.GetChangeDescriptionFromGitiles(
240 rev_info['fetch']['http']['url'], rev))
241 return rev_info['real_description']
242
243 def GetChangeOwner(self, issue):
244 return self.GetChangeInfo(issue)['owner']['email']
245
246 def GetChangeReviewers(self, issue, approving_only=True):
agable565adb52016-07-22 14:48:07 -0700247 cr = self.GetChangeInfo(issue)['labels']['Code-Review']
248 max_value = max(int(k) for k in cr['values'].keys())
249 return [r['email'] for r in cr['all']
250 if not approving_only or r.get('value', 0) == max_value]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000251
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000252
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000253class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000254 """An instance of OutputApi gets passed to presubmit scripts so that they
255 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000256 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000257 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000258 PresubmitError = _PresubmitError
259 PresubmitPromptWarning = _PresubmitPromptWarning
260 PresubmitNotifyResult = _PresubmitNotifyResult
261 MailTextResult = _MailTextResult
262
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000263 def __init__(self, is_committing):
264 self.is_committing = is_committing
265
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000266 def PresubmitPromptOrNotify(self, *args, **kwargs):
267 """Warn the user when uploading, but only notify if committing."""
268 if self.is_committing:
269 return self.PresubmitNotifyResult(*args, **kwargs)
270 return self.PresubmitPromptWarning(*args, **kwargs)
271
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000272
273class InputApi(object):
274 """An instance of this object is passed to presubmit scripts so they can
275 know stuff about the change they're looking at.
276 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000277 # Method could be a function
278 # pylint: disable=R0201
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000279
maruel@chromium.org3410d912009-06-09 20:56:16 +0000280 # File extensions that are considered source files from a style guide
281 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000282 #
283 # Files without an extension aren't included in the list. If you want to
284 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
285 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000286 DEFAULT_WHITE_LIST = (
287 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000288 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
289 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000290 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000291 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000292 # Other
estade@chromium.orgae7af922012-01-27 14:51:13 +0000293 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000294 )
295
296 # Path regexp that should be excluded from being considered containing source
297 # files. Don't modify this list from a presubmit script!
298 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000299 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000300 r".*\bexperimental[\\\/].*",
primiano@chromium.orgb9658c32015-10-06 10:50:13 +0000301 # Exclude third_party/.* but NOT third_party/WebKit (crbug.com/539768).
302 r".*\bthird_party[\\\/](?!WebKit[\\\/]).*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000303 # Output directories (just in case)
304 r".*\bDebug[\\\/].*",
305 r".*\bRelease[\\\/].*",
306 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000307 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000308 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000309 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000310 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000311 r"(|.*[\\\/])\.git[\\\/].*",
312 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000313 # There is no point in processing a patch file.
314 r".+\.diff$",
315 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000316 )
317
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000318 def __init__(self, change, presubmit_path, is_committing,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000319 rietveld_obj, verbose, gerrit_obj=None, dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000320 """Builds an InputApi object.
321
322 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000323 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000324 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000325 is_committing: True if the change is about to be committed.
maruel@chromium.org239f4112011-06-03 20:08:23 +0000326 rietveld_obj: rietveld.Rietveld client object
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000327 gerrit_obj: provides basic Gerrit codereview functionality.
328 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000329 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000330 # Version number of the presubmit_support script.
331 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000332 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000333 self.is_committing = is_committing
maruel@chromium.org239f4112011-06-03 20:08:23 +0000334 self.rietveld = rietveld_obj
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000335 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000336 self.dry_run = dry_run
maruel@chromium.orgcab38e92011-04-09 00:30:51 +0000337 # TBD
338 self.host_url = 'http://codereview.chromium.org'
339 if self.rietveld:
maruel@chromium.org239f4112011-06-03 20:08:23 +0000340 self.host_url = self.rietveld.url
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000341
342 # We expose various modules and functions as attributes of the input_api
343 # so that presubmit scripts don't have to import them.
344 self.basename = os.path.basename
345 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000346 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000347 self.cStringIO = cStringIO
dcheng091b7db2016-06-16 01:27:51 -0700348 self.fnmatch = fnmatch
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000349 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000350 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000351 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000352 self.os_listdir = os.listdir
353 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000354 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000355 self.os_stat = os.stat
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000356 self.pickle = pickle
357 self.marshal = marshal
358 self.re = re
359 self.subprocess = subprocess
360 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000361 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000362 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000363 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000364 self.urllib2 = urllib2
365
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000366 # To easily fork python.
367 self.python_executable = sys.executable
368 self.environ = os.environ
369
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000370 # InputApi.platform is the platform you're currently running on.
371 self.platform = sys.platform
372
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000373 self.cpu_count = multiprocessing.cpu_count()
374
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000375 # this is done here because in RunTests, the current working directory has
376 # changed, which causes Pool() to explode fantastically when run on windows
377 # (because it tries to load the __main__ module, which imports lots of
378 # things relative to the current working directory).
379 self._run_tests_pool = multiprocessing.Pool(self.cpu_count)
380
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000381 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000382 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000383
384 # We carry the canned checks so presubmit scripts can easily use them.
385 self.canned_checks = presubmit_canned_checks
386
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000387 # TODO(dpranke): figure out a list of all approved owners for a repo
388 # in order to be able to handle wildcard OWNERS files?
389 self.owners_db = owners.Database(change.RepositoryRoot(),
dtu944b6052016-07-14 14:48:21 -0700390 fopen=file, os_path=self.os_path)
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000391 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000392 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000393
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000394 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000395 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000396 # Access to a protected member _XX of a client class
397 # pylint: disable=W0212
398 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000399 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000400 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
401 for (a, b, header) in cpplint._re_pattern_templates
402 ]
403
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000404 def PresubmitLocalPath(self):
405 """Returns the local path of the presubmit script currently being run.
406
407 This is useful if you don't want to hard-code absolute paths in the
408 presubmit script. For example, It can be used to find another file
409 relative to the PRESUBMIT.py script, so the whole tree can be branched and
410 the presubmit script still works, without editing its content.
411 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000412 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000413
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000414 def DepotToLocalPath(self, depot_path):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000415 """Translate a depot path to a local path (relative to client root).
416
417 Args:
418 Depot path as a string.
419
420 Returns:
421 The local path of the depot path under the user's current client, or None
422 if the file is not mapped.
423
424 Remember to check for the None case and show an appropriate error!
425 """
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000426 return scm.SVN.CaptureLocalInfo([depot_path], self.change.RepositoryRoot()
427 ).get('Path')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000428
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000429 def LocalToDepotPath(self, local_path):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000430 """Translate a local path to a depot path.
431
432 Args:
433 Local path (relative to current directory, or absolute) as a string.
434
435 Returns:
436 The depot path (SVN URL) of the file if mapped, otherwise None.
437 """
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000438 return scm.SVN.CaptureLocalInfo([local_path], self.change.RepositoryRoot()
439 ).get('URL')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000440
sail@chromium.org5538e022011-05-12 17:53:16 +0000441 def AffectedFiles(self, include_dirs=False, include_deletes=True,
442 file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000443 """Same as input_api.change.AffectedFiles() except only lists files
444 (and optionally directories) in the same directory as the current presubmit
445 script, or subdirectories thereof.
446 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000447 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000448 if len(dir_with_slash) == 1:
449 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000450
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000451 return filter(
452 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
sail@chromium.org5538e022011-05-12 17:53:16 +0000453 self.change.AffectedFiles(include_dirs, include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000454
455 def LocalPaths(self, include_dirs=False):
456 """Returns local paths of input_api.AffectedFiles()."""
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000457 paths = [af.LocalPath() for af in self.AffectedFiles(include_dirs)]
458 logging.debug("LocalPaths: %s", paths)
459 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000460
461 def AbsoluteLocalPaths(self, include_dirs=False):
462 """Returns absolute local paths of input_api.AffectedFiles()."""
463 return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)]
464
465 def ServerPaths(self, include_dirs=False):
466 """Returns server paths of input_api.AffectedFiles()."""
467 return [af.ServerPath() for af in self.AffectedFiles(include_dirs)]
468
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000469 def AffectedTextFiles(self, include_deletes=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000470 """Same as input_api.change.AffectedTextFiles() except only lists files
471 in the same directory as the current presubmit script, or subdirectories
472 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000473 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000474 if include_deletes is not None:
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000475 warn("AffectedTextFiles(include_deletes=%s)"
476 " is deprecated and ignored" % str(include_deletes),
477 category=DeprecationWarning,
478 stacklevel=2)
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000479 return filter(lambda x: x.IsTextFile(),
480 self.AffectedFiles(include_dirs=False, include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000481
maruel@chromium.org3410d912009-06-09 20:56:16 +0000482 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
483 """Filters out files that aren't considered "source file".
484
485 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
486 and InputApi.DEFAULT_BLACK_LIST is used respectively.
487
488 The lists will be compiled as regular expression and
489 AffectedFile.LocalPath() needs to pass both list.
490
491 Note: Copy-paste this function to suit your needs or use a lambda function.
492 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000493 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000494 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000495 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000496 if self.re.match(item, local_path):
tobiasjs2836bcf2016-08-16 04:08:16 -0700497 logging.debug("%s matched %s", item, local_path)
maruel@chromium.org3410d912009-06-09 20:56:16 +0000498 return True
499 return False
500 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
501 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
502
503 def AffectedSourceFiles(self, source_file):
504 """Filter the list of AffectedTextFiles by the function source_file.
505
506 If source_file is None, InputApi.FilterSourceFile() is used.
507 """
508 if not source_file:
509 source_file = self.FilterSourceFile
510 return filter(source_file, self.AffectedTextFiles())
511
512 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000513 """An iterator over all text lines in "new" version of changed files.
514
515 Only lists lines from new or modified text files in the change that are
516 contained by the directory of the currently executing presubmit script.
517
518 This is useful for doing line-by-line regex checks, like checking for
519 trailing whitespace.
520
521 Yields:
522 a 3 tuple:
523 the AffectedFile instance of the current file;
524 integer line number (1-based); and
525 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000526
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000527 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000528 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000529 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000530 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000531
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000532 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000533 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000534
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000535 Deny reading anything outside the repository.
536 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000537 if isinstance(file_item, AffectedFile):
538 file_item = file_item.AbsoluteLocalPath()
539 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000540 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000541 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000542
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000543 @property
544 def tbr(self):
545 """Returns if a change is TBR'ed."""
546 return 'TBR' in self.change.tags
547
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000548 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000549 tests = []
550 msgs = []
551 for t in tests_mix:
552 if isinstance(t, OutputApi.PresubmitResult):
553 msgs.append(t)
554 else:
555 assert issubclass(t.message, _PresubmitResult)
556 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000557 if self.verbose:
558 t.info = _PresubmitNotifyResult
ilevy@chromium.org5678d332013-05-18 01:34:14 +0000559 if len(tests) > 1 and parallel:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000560 # async recipe works around multiprocessing bug handling Ctrl-C
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000561 msgs.extend(self._run_tests_pool.map_async(CallCommand, tests).get(99999))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000562 else:
563 msgs.extend(map(CallCommand, tests))
564 return [m for m in msgs if m]
565
scottmg86099d72016-09-01 09:16:51 -0700566 def ShutdownPool(self):
567 self._run_tests_pool.close()
568 self._run_tests_pool.join()
569 self._run_tests_pool = None
570
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000571
nick@chromium.orgff526192013-06-10 19:30:26 +0000572class _DiffCache(object):
573 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000574 def __init__(self, upstream=None):
575 """Stores the upstream revision against which all diffs will be computed."""
576 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000577
578 def GetDiff(self, path, local_root):
579 """Get the diff for a particular path."""
580 raise NotImplementedError()
581
582
583class _SvnDiffCache(_DiffCache):
584 """DiffCache implementation for subversion."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000585 def __init__(self, *args, **kwargs):
586 super(_SvnDiffCache, self).__init__(*args, **kwargs)
nick@chromium.orgff526192013-06-10 19:30:26 +0000587 self._diffs_by_file = {}
588
589 def GetDiff(self, path, local_root):
590 if path not in self._diffs_by_file:
591 self._diffs_by_file[path] = scm.SVN.GenerateDiff([path], local_root,
592 False, None)
593 return self._diffs_by_file[path]
594
595
596class _GitDiffCache(_DiffCache):
597 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000598 def __init__(self, upstream):
599 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000600 self._diffs_by_file = None
601
602 def GetDiff(self, path, local_root):
603 if not self._diffs_by_file:
604 # Compute a single diff for all files and parse the output; should
605 # with git this is much faster than computing one diff for each file.
606 diffs = {}
607
608 # Don't specify any filenames below, because there are command line length
609 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000610 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
611 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000612
613 # This regex matches the path twice, separated by a space. Note that
614 # filename itself may contain spaces.
615 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
616 current_diff = []
617 keep_line_endings = True
618 for x in unified_diff.splitlines(keep_line_endings):
619 match = file_marker.match(x)
620 if match:
621 # Marks the start of a new per-file section.
622 diffs[match.group('filename')] = current_diff = [x]
623 elif x.startswith('diff --git'):
624 raise PresubmitFailure('Unexpected diff line: %s' % x)
625 else:
626 current_diff.append(x)
627
628 self._diffs_by_file = dict(
629 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
630
631 if path not in self._diffs_by_file:
632 raise PresubmitFailure(
633 'Unified diff did not contain entry for file %s' % path)
634
635 return self._diffs_by_file[path]
636
637
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000638class AffectedFile(object):
639 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000640
641 DIFF_CACHE = _DiffCache
642
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000643 # Method could be a function
644 # pylint: disable=R0201
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000645 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000646 self._path = path
647 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000648 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000649 self._is_directory = None
650 self._properties = {}
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000651 self._cached_changed_contents = None
652 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000653 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700654 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000655
656 def ServerPath(self):
657 """Returns a path string that identifies the file in the SCM system.
658
659 Returns the empty string if the file does not exist in SCM.
660 """
nick@chromium.orgff526192013-06-10 19:30:26 +0000661 return ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000662
663 def LocalPath(self):
664 """Returns the path of this file on the local disk relative to client root.
665 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000666 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000667
668 def AbsoluteLocalPath(self):
669 """Returns the absolute path of this file on the local disk.
670 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000671 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000672
673 def IsDirectory(self):
674 """Returns true if this object is a directory."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000675 if self._is_directory is None:
676 path = self.AbsoluteLocalPath()
677 self._is_directory = (os.path.exists(path) and
678 os.path.isdir(path))
679 return self._is_directory
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000680
681 def Action(self):
682 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000683 # TODO(maruel): Somewhat crappy, Could be "A" or "A +" for svn but
684 # different for other SCM.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000685 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000686
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000687 def Property(self, property_name):
688 """Returns the specified SCM property of this file, or None if no such
689 property.
690 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000691 return self._properties.get(property_name, None)
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000692
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000693 def IsTextFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000694 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000695
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000696 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000697 raise NotImplementedError() # Implement when needed
698
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000699 def NewContents(self):
700 """Returns an iterator over the lines in the new version of file.
701
702 The new version is the file in the user's workspace, i.e. the "right hand
703 side".
704
705 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000706 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000707 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000708 if self._cached_new_contents is None:
709 self._cached_new_contents = []
710 if not self.IsDirectory():
711 try:
712 self._cached_new_contents = gclient_utils.FileRead(
713 self.AbsoluteLocalPath(), 'rU').splitlines()
714 except IOError:
715 pass # File not found? That's fine; maybe it was deleted.
716 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000717
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000718 def ChangedContents(self):
719 """Returns a list of tuples (line number, line text) of all new lines.
720
721 This relies on the scm diff output describing each changed code section
722 with a line of the form
723
724 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
725 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000726 if self._cached_changed_contents is not None:
727 return self._cached_changed_contents[:]
728 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000729 line_num = 0
730
731 if self.IsDirectory():
732 return []
733
734 for line in self.GenerateScmDiff().splitlines():
735 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
736 if m:
737 line_num = int(m.groups(1)[0])
738 continue
739 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000740 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000741 if not line.startswith('-'):
742 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000743 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000744
maruel@chromium.org5de13972009-06-10 18:16:06 +0000745 def __str__(self):
746 return self.LocalPath()
747
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000748 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000749 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000750
maruel@chromium.org58407af2011-04-12 23:15:57 +0000751
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000752class SvnAffectedFile(AffectedFile):
753 """Representation of a file in a change out of a Subversion checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000754 # Method 'NNN' is abstract in class 'NNN' but is not overridden
755 # pylint: disable=W0223
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000756
nick@chromium.orgff526192013-06-10 19:30:26 +0000757 DIFF_CACHE = _SvnDiffCache
758
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000759 def __init__(self, *args, **kwargs):
760 AffectedFile.__init__(self, *args, **kwargs)
761 self._server_path = None
762 self._is_text_file = None
763
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000764 def ServerPath(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000765 if self._server_path is None:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000766 self._server_path = scm.SVN.CaptureLocalInfo(
767 [self.LocalPath()], self._local_root).get('URL', '')
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000768 return self._server_path
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000769
770 def IsDirectory(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000771 if self._is_directory is None:
772 path = self.AbsoluteLocalPath()
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000773 if os.path.exists(path):
774 # Retrieve directly from the file system; it is much faster than
775 # querying subversion, especially on Windows.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000776 self._is_directory = os.path.isdir(path)
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000777 else:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000778 self._is_directory = scm.SVN.CaptureLocalInfo(
779 [self.LocalPath()], self._local_root
780 ).get('Node Kind') in ('dir', 'directory')
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000781 return self._is_directory
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000782
783 def Property(self, property_name):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000784 if not property_name in self._properties:
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000785 self._properties[property_name] = scm.SVN.GetFileProperty(
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000786 self.LocalPath(), property_name, self._local_root).rstrip()
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000787 return self._properties[property_name]
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000788
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000789 def IsTextFile(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000790 if self._is_text_file is None:
791 if self.Action() == 'D':
792 # A deleted file is not a text file.
793 self._is_text_file = False
794 elif self.IsDirectory():
795 self._is_text_file = False
796 else:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000797 mime_type = scm.SVN.GetFileProperty(
798 self.LocalPath(), 'svn:mime-type', self._local_root)
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000799 self._is_text_file = (not mime_type or mime_type.startswith('text/'))
800 return self._is_text_file
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000801
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000802
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000803class GitAffectedFile(AffectedFile):
804 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000805 # Method 'NNN' is abstract in class 'NNN' but is not overridden
806 # pylint: disable=W0223
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000807
nick@chromium.orgff526192013-06-10 19:30:26 +0000808 DIFF_CACHE = _GitDiffCache
809
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000810 def __init__(self, *args, **kwargs):
811 AffectedFile.__init__(self, *args, **kwargs)
812 self._server_path = None
813 self._is_text_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000814
815 def ServerPath(self):
816 if self._server_path is None:
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000817 raise NotImplementedError('TODO(maruel) Implement.')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000818 return self._server_path
819
820 def IsDirectory(self):
821 if self._is_directory is None:
822 path = self.AbsoluteLocalPath()
823 if os.path.exists(path):
824 # Retrieve directly from the file system; it is much faster than
825 # querying subversion, especially on Windows.
826 self._is_directory = os.path.isdir(path)
827 else:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000828 self._is_directory = False
829 return self._is_directory
830
831 def Property(self, property_name):
832 if not property_name in self._properties:
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000833 raise NotImplementedError('TODO(maruel) Implement.')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000834 return self._properties[property_name]
835
836 def IsTextFile(self):
837 if self._is_text_file is None:
838 if self.Action() == 'D':
839 # A deleted file is not a text file.
840 self._is_text_file = False
841 elif self.IsDirectory():
842 self._is_text_file = False
843 else:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000844 self._is_text_file = os.path.isfile(self.AbsoluteLocalPath())
845 return self._is_text_file
846
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000847
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000848class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000849 """Describe a change.
850
851 Used directly by the presubmit scripts to query the current change being
852 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000853
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000854 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000855 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000856 self.KEY: equivalent to tags['KEY']
857 """
858
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000859 _AFFECTED_FILES = AffectedFile
860
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000861 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000862 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000863 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000864 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000865
maruel@chromium.org58407af2011-04-12 23:15:57 +0000866 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000867 self, name, description, local_root, files, issue, patchset, author,
868 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000869 if files is None:
870 files = []
871 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +0000872 # Convert root into an absolute path.
873 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000874 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000875 self.issue = issue
876 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +0000877 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000878
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000879 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000880 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000881 self._description_without_tags = ''
882 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000883
maruel@chromium.orge085d812011-10-10 19:49:15 +0000884 assert all(
885 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
886
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000887 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000888 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +0000889 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
890 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000891 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000892
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000893 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000894 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000895 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000896
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000897 def DescriptionText(self):
898 """Returns the user-entered changelist description, minus tags.
899
900 Any line in the user-provided description starting with e.g. "FOO="
901 (whitespace permitted before and around) is considered a tag line. Such
902 lines are stripped out of the description this function returns.
903 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000904 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000905
906 def FullDescriptionText(self):
907 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000908 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000909
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000910 def SetDescriptionText(self, description):
911 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +0000912
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000913 Also updates the list of tags."""
914 self._full_description = description
915
916 # From the description text, build up a dictionary of key/value pairs
917 # plus the description minus all key/value or "tag" lines.
918 description_without_tags = []
919 self.tags = {}
920 for line in self._full_description.splitlines():
921 m = self.TAG_LINE_RE.match(line)
922 if m:
923 self.tags[m.group('key')] = m.group('value')
924 else:
925 description_without_tags.append(line)
926
927 # Change back to text and remove whitespace at end.
928 self._description_without_tags = (
929 '\n'.join(description_without_tags).rstrip())
930
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000931 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000932 """Returns the repository (checkout) root directory for this change,
933 as an absolute path.
934 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000935 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000936
937 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000938 """Return tags directly as attributes on the object."""
939 if not re.match(r"^[A-Z_]*$", attr):
940 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +0000941 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000942
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000943 def AllFiles(self, root=None):
944 """List all files under source control in the repo."""
945 raise NotImplementedError()
946
sail@chromium.org5538e022011-05-12 17:53:16 +0000947 def AffectedFiles(self, include_dirs=False, include_deletes=True,
948 file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000949 """Returns a list of AffectedFile instances for all files in the change.
950
951 Args:
952 include_deletes: If false, deleted files will be filtered out.
953 include_dirs: True to include directories in the list
sail@chromium.org5538e022011-05-12 17:53:16 +0000954 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000955
956 Returns:
957 [AffectedFile(path, action), AffectedFile(path, action)]
958 """
959 if include_dirs:
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000960 affected = self._affected_files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000961 else:
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000962 affected = filter(lambda x: not x.IsDirectory(), self._affected_files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000963
sail@chromium.org5538e022011-05-12 17:53:16 +0000964 affected = filter(file_filter, affected)
965
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000966 if include_deletes:
967 return affected
968 else:
969 return filter(lambda x: x.Action() != 'D', affected)
970
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000971 def AffectedTextFiles(self, include_deletes=None):
972 """Return a list of the existing text files in a change."""
973 if include_deletes is not None:
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000974 warn("AffectedTextFiles(include_deletes=%s)"
975 " is deprecated and ignored" % str(include_deletes),
976 category=DeprecationWarning,
977 stacklevel=2)
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000978 return filter(lambda x: x.IsTextFile(),
979 self.AffectedFiles(include_dirs=False, include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000980
981 def LocalPaths(self, include_dirs=False):
982 """Convenience function."""
983 return [af.LocalPath() for af in self.AffectedFiles(include_dirs)]
984
985 def AbsoluteLocalPaths(self, include_dirs=False):
986 """Convenience function."""
987 return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)]
988
989 def ServerPaths(self, include_dirs=False):
990 """Convenience function."""
991 return [af.ServerPath() for af in self.AffectedFiles(include_dirs)]
992
993 def RightHandSideLines(self):
994 """An iterator over all text lines in "new" version of changed files.
995
996 Lists lines from new or modified text files in the change.
997
998 This is useful for doing line-by-line regex checks, like checking for
999 trailing whitespace.
1000
1001 Yields:
1002 a 3 tuple:
1003 the AffectedFile instance of the current file;
1004 integer line number (1-based); and
1005 the contents of the line as a string.
1006 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001007 return _RightHandSideLinesImpl(
1008 x for x in self.AffectedFiles(include_deletes=False)
1009 if x.IsTextFile())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001010
1011
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001012class SvnChange(Change):
1013 _AFFECTED_FILES = SvnAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001014 scm = 'svn'
1015 _changelists = None
thestig@chromium.org6bd31702009-09-02 23:29:07 +00001016
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001017 def AllFiles(self, root=None):
1018 """List all files under source control in the repo."""
1019 root = root or self.RepositoryRoot()
1020 return subprocess.check_output(
1021 ['svn', 'ls', '-R', '.'], cwd=root).splitlines()
1022
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001023
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001024class GitChange(Change):
1025 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001026 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001027
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001028 def AllFiles(self, root=None):
1029 """List all files under source control in the repo."""
1030 root = root or self.RepositoryRoot()
1031 return subprocess.check_output(
1032 ['git', 'ls-files', '--', '.'], cwd=root).splitlines()
1033
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001034
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001035def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001036 """Finds all presubmit files that apply to a given set of source files.
1037
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001038 If inherit-review-settings-ok is present right under root, looks for
1039 PRESUBMIT.py in directories enclosing root.
1040
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001041 Args:
1042 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001043 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001044
1045 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001046 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001047 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001048 files = [normpath(os.path.join(root, f)) for f in files]
1049
1050 # List all the individual directories containing files.
1051 directories = set([os.path.dirname(f) for f in files])
1052
1053 # Ignore root if inherit-review-settings-ok is present.
1054 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1055 root = None
1056
1057 # Collect all unique directories that may contain PRESUBMIT.py.
1058 candidates = set()
1059 for directory in directories:
1060 while True:
1061 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001062 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001063 candidates.add(directory)
1064 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001065 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001066 parent_dir = os.path.dirname(directory)
1067 if parent_dir == directory:
1068 # We hit the system root directory.
1069 break
1070 directory = parent_dir
1071
1072 # Look for PRESUBMIT.py in all candidate directories.
1073 results = []
1074 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001075 try:
1076 for f in os.listdir(directory):
1077 p = os.path.join(directory, f)
1078 if os.path.isfile(p) and re.match(
1079 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1080 results.append(p)
1081 except OSError:
1082 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001083
tobiasjs2836bcf2016-08-16 04:08:16 -07001084 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001085 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001086
1087
thestig@chromium.orgde243452009-10-06 21:02:56 +00001088class GetTrySlavesExecuter(object):
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001089 @staticmethod
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001090 def ExecPresubmitScript(script_text, presubmit_path, project, change):
thestig@chromium.orgde243452009-10-06 21:02:56 +00001091 """Executes GetPreferredTrySlaves() from a single presubmit script.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001092
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001093 This will soon be deprecated and replaced by GetPreferredTryMasters().
thestig@chromium.orgde243452009-10-06 21:02:56 +00001094
1095 Args:
1096 script_text: The text of the presubmit script.
bradnelson@google.com78230022011-05-24 18:55:19 +00001097 presubmit_path: Project script to run.
1098 project: Project name to pass to presubmit script for bot selection.
thestig@chromium.orgde243452009-10-06 21:02:56 +00001099
1100 Return:
1101 A list of try slaves.
1102 """
1103 context = {}
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001104 main_path = os.getcwd()
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001105 try:
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001106 os.chdir(os.path.dirname(presubmit_path))
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001107 exec script_text in context
1108 except Exception, e:
1109 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001110 finally:
1111 os.chdir(main_path)
thestig@chromium.orgde243452009-10-06 21:02:56 +00001112
1113 function_name = 'GetPreferredTrySlaves'
1114 if function_name in context:
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001115 get_preferred_try_slaves = context[function_name]
1116 function_info = inspect.getargspec(get_preferred_try_slaves)
1117 if len(function_info[0]) == 1:
1118 result = get_preferred_try_slaves(project)
1119 elif len(function_info[0]) == 2:
1120 result = get_preferred_try_slaves(project, change)
1121 else:
1122 result = get_preferred_try_slaves()
thestig@chromium.orgde243452009-10-06 21:02:56 +00001123 if not isinstance(result, types.ListType):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001124 raise PresubmitFailure(
thestig@chromium.orgde243452009-10-06 21:02:56 +00001125 'Presubmit functions must return a list, got a %s instead: %s' %
1126 (type(result), str(result)))
1127 for item in result:
stip@chromium.org68e04192013-11-04 22:14:38 +00001128 if isinstance(item, basestring):
1129 # Old-style ['bot'] format.
1130 botname = item
1131 elif isinstance(item, tuple):
1132 # New-style [('bot', set(['tests']))] format.
1133 botname = item[0]
1134 else:
1135 raise PresubmitFailure('PRESUBMIT.py returned invalid tryslave/test'
1136 ' format.')
1137
1138 if botname != botname.strip():
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001139 raise PresubmitFailure(
1140 'Try slave names cannot start/end with whitespace')
stip@chromium.org68e04192013-11-04 22:14:38 +00001141 if ',' in botname:
maruel@chromium.org3ecc8ea2012-03-10 01:47:46 +00001142 raise PresubmitFailure(
stip@chromium.org68e04192013-11-04 22:14:38 +00001143 'Do not use \',\' separated builder or test names: %s' % botname)
thestig@chromium.orgde243452009-10-06 21:02:56 +00001144 else:
1145 result = []
stip@chromium.org5ca27622013-12-18 17:44:58 +00001146
1147 def valid_oldstyle(result):
1148 return all(isinstance(i, basestring) for i in result)
1149
1150 def valid_newstyle(result):
1151 return (all(isinstance(i, tuple) for i in result) and
1152 all(len(i) == 2 for i in result) and
1153 all(isinstance(i[0], basestring) for i in result) and
1154 all(isinstance(i[1], set) for i in result)
1155 )
1156
1157 # Ensure it's either all old-style or all new-style.
1158 if not valid_oldstyle(result) and not valid_newstyle(result):
1159 raise PresubmitFailure(
1160 'PRESUBMIT.py returned invalid trybot specification!')
1161
thestig@chromium.orgde243452009-10-06 21:02:56 +00001162 return result
1163
1164
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001165class GetTryMastersExecuter(object):
1166 @staticmethod
1167 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1168 """Executes GetPreferredTryMasters() from a single presubmit script.
1169
1170 Args:
1171 script_text: The text of the presubmit script.
1172 presubmit_path: Project script to run.
1173 project: Project name to pass to presubmit script for bot selection.
1174
1175 Return:
1176 A map of try masters to map of builders to set of tests.
1177 """
1178 context = {}
1179 try:
1180 exec script_text in context
1181 except Exception, e:
1182 raise PresubmitFailure('"%s" had an exception.\n%s'
1183 % (presubmit_path, e))
1184
1185 function_name = 'GetPreferredTryMasters'
1186 if function_name not in context:
1187 return {}
1188 get_preferred_try_masters = context[function_name]
1189 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1190 raise PresubmitFailure(
1191 'Expected function "GetPreferredTryMasters" to take two arguments.')
1192 return get_preferred_try_masters(project, change)
1193
1194
rmistry@google.com5626a922015-02-26 14:03:30 +00001195class GetPostUploadExecuter(object):
1196 @staticmethod
1197 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1198 """Executes PostUploadHook() from a single presubmit script.
1199
1200 Args:
1201 script_text: The text of the presubmit script.
1202 presubmit_path: Project script to run.
1203 cl: The Changelist object.
1204 change: The Change object.
1205
1206 Return:
1207 A list of results objects.
1208 """
1209 context = {}
1210 try:
1211 exec script_text in context
1212 except Exception, e:
1213 raise PresubmitFailure('"%s" had an exception.\n%s'
1214 % (presubmit_path, e))
1215
1216 function_name = 'PostUploadHook'
1217 if function_name not in context:
1218 return {}
1219 post_upload_hook = context[function_name]
1220 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1221 raise PresubmitFailure(
1222 'Expected function "PostUploadHook" to take three arguments.')
1223 return post_upload_hook(cl, change, OutputApi(False))
1224
1225
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001226def DoGetTrySlaves(change,
1227 changed_files,
thestig@chromium.orgde243452009-10-06 21:02:56 +00001228 repository_root,
1229 default_presubmit,
bradnelson@google.com78230022011-05-24 18:55:19 +00001230 project,
thestig@chromium.orgde243452009-10-06 21:02:56 +00001231 verbose,
1232 output_stream):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001233 """Get the list of try servers from the presubmit scripts (deprecated).
thestig@chromium.orgde243452009-10-06 21:02:56 +00001234
1235 Args:
1236 changed_files: List of modified files.
1237 repository_root: The repository root.
1238 default_presubmit: A default presubmit script to execute in any case.
bradnelson@google.com78230022011-05-24 18:55:19 +00001239 project: Optional name of a project used in selecting trybots.
thestig@chromium.orgde243452009-10-06 21:02:56 +00001240 verbose: Prints debug info.
1241 output_stream: A stream to write debug output to.
1242
1243 Return:
1244 List of try slaves
1245 """
1246 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1247 if not presubmit_files and verbose:
mdempsky@chromium.orgd59e7612014-03-05 19:55:56 +00001248 output_stream.write("Warning, no PRESUBMIT.py found.\n")
thestig@chromium.orgde243452009-10-06 21:02:56 +00001249 results = []
1250 executer = GetTrySlavesExecuter()
stip@chromium.org5ca27622013-12-18 17:44:58 +00001251
thestig@chromium.orgde243452009-10-06 21:02:56 +00001252 if default_presubmit:
1253 if verbose:
1254 output_stream.write("Running default presubmit script.\n")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001255 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
stip@chromium.org5ca27622013-12-18 17:44:58 +00001256 results.extend(executer.ExecPresubmitScript(
1257 default_presubmit, fake_path, project, change))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001258 for filename in presubmit_files:
1259 filename = os.path.abspath(filename)
1260 if verbose:
1261 output_stream.write("Running %s\n" % filename)
1262 # Accept CRLF presubmit script.
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +00001263 presubmit_script = gclient_utils.FileRead(filename, 'rU')
stip@chromium.org5ca27622013-12-18 17:44:58 +00001264 results.extend(executer.ExecPresubmitScript(
1265 presubmit_script, filename, project, change))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001266
stip@chromium.org5ca27622013-12-18 17:44:58 +00001267
1268 slave_dict = {}
1269 old_style = filter(lambda x: isinstance(x, basestring), results)
1270 new_style = filter(lambda x: isinstance(x, tuple), results)
1271
1272 for result in new_style:
1273 slave_dict.setdefault(result[0], set()).update(result[1])
1274 slaves = list(slave_dict.items())
1275
1276 slaves.extend(set(old_style))
stip@chromium.org68e04192013-11-04 22:14:38 +00001277
thestig@chromium.orgde243452009-10-06 21:02:56 +00001278 if slaves and verbose:
stip@chromium.org5ca27622013-12-18 17:44:58 +00001279 output_stream.write(', '.join((str(x) for x in slaves)))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001280 output_stream.write('\n')
1281 return slaves
1282
1283
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001284def _MergeMasters(masters1, masters2):
1285 """Merges two master maps. Merges also the tests of each builder."""
1286 result = {}
1287 for (master, builders) in itertools.chain(masters1.iteritems(),
1288 masters2.iteritems()):
1289 new_builders = result.setdefault(master, {})
1290 for (builder, tests) in builders.iteritems():
1291 new_builders.setdefault(builder, set([])).update(tests)
1292 return result
1293
1294
1295def DoGetTryMasters(change,
1296 changed_files,
1297 repository_root,
1298 default_presubmit,
1299 project,
1300 verbose,
1301 output_stream):
1302 """Get the list of try masters from the presubmit scripts.
1303
1304 Args:
1305 changed_files: List of modified files.
1306 repository_root: The repository root.
1307 default_presubmit: A default presubmit script to execute in any case.
1308 project: Optional name of a project used in selecting trybots.
1309 verbose: Prints debug info.
1310 output_stream: A stream to write debug output to.
1311
1312 Return:
1313 Map of try masters to map of builders to set of tests.
1314 """
1315 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1316 if not presubmit_files and verbose:
1317 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1318 results = {}
1319 executer = GetTryMastersExecuter()
1320
1321 if default_presubmit:
1322 if verbose:
1323 output_stream.write("Running default presubmit script.\n")
1324 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1325 results = _MergeMasters(results, executer.ExecPresubmitScript(
1326 default_presubmit, fake_path, project, change))
1327 for filename in presubmit_files:
1328 filename = os.path.abspath(filename)
1329 if verbose:
1330 output_stream.write("Running %s\n" % filename)
1331 # Accept CRLF presubmit script.
1332 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1333 results = _MergeMasters(results, executer.ExecPresubmitScript(
1334 presubmit_script, filename, project, change))
1335
1336 # Make sets to lists again for later JSON serialization.
1337 for builders in results.itervalues():
1338 for builder in builders:
1339 builders[builder] = list(builders[builder])
1340
1341 if results and verbose:
1342 output_stream.write('%s\n' % str(results))
1343 return results
1344
1345
rmistry@google.com5626a922015-02-26 14:03:30 +00001346def DoPostUploadExecuter(change,
1347 cl,
1348 repository_root,
1349 verbose,
1350 output_stream):
1351 """Execute the post upload hook.
1352
1353 Args:
1354 change: The Change object.
1355 cl: The Changelist object.
1356 repository_root: The repository root.
1357 verbose: Prints debug info.
1358 output_stream: A stream to write debug output to.
1359 """
1360 presubmit_files = ListRelevantPresubmitFiles(
1361 change.LocalPaths(), repository_root)
1362 if not presubmit_files and verbose:
1363 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1364 results = []
1365 executer = GetPostUploadExecuter()
1366 # The root presubmit file should be executed after the ones in subdirectories.
1367 # i.e. the specific post upload hooks should run before the general ones.
1368 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1369 presubmit_files.reverse()
1370
1371 for filename in presubmit_files:
1372 filename = os.path.abspath(filename)
1373 if verbose:
1374 output_stream.write("Running %s\n" % filename)
1375 # Accept CRLF presubmit script.
1376 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1377 results.extend(executer.ExecPresubmitScript(
1378 presubmit_script, filename, cl, change))
1379 output_stream.write('\n')
1380 if results:
1381 output_stream.write('** Post Upload Hook Messages **\n')
1382 for result in results:
1383 result.handle(output_stream)
1384 output_stream.write('\n')
1385
1386 return results
1387
1388
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001389class PresubmitExecuter(object):
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001390 def __init__(self, change, committing, rietveld_obj, verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001391 gerrit_obj=None, dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001392 """
1393 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001394 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001395 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001396 rietveld_obj: rietveld.Rietveld client object.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001397 gerrit_obj: provides basic Gerrit codereview functionality.
1398 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001399 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001400 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001401 self.committing = committing
maruel@chromium.org239f4112011-06-03 20:08:23 +00001402 self.rietveld = rietveld_obj
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001403 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001404 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001405 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001406
1407 def ExecPresubmitScript(self, script_text, presubmit_path):
1408 """Executes a single presubmit script.
1409
1410 Args:
1411 script_text: The text of the presubmit script.
1412 presubmit_path: The path to the presubmit file (this will be reported via
1413 input_api.PresubmitLocalPath()).
1414
1415 Return:
1416 A list of result objects, empty if no problems.
1417 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001418
chase@chromium.org8e416c82009-10-06 04:30:44 +00001419 # Change to the presubmit file's directory to support local imports.
1420 main_path = os.getcwd()
1421 os.chdir(os.path.dirname(presubmit_path))
1422
1423 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001424 input_api = InputApi(self.change, presubmit_path, self.committing,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001425 self.rietveld, self.verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001426 gerrit_obj=self.gerrit, dry_run=self.dry_run)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001427 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001428 try:
1429 exec script_text in context
1430 except Exception, e:
1431 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001432
1433 # These function names must change if we make substantial changes to
1434 # the presubmit API that are not backwards compatible.
1435 if self.committing:
1436 function_name = 'CheckChangeOnCommit'
1437 else:
1438 function_name = 'CheckChangeOnUpload'
1439 if function_name in context:
wez@chromium.orga6d011e2013-03-26 17:31:49 +00001440 context['__args'] = (input_api, OutputApi(self.committing))
tobiasjs2836bcf2016-08-16 04:08:16 -07001441 logging.debug('Running %s in %s', function_name, presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001442 result = eval(function_name + '(*__args)', context)
tobiasjs2836bcf2016-08-16 04:08:16 -07001443 logging.debug('Running %s done.', function_name)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001444 if not (isinstance(result, types.TupleType) or
1445 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001446 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001447 'Presubmit functions must return a tuple or list')
1448 for item in result:
1449 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001450 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001451 'All presubmit results must be of types derived from '
1452 'output_api.PresubmitResult')
1453 else:
1454 result = () # no error since the script doesn't care about current event.
1455
scottmg86099d72016-09-01 09:16:51 -07001456 input_api.ShutdownPool()
1457
chase@chromium.org8e416c82009-10-06 04:30:44 +00001458 # Return the process to the original working directory.
1459 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001460 return result
1461
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001462
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001463def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001464 committing,
1465 verbose,
1466 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001467 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001468 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001469 may_prompt,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001470 rietveld_obj,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001471 gerrit_obj=None,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001472 dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001473 """Runs all presubmit checks that apply to the files in the change.
1474
1475 This finds all PRESUBMIT.py files in directories enclosing the files in the
1476 change (up to the repository root) and calls the relevant entrypoint function
1477 depending on whether the change is being committed or uploaded.
1478
1479 Prints errors, warnings and notifications. Prompts the user for warnings
1480 when needed.
1481
1482 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001483 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001484 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001485 verbose: Prints debug info.
1486 output_stream: A stream to write output from presubmit tests to.
1487 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001488 default_presubmit: A default presubmit script to execute in any case.
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001489 may_prompt: Enable (y/n) questions on warning or error.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001490 rietveld_obj: rietveld.Rietveld object.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001491 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001492 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001493
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001494 Warning:
1495 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1496 SHOULD be sys.stdin.
1497
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001498 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001499 A PresubmitOutput object. Use output.should_continue() to figure out
1500 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001501 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001502 old_environ = os.environ
1503 try:
1504 # Make sure python subprocesses won't generate .pyc files.
1505 os.environ = os.environ.copy()
1506 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001507
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001508 output = PresubmitOutput(input_stream, output_stream)
1509 if committing:
1510 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001511 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001512 output.write("Running presubmit upload checks ...\n")
1513 start_time = time.time()
1514 presubmit_files = ListRelevantPresubmitFiles(
1515 change.AbsoluteLocalPaths(True), change.RepositoryRoot())
1516 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001517 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001518 results = []
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001519 executer = PresubmitExecuter(change, committing, rietveld_obj, verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001520 gerrit_obj, dry_run)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001521 if default_presubmit:
1522 if verbose:
1523 output.write("Running default presubmit script.\n")
1524 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1525 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1526 for filename in presubmit_files:
1527 filename = os.path.abspath(filename)
1528 if verbose:
1529 output.write("Running %s\n" % filename)
1530 # Accept CRLF presubmit script.
1531 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1532 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001533
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001534 errors = []
1535 notifications = []
1536 warnings = []
1537 for result in results:
1538 if result.fatal:
1539 errors.append(result)
1540 elif result.should_prompt:
1541 warnings.append(result)
1542 else:
1543 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001544
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001545 output.write('\n')
1546 for name, items in (('Messages', notifications),
1547 ('Warnings', warnings),
1548 ('ERRORS', errors)):
1549 if items:
1550 output.write('** Presubmit %s **\n' % name)
1551 for item in items:
1552 item.handle(output)
1553 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001554
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001555 total_time = time.time() - start_time
1556 if total_time > 1.0:
1557 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001558
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001559 if not errors:
1560 if not warnings:
1561 output.write('Presubmit checks passed.\n')
1562 elif may_prompt:
1563 output.prompt_yes_no('There were presubmit warnings. '
1564 'Are you sure you wish to continue? (y/N): ')
1565 else:
1566 output.fail()
1567
1568 global _ASKED_FOR_FEEDBACK
1569 # Ask for feedback one time out of 5.
1570 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001571 output.write(
1572 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1573 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1574 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001575 _ASKED_FOR_FEEDBACK = True
1576 return output
1577 finally:
1578 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001579
1580
1581def ScanSubDirs(mask, recursive):
1582 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001583 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001584 else:
1585 results = []
1586 for root, dirs, files in os.walk('.'):
1587 if '.svn' in dirs:
1588 dirs.remove('.svn')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001589 if '.git' in dirs:
1590 dirs.remove('.git')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001591 for name in files:
1592 if fnmatch.fnmatch(name, mask):
1593 results.append(os.path.join(root, name))
1594 return results
1595
1596
1597def ParseFiles(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001598 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001599 files = []
1600 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001601 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001602 return files
1603
1604
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001605def load_files(options, args):
1606 """Tries to determine the SCM."""
1607 change_scm = scm.determine_scm(options.root)
1608 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001609 if args:
1610 files = ParseFiles(args, options.recursive)
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001611 if change_scm == 'svn':
1612 change_class = SvnChange
1613 if not files:
1614 files = scm.SVN.CaptureStatus([], options.root)
1615 elif change_scm == 'git':
1616 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001617 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001618 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001619 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001620 else:
tobiasjs2836bcf2016-08-16 04:08:16 -07001621 logging.info('Doesn\'t seem under source control. Got %d files', len(args))
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001622 if not files:
1623 return None, None
1624 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001625 return change_class, files
1626
1627
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001628class NonexistantCannedCheckFilter(Exception):
1629 pass
1630
1631
1632@contextlib.contextmanager
1633def canned_check_filter(method_names):
1634 filtered = {}
1635 try:
1636 for method_name in method_names:
1637 if not hasattr(presubmit_canned_checks, method_name):
1638 raise NonexistantCannedCheckFilter(method_name)
1639 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1640 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1641 yield
1642 finally:
1643 for name, method in filtered.iteritems():
1644 setattr(presubmit_canned_checks, name, method)
1645
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001646
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001647def CallCommand(cmd_data):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001648 """Runs an external program, potentially from a child process created by the
1649 multiprocessing module.
1650
1651 multiprocessing needs a top level function with a single argument.
1652 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001653 cmd_data.kwargs['stdout'] = subprocess.PIPE
1654 cmd_data.kwargs['stderr'] = subprocess.STDOUT
1655 try:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001656 start = time.time()
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001657 (out, _), code = subprocess.communicate(cmd_data.cmd, **cmd_data.kwargs)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001658 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001659 except OSError as e:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001660 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001661 return cmd_data.message(
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001662 '%s exec failure (%4.2fs)\n %s' % (cmd_data.name, duration, e))
1663 if code != 0:
1664 return cmd_data.message(
1665 '%s (%4.2fs) failed\n%s' % (cmd_data.name, duration, out))
1666 if cmd_data.info:
1667 return cmd_data.info('%s (%4.2fs)' % (cmd_data.name, duration))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001668
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001669
sbc@chromium.org013731e2015-02-26 18:28:43 +00001670def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001671 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001672 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001673 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001674 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001675 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1676 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001677 parser.add_option("-r", "--recursive", action="store_true",
1678 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001679 parser.add_option("-v", "--verbose", action="count", default=0,
1680 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001681 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001682 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001683 parser.add_option("--description", default='')
1684 parser.add_option("--issue", type='int', default=0)
1685 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001686 parser.add_option("--root", default=os.getcwd(),
1687 help="Search for PRESUBMIT.py up to this directory. "
1688 "If inherit-review-settings-ok is present in this "
1689 "directory, parent directories up to the root file "
1690 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001691 parser.add_option("--upstream",
1692 help="Git only: the base ref or upstream branch against "
1693 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001694 parser.add_option("--default_presubmit")
1695 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001696 parser.add_option("--skip_canned", action='append', default=[],
1697 help="A list of checks to skip which appear in "
1698 "presubmit_canned_checks. Can be provided multiple times "
1699 "to skip multiple canned checks.")
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001700 parser.add_option("--dry_run", action='store_true',
1701 help=optparse.SUPPRESS_HELP)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001702 parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP)
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001703 parser.add_option("--gerrit_fetch", action='store_true',
1704 help=optparse.SUPPRESS_HELP)
maruel@chromium.org239f4112011-06-03 20:08:23 +00001705 parser.add_option("--rietveld_url", help=optparse.SUPPRESS_HELP)
1706 parser.add_option("--rietveld_email", help=optparse.SUPPRESS_HELP)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001707 parser.add_option("--rietveld_fetch", action='store_true', default=False,
1708 help=optparse.SUPPRESS_HELP)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001709 # These are for OAuth2 authentication for bots. See also apply_issue.py
1710 parser.add_option("--rietveld_email_file", help=optparse.SUPPRESS_HELP)
1711 parser.add_option("--rietveld_private_key_file", help=optparse.SUPPRESS_HELP)
1712
phajdan.jr@chromium.org2ff30182016-03-23 09:52:51 +00001713 # TODO(phajdan.jr): Update callers and remove obsolete --trybot-json .
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00001714 parser.add_option("--trybot-json",
1715 help="Output trybot information to the file specified.")
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001716 auth.add_auth_options(parser)
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001717 options, args = parser.parse_args(argv)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001718 auth_config = auth.extract_auth_config_from_options(options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001719
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001720 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001721 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001722 elif options.verbose:
1723 logging.basicConfig(level=logging.INFO)
1724 else:
1725 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001726
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001727 if (any((options.rietveld_url, options.rietveld_email_file,
1728 options.rietveld_fetch, options.rietveld_private_key_file))
1729 and any((options.gerrit_url, options.gerrit_fetch))):
1730 parser.error('Options for only codereview --rietveld_* or --gerrit_* '
1731 'allowed')
1732
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001733 if options.rietveld_email and options.rietveld_email_file:
1734 parser.error("Only one of --rietveld_email or --rietveld_email_file "
1735 "can be passed to this program.")
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001736 if options.rietveld_email_file:
1737 with open(options.rietveld_email_file, "rb") as f:
1738 options.rietveld_email = f.read().strip()
1739
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001740 change_class, files = load_files(options, args)
1741 if not change_class:
1742 parser.error('For unversioned directory, <files> is not optional.')
tobiasjs2836bcf2016-08-16 04:08:16 -07001743 logging.info('Found %d file(s).', len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001744
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001745 rietveld_obj, gerrit_obj = None, None
1746
maruel@chromium.org239f4112011-06-03 20:08:23 +00001747 if options.rietveld_url:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001748 # The empty password is permitted: '' is not None.
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001749 if options.rietveld_private_key_file:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001750 rietveld_obj = rietveld.JwtOAuth2Rietveld(
1751 options.rietveld_url,
1752 options.rietveld_email,
1753 options.rietveld_private_key_file)
1754 else:
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001755 rietveld_obj = rietveld.CachingRietveld(
1756 options.rietveld_url,
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001757 auth_config,
1758 options.rietveld_email)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001759 if options.rietveld_fetch:
1760 assert options.issue
1761 props = rietveld_obj.get_issue_properties(options.issue, False)
1762 options.author = props['owner_email']
1763 options.description = props['description']
1764 logging.info('Got author: "%s"', options.author)
1765 logging.info('Got description: """\n%s\n"""', options.description)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001766
1767 if options.gerrit_url and options.gerrit_fetch:
tandrii@chromium.org83b1b232016-04-29 16:33:19 +00001768 assert options.issue and options.patchset
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001769 rietveld_obj = None
1770 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1771 options.author = gerrit_obj.GetChangeOwner(options.issue)
1772 options.description = gerrit_obj.GetChangeDescription(options.issue,
1773 options.patchset)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001774 logging.info('Got author: "%s"', options.author)
1775 logging.info('Got description: """\n%s\n"""', options.description)
1776
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001777 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001778 with canned_check_filter(options.skip_canned):
1779 results = DoPresubmitChecks(
1780 change_class(options.name,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001781 options.description,
1782 options.root,
1783 files,
1784 options.issue,
1785 options.patchset,
1786 options.author,
1787 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001788 options.commit,
1789 options.verbose,
1790 sys.stdout,
1791 sys.stdin,
1792 options.default_presubmit,
1793 options.may_prompt,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001794 rietveld_obj,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001795 gerrit_obj,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001796 options.dry_run)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001797 return not results.should_continue()
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001798 except NonexistantCannedCheckFilter, e:
1799 print >> sys.stderr, (
1800 'Attempted to skip nonexistent canned presubmit check: %s' % e.message)
1801 return 2
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001802 except PresubmitFailure, e:
1803 print >> sys.stderr, e
1804 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
1805 print >> sys.stderr, 'If all fails, contact maruel@'
1806 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001807
1808
1809if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001810 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001811 try:
1812 sys.exit(main())
1813 except KeyboardInterrupt:
1814 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001815 sys.exit(2)