blob: 513b29f7cb9b532fda4082e616c7d5fc04c3d1b5 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
enne@chromium.orge72c5f52013-04-16 00:36:40 +000015import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000016import cPickle # Exposed through the API.
17import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000018import contextlib
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000019import fnmatch
20import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000021import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000022import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000023import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000024import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000025import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000026import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000027import optparse
28import os # Somewhat exposed through the API.
29import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000030import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000031import re # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
jam@chromium.org2a891dc2009-08-20 20:33:37 +000034import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000035import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000036import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000038import urllib2 # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000043import gclient_utils
dpranke@chromium.org2a009622011-03-01 02:43:31 +000044import owners
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000045import presubmit_canned_checks
maruel@chromium.org239f4112011-06-03 20:08:23 +000046import rietveld
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000047import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000048import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049
50
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000051# Ask for feedback only once in program lifetime.
52_ASKED_FOR_FEEDBACK = False
53
54
maruel@chromium.org899e1c12011-04-07 17:03:18 +000055class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000056 pass
57
58
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000059class CommandData(object):
60 def __init__(self, name, cmd, kwargs, message):
61 self.name = name
62 self.cmd = cmd
63 self.kwargs = kwargs
64 self.message = message
65 self.info = None
66
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000067
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000068def normpath(path):
69 '''Version of os.path.normpath that also changes backward slashes to
70 forward slashes when not running on Windows.
71 '''
72 # This is safe to always do because the Windows version of os.path.normpath
73 # will replace forward slashes with backward slashes.
74 path = path.replace(os.sep, '/')
75 return os.path.normpath(path)
76
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000077
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000078def _RightHandSideLinesImpl(affected_files):
79 """Implements RightHandSideLines for InputApi and GclChange."""
80 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000081 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000082 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000083 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000084
85
dpranke@chromium.org5ac21012011-03-16 02:58:25 +000086class PresubmitOutput(object):
87 def __init__(self, input_stream=None, output_stream=None):
88 self.input_stream = input_stream
89 self.output_stream = output_stream
90 self.reviewers = []
91 self.written_output = []
92 self.error_count = 0
93
94 def prompt_yes_no(self, prompt_string):
95 self.write(prompt_string)
96 if self.input_stream:
97 response = self.input_stream.readline().strip().lower()
98 if response not in ('y', 'yes'):
99 self.fail()
100 else:
101 self.fail()
102
103 def fail(self):
104 self.error_count += 1
105
106 def should_continue(self):
107 return not self.error_count
108
109 def write(self, s):
110 self.written_output.append(s)
111 if self.output_stream:
112 self.output_stream.write(s)
113
114 def getvalue(self):
115 return ''.join(self.written_output)
116
117
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000118# Top level object so multiprocessing can pickle
119# Public access through OutputApi object.
120class _PresubmitResult(object):
121 """Base class for result objects."""
122 fatal = False
123 should_prompt = False
124
125 def __init__(self, message, items=None, long_text=''):
126 """
127 message: A short one-line message to indicate errors.
128 items: A list of short strings to indicate where errors occurred.
129 long_text: multi-line text output, e.g. from another tool
130 """
131 self._message = message
132 self._items = items or []
133 if items:
134 self._items = items
135 self._long_text = long_text.rstrip()
136
137 def handle(self, output):
138 output.write(self._message)
139 output.write('\n')
140 for index, item in enumerate(self._items):
141 output.write(' ')
142 # Write separately in case it's unicode.
143 output.write(str(item))
144 if index < len(self._items) - 1:
145 output.write(' \\')
146 output.write('\n')
147 if self._long_text:
148 output.write('\n***************\n')
149 # Write separately in case it's unicode.
150 output.write(self._long_text)
151 output.write('\n***************\n')
152 if self.fatal:
153 output.fail()
154
155
156# Top level object so multiprocessing can pickle
157# Public access through OutputApi object.
158class _PresubmitAddReviewers(_PresubmitResult):
159 """Add some suggested reviewers to the change."""
160 def __init__(self, reviewers):
161 super(_PresubmitAddReviewers, self).__init__('')
162 self.reviewers = reviewers
163
164 def handle(self, output):
165 output.reviewers.extend(self.reviewers)
166
167
168# Top level object so multiprocessing can pickle
169# Public access through OutputApi object.
170class _PresubmitError(_PresubmitResult):
171 """A hard presubmit error."""
172 fatal = True
173
174
175# Top level object so multiprocessing can pickle
176# Public access through OutputApi object.
177class _PresubmitPromptWarning(_PresubmitResult):
178 """An warning that prompts the user if they want to continue."""
179 should_prompt = True
180
181
182# Top level object so multiprocessing can pickle
183# Public access through OutputApi object.
184class _PresubmitNotifyResult(_PresubmitResult):
185 """Just print something to the screen -- but it's not even a warning."""
186 pass
187
188
189# Top level object so multiprocessing can pickle
190# Public access through OutputApi object.
191class _MailTextResult(_PresubmitResult):
192 """A warning that should be included in the review request email."""
193 def __init__(self, *args, **kwargs):
194 super(_MailTextResult, self).__init__()
195 raise NotImplementedError()
196
197
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000198class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000199 """An instance of OutputApi gets passed to presubmit scripts so that they
200 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000201 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000202 PresubmitResult = _PresubmitResult
203 PresubmitAddReviewers = _PresubmitAddReviewers
204 PresubmitError = _PresubmitError
205 PresubmitPromptWarning = _PresubmitPromptWarning
206 PresubmitNotifyResult = _PresubmitNotifyResult
207 MailTextResult = _MailTextResult
208
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000209 def __init__(self, is_committing):
210 self.is_committing = is_committing
211
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000212 def PresubmitPromptOrNotify(self, *args, **kwargs):
213 """Warn the user when uploading, but only notify if committing."""
214 if self.is_committing:
215 return self.PresubmitNotifyResult(*args, **kwargs)
216 return self.PresubmitPromptWarning(*args, **kwargs)
217
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000218
219class InputApi(object):
220 """An instance of this object is passed to presubmit scripts so they can
221 know stuff about the change they're looking at.
222 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000223 # Method could be a function
224 # pylint: disable=R0201
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000225
maruel@chromium.org3410d912009-06-09 20:56:16 +0000226 # File extensions that are considered source files from a style guide
227 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000228 #
229 # Files without an extension aren't included in the list. If you want to
230 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
231 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000232 DEFAULT_WHITE_LIST = (
233 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000234 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
235 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000236 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000237 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000238 # Other
estade@chromium.orgae7af922012-01-27 14:51:13 +0000239 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000240 )
241
242 # Path regexp that should be excluded from being considered containing source
243 # files. Don't modify this list from a presubmit script!
244 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000245 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000246 r".*\bexperimental[\\\/].*",
247 r".*\bthird_party[\\\/].*",
248 # Output directories (just in case)
249 r".*\bDebug[\\\/].*",
250 r".*\bRelease[\\\/].*",
251 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000252 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000253 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000254 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000255 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000256 r"(|.*[\\\/])\.git[\\\/].*",
257 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000258 # There is no point in processing a patch file.
259 r".+\.diff$",
260 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000261 )
262
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000263 def __init__(self, change, presubmit_path, is_committing,
maruel@chromium.org239f4112011-06-03 20:08:23 +0000264 rietveld_obj, verbose):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000265 """Builds an InputApi object.
266
267 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000268 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000269 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000270 is_committing: True if the change is about to be committed.
maruel@chromium.org239f4112011-06-03 20:08:23 +0000271 rietveld_obj: rietveld.Rietveld client object
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000272 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000273 # Version number of the presubmit_support script.
274 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000275 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000276 self.is_committing = is_committing
maruel@chromium.org239f4112011-06-03 20:08:23 +0000277 self.rietveld = rietveld_obj
maruel@chromium.orgcab38e92011-04-09 00:30:51 +0000278 # TBD
279 self.host_url = 'http://codereview.chromium.org'
280 if self.rietveld:
maruel@chromium.org239f4112011-06-03 20:08:23 +0000281 self.host_url = self.rietveld.url
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000282
283 # We expose various modules and functions as attributes of the input_api
284 # so that presubmit scripts don't have to import them.
285 self.basename = os.path.basename
286 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000287 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000288 self.cStringIO = cStringIO
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000289 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000290 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000291 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000292 self.os_listdir = os.listdir
293 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000294 self.os_path = os.path
295 self.pickle = pickle
296 self.marshal = marshal
297 self.re = re
298 self.subprocess = subprocess
299 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000300 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000301 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000302 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000303 self.urllib2 = urllib2
304
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000305 # To easily fork python.
306 self.python_executable = sys.executable
307 self.environ = os.environ
308
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000309 # InputApi.platform is the platform you're currently running on.
310 self.platform = sys.platform
311
312 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000313 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000314
315 # We carry the canned checks so presubmit scripts can easily use them.
316 self.canned_checks = presubmit_canned_checks
317
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000318 # TODO(dpranke): figure out a list of all approved owners for a repo
319 # in order to be able to handle wildcard OWNERS files?
320 self.owners_db = owners.Database(change.RepositoryRoot(),
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000321 fopen=file, os_path=self.os_path, glob=self.glob)
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000322 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000323 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000324
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000325 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000326 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000327 # Access to a protected member _XX of a client class
328 # pylint: disable=W0212
329 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000330 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000331 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
332 for (a, b, header) in cpplint._re_pattern_templates
333 ]
334
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000335 def PresubmitLocalPath(self):
336 """Returns the local path of the presubmit script currently being run.
337
338 This is useful if you don't want to hard-code absolute paths in the
339 presubmit script. For example, It can be used to find another file
340 relative to the PRESUBMIT.py script, so the whole tree can be branched and
341 the presubmit script still works, without editing its content.
342 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000343 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000344
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000345 def DepotToLocalPath(self, depot_path):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000346 """Translate a depot path to a local path (relative to client root).
347
348 Args:
349 Depot path as a string.
350
351 Returns:
352 The local path of the depot path under the user's current client, or None
353 if the file is not mapped.
354
355 Remember to check for the None case and show an appropriate error!
356 """
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000357 return scm.SVN.CaptureLocalInfo([depot_path], self.change.RepositoryRoot()
358 ).get('Path')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000359
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000360 def LocalToDepotPath(self, local_path):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000361 """Translate a local path to a depot path.
362
363 Args:
364 Local path (relative to current directory, or absolute) as a string.
365
366 Returns:
367 The depot path (SVN URL) of the file if mapped, otherwise None.
368 """
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000369 return scm.SVN.CaptureLocalInfo([local_path], self.change.RepositoryRoot()
370 ).get('URL')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000371
sail@chromium.org5538e022011-05-12 17:53:16 +0000372 def AffectedFiles(self, include_dirs=False, include_deletes=True,
373 file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000374 """Same as input_api.change.AffectedFiles() except only lists files
375 (and optionally directories) in the same directory as the current presubmit
376 script, or subdirectories thereof.
377 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000378 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000379 if len(dir_with_slash) == 1:
380 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000381
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000382 return filter(
383 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
sail@chromium.org5538e022011-05-12 17:53:16 +0000384 self.change.AffectedFiles(include_dirs, include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000385
386 def LocalPaths(self, include_dirs=False):
387 """Returns local paths of input_api.AffectedFiles()."""
388 return [af.LocalPath() for af in self.AffectedFiles(include_dirs)]
389
390 def AbsoluteLocalPaths(self, include_dirs=False):
391 """Returns absolute local paths of input_api.AffectedFiles()."""
392 return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)]
393
394 def ServerPaths(self, include_dirs=False):
395 """Returns server paths of input_api.AffectedFiles()."""
396 return [af.ServerPath() for af in self.AffectedFiles(include_dirs)]
397
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000398 def AffectedTextFiles(self, include_deletes=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000399 """Same as input_api.change.AffectedTextFiles() except only lists files
400 in the same directory as the current presubmit script, or subdirectories
401 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000402 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000403 if include_deletes is not None:
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000404 warn("AffectedTextFiles(include_deletes=%s)"
405 " is deprecated and ignored" % str(include_deletes),
406 category=DeprecationWarning,
407 stacklevel=2)
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000408 return filter(lambda x: x.IsTextFile(),
409 self.AffectedFiles(include_dirs=False, include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000410
maruel@chromium.org3410d912009-06-09 20:56:16 +0000411 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
412 """Filters out files that aren't considered "source file".
413
414 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
415 and InputApi.DEFAULT_BLACK_LIST is used respectively.
416
417 The lists will be compiled as regular expression and
418 AffectedFile.LocalPath() needs to pass both list.
419
420 Note: Copy-paste this function to suit your needs or use a lambda function.
421 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000422 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000423 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000424 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000425 if self.re.match(item, local_path):
426 logging.debug("%s matched %s" % (item, local_path))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000427 return True
428 return False
429 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
430 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
431
432 def AffectedSourceFiles(self, source_file):
433 """Filter the list of AffectedTextFiles by the function source_file.
434
435 If source_file is None, InputApi.FilterSourceFile() is used.
436 """
437 if not source_file:
438 source_file = self.FilterSourceFile
439 return filter(source_file, self.AffectedTextFiles())
440
441 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000442 """An iterator over all text lines in "new" version of changed files.
443
444 Only lists lines from new or modified text files in the change that are
445 contained by the directory of the currently executing presubmit script.
446
447 This is useful for doing line-by-line regex checks, like checking for
448 trailing whitespace.
449
450 Yields:
451 a 3 tuple:
452 the AffectedFile instance of the current file;
453 integer line number (1-based); and
454 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000455
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000456 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000457 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000458 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000459 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000460
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000461 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000462 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000463
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000464 Deny reading anything outside the repository.
465 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000466 if isinstance(file_item, AffectedFile):
467 file_item = file_item.AbsoluteLocalPath()
468 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000469 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000470 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000471
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000472 @property
473 def tbr(self):
474 """Returns if a change is TBR'ed."""
475 return 'TBR' in self.change.tags
476
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000477 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000478 tests = []
479 msgs = []
480 for t in tests_mix:
481 if isinstance(t, OutputApi.PresubmitResult):
482 msgs.append(t)
483 else:
484 assert issubclass(t.message, _PresubmitResult)
485 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000486 if self.verbose:
487 t.info = _PresubmitNotifyResult
ilevy@chromium.org5678d332013-05-18 01:34:14 +0000488 if len(tests) > 1 and parallel:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000489 pool = multiprocessing.Pool()
490 # async recipe works around multiprocessing bug handling Ctrl-C
491 msgs.extend(pool.map_async(CallCommand, tests).get(99999))
492 pool.close()
493 pool.join()
494 else:
495 msgs.extend(map(CallCommand, tests))
496 return [m for m in msgs if m]
497
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000498
nick@chromium.orgff526192013-06-10 19:30:26 +0000499class _DiffCache(object):
500 """Caches diffs retrieved from a particular SCM."""
501
502 def GetDiff(self, path, local_root):
503 """Get the diff for a particular path."""
504 raise NotImplementedError()
505
506
507class _SvnDiffCache(_DiffCache):
508 """DiffCache implementation for subversion."""
509 def __init__(self):
510 super(_SvnDiffCache, self).__init__()
511 self._diffs_by_file = {}
512
513 def GetDiff(self, path, local_root):
514 if path not in self._diffs_by_file:
515 self._diffs_by_file[path] = scm.SVN.GenerateDiff([path], local_root,
516 False, None)
517 return self._diffs_by_file[path]
518
519
520class _GitDiffCache(_DiffCache):
521 """DiffCache implementation for git; gets all file diffs at once."""
522 def __init__(self):
523 super(_GitDiffCache, self).__init__()
524 self._diffs_by_file = None
525
526 def GetDiff(self, path, local_root):
527 if not self._diffs_by_file:
528 # Compute a single diff for all files and parse the output; should
529 # with git this is much faster than computing one diff for each file.
530 diffs = {}
531
532 # Don't specify any filenames below, because there are command line length
533 # limits on some platforms and GenerateDiff would fail.
534 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True)
535
536 # This regex matches the path twice, separated by a space. Note that
537 # filename itself may contain spaces.
538 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
539 current_diff = []
540 keep_line_endings = True
541 for x in unified_diff.splitlines(keep_line_endings):
542 match = file_marker.match(x)
543 if match:
544 # Marks the start of a new per-file section.
545 diffs[match.group('filename')] = current_diff = [x]
546 elif x.startswith('diff --git'):
547 raise PresubmitFailure('Unexpected diff line: %s' % x)
548 else:
549 current_diff.append(x)
550
551 self._diffs_by_file = dict(
552 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
553
554 if path not in self._diffs_by_file:
555 raise PresubmitFailure(
556 'Unified diff did not contain entry for file %s' % path)
557
558 return self._diffs_by_file[path]
559
560
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000561class AffectedFile(object):
562 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000563
564 DIFF_CACHE = _DiffCache
565
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000566 # Method could be a function
567 # pylint: disable=R0201
nick@chromium.orgff526192013-06-10 19:30:26 +0000568 def __init__(self, path, action, repository_root, diff_cache=None):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000569 self._path = path
570 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000571 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000572 self._is_directory = None
573 self._properties = {}
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000574 self._cached_changed_contents = None
575 self._cached_new_contents = None
nick@chromium.orgff526192013-06-10 19:30:26 +0000576 if diff_cache:
577 self._diff_cache = diff_cache
578 else:
579 self._diff_cache = self.DIFF_CACHE()
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000580 logging.debug('%s(%s)' % (self.__class__.__name__, self._path))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000581
582 def ServerPath(self):
583 """Returns a path string that identifies the file in the SCM system.
584
585 Returns the empty string if the file does not exist in SCM.
586 """
nick@chromium.orgff526192013-06-10 19:30:26 +0000587 return ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000588
589 def LocalPath(self):
590 """Returns the path of this file on the local disk relative to client root.
591 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000592 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000593
594 def AbsoluteLocalPath(self):
595 """Returns the absolute path of this file on the local disk.
596 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000597 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000598
599 def IsDirectory(self):
600 """Returns true if this object is a directory."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000601 if self._is_directory is None:
602 path = self.AbsoluteLocalPath()
603 self._is_directory = (os.path.exists(path) and
604 os.path.isdir(path))
605 return self._is_directory
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000606
607 def Action(self):
608 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000609 # TODO(maruel): Somewhat crappy, Could be "A" or "A +" for svn but
610 # different for other SCM.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000611 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000612
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000613 def Property(self, property_name):
614 """Returns the specified SCM property of this file, or None if no such
615 property.
616 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000617 return self._properties.get(property_name, None)
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000618
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000619 def IsTextFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000620 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000621
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000622 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000623 raise NotImplementedError() # Implement when needed
624
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000625 def NewContents(self):
626 """Returns an iterator over the lines in the new version of file.
627
628 The new version is the file in the user's workspace, i.e. the "right hand
629 side".
630
631 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000632 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000633 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000634 if self._cached_new_contents is None:
635 self._cached_new_contents = []
636 if not self.IsDirectory():
637 try:
638 self._cached_new_contents = gclient_utils.FileRead(
639 self.AbsoluteLocalPath(), 'rU').splitlines()
640 except IOError:
641 pass # File not found? That's fine; maybe it was deleted.
642 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000643
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000644 def ChangedContents(self):
645 """Returns a list of tuples (line number, line text) of all new lines.
646
647 This relies on the scm diff output describing each changed code section
648 with a line of the form
649
650 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
651 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000652 if self._cached_changed_contents is not None:
653 return self._cached_changed_contents[:]
654 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000655 line_num = 0
656
657 if self.IsDirectory():
658 return []
659
660 for line in self.GenerateScmDiff().splitlines():
661 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
662 if m:
663 line_num = int(m.groups(1)[0])
664 continue
665 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000666 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000667 if not line.startswith('-'):
668 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000669 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000670
maruel@chromium.org5de13972009-06-10 18:16:06 +0000671 def __str__(self):
672 return self.LocalPath()
673
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000674 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000675 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000676
maruel@chromium.org58407af2011-04-12 23:15:57 +0000677
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000678class SvnAffectedFile(AffectedFile):
679 """Representation of a file in a change out of a Subversion checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000680 # Method 'NNN' is abstract in class 'NNN' but is not overridden
681 # pylint: disable=W0223
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000682
nick@chromium.orgff526192013-06-10 19:30:26 +0000683 DIFF_CACHE = _SvnDiffCache
684
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000685 def __init__(self, *args, **kwargs):
686 AffectedFile.__init__(self, *args, **kwargs)
687 self._server_path = None
688 self._is_text_file = None
689
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000690 def ServerPath(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000691 if self._server_path is None:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000692 self._server_path = scm.SVN.CaptureLocalInfo(
693 [self.LocalPath()], self._local_root).get('URL', '')
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000694 return self._server_path
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000695
696 def IsDirectory(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000697 if self._is_directory is None:
698 path = self.AbsoluteLocalPath()
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000699 if os.path.exists(path):
700 # Retrieve directly from the file system; it is much faster than
701 # querying subversion, especially on Windows.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000702 self._is_directory = os.path.isdir(path)
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000703 else:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000704 self._is_directory = scm.SVN.CaptureLocalInfo(
705 [self.LocalPath()], self._local_root
706 ).get('Node Kind') in ('dir', 'directory')
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000707 return self._is_directory
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000708
709 def Property(self, property_name):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000710 if not property_name in self._properties:
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000711 self._properties[property_name] = scm.SVN.GetFileProperty(
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000712 self.LocalPath(), property_name, self._local_root).rstrip()
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000713 return self._properties[property_name]
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000714
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000715 def IsTextFile(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000716 if self._is_text_file is None:
717 if self.Action() == 'D':
718 # A deleted file is not a text file.
719 self._is_text_file = False
720 elif self.IsDirectory():
721 self._is_text_file = False
722 else:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000723 mime_type = scm.SVN.GetFileProperty(
724 self.LocalPath(), 'svn:mime-type', self._local_root)
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000725 self._is_text_file = (not mime_type or mime_type.startswith('text/'))
726 return self._is_text_file
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000727
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000728
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000729class GitAffectedFile(AffectedFile):
730 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000731 # Method 'NNN' is abstract in class 'NNN' but is not overridden
732 # pylint: disable=W0223
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000733
nick@chromium.orgff526192013-06-10 19:30:26 +0000734 DIFF_CACHE = _GitDiffCache
735
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000736 def __init__(self, *args, **kwargs):
737 AffectedFile.__init__(self, *args, **kwargs)
738 self._server_path = None
739 self._is_text_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000740
741 def ServerPath(self):
742 if self._server_path is None:
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000743 raise NotImplementedError('TODO(maruel) Implement.')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000744 return self._server_path
745
746 def IsDirectory(self):
747 if self._is_directory is None:
748 path = self.AbsoluteLocalPath()
749 if os.path.exists(path):
750 # Retrieve directly from the file system; it is much faster than
751 # querying subversion, especially on Windows.
752 self._is_directory = os.path.isdir(path)
753 else:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000754 self._is_directory = False
755 return self._is_directory
756
757 def Property(self, property_name):
758 if not property_name in self._properties:
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000759 raise NotImplementedError('TODO(maruel) Implement.')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000760 return self._properties[property_name]
761
762 def IsTextFile(self):
763 if self._is_text_file is None:
764 if self.Action() == 'D':
765 # A deleted file is not a text file.
766 self._is_text_file = False
767 elif self.IsDirectory():
768 self._is_text_file = False
769 else:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000770 self._is_text_file = os.path.isfile(self.AbsoluteLocalPath())
771 return self._is_text_file
772
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000773
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000774class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000775 """Describe a change.
776
777 Used directly by the presubmit scripts to query the current change being
778 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000779
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000780 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000781 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000782 self.KEY: equivalent to tags['KEY']
783 """
784
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000785 _AFFECTED_FILES = AffectedFile
786
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000787 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000788 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000789 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000790 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000791
maruel@chromium.org58407af2011-04-12 23:15:57 +0000792 def __init__(
793 self, name, description, local_root, files, issue, patchset, author):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000794 if files is None:
795 files = []
796 self._name = name
797 self._full_description = description
chase@chromium.org8e416c82009-10-06 04:30:44 +0000798 # Convert root into an absolute path.
799 self._local_root = os.path.abspath(local_root)
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000800 self.issue = issue
801 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +0000802 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000803
804 # From the description text, build up a dictionary of key/value pairs
805 # plus the description minus all key/value or "tag" lines.
maruel@chromium.orgfa410372010-09-10 17:01:01 +0000806 description_without_tags = []
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000807 self.tags = {}
maruel@chromium.org8d5c9a52009-06-12 15:59:08 +0000808 for line in self._full_description.splitlines():
maruel@chromium.org428342a2011-11-10 15:46:33 +0000809 m = self.TAG_LINE_RE.match(line)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000810 if m:
811 self.tags[m.group('key')] = m.group('value')
812 else:
maruel@chromium.orgfa410372010-09-10 17:01:01 +0000813 description_without_tags.append(line)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000814
815 # Change back to text and remove whitespace at end.
maruel@chromium.orgfa410372010-09-10 17:01:01 +0000816 self._description_without_tags = (
817 '\n'.join(description_without_tags).rstrip())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000818
maruel@chromium.orge085d812011-10-10 19:49:15 +0000819 assert all(
820 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
821
nick@chromium.orgff526192013-06-10 19:30:26 +0000822 diff_cache = self._AFFECTED_FILES.DIFF_CACHE()
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000823 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +0000824 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
825 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000826 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000827
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000828 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000829 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000830 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000831
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000832 def DescriptionText(self):
833 """Returns the user-entered changelist description, minus tags.
834
835 Any line in the user-provided description starting with e.g. "FOO="
836 (whitespace permitted before and around) is considered a tag line. Such
837 lines are stripped out of the description this function returns.
838 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000839 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000840
841 def FullDescriptionText(self):
842 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000843 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000844
845 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000846 """Returns the repository (checkout) root directory for this change,
847 as an absolute path.
848 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000849 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000850
851 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000852 """Return tags directly as attributes on the object."""
853 if not re.match(r"^[A-Z_]*$", attr):
854 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +0000855 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000856
sail@chromium.org5538e022011-05-12 17:53:16 +0000857 def AffectedFiles(self, include_dirs=False, include_deletes=True,
858 file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000859 """Returns a list of AffectedFile instances for all files in the change.
860
861 Args:
862 include_deletes: If false, deleted files will be filtered out.
863 include_dirs: True to include directories in the list
sail@chromium.org5538e022011-05-12 17:53:16 +0000864 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000865
866 Returns:
867 [AffectedFile(path, action), AffectedFile(path, action)]
868 """
869 if include_dirs:
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000870 affected = self._affected_files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000871 else:
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000872 affected = filter(lambda x: not x.IsDirectory(), self._affected_files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000873
sail@chromium.org5538e022011-05-12 17:53:16 +0000874 affected = filter(file_filter, affected)
875
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000876 if include_deletes:
877 return affected
878 else:
879 return filter(lambda x: x.Action() != 'D', affected)
880
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000881 def AffectedTextFiles(self, include_deletes=None):
882 """Return a list of the existing text files in a change."""
883 if include_deletes is not None:
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000884 warn("AffectedTextFiles(include_deletes=%s)"
885 " is deprecated and ignored" % str(include_deletes),
886 category=DeprecationWarning,
887 stacklevel=2)
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000888 return filter(lambda x: x.IsTextFile(),
889 self.AffectedFiles(include_dirs=False, include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000890
891 def LocalPaths(self, include_dirs=False):
892 """Convenience function."""
893 return [af.LocalPath() for af in self.AffectedFiles(include_dirs)]
894
895 def AbsoluteLocalPaths(self, include_dirs=False):
896 """Convenience function."""
897 return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)]
898
899 def ServerPaths(self, include_dirs=False):
900 """Convenience function."""
901 return [af.ServerPath() for af in self.AffectedFiles(include_dirs)]
902
903 def RightHandSideLines(self):
904 """An iterator over all text lines in "new" version of changed files.
905
906 Lists lines from new or modified text files in the change.
907
908 This is useful for doing line-by-line regex checks, like checking for
909 trailing whitespace.
910
911 Yields:
912 a 3 tuple:
913 the AffectedFile instance of the current file;
914 integer line number (1-based); and
915 the contents of the line as a string.
916 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000917 return _RightHandSideLinesImpl(
918 x for x in self.AffectedFiles(include_deletes=False)
919 if x.IsTextFile())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000920
921
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000922class SvnChange(Change):
923 _AFFECTED_FILES = SvnAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000924 scm = 'svn'
925 _changelists = None
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000926
927 def _GetChangeLists(self):
928 """Get all change lists."""
929 if self._changelists == None:
930 previous_cwd = os.getcwd()
931 os.chdir(self.RepositoryRoot())
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000932 # Need to import here to avoid circular dependency.
933 import gcl
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000934 self._changelists = gcl.GetModifiedFiles()
935 os.chdir(previous_cwd)
936 return self._changelists
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000937
938 def GetAllModifiedFiles(self):
939 """Get all modified files."""
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000940 changelists = self._GetChangeLists()
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000941 all_modified_files = []
942 for cl in changelists.values():
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000943 all_modified_files.extend(
944 [os.path.join(self.RepositoryRoot(), f[1]) for f in cl])
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000945 return all_modified_files
946
947 def GetModifiedFiles(self):
948 """Get modified files in the current CL."""
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000949 changelists = self._GetChangeLists()
950 return [os.path.join(self.RepositoryRoot(), f[1])
951 for f in changelists[self.Name()]]
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000952
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000953
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000954class GitChange(Change):
955 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000956 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000957
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000958
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000959def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000960 """Finds all presubmit files that apply to a given set of source files.
961
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000962 If inherit-review-settings-ok is present right under root, looks for
963 PRESUBMIT.py in directories enclosing root.
964
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000965 Args:
966 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000967 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000968
969 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000970 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000971 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000972 files = [normpath(os.path.join(root, f)) for f in files]
973
974 # List all the individual directories containing files.
975 directories = set([os.path.dirname(f) for f in files])
976
977 # Ignore root if inherit-review-settings-ok is present.
978 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
979 root = None
980
981 # Collect all unique directories that may contain PRESUBMIT.py.
982 candidates = set()
983 for directory in directories:
984 while True:
985 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000986 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000987 candidates.add(directory)
988 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000989 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000990 parent_dir = os.path.dirname(directory)
991 if parent_dir == directory:
992 # We hit the system root directory.
993 break
994 directory = parent_dir
995
996 # Look for PRESUBMIT.py in all candidate directories.
997 results = []
998 for directory in sorted(list(candidates)):
999 p = os.path.join(directory, 'PRESUBMIT.py')
1000 if os.path.isfile(p):
1001 results.append(p)
1002
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001003 logging.debug('Presubmit files: %s' % ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001004 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001005
1006
thestig@chromium.orgde243452009-10-06 21:02:56 +00001007class GetTrySlavesExecuter(object):
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001008 @staticmethod
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001009 def ExecPresubmitScript(script_text, presubmit_path, project, change):
thestig@chromium.orgde243452009-10-06 21:02:56 +00001010 """Executes GetPreferredTrySlaves() from a single presubmit script.
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001011
1012 This will soon be deprecated and replaced by GetPreferredTryMasters().
thestig@chromium.orgde243452009-10-06 21:02:56 +00001013
1014 Args:
1015 script_text: The text of the presubmit script.
bradnelson@google.com78230022011-05-24 18:55:19 +00001016 presubmit_path: Project script to run.
1017 project: Project name to pass to presubmit script for bot selection.
thestig@chromium.orgde243452009-10-06 21:02:56 +00001018
1019 Return:
1020 A list of try slaves.
1021 """
1022 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001023 try:
1024 exec script_text in context
1025 except Exception, e:
1026 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001027
1028 function_name = 'GetPreferredTrySlaves'
1029 if function_name in context:
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001030 get_preferred_try_slaves = context[function_name]
1031 function_info = inspect.getargspec(get_preferred_try_slaves)
1032 if len(function_info[0]) == 1:
1033 result = get_preferred_try_slaves(project)
1034 elif len(function_info[0]) == 2:
1035 result = get_preferred_try_slaves(project, change)
1036 else:
1037 result = get_preferred_try_slaves()
thestig@chromium.orgde243452009-10-06 21:02:56 +00001038 if not isinstance(result, types.ListType):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001039 raise PresubmitFailure(
thestig@chromium.orgde243452009-10-06 21:02:56 +00001040 'Presubmit functions must return a list, got a %s instead: %s' %
1041 (type(result), str(result)))
1042 for item in result:
stip@chromium.org68e04192013-11-04 22:14:38 +00001043 if isinstance(item, basestring):
1044 # Old-style ['bot'] format.
1045 botname = item
1046 elif isinstance(item, tuple):
1047 # New-style [('bot', set(['tests']))] format.
1048 botname = item[0]
1049 else:
1050 raise PresubmitFailure('PRESUBMIT.py returned invalid tryslave/test'
1051 ' format.')
1052
1053 if botname != botname.strip():
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001054 raise PresubmitFailure(
1055 'Try slave names cannot start/end with whitespace')
stip@chromium.org68e04192013-11-04 22:14:38 +00001056 if ',' in botname:
maruel@chromium.org3ecc8ea2012-03-10 01:47:46 +00001057 raise PresubmitFailure(
stip@chromium.org68e04192013-11-04 22:14:38 +00001058 'Do not use \',\' separated builder or test names: %s' % botname)
thestig@chromium.orgde243452009-10-06 21:02:56 +00001059 else:
1060 result = []
stip@chromium.org5ca27622013-12-18 17:44:58 +00001061
1062 def valid_oldstyle(result):
1063 return all(isinstance(i, basestring) for i in result)
1064
1065 def valid_newstyle(result):
1066 return (all(isinstance(i, tuple) for i in result) and
1067 all(len(i) == 2 for i in result) and
1068 all(isinstance(i[0], basestring) for i in result) and
1069 all(isinstance(i[1], set) for i in result)
1070 )
1071
1072 # Ensure it's either all old-style or all new-style.
1073 if not valid_oldstyle(result) and not valid_newstyle(result):
1074 raise PresubmitFailure(
1075 'PRESUBMIT.py returned invalid trybot specification!')
1076
thestig@chromium.orgde243452009-10-06 21:02:56 +00001077 return result
1078
1079
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001080class GetTryMastersExecuter(object):
1081 @staticmethod
1082 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1083 """Executes GetPreferredTryMasters() from a single presubmit script.
1084
1085 Args:
1086 script_text: The text of the presubmit script.
1087 presubmit_path: Project script to run.
1088 project: Project name to pass to presubmit script for bot selection.
1089
1090 Return:
1091 A map of try masters to map of builders to set of tests.
1092 """
1093 context = {}
1094 try:
1095 exec script_text in context
1096 except Exception, e:
1097 raise PresubmitFailure('"%s" had an exception.\n%s'
1098 % (presubmit_path, e))
1099
1100 function_name = 'GetPreferredTryMasters'
1101 if function_name not in context:
1102 return {}
1103 get_preferred_try_masters = context[function_name]
1104 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1105 raise PresubmitFailure(
1106 'Expected function "GetPreferredTryMasters" to take two arguments.')
1107 return get_preferred_try_masters(project, change)
1108
1109
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001110def DoGetTrySlaves(change,
1111 changed_files,
thestig@chromium.orgde243452009-10-06 21:02:56 +00001112 repository_root,
1113 default_presubmit,
bradnelson@google.com78230022011-05-24 18:55:19 +00001114 project,
thestig@chromium.orgde243452009-10-06 21:02:56 +00001115 verbose,
1116 output_stream):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001117 """Get the list of try servers from the presubmit scripts (deprecated).
thestig@chromium.orgde243452009-10-06 21:02:56 +00001118
1119 Args:
1120 changed_files: List of modified files.
1121 repository_root: The repository root.
1122 default_presubmit: A default presubmit script to execute in any case.
bradnelson@google.com78230022011-05-24 18:55:19 +00001123 project: Optional name of a project used in selecting trybots.
thestig@chromium.orgde243452009-10-06 21:02:56 +00001124 verbose: Prints debug info.
1125 output_stream: A stream to write debug output to.
1126
1127 Return:
1128 List of try slaves
1129 """
1130 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1131 if not presubmit_files and verbose:
1132 output_stream.write("Warning, no presubmit.py found.\n")
1133 results = []
1134 executer = GetTrySlavesExecuter()
stip@chromium.org5ca27622013-12-18 17:44:58 +00001135
thestig@chromium.orgde243452009-10-06 21:02:56 +00001136 if default_presubmit:
1137 if verbose:
1138 output_stream.write("Running default presubmit script.\n")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001139 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
stip@chromium.org5ca27622013-12-18 17:44:58 +00001140 results.extend(executer.ExecPresubmitScript(
1141 default_presubmit, fake_path, project, change))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001142 for filename in presubmit_files:
1143 filename = os.path.abspath(filename)
1144 if verbose:
1145 output_stream.write("Running %s\n" % filename)
1146 # Accept CRLF presubmit script.
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +00001147 presubmit_script = gclient_utils.FileRead(filename, 'rU')
stip@chromium.org5ca27622013-12-18 17:44:58 +00001148 results.extend(executer.ExecPresubmitScript(
1149 presubmit_script, filename, project, change))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001150
stip@chromium.org5ca27622013-12-18 17:44:58 +00001151
1152 slave_dict = {}
1153 old_style = filter(lambda x: isinstance(x, basestring), results)
1154 new_style = filter(lambda x: isinstance(x, tuple), results)
1155
1156 for result in new_style:
1157 slave_dict.setdefault(result[0], set()).update(result[1])
1158 slaves = list(slave_dict.items())
1159
1160 slaves.extend(set(old_style))
stip@chromium.org68e04192013-11-04 22:14:38 +00001161
thestig@chromium.orgde243452009-10-06 21:02:56 +00001162 if slaves and verbose:
stip@chromium.org5ca27622013-12-18 17:44:58 +00001163 output_stream.write(', '.join((str(x) for x in slaves)))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001164 output_stream.write('\n')
1165 return slaves
1166
1167
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001168def _MergeMasters(masters1, masters2):
1169 """Merges two master maps. Merges also the tests of each builder."""
1170 result = {}
1171 for (master, builders) in itertools.chain(masters1.iteritems(),
1172 masters2.iteritems()):
1173 new_builders = result.setdefault(master, {})
1174 for (builder, tests) in builders.iteritems():
1175 new_builders.setdefault(builder, set([])).update(tests)
1176 return result
1177
1178
1179def DoGetTryMasters(change,
1180 changed_files,
1181 repository_root,
1182 default_presubmit,
1183 project,
1184 verbose,
1185 output_stream):
1186 """Get the list of try masters from the presubmit scripts.
1187
1188 Args:
1189 changed_files: List of modified files.
1190 repository_root: The repository root.
1191 default_presubmit: A default presubmit script to execute in any case.
1192 project: Optional name of a project used in selecting trybots.
1193 verbose: Prints debug info.
1194 output_stream: A stream to write debug output to.
1195
1196 Return:
1197 Map of try masters to map of builders to set of tests.
1198 """
1199 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1200 if not presubmit_files and verbose:
1201 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1202 results = {}
1203 executer = GetTryMastersExecuter()
1204
1205 if default_presubmit:
1206 if verbose:
1207 output_stream.write("Running default presubmit script.\n")
1208 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1209 results = _MergeMasters(results, executer.ExecPresubmitScript(
1210 default_presubmit, fake_path, project, change))
1211 for filename in presubmit_files:
1212 filename = os.path.abspath(filename)
1213 if verbose:
1214 output_stream.write("Running %s\n" % filename)
1215 # Accept CRLF presubmit script.
1216 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1217 results = _MergeMasters(results, executer.ExecPresubmitScript(
1218 presubmit_script, filename, project, change))
1219
1220 # Make sets to lists again for later JSON serialization.
1221 for builders in results.itervalues():
1222 for builder in builders:
1223 builders[builder] = list(builders[builder])
1224
1225 if results and verbose:
1226 output_stream.write('%s\n' % str(results))
1227 return results
1228
1229
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001230class PresubmitExecuter(object):
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001231 def __init__(self, change, committing, rietveld_obj, verbose):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001232 """
1233 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001234 change: The Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001235 committing: True if 'gcl commit' is running, False if 'gcl upload' is.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001236 rietveld_obj: rietveld.Rietveld client object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001237 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001238 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001239 self.committing = committing
maruel@chromium.org239f4112011-06-03 20:08:23 +00001240 self.rietveld = rietveld_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001241 self.verbose = verbose
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001242
1243 def ExecPresubmitScript(self, script_text, presubmit_path):
1244 """Executes a single presubmit script.
1245
1246 Args:
1247 script_text: The text of the presubmit script.
1248 presubmit_path: The path to the presubmit file (this will be reported via
1249 input_api.PresubmitLocalPath()).
1250
1251 Return:
1252 A list of result objects, empty if no problems.
1253 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001254
1255 # Change to the presubmit file's directory to support local imports.
1256 main_path = os.getcwd()
1257 os.chdir(os.path.dirname(presubmit_path))
1258
1259 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001260 input_api = InputApi(self.change, presubmit_path, self.committing,
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001261 self.rietveld, self.verbose)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001262 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001263 try:
1264 exec script_text in context
1265 except Exception, e:
1266 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001267
1268 # These function names must change if we make substantial changes to
1269 # the presubmit API that are not backwards compatible.
1270 if self.committing:
1271 function_name = 'CheckChangeOnCommit'
1272 else:
1273 function_name = 'CheckChangeOnUpload'
1274 if function_name in context:
wez@chromium.orga6d011e2013-03-26 17:31:49 +00001275 context['__args'] = (input_api, OutputApi(self.committing))
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001276 logging.debug('Running %s in %s' % (function_name, presubmit_path))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001277 result = eval(function_name + '(*__args)', context)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001278 logging.debug('Running %s done.' % function_name)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001279 if not (isinstance(result, types.TupleType) or
1280 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001281 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001282 'Presubmit functions must return a tuple or list')
1283 for item in result:
1284 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001285 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001286 'All presubmit results must be of types derived from '
1287 'output_api.PresubmitResult')
1288 else:
1289 result = () # no error since the script doesn't care about current event.
1290
chase@chromium.org8e416c82009-10-06 04:30:44 +00001291 # Return the process to the original working directory.
1292 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001293 return result
1294
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001295
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001296def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001297 committing,
1298 verbose,
1299 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001300 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001301 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001302 may_prompt,
maruel@chromium.org239f4112011-06-03 20:08:23 +00001303 rietveld_obj):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001304 """Runs all presubmit checks that apply to the files in the change.
1305
1306 This finds all PRESUBMIT.py files in directories enclosing the files in the
1307 change (up to the repository root) and calls the relevant entrypoint function
1308 depending on whether the change is being committed or uploaded.
1309
1310 Prints errors, warnings and notifications. Prompts the user for warnings
1311 when needed.
1312
1313 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001314 change: The Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001315 committing: True if 'gcl commit' is running, False if 'gcl upload' is.
1316 verbose: Prints debug info.
1317 output_stream: A stream to write output from presubmit tests to.
1318 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001319 default_presubmit: A default presubmit script to execute in any case.
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001320 may_prompt: Enable (y/n) questions on warning or error.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001321 rietveld_obj: rietveld.Rietveld object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001322
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001323 Warning:
1324 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1325 SHOULD be sys.stdin.
1326
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001327 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001328 A PresubmitOutput object. Use output.should_continue() to figure out
1329 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001330 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001331 old_environ = os.environ
1332 try:
1333 # Make sure python subprocesses won't generate .pyc files.
1334 os.environ = os.environ.copy()
1335 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001336
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001337 output = PresubmitOutput(input_stream, output_stream)
1338 if committing:
1339 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001340 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001341 output.write("Running presubmit upload checks ...\n")
1342 start_time = time.time()
1343 presubmit_files = ListRelevantPresubmitFiles(
1344 change.AbsoluteLocalPaths(True), change.RepositoryRoot())
1345 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001346 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001347 results = []
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001348 executer = PresubmitExecuter(change, committing, rietveld_obj, verbose)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001349 if default_presubmit:
1350 if verbose:
1351 output.write("Running default presubmit script.\n")
1352 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1353 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1354 for filename in presubmit_files:
1355 filename = os.path.abspath(filename)
1356 if verbose:
1357 output.write("Running %s\n" % filename)
1358 # Accept CRLF presubmit script.
1359 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1360 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001361
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001362 errors = []
1363 notifications = []
1364 warnings = []
1365 for result in results:
1366 if result.fatal:
1367 errors.append(result)
1368 elif result.should_prompt:
1369 warnings.append(result)
1370 else:
1371 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001372
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001373 output.write('\n')
1374 for name, items in (('Messages', notifications),
1375 ('Warnings', warnings),
1376 ('ERRORS', errors)):
1377 if items:
1378 output.write('** Presubmit %s **\n' % name)
1379 for item in items:
1380 item.handle(output)
1381 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001382
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001383 total_time = time.time() - start_time
1384 if total_time > 1.0:
1385 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001386
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001387 if not errors:
1388 if not warnings:
1389 output.write('Presubmit checks passed.\n')
1390 elif may_prompt:
1391 output.prompt_yes_no('There were presubmit warnings. '
1392 'Are you sure you wish to continue? (y/N): ')
1393 else:
1394 output.fail()
1395
1396 global _ASKED_FOR_FEEDBACK
1397 # Ask for feedback one time out of 5.
1398 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001399 output.write(
1400 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1401 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1402 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001403 _ASKED_FOR_FEEDBACK = True
1404 return output
1405 finally:
1406 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001407
1408
1409def ScanSubDirs(mask, recursive):
1410 if not recursive:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001411 return [x for x in glob.glob(mask) if '.svn' not in x and '.git' not in x]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001412 else:
1413 results = []
1414 for root, dirs, files in os.walk('.'):
1415 if '.svn' in dirs:
1416 dirs.remove('.svn')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001417 if '.git' in dirs:
1418 dirs.remove('.git')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001419 for name in files:
1420 if fnmatch.fnmatch(name, mask):
1421 results.append(os.path.join(root, name))
1422 return results
1423
1424
1425def ParseFiles(args, recursive):
maruel@chromium.org7444c502011-02-09 14:02:11 +00001426 logging.debug('Searching for %s' % args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001427 files = []
1428 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001429 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001430 return files
1431
1432
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001433def load_files(options, args):
1434 """Tries to determine the SCM."""
1435 change_scm = scm.determine_scm(options.root)
1436 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001437 if args:
1438 files = ParseFiles(args, options.recursive)
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001439 if change_scm == 'svn':
1440 change_class = SvnChange
1441 if not files:
1442 files = scm.SVN.CaptureStatus([], options.root)
1443 elif change_scm == 'git':
1444 change_class = GitChange
1445 # TODO(maruel): Get upstream.
1446 if not files:
1447 files = scm.GIT.CaptureStatus([], options.root, None)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001448 else:
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001449 logging.info('Doesn\'t seem under source control. Got %d files' % len(args))
1450 if not files:
1451 return None, None
1452 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001453 return change_class, files
1454
1455
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001456class NonexistantCannedCheckFilter(Exception):
1457 pass
1458
1459
1460@contextlib.contextmanager
1461def canned_check_filter(method_names):
1462 filtered = {}
1463 try:
1464 for method_name in method_names:
1465 if not hasattr(presubmit_canned_checks, method_name):
1466 raise NonexistantCannedCheckFilter(method_name)
1467 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1468 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1469 yield
1470 finally:
1471 for name, method in filtered.iteritems():
1472 setattr(presubmit_canned_checks, name, method)
1473
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001474
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001475def CallCommand(cmd_data):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001476 """Runs an external program, potentially from a child process created by the
1477 multiprocessing module.
1478
1479 multiprocessing needs a top level function with a single argument.
1480 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001481 cmd_data.kwargs['stdout'] = subprocess.PIPE
1482 cmd_data.kwargs['stderr'] = subprocess.STDOUT
1483 try:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001484 start = time.time()
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001485 (out, _), code = subprocess.communicate(cmd_data.cmd, **cmd_data.kwargs)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001486 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001487 except OSError as e:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001488 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001489 return cmd_data.message(
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001490 '%s exec failure (%4.2fs)\n %s' % (cmd_data.name, duration, e))
1491 if code != 0:
1492 return cmd_data.message(
1493 '%s (%4.2fs) failed\n%s' % (cmd_data.name, duration, out))
1494 if cmd_data.info:
1495 return cmd_data.info('%s (%4.2fs)' % (cmd_data.name, duration))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001496
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001497
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001498def Main(argv):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001499 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001500 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001501 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001502 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001503 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1504 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001505 parser.add_option("-r", "--recursive", action="store_true",
1506 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001507 parser.add_option("-v", "--verbose", action="count", default=0,
1508 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001509 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001510 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001511 parser.add_option("--description", default='')
1512 parser.add_option("--issue", type='int', default=0)
1513 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001514 parser.add_option("--root", default=os.getcwd(),
1515 help="Search for PRESUBMIT.py up to this directory. "
1516 "If inherit-review-settings-ok is present in this "
1517 "directory, parent directories up to the root file "
1518 "system directories will also be searched.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001519 parser.add_option("--default_presubmit")
1520 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001521 parser.add_option("--skip_canned", action='append', default=[],
1522 help="A list of checks to skip which appear in "
1523 "presubmit_canned_checks. Can be provided multiple times "
1524 "to skip multiple canned checks.")
maruel@chromium.org239f4112011-06-03 20:08:23 +00001525 parser.add_option("--rietveld_url", help=optparse.SUPPRESS_HELP)
1526 parser.add_option("--rietveld_email", help=optparse.SUPPRESS_HELP)
1527 parser.add_option("--rietveld_password", help=optparse.SUPPRESS_HELP)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001528 parser.add_option("--rietveld_fetch", action='store_true', default=False,
1529 help=optparse.SUPPRESS_HELP)
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00001530 parser.add_option("--trybot-json",
1531 help="Output trybot information to the file specified.")
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001532 options, args = parser.parse_args(argv)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001533 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001534 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001535 elif options.verbose:
1536 logging.basicConfig(level=logging.INFO)
1537 else:
1538 logging.basicConfig(level=logging.ERROR)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001539 change_class, files = load_files(options, args)
1540 if not change_class:
1541 parser.error('For unversioned directory, <files> is not optional.')
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001542 logging.info('Found %d file(s).' % len(files))
maruel@chromium.org239f4112011-06-03 20:08:23 +00001543 rietveld_obj = None
1544 if options.rietveld_url:
maruel@chromium.org4bac4b52012-11-27 20:33:52 +00001545 rietveld_obj = rietveld.CachingRietveld(
maruel@chromium.org239f4112011-06-03 20:08:23 +00001546 options.rietveld_url,
1547 options.rietveld_email,
1548 options.rietveld_password)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001549 if options.rietveld_fetch:
1550 assert options.issue
1551 props = rietveld_obj.get_issue_properties(options.issue, False)
1552 options.author = props['owner_email']
1553 options.description = props['description']
1554 logging.info('Got author: "%s"', options.author)
1555 logging.info('Got description: """\n%s\n"""', options.description)
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00001556 if options.trybot_json:
1557 with open(options.trybot_json, 'w') as f:
1558 # Python's sets aren't JSON-encodable, so we convert them to lists here.
1559 class SetEncoder(json.JSONEncoder):
1560 # pylint: disable=E0202
1561 def default(self, obj):
1562 if isinstance(obj, set):
1563 return sorted(obj)
1564 return json.JSONEncoder.default(self, obj)
1565 change = change_class(options.name,
1566 options.description,
1567 options.root,
1568 files,
1569 options.issue,
1570 options.patchset,
1571 options.author)
1572 trybots = DoGetTrySlaves(
1573 change,
1574 change.LocalPaths(),
1575 change.RepositoryRoot(),
1576 None,
1577 None,
1578 options.verbose,
1579 sys.stdout)
1580 json.dump(trybots, f, cls=SetEncoder)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001581 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001582 with canned_check_filter(options.skip_canned):
1583 results = DoPresubmitChecks(
1584 change_class(options.name,
1585 options.description,
1586 options.root,
1587 files,
1588 options.issue,
1589 options.patchset,
1590 options.author),
1591 options.commit,
1592 options.verbose,
1593 sys.stdout,
1594 sys.stdin,
1595 options.default_presubmit,
1596 options.may_prompt,
1597 rietveld_obj)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001598 return not results.should_continue()
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001599 except NonexistantCannedCheckFilter, e:
1600 print >> sys.stderr, (
1601 'Attempted to skip nonexistent canned presubmit check: %s' % e.message)
1602 return 2
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001603 except PresubmitFailure, e:
1604 print >> sys.stderr, e
1605 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
1606 print >> sys.stderr, 'If all fails, contact maruel@'
1607 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001608
1609
1610if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001611 fix_encoding.fix_encoding()
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001612 sys.exit(Main(None))