blob: 594ac6878bf8a05b622ca44d45ed3d7219f8f76d [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
enne@chromium.orge72c5f52013-04-16 00:36:40 +000015import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000016import cPickle # Exposed through the API.
17import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000018import contextlib
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000019import fnmatch
20import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000021import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000022import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000023import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000024import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000025import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000026import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000027import optparse
28import os # Somewhat exposed through the API.
29import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000030import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000031import re # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
jam@chromium.org2a891dc2009-08-20 20:33:37 +000034import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000035import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000036import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000038import urllib2 # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000043import gclient_utils
dpranke@chromium.org2a009622011-03-01 02:43:31 +000044import owners
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000045import presubmit_canned_checks
maruel@chromium.org239f4112011-06-03 20:08:23 +000046import rietveld
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000047import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000048import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049
50
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000051# Ask for feedback only once in program lifetime.
52_ASKED_FOR_FEEDBACK = False
53
54
maruel@chromium.org899e1c12011-04-07 17:03:18 +000055class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000056 pass
57
58
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000059class CommandData(object):
60 def __init__(self, name, cmd, kwargs, message):
61 self.name = name
62 self.cmd = cmd
63 self.kwargs = kwargs
64 self.message = message
65 self.info = None
66
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000067
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000068def normpath(path):
69 '''Version of os.path.normpath that also changes backward slashes to
70 forward slashes when not running on Windows.
71 '''
72 # This is safe to always do because the Windows version of os.path.normpath
73 # will replace forward slashes with backward slashes.
74 path = path.replace(os.sep, '/')
75 return os.path.normpath(path)
76
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000077
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000078def _RightHandSideLinesImpl(affected_files):
79 """Implements RightHandSideLines for InputApi and GclChange."""
80 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000081 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000082 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000083 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000084
85
dpranke@chromium.org5ac21012011-03-16 02:58:25 +000086class PresubmitOutput(object):
87 def __init__(self, input_stream=None, output_stream=None):
88 self.input_stream = input_stream
89 self.output_stream = output_stream
90 self.reviewers = []
91 self.written_output = []
92 self.error_count = 0
93
94 def prompt_yes_no(self, prompt_string):
95 self.write(prompt_string)
96 if self.input_stream:
97 response = self.input_stream.readline().strip().lower()
98 if response not in ('y', 'yes'):
99 self.fail()
100 else:
101 self.fail()
102
103 def fail(self):
104 self.error_count += 1
105
106 def should_continue(self):
107 return not self.error_count
108
109 def write(self, s):
110 self.written_output.append(s)
111 if self.output_stream:
112 self.output_stream.write(s)
113
114 def getvalue(self):
115 return ''.join(self.written_output)
116
117
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000118# Top level object so multiprocessing can pickle
119# Public access through OutputApi object.
120class _PresubmitResult(object):
121 """Base class for result objects."""
122 fatal = False
123 should_prompt = False
124
125 def __init__(self, message, items=None, long_text=''):
126 """
127 message: A short one-line message to indicate errors.
128 items: A list of short strings to indicate where errors occurred.
129 long_text: multi-line text output, e.g. from another tool
130 """
131 self._message = message
132 self._items = items or []
133 if items:
134 self._items = items
135 self._long_text = long_text.rstrip()
136
137 def handle(self, output):
138 output.write(self._message)
139 output.write('\n')
140 for index, item in enumerate(self._items):
141 output.write(' ')
142 # Write separately in case it's unicode.
143 output.write(str(item))
144 if index < len(self._items) - 1:
145 output.write(' \\')
146 output.write('\n')
147 if self._long_text:
148 output.write('\n***************\n')
149 # Write separately in case it's unicode.
150 output.write(self._long_text)
151 output.write('\n***************\n')
152 if self.fatal:
153 output.fail()
154
155
156# Top level object so multiprocessing can pickle
157# Public access through OutputApi object.
158class _PresubmitAddReviewers(_PresubmitResult):
159 """Add some suggested reviewers to the change."""
160 def __init__(self, reviewers):
161 super(_PresubmitAddReviewers, self).__init__('')
162 self.reviewers = reviewers
163
164 def handle(self, output):
165 output.reviewers.extend(self.reviewers)
166
167
168# Top level object so multiprocessing can pickle
169# Public access through OutputApi object.
170class _PresubmitError(_PresubmitResult):
171 """A hard presubmit error."""
172 fatal = True
173
174
175# Top level object so multiprocessing can pickle
176# Public access through OutputApi object.
177class _PresubmitPromptWarning(_PresubmitResult):
178 """An warning that prompts the user if they want to continue."""
179 should_prompt = True
180
181
182# Top level object so multiprocessing can pickle
183# Public access through OutputApi object.
184class _PresubmitNotifyResult(_PresubmitResult):
185 """Just print something to the screen -- but it's not even a warning."""
186 pass
187
188
189# Top level object so multiprocessing can pickle
190# Public access through OutputApi object.
191class _MailTextResult(_PresubmitResult):
192 """A warning that should be included in the review request email."""
193 def __init__(self, *args, **kwargs):
194 super(_MailTextResult, self).__init__()
195 raise NotImplementedError()
196
197
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000198class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000199 """An instance of OutputApi gets passed to presubmit scripts so that they
200 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000201 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000202 PresubmitResult = _PresubmitResult
203 PresubmitAddReviewers = _PresubmitAddReviewers
204 PresubmitError = _PresubmitError
205 PresubmitPromptWarning = _PresubmitPromptWarning
206 PresubmitNotifyResult = _PresubmitNotifyResult
207 MailTextResult = _MailTextResult
208
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000209 def __init__(self, is_committing):
210 self.is_committing = is_committing
211
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000212 def PresubmitPromptOrNotify(self, *args, **kwargs):
213 """Warn the user when uploading, but only notify if committing."""
214 if self.is_committing:
215 return self.PresubmitNotifyResult(*args, **kwargs)
216 return self.PresubmitPromptWarning(*args, **kwargs)
217
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000218
219class InputApi(object):
220 """An instance of this object is passed to presubmit scripts so they can
221 know stuff about the change they're looking at.
222 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000223 # Method could be a function
224 # pylint: disable=R0201
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000225
maruel@chromium.org3410d912009-06-09 20:56:16 +0000226 # File extensions that are considered source files from a style guide
227 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000228 #
229 # Files without an extension aren't included in the list. If you want to
230 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
231 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000232 DEFAULT_WHITE_LIST = (
233 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000234 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
235 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000236 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000237 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000238 # Other
estade@chromium.orgae7af922012-01-27 14:51:13 +0000239 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000240 )
241
242 # Path regexp that should be excluded from being considered containing source
243 # files. Don't modify this list from a presubmit script!
244 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000245 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000246 r".*\bexperimental[\\\/].*",
247 r".*\bthird_party[\\\/].*",
248 # Output directories (just in case)
249 r".*\bDebug[\\\/].*",
250 r".*\bRelease[\\\/].*",
251 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000252 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000253 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000254 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000255 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000256 r"(|.*[\\\/])\.git[\\\/].*",
257 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000258 # There is no point in processing a patch file.
259 r".+\.diff$",
260 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000261 )
262
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000263 def __init__(self, change, presubmit_path, is_committing,
maruel@chromium.org239f4112011-06-03 20:08:23 +0000264 rietveld_obj, verbose):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000265 """Builds an InputApi object.
266
267 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000268 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000269 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000270 is_committing: True if the change is about to be committed.
maruel@chromium.org239f4112011-06-03 20:08:23 +0000271 rietveld_obj: rietveld.Rietveld client object
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000272 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000273 # Version number of the presubmit_support script.
274 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000275 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000276 self.is_committing = is_committing
maruel@chromium.org239f4112011-06-03 20:08:23 +0000277 self.rietveld = rietveld_obj
maruel@chromium.orgcab38e92011-04-09 00:30:51 +0000278 # TBD
279 self.host_url = 'http://codereview.chromium.org'
280 if self.rietveld:
maruel@chromium.org239f4112011-06-03 20:08:23 +0000281 self.host_url = self.rietveld.url
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000282
283 # We expose various modules and functions as attributes of the input_api
284 # so that presubmit scripts don't have to import them.
285 self.basename = os.path.basename
286 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000287 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000288 self.cStringIO = cStringIO
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000289 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000290 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000291 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000292 self.os_listdir = os.listdir
293 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000294 self.os_path = os.path
295 self.pickle = pickle
296 self.marshal = marshal
297 self.re = re
298 self.subprocess = subprocess
299 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000300 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000301 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000302 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000303 self.urllib2 = urllib2
304
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000305 # To easily fork python.
306 self.python_executable = sys.executable
307 self.environ = os.environ
308
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000309 # InputApi.platform is the platform you're currently running on.
310 self.platform = sys.platform
311
312 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000313 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000314
315 # We carry the canned checks so presubmit scripts can easily use them.
316 self.canned_checks = presubmit_canned_checks
317
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000318 # TODO(dpranke): figure out a list of all approved owners for a repo
319 # in order to be able to handle wildcard OWNERS files?
320 self.owners_db = owners.Database(change.RepositoryRoot(),
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000321 fopen=file, os_path=self.os_path, glob=self.glob)
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000322 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000323 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000324
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000325 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000326 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000327 # Access to a protected member _XX of a client class
328 # pylint: disable=W0212
329 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000330 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000331 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
332 for (a, b, header) in cpplint._re_pattern_templates
333 ]
334
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000335 def PresubmitLocalPath(self):
336 """Returns the local path of the presubmit script currently being run.
337
338 This is useful if you don't want to hard-code absolute paths in the
339 presubmit script. For example, It can be used to find another file
340 relative to the PRESUBMIT.py script, so the whole tree can be branched and
341 the presubmit script still works, without editing its content.
342 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000343 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000344
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000345 def DepotToLocalPath(self, depot_path):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000346 """Translate a depot path to a local path (relative to client root).
347
348 Args:
349 Depot path as a string.
350
351 Returns:
352 The local path of the depot path under the user's current client, or None
353 if the file is not mapped.
354
355 Remember to check for the None case and show an appropriate error!
356 """
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000357 return scm.SVN.CaptureLocalInfo([depot_path], self.change.RepositoryRoot()
358 ).get('Path')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000359
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000360 def LocalToDepotPath(self, local_path):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000361 """Translate a local path to a depot path.
362
363 Args:
364 Local path (relative to current directory, or absolute) as a string.
365
366 Returns:
367 The depot path (SVN URL) of the file if mapped, otherwise None.
368 """
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000369 return scm.SVN.CaptureLocalInfo([local_path], self.change.RepositoryRoot()
370 ).get('URL')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000371
sail@chromium.org5538e022011-05-12 17:53:16 +0000372 def AffectedFiles(self, include_dirs=False, include_deletes=True,
373 file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000374 """Same as input_api.change.AffectedFiles() except only lists files
375 (and optionally directories) in the same directory as the current presubmit
376 script, or subdirectories thereof.
377 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000378 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000379 if len(dir_with_slash) == 1:
380 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000381
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000382 return filter(
383 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
sail@chromium.org5538e022011-05-12 17:53:16 +0000384 self.change.AffectedFiles(include_dirs, include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000385
386 def LocalPaths(self, include_dirs=False):
387 """Returns local paths of input_api.AffectedFiles()."""
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000388 paths = [af.LocalPath() for af in self.AffectedFiles(include_dirs)]
389 logging.debug("LocalPaths: %s", paths)
390 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000391
392 def AbsoluteLocalPaths(self, include_dirs=False):
393 """Returns absolute local paths of input_api.AffectedFiles()."""
394 return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)]
395
396 def ServerPaths(self, include_dirs=False):
397 """Returns server paths of input_api.AffectedFiles()."""
398 return [af.ServerPath() for af in self.AffectedFiles(include_dirs)]
399
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000400 def AffectedTextFiles(self, include_deletes=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000401 """Same as input_api.change.AffectedTextFiles() except only lists files
402 in the same directory as the current presubmit script, or subdirectories
403 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000404 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000405 if include_deletes is not None:
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000406 warn("AffectedTextFiles(include_deletes=%s)"
407 " is deprecated and ignored" % str(include_deletes),
408 category=DeprecationWarning,
409 stacklevel=2)
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000410 return filter(lambda x: x.IsTextFile(),
411 self.AffectedFiles(include_dirs=False, include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000412
maruel@chromium.org3410d912009-06-09 20:56:16 +0000413 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
414 """Filters out files that aren't considered "source file".
415
416 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
417 and InputApi.DEFAULT_BLACK_LIST is used respectively.
418
419 The lists will be compiled as regular expression and
420 AffectedFile.LocalPath() needs to pass both list.
421
422 Note: Copy-paste this function to suit your needs or use a lambda function.
423 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000424 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000425 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000426 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000427 if self.re.match(item, local_path):
428 logging.debug("%s matched %s" % (item, local_path))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000429 return True
430 return False
431 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
432 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
433
434 def AffectedSourceFiles(self, source_file):
435 """Filter the list of AffectedTextFiles by the function source_file.
436
437 If source_file is None, InputApi.FilterSourceFile() is used.
438 """
439 if not source_file:
440 source_file = self.FilterSourceFile
441 return filter(source_file, self.AffectedTextFiles())
442
443 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000444 """An iterator over all text lines in "new" version of changed files.
445
446 Only lists lines from new or modified text files in the change that are
447 contained by the directory of the currently executing presubmit script.
448
449 This is useful for doing line-by-line regex checks, like checking for
450 trailing whitespace.
451
452 Yields:
453 a 3 tuple:
454 the AffectedFile instance of the current file;
455 integer line number (1-based); and
456 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000457
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000458 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000459 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000460 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000461 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000462
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000463 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000464 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000465
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000466 Deny reading anything outside the repository.
467 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000468 if isinstance(file_item, AffectedFile):
469 file_item = file_item.AbsoluteLocalPath()
470 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000471 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000472 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000473
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000474 @property
475 def tbr(self):
476 """Returns if a change is TBR'ed."""
477 return 'TBR' in self.change.tags
478
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000479 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000480 tests = []
481 msgs = []
482 for t in tests_mix:
483 if isinstance(t, OutputApi.PresubmitResult):
484 msgs.append(t)
485 else:
486 assert issubclass(t.message, _PresubmitResult)
487 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000488 if self.verbose:
489 t.info = _PresubmitNotifyResult
ilevy@chromium.org5678d332013-05-18 01:34:14 +0000490 if len(tests) > 1 and parallel:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000491 pool = multiprocessing.Pool()
492 # async recipe works around multiprocessing bug handling Ctrl-C
493 msgs.extend(pool.map_async(CallCommand, tests).get(99999))
494 pool.close()
495 pool.join()
496 else:
497 msgs.extend(map(CallCommand, tests))
498 return [m for m in msgs if m]
499
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000500
nick@chromium.orgff526192013-06-10 19:30:26 +0000501class _DiffCache(object):
502 """Caches diffs retrieved from a particular SCM."""
503
504 def GetDiff(self, path, local_root):
505 """Get the diff for a particular path."""
506 raise NotImplementedError()
507
508
509class _SvnDiffCache(_DiffCache):
510 """DiffCache implementation for subversion."""
511 def __init__(self):
512 super(_SvnDiffCache, self).__init__()
513 self._diffs_by_file = {}
514
515 def GetDiff(self, path, local_root):
516 if path not in self._diffs_by_file:
517 self._diffs_by_file[path] = scm.SVN.GenerateDiff([path], local_root,
518 False, None)
519 return self._diffs_by_file[path]
520
521
522class _GitDiffCache(_DiffCache):
523 """DiffCache implementation for git; gets all file diffs at once."""
524 def __init__(self):
525 super(_GitDiffCache, self).__init__()
526 self._diffs_by_file = None
527
528 def GetDiff(self, path, local_root):
529 if not self._diffs_by_file:
530 # Compute a single diff for all files and parse the output; should
531 # with git this is much faster than computing one diff for each file.
532 diffs = {}
533
534 # Don't specify any filenames below, because there are command line length
535 # limits on some platforms and GenerateDiff would fail.
536 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True)
537
538 # This regex matches the path twice, separated by a space. Note that
539 # filename itself may contain spaces.
540 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
541 current_diff = []
542 keep_line_endings = True
543 for x in unified_diff.splitlines(keep_line_endings):
544 match = file_marker.match(x)
545 if match:
546 # Marks the start of a new per-file section.
547 diffs[match.group('filename')] = current_diff = [x]
548 elif x.startswith('diff --git'):
549 raise PresubmitFailure('Unexpected diff line: %s' % x)
550 else:
551 current_diff.append(x)
552
553 self._diffs_by_file = dict(
554 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
555
556 if path not in self._diffs_by_file:
557 raise PresubmitFailure(
558 'Unified diff did not contain entry for file %s' % path)
559
560 return self._diffs_by_file[path]
561
562
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000563class AffectedFile(object):
564 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000565
566 DIFF_CACHE = _DiffCache
567
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000568 # Method could be a function
569 # pylint: disable=R0201
nick@chromium.orgff526192013-06-10 19:30:26 +0000570 def __init__(self, path, action, repository_root, diff_cache=None):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000571 self._path = path
572 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000573 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000574 self._is_directory = None
575 self._properties = {}
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000576 self._cached_changed_contents = None
577 self._cached_new_contents = None
nick@chromium.orgff526192013-06-10 19:30:26 +0000578 if diff_cache:
579 self._diff_cache = diff_cache
580 else:
581 self._diff_cache = self.DIFF_CACHE()
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000582 logging.debug('%s(%s)' % (self.__class__.__name__, self._path))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000583
584 def ServerPath(self):
585 """Returns a path string that identifies the file in the SCM system.
586
587 Returns the empty string if the file does not exist in SCM.
588 """
nick@chromium.orgff526192013-06-10 19:30:26 +0000589 return ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000590
591 def LocalPath(self):
592 """Returns the path of this file on the local disk relative to client root.
593 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000594 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000595
596 def AbsoluteLocalPath(self):
597 """Returns the absolute path of this file on the local disk.
598 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000599 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000600
601 def IsDirectory(self):
602 """Returns true if this object is a directory."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000603 if self._is_directory is None:
604 path = self.AbsoluteLocalPath()
605 self._is_directory = (os.path.exists(path) and
606 os.path.isdir(path))
607 return self._is_directory
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000608
609 def Action(self):
610 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000611 # TODO(maruel): Somewhat crappy, Could be "A" or "A +" for svn but
612 # different for other SCM.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000613 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000614
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000615 def Property(self, property_name):
616 """Returns the specified SCM property of this file, or None if no such
617 property.
618 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000619 return self._properties.get(property_name, None)
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000620
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000621 def IsTextFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000622 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000623
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000624 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000625 raise NotImplementedError() # Implement when needed
626
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000627 def NewContents(self):
628 """Returns an iterator over the lines in the new version of file.
629
630 The new version is the file in the user's workspace, i.e. the "right hand
631 side".
632
633 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000634 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000635 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000636 if self._cached_new_contents is None:
637 self._cached_new_contents = []
638 if not self.IsDirectory():
639 try:
640 self._cached_new_contents = gclient_utils.FileRead(
641 self.AbsoluteLocalPath(), 'rU').splitlines()
642 except IOError:
643 pass # File not found? That's fine; maybe it was deleted.
644 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000645
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000646 def ChangedContents(self):
647 """Returns a list of tuples (line number, line text) of all new lines.
648
649 This relies on the scm diff output describing each changed code section
650 with a line of the form
651
652 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
653 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000654 if self._cached_changed_contents is not None:
655 return self._cached_changed_contents[:]
656 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000657 line_num = 0
658
659 if self.IsDirectory():
660 return []
661
662 for line in self.GenerateScmDiff().splitlines():
663 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
664 if m:
665 line_num = int(m.groups(1)[0])
666 continue
667 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000668 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000669 if not line.startswith('-'):
670 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000671 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000672
maruel@chromium.org5de13972009-06-10 18:16:06 +0000673 def __str__(self):
674 return self.LocalPath()
675
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000676 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000677 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000678
maruel@chromium.org58407af2011-04-12 23:15:57 +0000679
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000680class SvnAffectedFile(AffectedFile):
681 """Representation of a file in a change out of a Subversion checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000682 # Method 'NNN' is abstract in class 'NNN' but is not overridden
683 # pylint: disable=W0223
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000684
nick@chromium.orgff526192013-06-10 19:30:26 +0000685 DIFF_CACHE = _SvnDiffCache
686
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000687 def __init__(self, *args, **kwargs):
688 AffectedFile.__init__(self, *args, **kwargs)
689 self._server_path = None
690 self._is_text_file = None
691
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000692 def ServerPath(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000693 if self._server_path is None:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000694 self._server_path = scm.SVN.CaptureLocalInfo(
695 [self.LocalPath()], self._local_root).get('URL', '')
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000696 return self._server_path
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000697
698 def IsDirectory(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000699 if self._is_directory is None:
700 path = self.AbsoluteLocalPath()
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000701 if os.path.exists(path):
702 # Retrieve directly from the file system; it is much faster than
703 # querying subversion, especially on Windows.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000704 self._is_directory = os.path.isdir(path)
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000705 else:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000706 self._is_directory = scm.SVN.CaptureLocalInfo(
707 [self.LocalPath()], self._local_root
708 ).get('Node Kind') in ('dir', 'directory')
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000709 return self._is_directory
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000710
711 def Property(self, property_name):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000712 if not property_name in self._properties:
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000713 self._properties[property_name] = scm.SVN.GetFileProperty(
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000714 self.LocalPath(), property_name, self._local_root).rstrip()
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000715 return self._properties[property_name]
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000716
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000717 def IsTextFile(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000718 if self._is_text_file is None:
719 if self.Action() == 'D':
720 # A deleted file is not a text file.
721 self._is_text_file = False
722 elif self.IsDirectory():
723 self._is_text_file = False
724 else:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000725 mime_type = scm.SVN.GetFileProperty(
726 self.LocalPath(), 'svn:mime-type', self._local_root)
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000727 self._is_text_file = (not mime_type or mime_type.startswith('text/'))
728 return self._is_text_file
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000729
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000730
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000731class GitAffectedFile(AffectedFile):
732 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000733 # Method 'NNN' is abstract in class 'NNN' but is not overridden
734 # pylint: disable=W0223
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000735
nick@chromium.orgff526192013-06-10 19:30:26 +0000736 DIFF_CACHE = _GitDiffCache
737
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000738 def __init__(self, *args, **kwargs):
739 AffectedFile.__init__(self, *args, **kwargs)
740 self._server_path = None
741 self._is_text_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000742
743 def ServerPath(self):
744 if self._server_path is None:
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000745 raise NotImplementedError('TODO(maruel) Implement.')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000746 return self._server_path
747
748 def IsDirectory(self):
749 if self._is_directory is None:
750 path = self.AbsoluteLocalPath()
751 if os.path.exists(path):
752 # Retrieve directly from the file system; it is much faster than
753 # querying subversion, especially on Windows.
754 self._is_directory = os.path.isdir(path)
755 else:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000756 self._is_directory = False
757 return self._is_directory
758
759 def Property(self, property_name):
760 if not property_name in self._properties:
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000761 raise NotImplementedError('TODO(maruel) Implement.')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000762 return self._properties[property_name]
763
764 def IsTextFile(self):
765 if self._is_text_file is None:
766 if self.Action() == 'D':
767 # A deleted file is not a text file.
768 self._is_text_file = False
769 elif self.IsDirectory():
770 self._is_text_file = False
771 else:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000772 self._is_text_file = os.path.isfile(self.AbsoluteLocalPath())
773 return self._is_text_file
774
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000775
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000776class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000777 """Describe a change.
778
779 Used directly by the presubmit scripts to query the current change being
780 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000781
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000782 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000783 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000784 self.KEY: equivalent to tags['KEY']
785 """
786
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000787 _AFFECTED_FILES = AffectedFile
788
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000789 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000790 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000791 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000792 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000793
maruel@chromium.org58407af2011-04-12 23:15:57 +0000794 def __init__(
795 self, name, description, local_root, files, issue, patchset, author):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000796 if files is None:
797 files = []
798 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +0000799 # Convert root into an absolute path.
800 self._local_root = os.path.abspath(local_root)
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000801 self.issue = issue
802 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +0000803 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000804
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000805 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000806 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000807 self._description_without_tags = ''
808 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000809
maruel@chromium.orge085d812011-10-10 19:49:15 +0000810 assert all(
811 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
812
nick@chromium.orgff526192013-06-10 19:30:26 +0000813 diff_cache = self._AFFECTED_FILES.DIFF_CACHE()
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000814 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +0000815 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
816 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000817 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000818
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000819 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000820 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000821 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000822
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000823 def DescriptionText(self):
824 """Returns the user-entered changelist description, minus tags.
825
826 Any line in the user-provided description starting with e.g. "FOO="
827 (whitespace permitted before and around) is considered a tag line. Such
828 lines are stripped out of the description this function returns.
829 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000830 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000831
832 def FullDescriptionText(self):
833 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000834 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000835
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000836 def SetDescriptionText(self, description):
837 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +0000838
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000839 Also updates the list of tags."""
840 self._full_description = description
841
842 # From the description text, build up a dictionary of key/value pairs
843 # plus the description minus all key/value or "tag" lines.
844 description_without_tags = []
845 self.tags = {}
846 for line in self._full_description.splitlines():
847 m = self.TAG_LINE_RE.match(line)
848 if m:
849 self.tags[m.group('key')] = m.group('value')
850 else:
851 description_without_tags.append(line)
852
853 # Change back to text and remove whitespace at end.
854 self._description_without_tags = (
855 '\n'.join(description_without_tags).rstrip())
856
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000857 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000858 """Returns the repository (checkout) root directory for this change,
859 as an absolute path.
860 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000861 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000862
863 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000864 """Return tags directly as attributes on the object."""
865 if not re.match(r"^[A-Z_]*$", attr):
866 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +0000867 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000868
sail@chromium.org5538e022011-05-12 17:53:16 +0000869 def AffectedFiles(self, include_dirs=False, include_deletes=True,
870 file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000871 """Returns a list of AffectedFile instances for all files in the change.
872
873 Args:
874 include_deletes: If false, deleted files will be filtered out.
875 include_dirs: True to include directories in the list
sail@chromium.org5538e022011-05-12 17:53:16 +0000876 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000877
878 Returns:
879 [AffectedFile(path, action), AffectedFile(path, action)]
880 """
881 if include_dirs:
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000882 affected = self._affected_files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000883 else:
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000884 affected = filter(lambda x: not x.IsDirectory(), self._affected_files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000885
sail@chromium.org5538e022011-05-12 17:53:16 +0000886 affected = filter(file_filter, affected)
887
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000888 if include_deletes:
889 return affected
890 else:
891 return filter(lambda x: x.Action() != 'D', affected)
892
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000893 def AffectedTextFiles(self, include_deletes=None):
894 """Return a list of the existing text files in a change."""
895 if include_deletes is not None:
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000896 warn("AffectedTextFiles(include_deletes=%s)"
897 " is deprecated and ignored" % str(include_deletes),
898 category=DeprecationWarning,
899 stacklevel=2)
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000900 return filter(lambda x: x.IsTextFile(),
901 self.AffectedFiles(include_dirs=False, include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000902
903 def LocalPaths(self, include_dirs=False):
904 """Convenience function."""
905 return [af.LocalPath() for af in self.AffectedFiles(include_dirs)]
906
907 def AbsoluteLocalPaths(self, include_dirs=False):
908 """Convenience function."""
909 return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)]
910
911 def ServerPaths(self, include_dirs=False):
912 """Convenience function."""
913 return [af.ServerPath() for af in self.AffectedFiles(include_dirs)]
914
915 def RightHandSideLines(self):
916 """An iterator over all text lines in "new" version of changed files.
917
918 Lists lines from new or modified text files in the change.
919
920 This is useful for doing line-by-line regex checks, like checking for
921 trailing whitespace.
922
923 Yields:
924 a 3 tuple:
925 the AffectedFile instance of the current file;
926 integer line number (1-based); and
927 the contents of the line as a string.
928 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000929 return _RightHandSideLinesImpl(
930 x for x in self.AffectedFiles(include_deletes=False)
931 if x.IsTextFile())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000932
933
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000934class SvnChange(Change):
935 _AFFECTED_FILES = SvnAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000936 scm = 'svn'
937 _changelists = None
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000938
939 def _GetChangeLists(self):
940 """Get all change lists."""
941 if self._changelists == None:
942 previous_cwd = os.getcwd()
943 os.chdir(self.RepositoryRoot())
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000944 # Need to import here to avoid circular dependency.
945 import gcl
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000946 self._changelists = gcl.GetModifiedFiles()
947 os.chdir(previous_cwd)
948 return self._changelists
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000949
950 def GetAllModifiedFiles(self):
951 """Get all modified files."""
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000952 changelists = self._GetChangeLists()
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000953 all_modified_files = []
954 for cl in changelists.values():
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000955 all_modified_files.extend(
956 [os.path.join(self.RepositoryRoot(), f[1]) for f in cl])
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000957 return all_modified_files
958
959 def GetModifiedFiles(self):
960 """Get modified files in the current CL."""
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000961 changelists = self._GetChangeLists()
962 return [os.path.join(self.RepositoryRoot(), f[1])
963 for f in changelists[self.Name()]]
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000964
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000965
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000966class GitChange(Change):
967 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000968 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000969
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000970
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000971def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000972 """Finds all presubmit files that apply to a given set of source files.
973
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000974 If inherit-review-settings-ok is present right under root, looks for
975 PRESUBMIT.py in directories enclosing root.
976
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000977 Args:
978 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000979 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000980
981 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000982 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000983 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000984 files = [normpath(os.path.join(root, f)) for f in files]
985
986 # List all the individual directories containing files.
987 directories = set([os.path.dirname(f) for f in files])
988
989 # Ignore root if inherit-review-settings-ok is present.
990 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
991 root = None
992
993 # Collect all unique directories that may contain PRESUBMIT.py.
994 candidates = set()
995 for directory in directories:
996 while True:
997 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000998 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000999 candidates.add(directory)
1000 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001001 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001002 parent_dir = os.path.dirname(directory)
1003 if parent_dir == directory:
1004 # We hit the system root directory.
1005 break
1006 directory = parent_dir
1007
1008 # Look for PRESUBMIT.py in all candidate directories.
1009 results = []
1010 for directory in sorted(list(candidates)):
1011 p = os.path.join(directory, 'PRESUBMIT.py')
1012 if os.path.isfile(p):
1013 results.append(p)
1014
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001015 logging.debug('Presubmit files: %s' % ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001016 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001017
1018
thestig@chromium.orgde243452009-10-06 21:02:56 +00001019class GetTrySlavesExecuter(object):
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001020 @staticmethod
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001021 def ExecPresubmitScript(script_text, presubmit_path, project, change):
thestig@chromium.orgde243452009-10-06 21:02:56 +00001022 """Executes GetPreferredTrySlaves() from a single presubmit script.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001023
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001024 This will soon be deprecated and replaced by GetPreferredTryMasters().
thestig@chromium.orgde243452009-10-06 21:02:56 +00001025
1026 Args:
1027 script_text: The text of the presubmit script.
bradnelson@google.com78230022011-05-24 18:55:19 +00001028 presubmit_path: Project script to run.
1029 project: Project name to pass to presubmit script for bot selection.
thestig@chromium.orgde243452009-10-06 21:02:56 +00001030
1031 Return:
1032 A list of try slaves.
1033 """
1034 context = {}
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001035 main_path = os.getcwd()
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001036 try:
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001037 os.chdir(os.path.dirname(presubmit_path))
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001038 exec script_text in context
1039 except Exception, e:
1040 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001041 finally:
1042 os.chdir(main_path)
thestig@chromium.orgde243452009-10-06 21:02:56 +00001043
1044 function_name = 'GetPreferredTrySlaves'
1045 if function_name in context:
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001046 get_preferred_try_slaves = context[function_name]
1047 function_info = inspect.getargspec(get_preferred_try_slaves)
1048 if len(function_info[0]) == 1:
1049 result = get_preferred_try_slaves(project)
1050 elif len(function_info[0]) == 2:
1051 result = get_preferred_try_slaves(project, change)
1052 else:
1053 result = get_preferred_try_slaves()
thestig@chromium.orgde243452009-10-06 21:02:56 +00001054 if not isinstance(result, types.ListType):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001055 raise PresubmitFailure(
thestig@chromium.orgde243452009-10-06 21:02:56 +00001056 'Presubmit functions must return a list, got a %s instead: %s' %
1057 (type(result), str(result)))
1058 for item in result:
stip@chromium.org68e04192013-11-04 22:14:38 +00001059 if isinstance(item, basestring):
1060 # Old-style ['bot'] format.
1061 botname = item
1062 elif isinstance(item, tuple):
1063 # New-style [('bot', set(['tests']))] format.
1064 botname = item[0]
1065 else:
1066 raise PresubmitFailure('PRESUBMIT.py returned invalid tryslave/test'
1067 ' format.')
1068
1069 if botname != botname.strip():
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001070 raise PresubmitFailure(
1071 'Try slave names cannot start/end with whitespace')
stip@chromium.org68e04192013-11-04 22:14:38 +00001072 if ',' in botname:
maruel@chromium.org3ecc8ea2012-03-10 01:47:46 +00001073 raise PresubmitFailure(
stip@chromium.org68e04192013-11-04 22:14:38 +00001074 'Do not use \',\' separated builder or test names: %s' % botname)
thestig@chromium.orgde243452009-10-06 21:02:56 +00001075 else:
1076 result = []
stip@chromium.org5ca27622013-12-18 17:44:58 +00001077
1078 def valid_oldstyle(result):
1079 return all(isinstance(i, basestring) for i in result)
1080
1081 def valid_newstyle(result):
1082 return (all(isinstance(i, tuple) for i in result) and
1083 all(len(i) == 2 for i in result) and
1084 all(isinstance(i[0], basestring) for i in result) and
1085 all(isinstance(i[1], set) for i in result)
1086 )
1087
1088 # Ensure it's either all old-style or all new-style.
1089 if not valid_oldstyle(result) and not valid_newstyle(result):
1090 raise PresubmitFailure(
1091 'PRESUBMIT.py returned invalid trybot specification!')
1092
thestig@chromium.orgde243452009-10-06 21:02:56 +00001093 return result
1094
1095
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001096class GetTryMastersExecuter(object):
1097 @staticmethod
1098 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1099 """Executes GetPreferredTryMasters() from a single presubmit script.
1100
1101 Args:
1102 script_text: The text of the presubmit script.
1103 presubmit_path: Project script to run.
1104 project: Project name to pass to presubmit script for bot selection.
1105
1106 Return:
1107 A map of try masters to map of builders to set of tests.
1108 """
1109 context = {}
1110 try:
1111 exec script_text in context
1112 except Exception, e:
1113 raise PresubmitFailure('"%s" had an exception.\n%s'
1114 % (presubmit_path, e))
1115
1116 function_name = 'GetPreferredTryMasters'
1117 if function_name not in context:
1118 return {}
1119 get_preferred_try_masters = context[function_name]
1120 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1121 raise PresubmitFailure(
1122 'Expected function "GetPreferredTryMasters" to take two arguments.')
1123 return get_preferred_try_masters(project, change)
1124
1125
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001126def DoGetTrySlaves(change,
1127 changed_files,
thestig@chromium.orgde243452009-10-06 21:02:56 +00001128 repository_root,
1129 default_presubmit,
bradnelson@google.com78230022011-05-24 18:55:19 +00001130 project,
thestig@chromium.orgde243452009-10-06 21:02:56 +00001131 verbose,
1132 output_stream):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001133 """Get the list of try servers from the presubmit scripts (deprecated).
thestig@chromium.orgde243452009-10-06 21:02:56 +00001134
1135 Args:
1136 changed_files: List of modified files.
1137 repository_root: The repository root.
1138 default_presubmit: A default presubmit script to execute in any case.
bradnelson@google.com78230022011-05-24 18:55:19 +00001139 project: Optional name of a project used in selecting trybots.
thestig@chromium.orgde243452009-10-06 21:02:56 +00001140 verbose: Prints debug info.
1141 output_stream: A stream to write debug output to.
1142
1143 Return:
1144 List of try slaves
1145 """
1146 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1147 if not presubmit_files and verbose:
mdempsky@chromium.orgd59e7612014-03-05 19:55:56 +00001148 output_stream.write("Warning, no PRESUBMIT.py found.\n")
thestig@chromium.orgde243452009-10-06 21:02:56 +00001149 results = []
1150 executer = GetTrySlavesExecuter()
stip@chromium.org5ca27622013-12-18 17:44:58 +00001151
thestig@chromium.orgde243452009-10-06 21:02:56 +00001152 if default_presubmit:
1153 if verbose:
1154 output_stream.write("Running default presubmit script.\n")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001155 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
stip@chromium.org5ca27622013-12-18 17:44:58 +00001156 results.extend(executer.ExecPresubmitScript(
1157 default_presubmit, fake_path, project, change))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001158 for filename in presubmit_files:
1159 filename = os.path.abspath(filename)
1160 if verbose:
1161 output_stream.write("Running %s\n" % filename)
1162 # Accept CRLF presubmit script.
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +00001163 presubmit_script = gclient_utils.FileRead(filename, 'rU')
stip@chromium.org5ca27622013-12-18 17:44:58 +00001164 results.extend(executer.ExecPresubmitScript(
1165 presubmit_script, filename, project, change))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001166
stip@chromium.org5ca27622013-12-18 17:44:58 +00001167
1168 slave_dict = {}
1169 old_style = filter(lambda x: isinstance(x, basestring), results)
1170 new_style = filter(lambda x: isinstance(x, tuple), results)
1171
1172 for result in new_style:
1173 slave_dict.setdefault(result[0], set()).update(result[1])
1174 slaves = list(slave_dict.items())
1175
1176 slaves.extend(set(old_style))
stip@chromium.org68e04192013-11-04 22:14:38 +00001177
thestig@chromium.orgde243452009-10-06 21:02:56 +00001178 if slaves and verbose:
stip@chromium.org5ca27622013-12-18 17:44:58 +00001179 output_stream.write(', '.join((str(x) for x in slaves)))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001180 output_stream.write('\n')
1181 return slaves
1182
1183
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001184def _MergeMasters(masters1, masters2):
1185 """Merges two master maps. Merges also the tests of each builder."""
1186 result = {}
1187 for (master, builders) in itertools.chain(masters1.iteritems(),
1188 masters2.iteritems()):
1189 new_builders = result.setdefault(master, {})
1190 for (builder, tests) in builders.iteritems():
1191 new_builders.setdefault(builder, set([])).update(tests)
1192 return result
1193
1194
1195def DoGetTryMasters(change,
1196 changed_files,
1197 repository_root,
1198 default_presubmit,
1199 project,
1200 verbose,
1201 output_stream):
1202 """Get the list of try masters from the presubmit scripts.
1203
1204 Args:
1205 changed_files: List of modified files.
1206 repository_root: The repository root.
1207 default_presubmit: A default presubmit script to execute in any case.
1208 project: Optional name of a project used in selecting trybots.
1209 verbose: Prints debug info.
1210 output_stream: A stream to write debug output to.
1211
1212 Return:
1213 Map of try masters to map of builders to set of tests.
1214 """
1215 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1216 if not presubmit_files and verbose:
1217 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1218 results = {}
1219 executer = GetTryMastersExecuter()
1220
1221 if default_presubmit:
1222 if verbose:
1223 output_stream.write("Running default presubmit script.\n")
1224 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1225 results = _MergeMasters(results, executer.ExecPresubmitScript(
1226 default_presubmit, fake_path, project, change))
1227 for filename in presubmit_files:
1228 filename = os.path.abspath(filename)
1229 if verbose:
1230 output_stream.write("Running %s\n" % filename)
1231 # Accept CRLF presubmit script.
1232 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1233 results = _MergeMasters(results, executer.ExecPresubmitScript(
1234 presubmit_script, filename, project, change))
1235
1236 # Make sets to lists again for later JSON serialization.
1237 for builders in results.itervalues():
1238 for builder in builders:
1239 builders[builder] = list(builders[builder])
1240
1241 if results and verbose:
1242 output_stream.write('%s\n' % str(results))
1243 return results
1244
1245
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001246class PresubmitExecuter(object):
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001247 def __init__(self, change, committing, rietveld_obj, verbose):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001248 """
1249 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001250 change: The Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001251 committing: True if 'gcl commit' is running, False if 'gcl upload' is.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001252 rietveld_obj: rietveld.Rietveld client object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001253 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001254 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001255 self.committing = committing
maruel@chromium.org239f4112011-06-03 20:08:23 +00001256 self.rietveld = rietveld_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001257 self.verbose = verbose
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001258
1259 def ExecPresubmitScript(self, script_text, presubmit_path):
1260 """Executes a single presubmit script.
1261
1262 Args:
1263 script_text: The text of the presubmit script.
1264 presubmit_path: The path to the presubmit file (this will be reported via
1265 input_api.PresubmitLocalPath()).
1266
1267 Return:
1268 A list of result objects, empty if no problems.
1269 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001270
1271 # Change to the presubmit file's directory to support local imports.
1272 main_path = os.getcwd()
1273 os.chdir(os.path.dirname(presubmit_path))
1274
1275 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001276 input_api = InputApi(self.change, presubmit_path, self.committing,
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001277 self.rietveld, self.verbose)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001278 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001279 try:
1280 exec script_text in context
1281 except Exception, e:
1282 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001283
1284 # These function names must change if we make substantial changes to
1285 # the presubmit API that are not backwards compatible.
1286 if self.committing:
1287 function_name = 'CheckChangeOnCommit'
1288 else:
1289 function_name = 'CheckChangeOnUpload'
1290 if function_name in context:
wez@chromium.orga6d011e2013-03-26 17:31:49 +00001291 context['__args'] = (input_api, OutputApi(self.committing))
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001292 logging.debug('Running %s in %s' % (function_name, presubmit_path))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001293 result = eval(function_name + '(*__args)', context)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001294 logging.debug('Running %s done.' % function_name)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001295 if not (isinstance(result, types.TupleType) or
1296 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001297 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001298 'Presubmit functions must return a tuple or list')
1299 for item in result:
1300 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001301 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001302 'All presubmit results must be of types derived from '
1303 'output_api.PresubmitResult')
1304 else:
1305 result = () # no error since the script doesn't care about current event.
1306
chase@chromium.org8e416c82009-10-06 04:30:44 +00001307 # Return the process to the original working directory.
1308 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001309 return result
1310
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001311
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001312def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001313 committing,
1314 verbose,
1315 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001316 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001317 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001318 may_prompt,
maruel@chromium.org239f4112011-06-03 20:08:23 +00001319 rietveld_obj):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001320 """Runs all presubmit checks that apply to the files in the change.
1321
1322 This finds all PRESUBMIT.py files in directories enclosing the files in the
1323 change (up to the repository root) and calls the relevant entrypoint function
1324 depending on whether the change is being committed or uploaded.
1325
1326 Prints errors, warnings and notifications. Prompts the user for warnings
1327 when needed.
1328
1329 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001330 change: The Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001331 committing: True if 'gcl commit' is running, False if 'gcl upload' is.
1332 verbose: Prints debug info.
1333 output_stream: A stream to write output from presubmit tests to.
1334 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001335 default_presubmit: A default presubmit script to execute in any case.
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001336 may_prompt: Enable (y/n) questions on warning or error.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001337 rietveld_obj: rietveld.Rietveld object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001338
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001339 Warning:
1340 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1341 SHOULD be sys.stdin.
1342
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001343 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001344 A PresubmitOutput object. Use output.should_continue() to figure out
1345 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001346 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001347 old_environ = os.environ
1348 try:
1349 # Make sure python subprocesses won't generate .pyc files.
1350 os.environ = os.environ.copy()
1351 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001352
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001353 output = PresubmitOutput(input_stream, output_stream)
1354 if committing:
1355 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001356 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001357 output.write("Running presubmit upload checks ...\n")
1358 start_time = time.time()
1359 presubmit_files = ListRelevantPresubmitFiles(
1360 change.AbsoluteLocalPaths(True), change.RepositoryRoot())
1361 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001362 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001363 results = []
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001364 executer = PresubmitExecuter(change, committing, rietveld_obj, verbose)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001365 if default_presubmit:
1366 if verbose:
1367 output.write("Running default presubmit script.\n")
1368 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1369 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1370 for filename in presubmit_files:
1371 filename = os.path.abspath(filename)
1372 if verbose:
1373 output.write("Running %s\n" % filename)
1374 # Accept CRLF presubmit script.
1375 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1376 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001377
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001378 errors = []
1379 notifications = []
1380 warnings = []
1381 for result in results:
1382 if result.fatal:
1383 errors.append(result)
1384 elif result.should_prompt:
1385 warnings.append(result)
1386 else:
1387 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001388
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001389 output.write('\n')
1390 for name, items in (('Messages', notifications),
1391 ('Warnings', warnings),
1392 ('ERRORS', errors)):
1393 if items:
1394 output.write('** Presubmit %s **\n' % name)
1395 for item in items:
1396 item.handle(output)
1397 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001398
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001399 total_time = time.time() - start_time
1400 if total_time > 1.0:
1401 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001402
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001403 if not errors:
1404 if not warnings:
1405 output.write('Presubmit checks passed.\n')
1406 elif may_prompt:
1407 output.prompt_yes_no('There were presubmit warnings. '
1408 'Are you sure you wish to continue? (y/N): ')
1409 else:
1410 output.fail()
1411
1412 global _ASKED_FOR_FEEDBACK
1413 # Ask for feedback one time out of 5.
1414 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001415 output.write(
1416 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1417 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1418 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001419 _ASKED_FOR_FEEDBACK = True
1420 return output
1421 finally:
1422 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001423
1424
1425def ScanSubDirs(mask, recursive):
1426 if not recursive:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001427 return [x for x in glob.glob(mask) if '.svn' not in x and '.git' not in x]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001428 else:
1429 results = []
1430 for root, dirs, files in os.walk('.'):
1431 if '.svn' in dirs:
1432 dirs.remove('.svn')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001433 if '.git' in dirs:
1434 dirs.remove('.git')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001435 for name in files:
1436 if fnmatch.fnmatch(name, mask):
1437 results.append(os.path.join(root, name))
1438 return results
1439
1440
1441def ParseFiles(args, recursive):
maruel@chromium.org7444c502011-02-09 14:02:11 +00001442 logging.debug('Searching for %s' % args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001443 files = []
1444 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001445 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001446 return files
1447
1448
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001449def load_files(options, args):
1450 """Tries to determine the SCM."""
1451 change_scm = scm.determine_scm(options.root)
1452 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001453 if args:
1454 files = ParseFiles(args, options.recursive)
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001455 if change_scm == 'svn':
1456 change_class = SvnChange
1457 if not files:
1458 files = scm.SVN.CaptureStatus([], options.root)
1459 elif change_scm == 'git':
1460 change_class = GitChange
1461 # TODO(maruel): Get upstream.
1462 if not files:
1463 files = scm.GIT.CaptureStatus([], options.root, None)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001464 else:
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001465 logging.info('Doesn\'t seem under source control. Got %d files' % len(args))
1466 if not files:
1467 return None, None
1468 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001469 return change_class, files
1470
1471
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001472class NonexistantCannedCheckFilter(Exception):
1473 pass
1474
1475
1476@contextlib.contextmanager
1477def canned_check_filter(method_names):
1478 filtered = {}
1479 try:
1480 for method_name in method_names:
1481 if not hasattr(presubmit_canned_checks, method_name):
1482 raise NonexistantCannedCheckFilter(method_name)
1483 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1484 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1485 yield
1486 finally:
1487 for name, method in filtered.iteritems():
1488 setattr(presubmit_canned_checks, name, method)
1489
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001490
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001491def CallCommand(cmd_data):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001492 """Runs an external program, potentially from a child process created by the
1493 multiprocessing module.
1494
1495 multiprocessing needs a top level function with a single argument.
1496 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001497 cmd_data.kwargs['stdout'] = subprocess.PIPE
1498 cmd_data.kwargs['stderr'] = subprocess.STDOUT
1499 try:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001500 start = time.time()
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001501 (out, _), code = subprocess.communicate(cmd_data.cmd, **cmd_data.kwargs)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001502 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001503 except OSError as e:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001504 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001505 return cmd_data.message(
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001506 '%s exec failure (%4.2fs)\n %s' % (cmd_data.name, duration, e))
1507 if code != 0:
1508 return cmd_data.message(
1509 '%s (%4.2fs) failed\n%s' % (cmd_data.name, duration, out))
1510 if cmd_data.info:
1511 return cmd_data.info('%s (%4.2fs)' % (cmd_data.name, duration))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001512
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001513
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001514def Main(argv):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001515 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001516 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001517 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001518 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001519 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1520 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001521 parser.add_option("-r", "--recursive", action="store_true",
1522 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001523 parser.add_option("-v", "--verbose", action="count", default=0,
1524 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001525 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001526 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001527 parser.add_option("--description", default='')
1528 parser.add_option("--issue", type='int', default=0)
1529 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001530 parser.add_option("--root", default=os.getcwd(),
1531 help="Search for PRESUBMIT.py up to this directory. "
1532 "If inherit-review-settings-ok is present in this "
1533 "directory, parent directories up to the root file "
1534 "system directories will also be searched.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001535 parser.add_option("--default_presubmit")
1536 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001537 parser.add_option("--skip_canned", action='append', default=[],
1538 help="A list of checks to skip which appear in "
1539 "presubmit_canned_checks. Can be provided multiple times "
1540 "to skip multiple canned checks.")
maruel@chromium.org239f4112011-06-03 20:08:23 +00001541 parser.add_option("--rietveld_url", help=optparse.SUPPRESS_HELP)
1542 parser.add_option("--rietveld_email", help=optparse.SUPPRESS_HELP)
1543 parser.add_option("--rietveld_password", help=optparse.SUPPRESS_HELP)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001544 parser.add_option("--rietveld_fetch", action='store_true', default=False,
1545 help=optparse.SUPPRESS_HELP)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001546 # These are for OAuth2 authentication for bots. See also apply_issue.py
1547 parser.add_option("--rietveld_email_file", help=optparse.SUPPRESS_HELP)
1548 parser.add_option("--rietveld_private_key_file", help=optparse.SUPPRESS_HELP)
1549
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00001550 parser.add_option("--trybot-json",
1551 help="Output trybot information to the file specified.")
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001552 options, args = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001553
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001554 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001555 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001556 elif options.verbose:
1557 logging.basicConfig(level=logging.INFO)
1558 else:
1559 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001560
1561 if options.rietveld_email and options.rietveld_email_file:
1562 parser.error("Only one of --rietveld_email or --rietveld_email_file "
1563 "can be passed to this program.")
1564 if options.rietveld_private_key_file and options.rietveld_password:
1565 parser.error("Only one of --rietveld_private_key_file or "
1566 "--rietveld_password can be passed to this program.")
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001567
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001568 if options.rietveld_email_file:
1569 with open(options.rietveld_email_file, "rb") as f:
1570 options.rietveld_email = f.read().strip()
1571
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001572 change_class, files = load_files(options, args)
1573 if not change_class:
1574 parser.error('For unversioned directory, <files> is not optional.')
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001575 logging.info('Found %d file(s).' % len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001576
maruel@chromium.org239f4112011-06-03 20:08:23 +00001577 rietveld_obj = None
1578 if options.rietveld_url:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001579 # The empty password is permitted: '' is not None.
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001580 if options.rietveld_private_key_file:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001581 rietveld_obj = rietveld.JwtOAuth2Rietveld(
1582 options.rietveld_url,
1583 options.rietveld_email,
1584 options.rietveld_private_key_file)
1585 else:
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001586 rietveld_obj = rietveld.CachingRietveld(
1587 options.rietveld_url,
1588 options.rietveld_email,
1589 options.rietveld_password)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001590 if options.rietveld_fetch:
1591 assert options.issue
1592 props = rietveld_obj.get_issue_properties(options.issue, False)
1593 options.author = props['owner_email']
1594 options.description = props['description']
1595 logging.info('Got author: "%s"', options.author)
1596 logging.info('Got description: """\n%s\n"""', options.description)
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00001597 if options.trybot_json:
1598 with open(options.trybot_json, 'w') as f:
1599 # Python's sets aren't JSON-encodable, so we convert them to lists here.
1600 class SetEncoder(json.JSONEncoder):
1601 # pylint: disable=E0202
1602 def default(self, obj):
1603 if isinstance(obj, set):
1604 return sorted(obj)
1605 return json.JSONEncoder.default(self, obj)
1606 change = change_class(options.name,
1607 options.description,
1608 options.root,
1609 files,
1610 options.issue,
1611 options.patchset,
1612 options.author)
1613 trybots = DoGetTrySlaves(
1614 change,
1615 change.LocalPaths(),
1616 change.RepositoryRoot(),
1617 None,
1618 None,
1619 options.verbose,
1620 sys.stdout)
1621 json.dump(trybots, f, cls=SetEncoder)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001622 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001623 with canned_check_filter(options.skip_canned):
1624 results = DoPresubmitChecks(
1625 change_class(options.name,
1626 options.description,
1627 options.root,
1628 files,
1629 options.issue,
1630 options.patchset,
1631 options.author),
1632 options.commit,
1633 options.verbose,
1634 sys.stdout,
1635 sys.stdin,
1636 options.default_presubmit,
1637 options.may_prompt,
1638 rietveld_obj)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001639 return not results.should_continue()
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001640 except NonexistantCannedCheckFilter, e:
1641 print >> sys.stderr, (
1642 'Attempted to skip nonexistent canned presubmit check: %s' % e.message)
1643 return 2
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001644 except PresubmitFailure, e:
1645 print >> sys.stderr, e
1646 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
1647 print >> sys.stderr, 'If all fails, contact maruel@'
1648 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001649
1650
1651if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001652 fix_encoding.fix_encoding()
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001653 sys.exit(Main(None))