blob: 0da80ff77c8463a31e0e9605e28b425f8e4bddb9 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090015import ast # Exposed through the API.
enne@chromium.orge72c5f52013-04-16 00:36:40 +000016import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000017import cPickle # Exposed through the API.
18import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
dcheng091b7db2016-06-16 01:27:51 -070020import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000021import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000022import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000023import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000024import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000025import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000026import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import optparse
29import os # Somewhat exposed through the API.
30import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000031import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040033import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000034import sys # Parts exposed through API.
35import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040036import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000037import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000038import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000040import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000041import urllib2 # Exposed through the API.
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000042import urlparse
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000043from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000044
45# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000046import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000047import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070048import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000049import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000050import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020051import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000052import presubmit_canned_checks
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000053import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000054import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000055
56
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000057# Ask for feedback only once in program lifetime.
58_ASKED_FOR_FEEDBACK = False
59
60
maruel@chromium.org899e1c12011-04-07 17:03:18 +000061class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000062 pass
63
64
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000065class CommandData(object):
66 def __init__(self, name, cmd, kwargs, message):
67 self.name = name
68 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040069 self.stdin = kwargs.get('stdin', None)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000070 self.kwargs = kwargs
Edward Lesmes8e282792018-04-03 18:50:29 -040071 self.kwargs['stdout'] = subprocess.PIPE
72 self.kwargs['stderr'] = subprocess.STDOUT
73 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000074 self.message = message
75 self.info = None
76
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000077
Edward Lesmes8e282792018-04-03 18:50:29 -040078# Adapted from
79# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
80#
81# An object that catches SIGINT sent to the Python process and notices
82# if processes passed to wait() die by SIGINT (we need to look for
83# both of those cases, because pressing Ctrl+C can result in either
84# the main process or one of the subprocesses getting the signal).
85#
86# Before a SIGINT is seen, wait(p) will simply call p.wait() and
87# return the result. Once a SIGINT has been seen (in the main process
88# or a subprocess, including the one the current call is waiting for),
89# wait(p) will call p.terminate() and raise ProcessWasInterrupted.
90class SigintHandler(object):
91 class ProcessWasInterrupted(Exception):
92 pass
93
94 sigint_returncodes = {-signal.SIGINT, # Unix
95 -1073741510, # Windows
96 }
97 def __init__(self):
98 self.__lock = threading.Lock()
99 self.__processes = set()
100 self.__got_sigint = False
101 signal.signal(signal.SIGINT, lambda signal_num, frame: self.interrupt())
102
103 def __on_sigint(self):
104 self.__got_sigint = True
105 while self.__processes:
106 try:
107 self.__processes.pop().terminate()
108 except OSError:
109 pass
110
111 def interrupt(self):
112 with self.__lock:
113 self.__on_sigint()
114
115 def got_sigint(self):
116 with self.__lock:
117 return self.__got_sigint
118
119 def wait(self, p, stdin):
120 with self.__lock:
121 if self.__got_sigint:
122 p.terminate()
123 self.__processes.add(p)
124 stdout, stderr = p.communicate(stdin)
125 code = p.returncode
126 with self.__lock:
127 self.__processes.discard(p)
128 if code in self.sigint_returncodes:
129 self.__on_sigint()
130 if self.__got_sigint:
131 raise self.ProcessWasInterrupted
132 return stdout, stderr
133
134sigint_handler = SigintHandler()
135
136
137class ThreadPool(object):
138 def __init__(self, pool_size=None):
139 self._pool_size = pool_size or multiprocessing.cpu_count()
140 self._messages = []
141 self._messages_lock = threading.Lock()
142 self._tests = []
143 self._tests_lock = threading.Lock()
144 self._nonparallel_tests = []
145
146 def CallCommand(self, test):
147 """Runs an external program.
148
149 This function converts invocation of .py files and invocations of "python"
150 to vpython invocations.
151 """
152 vpython = 'vpython.bat' if sys.platform == 'win32' else 'vpython'
153
154 cmd = test.cmd
155 if cmd[0] == 'python':
156 cmd = list(cmd)
157 cmd[0] = vpython
158 elif cmd[0].endswith('.py'):
159 cmd = [vpython] + cmd
160
161 try:
162 start = time.time()
163 p = subprocess.Popen(cmd, **test.kwargs)
164 stdout, _ = sigint_handler.wait(p, test.stdin)
165 duration = time.time() - start
166 except OSError as e:
167 duration = time.time() - start
168 return test.message(
169 '%s exec failure (%4.2fs)\n %s' % (test.name, duration, e))
170 if p.returncode != 0:
171 return test.message(
172 '%s (%4.2fs) failed\n%s' % (test.name, duration, stdout))
173 if test.info:
174 return test.info('%s (%4.2fs)' % (test.name, duration))
175
176 def AddTests(self, tests, parallel=True):
177 if parallel:
178 self._tests.extend(tests)
179 else:
180 self._nonparallel_tests.extend(tests)
181
182 def RunAsync(self):
183 self._messages = []
184
185 def _WorkerFn():
186 while True:
187 test = None
188 with self._tests_lock:
189 if not self._tests:
190 break
191 test = self._tests.pop()
192 result = self.CallCommand(test)
193 if result:
194 with self._messages_lock:
195 self._messages.append(result)
196
197 def _StartDaemon():
198 t = threading.Thread(target=_WorkerFn)
199 t.daemon = True
200 t.start()
201 return t
202
203 while self._nonparallel_tests:
204 test = self._nonparallel_tests.pop()
205 result = self.CallCommand(test)
206 if result:
207 self._messages.append(result)
208
209 if self._tests:
210 threads = [_StartDaemon() for _ in range(self._pool_size)]
211 for worker in threads:
212 worker.join()
213
214 return self._messages
215
216
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000217def normpath(path):
218 '''Version of os.path.normpath that also changes backward slashes to
219 forward slashes when not running on Windows.
220 '''
221 # This is safe to always do because the Windows version of os.path.normpath
222 # will replace forward slashes with backward slashes.
223 path = path.replace(os.sep, '/')
224 return os.path.normpath(path)
225
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000226
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000227def _RightHandSideLinesImpl(affected_files):
228 """Implements RightHandSideLines for InputApi and GclChange."""
229 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000230 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000231 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000232 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000233
234
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000235class PresubmitOutput(object):
236 def __init__(self, input_stream=None, output_stream=None):
237 self.input_stream = input_stream
238 self.output_stream = output_stream
239 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -0800240 self.more_cc = []
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000241 self.written_output = []
242 self.error_count = 0
243
244 def prompt_yes_no(self, prompt_string):
245 self.write(prompt_string)
246 if self.input_stream:
247 response = self.input_stream.readline().strip().lower()
248 if response not in ('y', 'yes'):
249 self.fail()
250 else:
251 self.fail()
252
253 def fail(self):
254 self.error_count += 1
255
256 def should_continue(self):
257 return not self.error_count
258
259 def write(self, s):
260 self.written_output.append(s)
261 if self.output_stream:
262 self.output_stream.write(s)
263
264 def getvalue(self):
265 return ''.join(self.written_output)
266
267
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000268# Top level object so multiprocessing can pickle
269# Public access through OutputApi object.
270class _PresubmitResult(object):
271 """Base class for result objects."""
272 fatal = False
273 should_prompt = False
274
275 def __init__(self, message, items=None, long_text=''):
276 """
277 message: A short one-line message to indicate errors.
278 items: A list of short strings to indicate where errors occurred.
279 long_text: multi-line text output, e.g. from another tool
280 """
281 self._message = message
282 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000283 self._long_text = long_text.rstrip()
284
285 def handle(self, output):
286 output.write(self._message)
287 output.write('\n')
288 for index, item in enumerate(self._items):
289 output.write(' ')
290 # Write separately in case it's unicode.
291 output.write(str(item))
292 if index < len(self._items) - 1:
293 output.write(' \\')
294 output.write('\n')
295 if self._long_text:
296 output.write('\n***************\n')
297 # Write separately in case it's unicode.
298 output.write(self._long_text)
299 output.write('\n***************\n')
300 if self.fatal:
301 output.fail()
302
303
304# Top level object so multiprocessing can pickle
305# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000306class _PresubmitError(_PresubmitResult):
307 """A hard presubmit error."""
308 fatal = True
309
310
311# Top level object so multiprocessing can pickle
312# Public access through OutputApi object.
313class _PresubmitPromptWarning(_PresubmitResult):
314 """An warning that prompts the user if they want to continue."""
315 should_prompt = True
316
317
318# Top level object so multiprocessing can pickle
319# Public access through OutputApi object.
320class _PresubmitNotifyResult(_PresubmitResult):
321 """Just print something to the screen -- but it's not even a warning."""
322 pass
323
324
325# Top level object so multiprocessing can pickle
326# Public access through OutputApi object.
327class _MailTextResult(_PresubmitResult):
328 """A warning that should be included in the review request email."""
329 def __init__(self, *args, **kwargs):
330 super(_MailTextResult, self).__init__()
331 raise NotImplementedError()
332
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000333class GerritAccessor(object):
334 """Limited Gerrit functionality for canned presubmit checks to work.
335
336 To avoid excessive Gerrit calls, caches the results.
337 """
338
339 def __init__(self, host):
340 self.host = host
341 self.cache = {}
342
343 def _FetchChangeDetail(self, issue):
344 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100345 try:
346 return gerrit_util.GetChangeDetail(
347 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700348 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100349 except gerrit_util.GerritError as e:
350 if e.http_status == 404:
351 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
352 'no credentials to fetch issue details' % issue)
353 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000354
355 def GetChangeInfo(self, issue):
356 """Returns labels and all revisions (patchsets) for this issue.
357
358 The result is a dictionary according to Gerrit REST Api.
359 https://gerrit-review.googlesource.com/Documentation/rest-api.html
360
361 However, API isn't very clear what's inside, so see tests for example.
362 """
363 assert issue
364 cache_key = int(issue)
365 if cache_key not in self.cache:
366 self.cache[cache_key] = self._FetchChangeDetail(issue)
367 return self.cache[cache_key]
368
369 def GetChangeDescription(self, issue, patchset=None):
370 """If patchset is none, fetches current patchset."""
371 info = self.GetChangeInfo(issue)
372 # info is a reference to cache. We'll modify it here adding description to
373 # it to the right patchset, if it is not yet there.
374
375 # Find revision info for the patchset we want.
376 if patchset is not None:
377 for rev, rev_info in info['revisions'].iteritems():
378 if str(rev_info['_number']) == str(patchset):
379 break
380 else:
381 raise Exception('patchset %s doesn\'t exist in issue %s' % (
382 patchset, issue))
383 else:
384 rev = info['current_revision']
385 rev_info = info['revisions'][rev]
386
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100387 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000388
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800389 def GetDestRef(self, issue):
390 ref = self.GetChangeInfo(issue)['branch']
391 if not ref.startswith('refs/'):
392 # NOTE: it is possible to create 'refs/x' branch,
393 # aka 'refs/heads/refs/x'. However, this is ill-advised.
394 ref = 'refs/heads/%s' % ref
395 return ref
396
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000397 def GetChangeOwner(self, issue):
398 return self.GetChangeInfo(issue)['owner']['email']
399
400 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700401 changeinfo = self.GetChangeInfo(issue)
402 if approving_only:
403 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
404 values = labelinfo.get('values', {}).keys()
405 try:
406 max_value = max(int(v) for v in values)
407 reviewers = [r for r in labelinfo.get('all', [])
408 if r.get('value', 0) == max_value]
409 except ValueError: # values is the empty list
410 reviewers = []
411 else:
412 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
413 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000414
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000415
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000416class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000417 """An instance of OutputApi gets passed to presubmit scripts so that they
418 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000419 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000420 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000421 PresubmitError = _PresubmitError
422 PresubmitPromptWarning = _PresubmitPromptWarning
423 PresubmitNotifyResult = _PresubmitNotifyResult
424 MailTextResult = _MailTextResult
425
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000426 def __init__(self, is_committing):
427 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800428 self.more_cc = []
429
430 def AppendCC(self, cc):
431 """Appends a user to cc for this change."""
432 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000433
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000434 def PresubmitPromptOrNotify(self, *args, **kwargs):
435 """Warn the user when uploading, but only notify if committing."""
436 if self.is_committing:
437 return self.PresubmitNotifyResult(*args, **kwargs)
438 return self.PresubmitPromptWarning(*args, **kwargs)
439
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800440 def EnsureCQIncludeTrybotsAreAdded(self, cl, bots_to_include, message):
441 """Helper for any PostUploadHook wishing to add CQ_INCLUDE_TRYBOTS.
442
443 Merges the bots_to_include into the current CQ_INCLUDE_TRYBOTS list,
444 keeping it alphabetically sorted. Returns the results that should be
445 returned from the PostUploadHook.
446
447 Args:
448 cl: The git_cl.Changelist object.
449 bots_to_include: A list of strings of bots to include, in the form
450 "master:slave".
451 message: A message to be printed in the case that
452 CQ_INCLUDE_TRYBOTS was updated.
453 """
454 description = cl.GetDescription(force=True)
Aaron Gableb584c4f2017-04-26 16:28:08 -0700455 include_re = re.compile(r'^CQ_INCLUDE_TRYBOTS=(.*)$', re.M | re.I)
456
457 prior_bots = []
458 if cl.IsGerrit():
459 trybot_footers = git_footers.parse_footers(description).get(
460 git_footers.normalize_name('Cq-Include-Trybots'), [])
461 for f in trybot_footers:
462 prior_bots += [b.strip() for b in f.split(';') if b.strip()]
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800463 else:
Aaron Gableb584c4f2017-04-26 16:28:08 -0700464 trybot_tags = include_re.finditer(description)
465 for t in trybot_tags:
466 prior_bots += [b.strip() for b in t.group(1).split(';') if b.strip()]
467
468 if set(prior_bots) >= set(bots_to_include):
469 return []
470 all_bots = ';'.join(sorted(set(prior_bots) | set(bots_to_include)))
471
472 if cl.IsGerrit():
473 description = git_footers.remove_footer(
474 description, 'Cq-Include-Trybots')
475 description = git_footers.add_footer(
476 description, 'Cq-Include-Trybots', all_bots,
477 before_keys=['Change-Id'])
478 else:
479 new_include_trybots = 'CQ_INCLUDE_TRYBOTS=%s' % all_bots
480 m = include_re.search(description)
481 if m:
482 description = include_re.sub(new_include_trybots, description)
Kenneth Russelldf6e7342017-04-24 17:07:41 -0700483 else:
Aaron Gableb584c4f2017-04-26 16:28:08 -0700484 description = '%s\n%s\n' % (description, new_include_trybots)
485
486 cl.UpdateDescription(description, force=True)
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800487 return [self.PresubmitNotifyResult(message)]
488
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000489
490class InputApi(object):
491 """An instance of this object is passed to presubmit scripts so they can
492 know stuff about the change they're looking at.
493 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000494 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800495 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000496
maruel@chromium.org3410d912009-06-09 20:56:16 +0000497 # File extensions that are considered source files from a style guide
498 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000499 #
500 # Files without an extension aren't included in the list. If you want to
501 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
502 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000503 DEFAULT_WHITE_LIST = (
504 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000505 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
506 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000507 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000508 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000509 # Other
Sergey Ulanov166bc4c2018-04-30 17:03:38 -0700510 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$", r".+\.mojom$",
511 r".+\.fidl$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000512 )
513
514 # Path regexp that should be excluded from being considered containing source
515 # files. Don't modify this list from a presubmit script!
516 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000517 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000518 r".*\bexperimental[\\\/].*",
Kent Tamura179dd1e2018-04-26 15:07:41 +0900519 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
520 # (crbug.com/539768 and crbug.com/836555).
521 r".*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000522 # Output directories (just in case)
523 r".*\bDebug[\\\/].*",
524 r".*\bRelease[\\\/].*",
525 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000526 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000527 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000528 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000529 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000530 r"(|.*[\\\/])\.git[\\\/].*",
531 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000532 # There is no point in processing a patch file.
533 r".+\.diff$",
534 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000535 )
536
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000537 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400538 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000539 """Builds an InputApi object.
540
541 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000542 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000543 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000544 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000545 gerrit_obj: provides basic Gerrit codereview functionality.
546 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400547 parallel: if true, all tests reported via input_api.RunTests for all
548 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000549 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000550 # Version number of the presubmit_support script.
551 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000552 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000553 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000554 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000555 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000556
Edward Lesmes8e282792018-04-03 18:50:29 -0400557 self.parallel = parallel
558 self.thread_pool = thread_pool or ThreadPool()
559
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000560 # We expose various modules and functions as attributes of the input_api
561 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900562 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000563 self.basename = os.path.basename
564 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000565 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000566 self.cStringIO = cStringIO
dcheng091b7db2016-06-16 01:27:51 -0700567 self.fnmatch = fnmatch
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000568 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000569 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000570 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000571 self.os_listdir = os.listdir
572 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000573 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000574 self.os_stat = os.stat
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000575 self.pickle = pickle
576 self.marshal = marshal
577 self.re = re
578 self.subprocess = subprocess
579 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000580 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000581 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000582 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000583 self.urllib2 = urllib2
584
Robert Iannucci50258932018-03-19 10:30:59 -0700585 self.is_windows = sys.platform == 'win32'
586
587 # Set python_executable to 'python'. This is interpreted in CallCommand to
588 # convert to vpython in order to allow scripts in other repos (e.g. src.git)
589 # to automatically pick up that repo's .vpython file, instead of inheriting
590 # the one in depot_tools.
591 self.python_executable = 'python'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000592 self.environ = os.environ
593
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000594 # InputApi.platform is the platform you're currently running on.
595 self.platform = sys.platform
596
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000597 self.cpu_count = multiprocessing.cpu_count()
598
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000599 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000600 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000601
602 # We carry the canned checks so presubmit scripts can easily use them.
603 self.canned_checks = presubmit_canned_checks
604
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100605 # Temporary files we must manually remove at the end of a run.
606 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200607
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000608 # TODO(dpranke): figure out a list of all approved owners for a repo
609 # in order to be able to handle wildcard OWNERS files?
610 self.owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +0200611 fopen=file, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200612 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000613 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000614 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000615
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000616 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000617 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000618 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800619 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000620 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000621 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000622 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
623 for (a, b, header) in cpplint._re_pattern_templates
624 ]
625
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000626 def PresubmitLocalPath(self):
627 """Returns the local path of the presubmit script currently being run.
628
629 This is useful if you don't want to hard-code absolute paths in the
630 presubmit script. For example, It can be used to find another file
631 relative to the PRESUBMIT.py script, so the whole tree can be branched and
632 the presubmit script still works, without editing its content.
633 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000634 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000635
agable0b65e732016-11-22 09:25:46 -0800636 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000637 """Same as input_api.change.AffectedFiles() except only lists files
638 (and optionally directories) in the same directory as the current presubmit
639 script, or subdirectories thereof.
640 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000641 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000642 if len(dir_with_slash) == 1:
643 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000644
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000645 return filter(
646 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
agable0b65e732016-11-22 09:25:46 -0800647 self.change.AffectedFiles(include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000648
agable0b65e732016-11-22 09:25:46 -0800649 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000650 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800651 paths = [af.LocalPath() for af in self.AffectedFiles()]
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000652 logging.debug("LocalPaths: %s", paths)
653 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000654
agable0b65e732016-11-22 09:25:46 -0800655 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000656 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800657 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000658
John Budorick16162372018-04-18 10:39:53 -0700659 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800660 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000661 in the same directory as the current presubmit script, or subdirectories
662 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000663 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000664 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800665 warn("AffectedTestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000666 " is deprecated and ignored" % str(include_deletes),
667 category=DeprecationWarning,
668 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -0800669 return filter(lambda x: x.IsTestableFile(),
John Budorick16162372018-04-18 10:39:53 -0700670 self.AffectedFiles(include_deletes=False, **kwargs))
agable0b65e732016-11-22 09:25:46 -0800671
672 def AffectedTextFiles(self, include_deletes=None):
673 """An alias to AffectedTestableFiles for backwards compatibility."""
674 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000675
maruel@chromium.org3410d912009-06-09 20:56:16 +0000676 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
677 """Filters out files that aren't considered "source file".
678
679 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
680 and InputApi.DEFAULT_BLACK_LIST is used respectively.
681
682 The lists will be compiled as regular expression and
683 AffectedFile.LocalPath() needs to pass both list.
684
685 Note: Copy-paste this function to suit your needs or use a lambda function.
686 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000687 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000688 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000689 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000690 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000691 return True
692 return False
693 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
694 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
695
696 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800697 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000698
699 If source_file is None, InputApi.FilterSourceFile() is used.
700 """
701 if not source_file:
702 source_file = self.FilterSourceFile
agable0b65e732016-11-22 09:25:46 -0800703 return filter(source_file, self.AffectedTestableFiles())
maruel@chromium.org3410d912009-06-09 20:56:16 +0000704
705 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000706 """An iterator over all text lines in "new" version of changed files.
707
708 Only lists lines from new or modified text files in the change that are
709 contained by the directory of the currently executing presubmit script.
710
711 This is useful for doing line-by-line regex checks, like checking for
712 trailing whitespace.
713
714 Yields:
715 a 3 tuple:
716 the AffectedFile instance of the current file;
717 integer line number (1-based); and
718 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000719
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000720 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000721 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000722 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000723 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000724
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000725 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000726 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000727
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000728 Deny reading anything outside the repository.
729 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000730 if isinstance(file_item, AffectedFile):
731 file_item = file_item.AbsoluteLocalPath()
732 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000733 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000734 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000735
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100736 def CreateTemporaryFile(self, **kwargs):
737 """Returns a named temporary file that must be removed with a call to
738 RemoveTemporaryFiles().
739
740 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
741 except for |delete|, which is always set to False.
742
743 Presubmit checks that need to create a temporary file and pass it for
744 reading should use this function instead of NamedTemporaryFile(), as
745 Windows fails to open a file that is already open for writing.
746
747 with input_api.CreateTemporaryFile() as f:
748 f.write('xyz')
749 f.close()
750 input_api.subprocess.check_output(['script-that', '--reads-from',
751 f.name])
752
753
754 Note that callers of CreateTemporaryFile() should not worry about removing
755 any temporary file; this is done transparently by the presubmit handling
756 code.
757 """
758 if 'delete' in kwargs:
759 # Prevent users from passing |delete|; we take care of file deletion
760 # ourselves and this prevents unintuitive error messages when we pass
761 # delete=False and 'delete' is also in kwargs.
762 raise TypeError('CreateTemporaryFile() does not take a "delete" '
763 'argument, file deletion is handled automatically by '
764 'the same presubmit_support code that creates InputApi '
765 'objects.')
766 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
767 self._named_temporary_files.append(temp_file.name)
768 return temp_file
769
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000770 @property
771 def tbr(self):
772 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400773 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000774
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000775 def RunTests(self, tests_mix, parallel=True):
Edward Lesmes8e282792018-04-03 18:50:29 -0400776 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
777 # will run all tests once all PRESUBMIT files are processed.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000778 tests = []
779 msgs = []
780 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400781 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000782 msgs.append(t)
783 else:
784 assert issubclass(t.message, _PresubmitResult)
785 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000786 if self.verbose:
787 t.info = _PresubmitNotifyResult
Edward Lesmes8e282792018-04-03 18:50:29 -0400788 t.kwargs['cwd'] = self.PresubmitLocalPath()
789 self.thread_pool.AddTests(tests, parallel)
790 if not self.parallel:
791 msgs.extend(self.thread_pool.RunAsync())
792 return msgs
scottmg86099d72016-09-01 09:16:51 -0700793
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000794
nick@chromium.orgff526192013-06-10 19:30:26 +0000795class _DiffCache(object):
796 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000797 def __init__(self, upstream=None):
798 """Stores the upstream revision against which all diffs will be computed."""
799 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000800
801 def GetDiff(self, path, local_root):
802 """Get the diff for a particular path."""
803 raise NotImplementedError()
804
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700805 def GetOldContents(self, path, local_root):
806 """Get the old version for a particular path."""
807 raise NotImplementedError()
808
nick@chromium.orgff526192013-06-10 19:30:26 +0000809
nick@chromium.orgff526192013-06-10 19:30:26 +0000810class _GitDiffCache(_DiffCache):
811 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000812 def __init__(self, upstream):
813 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000814 self._diffs_by_file = None
815
816 def GetDiff(self, path, local_root):
817 if not self._diffs_by_file:
818 # Compute a single diff for all files and parse the output; should
819 # with git this is much faster than computing one diff for each file.
820 diffs = {}
821
822 # Don't specify any filenames below, because there are command line length
823 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000824 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
825 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000826
827 # This regex matches the path twice, separated by a space. Note that
828 # filename itself may contain spaces.
829 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
830 current_diff = []
831 keep_line_endings = True
832 for x in unified_diff.splitlines(keep_line_endings):
833 match = file_marker.match(x)
834 if match:
835 # Marks the start of a new per-file section.
836 diffs[match.group('filename')] = current_diff = [x]
837 elif x.startswith('diff --git'):
838 raise PresubmitFailure('Unexpected diff line: %s' % x)
839 else:
840 current_diff.append(x)
841
842 self._diffs_by_file = dict(
843 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
844
845 if path not in self._diffs_by_file:
846 raise PresubmitFailure(
847 'Unified diff did not contain entry for file %s' % path)
848
849 return self._diffs_by_file[path]
850
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700851 def GetOldContents(self, path, local_root):
852 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
853
nick@chromium.orgff526192013-06-10 19:30:26 +0000854
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000855class AffectedFile(object):
856 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000857
858 DIFF_CACHE = _DiffCache
859
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000860 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800861 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000862 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000863 self._path = path
864 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000865 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000866 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000867 self._cached_changed_contents = None
868 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000869 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700870 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000871
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000872 def LocalPath(self):
873 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400874
875 This should be used for error messages but not for accessing files,
876 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
877 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000878 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000879 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000880
881 def AbsoluteLocalPath(self):
882 """Returns the absolute path of this file on the local disk.
883 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000884 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000885
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000886 def Action(self):
887 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000888 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000889
agable0b65e732016-11-22 09:25:46 -0800890 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000891 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000892
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000893 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000894 raise NotImplementedError() # Implement when needed
895
agable0b65e732016-11-22 09:25:46 -0800896 def IsTextFile(self):
897 """An alias to IsTestableFile for backwards compatibility."""
898 return self.IsTestableFile()
899
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700900 def OldContents(self):
901 """Returns an iterator over the lines in the old version of file.
902
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700903 The old version is the file before any modifications in the user's
904 workspace, i.e. the "left hand side".
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700905
906 Contents will be empty if the file is a directory or does not exist.
907 Note: The carriage returns (LF or CR) are stripped off.
908 """
909 return self._diff_cache.GetOldContents(self.LocalPath(),
910 self._local_root).splitlines()
911
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000912 def NewContents(self):
913 """Returns an iterator over the lines in the new version of file.
914
915 The new version is the file in the user's workspace, i.e. the "right hand
916 side".
917
918 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000919 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000920 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000921 if self._cached_new_contents is None:
922 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800923 try:
924 self._cached_new_contents = gclient_utils.FileRead(
925 self.AbsoluteLocalPath(), 'rU').splitlines()
926 except IOError:
927 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000928 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000929
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000930 def ChangedContents(self):
931 """Returns a list of tuples (line number, line text) of all new lines.
932
933 This relies on the scm diff output describing each changed code section
934 with a line of the form
935
936 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
937 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000938 if self._cached_changed_contents is not None:
939 return self._cached_changed_contents[:]
940 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000941 line_num = 0
942
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000943 for line in self.GenerateScmDiff().splitlines():
944 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
945 if m:
946 line_num = int(m.groups(1)[0])
947 continue
948 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000949 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000950 if not line.startswith('-'):
951 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000952 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000953
maruel@chromium.org5de13972009-06-10 18:16:06 +0000954 def __str__(self):
955 return self.LocalPath()
956
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000957 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000958 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000959
maruel@chromium.org58407af2011-04-12 23:15:57 +0000960
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000961class GitAffectedFile(AffectedFile):
962 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000963 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800964 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000965
nick@chromium.orgff526192013-06-10 19:30:26 +0000966 DIFF_CACHE = _GitDiffCache
967
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000968 def __init__(self, *args, **kwargs):
969 AffectedFile.__init__(self, *args, **kwargs)
970 self._server_path = None
agable0b65e732016-11-22 09:25:46 -0800971 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000972
agable0b65e732016-11-22 09:25:46 -0800973 def IsTestableFile(self):
974 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000975 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -0800976 # A deleted file is not testable.
977 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000978 else:
agable0b65e732016-11-22 09:25:46 -0800979 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
980 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000981
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000982
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000983class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000984 """Describe a change.
985
986 Used directly by the presubmit scripts to query the current change being
987 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000988
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000989 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000990 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000991 self.KEY: equivalent to tags['KEY']
992 """
993
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000994 _AFFECTED_FILES = AffectedFile
995
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000996 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000997 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000998 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000999 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001000
maruel@chromium.org58407af2011-04-12 23:15:57 +00001001 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001002 self, name, description, local_root, files, issue, patchset, author,
1003 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001004 if files is None:
1005 files = []
1006 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001007 # Convert root into an absolute path.
1008 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001009 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001010 self.issue = issue
1011 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001012 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001013
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001014 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001015 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001016 self._description_without_tags = ''
1017 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001018
maruel@chromium.orge085d812011-10-10 19:49:15 +00001019 assert all(
1020 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1021
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001022 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001023 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001024 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1025 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001026 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001027
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001028 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001029 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001030 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001031
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001032 def DescriptionText(self):
1033 """Returns the user-entered changelist description, minus tags.
1034
1035 Any line in the user-provided description starting with e.g. "FOO="
1036 (whitespace permitted before and around) is considered a tag line. Such
1037 lines are stripped out of the description this function returns.
1038 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001039 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001040
1041 def FullDescriptionText(self):
1042 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001043 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001044
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001045 def SetDescriptionText(self, description):
1046 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001047
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001048 Also updates the list of tags."""
1049 self._full_description = description
1050
1051 # From the description text, build up a dictionary of key/value pairs
1052 # plus the description minus all key/value or "tag" lines.
1053 description_without_tags = []
1054 self.tags = {}
1055 for line in self._full_description.splitlines():
1056 m = self.TAG_LINE_RE.match(line)
1057 if m:
1058 self.tags[m.group('key')] = m.group('value')
1059 else:
1060 description_without_tags.append(line)
1061
1062 # Change back to text and remove whitespace at end.
1063 self._description_without_tags = (
1064 '\n'.join(description_without_tags).rstrip())
1065
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001066 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001067 """Returns the repository (checkout) root directory for this change,
1068 as an absolute path.
1069 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001070 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001071
1072 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001073 """Return tags directly as attributes on the object."""
1074 if not re.match(r"^[A-Z_]*$", attr):
1075 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001076 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001077
Aaron Gablefc03e672017-05-15 14:09:42 -07001078 def BugsFromDescription(self):
1079 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001080 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
1081 footers = git_footers.parse_footers(self._full_description).get('Bug', [])
1082 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001083
1084 def ReviewersFromDescription(self):
1085 """Returns all reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001086 # We don't support a "R:" git-footer for reviewers; that is in metadata.
1087 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1088 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001089
1090 def TBRsFromDescription(self):
1091 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001092 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1093 # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically
1094 # determined by self-CR+1s.
1095 footers = git_footers.parse_footers(self._full_description).get('Tbr', [])
1096 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001097
1098 # TODO(agable): Delete these once we're sure they're unused.
1099 @property
1100 def BUG(self):
1101 return ','.join(self.BugsFromDescription())
1102 @property
1103 def R(self):
1104 return ','.join(self.ReviewersFromDescription())
1105 @property
1106 def TBR(self):
1107 return ','.join(self.TBRsFromDescription())
1108
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001109 def AllFiles(self, root=None):
1110 """List all files under source control in the repo."""
1111 raise NotImplementedError()
1112
agable0b65e732016-11-22 09:25:46 -08001113 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001114 """Returns a list of AffectedFile instances for all files in the change.
1115
1116 Args:
1117 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001118 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001119
1120 Returns:
1121 [AffectedFile(path, action), AffectedFile(path, action)]
1122 """
agable0b65e732016-11-22 09:25:46 -08001123 affected = filter(file_filter, self._affected_files)
sail@chromium.org5538e022011-05-12 17:53:16 +00001124
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001125 if include_deletes:
1126 return affected
Lei Zhang9611c4c2017-04-04 01:41:56 -07001127 return filter(lambda x: x.Action() != 'D', affected)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001128
John Budorick16162372018-04-18 10:39:53 -07001129 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001130 """Return a list of the existing text files in a change."""
1131 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -08001132 warn("AffectedTeestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001133 " is deprecated and ignored" % str(include_deletes),
1134 category=DeprecationWarning,
1135 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -08001136 return filter(lambda x: x.IsTestableFile(),
John Budorick16162372018-04-18 10:39:53 -07001137 self.AffectedFiles(include_deletes=False, **kwargs))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001138
agable0b65e732016-11-22 09:25:46 -08001139 def AffectedTextFiles(self, include_deletes=None):
1140 """An alias to AffectedTestableFiles for backwards compatibility."""
1141 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001142
agable0b65e732016-11-22 09:25:46 -08001143 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001144 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001145 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001146
agable0b65e732016-11-22 09:25:46 -08001147 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001148 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001149 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001150
1151 def RightHandSideLines(self):
1152 """An iterator over all text lines in "new" version of changed files.
1153
1154 Lists lines from new or modified text files in the change.
1155
1156 This is useful for doing line-by-line regex checks, like checking for
1157 trailing whitespace.
1158
1159 Yields:
1160 a 3 tuple:
1161 the AffectedFile instance of the current file;
1162 integer line number (1-based); and
1163 the contents of the line as a string.
1164 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001165 return _RightHandSideLinesImpl(
1166 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001167 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001168
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001169 def OriginalOwnersFiles(self):
1170 """A map from path names of affected OWNERS files to their old content."""
1171 def owners_file_filter(f):
1172 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1173 files = self.AffectedFiles(file_filter=owners_file_filter)
1174 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1175
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001176
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001177class GitChange(Change):
1178 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001179 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001180
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001181 def AllFiles(self, root=None):
1182 """List all files under source control in the repo."""
1183 root = root or self.RepositoryRoot()
1184 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001185 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1186 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001187
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001188
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001189def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001190 """Finds all presubmit files that apply to a given set of source files.
1191
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001192 If inherit-review-settings-ok is present right under root, looks for
1193 PRESUBMIT.py in directories enclosing root.
1194
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001195 Args:
1196 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001197 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001198
1199 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001200 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001201 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001202 files = [normpath(os.path.join(root, f)) for f in files]
1203
1204 # List all the individual directories containing files.
1205 directories = set([os.path.dirname(f) for f in files])
1206
1207 # Ignore root if inherit-review-settings-ok is present.
1208 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1209 root = None
1210
1211 # Collect all unique directories that may contain PRESUBMIT.py.
1212 candidates = set()
1213 for directory in directories:
1214 while True:
1215 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001216 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001217 candidates.add(directory)
1218 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001219 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001220 parent_dir = os.path.dirname(directory)
1221 if parent_dir == directory:
1222 # We hit the system root directory.
1223 break
1224 directory = parent_dir
1225
1226 # Look for PRESUBMIT.py in all candidate directories.
1227 results = []
1228 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001229 try:
1230 for f in os.listdir(directory):
1231 p = os.path.join(directory, f)
1232 if os.path.isfile(p) and re.match(
1233 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1234 results.append(p)
1235 except OSError:
1236 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001237
tobiasjs2836bcf2016-08-16 04:08:16 -07001238 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001239 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001240
1241
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001242class GetTryMastersExecuter(object):
1243 @staticmethod
1244 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1245 """Executes GetPreferredTryMasters() from a single presubmit script.
1246
1247 Args:
1248 script_text: The text of the presubmit script.
1249 presubmit_path: Project script to run.
1250 project: Project name to pass to presubmit script for bot selection.
1251
1252 Return:
1253 A map of try masters to map of builders to set of tests.
1254 """
1255 context = {}
1256 try:
1257 exec script_text in context
1258 except Exception, e:
1259 raise PresubmitFailure('"%s" had an exception.\n%s'
1260 % (presubmit_path, e))
1261
1262 function_name = 'GetPreferredTryMasters'
1263 if function_name not in context:
1264 return {}
1265 get_preferred_try_masters = context[function_name]
1266 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1267 raise PresubmitFailure(
1268 'Expected function "GetPreferredTryMasters" to take two arguments.')
1269 return get_preferred_try_masters(project, change)
1270
1271
rmistry@google.com5626a922015-02-26 14:03:30 +00001272class GetPostUploadExecuter(object):
1273 @staticmethod
1274 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1275 """Executes PostUploadHook() from a single presubmit script.
1276
1277 Args:
1278 script_text: The text of the presubmit script.
1279 presubmit_path: Project script to run.
1280 cl: The Changelist object.
1281 change: The Change object.
1282
1283 Return:
1284 A list of results objects.
1285 """
1286 context = {}
1287 try:
1288 exec script_text in context
1289 except Exception, e:
1290 raise PresubmitFailure('"%s" had an exception.\n%s'
1291 % (presubmit_path, e))
1292
1293 function_name = 'PostUploadHook'
1294 if function_name not in context:
1295 return {}
1296 post_upload_hook = context[function_name]
1297 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1298 raise PresubmitFailure(
1299 'Expected function "PostUploadHook" to take three arguments.')
1300 return post_upload_hook(cl, change, OutputApi(False))
1301
1302
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001303def _MergeMasters(masters1, masters2):
1304 """Merges two master maps. Merges also the tests of each builder."""
1305 result = {}
1306 for (master, builders) in itertools.chain(masters1.iteritems(),
1307 masters2.iteritems()):
1308 new_builders = result.setdefault(master, {})
1309 for (builder, tests) in builders.iteritems():
1310 new_builders.setdefault(builder, set([])).update(tests)
1311 return result
1312
1313
1314def DoGetTryMasters(change,
1315 changed_files,
1316 repository_root,
1317 default_presubmit,
1318 project,
1319 verbose,
1320 output_stream):
1321 """Get the list of try masters from the presubmit scripts.
1322
1323 Args:
1324 changed_files: List of modified files.
1325 repository_root: The repository root.
1326 default_presubmit: A default presubmit script to execute in any case.
1327 project: Optional name of a project used in selecting trybots.
1328 verbose: Prints debug info.
1329 output_stream: A stream to write debug output to.
1330
1331 Return:
1332 Map of try masters to map of builders to set of tests.
1333 """
1334 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1335 if not presubmit_files and verbose:
1336 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1337 results = {}
1338 executer = GetTryMastersExecuter()
1339
1340 if default_presubmit:
1341 if verbose:
1342 output_stream.write("Running default presubmit script.\n")
1343 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1344 results = _MergeMasters(results, executer.ExecPresubmitScript(
1345 default_presubmit, fake_path, project, change))
1346 for filename in presubmit_files:
1347 filename = os.path.abspath(filename)
1348 if verbose:
1349 output_stream.write("Running %s\n" % filename)
1350 # Accept CRLF presubmit script.
1351 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1352 results = _MergeMasters(results, executer.ExecPresubmitScript(
1353 presubmit_script, filename, project, change))
1354
1355 # Make sets to lists again for later JSON serialization.
1356 for builders in results.itervalues():
1357 for builder in builders:
1358 builders[builder] = list(builders[builder])
1359
1360 if results and verbose:
1361 output_stream.write('%s\n' % str(results))
1362 return results
1363
1364
rmistry@google.com5626a922015-02-26 14:03:30 +00001365def DoPostUploadExecuter(change,
1366 cl,
1367 repository_root,
1368 verbose,
1369 output_stream):
1370 """Execute the post upload hook.
1371
1372 Args:
1373 change: The Change object.
1374 cl: The Changelist object.
1375 repository_root: The repository root.
1376 verbose: Prints debug info.
1377 output_stream: A stream to write debug output to.
1378 """
1379 presubmit_files = ListRelevantPresubmitFiles(
1380 change.LocalPaths(), repository_root)
1381 if not presubmit_files and verbose:
1382 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1383 results = []
1384 executer = GetPostUploadExecuter()
1385 # The root presubmit file should be executed after the ones in subdirectories.
1386 # i.e. the specific post upload hooks should run before the general ones.
1387 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1388 presubmit_files.reverse()
1389
1390 for filename in presubmit_files:
1391 filename = os.path.abspath(filename)
1392 if verbose:
1393 output_stream.write("Running %s\n" % filename)
1394 # Accept CRLF presubmit script.
1395 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1396 results.extend(executer.ExecPresubmitScript(
1397 presubmit_script, filename, cl, change))
1398 output_stream.write('\n')
1399 if results:
1400 output_stream.write('** Post Upload Hook Messages **\n')
1401 for result in results:
1402 result.handle(output_stream)
1403 output_stream.write('\n')
1404
1405 return results
1406
1407
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001408class PresubmitExecuter(object):
Aaron Gable668c1d82018-04-03 10:19:16 -07001409 def __init__(self, change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001410 gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001411 """
1412 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001413 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001414 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001415 gerrit_obj: provides basic Gerrit codereview functionality.
1416 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001417 parallel: if true, all tests reported via input_api.RunTests for all
1418 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001419 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001420 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001421 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001422 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001423 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001424 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001425 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001426 self.thread_pool = thread_pool
1427 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001428
1429 def ExecPresubmitScript(self, script_text, presubmit_path):
1430 """Executes a single presubmit script.
1431
1432 Args:
1433 script_text: The text of the presubmit script.
1434 presubmit_path: The path to the presubmit file (this will be reported via
1435 input_api.PresubmitLocalPath()).
1436
1437 Return:
1438 A list of result objects, empty if no problems.
1439 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001440
chase@chromium.org8e416c82009-10-06 04:30:44 +00001441 # Change to the presubmit file's directory to support local imports.
1442 main_path = os.getcwd()
1443 os.chdir(os.path.dirname(presubmit_path))
1444
1445 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001446 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001447 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001448 dry_run=self.dry_run, thread_pool=self.thread_pool,
1449 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001450 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001451 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001452 try:
1453 exec script_text in context
1454 except Exception, e:
1455 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001456
1457 # These function names must change if we make substantial changes to
1458 # the presubmit API that are not backwards compatible.
1459 if self.committing:
1460 function_name = 'CheckChangeOnCommit'
1461 else:
1462 function_name = 'CheckChangeOnUpload'
1463 if function_name in context:
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001464 try:
Daniel Cheng7227d212017-11-17 08:12:37 -08001465 context['__args'] = (input_api, output_api)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001466 logging.debug('Running %s in %s', function_name, presubmit_path)
1467 result = eval(function_name + '(*__args)', context)
1468 logging.debug('Running %s done.', function_name)
Daniel Chengd36fce42017-11-21 21:52:52 -08001469 self.more_cc.extend(output_api.more_cc)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001470 finally:
1471 map(os.remove, input_api._named_temporary_files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001472 if not (isinstance(result, types.TupleType) or
1473 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001474 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001475 'Presubmit functions must return a tuple or list')
1476 for item in result:
1477 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001478 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001479 'All presubmit results must be of types derived from '
1480 'output_api.PresubmitResult')
1481 else:
1482 result = () # no error since the script doesn't care about current event.
1483
chase@chromium.org8e416c82009-10-06 04:30:44 +00001484 # Return the process to the original working directory.
1485 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001486 return result
1487
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001488def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001489 committing,
1490 verbose,
1491 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001492 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001493 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001494 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001495 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001496 dry_run=None,
1497 parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001498 """Runs all presubmit checks that apply to the files in the change.
1499
1500 This finds all PRESUBMIT.py files in directories enclosing the files in the
1501 change (up to the repository root) and calls the relevant entrypoint function
1502 depending on whether the change is being committed or uploaded.
1503
1504 Prints errors, warnings and notifications. Prompts the user for warnings
1505 when needed.
1506
1507 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001508 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001509 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001510 verbose: Prints debug info.
1511 output_stream: A stream to write output from presubmit tests to.
1512 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001513 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001514 may_prompt: Enable (y/n) questions on warning or error. If False,
1515 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001516 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001517 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001518 parallel: if true, all tests specified by input_api.RunTests in all
1519 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001520
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001521 Warning:
1522 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1523 SHOULD be sys.stdin.
1524
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001525 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001526 A PresubmitOutput object. Use output.should_continue() to figure out
1527 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001528 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001529 old_environ = os.environ
1530 try:
1531 # Make sure python subprocesses won't generate .pyc files.
1532 os.environ = os.environ.copy()
1533 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001534
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001535 output = PresubmitOutput(input_stream, output_stream)
1536 if committing:
1537 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001538 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001539 output.write("Running presubmit upload checks ...\n")
1540 start_time = time.time()
1541 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001542 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001543 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001544 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001545 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001546 thread_pool = ThreadPool()
Aaron Gable668c1d82018-04-03 10:19:16 -07001547 executer = PresubmitExecuter(change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001548 gerrit_obj, dry_run, thread_pool)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001549 if default_presubmit:
1550 if verbose:
1551 output.write("Running default presubmit script.\n")
1552 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1553 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1554 for filename in presubmit_files:
1555 filename = os.path.abspath(filename)
1556 if verbose:
1557 output.write("Running %s\n" % filename)
1558 # Accept CRLF presubmit script.
1559 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1560 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001561
Edward Lesmes8e282792018-04-03 18:50:29 -04001562 results += thread_pool.RunAsync()
1563
Daniel Cheng7227d212017-11-17 08:12:37 -08001564 output.more_cc.extend(executer.more_cc)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001565 errors = []
1566 notifications = []
1567 warnings = []
1568 for result in results:
1569 if result.fatal:
1570 errors.append(result)
1571 elif result.should_prompt:
1572 warnings.append(result)
1573 else:
1574 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001575
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001576 output.write('\n')
1577 for name, items in (('Messages', notifications),
1578 ('Warnings', warnings),
1579 ('ERRORS', errors)):
1580 if items:
1581 output.write('** Presubmit %s **\n' % name)
1582 for item in items:
1583 item.handle(output)
1584 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001585
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001586 total_time = time.time() - start_time
1587 if total_time > 1.0:
1588 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001589
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001590 if errors:
1591 output.fail()
1592 elif warnings:
1593 output.write('There were presubmit warnings. ')
1594 if may_prompt:
1595 output.prompt_yes_no('Are you sure you wish to continue? (y/N): ')
1596 else:
1597 output.write('Presubmit checks passed.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001598
1599 global _ASKED_FOR_FEEDBACK
1600 # Ask for feedback one time out of 5.
1601 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001602 output.write(
1603 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1604 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1605 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001606 _ASKED_FOR_FEEDBACK = True
1607 return output
1608 finally:
1609 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001610
1611
1612def ScanSubDirs(mask, recursive):
1613 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001614 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001615
1616 results = []
1617 for root, dirs, files in os.walk('.'):
1618 if '.svn' in dirs:
1619 dirs.remove('.svn')
1620 if '.git' in dirs:
1621 dirs.remove('.git')
1622 for name in files:
1623 if fnmatch.fnmatch(name, mask):
1624 results.append(os.path.join(root, name))
1625 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001626
1627
1628def ParseFiles(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001629 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001630 files = []
1631 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001632 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001633 return files
1634
1635
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001636def load_files(options, args):
1637 """Tries to determine the SCM."""
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001638 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001639 if args:
1640 files = ParseFiles(args, options.recursive)
agable0b65e732016-11-22 09:25:46 -08001641 change_scm = scm.determine_scm(options.root)
1642 if change_scm == 'git':
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001643 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001644 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001645 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001646 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001647 else:
tobiasjs2836bcf2016-08-16 04:08:16 -07001648 logging.info('Doesn\'t seem under source control. Got %d files', len(args))
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001649 if not files:
1650 return None, None
1651 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001652 return change_class, files
1653
1654
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001655@contextlib.contextmanager
1656def canned_check_filter(method_names):
1657 filtered = {}
1658 try:
1659 for method_name in method_names:
1660 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001661 logging.warn('Skipping unknown "canned" check %s' % method_name)
1662 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001663 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1664 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1665 yield
1666 finally:
1667 for name, method in filtered.iteritems():
1668 setattr(presubmit_canned_checks, name, method)
1669
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001670
sbc@chromium.org013731e2015-02-26 18:28:43 +00001671def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001672 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001673 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001674 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001675 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001676 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1677 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001678 parser.add_option("-r", "--recursive", action="store_true",
1679 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001680 parser.add_option("-v", "--verbose", action="count", default=0,
1681 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001682 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001683 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001684 parser.add_option("--description", default='')
1685 parser.add_option("--issue", type='int', default=0)
1686 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001687 parser.add_option("--root", default=os.getcwd(),
1688 help="Search for PRESUBMIT.py up to this directory. "
1689 "If inherit-review-settings-ok is present in this "
1690 "directory, parent directories up to the root file "
1691 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001692 parser.add_option("--upstream",
1693 help="Git only: the base ref or upstream branch against "
1694 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001695 parser.add_option("--default_presubmit")
1696 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001697 parser.add_option("--skip_canned", action='append', default=[],
1698 help="A list of checks to skip which appear in "
1699 "presubmit_canned_checks. Can be provided multiple times "
1700 "to skip multiple canned checks.")
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001701 parser.add_option("--dry_run", action='store_true',
1702 help=optparse.SUPPRESS_HELP)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001703 parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP)
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001704 parser.add_option("--gerrit_fetch", action='store_true',
1705 help=optparse.SUPPRESS_HELP)
Edward Lesmes8e282792018-04-03 18:50:29 -04001706 parser.add_option('--parallel', action='store_true',
1707 help='Run all tests specified by input_api.RunTests in all '
1708 'PRESUBMIT files in parallel.')
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001709
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001710 options, args = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001711
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001712 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001713 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001714 elif options.verbose:
1715 logging.basicConfig(level=logging.INFO)
1716 else:
1717 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001718
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001719 change_class, files = load_files(options, args)
1720 if not change_class:
1721 parser.error('For unversioned directory, <files> is not optional.')
tobiasjs2836bcf2016-08-16 04:08:16 -07001722 logging.info('Found %d file(s).', len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001723
Aaron Gable668c1d82018-04-03 10:19:16 -07001724 gerrit_obj = None
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001725 if options.gerrit_url and options.gerrit_fetch:
tandrii@chromium.org83b1b232016-04-29 16:33:19 +00001726 assert options.issue and options.patchset
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001727 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1728 options.author = gerrit_obj.GetChangeOwner(options.issue)
1729 options.description = gerrit_obj.GetChangeDescription(options.issue,
1730 options.patchset)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001731 logging.info('Got author: "%s"', options.author)
1732 logging.info('Got description: """\n%s\n"""', options.description)
1733
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001734 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001735 with canned_check_filter(options.skip_canned):
1736 results = DoPresubmitChecks(
1737 change_class(options.name,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001738 options.description,
1739 options.root,
1740 files,
1741 options.issue,
1742 options.patchset,
1743 options.author,
1744 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001745 options.commit,
1746 options.verbose,
1747 sys.stdout,
1748 sys.stdin,
1749 options.default_presubmit,
1750 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001751 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001752 options.dry_run,
1753 options.parallel)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001754 return not results.should_continue()
1755 except PresubmitFailure, e:
1756 print >> sys.stderr, e
1757 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001758 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001759
1760
1761if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001762 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001763 try:
1764 sys.exit(main())
1765 except KeyboardInterrupt:
1766 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001767 sys.exit(2)