blob: ff57c90493cb0d61dda89563adbf2e51a7e31165 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090015import ast # Exposed through the API.
enne@chromium.orge72c5f52013-04-16 00:36:40 +000016import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000017import cPickle # Exposed through the API.
18import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
dcheng091b7db2016-06-16 01:27:51 -070020import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000021import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000022import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000023import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000024import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000025import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000026import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import optparse
29import os # Somewhat exposed through the API.
30import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000031import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040033import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000034import sys # Parts exposed through API.
35import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040036import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000037import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000038import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000040import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000041import urllib2 # Exposed through the API.
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000042import urlparse
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000043from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000044
45# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000046import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000047import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070048import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000049import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000050import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020051import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000052import presubmit_canned_checks
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000053import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000054import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000055
56
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000057# Ask for feedback only once in program lifetime.
58_ASKED_FOR_FEEDBACK = False
59
60
maruel@chromium.org899e1c12011-04-07 17:03:18 +000061class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000062 pass
63
64
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000065class CommandData(object):
66 def __init__(self, name, cmd, kwargs, message):
67 self.name = name
68 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040069 self.stdin = kwargs.get('stdin', None)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000070 self.kwargs = kwargs
Edward Lesmes8e282792018-04-03 18:50:29 -040071 self.kwargs['stdout'] = subprocess.PIPE
72 self.kwargs['stderr'] = subprocess.STDOUT
73 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000074 self.message = message
75 self.info = None
76
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000077
Edward Lesmes8e282792018-04-03 18:50:29 -040078# Adapted from
79# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
80#
81# An object that catches SIGINT sent to the Python process and notices
82# if processes passed to wait() die by SIGINT (we need to look for
83# both of those cases, because pressing Ctrl+C can result in either
84# the main process or one of the subprocesses getting the signal).
85#
86# Before a SIGINT is seen, wait(p) will simply call p.wait() and
87# return the result. Once a SIGINT has been seen (in the main process
88# or a subprocess, including the one the current call is waiting for),
89# wait(p) will call p.terminate() and raise ProcessWasInterrupted.
90class SigintHandler(object):
91 class ProcessWasInterrupted(Exception):
92 pass
93
94 sigint_returncodes = {-signal.SIGINT, # Unix
95 -1073741510, # Windows
96 }
97 def __init__(self):
98 self.__lock = threading.Lock()
99 self.__processes = set()
100 self.__got_sigint = False
101 signal.signal(signal.SIGINT, lambda signal_num, frame: self.interrupt())
102
103 def __on_sigint(self):
104 self.__got_sigint = True
105 while self.__processes:
106 try:
107 self.__processes.pop().terminate()
108 except OSError:
109 pass
110
111 def interrupt(self):
112 with self.__lock:
113 self.__on_sigint()
114
115 def got_sigint(self):
116 with self.__lock:
117 return self.__got_sigint
118
119 def wait(self, p, stdin):
120 with self.__lock:
121 if self.__got_sigint:
122 p.terminate()
123 self.__processes.add(p)
124 stdout, stderr = p.communicate(stdin)
125 code = p.returncode
126 with self.__lock:
127 self.__processes.discard(p)
128 if code in self.sigint_returncodes:
129 self.__on_sigint()
130 if self.__got_sigint:
131 raise self.ProcessWasInterrupted
132 return stdout, stderr
133
134sigint_handler = SigintHandler()
135
136
137class ThreadPool(object):
138 def __init__(self, pool_size=None):
139 self._pool_size = pool_size or multiprocessing.cpu_count()
140 self._messages = []
141 self._messages_lock = threading.Lock()
142 self._tests = []
143 self._tests_lock = threading.Lock()
144 self._nonparallel_tests = []
145
146 def CallCommand(self, test):
147 """Runs an external program.
148
149 This function converts invocation of .py files and invocations of "python"
150 to vpython invocations.
151 """
152 vpython = 'vpython.bat' if sys.platform == 'win32' else 'vpython'
153
154 cmd = test.cmd
155 if cmd[0] == 'python':
156 cmd = list(cmd)
157 cmd[0] = vpython
158 elif cmd[0].endswith('.py'):
159 cmd = [vpython] + cmd
160
161 try:
162 start = time.time()
163 p = subprocess.Popen(cmd, **test.kwargs)
164 stdout, _ = sigint_handler.wait(p, test.stdin)
165 duration = time.time() - start
166 except OSError as e:
167 duration = time.time() - start
168 return test.message(
169 '%s exec failure (%4.2fs)\n %s' % (test.name, duration, e))
170 if p.returncode != 0:
171 return test.message(
172 '%s (%4.2fs) failed\n%s' % (test.name, duration, stdout))
173 if test.info:
174 return test.info('%s (%4.2fs)' % (test.name, duration))
175
176 def AddTests(self, tests, parallel=True):
177 if parallel:
178 self._tests.extend(tests)
179 else:
180 self._nonparallel_tests.extend(tests)
181
182 def RunAsync(self):
183 self._messages = []
184
185 def _WorkerFn():
186 while True:
187 test = None
188 with self._tests_lock:
189 if not self._tests:
190 break
191 test = self._tests.pop()
192 result = self.CallCommand(test)
193 if result:
194 with self._messages_lock:
195 self._messages.append(result)
196
197 def _StartDaemon():
198 t = threading.Thread(target=_WorkerFn)
199 t.daemon = True
200 t.start()
201 return t
202
203 while self._nonparallel_tests:
204 test = self._nonparallel_tests.pop()
205 result = self.CallCommand(test)
206 if result:
207 self._messages.append(result)
208
209 if self._tests:
210 threads = [_StartDaemon() for _ in range(self._pool_size)]
211 for worker in threads:
212 worker.join()
213
214 return self._messages
215
216
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000217def normpath(path):
218 '''Version of os.path.normpath that also changes backward slashes to
219 forward slashes when not running on Windows.
220 '''
221 # This is safe to always do because the Windows version of os.path.normpath
222 # will replace forward slashes with backward slashes.
223 path = path.replace(os.sep, '/')
224 return os.path.normpath(path)
225
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000226
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000227def _RightHandSideLinesImpl(affected_files):
228 """Implements RightHandSideLines for InputApi and GclChange."""
229 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000230 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000231 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000232 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000233
234
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000235class PresubmitOutput(object):
236 def __init__(self, input_stream=None, output_stream=None):
237 self.input_stream = input_stream
238 self.output_stream = output_stream
239 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -0800240 self.more_cc = []
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000241 self.written_output = []
242 self.error_count = 0
243
244 def prompt_yes_no(self, prompt_string):
245 self.write(prompt_string)
246 if self.input_stream:
247 response = self.input_stream.readline().strip().lower()
248 if response not in ('y', 'yes'):
249 self.fail()
250 else:
251 self.fail()
252
253 def fail(self):
254 self.error_count += 1
255
256 def should_continue(self):
257 return not self.error_count
258
259 def write(self, s):
260 self.written_output.append(s)
261 if self.output_stream:
262 self.output_stream.write(s)
263
264 def getvalue(self):
265 return ''.join(self.written_output)
266
267
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000268# Top level object so multiprocessing can pickle
269# Public access through OutputApi object.
270class _PresubmitResult(object):
271 """Base class for result objects."""
272 fatal = False
273 should_prompt = False
274
275 def __init__(self, message, items=None, long_text=''):
276 """
277 message: A short one-line message to indicate errors.
278 items: A list of short strings to indicate where errors occurred.
279 long_text: multi-line text output, e.g. from another tool
280 """
281 self._message = message
282 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000283 self._long_text = long_text.rstrip()
284
285 def handle(self, output):
286 output.write(self._message)
287 output.write('\n')
288 for index, item in enumerate(self._items):
289 output.write(' ')
290 # Write separately in case it's unicode.
291 output.write(str(item))
292 if index < len(self._items) - 1:
293 output.write(' \\')
294 output.write('\n')
295 if self._long_text:
296 output.write('\n***************\n')
297 # Write separately in case it's unicode.
298 output.write(self._long_text)
299 output.write('\n***************\n')
300 if self.fatal:
301 output.fail()
302
303
304# Top level object so multiprocessing can pickle
305# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000306class _PresubmitError(_PresubmitResult):
307 """A hard presubmit error."""
308 fatal = True
309
310
311# Top level object so multiprocessing can pickle
312# Public access through OutputApi object.
313class _PresubmitPromptWarning(_PresubmitResult):
314 """An warning that prompts the user if they want to continue."""
315 should_prompt = True
316
317
318# Top level object so multiprocessing can pickle
319# Public access through OutputApi object.
320class _PresubmitNotifyResult(_PresubmitResult):
321 """Just print something to the screen -- but it's not even a warning."""
322 pass
323
324
325# Top level object so multiprocessing can pickle
326# Public access through OutputApi object.
327class _MailTextResult(_PresubmitResult):
328 """A warning that should be included in the review request email."""
329 def __init__(self, *args, **kwargs):
330 super(_MailTextResult, self).__init__()
331 raise NotImplementedError()
332
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000333class GerritAccessor(object):
334 """Limited Gerrit functionality for canned presubmit checks to work.
335
336 To avoid excessive Gerrit calls, caches the results.
337 """
338
339 def __init__(self, host):
340 self.host = host
341 self.cache = {}
342
343 def _FetchChangeDetail(self, issue):
344 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100345 try:
346 return gerrit_util.GetChangeDetail(
347 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700348 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100349 except gerrit_util.GerritError as e:
350 if e.http_status == 404:
351 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
352 'no credentials to fetch issue details' % issue)
353 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000354
355 def GetChangeInfo(self, issue):
356 """Returns labels and all revisions (patchsets) for this issue.
357
358 The result is a dictionary according to Gerrit REST Api.
359 https://gerrit-review.googlesource.com/Documentation/rest-api.html
360
361 However, API isn't very clear what's inside, so see tests for example.
362 """
363 assert issue
364 cache_key = int(issue)
365 if cache_key not in self.cache:
366 self.cache[cache_key] = self._FetchChangeDetail(issue)
367 return self.cache[cache_key]
368
369 def GetChangeDescription(self, issue, patchset=None):
370 """If patchset is none, fetches current patchset."""
371 info = self.GetChangeInfo(issue)
372 # info is a reference to cache. We'll modify it here adding description to
373 # it to the right patchset, if it is not yet there.
374
375 # Find revision info for the patchset we want.
376 if patchset is not None:
377 for rev, rev_info in info['revisions'].iteritems():
378 if str(rev_info['_number']) == str(patchset):
379 break
380 else:
381 raise Exception('patchset %s doesn\'t exist in issue %s' % (
382 patchset, issue))
383 else:
384 rev = info['current_revision']
385 rev_info = info['revisions'][rev]
386
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100387 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000388
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800389 def GetDestRef(self, issue):
390 ref = self.GetChangeInfo(issue)['branch']
391 if not ref.startswith('refs/'):
392 # NOTE: it is possible to create 'refs/x' branch,
393 # aka 'refs/heads/refs/x'. However, this is ill-advised.
394 ref = 'refs/heads/%s' % ref
395 return ref
396
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000397 def GetChangeOwner(self, issue):
398 return self.GetChangeInfo(issue)['owner']['email']
399
400 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700401 changeinfo = self.GetChangeInfo(issue)
402 if approving_only:
403 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
404 values = labelinfo.get('values', {}).keys()
405 try:
406 max_value = max(int(v) for v in values)
407 reviewers = [r for r in labelinfo.get('all', [])
408 if r.get('value', 0) == max_value]
409 except ValueError: # values is the empty list
410 reviewers = []
411 else:
412 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
413 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000414
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000415
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000416class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000417 """An instance of OutputApi gets passed to presubmit scripts so that they
418 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000419 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000420 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000421 PresubmitError = _PresubmitError
422 PresubmitPromptWarning = _PresubmitPromptWarning
423 PresubmitNotifyResult = _PresubmitNotifyResult
424 MailTextResult = _MailTextResult
425
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000426 def __init__(self, is_committing):
427 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800428 self.more_cc = []
429
430 def AppendCC(self, cc):
431 """Appends a user to cc for this change."""
432 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000433
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000434 def PresubmitPromptOrNotify(self, *args, **kwargs):
435 """Warn the user when uploading, but only notify if committing."""
436 if self.is_committing:
437 return self.PresubmitNotifyResult(*args, **kwargs)
438 return self.PresubmitPromptWarning(*args, **kwargs)
439
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800440 def EnsureCQIncludeTrybotsAreAdded(self, cl, bots_to_include, message):
441 """Helper for any PostUploadHook wishing to add CQ_INCLUDE_TRYBOTS.
442
443 Merges the bots_to_include into the current CQ_INCLUDE_TRYBOTS list,
444 keeping it alphabetically sorted. Returns the results that should be
445 returned from the PostUploadHook.
446
447 Args:
448 cl: The git_cl.Changelist object.
449 bots_to_include: A list of strings of bots to include, in the form
450 "master:slave".
451 message: A message to be printed in the case that
452 CQ_INCLUDE_TRYBOTS was updated.
453 """
454 description = cl.GetDescription(force=True)
Aaron Gableb584c4f2017-04-26 16:28:08 -0700455 include_re = re.compile(r'^CQ_INCLUDE_TRYBOTS=(.*)$', re.M | re.I)
456
457 prior_bots = []
458 if cl.IsGerrit():
459 trybot_footers = git_footers.parse_footers(description).get(
460 git_footers.normalize_name('Cq-Include-Trybots'), [])
461 for f in trybot_footers:
462 prior_bots += [b.strip() for b in f.split(';') if b.strip()]
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800463 else:
Aaron Gableb584c4f2017-04-26 16:28:08 -0700464 trybot_tags = include_re.finditer(description)
465 for t in trybot_tags:
466 prior_bots += [b.strip() for b in t.group(1).split(';') if b.strip()]
467
468 if set(prior_bots) >= set(bots_to_include):
469 return []
470 all_bots = ';'.join(sorted(set(prior_bots) | set(bots_to_include)))
471
472 if cl.IsGerrit():
473 description = git_footers.remove_footer(
474 description, 'Cq-Include-Trybots')
475 description = git_footers.add_footer(
476 description, 'Cq-Include-Trybots', all_bots,
477 before_keys=['Change-Id'])
478 else:
479 new_include_trybots = 'CQ_INCLUDE_TRYBOTS=%s' % all_bots
480 m = include_re.search(description)
481 if m:
482 description = include_re.sub(new_include_trybots, description)
Kenneth Russelldf6e7342017-04-24 17:07:41 -0700483 else:
Aaron Gableb584c4f2017-04-26 16:28:08 -0700484 description = '%s\n%s\n' % (description, new_include_trybots)
485
486 cl.UpdateDescription(description, force=True)
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800487 return [self.PresubmitNotifyResult(message)]
488
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000489
490class InputApi(object):
491 """An instance of this object is passed to presubmit scripts so they can
492 know stuff about the change they're looking at.
493 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000494 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800495 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000496
maruel@chromium.org3410d912009-06-09 20:56:16 +0000497 # File extensions that are considered source files from a style guide
498 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000499 #
500 # Files without an extension aren't included in the list. If you want to
501 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
502 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000503 DEFAULT_WHITE_LIST = (
504 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000505 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
506 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000507 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000508 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000509 # Other
estade@chromium.orgae7af922012-01-27 14:51:13 +0000510 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000511 )
512
513 # Path regexp that should be excluded from being considered containing source
514 # files. Don't modify this list from a presubmit script!
515 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000516 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000517 r".*\bexperimental[\\\/].*",
Kent Tamura179dd1e2018-04-26 15:07:41 +0900518 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
519 # (crbug.com/539768 and crbug.com/836555).
520 r".*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000521 # Output directories (just in case)
522 r".*\bDebug[\\\/].*",
523 r".*\bRelease[\\\/].*",
524 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000525 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000526 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000527 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000528 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000529 r"(|.*[\\\/])\.git[\\\/].*",
530 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000531 # There is no point in processing a patch file.
532 r".+\.diff$",
533 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000534 )
535
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000536 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400537 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000538 """Builds an InputApi object.
539
540 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000541 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000542 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000543 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000544 gerrit_obj: provides basic Gerrit codereview functionality.
545 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400546 parallel: if true, all tests reported via input_api.RunTests for all
547 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000548 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000549 # Version number of the presubmit_support script.
550 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000551 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000552 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000553 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000554 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000555
Edward Lesmes8e282792018-04-03 18:50:29 -0400556 self.parallel = parallel
557 self.thread_pool = thread_pool or ThreadPool()
558
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000559 # We expose various modules and functions as attributes of the input_api
560 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900561 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000562 self.basename = os.path.basename
563 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000564 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000565 self.cStringIO = cStringIO
dcheng091b7db2016-06-16 01:27:51 -0700566 self.fnmatch = fnmatch
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000567 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000568 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000569 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000570 self.os_listdir = os.listdir
571 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000572 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000573 self.os_stat = os.stat
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000574 self.pickle = pickle
575 self.marshal = marshal
576 self.re = re
577 self.subprocess = subprocess
578 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000579 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000580 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000581 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000582 self.urllib2 = urllib2
583
Robert Iannucci50258932018-03-19 10:30:59 -0700584 self.is_windows = sys.platform == 'win32'
585
586 # Set python_executable to 'python'. This is interpreted in CallCommand to
587 # convert to vpython in order to allow scripts in other repos (e.g. src.git)
588 # to automatically pick up that repo's .vpython file, instead of inheriting
589 # the one in depot_tools.
590 self.python_executable = 'python'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000591 self.environ = os.environ
592
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000593 # InputApi.platform is the platform you're currently running on.
594 self.platform = sys.platform
595
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000596 self.cpu_count = multiprocessing.cpu_count()
597
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000598 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000599 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000600
601 # We carry the canned checks so presubmit scripts can easily use them.
602 self.canned_checks = presubmit_canned_checks
603
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100604 # Temporary files we must manually remove at the end of a run.
605 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200606
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000607 # TODO(dpranke): figure out a list of all approved owners for a repo
608 # in order to be able to handle wildcard OWNERS files?
609 self.owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +0200610 fopen=file, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200611 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000612 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000613 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000614
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000615 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000616 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000617 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800618 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000619 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000620 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000621 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
622 for (a, b, header) in cpplint._re_pattern_templates
623 ]
624
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000625 def PresubmitLocalPath(self):
626 """Returns the local path of the presubmit script currently being run.
627
628 This is useful if you don't want to hard-code absolute paths in the
629 presubmit script. For example, It can be used to find another file
630 relative to the PRESUBMIT.py script, so the whole tree can be branched and
631 the presubmit script still works, without editing its content.
632 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000633 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000634
agable0b65e732016-11-22 09:25:46 -0800635 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000636 """Same as input_api.change.AffectedFiles() except only lists files
637 (and optionally directories) in the same directory as the current presubmit
638 script, or subdirectories thereof.
639 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000640 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000641 if len(dir_with_slash) == 1:
642 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000643
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000644 return filter(
645 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
agable0b65e732016-11-22 09:25:46 -0800646 self.change.AffectedFiles(include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000647
agable0b65e732016-11-22 09:25:46 -0800648 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000649 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800650 paths = [af.LocalPath() for af in self.AffectedFiles()]
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000651 logging.debug("LocalPaths: %s", paths)
652 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000653
agable0b65e732016-11-22 09:25:46 -0800654 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000655 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800656 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000657
John Budorick16162372018-04-18 10:39:53 -0700658 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800659 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000660 in the same directory as the current presubmit script, or subdirectories
661 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000662 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000663 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800664 warn("AffectedTestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000665 " is deprecated and ignored" % str(include_deletes),
666 category=DeprecationWarning,
667 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -0800668 return filter(lambda x: x.IsTestableFile(),
John Budorick16162372018-04-18 10:39:53 -0700669 self.AffectedFiles(include_deletes=False, **kwargs))
agable0b65e732016-11-22 09:25:46 -0800670
671 def AffectedTextFiles(self, include_deletes=None):
672 """An alias to AffectedTestableFiles for backwards compatibility."""
673 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000674
maruel@chromium.org3410d912009-06-09 20:56:16 +0000675 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
676 """Filters out files that aren't considered "source file".
677
678 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
679 and InputApi.DEFAULT_BLACK_LIST is used respectively.
680
681 The lists will be compiled as regular expression and
682 AffectedFile.LocalPath() needs to pass both list.
683
684 Note: Copy-paste this function to suit your needs or use a lambda function.
685 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000686 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000687 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000688 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000689 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000690 return True
691 return False
692 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
693 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
694
695 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800696 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000697
698 If source_file is None, InputApi.FilterSourceFile() is used.
699 """
700 if not source_file:
701 source_file = self.FilterSourceFile
agable0b65e732016-11-22 09:25:46 -0800702 return filter(source_file, self.AffectedTestableFiles())
maruel@chromium.org3410d912009-06-09 20:56:16 +0000703
704 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000705 """An iterator over all text lines in "new" version of changed files.
706
707 Only lists lines from new or modified text files in the change that are
708 contained by the directory of the currently executing presubmit script.
709
710 This is useful for doing line-by-line regex checks, like checking for
711 trailing whitespace.
712
713 Yields:
714 a 3 tuple:
715 the AffectedFile instance of the current file;
716 integer line number (1-based); and
717 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000718
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000719 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000720 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000721 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000722 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000723
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000724 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000725 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000726
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000727 Deny reading anything outside the repository.
728 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000729 if isinstance(file_item, AffectedFile):
730 file_item = file_item.AbsoluteLocalPath()
731 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000732 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000733 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000734
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100735 def CreateTemporaryFile(self, **kwargs):
736 """Returns a named temporary file that must be removed with a call to
737 RemoveTemporaryFiles().
738
739 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
740 except for |delete|, which is always set to False.
741
742 Presubmit checks that need to create a temporary file and pass it for
743 reading should use this function instead of NamedTemporaryFile(), as
744 Windows fails to open a file that is already open for writing.
745
746 with input_api.CreateTemporaryFile() as f:
747 f.write('xyz')
748 f.close()
749 input_api.subprocess.check_output(['script-that', '--reads-from',
750 f.name])
751
752
753 Note that callers of CreateTemporaryFile() should not worry about removing
754 any temporary file; this is done transparently by the presubmit handling
755 code.
756 """
757 if 'delete' in kwargs:
758 # Prevent users from passing |delete|; we take care of file deletion
759 # ourselves and this prevents unintuitive error messages when we pass
760 # delete=False and 'delete' is also in kwargs.
761 raise TypeError('CreateTemporaryFile() does not take a "delete" '
762 'argument, file deletion is handled automatically by '
763 'the same presubmit_support code that creates InputApi '
764 'objects.')
765 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
766 self._named_temporary_files.append(temp_file.name)
767 return temp_file
768
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000769 @property
770 def tbr(self):
771 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400772 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000773
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000774 def RunTests(self, tests_mix, parallel=True):
Edward Lesmes8e282792018-04-03 18:50:29 -0400775 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
776 # will run all tests once all PRESUBMIT files are processed.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000777 tests = []
778 msgs = []
779 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400780 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000781 msgs.append(t)
782 else:
783 assert issubclass(t.message, _PresubmitResult)
784 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000785 if self.verbose:
786 t.info = _PresubmitNotifyResult
Edward Lesmes8e282792018-04-03 18:50:29 -0400787 t.kwargs['cwd'] = self.PresubmitLocalPath()
788 self.thread_pool.AddTests(tests, parallel)
789 if not self.parallel:
790 msgs.extend(self.thread_pool.RunAsync())
791 return msgs
scottmg86099d72016-09-01 09:16:51 -0700792
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000793
nick@chromium.orgff526192013-06-10 19:30:26 +0000794class _DiffCache(object):
795 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000796 def __init__(self, upstream=None):
797 """Stores the upstream revision against which all diffs will be computed."""
798 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000799
800 def GetDiff(self, path, local_root):
801 """Get the diff for a particular path."""
802 raise NotImplementedError()
803
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700804 def GetOldContents(self, path, local_root):
805 """Get the old version for a particular path."""
806 raise NotImplementedError()
807
nick@chromium.orgff526192013-06-10 19:30:26 +0000808
nick@chromium.orgff526192013-06-10 19:30:26 +0000809class _GitDiffCache(_DiffCache):
810 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000811 def __init__(self, upstream):
812 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000813 self._diffs_by_file = None
814
815 def GetDiff(self, path, local_root):
816 if not self._diffs_by_file:
817 # Compute a single diff for all files and parse the output; should
818 # with git this is much faster than computing one diff for each file.
819 diffs = {}
820
821 # Don't specify any filenames below, because there are command line length
822 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000823 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
824 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000825
826 # This regex matches the path twice, separated by a space. Note that
827 # filename itself may contain spaces.
828 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
829 current_diff = []
830 keep_line_endings = True
831 for x in unified_diff.splitlines(keep_line_endings):
832 match = file_marker.match(x)
833 if match:
834 # Marks the start of a new per-file section.
835 diffs[match.group('filename')] = current_diff = [x]
836 elif x.startswith('diff --git'):
837 raise PresubmitFailure('Unexpected diff line: %s' % x)
838 else:
839 current_diff.append(x)
840
841 self._diffs_by_file = dict(
842 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
843
844 if path not in self._diffs_by_file:
845 raise PresubmitFailure(
846 'Unified diff did not contain entry for file %s' % path)
847
848 return self._diffs_by_file[path]
849
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700850 def GetOldContents(self, path, local_root):
851 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
852
nick@chromium.orgff526192013-06-10 19:30:26 +0000853
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000854class AffectedFile(object):
855 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000856
857 DIFF_CACHE = _DiffCache
858
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000859 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800860 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000861 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000862 self._path = path
863 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000864 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000865 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000866 self._cached_changed_contents = None
867 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000868 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700869 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000870
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000871 def LocalPath(self):
872 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400873
874 This should be used for error messages but not for accessing files,
875 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
876 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000877 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000878 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000879
880 def AbsoluteLocalPath(self):
881 """Returns the absolute path of this file on the local disk.
882 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000883 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000884
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000885 def Action(self):
886 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000887 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000888
agable0b65e732016-11-22 09:25:46 -0800889 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000890 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000891
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000892 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000893 raise NotImplementedError() # Implement when needed
894
agable0b65e732016-11-22 09:25:46 -0800895 def IsTextFile(self):
896 """An alias to IsTestableFile for backwards compatibility."""
897 return self.IsTestableFile()
898
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700899 def OldContents(self):
900 """Returns an iterator over the lines in the old version of file.
901
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700902 The old version is the file before any modifications in the user's
903 workspace, i.e. the "left hand side".
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700904
905 Contents will be empty if the file is a directory or does not exist.
906 Note: The carriage returns (LF or CR) are stripped off.
907 """
908 return self._diff_cache.GetOldContents(self.LocalPath(),
909 self._local_root).splitlines()
910
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000911 def NewContents(self):
912 """Returns an iterator over the lines in the new version of file.
913
914 The new version is the file in the user's workspace, i.e. the "right hand
915 side".
916
917 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000918 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000919 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000920 if self._cached_new_contents is None:
921 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800922 try:
923 self._cached_new_contents = gclient_utils.FileRead(
924 self.AbsoluteLocalPath(), 'rU').splitlines()
925 except IOError:
926 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000927 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000928
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000929 def ChangedContents(self):
930 """Returns a list of tuples (line number, line text) of all new lines.
931
932 This relies on the scm diff output describing each changed code section
933 with a line of the form
934
935 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
936 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000937 if self._cached_changed_contents is not None:
938 return self._cached_changed_contents[:]
939 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000940 line_num = 0
941
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000942 for line in self.GenerateScmDiff().splitlines():
943 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
944 if m:
945 line_num = int(m.groups(1)[0])
946 continue
947 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000948 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000949 if not line.startswith('-'):
950 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000951 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000952
maruel@chromium.org5de13972009-06-10 18:16:06 +0000953 def __str__(self):
954 return self.LocalPath()
955
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000956 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000957 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000958
maruel@chromium.org58407af2011-04-12 23:15:57 +0000959
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000960class GitAffectedFile(AffectedFile):
961 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000962 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800963 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000964
nick@chromium.orgff526192013-06-10 19:30:26 +0000965 DIFF_CACHE = _GitDiffCache
966
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000967 def __init__(self, *args, **kwargs):
968 AffectedFile.__init__(self, *args, **kwargs)
969 self._server_path = None
agable0b65e732016-11-22 09:25:46 -0800970 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000971
agable0b65e732016-11-22 09:25:46 -0800972 def IsTestableFile(self):
973 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000974 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -0800975 # A deleted file is not testable.
976 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000977 else:
agable0b65e732016-11-22 09:25:46 -0800978 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
979 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000980
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000981
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000982class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000983 """Describe a change.
984
985 Used directly by the presubmit scripts to query the current change being
986 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000987
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000988 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000989 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000990 self.KEY: equivalent to tags['KEY']
991 """
992
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000993 _AFFECTED_FILES = AffectedFile
994
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000995 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000996 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000997 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000998 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000999
maruel@chromium.org58407af2011-04-12 23:15:57 +00001000 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001001 self, name, description, local_root, files, issue, patchset, author,
1002 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001003 if files is None:
1004 files = []
1005 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001006 # Convert root into an absolute path.
1007 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001008 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001009 self.issue = issue
1010 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001011 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001012
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001013 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001014 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001015 self._description_without_tags = ''
1016 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001017
maruel@chromium.orge085d812011-10-10 19:49:15 +00001018 assert all(
1019 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1020
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001021 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001022 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001023 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1024 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001025 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001026
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001027 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001028 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001029 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001030
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001031 def DescriptionText(self):
1032 """Returns the user-entered changelist description, minus tags.
1033
1034 Any line in the user-provided description starting with e.g. "FOO="
1035 (whitespace permitted before and around) is considered a tag line. Such
1036 lines are stripped out of the description this function returns.
1037 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001038 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001039
1040 def FullDescriptionText(self):
1041 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001042 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001043
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001044 def SetDescriptionText(self, description):
1045 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001046
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001047 Also updates the list of tags."""
1048 self._full_description = description
1049
1050 # From the description text, build up a dictionary of key/value pairs
1051 # plus the description minus all key/value or "tag" lines.
1052 description_without_tags = []
1053 self.tags = {}
1054 for line in self._full_description.splitlines():
1055 m = self.TAG_LINE_RE.match(line)
1056 if m:
1057 self.tags[m.group('key')] = m.group('value')
1058 else:
1059 description_without_tags.append(line)
1060
1061 # Change back to text and remove whitespace at end.
1062 self._description_without_tags = (
1063 '\n'.join(description_without_tags).rstrip())
1064
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001065 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001066 """Returns the repository (checkout) root directory for this change,
1067 as an absolute path.
1068 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001069 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001070
1071 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001072 """Return tags directly as attributes on the object."""
1073 if not re.match(r"^[A-Z_]*$", attr):
1074 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001075 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001076
Aaron Gablefc03e672017-05-15 14:09:42 -07001077 def BugsFromDescription(self):
1078 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001079 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
1080 footers = git_footers.parse_footers(self._full_description).get('Bug', [])
1081 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001082
1083 def ReviewersFromDescription(self):
1084 """Returns all reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001085 # We don't support a "R:" git-footer for reviewers; that is in metadata.
1086 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1087 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001088
1089 def TBRsFromDescription(self):
1090 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001091 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1092 # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically
1093 # determined by self-CR+1s.
1094 footers = git_footers.parse_footers(self._full_description).get('Tbr', [])
1095 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001096
1097 # TODO(agable): Delete these once we're sure they're unused.
1098 @property
1099 def BUG(self):
1100 return ','.join(self.BugsFromDescription())
1101 @property
1102 def R(self):
1103 return ','.join(self.ReviewersFromDescription())
1104 @property
1105 def TBR(self):
1106 return ','.join(self.TBRsFromDescription())
1107
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001108 def AllFiles(self, root=None):
1109 """List all files under source control in the repo."""
1110 raise NotImplementedError()
1111
agable0b65e732016-11-22 09:25:46 -08001112 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001113 """Returns a list of AffectedFile instances for all files in the change.
1114
1115 Args:
1116 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001117 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001118
1119 Returns:
1120 [AffectedFile(path, action), AffectedFile(path, action)]
1121 """
agable0b65e732016-11-22 09:25:46 -08001122 affected = filter(file_filter, self._affected_files)
sail@chromium.org5538e022011-05-12 17:53:16 +00001123
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001124 if include_deletes:
1125 return affected
Lei Zhang9611c4c2017-04-04 01:41:56 -07001126 return filter(lambda x: x.Action() != 'D', affected)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001127
John Budorick16162372018-04-18 10:39:53 -07001128 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001129 """Return a list of the existing text files in a change."""
1130 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -08001131 warn("AffectedTeestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001132 " is deprecated and ignored" % str(include_deletes),
1133 category=DeprecationWarning,
1134 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -08001135 return filter(lambda x: x.IsTestableFile(),
John Budorick16162372018-04-18 10:39:53 -07001136 self.AffectedFiles(include_deletes=False, **kwargs))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001137
agable0b65e732016-11-22 09:25:46 -08001138 def AffectedTextFiles(self, include_deletes=None):
1139 """An alias to AffectedTestableFiles for backwards compatibility."""
1140 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001141
agable0b65e732016-11-22 09:25:46 -08001142 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001143 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001144 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001145
agable0b65e732016-11-22 09:25:46 -08001146 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001147 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001148 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001149
1150 def RightHandSideLines(self):
1151 """An iterator over all text lines in "new" version of changed files.
1152
1153 Lists lines from new or modified text files in the change.
1154
1155 This is useful for doing line-by-line regex checks, like checking for
1156 trailing whitespace.
1157
1158 Yields:
1159 a 3 tuple:
1160 the AffectedFile instance of the current file;
1161 integer line number (1-based); and
1162 the contents of the line as a string.
1163 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001164 return _RightHandSideLinesImpl(
1165 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001166 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001167
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001168 def OriginalOwnersFiles(self):
1169 """A map from path names of affected OWNERS files to their old content."""
1170 def owners_file_filter(f):
1171 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1172 files = self.AffectedFiles(file_filter=owners_file_filter)
1173 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1174
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001175
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001176class GitChange(Change):
1177 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001178 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001179
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001180 def AllFiles(self, root=None):
1181 """List all files under source control in the repo."""
1182 root = root or self.RepositoryRoot()
1183 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001184 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1185 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001186
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001187
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001188def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001189 """Finds all presubmit files that apply to a given set of source files.
1190
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001191 If inherit-review-settings-ok is present right under root, looks for
1192 PRESUBMIT.py in directories enclosing root.
1193
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001194 Args:
1195 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001196 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001197
1198 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001199 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001200 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001201 files = [normpath(os.path.join(root, f)) for f in files]
1202
1203 # List all the individual directories containing files.
1204 directories = set([os.path.dirname(f) for f in files])
1205
1206 # Ignore root if inherit-review-settings-ok is present.
1207 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1208 root = None
1209
1210 # Collect all unique directories that may contain PRESUBMIT.py.
1211 candidates = set()
1212 for directory in directories:
1213 while True:
1214 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001215 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001216 candidates.add(directory)
1217 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001218 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001219 parent_dir = os.path.dirname(directory)
1220 if parent_dir == directory:
1221 # We hit the system root directory.
1222 break
1223 directory = parent_dir
1224
1225 # Look for PRESUBMIT.py in all candidate directories.
1226 results = []
1227 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001228 try:
1229 for f in os.listdir(directory):
1230 p = os.path.join(directory, f)
1231 if os.path.isfile(p) and re.match(
1232 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1233 results.append(p)
1234 except OSError:
1235 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001236
tobiasjs2836bcf2016-08-16 04:08:16 -07001237 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001238 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001239
1240
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001241class GetTryMastersExecuter(object):
1242 @staticmethod
1243 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1244 """Executes GetPreferredTryMasters() from a single presubmit script.
1245
1246 Args:
1247 script_text: The text of the presubmit script.
1248 presubmit_path: Project script to run.
1249 project: Project name to pass to presubmit script for bot selection.
1250
1251 Return:
1252 A map of try masters to map of builders to set of tests.
1253 """
1254 context = {}
1255 try:
1256 exec script_text in context
1257 except Exception, e:
1258 raise PresubmitFailure('"%s" had an exception.\n%s'
1259 % (presubmit_path, e))
1260
1261 function_name = 'GetPreferredTryMasters'
1262 if function_name not in context:
1263 return {}
1264 get_preferred_try_masters = context[function_name]
1265 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1266 raise PresubmitFailure(
1267 'Expected function "GetPreferredTryMasters" to take two arguments.')
1268 return get_preferred_try_masters(project, change)
1269
1270
rmistry@google.com5626a922015-02-26 14:03:30 +00001271class GetPostUploadExecuter(object):
1272 @staticmethod
1273 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1274 """Executes PostUploadHook() from a single presubmit script.
1275
1276 Args:
1277 script_text: The text of the presubmit script.
1278 presubmit_path: Project script to run.
1279 cl: The Changelist object.
1280 change: The Change object.
1281
1282 Return:
1283 A list of results objects.
1284 """
1285 context = {}
1286 try:
1287 exec script_text in context
1288 except Exception, e:
1289 raise PresubmitFailure('"%s" had an exception.\n%s'
1290 % (presubmit_path, e))
1291
1292 function_name = 'PostUploadHook'
1293 if function_name not in context:
1294 return {}
1295 post_upload_hook = context[function_name]
1296 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1297 raise PresubmitFailure(
1298 'Expected function "PostUploadHook" to take three arguments.')
1299 return post_upload_hook(cl, change, OutputApi(False))
1300
1301
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001302def _MergeMasters(masters1, masters2):
1303 """Merges two master maps. Merges also the tests of each builder."""
1304 result = {}
1305 for (master, builders) in itertools.chain(masters1.iteritems(),
1306 masters2.iteritems()):
1307 new_builders = result.setdefault(master, {})
1308 for (builder, tests) in builders.iteritems():
1309 new_builders.setdefault(builder, set([])).update(tests)
1310 return result
1311
1312
1313def DoGetTryMasters(change,
1314 changed_files,
1315 repository_root,
1316 default_presubmit,
1317 project,
1318 verbose,
1319 output_stream):
1320 """Get the list of try masters from the presubmit scripts.
1321
1322 Args:
1323 changed_files: List of modified files.
1324 repository_root: The repository root.
1325 default_presubmit: A default presubmit script to execute in any case.
1326 project: Optional name of a project used in selecting trybots.
1327 verbose: Prints debug info.
1328 output_stream: A stream to write debug output to.
1329
1330 Return:
1331 Map of try masters to map of builders to set of tests.
1332 """
1333 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1334 if not presubmit_files and verbose:
1335 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1336 results = {}
1337 executer = GetTryMastersExecuter()
1338
1339 if default_presubmit:
1340 if verbose:
1341 output_stream.write("Running default presubmit script.\n")
1342 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1343 results = _MergeMasters(results, executer.ExecPresubmitScript(
1344 default_presubmit, fake_path, project, change))
1345 for filename in presubmit_files:
1346 filename = os.path.abspath(filename)
1347 if verbose:
1348 output_stream.write("Running %s\n" % filename)
1349 # Accept CRLF presubmit script.
1350 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1351 results = _MergeMasters(results, executer.ExecPresubmitScript(
1352 presubmit_script, filename, project, change))
1353
1354 # Make sets to lists again for later JSON serialization.
1355 for builders in results.itervalues():
1356 for builder in builders:
1357 builders[builder] = list(builders[builder])
1358
1359 if results and verbose:
1360 output_stream.write('%s\n' % str(results))
1361 return results
1362
1363
rmistry@google.com5626a922015-02-26 14:03:30 +00001364def DoPostUploadExecuter(change,
1365 cl,
1366 repository_root,
1367 verbose,
1368 output_stream):
1369 """Execute the post upload hook.
1370
1371 Args:
1372 change: The Change object.
1373 cl: The Changelist object.
1374 repository_root: The repository root.
1375 verbose: Prints debug info.
1376 output_stream: A stream to write debug output to.
1377 """
1378 presubmit_files = ListRelevantPresubmitFiles(
1379 change.LocalPaths(), repository_root)
1380 if not presubmit_files and verbose:
1381 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1382 results = []
1383 executer = GetPostUploadExecuter()
1384 # The root presubmit file should be executed after the ones in subdirectories.
1385 # i.e. the specific post upload hooks should run before the general ones.
1386 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1387 presubmit_files.reverse()
1388
1389 for filename in presubmit_files:
1390 filename = os.path.abspath(filename)
1391 if verbose:
1392 output_stream.write("Running %s\n" % filename)
1393 # Accept CRLF presubmit script.
1394 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1395 results.extend(executer.ExecPresubmitScript(
1396 presubmit_script, filename, cl, change))
1397 output_stream.write('\n')
1398 if results:
1399 output_stream.write('** Post Upload Hook Messages **\n')
1400 for result in results:
1401 result.handle(output_stream)
1402 output_stream.write('\n')
1403
1404 return results
1405
1406
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001407class PresubmitExecuter(object):
Aaron Gable668c1d82018-04-03 10:19:16 -07001408 def __init__(self, change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001409 gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001410 """
1411 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001412 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001413 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001414 gerrit_obj: provides basic Gerrit codereview functionality.
1415 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001416 parallel: if true, all tests reported via input_api.RunTests for all
1417 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001418 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001419 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001420 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001421 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001422 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001423 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001424 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001425 self.thread_pool = thread_pool
1426 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001427
1428 def ExecPresubmitScript(self, script_text, presubmit_path):
1429 """Executes a single presubmit script.
1430
1431 Args:
1432 script_text: The text of the presubmit script.
1433 presubmit_path: The path to the presubmit file (this will be reported via
1434 input_api.PresubmitLocalPath()).
1435
1436 Return:
1437 A list of result objects, empty if no problems.
1438 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001439
chase@chromium.org8e416c82009-10-06 04:30:44 +00001440 # Change to the presubmit file's directory to support local imports.
1441 main_path = os.getcwd()
1442 os.chdir(os.path.dirname(presubmit_path))
1443
1444 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001445 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001446 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001447 dry_run=self.dry_run, thread_pool=self.thread_pool,
1448 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001449 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001450 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001451 try:
1452 exec script_text in context
1453 except Exception, e:
1454 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001455
1456 # These function names must change if we make substantial changes to
1457 # the presubmit API that are not backwards compatible.
1458 if self.committing:
1459 function_name = 'CheckChangeOnCommit'
1460 else:
1461 function_name = 'CheckChangeOnUpload'
1462 if function_name in context:
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001463 try:
Daniel Cheng7227d212017-11-17 08:12:37 -08001464 context['__args'] = (input_api, output_api)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001465 logging.debug('Running %s in %s', function_name, presubmit_path)
1466 result = eval(function_name + '(*__args)', context)
1467 logging.debug('Running %s done.', function_name)
Daniel Chengd36fce42017-11-21 21:52:52 -08001468 self.more_cc.extend(output_api.more_cc)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001469 finally:
1470 map(os.remove, input_api._named_temporary_files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001471 if not (isinstance(result, types.TupleType) or
1472 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001473 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001474 'Presubmit functions must return a tuple or list')
1475 for item in result:
1476 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001477 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001478 'All presubmit results must be of types derived from '
1479 'output_api.PresubmitResult')
1480 else:
1481 result = () # no error since the script doesn't care about current event.
1482
chase@chromium.org8e416c82009-10-06 04:30:44 +00001483 # Return the process to the original working directory.
1484 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001485 return result
1486
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001487def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001488 committing,
1489 verbose,
1490 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001491 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001492 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001493 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001494 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001495 dry_run=None,
1496 parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001497 """Runs all presubmit checks that apply to the files in the change.
1498
1499 This finds all PRESUBMIT.py files in directories enclosing the files in the
1500 change (up to the repository root) and calls the relevant entrypoint function
1501 depending on whether the change is being committed or uploaded.
1502
1503 Prints errors, warnings and notifications. Prompts the user for warnings
1504 when needed.
1505
1506 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001507 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001508 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001509 verbose: Prints debug info.
1510 output_stream: A stream to write output from presubmit tests to.
1511 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001512 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001513 may_prompt: Enable (y/n) questions on warning or error. If False,
1514 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001515 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001516 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001517 parallel: if true, all tests specified by input_api.RunTests in all
1518 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001519
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001520 Warning:
1521 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1522 SHOULD be sys.stdin.
1523
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001524 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001525 A PresubmitOutput object. Use output.should_continue() to figure out
1526 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001527 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001528 old_environ = os.environ
1529 try:
1530 # Make sure python subprocesses won't generate .pyc files.
1531 os.environ = os.environ.copy()
1532 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001533
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001534 output = PresubmitOutput(input_stream, output_stream)
1535 if committing:
1536 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001537 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001538 output.write("Running presubmit upload checks ...\n")
1539 start_time = time.time()
1540 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001541 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001542 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001543 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001544 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001545 thread_pool = ThreadPool()
Aaron Gable668c1d82018-04-03 10:19:16 -07001546 executer = PresubmitExecuter(change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001547 gerrit_obj, dry_run, thread_pool)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001548 if default_presubmit:
1549 if verbose:
1550 output.write("Running default presubmit script.\n")
1551 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1552 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1553 for filename in presubmit_files:
1554 filename = os.path.abspath(filename)
1555 if verbose:
1556 output.write("Running %s\n" % filename)
1557 # Accept CRLF presubmit script.
1558 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1559 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001560
Edward Lesmes8e282792018-04-03 18:50:29 -04001561 results += thread_pool.RunAsync()
1562
Daniel Cheng7227d212017-11-17 08:12:37 -08001563 output.more_cc.extend(executer.more_cc)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001564 errors = []
1565 notifications = []
1566 warnings = []
1567 for result in results:
1568 if result.fatal:
1569 errors.append(result)
1570 elif result.should_prompt:
1571 warnings.append(result)
1572 else:
1573 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001574
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001575 output.write('\n')
1576 for name, items in (('Messages', notifications),
1577 ('Warnings', warnings),
1578 ('ERRORS', errors)):
1579 if items:
1580 output.write('** Presubmit %s **\n' % name)
1581 for item in items:
1582 item.handle(output)
1583 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001584
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001585 total_time = time.time() - start_time
1586 if total_time > 1.0:
1587 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001588
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001589 if errors:
1590 output.fail()
1591 elif warnings:
1592 output.write('There were presubmit warnings. ')
1593 if may_prompt:
1594 output.prompt_yes_no('Are you sure you wish to continue? (y/N): ')
1595 else:
1596 output.write('Presubmit checks passed.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001597
1598 global _ASKED_FOR_FEEDBACK
1599 # Ask for feedback one time out of 5.
1600 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001601 output.write(
1602 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1603 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1604 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001605 _ASKED_FOR_FEEDBACK = True
1606 return output
1607 finally:
1608 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001609
1610
1611def ScanSubDirs(mask, recursive):
1612 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001613 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001614
1615 results = []
1616 for root, dirs, files in os.walk('.'):
1617 if '.svn' in dirs:
1618 dirs.remove('.svn')
1619 if '.git' in dirs:
1620 dirs.remove('.git')
1621 for name in files:
1622 if fnmatch.fnmatch(name, mask):
1623 results.append(os.path.join(root, name))
1624 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001625
1626
1627def ParseFiles(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001628 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001629 files = []
1630 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001631 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001632 return files
1633
1634
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001635def load_files(options, args):
1636 """Tries to determine the SCM."""
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001637 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001638 if args:
1639 files = ParseFiles(args, options.recursive)
agable0b65e732016-11-22 09:25:46 -08001640 change_scm = scm.determine_scm(options.root)
1641 if change_scm == 'git':
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001642 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001643 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001644 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001645 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001646 else:
tobiasjs2836bcf2016-08-16 04:08:16 -07001647 logging.info('Doesn\'t seem under source control. Got %d files', len(args))
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001648 if not files:
1649 return None, None
1650 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001651 return change_class, files
1652
1653
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001654@contextlib.contextmanager
1655def canned_check_filter(method_names):
1656 filtered = {}
1657 try:
1658 for method_name in method_names:
1659 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001660 logging.warn('Skipping unknown "canned" check %s' % method_name)
1661 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001662 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1663 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1664 yield
1665 finally:
1666 for name, method in filtered.iteritems():
1667 setattr(presubmit_canned_checks, name, method)
1668
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001669
sbc@chromium.org013731e2015-02-26 18:28:43 +00001670def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001671 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001672 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001673 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001674 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001675 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1676 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001677 parser.add_option("-r", "--recursive", action="store_true",
1678 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001679 parser.add_option("-v", "--verbose", action="count", default=0,
1680 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001681 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001682 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001683 parser.add_option("--description", default='')
1684 parser.add_option("--issue", type='int', default=0)
1685 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001686 parser.add_option("--root", default=os.getcwd(),
1687 help="Search for PRESUBMIT.py up to this directory. "
1688 "If inherit-review-settings-ok is present in this "
1689 "directory, parent directories up to the root file "
1690 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001691 parser.add_option("--upstream",
1692 help="Git only: the base ref or upstream branch against "
1693 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001694 parser.add_option("--default_presubmit")
1695 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001696 parser.add_option("--skip_canned", action='append', default=[],
1697 help="A list of checks to skip which appear in "
1698 "presubmit_canned_checks. Can be provided multiple times "
1699 "to skip multiple canned checks.")
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001700 parser.add_option("--dry_run", action='store_true',
1701 help=optparse.SUPPRESS_HELP)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001702 parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP)
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001703 parser.add_option("--gerrit_fetch", action='store_true',
1704 help=optparse.SUPPRESS_HELP)
Edward Lesmes8e282792018-04-03 18:50:29 -04001705 parser.add_option('--parallel', action='store_true',
1706 help='Run all tests specified by input_api.RunTests in all '
1707 'PRESUBMIT files in parallel.')
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001708
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001709 options, args = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001710
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001711 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001712 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001713 elif options.verbose:
1714 logging.basicConfig(level=logging.INFO)
1715 else:
1716 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001717
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001718 change_class, files = load_files(options, args)
1719 if not change_class:
1720 parser.error('For unversioned directory, <files> is not optional.')
tobiasjs2836bcf2016-08-16 04:08:16 -07001721 logging.info('Found %d file(s).', len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001722
Aaron Gable668c1d82018-04-03 10:19:16 -07001723 gerrit_obj = None
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001724 if options.gerrit_url and options.gerrit_fetch:
tandrii@chromium.org83b1b232016-04-29 16:33:19 +00001725 assert options.issue and options.patchset
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001726 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1727 options.author = gerrit_obj.GetChangeOwner(options.issue)
1728 options.description = gerrit_obj.GetChangeDescription(options.issue,
1729 options.patchset)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001730 logging.info('Got author: "%s"', options.author)
1731 logging.info('Got description: """\n%s\n"""', options.description)
1732
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001733 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001734 with canned_check_filter(options.skip_canned):
1735 results = DoPresubmitChecks(
1736 change_class(options.name,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001737 options.description,
1738 options.root,
1739 files,
1740 options.issue,
1741 options.patchset,
1742 options.author,
1743 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001744 options.commit,
1745 options.verbose,
1746 sys.stdout,
1747 sys.stdin,
1748 options.default_presubmit,
1749 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001750 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001751 options.dry_run,
1752 options.parallel)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001753 return not results.should_continue()
1754 except PresubmitFailure, e:
1755 print >> sys.stderr, e
1756 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001757 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001758
1759
1760if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001761 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001762 try:
1763 sys.exit(main())
1764 except KeyboardInterrupt:
1765 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001766 sys.exit(2)