blob: 087b3e4e23bd38522a6cb0758e9a7a621ef59167 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
enne@chromium.orge72c5f52013-04-16 00:36:40 +000015import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000016import cPickle # Exposed through the API.
17import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000018import contextlib
dcheng091b7db2016-06-16 01:27:51 -070019import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000020import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000021import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000022import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000023import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000024import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000025import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000026import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000027import optparse
28import os # Somewhat exposed through the API.
29import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000030import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000031import re # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
jam@chromium.org2a891dc2009-08-20 20:33:37 +000034import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000035import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000036import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000038import urllib2 # Exposed through the API.
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000039import urlparse
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000040from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000041
42# Local imports.
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000043import auth
maruel@chromium.org35625c72011-03-23 17:34:02 +000044import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000045import gclient_utils
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000047import owners
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000048import presubmit_canned_checks
maruel@chromium.org239f4112011-06-03 20:08:23 +000049import rietveld
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000050import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000051import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000052
53
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000054# Ask for feedback only once in program lifetime.
55_ASKED_FOR_FEEDBACK = False
56
57
maruel@chromium.org899e1c12011-04-07 17:03:18 +000058class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000059 pass
60
61
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000062class CommandData(object):
63 def __init__(self, name, cmd, kwargs, message):
64 self.name = name
65 self.cmd = cmd
66 self.kwargs = kwargs
67 self.message = message
68 self.info = None
69
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000070
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000071def normpath(path):
72 '''Version of os.path.normpath that also changes backward slashes to
73 forward slashes when not running on Windows.
74 '''
75 # This is safe to always do because the Windows version of os.path.normpath
76 # will replace forward slashes with backward slashes.
77 path = path.replace(os.sep, '/')
78 return os.path.normpath(path)
79
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000080
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000081def _RightHandSideLinesImpl(affected_files):
82 """Implements RightHandSideLines for InputApi and GclChange."""
83 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000084 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000085 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000086 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000087
88
dpranke@chromium.org5ac21012011-03-16 02:58:25 +000089class PresubmitOutput(object):
90 def __init__(self, input_stream=None, output_stream=None):
91 self.input_stream = input_stream
92 self.output_stream = output_stream
93 self.reviewers = []
94 self.written_output = []
95 self.error_count = 0
96
97 def prompt_yes_no(self, prompt_string):
98 self.write(prompt_string)
99 if self.input_stream:
100 response = self.input_stream.readline().strip().lower()
101 if response not in ('y', 'yes'):
102 self.fail()
103 else:
104 self.fail()
105
106 def fail(self):
107 self.error_count += 1
108
109 def should_continue(self):
110 return not self.error_count
111
112 def write(self, s):
113 self.written_output.append(s)
114 if self.output_stream:
115 self.output_stream.write(s)
116
117 def getvalue(self):
118 return ''.join(self.written_output)
119
120
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000121# Top level object so multiprocessing can pickle
122# Public access through OutputApi object.
123class _PresubmitResult(object):
124 """Base class for result objects."""
125 fatal = False
126 should_prompt = False
127
128 def __init__(self, message, items=None, long_text=''):
129 """
130 message: A short one-line message to indicate errors.
131 items: A list of short strings to indicate where errors occurred.
132 long_text: multi-line text output, e.g. from another tool
133 """
134 self._message = message
135 self._items = items or []
136 if items:
137 self._items = items
138 self._long_text = long_text.rstrip()
139
140 def handle(self, output):
141 output.write(self._message)
142 output.write('\n')
143 for index, item in enumerate(self._items):
144 output.write(' ')
145 # Write separately in case it's unicode.
146 output.write(str(item))
147 if index < len(self._items) - 1:
148 output.write(' \\')
149 output.write('\n')
150 if self._long_text:
151 output.write('\n***************\n')
152 # Write separately in case it's unicode.
153 output.write(self._long_text)
154 output.write('\n***************\n')
155 if self.fatal:
156 output.fail()
157
158
159# Top level object so multiprocessing can pickle
160# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000161class _PresubmitError(_PresubmitResult):
162 """A hard presubmit error."""
163 fatal = True
164
165
166# Top level object so multiprocessing can pickle
167# Public access through OutputApi object.
168class _PresubmitPromptWarning(_PresubmitResult):
169 """An warning that prompts the user if they want to continue."""
170 should_prompt = True
171
172
173# Top level object so multiprocessing can pickle
174# Public access through OutputApi object.
175class _PresubmitNotifyResult(_PresubmitResult):
176 """Just print something to the screen -- but it's not even a warning."""
177 pass
178
179
180# Top level object so multiprocessing can pickle
181# Public access through OutputApi object.
182class _MailTextResult(_PresubmitResult):
183 """A warning that should be included in the review request email."""
184 def __init__(self, *args, **kwargs):
185 super(_MailTextResult, self).__init__()
186 raise NotImplementedError()
187
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000188class GerritAccessor(object):
189 """Limited Gerrit functionality for canned presubmit checks to work.
190
191 To avoid excessive Gerrit calls, caches the results.
192 """
193
194 def __init__(self, host):
195 self.host = host
196 self.cache = {}
197
198 def _FetchChangeDetail(self, issue):
199 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100200 try:
201 return gerrit_util.GetChangeDetail(
202 self.host, str(issue),
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100203 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'],
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100204 ignore_404=False)
205 except gerrit_util.GerritError as e:
206 if e.http_status == 404:
207 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
208 'no credentials to fetch issue details' % issue)
209 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000210
211 def GetChangeInfo(self, issue):
212 """Returns labels and all revisions (patchsets) for this issue.
213
214 The result is a dictionary according to Gerrit REST Api.
215 https://gerrit-review.googlesource.com/Documentation/rest-api.html
216
217 However, API isn't very clear what's inside, so see tests for example.
218 """
219 assert issue
220 cache_key = int(issue)
221 if cache_key not in self.cache:
222 self.cache[cache_key] = self._FetchChangeDetail(issue)
223 return self.cache[cache_key]
224
225 def GetChangeDescription(self, issue, patchset=None):
226 """If patchset is none, fetches current patchset."""
227 info = self.GetChangeInfo(issue)
228 # info is a reference to cache. We'll modify it here adding description to
229 # it to the right patchset, if it is not yet there.
230
231 # Find revision info for the patchset we want.
232 if patchset is not None:
233 for rev, rev_info in info['revisions'].iteritems():
234 if str(rev_info['_number']) == str(patchset):
235 break
236 else:
237 raise Exception('patchset %s doesn\'t exist in issue %s' % (
238 patchset, issue))
239 else:
240 rev = info['current_revision']
241 rev_info = info['revisions'][rev]
242
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100243 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000244
245 def GetChangeOwner(self, issue):
246 return self.GetChangeInfo(issue)['owner']['email']
247
248 def GetChangeReviewers(self, issue, approving_only=True):
agable565adb52016-07-22 14:48:07 -0700249 cr = self.GetChangeInfo(issue)['labels']['Code-Review']
250 max_value = max(int(k) for k in cr['values'].keys())
Aaron Gablef5644a92016-12-02 15:31:58 -0800251 return [r.get('email') for r in cr.get('all', [])
agable565adb52016-07-22 14:48:07 -0700252 if not approving_only or r.get('value', 0) == max_value]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000253
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000254
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000255class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000256 """An instance of OutputApi gets passed to presubmit scripts so that they
257 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000258 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000259 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000260 PresubmitError = _PresubmitError
261 PresubmitPromptWarning = _PresubmitPromptWarning
262 PresubmitNotifyResult = _PresubmitNotifyResult
263 MailTextResult = _MailTextResult
264
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000265 def __init__(self, is_committing):
266 self.is_committing = is_committing
267
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000268 def PresubmitPromptOrNotify(self, *args, **kwargs):
269 """Warn the user when uploading, but only notify if committing."""
270 if self.is_committing:
271 return self.PresubmitNotifyResult(*args, **kwargs)
272 return self.PresubmitPromptWarning(*args, **kwargs)
273
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800274 def EnsureCQIncludeTrybotsAreAdded(self, cl, bots_to_include, message):
275 """Helper for any PostUploadHook wishing to add CQ_INCLUDE_TRYBOTS.
276
277 Merges the bots_to_include into the current CQ_INCLUDE_TRYBOTS list,
278 keeping it alphabetically sorted. Returns the results that should be
279 returned from the PostUploadHook.
280
281 Args:
282 cl: The git_cl.Changelist object.
283 bots_to_include: A list of strings of bots to include, in the form
284 "master:slave".
285 message: A message to be printed in the case that
286 CQ_INCLUDE_TRYBOTS was updated.
287 """
288 description = cl.GetDescription(force=True)
289 all_bots = []
290 include_re = re.compile(r'^CQ_INCLUDE_TRYBOTS=(.*)', re.M | re.I)
291 m = include_re.search(description)
292 if m:
293 all_bots = [i.strip() for i in m.group(1).split(';') if i.strip()]
294 if set(all_bots) >= set(bots_to_include):
295 return []
296 # Sort the bots to keep them in some consistent order -- not required.
297 all_bots = sorted(set(all_bots) | set(bots_to_include))
298 new_include_trybots = 'CQ_INCLUDE_TRYBOTS=%s' % ';'.join(all_bots)
299 if m:
300 new_description = include_re.sub(new_include_trybots, description)
301 else:
302 new_description = description + '\n' + new_include_trybots + '\n'
303 cl.UpdateDescription(new_description, force=True)
304 return [self.PresubmitNotifyResult(message)]
305
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000306
307class InputApi(object):
308 """An instance of this object is passed to presubmit scripts so they can
309 know stuff about the change they're looking at.
310 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000311 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800312 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000313
maruel@chromium.org3410d912009-06-09 20:56:16 +0000314 # File extensions that are considered source files from a style guide
315 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000316 #
317 # Files without an extension aren't included in the list. If you want to
318 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
319 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000320 DEFAULT_WHITE_LIST = (
321 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000322 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
323 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000324 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000325 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000326 # Other
estade@chromium.orgae7af922012-01-27 14:51:13 +0000327 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000328 )
329
330 # Path regexp that should be excluded from being considered containing source
331 # files. Don't modify this list from a presubmit script!
332 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000333 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000334 r".*\bexperimental[\\\/].*",
primiano@chromium.orgb9658c32015-10-06 10:50:13 +0000335 # Exclude third_party/.* but NOT third_party/WebKit (crbug.com/539768).
336 r".*\bthird_party[\\\/](?!WebKit[\\\/]).*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000337 # Output directories (just in case)
338 r".*\bDebug[\\\/].*",
339 r".*\bRelease[\\\/].*",
340 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000341 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000342 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000343 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000344 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000345 r"(|.*[\\\/])\.git[\\\/].*",
346 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000347 # There is no point in processing a patch file.
348 r".+\.diff$",
349 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000350 )
351
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000352 def __init__(self, change, presubmit_path, is_committing,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000353 rietveld_obj, verbose, gerrit_obj=None, dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000354 """Builds an InputApi object.
355
356 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000357 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000358 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000359 is_committing: True if the change is about to be committed.
maruel@chromium.org239f4112011-06-03 20:08:23 +0000360 rietveld_obj: rietveld.Rietveld client object
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000361 gerrit_obj: provides basic Gerrit codereview functionality.
362 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000363 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000364 # Version number of the presubmit_support script.
365 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000366 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000367 self.is_committing = is_committing
maruel@chromium.org239f4112011-06-03 20:08:23 +0000368 self.rietveld = rietveld_obj
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000369 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000370 self.dry_run = dry_run
maruel@chromium.orgcab38e92011-04-09 00:30:51 +0000371 # TBD
372 self.host_url = 'http://codereview.chromium.org'
373 if self.rietveld:
maruel@chromium.org239f4112011-06-03 20:08:23 +0000374 self.host_url = self.rietveld.url
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000375
376 # We expose various modules and functions as attributes of the input_api
377 # so that presubmit scripts don't have to import them.
378 self.basename = os.path.basename
379 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000380 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000381 self.cStringIO = cStringIO
dcheng091b7db2016-06-16 01:27:51 -0700382 self.fnmatch = fnmatch
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000383 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000384 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000385 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000386 self.os_listdir = os.listdir
387 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000388 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000389 self.os_stat = os.stat
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000390 self.pickle = pickle
391 self.marshal = marshal
392 self.re = re
393 self.subprocess = subprocess
394 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000395 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000396 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000397 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000398 self.urllib2 = urllib2
399
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000400 # To easily fork python.
401 self.python_executable = sys.executable
402 self.environ = os.environ
403
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000404 # InputApi.platform is the platform you're currently running on.
405 self.platform = sys.platform
406
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000407 self.cpu_count = multiprocessing.cpu_count()
408
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000409 # this is done here because in RunTests, the current working directory has
410 # changed, which causes Pool() to explode fantastically when run on windows
411 # (because it tries to load the __main__ module, which imports lots of
412 # things relative to the current working directory).
413 self._run_tests_pool = multiprocessing.Pool(self.cpu_count)
414
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000415 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000416 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000417
418 # We carry the canned checks so presubmit scripts can easily use them.
419 self.canned_checks = presubmit_canned_checks
420
Jochen Eisinger72606f82017-04-04 10:44:18 +0200421
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000422 # TODO(dpranke): figure out a list of all approved owners for a repo
423 # in order to be able to handle wildcard OWNERS files?
424 self.owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +0200425 change.GetOwnersStatusFile(),
426 fopen=file, os_path=self.os_path)
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000427 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000428 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000429
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000430 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000431 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000432 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800433 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000434 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000435 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000436 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
437 for (a, b, header) in cpplint._re_pattern_templates
438 ]
439
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000440 def PresubmitLocalPath(self):
441 """Returns the local path of the presubmit script currently being run.
442
443 This is useful if you don't want to hard-code absolute paths in the
444 presubmit script. For example, It can be used to find another file
445 relative to the PRESUBMIT.py script, so the whole tree can be branched and
446 the presubmit script still works, without editing its content.
447 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000448 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000449
agable0b65e732016-11-22 09:25:46 -0800450 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000451 """Same as input_api.change.AffectedFiles() except only lists files
452 (and optionally directories) in the same directory as the current presubmit
453 script, or subdirectories thereof.
454 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000455 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000456 if len(dir_with_slash) == 1:
457 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000458
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000459 return filter(
460 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
agable0b65e732016-11-22 09:25:46 -0800461 self.change.AffectedFiles(include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000462
agable0b65e732016-11-22 09:25:46 -0800463 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000464 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800465 paths = [af.LocalPath() for af in self.AffectedFiles()]
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000466 logging.debug("LocalPaths: %s", paths)
467 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000468
agable0b65e732016-11-22 09:25:46 -0800469 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000470 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800471 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000472
agable0b65e732016-11-22 09:25:46 -0800473 def AffectedTestableFiles(self, include_deletes=None):
474 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000475 in the same directory as the current presubmit script, or subdirectories
476 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000477 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000478 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800479 warn("AffectedTestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000480 " is deprecated and ignored" % str(include_deletes),
481 category=DeprecationWarning,
482 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -0800483 return filter(lambda x: x.IsTestableFile(),
484 self.AffectedFiles(include_deletes=False))
485
486 def AffectedTextFiles(self, include_deletes=None):
487 """An alias to AffectedTestableFiles for backwards compatibility."""
488 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000489
maruel@chromium.org3410d912009-06-09 20:56:16 +0000490 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
491 """Filters out files that aren't considered "source file".
492
493 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
494 and InputApi.DEFAULT_BLACK_LIST is used respectively.
495
496 The lists will be compiled as regular expression and
497 AffectedFile.LocalPath() needs to pass both list.
498
499 Note: Copy-paste this function to suit your needs or use a lambda function.
500 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000501 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000502 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000503 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000504 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000505 return True
506 return False
507 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
508 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
509
510 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800511 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000512
513 If source_file is None, InputApi.FilterSourceFile() is used.
514 """
515 if not source_file:
516 source_file = self.FilterSourceFile
agable0b65e732016-11-22 09:25:46 -0800517 return filter(source_file, self.AffectedTestableFiles())
maruel@chromium.org3410d912009-06-09 20:56:16 +0000518
519 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000520 """An iterator over all text lines in "new" version of changed files.
521
522 Only lists lines from new or modified text files in the change that are
523 contained by the directory of the currently executing presubmit script.
524
525 This is useful for doing line-by-line regex checks, like checking for
526 trailing whitespace.
527
528 Yields:
529 a 3 tuple:
530 the AffectedFile instance of the current file;
531 integer line number (1-based); and
532 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000533
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000534 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000535 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000536 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000537 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000538
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000539 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000540 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000541
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000542 Deny reading anything outside the repository.
543 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000544 if isinstance(file_item, AffectedFile):
545 file_item = file_item.AbsoluteLocalPath()
546 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000547 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000548 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000549
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000550 @property
551 def tbr(self):
552 """Returns if a change is TBR'ed."""
553 return 'TBR' in self.change.tags
554
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000555 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000556 tests = []
557 msgs = []
558 for t in tests_mix:
559 if isinstance(t, OutputApi.PresubmitResult):
560 msgs.append(t)
561 else:
562 assert issubclass(t.message, _PresubmitResult)
563 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000564 if self.verbose:
565 t.info = _PresubmitNotifyResult
ilevy@chromium.org5678d332013-05-18 01:34:14 +0000566 if len(tests) > 1 and parallel:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000567 # async recipe works around multiprocessing bug handling Ctrl-C
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000568 msgs.extend(self._run_tests_pool.map_async(CallCommand, tests).get(99999))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000569 else:
570 msgs.extend(map(CallCommand, tests))
571 return [m for m in msgs if m]
572
scottmg86099d72016-09-01 09:16:51 -0700573 def ShutdownPool(self):
574 self._run_tests_pool.close()
575 self._run_tests_pool.join()
576 self._run_tests_pool = None
577
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000578
nick@chromium.orgff526192013-06-10 19:30:26 +0000579class _DiffCache(object):
580 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000581 def __init__(self, upstream=None):
582 """Stores the upstream revision against which all diffs will be computed."""
583 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000584
585 def GetDiff(self, path, local_root):
586 """Get the diff for a particular path."""
587 raise NotImplementedError()
588
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700589 def GetOldContents(self, path, local_root):
590 """Get the old version for a particular path."""
591 raise NotImplementedError()
592
nick@chromium.orgff526192013-06-10 19:30:26 +0000593
nick@chromium.orgff526192013-06-10 19:30:26 +0000594class _GitDiffCache(_DiffCache):
595 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000596 def __init__(self, upstream):
597 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000598 self._diffs_by_file = None
599
600 def GetDiff(self, path, local_root):
601 if not self._diffs_by_file:
602 # Compute a single diff for all files and parse the output; should
603 # with git this is much faster than computing one diff for each file.
604 diffs = {}
605
606 # Don't specify any filenames below, because there are command line length
607 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000608 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
609 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000610
611 # This regex matches the path twice, separated by a space. Note that
612 # filename itself may contain spaces.
613 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
614 current_diff = []
615 keep_line_endings = True
616 for x in unified_diff.splitlines(keep_line_endings):
617 match = file_marker.match(x)
618 if match:
619 # Marks the start of a new per-file section.
620 diffs[match.group('filename')] = current_diff = [x]
621 elif x.startswith('diff --git'):
622 raise PresubmitFailure('Unexpected diff line: %s' % x)
623 else:
624 current_diff.append(x)
625
626 self._diffs_by_file = dict(
627 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
628
629 if path not in self._diffs_by_file:
630 raise PresubmitFailure(
631 'Unified diff did not contain entry for file %s' % path)
632
633 return self._diffs_by_file[path]
634
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700635 def GetOldContents(self, path, local_root):
636 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
637
nick@chromium.orgff526192013-06-10 19:30:26 +0000638
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000639class AffectedFile(object):
640 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000641
642 DIFF_CACHE = _DiffCache
643
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000644 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800645 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000646 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000647 self._path = path
648 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000649 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000650 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000651 self._cached_changed_contents = None
652 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000653 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700654 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000655
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000656 def LocalPath(self):
657 """Returns the path of this file on the local disk relative to client root.
658 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000659 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000660
661 def AbsoluteLocalPath(self):
662 """Returns the absolute path of this file on the local disk.
663 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000664 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000665
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000666 def Action(self):
667 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000668 # TODO(maruel): Somewhat crappy, Could be "A" or "A +" for svn but
669 # different for other SCM.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000670 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000671
agable0b65e732016-11-22 09:25:46 -0800672 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000673 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000674
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000675 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000676 raise NotImplementedError() # Implement when needed
677
agable0b65e732016-11-22 09:25:46 -0800678 def IsTextFile(self):
679 """An alias to IsTestableFile for backwards compatibility."""
680 return self.IsTestableFile()
681
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700682 def OldContents(self):
683 """Returns an iterator over the lines in the old version of file.
684
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700685 The old version is the file before any modifications in the user's
686 workspace, i.e. the "left hand side".
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700687
688 Contents will be empty if the file is a directory or does not exist.
689 Note: The carriage returns (LF or CR) are stripped off.
690 """
691 return self._diff_cache.GetOldContents(self.LocalPath(),
692 self._local_root).splitlines()
693
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000694 def NewContents(self):
695 """Returns an iterator over the lines in the new version of file.
696
697 The new version is the file in the user's workspace, i.e. the "right hand
698 side".
699
700 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000701 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000702 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000703 if self._cached_new_contents is None:
704 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800705 try:
706 self._cached_new_contents = gclient_utils.FileRead(
707 self.AbsoluteLocalPath(), 'rU').splitlines()
708 except IOError:
709 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000710 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000711
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000712 def ChangedContents(self):
713 """Returns a list of tuples (line number, line text) of all new lines.
714
715 This relies on the scm diff output describing each changed code section
716 with a line of the form
717
718 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
719 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000720 if self._cached_changed_contents is not None:
721 return self._cached_changed_contents[:]
722 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000723 line_num = 0
724
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000725 for line in self.GenerateScmDiff().splitlines():
726 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
727 if m:
728 line_num = int(m.groups(1)[0])
729 continue
730 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000731 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000732 if not line.startswith('-'):
733 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000734 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000735
maruel@chromium.org5de13972009-06-10 18:16:06 +0000736 def __str__(self):
737 return self.LocalPath()
738
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000739 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000740 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000741
maruel@chromium.org58407af2011-04-12 23:15:57 +0000742
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000743class GitAffectedFile(AffectedFile):
744 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000745 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800746 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000747
nick@chromium.orgff526192013-06-10 19:30:26 +0000748 DIFF_CACHE = _GitDiffCache
749
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000750 def __init__(self, *args, **kwargs):
751 AffectedFile.__init__(self, *args, **kwargs)
752 self._server_path = None
agable0b65e732016-11-22 09:25:46 -0800753 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000754
agable0b65e732016-11-22 09:25:46 -0800755 def IsTestableFile(self):
756 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000757 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -0800758 # A deleted file is not testable.
759 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000760 else:
agable0b65e732016-11-22 09:25:46 -0800761 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
762 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000763
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000764
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000765class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000766 """Describe a change.
767
768 Used directly by the presubmit scripts to query the current change being
769 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000770
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000771 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000772 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000773 self.KEY: equivalent to tags['KEY']
774 """
775
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000776 _AFFECTED_FILES = AffectedFile
777
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000778 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000779 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000780 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000781 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000782
maruel@chromium.org58407af2011-04-12 23:15:57 +0000783 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000784 self, name, description, local_root, files, issue, patchset, author,
785 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000786 if files is None:
787 files = []
788 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +0000789 # Convert root into an absolute path.
790 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000791 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000792 self.issue = issue
793 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +0000794 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000795
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000796 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000797 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000798 self._description_without_tags = ''
799 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000800
maruel@chromium.orge085d812011-10-10 19:49:15 +0000801 assert all(
802 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
803
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000804 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000805 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +0000806 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
807 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000808 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000809
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000810 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000811 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000812 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000813
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000814 def DescriptionText(self):
815 """Returns the user-entered changelist description, minus tags.
816
817 Any line in the user-provided description starting with e.g. "FOO="
818 (whitespace permitted before and around) is considered a tag line. Such
819 lines are stripped out of the description this function returns.
820 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000821 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000822
823 def FullDescriptionText(self):
824 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000825 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000826
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000827 def SetDescriptionText(self, description):
828 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +0000829
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000830 Also updates the list of tags."""
831 self._full_description = description
832
833 # From the description text, build up a dictionary of key/value pairs
834 # plus the description minus all key/value or "tag" lines.
835 description_without_tags = []
836 self.tags = {}
837 for line in self._full_description.splitlines():
838 m = self.TAG_LINE_RE.match(line)
839 if m:
840 self.tags[m.group('key')] = m.group('value')
841 else:
842 description_without_tags.append(line)
843
844 # Change back to text and remove whitespace at end.
845 self._description_without_tags = (
846 '\n'.join(description_without_tags).rstrip())
847
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000848 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000849 """Returns the repository (checkout) root directory for this change,
850 as an absolute path.
851 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000852 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000853
854 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000855 """Return tags directly as attributes on the object."""
856 if not re.match(r"^[A-Z_]*$", attr):
857 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +0000858 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000859
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000860 def AllFiles(self, root=None):
861 """List all files under source control in the repo."""
862 raise NotImplementedError()
863
agable0b65e732016-11-22 09:25:46 -0800864 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000865 """Returns a list of AffectedFile instances for all files in the change.
866
867 Args:
868 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +0000869 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000870
871 Returns:
872 [AffectedFile(path, action), AffectedFile(path, action)]
873 """
agable0b65e732016-11-22 09:25:46 -0800874 affected = filter(file_filter, self._affected_files)
sail@chromium.org5538e022011-05-12 17:53:16 +0000875
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000876 if include_deletes:
877 return affected
878 else:
879 return filter(lambda x: x.Action() != 'D', affected)
880
agable0b65e732016-11-22 09:25:46 -0800881 def AffectedTestableFiles(self, include_deletes=None):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000882 """Return a list of the existing text files in a change."""
883 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800884 warn("AffectedTeestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000885 " is deprecated and ignored" % str(include_deletes),
886 category=DeprecationWarning,
887 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -0800888 return filter(lambda x: x.IsTestableFile(),
889 self.AffectedFiles(include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000890
agable0b65e732016-11-22 09:25:46 -0800891 def AffectedTextFiles(self, include_deletes=None):
892 """An alias to AffectedTestableFiles for backwards compatibility."""
893 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000894
agable0b65e732016-11-22 09:25:46 -0800895 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000896 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -0800897 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000898
agable0b65e732016-11-22 09:25:46 -0800899 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000900 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -0800901 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000902
903 def RightHandSideLines(self):
904 """An iterator over all text lines in "new" version of changed files.
905
906 Lists lines from new or modified text files in the change.
907
908 This is useful for doing line-by-line regex checks, like checking for
909 trailing whitespace.
910
911 Yields:
912 a 3 tuple:
913 the AffectedFile instance of the current file;
914 integer line number (1-based); and
915 the contents of the line as a string.
916 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000917 return _RightHandSideLinesImpl(
918 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -0800919 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000920
Jochen Eisinger72606f82017-04-04 10:44:18 +0200921 def GetOwnersStatusFile(self):
922 """Returns the name of the global OWNERS status file."""
923 return None
924
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000925
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000926class GitChange(Change):
927 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000928 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000929
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000930 def AllFiles(self, root=None):
931 """List all files under source control in the repo."""
932 root = root or self.RepositoryRoot()
933 return subprocess.check_output(
934 ['git', 'ls-files', '--', '.'], cwd=root).splitlines()
935
Jochen Eisinger72606f82017-04-04 10:44:18 +0200936 def GetOwnersStatusFile(self):
937 """Returns the name of the global OWNERS status file."""
938
939 try:
940 status_file = subprocess.check_output(
941 ['git', 'config', 'rietveld.owners-status-file'],
942 cwd=self.RepositoryRoot())
943 return status_file
944 except subprocess.CalledProcessError:
945 pass
946
947 return None
948
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000949
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000950def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000951 """Finds all presubmit files that apply to a given set of source files.
952
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000953 If inherit-review-settings-ok is present right under root, looks for
954 PRESUBMIT.py in directories enclosing root.
955
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000956 Args:
957 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000958 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000959
960 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000961 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000962 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000963 files = [normpath(os.path.join(root, f)) for f in files]
964
965 # List all the individual directories containing files.
966 directories = set([os.path.dirname(f) for f in files])
967
968 # Ignore root if inherit-review-settings-ok is present.
969 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
970 root = None
971
972 # Collect all unique directories that may contain PRESUBMIT.py.
973 candidates = set()
974 for directory in directories:
975 while True:
976 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000977 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000978 candidates.add(directory)
979 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000980 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000981 parent_dir = os.path.dirname(directory)
982 if parent_dir == directory:
983 # We hit the system root directory.
984 break
985 directory = parent_dir
986
987 # Look for PRESUBMIT.py in all candidate directories.
988 results = []
989 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -0700990 try:
991 for f in os.listdir(directory):
992 p = os.path.join(directory, f)
993 if os.path.isfile(p) and re.match(
994 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
995 results.append(p)
996 except OSError:
997 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000998
tobiasjs2836bcf2016-08-16 04:08:16 -0700999 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001000 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001001
1002
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001003class GetTryMastersExecuter(object):
1004 @staticmethod
1005 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1006 """Executes GetPreferredTryMasters() from a single presubmit script.
1007
1008 Args:
1009 script_text: The text of the presubmit script.
1010 presubmit_path: Project script to run.
1011 project: Project name to pass to presubmit script for bot selection.
1012
1013 Return:
1014 A map of try masters to map of builders to set of tests.
1015 """
1016 context = {}
1017 try:
1018 exec script_text in context
1019 except Exception, e:
1020 raise PresubmitFailure('"%s" had an exception.\n%s'
1021 % (presubmit_path, e))
1022
1023 function_name = 'GetPreferredTryMasters'
1024 if function_name not in context:
1025 return {}
1026 get_preferred_try_masters = context[function_name]
1027 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1028 raise PresubmitFailure(
1029 'Expected function "GetPreferredTryMasters" to take two arguments.')
1030 return get_preferred_try_masters(project, change)
1031
1032
rmistry@google.com5626a922015-02-26 14:03:30 +00001033class GetPostUploadExecuter(object):
1034 @staticmethod
1035 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1036 """Executes PostUploadHook() from a single presubmit script.
1037
1038 Args:
1039 script_text: The text of the presubmit script.
1040 presubmit_path: Project script to run.
1041 cl: The Changelist object.
1042 change: The Change object.
1043
1044 Return:
1045 A list of results objects.
1046 """
1047 context = {}
1048 try:
1049 exec script_text in context
1050 except Exception, e:
1051 raise PresubmitFailure('"%s" had an exception.\n%s'
1052 % (presubmit_path, e))
1053
1054 function_name = 'PostUploadHook'
1055 if function_name not in context:
1056 return {}
1057 post_upload_hook = context[function_name]
1058 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1059 raise PresubmitFailure(
1060 'Expected function "PostUploadHook" to take three arguments.')
1061 return post_upload_hook(cl, change, OutputApi(False))
1062
1063
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001064def _MergeMasters(masters1, masters2):
1065 """Merges two master maps. Merges also the tests of each builder."""
1066 result = {}
1067 for (master, builders) in itertools.chain(masters1.iteritems(),
1068 masters2.iteritems()):
1069 new_builders = result.setdefault(master, {})
1070 for (builder, tests) in builders.iteritems():
1071 new_builders.setdefault(builder, set([])).update(tests)
1072 return result
1073
1074
1075def DoGetTryMasters(change,
1076 changed_files,
1077 repository_root,
1078 default_presubmit,
1079 project,
1080 verbose,
1081 output_stream):
1082 """Get the list of try masters from the presubmit scripts.
1083
1084 Args:
1085 changed_files: List of modified files.
1086 repository_root: The repository root.
1087 default_presubmit: A default presubmit script to execute in any case.
1088 project: Optional name of a project used in selecting trybots.
1089 verbose: Prints debug info.
1090 output_stream: A stream to write debug output to.
1091
1092 Return:
1093 Map of try masters to map of builders to set of tests.
1094 """
1095 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1096 if not presubmit_files and verbose:
1097 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1098 results = {}
1099 executer = GetTryMastersExecuter()
1100
1101 if default_presubmit:
1102 if verbose:
1103 output_stream.write("Running default presubmit script.\n")
1104 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1105 results = _MergeMasters(results, executer.ExecPresubmitScript(
1106 default_presubmit, fake_path, project, change))
1107 for filename in presubmit_files:
1108 filename = os.path.abspath(filename)
1109 if verbose:
1110 output_stream.write("Running %s\n" % filename)
1111 # Accept CRLF presubmit script.
1112 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1113 results = _MergeMasters(results, executer.ExecPresubmitScript(
1114 presubmit_script, filename, project, change))
1115
1116 # Make sets to lists again for later JSON serialization.
1117 for builders in results.itervalues():
1118 for builder in builders:
1119 builders[builder] = list(builders[builder])
1120
1121 if results and verbose:
1122 output_stream.write('%s\n' % str(results))
1123 return results
1124
1125
rmistry@google.com5626a922015-02-26 14:03:30 +00001126def DoPostUploadExecuter(change,
1127 cl,
1128 repository_root,
1129 verbose,
1130 output_stream):
1131 """Execute the post upload hook.
1132
1133 Args:
1134 change: The Change object.
1135 cl: The Changelist object.
1136 repository_root: The repository root.
1137 verbose: Prints debug info.
1138 output_stream: A stream to write debug output to.
1139 """
1140 presubmit_files = ListRelevantPresubmitFiles(
1141 change.LocalPaths(), repository_root)
1142 if not presubmit_files and verbose:
1143 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1144 results = []
1145 executer = GetPostUploadExecuter()
1146 # The root presubmit file should be executed after the ones in subdirectories.
1147 # i.e. the specific post upload hooks should run before the general ones.
1148 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1149 presubmit_files.reverse()
1150
1151 for filename in presubmit_files:
1152 filename = os.path.abspath(filename)
1153 if verbose:
1154 output_stream.write("Running %s\n" % filename)
1155 # Accept CRLF presubmit script.
1156 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1157 results.extend(executer.ExecPresubmitScript(
1158 presubmit_script, filename, cl, change))
1159 output_stream.write('\n')
1160 if results:
1161 output_stream.write('** Post Upload Hook Messages **\n')
1162 for result in results:
1163 result.handle(output_stream)
1164 output_stream.write('\n')
1165
1166 return results
1167
1168
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001169class PresubmitExecuter(object):
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001170 def __init__(self, change, committing, rietveld_obj, verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001171 gerrit_obj=None, dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001172 """
1173 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001174 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001175 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001176 rietveld_obj: rietveld.Rietveld client object.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001177 gerrit_obj: provides basic Gerrit codereview functionality.
1178 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001179 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001180 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001181 self.committing = committing
maruel@chromium.org239f4112011-06-03 20:08:23 +00001182 self.rietveld = rietveld_obj
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001183 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001184 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001185 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001186
1187 def ExecPresubmitScript(self, script_text, presubmit_path):
1188 """Executes a single presubmit script.
1189
1190 Args:
1191 script_text: The text of the presubmit script.
1192 presubmit_path: The path to the presubmit file (this will be reported via
1193 input_api.PresubmitLocalPath()).
1194
1195 Return:
1196 A list of result objects, empty if no problems.
1197 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001198
chase@chromium.org8e416c82009-10-06 04:30:44 +00001199 # Change to the presubmit file's directory to support local imports.
1200 main_path = os.getcwd()
1201 os.chdir(os.path.dirname(presubmit_path))
1202
1203 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001204 input_api = InputApi(self.change, presubmit_path, self.committing,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001205 self.rietveld, self.verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001206 gerrit_obj=self.gerrit, dry_run=self.dry_run)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001207 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001208 try:
1209 exec script_text in context
1210 except Exception, e:
1211 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001212
1213 # These function names must change if we make substantial changes to
1214 # the presubmit API that are not backwards compatible.
1215 if self.committing:
1216 function_name = 'CheckChangeOnCommit'
1217 else:
1218 function_name = 'CheckChangeOnUpload'
1219 if function_name in context:
wez@chromium.orga6d011e2013-03-26 17:31:49 +00001220 context['__args'] = (input_api, OutputApi(self.committing))
tobiasjs2836bcf2016-08-16 04:08:16 -07001221 logging.debug('Running %s in %s', function_name, presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001222 result = eval(function_name + '(*__args)', context)
tobiasjs2836bcf2016-08-16 04:08:16 -07001223 logging.debug('Running %s done.', function_name)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001224 if not (isinstance(result, types.TupleType) or
1225 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001226 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001227 'Presubmit functions must return a tuple or list')
1228 for item in result:
1229 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001230 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001231 'All presubmit results must be of types derived from '
1232 'output_api.PresubmitResult')
1233 else:
1234 result = () # no error since the script doesn't care about current event.
1235
scottmg86099d72016-09-01 09:16:51 -07001236 input_api.ShutdownPool()
1237
chase@chromium.org8e416c82009-10-06 04:30:44 +00001238 # Return the process to the original working directory.
1239 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001240 return result
1241
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001242def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001243 committing,
1244 verbose,
1245 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001246 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001247 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001248 may_prompt,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001249 rietveld_obj,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001250 gerrit_obj=None,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001251 dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001252 """Runs all presubmit checks that apply to the files in the change.
1253
1254 This finds all PRESUBMIT.py files in directories enclosing the files in the
1255 change (up to the repository root) and calls the relevant entrypoint function
1256 depending on whether the change is being committed or uploaded.
1257
1258 Prints errors, warnings and notifications. Prompts the user for warnings
1259 when needed.
1260
1261 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001262 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001263 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001264 verbose: Prints debug info.
1265 output_stream: A stream to write output from presubmit tests to.
1266 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001267 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001268 may_prompt: Enable (y/n) questions on warning or error. If False,
1269 any questions are answered with yes by default.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001270 rietveld_obj: rietveld.Rietveld object.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001271 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001272 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001273
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001274 Warning:
1275 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1276 SHOULD be sys.stdin.
1277
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001278 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001279 A PresubmitOutput object. Use output.should_continue() to figure out
1280 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001281 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001282 old_environ = os.environ
1283 try:
1284 # Make sure python subprocesses won't generate .pyc files.
1285 os.environ = os.environ.copy()
1286 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001287
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001288 output = PresubmitOutput(input_stream, output_stream)
1289 if committing:
1290 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001291 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001292 output.write("Running presubmit upload checks ...\n")
1293 start_time = time.time()
1294 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001295 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001296 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001297 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001298 results = []
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001299 executer = PresubmitExecuter(change, committing, rietveld_obj, verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001300 gerrit_obj, dry_run)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001301 if default_presubmit:
1302 if verbose:
1303 output.write("Running default presubmit script.\n")
1304 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1305 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1306 for filename in presubmit_files:
1307 filename = os.path.abspath(filename)
1308 if verbose:
1309 output.write("Running %s\n" % filename)
1310 # Accept CRLF presubmit script.
1311 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1312 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001313
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001314 errors = []
1315 notifications = []
1316 warnings = []
1317 for result in results:
1318 if result.fatal:
1319 errors.append(result)
1320 elif result.should_prompt:
1321 warnings.append(result)
1322 else:
1323 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001324
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001325 output.write('\n')
1326 for name, items in (('Messages', notifications),
1327 ('Warnings', warnings),
1328 ('ERRORS', errors)):
1329 if items:
1330 output.write('** Presubmit %s **\n' % name)
1331 for item in items:
1332 item.handle(output)
1333 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001334
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001335 total_time = time.time() - start_time
1336 if total_time > 1.0:
1337 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001338
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001339 if errors:
1340 output.fail()
1341 elif warnings:
1342 output.write('There were presubmit warnings. ')
1343 if may_prompt:
1344 output.prompt_yes_no('Are you sure you wish to continue? (y/N): ')
1345 else:
1346 output.write('Presubmit checks passed.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001347
1348 global _ASKED_FOR_FEEDBACK
1349 # Ask for feedback one time out of 5.
1350 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001351 output.write(
1352 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1353 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1354 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001355 _ASKED_FOR_FEEDBACK = True
1356 return output
1357 finally:
1358 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001359
1360
1361def ScanSubDirs(mask, recursive):
1362 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001363 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001364 else:
1365 results = []
1366 for root, dirs, files in os.walk('.'):
1367 if '.svn' in dirs:
1368 dirs.remove('.svn')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001369 if '.git' in dirs:
1370 dirs.remove('.git')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001371 for name in files:
1372 if fnmatch.fnmatch(name, mask):
1373 results.append(os.path.join(root, name))
1374 return results
1375
1376
1377def ParseFiles(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001378 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001379 files = []
1380 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001381 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001382 return files
1383
1384
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001385def load_files(options, args):
1386 """Tries to determine the SCM."""
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001387 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001388 if args:
1389 files = ParseFiles(args, options.recursive)
agable0b65e732016-11-22 09:25:46 -08001390 change_scm = scm.determine_scm(options.root)
1391 if change_scm == 'git':
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001392 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001393 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001394 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001395 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001396 else:
tobiasjs2836bcf2016-08-16 04:08:16 -07001397 logging.info('Doesn\'t seem under source control. Got %d files', len(args))
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001398 if not files:
1399 return None, None
1400 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001401 return change_class, files
1402
1403
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001404class NonexistantCannedCheckFilter(Exception):
1405 pass
1406
1407
1408@contextlib.contextmanager
1409def canned_check_filter(method_names):
1410 filtered = {}
1411 try:
1412 for method_name in method_names:
1413 if not hasattr(presubmit_canned_checks, method_name):
1414 raise NonexistantCannedCheckFilter(method_name)
1415 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1416 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1417 yield
1418 finally:
1419 for name, method in filtered.iteritems():
1420 setattr(presubmit_canned_checks, name, method)
1421
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001422
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001423def CallCommand(cmd_data):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001424 """Runs an external program, potentially from a child process created by the
1425 multiprocessing module.
1426
1427 multiprocessing needs a top level function with a single argument.
1428 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001429 cmd_data.kwargs['stdout'] = subprocess.PIPE
1430 cmd_data.kwargs['stderr'] = subprocess.STDOUT
1431 try:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001432 start = time.time()
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001433 (out, _), code = subprocess.communicate(cmd_data.cmd, **cmd_data.kwargs)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001434 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001435 except OSError as e:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001436 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001437 return cmd_data.message(
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001438 '%s exec failure (%4.2fs)\n %s' % (cmd_data.name, duration, e))
1439 if code != 0:
1440 return cmd_data.message(
1441 '%s (%4.2fs) failed\n%s' % (cmd_data.name, duration, out))
1442 if cmd_data.info:
1443 return cmd_data.info('%s (%4.2fs)' % (cmd_data.name, duration))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001444
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001445
sbc@chromium.org013731e2015-02-26 18:28:43 +00001446def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001447 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001448 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001449 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001450 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001451 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1452 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001453 parser.add_option("-r", "--recursive", action="store_true",
1454 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001455 parser.add_option("-v", "--verbose", action="count", default=0,
1456 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001457 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001458 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001459 parser.add_option("--description", default='')
1460 parser.add_option("--issue", type='int', default=0)
1461 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001462 parser.add_option("--root", default=os.getcwd(),
1463 help="Search for PRESUBMIT.py up to this directory. "
1464 "If inherit-review-settings-ok is present in this "
1465 "directory, parent directories up to the root file "
1466 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001467 parser.add_option("--upstream",
1468 help="Git only: the base ref or upstream branch against "
1469 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001470 parser.add_option("--default_presubmit")
1471 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001472 parser.add_option("--skip_canned", action='append', default=[],
1473 help="A list of checks to skip which appear in "
1474 "presubmit_canned_checks. Can be provided multiple times "
1475 "to skip multiple canned checks.")
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001476 parser.add_option("--dry_run", action='store_true',
1477 help=optparse.SUPPRESS_HELP)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001478 parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP)
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001479 parser.add_option("--gerrit_fetch", action='store_true',
1480 help=optparse.SUPPRESS_HELP)
maruel@chromium.org239f4112011-06-03 20:08:23 +00001481 parser.add_option("--rietveld_url", help=optparse.SUPPRESS_HELP)
1482 parser.add_option("--rietveld_email", help=optparse.SUPPRESS_HELP)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001483 parser.add_option("--rietveld_fetch", action='store_true', default=False,
1484 help=optparse.SUPPRESS_HELP)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001485 # These are for OAuth2 authentication for bots. See also apply_issue.py
1486 parser.add_option("--rietveld_email_file", help=optparse.SUPPRESS_HELP)
1487 parser.add_option("--rietveld_private_key_file", help=optparse.SUPPRESS_HELP)
1488
phajdan.jr@chromium.org2ff30182016-03-23 09:52:51 +00001489 # TODO(phajdan.jr): Update callers and remove obsolete --trybot-json .
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00001490 parser.add_option("--trybot-json",
1491 help="Output trybot information to the file specified.")
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001492 auth.add_auth_options(parser)
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001493 options, args = parser.parse_args(argv)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001494 auth_config = auth.extract_auth_config_from_options(options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001495
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001496 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001497 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001498 elif options.verbose:
1499 logging.basicConfig(level=logging.INFO)
1500 else:
1501 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001502
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001503 if (any((options.rietveld_url, options.rietveld_email_file,
1504 options.rietveld_fetch, options.rietveld_private_key_file))
1505 and any((options.gerrit_url, options.gerrit_fetch))):
1506 parser.error('Options for only codereview --rietveld_* or --gerrit_* '
1507 'allowed')
1508
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001509 if options.rietveld_email and options.rietveld_email_file:
1510 parser.error("Only one of --rietveld_email or --rietveld_email_file "
1511 "can be passed to this program.")
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001512 if options.rietveld_email_file:
1513 with open(options.rietveld_email_file, "rb") as f:
1514 options.rietveld_email = f.read().strip()
1515
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001516 change_class, files = load_files(options, args)
1517 if not change_class:
1518 parser.error('For unversioned directory, <files> is not optional.')
tobiasjs2836bcf2016-08-16 04:08:16 -07001519 logging.info('Found %d file(s).', len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001520
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001521 rietveld_obj, gerrit_obj = None, None
1522
maruel@chromium.org239f4112011-06-03 20:08:23 +00001523 if options.rietveld_url:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001524 # The empty password is permitted: '' is not None.
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001525 if options.rietveld_private_key_file:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001526 rietveld_obj = rietveld.JwtOAuth2Rietveld(
1527 options.rietveld_url,
1528 options.rietveld_email,
1529 options.rietveld_private_key_file)
1530 else:
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001531 rietveld_obj = rietveld.CachingRietveld(
1532 options.rietveld_url,
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001533 auth_config,
1534 options.rietveld_email)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001535 if options.rietveld_fetch:
1536 assert options.issue
1537 props = rietveld_obj.get_issue_properties(options.issue, False)
1538 options.author = props['owner_email']
1539 options.description = props['description']
1540 logging.info('Got author: "%s"', options.author)
1541 logging.info('Got description: """\n%s\n"""', options.description)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001542
1543 if options.gerrit_url and options.gerrit_fetch:
tandrii@chromium.org83b1b232016-04-29 16:33:19 +00001544 assert options.issue and options.patchset
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001545 rietveld_obj = None
1546 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1547 options.author = gerrit_obj.GetChangeOwner(options.issue)
1548 options.description = gerrit_obj.GetChangeDescription(options.issue,
1549 options.patchset)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001550 logging.info('Got author: "%s"', options.author)
1551 logging.info('Got description: """\n%s\n"""', options.description)
1552
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001553 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001554 with canned_check_filter(options.skip_canned):
1555 results = DoPresubmitChecks(
1556 change_class(options.name,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001557 options.description,
1558 options.root,
1559 files,
1560 options.issue,
1561 options.patchset,
1562 options.author,
1563 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001564 options.commit,
1565 options.verbose,
1566 sys.stdout,
1567 sys.stdin,
1568 options.default_presubmit,
1569 options.may_prompt,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001570 rietveld_obj,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001571 gerrit_obj,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001572 options.dry_run)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001573 return not results.should_continue()
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001574 except NonexistantCannedCheckFilter, e:
1575 print >> sys.stderr, (
1576 'Attempted to skip nonexistent canned presubmit check: %s' % e.message)
1577 return 2
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001578 except PresubmitFailure, e:
1579 print >> sys.stderr, e
1580 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
1581 print >> sys.stderr, 'If all fails, contact maruel@'
1582 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001583
1584
1585if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001586 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001587 try:
1588 sys.exit(main())
1589 except KeyboardInterrupt:
1590 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001591 sys.exit(2)