blob: 4148b704c738c1d1810e9a316bd7f7bd8015a745 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090015import ast # Exposed through the API.
enne@chromium.orge72c5f52013-04-16 00:36:40 +000016import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000017import cPickle # Exposed through the API.
18import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
dcheng091b7db2016-06-16 01:27:51 -070020import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000021import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000022import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000023import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000024import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000025import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000026import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import optparse
29import os # Somewhat exposed through the API.
30import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000031import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040033import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000034import sys # Parts exposed through API.
35import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040036import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000037import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000038import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000040import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000041import urllib2 # Exposed through the API.
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000042import urlparse
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000043from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000044
45# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000046import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000047import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070048import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000049import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000050import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020051import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000052import presubmit_canned_checks
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000053import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000054import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000055
56
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000057# Ask for feedback only once in program lifetime.
58_ASKED_FOR_FEEDBACK = False
59
60
maruel@chromium.org899e1c12011-04-07 17:03:18 +000061class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000062 pass
63
64
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000065class CommandData(object):
66 def __init__(self, name, cmd, kwargs, message):
67 self.name = name
68 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040069 self.stdin = kwargs.get('stdin', None)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000070 self.kwargs = kwargs
Edward Lesmes8e282792018-04-03 18:50:29 -040071 self.kwargs['stdout'] = subprocess.PIPE
72 self.kwargs['stderr'] = subprocess.STDOUT
73 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000074 self.message = message
75 self.info = None
76
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000077
Edward Lesmes8e282792018-04-03 18:50:29 -040078# Adapted from
79# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
80#
81# An object that catches SIGINT sent to the Python process and notices
82# if processes passed to wait() die by SIGINT (we need to look for
83# both of those cases, because pressing Ctrl+C can result in either
84# the main process or one of the subprocesses getting the signal).
85#
86# Before a SIGINT is seen, wait(p) will simply call p.wait() and
87# return the result. Once a SIGINT has been seen (in the main process
88# or a subprocess, including the one the current call is waiting for),
89# wait(p) will call p.terminate() and raise ProcessWasInterrupted.
90class SigintHandler(object):
91 class ProcessWasInterrupted(Exception):
92 pass
93
94 sigint_returncodes = {-signal.SIGINT, # Unix
95 -1073741510, # Windows
96 }
97 def __init__(self):
98 self.__lock = threading.Lock()
99 self.__processes = set()
100 self.__got_sigint = False
101 signal.signal(signal.SIGINT, lambda signal_num, frame: self.interrupt())
102
103 def __on_sigint(self):
104 self.__got_sigint = True
105 while self.__processes:
106 try:
107 self.__processes.pop().terminate()
108 except OSError:
109 pass
110
111 def interrupt(self):
112 with self.__lock:
113 self.__on_sigint()
114
115 def got_sigint(self):
116 with self.__lock:
117 return self.__got_sigint
118
119 def wait(self, p, stdin):
120 with self.__lock:
121 if self.__got_sigint:
122 p.terminate()
123 self.__processes.add(p)
124 stdout, stderr = p.communicate(stdin)
125 code = p.returncode
126 with self.__lock:
127 self.__processes.discard(p)
128 if code in self.sigint_returncodes:
129 self.__on_sigint()
130 if self.__got_sigint:
131 raise self.ProcessWasInterrupted
132 return stdout, stderr
133
134sigint_handler = SigintHandler()
135
136
137class ThreadPool(object):
138 def __init__(self, pool_size=None):
139 self._pool_size = pool_size or multiprocessing.cpu_count()
140 self._messages = []
141 self._messages_lock = threading.Lock()
142 self._tests = []
143 self._tests_lock = threading.Lock()
144 self._nonparallel_tests = []
145
146 def CallCommand(self, test):
147 """Runs an external program.
148
149 This function converts invocation of .py files and invocations of "python"
150 to vpython invocations.
151 """
152 vpython = 'vpython.bat' if sys.platform == 'win32' else 'vpython'
153
154 cmd = test.cmd
155 if cmd[0] == 'python':
156 cmd = list(cmd)
157 cmd[0] = vpython
158 elif cmd[0].endswith('.py'):
159 cmd = [vpython] + cmd
160
161 try:
162 start = time.time()
163 p = subprocess.Popen(cmd, **test.kwargs)
164 stdout, _ = sigint_handler.wait(p, test.stdin)
165 duration = time.time() - start
166 except OSError as e:
167 duration = time.time() - start
168 return test.message(
169 '%s exec failure (%4.2fs)\n %s' % (test.name, duration, e))
170 if p.returncode != 0:
171 return test.message(
172 '%s (%4.2fs) failed\n%s' % (test.name, duration, stdout))
173 if test.info:
174 return test.info('%s (%4.2fs)' % (test.name, duration))
175
176 def AddTests(self, tests, parallel=True):
177 if parallel:
178 self._tests.extend(tests)
179 else:
180 self._nonparallel_tests.extend(tests)
181
182 def RunAsync(self):
183 self._messages = []
184
185 def _WorkerFn():
186 while True:
187 test = None
188 with self._tests_lock:
189 if not self._tests:
190 break
191 test = self._tests.pop()
192 result = self.CallCommand(test)
193 if result:
194 with self._messages_lock:
195 self._messages.append(result)
196
197 def _StartDaemon():
198 t = threading.Thread(target=_WorkerFn)
199 t.daemon = True
200 t.start()
201 return t
202
203 while self._nonparallel_tests:
204 test = self._nonparallel_tests.pop()
205 result = self.CallCommand(test)
206 if result:
207 self._messages.append(result)
208
209 if self._tests:
210 threads = [_StartDaemon() for _ in range(self._pool_size)]
211 for worker in threads:
212 worker.join()
213
214 return self._messages
215
216
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000217def normpath(path):
218 '''Version of os.path.normpath that also changes backward slashes to
219 forward slashes when not running on Windows.
220 '''
221 # This is safe to always do because the Windows version of os.path.normpath
222 # will replace forward slashes with backward slashes.
223 path = path.replace(os.sep, '/')
224 return os.path.normpath(path)
225
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000226
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000227def _RightHandSideLinesImpl(affected_files):
228 """Implements RightHandSideLines for InputApi and GclChange."""
229 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000230 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000231 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000232 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000233
234
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000235class PresubmitOutput(object):
236 def __init__(self, input_stream=None, output_stream=None):
237 self.input_stream = input_stream
238 self.output_stream = output_stream
239 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -0800240 self.more_cc = []
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000241 self.written_output = []
242 self.error_count = 0
243
244 def prompt_yes_no(self, prompt_string):
245 self.write(prompt_string)
246 if self.input_stream:
247 response = self.input_stream.readline().strip().lower()
248 if response not in ('y', 'yes'):
249 self.fail()
250 else:
251 self.fail()
252
253 def fail(self):
254 self.error_count += 1
255
256 def should_continue(self):
257 return not self.error_count
258
259 def write(self, s):
260 self.written_output.append(s)
261 if self.output_stream:
262 self.output_stream.write(s)
263
264 def getvalue(self):
265 return ''.join(self.written_output)
266
267
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000268# Top level object so multiprocessing can pickle
269# Public access through OutputApi object.
270class _PresubmitResult(object):
271 """Base class for result objects."""
272 fatal = False
273 should_prompt = False
274
275 def __init__(self, message, items=None, long_text=''):
276 """
277 message: A short one-line message to indicate errors.
278 items: A list of short strings to indicate where errors occurred.
279 long_text: multi-line text output, e.g. from another tool
280 """
281 self._message = message
282 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000283 self._long_text = long_text.rstrip()
284
285 def handle(self, output):
286 output.write(self._message)
287 output.write('\n')
288 for index, item in enumerate(self._items):
289 output.write(' ')
290 # Write separately in case it's unicode.
291 output.write(str(item))
292 if index < len(self._items) - 1:
293 output.write(' \\')
294 output.write('\n')
295 if self._long_text:
296 output.write('\n***************\n')
297 # Write separately in case it's unicode.
298 output.write(self._long_text)
299 output.write('\n***************\n')
300 if self.fatal:
301 output.fail()
302
303
304# Top level object so multiprocessing can pickle
305# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000306class _PresubmitError(_PresubmitResult):
307 """A hard presubmit error."""
308 fatal = True
309
310
311# Top level object so multiprocessing can pickle
312# Public access through OutputApi object.
313class _PresubmitPromptWarning(_PresubmitResult):
314 """An warning that prompts the user if they want to continue."""
315 should_prompt = True
316
317
318# Top level object so multiprocessing can pickle
319# Public access through OutputApi object.
320class _PresubmitNotifyResult(_PresubmitResult):
321 """Just print something to the screen -- but it's not even a warning."""
322 pass
323
324
325# Top level object so multiprocessing can pickle
326# Public access through OutputApi object.
327class _MailTextResult(_PresubmitResult):
328 """A warning that should be included in the review request email."""
329 def __init__(self, *args, **kwargs):
330 super(_MailTextResult, self).__init__()
331 raise NotImplementedError()
332
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000333class GerritAccessor(object):
334 """Limited Gerrit functionality for canned presubmit checks to work.
335
336 To avoid excessive Gerrit calls, caches the results.
337 """
338
339 def __init__(self, host):
340 self.host = host
341 self.cache = {}
342
343 def _FetchChangeDetail(self, issue):
344 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100345 try:
346 return gerrit_util.GetChangeDetail(
347 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700348 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100349 except gerrit_util.GerritError as e:
350 if e.http_status == 404:
351 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
352 'no credentials to fetch issue details' % issue)
353 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000354
355 def GetChangeInfo(self, issue):
356 """Returns labels and all revisions (patchsets) for this issue.
357
358 The result is a dictionary according to Gerrit REST Api.
359 https://gerrit-review.googlesource.com/Documentation/rest-api.html
360
361 However, API isn't very clear what's inside, so see tests for example.
362 """
363 assert issue
364 cache_key = int(issue)
365 if cache_key not in self.cache:
366 self.cache[cache_key] = self._FetchChangeDetail(issue)
367 return self.cache[cache_key]
368
369 def GetChangeDescription(self, issue, patchset=None):
370 """If patchset is none, fetches current patchset."""
371 info = self.GetChangeInfo(issue)
372 # info is a reference to cache. We'll modify it here adding description to
373 # it to the right patchset, if it is not yet there.
374
375 # Find revision info for the patchset we want.
376 if patchset is not None:
377 for rev, rev_info in info['revisions'].iteritems():
378 if str(rev_info['_number']) == str(patchset):
379 break
380 else:
381 raise Exception('patchset %s doesn\'t exist in issue %s' % (
382 patchset, issue))
383 else:
384 rev = info['current_revision']
385 rev_info = info['revisions'][rev]
386
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100387 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000388
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800389 def GetDestRef(self, issue):
390 ref = self.GetChangeInfo(issue)['branch']
391 if not ref.startswith('refs/'):
392 # NOTE: it is possible to create 'refs/x' branch,
393 # aka 'refs/heads/refs/x'. However, this is ill-advised.
394 ref = 'refs/heads/%s' % ref
395 return ref
396
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000397 def GetChangeOwner(self, issue):
398 return self.GetChangeInfo(issue)['owner']['email']
399
400 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700401 changeinfo = self.GetChangeInfo(issue)
402 if approving_only:
403 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
404 values = labelinfo.get('values', {}).keys()
405 try:
406 max_value = max(int(v) for v in values)
407 reviewers = [r for r in labelinfo.get('all', [])
408 if r.get('value', 0) == max_value]
409 except ValueError: # values is the empty list
410 reviewers = []
411 else:
412 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
413 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000414
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000415
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000416class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000417 """An instance of OutputApi gets passed to presubmit scripts so that they
418 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000419 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000420 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000421 PresubmitError = _PresubmitError
422 PresubmitPromptWarning = _PresubmitPromptWarning
423 PresubmitNotifyResult = _PresubmitNotifyResult
424 MailTextResult = _MailTextResult
425
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000426 def __init__(self, is_committing):
427 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800428 self.more_cc = []
429
430 def AppendCC(self, cc):
431 """Appends a user to cc for this change."""
432 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000433
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000434 def PresubmitPromptOrNotify(self, *args, **kwargs):
435 """Warn the user when uploading, but only notify if committing."""
436 if self.is_committing:
437 return self.PresubmitNotifyResult(*args, **kwargs)
438 return self.PresubmitPromptWarning(*args, **kwargs)
439
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800440 def EnsureCQIncludeTrybotsAreAdded(self, cl, bots_to_include, message):
441 """Helper for any PostUploadHook wishing to add CQ_INCLUDE_TRYBOTS.
442
443 Merges the bots_to_include into the current CQ_INCLUDE_TRYBOTS list,
444 keeping it alphabetically sorted. Returns the results that should be
445 returned from the PostUploadHook.
446
447 Args:
448 cl: The git_cl.Changelist object.
449 bots_to_include: A list of strings of bots to include, in the form
450 "master:slave".
451 message: A message to be printed in the case that
452 CQ_INCLUDE_TRYBOTS was updated.
453 """
454 description = cl.GetDescription(force=True)
Aaron Gableb584c4f2017-04-26 16:28:08 -0700455 include_re = re.compile(r'^CQ_INCLUDE_TRYBOTS=(.*)$', re.M | re.I)
456
457 prior_bots = []
458 if cl.IsGerrit():
459 trybot_footers = git_footers.parse_footers(description).get(
460 git_footers.normalize_name('Cq-Include-Trybots'), [])
461 for f in trybot_footers:
462 prior_bots += [b.strip() for b in f.split(';') if b.strip()]
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800463 else:
Aaron Gableb584c4f2017-04-26 16:28:08 -0700464 trybot_tags = include_re.finditer(description)
465 for t in trybot_tags:
466 prior_bots += [b.strip() for b in t.group(1).split(';') if b.strip()]
467
468 if set(prior_bots) >= set(bots_to_include):
469 return []
470 all_bots = ';'.join(sorted(set(prior_bots) | set(bots_to_include)))
471
472 if cl.IsGerrit():
473 description = git_footers.remove_footer(
474 description, 'Cq-Include-Trybots')
475 description = git_footers.add_footer(
476 description, 'Cq-Include-Trybots', all_bots,
477 before_keys=['Change-Id'])
478 else:
479 new_include_trybots = 'CQ_INCLUDE_TRYBOTS=%s' % all_bots
480 m = include_re.search(description)
481 if m:
482 description = include_re.sub(new_include_trybots, description)
Kenneth Russelldf6e7342017-04-24 17:07:41 -0700483 else:
Aaron Gableb584c4f2017-04-26 16:28:08 -0700484 description = '%s\n%s\n' % (description, new_include_trybots)
485
486 cl.UpdateDescription(description, force=True)
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800487 return [self.PresubmitNotifyResult(message)]
488
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000489
490class InputApi(object):
491 """An instance of this object is passed to presubmit scripts so they can
492 know stuff about the change they're looking at.
493 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000494 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800495 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000496
maruel@chromium.org3410d912009-06-09 20:56:16 +0000497 # File extensions that are considered source files from a style guide
498 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000499 #
500 # Files without an extension aren't included in the list. If you want to
501 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
502 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000503 DEFAULT_WHITE_LIST = (
504 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000505 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
506 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000507 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000508 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000509 # Other
Sergey Ulanov166bc4c2018-04-30 17:03:38 -0700510 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$", r".+\.mojom$",
511 r".+\.fidl$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000512 )
513
514 # Path regexp that should be excluded from being considered containing source
515 # files. Don't modify this list from a presubmit script!
516 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000517 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000518 r".*\bexperimental[\\\/].*",
Kent Tamura179dd1e2018-04-26 15:07:41 +0900519 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
520 # (crbug.com/539768 and crbug.com/836555).
521 r".*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000522 # Output directories (just in case)
523 r".*\bDebug[\\\/].*",
524 r".*\bRelease[\\\/].*",
525 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000526 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000527 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000528 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000529 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000530 r"(|.*[\\\/])\.git[\\\/].*",
531 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000532 # There is no point in processing a patch file.
533 r".+\.diff$",
534 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000535 )
536
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000537 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400538 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000539 """Builds an InputApi object.
540
541 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000542 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000543 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000544 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000545 gerrit_obj: provides basic Gerrit codereview functionality.
546 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400547 parallel: if true, all tests reported via input_api.RunTests for all
548 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000549 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000550 # Version number of the presubmit_support script.
551 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000552 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000553 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000554 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000555 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000556
Edward Lesmes8e282792018-04-03 18:50:29 -0400557 self.parallel = parallel
558 self.thread_pool = thread_pool or ThreadPool()
559
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000560 # We expose various modules and functions as attributes of the input_api
561 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900562 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000563 self.basename = os.path.basename
564 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000565 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000566 self.cStringIO = cStringIO
dcheng091b7db2016-06-16 01:27:51 -0700567 self.fnmatch = fnmatch
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000568 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000569 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000570 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000571 self.os_listdir = os.listdir
572 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000573 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000574 self.os_stat = os.stat
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000575 self.pickle = pickle
576 self.marshal = marshal
577 self.re = re
578 self.subprocess = subprocess
579 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000580 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000581 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000582 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000583 self.urllib2 = urllib2
584
Robert Iannucci50258932018-03-19 10:30:59 -0700585 self.is_windows = sys.platform == 'win32'
586
587 # Set python_executable to 'python'. This is interpreted in CallCommand to
588 # convert to vpython in order to allow scripts in other repos (e.g. src.git)
589 # to automatically pick up that repo's .vpython file, instead of inheriting
590 # the one in depot_tools.
591 self.python_executable = 'python'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000592 self.environ = os.environ
593
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000594 # InputApi.platform is the platform you're currently running on.
595 self.platform = sys.platform
596
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000597 self.cpu_count = multiprocessing.cpu_count()
598
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000599 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000600 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000601
602 # We carry the canned checks so presubmit scripts can easily use them.
603 self.canned_checks = presubmit_canned_checks
604
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100605 # Temporary files we must manually remove at the end of a run.
606 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200607
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000608 # TODO(dpranke): figure out a list of all approved owners for a repo
609 # in order to be able to handle wildcard OWNERS files?
610 self.owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +0200611 fopen=file, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200612 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000613 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000614 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000615
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000616 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000617 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000618 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800619 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000620 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000621 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000622 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
623 for (a, b, header) in cpplint._re_pattern_templates
624 ]
625
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000626 def PresubmitLocalPath(self):
627 """Returns the local path of the presubmit script currently being run.
628
629 This is useful if you don't want to hard-code absolute paths in the
630 presubmit script. For example, It can be used to find another file
631 relative to the PRESUBMIT.py script, so the whole tree can be branched and
632 the presubmit script still works, without editing its content.
633 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000634 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000635
agable0b65e732016-11-22 09:25:46 -0800636 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000637 """Same as input_api.change.AffectedFiles() except only lists files
638 (and optionally directories) in the same directory as the current presubmit
639 script, or subdirectories thereof.
640 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000641 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000642 if len(dir_with_slash) == 1:
643 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000644
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000645 return filter(
646 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
agable0b65e732016-11-22 09:25:46 -0800647 self.change.AffectedFiles(include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000648
agable0b65e732016-11-22 09:25:46 -0800649 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000650 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800651 paths = [af.LocalPath() for af in self.AffectedFiles()]
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000652 logging.debug("LocalPaths: %s", paths)
653 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000654
agable0b65e732016-11-22 09:25:46 -0800655 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000656 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800657 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000658
John Budorick16162372018-04-18 10:39:53 -0700659 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800660 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000661 in the same directory as the current presubmit script, or subdirectories
662 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000663 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000664 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800665 warn("AffectedTestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000666 " is deprecated and ignored" % str(include_deletes),
667 category=DeprecationWarning,
668 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -0800669 return filter(lambda x: x.IsTestableFile(),
John Budorick16162372018-04-18 10:39:53 -0700670 self.AffectedFiles(include_deletes=False, **kwargs))
agable0b65e732016-11-22 09:25:46 -0800671
672 def AffectedTextFiles(self, include_deletes=None):
673 """An alias to AffectedTestableFiles for backwards compatibility."""
674 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000675
maruel@chromium.org3410d912009-06-09 20:56:16 +0000676 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
677 """Filters out files that aren't considered "source file".
678
679 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
680 and InputApi.DEFAULT_BLACK_LIST is used respectively.
681
682 The lists will be compiled as regular expression and
683 AffectedFile.LocalPath() needs to pass both list.
684
685 Note: Copy-paste this function to suit your needs or use a lambda function.
686 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000687 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000688 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000689 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000690 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000691 return True
692 return False
693 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
694 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
695
696 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800697 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000698
699 If source_file is None, InputApi.FilterSourceFile() is used.
700 """
701 if not source_file:
702 source_file = self.FilterSourceFile
agable0b65e732016-11-22 09:25:46 -0800703 return filter(source_file, self.AffectedTestableFiles())
maruel@chromium.org3410d912009-06-09 20:56:16 +0000704
705 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000706 """An iterator over all text lines in "new" version of changed files.
707
708 Only lists lines from new or modified text files in the change that are
709 contained by the directory of the currently executing presubmit script.
710
711 This is useful for doing line-by-line regex checks, like checking for
712 trailing whitespace.
713
714 Yields:
715 a 3 tuple:
716 the AffectedFile instance of the current file;
717 integer line number (1-based); and
718 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000719
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000720 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000721 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000722 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000723 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000724
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000725 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000726 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000727
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000728 Deny reading anything outside the repository.
729 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000730 if isinstance(file_item, AffectedFile):
731 file_item = file_item.AbsoluteLocalPath()
732 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000733 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000734 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000735
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100736 def CreateTemporaryFile(self, **kwargs):
737 """Returns a named temporary file that must be removed with a call to
738 RemoveTemporaryFiles().
739
740 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
741 except for |delete|, which is always set to False.
742
743 Presubmit checks that need to create a temporary file and pass it for
744 reading should use this function instead of NamedTemporaryFile(), as
745 Windows fails to open a file that is already open for writing.
746
747 with input_api.CreateTemporaryFile() as f:
748 f.write('xyz')
749 f.close()
750 input_api.subprocess.check_output(['script-that', '--reads-from',
751 f.name])
752
753
754 Note that callers of CreateTemporaryFile() should not worry about removing
755 any temporary file; this is done transparently by the presubmit handling
756 code.
757 """
758 if 'delete' in kwargs:
759 # Prevent users from passing |delete|; we take care of file deletion
760 # ourselves and this prevents unintuitive error messages when we pass
761 # delete=False and 'delete' is also in kwargs.
762 raise TypeError('CreateTemporaryFile() does not take a "delete" '
763 'argument, file deletion is handled automatically by '
764 'the same presubmit_support code that creates InputApi '
765 'objects.')
766 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
767 self._named_temporary_files.append(temp_file.name)
768 return temp_file
769
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000770 @property
771 def tbr(self):
772 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400773 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000774
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000775 def RunTests(self, tests_mix, parallel=True):
Edward Lesmes8e282792018-04-03 18:50:29 -0400776 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
777 # will run all tests once all PRESUBMIT files are processed.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000778 tests = []
779 msgs = []
780 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400781 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000782 msgs.append(t)
783 else:
784 assert issubclass(t.message, _PresubmitResult)
785 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000786 if self.verbose:
787 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400788 if not t.kwargs.get('cwd'):
789 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400790 self.thread_pool.AddTests(tests, parallel)
791 if not self.parallel:
792 msgs.extend(self.thread_pool.RunAsync())
793 return msgs
scottmg86099d72016-09-01 09:16:51 -0700794
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000795
nick@chromium.orgff526192013-06-10 19:30:26 +0000796class _DiffCache(object):
797 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000798 def __init__(self, upstream=None):
799 """Stores the upstream revision against which all diffs will be computed."""
800 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000801
802 def GetDiff(self, path, local_root):
803 """Get the diff for a particular path."""
804 raise NotImplementedError()
805
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700806 def GetOldContents(self, path, local_root):
807 """Get the old version for a particular path."""
808 raise NotImplementedError()
809
nick@chromium.orgff526192013-06-10 19:30:26 +0000810
nick@chromium.orgff526192013-06-10 19:30:26 +0000811class _GitDiffCache(_DiffCache):
812 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000813 def __init__(self, upstream):
814 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000815 self._diffs_by_file = None
816
817 def GetDiff(self, path, local_root):
818 if not self._diffs_by_file:
819 # Compute a single diff for all files and parse the output; should
820 # with git this is much faster than computing one diff for each file.
821 diffs = {}
822
823 # Don't specify any filenames below, because there are command line length
824 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000825 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
826 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000827
828 # This regex matches the path twice, separated by a space. Note that
829 # filename itself may contain spaces.
830 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
831 current_diff = []
832 keep_line_endings = True
833 for x in unified_diff.splitlines(keep_line_endings):
834 match = file_marker.match(x)
835 if match:
836 # Marks the start of a new per-file section.
837 diffs[match.group('filename')] = current_diff = [x]
838 elif x.startswith('diff --git'):
839 raise PresubmitFailure('Unexpected diff line: %s' % x)
840 else:
841 current_diff.append(x)
842
843 self._diffs_by_file = dict(
844 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
845
846 if path not in self._diffs_by_file:
847 raise PresubmitFailure(
848 'Unified diff did not contain entry for file %s' % path)
849
850 return self._diffs_by_file[path]
851
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700852 def GetOldContents(self, path, local_root):
853 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
854
nick@chromium.orgff526192013-06-10 19:30:26 +0000855
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000856class AffectedFile(object):
857 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000858
859 DIFF_CACHE = _DiffCache
860
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000861 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800862 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000863 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000864 self._path = path
865 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000866 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000867 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000868 self._cached_changed_contents = None
869 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000870 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700871 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000872
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000873 def LocalPath(self):
874 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400875
876 This should be used for error messages but not for accessing files,
877 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
878 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000879 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000880 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000881
882 def AbsoluteLocalPath(self):
883 """Returns the absolute path of this file on the local disk.
884 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000885 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000886
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000887 def Action(self):
888 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000889 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000890
agable0b65e732016-11-22 09:25:46 -0800891 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000892 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000893
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000894 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000895 raise NotImplementedError() # Implement when needed
896
agable0b65e732016-11-22 09:25:46 -0800897 def IsTextFile(self):
898 """An alias to IsTestableFile for backwards compatibility."""
899 return self.IsTestableFile()
900
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700901 def OldContents(self):
902 """Returns an iterator over the lines in the old version of file.
903
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700904 The old version is the file before any modifications in the user's
905 workspace, i.e. the "left hand side".
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700906
907 Contents will be empty if the file is a directory or does not exist.
908 Note: The carriage returns (LF or CR) are stripped off.
909 """
910 return self._diff_cache.GetOldContents(self.LocalPath(),
911 self._local_root).splitlines()
912
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000913 def NewContents(self):
914 """Returns an iterator over the lines in the new version of file.
915
916 The new version is the file in the user's workspace, i.e. the "right hand
917 side".
918
919 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000920 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000921 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000922 if self._cached_new_contents is None:
923 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800924 try:
925 self._cached_new_contents = gclient_utils.FileRead(
926 self.AbsoluteLocalPath(), 'rU').splitlines()
927 except IOError:
928 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000929 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000930
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000931 def ChangedContents(self):
932 """Returns a list of tuples (line number, line text) of all new lines.
933
934 This relies on the scm diff output describing each changed code section
935 with a line of the form
936
937 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
938 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000939 if self._cached_changed_contents is not None:
940 return self._cached_changed_contents[:]
941 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000942 line_num = 0
943
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000944 for line in self.GenerateScmDiff().splitlines():
945 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
946 if m:
947 line_num = int(m.groups(1)[0])
948 continue
949 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000950 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000951 if not line.startswith('-'):
952 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000953 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000954
maruel@chromium.org5de13972009-06-10 18:16:06 +0000955 def __str__(self):
956 return self.LocalPath()
957
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000958 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000959 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000960
maruel@chromium.org58407af2011-04-12 23:15:57 +0000961
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000962class GitAffectedFile(AffectedFile):
963 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000964 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800965 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000966
nick@chromium.orgff526192013-06-10 19:30:26 +0000967 DIFF_CACHE = _GitDiffCache
968
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000969 def __init__(self, *args, **kwargs):
970 AffectedFile.__init__(self, *args, **kwargs)
971 self._server_path = None
agable0b65e732016-11-22 09:25:46 -0800972 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000973
agable0b65e732016-11-22 09:25:46 -0800974 def IsTestableFile(self):
975 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000976 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -0800977 # A deleted file is not testable.
978 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000979 else:
agable0b65e732016-11-22 09:25:46 -0800980 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
981 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000982
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000983
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000984class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000985 """Describe a change.
986
987 Used directly by the presubmit scripts to query the current change being
988 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000989
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000990 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000991 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000992 self.KEY: equivalent to tags['KEY']
993 """
994
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000995 _AFFECTED_FILES = AffectedFile
996
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000997 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000998 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000999 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001000 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001001
maruel@chromium.org58407af2011-04-12 23:15:57 +00001002 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001003 self, name, description, local_root, files, issue, patchset, author,
1004 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001005 if files is None:
1006 files = []
1007 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001008 # Convert root into an absolute path.
1009 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001010 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001011 self.issue = issue
1012 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001013 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001014
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001015 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001016 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001017 self._description_without_tags = ''
1018 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001019
maruel@chromium.orge085d812011-10-10 19:49:15 +00001020 assert all(
1021 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1022
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001023 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001024 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001025 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1026 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001027 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001028
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001029 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001030 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001031 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001032
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001033 def DescriptionText(self):
1034 """Returns the user-entered changelist description, minus tags.
1035
1036 Any line in the user-provided description starting with e.g. "FOO="
1037 (whitespace permitted before and around) is considered a tag line. Such
1038 lines are stripped out of the description this function returns.
1039 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001040 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001041
1042 def FullDescriptionText(self):
1043 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001044 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001045
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001046 def SetDescriptionText(self, description):
1047 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001048
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001049 Also updates the list of tags."""
1050 self._full_description = description
1051
1052 # From the description text, build up a dictionary of key/value pairs
1053 # plus the description minus all key/value or "tag" lines.
1054 description_without_tags = []
1055 self.tags = {}
1056 for line in self._full_description.splitlines():
1057 m = self.TAG_LINE_RE.match(line)
1058 if m:
1059 self.tags[m.group('key')] = m.group('value')
1060 else:
1061 description_without_tags.append(line)
1062
1063 # Change back to text and remove whitespace at end.
1064 self._description_without_tags = (
1065 '\n'.join(description_without_tags).rstrip())
1066
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001067 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001068 """Returns the repository (checkout) root directory for this change,
1069 as an absolute path.
1070 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001071 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001072
1073 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001074 """Return tags directly as attributes on the object."""
1075 if not re.match(r"^[A-Z_]*$", attr):
1076 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001077 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001078
Aaron Gablefc03e672017-05-15 14:09:42 -07001079 def BugsFromDescription(self):
1080 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001081 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
1082 footers = git_footers.parse_footers(self._full_description).get('Bug', [])
1083 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001084
1085 def ReviewersFromDescription(self):
1086 """Returns all reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001087 # We don't support a "R:" git-footer for reviewers; that is in metadata.
1088 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1089 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001090
1091 def TBRsFromDescription(self):
1092 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001093 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1094 # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically
1095 # determined by self-CR+1s.
1096 footers = git_footers.parse_footers(self._full_description).get('Tbr', [])
1097 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001098
1099 # TODO(agable): Delete these once we're sure they're unused.
1100 @property
1101 def BUG(self):
1102 return ','.join(self.BugsFromDescription())
1103 @property
1104 def R(self):
1105 return ','.join(self.ReviewersFromDescription())
1106 @property
1107 def TBR(self):
1108 return ','.join(self.TBRsFromDescription())
1109
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001110 def AllFiles(self, root=None):
1111 """List all files under source control in the repo."""
1112 raise NotImplementedError()
1113
agable0b65e732016-11-22 09:25:46 -08001114 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001115 """Returns a list of AffectedFile instances for all files in the change.
1116
1117 Args:
1118 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001119 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001120
1121 Returns:
1122 [AffectedFile(path, action), AffectedFile(path, action)]
1123 """
agable0b65e732016-11-22 09:25:46 -08001124 affected = filter(file_filter, self._affected_files)
sail@chromium.org5538e022011-05-12 17:53:16 +00001125
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001126 if include_deletes:
1127 return affected
Lei Zhang9611c4c2017-04-04 01:41:56 -07001128 return filter(lambda x: x.Action() != 'D', affected)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001129
John Budorick16162372018-04-18 10:39:53 -07001130 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001131 """Return a list of the existing text files in a change."""
1132 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -08001133 warn("AffectedTeestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001134 " is deprecated and ignored" % str(include_deletes),
1135 category=DeprecationWarning,
1136 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -08001137 return filter(lambda x: x.IsTestableFile(),
John Budorick16162372018-04-18 10:39:53 -07001138 self.AffectedFiles(include_deletes=False, **kwargs))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001139
agable0b65e732016-11-22 09:25:46 -08001140 def AffectedTextFiles(self, include_deletes=None):
1141 """An alias to AffectedTestableFiles for backwards compatibility."""
1142 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001143
agable0b65e732016-11-22 09:25:46 -08001144 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001145 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001146 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001147
agable0b65e732016-11-22 09:25:46 -08001148 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001149 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001150 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001151
1152 def RightHandSideLines(self):
1153 """An iterator over all text lines in "new" version of changed files.
1154
1155 Lists lines from new or modified text files in the change.
1156
1157 This is useful for doing line-by-line regex checks, like checking for
1158 trailing whitespace.
1159
1160 Yields:
1161 a 3 tuple:
1162 the AffectedFile instance of the current file;
1163 integer line number (1-based); and
1164 the contents of the line as a string.
1165 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001166 return _RightHandSideLinesImpl(
1167 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001168 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001169
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001170 def OriginalOwnersFiles(self):
1171 """A map from path names of affected OWNERS files to their old content."""
1172 def owners_file_filter(f):
1173 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1174 files = self.AffectedFiles(file_filter=owners_file_filter)
1175 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1176
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001177
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001178class GitChange(Change):
1179 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001180 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001181
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001182 def AllFiles(self, root=None):
1183 """List all files under source control in the repo."""
1184 root = root or self.RepositoryRoot()
1185 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001186 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1187 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001188
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001189
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001190def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001191 """Finds all presubmit files that apply to a given set of source files.
1192
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001193 If inherit-review-settings-ok is present right under root, looks for
1194 PRESUBMIT.py in directories enclosing root.
1195
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001196 Args:
1197 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001198 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001199
1200 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001201 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001202 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001203 files = [normpath(os.path.join(root, f)) for f in files]
1204
1205 # List all the individual directories containing files.
1206 directories = set([os.path.dirname(f) for f in files])
1207
1208 # Ignore root if inherit-review-settings-ok is present.
1209 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1210 root = None
1211
1212 # Collect all unique directories that may contain PRESUBMIT.py.
1213 candidates = set()
1214 for directory in directories:
1215 while True:
1216 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001217 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001218 candidates.add(directory)
1219 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001220 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001221 parent_dir = os.path.dirname(directory)
1222 if parent_dir == directory:
1223 # We hit the system root directory.
1224 break
1225 directory = parent_dir
1226
1227 # Look for PRESUBMIT.py in all candidate directories.
1228 results = []
1229 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001230 try:
1231 for f in os.listdir(directory):
1232 p = os.path.join(directory, f)
1233 if os.path.isfile(p) and re.match(
1234 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1235 results.append(p)
1236 except OSError:
1237 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001238
tobiasjs2836bcf2016-08-16 04:08:16 -07001239 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001240 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001241
1242
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001243class GetTryMastersExecuter(object):
1244 @staticmethod
1245 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1246 """Executes GetPreferredTryMasters() from a single presubmit script.
1247
1248 Args:
1249 script_text: The text of the presubmit script.
1250 presubmit_path: Project script to run.
1251 project: Project name to pass to presubmit script for bot selection.
1252
1253 Return:
1254 A map of try masters to map of builders to set of tests.
1255 """
1256 context = {}
1257 try:
1258 exec script_text in context
1259 except Exception, e:
1260 raise PresubmitFailure('"%s" had an exception.\n%s'
1261 % (presubmit_path, e))
1262
1263 function_name = 'GetPreferredTryMasters'
1264 if function_name not in context:
1265 return {}
1266 get_preferred_try_masters = context[function_name]
1267 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1268 raise PresubmitFailure(
1269 'Expected function "GetPreferredTryMasters" to take two arguments.')
1270 return get_preferred_try_masters(project, change)
1271
1272
rmistry@google.com5626a922015-02-26 14:03:30 +00001273class GetPostUploadExecuter(object):
1274 @staticmethod
1275 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1276 """Executes PostUploadHook() from a single presubmit script.
1277
1278 Args:
1279 script_text: The text of the presubmit script.
1280 presubmit_path: Project script to run.
1281 cl: The Changelist object.
1282 change: The Change object.
1283
1284 Return:
1285 A list of results objects.
1286 """
1287 context = {}
1288 try:
1289 exec script_text in context
1290 except Exception, e:
1291 raise PresubmitFailure('"%s" had an exception.\n%s'
1292 % (presubmit_path, e))
1293
1294 function_name = 'PostUploadHook'
1295 if function_name not in context:
1296 return {}
1297 post_upload_hook = context[function_name]
1298 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1299 raise PresubmitFailure(
1300 'Expected function "PostUploadHook" to take three arguments.')
1301 return post_upload_hook(cl, change, OutputApi(False))
1302
1303
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001304def _MergeMasters(masters1, masters2):
1305 """Merges two master maps. Merges also the tests of each builder."""
1306 result = {}
1307 for (master, builders) in itertools.chain(masters1.iteritems(),
1308 masters2.iteritems()):
1309 new_builders = result.setdefault(master, {})
1310 for (builder, tests) in builders.iteritems():
1311 new_builders.setdefault(builder, set([])).update(tests)
1312 return result
1313
1314
1315def DoGetTryMasters(change,
1316 changed_files,
1317 repository_root,
1318 default_presubmit,
1319 project,
1320 verbose,
1321 output_stream):
1322 """Get the list of try masters from the presubmit scripts.
1323
1324 Args:
1325 changed_files: List of modified files.
1326 repository_root: The repository root.
1327 default_presubmit: A default presubmit script to execute in any case.
1328 project: Optional name of a project used in selecting trybots.
1329 verbose: Prints debug info.
1330 output_stream: A stream to write debug output to.
1331
1332 Return:
1333 Map of try masters to map of builders to set of tests.
1334 """
1335 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1336 if not presubmit_files and verbose:
1337 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1338 results = {}
1339 executer = GetTryMastersExecuter()
1340
1341 if default_presubmit:
1342 if verbose:
1343 output_stream.write("Running default presubmit script.\n")
1344 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1345 results = _MergeMasters(results, executer.ExecPresubmitScript(
1346 default_presubmit, fake_path, project, change))
1347 for filename in presubmit_files:
1348 filename = os.path.abspath(filename)
1349 if verbose:
1350 output_stream.write("Running %s\n" % filename)
1351 # Accept CRLF presubmit script.
1352 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1353 results = _MergeMasters(results, executer.ExecPresubmitScript(
1354 presubmit_script, filename, project, change))
1355
1356 # Make sets to lists again for later JSON serialization.
1357 for builders in results.itervalues():
1358 for builder in builders:
1359 builders[builder] = list(builders[builder])
1360
1361 if results and verbose:
1362 output_stream.write('%s\n' % str(results))
1363 return results
1364
1365
rmistry@google.com5626a922015-02-26 14:03:30 +00001366def DoPostUploadExecuter(change,
1367 cl,
1368 repository_root,
1369 verbose,
1370 output_stream):
1371 """Execute the post upload hook.
1372
1373 Args:
1374 change: The Change object.
1375 cl: The Changelist object.
1376 repository_root: The repository root.
1377 verbose: Prints debug info.
1378 output_stream: A stream to write debug output to.
1379 """
1380 presubmit_files = ListRelevantPresubmitFiles(
1381 change.LocalPaths(), repository_root)
1382 if not presubmit_files and verbose:
1383 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1384 results = []
1385 executer = GetPostUploadExecuter()
1386 # The root presubmit file should be executed after the ones in subdirectories.
1387 # i.e. the specific post upload hooks should run before the general ones.
1388 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1389 presubmit_files.reverse()
1390
1391 for filename in presubmit_files:
1392 filename = os.path.abspath(filename)
1393 if verbose:
1394 output_stream.write("Running %s\n" % filename)
1395 # Accept CRLF presubmit script.
1396 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1397 results.extend(executer.ExecPresubmitScript(
1398 presubmit_script, filename, cl, change))
1399 output_stream.write('\n')
1400 if results:
1401 output_stream.write('** Post Upload Hook Messages **\n')
1402 for result in results:
1403 result.handle(output_stream)
1404 output_stream.write('\n')
1405
1406 return results
1407
1408
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001409class PresubmitExecuter(object):
Aaron Gable668c1d82018-04-03 10:19:16 -07001410 def __init__(self, change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001411 gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001412 """
1413 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001414 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001415 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001416 gerrit_obj: provides basic Gerrit codereview functionality.
1417 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001418 parallel: if true, all tests reported via input_api.RunTests for all
1419 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001420 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001421 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001422 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001423 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001424 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001425 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001426 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001427 self.thread_pool = thread_pool
1428 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001429
1430 def ExecPresubmitScript(self, script_text, presubmit_path):
1431 """Executes a single presubmit script.
1432
1433 Args:
1434 script_text: The text of the presubmit script.
1435 presubmit_path: The path to the presubmit file (this will be reported via
1436 input_api.PresubmitLocalPath()).
1437
1438 Return:
1439 A list of result objects, empty if no problems.
1440 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001441
chase@chromium.org8e416c82009-10-06 04:30:44 +00001442 # Change to the presubmit file's directory to support local imports.
1443 main_path = os.getcwd()
1444 os.chdir(os.path.dirname(presubmit_path))
1445
1446 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001447 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001448 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001449 dry_run=self.dry_run, thread_pool=self.thread_pool,
1450 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001451 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001452 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001453 try:
1454 exec script_text in context
1455 except Exception, e:
1456 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001457
1458 # These function names must change if we make substantial changes to
1459 # the presubmit API that are not backwards compatible.
1460 if self.committing:
1461 function_name = 'CheckChangeOnCommit'
1462 else:
1463 function_name = 'CheckChangeOnUpload'
1464 if function_name in context:
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001465 try:
Daniel Cheng7227d212017-11-17 08:12:37 -08001466 context['__args'] = (input_api, output_api)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001467 logging.debug('Running %s in %s', function_name, presubmit_path)
1468 result = eval(function_name + '(*__args)', context)
1469 logging.debug('Running %s done.', function_name)
Daniel Chengd36fce42017-11-21 21:52:52 -08001470 self.more_cc.extend(output_api.more_cc)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001471 finally:
1472 map(os.remove, input_api._named_temporary_files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001473 if not (isinstance(result, types.TupleType) or
1474 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001475 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001476 'Presubmit functions must return a tuple or list')
1477 for item in result:
1478 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001479 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001480 'All presubmit results must be of types derived from '
1481 'output_api.PresubmitResult')
1482 else:
1483 result = () # no error since the script doesn't care about current event.
1484
chase@chromium.org8e416c82009-10-06 04:30:44 +00001485 # Return the process to the original working directory.
1486 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001487 return result
1488
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001489def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001490 committing,
1491 verbose,
1492 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001493 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001494 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001495 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001496 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001497 dry_run=None,
1498 parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001499 """Runs all presubmit checks that apply to the files in the change.
1500
1501 This finds all PRESUBMIT.py files in directories enclosing the files in the
1502 change (up to the repository root) and calls the relevant entrypoint function
1503 depending on whether the change is being committed or uploaded.
1504
1505 Prints errors, warnings and notifications. Prompts the user for warnings
1506 when needed.
1507
1508 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001509 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001510 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001511 verbose: Prints debug info.
1512 output_stream: A stream to write output from presubmit tests to.
1513 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001514 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001515 may_prompt: Enable (y/n) questions on warning or error. If False,
1516 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001517 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001518 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001519 parallel: if true, all tests specified by input_api.RunTests in all
1520 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001521
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001522 Warning:
1523 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1524 SHOULD be sys.stdin.
1525
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001526 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001527 A PresubmitOutput object. Use output.should_continue() to figure out
1528 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001529 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001530 old_environ = os.environ
1531 try:
1532 # Make sure python subprocesses won't generate .pyc files.
1533 os.environ = os.environ.copy()
1534 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001535
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001536 output = PresubmitOutput(input_stream, output_stream)
1537 if committing:
1538 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001539 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001540 output.write("Running presubmit upload checks ...\n")
1541 start_time = time.time()
1542 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001543 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001544 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001545 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001546 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001547 thread_pool = ThreadPool()
Aaron Gable668c1d82018-04-03 10:19:16 -07001548 executer = PresubmitExecuter(change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001549 gerrit_obj, dry_run, thread_pool)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001550 if default_presubmit:
1551 if verbose:
1552 output.write("Running default presubmit script.\n")
1553 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1554 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1555 for filename in presubmit_files:
1556 filename = os.path.abspath(filename)
1557 if verbose:
1558 output.write("Running %s\n" % filename)
1559 # Accept CRLF presubmit script.
1560 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1561 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001562
Edward Lesmes8e282792018-04-03 18:50:29 -04001563 results += thread_pool.RunAsync()
1564
Daniel Cheng7227d212017-11-17 08:12:37 -08001565 output.more_cc.extend(executer.more_cc)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001566 errors = []
1567 notifications = []
1568 warnings = []
1569 for result in results:
1570 if result.fatal:
1571 errors.append(result)
1572 elif result.should_prompt:
1573 warnings.append(result)
1574 else:
1575 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001576
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001577 output.write('\n')
1578 for name, items in (('Messages', notifications),
1579 ('Warnings', warnings),
1580 ('ERRORS', errors)):
1581 if items:
1582 output.write('** Presubmit %s **\n' % name)
1583 for item in items:
1584 item.handle(output)
1585 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001586
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001587 total_time = time.time() - start_time
1588 if total_time > 1.0:
1589 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001590
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001591 if errors:
1592 output.fail()
1593 elif warnings:
1594 output.write('There were presubmit warnings. ')
1595 if may_prompt:
1596 output.prompt_yes_no('Are you sure you wish to continue? (y/N): ')
1597 else:
1598 output.write('Presubmit checks passed.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001599
1600 global _ASKED_FOR_FEEDBACK
1601 # Ask for feedback one time out of 5.
1602 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001603 output.write(
1604 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1605 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1606 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001607 _ASKED_FOR_FEEDBACK = True
1608 return output
1609 finally:
1610 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001611
1612
1613def ScanSubDirs(mask, recursive):
1614 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001615 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001616
1617 results = []
1618 for root, dirs, files in os.walk('.'):
1619 if '.svn' in dirs:
1620 dirs.remove('.svn')
1621 if '.git' in dirs:
1622 dirs.remove('.git')
1623 for name in files:
1624 if fnmatch.fnmatch(name, mask):
1625 results.append(os.path.join(root, name))
1626 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001627
1628
1629def ParseFiles(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001630 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001631 files = []
1632 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001633 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001634 return files
1635
1636
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001637def load_files(options, args):
1638 """Tries to determine the SCM."""
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001639 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001640 if args:
1641 files = ParseFiles(args, options.recursive)
agable0b65e732016-11-22 09:25:46 -08001642 change_scm = scm.determine_scm(options.root)
1643 if change_scm == 'git':
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001644 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001645 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001646 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001647 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001648 else:
tobiasjs2836bcf2016-08-16 04:08:16 -07001649 logging.info('Doesn\'t seem under source control. Got %d files', len(args))
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001650 if not files:
1651 return None, None
1652 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001653 return change_class, files
1654
1655
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001656@contextlib.contextmanager
1657def canned_check_filter(method_names):
1658 filtered = {}
1659 try:
1660 for method_name in method_names:
1661 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001662 logging.warn('Skipping unknown "canned" check %s' % method_name)
1663 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001664 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1665 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1666 yield
1667 finally:
1668 for name, method in filtered.iteritems():
1669 setattr(presubmit_canned_checks, name, method)
1670
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001671
sbc@chromium.org013731e2015-02-26 18:28:43 +00001672def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001673 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001674 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001675 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001676 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001677 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1678 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001679 parser.add_option("-r", "--recursive", action="store_true",
1680 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001681 parser.add_option("-v", "--verbose", action="count", default=0,
1682 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001683 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001684 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001685 parser.add_option("--description", default='')
1686 parser.add_option("--issue", type='int', default=0)
1687 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001688 parser.add_option("--root", default=os.getcwd(),
1689 help="Search for PRESUBMIT.py up to this directory. "
1690 "If inherit-review-settings-ok is present in this "
1691 "directory, parent directories up to the root file "
1692 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001693 parser.add_option("--upstream",
1694 help="Git only: the base ref or upstream branch against "
1695 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001696 parser.add_option("--default_presubmit")
1697 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001698 parser.add_option("--skip_canned", action='append', default=[],
1699 help="A list of checks to skip which appear in "
1700 "presubmit_canned_checks. Can be provided multiple times "
1701 "to skip multiple canned checks.")
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001702 parser.add_option("--dry_run", action='store_true',
1703 help=optparse.SUPPRESS_HELP)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001704 parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP)
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001705 parser.add_option("--gerrit_fetch", action='store_true',
1706 help=optparse.SUPPRESS_HELP)
Edward Lesmes8e282792018-04-03 18:50:29 -04001707 parser.add_option('--parallel', action='store_true',
1708 help='Run all tests specified by input_api.RunTests in all '
1709 'PRESUBMIT files in parallel.')
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001710
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001711 options, args = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001712
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001713 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001714 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001715 elif options.verbose:
1716 logging.basicConfig(level=logging.INFO)
1717 else:
1718 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001719
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001720 change_class, files = load_files(options, args)
1721 if not change_class:
1722 parser.error('For unversioned directory, <files> is not optional.')
tobiasjs2836bcf2016-08-16 04:08:16 -07001723 logging.info('Found %d file(s).', len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001724
Aaron Gable668c1d82018-04-03 10:19:16 -07001725 gerrit_obj = None
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001726 if options.gerrit_url and options.gerrit_fetch:
tandrii@chromium.org83b1b232016-04-29 16:33:19 +00001727 assert options.issue and options.patchset
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001728 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1729 options.author = gerrit_obj.GetChangeOwner(options.issue)
1730 options.description = gerrit_obj.GetChangeDescription(options.issue,
1731 options.patchset)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001732 logging.info('Got author: "%s"', options.author)
1733 logging.info('Got description: """\n%s\n"""', options.description)
1734
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001735 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001736 with canned_check_filter(options.skip_canned):
1737 results = DoPresubmitChecks(
1738 change_class(options.name,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001739 options.description,
1740 options.root,
1741 files,
1742 options.issue,
1743 options.patchset,
1744 options.author,
1745 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001746 options.commit,
1747 options.verbose,
1748 sys.stdout,
1749 sys.stdin,
1750 options.default_presubmit,
1751 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001752 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001753 options.dry_run,
1754 options.parallel)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001755 return not results.should_continue()
1756 except PresubmitFailure, e:
1757 print >> sys.stderr, e
1758 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001759 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001760
1761
1762if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001763 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001764 try:
1765 sys.exit(main())
1766 except KeyboardInterrupt:
1767 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001768 sys.exit(2)