blob: e9038a951958f31fc14e4e054ef3c94ea16f266e [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
stip@chromium.orgf7d31f52014-01-03 20:14:46 +000011__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090017import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000018import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000019import cpplint
dcheng091b7db2016-06-16 01:27:51 -070020import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000021import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000022import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000023import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000024import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000025import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000026import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000027import optparse
28import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000038from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039
40# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000041import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000042import gclient_paths # Exposed through the API
43import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070044import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000045import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000046import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020047import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000048import presubmit_canned_checks
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000049import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000050import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000051
Edward Lemur16af3562019-10-17 22:11:33 +000052if sys.version_info.major == 2:
53 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
54 import urllib2 # Exposed through the API.
55 import urlparse
56 import urllib2 as urllib_request
57 import urllib2 as urllib_error
58else:
59 import urllib.parse as urlparse
60 import urllib.request as urllib_request
61 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000062
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000063# Ask for feedback only once in program lifetime.
64_ASKED_FOR_FEEDBACK = False
65
66
maruel@chromium.org899e1c12011-04-07 17:03:18 +000067class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000068 pass
69
70
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000071class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000072 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000073 self.name = name
74 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040075 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000076 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040077 self.kwargs['stdout'] = subprocess.PIPE
78 self.kwargs['stderr'] = subprocess.STDOUT
79 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000080 self.message = message
81 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000082 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000083
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000084
Edward Lesmes8e282792018-04-03 18:50:29 -040085# Adapted from
86# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
87#
88# An object that catches SIGINT sent to the Python process and notices
89# if processes passed to wait() die by SIGINT (we need to look for
90# both of those cases, because pressing Ctrl+C can result in either
91# the main process or one of the subprocesses getting the signal).
92#
93# Before a SIGINT is seen, wait(p) will simply call p.wait() and
94# return the result. Once a SIGINT has been seen (in the main process
95# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +000096# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -040097class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -040098 sigint_returncodes = {-signal.SIGINT, # Unix
99 -1073741510, # Windows
100 }
101 def __init__(self):
102 self.__lock = threading.Lock()
103 self.__processes = set()
104 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000105 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400106
107 def __on_sigint(self):
108 self.__got_sigint = True
109 while self.__processes:
110 try:
111 self.__processes.pop().terminate()
112 except OSError:
113 pass
114
Edward Lemur9a5bb612019-09-26 02:01:52 +0000115 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400116 with self.__lock:
117 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000118 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400119
120 def got_sigint(self):
121 with self.__lock:
122 return self.__got_sigint
123
124 def wait(self, p, stdin):
125 with self.__lock:
126 if self.__got_sigint:
127 p.terminate()
128 self.__processes.add(p)
129 stdout, stderr = p.communicate(stdin)
130 code = p.returncode
131 with self.__lock:
132 self.__processes.discard(p)
133 if code in self.sigint_returncodes:
134 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400135 return stdout, stderr
136
137sigint_handler = SigintHandler()
138
139
140class ThreadPool(object):
141 def __init__(self, pool_size=None):
142 self._pool_size = pool_size or multiprocessing.cpu_count()
143 self._messages = []
144 self._messages_lock = threading.Lock()
145 self._tests = []
146 self._tests_lock = threading.Lock()
147 self._nonparallel_tests = []
148
149 def CallCommand(self, test):
150 """Runs an external program.
151
152 This function converts invocation of .py files and invocations of "python"
153 to vpython invocations.
154 """
Edward Lemur940c2822019-08-23 00:34:25 +0000155 vpython = 'vpython'
156 if test.python3:
157 vpython += '3'
158 if sys.platform == 'win32':
159 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400160
161 cmd = test.cmd
162 if cmd[0] == 'python':
163 cmd = list(cmd)
164 cmd[0] = vpython
165 elif cmd[0].endswith('.py'):
166 cmd = [vpython] + cmd
167
Edward Lemur336e51f2019-11-14 21:42:04 +0000168 # On Windows, scripts on the current directory take precedence over PATH, so
169 # that when testing depot_tools on Windows, calling `vpython.bat` will
170 # execute the copy of vpython of the depot_tools under test instead of the
171 # one in the bot.
172 # As a workaround, we run the tests from the parent directory instead.
173 if (cmd[0] == vpython and
174 'cwd' in test.kwargs and
175 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
176 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
177 cmd[1] = os.path.join('depot_tools', cmd[1])
178
Edward Lesmes8e282792018-04-03 18:50:29 -0400179 try:
180 start = time.time()
181 p = subprocess.Popen(cmd, **test.kwargs)
182 stdout, _ = sigint_handler.wait(p, test.stdin)
183 duration = time.time() - start
184 except OSError as e:
185 duration = time.time() - start
186 return test.message(
187 '%s exec failure (%4.2fs)\n %s' % (test.name, duration, e))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000188 except Exception as e:
189 duration = time.time() - start
190 return test.message(
191 '%s exec failure (%4.2fs)\n%s' % (
192 test.name, duration, traceback.format_exc()))
193
Edward Lesmes8e282792018-04-03 18:50:29 -0400194 if p.returncode != 0:
195 return test.message(
196 '%s (%4.2fs) failed\n%s' % (test.name, duration, stdout))
197 if test.info:
198 return test.info('%s (%4.2fs)' % (test.name, duration))
199
200 def AddTests(self, tests, parallel=True):
201 if parallel:
202 self._tests.extend(tests)
203 else:
204 self._nonparallel_tests.extend(tests)
205
206 def RunAsync(self):
207 self._messages = []
208
209 def _WorkerFn():
210 while True:
211 test = None
212 with self._tests_lock:
213 if not self._tests:
214 break
215 test = self._tests.pop()
216 result = self.CallCommand(test)
217 if result:
218 with self._messages_lock:
219 self._messages.append(result)
220
221 def _StartDaemon():
222 t = threading.Thread(target=_WorkerFn)
223 t.daemon = True
224 t.start()
225 return t
226
227 while self._nonparallel_tests:
228 test = self._nonparallel_tests.pop()
229 result = self.CallCommand(test)
230 if result:
231 self._messages.append(result)
232
233 if self._tests:
234 threads = [_StartDaemon() for _ in range(self._pool_size)]
235 for worker in threads:
236 worker.join()
237
238 return self._messages
239
240
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000241def normpath(path):
242 '''Version of os.path.normpath that also changes backward slashes to
243 forward slashes when not running on Windows.
244 '''
245 # This is safe to always do because the Windows version of os.path.normpath
246 # will replace forward slashes with backward slashes.
247 path = path.replace(os.sep, '/')
248 return os.path.normpath(path)
249
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000250
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000251def _RightHandSideLinesImpl(affected_files):
252 """Implements RightHandSideLines for InputApi and GclChange."""
253 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000254 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000255 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000256 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000257
258
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000259class PresubmitOutput(object):
260 def __init__(self, input_stream=None, output_stream=None):
261 self.input_stream = input_stream
262 self.output_stream = output_stream
263 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -0800264 self.more_cc = []
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000265 self.written_output = []
266 self.error_count = 0
267
268 def prompt_yes_no(self, prompt_string):
269 self.write(prompt_string)
270 if self.input_stream:
271 response = self.input_stream.readline().strip().lower()
272 if response not in ('y', 'yes'):
273 self.fail()
274 else:
275 self.fail()
276
277 def fail(self):
278 self.error_count += 1
279
280 def should_continue(self):
281 return not self.error_count
282
283 def write(self, s):
284 self.written_output.append(s)
285 if self.output_stream:
286 self.output_stream.write(s)
287
288 def getvalue(self):
289 return ''.join(self.written_output)
290
291
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000292# Top level object so multiprocessing can pickle
293# Public access through OutputApi object.
294class _PresubmitResult(object):
295 """Base class for result objects."""
296 fatal = False
297 should_prompt = False
298
299 def __init__(self, message, items=None, long_text=''):
300 """
301 message: A short one-line message to indicate errors.
302 items: A list of short strings to indicate where errors occurred.
303 long_text: multi-line text output, e.g. from another tool
304 """
305 self._message = message
306 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000307 self._long_text = long_text.rstrip()
308
309 def handle(self, output):
310 output.write(self._message)
311 output.write('\n')
312 for index, item in enumerate(self._items):
313 output.write(' ')
314 # Write separately in case it's unicode.
315 output.write(str(item))
316 if index < len(self._items) - 1:
317 output.write(' \\')
318 output.write('\n')
319 if self._long_text:
320 output.write('\n***************\n')
321 # Write separately in case it's unicode.
322 output.write(self._long_text)
323 output.write('\n***************\n')
324 if self.fatal:
325 output.fail()
326
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000327 def json_format(self):
328 return {
329 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000330 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000331 'long_text': self._long_text,
332 'fatal': self.fatal
333 }
334
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000335
336# Top level object so multiprocessing can pickle
337# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000338class _PresubmitError(_PresubmitResult):
339 """A hard presubmit error."""
340 fatal = True
341
342
343# Top level object so multiprocessing can pickle
344# Public access through OutputApi object.
345class _PresubmitPromptWarning(_PresubmitResult):
346 """An warning that prompts the user if they want to continue."""
347 should_prompt = True
348
349
350# Top level object so multiprocessing can pickle
351# Public access through OutputApi object.
352class _PresubmitNotifyResult(_PresubmitResult):
353 """Just print something to the screen -- but it's not even a warning."""
354 pass
355
356
357# Top level object so multiprocessing can pickle
358# Public access through OutputApi object.
359class _MailTextResult(_PresubmitResult):
360 """A warning that should be included in the review request email."""
361 def __init__(self, *args, **kwargs):
362 super(_MailTextResult, self).__init__()
363 raise NotImplementedError()
364
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000365class GerritAccessor(object):
366 """Limited Gerrit functionality for canned presubmit checks to work.
367
368 To avoid excessive Gerrit calls, caches the results.
369 """
370
371 def __init__(self, host):
372 self.host = host
373 self.cache = {}
374
375 def _FetchChangeDetail(self, issue):
376 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100377 try:
378 return gerrit_util.GetChangeDetail(
379 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700380 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100381 except gerrit_util.GerritError as e:
382 if e.http_status == 404:
383 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
384 'no credentials to fetch issue details' % issue)
385 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000386
387 def GetChangeInfo(self, issue):
388 """Returns labels and all revisions (patchsets) for this issue.
389
390 The result is a dictionary according to Gerrit REST Api.
391 https://gerrit-review.googlesource.com/Documentation/rest-api.html
392
393 However, API isn't very clear what's inside, so see tests for example.
394 """
395 assert issue
396 cache_key = int(issue)
397 if cache_key not in self.cache:
398 self.cache[cache_key] = self._FetchChangeDetail(issue)
399 return self.cache[cache_key]
400
401 def GetChangeDescription(self, issue, patchset=None):
402 """If patchset is none, fetches current patchset."""
403 info = self.GetChangeInfo(issue)
404 # info is a reference to cache. We'll modify it here adding description to
405 # it to the right patchset, if it is not yet there.
406
407 # Find revision info for the patchset we want.
408 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000409 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000410 if str(rev_info['_number']) == str(patchset):
411 break
412 else:
413 raise Exception('patchset %s doesn\'t exist in issue %s' % (
414 patchset, issue))
415 else:
416 rev = info['current_revision']
417 rev_info = info['revisions'][rev]
418
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100419 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000420
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800421 def GetDestRef(self, issue):
422 ref = self.GetChangeInfo(issue)['branch']
423 if not ref.startswith('refs/'):
424 # NOTE: it is possible to create 'refs/x' branch,
425 # aka 'refs/heads/refs/x'. However, this is ill-advised.
426 ref = 'refs/heads/%s' % ref
427 return ref
428
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000429 def GetChangeOwner(self, issue):
430 return self.GetChangeInfo(issue)['owner']['email']
431
432 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700433 changeinfo = self.GetChangeInfo(issue)
434 if approving_only:
435 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
436 values = labelinfo.get('values', {}).keys()
437 try:
438 max_value = max(int(v) for v in values)
439 reviewers = [r for r in labelinfo.get('all', [])
440 if r.get('value', 0) == max_value]
441 except ValueError: # values is the empty list
442 reviewers = []
443 else:
444 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
445 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000446
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000447
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000448class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000449 """An instance of OutputApi gets passed to presubmit scripts so that they
450 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000451 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000452 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000453 PresubmitError = _PresubmitError
454 PresubmitPromptWarning = _PresubmitPromptWarning
455 PresubmitNotifyResult = _PresubmitNotifyResult
456 MailTextResult = _MailTextResult
457
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000458 def __init__(self, is_committing):
459 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800460 self.more_cc = []
461
462 def AppendCC(self, cc):
463 """Appends a user to cc for this change."""
464 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000465
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000466 def PresubmitPromptOrNotify(self, *args, **kwargs):
467 """Warn the user when uploading, but only notify if committing."""
468 if self.is_committing:
469 return self.PresubmitNotifyResult(*args, **kwargs)
470 return self.PresubmitPromptWarning(*args, **kwargs)
471
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000472
473class InputApi(object):
474 """An instance of this object is passed to presubmit scripts so they can
475 know stuff about the change they're looking at.
476 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000477 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800478 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000479
maruel@chromium.org3410d912009-06-09 20:56:16 +0000480 # File extensions that are considered source files from a style guide
481 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000482 #
483 # Files without an extension aren't included in the list. If you want to
484 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
485 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000486 DEFAULT_WHITE_LIST = (
487 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000488 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
489 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000490 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000491 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000492 # Other
Sergey Ulanov166bc4c2018-04-30 17:03:38 -0700493 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$", r".+\.mojom$",
494 r".+\.fidl$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000495 )
496
497 # Path regexp that should be excluded from being considered containing source
498 # files. Don't modify this list from a presubmit script!
499 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000500 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000501 r".*\bexperimental[\\\/].*",
Kent Tamura179dd1e2018-04-26 15:07:41 +0900502 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
503 # (crbug.com/539768 and crbug.com/836555).
504 r".*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000505 # Output directories (just in case)
506 r".*\bDebug[\\\/].*",
507 r".*\bRelease[\\\/].*",
508 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000509 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000510 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000511 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000512 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000513 r"(|.*[\\\/])\.git[\\\/].*",
514 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000515 # There is no point in processing a patch file.
516 r".+\.diff$",
517 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000518 )
519
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000520 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400521 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000522 """Builds an InputApi object.
523
524 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000525 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000526 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000527 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000528 gerrit_obj: provides basic Gerrit codereview functionality.
529 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400530 parallel: if true, all tests reported via input_api.RunTests for all
531 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000532 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000533 # Version number of the presubmit_support script.
534 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000535 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000536 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000537 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000538 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000539
Edward Lesmes8e282792018-04-03 18:50:29 -0400540 self.parallel = parallel
541 self.thread_pool = thread_pool or ThreadPool()
542
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000543 # We expose various modules and functions as attributes of the input_api
544 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900545 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000546 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000547 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700548 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000549 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000550 # TODO(yyanagisawa): stop exposing this when python3 become default.
551 # Since python3's tempfile has TemporaryDirectory, we do not need this.
552 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000553 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000554 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000555 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000556 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000557 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000558 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000559 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000560 self.re = re
561 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000562 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000563 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000564 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000565 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000566 if sys.version_info.major == 2:
567 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000568 self.urllib_request = urllib_request
569 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000570
Robert Iannucci50258932018-03-19 10:30:59 -0700571 self.is_windows = sys.platform == 'win32'
572
Edward Lemurb9646622019-10-25 20:57:35 +0000573 # Set python_executable to 'vpython' in order to allow scripts in other
574 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
575 # instead of inheriting the one in depot_tools.
576 self.python_executable = 'vpython'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000577 self.environ = os.environ
578
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000579 # InputApi.platform is the platform you're currently running on.
580 self.platform = sys.platform
581
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000582 self.cpu_count = multiprocessing.cpu_count()
583
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000584 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000585 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000586
587 # We carry the canned checks so presubmit scripts can easily use them.
588 self.canned_checks = presubmit_canned_checks
589
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100590 # Temporary files we must manually remove at the end of a run.
591 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200592
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000593 # TODO(dpranke): figure out a list of all approved owners for a repo
594 # in order to be able to handle wildcard OWNERS files?
595 self.owners_db = owners.Database(change.RepositoryRoot(),
Edward Lemurb9830242019-10-30 22:19:20 +0000596 fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200597 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000598 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000599 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000600
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000601 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000602 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000603 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800604 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000605 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000606 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000607 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
608 for (a, b, header) in cpplint._re_pattern_templates
609 ]
610
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000611 def PresubmitLocalPath(self):
612 """Returns the local path of the presubmit script currently being run.
613
614 This is useful if you don't want to hard-code absolute paths in the
615 presubmit script. For example, It can be used to find another file
616 relative to the PRESUBMIT.py script, so the whole tree can be branched and
617 the presubmit script still works, without editing its content.
618 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000619 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000620
agable0b65e732016-11-22 09:25:46 -0800621 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000622 """Same as input_api.change.AffectedFiles() except only lists files
623 (and optionally directories) in the same directory as the current presubmit
624 script, or subdirectories thereof.
625 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000626 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000627 if len(dir_with_slash) == 1:
628 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000629
Edward Lemurb9830242019-10-30 22:19:20 +0000630 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000631 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000632 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000633
agable0b65e732016-11-22 09:25:46 -0800634 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000635 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800636 paths = [af.LocalPath() for af in self.AffectedFiles()]
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000637 logging.debug("LocalPaths: %s", paths)
638 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000639
agable0b65e732016-11-22 09:25:46 -0800640 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000641 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800642 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000643
John Budorick16162372018-04-18 10:39:53 -0700644 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800645 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000646 in the same directory as the current presubmit script, or subdirectories
647 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000648 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000649 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800650 warn("AffectedTestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000651 " is deprecated and ignored" % str(include_deletes),
652 category=DeprecationWarning,
653 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000654 return list(filter(
655 lambda x: x.IsTestableFile(),
656 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800657
658 def AffectedTextFiles(self, include_deletes=None):
659 """An alias to AffectedTestableFiles for backwards compatibility."""
660 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000661
maruel@chromium.org3410d912009-06-09 20:56:16 +0000662 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
663 """Filters out files that aren't considered "source file".
664
665 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
666 and InputApi.DEFAULT_BLACK_LIST is used respectively.
667
668 The lists will be compiled as regular expression and
669 AffectedFile.LocalPath() needs to pass both list.
670
671 Note: Copy-paste this function to suit your needs or use a lambda function.
672 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000673 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000674 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000675 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000676 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000677 return True
678 return False
679 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
680 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
681
682 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800683 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000684
685 If source_file is None, InputApi.FilterSourceFile() is used.
686 """
687 if not source_file:
688 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000689 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000690
691 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000692 """An iterator over all text lines in "new" version of changed files.
693
694 Only lists lines from new or modified text files in the change that are
695 contained by the directory of the currently executing presubmit script.
696
697 This is useful for doing line-by-line regex checks, like checking for
698 trailing whitespace.
699
700 Yields:
701 a 3 tuple:
702 the AffectedFile instance of the current file;
703 integer line number (1-based); and
704 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000705
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000706 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000707 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000708 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000709 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000710
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000711 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000712 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000713
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000714 Deny reading anything outside the repository.
715 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000716 if isinstance(file_item, AffectedFile):
717 file_item = file_item.AbsoluteLocalPath()
718 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000719 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000720 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000721
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100722 def CreateTemporaryFile(self, **kwargs):
723 """Returns a named temporary file that must be removed with a call to
724 RemoveTemporaryFiles().
725
726 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
727 except for |delete|, which is always set to False.
728
729 Presubmit checks that need to create a temporary file and pass it for
730 reading should use this function instead of NamedTemporaryFile(), as
731 Windows fails to open a file that is already open for writing.
732
733 with input_api.CreateTemporaryFile() as f:
734 f.write('xyz')
735 f.close()
736 input_api.subprocess.check_output(['script-that', '--reads-from',
737 f.name])
738
739
740 Note that callers of CreateTemporaryFile() should not worry about removing
741 any temporary file; this is done transparently by the presubmit handling
742 code.
743 """
744 if 'delete' in kwargs:
745 # Prevent users from passing |delete|; we take care of file deletion
746 # ourselves and this prevents unintuitive error messages when we pass
747 # delete=False and 'delete' is also in kwargs.
748 raise TypeError('CreateTemporaryFile() does not take a "delete" '
749 'argument, file deletion is handled automatically by '
750 'the same presubmit_support code that creates InputApi '
751 'objects.')
752 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
753 self._named_temporary_files.append(temp_file.name)
754 return temp_file
755
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000756 @property
757 def tbr(self):
758 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400759 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000760
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000761 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000762 tests = []
763 msgs = []
764 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400765 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000766 msgs.append(t)
767 else:
768 assert issubclass(t.message, _PresubmitResult)
769 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000770 if self.verbose:
771 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400772 if not t.kwargs.get('cwd'):
773 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400774 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000775 # When self.parallel is True (i.e. --parallel is passed as an option)
776 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
777 # will run all tests once all PRESUBMIT files are processed.
778 # Otherwise, it will run them and return the results.
779 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400780 msgs.extend(self.thread_pool.RunAsync())
781 return msgs
scottmg86099d72016-09-01 09:16:51 -0700782
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000783
nick@chromium.orgff526192013-06-10 19:30:26 +0000784class _DiffCache(object):
785 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000786 def __init__(self, upstream=None):
787 """Stores the upstream revision against which all diffs will be computed."""
788 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000789
790 def GetDiff(self, path, local_root):
791 """Get the diff for a particular path."""
792 raise NotImplementedError()
793
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700794 def GetOldContents(self, path, local_root):
795 """Get the old version for a particular path."""
796 raise NotImplementedError()
797
nick@chromium.orgff526192013-06-10 19:30:26 +0000798
nick@chromium.orgff526192013-06-10 19:30:26 +0000799class _GitDiffCache(_DiffCache):
800 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000801 def __init__(self, upstream):
802 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000803 self._diffs_by_file = None
804
805 def GetDiff(self, path, local_root):
806 if not self._diffs_by_file:
807 # Compute a single diff for all files and parse the output; should
808 # with git this is much faster than computing one diff for each file.
809 diffs = {}
810
811 # Don't specify any filenames below, because there are command line length
812 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000813 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
814 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000815
816 # This regex matches the path twice, separated by a space. Note that
817 # filename itself may contain spaces.
818 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
819 current_diff = []
820 keep_line_endings = True
821 for x in unified_diff.splitlines(keep_line_endings):
822 match = file_marker.match(x)
823 if match:
824 # Marks the start of a new per-file section.
825 diffs[match.group('filename')] = current_diff = [x]
826 elif x.startswith('diff --git'):
827 raise PresubmitFailure('Unexpected diff line: %s' % x)
828 else:
829 current_diff.append(x)
830
831 self._diffs_by_file = dict(
832 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
833
834 if path not in self._diffs_by_file:
835 raise PresubmitFailure(
836 'Unified diff did not contain entry for file %s' % path)
837
838 return self._diffs_by_file[path]
839
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700840 def GetOldContents(self, path, local_root):
841 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
842
nick@chromium.orgff526192013-06-10 19:30:26 +0000843
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000844class AffectedFile(object):
845 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000846
847 DIFF_CACHE = _DiffCache
848
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000849 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800850 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000851 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000852 self._path = path
853 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000854 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000855 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000856 self._cached_changed_contents = None
857 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000858 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700859 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000860
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000861 def LocalPath(self):
862 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400863
864 This should be used for error messages but not for accessing files,
865 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
866 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000867 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000868 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000869
870 def AbsoluteLocalPath(self):
871 """Returns the absolute path of this file on the local disk.
872 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000873 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000874
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000875 def Action(self):
876 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000877 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000878
agable0b65e732016-11-22 09:25:46 -0800879 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000880 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000881
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000882 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000883 raise NotImplementedError() # Implement when needed
884
agable0b65e732016-11-22 09:25:46 -0800885 def IsTextFile(self):
886 """An alias to IsTestableFile for backwards compatibility."""
887 return self.IsTestableFile()
888
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700889 def OldContents(self):
890 """Returns an iterator over the lines in the old version of file.
891
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700892 The old version is the file before any modifications in the user's
893 workspace, i.e. the "left hand side".
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700894
895 Contents will be empty if the file is a directory or does not exist.
896 Note: The carriage returns (LF or CR) are stripped off.
897 """
898 return self._diff_cache.GetOldContents(self.LocalPath(),
899 self._local_root).splitlines()
900
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000901 def NewContents(self):
902 """Returns an iterator over the lines in the new version of file.
903
904 The new version is the file in the user's workspace, i.e. the "right hand
905 side".
906
907 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000908 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000909 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000910 if self._cached_new_contents is None:
911 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800912 try:
913 self._cached_new_contents = gclient_utils.FileRead(
914 self.AbsoluteLocalPath(), 'rU').splitlines()
915 except IOError:
916 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000917 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000918
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000919 def ChangedContents(self):
920 """Returns a list of tuples (line number, line text) of all new lines.
921
922 This relies on the scm diff output describing each changed code section
923 with a line of the form
924
925 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
926 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000927 if self._cached_changed_contents is not None:
928 return self._cached_changed_contents[:]
929 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000930 line_num = 0
931
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000932 for line in self.GenerateScmDiff().splitlines():
933 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
934 if m:
935 line_num = int(m.groups(1)[0])
936 continue
937 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000938 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000939 if not line.startswith('-'):
940 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000941 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000942
maruel@chromium.org5de13972009-06-10 18:16:06 +0000943 def __str__(self):
944 return self.LocalPath()
945
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000946 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000947 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000948
maruel@chromium.org58407af2011-04-12 23:15:57 +0000949
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000950class GitAffectedFile(AffectedFile):
951 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000952 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800953 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000954
nick@chromium.orgff526192013-06-10 19:30:26 +0000955 DIFF_CACHE = _GitDiffCache
956
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000957 def __init__(self, *args, **kwargs):
958 AffectedFile.__init__(self, *args, **kwargs)
959 self._server_path = None
agable0b65e732016-11-22 09:25:46 -0800960 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000961
agable0b65e732016-11-22 09:25:46 -0800962 def IsTestableFile(self):
963 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000964 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -0800965 # A deleted file is not testable.
966 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000967 else:
agable0b65e732016-11-22 09:25:46 -0800968 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
969 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000970
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000971
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000972class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000973 """Describe a change.
974
975 Used directly by the presubmit scripts to query the current change being
976 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000977
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000978 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000979 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000980 self.KEY: equivalent to tags['KEY']
981 """
982
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000983 _AFFECTED_FILES = AffectedFile
984
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000985 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000986 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000987 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000988 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000989
maruel@chromium.org58407af2011-04-12 23:15:57 +0000990 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000991 self, name, description, local_root, files, issue, patchset, author,
992 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000993 if files is None:
994 files = []
995 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +0000996 # Convert root into an absolute path.
997 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000998 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000999 self.issue = issue
1000 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001001 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001002
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001003 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001004 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001005 self._description_without_tags = ''
1006 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001007
maruel@chromium.orge085d812011-10-10 19:49:15 +00001008 assert all(
1009 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1010
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001011 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001012 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001013 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1014 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001015 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001016
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001017 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001018 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001019 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001020
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001021 def DescriptionText(self):
1022 """Returns the user-entered changelist description, minus tags.
1023
1024 Any line in the user-provided description starting with e.g. "FOO="
1025 (whitespace permitted before and around) is considered a tag line. Such
1026 lines are stripped out of the description this function returns.
1027 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001028 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001029
1030 def FullDescriptionText(self):
1031 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001032 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001033
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001034 def SetDescriptionText(self, description):
1035 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001036
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001037 Also updates the list of tags."""
1038 self._full_description = description
1039
1040 # From the description text, build up a dictionary of key/value pairs
1041 # plus the description minus all key/value or "tag" lines.
1042 description_without_tags = []
1043 self.tags = {}
1044 for line in self._full_description.splitlines():
1045 m = self.TAG_LINE_RE.match(line)
1046 if m:
1047 self.tags[m.group('key')] = m.group('value')
1048 else:
1049 description_without_tags.append(line)
1050
1051 # Change back to text and remove whitespace at end.
1052 self._description_without_tags = (
1053 '\n'.join(description_without_tags).rstrip())
1054
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001055 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001056 """Returns the repository (checkout) root directory for this change,
1057 as an absolute path.
1058 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001059 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001060
1061 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001062 """Return tags directly as attributes on the object."""
1063 if not re.match(r"^[A-Z_]*$", attr):
1064 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001065 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001066
Aaron Gablefc03e672017-05-15 14:09:42 -07001067 def BugsFromDescription(self):
1068 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001069 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001070 footers = []
Dan Beam62954042019-10-03 21:20:33 +00001071 parsed = git_footers.parse_footers(self._full_description)
1072 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001073 for unsplit_footer in unsplit_footers:
1074 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001075 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001076
1077 def ReviewersFromDescription(self):
1078 """Returns all reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001079 # We don't support a "R:" git-footer for reviewers; that is in metadata.
1080 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1081 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001082
1083 def TBRsFromDescription(self):
1084 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001085 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1086 # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically
1087 # determined by self-CR+1s.
1088 footers = git_footers.parse_footers(self._full_description).get('Tbr', [])
1089 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001090
1091 # TODO(agable): Delete these once we're sure they're unused.
1092 @property
1093 def BUG(self):
1094 return ','.join(self.BugsFromDescription())
1095 @property
1096 def R(self):
1097 return ','.join(self.ReviewersFromDescription())
1098 @property
1099 def TBR(self):
1100 return ','.join(self.TBRsFromDescription())
1101
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001102 def AllFiles(self, root=None):
1103 """List all files under source control in the repo."""
1104 raise NotImplementedError()
1105
agable0b65e732016-11-22 09:25:46 -08001106 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001107 """Returns a list of AffectedFile instances for all files in the change.
1108
1109 Args:
1110 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001111 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001112
1113 Returns:
1114 [AffectedFile(path, action), AffectedFile(path, action)]
1115 """
Edward Lemurb9830242019-10-30 22:19:20 +00001116 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001117
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001118 if include_deletes:
1119 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001120 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001121
John Budorick16162372018-04-18 10:39:53 -07001122 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001123 """Return a list of the existing text files in a change."""
1124 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -08001125 warn("AffectedTeestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001126 " is deprecated and ignored" % str(include_deletes),
1127 category=DeprecationWarning,
1128 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001129 return list(filter(
1130 lambda x: x.IsTestableFile(),
1131 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001132
agable0b65e732016-11-22 09:25:46 -08001133 def AffectedTextFiles(self, include_deletes=None):
1134 """An alias to AffectedTestableFiles for backwards compatibility."""
1135 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001136
agable0b65e732016-11-22 09:25:46 -08001137 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001138 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001139 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001140
agable0b65e732016-11-22 09:25:46 -08001141 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001142 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001143 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001144
1145 def RightHandSideLines(self):
1146 """An iterator over all text lines in "new" version of changed files.
1147
1148 Lists lines from new or modified text files in the change.
1149
1150 This is useful for doing line-by-line regex checks, like checking for
1151 trailing whitespace.
1152
1153 Yields:
1154 a 3 tuple:
1155 the AffectedFile instance of the current file;
1156 integer line number (1-based); and
1157 the contents of the line as a string.
1158 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001159 return _RightHandSideLinesImpl(
1160 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001161 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001162
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001163 def OriginalOwnersFiles(self):
1164 """A map from path names of affected OWNERS files to their old content."""
1165 def owners_file_filter(f):
1166 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1167 files = self.AffectedFiles(file_filter=owners_file_filter)
1168 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1169
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001170
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001171class GitChange(Change):
1172 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001173 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001174
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001175 def AllFiles(self, root=None):
1176 """List all files under source control in the repo."""
1177 root = root or self.RepositoryRoot()
1178 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001179 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1180 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001181
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001182
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001183def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001184 """Finds all presubmit files that apply to a given set of source files.
1185
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001186 If inherit-review-settings-ok is present right under root, looks for
1187 PRESUBMIT.py in directories enclosing root.
1188
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001189 Args:
1190 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001191 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001192
1193 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001194 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001195 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001196 files = [normpath(os.path.join(root, f)) for f in files]
1197
1198 # List all the individual directories containing files.
1199 directories = set([os.path.dirname(f) for f in files])
1200
1201 # Ignore root if inherit-review-settings-ok is present.
1202 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1203 root = None
1204
1205 # Collect all unique directories that may contain PRESUBMIT.py.
1206 candidates = set()
1207 for directory in directories:
1208 while True:
1209 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001210 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001211 candidates.add(directory)
1212 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001213 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001214 parent_dir = os.path.dirname(directory)
1215 if parent_dir == directory:
1216 # We hit the system root directory.
1217 break
1218 directory = parent_dir
1219
1220 # Look for PRESUBMIT.py in all candidate directories.
1221 results = []
1222 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001223 try:
1224 for f in os.listdir(directory):
1225 p = os.path.join(directory, f)
1226 if os.path.isfile(p) and re.match(
1227 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1228 results.append(p)
1229 except OSError:
1230 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001231
tobiasjs2836bcf2016-08-16 04:08:16 -07001232 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001233 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001234
1235
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001236class GetTryMastersExecuter(object):
1237 @staticmethod
1238 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1239 """Executes GetPreferredTryMasters() from a single presubmit script.
1240
1241 Args:
1242 script_text: The text of the presubmit script.
1243 presubmit_path: Project script to run.
1244 project: Project name to pass to presubmit script for bot selection.
1245
1246 Return:
1247 A map of try masters to map of builders to set of tests.
1248 """
1249 context = {}
1250 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001251 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1252 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001253 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001254 raise PresubmitFailure('"%s" had an exception.\n%s'
1255 % (presubmit_path, e))
1256
1257 function_name = 'GetPreferredTryMasters'
1258 if function_name not in context:
1259 return {}
1260 get_preferred_try_masters = context[function_name]
1261 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1262 raise PresubmitFailure(
1263 'Expected function "GetPreferredTryMasters" to take two arguments.')
1264 return get_preferred_try_masters(project, change)
1265
1266
rmistry@google.com5626a922015-02-26 14:03:30 +00001267class GetPostUploadExecuter(object):
1268 @staticmethod
1269 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1270 """Executes PostUploadHook() from a single presubmit script.
1271
1272 Args:
1273 script_text: The text of the presubmit script.
1274 presubmit_path: Project script to run.
1275 cl: The Changelist object.
1276 change: The Change object.
1277
1278 Return:
1279 A list of results objects.
1280 """
1281 context = {}
1282 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001283 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1284 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001285 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001286 raise PresubmitFailure('"%s" had an exception.\n%s'
1287 % (presubmit_path, e))
1288
1289 function_name = 'PostUploadHook'
1290 if function_name not in context:
1291 return {}
1292 post_upload_hook = context[function_name]
1293 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1294 raise PresubmitFailure(
1295 'Expected function "PostUploadHook" to take three arguments.')
1296 return post_upload_hook(cl, change, OutputApi(False))
1297
1298
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001299def _MergeMasters(masters1, masters2):
1300 """Merges two master maps. Merges also the tests of each builder."""
1301 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001302 for (master, builders) in itertools.chain(masters1.items(),
1303 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001304 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001305 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001306 new_builders.setdefault(builder, set([])).update(tests)
1307 return result
1308
1309
1310def DoGetTryMasters(change,
1311 changed_files,
1312 repository_root,
1313 default_presubmit,
1314 project,
1315 verbose,
1316 output_stream):
1317 """Get the list of try masters from the presubmit scripts.
1318
1319 Args:
1320 changed_files: List of modified files.
1321 repository_root: The repository root.
1322 default_presubmit: A default presubmit script to execute in any case.
1323 project: Optional name of a project used in selecting trybots.
1324 verbose: Prints debug info.
1325 output_stream: A stream to write debug output to.
1326
1327 Return:
1328 Map of try masters to map of builders to set of tests.
1329 """
1330 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1331 if not presubmit_files and verbose:
1332 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1333 results = {}
1334 executer = GetTryMastersExecuter()
1335
1336 if default_presubmit:
1337 if verbose:
1338 output_stream.write("Running default presubmit script.\n")
1339 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1340 results = _MergeMasters(results, executer.ExecPresubmitScript(
1341 default_presubmit, fake_path, project, change))
1342 for filename in presubmit_files:
1343 filename = os.path.abspath(filename)
1344 if verbose:
1345 output_stream.write("Running %s\n" % filename)
1346 # Accept CRLF presubmit script.
1347 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1348 results = _MergeMasters(results, executer.ExecPresubmitScript(
1349 presubmit_script, filename, project, change))
1350
1351 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001352 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001353 for builder in builders:
1354 builders[builder] = list(builders[builder])
1355
1356 if results and verbose:
1357 output_stream.write('%s\n' % str(results))
1358 return results
1359
1360
rmistry@google.com5626a922015-02-26 14:03:30 +00001361def DoPostUploadExecuter(change,
1362 cl,
1363 repository_root,
1364 verbose,
1365 output_stream):
1366 """Execute the post upload hook.
1367
1368 Args:
1369 change: The Change object.
1370 cl: The Changelist object.
1371 repository_root: The repository root.
1372 verbose: Prints debug info.
1373 output_stream: A stream to write debug output to.
1374 """
1375 presubmit_files = ListRelevantPresubmitFiles(
1376 change.LocalPaths(), repository_root)
1377 if not presubmit_files and verbose:
1378 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1379 results = []
1380 executer = GetPostUploadExecuter()
1381 # The root presubmit file should be executed after the ones in subdirectories.
1382 # i.e. the specific post upload hooks should run before the general ones.
1383 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1384 presubmit_files.reverse()
1385
1386 for filename in presubmit_files:
1387 filename = os.path.abspath(filename)
1388 if verbose:
1389 output_stream.write("Running %s\n" % filename)
1390 # Accept CRLF presubmit script.
1391 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1392 results.extend(executer.ExecPresubmitScript(
1393 presubmit_script, filename, cl, change))
1394 output_stream.write('\n')
1395 if results:
1396 output_stream.write('** Post Upload Hook Messages **\n')
1397 for result in results:
1398 result.handle(output_stream)
1399 output_stream.write('\n')
1400
1401 return results
1402
1403
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001404class PresubmitExecuter(object):
Aaron Gable668c1d82018-04-03 10:19:16 -07001405 def __init__(self, change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001406 gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001407 """
1408 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001409 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001410 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001411 gerrit_obj: provides basic Gerrit codereview functionality.
1412 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001413 parallel: if true, all tests reported via input_api.RunTests for all
1414 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001415 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001416 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001417 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001418 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001419 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001420 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001421 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001422 self.thread_pool = thread_pool
1423 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001424
1425 def ExecPresubmitScript(self, script_text, presubmit_path):
1426 """Executes a single presubmit script.
1427
1428 Args:
1429 script_text: The text of the presubmit script.
1430 presubmit_path: The path to the presubmit file (this will be reported via
1431 input_api.PresubmitLocalPath()).
1432
1433 Return:
1434 A list of result objects, empty if no problems.
1435 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001436
chase@chromium.org8e416c82009-10-06 04:30:44 +00001437 # Change to the presubmit file's directory to support local imports.
1438 main_path = os.getcwd()
1439 os.chdir(os.path.dirname(presubmit_path))
1440
1441 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001442 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001443 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001444 dry_run=self.dry_run, thread_pool=self.thread_pool,
1445 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001446 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001447 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001448 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001449 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1450 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001451 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001452 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001453
1454 # These function names must change if we make substantial changes to
1455 # the presubmit API that are not backwards compatible.
1456 if self.committing:
1457 function_name = 'CheckChangeOnCommit'
1458 else:
1459 function_name = 'CheckChangeOnUpload'
1460 if function_name in context:
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001461 try:
Daniel Cheng7227d212017-11-17 08:12:37 -08001462 context['__args'] = (input_api, output_api)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001463 logging.debug('Running %s in %s', function_name, presubmit_path)
1464 result = eval(function_name + '(*__args)', context)
1465 logging.debug('Running %s done.', function_name)
Daniel Chengd36fce42017-11-21 21:52:52 -08001466 self.more_cc.extend(output_api.more_cc)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001467 finally:
Edward Lemurb9830242019-10-30 22:19:20 +00001468 for f in input_api._named_temporary_files:
1469 os.remove(f)
1470 if not isinstance(result, (tuple, list)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001471 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001472 'Presubmit functions must return a tuple or list')
1473 for item in result:
1474 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001475 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001476 'All presubmit results must be of types derived from '
1477 'output_api.PresubmitResult')
1478 else:
1479 result = () # no error since the script doesn't care about current event.
1480
chase@chromium.org8e416c82009-10-06 04:30:44 +00001481 # Return the process to the original working directory.
1482 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001483 return result
1484
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001485def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001486 committing,
1487 verbose,
1488 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001489 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001490 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001491 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001492 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001493 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001494 parallel=False,
1495 json_output=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001496 """Runs all presubmit checks that apply to the files in the change.
1497
1498 This finds all PRESUBMIT.py files in directories enclosing the files in the
1499 change (up to the repository root) and calls the relevant entrypoint function
1500 depending on whether the change is being committed or uploaded.
1501
1502 Prints errors, warnings and notifications. Prompts the user for warnings
1503 when needed.
1504
1505 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001506 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001507 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001508 verbose: Prints debug info.
1509 output_stream: A stream to write output from presubmit tests to.
1510 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001511 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001512 may_prompt: Enable (y/n) questions on warning or error. If False,
1513 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001514 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001515 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001516 parallel: if true, all tests specified by input_api.RunTests in all
1517 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001518
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001519 Warning:
1520 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1521 SHOULD be sys.stdin.
1522
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001523 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001524 A PresubmitOutput object. Use output.should_continue() to figure out
1525 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001526 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001527 old_environ = os.environ
1528 try:
1529 # Make sure python subprocesses won't generate .pyc files.
1530 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001531 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001532
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001533 output = PresubmitOutput(input_stream, output_stream)
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001534
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001535 if committing:
1536 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001537 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001538 output.write("Running presubmit upload checks ...\n")
1539 start_time = time.time()
1540 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001541 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001542 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001543 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001544 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001545 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001546 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
1547 dry_run, thread_pool, parallel)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001548 if default_presubmit:
1549 if verbose:
1550 output.write("Running default presubmit script.\n")
1551 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1552 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1553 for filename in presubmit_files:
1554 filename = os.path.abspath(filename)
1555 if verbose:
1556 output.write("Running %s\n" % filename)
1557 # Accept CRLF presubmit script.
1558 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1559 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001560
Edward Lesmes8e282792018-04-03 18:50:29 -04001561 results += thread_pool.RunAsync()
1562
Daniel Cheng7227d212017-11-17 08:12:37 -08001563 output.more_cc.extend(executer.more_cc)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001564 errors = []
1565 notifications = []
1566 warnings = []
1567 for result in results:
1568 if result.fatal:
1569 errors.append(result)
1570 elif result.should_prompt:
1571 warnings.append(result)
1572 else:
1573 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001574
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001575 if json_output:
1576 # Write the presubmit results to json output
1577 presubmit_results = {
1578 'errors': [
1579 error.json_format() for error in errors
1580 ],
1581 'notifications': [
1582 notification.json_format() for notification in notifications
1583 ],
1584 'warnings': [
1585 warning.json_format() for warning in warnings
1586 ]
1587 }
1588
Edward Lemurb9830242019-10-30 22:19:20 +00001589 gclient_utils.FileWrite(
1590 json_output, json.dumps(presubmit_results, sort_keys=True))
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001591
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001592 output.write('\n')
1593 for name, items in (('Messages', notifications),
1594 ('Warnings', warnings),
1595 ('ERRORS', errors)):
1596 if items:
1597 output.write('** Presubmit %s **\n' % name)
1598 for item in items:
1599 item.handle(output)
1600 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001601
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001602 total_time = time.time() - start_time
1603 if total_time > 1.0:
1604 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001605
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001606 if errors:
1607 output.fail()
1608 elif warnings:
1609 output.write('There were presubmit warnings. ')
1610 if may_prompt:
1611 output.prompt_yes_no('Are you sure you wish to continue? (y/N): ')
1612 else:
1613 output.write('Presubmit checks passed.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001614
1615 global _ASKED_FOR_FEEDBACK
1616 # Ask for feedback one time out of 5.
1617 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001618 output.write(
1619 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1620 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1621 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001622 _ASKED_FOR_FEEDBACK = True
1623 return output
1624 finally:
1625 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001626
1627
1628def ScanSubDirs(mask, recursive):
1629 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001630 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001631
1632 results = []
1633 for root, dirs, files in os.walk('.'):
1634 if '.svn' in dirs:
1635 dirs.remove('.svn')
1636 if '.git' in dirs:
1637 dirs.remove('.git')
1638 for name in files:
1639 if fnmatch.fnmatch(name, mask):
1640 results.append(os.path.join(root, name))
1641 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001642
1643
1644def ParseFiles(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001645 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001646 files = []
1647 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001648 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001649 return files
1650
1651
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001652def load_files(options, args):
1653 """Tries to determine the SCM."""
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001654 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001655 if args:
1656 files = ParseFiles(args, options.recursive)
agable0b65e732016-11-22 09:25:46 -08001657 change_scm = scm.determine_scm(options.root)
1658 if change_scm == 'git':
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001659 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001660 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001661 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001662 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001663 else:
tobiasjs2836bcf2016-08-16 04:08:16 -07001664 logging.info('Doesn\'t seem under source control. Got %d files', len(args))
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001665 if not files:
1666 return None, None
1667 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001668 return change_class, files
1669
1670
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001671@contextlib.contextmanager
1672def canned_check_filter(method_names):
1673 filtered = {}
1674 try:
1675 for method_name in method_names:
1676 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001677 logging.warn('Skipping unknown "canned" check %s' % method_name)
1678 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001679 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1680 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1681 yield
1682 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001683 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001684 setattr(presubmit_canned_checks, name, method)
1685
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001686
sbc@chromium.org013731e2015-02-26 18:28:43 +00001687def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001688 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001689 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001690 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001691 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001692 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1693 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001694 parser.add_option("-r", "--recursive", action="store_true",
1695 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001696 parser.add_option("-v", "--verbose", action="count", default=0,
1697 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001698 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001699 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001700 parser.add_option("--description", default='')
1701 parser.add_option("--issue", type='int', default=0)
1702 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001703 parser.add_option("--root", default=os.getcwd(),
1704 help="Search for PRESUBMIT.py up to this directory. "
1705 "If inherit-review-settings-ok is present in this "
1706 "directory, parent directories up to the root file "
1707 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001708 parser.add_option("--upstream",
1709 help="Git only: the base ref or upstream branch against "
1710 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001711 parser.add_option("--default_presubmit")
1712 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001713 parser.add_option("--skip_canned", action='append', default=[],
1714 help="A list of checks to skip which appear in "
1715 "presubmit_canned_checks. Can be provided multiple times "
1716 "to skip multiple canned checks.")
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001717 parser.add_option("--dry_run", action='store_true',
1718 help=optparse.SUPPRESS_HELP)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001719 parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP)
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001720 parser.add_option("--gerrit_fetch", action='store_true',
1721 help=optparse.SUPPRESS_HELP)
Edward Lesmes8e282792018-04-03 18:50:29 -04001722 parser.add_option('--parallel', action='store_true',
1723 help='Run all tests specified by input_api.RunTests in all '
1724 'PRESUBMIT files in parallel.')
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001725 parser.add_option('--json_output',
1726 help='Write presubmit errors to json output.')
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001727
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001728 options, args = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001729
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001730 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001731 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001732 elif options.verbose:
1733 logging.basicConfig(level=logging.INFO)
1734 else:
1735 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001736
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001737 change_class, files = load_files(options, args)
1738 if not change_class:
1739 parser.error('For unversioned directory, <files> is not optional.')
tobiasjs2836bcf2016-08-16 04:08:16 -07001740 logging.info('Found %d file(s).', len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001741
Aaron Gable668c1d82018-04-03 10:19:16 -07001742 gerrit_obj = None
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001743 if options.gerrit_url and options.gerrit_fetch:
tandrii@chromium.org83b1b232016-04-29 16:33:19 +00001744 assert options.issue and options.patchset
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001745 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1746 options.author = gerrit_obj.GetChangeOwner(options.issue)
1747 options.description = gerrit_obj.GetChangeDescription(options.issue,
1748 options.patchset)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001749 logging.info('Got author: "%s"', options.author)
1750 logging.info('Got description: """\n%s\n"""', options.description)
1751
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001752 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001753 with canned_check_filter(options.skip_canned):
1754 results = DoPresubmitChecks(
1755 change_class(options.name,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001756 options.description,
1757 options.root,
1758 files,
1759 options.issue,
1760 options.patchset,
1761 options.author,
1762 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001763 options.commit,
1764 options.verbose,
1765 sys.stdout,
1766 sys.stdin,
1767 options.default_presubmit,
1768 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001769 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001770 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001771 options.parallel,
1772 options.json_output)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001773 return not results.should_continue()
Raul Tambre7c938462019-05-24 16:35:35 +00001774 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00001775 print(e, file=sys.stderr)
1776 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001777 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001778
1779
1780if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001781 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001782 try:
1783 sys.exit(main())
1784 except KeyboardInterrupt:
1785 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001786 sys.exit(2)