blob: fb3cb51ed0f50d0ea096becdb63054920f18722e [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env python3
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners as owners_db
48import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020049import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000050import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000051import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000052import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000053import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000054
Edward Lemur16af3562019-10-17 22:11:33 +000055if sys.version_info.major == 2:
56 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
57 import urllib2 # Exposed through the API.
58 import urlparse
59 import urllib2 as urllib_request
60 import urllib2 as urllib_error
61else:
62 import urllib.parse as urlparse
63 import urllib.request as urllib_request
64 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000065
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000066# Ask for feedback only once in program lifetime.
67_ASKED_FOR_FEEDBACK = False
68
Edward Lemurecc27072020-01-06 16:42:34 +000069def time_time():
70 # Use this so that it can be mocked in tests without interfering with python
71 # system machinery.
72 return time.time()
73
74
maruel@chromium.org899e1c12011-04-07 17:03:18 +000075class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000076 pass
77
78
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000080 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000081 self.name = name
82 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000084 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040085 self.kwargs['stdout'] = subprocess.PIPE
86 self.kwargs['stderr'] = subprocess.STDOUT
87 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000088 self.message = message
89 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000090 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000091
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000092
Edward Lesmes8e282792018-04-03 18:50:29 -040093# Adapted from
94# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
95#
96# An object that catches SIGINT sent to the Python process and notices
97# if processes passed to wait() die by SIGINT (we need to look for
98# both of those cases, because pressing Ctrl+C can result in either
99# the main process or one of the subprocesses getting the signal).
100#
101# Before a SIGINT is seen, wait(p) will simply call p.wait() and
102# return the result. Once a SIGINT has been seen (in the main process
103# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000104# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400105class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400106 sigint_returncodes = {-signal.SIGINT, # Unix
107 -1073741510, # Windows
108 }
109 def __init__(self):
110 self.__lock = threading.Lock()
111 self.__processes = set()
112 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000113 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400114
115 def __on_sigint(self):
116 self.__got_sigint = True
117 while self.__processes:
118 try:
119 self.__processes.pop().terminate()
120 except OSError:
121 pass
122
Edward Lemur9a5bb612019-09-26 02:01:52 +0000123 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400124 with self.__lock:
125 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000126 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400127
128 def got_sigint(self):
129 with self.__lock:
130 return self.__got_sigint
131
132 def wait(self, p, stdin):
133 with self.__lock:
134 if self.__got_sigint:
135 p.terminate()
136 self.__processes.add(p)
137 stdout, stderr = p.communicate(stdin)
138 code = p.returncode
139 with self.__lock:
140 self.__processes.discard(p)
141 if code in self.sigint_returncodes:
142 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400143 return stdout, stderr
144
145sigint_handler = SigintHandler()
146
147
Edward Lemurecc27072020-01-06 16:42:34 +0000148class Timer(object):
149 def __init__(self, timeout, fn):
150 self.completed = False
151 self._fn = fn
152 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
153
154 def __enter__(self):
155 if self._timer:
156 self._timer.start()
157 return self
158
159 def __exit__(self, _type, _value, _traceback):
160 if self._timer:
161 self._timer.cancel()
162
163 def _onTimer(self):
164 self._fn()
165 self.completed = True
166
167
Edward Lesmes8e282792018-04-03 18:50:29 -0400168class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000169 def __init__(self, pool_size=None, timeout=None):
170 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400171 self._pool_size = pool_size or multiprocessing.cpu_count()
172 self._messages = []
173 self._messages_lock = threading.Lock()
174 self._tests = []
175 self._tests_lock = threading.Lock()
176 self._nonparallel_tests = []
177
Edward Lemurecc27072020-01-06 16:42:34 +0000178 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000179 vpython = 'vpython'
180 if test.python3:
181 vpython += '3'
182 if sys.platform == 'win32':
183 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400184
185 cmd = test.cmd
186 if cmd[0] == 'python':
187 cmd = list(cmd)
188 cmd[0] = vpython
189 elif cmd[0].endswith('.py'):
190 cmd = [vpython] + cmd
191
Edward Lemur336e51f2019-11-14 21:42:04 +0000192 # On Windows, scripts on the current directory take precedence over PATH, so
193 # that when testing depot_tools on Windows, calling `vpython.bat` will
194 # execute the copy of vpython of the depot_tools under test instead of the
195 # one in the bot.
196 # As a workaround, we run the tests from the parent directory instead.
197 if (cmd[0] == vpython and
198 'cwd' in test.kwargs and
199 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
200 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
201 cmd[1] = os.path.join('depot_tools', cmd[1])
202
Edward Lemurecc27072020-01-06 16:42:34 +0000203 return cmd
204
205 def _RunWithTimeout(self, cmd, stdin, kwargs):
206 p = subprocess.Popen(cmd, **kwargs)
207 with Timer(self.timeout, p.terminate) as timer:
208 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000209 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000210 if timer.completed:
211 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000212 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000213
214 def CallCommand(self, test):
215 """Runs an external program.
216
Edward Lemura5799e32020-01-17 19:26:51 +0000217 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000218 to vpython invocations.
219 """
220 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400221 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000222 start = time_time()
223 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
224 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000225 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000226 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400227 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000228 '%s\n%s exec failure (%4.2fs)\n%s' % (
229 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000230
Edward Lemurecc27072020-01-06 16:42:34 +0000231 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400232 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000233 '%s\n%s (%4.2fs) failed\n%s' % (
234 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000235
Edward Lesmes8e282792018-04-03 18:50:29 -0400236 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000237 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400238
239 def AddTests(self, tests, parallel=True):
240 if parallel:
241 self._tests.extend(tests)
242 else:
243 self._nonparallel_tests.extend(tests)
244
245 def RunAsync(self):
246 self._messages = []
247
248 def _WorkerFn():
249 while True:
250 test = None
251 with self._tests_lock:
252 if not self._tests:
253 break
254 test = self._tests.pop()
255 result = self.CallCommand(test)
256 if result:
257 with self._messages_lock:
258 self._messages.append(result)
259
260 def _StartDaemon():
261 t = threading.Thread(target=_WorkerFn)
262 t.daemon = True
263 t.start()
264 return t
265
266 while self._nonparallel_tests:
267 test = self._nonparallel_tests.pop()
268 result = self.CallCommand(test)
269 if result:
270 self._messages.append(result)
271
272 if self._tests:
273 threads = [_StartDaemon() for _ in range(self._pool_size)]
274 for worker in threads:
275 worker.join()
276
277 return self._messages
278
279
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000280def normpath(path):
281 '''Version of os.path.normpath that also changes backward slashes to
282 forward slashes when not running on Windows.
283 '''
284 # This is safe to always do because the Windows version of os.path.normpath
285 # will replace forward slashes with backward slashes.
286 path = path.replace(os.sep, '/')
287 return os.path.normpath(path)
288
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000289
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000290def _RightHandSideLinesImpl(affected_files):
291 """Implements RightHandSideLines for InputApi and GclChange."""
292 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000293 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000294 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000295 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000296
297
Edward Lemur6eb1d322020-02-27 22:20:15 +0000298def prompt_should_continue(prompt_string):
299 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000300 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000301 response = sys.stdin.readline().strip().lower()
302 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000303
304
Josip Sokcevice293d3d2022-02-16 22:52:15 +0000305def _ShouldRunPresubmit(script_text, use_python3):
306 """Try to figure out whether these presubmit checks should be run under
307 python2 or python3. We need to do this without actually trying to
308 compile the text, since the text might compile in one but not the
309 other.
310
311 Args:
312 script_text: The text of the presubmit script.
313 use_python3: if true, will use python3 instead of python2 by default
314 if USE_PYTHON3 is not specified.
315
316 Return:
317 A boolean if presubmit should be executed
318 """
319 m = re.search('^USE_PYTHON3 = (True|False)$', script_text, flags=re.MULTILINE)
320 if m:
321 use_python3 = m.group(1) == 'True'
322
323 return ((sys.version_info.major == 2) and not use_python3) or \
324 ((sys.version_info.major == 3) and use_python3)
325
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000326# Top level object so multiprocessing can pickle
327# Public access through OutputApi object.
328class _PresubmitResult(object):
329 """Base class for result objects."""
330 fatal = False
331 should_prompt = False
332
333 def __init__(self, message, items=None, long_text=''):
334 """
335 message: A short one-line message to indicate errors.
336 items: A list of short strings to indicate where errors occurred.
337 long_text: multi-line text output, e.g. from another tool
338 """
Bruce Dawsondb8622b2022-04-03 15:38:12 +0000339 self._message = _PresubmitResult._ensure_str(message)
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000340 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000341 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
342
343 @staticmethod
344 def _ensure_str(val):
345 """
346 val: A "stringish" value. Can be any of str, unicode or bytes.
347 returns: A str after applying encoding/decoding as needed.
348 Assumes/uses UTF-8 for relevant inputs/outputs.
349
350 We'd prefer to use six.ensure_str but our copy of six is old :(
351 """
352 if isinstance(val, str):
353 return val
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000354
Tom McKee61c72652021-07-20 11:56:32 +0000355 if six.PY2 and isinstance(val, unicode):
356 return val.encode()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000357
358 if six.PY3 and isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000359 return val.decode()
360 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000361
Edward Lemur6eb1d322020-02-27 22:20:15 +0000362 def handle(self):
363 sys.stdout.write(self._message)
364 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000365 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000366 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000367 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000368 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000369 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000370 sys.stdout.write(' \\')
371 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000372 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000373 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000374 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000375 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000376 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000377
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000378 def json_format(self):
379 return {
380 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000381 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000382 'long_text': self._long_text,
383 'fatal': self.fatal
384 }
385
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000386
387# Top level object so multiprocessing can pickle
388# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000389class _PresubmitError(_PresubmitResult):
390 """A hard presubmit error."""
391 fatal = True
392
393
394# Top level object so multiprocessing can pickle
395# Public access through OutputApi object.
396class _PresubmitPromptWarning(_PresubmitResult):
397 """An warning that prompts the user if they want to continue."""
398 should_prompt = True
399
400
401# Top level object so multiprocessing can pickle
402# Public access through OutputApi object.
403class _PresubmitNotifyResult(_PresubmitResult):
404 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000405
406
407# Top level object so multiprocessing can pickle
408# Public access through OutputApi object.
409class _MailTextResult(_PresubmitResult):
410 """A warning that should be included in the review request email."""
411 def __init__(self, *args, **kwargs):
412 super(_MailTextResult, self).__init__()
413 raise NotImplementedError()
414
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000415class GerritAccessor(object):
416 """Limited Gerrit functionality for canned presubmit checks to work.
417
418 To avoid excessive Gerrit calls, caches the results.
419 """
420
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000421 def __init__(self, url=None, project=None, branch=None):
422 self.host = urlparse.urlparse(url).netloc if url else None
423 self.project = project
424 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000425 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000426 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000427
428 def _FetchChangeDetail(self, issue):
429 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100430 try:
431 return gerrit_util.GetChangeDetail(
432 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700433 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100434 except gerrit_util.GerritError as e:
435 if e.http_status == 404:
436 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
437 'no credentials to fetch issue details' % issue)
438 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000439
440 def GetChangeInfo(self, issue):
441 """Returns labels and all revisions (patchsets) for this issue.
442
443 The result is a dictionary according to Gerrit REST Api.
444 https://gerrit-review.googlesource.com/Documentation/rest-api.html
445
446 However, API isn't very clear what's inside, so see tests for example.
447 """
448 assert issue
449 cache_key = int(issue)
450 if cache_key not in self.cache:
451 self.cache[cache_key] = self._FetchChangeDetail(issue)
452 return self.cache[cache_key]
453
454 def GetChangeDescription(self, issue, patchset=None):
455 """If patchset is none, fetches current patchset."""
456 info = self.GetChangeInfo(issue)
457 # info is a reference to cache. We'll modify it here adding description to
458 # it to the right patchset, if it is not yet there.
459
460 # Find revision info for the patchset we want.
461 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000462 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000463 if str(rev_info['_number']) == str(patchset):
464 break
465 else:
466 raise Exception('patchset %s doesn\'t exist in issue %s' % (
467 patchset, issue))
468 else:
469 rev = info['current_revision']
470 rev_info = info['revisions'][rev]
471
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100472 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000473
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800474 def GetDestRef(self, issue):
475 ref = self.GetChangeInfo(issue)['branch']
476 if not ref.startswith('refs/'):
477 # NOTE: it is possible to create 'refs/x' branch,
478 # aka 'refs/heads/refs/x'. However, this is ill-advised.
479 ref = 'refs/heads/%s' % ref
480 return ref
481
Edward Lesmes02d4b822020-11-11 00:37:35 +0000482 def _GetApproversForLabel(self, issue, label):
483 change_info = self.GetChangeInfo(issue)
484 label_info = change_info.get('labels', {}).get(label, {})
485 values = label_info.get('values', {}).keys()
486 if not values:
487 return []
488 max_value = max(int(v) for v in values)
489 return [v for v in label_info.get('all', [])
490 if v.get('value', 0) == max_value]
491
Edward Lesmesc4566172021-03-19 16:55:13 +0000492 def IsBotCommitApproved(self, issue):
493 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
494
Edward Lesmescf49cb82020-11-11 01:08:36 +0000495 def IsOwnersOverrideApproved(self, issue):
496 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
497
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000498 def GetChangeOwner(self, issue):
499 return self.GetChangeInfo(issue)['owner']['email']
500
501 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700502 changeinfo = self.GetChangeInfo(issue)
503 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000504 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700505 else:
506 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
507 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000508
Edward Lemure4d329c2020-02-03 20:41:18 +0000509 def UpdateDescription(self, description, issue):
510 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
511
Edward Lesmes8170c292021-03-19 20:04:43 +0000512 def IsCodeOwnersEnabledOnRepo(self):
513 if self.code_owners_enabled is None:
514 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000515 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000516 return self.code_owners_enabled
517
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000518
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000519class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000520 """An instance of OutputApi gets passed to presubmit scripts so that they
521 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000522 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000523 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000524 PresubmitError = _PresubmitError
525 PresubmitPromptWarning = _PresubmitPromptWarning
526 PresubmitNotifyResult = _PresubmitNotifyResult
527 MailTextResult = _MailTextResult
528
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000529 def __init__(self, is_committing):
530 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800531 self.more_cc = []
532
533 def AppendCC(self, cc):
534 """Appends a user to cc for this change."""
535 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000536
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000537 def PresubmitPromptOrNotify(self, *args, **kwargs):
538 """Warn the user when uploading, but only notify if committing."""
539 if self.is_committing:
540 return self.PresubmitNotifyResult(*args, **kwargs)
541 return self.PresubmitPromptWarning(*args, **kwargs)
542
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000543
544class InputApi(object):
545 """An instance of this object is passed to presubmit scripts so they can
546 know stuff about the change they're looking at.
547 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000548 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800549 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000550
maruel@chromium.org3410d912009-06-09 20:56:16 +0000551 # File extensions that are considered source files from a style guide
552 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000553 #
554 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000555 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000556 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
557 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000558 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000559 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
560 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000561 # Scripts
dpapad443d9132022-05-05 00:17:30 +0000562 r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$',
563 r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000564 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000565 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
566 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000567 )
568
569 # Path regexp that should be excluded from being considered containing source
570 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000571 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000572 r'testing_support[\\\/]google_appengine[\\\/].*',
573 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900574 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
575 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000576 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000577 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000578 r'.*\bDebug[\\\/].*',
579 r'.*\bRelease[\\\/].*',
580 r'.*\bxcodebuild[\\\/].*',
581 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000582 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000583 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000584 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000585 r'(|.*[\\\/])\.git[\\\/].*',
586 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000587 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000588 r'.+\.diff$',
589 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000590 )
591
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000592 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400593 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000594 """Builds an InputApi object.
595
596 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000597 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000598 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000599 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000600 gerrit_obj: provides basic Gerrit codereview functionality.
601 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400602 parallel: if true, all tests reported via input_api.RunTests for all
603 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000604 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000605 # Version number of the presubmit_support script.
606 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000607 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000608 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000609 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000610 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000611
Edward Lesmes8e282792018-04-03 18:50:29 -0400612 self.parallel = parallel
613 self.thread_pool = thread_pool or ThreadPool()
614
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000615 # We expose various modules and functions as attributes of the input_api
616 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900617 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000618 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000619 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700620 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000621 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000622 # TODO(yyanagisawa): stop exposing this when python3 become default.
623 # Since python3's tempfile has TemporaryDirectory, we do not need this.
624 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000625 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000626 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000627 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000628 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000629 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000630 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000631 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000632 self.re = re
633 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000634 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000635 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000636 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000637 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000638 if sys.version_info.major == 2:
639 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000640 self.urllib_request = urllib_request
641 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000642
Robert Iannucci50258932018-03-19 10:30:59 -0700643 self.is_windows = sys.platform == 'win32'
644
Edward Lemurb9646622019-10-25 20:57:35 +0000645 # Set python_executable to 'vpython' in order to allow scripts in other
646 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
647 # instead of inheriting the one in depot_tools.
648 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000649 # Offer a python 3 executable for use during the migration off of python 2.
650 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000651 self.environ = os.environ
652
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000653 # InputApi.platform is the platform you're currently running on.
654 self.platform = sys.platform
655
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000656 self.cpu_count = multiprocessing.cpu_count()
657
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000658 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000659 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000660
661 # We carry the canned checks so presubmit scripts can easily use them.
662 self.canned_checks = presubmit_canned_checks
663
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100664 # Temporary files we must manually remove at the end of a run.
665 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200666
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000667 self.owners_client = None
668 if self.gerrit:
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000669 try:
670 self.owners_client = owners_client.GetCodeOwnersClient(
671 root=change.RepositoryRoot(),
672 upstream=change.UpstreamBranch(),
673 host=self.gerrit.host,
674 project=self.gerrit.project,
675 branch=self.gerrit.branch)
676 except Exception as e:
677 print('Failed to set owners_client - %s' % str(e))
Edward Lesmes9ce03f82021-01-12 20:13:31 +0000678 self.owners_db = owners_db.Database(
679 change.RepositoryRoot(), fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200680 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000681 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000682 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000683
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000684 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000685 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000686 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800687 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000688 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000689 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000690 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
691 for (a, b, header) in cpplint._re_pattern_templates
692 ]
693
Edward Lemurecc27072020-01-06 16:42:34 +0000694 def SetTimeout(self, timeout):
695 self.thread_pool.timeout = timeout
696
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000697 def PresubmitLocalPath(self):
698 """Returns the local path of the presubmit script currently being run.
699
700 This is useful if you don't want to hard-code absolute paths in the
701 presubmit script. For example, It can be used to find another file
702 relative to the PRESUBMIT.py script, so the whole tree can be branched and
703 the presubmit script still works, without editing its content.
704 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000705 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000706
agable0b65e732016-11-22 09:25:46 -0800707 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000708 """Same as input_api.change.AffectedFiles() except only lists files
709 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000710 script, or subdirectories thereof. Note that files are listed using the OS
711 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000712 """
Edward Lemura5799e32020-01-17 19:26:51 +0000713 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000714 if len(dir_with_slash) == 1:
715 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000716
Edward Lemurb9830242019-10-30 22:19:20 +0000717 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000718 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000719 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000720
agable0b65e732016-11-22 09:25:46 -0800721 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000722 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800723 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000724 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000725 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000726
agable0b65e732016-11-22 09:25:46 -0800727 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000728 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800729 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000730
John Budorick16162372018-04-18 10:39:53 -0700731 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800732 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000733 in the same directory as the current presubmit script, or subdirectories
734 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000735 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000736 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000737 warn('AffectedTestableFiles(include_deletes=%s)'
738 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000739 category=DeprecationWarning,
740 stacklevel=2)
Josip Sokcevic4de5dea2022-03-23 21:15:14 +0000741 # pylint: disable=consider-using-generator
742 return [
743 x for x in self.AffectedFiles(include_deletes=False, **kwargs)
744 if x.IsTestableFile()
745 ]
agable0b65e732016-11-22 09:25:46 -0800746
747 def AffectedTextFiles(self, include_deletes=None):
748 """An alias to AffectedTestableFiles for backwards compatibility."""
749 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000750
Josip Sokcevic8c955952021-02-01 21:32:57 +0000751 def FilterSourceFile(self,
752 affected_file,
753 files_to_check=None,
754 files_to_skip=None,
755 allow_list=None,
756 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000757 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000758
local_bot64021412020-07-08 21:05:39 +0000759 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
760 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000761
762 The lists will be compiled as regular expression and
763 AffectedFile.LocalPath() needs to pass both list.
764
765 Note: Copy-paste this function to suit your needs or use a lambda function.
766 """
local_bot64021412020-07-08 21:05:39 +0000767 if files_to_check is None:
768 files_to_check = self.DEFAULT_FILES_TO_CHECK
769 if files_to_skip is None:
770 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000771
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000772 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000773 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000774 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000775 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000776 return True
Bruce Dawsona3a014e2022-04-27 23:28:17 +0000777 # Handle the cases where the files regex only handles /, but the local
778 # path uses \.
779 if self.is_windows and self.re.match(item, local_path.replace(
780 '\\', '/')):
781 return True
maruel@chromium.org3410d912009-06-09 20:56:16 +0000782 return False
local_bot64021412020-07-08 21:05:39 +0000783 return (Find(affected_file, files_to_check) and
784 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000785
786 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800787 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000788
789 If source_file is None, InputApi.FilterSourceFile() is used.
790 """
791 if not source_file:
792 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000793 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000794
795 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000796 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000797
798 Only lists lines from new or modified text files in the change that are
799 contained by the directory of the currently executing presubmit script.
800
801 This is useful for doing line-by-line regex checks, like checking for
802 trailing whitespace.
803
804 Yields:
805 a 3 tuple:
806 the AffectedFile instance of the current file;
807 integer line number (1-based); and
808 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000809
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000810 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000811 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000812 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000813 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000814
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000815 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000816 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000817
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000818 Deny reading anything outside the repository.
819 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000820 if isinstance(file_item, AffectedFile):
821 file_item = file_item.AbsoluteLocalPath()
822 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000823 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000824 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000825
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100826 def CreateTemporaryFile(self, **kwargs):
827 """Returns a named temporary file that must be removed with a call to
828 RemoveTemporaryFiles().
829
830 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
831 except for |delete|, which is always set to False.
832
833 Presubmit checks that need to create a temporary file and pass it for
834 reading should use this function instead of NamedTemporaryFile(), as
835 Windows fails to open a file that is already open for writing.
836
837 with input_api.CreateTemporaryFile() as f:
838 f.write('xyz')
839 f.close()
840 input_api.subprocess.check_output(['script-that', '--reads-from',
841 f.name])
842
843
844 Note that callers of CreateTemporaryFile() should not worry about removing
845 any temporary file; this is done transparently by the presubmit handling
846 code.
847 """
848 if 'delete' in kwargs:
849 # Prevent users from passing |delete|; we take care of file deletion
850 # ourselves and this prevents unintuitive error messages when we pass
851 # delete=False and 'delete' is also in kwargs.
852 raise TypeError('CreateTemporaryFile() does not take a "delete" '
853 'argument, file deletion is handled automatically by '
854 'the same presubmit_support code that creates InputApi '
855 'objects.')
856 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
857 self._named_temporary_files.append(temp_file.name)
858 return temp_file
859
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000860 @property
861 def tbr(self):
862 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400863 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000864
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000865 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000866 tests = []
867 msgs = []
868 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400869 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000870 msgs.append(t)
871 else:
872 assert issubclass(t.message, _PresubmitResult)
873 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000874 if self.verbose:
875 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400876 if not t.kwargs.get('cwd'):
877 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400878 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000879 # When self.parallel is True (i.e. --parallel is passed as an option)
880 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
881 # will run all tests once all PRESUBMIT files are processed.
882 # Otherwise, it will run them and return the results.
883 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400884 msgs.extend(self.thread_pool.RunAsync())
885 return msgs
scottmg86099d72016-09-01 09:16:51 -0700886
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000887
nick@chromium.orgff526192013-06-10 19:30:26 +0000888class _DiffCache(object):
889 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000890 def __init__(self, upstream=None):
891 """Stores the upstream revision against which all diffs will be computed."""
892 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000893
894 def GetDiff(self, path, local_root):
895 """Get the diff for a particular path."""
896 raise NotImplementedError()
897
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700898 def GetOldContents(self, path, local_root):
899 """Get the old version for a particular path."""
900 raise NotImplementedError()
901
nick@chromium.orgff526192013-06-10 19:30:26 +0000902
nick@chromium.orgff526192013-06-10 19:30:26 +0000903class _GitDiffCache(_DiffCache):
904 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000905 def __init__(self, upstream):
906 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000907 self._diffs_by_file = None
908
909 def GetDiff(self, path, local_root):
Bruce Dawson5f63d3c2022-04-19 17:02:36 +0000910 # Compare against None to distinguish between None and an initialized but
911 # empty dictionary.
912 if self._diffs_by_file == None:
nick@chromium.orgff526192013-06-10 19:30:26 +0000913 # Compute a single diff for all files and parse the output; should
914 # with git this is much faster than computing one diff for each file.
915 diffs = {}
916
917 # Don't specify any filenames below, because there are command line length
918 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000919 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
920 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000921
922 # This regex matches the path twice, separated by a space. Note that
923 # filename itself may contain spaces.
924 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
925 current_diff = []
926 keep_line_endings = True
927 for x in unified_diff.splitlines(keep_line_endings):
928 match = file_marker.match(x)
929 if match:
930 # Marks the start of a new per-file section.
931 diffs[match.group('filename')] = current_diff = [x]
932 elif x.startswith('diff --git'):
933 raise PresubmitFailure('Unexpected diff line: %s' % x)
934 else:
935 current_diff.append(x)
936
937 self._diffs_by_file = dict(
938 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
939
940 if path not in self._diffs_by_file:
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000941 # SCM didn't have any diff on this file. It could be that the file was not
942 # modified at all (e.g. user used --all flag in git cl presubmit).
943 # Intead of failing, return empty string.
944 # See: https://crbug.com/808346.
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000945 return ''
nick@chromium.orgff526192013-06-10 19:30:26 +0000946
947 return self._diffs_by_file[path]
948
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700949 def GetOldContents(self, path, local_root):
950 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
951
nick@chromium.orgff526192013-06-10 19:30:26 +0000952
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000953class AffectedFile(object):
954 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000955
956 DIFF_CACHE = _DiffCache
957
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000958 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800959 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000960 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000961 self._path = path
962 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000963 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000964 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000965 self._cached_changed_contents = None
966 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000967 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700968 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000969
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000970 def LocalPath(self):
971 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400972
973 This should be used for error messages but not for accessing files,
974 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
975 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000976 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000977 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000978
979 def AbsoluteLocalPath(self):
980 """Returns the absolute path of this file on the local disk.
981 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000982 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000983
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000984 def Action(self):
985 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000986 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000987
agable0b65e732016-11-22 09:25:46 -0800988 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000989 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000990
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000991 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000992 raise NotImplementedError() # Implement when needed
993
agable0b65e732016-11-22 09:25:46 -0800994 def IsTextFile(self):
995 """An alias to IsTestableFile for backwards compatibility."""
996 return self.IsTestableFile()
997
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700998 def OldContents(self):
999 """Returns an iterator over the lines in the old version of file.
1000
Daniel Cheng2da34fe2017-03-21 20:42:12 -07001001 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +00001002 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -07001003
1004 Contents will be empty if the file is a directory or does not exist.
1005 Note: The carriage returns (LF or CR) are stripped off.
1006 """
1007 return self._diff_cache.GetOldContents(self.LocalPath(),
1008 self._local_root).splitlines()
1009
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001010 def NewContents(self):
1011 """Returns an iterator over the lines in the new version of file.
1012
Edward Lemura5799e32020-01-17 19:26:51 +00001013 The new version is the file in the user's workspace, i.e. the 'right hand
1014 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001015
1016 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001017 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001018 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001019 if self._cached_new_contents is None:
1020 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -08001021 try:
1022 self._cached_new_contents = gclient_utils.FileRead(
1023 self.AbsoluteLocalPath(), 'rU').splitlines()
1024 except IOError:
1025 pass # File not found? That's fine; maybe it was deleted.
Greg Thompson30cde452021-06-01 16:38:47 +00001026 except UnicodeDecodeError as e:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001027 # log the filename since we're probably trying to read a binary
1028 # file, and shouldn't be.
1029 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1030 raise
1031
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001032 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001033
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001034 def ChangedContents(self, keeplinebreaks=False):
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001035 """Returns a list of tuples (line number, line text) of all new lines.
1036
1037 This relies on the scm diff output describing each changed code section
1038 with a line of the form
1039
1040 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1041 """
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001042 # Don't return cached results when line breaks are requested.
1043 if not keeplinebreaks and self._cached_changed_contents is not None:
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001044 return self._cached_changed_contents[:]
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001045 result = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001046 line_num = 0
1047
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001048 # The keeplinebreaks parameter to splitlines must be True or else the
1049 # CheckForWindowsLineEndings presubmit will be a NOP.
1050 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
Edward Lemurac5c55f2020-02-29 00:17:16 +00001051 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1052 if m:
1053 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001054 continue
1055 if line.startswith('+') and not line.startswith('++'):
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001056 result.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001057 if not line.startswith('-'):
1058 line_num += 1
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001059 # Don't cache results with line breaks.
1060 if keeplinebreaks:
1061 return result;
1062 self._cached_changed_contents = result
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001063 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001064
maruel@chromium.org5de13972009-06-10 18:16:06 +00001065 def __str__(self):
1066 return self.LocalPath()
1067
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001068 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001069 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001070
maruel@chromium.org58407af2011-04-12 23:15:57 +00001071
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001072class GitAffectedFile(AffectedFile):
1073 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001074 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001075 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001076
nick@chromium.orgff526192013-06-10 19:30:26 +00001077 DIFF_CACHE = _GitDiffCache
1078
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001079 def __init__(self, *args, **kwargs):
1080 AffectedFile.__init__(self, *args, **kwargs)
1081 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001082 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001083
agable0b65e732016-11-22 09:25:46 -08001084 def IsTestableFile(self):
1085 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001086 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001087 # A deleted file is not testable.
1088 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001089 else:
agable0b65e732016-11-22 09:25:46 -08001090 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1091 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001092
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001093
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001094class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001095 """Describe a change.
1096
1097 Used directly by the presubmit scripts to query the current change being
1098 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001099
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001100 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001101 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001102 self.KEY: equivalent to tags['KEY']
1103 """
1104
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001105 _AFFECTED_FILES = AffectedFile
1106
Edward Lemura5799e32020-01-17 19:26:51 +00001107 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001108 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001109 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001110 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001111
maruel@chromium.org58407af2011-04-12 23:15:57 +00001112 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001113 self, name, description, local_root, files, issue, patchset, author,
1114 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001115 if files is None:
1116 files = []
1117 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001118 # Convert root into an absolute path.
1119 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001120 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001121 self.issue = issue
1122 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001123 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001124
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001125 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001126 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001127 self._description_without_tags = ''
1128 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001129
maruel@chromium.orge085d812011-10-10 19:49:15 +00001130 assert all(
1131 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1132
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001133 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001134 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001135 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1136 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001137 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001138
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001139 def UpstreamBranch(self):
1140 """Returns the upstream branch for the change."""
1141 return self._upstream
1142
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001143 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001144 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001145 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001146
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001147 def DescriptionText(self):
1148 """Returns the user-entered changelist description, minus tags.
1149
Edward Lemura5799e32020-01-17 19:26:51 +00001150 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001151 (whitespace permitted before and around) is considered a tag line. Such
1152 lines are stripped out of the description this function returns.
1153 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001154 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001155
1156 def FullDescriptionText(self):
1157 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001158 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001159
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001160 def SetDescriptionText(self, description):
1161 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001162
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001163 Also updates the list of tags."""
1164 self._full_description = description
1165
1166 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001167 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001168 description_without_tags = []
1169 self.tags = {}
1170 for line in self._full_description.splitlines():
1171 m = self.TAG_LINE_RE.match(line)
1172 if m:
1173 self.tags[m.group('key')] = m.group('value')
1174 else:
1175 description_without_tags.append(line)
1176
1177 # Change back to text and remove whitespace at end.
1178 self._description_without_tags = (
1179 '\n'.join(description_without_tags).rstrip())
1180
Edward Lemur69bb8be2020-02-03 20:37:38 +00001181 def AddDescriptionFooter(self, key, value):
1182 """Adds the given footer to the change description.
1183
1184 Args:
1185 key: A string with the key for the git footer. It must conform to
1186 the git footers format (i.e. 'List-Of-Tokens') and will be case
1187 normalized so that each token is title-cased.
1188 value: A string with the value for the git footer.
1189 """
1190 description = git_footers.add_footer(
1191 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1192 self.SetDescriptionText(description)
1193
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001194 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001195 """Returns the repository (checkout) root directory for this change,
1196 as an absolute path.
1197 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001198 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001199
1200 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001201 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001202 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001203 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001204 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001205
Edward Lemur69bb8be2020-02-03 20:37:38 +00001206 def GitFootersFromDescription(self):
1207 """Return the git footers present in the description.
1208
1209 Returns:
1210 footers: A dict of {footer: [values]} containing a multimap of the footers
1211 in the change description.
1212 """
1213 return git_footers.parse_footers(self.FullDescriptionText())
1214
Aaron Gablefc03e672017-05-15 14:09:42 -07001215 def BugsFromDescription(self):
1216 """Returns all bugs referenced in the commit description."""
Sean McAllister1e509c52021-10-25 17:54:25 +00001217 bug_tags = ['BUG', 'FIXED']
1218
1219 tags = []
1220 for tag in bug_tags:
1221 values = self.tags.get(tag)
1222 if values:
1223 tags += [value.strip() for value in values.split(',')]
1224
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001225 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001226 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001227 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001228 for unsplit_footer in unsplit_footers:
1229 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001230 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001231
1232 def ReviewersFromDescription(self):
1233 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001234 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001235 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1236 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001237
1238 def TBRsFromDescription(self):
1239 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001240 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001241 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1242 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001243 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001244 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001245
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001246 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001247 @property
1248 def BUG(self):
1249 return ','.join(self.BugsFromDescription())
1250 @property
1251 def R(self):
1252 return ','.join(self.ReviewersFromDescription())
1253 @property
1254 def TBR(self):
1255 return ','.join(self.TBRsFromDescription())
1256
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001257 def AllFiles(self, root=None):
1258 """List all files under source control in the repo."""
1259 raise NotImplementedError()
1260
agable0b65e732016-11-22 09:25:46 -08001261 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001262 """Returns a list of AffectedFile instances for all files in the change.
1263
1264 Args:
1265 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001266 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001267
1268 Returns:
1269 [AffectedFile(path, action), AffectedFile(path, action)]
1270 """
Edward Lemurb9830242019-10-30 22:19:20 +00001271 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001272
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001273 if include_deletes:
1274 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001275 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001276
John Budorick16162372018-04-18 10:39:53 -07001277 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001278 """Return a list of the existing text files in a change."""
1279 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001280 warn('AffectedTeestableFiles(include_deletes=%s)'
1281 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001282 category=DeprecationWarning,
1283 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001284 return list(filter(
1285 lambda x: x.IsTestableFile(),
1286 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001287
agable0b65e732016-11-22 09:25:46 -08001288 def AffectedTextFiles(self, include_deletes=None):
1289 """An alias to AffectedTestableFiles for backwards compatibility."""
1290 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001291
agable0b65e732016-11-22 09:25:46 -08001292 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001293 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001294 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001295
agable0b65e732016-11-22 09:25:46 -08001296 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001297 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001298 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001299
1300 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001301 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001302
1303 Lists lines from new or modified text files in the change.
1304
1305 This is useful for doing line-by-line regex checks, like checking for
1306 trailing whitespace.
1307
1308 Yields:
1309 a 3 tuple:
1310 the AffectedFile instance of the current file;
1311 integer line number (1-based); and
1312 the contents of the line as a string.
1313 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001314 return _RightHandSideLinesImpl(
1315 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001316 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001317
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001318 def OriginalOwnersFiles(self):
1319 """A map from path names of affected OWNERS files to their old content."""
1320 def owners_file_filter(f):
1321 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1322 files = self.AffectedFiles(file_filter=owners_file_filter)
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001323 return {f.LocalPath(): f.OldContents() for f in files}
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001324
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001325
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001326class GitChange(Change):
1327 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001328 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001329
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001330 def AllFiles(self, root=None):
1331 """List all files under source control in the repo."""
1332 root = root or self.RepositoryRoot()
1333 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001334 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
Josip Sokcevic0b123462021-06-08 20:41:32 +00001335 cwd=root).decode('utf-8', 'ignore').splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001336
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001337
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001338def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001339 """Finds all presubmit files that apply to a given set of source files.
1340
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001341 If inherit-review-settings-ok is present right under root, looks for
1342 PRESUBMIT.py in directories enclosing root.
1343
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001344 Args:
1345 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001346 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001347
1348 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001349 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001350 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001351 files = [normpath(os.path.join(root, f)) for f in files]
1352
1353 # List all the individual directories containing files.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001354 directories = {os.path.dirname(f) for f in files}
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001355
1356 # Ignore root if inherit-review-settings-ok is present.
1357 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1358 root = None
1359
1360 # Collect all unique directories that may contain PRESUBMIT.py.
1361 candidates = set()
1362 for directory in directories:
1363 while True:
1364 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001365 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001366 candidates.add(directory)
1367 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001368 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001369 parent_dir = os.path.dirname(directory)
1370 if parent_dir == directory:
1371 # We hit the system root directory.
1372 break
1373 directory = parent_dir
1374
1375 # Look for PRESUBMIT.py in all candidate directories.
1376 results = []
1377 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001378 try:
1379 for f in os.listdir(directory):
1380 p = os.path.join(directory, f)
1381 if os.path.isfile(p) and re.match(
1382 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1383 results.append(p)
1384 except OSError:
1385 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001386
tobiasjs2836bcf2016-08-16 04:08:16 -07001387 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001388 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001389
1390
rmistry@google.com5626a922015-02-26 14:03:30 +00001391class GetPostUploadExecuter(object):
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001392 def __init__(self, use_python3):
1393 """
1394 Args:
1395 use_python3: if true, will use python3 instead of python2 by default
1396 if USE_PYTHON3 is not specified.
1397 """
1398 self.use_python3 = use_python3
1399
1400 def ExecPresubmitScript(self, script_text, presubmit_path, gerrit_obj,
1401 change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001402 """Executes PostUploadHook() from a single presubmit script.
1403
1404 Args:
1405 script_text: The text of the presubmit script.
1406 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001407 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001408 change: The Change object.
1409
1410 Return:
1411 A list of results objects.
1412 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001413 if not _ShouldRunPresubmit(script_text, self.use_python3):
1414 return {}
1415
rmistry@google.com5626a922015-02-26 14:03:30 +00001416 context = {}
1417 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001418 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1419 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001420 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001421 raise PresubmitFailure('"%s" had an exception.\n%s'
1422 % (presubmit_path, e))
1423
1424 function_name = 'PostUploadHook'
1425 if function_name not in context:
1426 return {}
1427 post_upload_hook = context[function_name]
1428 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1429 raise PresubmitFailure(
1430 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001431 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001432
1433
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001434def _MergeMasters(masters1, masters2):
1435 """Merges two master maps. Merges also the tests of each builder."""
1436 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001437 for (master, builders) in itertools.chain(masters1.items(),
1438 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001439 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001440 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001441 new_builders.setdefault(builder, set([])).update(tests)
1442 return result
1443
1444
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001445def DoPostUploadExecuter(change, gerrit_obj, verbose, use_python3=False):
rmistry@google.com5626a922015-02-26 14:03:30 +00001446 """Execute the post upload hook.
1447
1448 Args:
1449 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001450 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001451 verbose: Prints debug info.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001452 use_python3: if true, default to using Python3 for presubmit checks
1453 rather than Python2.
rmistry@google.com5626a922015-02-26 14:03:30 +00001454 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001455 python_version = 'Python %s' % sys.version_info.major
1456 sys.stdout.write('Running %s post upload checks ...\n' % python_version)
rmistry@google.com5626a922015-02-26 14:03:30 +00001457 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001458 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001459 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001460 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001461 results = []
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001462 executer = GetPostUploadExecuter(use_python3)
rmistry@google.com5626a922015-02-26 14:03:30 +00001463 # The root presubmit file should be executed after the ones in subdirectories.
1464 # i.e. the specific post upload hooks should run before the general ones.
1465 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1466 presubmit_files.reverse()
1467
1468 for filename in presubmit_files:
1469 filename = os.path.abspath(filename)
1470 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001471 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001472 # Accept CRLF presubmit script.
1473 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1474 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001475 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001476
Edward Lemur6eb1d322020-02-27 22:20:15 +00001477 if not results:
1478 return 0
1479
1480 sys.stdout.write('\n')
1481 sys.stdout.write('** Post Upload Hook Messages **\n')
1482
1483 exit_code = 0
1484 for result in results:
1485 if result.fatal:
1486 exit_code = 1
1487 result.handle()
1488 sys.stdout.write('\n')
1489
1490 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001491
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001492class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001493 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001494 thread_pool=None, parallel=False, use_python3=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001495 """
1496 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001497 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001498 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001499 gerrit_obj: provides basic Gerrit codereview functionality.
1500 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001501 parallel: if true, all tests reported via input_api.RunTests for all
1502 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001503 use_python3: if true, will use python3 instead of python2 by default
1504 if USE_PYTHON3 is not specified.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001505 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001506 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001507 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001508 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001509 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001510 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001511 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001512 self.thread_pool = thread_pool
1513 self.parallel = parallel
Dirk Pranke6f0df682021-06-25 00:42:33 +00001514 self.use_python3 = use_python3
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001515
1516 def ExecPresubmitScript(self, script_text, presubmit_path):
1517 """Executes a single presubmit script.
1518
1519 Args:
1520 script_text: The text of the presubmit script.
1521 presubmit_path: The path to the presubmit file (this will be reported via
1522 input_api.PresubmitLocalPath()).
1523
1524 Return:
1525 A list of result objects, empty if no problems.
1526 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001527 if not _ShouldRunPresubmit(script_text, self.use_python3):
1528 return []
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001529
chase@chromium.org8e416c82009-10-06 04:30:44 +00001530 # Change to the presubmit file's directory to support local imports.
1531 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001532 presubmit_dir = os.path.dirname(presubmit_path)
1533 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001534
1535 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001536 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001537 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001538 dry_run=self.dry_run, thread_pool=self.thread_pool,
1539 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001540 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001541 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001542
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001543 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001544 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1545 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001546 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001547 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001548
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001549 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001550
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001551 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001552 # Always use forward slashes, so that path is same in *nix and Windows
1553 root = input_api.change.RepositoryRoot()
1554 rel_path = os.path.relpath(presubmit_dir, root)
1555 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001556
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001557 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001558 host = project = ''
1559 if self.gerrit:
1560 host = self.gerrit.host or ''
1561 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001562
1563 # Prefix for test names
1564 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1565
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001566 # Perform all the desired presubmit checks.
1567 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001568
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001569 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001570 version = [
1571 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1572 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001573
Scott Leecc2fe9b2020-11-19 19:38:06 +00001574 with rdb_wrapper.client(prefix) as sink:
1575 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001576 # Copy the keys to prevent "dictionary changed size during iteration"
1577 # exception if checks add globals to context. E.g. sometimes the
1578 # Python runtime will add __warningregistry__.
1579 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001580 if not function_name.startswith('Check'):
1581 continue
1582 if function_name.endswith('Commit') and not self.committing:
1583 continue
1584 if function_name.endswith('Upload') and self.committing:
1585 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001586 logging.debug('Running %s in %s', function_name, presubmit_path)
1587 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001588 self._run_check_function(function_name, context, sink,
1589 presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001590 logging.debug('Running %s done.', function_name)
1591 self.more_cc.extend(output_api.more_cc)
1592
1593 else: # Old format
1594 if self.committing:
1595 function_name = 'CheckChangeOnCommit'
1596 else:
1597 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001598 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001599 logging.debug('Running %s in %s', function_name, presubmit_path)
1600 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001601 self._run_check_function(function_name, context, sink,
1602 presubmit_path))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001603 logging.debug('Running %s done.', function_name)
1604 self.more_cc.extend(output_api.more_cc)
1605
1606 finally:
1607 for f in input_api._named_temporary_files:
1608 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001609
chase@chromium.org8e416c82009-10-06 04:30:44 +00001610 # Return the process to the original working directory.
1611 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001612 return results
1613
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001614 def _run_check_function(self, function_name, context, sink, presubmit_path):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001615 """Evaluates and returns the result of a given presubmit function.
1616
1617 If sink is given, the result of the presubmit function will be reported
1618 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001619
1620 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001621 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001622 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001623 sink: an instance of ResultSink. None, by default.
1624 Returns:
1625 the result of the presubmit function call.
1626 """
1627 start_time = time_time()
1628 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001629 result = eval(function_name + '(*__args)', context)
1630 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001631 except Exception:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001632 if sink:
1633 elapsed_time = time_time() - start_time
1634 sink.report(function_name, rdb_wrapper.STATUS_FAIL, elapsed_time)
Allen Webbfe7d7092021-05-18 02:05:49 +00001635 # TODO(crbug.com/953884): replace reraise with native py3:
Allen Webbb65bbfe2021-05-11 21:22:01 +00001636 # raise .. from e
Allen Webbfe7d7092021-05-18 02:05:49 +00001637 e_type, e_value, e_tb = sys.exc_info()
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001638 print('Evaluation of %s failed: %s' % (function_name, e_value))
1639 six.reraise(e_type, e_value, e_tb)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001640
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001641 elapsed_time = time_time() - start_time
1642 if elapsed_time > 10.0:
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001643 sys.stdout.write('%s from %s took %.1fs to run.\n' %
1644 (function_name, presubmit_path, elapsed_time))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001645 if sink:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001646 status = rdb_wrapper.STATUS_PASS
1647 if any(r.fatal for r in result):
1648 status = rdb_wrapper.STATUS_FAIL
1649 sink.report(function_name, status, elapsed_time)
1650
1651 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001652
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001653 def _check_result_type(self, result):
1654 """Helper function which ensures result is a list, and all elements are
1655 instances of OutputApi.PresubmitResult"""
1656 if not isinstance(result, (tuple, list)):
1657 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1658 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1659 raise PresubmitFailure(
1660 'All presubmit results must be of types derived from '
1661 'output_api.PresubmitResult')
1662
1663
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001664def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001665 committing,
1666 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001667 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001668 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001669 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001670 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001671 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001672 json_output=None,
1673 use_python3=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001674 """Runs all presubmit checks that apply to the files in the change.
1675
1676 This finds all PRESUBMIT.py files in directories enclosing the files in the
1677 change (up to the repository root) and calls the relevant entrypoint function
1678 depending on whether the change is being committed or uploaded.
1679
1680 Prints errors, warnings and notifications. Prompts the user for warnings
1681 when needed.
1682
1683 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001684 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001685 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001686 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001687 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001688 may_prompt: Enable (y/n) questions on warning or error. If False,
1689 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001690 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001691 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001692 parallel: if true, all tests specified by input_api.RunTests in all
1693 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001694 use_python3: if true, default to using Python3 for presubmit checks
1695 rather than Python2.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001696 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001697 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001698 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001699 old_environ = os.environ
1700 try:
1701 # Make sure python subprocesses won't generate .pyc files.
1702 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001703 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001704
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001705 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001706 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001707 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001708 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001709 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001710 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1711 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001712 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001713 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001714 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001715 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001716 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001717 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001718 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001719 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001720 dry_run, thread_pool, parallel, use_python3)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001721 if default_presubmit:
1722 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001723 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001724 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1725 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1726 for filename in presubmit_files:
1727 filename = os.path.abspath(filename)
1728 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001729 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001730 # Accept CRLF presubmit script.
1731 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1732 results += executer.ExecPresubmitScript(presubmit_script, filename)
Edward Lesmes8e282792018-04-03 18:50:29 -04001733 results += thread_pool.RunAsync()
1734
Edward Lemur6eb1d322020-02-27 22:20:15 +00001735 messages = {}
1736 should_prompt = False
1737 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001738 for result in results:
1739 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001740 presubmits_failed = True
1741 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001742 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001743 should_prompt = True
1744 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001745 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001746 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001747
Edward Lemur6eb1d322020-02-27 22:20:15 +00001748 for name, items in messages.items():
1749 sys.stdout.write('** Presubmit %s **\n' % name)
1750 for item in items:
1751 item.handle()
1752 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001753
Edward Lemurecc27072020-01-06 16:42:34 +00001754 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001755 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001756 sys.stdout.write(
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001757 'Presubmit checks took %.1fs to calculate.\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001758
Edward Lemur6eb1d322020-02-27 22:20:15 +00001759 if not should_prompt and not presubmits_failed:
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001760 sys.stdout.write('%s presubmit checks passed.\n\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001761 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001762 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001763 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001764 presubmits_failed = not prompt_should_continue(
1765 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001766 else:
1767 sys.stdout.write('\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001768
Edward Lemur1dc66e12020-02-21 21:36:34 +00001769 if json_output:
1770 # Write the presubmit results to json output
1771 presubmit_results = {
1772 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001773 error.json_format()
1774 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001775 ],
1776 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001777 notification.json_format()
1778 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001779 ],
1780 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001781 warning.json_format()
1782 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001783 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001784 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001785 }
1786
1787 gclient_utils.FileWrite(
1788 json_output, json.dumps(presubmit_results, sort_keys=True))
1789
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001790 global _ASKED_FOR_FEEDBACK
1791 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001792 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001793 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001794 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1795 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1796 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001797 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001798
1799 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001800 finally:
1801 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001802
1803
Edward Lemur50984a62020-02-06 18:10:18 +00001804def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001805 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001806 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001807
1808 results = []
1809 for root, dirs, files in os.walk('.'):
1810 if '.svn' in dirs:
1811 dirs.remove('.svn')
1812 if '.git' in dirs:
1813 dirs.remove('.git')
1814 for name in files:
1815 if fnmatch.fnmatch(name, mask):
1816 results.append(os.path.join(root, name))
1817 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001818
1819
Edward Lemur50984a62020-02-06 18:10:18 +00001820def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001821 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001822 files = []
1823 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001824 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001825 return files
1826
1827
Edward Lemur50984a62020-02-06 18:10:18 +00001828def _parse_change(parser, options):
1829 """Process change options.
1830
1831 Args:
1832 parser: The parser used to parse the arguments from command line.
1833 options: The arguments parsed from command line.
1834 Returns:
1835 A GitChange if the change root is a git repository, or a Change otherwise.
1836 """
1837 if options.files and options.all_files:
1838 parser.error('<files> cannot be specified when --all-files is set.')
1839
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001840 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001841 if change_scm != 'git' and not options.files:
1842 parser.error('<files> is not optional for unversioned directories.')
1843
1844 if options.files:
Josip Sokcevic017544d2022-03-31 23:47:53 +00001845 if options.source_controlled_only:
1846 # Get the filtered set of files from SCM.
1847 change_files = []
1848 for name in scm.GIT.GetAllFiles(options.root):
1849 for mask in options.files:
1850 if fnmatch.fnmatch(name, mask):
1851 change_files.append(('M', name))
1852 break
1853 else:
1854 # Get the filtered set of files from a directory scan.
1855 change_files = _parse_files(options.files, options.recursive)
Edward Lemur50984a62020-02-06 18:10:18 +00001856 elif options.all_files:
1857 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001858 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001859 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001860 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001861
1862 logging.info('Found %d file(s).', len(change_files))
1863
1864 change_class = GitChange if change_scm == 'git' else Change
1865 return change_class(
1866 options.name,
1867 options.description,
1868 options.root,
1869 change_files,
1870 options.issue,
1871 options.patchset,
1872 options.author,
1873 upstream=options.upstream)
1874
1875
1876def _parse_gerrit_options(parser, options):
1877 """Process gerrit options.
1878
1879 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1880 options.gerrit_fetch is set.
1881
1882 Args:
1883 parser: The parser used to parse the arguments from command line.
1884 options: The arguments parsed from command line.
1885 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001886 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001887 """
1888 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001889 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001890 gerrit_obj = GerritAccessor(
1891 url=options.gerrit_url,
1892 project=options.gerrit_project,
1893 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001894
1895 if not options.gerrit_fetch:
1896 return gerrit_obj
1897
1898 if not options.gerrit_url or not options.issue or not options.patchset:
1899 parser.error(
1900 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1901
1902 options.author = gerrit_obj.GetChangeOwner(options.issue)
1903 options.description = gerrit_obj.GetChangeDescription(
1904 options.issue, options.patchset)
1905
1906 logging.info('Got author: "%s"', options.author)
1907 logging.info('Got description: """\n%s\n"""', options.description)
1908
1909 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001910
1911
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001912@contextlib.contextmanager
1913def canned_check_filter(method_names):
1914 filtered = {}
1915 try:
1916 for method_name in method_names:
1917 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001918 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001919 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001920 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1921 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1922 yield
1923 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001924 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001925 setattr(presubmit_canned_checks, name, method)
1926
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001927
sbc@chromium.org013731e2015-02-26 18:28:43 +00001928def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001929 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1930 hooks = parser.add_mutually_exclusive_group()
1931 hooks.add_argument('-c', '--commit', action='store_true',
1932 help='Use commit instead of upload checks.')
1933 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1934 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001935 hooks.add_argument('--post_upload', action='store_true',
1936 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001937 parser.add_argument('-r', '--recursive', action='store_true',
1938 help='Act recursively.')
1939 parser.add_argument('-v', '--verbose', action='count', default=0,
1940 help='Use 2 times for more debug info.')
1941 parser.add_argument('--name', default='no name')
1942 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001943 desc = parser.add_mutually_exclusive_group()
1944 desc.add_argument('--description', default='', help='The change description.')
1945 desc.add_argument('--description_file',
1946 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001947 parser.add_argument('--issue', type=int, default=0)
1948 parser.add_argument('--patchset', type=int, default=0)
1949 parser.add_argument('--root', default=os.getcwd(),
1950 help='Search for PRESUBMIT.py up to this directory. '
1951 'If inherit-review-settings-ok is present in this '
1952 'directory, parent directories up to the root file '
1953 'system directories will also be searched.')
1954 parser.add_argument('--upstream',
1955 help='Git only: the base ref or upstream branch against '
1956 'which the diff should be computed.')
1957 parser.add_argument('--default_presubmit')
1958 parser.add_argument('--may_prompt', action='store_true', default=False)
1959 parser.add_argument('--skip_canned', action='append', default=[],
1960 help='A list of checks to skip which appear in '
1961 'presubmit_canned_checks. Can be provided multiple times '
1962 'to skip multiple canned checks.')
1963 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1964 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001965 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
1966 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001967 parser.add_argument('--gerrit_fetch', action='store_true',
1968 help=argparse.SUPPRESS)
1969 parser.add_argument('--parallel', action='store_true',
1970 help='Run all tests specified by input_api.RunTests in '
1971 'all PRESUBMIT files in parallel.')
1972 parser.add_argument('--json_output',
1973 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001974 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001975 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001976 parser.add_argument('files', nargs='*',
1977 help='List of files to be marked as modified when '
1978 'executing presubmit or post-upload hooks. fnmatch '
1979 'wildcards can also be used.')
Josip Sokcevic017544d2022-03-31 23:47:53 +00001980 parser.add_argument('--source_controlled_only', action='store_true',
1981 help='Constrain \'files\' to those in source control.')
Dirk Pranke6f0df682021-06-25 00:42:33 +00001982 parser.add_argument('--use-python3', action='store_true',
1983 help='Use python3 for presubmit checks by default')
Edward Lemura5799e32020-01-17 19:26:51 +00001984 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001985
Erik Staabcca5c492020-04-16 17:40:07 +00001986 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001987 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001988 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001989 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001990 log_level = logging.INFO
1991 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1992 '%(filename)s] %(message)s')
1993 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001994
Edward Lemur227d5102020-02-25 23:45:35 +00001995 if options.description_file:
1996 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001997 gerrit_obj = _parse_gerrit_options(parser, options)
1998 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001999
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002000 try:
Edward Lemur75526302020-02-27 22:31:05 +00002001 if options.post_upload:
Josip Sokcevice293d3d2022-02-16 22:52:15 +00002002 return DoPostUploadExecuter(change, gerrit_obj, options.verbose,
2003 options.use_python3)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002004 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002005 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002006 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002007 options.commit,
2008 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002009 options.default_presubmit,
2010 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002011 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002012 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002013 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00002014 options.json_output,
2015 options.use_python3)
Raul Tambre7c938462019-05-24 16:35:35 +00002016 except PresubmitFailure as e:
Josip Sokcevic0399e172022-03-21 23:11:51 +00002017 import utils
Raul Tambre80ee78e2019-05-06 22:41:05 +00002018 print(e, file=sys.stderr)
2019 print('Maybe your depot_tools is out of date?', file=sys.stderr)
Josip Sokcevic0399e172022-03-21 23:11:51 +00002020 print('depot_tools version: %s' % utils.depot_tools_version(),
2021 file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002022 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002023
2024
2025if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002026 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002027 try:
2028 sys.exit(main())
2029 except KeyboardInterrupt:
2030 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002031 sys.exit(2)